1 // Copyright 2015 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 use self::ImportDirectiveSubclass::*;
13 use {AmbiguityError, CrateLint, Module, PerNS};
14 use Namespace::{self, TypeNS, MacroNS};
15 use {NameBinding, NameBindingKind, ToNameBinding, PathResult, PrivacyError};
17 use {names_to_string, module_to_string};
18 use {resolve_error, ResolutionError};
20 use rustc_data_structures::ptr_key::PtrKey;
22 use rustc::lint::builtin::BuiltinLintDiagnostics;
23 use rustc::lint::builtin::{DUPLICATE_MACRO_EXPORTS, PUB_USE_OF_PRIVATE_EXTERN_CRATE};
24 use rustc::hir::def_id::{CRATE_DEF_INDEX, DefId};
25 use rustc::hir::def::*;
26 use rustc::session::DiagnosticMessageId;
27 use rustc::util::nodemap::{FxHashMap, FxHashSet};
29 use syntax::ast::{Ident, Name, NodeId, CRATE_NODE_ID};
30 use syntax::ext::base::Determinacy::{self, Determined, Undetermined};
31 use syntax::ext::hygiene::Mark;
32 use syntax::symbol::keywords;
33 use syntax::util::lev_distance::find_best_match_for_name;
36 use std::cell::{Cell, RefCell};
39 /// Contains data for specific types of import directives.
40 #[derive(Clone, Debug)]
41 pub enum ImportDirectiveSubclass<'a> {
45 result: PerNS<Cell<Result<&'a NameBinding<'a>, Determinacy>>>,
50 max_vis: Cell<ty::Visibility>, // The visibility of the greatest re-export.
51 // n.b. `max_vis` is only used in `finalize_import` to check for re-export errors.
53 ExternCrate(Option<Name>),
57 /// One import directive.
58 #[derive(Debug,Clone)]
59 pub struct ImportDirective<'a> {
60 /// The id of the `extern crate`, `UseTree` etc that imported this `ImportDirective`.
62 /// In the case where the `ImportDirective` was expanded from a "nested" use tree,
63 /// this id is the id of the leaf tree. For example:
65 /// ```ignore (pacify the mercilous tidy)
66 /// use foo::bar::{a, b}
69 /// If this is the import directive for `foo::bar::a`, we would have the id of the `UseTree`
70 /// for `a` in this field.
73 /// The `id` of the "root" use-kind -- this is always the same as
74 /// `id` except in the case of "nested" use trees, in which case
75 /// it will be the `id` of the root use tree. e.g., in the example
76 /// from `id`, this would be the id of the `use foo::bar`
80 /// Span of this use tree.
83 /// Span of the *root* use tree (see `root_id`).
86 pub parent: Module<'a>,
87 pub module_path: Vec<Ident>,
88 pub imported_module: Cell<Option<Module<'a>>>, // the resolution of `module_path`
89 pub subclass: ImportDirectiveSubclass<'a>,
90 pub vis: Cell<ty::Visibility>,
95 impl<'a> ImportDirective<'a> {
96 pub fn is_glob(&self) -> bool {
97 match self.subclass { ImportDirectiveSubclass::GlobImport { .. } => true, _ => false }
100 crate fn crate_lint(&self) -> CrateLint {
101 CrateLint::UsePath { root_id: self.root_id, root_span: self.root_span }
105 #[derive(Clone, Default, Debug)]
106 /// Records information about the resolution of a name in a namespace of a module.
107 pub struct NameResolution<'a> {
108 /// Single imports that may define the name in the namespace.
109 /// Import directives are arena-allocated, so it's ok to use pointers as keys.
110 single_imports: FxHashSet<PtrKey<'a, ImportDirective<'a>>>,
111 /// The least shadowable known binding for this name, or None if there are no known bindings.
112 pub binding: Option<&'a NameBinding<'a>>,
113 shadowed_glob: Option<&'a NameBinding<'a>>,
116 impl<'a> NameResolution<'a> {
117 // Returns the binding for the name if it is known or None if it not known.
118 fn binding(&self) -> Option<&'a NameBinding<'a>> {
119 self.binding.and_then(|binding| {
120 if !binding.is_glob_import() ||
121 self.single_imports.is_empty() { Some(binding) } else { None }
126 impl<'a, 'crateloader> Resolver<'a, 'crateloader> {
127 fn resolution(&self, module: Module<'a>, ident: Ident, ns: Namespace)
128 -> &'a RefCell<NameResolution<'a>> {
129 *module.resolutions.borrow_mut().entry((ident.modern(), ns))
130 .or_insert_with(|| self.arenas.alloc_name_resolution())
133 /// Attempts to resolve `ident` in namespaces `ns` of `module`.
134 /// Invariant: if `record_used` is `Some`, expansion and import resolution must be complete.
135 pub fn resolve_ident_in_module_unadjusted(&mut self,
139 restricted_shadowing: bool,
142 -> Result<&'a NameBinding<'a>, Determinacy> {
143 self.populate_module_if_necessary(module);
145 let resolution = self.resolution(module, ident, ns)
147 .map_err(|_| Determined)?; // This happens when there is a cycle of imports
150 if let Some(binding) = resolution.binding {
151 if let Some(shadowed_glob) = resolution.shadowed_glob {
152 let name = ident.name;
153 // Forbid expanded shadowing to avoid time travel.
154 if restricted_shadowing &&
155 binding.expansion != Mark::root() &&
156 ns != MacroNS && // In MacroNS, `try_define` always forbids this shadowing
157 binding.def() != shadowed_glob.def() {
158 self.ambiguity_errors.push(AmbiguityError {
167 if self.record_use(ident, ns, binding, path_span) {
168 return Ok(self.dummy_binding);
170 if !self.is_accessible(binding.vis) {
171 self.privacy_errors.push(PrivacyError(path_span, ident.name, binding));
175 return resolution.binding.ok_or(Determined);
178 let check_usable = |this: &mut Self, binding: &'a NameBinding<'a>| {
179 // `extern crate` are always usable for backwards compatibility, see issue #37020.
180 let usable = this.is_accessible(binding.vis) || binding.is_extern_crate();
181 if usable { Ok(binding) } else { Err(Determined) }
184 // Items and single imports are not shadowable, if we have one, then it's determined.
185 if let Some(binding) = resolution.binding {
186 if !binding.is_glob_import() {
187 return check_usable(self, binding);
191 // --- From now on we either have a glob resolution or no resolution. ---
193 // Check if one of single imports can still define the name,
194 // if it can then our result is not determined and can be invalidated.
195 for single_import in &resolution.single_imports {
196 if !self.is_accessible(single_import.vis.get()) {
199 let module = unwrap_or!(single_import.imported_module.get(), return Err(Undetermined));
200 let ident = match single_import.subclass {
201 SingleImport { source, .. } => source,
204 match self.resolve_ident_in_module(module, ident, ns, false, path_span) {
205 Err(Determined) => continue,
206 Ok(_) | Err(Undetermined) => return Err(Undetermined),
210 // So we have a resolution that's from a glob import. This resolution is determined
211 // if it cannot be shadowed by some new item/import expanded from a macro.
212 // This happens either if there are no unexpanded macros, or expanded names cannot
213 // shadow globs (that happens in macro namespace or with restricted shadowing).
214 let unexpanded_macros = !module.unresolved_invocations.borrow().is_empty() ||
215 (ns == MacroNS && ptr::eq(module, self.graph_root) &&
216 !self.unresolved_invocations_macro_export.is_empty());
217 if let Some(binding) = resolution.binding {
218 if !unexpanded_macros || ns == MacroNS || restricted_shadowing {
219 return check_usable(self, binding);
221 return Err(Undetermined);
225 // --- From now on we have no resolution. ---
227 // Now we are in situation when new item/import can appear only from a glob or a macro
228 // expansion. With restricted shadowing names from globs and macro expansions cannot
229 // shadow names from outer scopes, so we can freely fallback from module search to search
230 // in outer scopes. To continue search in outer scopes we have to lie a bit and return
231 // `Determined` to `resolve_lexical_macro_path_segment` even if the correct answer
232 // for in-module resolution could be `Undetermined`.
233 if restricted_shadowing {
234 return Err(Determined);
237 // Check if one of unexpanded macros can still define the name,
238 // if it can then our "no resolution" result is not determined and can be invalidated.
239 if unexpanded_macros {
240 return Err(Undetermined);
243 // Check if one of glob imports can still define the name,
244 // if it can then our "no resolution" result is not determined and can be invalidated.
245 for glob_import in module.globs.borrow().iter() {
246 if !self.is_accessible(glob_import.vis.get()) {
249 let module = unwrap_or!(glob_import.imported_module.get(), return Err(Undetermined));
250 let (orig_current_module, mut ident) = (self.current_module, ident.modern());
251 match ident.span.glob_adjust(module.expansion, glob_import.span.ctxt().modern()) {
252 Some(Some(def)) => self.current_module = self.macro_def_scope(def),
256 let result = self.resolve_ident_in_module_unadjusted(
257 module, ident, ns, false, false, path_span,
259 self.current_module = orig_current_module;
261 Err(Determined) => continue,
262 Ok(_) | Err(Undetermined) => return Err(Undetermined),
266 // No resolution and no one else can define the name - determinate error.
270 // Add an import directive to the current module.
271 pub fn add_import_directive(&mut self,
272 module_path: Vec<Ident>,
273 subclass: ImportDirectiveSubclass<'a>,
280 let current_module = self.current_module;
281 let directive = self.arenas.alloc_import_directive(ImportDirective {
282 parent: current_module,
284 imported_module: Cell::new(None),
292 used: Cell::new(false),
295 self.indeterminate_imports.push(directive);
296 match directive.subclass {
297 SingleImport { target, type_ns_only, .. } => {
298 self.per_ns(|this, ns| if !type_ns_only || ns == TypeNS {
299 let mut resolution = this.resolution(current_module, target, ns).borrow_mut();
300 resolution.single_imports.insert(PtrKey(directive));
303 // We don't add prelude imports to the globs since they only affect lexical scopes,
304 // which are not relevant to import resolution.
305 GlobImport { is_prelude: true, .. } => {}
306 GlobImport { .. } => self.current_module.globs.borrow_mut().push(directive),
311 // Given a binding and an import directive that resolves to it,
312 // return the corresponding binding defined by the import directive.
313 pub fn import(&self, binding: &'a NameBinding<'a>, directive: &'a ImportDirective<'a>)
314 -> &'a NameBinding<'a> {
315 let vis = if binding.pseudo_vis().is_at_least(directive.vis.get(), self) ||
316 // c.f. `PUB_USE_OF_PRIVATE_EXTERN_CRATE`
317 !directive.is_glob() && binding.is_extern_crate() {
323 if let GlobImport { ref max_vis, .. } = directive.subclass {
324 if vis == directive.vis.get() || vis.is_at_least(max_vis.get(), self) {
329 self.arenas.alloc_name_binding(NameBinding {
330 kind: NameBindingKind::Import {
333 used: Cell::new(false),
335 span: directive.span,
337 expansion: directive.expansion,
341 // Define the name or return the existing binding if there is a collision.
342 pub fn try_define(&mut self,
346 binding: &'a NameBinding<'a>)
347 -> Result<(), &'a NameBinding<'a>> {
348 self.update_resolution(module, ident, ns, |this, resolution| {
349 if let Some(old_binding) = resolution.binding {
350 if binding.is_glob_import() {
351 if !old_binding.is_glob_import() &&
352 !(ns == MacroNS && old_binding.expansion != Mark::root()) {
353 resolution.shadowed_glob = Some(binding);
354 } else if binding.def() != old_binding.def() {
355 resolution.binding = Some(this.ambiguity(old_binding, binding));
356 } else if !old_binding.vis.is_at_least(binding.vis, &*this) {
357 // We are glob-importing the same item but with greater visibility.
358 resolution.binding = Some(binding);
360 } else if old_binding.is_glob_import() {
361 if ns == MacroNS && binding.expansion != Mark::root() &&
362 binding.def() != old_binding.def() {
363 resolution.binding = Some(this.ambiguity(binding, old_binding));
365 resolution.binding = Some(binding);
366 resolution.shadowed_glob = Some(old_binding);
368 } else if let (&NameBindingKind::Def(_, true), &NameBindingKind::Def(_, true)) =
369 (&old_binding.kind, &binding.kind) {
371 this.session.buffer_lint_with_diagnostic(
372 DUPLICATE_MACRO_EXPORTS,
375 &format!("a macro named `{}` has already been exported", ident),
376 BuiltinLintDiagnostics::DuplicatedMacroExports(
377 ident, old_binding.span, binding.span));
379 resolution.binding = Some(binding);
381 return Err(old_binding);
384 resolution.binding = Some(binding);
391 pub fn ambiguity(&self, b1: &'a NameBinding<'a>, b2: &'a NameBinding<'a>)
392 -> &'a NameBinding<'a> {
393 self.arenas.alloc_name_binding(NameBinding {
394 kind: NameBindingKind::Ambiguity { b1, b2 },
395 vis: if b1.vis.is_at_least(b2.vis, self) { b1.vis } else { b2.vis },
397 expansion: Mark::root(),
401 // Use `f` to mutate the resolution of the name in the module.
402 // If the resolution becomes a success, define it in the module's glob importers.
403 fn update_resolution<T, F>(&mut self, module: Module<'a>, ident: Ident, ns: Namespace, f: F)
405 where F: FnOnce(&mut Resolver<'a, 'crateloader>, &mut NameResolution<'a>) -> T
407 // Ensure that `resolution` isn't borrowed when defining in the module's glob importers,
408 // during which the resolution might end up getting re-defined via a glob cycle.
410 let resolution = &mut *self.resolution(module, ident, ns).borrow_mut();
411 let old_binding = resolution.binding();
413 let t = f(self, resolution);
415 match resolution.binding() {
416 _ if old_binding.is_some() => return t,
418 Some(binding) => match old_binding {
419 Some(old_binding) if ptr::eq(old_binding, binding) => return t,
425 // Define `binding` in `module`s glob importers.
426 for directive in module.glob_importers.borrow_mut().iter() {
427 let mut ident = ident.modern();
428 let scope = match ident.span.reverse_glob_adjust(module.expansion,
429 directive.span.ctxt().modern()) {
430 Some(Some(def)) => self.macro_def_scope(def),
431 Some(None) => directive.parent,
434 if self.is_accessible_from(binding.vis, scope) {
435 let imported_binding = self.import(binding, directive);
436 let _ = self.try_define(directive.parent, ident, ns, imported_binding);
443 // Define a "dummy" resolution containing a Def::Err as a placeholder for a
445 fn import_dummy_binding(&mut self, directive: &'a ImportDirective<'a>) {
446 if let SingleImport { target, .. } = directive.subclass {
447 let dummy_binding = self.dummy_binding;
448 let dummy_binding = self.import(dummy_binding, directive);
449 self.per_ns(|this, ns| {
450 let _ = this.try_define(directive.parent, target, ns, dummy_binding);
456 pub struct ImportResolver<'a, 'b: 'a, 'c: 'a + 'b> {
457 pub resolver: &'a mut Resolver<'b, 'c>,
460 impl<'a, 'b: 'a, 'c: 'a + 'b> ::std::ops::Deref for ImportResolver<'a, 'b, 'c> {
461 type Target = Resolver<'b, 'c>;
462 fn deref(&self) -> &Resolver<'b, 'c> {
467 impl<'a, 'b: 'a, 'c: 'a + 'b> ::std::ops::DerefMut for ImportResolver<'a, 'b, 'c> {
468 fn deref_mut(&mut self) -> &mut Resolver<'b, 'c> {
473 impl<'a, 'b: 'a, 'c: 'a + 'b> ty::DefIdTree for &'a ImportResolver<'a, 'b, 'c> {
474 fn parent(self, id: DefId) -> Option<DefId> {
475 self.resolver.parent(id)
479 impl<'a, 'b:'a, 'c: 'b> ImportResolver<'a, 'b, 'c> {
482 // This is a fixed-point algorithm. We resolve imports until our efforts
483 // are stymied by an unresolved import; then we bail out of the current
484 // module and continue. We terminate successfully once no more imports
485 // remain or unsuccessfully when no forward progress in resolving imports
488 /// Resolves all imports for the crate. This method performs the fixed-
490 pub fn resolve_imports(&mut self) {
491 let mut prev_num_indeterminates = self.indeterminate_imports.len() + 1;
492 while self.indeterminate_imports.len() < prev_num_indeterminates {
493 prev_num_indeterminates = self.indeterminate_imports.len();
494 for import in mem::replace(&mut self.indeterminate_imports, Vec::new()) {
495 match self.resolve_import(&import) {
496 true => self.determined_imports.push(import),
497 false => self.indeterminate_imports.push(import),
503 pub fn finalize_imports(&mut self) {
504 for module in self.arenas.local_modules().iter() {
505 self.finalize_resolutions_in(module);
508 let mut errors = false;
509 let mut seen_spans = FxHashSet();
510 for i in 0 .. self.determined_imports.len() {
511 let import = self.determined_imports[i];
512 if let Some((span, err)) = self.finalize_import(import) {
515 if let SingleImport { source, ref result, .. } = import.subclass {
516 if source.name == "self" {
517 // Silence `unresolved import` error if E0429 is already emitted
518 match result.value_ns.get() {
519 Err(Determined) => continue,
525 // If the error is a single failed import then create a "fake" import
526 // resolution for it so that later resolve stages won't complain.
527 self.import_dummy_binding(import);
528 if !seen_spans.contains(&span) {
529 let path = import_path_to_string(&import.module_path[..],
532 let error = ResolutionError::UnresolvedImport(Some((span, &path, &err)));
533 resolve_error(self.resolver, span, error);
534 seen_spans.insert(span);
539 // Report unresolved imports only if no hard error was already reported
540 // to avoid generating multiple errors on the same import.
542 if let Some(import) = self.indeterminate_imports.iter().next() {
543 let error = ResolutionError::UnresolvedImport(None);
544 resolve_error(self.resolver, import.span, error);
549 /// Attempts to resolve the given import, returning true if its resolution is determined.
550 /// If successful, the resolved bindings are written into the module.
551 fn resolve_import(&mut self, directive: &'b ImportDirective<'b>) -> bool {
552 debug!("(resolving import for module) resolving import `{}::...` in `{}`",
553 names_to_string(&directive.module_path[..]),
554 module_to_string(self.current_module).unwrap_or("???".to_string()));
556 self.current_module = directive.parent;
558 let module = if let Some(module) = directive.imported_module.get() {
561 let vis = directive.vis.get();
562 // For better failure detection, pretend that the import will not define any names
563 // while resolving its module path.
564 directive.vis.set(ty::Visibility::Invisible);
565 let result = self.resolve_path(&directive.module_path[..], None, false,
566 directive.span, directive.crate_lint());
567 directive.vis.set(vis);
570 PathResult::Module(module) => module,
571 PathResult::Indeterminate => return false,
576 directive.imported_module.set(Some(module));
577 let (source, target, result, type_ns_only) = match directive.subclass {
578 SingleImport { source, target, ref result, type_ns_only } =>
579 (source, target, result, type_ns_only),
580 GlobImport { .. } => {
581 self.resolve_glob_import(directive);
587 let mut indeterminate = false;
588 self.per_ns(|this, ns| if !type_ns_only || ns == TypeNS {
589 if let Err(Undetermined) = result[ns].get() {
590 result[ns].set(this.resolve_ident_in_module(module,
599 let parent = directive.parent;
600 match result[ns].get() {
601 Err(Undetermined) => indeterminate = true,
603 this.update_resolution(parent, target, ns, |_, resolution| {
604 resolution.single_imports.remove(&PtrKey(directive));
607 Ok(binding) if !binding.is_importable() => {
608 let msg = format!("`{}` is not directly importable", target);
609 struct_span_err!(this.session, directive.span, E0253, "{}", &msg)
610 .span_label(directive.span, "cannot be imported directly")
612 // Do not import this illegal binding. Import a dummy binding and pretend
613 // everything is fine
614 this.import_dummy_binding(directive);
617 let imported_binding = this.import(binding, directive);
618 let conflict = this.try_define(parent, target, ns, imported_binding);
619 if let Err(old_binding) = conflict {
620 this.report_conflict(parent, target, ns, imported_binding, old_binding);
629 // If appropriate, returns an error to report.
630 fn finalize_import(&mut self, directive: &'b ImportDirective<'b>) -> Option<(Span, String)> {
631 self.current_module = directive.parent;
632 let ImportDirective { ref module_path, span, .. } = *directive;
633 let mut warn_if_binding_comes_from_local_crate = false;
635 // FIXME: Last path segment is treated specially in import resolution, so extern crate
636 // mode for absolute paths needs some special support for single-segment imports.
637 if module_path.len() == 1 && (module_path[0].name == keywords::CrateRoot.name() ||
638 module_path[0].name == keywords::Extern.name()) {
639 let is_extern = module_path[0].name == keywords::Extern.name() ||
640 (self.session.features_untracked().extern_absolute_paths &&
641 self.session.rust_2018());
642 match directive.subclass {
643 GlobImport { .. } if is_extern => {
644 return Some((directive.span,
645 "cannot glob-import all possible crates".to_string()));
647 GlobImport { .. } if self.session.features_untracked().extern_absolute_paths => {
648 self.lint_path_starts_with_module(
653 SingleImport { source, target, .. } => {
654 let crate_root = if source.name == keywords::Crate.name() &&
655 module_path[0].name != keywords::Extern.name() {
656 if target.name == keywords::Crate.name() {
657 return Some((directive.span,
658 "crate root imports need to be explicitly named: \
659 `use crate as name;`".to_string()));
661 Some(self.resolve_crate_root(source))
663 } else if is_extern && !source.is_path_segment_keyword() {
665 self.resolver.crate_loader.process_use_extern(
669 &self.resolver.definitions,
672 self.get_module(DefId { krate: crate_id, index: CRATE_DEF_INDEX });
673 self.populate_module_if_necessary(crate_root);
676 warn_if_binding_comes_from_local_crate = true;
680 if let Some(crate_root) = crate_root {
681 let binding = (crate_root, ty::Visibility::Public, directive.span,
682 directive.expansion).to_name_binding(self.arenas);
683 let binding = self.arenas.alloc_name_binding(NameBinding {
684 kind: NameBindingKind::Import {
687 used: Cell::new(false),
689 vis: directive.vis.get(),
690 span: directive.span,
691 expansion: directive.expansion,
693 let _ = self.try_define(directive.parent, target, TypeNS, binding);
694 let import = self.import_map.entry(directive.id).or_default();
695 import[TypeNS] = Some(PathResolution::new(binding.def()));
703 let module_result = self.resolve_path(
708 directive.crate_lint(),
710 let module = match module_result {
711 PathResult::Module(module) => module,
712 PathResult::Failed(span, msg, false) => {
713 resolve_error(self, span, ResolutionError::FailedToResolve(&msg));
716 PathResult::Failed(span, msg, true) => {
717 let (mut self_path, mut self_result) = (module_path.clone(), None);
718 let is_special = |ident: Ident| ident.is_path_segment_keyword() &&
719 ident.name != keywords::CrateRoot.name();
720 if !self_path.is_empty() && !is_special(self_path[0]) &&
721 !(self_path.len() > 1 && is_special(self_path[1])) {
722 self_path[0].name = keywords::SelfValue.name();
723 self_result = Some(self.resolve_path(&self_path, None, false,
724 span, CrateLint::No));
726 return if let Some(PathResult::Module(..)) = self_result {
727 Some((span, format!("Did you mean `{}`?", names_to_string(&self_path[..]))))
735 let (ident, result, type_ns_only) = match directive.subclass {
736 SingleImport { source, ref result, type_ns_only, .. } => (source, result, type_ns_only),
737 GlobImport { .. } if module.def_id() == directive.parent.def_id() => {
738 // Importing a module into itself is not allowed.
739 return Some((directive.span,
740 "Cannot glob-import a module into itself.".to_string()));
742 GlobImport { is_prelude, ref max_vis } => {
744 max_vis.get() != ty::Visibility::Invisible && // Allow empty globs.
745 !max_vis.get().is_at_least(directive.vis.get(), &*self) {
746 let msg = "A non-empty glob must import something with the glob's visibility";
747 self.session.span_err(directive.span, msg);
754 let mut all_ns_err = true;
755 self.per_ns(|this, ns| if !type_ns_only || ns == TypeNS {
756 if let Ok(binding) = result[ns].get() {
758 if this.record_use(ident, ns, binding, directive.span) {
759 this.resolution(module, ident, ns).borrow_mut().binding =
760 Some(this.dummy_binding);
766 let mut all_ns_failed = true;
767 self.per_ns(|this, ns| if !type_ns_only || ns == TypeNS {
768 match this.resolve_ident_in_module(module, ident, ns, true, span) {
769 Ok(_) => all_ns_failed = false,
774 return if all_ns_failed {
775 let resolutions = module.resolutions.borrow();
776 let names = resolutions.iter().filter_map(|(&(ref i, _), resolution)| {
777 if *i == ident { return None; } // Never suggest the same name
778 match *resolution.borrow() {
779 NameResolution { binding: Some(name_binding), .. } => {
780 match name_binding.kind {
781 NameBindingKind::Import { binding, .. } => {
783 // Never suggest the name that has binding error
784 // i.e. the name that cannot be previously resolved
785 NameBindingKind::Def(Def::Err, _) => return None,
792 NameResolution { ref single_imports, .. }
793 if single_imports.is_empty() => None,
798 match find_best_match_for_name(names, &ident.as_str(), None) {
799 Some(name) => format!(". Did you mean to use `{}`?", name),
800 None => "".to_owned(),
802 let module_str = module_to_string(module);
803 let msg = if let Some(module_str) = module_str {
804 format!("no `{}` in `{}`{}", ident, module_str, lev_suggestion)
806 format!("no `{}` in the root{}", ident, lev_suggestion)
810 // `resolve_ident_in_module` reported a privacy error.
811 self.import_dummy_binding(directive);
816 let mut reexport_error = None;
817 let mut any_successful_reexport = false;
818 self.per_ns(|this, ns| {
819 if let Ok(binding) = result[ns].get() {
820 let vis = directive.vis.get();
821 if !binding.pseudo_vis().is_at_least(vis, &*this) {
822 reexport_error = Some((ns, binding));
824 any_successful_reexport = true;
829 // All namespaces must be re-exported with extra visibility for an error to occur.
830 if !any_successful_reexport {
831 let (ns, binding) = reexport_error.unwrap();
832 if ns == TypeNS && binding.is_extern_crate() {
833 let msg = format!("extern crate `{}` is private, and cannot be \
834 re-exported (error E0365), consider declaring with \
837 self.session.buffer_lint(PUB_USE_OF_PRIVATE_EXTERN_CRATE,
841 } else if ns == TypeNS {
842 struct_span_err!(self.session, directive.span, E0365,
843 "`{}` is private, and cannot be re-exported", ident)
844 .span_label(directive.span, format!("re-export of private `{}`", ident))
845 .note(&format!("consider declaring type or module `{}` with `pub`", ident))
848 let msg = format!("`{}` is private, and cannot be re-exported", ident);
850 format!("consider marking `{}` as `pub` in the imported module", ident);
851 struct_span_err!(self.session, directive.span, E0364, "{}", &msg)
852 .span_note(directive.span, ¬e_msg)
857 if warn_if_binding_comes_from_local_crate {
858 let mut warned = false;
859 self.per_ns(|this, ns| {
860 let binding = match result[ns].get().ok() {
864 if let NameBindingKind::Import { directive: d, .. } = binding.kind {
865 if let ImportDirectiveSubclass::ExternCrate(..) = d.subclass {
873 this.lint_path_starts_with_module(
880 // Record what this import resolves to for later uses in documentation,
881 // this may resolve to either a value or a type, but for documentation
882 // purposes it's good enough to just favor one over the other.
883 self.per_ns(|this, ns| if let Some(binding) = result[ns].get().ok() {
884 let import = this.import_map.entry(directive.id).or_default();
885 import[ns] = Some(PathResolution::new(binding.def()));
888 debug!("(resolving single import) successfully resolved import");
892 fn resolve_glob_import(&mut self, directive: &'b ImportDirective<'b>) {
893 let module = directive.imported_module.get().unwrap();
894 self.populate_module_if_necessary(module);
896 if let Some(Def::Trait(_)) = module.def() {
897 self.session.span_err(directive.span, "items in traits are not importable.");
899 } else if module.def_id() == directive.parent.def_id() {
901 } else if let GlobImport { is_prelude: true, .. } = directive.subclass {
902 self.prelude = Some(module);
906 // Add to module's glob_importers
907 module.glob_importers.borrow_mut().push(directive);
909 // Ensure that `resolutions` isn't borrowed during `try_define`,
910 // since it might get updated via a glob cycle.
911 let bindings = module.resolutions.borrow().iter().filter_map(|(&ident, resolution)| {
912 resolution.borrow().binding().map(|binding| (ident, binding))
913 }).collect::<Vec<_>>();
914 for ((mut ident, ns), binding) in bindings {
915 let scope = match ident.span.reverse_glob_adjust(module.expansion,
916 directive.span.ctxt().modern()) {
917 Some(Some(def)) => self.macro_def_scope(def),
918 Some(None) => self.current_module,
921 if self.is_accessible_from(binding.pseudo_vis(), scope) {
922 let imported_binding = self.import(binding, directive);
923 let _ = self.try_define(directive.parent, ident, ns, imported_binding);
927 // Record the destination of this import
928 self.record_def(directive.id, PathResolution::new(module.def().unwrap()));
931 // Miscellaneous post-processing, including recording re-exports,
932 // reporting conflicts, and reporting unresolved imports.
933 fn finalize_resolutions_in(&mut self, module: Module<'b>) {
934 // Since import resolution is finished, globs will not define any more names.
935 *module.globs.borrow_mut() = Vec::new();
937 let mut reexports = Vec::new();
938 let mut exported_macro_names = FxHashMap();
939 if ptr::eq(module, self.graph_root) {
940 let macro_exports = mem::replace(&mut self.macro_exports, Vec::new());
941 for export in macro_exports.into_iter().rev() {
942 if let Some(later_span) = exported_macro_names.insert(export.ident.modern(),
944 self.session.buffer_lint_with_diagnostic(
945 DUPLICATE_MACRO_EXPORTS,
948 &format!("a macro named `{}` has already been exported", export.ident),
949 BuiltinLintDiagnostics::DuplicatedMacroExports(
950 export.ident, export.span, later_span));
952 reexports.push(export);
957 for (&(ident, ns), resolution) in module.resolutions.borrow().iter() {
958 let resolution = &mut *resolution.borrow_mut();
959 let binding = match resolution.binding {
960 Some(binding) => binding,
964 if binding.is_import() || binding.is_macro_def() {
965 let def = binding.def();
967 if !def.def_id().is_local() {
968 self.cstore.export_macros_untracked(def.def_id().krate);
970 if let Def::Macro(..) = def {
971 if let Some(&span) = exported_macro_names.get(&ident.modern()) {
973 format!("a macro named `{}` has already been exported", ident);
974 self.session.struct_span_err(span, &msg)
975 .span_label(span, format!("`{}` already exported", ident))
976 .span_note(binding.span, "previous macro export here")
980 reexports.push(Export {
981 ident: ident.modern(),
990 NameBindingKind::Import { binding: orig_binding, directive, .. } => {
991 if ns == TypeNS && orig_binding.is_variant() &&
992 !orig_binding.vis.is_at_least(binding.vis, &*self) {
993 let msg = match directive.subclass {
994 ImportDirectiveSubclass::SingleImport { .. } => {
995 format!("variant `{}` is private and cannot be re-exported",
998 ImportDirectiveSubclass::GlobImport { .. } => {
999 let msg = "enum is private and its variants \
1000 cannot be re-exported".to_owned();
1001 let error_id = (DiagnosticMessageId::ErrorId(0), // no code?!
1004 let fresh = self.session.one_time_diagnostics
1005 .borrow_mut().insert(error_id);
1011 ref s @ _ => bug!("unexpected import subclass {:?}", s)
1013 let mut err = self.session.struct_span_err(binding.span, &msg);
1015 let imported_module = directive.imported_module.get()
1016 .expect("module should exist");
1017 let resolutions = imported_module.parent.expect("parent should exist")
1018 .resolutions.borrow();
1019 let enum_path_segment_index = directive.module_path.len() - 1;
1020 let enum_ident = directive.module_path[enum_path_segment_index];
1022 let enum_resolution = resolutions.get(&(enum_ident, TypeNS))
1023 .expect("resolution should exist");
1024 let enum_span = enum_resolution.borrow()
1025 .binding.expect("binding should exist")
1027 let enum_def_span = self.session.codemap().def_span(enum_span);
1028 let enum_def_snippet = self.session.codemap()
1029 .span_to_snippet(enum_def_span).expect("snippet should exist");
1030 // potentially need to strip extant `crate`/`pub(path)` for suggestion
1031 let after_vis_index = enum_def_snippet.find("enum")
1032 .expect("`enum` keyword should exist in snippet");
1033 let suggestion = format!("pub {}",
1034 &enum_def_snippet[after_vis_index..]);
1037 .diag_span_suggestion_once(&mut err,
1038 DiagnosticMessageId::ErrorId(0),
1040 "consider making the enum public",
1049 if reexports.len() > 0 {
1050 if let Some(def_id) = module.def_id() {
1051 self.export_map.insert(def_id, reexports);
1057 fn import_path_to_string(names: &[Ident],
1058 subclass: &ImportDirectiveSubclass,
1059 span: Span) -> String {
1060 let pos = names.iter()
1061 .position(|p| span == p.span && p.name != keywords::CrateRoot.name());
1062 let global = !names.is_empty() && names[0].name == keywords::CrateRoot.name();
1063 if let Some(pos) = pos {
1064 let names = if global { &names[1..pos + 1] } else { &names[..pos + 1] };
1065 names_to_string(names)
1067 let names = if global { &names[1..] } else { names };
1068 if names.is_empty() {
1069 import_directive_subclass_to_string(subclass)
1072 names_to_string(names),
1073 import_directive_subclass_to_string(subclass))
1078 fn import_directive_subclass_to_string(subclass: &ImportDirectiveSubclass) -> String {
1080 SingleImport { source, .. } => source.to_string(),
1081 GlobImport { .. } => "*".to_string(),
1082 ExternCrate(_) => "<extern crate>".to_string(),
1083 MacroUse => "#[macro_use]".to_string(),