]> git.lizzy.rs Git - rust.git/blob - src/librustc_resolve/macros.rs
030e3936de994fb24c436b5bb389e209855afd75
[rust.git] / src / librustc_resolve / macros.rs
1 // Copyright 2016 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
4 //
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
10
11 use {AmbiguityError, Resolver, ResolutionError, resolve_error};
12 use {Module, ModuleKind, NameBinding, NameBindingKind, PathResult};
13 use Namespace::{self, MacroNS};
14 use build_reduced_graph::BuildReducedGraphVisitor;
15 use resolve_imports::ImportResolver;
16 use rustc::hir::def_id::{DefId, BUILTIN_MACROS_CRATE, CRATE_DEF_INDEX, DefIndex};
17 use rustc::hir::def::{Def, Export};
18 use rustc::hir::map::{self, DefCollector};
19 use rustc::ty;
20 use syntax::ast::{self, Name, Ident};
21 use syntax::attr::{self, HasAttrs};
22 use syntax::errors::DiagnosticBuilder;
23 use syntax::ext::base::{self, Annotatable, Determinacy, MultiModifier, MultiDecorator};
24 use syntax::ext::base::{MacroKind, SyntaxExtension, Resolver as SyntaxResolver};
25 use syntax::ext::expand::{Expansion, ExpansionKind, Invocation, InvocationKind, find_attr_invoc};
26 use syntax::ext::hygiene::Mark;
27 use syntax::ext::placeholders::placeholder;
28 use syntax::ext::tt::macro_rules;
29 use syntax::feature_gate::{self, emit_feature_err, GateIssue};
30 use syntax::fold::{self, Folder};
31 use syntax::parse::parser::PathStyle;
32 use syntax::parse::token::{self, Token};
33 use syntax::ptr::P;
34 use syntax::symbol::{Symbol, keywords};
35 use syntax::tokenstream::{TokenStream, TokenTree, Delimited};
36 use syntax::util::lev_distance::find_best_match_for_name;
37 use syntax_pos::{Span, DUMMY_SP};
38
39 use std::cell::Cell;
40 use std::mem;
41 use std::rc::Rc;
42
43 #[derive(Clone)]
44 pub struct InvocationData<'a> {
45     pub module: Cell<Module<'a>>,
46     pub def_index: DefIndex,
47     // True if this expansion is in a `const_expr` position, for example `[u32; m!()]`.
48     // c.f. `DefCollector::visit_const_expr`.
49     pub const_expr: bool,
50     // The scope in which the invocation path is resolved.
51     pub legacy_scope: Cell<LegacyScope<'a>>,
52     // The smallest scope that includes this invocation's expansion,
53     // or `Empty` if this invocation has not been expanded yet.
54     pub expansion: Cell<LegacyScope<'a>>,
55 }
56
57 impl<'a> InvocationData<'a> {
58     pub fn root(graph_root: Module<'a>) -> Self {
59         InvocationData {
60             module: Cell::new(graph_root),
61             def_index: CRATE_DEF_INDEX,
62             const_expr: false,
63             legacy_scope: Cell::new(LegacyScope::Empty),
64             expansion: Cell::new(LegacyScope::Empty),
65         }
66     }
67 }
68
69 #[derive(Copy, Clone)]
70 pub enum LegacyScope<'a> {
71     Empty,
72     Invocation(&'a InvocationData<'a>), // The scope of the invocation, not including its expansion
73     Expansion(&'a InvocationData<'a>), // The scope of the invocation, including its expansion
74     Binding(&'a LegacyBinding<'a>),
75 }
76
77 pub struct LegacyBinding<'a> {
78     pub parent: Cell<LegacyScope<'a>>,
79     pub name: ast::Name,
80     def_id: DefId,
81     pub span: Span,
82 }
83
84 #[derive(Copy, Clone)]
85 pub enum MacroBinding<'a> {
86     Legacy(&'a LegacyBinding<'a>),
87     Global(&'a NameBinding<'a>),
88     Modern(&'a NameBinding<'a>),
89 }
90
91 impl<'a> MacroBinding<'a> {
92     pub fn span(self) -> Span {
93         match self {
94             MacroBinding::Legacy(binding) => binding.span,
95             MacroBinding::Global(binding) | MacroBinding::Modern(binding) => binding.span,
96         }
97     }
98
99     pub fn binding(self) -> &'a NameBinding<'a> {
100         match self {
101             MacroBinding::Global(binding) | MacroBinding::Modern(binding) => binding,
102             MacroBinding::Legacy(_) => panic!("unexpected MacroBinding::Legacy"),
103         }
104     }
105 }
106
107 impl<'a> base::Resolver for Resolver<'a> {
108     fn next_node_id(&mut self) -> ast::NodeId {
109         self.session.next_node_id()
110     }
111
112     fn get_module_scope(&mut self, id: ast::NodeId) -> Mark {
113         let mark = Mark::fresh();
114         let module = self.module_map[&self.definitions.local_def_id(id)];
115         self.invocations.insert(mark, self.arenas.alloc_invocation_data(InvocationData {
116             module: Cell::new(module),
117             def_index: module.def_id().unwrap().index,
118             const_expr: false,
119             legacy_scope: Cell::new(LegacyScope::Empty),
120             expansion: Cell::new(LegacyScope::Empty),
121         }));
122         mark
123     }
124
125     fn eliminate_crate_var(&mut self, item: P<ast::Item>) -> P<ast::Item> {
126         struct EliminateCrateVar<'b, 'a: 'b>(&'b mut Resolver<'a>);
127
128         impl<'a, 'b> Folder for EliminateCrateVar<'a, 'b> {
129             fn fold_path(&mut self, mut path: ast::Path) -> ast::Path {
130                 let ident = path.segments[0].identifier;
131                 if ident.name == "$crate" {
132                     path.segments[0].identifier.name = keywords::CrateRoot.name();
133                     let module = self.0.resolve_crate_var(ident.ctxt);
134                     if !module.is_local() {
135                         let span = path.segments[0].span;
136                         path.segments.insert(1, match module.kind {
137                             ModuleKind::Def(_, name) => ast::PathSegment::from_ident(
138                                 ast::Ident::with_empty_ctxt(name), span
139                             ),
140                             _ => unreachable!(),
141                         })
142                     }
143                 }
144                 path
145             }
146
147             fn fold_mac(&mut self, mac: ast::Mac) -> ast::Mac {
148                 fold::noop_fold_mac(mac, self)
149             }
150         }
151
152         EliminateCrateVar(self).fold_item(item).expect_one("")
153     }
154
155     fn is_whitelisted_legacy_custom_derive(&self, name: Name) -> bool {
156         self.whitelisted_legacy_custom_derives.contains(&name)
157     }
158
159     fn visit_expansion(&mut self, mark: Mark, expansion: &Expansion, derives: &[Mark]) {
160         let invocation = self.invocations[&mark];
161         self.collect_def_ids(invocation, expansion);
162
163         self.current_module = invocation.module.get();
164         self.current_module.unresolved_invocations.borrow_mut().remove(&mark);
165         self.current_module.unresolved_invocations.borrow_mut().extend(derives);
166         for &derive in derives {
167             self.invocations.insert(derive, invocation);
168         }
169         let mut visitor = BuildReducedGraphVisitor {
170             resolver: self,
171             legacy_scope: LegacyScope::Invocation(invocation),
172             expansion: mark,
173         };
174         expansion.visit_with(&mut visitor);
175         invocation.expansion.set(visitor.legacy_scope);
176     }
177
178     fn add_builtin(&mut self, ident: ast::Ident, ext: Rc<SyntaxExtension>) {
179         let def_id = DefId {
180             krate: BUILTIN_MACROS_CRATE,
181             index: DefIndex::new(self.macro_map.len()),
182         };
183         let kind = ext.kind();
184         self.macro_map.insert(def_id, ext);
185         let binding = self.arenas.alloc_name_binding(NameBinding {
186             kind: NameBindingKind::Def(Def::Macro(def_id, kind)),
187             span: DUMMY_SP,
188             vis: ty::Visibility::Invisible,
189             expansion: Mark::root(),
190         });
191         self.global_macros.insert(ident.name, binding);
192     }
193
194     fn resolve_imports(&mut self) {
195         ImportResolver { resolver: self }.resolve_imports()
196     }
197
198     // Resolves attribute and derive legacy macros from `#![plugin(..)]`.
199     fn find_legacy_attr_invoc(&mut self, attrs: &mut Vec<ast::Attribute>)
200                               -> Option<ast::Attribute> {
201         for i in 0..attrs.len() {
202             let name = unwrap_or!(attrs[i].name(), continue);
203
204             if self.session.plugin_attributes.borrow().iter()
205                     .any(|&(ref attr_nm, _)| name == &**attr_nm) {
206                 attr::mark_known(&attrs[i]);
207             }
208
209             match self.global_macros.get(&name).cloned() {
210                 Some(binding) => match *binding.get_macro(self) {
211                     MultiModifier(..) | MultiDecorator(..) | SyntaxExtension::AttrProcMacro(..) => {
212                         return Some(attrs.remove(i))
213                     }
214                     _ => {}
215                 },
216                 None => {}
217             }
218         }
219
220         // Check for legacy derives
221         for i in 0..attrs.len() {
222             let name = unwrap_or!(attrs[i].name(), continue);
223
224             if name == "derive" {
225                 let result = attrs[i].parse_list(&self.session.parse_sess, |parser| {
226                     parser.parse_path_allowing_meta(PathStyle::Mod)
227                 });
228
229                 let mut traits = match result {
230                     Ok(traits) => traits,
231                     Err(mut e) => {
232                         e.cancel();
233                         continue
234                     }
235                 };
236
237                 for j in 0..traits.len() {
238                     if traits[j].segments.len() > 1 {
239                         continue
240                     }
241                     let trait_name = traits[j].segments[0].identifier.name;
242                     let legacy_name = Symbol::intern(&format!("derive_{}", trait_name));
243                     if !self.global_macros.contains_key(&legacy_name) {
244                         continue
245                     }
246                     let span = traits.remove(j).span;
247                     self.gate_legacy_custom_derive(legacy_name, span);
248                     if traits.is_empty() {
249                         attrs.remove(i);
250                     } else {
251                         let mut tokens = Vec::new();
252                         for (j, path) in traits.iter().enumerate() {
253                             if j > 0 {
254                                 tokens.push(TokenTree::Token(attrs[i].span, Token::Comma).into());
255                             }
256                             for (k, segment) in path.segments.iter().enumerate() {
257                                 if k > 0 {
258                                     tokens.push(TokenTree::Token(path.span, Token::ModSep).into());
259                                 }
260                                 let tok = Token::Ident(segment.identifier);
261                                 tokens.push(TokenTree::Token(path.span, tok).into());
262                             }
263                         }
264                         attrs[i].tokens = TokenTree::Delimited(attrs[i].span, Delimited {
265                             delim: token::Paren,
266                             tts: TokenStream::concat(tokens).into(),
267                         }).into();
268                     }
269                     return Some(ast::Attribute {
270                         path: ast::Path::from_ident(span, Ident::with_empty_ctxt(legacy_name)),
271                         tokens: TokenStream::empty(),
272                         id: attr::mk_attr_id(),
273                         style: ast::AttrStyle::Outer,
274                         is_sugared_doc: false,
275                         span: span,
276                     });
277                 }
278             }
279         }
280
281         None
282     }
283
284     fn resolve_invoc(&mut self, invoc: &mut Invocation, scope: Mark, force: bool)
285                      -> Result<Option<Rc<SyntaxExtension>>, Determinacy> {
286         let def = match invoc.kind {
287             InvocationKind::Attr { attr: None, .. } => return Ok(None),
288             _ => match self.resolve_invoc_to_def(invoc, scope, force) {
289                 Ok(def) => def,
290                 Err(determinacy) => return Err(determinacy),
291             },
292         };
293         self.macro_defs.insert(invoc.expansion_data.mark, def.def_id());
294         Ok(Some(self.get_macro(def)))
295     }
296
297     fn resolve_macro(&mut self, scope: Mark, path: &ast::Path, kind: MacroKind, force: bool)
298                      -> Result<Rc<SyntaxExtension>, Determinacy> {
299         self.resolve_macro_to_def(scope, path, kind, force).map(|def| self.get_macro(def))
300     }
301 }
302
303 impl<'a> Resolver<'a> {
304     fn resolve_invoc_to_def(&mut self, invoc: &mut Invocation, scope: Mark, force: bool)
305                             -> Result<Def, Determinacy> {
306         let (attr, traits, item) = match invoc.kind {
307             InvocationKind::Attr { ref mut attr, ref traits, ref mut item } => (attr, traits, item),
308             InvocationKind::Bang { ref mac, .. } => {
309                 return self.resolve_macro_to_def(scope, &mac.node.path, MacroKind::Bang, force);
310             }
311             InvocationKind::Derive { ref path, .. } => {
312                 return self.resolve_macro_to_def(scope, path, MacroKind::Derive, force);
313             }
314         };
315
316
317         let path = attr.as_ref().unwrap().path.clone();
318         let mut determinacy = Determinacy::Determined;
319         match self.resolve_macro_to_def(scope, &path, MacroKind::Attr, force) {
320             Ok(def) => return Ok(def),
321             Err(Determinacy::Undetermined) => determinacy = Determinacy::Undetermined,
322             Err(Determinacy::Determined) if force => return Err(Determinacy::Determined),
323             Err(Determinacy::Determined) => {}
324         }
325
326         let attr_name = match path.segments.len() {
327             1 => path.segments[0].identifier.name,
328             _ => return Err(determinacy),
329         };
330         for path in traits {
331             match self.resolve_macro(scope, path, MacroKind::Derive, force) {
332                 Ok(ext) => if let SyntaxExtension::ProcMacroDerive(_, ref inert_attrs) = *ext {
333                     if inert_attrs.contains(&attr_name) {
334                         // FIXME(jseyfried) Avoid `mem::replace` here.
335                         let dummy_item = placeholder(ExpansionKind::Items, ast::DUMMY_NODE_ID)
336                             .make_items().pop().unwrap();
337                         let dummy_item = Annotatable::Item(dummy_item);
338                         *item = mem::replace(item, dummy_item).map_attrs(|mut attrs| {
339                             let inert_attr = attr.take().unwrap();
340                             attr::mark_known(&inert_attr);
341                             if self.proc_macro_enabled {
342                                 *attr = find_attr_invoc(&mut attrs);
343                             }
344                             attrs.push(inert_attr);
345                             attrs
346                         });
347                     }
348                     return Err(Determinacy::Undetermined);
349                 },
350                 Err(Determinacy::Undetermined) => determinacy = Determinacy::Undetermined,
351                 Err(Determinacy::Determined) => {}
352             }
353         }
354
355         Err(determinacy)
356     }
357
358     fn resolve_macro_to_def(&mut self, scope: Mark, path: &ast::Path, kind: MacroKind, force: bool)
359                             -> Result<Def, Determinacy> {
360         let ast::Path { ref segments, span } = *path;
361         if segments.iter().any(|segment| segment.parameters.is_some()) {
362             let kind =
363                 if segments.last().unwrap().parameters.is_some() { "macro" } else { "module" };
364             let msg = format!("type parameters are not allowed on {}s", kind);
365             self.session.span_err(path.span, &msg);
366             return Err(Determinacy::Determined);
367         }
368
369         let path: Vec<_> = segments.iter().map(|seg| seg.identifier).collect();
370         let invocation = self.invocations[&scope];
371         self.current_module = invocation.module.get();
372
373         if path.len() > 1 {
374             if !self.use_extern_macros && self.gated_errors.insert(span) {
375                 let msg = "non-ident macro paths are experimental";
376                 let feature = "use_extern_macros";
377                 emit_feature_err(&self.session.parse_sess, feature, span, GateIssue::Language, msg);
378                 self.found_unresolved_macro = true;
379                 return Err(Determinacy::Determined);
380             }
381
382             let def = match self.resolve_path(&path, Some(MacroNS), None) {
383                 PathResult::NonModule(path_res) => match path_res.base_def() {
384                     Def::Err => Err(Determinacy::Determined),
385                     def @ _ => Ok(def),
386                 },
387                 PathResult::Module(..) => unreachable!(),
388                 PathResult::Indeterminate if !force => return Err(Determinacy::Undetermined),
389                 _ => {
390                     self.found_unresolved_macro = true;
391                     Err(Determinacy::Determined)
392                 },
393             };
394             self.current_module.nearest_item_scope().macro_resolutions.borrow_mut()
395                 .push((path.into_boxed_slice(), span));
396             return def;
397         }
398
399         let name = path[0].name;
400         let legacy_resolution = self.resolve_legacy_scope(&invocation.legacy_scope, name, false);
401         let result = if let Some(MacroBinding::Legacy(binding)) = legacy_resolution {
402             Ok(Def::Macro(binding.def_id, MacroKind::Bang))
403         } else {
404             match self.resolve_lexical_macro_path_segment(path[0], MacroNS, None) {
405                 Ok(binding) => Ok(binding.binding().def_ignoring_ambiguity()),
406                 Err(Determinacy::Undetermined) if !force => return Err(Determinacy::Undetermined),
407                 Err(_) => {
408                     self.found_unresolved_macro = true;
409                     Err(Determinacy::Determined)
410                 }
411             }
412         };
413
414         self.current_module.nearest_item_scope().legacy_macro_resolutions.borrow_mut()
415             .push((scope, path[0], span, kind));
416
417         result
418     }
419
420     // Resolve the initial segment of a non-global macro path (e.g. `foo` in `foo::bar!();`)
421     pub fn resolve_lexical_macro_path_segment(&mut self,
422                                               ident: Ident,
423                                               ns: Namespace,
424                                               record_used: Option<Span>)
425                                               -> Result<MacroBinding<'a>, Determinacy> {
426         let mut module = Some(self.current_module);
427         let mut potential_illegal_shadower = Err(Determinacy::Determined);
428         let determinacy =
429             if record_used.is_some() { Determinacy::Determined } else { Determinacy::Undetermined };
430         loop {
431             let result = if let Some(module) = module {
432                 // Since expanded macros may not shadow the lexical scope and
433                 // globs may not shadow global macros (both enforced below),
434                 // we resolve with restricted shadowing (indicated by the penultimate argument).
435                 self.resolve_ident_in_module(module, ident, ns, true, record_used)
436                     .map(MacroBinding::Modern)
437             } else {
438                 self.global_macros.get(&ident.name).cloned().ok_or(determinacy)
439                     .map(MacroBinding::Global)
440             };
441
442             match result.map(MacroBinding::binding) {
443                 Ok(binding) => {
444                     let span = match record_used {
445                         Some(span) => span,
446                         None => return result,
447                     };
448                     if let Ok(MacroBinding::Modern(shadower)) = potential_illegal_shadower {
449                         if shadower.def() != binding.def() {
450                             let name = ident.name;
451                             self.ambiguity_errors.push(AmbiguityError {
452                                 span: span, name: name, b1: shadower, b2: binding, lexical: true,
453                                 legacy: false,
454                             });
455                             return potential_illegal_shadower;
456                         }
457                     }
458                     if binding.expansion != Mark::root() ||
459                        (binding.is_glob_import() && module.unwrap().def().is_some()) {
460                         potential_illegal_shadower = result;
461                     } else {
462                         return result;
463                     }
464                 },
465                 Err(Determinacy::Undetermined) => return Err(Determinacy::Undetermined),
466                 Err(Determinacy::Determined) => {}
467             }
468
469             module = match module {
470                 Some(module) => match module.kind {
471                     ModuleKind::Block(..) => module.parent,
472                     ModuleKind::Def(..) => None,
473                 },
474                 None => return potential_illegal_shadower,
475             }
476         }
477     }
478
479     pub fn resolve_legacy_scope(&mut self,
480                                 mut scope: &'a Cell<LegacyScope<'a>>,
481                                 name: Name,
482                                 record_used: bool)
483                                 -> Option<MacroBinding<'a>> {
484         let mut possible_time_travel = None;
485         let mut relative_depth: u32 = 0;
486         let mut binding = None;
487         loop {
488             match scope.get() {
489                 LegacyScope::Empty => break,
490                 LegacyScope::Expansion(invocation) => {
491                     match invocation.expansion.get() {
492                         LegacyScope::Invocation(_) => scope.set(invocation.legacy_scope.get()),
493                         LegacyScope::Empty => {
494                             if possible_time_travel.is_none() {
495                                 possible_time_travel = Some(scope);
496                             }
497                             scope = &invocation.legacy_scope;
498                         }
499                         _ => {
500                             relative_depth += 1;
501                             scope = &invocation.expansion;
502                         }
503                     }
504                 }
505                 LegacyScope::Invocation(invocation) => {
506                     relative_depth = relative_depth.saturating_sub(1);
507                     scope = &invocation.legacy_scope;
508                 }
509                 LegacyScope::Binding(potential_binding) => {
510                     if potential_binding.name == name {
511                         if (!self.use_extern_macros || record_used) && relative_depth > 0 {
512                             self.disallowed_shadowing.push(potential_binding);
513                         }
514                         binding = Some(potential_binding);
515                         break
516                     }
517                     scope = &potential_binding.parent;
518                 }
519             };
520         }
521
522         let binding = if let Some(binding) = binding {
523             MacroBinding::Legacy(binding)
524         } else if let Some(binding) = self.global_macros.get(&name).cloned() {
525             if !self.use_extern_macros {
526                 self.record_use(Ident::with_empty_ctxt(name), MacroNS, binding, DUMMY_SP);
527             }
528             MacroBinding::Global(binding)
529         } else {
530             return None;
531         };
532
533         if !self.use_extern_macros {
534             if let Some(scope) = possible_time_travel {
535                 // Check for disallowed shadowing later
536                 self.lexical_macro_resolutions.push((name, scope));
537             }
538         }
539
540         Some(binding)
541     }
542
543     pub fn finalize_current_module_macro_resolutions(&mut self) {
544         let module = self.current_module;
545         for &(ref path, span) in module.macro_resolutions.borrow().iter() {
546             match self.resolve_path(path, Some(MacroNS), Some(span)) {
547                 PathResult::NonModule(_) => {},
548                 PathResult::Failed(msg, _) => {
549                     resolve_error(self, span, ResolutionError::FailedToResolve(&msg));
550                 }
551                 _ => unreachable!(),
552             }
553         }
554
555         for &(mark, ident, span, kind) in module.legacy_macro_resolutions.borrow().iter() {
556             let legacy_scope = &self.invocations[&mark].legacy_scope;
557             let legacy_resolution = self.resolve_legacy_scope(legacy_scope, ident.name, true);
558             let resolution = self.resolve_lexical_macro_path_segment(ident, MacroNS, Some(span));
559             match (legacy_resolution, resolution) {
560                 (Some(MacroBinding::Legacy(legacy_binding)), Ok(MacroBinding::Modern(binding))) => {
561                     let msg1 = format!("`{}` could refer to the macro defined here", ident);
562                     let msg2 = format!("`{}` could also refer to the macro imported here", ident);
563                     self.session.struct_span_err(span, &format!("`{}` is ambiguous", ident))
564                         .span_note(legacy_binding.span, &msg1)
565                         .span_note(binding.span, &msg2)
566                         .emit();
567                 },
568                 (Some(MacroBinding::Global(binding)), Ok(MacroBinding::Global(_))) => {
569                     self.record_use(ident, MacroNS, binding, span);
570                     self.err_if_macro_use_proc_macro(ident.name, span, binding);
571                 },
572                 (None, Err(_)) => {
573                     let msg = match kind {
574                         MacroKind::Bang =>
575                             format!("cannot find macro `{}!` in this scope", ident),
576                         MacroKind::Attr =>
577                             format!("cannot find attribute macro `{}` in this scope", ident),
578                         MacroKind::Derive =>
579                             format!("cannot find derive macro `{}` in this scope", ident),
580                     };
581                     let mut err = self.session.struct_span_err(span, &msg);
582                     self.suggest_macro_name(&ident.name.as_str(), kind, &mut err);
583                     err.emit();
584                 },
585                 _ => {},
586             };
587         }
588     }
589
590     fn suggest_macro_name(&mut self, name: &str, kind: MacroKind,
591                           err: &mut DiagnosticBuilder<'a>) {
592         // First check if this is a locally-defined bang macro.
593         let suggestion = if let MacroKind::Bang = kind {
594             find_best_match_for_name(self.macro_names.iter(), name, None)
595         } else {
596             None
597         // Then check global macros.
598         }.or_else(|| {
599             // FIXME: get_macro needs an &mut Resolver, can we do it without cloning?
600             let global_macros = self.global_macros.clone();
601             let names = global_macros.iter().filter_map(|(name, binding)| {
602                 if binding.get_macro(self).kind() == kind {
603                     Some(name)
604                 } else {
605                     None
606                 }
607             });
608             find_best_match_for_name(names, name, None)
609         // Then check modules.
610         }).or_else(|| {
611             if !self.use_extern_macros {
612                 return None;
613             }
614             let is_macro = |def| {
615                 if let Def::Macro(_, def_kind) = def {
616                     def_kind == kind
617                 } else {
618                     false
619                 }
620             };
621             let ident = Ident::from_str(name);
622             self.lookup_typo_candidate(&vec![ident], MacroNS, is_macro)
623         });
624
625         if let Some(suggestion) = suggestion {
626             if suggestion != name {
627                 if let MacroKind::Bang = kind {
628                     err.help(&format!("did you mean `{}!`?", suggestion));
629                 } else {
630                     err.help(&format!("did you mean `{}`?", suggestion));
631                 }
632             } else {
633                 err.help(&format!("have you added the `#[macro_use]` on the module/import?"));
634             }
635         }
636     }
637
638     fn collect_def_ids(&mut self, invocation: &'a InvocationData<'a>, expansion: &Expansion) {
639         let Resolver { ref mut invocations, arenas, graph_root, .. } = *self;
640         let InvocationData { def_index, const_expr, .. } = *invocation;
641
642         let visit_macro_invoc = &mut |invoc: map::MacroInvocationData| {
643             invocations.entry(invoc.mark).or_insert_with(|| {
644                 arenas.alloc_invocation_data(InvocationData {
645                     def_index: invoc.def_index,
646                     const_expr: invoc.const_expr,
647                     module: Cell::new(graph_root),
648                     expansion: Cell::new(LegacyScope::Empty),
649                     legacy_scope: Cell::new(LegacyScope::Empty),
650                 })
651             });
652         };
653
654         let mut def_collector = DefCollector::new(&mut self.definitions);
655         def_collector.visit_macro_invoc = Some(visit_macro_invoc);
656         def_collector.with_parent(def_index, |def_collector| {
657             if const_expr {
658                 if let Expansion::Expr(ref expr) = *expansion {
659                     def_collector.visit_const_expr(expr);
660                 }
661             }
662             expansion.visit_with(def_collector)
663         });
664     }
665
666     pub fn define_macro(&mut self, item: &ast::Item, legacy_scope: &mut LegacyScope<'a>) {
667         self.local_macro_def_scopes.insert(item.id, self.current_module);
668         let ident = item.ident;
669         if ident.name == "macro_rules" {
670             self.session.span_err(item.span, "user-defined macros may not be named `macro_rules`");
671         }
672
673         let def_id = self.definitions.local_def_id(item.id);
674         let ext = Rc::new(macro_rules::compile(&self.session.parse_sess,
675                                                &self.session.features,
676                                                item));
677         self.macro_map.insert(def_id, ext);
678         *legacy_scope = LegacyScope::Binding(self.arenas.alloc_legacy_binding(LegacyBinding {
679             parent: Cell::new(*legacy_scope), name: ident.name, def_id: def_id, span: item.span,
680         }));
681         self.macro_names.insert(ident.name);
682
683         if attr::contains_name(&item.attrs, "macro_export") {
684             let def = Def::Macro(def_id, MacroKind::Bang);
685             self.macro_exports.push(Export { name: ident.name, def: def, span: item.span });
686         }
687     }
688
689     /// Error if `ext` is a Macros 1.1 procedural macro being imported by `#[macro_use]`
690     fn err_if_macro_use_proc_macro(&mut self, name: Name, use_span: Span,
691                                    binding: &NameBinding<'a>) {
692         use self::SyntaxExtension::*;
693
694         let krate = binding.def().def_id().krate;
695
696         // Plugin-based syntax extensions are exempt from this check
697         if krate == BUILTIN_MACROS_CRATE { return; }
698
699         let ext = binding.get_macro(self);
700
701         match *ext {
702             // If `ext` is a procedural macro, check if we've already warned about it
703             AttrProcMacro(_) | ProcMacro(_) => if !self.warned_proc_macros.insert(name) { return; },
704             _ => return,
705         }
706
707         let warn_msg = match *ext {
708             AttrProcMacro(_) => "attribute procedural macros cannot be \
709                                  imported with `#[macro_use]`",
710             ProcMacro(_) => "procedural macros cannot be imported with `#[macro_use]`",
711             _ => return,
712         };
713
714         let crate_name = self.session.cstore.crate_name(krate);
715
716         self.session.struct_span_err(use_span, warn_msg)
717             .help(&format!("instead, import the procedural macro like any other item: \
718                              `use {}::{};`", crate_name, name))
719             .emit();
720     }
721
722     fn gate_legacy_custom_derive(&mut self, name: Symbol, span: Span) {
723         if !self.session.features.borrow().custom_derive {
724             let sess = &self.session.parse_sess;
725             let explain = feature_gate::EXPLAIN_CUSTOM_DERIVE;
726             emit_feature_err(sess, "custom_derive", span, GateIssue::Language, explain);
727         } else if !self.is_whitelisted_legacy_custom_derive(name) {
728             self.session.span_warn(span, feature_gate::EXPLAIN_DEPR_CUSTOM_DERIVE);
729         }
730     }
731 }