1 // Copyright 2012-2015 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 #![doc(html_logo_url = "https://www.rust-lang.org/logos/rust-logo-128x128-blk-v2.png",
12 html_favicon_url = "https://doc.rust-lang.org/favicon.ico",
13 html_root_url = "https://doc.rust-lang.org/nightly/")]
15 #![feature(crate_visibility_modifier)]
17 #![feature(rustc_diagnostic_macros)]
18 #![feature(slice_sort_by_cached_key)]
21 extern crate bitflags;
26 extern crate syntax_pos;
27 extern crate rustc_errors as errors;
31 extern crate rustc_data_structures;
32 extern crate rustc_metadata;
34 pub use rustc::hir::def::{Namespace, PerNS};
36 use self::TypeParameters::*;
39 use rustc::hir::map::{Definitions, DefCollector};
40 use rustc::hir::{self, PrimTy, Bool, Char, Float, Int, Uint, Str};
41 use rustc::middle::cstore::CrateStore;
42 use rustc::session::Session;
44 use rustc::hir::def::*;
45 use rustc::hir::def::Namespace::*;
46 use rustc::hir::def_id::{CRATE_DEF_INDEX, LOCAL_CRATE, DefId};
47 use rustc::hir::{Freevar, FreevarMap, TraitCandidate, TraitMap, GlobMap};
48 use rustc::session::config::nightly_options;
50 use rustc::util::nodemap::{NodeMap, NodeSet, FxHashMap, FxHashSet, DefIdMap};
52 use rustc_metadata::creader::CrateLoader;
53 use rustc_metadata::cstore::CStore;
55 use syntax::source_map::SourceMap;
56 use syntax::ext::hygiene::{Mark, Transparency, SyntaxContext};
57 use syntax::ast::{self, Name, NodeId, Ident, FloatTy, IntTy, UintTy};
58 use syntax::ext::base::SyntaxExtension;
59 use syntax::ext::base::Determinacy::{self, Determined, Undetermined};
60 use syntax::ext::base::MacroKind;
61 use syntax::symbol::{Symbol, keywords};
62 use syntax::util::lev_distance::find_best_match_for_name;
64 use syntax::visit::{self, FnKind, Visitor};
66 use syntax::ast::{CRATE_NODE_ID, Arm, IsAsync, BindingMode, Block, Crate, Expr, ExprKind};
67 use syntax::ast::{FnDecl, ForeignItem, ForeignItemKind, GenericParamKind, Generics};
68 use syntax::ast::{Item, ItemKind, ImplItem, ImplItemKind};
69 use syntax::ast::{Label, Local, Mutability, Pat, PatKind, Path};
70 use syntax::ast::{QSelf, TraitItemKind, TraitRef, Ty, TyKind};
73 use syntax_pos::{Span, DUMMY_SP, MultiSpan};
74 use errors::{Applicability, DiagnosticBuilder, DiagnosticId};
76 use std::cell::{Cell, RefCell};
77 use std::{cmp, fmt, iter, ptr};
78 use std::collections::BTreeSet;
79 use std::mem::replace;
80 use rustc_data_structures::ptr_key::PtrKey;
81 use rustc_data_structures::sync::Lrc;
83 use resolve_imports::{ImportDirective, ImportDirectiveSubclass, NameResolution, ImportResolver};
84 use macros::{InvocationData, LegacyBinding, ParentScope};
86 // NB: This module needs to be declared first so diagnostics are
87 // registered before they are used.
92 mod build_reduced_graph;
95 fn is_known_tool(name: Name) -> bool {
96 ["clippy", "rustfmt"].contains(&&*name.as_str())
99 /// A free importable items suggested in case of resolution failure.
100 struct ImportSuggestion {
104 /// A field or associated item from self type suggested in case of resolution failure.
105 enum AssocSuggestion {
112 struct BindingError {
114 origin: BTreeSet<Span>,
115 target: BTreeSet<Span>,
118 impl PartialOrd for BindingError {
119 fn partial_cmp(&self, other: &BindingError) -> Option<cmp::Ordering> {
120 Some(self.cmp(other))
124 impl PartialEq for BindingError {
125 fn eq(&self, other: &BindingError) -> bool {
126 self.name == other.name
130 impl Ord for BindingError {
131 fn cmp(&self, other: &BindingError) -> cmp::Ordering {
132 self.name.cmp(&other.name)
136 enum ResolutionError<'a> {
137 /// error E0401: can't use type parameters from outer function
138 TypeParametersFromOuterFunction(Def),
139 /// error E0403: the name is already used for a type parameter in this type parameter list
140 NameAlreadyUsedInTypeParameterList(Name, &'a Span),
141 /// error E0407: method is not a member of trait
142 MethodNotMemberOfTrait(Name, &'a str),
143 /// error E0437: type is not a member of trait
144 TypeNotMemberOfTrait(Name, &'a str),
145 /// error E0438: const is not a member of trait
146 ConstNotMemberOfTrait(Name, &'a str),
147 /// error E0408: variable `{}` is not bound in all patterns
148 VariableNotBoundInPattern(&'a BindingError),
149 /// error E0409: variable `{}` is bound in inconsistent ways within the same match arm
150 VariableBoundWithDifferentMode(Name, Span),
151 /// error E0415: identifier is bound more than once in this parameter list
152 IdentifierBoundMoreThanOnceInParameterList(&'a str),
153 /// error E0416: identifier is bound more than once in the same pattern
154 IdentifierBoundMoreThanOnceInSamePattern(&'a str),
155 /// error E0426: use of undeclared label
156 UndeclaredLabel(&'a str, Option<Name>),
157 /// error E0429: `self` imports are only allowed within a { } list
158 SelfImportsOnlyAllowedWithin,
159 /// error E0430: `self` import can only appear once in the list
160 SelfImportCanOnlyAppearOnceInTheList,
161 /// error E0431: `self` import can only appear in an import list with a non-empty prefix
162 SelfImportOnlyInImportListWithNonEmptyPrefix,
163 /// error E0433: failed to resolve
164 FailedToResolve(&'a str),
165 /// error E0434: can't capture dynamic environment in a fn item
166 CannotCaptureDynamicEnvironmentInFnItem,
167 /// error E0435: attempt to use a non-constant value in a constant
168 AttemptToUseNonConstantValueInConstant,
169 /// error E0530: X bindings cannot shadow Ys
170 BindingShadowsSomethingUnacceptable(&'a str, Name, &'a NameBinding<'a>),
171 /// error E0128: type parameters with a default cannot use forward declared identifiers
172 ForwardDeclaredTyParam,
175 /// Combines an error with provided span and emits it
177 /// This takes the error provided, combines it with the span and any additional spans inside the
178 /// error and emits it.
179 fn resolve_error<'sess, 'a>(resolver: &'sess Resolver,
181 resolution_error: ResolutionError<'a>) {
182 resolve_struct_error(resolver, span, resolution_error).emit();
185 fn resolve_struct_error<'sess, 'a>(resolver: &'sess Resolver,
187 resolution_error: ResolutionError<'a>)
188 -> DiagnosticBuilder<'sess> {
189 match resolution_error {
190 ResolutionError::TypeParametersFromOuterFunction(outer_def) => {
191 let mut err = struct_span_err!(resolver.session,
194 "can't use type parameters from outer function");
195 err.span_label(span, "use of type variable from outer function");
197 let cm = resolver.session.source_map();
199 Def::SelfTy(maybe_trait_defid, maybe_impl_defid) => {
200 if let Some(impl_span) = maybe_impl_defid.and_then(|def_id| {
201 resolver.definitions.opt_span(def_id)
204 reduce_impl_span_to_impl_keyword(cm, impl_span),
205 "`Self` type implicitly declared here, by this `impl`",
208 match (maybe_trait_defid, maybe_impl_defid) {
210 err.span_label(span, "can't use `Self` here");
213 err.span_label(span, "use a type here instead");
215 (None, None) => bug!("`impl` without trait nor type?"),
219 Def::TyParam(typaram_defid) => {
220 if let Some(typaram_span) = resolver.definitions.opt_span(typaram_defid) {
221 err.span_label(typaram_span, "type variable from outer function");
225 bug!("TypeParametersFromOuterFunction should only be used with Def::SelfTy or \
230 // Try to retrieve the span of the function signature and generate a new message with
231 // a local type parameter
232 let sugg_msg = "try using a local type parameter instead";
233 if let Some((sugg_span, new_snippet)) = cm.generate_local_type_param_snippet(span) {
234 // Suggest the modification to the user
235 err.span_suggestion_with_applicability(
239 Applicability::MachineApplicable,
241 } else if let Some(sp) = cm.generate_fn_name_span(span) {
242 err.span_label(sp, "try adding a local type parameter in this method instead");
244 err.help("try using a local type parameter instead");
249 ResolutionError::NameAlreadyUsedInTypeParameterList(name, first_use_span) => {
250 let mut err = struct_span_err!(resolver.session,
253 "the name `{}` is already used for a type parameter \
254 in this type parameter list",
256 err.span_label(span, "already used");
257 err.span_label(first_use_span.clone(), format!("first use of `{}`", name));
260 ResolutionError::MethodNotMemberOfTrait(method, trait_) => {
261 let mut err = struct_span_err!(resolver.session,
264 "method `{}` is not a member of trait `{}`",
267 err.span_label(span, format!("not a member of trait `{}`", trait_));
270 ResolutionError::TypeNotMemberOfTrait(type_, trait_) => {
271 let mut err = struct_span_err!(resolver.session,
274 "type `{}` is not a member of trait `{}`",
277 err.span_label(span, format!("not a member of trait `{}`", trait_));
280 ResolutionError::ConstNotMemberOfTrait(const_, trait_) => {
281 let mut err = struct_span_err!(resolver.session,
284 "const `{}` is not a member of trait `{}`",
287 err.span_label(span, format!("not a member of trait `{}`", trait_));
290 ResolutionError::VariableNotBoundInPattern(binding_error) => {
291 let target_sp = binding_error.target.iter().cloned().collect::<Vec<_>>();
292 let msp = MultiSpan::from_spans(target_sp.clone());
293 let msg = format!("variable `{}` is not bound in all patterns", binding_error.name);
294 let mut err = resolver.session.struct_span_err_with_code(
297 DiagnosticId::Error("E0408".into()),
299 for sp in target_sp {
300 err.span_label(sp, format!("pattern doesn't bind `{}`", binding_error.name));
302 let origin_sp = binding_error.origin.iter().cloned();
303 for sp in origin_sp {
304 err.span_label(sp, "variable not in all patterns");
308 ResolutionError::VariableBoundWithDifferentMode(variable_name,
309 first_binding_span) => {
310 let mut err = struct_span_err!(resolver.session,
313 "variable `{}` is bound in inconsistent \
314 ways within the same match arm",
316 err.span_label(span, "bound in different ways");
317 err.span_label(first_binding_span, "first binding");
320 ResolutionError::IdentifierBoundMoreThanOnceInParameterList(identifier) => {
321 let mut err = struct_span_err!(resolver.session,
324 "identifier `{}` is bound more than once in this parameter list",
326 err.span_label(span, "used as parameter more than once");
329 ResolutionError::IdentifierBoundMoreThanOnceInSamePattern(identifier) => {
330 let mut err = struct_span_err!(resolver.session,
333 "identifier `{}` is bound more than once in the same pattern",
335 err.span_label(span, "used in a pattern more than once");
338 ResolutionError::UndeclaredLabel(name, lev_candidate) => {
339 let mut err = struct_span_err!(resolver.session,
342 "use of undeclared label `{}`",
344 if let Some(lev_candidate) = lev_candidate {
345 err.span_label(span, format!("did you mean `{}`?", lev_candidate));
347 err.span_label(span, format!("undeclared label `{}`", name));
351 ResolutionError::SelfImportsOnlyAllowedWithin => {
352 struct_span_err!(resolver.session,
356 "`self` imports are only allowed within a { } list")
358 ResolutionError::SelfImportCanOnlyAppearOnceInTheList => {
359 let mut err = struct_span_err!(resolver.session, span, E0430,
360 "`self` import can only appear once in an import list");
361 err.span_label(span, "can only appear once in an import list");
364 ResolutionError::SelfImportOnlyInImportListWithNonEmptyPrefix => {
365 let mut err = struct_span_err!(resolver.session, span, E0431,
366 "`self` import can only appear in an import list with \
367 a non-empty prefix");
368 err.span_label(span, "can only appear in an import list with a non-empty prefix");
371 ResolutionError::FailedToResolve(msg) => {
372 let mut err = struct_span_err!(resolver.session, span, E0433,
373 "failed to resolve. {}", msg);
374 err.span_label(span, msg);
377 ResolutionError::CannotCaptureDynamicEnvironmentInFnItem => {
378 let mut err = struct_span_err!(resolver.session,
382 "can't capture dynamic environment in a fn item");
383 err.help("use the `|| { ... }` closure form instead");
386 ResolutionError::AttemptToUseNonConstantValueInConstant => {
387 let mut err = struct_span_err!(resolver.session, span, E0435,
388 "attempt to use a non-constant value in a constant");
389 err.span_label(span, "non-constant value");
392 ResolutionError::BindingShadowsSomethingUnacceptable(what_binding, name, binding) => {
393 let shadows_what = PathResolution::new(binding.def()).kind_name();
394 let mut err = struct_span_err!(resolver.session,
397 "{}s cannot shadow {}s", what_binding, shadows_what);
398 err.span_label(span, format!("cannot be named the same as a {}", shadows_what));
399 let participle = if binding.is_import() { "imported" } else { "defined" };
400 let msg = format!("a {} `{}` is {} here", shadows_what, name, participle);
401 err.span_label(binding.span, msg);
404 ResolutionError::ForwardDeclaredTyParam => {
405 let mut err = struct_span_err!(resolver.session, span, E0128,
406 "type parameters with a default cannot use \
407 forward declared identifiers");
409 span, "defaulted type parameters cannot be forward declared".to_string());
415 /// Adjust the impl span so that just the `impl` keyword is taken by removing
416 /// everything after `<` (`"impl<T> Iterator for A<T> {}" -> "impl"`) and
417 /// everything after the first whitespace (`"impl Iterator for A" -> "impl"`)
419 /// Attention: The method used is very fragile since it essentially duplicates the work of the
420 /// parser. If you need to use this function or something similar, please consider updating the
421 /// source_map functions and this function to something more robust.
422 fn reduce_impl_span_to_impl_keyword(cm: &SourceMap, impl_span: Span) -> Span {
423 let impl_span = cm.span_until_char(impl_span, '<');
424 let impl_span = cm.span_until_whitespace(impl_span);
428 #[derive(Copy, Clone, Debug)]
431 binding_mode: BindingMode,
434 /// Map from the name in a pattern to its binding mode.
435 type BindingMap = FxHashMap<Ident, BindingInfo>;
437 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
448 fn descr(self) -> &'static str {
450 PatternSource::Match => "match binding",
451 PatternSource::IfLet => "if let binding",
452 PatternSource::WhileLet => "while let binding",
453 PatternSource::Let => "let binding",
454 PatternSource::For => "for binding",
455 PatternSource::FnParam => "function parameter",
460 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
461 enum AliasPossibility {
466 #[derive(Copy, Clone, Debug)]
467 enum PathSource<'a> {
468 // Type paths `Path`.
470 // Trait paths in bounds or impls.
471 Trait(AliasPossibility),
472 // Expression paths `path`, with optional parent context.
473 Expr(Option<&'a Expr>),
474 // Paths in path patterns `Path`.
476 // Paths in struct expressions and patterns `Path { .. }`.
478 // Paths in tuple struct patterns `Path(..)`.
480 // `m::A::B` in `<T as m::A>::B::C`.
481 TraitItem(Namespace),
482 // Path in `pub(path)`
484 // Path in `use a::b::{...};`
488 impl<'a> PathSource<'a> {
489 fn namespace(self) -> Namespace {
491 PathSource::Type | PathSource::Trait(_) | PathSource::Struct |
492 PathSource::Visibility | PathSource::ImportPrefix => TypeNS,
493 PathSource::Expr(..) | PathSource::Pat | PathSource::TupleStruct => ValueNS,
494 PathSource::TraitItem(ns) => ns,
498 fn global_by_default(self) -> bool {
500 PathSource::Visibility | PathSource::ImportPrefix => true,
501 PathSource::Type | PathSource::Expr(..) | PathSource::Pat |
502 PathSource::Struct | PathSource::TupleStruct |
503 PathSource::Trait(_) | PathSource::TraitItem(..) => false,
507 fn defer_to_typeck(self) -> bool {
509 PathSource::Type | PathSource::Expr(..) | PathSource::Pat |
510 PathSource::Struct | PathSource::TupleStruct => true,
511 PathSource::Trait(_) | PathSource::TraitItem(..) |
512 PathSource::Visibility | PathSource::ImportPrefix => false,
516 fn descr_expected(self) -> &'static str {
518 PathSource::Type => "type",
519 PathSource::Trait(_) => "trait",
520 PathSource::Pat => "unit struct/variant or constant",
521 PathSource::Struct => "struct, variant or union type",
522 PathSource::TupleStruct => "tuple struct/variant",
523 PathSource::Visibility => "module",
524 PathSource::ImportPrefix => "module or enum",
525 PathSource::TraitItem(ns) => match ns {
526 TypeNS => "associated type",
527 ValueNS => "method or associated constant",
528 MacroNS => bug!("associated macro"),
530 PathSource::Expr(parent) => match parent.map(|p| &p.node) {
531 // "function" here means "anything callable" rather than `Def::Fn`,
532 // this is not precise but usually more helpful than just "value".
533 Some(&ExprKind::Call(..)) => "function",
539 fn is_expected(self, def: Def) -> bool {
541 PathSource::Type => match def {
542 Def::Struct(..) | Def::Union(..) | Def::Enum(..) |
543 Def::Trait(..) | Def::TyAlias(..) | Def::AssociatedTy(..) |
544 Def::PrimTy(..) | Def::TyParam(..) | Def::SelfTy(..) |
545 Def::Existential(..) |
546 Def::ForeignTy(..) => true,
549 PathSource::Trait(AliasPossibility::No) => match def {
550 Def::Trait(..) => true,
553 PathSource::Trait(AliasPossibility::Maybe) => match def {
554 Def::Trait(..) => true,
555 Def::TraitAlias(..) => true,
558 PathSource::Expr(..) => match def {
559 Def::StructCtor(_, CtorKind::Const) | Def::StructCtor(_, CtorKind::Fn) |
560 Def::VariantCtor(_, CtorKind::Const) | Def::VariantCtor(_, CtorKind::Fn) |
561 Def::Const(..) | Def::Static(..) | Def::Local(..) | Def::Upvar(..) |
562 Def::Fn(..) | Def::Method(..) | Def::AssociatedConst(..) |
563 Def::SelfCtor(..) => true,
566 PathSource::Pat => match def {
567 Def::StructCtor(_, CtorKind::Const) |
568 Def::VariantCtor(_, CtorKind::Const) |
569 Def::Const(..) | Def::AssociatedConst(..) |
570 Def::SelfCtor(..) => true,
573 PathSource::TupleStruct => match def {
574 Def::StructCtor(_, CtorKind::Fn) |
575 Def::VariantCtor(_, CtorKind::Fn) |
576 Def::SelfCtor(..) => true,
579 PathSource::Struct => match def {
580 Def::Struct(..) | Def::Union(..) | Def::Variant(..) |
581 Def::TyAlias(..) | Def::AssociatedTy(..) | Def::SelfTy(..) => true,
584 PathSource::TraitItem(ns) => match def {
585 Def::AssociatedConst(..) | Def::Method(..) if ns == ValueNS => true,
586 Def::AssociatedTy(..) if ns == TypeNS => true,
589 PathSource::ImportPrefix => match def {
590 Def::Mod(..) | Def::Enum(..) => true,
593 PathSource::Visibility => match def {
594 Def::Mod(..) => true,
600 fn error_code(self, has_unexpected_resolution: bool) -> &'static str {
601 __diagnostic_used!(E0404);
602 __diagnostic_used!(E0405);
603 __diagnostic_used!(E0412);
604 __diagnostic_used!(E0422);
605 __diagnostic_used!(E0423);
606 __diagnostic_used!(E0425);
607 __diagnostic_used!(E0531);
608 __diagnostic_used!(E0532);
609 __diagnostic_used!(E0573);
610 __diagnostic_used!(E0574);
611 __diagnostic_used!(E0575);
612 __diagnostic_used!(E0576);
613 __diagnostic_used!(E0577);
614 __diagnostic_used!(E0578);
615 match (self, has_unexpected_resolution) {
616 (PathSource::Trait(_), true) => "E0404",
617 (PathSource::Trait(_), false) => "E0405",
618 (PathSource::Type, true) => "E0573",
619 (PathSource::Type, false) => "E0412",
620 (PathSource::Struct, true) => "E0574",
621 (PathSource::Struct, false) => "E0422",
622 (PathSource::Expr(..), true) => "E0423",
623 (PathSource::Expr(..), false) => "E0425",
624 (PathSource::Pat, true) | (PathSource::TupleStruct, true) => "E0532",
625 (PathSource::Pat, false) | (PathSource::TupleStruct, false) => "E0531",
626 (PathSource::TraitItem(..), true) => "E0575",
627 (PathSource::TraitItem(..), false) => "E0576",
628 (PathSource::Visibility, true) | (PathSource::ImportPrefix, true) => "E0577",
629 (PathSource::Visibility, false) | (PathSource::ImportPrefix, false) => "E0578",
634 struct UsePlacementFinder {
635 target_module: NodeId,
640 impl UsePlacementFinder {
641 fn check(krate: &Crate, target_module: NodeId) -> (Option<Span>, bool) {
642 let mut finder = UsePlacementFinder {
647 visit::walk_crate(&mut finder, krate);
648 (finder.span, finder.found_use)
652 impl<'tcx> Visitor<'tcx> for UsePlacementFinder {
655 module: &'tcx ast::Mod,
657 _: &[ast::Attribute],
660 if self.span.is_some() {
663 if node_id != self.target_module {
664 visit::walk_mod(self, module);
667 // find a use statement
668 for item in &module.items {
670 ItemKind::Use(..) => {
671 // don't suggest placing a use before the prelude
672 // import or other generated ones
673 if item.span.ctxt().outer().expn_info().is_none() {
674 self.span = Some(item.span.shrink_to_lo());
675 self.found_use = true;
679 // don't place use before extern crate
680 ItemKind::ExternCrate(_) => {}
681 // but place them before the first other item
682 _ => if self.span.map_or(true, |span| item.span < span ) {
683 if item.span.ctxt().outer().expn_info().is_none() {
684 // don't insert between attributes and an item
685 if item.attrs.is_empty() {
686 self.span = Some(item.span.shrink_to_lo());
688 // find the first attribute on the item
689 for attr in &item.attrs {
690 if self.span.map_or(true, |span| attr.span < span) {
691 self.span = Some(attr.span.shrink_to_lo());
702 /// This thing walks the whole crate in DFS manner, visiting each item, resolving names as it goes.
703 impl<'a, 'tcx, 'cl> Visitor<'tcx> for Resolver<'a, 'cl> {
704 fn visit_item(&mut self, item: &'tcx Item) {
705 self.resolve_item(item);
707 fn visit_arm(&mut self, arm: &'tcx Arm) {
708 self.resolve_arm(arm);
710 fn visit_block(&mut self, block: &'tcx Block) {
711 self.resolve_block(block);
713 fn visit_anon_const(&mut self, constant: &'tcx ast::AnonConst) {
714 self.with_constant_rib(|this| {
715 visit::walk_anon_const(this, constant);
718 fn visit_expr(&mut self, expr: &'tcx Expr) {
719 self.resolve_expr(expr, None);
721 fn visit_local(&mut self, local: &'tcx Local) {
722 self.resolve_local(local);
724 fn visit_ty(&mut self, ty: &'tcx Ty) {
726 TyKind::Path(ref qself, ref path) => {
727 self.smart_resolve_path(ty.id, qself.as_ref(), path, PathSource::Type);
729 TyKind::ImplicitSelf => {
730 let self_ty = keywords::SelfType.ident();
731 let def = self.resolve_ident_in_lexical_scope(self_ty, TypeNS, Some(ty.id), ty.span)
732 .map_or(Def::Err, |d| d.def());
733 self.record_def(ty.id, PathResolution::new(def));
737 visit::walk_ty(self, ty);
739 fn visit_poly_trait_ref(&mut self,
740 tref: &'tcx ast::PolyTraitRef,
741 m: &'tcx ast::TraitBoundModifier) {
742 self.smart_resolve_path(tref.trait_ref.ref_id, None,
743 &tref.trait_ref.path, PathSource::Trait(AliasPossibility::Maybe));
744 visit::walk_poly_trait_ref(self, tref, m);
746 fn visit_foreign_item(&mut self, foreign_item: &'tcx ForeignItem) {
747 let type_parameters = match foreign_item.node {
748 ForeignItemKind::Fn(_, ref generics) => {
749 HasTypeParameters(generics, ItemRibKind)
751 ForeignItemKind::Static(..) => NoTypeParameters,
752 ForeignItemKind::Ty => NoTypeParameters,
753 ForeignItemKind::Macro(..) => NoTypeParameters,
755 self.with_type_parameter_rib(type_parameters, |this| {
756 visit::walk_foreign_item(this, foreign_item);
759 fn visit_fn(&mut self,
760 function_kind: FnKind<'tcx>,
761 declaration: &'tcx FnDecl,
765 let (rib_kind, asyncness) = match function_kind {
766 FnKind::ItemFn(_, ref header, ..) =>
767 (ItemRibKind, header.asyncness),
768 FnKind::Method(_, ref sig, _, _) =>
769 (TraitOrImplItemRibKind, sig.header.asyncness),
770 FnKind::Closure(_) =>
771 // Async closures aren't resolved through `visit_fn`-- they're
772 // processed separately
773 (ClosureRibKind(node_id), IsAsync::NotAsync),
776 // Create a value rib for the function.
777 self.ribs[ValueNS].push(Rib::new(rib_kind));
779 // Create a label rib for the function.
780 self.label_ribs.push(Rib::new(rib_kind));
782 // Add each argument to the rib.
783 let mut bindings_list = FxHashMap();
784 for argument in &declaration.inputs {
785 self.resolve_pattern(&argument.pat, PatternSource::FnParam, &mut bindings_list);
787 self.visit_ty(&argument.ty);
789 debug!("(resolving function) recorded argument");
791 visit::walk_fn_ret_ty(self, &declaration.output);
793 // Resolve the function body, potentially inside the body of an async closure
794 if let IsAsync::Async { closure_id, .. } = asyncness {
795 let rib_kind = ClosureRibKind(closure_id);
796 self.ribs[ValueNS].push(Rib::new(rib_kind));
797 self.label_ribs.push(Rib::new(rib_kind));
800 match function_kind {
801 FnKind::ItemFn(.., body) |
802 FnKind::Method(.., body) => {
803 self.visit_block(body);
805 FnKind::Closure(body) => {
806 self.visit_expr(body);
810 // Leave the body of the async closure
811 if asyncness.is_async() {
812 self.label_ribs.pop();
813 self.ribs[ValueNS].pop();
816 debug!("(resolving function) leaving function");
818 self.label_ribs.pop();
819 self.ribs[ValueNS].pop();
821 fn visit_generics(&mut self, generics: &'tcx Generics) {
822 // For type parameter defaults, we have to ban access
823 // to following type parameters, as the Substs can only
824 // provide previous type parameters as they're built. We
825 // put all the parameters on the ban list and then remove
826 // them one by one as they are processed and become available.
827 let mut default_ban_rib = Rib::new(ForwardTyParamBanRibKind);
828 let mut found_default = false;
829 default_ban_rib.bindings.extend(generics.params.iter()
830 .filter_map(|param| match param.kind {
831 GenericParamKind::Lifetime { .. } => None,
832 GenericParamKind::Type { ref default, .. } => {
833 found_default |= default.is_some();
835 Some((Ident::with_empty_ctxt(param.ident.name), Def::Err))
842 for param in &generics.params {
844 GenericParamKind::Lifetime { .. } => self.visit_generic_param(param),
845 GenericParamKind::Type { ref default, .. } => {
846 for bound in ¶m.bounds {
847 self.visit_param_bound(bound);
850 if let Some(ref ty) = default {
851 self.ribs[TypeNS].push(default_ban_rib);
853 default_ban_rib = self.ribs[TypeNS].pop().unwrap();
856 // Allow all following defaults to refer to this type parameter.
857 default_ban_rib.bindings.remove(&Ident::with_empty_ctxt(param.ident.name));
861 for p in &generics.where_clause.predicates {
862 self.visit_where_predicate(p);
867 #[derive(Copy, Clone)]
868 enum TypeParameters<'a, 'b> {
870 HasTypeParameters(// Type parameters.
873 // The kind of the rib used for type parameters.
877 /// The rib kind controls the translation of local
878 /// definitions (`Def::Local`) to upvars (`Def::Upvar`).
879 #[derive(Copy, Clone, Debug)]
881 /// No translation needs to be applied.
884 /// We passed through a closure scope at the given node ID.
885 /// Translate upvars as appropriate.
886 ClosureRibKind(NodeId /* func id */),
888 /// We passed through an impl or trait and are now in one of its
889 /// methods or associated types. Allow references to ty params that impl or trait
890 /// binds. Disallow any other upvars (including other ty params that are
892 TraitOrImplItemRibKind,
894 /// We passed through an item scope. Disallow upvars.
897 /// We're in a constant item. Can't refer to dynamic stuff.
900 /// We passed through a module.
901 ModuleRibKind(Module<'a>),
903 /// We passed through a `macro_rules!` statement
904 MacroDefinition(DefId),
906 /// All bindings in this rib are type parameters that can't be used
907 /// from the default of a type parameter because they're not declared
908 /// before said type parameter. Also see the `visit_generics` override.
909 ForwardTyParamBanRibKind,
914 /// A rib represents a scope names can live in. Note that these appear in many places, not just
915 /// around braces. At any place where the list of accessible names (of the given namespace)
916 /// changes or a new restrictions on the name accessibility are introduced, a new rib is put onto a
917 /// stack. This may be, for example, a `let` statement (because it introduces variables), a macro,
920 /// Different [rib kinds](enum.RibKind) are transparent for different names.
922 /// The resolution keeps a separate stack of ribs as it traverses the AST for each namespace. When
923 /// resolving, the name is looked up from inside out.
926 bindings: FxHashMap<Ident, Def>,
931 fn new(kind: RibKind<'a>) -> Rib<'a> {
933 bindings: FxHashMap(),
939 /// An intermediate resolution result.
941 /// This refers to the thing referred by a name. The difference between `Def` and `Item` is that
942 /// items are visible in their whole block, while defs only from the place they are defined
944 enum LexicalScopeBinding<'a> {
945 Item(&'a NameBinding<'a>),
949 impl<'a> LexicalScopeBinding<'a> {
950 fn item(self) -> Option<&'a NameBinding<'a>> {
952 LexicalScopeBinding::Item(binding) => Some(binding),
957 fn def(self) -> Def {
959 LexicalScopeBinding::Item(binding) => binding.def(),
960 LexicalScopeBinding::Def(def) => def,
965 #[derive(Copy, Clone, Debug)]
966 pub enum ModuleOrUniformRoot<'a> {
970 /// The `{{root}}` (`CrateRoot` aka "global") / `extern` initial segment
971 /// in which external crates resolve, and also `crate` (only in `{{root}}`,
972 /// but *not* `extern`), in the Rust 2018 edition.
976 #[derive(Clone, Debug)]
977 enum PathResult<'a> {
978 Module(ModuleOrUniformRoot<'a>),
979 NonModule(PathResolution),
981 Failed(Span, String, bool /* is the error from the last segment? */),
985 /// An anonymous module, eg. just a block.
990 /// { // This is an anonymous module
991 /// f(); // This resolves to (2) as we are inside the block.
994 /// f(); // Resolves to (1)
998 /// Any module with a name.
1002 /// * A normal module ‒ either `mod from_file;` or `mod from_block { }`.
1003 /// * A trait or an enum (it implicitly contains associated types, methods and variant
1008 /// One node in the tree of modules.
1009 pub struct ModuleData<'a> {
1010 parent: Option<Module<'a>>,
1013 // The def id of the closest normal module (`mod`) ancestor (including this module).
1014 normal_ancestor_id: DefId,
1016 resolutions: RefCell<FxHashMap<(Ident, Namespace), &'a RefCell<NameResolution<'a>>>>,
1017 legacy_macro_resolutions: RefCell<Vec<(Ident, MacroKind, ParentScope<'a>,
1018 Option<&'a NameBinding<'a>>)>>,
1019 macro_resolutions: RefCell<Vec<(Box<[Ident]>, Span)>>,
1020 builtin_attrs: RefCell<Vec<(Ident, ParentScope<'a>)>>,
1022 // Macro invocations that can expand into items in this module.
1023 unresolved_invocations: RefCell<FxHashSet<Mark>>,
1025 no_implicit_prelude: bool,
1027 glob_importers: RefCell<Vec<&'a ImportDirective<'a>>>,
1028 globs: RefCell<Vec<&'a ImportDirective<'a>>>,
1030 // Used to memoize the traits in this module for faster searches through all traits in scope.
1031 traits: RefCell<Option<Box<[(Ident, &'a NameBinding<'a>)]>>>,
1033 // Whether this module is populated. If not populated, any attempt to
1034 // access the children must be preceded with a
1035 // `populate_module_if_necessary` call.
1036 populated: Cell<bool>,
1038 /// Span of the module itself. Used for error reporting.
1044 type Module<'a> = &'a ModuleData<'a>;
1046 impl<'a> ModuleData<'a> {
1047 fn new(parent: Option<Module<'a>>,
1049 normal_ancestor_id: DefId,
1051 span: Span) -> Self {
1056 resolutions: RefCell::new(FxHashMap()),
1057 legacy_macro_resolutions: RefCell::new(Vec::new()),
1058 macro_resolutions: RefCell::new(Vec::new()),
1059 builtin_attrs: RefCell::new(Vec::new()),
1060 unresolved_invocations: RefCell::new(FxHashSet()),
1061 no_implicit_prelude: false,
1062 glob_importers: RefCell::new(Vec::new()),
1063 globs: RefCell::new(Vec::new()),
1064 traits: RefCell::new(None),
1065 populated: Cell::new(normal_ancestor_id.is_local()),
1071 fn for_each_child<F: FnMut(Ident, Namespace, &'a NameBinding<'a>)>(&self, mut f: F) {
1072 for (&(ident, ns), name_resolution) in self.resolutions.borrow().iter() {
1073 name_resolution.borrow().binding.map(|binding| f(ident, ns, binding));
1077 fn for_each_child_stable<F: FnMut(Ident, Namespace, &'a NameBinding<'a>)>(&self, mut f: F) {
1078 let resolutions = self.resolutions.borrow();
1079 let mut resolutions = resolutions.iter().collect::<Vec<_>>();
1080 resolutions.sort_by_cached_key(|&(&(ident, ns), _)| (ident.as_str(), ns));
1081 for &(&(ident, ns), &resolution) in resolutions.iter() {
1082 resolution.borrow().binding.map(|binding| f(ident, ns, binding));
1086 fn def(&self) -> Option<Def> {
1088 ModuleKind::Def(def, _) => Some(def),
1093 fn def_id(&self) -> Option<DefId> {
1094 self.def().as_ref().map(Def::def_id)
1097 // `self` resolves to the first module ancestor that `is_normal`.
1098 fn is_normal(&self) -> bool {
1100 ModuleKind::Def(Def::Mod(_), _) => true,
1105 fn is_trait(&self) -> bool {
1107 ModuleKind::Def(Def::Trait(_), _) => true,
1112 fn is_local(&self) -> bool {
1113 self.normal_ancestor_id.is_local()
1116 fn nearest_item_scope(&'a self) -> Module<'a> {
1117 if self.is_trait() { self.parent.unwrap() } else { self }
1120 fn is_ancestor_of(&self, mut other: &Self) -> bool {
1121 while !ptr::eq(self, other) {
1122 if let Some(parent) = other.parent {
1132 impl<'a> fmt::Debug for ModuleData<'a> {
1133 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1134 write!(f, "{:?}", self.def())
1138 /// Records a possibly-private value, type, or module definition.
1139 #[derive(Clone, Debug)]
1140 pub struct NameBinding<'a> {
1141 kind: NameBindingKind<'a>,
1144 vis: ty::Visibility,
1147 pub trait ToNameBinding<'a> {
1148 fn to_name_binding(self, arenas: &'a ResolverArenas<'a>) -> &'a NameBinding<'a>;
1151 impl<'a> ToNameBinding<'a> for &'a NameBinding<'a> {
1152 fn to_name_binding(self, _: &'a ResolverArenas<'a>) -> &'a NameBinding<'a> {
1157 #[derive(Clone, Debug)]
1158 enum NameBindingKind<'a> {
1159 Def(Def, /* is_macro_export */ bool),
1162 binding: &'a NameBinding<'a>,
1163 directive: &'a ImportDirective<'a>,
1167 b1: &'a NameBinding<'a>,
1168 b2: &'a NameBinding<'a>,
1172 struct PrivacyError<'a>(Span, Name, &'a NameBinding<'a>);
1174 struct UseError<'a> {
1175 err: DiagnosticBuilder<'a>,
1176 /// Attach `use` statements for these candidates
1177 candidates: Vec<ImportSuggestion>,
1178 /// The node id of the module to place the use statements in
1180 /// Whether the diagnostic should state that it's "better"
1184 struct AmbiguityError<'a> {
1186 b1: &'a NameBinding<'a>,
1187 b2: &'a NameBinding<'a>,
1190 impl<'a> NameBinding<'a> {
1191 fn module(&self) -> Option<Module<'a>> {
1193 NameBindingKind::Module(module) => Some(module),
1194 NameBindingKind::Import { binding, .. } => binding.module(),
1199 fn def(&self) -> Def {
1201 NameBindingKind::Def(def, _) => def,
1202 NameBindingKind::Module(module) => module.def().unwrap(),
1203 NameBindingKind::Import { binding, .. } => binding.def(),
1204 NameBindingKind::Ambiguity { .. } => Def::Err,
1208 fn def_ignoring_ambiguity(&self) -> Def {
1210 NameBindingKind::Import { binding, .. } => binding.def_ignoring_ambiguity(),
1211 NameBindingKind::Ambiguity { b1, .. } => b1.def_ignoring_ambiguity(),
1216 // We sometimes need to treat variants as `pub` for backwards compatibility
1217 fn pseudo_vis(&self) -> ty::Visibility {
1218 if self.is_variant() && self.def().def_id().is_local() {
1219 ty::Visibility::Public
1225 fn is_variant(&self) -> bool {
1227 NameBindingKind::Def(Def::Variant(..), _) |
1228 NameBindingKind::Def(Def::VariantCtor(..), _) => true,
1233 fn is_extern_crate(&self) -> bool {
1235 NameBindingKind::Import {
1236 directive: &ImportDirective {
1237 subclass: ImportDirectiveSubclass::ExternCrate(_), ..
1244 fn is_import(&self) -> bool {
1246 NameBindingKind::Import { .. } => true,
1251 fn is_renamed_extern_crate(&self) -> bool {
1252 if let NameBindingKind::Import { directive, ..} = self.kind {
1253 if let ImportDirectiveSubclass::ExternCrate(Some(_)) = directive.subclass {
1260 fn is_glob_import(&self) -> bool {
1262 NameBindingKind::Import { directive, .. } => directive.is_glob(),
1263 NameBindingKind::Ambiguity { b1, .. } => b1.is_glob_import(),
1268 fn is_importable(&self) -> bool {
1270 Def::AssociatedConst(..) | Def::Method(..) | Def::AssociatedTy(..) => false,
1275 fn is_macro_def(&self) -> bool {
1277 NameBindingKind::Def(Def::Macro(..), _) => true,
1282 fn macro_kind(&self) -> Option<MacroKind> {
1283 match self.def_ignoring_ambiguity() {
1284 Def::Macro(_, kind) => Some(kind),
1285 Def::NonMacroAttr(..) => Some(MacroKind::Attr),
1290 fn descr(&self) -> &'static str {
1291 if self.is_extern_crate() { "extern crate" } else { self.def().kind_name() }
1294 // Suppose that we resolved macro invocation with `invoc_parent_expansion` to binding `binding`
1295 // at some expansion round `max(invoc, binding)` when they both emerged from macros.
1296 // Then this function returns `true` if `self` may emerge from a macro *after* that
1297 // in some later round and screw up our previously found resolution.
1298 // See more detailed explanation in
1299 // https://github.com/rust-lang/rust/pull/53778#issuecomment-419224049
1300 fn may_appear_after(&self, invoc_parent_expansion: Mark, binding: &NameBinding) -> bool {
1301 // self > max(invoc, binding) => !(self <= invoc || self <= binding)
1302 // Expansions are partially ordered, so "may appear after" is an inversion of
1303 // "certainly appears before or simultaneously" and includes unordered cases.
1304 let self_parent_expansion = self.expansion;
1305 let other_parent_expansion = binding.expansion;
1306 let certainly_before_other_or_simultaneously =
1307 other_parent_expansion.is_descendant_of(self_parent_expansion);
1308 let certainly_before_invoc_or_simultaneously =
1309 invoc_parent_expansion.is_descendant_of(self_parent_expansion);
1310 !(certainly_before_other_or_simultaneously || certainly_before_invoc_or_simultaneously)
1314 /// Interns the names of the primitive types.
1316 /// All other types are defined somewhere and possibly imported, but the primitive ones need
1317 /// special handling, since they have no place of origin.
1318 struct PrimitiveTypeTable {
1319 primitive_types: FxHashMap<Name, PrimTy>,
1322 impl PrimitiveTypeTable {
1323 fn new() -> PrimitiveTypeTable {
1324 let mut table = PrimitiveTypeTable { primitive_types: FxHashMap() };
1326 table.intern("bool", Bool);
1327 table.intern("char", Char);
1328 table.intern("f32", Float(FloatTy::F32));
1329 table.intern("f64", Float(FloatTy::F64));
1330 table.intern("isize", Int(IntTy::Isize));
1331 table.intern("i8", Int(IntTy::I8));
1332 table.intern("i16", Int(IntTy::I16));
1333 table.intern("i32", Int(IntTy::I32));
1334 table.intern("i64", Int(IntTy::I64));
1335 table.intern("i128", Int(IntTy::I128));
1336 table.intern("str", Str);
1337 table.intern("usize", Uint(UintTy::Usize));
1338 table.intern("u8", Uint(UintTy::U8));
1339 table.intern("u16", Uint(UintTy::U16));
1340 table.intern("u32", Uint(UintTy::U32));
1341 table.intern("u64", Uint(UintTy::U64));
1342 table.intern("u128", Uint(UintTy::U128));
1346 fn intern(&mut self, string: &str, primitive_type: PrimTy) {
1347 self.primitive_types.insert(Symbol::intern(string), primitive_type);
1351 /// The main resolver class.
1353 /// This is the visitor that walks the whole crate.
1354 pub struct Resolver<'a, 'b: 'a> {
1355 session: &'a Session,
1358 pub definitions: Definitions,
1360 graph_root: Module<'a>,
1362 prelude: Option<Module<'a>>,
1363 pub extern_prelude: FxHashSet<Name>,
1365 /// n.b. This is used only for better diagnostics, not name resolution itself.
1366 has_self: FxHashSet<DefId>,
1368 /// Names of fields of an item `DefId` accessible with dot syntax.
1369 /// Used for hints during error reporting.
1370 field_names: FxHashMap<DefId, Vec<Name>>,
1372 /// All imports known to succeed or fail.
1373 determined_imports: Vec<&'a ImportDirective<'a>>,
1375 /// All non-determined imports.
1376 indeterminate_imports: Vec<&'a ImportDirective<'a>>,
1378 /// The module that represents the current item scope.
1379 current_module: Module<'a>,
1381 /// The current set of local scopes for types and values.
1382 /// FIXME #4948: Reuse ribs to avoid allocation.
1383 ribs: PerNS<Vec<Rib<'a>>>,
1385 /// The current set of local scopes, for labels.
1386 label_ribs: Vec<Rib<'a>>,
1388 /// The trait that the current context can refer to.
1389 current_trait_ref: Option<(Module<'a>, TraitRef)>,
1391 /// The current self type if inside an impl (used for better errors).
1392 current_self_type: Option<Ty>,
1394 /// The current self item if inside an ADT (used for better errors).
1395 current_self_item: Option<NodeId>,
1397 /// The idents for the primitive types.
1398 primitive_type_table: PrimitiveTypeTable,
1401 import_map: ImportMap,
1402 pub freevars: FreevarMap,
1403 freevars_seen: NodeMap<NodeMap<usize>>,
1404 pub export_map: ExportMap,
1405 pub trait_map: TraitMap,
1407 /// A map from nodes to anonymous modules.
1408 /// Anonymous modules are pseudo-modules that are implicitly created around items
1409 /// contained within blocks.
1411 /// For example, if we have this:
1419 /// There will be an anonymous module created around `g` with the ID of the
1420 /// entry block for `f`.
1421 block_map: NodeMap<Module<'a>>,
1422 module_map: FxHashMap<DefId, Module<'a>>,
1423 extern_module_map: FxHashMap<(DefId, bool /* MacrosOnly? */), Module<'a>>,
1424 binding_parent_modules: FxHashMap<PtrKey<'a, NameBinding<'a>>, Module<'a>>,
1426 pub make_glob_map: bool,
1427 /// Maps imports to the names of items actually imported (this actually maps
1428 /// all imports, but only glob imports are actually interesting).
1429 pub glob_map: GlobMap,
1431 used_imports: FxHashSet<(NodeId, Namespace)>,
1432 pub maybe_unused_trait_imports: NodeSet,
1433 pub maybe_unused_extern_crates: Vec<(NodeId, Span)>,
1435 /// A list of labels as of yet unused. Labels will be removed from this map when
1436 /// they are used (in a `break` or `continue` statement)
1437 pub unused_labels: FxHashMap<NodeId, Span>,
1439 /// privacy errors are delayed until the end in order to deduplicate them
1440 privacy_errors: Vec<PrivacyError<'a>>,
1441 /// ambiguity errors are delayed for deduplication
1442 ambiguity_errors: Vec<AmbiguityError<'a>>,
1443 /// `use` injections are delayed for better placement and deduplication
1444 use_injections: Vec<UseError<'a>>,
1445 /// crate-local macro expanded `macro_export` referred to by a module-relative path
1446 macro_expanded_macro_export_errors: BTreeSet<(Span, Span)>,
1448 arenas: &'a ResolverArenas<'a>,
1449 dummy_binding: &'a NameBinding<'a>,
1451 crate_loader: &'a mut CrateLoader<'b>,
1452 macro_names: FxHashSet<Ident>,
1453 builtin_macros: FxHashMap<Name, &'a NameBinding<'a>>,
1454 macro_use_prelude: FxHashMap<Name, &'a NameBinding<'a>>,
1455 pub all_macros: FxHashMap<Name, Def>,
1456 macro_map: FxHashMap<DefId, Lrc<SyntaxExtension>>,
1457 macro_defs: FxHashMap<Mark, DefId>,
1458 local_macro_def_scopes: FxHashMap<NodeId, Module<'a>>,
1459 pub whitelisted_legacy_custom_derives: Vec<Name>,
1460 pub found_unresolved_macro: bool,
1462 /// List of crate local macros that we need to warn about as being unused.
1463 /// Right now this only includes macro_rules! macros, and macros 2.0.
1464 unused_macros: FxHashSet<DefId>,
1466 /// Maps the `Mark` of an expansion to its containing module or block.
1467 invocations: FxHashMap<Mark, &'a InvocationData<'a>>,
1469 /// Avoid duplicated errors for "name already defined".
1470 name_already_seen: FxHashMap<Name, Span>,
1472 potentially_unused_imports: Vec<&'a ImportDirective<'a>>,
1474 /// This table maps struct IDs into struct constructor IDs,
1475 /// it's not used during normal resolution, only for better error reporting.
1476 struct_constructors: DefIdMap<(Def, ty::Visibility)>,
1478 /// Only used for better errors on `fn(): fn()`
1479 current_type_ascription: Vec<Span>,
1481 injected_crate: Option<Module<'a>>,
1484 /// Nothing really interesting here, it just provides memory for the rest of the crate.
1485 pub struct ResolverArenas<'a> {
1486 modules: arena::TypedArena<ModuleData<'a>>,
1487 local_modules: RefCell<Vec<Module<'a>>>,
1488 name_bindings: arena::TypedArena<NameBinding<'a>>,
1489 import_directives: arena::TypedArena<ImportDirective<'a>>,
1490 name_resolutions: arena::TypedArena<RefCell<NameResolution<'a>>>,
1491 invocation_data: arena::TypedArena<InvocationData<'a>>,
1492 legacy_bindings: arena::TypedArena<LegacyBinding<'a>>,
1495 impl<'a> ResolverArenas<'a> {
1496 fn alloc_module(&'a self, module: ModuleData<'a>) -> Module<'a> {
1497 let module = self.modules.alloc(module);
1498 if module.def_id().map(|def_id| def_id.is_local()).unwrap_or(true) {
1499 self.local_modules.borrow_mut().push(module);
1503 fn local_modules(&'a self) -> ::std::cell::Ref<'a, Vec<Module<'a>>> {
1504 self.local_modules.borrow()
1506 fn alloc_name_binding(&'a self, name_binding: NameBinding<'a>) -> &'a NameBinding<'a> {
1507 self.name_bindings.alloc(name_binding)
1509 fn alloc_import_directive(&'a self, import_directive: ImportDirective<'a>)
1510 -> &'a ImportDirective {
1511 self.import_directives.alloc(import_directive)
1513 fn alloc_name_resolution(&'a self) -> &'a RefCell<NameResolution<'a>> {
1514 self.name_resolutions.alloc(Default::default())
1516 fn alloc_invocation_data(&'a self, expansion_data: InvocationData<'a>)
1517 -> &'a InvocationData<'a> {
1518 self.invocation_data.alloc(expansion_data)
1520 fn alloc_legacy_binding(&'a self, binding: LegacyBinding<'a>) -> &'a LegacyBinding<'a> {
1521 self.legacy_bindings.alloc(binding)
1525 impl<'a, 'b: 'a, 'cl: 'b> ty::DefIdTree for &'a Resolver<'b, 'cl> {
1526 fn parent(self, id: DefId) -> Option<DefId> {
1528 LOCAL_CRATE => self.definitions.def_key(id.index).parent,
1529 _ => self.cstore.def_key(id).parent,
1530 }.map(|index| DefId { index, ..id })
1534 /// This interface is used through the AST→HIR step, to embed full paths into the HIR. After that
1535 /// the resolver is no longer needed as all the relevant information is inline.
1536 impl<'a, 'cl> hir::lowering::Resolver for Resolver<'a, 'cl> {
1537 fn resolve_hir_path(&mut self, path: &mut hir::Path, is_value: bool) {
1538 self.resolve_hir_path_cb(path, is_value,
1539 |resolver, span, error| resolve_error(resolver, span, error))
1542 fn resolve_str_path(
1545 crate_root: Option<&str>,
1546 components: &[&str],
1547 args: Option<P<hir::GenericArgs>>,
1550 let mut segments = iter::once(keywords::CrateRoot.ident())
1552 crate_root.into_iter()
1553 .chain(components.iter().cloned())
1554 .map(Ident::from_str)
1555 ).map(hir::PathSegment::from_ident).collect::<Vec<_>>();
1557 if let Some(args) = args {
1558 let ident = segments.last().unwrap().ident;
1559 *segments.last_mut().unwrap() = hir::PathSegment {
1566 let mut path = hir::Path {
1569 segments: segments.into(),
1572 self.resolve_hir_path(&mut path, is_value);
1576 fn get_resolution(&mut self, id: NodeId) -> Option<PathResolution> {
1577 self.def_map.get(&id).cloned()
1580 fn get_import(&mut self, id: NodeId) -> PerNS<Option<PathResolution>> {
1581 self.import_map.get(&id).cloned().unwrap_or_default()
1584 fn definitions(&mut self) -> &mut Definitions {
1585 &mut self.definitions
1589 impl<'a, 'crateloader> Resolver<'a, 'crateloader> {
1590 /// Rustdoc uses this to resolve things in a recoverable way. ResolutionError<'a>
1591 /// isn't something that can be returned because it can't be made to live that long,
1592 /// and also it's a private type. Fortunately rustdoc doesn't need to know the error,
1593 /// just that an error occurred.
1594 pub fn resolve_str_path_error(&mut self, span: Span, path_str: &str, is_value: bool)
1595 -> Result<hir::Path, ()> {
1597 let mut errored = false;
1599 let mut path = if path_str.starts_with("::") {
1603 segments: iter::once(keywords::CrateRoot.ident()).chain({
1604 path_str.split("::").skip(1).map(Ident::from_str)
1605 }).map(hir::PathSegment::from_ident).collect(),
1611 segments: path_str.split("::").map(Ident::from_str)
1612 .map(hir::PathSegment::from_ident).collect(),
1615 self.resolve_hir_path_cb(&mut path, is_value, |_, _, _| errored = true);
1616 if errored || path.def == Def::Err {
1623 /// resolve_hir_path, but takes a callback in case there was an error
1624 fn resolve_hir_path_cb<F>(&mut self, path: &mut hir::Path, is_value: bool, error_callback: F)
1625 where F: for<'c, 'b> FnOnce(&'c mut Resolver, Span, ResolutionError<'b>)
1627 let namespace = if is_value { ValueNS } else { TypeNS };
1628 let hir::Path { ref segments, span, ref mut def } = *path;
1629 let path: Vec<_> = segments.iter().map(|seg| seg.ident).collect();
1630 // FIXME (Manishearth): Intra doc links won't get warned of epoch changes
1631 match self.resolve_path(None, &path, Some(namespace), true, span, CrateLint::No) {
1632 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
1633 *def = module.def().unwrap(),
1634 PathResult::NonModule(path_res) if path_res.unresolved_segments() == 0 =>
1635 *def = path_res.base_def(),
1636 PathResult::NonModule(..) => match self.resolve_path(
1644 PathResult::Failed(span, msg, _) => {
1645 error_callback(self, span, ResolutionError::FailedToResolve(&msg));
1649 PathResult::Module(ModuleOrUniformRoot::UniformRoot(_)) |
1650 PathResult::Indeterminate => unreachable!(),
1651 PathResult::Failed(span, msg, _) => {
1652 error_callback(self, span, ResolutionError::FailedToResolve(&msg));
1658 impl<'a, 'crateloader: 'a> Resolver<'a, 'crateloader> {
1659 pub fn new(session: &'a Session,
1663 make_glob_map: MakeGlobMap,
1664 crate_loader: &'a mut CrateLoader<'crateloader>,
1665 arenas: &'a ResolverArenas<'a>)
1666 -> Resolver<'a, 'crateloader> {
1667 let root_def_id = DefId::local(CRATE_DEF_INDEX);
1668 let root_module_kind = ModuleKind::Def(Def::Mod(root_def_id), keywords::Invalid.name());
1669 let graph_root = arenas.alloc_module(ModuleData {
1670 no_implicit_prelude: attr::contains_name(&krate.attrs, "no_implicit_prelude"),
1671 ..ModuleData::new(None, root_module_kind, root_def_id, Mark::root(), krate.span)
1673 let mut module_map = FxHashMap();
1674 module_map.insert(DefId::local(CRATE_DEF_INDEX), graph_root);
1676 let mut definitions = Definitions::new();
1677 DefCollector::new(&mut definitions, Mark::root())
1678 .collect_root(crate_name, session.local_crate_disambiguator());
1680 let mut extern_prelude: FxHashSet<Name> =
1681 session.opts.externs.iter().map(|kv| Symbol::intern(kv.0)).collect();
1683 if !attr::contains_name(&krate.attrs, "no_core") {
1684 extern_prelude.insert(Symbol::intern("core"));
1685 if !attr::contains_name(&krate.attrs, "no_std") {
1686 extern_prelude.insert(Symbol::intern("std"));
1687 if session.rust_2018() {
1688 extern_prelude.insert(Symbol::intern("meta"));
1693 let mut invocations = FxHashMap();
1694 invocations.insert(Mark::root(),
1695 arenas.alloc_invocation_data(InvocationData::root(graph_root)));
1697 let mut macro_defs = FxHashMap();
1698 macro_defs.insert(Mark::root(), root_def_id);
1707 // The outermost module has def ID 0; this is not reflected in the
1713 has_self: FxHashSet(),
1714 field_names: FxHashMap(),
1716 determined_imports: Vec::new(),
1717 indeterminate_imports: Vec::new(),
1719 current_module: graph_root,
1721 value_ns: vec![Rib::new(ModuleRibKind(graph_root))],
1722 type_ns: vec![Rib::new(ModuleRibKind(graph_root))],
1723 macro_ns: vec![Rib::new(ModuleRibKind(graph_root))],
1725 label_ribs: Vec::new(),
1727 current_trait_ref: None,
1728 current_self_type: None,
1729 current_self_item: None,
1731 primitive_type_table: PrimitiveTypeTable::new(),
1734 import_map: NodeMap(),
1735 freevars: NodeMap(),
1736 freevars_seen: NodeMap(),
1737 export_map: FxHashMap(),
1738 trait_map: NodeMap(),
1740 block_map: NodeMap(),
1741 extern_module_map: FxHashMap(),
1742 binding_parent_modules: FxHashMap(),
1744 make_glob_map: make_glob_map == MakeGlobMap::Yes,
1745 glob_map: NodeMap(),
1747 used_imports: FxHashSet(),
1748 maybe_unused_trait_imports: NodeSet(),
1749 maybe_unused_extern_crates: Vec::new(),
1751 unused_labels: FxHashMap(),
1753 privacy_errors: Vec::new(),
1754 ambiguity_errors: Vec::new(),
1755 use_injections: Vec::new(),
1756 macro_expanded_macro_export_errors: BTreeSet::new(),
1759 dummy_binding: arenas.alloc_name_binding(NameBinding {
1760 kind: NameBindingKind::Def(Def::Err, false),
1761 expansion: Mark::root(),
1763 vis: ty::Visibility::Public,
1767 macro_names: FxHashSet(),
1768 builtin_macros: FxHashMap(),
1769 macro_use_prelude: FxHashMap(),
1770 all_macros: FxHashMap(),
1771 macro_map: FxHashMap(),
1774 local_macro_def_scopes: FxHashMap(),
1775 name_already_seen: FxHashMap(),
1776 whitelisted_legacy_custom_derives: Vec::new(),
1777 potentially_unused_imports: Vec::new(),
1778 struct_constructors: DefIdMap(),
1779 found_unresolved_macro: false,
1780 unused_macros: FxHashSet(),
1781 current_type_ascription: Vec::new(),
1782 injected_crate: None,
1786 pub fn arenas() -> ResolverArenas<'a> {
1788 modules: arena::TypedArena::new(),
1789 local_modules: RefCell::new(Vec::new()),
1790 name_bindings: arena::TypedArena::new(),
1791 import_directives: arena::TypedArena::new(),
1792 name_resolutions: arena::TypedArena::new(),
1793 invocation_data: arena::TypedArena::new(),
1794 legacy_bindings: arena::TypedArena::new(),
1798 /// Runs the function on each namespace.
1799 fn per_ns<F: FnMut(&mut Self, Namespace)>(&mut self, mut f: F) {
1805 fn macro_def(&self, mut ctxt: SyntaxContext) -> DefId {
1807 match self.macro_defs.get(&ctxt.outer()) {
1808 Some(&def_id) => return def_id,
1809 None => ctxt.remove_mark(),
1814 /// Entry point to crate resolution.
1815 pub fn resolve_crate(&mut self, krate: &Crate) {
1816 ImportResolver { resolver: self }.finalize_imports();
1817 self.current_module = self.graph_root;
1818 self.finalize_current_module_macro_resolutions();
1820 visit::walk_crate(self, krate);
1822 check_unused::check_crate(self, krate);
1823 self.report_errors(krate);
1824 self.crate_loader.postprocess(krate);
1831 normal_ancestor_id: DefId,
1835 let module = ModuleData::new(Some(parent), kind, normal_ancestor_id, expansion, span);
1836 self.arenas.alloc_module(module)
1839 fn record_use(&mut self, ident: Ident, ns: Namespace, binding: &'a NameBinding<'a>)
1840 -> bool /* true if an error was reported */ {
1841 match binding.kind {
1842 NameBindingKind::Import { directive, binding, ref used }
1845 directive.used.set(true);
1846 self.used_imports.insert((directive.id, ns));
1847 self.add_to_glob_map(directive.id, ident);
1848 self.record_use(ident, ns, binding)
1850 NameBindingKind::Import { .. } => false,
1851 NameBindingKind::Ambiguity { b1, b2 } => {
1852 self.ambiguity_errors.push(AmbiguityError { ident, b1, b2 });
1859 fn add_to_glob_map(&mut self, id: NodeId, ident: Ident) {
1860 if self.make_glob_map {
1861 self.glob_map.entry(id).or_default().insert(ident.name);
1865 /// This resolves the identifier `ident` in the namespace `ns` in the current lexical scope.
1866 /// More specifically, we proceed up the hierarchy of scopes and return the binding for
1867 /// `ident` in the first scope that defines it (or None if no scopes define it).
1869 /// A block's items are above its local variables in the scope hierarchy, regardless of where
1870 /// the items are defined in the block. For example,
1873 /// g(); // Since there are no local variables in scope yet, this resolves to the item.
1876 /// g(); // This resolves to the local variable `g` since it shadows the item.
1880 /// Invariant: This must only be called during main resolution, not during
1881 /// import resolution.
1882 fn resolve_ident_in_lexical_scope(&mut self,
1885 record_used_id: Option<NodeId>,
1887 -> Option<LexicalScopeBinding<'a>> {
1888 let record_used = record_used_id.is_some();
1889 assert!(ns == TypeNS || ns == ValueNS);
1891 ident.span = if ident.name == keywords::SelfType.name() {
1892 // FIXME(jseyfried) improve `Self` hygiene
1893 ident.span.with_ctxt(SyntaxContext::empty())
1898 ident = ident.modern_and_legacy();
1901 // Walk backwards up the ribs in scope.
1902 let mut module = self.graph_root;
1903 for i in (0 .. self.ribs[ns].len()).rev() {
1904 if let Some(def) = self.ribs[ns][i].bindings.get(&ident).cloned() {
1905 // The ident resolves to a type parameter or local variable.
1906 return Some(LexicalScopeBinding::Def(
1907 self.adjust_local_def(ns, i, def, record_used, path_span)
1911 module = match self.ribs[ns][i].kind {
1912 ModuleRibKind(module) => module,
1913 MacroDefinition(def) if def == self.macro_def(ident.span.ctxt()) => {
1914 // If an invocation of this macro created `ident`, give up on `ident`
1915 // and switch to `ident`'s source from the macro definition.
1916 ident.span.remove_mark();
1922 let item = self.resolve_ident_in_module_unadjusted(
1923 ModuleOrUniformRoot::Module(module),
1930 if let Ok(binding) = item {
1931 // The ident resolves to an item.
1932 return Some(LexicalScopeBinding::Item(binding));
1936 ModuleKind::Block(..) => {}, // We can see through blocks
1941 ident.span = ident.span.modern();
1942 let mut poisoned = None;
1944 let opt_module = if let Some(node_id) = record_used_id {
1945 self.hygienic_lexical_parent_with_compatibility_fallback(module, &mut ident.span,
1946 node_id, &mut poisoned)
1948 self.hygienic_lexical_parent(module, &mut ident.span)
1950 module = unwrap_or!(opt_module, break);
1951 let orig_current_module = self.current_module;
1952 self.current_module = module; // Lexical resolutions can never be a privacy error.
1953 let result = self.resolve_ident_in_module_unadjusted(
1954 ModuleOrUniformRoot::Module(module),
1961 self.current_module = orig_current_module;
1965 if let Some(node_id) = poisoned {
1966 self.session.buffer_lint_with_diagnostic(
1967 lint::builtin::PROC_MACRO_DERIVE_RESOLUTION_FALLBACK,
1968 node_id, ident.span,
1969 &format!("cannot find {} `{}` in this scope", ns.descr(), ident),
1970 lint::builtin::BuiltinLintDiagnostics::
1971 ProcMacroDeriveResolutionFallback(ident.span),
1974 return Some(LexicalScopeBinding::Item(binding))
1976 Err(Determined) => continue,
1977 Err(Undetermined) =>
1978 span_bug!(ident.span, "undetermined resolution during main resolution pass"),
1982 if !module.no_implicit_prelude {
1983 // `record_used` means that we don't try to load crates during speculative resolution
1984 if record_used && ns == TypeNS && self.extern_prelude.contains(&ident.name) {
1985 let crate_id = self.crate_loader.process_path_extern(ident.name, ident.span);
1986 let crate_root = self.get_module(DefId { krate: crate_id, index: CRATE_DEF_INDEX });
1987 self.populate_module_if_necessary(&crate_root);
1989 let binding = (crate_root, ty::Visibility::Public,
1990 ident.span, Mark::root()).to_name_binding(self.arenas);
1991 return Some(LexicalScopeBinding::Item(binding));
1993 if ns == TypeNS && is_known_tool(ident.name) {
1994 let binding = (Def::ToolMod, ty::Visibility::Public,
1995 ident.span, Mark::root()).to_name_binding(self.arenas);
1996 return Some(LexicalScopeBinding::Item(binding));
1998 if let Some(prelude) = self.prelude {
1999 if let Ok(binding) = self.resolve_ident_in_module_unadjusted(
2000 ModuleOrUniformRoot::Module(prelude),
2007 return Some(LexicalScopeBinding::Item(binding));
2015 fn hygienic_lexical_parent(&mut self, module: Module<'a>, span: &mut Span)
2016 -> Option<Module<'a>> {
2017 if !module.expansion.is_descendant_of(span.ctxt().outer()) {
2018 return Some(self.macro_def_scope(span.remove_mark()));
2021 if let ModuleKind::Block(..) = module.kind {
2022 return Some(module.parent.unwrap());
2028 fn hygienic_lexical_parent_with_compatibility_fallback(&mut self, module: Module<'a>,
2029 span: &mut Span, node_id: NodeId,
2030 poisoned: &mut Option<NodeId>)
2031 -> Option<Module<'a>> {
2032 if let module @ Some(..) = self.hygienic_lexical_parent(module, span) {
2036 // We need to support the next case under a deprecation warning
2039 // ---- begin: this comes from a proc macro derive
2040 // mod implementation_details {
2041 // // Note that `MyStruct` is not in scope here.
2042 // impl SomeTrait for MyStruct { ... }
2046 // So we have to fall back to the module's parent during lexical resolution in this case.
2047 if let Some(parent) = module.parent {
2048 // Inner module is inside the macro, parent module is outside of the macro.
2049 if module.expansion != parent.expansion &&
2050 module.expansion.is_descendant_of(parent.expansion) {
2051 // The macro is a proc macro derive
2052 if module.expansion.looks_like_proc_macro_derive() {
2053 if parent.expansion.is_descendant_of(span.ctxt().outer()) {
2054 *poisoned = Some(node_id);
2055 return module.parent;
2064 fn resolve_ident_in_module(&mut self,
2065 module: ModuleOrUniformRoot<'a>,
2070 -> Result<&'a NameBinding<'a>, Determinacy> {
2071 ident.span = ident.span.modern();
2072 let orig_current_module = self.current_module;
2073 if let ModuleOrUniformRoot::Module(module) = module {
2074 if let Some(def) = ident.span.adjust(module.expansion) {
2075 self.current_module = self.macro_def_scope(def);
2078 let result = self.resolve_ident_in_module_unadjusted(
2079 module, ident, ns, false, record_used, span,
2081 self.current_module = orig_current_module;
2085 fn resolve_crate_root(&mut self, ident: Ident) -> Module<'a> {
2086 let mut ctxt = ident.span.ctxt();
2087 let mark = if ident.name == keywords::DollarCrate.name() {
2088 // When resolving `$crate` from a `macro_rules!` invoked in a `macro`,
2089 // we don't want to pretend that the `macro_rules!` definition is in the `macro`
2090 // as described in `SyntaxContext::apply_mark`, so we ignore prepended modern marks.
2091 // FIXME: This is only a guess and it doesn't work correctly for `macro_rules!`
2092 // definitions actually produced by `macro` and `macro` definitions produced by
2093 // `macro_rules!`, but at least such configurations are not stable yet.
2094 ctxt = ctxt.modern_and_legacy();
2095 let mut iter = ctxt.marks().into_iter().rev().peekable();
2096 let mut result = None;
2097 // Find the last modern mark from the end if it exists.
2098 while let Some(&(mark, transparency)) = iter.peek() {
2099 if transparency == Transparency::Opaque {
2100 result = Some(mark);
2106 // Then find the last legacy mark from the end if it exists.
2107 for (mark, transparency) in iter {
2108 if transparency == Transparency::SemiTransparent {
2109 result = Some(mark);
2116 ctxt = ctxt.modern();
2117 ctxt.adjust(Mark::root())
2119 let module = match mark {
2120 Some(def) => self.macro_def_scope(def),
2121 None => return self.graph_root,
2123 self.get_module(DefId { index: CRATE_DEF_INDEX, ..module.normal_ancestor_id })
2126 fn resolve_self(&mut self, ctxt: &mut SyntaxContext, module: Module<'a>) -> Module<'a> {
2127 let mut module = self.get_module(module.normal_ancestor_id);
2128 while module.span.ctxt().modern() != *ctxt {
2129 let parent = module.parent.unwrap_or_else(|| self.macro_def_scope(ctxt.remove_mark()));
2130 module = self.get_module(parent.normal_ancestor_id);
2137 // We maintain a list of value ribs and type ribs.
2139 // Simultaneously, we keep track of the current position in the module
2140 // graph in the `current_module` pointer. When we go to resolve a name in
2141 // the value or type namespaces, we first look through all the ribs and
2142 // then query the module graph. When we resolve a name in the module
2143 // namespace, we can skip all the ribs (since nested modules are not
2144 // allowed within blocks in Rust) and jump straight to the current module
2147 // Named implementations are handled separately. When we find a method
2148 // call, we consult the module node to find all of the implementations in
2149 // scope. This information is lazily cached in the module node. We then
2150 // generate a fake "implementation scope" containing all the
2151 // implementations thus found, for compatibility with old resolve pass.
2153 pub fn with_scope<F, T>(&mut self, id: NodeId, f: F) -> T
2154 where F: FnOnce(&mut Resolver) -> T
2156 let id = self.definitions.local_def_id(id);
2157 let module = self.module_map.get(&id).cloned(); // clones a reference
2158 if let Some(module) = module {
2159 // Move down in the graph.
2160 let orig_module = replace(&mut self.current_module, module);
2161 self.ribs[ValueNS].push(Rib::new(ModuleRibKind(module)));
2162 self.ribs[TypeNS].push(Rib::new(ModuleRibKind(module)));
2164 self.finalize_current_module_macro_resolutions();
2167 self.current_module = orig_module;
2168 self.ribs[ValueNS].pop();
2169 self.ribs[TypeNS].pop();
2176 /// Searches the current set of local scopes for labels. Returns the first non-None label that
2177 /// is returned by the given predicate function
2179 /// Stops after meeting a closure.
2180 fn search_label<P, R>(&self, mut ident: Ident, pred: P) -> Option<R>
2181 where P: Fn(&Rib, Ident) -> Option<R>
2183 for rib in self.label_ribs.iter().rev() {
2186 // If an invocation of this macro created `ident`, give up on `ident`
2187 // and switch to `ident`'s source from the macro definition.
2188 MacroDefinition(def) => {
2189 if def == self.macro_def(ident.span.ctxt()) {
2190 ident.span.remove_mark();
2194 // Do not resolve labels across function boundary
2198 let r = pred(rib, ident);
2206 fn resolve_adt(&mut self, item: &Item, generics: &Generics) {
2207 self.with_current_self_item(item, |this| {
2208 this.with_type_parameter_rib(HasTypeParameters(generics, ItemRibKind), |this| {
2209 let item_def_id = this.definitions.local_def_id(item.id);
2210 if this.session.features_untracked().self_in_typedefs {
2211 this.with_self_rib(Def::SelfTy(None, Some(item_def_id)), |this| {
2212 visit::walk_item(this, item);
2215 visit::walk_item(this, item);
2221 fn resolve_item(&mut self, item: &Item) {
2222 let name = item.ident.name;
2223 debug!("(resolving item) resolving {}", name);
2226 ItemKind::Ty(_, ref generics) |
2227 ItemKind::Fn(_, _, ref generics, _) |
2228 ItemKind::Existential(_, ref generics) => {
2229 self.with_type_parameter_rib(HasTypeParameters(generics, ItemRibKind),
2230 |this| visit::walk_item(this, item));
2233 ItemKind::Enum(_, ref generics) |
2234 ItemKind::Struct(_, ref generics) |
2235 ItemKind::Union(_, ref generics) => {
2236 self.resolve_adt(item, generics);
2239 ItemKind::Impl(.., ref generics, ref opt_trait_ref, ref self_type, ref impl_items) =>
2240 self.resolve_implementation(generics,
2246 ItemKind::Trait(.., ref generics, ref bounds, ref trait_items) => {
2247 // Create a new rib for the trait-wide type parameters.
2248 self.with_type_parameter_rib(HasTypeParameters(generics, ItemRibKind), |this| {
2249 let local_def_id = this.definitions.local_def_id(item.id);
2250 this.with_self_rib(Def::SelfTy(Some(local_def_id), None), |this| {
2251 this.visit_generics(generics);
2252 walk_list!(this, visit_param_bound, bounds);
2254 for trait_item in trait_items {
2255 let type_parameters = HasTypeParameters(&trait_item.generics,
2256 TraitOrImplItemRibKind);
2257 this.with_type_parameter_rib(type_parameters, |this| {
2258 match trait_item.node {
2259 TraitItemKind::Const(ref ty, ref default) => {
2262 // Only impose the restrictions of
2263 // ConstRibKind for an actual constant
2264 // expression in a provided default.
2265 if let Some(ref expr) = *default{
2266 this.with_constant_rib(|this| {
2267 this.visit_expr(expr);
2271 TraitItemKind::Method(_, _) => {
2272 visit::walk_trait_item(this, trait_item)
2274 TraitItemKind::Type(..) => {
2275 visit::walk_trait_item(this, trait_item)
2277 TraitItemKind::Macro(_) => {
2278 panic!("unexpanded macro in resolve!")
2287 ItemKind::TraitAlias(ref generics, ref bounds) => {
2288 // Create a new rib for the trait-wide type parameters.
2289 self.with_type_parameter_rib(HasTypeParameters(generics, ItemRibKind), |this| {
2290 let local_def_id = this.definitions.local_def_id(item.id);
2291 this.with_self_rib(Def::SelfTy(Some(local_def_id), None), |this| {
2292 this.visit_generics(generics);
2293 walk_list!(this, visit_param_bound, bounds);
2298 ItemKind::Mod(_) | ItemKind::ForeignMod(_) => {
2299 self.with_scope(item.id, |this| {
2300 visit::walk_item(this, item);
2304 ItemKind::Static(ref ty, _, ref expr) |
2305 ItemKind::Const(ref ty, ref expr) => {
2306 self.with_item_rib(|this| {
2308 this.with_constant_rib(|this| {
2309 this.visit_expr(expr);
2314 ItemKind::Use(ref use_tree) => {
2315 // Imports are resolved as global by default, add starting root segment.
2317 segments: use_tree.prefix.make_root().into_iter().collect(),
2318 span: use_tree.span,
2320 self.resolve_use_tree(item.id, use_tree.span, item.id, use_tree, &path);
2323 ItemKind::ExternCrate(_) | ItemKind::MacroDef(..) | ItemKind::GlobalAsm(_) => {
2324 // do nothing, these are just around to be encoded
2327 ItemKind::Mac(_) => panic!("unexpanded macro in resolve!"),
2331 /// For the most part, use trees are desugared into `ImportDirective` instances
2332 /// when building the reduced graph (see `build_reduced_graph_for_use_tree`). But
2333 /// there is one special case we handle here: an empty nested import like
2334 /// `a::{b::{}}`, which desugares into...no import directives.
2335 fn resolve_use_tree(
2340 use_tree: &ast::UseTree,
2343 match use_tree.kind {
2344 ast::UseTreeKind::Nested(ref items) => {
2346 segments: prefix.segments
2348 .chain(use_tree.prefix.segments.iter())
2351 span: prefix.span.to(use_tree.prefix.span),
2354 if items.len() == 0 {
2355 // Resolve prefix of an import with empty braces (issue #28388).
2356 self.smart_resolve_path_with_crate_lint(
2360 PathSource::ImportPrefix,
2361 CrateLint::UsePath { root_id, root_span },
2364 for &(ref tree, nested_id) in items {
2365 self.resolve_use_tree(root_id, root_span, nested_id, tree, &path);
2369 ast::UseTreeKind::Simple(..) => {},
2370 ast::UseTreeKind::Glob => {},
2374 fn with_type_parameter_rib<'b, F>(&'b mut self, type_parameters: TypeParameters<'a, 'b>, f: F)
2375 where F: FnOnce(&mut Resolver)
2377 match type_parameters {
2378 HasTypeParameters(generics, rib_kind) => {
2379 let mut function_type_rib = Rib::new(rib_kind);
2380 let mut seen_bindings = FxHashMap();
2381 for param in &generics.params {
2383 GenericParamKind::Lifetime { .. } => {}
2384 GenericParamKind::Type { .. } => {
2385 let ident = param.ident.modern();
2386 debug!("with_type_parameter_rib: {}", param.id);
2388 if seen_bindings.contains_key(&ident) {
2389 let span = seen_bindings.get(&ident).unwrap();
2390 let err = ResolutionError::NameAlreadyUsedInTypeParameterList(
2394 resolve_error(self, param.ident.span, err);
2396 seen_bindings.entry(ident).or_insert(param.ident.span);
2398 // Plain insert (no renaming).
2399 let def = Def::TyParam(self.definitions.local_def_id(param.id));
2400 function_type_rib.bindings.insert(ident, def);
2401 self.record_def(param.id, PathResolution::new(def));
2405 self.ribs[TypeNS].push(function_type_rib);
2408 NoTypeParameters => {
2415 if let HasTypeParameters(..) = type_parameters {
2416 self.ribs[TypeNS].pop();
2420 fn with_label_rib<F>(&mut self, f: F)
2421 where F: FnOnce(&mut Resolver)
2423 self.label_ribs.push(Rib::new(NormalRibKind));
2425 self.label_ribs.pop();
2428 fn with_item_rib<F>(&mut self, f: F)
2429 where F: FnOnce(&mut Resolver)
2431 self.ribs[ValueNS].push(Rib::new(ItemRibKind));
2432 self.ribs[TypeNS].push(Rib::new(ItemRibKind));
2434 self.ribs[TypeNS].pop();
2435 self.ribs[ValueNS].pop();
2438 fn with_constant_rib<F>(&mut self, f: F)
2439 where F: FnOnce(&mut Resolver)
2441 self.ribs[ValueNS].push(Rib::new(ConstantItemRibKind));
2442 self.label_ribs.push(Rib::new(ConstantItemRibKind));
2444 self.label_ribs.pop();
2445 self.ribs[ValueNS].pop();
2448 fn with_current_self_type<T, F>(&mut self, self_type: &Ty, f: F) -> T
2449 where F: FnOnce(&mut Resolver) -> T
2451 // Handle nested impls (inside fn bodies)
2452 let previous_value = replace(&mut self.current_self_type, Some(self_type.clone()));
2453 let result = f(self);
2454 self.current_self_type = previous_value;
2458 fn with_current_self_item<T, F>(&mut self, self_item: &Item, f: F) -> T
2459 where F: FnOnce(&mut Resolver) -> T
2461 let previous_value = replace(&mut self.current_self_item, Some(self_item.id));
2462 let result = f(self);
2463 self.current_self_item = previous_value;
2467 /// This is called to resolve a trait reference from an `impl` (i.e. `impl Trait for Foo`)
2468 fn with_optional_trait_ref<T, F>(&mut self, opt_trait_ref: Option<&TraitRef>, f: F) -> T
2469 where F: FnOnce(&mut Resolver, Option<DefId>) -> T
2471 let mut new_val = None;
2472 let mut new_id = None;
2473 if let Some(trait_ref) = opt_trait_ref {
2474 let path: Vec<_> = trait_ref.path.segments.iter()
2475 .map(|seg| seg.ident)
2477 let def = self.smart_resolve_path_fragment(
2481 trait_ref.path.span,
2482 PathSource::Trait(AliasPossibility::No),
2483 CrateLint::SimplePath(trait_ref.ref_id),
2485 if def != Def::Err {
2486 new_id = Some(def.def_id());
2487 let span = trait_ref.path.span;
2488 if let PathResult::Module(ModuleOrUniformRoot::Module(module)) =
2495 CrateLint::SimplePath(trait_ref.ref_id),
2498 new_val = Some((module, trait_ref.clone()));
2502 let original_trait_ref = replace(&mut self.current_trait_ref, new_val);
2503 let result = f(self, new_id);
2504 self.current_trait_ref = original_trait_ref;
2508 fn with_self_rib<F>(&mut self, self_def: Def, f: F)
2509 where F: FnOnce(&mut Resolver)
2511 let mut self_type_rib = Rib::new(NormalRibKind);
2513 // plain insert (no renaming, types are not currently hygienic....)
2514 self_type_rib.bindings.insert(keywords::SelfType.ident(), self_def);
2515 self.ribs[TypeNS].push(self_type_rib);
2517 self.ribs[TypeNS].pop();
2520 fn with_self_struct_ctor_rib<F>(&mut self, impl_id: DefId, f: F)
2521 where F: FnOnce(&mut Resolver)
2523 let self_def = Def::SelfCtor(impl_id);
2524 let mut self_type_rib = Rib::new(NormalRibKind);
2525 self_type_rib.bindings.insert(keywords::SelfType.ident(), self_def);
2526 self.ribs[ValueNS].push(self_type_rib);
2528 self.ribs[ValueNS].pop();
2531 fn resolve_implementation(&mut self,
2532 generics: &Generics,
2533 opt_trait_reference: &Option<TraitRef>,
2536 impl_items: &[ImplItem]) {
2537 // If applicable, create a rib for the type parameters.
2538 self.with_type_parameter_rib(HasTypeParameters(generics, ItemRibKind), |this| {
2539 // Dummy self type for better errors if `Self` is used in the trait path.
2540 this.with_self_rib(Def::SelfTy(None, None), |this| {
2541 // Resolve the trait reference, if necessary.
2542 this.with_optional_trait_ref(opt_trait_reference.as_ref(), |this, trait_id| {
2543 let item_def_id = this.definitions.local_def_id(item_id);
2544 this.with_self_rib(Def::SelfTy(trait_id, Some(item_def_id)), |this| {
2545 if let Some(trait_ref) = opt_trait_reference.as_ref() {
2546 // Resolve type arguments in the trait path.
2547 visit::walk_trait_ref(this, trait_ref);
2549 // Resolve the self type.
2550 this.visit_ty(self_type);
2551 // Resolve the type parameters.
2552 this.visit_generics(generics);
2553 // Resolve the items within the impl.
2554 this.with_current_self_type(self_type, |this| {
2555 this.with_self_struct_ctor_rib(item_def_id, |this| {
2556 for impl_item in impl_items {
2557 this.resolve_visibility(&impl_item.vis);
2559 // We also need a new scope for the impl item type parameters.
2560 let type_parameters = HasTypeParameters(&impl_item.generics,
2561 TraitOrImplItemRibKind);
2562 this.with_type_parameter_rib(type_parameters, |this| {
2563 use self::ResolutionError::*;
2564 match impl_item.node {
2565 ImplItemKind::Const(..) => {
2566 // If this is a trait impl, ensure the const
2568 this.check_trait_item(impl_item.ident,
2571 |n, s| ConstNotMemberOfTrait(n, s));
2572 this.with_constant_rib(|this|
2573 visit::walk_impl_item(this, impl_item)
2576 ImplItemKind::Method(..) => {
2577 // If this is a trait impl, ensure the method
2579 this.check_trait_item(impl_item.ident,
2582 |n, s| MethodNotMemberOfTrait(n, s));
2584 visit::walk_impl_item(this, impl_item);
2586 ImplItemKind::Type(ref ty) => {
2587 // If this is a trait impl, ensure the type
2589 this.check_trait_item(impl_item.ident,
2592 |n, s| TypeNotMemberOfTrait(n, s));
2596 ImplItemKind::Existential(ref bounds) => {
2597 // If this is a trait impl, ensure the type
2599 this.check_trait_item(impl_item.ident,
2602 |n, s| TypeNotMemberOfTrait(n, s));
2604 for bound in bounds {
2605 this.visit_param_bound(bound);
2608 ImplItemKind::Macro(_) =>
2609 panic!("unexpanded macro in resolve!"),
2621 fn check_trait_item<F>(&mut self, ident: Ident, ns: Namespace, span: Span, err: F)
2622 where F: FnOnce(Name, &str) -> ResolutionError
2624 // If there is a TraitRef in scope for an impl, then the method must be in the
2626 if let Some((module, _)) = self.current_trait_ref {
2627 if self.resolve_ident_in_module(
2628 ModuleOrUniformRoot::Module(module),
2634 let path = &self.current_trait_ref.as_ref().unwrap().1.path;
2635 resolve_error(self, span, err(ident.name, &path_names_to_string(path)));
2640 fn resolve_local(&mut self, local: &Local) {
2641 // Resolve the type.
2642 walk_list!(self, visit_ty, &local.ty);
2644 // Resolve the initializer.
2645 walk_list!(self, visit_expr, &local.init);
2647 // Resolve the pattern.
2648 self.resolve_pattern(&local.pat, PatternSource::Let, &mut FxHashMap());
2651 // build a map from pattern identifiers to binding-info's.
2652 // this is done hygienically. This could arise for a macro
2653 // that expands into an or-pattern where one 'x' was from the
2654 // user and one 'x' came from the macro.
2655 fn binding_mode_map(&mut self, pat: &Pat) -> BindingMap {
2656 let mut binding_map = FxHashMap();
2658 pat.walk(&mut |pat| {
2659 if let PatKind::Ident(binding_mode, ident, ref sub_pat) = pat.node {
2660 if sub_pat.is_some() || match self.def_map.get(&pat.id).map(|res| res.base_def()) {
2661 Some(Def::Local(..)) => true,
2664 let binding_info = BindingInfo { span: ident.span, binding_mode: binding_mode };
2665 binding_map.insert(ident, binding_info);
2674 // check that all of the arms in an or-pattern have exactly the
2675 // same set of bindings, with the same binding modes for each.
2676 fn check_consistent_bindings(&mut self, pats: &[P<Pat>]) {
2677 if pats.is_empty() {
2681 let mut missing_vars = FxHashMap();
2682 let mut inconsistent_vars = FxHashMap();
2683 for (i, p) in pats.iter().enumerate() {
2684 let map_i = self.binding_mode_map(&p);
2686 for (j, q) in pats.iter().enumerate() {
2691 let map_j = self.binding_mode_map(&q);
2692 for (&key, &binding_i) in &map_i {
2693 if map_j.len() == 0 { // Account for missing bindings when
2694 let binding_error = missing_vars // map_j has none.
2696 .or_insert(BindingError {
2698 origin: BTreeSet::new(),
2699 target: BTreeSet::new(),
2701 binding_error.origin.insert(binding_i.span);
2702 binding_error.target.insert(q.span);
2704 for (&key_j, &binding_j) in &map_j {
2705 match map_i.get(&key_j) {
2706 None => { // missing binding
2707 let binding_error = missing_vars
2709 .or_insert(BindingError {
2711 origin: BTreeSet::new(),
2712 target: BTreeSet::new(),
2714 binding_error.origin.insert(binding_j.span);
2715 binding_error.target.insert(p.span);
2717 Some(binding_i) => { // check consistent binding
2718 if binding_i.binding_mode != binding_j.binding_mode {
2721 .or_insert((binding_j.span, binding_i.span));
2729 let mut missing_vars = missing_vars.iter().collect::<Vec<_>>();
2730 missing_vars.sort();
2731 for (_, v) in missing_vars {
2733 *v.origin.iter().next().unwrap(),
2734 ResolutionError::VariableNotBoundInPattern(v));
2736 let mut inconsistent_vars = inconsistent_vars.iter().collect::<Vec<_>>();
2737 inconsistent_vars.sort();
2738 for (name, v) in inconsistent_vars {
2739 resolve_error(self, v.0, ResolutionError::VariableBoundWithDifferentMode(*name, v.1));
2743 fn resolve_arm(&mut self, arm: &Arm) {
2744 self.ribs[ValueNS].push(Rib::new(NormalRibKind));
2746 let mut bindings_list = FxHashMap();
2747 for pattern in &arm.pats {
2748 self.resolve_pattern(&pattern, PatternSource::Match, &mut bindings_list);
2751 // This has to happen *after* we determine which pat_idents are variants
2752 self.check_consistent_bindings(&arm.pats);
2755 Some(ast::Guard::If(ref expr)) => self.visit_expr(expr),
2758 self.visit_expr(&arm.body);
2760 self.ribs[ValueNS].pop();
2763 fn resolve_block(&mut self, block: &Block) {
2764 debug!("(resolving block) entering block");
2765 // Move down in the graph, if there's an anonymous module rooted here.
2766 let orig_module = self.current_module;
2767 let anonymous_module = self.block_map.get(&block.id).cloned(); // clones a reference
2769 let mut num_macro_definition_ribs = 0;
2770 if let Some(anonymous_module) = anonymous_module {
2771 debug!("(resolving block) found anonymous module, moving down");
2772 self.ribs[ValueNS].push(Rib::new(ModuleRibKind(anonymous_module)));
2773 self.ribs[TypeNS].push(Rib::new(ModuleRibKind(anonymous_module)));
2774 self.current_module = anonymous_module;
2775 self.finalize_current_module_macro_resolutions();
2777 self.ribs[ValueNS].push(Rib::new(NormalRibKind));
2780 // Descend into the block.
2781 for stmt in &block.stmts {
2782 if let ast::StmtKind::Item(ref item) = stmt.node {
2783 if let ast::ItemKind::MacroDef(..) = item.node {
2784 num_macro_definition_ribs += 1;
2785 let def = self.definitions.local_def_id(item.id);
2786 self.ribs[ValueNS].push(Rib::new(MacroDefinition(def)));
2787 self.label_ribs.push(Rib::new(MacroDefinition(def)));
2791 self.visit_stmt(stmt);
2795 self.current_module = orig_module;
2796 for _ in 0 .. num_macro_definition_ribs {
2797 self.ribs[ValueNS].pop();
2798 self.label_ribs.pop();
2800 self.ribs[ValueNS].pop();
2801 if anonymous_module.is_some() {
2802 self.ribs[TypeNS].pop();
2804 debug!("(resolving block) leaving block");
2807 fn fresh_binding(&mut self,
2810 outer_pat_id: NodeId,
2811 pat_src: PatternSource,
2812 bindings: &mut FxHashMap<Ident, NodeId>)
2814 // Add the binding to the local ribs, if it
2815 // doesn't already exist in the bindings map. (We
2816 // must not add it if it's in the bindings map
2817 // because that breaks the assumptions later
2818 // passes make about or-patterns.)
2819 let ident = ident.modern_and_legacy();
2820 let mut def = Def::Local(pat_id);
2821 match bindings.get(&ident).cloned() {
2822 Some(id) if id == outer_pat_id => {
2823 // `Variant(a, a)`, error
2827 ResolutionError::IdentifierBoundMoreThanOnceInSamePattern(
2831 Some(..) if pat_src == PatternSource::FnParam => {
2832 // `fn f(a: u8, a: u8)`, error
2836 ResolutionError::IdentifierBoundMoreThanOnceInParameterList(
2840 Some(..) if pat_src == PatternSource::Match ||
2841 pat_src == PatternSource::IfLet ||
2842 pat_src == PatternSource::WhileLet => {
2843 // `Variant1(a) | Variant2(a)`, ok
2844 // Reuse definition from the first `a`.
2845 def = self.ribs[ValueNS].last_mut().unwrap().bindings[&ident];
2848 span_bug!(ident.span, "two bindings with the same name from \
2849 unexpected pattern source {:?}", pat_src);
2852 // A completely fresh binding, add to the lists if it's valid.
2853 if ident.name != keywords::Invalid.name() {
2854 bindings.insert(ident, outer_pat_id);
2855 self.ribs[ValueNS].last_mut().unwrap().bindings.insert(ident, def);
2860 PathResolution::new(def)
2863 fn resolve_pattern(&mut self,
2865 pat_src: PatternSource,
2866 // Maps idents to the node ID for the
2867 // outermost pattern that binds them.
2868 bindings: &mut FxHashMap<Ident, NodeId>) {
2869 // Visit all direct subpatterns of this pattern.
2870 let outer_pat_id = pat.id;
2871 pat.walk(&mut |pat| {
2873 PatKind::Ident(bmode, ident, ref opt_pat) => {
2874 // First try to resolve the identifier as some existing
2875 // entity, then fall back to a fresh binding.
2876 let binding = self.resolve_ident_in_lexical_scope(ident, ValueNS,
2878 .and_then(LexicalScopeBinding::item);
2879 let resolution = binding.map(NameBinding::def).and_then(|def| {
2880 let is_syntactic_ambiguity = opt_pat.is_none() &&
2881 bmode == BindingMode::ByValue(Mutability::Immutable);
2883 Def::StructCtor(_, CtorKind::Const) |
2884 Def::VariantCtor(_, CtorKind::Const) |
2885 Def::Const(..) if is_syntactic_ambiguity => {
2886 // Disambiguate in favor of a unit struct/variant
2887 // or constant pattern.
2888 self.record_use(ident, ValueNS, binding.unwrap());
2889 Some(PathResolution::new(def))
2891 Def::StructCtor(..) | Def::VariantCtor(..) |
2892 Def::Const(..) | Def::Static(..) => {
2893 // This is unambiguously a fresh binding, either syntactically
2894 // (e.g. `IDENT @ PAT` or `ref IDENT`) or because `IDENT` resolves
2895 // to something unusable as a pattern (e.g. constructor function),
2896 // but we still conservatively report an error, see
2897 // issues/33118#issuecomment-233962221 for one reason why.
2901 ResolutionError::BindingShadowsSomethingUnacceptable(
2902 pat_src.descr(), ident.name, binding.unwrap())
2906 Def::Fn(..) | Def::Err => {
2907 // These entities are explicitly allowed
2908 // to be shadowed by fresh bindings.
2912 span_bug!(ident.span, "unexpected definition for an \
2913 identifier in pattern: {:?}", def);
2916 }).unwrap_or_else(|| {
2917 self.fresh_binding(ident, pat.id, outer_pat_id, pat_src, bindings)
2920 self.record_def(pat.id, resolution);
2923 PatKind::TupleStruct(ref path, ..) => {
2924 self.smart_resolve_path(pat.id, None, path, PathSource::TupleStruct);
2927 PatKind::Path(ref qself, ref path) => {
2928 self.smart_resolve_path(pat.id, qself.as_ref(), path, PathSource::Pat);
2931 PatKind::Struct(ref path, ..) => {
2932 self.smart_resolve_path(pat.id, None, path, PathSource::Struct);
2940 visit::walk_pat(self, pat);
2943 // High-level and context dependent path resolution routine.
2944 // Resolves the path and records the resolution into definition map.
2945 // If resolution fails tries several techniques to find likely
2946 // resolution candidates, suggest imports or other help, and report
2947 // errors in user friendly way.
2948 fn smart_resolve_path(&mut self,
2950 qself: Option<&QSelf>,
2954 self.smart_resolve_path_with_crate_lint(id, qself, path, source, CrateLint::SimplePath(id))
2957 /// A variant of `smart_resolve_path` where you also specify extra
2958 /// information about where the path came from; this extra info is
2959 /// sometimes needed for the lint that recommends rewriting
2960 /// absolute paths to `crate`, so that it knows how to frame the
2961 /// suggestion. If you are just resolving a path like `foo::bar`
2962 /// that appears...somewhere, though, then you just want
2963 /// `CrateLint::SimplePath`, which is what `smart_resolve_path`
2964 /// already provides.
2965 fn smart_resolve_path_with_crate_lint(
2968 qself: Option<&QSelf>,
2971 crate_lint: CrateLint
2972 ) -> PathResolution {
2973 let segments = &path.segments.iter()
2974 .map(|seg| seg.ident)
2975 .collect::<Vec<_>>();
2976 self.smart_resolve_path_fragment(id, qself, segments, path.span, source, crate_lint)
2979 fn smart_resolve_path_fragment(&mut self,
2981 qself: Option<&QSelf>,
2985 crate_lint: CrateLint)
2987 let ident_span = path.last().map_or(span, |ident| ident.span);
2988 let ns = source.namespace();
2989 let is_expected = &|def| source.is_expected(def);
2990 let is_enum_variant = &|def| if let Def::Variant(..) = def { true } else { false };
2992 // Base error is amended with one short label and possibly some longer helps/notes.
2993 let report_errors = |this: &mut Self, def: Option<Def>| {
2994 // Make the base error.
2995 let expected = source.descr_expected();
2996 let path_str = names_to_string(path);
2997 let item_str = path[path.len() - 1];
2998 let code = source.error_code(def.is_some());
2999 let (base_msg, fallback_label, base_span) = if let Some(def) = def {
3000 (format!("expected {}, found {} `{}`", expected, def.kind_name(), path_str),
3001 format!("not a {}", expected),
3004 let item_span = path[path.len() - 1].span;
3005 let (mod_prefix, mod_str) = if path.len() == 1 {
3006 (String::new(), "this scope".to_string())
3007 } else if path.len() == 2 && path[0].name == keywords::CrateRoot.name() {
3008 (String::new(), "the crate root".to_string())
3010 let mod_path = &path[..path.len() - 1];
3011 let mod_prefix = match this.resolve_path(None, mod_path, Some(TypeNS),
3012 false, span, CrateLint::No) {
3013 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
3016 }.map_or(String::new(), |def| format!("{} ", def.kind_name()));
3017 (mod_prefix, format!("`{}`", names_to_string(mod_path)))
3019 (format!("cannot find {} `{}` in {}{}", expected, item_str, mod_prefix, mod_str),
3020 format!("not found in {}", mod_str),
3023 let code = DiagnosticId::Error(code.into());
3024 let mut err = this.session.struct_span_err_with_code(base_span, &base_msg, code);
3026 // Emit help message for fake-self from other languages like `this`(javascript)
3027 let fake_self: Vec<Ident> = ["this", "my"].iter().map(
3028 |s| Ident::from_str(*s)
3030 if fake_self.contains(&item_str)
3031 && this.self_value_is_available(path[0].span, span) {
3032 err.span_suggestion_with_applicability(
3036 Applicability::MaybeIncorrect,
3040 // Emit special messages for unresolved `Self` and `self`.
3041 if is_self_type(path, ns) {
3042 __diagnostic_used!(E0411);
3043 err.code(DiagnosticId::Error("E0411".into()));
3044 let available_in = if this.session.features_untracked().self_in_typedefs {
3045 "impls, traits, and type definitions"
3049 err.span_label(span, format!("`Self` is only available in {}", available_in));
3050 if this.current_self_item.is_some() && nightly_options::is_nightly_build() {
3051 err.help("add #![feature(self_in_typedefs)] to the crate attributes \
3054 return (err, Vec::new());
3056 if is_self_value(path, ns) {
3057 __diagnostic_used!(E0424);
3058 err.code(DiagnosticId::Error("E0424".into()));
3059 err.span_label(span, format!("`self` value is a keyword \
3061 methods with `self` parameter"));
3062 return (err, Vec::new());
3065 // Try to lookup the name in more relaxed fashion for better error reporting.
3066 let ident = *path.last().unwrap();
3067 let candidates = this.lookup_import_candidates(ident.name, ns, is_expected);
3068 if candidates.is_empty() && is_expected(Def::Enum(DefId::local(CRATE_DEF_INDEX))) {
3069 let enum_candidates =
3070 this.lookup_import_candidates(ident.name, ns, is_enum_variant);
3071 let mut enum_candidates = enum_candidates.iter()
3072 .map(|suggestion| import_candidate_to_paths(&suggestion)).collect::<Vec<_>>();
3073 enum_candidates.sort();
3074 for (sp, variant_path, enum_path) in enum_candidates {
3076 let msg = format!("there is an enum variant `{}`, \
3082 err.span_suggestion_with_applicability(
3084 "you can try using the variant's enum",
3086 Applicability::MachineApplicable,
3091 if path.len() == 1 && this.self_type_is_available(span) {
3092 if let Some(candidate) = this.lookup_assoc_candidate(ident, ns, is_expected) {
3093 let self_is_available = this.self_value_is_available(path[0].span, span);
3095 AssocSuggestion::Field => {
3096 err.span_suggestion_with_applicability(
3099 format!("self.{}", path_str),
3100 Applicability::MachineApplicable,
3102 if !self_is_available {
3103 err.span_label(span, format!("`self` value is a keyword \
3105 methods with `self` parameter"));
3108 AssocSuggestion::MethodWithSelf if self_is_available => {
3109 err.span_suggestion_with_applicability(
3112 format!("self.{}", path_str),
3113 Applicability::MachineApplicable,
3116 AssocSuggestion::MethodWithSelf | AssocSuggestion::AssocItem => {
3117 err.span_suggestion_with_applicability(
3120 format!("Self::{}", path_str),
3121 Applicability::MachineApplicable,
3125 return (err, candidates);
3129 let mut levenshtein_worked = false;
3132 if let Some(candidate) = this.lookup_typo_candidate(path, ns, is_expected, span) {
3133 err.span_label(ident_span, format!("did you mean `{}`?", candidate));
3134 levenshtein_worked = true;
3137 // Try context dependent help if relaxed lookup didn't work.
3138 if let Some(def) = def {
3139 match (def, source) {
3140 (Def::Macro(..), _) => {
3141 err.span_label(span, format!("did you mean `{}!(...)`?", path_str));
3142 return (err, candidates);
3144 (Def::TyAlias(..), PathSource::Trait(_)) => {
3145 err.span_label(span, "type aliases cannot be used for traits");
3146 return (err, candidates);
3148 (Def::Mod(..), PathSource::Expr(Some(parent))) => match parent.node {
3149 ExprKind::Field(_, ident) => {
3150 err.span_label(parent.span, format!("did you mean `{}::{}`?",
3152 return (err, candidates);
3154 ExprKind::MethodCall(ref segment, ..) => {
3155 err.span_label(parent.span, format!("did you mean `{}::{}(...)`?",
3156 path_str, segment.ident));
3157 return (err, candidates);
3161 (Def::Enum(..), PathSource::TupleStruct)
3162 | (Def::Enum(..), PathSource::Expr(..)) => {
3163 if let Some(variants) = this.collect_enum_variants(def) {
3164 err.note(&format!("did you mean to use one \
3165 of the following variants?\n{}",
3167 .map(|suggestion| path_names_to_string(suggestion))
3168 .map(|suggestion| format!("- `{}`", suggestion))
3169 .collect::<Vec<_>>()
3173 err.note("did you mean to use one of the enum's variants?");
3175 return (err, candidates);
3177 (Def::Struct(def_id), _) if ns == ValueNS => {
3178 if let Some((ctor_def, ctor_vis))
3179 = this.struct_constructors.get(&def_id).cloned() {
3180 let accessible_ctor = this.is_accessible(ctor_vis);
3181 if is_expected(ctor_def) && !accessible_ctor {
3182 err.span_label(span, format!("constructor is not visible \
3183 here due to private fields"));
3186 // HACK(estebank): find a better way to figure out that this was a
3187 // parser issue where a struct literal is being used on an expression
3188 // where a brace being opened means a block is being started. Look
3189 // ahead for the next text to see if `span` is followed by a `{`.
3190 let sm = this.session.source_map();
3193 sp = sm.next_point(sp);
3194 match sm.span_to_snippet(sp) {
3195 Ok(ref snippet) => {
3196 if snippet.chars().any(|c| { !c.is_whitespace() }) {
3203 let followed_by_brace = match sm.span_to_snippet(sp) {
3204 Ok(ref snippet) if snippet == "{" => true,
3208 PathSource::Expr(Some(parent)) => {
3210 ExprKind::MethodCall(ref path_assignment, _) => {
3211 err.span_suggestion_with_applicability(
3212 sm.start_point(parent.span)
3213 .to(path_assignment.ident.span),
3214 "use `::` to access an associated function",
3217 path_assignment.ident),
3218 Applicability::MaybeIncorrect
3220 return (err, candidates);
3225 format!("did you mean `{} {{ /* fields */ }}`?",
3228 return (err, candidates);
3232 PathSource::Expr(None) if followed_by_brace == true => {
3235 format!("did you mean `({} {{ /* fields */ }})`?",
3238 return (err, candidates);
3243 format!("did you mean `{} {{ /* fields */ }}`?",
3246 return (err, candidates);
3250 return (err, candidates);
3252 (Def::Union(..), _) |
3253 (Def::Variant(..), _) |
3254 (Def::VariantCtor(_, CtorKind::Fictive), _) if ns == ValueNS => {
3255 err.span_label(span, format!("did you mean `{} {{ /* fields */ }}`?",
3257 return (err, candidates);
3259 (Def::SelfTy(..), _) if ns == ValueNS => {
3260 err.span_label(span, fallback_label);
3261 err.note("can't use `Self` as a constructor, you must use the \
3262 implemented struct");
3263 return (err, candidates);
3265 (Def::TyAlias(_), _) | (Def::AssociatedTy(..), _) if ns == ValueNS => {
3266 err.note("can't use a type alias as a constructor");
3267 return (err, candidates);
3274 if !levenshtein_worked {
3275 err.span_label(base_span, fallback_label);
3276 this.type_ascription_suggestion(&mut err, base_span);
3280 let report_errors = |this: &mut Self, def: Option<Def>| {
3281 let (err, candidates) = report_errors(this, def);
3282 let def_id = this.current_module.normal_ancestor_id;
3283 let node_id = this.definitions.as_local_node_id(def_id).unwrap();
3284 let better = def.is_some();
3285 this.use_injections.push(UseError { err, candidates, node_id, better });
3286 err_path_resolution()
3289 let resolution = match self.resolve_qpath_anywhere(
3295 source.defer_to_typeck(),
3296 source.global_by_default(),
3299 Some(resolution) if resolution.unresolved_segments() == 0 => {
3300 if is_expected(resolution.base_def()) || resolution.base_def() == Def::Err {
3303 // Add a temporary hack to smooth the transition to new struct ctor
3304 // visibility rules. See #38932 for more details.
3306 if let Def::Struct(def_id) = resolution.base_def() {
3307 if let Some((ctor_def, ctor_vis))
3308 = self.struct_constructors.get(&def_id).cloned() {
3309 if is_expected(ctor_def) && self.is_accessible(ctor_vis) {
3310 let lint = lint::builtin::LEGACY_CONSTRUCTOR_VISIBILITY;
3311 self.session.buffer_lint(lint, id, span,
3312 "private struct constructors are not usable through \
3313 re-exports in outer modules",
3315 res = Some(PathResolution::new(ctor_def));
3320 res.unwrap_or_else(|| report_errors(self, Some(resolution.base_def())))
3323 Some(resolution) if source.defer_to_typeck() => {
3324 // Not fully resolved associated item `T::A::B` or `<T as Tr>::A::B`
3325 // or `<T>::A::B`. If `B` should be resolved in value namespace then
3326 // it needs to be added to the trait map.
3328 let item_name = *path.last().unwrap();
3329 let traits = self.get_traits_containing_item(item_name, ns);
3330 self.trait_map.insert(id, traits);
3334 _ => report_errors(self, None)
3337 if let PathSource::TraitItem(..) = source {} else {
3338 // Avoid recording definition of `A::B` in `<T as A>::B::C`.
3339 self.record_def(id, resolution);
3344 fn type_ascription_suggestion(&self,
3345 err: &mut DiagnosticBuilder,
3347 debug!("type_ascription_suggetion {:?}", base_span);
3348 let cm = self.session.source_map();
3349 debug!("self.current_type_ascription {:?}", self.current_type_ascription);
3350 if let Some(sp) = self.current_type_ascription.last() {
3352 loop { // try to find the `:`, bail on first non-':'/non-whitespace
3353 sp = cm.next_point(sp);
3354 if let Ok(snippet) = cm.span_to_snippet(sp.to(cm.next_point(sp))) {
3355 debug!("snippet {:?}", snippet);
3356 let line_sp = cm.lookup_char_pos(sp.hi()).line;
3357 let line_base_sp = cm.lookup_char_pos(base_span.lo()).line;
3358 debug!("{:?} {:?}", line_sp, line_base_sp);
3360 err.span_label(base_span,
3361 "expecting a type here because of type ascription");
3362 if line_sp != line_base_sp {
3363 err.span_suggestion_short_with_applicability(
3365 "did you mean to use `;` here instead?",
3367 Applicability::MaybeIncorrect,
3371 } else if snippet.trim().len() != 0 {
3372 debug!("tried to find type ascription `:` token, couldn't find it");
3382 fn self_type_is_available(&mut self, span: Span) -> bool {
3383 let binding = self.resolve_ident_in_lexical_scope(keywords::SelfType.ident(),
3384 TypeNS, None, span);
3385 if let Some(LexicalScopeBinding::Def(def)) = binding { def != Def::Err } else { false }
3388 fn self_value_is_available(&mut self, self_span: Span, path_span: Span) -> bool {
3389 let ident = Ident::new(keywords::SelfValue.name(), self_span);
3390 let binding = self.resolve_ident_in_lexical_scope(ident, ValueNS, None, path_span);
3391 if let Some(LexicalScopeBinding::Def(def)) = binding { def != Def::Err } else { false }
3394 // Resolve in alternative namespaces if resolution in the primary namespace fails.
3395 fn resolve_qpath_anywhere(&mut self,
3397 qself: Option<&QSelf>,
3399 primary_ns: Namespace,
3401 defer_to_typeck: bool,
3402 global_by_default: bool,
3403 crate_lint: CrateLint)
3404 -> Option<PathResolution> {
3405 let mut fin_res = None;
3406 // FIXME: can't resolve paths in macro namespace yet, macros are
3407 // processed by the little special hack below.
3408 for (i, ns) in [primary_ns, TypeNS, ValueNS, /*MacroNS*/].iter().cloned().enumerate() {
3409 if i == 0 || ns != primary_ns {
3410 match self.resolve_qpath(id, qself, path, ns, span, global_by_default, crate_lint) {
3411 // If defer_to_typeck, then resolution > no resolution,
3412 // otherwise full resolution > partial resolution > no resolution.
3413 Some(res) if res.unresolved_segments() == 0 || defer_to_typeck =>
3415 res => if fin_res.is_none() { fin_res = res },
3419 if primary_ns != MacroNS &&
3420 (self.macro_names.contains(&path[0].modern()) ||
3421 self.builtin_macros.get(&path[0].name).cloned()
3422 .and_then(NameBinding::macro_kind) == Some(MacroKind::Bang) ||
3423 self.macro_use_prelude.get(&path[0].name).cloned()
3424 .and_then(NameBinding::macro_kind) == Some(MacroKind::Bang)) {
3425 // Return some dummy definition, it's enough for error reporting.
3427 PathResolution::new(Def::Macro(DefId::local(CRATE_DEF_INDEX), MacroKind::Bang))
3433 /// Handles paths that may refer to associated items.
3434 fn resolve_qpath(&mut self,
3436 qself: Option<&QSelf>,
3440 global_by_default: bool,
3441 crate_lint: CrateLint)
3442 -> Option<PathResolution> {
3444 "resolve_qpath(id={:?}, qself={:?}, path={:?}, \
3445 ns={:?}, span={:?}, global_by_default={:?})",
3454 if let Some(qself) = qself {
3455 if qself.position == 0 {
3456 // This is a case like `<T>::B`, where there is no
3457 // trait to resolve. In that case, we leave the `B`
3458 // segment to be resolved by type-check.
3459 return Some(PathResolution::with_unresolved_segments(
3460 Def::Mod(DefId::local(CRATE_DEF_INDEX)), path.len()
3464 // Make sure `A::B` in `<T as A::B>::C` is a trait item.
3466 // Currently, `path` names the full item (`A::B::C`, in
3467 // our example). so we extract the prefix of that that is
3468 // the trait (the slice upto and including
3469 // `qself.position`). And then we recursively resolve that,
3470 // but with `qself` set to `None`.
3472 // However, setting `qself` to none (but not changing the
3473 // span) loses the information about where this path
3474 // *actually* appears, so for the purposes of the crate
3475 // lint we pass along information that this is the trait
3476 // name from a fully qualified path, and this also
3477 // contains the full span (the `CrateLint::QPathTrait`).
3478 let ns = if qself.position + 1 == path.len() { ns } else { TypeNS };
3479 let res = self.smart_resolve_path_fragment(
3482 &path[..qself.position + 1],
3484 PathSource::TraitItem(ns),
3485 CrateLint::QPathTrait {
3487 qpath_span: qself.path_span,
3491 // The remaining segments (the `C` in our example) will
3492 // have to be resolved by type-check, since that requires doing
3493 // trait resolution.
3494 return Some(PathResolution::with_unresolved_segments(
3495 res.base_def(), res.unresolved_segments() + path.len() - qself.position - 1
3499 let result = match self.resolve_path(
3507 PathResult::NonModule(path_res) => path_res,
3508 PathResult::Module(ModuleOrUniformRoot::Module(module)) if !module.is_normal() => {
3509 PathResolution::new(module.def().unwrap())
3511 // In `a(::assoc_item)*` `a` cannot be a module. If `a` does resolve to a module we
3512 // don't report an error right away, but try to fallback to a primitive type.
3513 // So, we are still able to successfully resolve something like
3515 // use std::u8; // bring module u8 in scope
3516 // fn f() -> u8 { // OK, resolves to primitive u8, not to std::u8
3517 // u8::max_value() // OK, resolves to associated function <u8>::max_value,
3518 // // not to non-existent std::u8::max_value
3521 // Such behavior is required for backward compatibility.
3522 // The same fallback is used when `a` resolves to nothing.
3523 PathResult::Module(ModuleOrUniformRoot::Module(_)) |
3524 PathResult::Failed(..)
3525 if (ns == TypeNS || path.len() > 1) &&
3526 self.primitive_type_table.primitive_types
3527 .contains_key(&path[0].name) => {
3528 let prim = self.primitive_type_table.primitive_types[&path[0].name];
3529 PathResolution::with_unresolved_segments(Def::PrimTy(prim), path.len() - 1)
3531 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
3532 PathResolution::new(module.def().unwrap()),
3533 PathResult::Failed(span, msg, false) => {
3534 resolve_error(self, span, ResolutionError::FailedToResolve(&msg));
3535 err_path_resolution()
3537 PathResult::Module(ModuleOrUniformRoot::UniformRoot(_)) |
3538 PathResult::Failed(..) => return None,
3539 PathResult::Indeterminate => bug!("indetermined path result in resolve_qpath"),
3542 if path.len() > 1 && !global_by_default && result.base_def() != Def::Err &&
3543 path[0].name != keywords::CrateRoot.name() &&
3544 path[0].name != keywords::DollarCrate.name() {
3545 let unqualified_result = {
3546 match self.resolve_path(
3548 &[*path.last().unwrap()],
3554 PathResult::NonModule(path_res) => path_res.base_def(),
3555 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
3556 module.def().unwrap(),
3557 _ => return Some(result),
3560 if result.base_def() == unqualified_result {
3561 let lint = lint::builtin::UNUSED_QUALIFICATIONS;
3562 self.session.buffer_lint(lint, id, span, "unnecessary qualification")
3571 base_module: Option<ModuleOrUniformRoot<'a>>,
3573 opt_ns: Option<Namespace>, // `None` indicates a module path
3576 crate_lint: CrateLint,
3577 ) -> PathResult<'a> {
3578 let parent_scope = ParentScope { module: self.current_module, ..self.dummy_parent_scope() };
3579 self.resolve_path_with_parent_scope(base_module, path, opt_ns, &parent_scope,
3580 record_used, path_span, crate_lint)
3583 fn resolve_path_with_parent_scope(
3585 base_module: Option<ModuleOrUniformRoot<'a>>,
3587 opt_ns: Option<Namespace>, // `None` indicates a module path
3588 parent_scope: &ParentScope<'a>,
3591 crate_lint: CrateLint,
3592 ) -> PathResult<'a> {
3593 let mut module = base_module;
3594 let mut allow_super = true;
3595 let mut second_binding = None;
3596 self.current_module = parent_scope.module;
3599 "resolve_path(path={:?}, opt_ns={:?}, record_used={:?}, \
3600 path_span={:?}, crate_lint={:?})",
3608 for (i, &ident) in path.iter().enumerate() {
3609 debug!("resolve_path ident {} {:?}", i, ident);
3610 let is_last = i == path.len() - 1;
3611 let ns = if is_last { opt_ns.unwrap_or(TypeNS) } else { TypeNS };
3612 let name = ident.name;
3614 allow_super &= ns == TypeNS &&
3615 (name == keywords::SelfValue.name() ||
3616 name == keywords::Super.name());
3619 if allow_super && name == keywords::Super.name() {
3620 let mut ctxt = ident.span.ctxt().modern();
3621 let self_module = match i {
3622 0 => Some(self.resolve_self(&mut ctxt, self.current_module)),
3624 Some(ModuleOrUniformRoot::Module(module)) => Some(module),
3628 if let Some(self_module) = self_module {
3629 if let Some(parent) = self_module.parent {
3630 module = Some(ModuleOrUniformRoot::Module(
3631 self.resolve_self(&mut ctxt, parent)));
3635 let msg = "There are too many initial `super`s.".to_string();
3636 return PathResult::Failed(ident.span, msg, false);
3639 if name == keywords::SelfValue.name() {
3640 let mut ctxt = ident.span.ctxt().modern();
3641 module = Some(ModuleOrUniformRoot::Module(
3642 self.resolve_self(&mut ctxt, self.current_module)));
3645 if name == keywords::Extern.name() ||
3646 name == keywords::CrateRoot.name() &&
3647 self.session.rust_2018() {
3648 module = Some(ModuleOrUniformRoot::UniformRoot(name));
3651 if name == keywords::CrateRoot.name() ||
3652 name == keywords::Crate.name() ||
3653 name == keywords::DollarCrate.name() {
3654 // `::a::b`, `crate::a::b` or `$crate::a::b`
3655 module = Some(ModuleOrUniformRoot::Module(
3656 self.resolve_crate_root(ident)));
3662 // Report special messages for path segment keywords in wrong positions.
3663 if ident.is_path_segment_keyword() && i != 0 {
3664 let name_str = if name == keywords::CrateRoot.name() {
3665 "crate root".to_string()
3667 format!("`{}`", name)
3669 let msg = if i == 1 && path[0].name == keywords::CrateRoot.name() {
3670 format!("global paths cannot start with {}", name_str)
3672 format!("{} in paths can only be used in start position", name_str)
3674 return PathResult::Failed(ident.span, msg, false);
3677 let binding = if let Some(module) = module {
3678 self.resolve_ident_in_module(module, ident, ns, record_used, path_span)
3679 } else if opt_ns == Some(MacroNS) {
3680 assert!(ns == TypeNS);
3681 self.early_resolve_ident_in_lexical_scope(ident, ns, None, parent_scope,
3682 record_used, record_used, path_span)
3684 let record_used_id =
3685 if record_used { crate_lint.node_id().or(Some(CRATE_NODE_ID)) } else { None };
3686 match self.resolve_ident_in_lexical_scope(ident, ns, record_used_id, path_span) {
3687 // we found a locally-imported or available item/module
3688 Some(LexicalScopeBinding::Item(binding)) => Ok(binding),
3689 // we found a local variable or type param
3690 Some(LexicalScopeBinding::Def(def))
3691 if opt_ns == Some(TypeNS) || opt_ns == Some(ValueNS) => {
3692 return PathResult::NonModule(PathResolution::with_unresolved_segments(
3696 _ => Err(if record_used { Determined } else { Undetermined }),
3703 second_binding = Some(binding);
3705 let def = binding.def();
3706 let maybe_assoc = opt_ns != Some(MacroNS) && PathSource::Type.is_expected(def);
3707 if let Some(next_module) = binding.module() {
3708 module = Some(ModuleOrUniformRoot::Module(next_module));
3709 } else if def == Def::ToolMod && i + 1 != path.len() {
3710 let def = Def::NonMacroAttr(NonMacroAttrKind::Tool);
3711 return PathResult::NonModule(PathResolution::new(def));
3712 } else if def == Def::Err {
3713 return PathResult::NonModule(err_path_resolution());
3714 } else if opt_ns.is_some() && (is_last || maybe_assoc) {
3715 self.lint_if_path_starts_with_module(
3721 return PathResult::NonModule(PathResolution::with_unresolved_segments(
3722 def, path.len() - i - 1
3725 return PathResult::Failed(ident.span,
3726 format!("Not a module `{}`", ident),
3730 Err(Undetermined) => return PathResult::Indeterminate,
3731 Err(Determined) => {
3732 if let Some(ModuleOrUniformRoot::Module(module)) = module {
3733 if opt_ns.is_some() && !module.is_normal() {
3734 return PathResult::NonModule(PathResolution::with_unresolved_segments(
3735 module.def().unwrap(), path.len() - i
3739 let module_def = match module {
3740 Some(ModuleOrUniformRoot::Module(module)) => module.def(),
3743 let msg = if module_def == self.graph_root.def() {
3744 let is_mod = |def| match def { Def::Mod(..) => true, _ => false };
3745 let mut candidates =
3746 self.lookup_import_candidates(name, TypeNS, is_mod);
3747 candidates.sort_by_cached_key(|c| {
3748 (c.path.segments.len(), c.path.to_string())
3750 if let Some(candidate) = candidates.get(0) {
3751 format!("Did you mean `{}`?", candidate.path)
3753 format!("Maybe a missing `extern crate {};`?", ident)
3756 format!("Use of undeclared type or module `{}`", ident)
3758 format!("Could not find `{}` in `{}`", ident, path[i - 1])
3760 return PathResult::Failed(ident.span, msg, is_last);
3765 self.lint_if_path_starts_with_module(crate_lint, path, path_span, second_binding);
3767 PathResult::Module(module.unwrap_or_else(|| {
3768 span_bug!(path_span, "resolve_path: empty(?) path {:?} has no module", path);
3773 fn lint_if_path_starts_with_module(
3775 crate_lint: CrateLint,
3778 second_binding: Option<&NameBinding>,
3780 // In the 2018 edition this lint is a hard error, so nothing to do
3781 if self.session.rust_2018() {
3785 let (diag_id, diag_span) = match crate_lint {
3786 CrateLint::No => return,
3787 CrateLint::SimplePath(id) => (id, path_span),
3788 CrateLint::UsePath { root_id, root_span } => (root_id, root_span),
3789 CrateLint::QPathTrait { qpath_id, qpath_span } => (qpath_id, qpath_span),
3792 let first_name = match path.get(0) {
3793 Some(ident) => ident.name,
3797 // We're only interested in `use` paths which should start with
3798 // `{{root}}` or `extern` currently.
3799 if first_name != keywords::Extern.name() && first_name != keywords::CrateRoot.name() {
3804 // If this import looks like `crate::...` it's already good
3805 Some(ident) if ident.name == keywords::Crate.name() => return,
3806 // Otherwise go below to see if it's an extern crate
3808 // If the path has length one (and it's `CrateRoot` most likely)
3809 // then we don't know whether we're gonna be importing a crate or an
3810 // item in our crate. Defer this lint to elsewhere
3814 // If the first element of our path was actually resolved to an
3815 // `ExternCrate` (also used for `crate::...`) then no need to issue a
3816 // warning, this looks all good!
3817 if let Some(binding) = second_binding {
3818 if let NameBindingKind::Import { directive: d, .. } = binding.kind {
3819 // Careful: we still want to rewrite paths from
3820 // renamed extern crates.
3821 if let ImportDirectiveSubclass::ExternCrate(None) = d.subclass {
3827 let diag = lint::builtin::BuiltinLintDiagnostics
3828 ::AbsPathWithModule(diag_span);
3829 self.session.buffer_lint_with_diagnostic(
3830 lint::builtin::ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE,
3832 "absolute paths must start with `self`, `super`, \
3833 `crate`, or an external crate name in the 2018 edition",
3837 // Resolve a local definition, potentially adjusting for closures.
3838 fn adjust_local_def(&mut self,
3843 span: Span) -> Def {
3844 let ribs = &self.ribs[ns][rib_index + 1..];
3846 // An invalid forward use of a type parameter from a previous default.
3847 if let ForwardTyParamBanRibKind = self.ribs[ns][rib_index].kind {
3849 resolve_error(self, span, ResolutionError::ForwardDeclaredTyParam);
3851 assert_eq!(def, Def::Err);
3857 span_bug!(span, "unexpected {:?} in bindings", def)
3859 Def::Local(node_id) => {
3862 NormalRibKind | ModuleRibKind(..) | MacroDefinition(..) |
3863 ForwardTyParamBanRibKind => {
3864 // Nothing to do. Continue.
3866 ClosureRibKind(function_id) => {
3869 let seen = self.freevars_seen
3872 if let Some(&index) = seen.get(&node_id) {
3873 def = Def::Upvar(node_id, index, function_id);
3876 let vec = self.freevars
3879 let depth = vec.len();
3880 def = Def::Upvar(node_id, depth, function_id);
3887 seen.insert(node_id, depth);
3890 ItemRibKind | TraitOrImplItemRibKind => {
3891 // This was an attempt to access an upvar inside a
3892 // named function item. This is not allowed, so we
3895 resolve_error(self, span,
3896 ResolutionError::CannotCaptureDynamicEnvironmentInFnItem);
3900 ConstantItemRibKind => {
3901 // Still doesn't deal with upvars
3903 resolve_error(self, span,
3904 ResolutionError::AttemptToUseNonConstantValueInConstant);
3911 Def::TyParam(..) | Def::SelfTy(..) => {
3914 NormalRibKind | TraitOrImplItemRibKind | ClosureRibKind(..) |
3915 ModuleRibKind(..) | MacroDefinition(..) | ForwardTyParamBanRibKind |
3916 ConstantItemRibKind => {
3917 // Nothing to do. Continue.
3920 // This was an attempt to use a type parameter outside
3923 resolve_error(self, span,
3924 ResolutionError::TypeParametersFromOuterFunction(def));
3936 fn lookup_assoc_candidate<FilterFn>(&mut self,
3939 filter_fn: FilterFn)
3940 -> Option<AssocSuggestion>
3941 where FilterFn: Fn(Def) -> bool
3943 fn extract_node_id(t: &Ty) -> Option<NodeId> {
3945 TyKind::Path(None, _) => Some(t.id),
3946 TyKind::Rptr(_, ref mut_ty) => extract_node_id(&mut_ty.ty),
3947 // This doesn't handle the remaining `Ty` variants as they are not
3948 // that commonly the self_type, it might be interesting to provide
3949 // support for those in future.
3954 // Fields are generally expected in the same contexts as locals.
3955 if filter_fn(Def::Local(ast::DUMMY_NODE_ID)) {
3956 if let Some(node_id) = self.current_self_type.as_ref().and_then(extract_node_id) {
3957 // Look for a field with the same name in the current self_type.
3958 if let Some(resolution) = self.def_map.get(&node_id) {
3959 match resolution.base_def() {
3960 Def::Struct(did) | Def::Union(did)
3961 if resolution.unresolved_segments() == 0 => {
3962 if let Some(field_names) = self.field_names.get(&did) {
3963 if field_names.iter().any(|&field_name| ident.name == field_name) {
3964 return Some(AssocSuggestion::Field);
3974 // Look for associated items in the current trait.
3975 if let Some((module, _)) = self.current_trait_ref {
3976 if let Ok(binding) = self.resolve_ident_in_module(
3977 ModuleOrUniformRoot::Module(module),
3983 let def = binding.def();
3985 return Some(if self.has_self.contains(&def.def_id()) {
3986 AssocSuggestion::MethodWithSelf
3988 AssocSuggestion::AssocItem
3997 fn lookup_typo_candidate<FilterFn>(&mut self,
4000 filter_fn: FilterFn,
4003 where FilterFn: Fn(Def) -> bool
4005 let add_module_candidates = |module: Module, names: &mut Vec<Name>| {
4006 for (&(ident, _), resolution) in module.resolutions.borrow().iter() {
4007 if let Some(binding) = resolution.borrow().binding {
4008 if filter_fn(binding.def()) {
4009 names.push(ident.name);
4015 let mut names = Vec::new();
4016 if path.len() == 1 {
4017 // Search in lexical scope.
4018 // Walk backwards up the ribs in scope and collect candidates.
4019 for rib in self.ribs[ns].iter().rev() {
4020 // Locals and type parameters
4021 for (ident, def) in &rib.bindings {
4022 if filter_fn(*def) {
4023 names.push(ident.name);
4027 if let ModuleRibKind(module) = rib.kind {
4028 // Items from this module
4029 add_module_candidates(module, &mut names);
4031 if let ModuleKind::Block(..) = module.kind {
4032 // We can see through blocks
4034 // Items from the prelude
4035 if !module.no_implicit_prelude {
4036 names.extend(self.extern_prelude.iter().cloned());
4037 if let Some(prelude) = self.prelude {
4038 add_module_candidates(prelude, &mut names);
4045 // Add primitive types to the mix
4046 if filter_fn(Def::PrimTy(Bool)) {
4048 self.primitive_type_table.primitive_types.iter().map(|(name, _)| name)
4052 // Search in module.
4053 let mod_path = &path[..path.len() - 1];
4054 if let PathResult::Module(module) = self.resolve_path(None, mod_path, Some(TypeNS),
4055 false, span, CrateLint::No) {
4056 if let ModuleOrUniformRoot::Module(module) = module {
4057 add_module_candidates(module, &mut names);
4062 let name = path[path.len() - 1].name;
4063 // Make sure error reporting is deterministic.
4064 names.sort_by_cached_key(|name| name.as_str());
4065 match find_best_match_for_name(names.iter(), &name.as_str(), None) {
4066 Some(found) if found != name => Some(found),
4071 fn with_resolved_label<F>(&mut self, label: Option<Label>, id: NodeId, f: F)
4072 where F: FnOnce(&mut Resolver)
4074 if let Some(label) = label {
4075 self.unused_labels.insert(id, label.ident.span);
4076 let def = Def::Label(id);
4077 self.with_label_rib(|this| {
4078 let ident = label.ident.modern_and_legacy();
4079 this.label_ribs.last_mut().unwrap().bindings.insert(ident, def);
4087 fn resolve_labeled_block(&mut self, label: Option<Label>, id: NodeId, block: &Block) {
4088 self.with_resolved_label(label, id, |this| this.visit_block(block));
4091 fn resolve_expr(&mut self, expr: &Expr, parent: Option<&Expr>) {
4092 // First, record candidate traits for this expression if it could
4093 // result in the invocation of a method call.
4095 self.record_candidate_traits_for_expr_if_necessary(expr);
4097 // Next, resolve the node.
4099 ExprKind::Path(ref qself, ref path) => {
4100 self.smart_resolve_path(expr.id, qself.as_ref(), path, PathSource::Expr(parent));
4101 visit::walk_expr(self, expr);
4104 ExprKind::Struct(ref path, ..) => {
4105 self.smart_resolve_path(expr.id, None, path, PathSource::Struct);
4106 visit::walk_expr(self, expr);
4109 ExprKind::Break(Some(label), _) | ExprKind::Continue(Some(label)) => {
4110 let def = self.search_label(label.ident, |rib, ident| {
4111 rib.bindings.get(&ident.modern_and_legacy()).cloned()
4115 // Search again for close matches...
4116 // Picks the first label that is "close enough", which is not necessarily
4117 // the closest match
4118 let close_match = self.search_label(label.ident, |rib, ident| {
4119 let names = rib.bindings.iter().map(|(id, _)| &id.name);
4120 find_best_match_for_name(names, &*ident.as_str(), None)
4122 self.record_def(expr.id, err_path_resolution());
4125 ResolutionError::UndeclaredLabel(&label.ident.as_str(),
4128 Some(Def::Label(id)) => {
4129 // Since this def is a label, it is never read.
4130 self.record_def(expr.id, PathResolution::new(Def::Label(id)));
4131 self.unused_labels.remove(&id);
4134 span_bug!(expr.span, "label wasn't mapped to a label def!");
4138 // visit `break` argument if any
4139 visit::walk_expr(self, expr);
4142 ExprKind::IfLet(ref pats, ref subexpression, ref if_block, ref optional_else) => {
4143 self.visit_expr(subexpression);
4145 self.ribs[ValueNS].push(Rib::new(NormalRibKind));
4146 let mut bindings_list = FxHashMap();
4148 self.resolve_pattern(pat, PatternSource::IfLet, &mut bindings_list);
4150 // This has to happen *after* we determine which pat_idents are variants
4151 self.check_consistent_bindings(pats);
4152 self.visit_block(if_block);
4153 self.ribs[ValueNS].pop();
4155 optional_else.as_ref().map(|expr| self.visit_expr(expr));
4158 ExprKind::Loop(ref block, label) => self.resolve_labeled_block(label, expr.id, &block),
4160 ExprKind::While(ref subexpression, ref block, label) => {
4161 self.with_resolved_label(label, expr.id, |this| {
4162 this.visit_expr(subexpression);
4163 this.visit_block(block);
4167 ExprKind::WhileLet(ref pats, ref subexpression, ref block, label) => {
4168 self.with_resolved_label(label, expr.id, |this| {
4169 this.visit_expr(subexpression);
4170 this.ribs[ValueNS].push(Rib::new(NormalRibKind));
4171 let mut bindings_list = FxHashMap();
4173 this.resolve_pattern(pat, PatternSource::WhileLet, &mut bindings_list);
4175 // This has to happen *after* we determine which pat_idents are variants
4176 this.check_consistent_bindings(pats);
4177 this.visit_block(block);
4178 this.ribs[ValueNS].pop();
4182 ExprKind::ForLoop(ref pattern, ref subexpression, ref block, label) => {
4183 self.visit_expr(subexpression);
4184 self.ribs[ValueNS].push(Rib::new(NormalRibKind));
4185 self.resolve_pattern(pattern, PatternSource::For, &mut FxHashMap());
4187 self.resolve_labeled_block(label, expr.id, block);
4189 self.ribs[ValueNS].pop();
4192 ExprKind::Block(ref block, label) => self.resolve_labeled_block(label, block.id, block),
4194 // Equivalent to `visit::walk_expr` + passing some context to children.
4195 ExprKind::Field(ref subexpression, _) => {
4196 self.resolve_expr(subexpression, Some(expr));
4198 ExprKind::MethodCall(ref segment, ref arguments) => {
4199 let mut arguments = arguments.iter();
4200 self.resolve_expr(arguments.next().unwrap(), Some(expr));
4201 for argument in arguments {
4202 self.resolve_expr(argument, None);
4204 self.visit_path_segment(expr.span, segment);
4207 ExprKind::Call(ref callee, ref arguments) => {
4208 self.resolve_expr(callee, Some(expr));
4209 for argument in arguments {
4210 self.resolve_expr(argument, None);
4213 ExprKind::Type(ref type_expr, _) => {
4214 self.current_type_ascription.push(type_expr.span);
4215 visit::walk_expr(self, expr);
4216 self.current_type_ascription.pop();
4218 // Resolve the body of async exprs inside the async closure to which they desugar
4219 ExprKind::Async(_, async_closure_id, ref block) => {
4220 let rib_kind = ClosureRibKind(async_closure_id);
4221 self.ribs[ValueNS].push(Rib::new(rib_kind));
4222 self.label_ribs.push(Rib::new(rib_kind));
4223 self.visit_block(&block);
4224 self.label_ribs.pop();
4225 self.ribs[ValueNS].pop();
4227 // `async |x| ...` gets desugared to `|x| future_from_generator(|| ...)`, so we need to
4228 // resolve the arguments within the proper scopes so that usages of them inside the
4229 // closure are detected as upvars rather than normal closure arg usages.
4231 _, IsAsync::Async { closure_id: inner_closure_id, .. }, _,
4232 ref fn_decl, ref body, _span,
4234 let rib_kind = ClosureRibKind(expr.id);
4235 self.ribs[ValueNS].push(Rib::new(rib_kind));
4236 self.label_ribs.push(Rib::new(rib_kind));
4237 // Resolve arguments:
4238 let mut bindings_list = FxHashMap();
4239 for argument in &fn_decl.inputs {
4240 self.resolve_pattern(&argument.pat, PatternSource::FnParam, &mut bindings_list);
4241 self.visit_ty(&argument.ty);
4243 // No need to resolve return type-- the outer closure return type is
4244 // FunctionRetTy::Default
4246 // Now resolve the inner closure
4248 let rib_kind = ClosureRibKind(inner_closure_id);
4249 self.ribs[ValueNS].push(Rib::new(rib_kind));
4250 self.label_ribs.push(Rib::new(rib_kind));
4251 // No need to resolve arguments: the inner closure has none.
4252 // Resolve the return type:
4253 visit::walk_fn_ret_ty(self, &fn_decl.output);
4255 self.visit_expr(body);
4256 self.label_ribs.pop();
4257 self.ribs[ValueNS].pop();
4259 self.label_ribs.pop();
4260 self.ribs[ValueNS].pop();
4263 visit::walk_expr(self, expr);
4268 fn record_candidate_traits_for_expr_if_necessary(&mut self, expr: &Expr) {
4270 ExprKind::Field(_, ident) => {
4271 // FIXME(#6890): Even though you can't treat a method like a
4272 // field, we need to add any trait methods we find that match
4273 // the field name so that we can do some nice error reporting
4274 // later on in typeck.
4275 let traits = self.get_traits_containing_item(ident, ValueNS);
4276 self.trait_map.insert(expr.id, traits);
4278 ExprKind::MethodCall(ref segment, ..) => {
4279 debug!("(recording candidate traits for expr) recording traits for {}",
4281 let traits = self.get_traits_containing_item(segment.ident, ValueNS);
4282 self.trait_map.insert(expr.id, traits);
4290 fn get_traits_containing_item(&mut self, mut ident: Ident, ns: Namespace)
4291 -> Vec<TraitCandidate> {
4292 debug!("(getting traits containing item) looking for '{}'", ident.name);
4294 let mut found_traits = Vec::new();
4295 // Look for the current trait.
4296 if let Some((module, _)) = self.current_trait_ref {
4297 if self.resolve_ident_in_module(
4298 ModuleOrUniformRoot::Module(module),
4304 let def_id = module.def_id().unwrap();
4305 found_traits.push(TraitCandidate { def_id: def_id, import_id: None });
4309 ident.span = ident.span.modern();
4310 let mut search_module = self.current_module;
4312 self.get_traits_in_module_containing_item(ident, ns, search_module, &mut found_traits);
4313 search_module = unwrap_or!(
4314 self.hygienic_lexical_parent(search_module, &mut ident.span), break
4318 if let Some(prelude) = self.prelude {
4319 if !search_module.no_implicit_prelude {
4320 self.get_traits_in_module_containing_item(ident, ns, prelude, &mut found_traits);
4327 fn get_traits_in_module_containing_item(&mut self,
4331 found_traits: &mut Vec<TraitCandidate>) {
4332 assert!(ns == TypeNS || ns == ValueNS);
4333 let mut traits = module.traits.borrow_mut();
4334 if traits.is_none() {
4335 let mut collected_traits = Vec::new();
4336 module.for_each_child(|name, ns, binding| {
4337 if ns != TypeNS { return }
4338 if let Def::Trait(_) = binding.def() {
4339 collected_traits.push((name, binding));
4342 *traits = Some(collected_traits.into_boxed_slice());
4345 for &(trait_name, binding) in traits.as_ref().unwrap().iter() {
4346 let module = binding.module().unwrap();
4347 let mut ident = ident;
4348 if ident.span.glob_adjust(module.expansion, binding.span.ctxt().modern()).is_none() {
4351 if self.resolve_ident_in_module_unadjusted(
4352 ModuleOrUniformRoot::Module(module),
4359 let import_id = match binding.kind {
4360 NameBindingKind::Import { directive, .. } => {
4361 self.maybe_unused_trait_imports.insert(directive.id);
4362 self.add_to_glob_map(directive.id, trait_name);
4367 let trait_def_id = module.def_id().unwrap();
4368 found_traits.push(TraitCandidate { def_id: trait_def_id, import_id: import_id });
4373 fn lookup_import_candidates_from_module<FilterFn>(&mut self,
4375 namespace: Namespace,
4376 start_module: &'a ModuleData<'a>,
4378 filter_fn: FilterFn)
4379 -> Vec<ImportSuggestion>
4380 where FilterFn: Fn(Def) -> bool
4382 let mut candidates = Vec::new();
4383 let mut worklist = Vec::new();
4384 let mut seen_modules = FxHashSet();
4385 let not_local_module = crate_name != keywords::Crate.ident();
4386 worklist.push((start_module, Vec::<ast::PathSegment>::new(), not_local_module));
4388 while let Some((in_module,
4390 in_module_is_extern)) = worklist.pop() {
4391 self.populate_module_if_necessary(in_module);
4393 // We have to visit module children in deterministic order to avoid
4394 // instabilities in reported imports (#43552).
4395 in_module.for_each_child_stable(|ident, ns, name_binding| {
4396 // avoid imports entirely
4397 if name_binding.is_import() && !name_binding.is_extern_crate() { return; }
4398 // avoid non-importable candidates as well
4399 if !name_binding.is_importable() { return; }
4401 // collect results based on the filter function
4402 if ident.name == lookup_name && ns == namespace {
4403 if filter_fn(name_binding.def()) {
4405 let mut segms = path_segments.clone();
4406 if self.session.rust_2018() {
4407 // crate-local absolute paths start with `crate::` in edition 2018
4408 // FIXME: may also be stabilized for Rust 2015 (Issues #45477, #44660)
4410 0, ast::PathSegment::from_ident(crate_name)
4414 segms.push(ast::PathSegment::from_ident(ident));
4416 span: name_binding.span,
4419 // the entity is accessible in the following cases:
4420 // 1. if it's defined in the same crate, it's always
4421 // accessible (since private entities can be made public)
4422 // 2. if it's defined in another crate, it's accessible
4423 // only if both the module is public and the entity is
4424 // declared as public (due to pruning, we don't explore
4425 // outside crate private modules => no need to check this)
4426 if !in_module_is_extern || name_binding.vis == ty::Visibility::Public {
4427 candidates.push(ImportSuggestion { path: path });
4432 // collect submodules to explore
4433 if let Some(module) = name_binding.module() {
4435 let mut path_segments = path_segments.clone();
4436 path_segments.push(ast::PathSegment::from_ident(ident));
4438 let is_extern_crate_that_also_appears_in_prelude =
4439 name_binding.is_extern_crate() &&
4440 self.session.rust_2018();
4442 let is_visible_to_user =
4443 !in_module_is_extern || name_binding.vis == ty::Visibility::Public;
4445 if !is_extern_crate_that_also_appears_in_prelude && is_visible_to_user {
4446 // add the module to the lookup
4447 let is_extern = in_module_is_extern || name_binding.is_extern_crate();
4448 if seen_modules.insert(module.def_id().unwrap()) {
4449 worklist.push((module, path_segments, is_extern));
4459 /// When name resolution fails, this method can be used to look up candidate
4460 /// entities with the expected name. It allows filtering them using the
4461 /// supplied predicate (which should be used to only accept the types of
4462 /// definitions expected e.g. traits). The lookup spans across all crates.
4464 /// NOTE: The method does not look into imports, but this is not a problem,
4465 /// since we report the definitions (thus, the de-aliased imports).
4466 fn lookup_import_candidates<FilterFn>(&mut self,
4468 namespace: Namespace,
4469 filter_fn: FilterFn)
4470 -> Vec<ImportSuggestion>
4471 where FilterFn: Fn(Def) -> bool
4473 let mut suggestions = vec![];
4476 self.lookup_import_candidates_from_module(
4477 lookup_name, namespace, self.graph_root, keywords::Crate.ident(), &filter_fn
4481 if self.session.rust_2018() {
4482 let extern_prelude_names = self.extern_prelude.clone();
4483 for &name in extern_prelude_names.iter() {
4484 let ident = Ident::with_empty_ctxt(name);
4485 match self.crate_loader.maybe_process_path_extern(name, ident.span) {
4487 let crate_root = self.get_module(DefId {
4489 index: CRATE_DEF_INDEX,
4491 self.populate_module_if_necessary(&crate_root);
4494 self.lookup_import_candidates_from_module(
4495 lookup_name, namespace, crate_root, ident, &filter_fn
4507 fn find_module(&mut self,
4509 -> Option<(Module<'a>, ImportSuggestion)>
4511 let mut result = None;
4512 let mut worklist = Vec::new();
4513 let mut seen_modules = FxHashSet();
4514 worklist.push((self.graph_root, Vec::new()));
4516 while let Some((in_module, path_segments)) = worklist.pop() {
4517 // abort if the module is already found
4518 if result.is_some() { break; }
4520 self.populate_module_if_necessary(in_module);
4522 in_module.for_each_child_stable(|ident, _, name_binding| {
4523 // abort if the module is already found or if name_binding is private external
4524 if result.is_some() || !name_binding.vis.is_visible_locally() {
4527 if let Some(module) = name_binding.module() {
4529 let mut path_segments = path_segments.clone();
4530 path_segments.push(ast::PathSegment::from_ident(ident));
4531 if module.def() == Some(module_def) {
4533 span: name_binding.span,
4534 segments: path_segments,
4536 result = Some((module, ImportSuggestion { path: path }));
4538 // add the module to the lookup
4539 if seen_modules.insert(module.def_id().unwrap()) {
4540 worklist.push((module, path_segments));
4550 fn collect_enum_variants(&mut self, enum_def: Def) -> Option<Vec<Path>> {
4551 if let Def::Enum(..) = enum_def {} else {
4552 panic!("Non-enum def passed to collect_enum_variants: {:?}", enum_def)
4555 self.find_module(enum_def).map(|(enum_module, enum_import_suggestion)| {
4556 self.populate_module_if_necessary(enum_module);
4558 let mut variants = Vec::new();
4559 enum_module.for_each_child_stable(|ident, _, name_binding| {
4560 if let Def::Variant(..) = name_binding.def() {
4561 let mut segms = enum_import_suggestion.path.segments.clone();
4562 segms.push(ast::PathSegment::from_ident(ident));
4563 variants.push(Path {
4564 span: name_binding.span,
4573 fn record_def(&mut self, node_id: NodeId, resolution: PathResolution) {
4574 debug!("(recording def) recording {:?} for {}", resolution, node_id);
4575 if let Some(prev_res) = self.def_map.insert(node_id, resolution) {
4576 panic!("path resolved multiple times ({:?} before, {:?} now)", prev_res, resolution);
4580 fn resolve_visibility(&mut self, vis: &ast::Visibility) -> ty::Visibility {
4582 ast::VisibilityKind::Public => ty::Visibility::Public,
4583 ast::VisibilityKind::Crate(..) => {
4584 ty::Visibility::Restricted(DefId::local(CRATE_DEF_INDEX))
4586 ast::VisibilityKind::Inherited => {
4587 ty::Visibility::Restricted(self.current_module.normal_ancestor_id)
4589 ast::VisibilityKind::Restricted { ref path, id, .. } => {
4590 // Visibilities are resolved as global by default, add starting root segment.
4591 let segments = path.make_root().iter().chain(path.segments.iter())
4592 .map(|seg| seg.ident)
4593 .collect::<Vec<_>>();
4594 let def = self.smart_resolve_path_fragment(
4599 PathSource::Visibility,
4600 CrateLint::SimplePath(id),
4602 if def == Def::Err {
4603 ty::Visibility::Public
4605 let vis = ty::Visibility::Restricted(def.def_id());
4606 if self.is_accessible(vis) {
4609 self.session.span_err(path.span, "visibilities can only be restricted \
4610 to ancestor modules");
4611 ty::Visibility::Public
4618 fn is_accessible(&self, vis: ty::Visibility) -> bool {
4619 vis.is_accessible_from(self.current_module.normal_ancestor_id, self)
4622 fn is_accessible_from(&self, vis: ty::Visibility, module: Module<'a>) -> bool {
4623 vis.is_accessible_from(module.normal_ancestor_id, self)
4626 fn set_binding_parent_module(&mut self, binding: &'a NameBinding<'a>, module: Module<'a>) {
4627 if let Some(old_module) = self.binding_parent_modules.insert(PtrKey(binding), module) {
4628 if !ptr::eq(module, old_module) {
4629 span_bug!(binding.span, "parent module is reset for binding");
4634 fn disambiguate_legacy_vs_modern(
4636 legacy: &'a NameBinding<'a>,
4637 modern: &'a NameBinding<'a>,
4639 // Some non-controversial subset of ambiguities "modern macro name" vs "macro_rules"
4640 // is disambiguated to mitigate regressions from macro modularization.
4641 // Scoping for `macro_rules` behaves like scoping for `let` at module level, in general.
4642 match (self.binding_parent_modules.get(&PtrKey(legacy)),
4643 self.binding_parent_modules.get(&PtrKey(modern))) {
4644 (Some(legacy), Some(modern)) =>
4645 legacy.normal_ancestor_id == modern.normal_ancestor_id &&
4646 modern.is_ancestor_of(legacy),
4651 fn report_ambiguity_error(&self, ident: Ident, b1: &NameBinding, b2: &NameBinding) {
4652 let participle = |is_import: bool| if is_import { "imported" } else { "defined" };
4654 format!("`{}` could refer to the name {} here", ident, participle(b1.is_import()));
4656 format!("`{}` could also refer to the name {} here", ident, participle(b2.is_import()));
4657 let note = if b1.expansion != Mark::root() {
4658 Some(if let Def::Macro(..) = b1.def() {
4659 format!("macro-expanded {} do not shadow",
4660 if b1.is_import() { "macro imports" } else { "macros" })
4662 format!("macro-expanded {} do not shadow when used in a macro invocation path",
4663 if b1.is_import() { "imports" } else { "items" })
4665 } else if b1.is_glob_import() {
4666 Some(format!("consider adding an explicit import of `{}` to disambiguate", ident))
4671 let mut err = struct_span_err!(self.session, ident.span, E0659, "`{}` is ambiguous", ident);
4672 err.span_label(ident.span, "ambiguous name");
4673 err.span_note(b1.span, &msg1);
4675 Def::Macro(..) if b2.span.is_dummy() =>
4676 err.note(&format!("`{}` is also a builtin macro", ident)),
4677 _ => err.span_note(b2.span, &msg2),
4679 if let Some(note) = note {
4685 fn report_errors(&mut self, krate: &Crate) {
4686 self.report_with_use_injections(krate);
4687 let mut reported_spans = FxHashSet();
4689 for &(span_use, span_def) in &self.macro_expanded_macro_export_errors {
4690 let msg = "macro-expanded `macro_export` macros from the current crate \
4691 cannot be referred to by absolute paths";
4692 self.session.buffer_lint_with_diagnostic(
4693 lint::builtin::MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS,
4694 CRATE_NODE_ID, span_use, msg,
4695 lint::builtin::BuiltinLintDiagnostics::
4696 MacroExpandedMacroExportsAccessedByAbsolutePaths(span_def),
4700 for &AmbiguityError { ident, b1, b2 } in &self.ambiguity_errors {
4701 if reported_spans.insert(ident.span) {
4702 self.report_ambiguity_error(ident, b1, b2);
4706 for &PrivacyError(span, name, binding) in &self.privacy_errors {
4707 if !reported_spans.insert(span) { continue }
4708 span_err!(self.session, span, E0603, "{} `{}` is private", binding.descr(), name);
4712 fn report_with_use_injections(&mut self, krate: &Crate) {
4713 for UseError { mut err, candidates, node_id, better } in self.use_injections.drain(..) {
4714 let (span, found_use) = UsePlacementFinder::check(krate, node_id);
4715 if !candidates.is_empty() {
4716 show_candidates(&mut err, span, &candidates, better, found_use);
4722 fn report_conflict<'b>(&mut self,
4726 new_binding: &NameBinding<'b>,
4727 old_binding: &NameBinding<'b>) {
4728 // Error on the second of two conflicting names
4729 if old_binding.span.lo() > new_binding.span.lo() {
4730 return self.report_conflict(parent, ident, ns, old_binding, new_binding);
4733 let container = match parent.kind {
4734 ModuleKind::Def(Def::Mod(_), _) => "module",
4735 ModuleKind::Def(Def::Trait(_), _) => "trait",
4736 ModuleKind::Block(..) => "block",
4740 let old_noun = match old_binding.is_import() {
4742 false => "definition",
4745 let new_participle = match new_binding.is_import() {
4750 let (name, span) = (ident.name, self.session.source_map().def_span(new_binding.span));
4752 if let Some(s) = self.name_already_seen.get(&name) {
4758 let old_kind = match (ns, old_binding.module()) {
4759 (ValueNS, _) => "value",
4760 (MacroNS, _) => "macro",
4761 (TypeNS, _) if old_binding.is_extern_crate() => "extern crate",
4762 (TypeNS, Some(module)) if module.is_normal() => "module",
4763 (TypeNS, Some(module)) if module.is_trait() => "trait",
4764 (TypeNS, _) => "type",
4767 let msg = format!("the name `{}` is defined multiple times", name);
4769 let mut err = match (old_binding.is_extern_crate(), new_binding.is_extern_crate()) {
4770 (true, true) => struct_span_err!(self.session, span, E0259, "{}", msg),
4771 (true, _) | (_, true) => match new_binding.is_import() && old_binding.is_import() {
4772 true => struct_span_err!(self.session, span, E0254, "{}", msg),
4773 false => struct_span_err!(self.session, span, E0260, "{}", msg),
4775 _ => match (old_binding.is_import(), new_binding.is_import()) {
4776 (false, false) => struct_span_err!(self.session, span, E0428, "{}", msg),
4777 (true, true) => struct_span_err!(self.session, span, E0252, "{}", msg),
4778 _ => struct_span_err!(self.session, span, E0255, "{}", msg),
4782 err.note(&format!("`{}` must be defined only once in the {} namespace of this {}",
4787 err.span_label(span, format!("`{}` re{} here", name, new_participle));
4788 if !old_binding.span.is_dummy() {
4789 err.span_label(self.session.source_map().def_span(old_binding.span),
4790 format!("previous {} of the {} `{}` here", old_noun, old_kind, name));
4793 // See https://github.com/rust-lang/rust/issues/32354
4794 if old_binding.is_import() || new_binding.is_import() {
4795 let binding = if new_binding.is_import() && !new_binding.span.is_dummy() {
4801 let cm = self.session.source_map();
4802 let rename_msg = "You can use `as` to change the binding name of the import";
4804 if let (Ok(snippet), false) = (cm.span_to_snippet(binding.span),
4805 binding.is_renamed_extern_crate()) {
4806 let suggested_name = if name.as_str().chars().next().unwrap().is_uppercase() {
4807 format!("Other{}", name)
4809 format!("other_{}", name)
4812 err.span_suggestion_with_applicability(
4815 if snippet.ends_with(';') {
4816 format!("{} as {};", &snippet[..snippet.len() - 1], suggested_name)
4818 format!("{} as {}", snippet, suggested_name)
4820 Applicability::MachineApplicable,
4823 err.span_label(binding.span, rename_msg);
4828 self.name_already_seen.insert(name, span);
4832 fn is_self_type(path: &[Ident], namespace: Namespace) -> bool {
4833 namespace == TypeNS && path.len() == 1 && path[0].name == keywords::SelfType.name()
4836 fn is_self_value(path: &[Ident], namespace: Namespace) -> bool {
4837 namespace == ValueNS && path.len() == 1 && path[0].name == keywords::SelfValue.name()
4840 fn names_to_string(idents: &[Ident]) -> String {
4841 let mut result = String::new();
4842 for (i, ident) in idents.iter()
4843 .filter(|ident| ident.name != keywords::CrateRoot.name())
4846 result.push_str("::");
4848 result.push_str(&ident.as_str());
4853 fn path_names_to_string(path: &Path) -> String {
4854 names_to_string(&path.segments.iter()
4855 .map(|seg| seg.ident)
4856 .collect::<Vec<_>>())
4859 /// Get the path for an enum and the variant from an `ImportSuggestion` for an enum variant.
4860 fn import_candidate_to_paths(suggestion: &ImportSuggestion) -> (Span, String, String) {
4861 let variant_path = &suggestion.path;
4862 let variant_path_string = path_names_to_string(variant_path);
4864 let path_len = suggestion.path.segments.len();
4865 let enum_path = ast::Path {
4866 span: suggestion.path.span,
4867 segments: suggestion.path.segments[0..path_len - 1].to_vec(),
4869 let enum_path_string = path_names_to_string(&enum_path);
4871 (suggestion.path.span, variant_path_string, enum_path_string)
4875 /// When an entity with a given name is not available in scope, we search for
4876 /// entities with that name in all crates. This method allows outputting the
4877 /// results of this search in a programmer-friendly way
4878 fn show_candidates(err: &mut DiagnosticBuilder,
4879 // This is `None` if all placement locations are inside expansions
4881 candidates: &[ImportSuggestion],
4885 // we want consistent results across executions, but candidates are produced
4886 // by iterating through a hash map, so make sure they are ordered:
4887 let mut path_strings: Vec<_> =
4888 candidates.into_iter().map(|c| path_names_to_string(&c.path)).collect();
4889 path_strings.sort();
4891 let better = if better { "better " } else { "" };
4892 let msg_diff = match path_strings.len() {
4893 1 => " is found in another module, you can import it",
4894 _ => "s are found in other modules, you can import them",
4896 let msg = format!("possible {}candidate{} into scope", better, msg_diff);
4898 if let Some(span) = span {
4899 for candidate in &mut path_strings {
4900 // produce an additional newline to separate the new use statement
4901 // from the directly following item.
4902 let additional_newline = if found_use {
4907 *candidate = format!("use {};\n{}", candidate, additional_newline);
4910 err.span_suggestions_with_applicability(
4914 Applicability::Unspecified,
4919 for candidate in path_strings {
4921 msg.push_str(&candidate);
4926 /// A somewhat inefficient routine to obtain the name of a module.
4927 fn module_to_string(module: Module) -> Option<String> {
4928 let mut names = Vec::new();
4930 fn collect_mod(names: &mut Vec<Ident>, module: Module) {
4931 if let ModuleKind::Def(_, name) = module.kind {
4932 if let Some(parent) = module.parent {
4933 names.push(Ident::with_empty_ctxt(name));
4934 collect_mod(names, parent);
4937 // danger, shouldn't be ident?
4938 names.push(Ident::from_str("<opaque>"));
4939 collect_mod(names, module.parent.unwrap());
4942 collect_mod(&mut names, module);
4944 if names.is_empty() {
4947 Some(names_to_string(&names.into_iter()
4949 .collect::<Vec<_>>()))
4952 fn err_path_resolution() -> PathResolution {
4953 PathResolution::new(Def::Err)
4956 #[derive(PartialEq,Copy, Clone)]
4957 pub enum MakeGlobMap {
4962 #[derive(Copy, Clone, Debug)]
4964 /// Do not issue the lint
4967 /// This lint applies to some random path like `impl ::foo::Bar`
4968 /// or whatever. In this case, we can take the span of that path.
4971 /// This lint comes from a `use` statement. In this case, what we
4972 /// care about really is the *root* `use` statement; e.g., if we
4973 /// have nested things like `use a::{b, c}`, we care about the
4975 UsePath { root_id: NodeId, root_span: Span },
4977 /// This is the "trait item" from a fully qualified path. For example,
4978 /// we might be resolving `X::Y::Z` from a path like `<T as X::Y>::Z`.
4979 /// The `path_span` is the span of the to the trait itself (`X::Y`).
4980 QPathTrait { qpath_id: NodeId, qpath_span: Span },
4984 fn node_id(&self) -> Option<NodeId> {
4986 CrateLint::No => None,
4987 CrateLint::SimplePath(id) |
4988 CrateLint::UsePath { root_id: id, .. } |
4989 CrateLint::QPathTrait { qpath_id: id, .. } => Some(id),
4994 __build_diagnostic_array! { librustc_resolve, DIAGNOSTICS }