1 //! This crate is responsible for the part of name resolution that doesn't require type checker.
3 //! Module structure of the crate is built here.
4 //! Paths in macros, imports, expressions, types, patterns are resolved here.
5 //! Label names are resolved here as well.
7 //! Type-relative name resolution (methods, fields, associated items) happens in `librustc_typeck`.
8 //! Lifetime names are resolved in `librustc/middle/resolve_lifetime.rs`.
10 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
12 #![feature(crate_visibility_modifier)]
13 #![feature(label_break_value)]
16 #![recursion_limit="256"]
18 pub use rustc::hir::def::{Namespace, PerNS};
22 use rustc::hir::map::Definitions;
23 use rustc::hir::{self, PrimTy, Bool, Char, Float, Int, Uint, Str};
24 use rustc::middle::cstore::{CrateStore, MetadataLoaderDyn};
25 use rustc::session::Session;
27 use rustc::hir::def::{self, DefKind, PartialRes, CtorKind, CtorOf, NonMacroAttrKind, ExportMap};
28 use rustc::hir::def::Namespace::*;
29 use rustc::hir::def_id::{CRATE_DEF_INDEX, LOCAL_CRATE, CrateNum, DefId};
30 use rustc::hir::{TraitMap, GlobMap};
31 use rustc::ty::{self, DefIdTree, ResolverOutputs};
32 use rustc::util::nodemap::{NodeMap, NodeSet, FxHashMap, FxHashSet, DefIdMap};
35 use rustc_metadata::creader::CrateLoader;
36 use rustc_metadata::cstore::CStore;
38 use syntax::{struct_span_err, unwrap_or};
39 use syntax::ast::{self, Name, NodeId, Ident, FloatTy, IntTy, UintTy};
40 use syntax::ast::{CRATE_NODE_ID, Crate};
41 use syntax::ast::{ItemKind, Path};
43 use syntax::print::pprust;
44 use syntax::symbol::{kw, sym};
45 use syntax::source_map::Spanned;
46 use syntax::visit::{self, Visitor};
47 use syntax_expand::base::SyntaxExtension;
48 use syntax_pos::hygiene::{MacroKind, ExpnId, Transparency, SyntaxContext};
49 use syntax_pos::{Span, DUMMY_SP};
50 use errors::{Applicability, DiagnosticBuilder};
54 use std::cell::{Cell, RefCell};
55 use std::{cmp, fmt, iter, ptr};
56 use std::collections::BTreeSet;
57 use rustc_data_structures::ptr_key::PtrKey;
58 use rustc_data_structures::sync::Lrc;
59 use rustc_data_structures::fx::FxIndexMap;
61 use diagnostics::{Suggestion, ImportSuggestion};
62 use diagnostics::{find_span_of_binding_until_next_binding, extend_span_to_previous_binding};
63 use late::{HasGenericParams, PathSource, Rib, RibKind::*};
64 use resolve_imports::{ImportDirective, ImportDirectiveSubclass, NameResolution, ImportResolver};
65 use macros::{LegacyBinding, LegacyScope};
67 type Res = def::Res<NodeId>;
74 mod build_reduced_graph;
77 const KNOWN_TOOLS: &[Name] = &[sym::clippy, sym::rustfmt];
84 #[derive(Copy, Clone, PartialEq, Debug)]
85 pub enum Determinacy {
91 fn determined(determined: bool) -> Determinacy {
92 if determined { Determinacy::Determined } else { Determinacy::Undetermined }
96 /// A specific scope in which a name can be looked up.
97 /// This enum is currently used only for early resolution (imports and macros),
98 /// but not for late resolution yet.
99 #[derive(Clone, Copy)]
102 MacroRules(LegacyScope<'a>),
114 /// Names from different contexts may want to visit different subsets of all specific scopes
115 /// with different restrictions when looking up the resolution.
116 /// This enum is currently used only for early resolution (imports and macros),
117 /// but not for late resolution yet.
119 /// All scopes with the given namespace.
120 All(Namespace, /*is_import*/ bool),
121 /// Crate root, then extern prelude (used for mixed 2015-2018 mode in macros).
122 AbsolutePath(Namespace),
123 /// All scopes with macro namespace and the given macro kind restriction.
127 /// Everything you need to know about a name's location to resolve it.
128 /// Serves as a starting point for the scope visitor.
129 /// This struct is currently used only for early resolution (imports and macros),
130 /// but not for late resolution yet.
131 #[derive(Clone, Copy, Debug)]
132 pub struct ParentScope<'a> {
135 legacy: LegacyScope<'a>,
136 derives: &'a [ast::Path],
139 impl<'a> ParentScope<'a> {
140 /// Creates a parent scope with the passed argument used as the module scope component,
141 /// and other scope components set to default empty values.
142 pub fn module(module: Module<'a>) -> ParentScope<'a> {
145 expansion: ExpnId::root(),
146 legacy: LegacyScope::Empty,
153 struct BindingError {
155 origin: BTreeSet<Span>,
156 target: BTreeSet<Span>,
160 impl PartialOrd for BindingError {
161 fn partial_cmp(&self, other: &BindingError) -> Option<cmp::Ordering> {
162 Some(self.cmp(other))
166 impl PartialEq for BindingError {
167 fn eq(&self, other: &BindingError) -> bool {
168 self.name == other.name
172 impl Ord for BindingError {
173 fn cmp(&self, other: &BindingError) -> cmp::Ordering {
174 self.name.cmp(&other.name)
178 enum ResolutionError<'a> {
179 /// Error E0401: can't use type or const parameters from outer function.
180 GenericParamsFromOuterFunction(Res, HasGenericParams),
181 /// Error E0403: the name is already used for a type or const parameter in this generic
183 NameAlreadyUsedInParameterList(Name, Span),
184 /// Error E0407: method is not a member of trait.
185 MethodNotMemberOfTrait(Name, &'a str),
186 /// Error E0437: type is not a member of trait.
187 TypeNotMemberOfTrait(Name, &'a str),
188 /// Error E0438: const is not a member of trait.
189 ConstNotMemberOfTrait(Name, &'a str),
190 /// Error E0408: variable `{}` is not bound in all patterns.
191 VariableNotBoundInPattern(&'a BindingError),
192 /// Error E0409: variable `{}` is bound in inconsistent ways within the same match arm.
193 VariableBoundWithDifferentMode(Name, Span),
194 /// Error E0415: identifier is bound more than once in this parameter list.
195 IdentifierBoundMoreThanOnceInParameterList(&'a str),
196 /// Error E0416: identifier is bound more than once in the same pattern.
197 IdentifierBoundMoreThanOnceInSamePattern(&'a str),
198 /// Error E0426: use of undeclared label.
199 UndeclaredLabel(&'a str, Option<Name>),
200 /// Error E0429: `self` imports are only allowed within a `{ }` list.
201 SelfImportsOnlyAllowedWithin,
202 /// Error E0430: `self` import can only appear once in the list.
203 SelfImportCanOnlyAppearOnceInTheList,
204 /// Error E0431: `self` import can only appear in an import list with a non-empty prefix.
205 SelfImportOnlyInImportListWithNonEmptyPrefix,
206 /// Error E0433: failed to resolve.
207 FailedToResolve { label: String, suggestion: Option<Suggestion> },
208 /// Error E0434: can't capture dynamic environment in a fn item.
209 CannotCaptureDynamicEnvironmentInFnItem,
210 /// Error E0435: attempt to use a non-constant value in a constant.
211 AttemptToUseNonConstantValueInConstant,
212 /// Error E0530: `X` bindings cannot shadow `Y`s.
213 BindingShadowsSomethingUnacceptable(&'a str, Name, &'a NameBinding<'a>),
214 /// Error E0128: type parameters with a default cannot use forward-declared identifiers.
215 ForwardDeclaredTyParam, // FIXME(const_generics:defaults)
216 /// Error E0735: type parameters with a default cannot use `Self`
217 SelfInTyParamDefault,
220 // A minimal representation of a path segment. We use this in resolve because
221 // we synthesize 'path segments' which don't have the rest of an AST or HIR
223 #[derive(Clone, Copy, Debug)]
230 fn from_path(path: &Path) -> Vec<Segment> {
231 path.segments.iter().map(|s| s.into()).collect()
234 fn from_ident(ident: Ident) -> Segment {
241 fn names_to_string(segments: &[Segment]) -> String {
242 names_to_string(&segments.iter()
243 .map(|seg| seg.ident.name)
244 .collect::<Vec<_>>())
248 impl<'a> From<&'a ast::PathSegment> for Segment {
249 fn from(seg: &'a ast::PathSegment) -> Segment {
257 struct UsePlacementFinder {
258 target_module: NodeId,
263 impl UsePlacementFinder {
264 fn check(krate: &Crate, target_module: NodeId) -> (Option<Span>, bool) {
265 let mut finder = UsePlacementFinder {
270 visit::walk_crate(&mut finder, krate);
271 (finder.span, finder.found_use)
275 impl<'tcx> Visitor<'tcx> for UsePlacementFinder {
278 module: &'tcx ast::Mod,
280 _: &[ast::Attribute],
283 if self.span.is_some() {
286 if node_id != self.target_module {
287 visit::walk_mod(self, module);
290 // find a use statement
291 for item in &module.items {
293 ItemKind::Use(..) => {
294 // don't suggest placing a use before the prelude
295 // import or other generated ones
296 if !item.span.from_expansion() {
297 self.span = Some(item.span.shrink_to_lo());
298 self.found_use = true;
302 // don't place use before extern crate
303 ItemKind::ExternCrate(_) => {}
304 // but place them before the first other item
305 _ => if self.span.map_or(true, |span| item.span < span ) {
306 if !item.span.from_expansion() {
307 // don't insert between attributes and an item
308 if item.attrs.is_empty() {
309 self.span = Some(item.span.shrink_to_lo());
311 // find the first attribute on the item
312 for attr in &item.attrs {
313 if self.span.map_or(true, |span| attr.span < span) {
314 self.span = Some(attr.span.shrink_to_lo());
325 /// An intermediate resolution result.
327 /// This refers to the thing referred by a name. The difference between `Res` and `Item` is that
328 /// items are visible in their whole block, while `Res`es only from the place they are defined
331 enum LexicalScopeBinding<'a> {
332 Item(&'a NameBinding<'a>),
336 impl<'a> LexicalScopeBinding<'a> {
337 fn item(self) -> Option<&'a NameBinding<'a>> {
339 LexicalScopeBinding::Item(binding) => Some(binding),
344 fn res(self) -> Res {
346 LexicalScopeBinding::Item(binding) => binding.res(),
347 LexicalScopeBinding::Res(res) => res,
352 #[derive(Copy, Clone, Debug)]
353 enum ModuleOrUniformRoot<'a> {
357 /// Virtual module that denotes resolution in crate root with fallback to extern prelude.
358 CrateRootAndExternPrelude,
360 /// Virtual module that denotes resolution in extern prelude.
361 /// Used for paths starting with `::` on 2018 edition.
364 /// Virtual module that denotes resolution in current scope.
365 /// Used only for resolving single-segment imports. The reason it exists is that import paths
366 /// are always split into two parts, the first of which should be some kind of module.
370 impl ModuleOrUniformRoot<'_> {
371 fn same_def(lhs: Self, rhs: Self) -> bool {
373 (ModuleOrUniformRoot::Module(lhs),
374 ModuleOrUniformRoot::Module(rhs)) => lhs.def_id() == rhs.def_id(),
375 (ModuleOrUniformRoot::CrateRootAndExternPrelude,
376 ModuleOrUniformRoot::CrateRootAndExternPrelude) |
377 (ModuleOrUniformRoot::ExternPrelude, ModuleOrUniformRoot::ExternPrelude) |
378 (ModuleOrUniformRoot::CurrentScope, ModuleOrUniformRoot::CurrentScope) => true,
384 #[derive(Clone, Debug)]
385 enum PathResult<'a> {
386 Module(ModuleOrUniformRoot<'a>),
387 NonModule(PartialRes),
392 suggestion: Option<Suggestion>,
393 is_error_from_last_segment: bool,
398 /// An anonymous module; e.g., just a block.
403 /// { // This is an anonymous module
404 /// f(); // This resolves to (2) as we are inside the block.
407 /// f(); // Resolves to (1)
411 /// Any module with a name.
415 /// * A normal module ‒ either `mod from_file;` or `mod from_block { }`.
416 /// * A trait or an enum (it implicitly contains associated types, methods and variant
418 Def(DefKind, DefId, Name),
422 /// Get name of the module.
423 pub fn name(&self) -> Option<Name> {
425 ModuleKind::Block(..) => None,
426 ModuleKind::Def(.., name) => Some(*name),
431 /// A key that identifies a binding in a given `Module`.
433 /// Multiple bindings in the same module can have the same key (in a valid
434 /// program) if all but one of them come from glob imports.
435 #[derive(Copy, Clone, PartialEq, Eq, Hash)]
437 /// The identifier for the binding, aways the `modern` version of the
441 /// 0 if ident is not `_`, otherwise a value that's unique to the specific
442 /// `_` in the expanded AST that introduced this binding.
446 type Resolutions<'a> = RefCell<FxIndexMap<BindingKey, &'a RefCell<NameResolution<'a>>>>;
448 /// One node in the tree of modules.
449 pub struct ModuleData<'a> {
450 parent: Option<Module<'a>>,
453 // The def id of the closest normal module (`mod`) ancestor (including this module).
454 normal_ancestor_id: DefId,
456 // Mapping between names and their (possibly in-progress) resolutions in this module.
457 // Resolutions in modules from other crates are not populated until accessed.
458 lazy_resolutions: Resolutions<'a>,
459 // True if this is a module from other crate that needs to be populated on access.
460 populate_on_access: Cell<bool>,
462 // Macro invocations that can expand into items in this module.
463 unexpanded_invocations: RefCell<FxHashSet<ExpnId>>,
465 no_implicit_prelude: bool,
467 glob_importers: RefCell<Vec<&'a ImportDirective<'a>>>,
468 globs: RefCell<Vec<&'a ImportDirective<'a>>>,
470 // Used to memoize the traits in this module for faster searches through all traits in scope.
471 traits: RefCell<Option<Box<[(Ident, &'a NameBinding<'a>)]>>>,
473 /// Span of the module itself. Used for error reporting.
479 type Module<'a> = &'a ModuleData<'a>;
481 impl<'a> ModuleData<'a> {
482 fn new(parent: Option<Module<'a>>,
484 normal_ancestor_id: DefId,
486 span: Span) -> Self {
491 lazy_resolutions: Default::default(),
492 populate_on_access: Cell::new(!normal_ancestor_id.is_local()),
493 unexpanded_invocations: Default::default(),
494 no_implicit_prelude: false,
495 glob_importers: RefCell::new(Vec::new()),
496 globs: RefCell::new(Vec::new()),
497 traits: RefCell::new(None),
503 fn for_each_child<R, F>(&'a self, resolver: &mut R, mut f: F)
504 where R: AsMut<Resolver<'a>>, F: FnMut(&mut R, Ident, Namespace, &'a NameBinding<'a>)
506 for (key, name_resolution) in resolver.as_mut().resolutions(self).borrow().iter() {
507 name_resolution.borrow().binding.map(|binding| f(resolver, key.ident, key.ns, binding));
511 fn res(&self) -> Option<Res> {
513 ModuleKind::Def(kind, def_id, _) => Some(Res::Def(kind, def_id)),
518 fn def_id(&self) -> Option<DefId> {
520 ModuleKind::Def(_, def_id, _) => Some(def_id),
525 // `self` resolves to the first module ancestor that `is_normal`.
526 fn is_normal(&self) -> bool {
528 ModuleKind::Def(DefKind::Mod, _, _) => true,
533 fn is_trait(&self) -> bool {
535 ModuleKind::Def(DefKind::Trait, _, _) => true,
540 fn nearest_item_scope(&'a self) -> Module<'a> {
542 ModuleKind::Def(DefKind::Enum, ..) | ModuleKind::Def(DefKind::Trait, ..) =>
543 self.parent.expect("enum or trait module without a parent"),
548 fn is_ancestor_of(&self, mut other: &Self) -> bool {
549 while !ptr::eq(self, other) {
550 if let Some(parent) = other.parent {
560 impl<'a> fmt::Debug for ModuleData<'a> {
561 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
562 write!(f, "{:?}", self.res())
566 /// Records a possibly-private value, type, or module definition.
567 #[derive(Clone, Debug)]
568 pub struct NameBinding<'a> {
569 kind: NameBindingKind<'a>,
570 ambiguity: Option<(&'a NameBinding<'a>, AmbiguityKind)>,
576 pub trait ToNameBinding<'a> {
577 fn to_name_binding(self, arenas: &'a ResolverArenas<'a>) -> &'a NameBinding<'a>;
580 impl<'a> ToNameBinding<'a> for &'a NameBinding<'a> {
581 fn to_name_binding(self, _: &'a ResolverArenas<'a>) -> &'a NameBinding<'a> {
586 #[derive(Clone, Debug)]
587 enum NameBindingKind<'a> {
588 Res(Res, /* is_macro_export */ bool),
591 binding: &'a NameBinding<'a>,
592 directive: &'a ImportDirective<'a>,
597 impl<'a> NameBindingKind<'a> {
598 /// Is this a name binding of a import?
599 fn is_import(&self) -> bool {
601 NameBindingKind::Import { .. } => true,
607 struct PrivacyError<'a>(Span, Ident, &'a NameBinding<'a>);
609 struct UseError<'a> {
610 err: DiagnosticBuilder<'a>,
611 /// Attach `use` statements for these candidates.
612 candidates: Vec<ImportSuggestion>,
613 /// The `NodeId` of the module to place the use-statements in.
615 /// Whether the diagnostic should state that it's "better".
619 #[derive(Clone, Copy, PartialEq, Debug)]
624 LegacyHelperVsPrelude,
633 fn descr(self) -> &'static str {
635 AmbiguityKind::Import =>
636 "name vs any other name during import resolution",
637 AmbiguityKind::BuiltinAttr =>
638 "built-in attribute vs any other name",
639 AmbiguityKind::DeriveHelper =>
640 "derive helper attribute vs any other name",
641 AmbiguityKind::LegacyHelperVsPrelude =>
642 "legacy plugin helper attribute vs name from prelude",
643 AmbiguityKind::LegacyVsModern =>
644 "`macro_rules` vs non-`macro_rules` from other module",
645 AmbiguityKind::GlobVsOuter =>
646 "glob import vs any other name from outer scope during import/macro resolution",
647 AmbiguityKind::GlobVsGlob =>
648 "glob import vs glob import in the same module",
649 AmbiguityKind::GlobVsExpanded =>
650 "glob import vs macro-expanded name in the same \
651 module during import/macro resolution",
652 AmbiguityKind::MoreExpandedVsOuter =>
653 "macro-expanded name vs less macro-expanded name \
654 from outer scope during import/macro resolution",
659 /// Miscellaneous bits of metadata for better ambiguity error reporting.
660 #[derive(Clone, Copy, PartialEq)]
661 enum AmbiguityErrorMisc {
668 struct AmbiguityError<'a> {
671 b1: &'a NameBinding<'a>,
672 b2: &'a NameBinding<'a>,
673 misc1: AmbiguityErrorMisc,
674 misc2: AmbiguityErrorMisc,
677 impl<'a> NameBinding<'a> {
678 fn module(&self) -> Option<Module<'a>> {
680 NameBindingKind::Module(module) => Some(module),
681 NameBindingKind::Import { binding, .. } => binding.module(),
686 fn res(&self) -> Res {
688 NameBindingKind::Res(res, _) => res,
689 NameBindingKind::Module(module) => module.res().unwrap(),
690 NameBindingKind::Import { binding, .. } => binding.res(),
694 fn is_ambiguity(&self) -> bool {
695 self.ambiguity.is_some() || match self.kind {
696 NameBindingKind::Import { binding, .. } => binding.is_ambiguity(),
701 // We sometimes need to treat variants as `pub` for backwards compatibility.
702 fn pseudo_vis(&self) -> ty::Visibility {
703 if self.is_variant() && self.res().def_id().is_local() {
704 ty::Visibility::Public
710 fn is_variant(&self) -> bool {
712 NameBindingKind::Res(Res::Def(DefKind::Variant, _), _) |
713 NameBindingKind::Res(Res::Def(DefKind::Ctor(CtorOf::Variant, ..), _), _) => true,
718 fn is_extern_crate(&self) -> bool {
720 NameBindingKind::Import {
721 directive: &ImportDirective {
722 subclass: ImportDirectiveSubclass::ExternCrate { .. }, ..
725 NameBindingKind::Module(
726 &ModuleData { kind: ModuleKind::Def(DefKind::Mod, def_id, _), .. }
727 ) => def_id.index == CRATE_DEF_INDEX,
732 fn is_import(&self) -> bool {
734 NameBindingKind::Import { .. } => true,
739 fn is_glob_import(&self) -> bool {
741 NameBindingKind::Import { directive, .. } => directive.is_glob(),
746 fn is_importable(&self) -> bool {
748 Res::Def(DefKind::AssocConst, _)
749 | Res::Def(DefKind::Method, _)
750 | Res::Def(DefKind::AssocTy, _) => false,
755 fn is_macro_def(&self) -> bool {
757 NameBindingKind::Res(Res::Def(DefKind::Macro(..), _), _) => true,
762 fn macro_kind(&self) -> Option<MacroKind> {
763 self.res().macro_kind()
766 // Suppose that we resolved macro invocation with `invoc_parent_expansion` to binding `binding`
767 // at some expansion round `max(invoc, binding)` when they both emerged from macros.
768 // Then this function returns `true` if `self` may emerge from a macro *after* that
769 // in some later round and screw up our previously found resolution.
770 // See more detailed explanation in
771 // https://github.com/rust-lang/rust/pull/53778#issuecomment-419224049
772 fn may_appear_after(&self, invoc_parent_expansion: ExpnId, binding: &NameBinding<'_>) -> bool {
773 // self > max(invoc, binding) => !(self <= invoc || self <= binding)
774 // Expansions are partially ordered, so "may appear after" is an inversion of
775 // "certainly appears before or simultaneously" and includes unordered cases.
776 let self_parent_expansion = self.expansion;
777 let other_parent_expansion = binding.expansion;
778 let certainly_before_other_or_simultaneously =
779 other_parent_expansion.is_descendant_of(self_parent_expansion);
780 let certainly_before_invoc_or_simultaneously =
781 invoc_parent_expansion.is_descendant_of(self_parent_expansion);
782 !(certainly_before_other_or_simultaneously || certainly_before_invoc_or_simultaneously)
786 /// Interns the names of the primitive types.
788 /// All other types are defined somewhere and possibly imported, but the primitive ones need
789 /// special handling, since they have no place of origin.
790 struct PrimitiveTypeTable {
791 primitive_types: FxHashMap<Name, PrimTy>,
794 impl PrimitiveTypeTable {
795 fn new() -> PrimitiveTypeTable {
796 let mut table = FxHashMap::default();
798 table.insert(sym::bool, Bool);
799 table.insert(sym::char, Char);
800 table.insert(sym::f32, Float(FloatTy::F32));
801 table.insert(sym::f64, Float(FloatTy::F64));
802 table.insert(sym::isize, Int(IntTy::Isize));
803 table.insert(sym::i8, Int(IntTy::I8));
804 table.insert(sym::i16, Int(IntTy::I16));
805 table.insert(sym::i32, Int(IntTy::I32));
806 table.insert(sym::i64, Int(IntTy::I64));
807 table.insert(sym::i128, Int(IntTy::I128));
808 table.insert(sym::str, Str);
809 table.insert(sym::usize, Uint(UintTy::Usize));
810 table.insert(sym::u8, Uint(UintTy::U8));
811 table.insert(sym::u16, Uint(UintTy::U16));
812 table.insert(sym::u32, Uint(UintTy::U32));
813 table.insert(sym::u64, Uint(UintTy::U64));
814 table.insert(sym::u128, Uint(UintTy::U128));
815 Self { primitive_types: table }
819 #[derive(Debug, Default, Clone)]
820 pub struct ExternPreludeEntry<'a> {
821 extern_crate_item: Option<&'a NameBinding<'a>>,
822 pub introduced_by_item: bool,
825 /// The main resolver class.
827 /// This is the visitor that walks the whole crate.
828 pub struct Resolver<'a> {
829 session: &'a Session,
831 definitions: Definitions,
833 graph_root: Module<'a>,
835 prelude: Option<Module<'a>>,
836 extern_prelude: FxHashMap<Ident, ExternPreludeEntry<'a>>,
838 /// N.B., this is used only for better diagnostics, not name resolution itself.
839 has_self: FxHashSet<DefId>,
841 /// Names of fields of an item `DefId` accessible with dot syntax.
842 /// Used for hints during error reporting.
843 field_names: FxHashMap<DefId, Vec<Spanned<Name>>>,
845 /// All imports known to succeed or fail.
846 determined_imports: Vec<&'a ImportDirective<'a>>,
848 /// All non-determined imports.
849 indeterminate_imports: Vec<&'a ImportDirective<'a>>,
851 /// FIXME: Refactor things so that these fields are passed through arguments and not resolver.
852 /// We are resolving a last import segment during import validation.
853 last_import_segment: bool,
854 /// This binding should be ignored during in-module resolution, so that we don't get
855 /// "self-confirming" import resolutions during import validation.
856 blacklisted_binding: Option<&'a NameBinding<'a>>,
858 /// The idents for the primitive types.
859 primitive_type_table: PrimitiveTypeTable,
861 /// Resolutions for nodes that have a single resolution.
862 partial_res_map: NodeMap<PartialRes>,
863 /// Resolutions for import nodes, which have multiple resolutions in different namespaces.
864 import_res_map: NodeMap<PerNS<Option<Res>>>,
865 /// Resolutions for labels (node IDs of their corresponding blocks or loops).
866 label_res_map: NodeMap<NodeId>,
868 /// `CrateNum` resolutions of `extern crate` items.
869 extern_crate_map: NodeMap<CrateNum>,
870 export_map: ExportMap<NodeId>,
873 /// A map from nodes to anonymous modules.
874 /// Anonymous modules are pseudo-modules that are implicitly created around items
875 /// contained within blocks.
877 /// For example, if we have this:
885 /// There will be an anonymous module created around `g` with the ID of the
886 /// entry block for `f`.
887 block_map: NodeMap<Module<'a>>,
888 /// A fake module that contains no definition and no prelude. Used so that
889 /// some AST passes can generate identifiers that only resolve to local or
891 empty_module: Module<'a>,
892 module_map: FxHashMap<DefId, Module<'a>>,
893 extern_module_map: FxHashMap<DefId, Module<'a>>,
894 binding_parent_modules: FxHashMap<PtrKey<'a, NameBinding<'a>>, Module<'a>>,
895 underscore_disambiguator: u32,
897 /// Maps glob imports to the names of items actually imported.
900 used_imports: FxHashSet<(NodeId, Namespace)>,
901 maybe_unused_trait_imports: NodeSet,
902 maybe_unused_extern_crates: Vec<(NodeId, Span)>,
904 /// Privacy errors are delayed until the end in order to deduplicate them.
905 privacy_errors: Vec<PrivacyError<'a>>,
906 /// Ambiguity errors are delayed for deduplication.
907 ambiguity_errors: Vec<AmbiguityError<'a>>,
908 /// `use` injections are delayed for better placement and deduplication.
909 use_injections: Vec<UseError<'a>>,
910 /// Crate-local macro expanded `macro_export` referred to by a module-relative path.
911 macro_expanded_macro_export_errors: BTreeSet<(Span, Span)>,
913 arenas: &'a ResolverArenas<'a>,
914 dummy_binding: &'a NameBinding<'a>,
916 crate_loader: CrateLoader<'a>,
917 macro_names: FxHashSet<Ident>,
918 builtin_macros: FxHashMap<Name, SyntaxExtension>,
919 macro_use_prelude: FxHashMap<Name, &'a NameBinding<'a>>,
920 all_macros: FxHashMap<Name, Res>,
921 macro_map: FxHashMap<DefId, Lrc<SyntaxExtension>>,
922 dummy_ext_bang: Lrc<SyntaxExtension>,
923 dummy_ext_derive: Lrc<SyntaxExtension>,
924 non_macro_attrs: [Lrc<SyntaxExtension>; 2],
925 macro_defs: FxHashMap<ExpnId, DefId>,
926 local_macro_def_scopes: FxHashMap<NodeId, Module<'a>>,
927 ast_transform_scopes: FxHashMap<ExpnId, Module<'a>>,
928 unused_macros: NodeMap<Span>,
929 proc_macro_stubs: NodeSet,
930 /// Traces collected during macro resolution and validated when it's complete.
931 single_segment_macro_resolutions: Vec<(Ident, MacroKind, ParentScope<'a>,
932 Option<&'a NameBinding<'a>>)>,
933 multi_segment_macro_resolutions: Vec<(Vec<Segment>, Span, MacroKind, ParentScope<'a>,
935 builtin_attrs: Vec<(Ident, ParentScope<'a>)>,
936 /// `derive(Copy)` marks items they are applied to so they are treated specially later.
937 /// Derive macros cannot modify the item themselves and have to store the markers in the global
938 /// context, so they attach the markers to derive container IDs using this resolver table.
939 containers_deriving_copy: FxHashSet<ExpnId>,
940 /// Parent scopes in which the macros were invoked.
941 /// FIXME: `derives` are missing in these parent scopes and need to be taken from elsewhere.
942 invocation_parent_scopes: FxHashMap<ExpnId, ParentScope<'a>>,
943 /// Legacy scopes *produced* by expanding the macro invocations,
944 /// include all the `macro_rules` items and other invocations generated by them.
945 output_legacy_scopes: FxHashMap<ExpnId, LegacyScope<'a>>,
947 /// Avoid duplicated errors for "name already defined".
948 name_already_seen: FxHashMap<Name, Span>,
950 potentially_unused_imports: Vec<&'a ImportDirective<'a>>,
952 /// Table for mapping struct IDs into struct constructor IDs,
953 /// it's not used during normal resolution, only for better error reporting.
954 struct_constructors: DefIdMap<(Res, ty::Visibility)>,
956 /// Features enabled for this crate.
957 active_features: FxHashSet<Name>,
959 /// Stores enum visibilities to properly build a reduced graph
960 /// when visiting the correspondent variants.
961 variant_vis: DefIdMap<ty::Visibility>,
963 lint_buffer: lint::LintBuffer,
966 /// Nothing really interesting here; it just provides memory for the rest of the crate.
968 pub struct ResolverArenas<'a> {
969 modules: arena::TypedArena<ModuleData<'a>>,
970 local_modules: RefCell<Vec<Module<'a>>>,
971 name_bindings: arena::TypedArena<NameBinding<'a>>,
972 import_directives: arena::TypedArena<ImportDirective<'a>>,
973 name_resolutions: arena::TypedArena<RefCell<NameResolution<'a>>>,
974 legacy_bindings: arena::TypedArena<LegacyBinding<'a>>,
975 ast_paths: arena::TypedArena<ast::Path>,
978 impl<'a> ResolverArenas<'a> {
979 fn alloc_module(&'a self, module: ModuleData<'a>) -> Module<'a> {
980 let module = self.modules.alloc(module);
981 if module.def_id().map(|def_id| def_id.is_local()).unwrap_or(true) {
982 self.local_modules.borrow_mut().push(module);
986 fn local_modules(&'a self) -> std::cell::Ref<'a, Vec<Module<'a>>> {
987 self.local_modules.borrow()
989 fn alloc_name_binding(&'a self, name_binding: NameBinding<'a>) -> &'a NameBinding<'a> {
990 self.name_bindings.alloc(name_binding)
992 fn alloc_import_directive(&'a self, import_directive: ImportDirective<'a>)
993 -> &'a ImportDirective<'_> {
994 self.import_directives.alloc(import_directive)
996 fn alloc_name_resolution(&'a self) -> &'a RefCell<NameResolution<'a>> {
997 self.name_resolutions.alloc(Default::default())
999 fn alloc_legacy_binding(&'a self, binding: LegacyBinding<'a>) -> &'a LegacyBinding<'a> {
1000 self.legacy_bindings.alloc(binding)
1002 fn alloc_ast_paths(&'a self, paths: &[ast::Path]) -> &'a [ast::Path] {
1003 self.ast_paths.alloc_from_iter(paths.iter().cloned())
1007 impl<'a> AsMut<Resolver<'a>> for Resolver<'a> {
1008 fn as_mut(&mut self) -> &mut Resolver<'a> { self }
1011 impl<'a, 'b> DefIdTree for &'a Resolver<'b> {
1012 fn parent(self, id: DefId) -> Option<DefId> {
1014 LOCAL_CRATE => self.definitions.def_key(id.index).parent,
1015 _ => self.cstore().def_key(id).parent,
1016 }.map(|index| DefId { index, ..id })
1020 /// This interface is used through the AST→HIR step, to embed full paths into the HIR. After that
1021 /// the resolver is no longer needed as all the relevant information is inline.
1022 impl<'a> hir::lowering::Resolver for Resolver<'a> {
1023 fn cstore(&self) -> &dyn CrateStore {
1027 fn resolve_str_path(
1030 crate_root: Option<Name>,
1031 components: &[Name],
1033 ) -> (ast::Path, Res) {
1034 let root = if crate_root.is_some() {
1039 let segments = iter::once(Ident::with_dummy_span(root))
1041 crate_root.into_iter()
1042 .chain(components.iter().cloned())
1043 .map(Ident::with_dummy_span)
1044 ).map(|i| self.new_ast_path_segment(i)).collect::<Vec<_>>();
1046 let path = ast::Path {
1051 let parent_scope = &ParentScope::module(self.graph_root);
1052 let res = match self.resolve_ast_path(&path, ns, parent_scope) {
1054 Err((span, error)) => {
1055 self.report_error(span, error);
1062 fn get_partial_res(&mut self, id: NodeId) -> Option<PartialRes> {
1063 self.partial_res_map.get(&id).cloned()
1066 fn get_import_res(&mut self, id: NodeId) -> PerNS<Option<Res>> {
1067 self.import_res_map.get(&id).cloned().unwrap_or_default()
1070 fn get_label_res(&mut self, id: NodeId) -> Option<NodeId> {
1071 self.label_res_map.get(&id).cloned()
1074 fn definitions(&mut self) -> &mut Definitions {
1075 &mut self.definitions
1078 fn lint_buffer(&mut self) -> &mut lint::LintBuffer {
1079 &mut self.lint_buffer
1083 impl<'a> Resolver<'a> {
1084 pub fn new(session: &'a Session,
1087 metadata_loader: &'a MetadataLoaderDyn,
1088 arenas: &'a ResolverArenas<'a>)
1090 let root_def_id = DefId::local(CRATE_DEF_INDEX);
1091 let root_module_kind = ModuleKind::Def(
1096 let graph_root = arenas.alloc_module(ModuleData {
1097 no_implicit_prelude: attr::contains_name(&krate.attrs, sym::no_implicit_prelude),
1098 ..ModuleData::new(None, root_module_kind, root_def_id, ExpnId::root(), krate.span)
1100 let empty_module_kind = ModuleKind::Def(
1105 let empty_module = arenas.alloc_module(ModuleData {
1106 no_implicit_prelude: true,
1115 let mut module_map = FxHashMap::default();
1116 module_map.insert(DefId::local(CRATE_DEF_INDEX), graph_root);
1118 let mut definitions = Definitions::default();
1119 definitions.create_root_def(crate_name, session.local_crate_disambiguator());
1121 let mut extern_prelude: FxHashMap<Ident, ExternPreludeEntry<'_>> =
1122 session.opts.externs.iter().map(|kv| (Ident::from_str(kv.0), Default::default()))
1125 if !attr::contains_name(&krate.attrs, sym::no_core) {
1126 extern_prelude.insert(Ident::with_dummy_span(sym::core), Default::default());
1127 if !attr::contains_name(&krate.attrs, sym::no_std) {
1128 extern_prelude.insert(Ident::with_dummy_span(sym::std), Default::default());
1129 if session.rust_2018() {
1130 extern_prelude.insert(Ident::with_dummy_span(sym::meta), Default::default());
1135 let mut invocation_parent_scopes = FxHashMap::default();
1136 invocation_parent_scopes.insert(ExpnId::root(), ParentScope::module(graph_root));
1138 let mut macro_defs = FxHashMap::default();
1139 macro_defs.insert(ExpnId::root(), root_def_id);
1141 let features = session.features_untracked();
1142 let non_macro_attr =
1143 |mark_used| Lrc::new(SyntaxExtension::non_macro_attr(mark_used, session.edition()));
1150 // The outermost module has def ID 0; this is not reflected in the
1156 has_self: FxHashSet::default(),
1157 field_names: FxHashMap::default(),
1159 determined_imports: Vec::new(),
1160 indeterminate_imports: Vec::new(),
1162 last_import_segment: false,
1163 blacklisted_binding: None,
1165 primitive_type_table: PrimitiveTypeTable::new(),
1167 partial_res_map: Default::default(),
1168 import_res_map: Default::default(),
1169 label_res_map: Default::default(),
1170 extern_crate_map: Default::default(),
1171 export_map: FxHashMap::default(),
1172 trait_map: Default::default(),
1173 underscore_disambiguator: 0,
1176 block_map: Default::default(),
1177 extern_module_map: FxHashMap::default(),
1178 binding_parent_modules: FxHashMap::default(),
1179 ast_transform_scopes: FxHashMap::default(),
1181 glob_map: Default::default(),
1183 used_imports: FxHashSet::default(),
1184 maybe_unused_trait_imports: Default::default(),
1185 maybe_unused_extern_crates: Vec::new(),
1187 privacy_errors: Vec::new(),
1188 ambiguity_errors: Vec::new(),
1189 use_injections: Vec::new(),
1190 macro_expanded_macro_export_errors: BTreeSet::new(),
1193 dummy_binding: arenas.alloc_name_binding(NameBinding {
1194 kind: NameBindingKind::Res(Res::Err, false),
1196 expansion: ExpnId::root(),
1198 vis: ty::Visibility::Public,
1201 crate_loader: CrateLoader::new(session, metadata_loader, crate_name),
1202 macro_names: FxHashSet::default(),
1203 builtin_macros: Default::default(),
1204 macro_use_prelude: FxHashMap::default(),
1205 all_macros: FxHashMap::default(),
1206 macro_map: FxHashMap::default(),
1207 dummy_ext_bang: Lrc::new(SyntaxExtension::dummy_bang(session.edition())),
1208 dummy_ext_derive: Lrc::new(SyntaxExtension::dummy_derive(session.edition())),
1209 non_macro_attrs: [non_macro_attr(false), non_macro_attr(true)],
1210 invocation_parent_scopes,
1211 output_legacy_scopes: Default::default(),
1213 local_macro_def_scopes: FxHashMap::default(),
1214 name_already_seen: FxHashMap::default(),
1215 potentially_unused_imports: Vec::new(),
1216 struct_constructors: Default::default(),
1217 unused_macros: Default::default(),
1218 proc_macro_stubs: Default::default(),
1219 single_segment_macro_resolutions: Default::default(),
1220 multi_segment_macro_resolutions: Default::default(),
1221 builtin_attrs: Default::default(),
1222 containers_deriving_copy: Default::default(),
1224 features.declared_lib_features.iter().map(|(feat, ..)| *feat)
1225 .chain(features.declared_lang_features.iter().map(|(feat, ..)| *feat))
1227 variant_vis: Default::default(),
1228 lint_buffer: lint::LintBuffer::default(),
1232 pub fn lint_buffer(&mut self) -> &mut lint::LintBuffer {
1233 &mut self.lint_buffer
1236 pub fn arenas() -> ResolverArenas<'a> {
1240 pub fn into_outputs(self) -> ResolverOutputs {
1242 definitions: self.definitions,
1243 cstore: Box::new(self.crate_loader.into_cstore()),
1244 extern_crate_map: self.extern_crate_map,
1245 export_map: self.export_map,
1246 trait_map: self.trait_map,
1247 glob_map: self.glob_map,
1248 maybe_unused_trait_imports: self.maybe_unused_trait_imports,
1249 maybe_unused_extern_crates: self.maybe_unused_extern_crates,
1250 extern_prelude: self.extern_prelude.iter().map(|(ident, entry)| {
1251 (ident.name, entry.introduced_by_item)
1256 pub fn clone_outputs(&self) -> ResolverOutputs {
1258 definitions: self.definitions.clone(),
1259 cstore: Box::new(self.cstore().clone()),
1260 extern_crate_map: self.extern_crate_map.clone(),
1261 export_map: self.export_map.clone(),
1262 trait_map: self.trait_map.clone(),
1263 glob_map: self.glob_map.clone(),
1264 maybe_unused_trait_imports: self.maybe_unused_trait_imports.clone(),
1265 maybe_unused_extern_crates: self.maybe_unused_extern_crates.clone(),
1266 extern_prelude: self.extern_prelude.iter().map(|(ident, entry)| {
1267 (ident.name, entry.introduced_by_item)
1272 pub fn cstore(&self) -> &CStore {
1273 self.crate_loader.cstore()
1276 fn non_macro_attr(&self, mark_used: bool) -> Lrc<SyntaxExtension> {
1277 self.non_macro_attrs[mark_used as usize].clone()
1280 fn dummy_ext(&self, macro_kind: MacroKind) -> Lrc<SyntaxExtension> {
1282 MacroKind::Bang => self.dummy_ext_bang.clone(),
1283 MacroKind::Derive => self.dummy_ext_derive.clone(),
1284 MacroKind::Attr => self.non_macro_attr(true),
1288 /// Runs the function on each namespace.
1289 fn per_ns<F: FnMut(&mut Self, Namespace)>(&mut self, mut f: F) {
1295 fn is_builtin_macro(&mut self, res: Res) -> bool {
1296 self.get_macro(res).map_or(false, |ext| ext.is_builtin)
1299 fn macro_def(&self, mut ctxt: SyntaxContext) -> DefId {
1301 match self.macro_defs.get(&ctxt.outer_expn()) {
1302 Some(&def_id) => return def_id,
1303 None => ctxt.remove_mark(),
1308 /// Entry point to crate resolution.
1309 pub fn resolve_crate(&mut self, krate: &Crate) {
1311 self.session.prof.generic_activity("resolve_crate");
1313 ImportResolver { r: self }.finalize_imports();
1314 self.finalize_macro_resolutions();
1316 self.late_resolve_crate(krate);
1318 self.check_unused(krate);
1319 self.report_errors(krate);
1320 self.crate_loader.postprocess(krate);
1327 normal_ancestor_id: DefId,
1331 let module = ModuleData::new(Some(parent), kind, normal_ancestor_id, expn_id, span);
1332 self.arenas.alloc_module(module)
1335 fn new_key(&mut self, ident: Ident, ns: Namespace) -> BindingKey {
1336 let ident = ident.modern();
1337 let disambiguator = if ident.name == kw::Underscore {
1338 self.underscore_disambiguator += 1;
1339 self.underscore_disambiguator
1343 BindingKey { ident, ns, disambiguator }
1346 fn resolutions(&mut self, module: Module<'a>) -> &'a Resolutions<'a> {
1347 if module.populate_on_access.get() {
1348 module.populate_on_access.set(false);
1349 self.build_reduced_graph_external(module);
1351 &module.lazy_resolutions
1354 fn resolution(&mut self, module: Module<'a>, key: BindingKey)
1355 -> &'a RefCell<NameResolution<'a>> {
1356 *self.resolutions(module).borrow_mut().entry(key)
1357 .or_insert_with(|| self.arenas.alloc_name_resolution())
1360 fn record_use(&mut self, ident: Ident, ns: Namespace,
1361 used_binding: &'a NameBinding<'a>, is_lexical_scope: bool) {
1362 if let Some((b2, kind)) = used_binding.ambiguity {
1363 self.ambiguity_errors.push(AmbiguityError {
1364 kind, ident, b1: used_binding, b2,
1365 misc1: AmbiguityErrorMisc::None,
1366 misc2: AmbiguityErrorMisc::None,
1369 if let NameBindingKind::Import { directive, binding, ref used } = used_binding.kind {
1370 // Avoid marking `extern crate` items that refer to a name from extern prelude,
1371 // but not introduce it, as used if they are accessed from lexical scope.
1372 if is_lexical_scope {
1373 if let Some(entry) = self.extern_prelude.get(&ident.modern()) {
1374 if let Some(crate_item) = entry.extern_crate_item {
1375 if ptr::eq(used_binding, crate_item) && !entry.introduced_by_item {
1382 directive.used.set(true);
1383 self.used_imports.insert((directive.id, ns));
1384 self.add_to_glob_map(&directive, ident);
1385 self.record_use(ident, ns, binding, false);
1390 fn add_to_glob_map(&mut self, directive: &ImportDirective<'_>, ident: Ident) {
1391 if directive.is_glob() {
1392 self.glob_map.entry(directive.id).or_default().insert(ident.name);
1396 /// A generic scope visitor.
1397 /// Visits scopes in order to resolve some identifier in them or perform other actions.
1398 /// If the callback returns `Some` result, we stop visiting scopes and return it.
1401 scope_set: ScopeSet,
1402 parent_scope: &ParentScope<'a>,
1404 mut visitor: impl FnMut(&mut Self, Scope<'a>, /*use_prelude*/ bool, Ident) -> Option<T>,
1406 // General principles:
1407 // 1. Not controlled (user-defined) names should have higher priority than controlled names
1408 // built into the language or standard library. This way we can add new names into the
1409 // language or standard library without breaking user code.
1410 // 2. "Closed set" below means new names cannot appear after the current resolution attempt.
1411 // Places to search (in order of decreasing priority):
1413 // 1. FIXME: Ribs (type parameters), there's no necessary infrastructure yet
1414 // (open set, not controlled).
1415 // 2. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1416 // (open, not controlled).
1417 // 3. Extern prelude (open, the open part is from macro expansions, not controlled).
1418 // 4. Tool modules (closed, controlled right now, but not in the future).
1419 // 5. Standard library prelude (de-facto closed, controlled).
1420 // 6. Language prelude (closed, controlled).
1422 // 1. FIXME: Ribs (local variables), there's no necessary infrastructure yet
1423 // (open set, not controlled).
1424 // 2. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1425 // (open, not controlled).
1426 // 3. Standard library prelude (de-facto closed, controlled).
1428 // 1-3. Derive helpers (open, not controlled). All ambiguities with other names
1429 // are currently reported as errors. They should be higher in priority than preludes
1430 // and probably even names in modules according to the "general principles" above. They
1431 // also should be subject to restricted shadowing because are effectively produced by
1432 // derives (you need to resolve the derive first to add helpers into scope), but they
1433 // should be available before the derive is expanded for compatibility.
1434 // It's mess in general, so we are being conservative for now.
1435 // 1-3. `macro_rules` (open, not controlled), loop through legacy scopes. Have higher
1436 // priority than prelude macros, but create ambiguities with macros in modules.
1437 // 1-3. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1438 // (open, not controlled). Have higher priority than prelude macros, but create
1439 // ambiguities with `macro_rules`.
1440 // 4. `macro_use` prelude (open, the open part is from macro expansions, not controlled).
1441 // 4a. User-defined prelude from macro-use
1442 // (open, the open part is from macro expansions, not controlled).
1443 // 4b. "Standard library prelude" part implemented through `macro-use` (closed, controlled).
1444 // 4c. Standard library prelude (de-facto closed, controlled).
1445 // 6. Language prelude: builtin attributes (closed, controlled).
1446 // 4-6. Legacy plugin helpers (open, not controlled). Similar to derive helpers,
1447 // but introduced by legacy plugins using `register_attribute`. Priority is somewhere
1448 // in prelude, not sure where exactly (creates ambiguities with any other prelude names).
1450 let rust_2015 = ident.span.rust_2015();
1451 let (ns, is_absolute_path) = match scope_set {
1452 ScopeSet::All(ns, _) => (ns, false),
1453 ScopeSet::AbsolutePath(ns) => (ns, true),
1454 ScopeSet::Macro(_) => (MacroNS, false),
1456 // Jump out of trait or enum modules, they do not act as scopes.
1457 let module = parent_scope.module.nearest_item_scope();
1458 let mut scope = match ns {
1459 _ if is_absolute_path => Scope::CrateRoot,
1460 TypeNS | ValueNS => Scope::Module(module),
1461 MacroNS => Scope::DeriveHelpers,
1463 let mut ident = ident.modern();
1464 let mut use_prelude = !module.no_implicit_prelude;
1467 let visit = match scope {
1468 Scope::DeriveHelpers => true,
1469 Scope::MacroRules(..) => true,
1470 Scope::CrateRoot => true,
1471 Scope::Module(..) => true,
1472 Scope::MacroUsePrelude => use_prelude || rust_2015,
1473 Scope::BuiltinAttrs => true,
1474 Scope::LegacyPluginHelpers => use_prelude || rust_2015,
1475 Scope::ExternPrelude => use_prelude || is_absolute_path,
1476 Scope::ToolPrelude => use_prelude,
1477 Scope::StdLibPrelude => use_prelude || ns == MacroNS,
1478 Scope::BuiltinTypes => true,
1482 if let break_result @ Some(..) = visitor(self, scope, use_prelude, ident) {
1483 return break_result;
1487 scope = match scope {
1488 Scope::DeriveHelpers =>
1489 Scope::MacroRules(parent_scope.legacy),
1490 Scope::MacroRules(legacy_scope) => match legacy_scope {
1491 LegacyScope::Binding(binding) => Scope::MacroRules(
1492 binding.parent_legacy_scope
1494 LegacyScope::Invocation(invoc_id) => Scope::MacroRules(
1495 self.output_legacy_scopes.get(&invoc_id).cloned()
1496 .unwrap_or(self.invocation_parent_scopes[&invoc_id].legacy)
1498 LegacyScope::Empty => Scope::Module(module),
1500 Scope::CrateRoot => match ns {
1502 ident.span.adjust(ExpnId::root());
1503 Scope::ExternPrelude
1505 ValueNS | MacroNS => break,
1507 Scope::Module(module) => {
1508 use_prelude = !module.no_implicit_prelude;
1509 match self.hygienic_lexical_parent(module, &mut ident.span) {
1510 Some(parent_module) => Scope::Module(parent_module),
1512 ident.span.adjust(ExpnId::root());
1514 TypeNS => Scope::ExternPrelude,
1515 ValueNS => Scope::StdLibPrelude,
1516 MacroNS => Scope::MacroUsePrelude,
1521 Scope::MacroUsePrelude => Scope::StdLibPrelude,
1522 Scope::BuiltinAttrs => Scope::LegacyPluginHelpers,
1523 Scope::LegacyPluginHelpers => break, // nowhere else to search
1524 Scope::ExternPrelude if is_absolute_path => break,
1525 Scope::ExternPrelude => Scope::ToolPrelude,
1526 Scope::ToolPrelude => Scope::StdLibPrelude,
1527 Scope::StdLibPrelude => match ns {
1528 TypeNS => Scope::BuiltinTypes,
1529 ValueNS => break, // nowhere else to search
1530 MacroNS => Scope::BuiltinAttrs,
1532 Scope::BuiltinTypes => break, // nowhere else to search
1539 /// This resolves the identifier `ident` in the namespace `ns` in the current lexical scope.
1540 /// More specifically, we proceed up the hierarchy of scopes and return the binding for
1541 /// `ident` in the first scope that defines it (or None if no scopes define it).
1543 /// A block's items are above its local variables in the scope hierarchy, regardless of where
1544 /// the items are defined in the block. For example,
1547 /// g(); // Since there are no local variables in scope yet, this resolves to the item.
1550 /// g(); // This resolves to the local variable `g` since it shadows the item.
1554 /// Invariant: This must only be called during main resolution, not during
1555 /// import resolution.
1556 fn resolve_ident_in_lexical_scope(&mut self,
1559 parent_scope: &ParentScope<'a>,
1560 record_used_id: Option<NodeId>,
1563 -> Option<LexicalScopeBinding<'a>> {
1564 assert!(ns == TypeNS || ns == ValueNS);
1565 if ident.name == kw::Invalid {
1566 return Some(LexicalScopeBinding::Res(Res::Err));
1568 let (general_span, modern_span) = if ident.name == kw::SelfUpper {
1569 // FIXME(jseyfried) improve `Self` hygiene
1570 let empty_span = ident.span.with_ctxt(SyntaxContext::root());
1571 (empty_span, empty_span)
1572 } else if ns == TypeNS {
1573 let modern_span = ident.span.modern();
1574 (modern_span, modern_span)
1576 (ident.span.modern_and_legacy(), ident.span.modern())
1578 ident.span = general_span;
1579 let modern_ident = Ident { span: modern_span, ..ident };
1581 // Walk backwards up the ribs in scope.
1582 let record_used = record_used_id.is_some();
1583 let mut module = self.graph_root;
1584 for i in (0 .. ribs.len()).rev() {
1585 debug!("walk rib\n{:?}", ribs[i].bindings);
1586 // Use the rib kind to determine whether we are resolving parameters
1587 // (modern hygiene) or local variables (legacy hygiene).
1588 let rib_ident = if ribs[i].kind.contains_params() {
1593 if let Some(res) = ribs[i].bindings.get(&rib_ident).cloned() {
1594 // The ident resolves to a type parameter or local variable.
1595 return Some(LexicalScopeBinding::Res(
1596 self.validate_res_from_ribs(i, rib_ident, res, record_used, path_span, ribs),
1600 module = match ribs[i].kind {
1601 ModuleRibKind(module) => module,
1602 MacroDefinition(def) if def == self.macro_def(ident.span.ctxt()) => {
1603 // If an invocation of this macro created `ident`, give up on `ident`
1604 // and switch to `ident`'s source from the macro definition.
1605 ident.span.remove_mark();
1612 let item = self.resolve_ident_in_module_unadjusted(
1613 ModuleOrUniformRoot::Module(module),
1620 if let Ok(binding) = item {
1621 // The ident resolves to an item.
1622 return Some(LexicalScopeBinding::Item(binding));
1626 ModuleKind::Block(..) => {}, // We can see through blocks
1631 ident = modern_ident;
1632 let mut poisoned = None;
1634 let opt_module = if let Some(node_id) = record_used_id {
1635 self.hygienic_lexical_parent_with_compatibility_fallback(module, &mut ident.span,
1636 node_id, &mut poisoned)
1638 self.hygienic_lexical_parent(module, &mut ident.span)
1640 module = unwrap_or!(opt_module, break);
1641 let adjusted_parent_scope = &ParentScope { module, ..*parent_scope };
1642 let result = self.resolve_ident_in_module_unadjusted(
1643 ModuleOrUniformRoot::Module(module),
1646 adjusted_parent_scope,
1653 if let Some(node_id) = poisoned {
1654 self.lint_buffer.buffer_lint_with_diagnostic(
1655 lint::builtin::PROC_MACRO_DERIVE_RESOLUTION_FALLBACK,
1656 node_id, ident.span,
1657 &format!("cannot find {} `{}` in this scope", ns.descr(), ident),
1658 lint::builtin::BuiltinLintDiagnostics::
1659 ProcMacroDeriveResolutionFallback(ident.span),
1662 return Some(LexicalScopeBinding::Item(binding))
1664 Err(Determined) => continue,
1665 Err(Undetermined) =>
1666 span_bug!(ident.span, "undetermined resolution during main resolution pass"),
1670 if !module.no_implicit_prelude {
1671 ident.span.adjust(ExpnId::root());
1673 if let Some(binding) = self.extern_prelude_get(ident, !record_used) {
1674 return Some(LexicalScopeBinding::Item(binding));
1677 if ns == TypeNS && KNOWN_TOOLS.contains(&ident.name) {
1678 let binding = (Res::ToolMod, ty::Visibility::Public,
1679 DUMMY_SP, ExpnId::root()).to_name_binding(self.arenas);
1680 return Some(LexicalScopeBinding::Item(binding));
1682 if let Some(prelude) = self.prelude {
1683 if let Ok(binding) = self.resolve_ident_in_module_unadjusted(
1684 ModuleOrUniformRoot::Module(prelude),
1691 return Some(LexicalScopeBinding::Item(binding));
1699 fn hygienic_lexical_parent(&mut self, module: Module<'a>, span: &mut Span)
1700 -> Option<Module<'a>> {
1701 if !module.expansion.outer_expn_is_descendant_of(span.ctxt()) {
1702 return Some(self.macro_def_scope(span.remove_mark()));
1705 if let ModuleKind::Block(..) = module.kind {
1706 return Some(module.parent.unwrap().nearest_item_scope());
1712 fn hygienic_lexical_parent_with_compatibility_fallback(&mut self, module: Module<'a>,
1713 span: &mut Span, node_id: NodeId,
1714 poisoned: &mut Option<NodeId>)
1715 -> Option<Module<'a>> {
1716 if let module @ Some(..) = self.hygienic_lexical_parent(module, span) {
1720 // We need to support the next case under a deprecation warning
1723 // ---- begin: this comes from a proc macro derive
1724 // mod implementation_details {
1725 // // Note that `MyStruct` is not in scope here.
1726 // impl SomeTrait for MyStruct { ... }
1730 // So we have to fall back to the module's parent during lexical resolution in this case.
1731 if let Some(parent) = module.parent {
1732 // Inner module is inside the macro, parent module is outside of the macro.
1733 if module.expansion != parent.expansion &&
1734 module.expansion.is_descendant_of(parent.expansion) {
1735 // The macro is a proc macro derive
1736 if let Some(&def_id) = self.macro_defs.get(&module.expansion) {
1737 if let Some(ext) = self.get_macro_by_def_id(def_id) {
1738 if !ext.is_builtin && ext.macro_kind() == MacroKind::Derive {
1739 if parent.expansion.outer_expn_is_descendant_of(span.ctxt()) {
1740 *poisoned = Some(node_id);
1741 return module.parent;
1752 fn resolve_ident_in_module(
1754 module: ModuleOrUniformRoot<'a>,
1757 parent_scope: &ParentScope<'a>,
1760 ) -> Result<&'a NameBinding<'a>, Determinacy> {
1761 self.resolve_ident_in_module_ext(
1762 module, ident, ns, parent_scope, record_used, path_span
1763 ).map_err(|(determinacy, _)| determinacy)
1766 fn resolve_ident_in_module_ext(
1768 module: ModuleOrUniformRoot<'a>,
1771 parent_scope: &ParentScope<'a>,
1774 ) -> Result<&'a NameBinding<'a>, (Determinacy, Weak)> {
1775 let tmp_parent_scope;
1776 let mut adjusted_parent_scope = parent_scope;
1778 ModuleOrUniformRoot::Module(m) => {
1779 if let Some(def) = ident.span.modernize_and_adjust(m.expansion) {
1781 ParentScope { module: self.macro_def_scope(def), ..*parent_scope };
1782 adjusted_parent_scope = &tmp_parent_scope;
1785 ModuleOrUniformRoot::ExternPrelude => {
1786 ident.span.modernize_and_adjust(ExpnId::root());
1788 ModuleOrUniformRoot::CrateRootAndExternPrelude |
1789 ModuleOrUniformRoot::CurrentScope => {
1793 let result = self.resolve_ident_in_module_unadjusted_ext(
1794 module, ident, ns, adjusted_parent_scope, false, record_used, path_span,
1799 fn resolve_crate_root(&mut self, ident: Ident) -> Module<'a> {
1800 let mut ctxt = ident.span.ctxt();
1801 let mark = if ident.name == kw::DollarCrate {
1802 // When resolving `$crate` from a `macro_rules!` invoked in a `macro`,
1803 // we don't want to pretend that the `macro_rules!` definition is in the `macro`
1804 // as described in `SyntaxContext::apply_mark`, so we ignore prepended modern marks.
1805 // FIXME: This is only a guess and it doesn't work correctly for `macro_rules!`
1806 // definitions actually produced by `macro` and `macro` definitions produced by
1807 // `macro_rules!`, but at least such configurations are not stable yet.
1808 ctxt = ctxt.modern_and_legacy();
1809 let mut iter = ctxt.marks().into_iter().rev().peekable();
1810 let mut result = None;
1811 // Find the last modern mark from the end if it exists.
1812 while let Some(&(mark, transparency)) = iter.peek() {
1813 if transparency == Transparency::Opaque {
1814 result = Some(mark);
1820 // Then find the last legacy mark from the end if it exists.
1821 for (mark, transparency) in iter {
1822 if transparency == Transparency::SemiTransparent {
1823 result = Some(mark);
1830 ctxt = ctxt.modern();
1831 ctxt.adjust(ExpnId::root())
1833 let module = match mark {
1834 Some(def) => self.macro_def_scope(def),
1835 None => return self.graph_root,
1837 self.get_module(DefId { index: CRATE_DEF_INDEX, ..module.normal_ancestor_id })
1840 fn resolve_self(&mut self, ctxt: &mut SyntaxContext, module: Module<'a>) -> Module<'a> {
1841 let mut module = self.get_module(module.normal_ancestor_id);
1842 while module.span.ctxt().modern() != *ctxt {
1843 let parent = module.parent.unwrap_or_else(|| self.macro_def_scope(ctxt.remove_mark()));
1844 module = self.get_module(parent.normal_ancestor_id);
1852 opt_ns: Option<Namespace>, // `None` indicates a module path in import
1853 parent_scope: &ParentScope<'a>,
1856 crate_lint: CrateLint,
1857 ) -> PathResult<'a> {
1858 self.resolve_path_with_ribs(
1859 path, opt_ns, parent_scope, record_used, path_span, crate_lint, None
1863 fn resolve_path_with_ribs(
1866 opt_ns: Option<Namespace>, // `None` indicates a module path in import
1867 parent_scope: &ParentScope<'a>,
1870 crate_lint: CrateLint,
1871 ribs: Option<&PerNS<Vec<Rib<'a>>>>,
1872 ) -> PathResult<'a> {
1873 let mut module = None;
1874 let mut allow_super = true;
1875 let mut second_binding = None;
1878 "resolve_path(path={:?}, opt_ns={:?}, record_used={:?}, \
1879 path_span={:?}, crate_lint={:?})",
1887 for (i, &Segment { ident, id }) in path.iter().enumerate() {
1888 debug!("resolve_path ident {} {:?} {:?}", i, ident, id);
1889 let record_segment_res = |this: &mut Self, res| {
1891 if let Some(id) = id {
1892 if !this.partial_res_map.contains_key(&id) {
1893 assert!(id != ast::DUMMY_NODE_ID, "Trying to resolve dummy id");
1894 this.record_partial_res(id, PartialRes::new(res));
1900 let is_last = i == path.len() - 1;
1901 let ns = if is_last { opt_ns.unwrap_or(TypeNS) } else { TypeNS };
1902 let name = ident.name;
1904 allow_super &= ns == TypeNS &&
1905 (name == kw::SelfLower ||
1909 if allow_super && name == kw::Super {
1910 let mut ctxt = ident.span.ctxt().modern();
1911 let self_module = match i {
1912 0 => Some(self.resolve_self(&mut ctxt, parent_scope.module)),
1914 Some(ModuleOrUniformRoot::Module(module)) => Some(module),
1918 if let Some(self_module) = self_module {
1919 if let Some(parent) = self_module.parent {
1920 module = Some(ModuleOrUniformRoot::Module(
1921 self.resolve_self(&mut ctxt, parent)));
1925 let msg = "there are too many initial `super`s.".to_string();
1926 return PathResult::Failed {
1930 is_error_from_last_segment: false,
1934 if name == kw::SelfLower {
1935 let mut ctxt = ident.span.ctxt().modern();
1936 module = Some(ModuleOrUniformRoot::Module(
1937 self.resolve_self(&mut ctxt, parent_scope.module)));
1940 if name == kw::PathRoot && ident.span.rust_2018() {
1941 module = Some(ModuleOrUniformRoot::ExternPrelude);
1944 if name == kw::PathRoot &&
1945 ident.span.rust_2015() && self.session.rust_2018() {
1946 // `::a::b` from 2015 macro on 2018 global edition
1947 module = Some(ModuleOrUniformRoot::CrateRootAndExternPrelude);
1950 if name == kw::PathRoot ||
1951 name == kw::Crate ||
1952 name == kw::DollarCrate {
1953 // `::a::b`, `crate::a::b` or `$crate::a::b`
1954 module = Some(ModuleOrUniformRoot::Module(
1955 self.resolve_crate_root(ident)));
1961 // Report special messages for path segment keywords in wrong positions.
1962 if ident.is_path_segment_keyword() && i != 0 {
1963 let name_str = if name == kw::PathRoot {
1964 "crate root".to_string()
1966 format!("`{}`", name)
1968 let label = if i == 1 && path[0].ident.name == kw::PathRoot {
1969 format!("global paths cannot start with {}", name_str)
1971 format!("{} in paths can only be used in start position", name_str)
1973 return PathResult::Failed {
1977 is_error_from_last_segment: false,
1981 let binding = if let Some(module) = module {
1982 self.resolve_ident_in_module(
1983 module, ident, ns, parent_scope, record_used, path_span
1985 } else if ribs.is_none() || opt_ns.is_none() || opt_ns == Some(MacroNS) {
1986 let scopes = ScopeSet::All(ns, opt_ns.is_none());
1987 self.early_resolve_ident_in_lexical_scope(ident, scopes, parent_scope, record_used,
1988 record_used, path_span)
1990 let record_used_id =
1991 if record_used { crate_lint.node_id().or(Some(CRATE_NODE_ID)) } else { None };
1992 match self.resolve_ident_in_lexical_scope(
1993 ident, ns, parent_scope, record_used_id, path_span, &ribs.unwrap()[ns]
1995 // we found a locally-imported or available item/module
1996 Some(LexicalScopeBinding::Item(binding)) => Ok(binding),
1997 // we found a local variable or type param
1998 Some(LexicalScopeBinding::Res(res))
1999 if opt_ns == Some(TypeNS) || opt_ns == Some(ValueNS) => {
2000 record_segment_res(self, res);
2001 return PathResult::NonModule(PartialRes::with_unresolved_segments(
2005 _ => Err(Determinacy::determined(record_used)),
2012 second_binding = Some(binding);
2014 let res = binding.res();
2015 let maybe_assoc = opt_ns != Some(MacroNS) && PathSource::Type.is_expected(res);
2016 if let Some(next_module) = binding.module() {
2017 module = Some(ModuleOrUniformRoot::Module(next_module));
2018 record_segment_res(self, res);
2019 } else if res == Res::ToolMod && i + 1 != path.len() {
2020 if binding.is_import() {
2021 self.session.struct_span_err(
2022 ident.span, "cannot use a tool module through an import"
2024 binding.span, "the tool module imported here"
2027 let res = Res::NonMacroAttr(NonMacroAttrKind::Tool);
2028 return PathResult::NonModule(PartialRes::new(res));
2029 } else if res == Res::Err {
2030 return PathResult::NonModule(PartialRes::new(Res::Err));
2031 } else if opt_ns.is_some() && (is_last || maybe_assoc) {
2032 self.lint_if_path_starts_with_module(
2038 return PathResult::NonModule(PartialRes::with_unresolved_segments(
2039 res, path.len() - i - 1
2042 let label = format!(
2043 "`{}` is {} {}, not a module",
2049 return PathResult::Failed {
2053 is_error_from_last_segment: is_last,
2057 Err(Undetermined) => return PathResult::Indeterminate,
2058 Err(Determined) => {
2059 if let Some(ModuleOrUniformRoot::Module(module)) = module {
2060 if opt_ns.is_some() && !module.is_normal() {
2061 return PathResult::NonModule(PartialRes::with_unresolved_segments(
2062 module.res().unwrap(), path.len() - i
2066 let module_res = match module {
2067 Some(ModuleOrUniformRoot::Module(module)) => module.res(),
2070 let (label, suggestion) = if module_res == self.graph_root.res() {
2071 let is_mod = |res| {
2072 match res { Res::Def(DefKind::Mod, _) => true, _ => false }
2074 let mut candidates =
2075 self.lookup_import_candidates(ident, TypeNS, is_mod);
2076 candidates.sort_by_cached_key(|c| {
2077 (c.path.segments.len(), pprust::path_to_string(&c.path))
2079 if let Some(candidate) = candidates.get(0) {
2081 String::from("unresolved import"),
2083 vec![(ident.span, pprust::path_to_string(&candidate.path))],
2084 String::from("a similar path exists"),
2085 Applicability::MaybeIncorrect,
2088 } else if !ident.is_reserved() {
2089 (format!("maybe a missing crate `{}`?", ident), None)
2091 // the parser will already have complained about the keyword being used
2092 return PathResult::NonModule(PartialRes::new(Res::Err));
2095 (format!("use of undeclared type or module `{}`", ident), None)
2097 (format!("could not find `{}` in `{}`", ident, path[i - 1].ident), None)
2099 return PathResult::Failed {
2103 is_error_from_last_segment: is_last,
2109 self.lint_if_path_starts_with_module(crate_lint, path, path_span, second_binding);
2111 PathResult::Module(match module {
2112 Some(module) => module,
2113 None if path.is_empty() => ModuleOrUniformRoot::CurrentScope,
2114 _ => span_bug!(path_span, "resolve_path: non-empty path `{:?}` has no module", path),
2118 fn lint_if_path_starts_with_module(
2120 crate_lint: CrateLint,
2123 second_binding: Option<&NameBinding<'_>>,
2125 let (diag_id, diag_span) = match crate_lint {
2126 CrateLint::No => return,
2127 CrateLint::SimplePath(id) => (id, path_span),
2128 CrateLint::UsePath { root_id, root_span } => (root_id, root_span),
2129 CrateLint::QPathTrait { qpath_id, qpath_span } => (qpath_id, qpath_span),
2132 let first_name = match path.get(0) {
2133 // In the 2018 edition this lint is a hard error, so nothing to do
2134 Some(seg) if seg.ident.span.rust_2015() && self.session.rust_2015() => seg.ident.name,
2138 // We're only interested in `use` paths which should start with
2139 // `{{root}}` currently.
2140 if first_name != kw::PathRoot {
2145 // If this import looks like `crate::...` it's already good
2146 Some(Segment { ident, .. }) if ident.name == kw::Crate => return,
2147 // Otherwise go below to see if it's an extern crate
2149 // If the path has length one (and it's `PathRoot` most likely)
2150 // then we don't know whether we're gonna be importing a crate or an
2151 // item in our crate. Defer this lint to elsewhere
2155 // If the first element of our path was actually resolved to an
2156 // `ExternCrate` (also used for `crate::...`) then no need to issue a
2157 // warning, this looks all good!
2158 if let Some(binding) = second_binding {
2159 if let NameBindingKind::Import { directive: d, .. } = binding.kind {
2160 // Careful: we still want to rewrite paths from
2161 // renamed extern crates.
2162 if let ImportDirectiveSubclass::ExternCrate { source: None, .. } = d.subclass {
2168 let diag = lint::builtin::BuiltinLintDiagnostics
2169 ::AbsPathWithModule(diag_span);
2170 self.lint_buffer.buffer_lint_with_diagnostic(
2171 lint::builtin::ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE,
2173 "absolute paths must start with `self`, `super`, \
2174 `crate`, or an external crate name in the 2018 edition",
2178 // Validate a local resolution (from ribs).
2179 fn validate_res_from_ribs(
2186 all_ribs: &[Rib<'a>],
2188 debug!("validate_res_from_ribs({:?})", res);
2189 let ribs = &all_ribs[rib_index + 1..];
2191 // An invalid forward use of a type parameter from a previous default.
2192 if let ForwardTyParamBanRibKind = all_ribs[rib_index].kind {
2194 let res_error = if rib_ident.name == kw::SelfUpper {
2195 ResolutionError::SelfInTyParamDefault
2197 ResolutionError::ForwardDeclaredTyParam
2199 self.report_error(span, res_error);
2201 assert_eq!(res, Res::Err);
2207 use ResolutionError::*;
2208 let mut res_err = None;
2212 NormalRibKind | ModuleRibKind(..) | MacroDefinition(..) |
2213 ForwardTyParamBanRibKind => {
2214 // Nothing to do. Continue.
2216 ItemRibKind(_) | FnItemRibKind | AssocItemRibKind => {
2217 // This was an attempt to access an upvar inside a
2218 // named function item. This is not allowed, so we
2221 // We don't immediately trigger a resolve error, because
2222 // we want certain other resolution errors (namely those
2223 // emitted for `ConstantItemRibKind` below) to take
2225 res_err = Some(CannotCaptureDynamicEnvironmentInFnItem);
2228 ConstantItemRibKind => {
2229 // Still doesn't deal with upvars
2231 self.report_error(span, AttemptToUseNonConstantValueInConstant);
2237 if let Some(res_err) = res_err {
2238 self.report_error(span, res_err);
2242 Res::Def(DefKind::TyParam, _) | Res::SelfTy(..) => {
2244 let has_generic_params = match rib.kind {
2245 NormalRibKind | AssocItemRibKind |
2246 ModuleRibKind(..) | MacroDefinition(..) | ForwardTyParamBanRibKind |
2247 ConstantItemRibKind => {
2248 // Nothing to do. Continue.
2251 // This was an attempt to use a type parameter outside its scope.
2252 ItemRibKind(has_generic_params) => has_generic_params,
2253 FnItemRibKind => HasGenericParams::Yes,
2257 self.report_error(span, ResolutionError::GenericParamsFromOuterFunction(
2258 res, has_generic_params));
2263 Res::Def(DefKind::ConstParam, _) => {
2264 let mut ribs = ribs.iter().peekable();
2265 if let Some(Rib { kind: FnItemRibKind, .. }) = ribs.peek() {
2266 // When declaring const parameters inside function signatures, the first rib
2267 // is always a `FnItemRibKind`. In this case, we can skip it, to avoid it
2268 // (spuriously) conflicting with the const param.
2272 let has_generic_params = match rib.kind {
2273 ItemRibKind(has_generic_params) => has_generic_params,
2274 FnItemRibKind => HasGenericParams::Yes,
2278 // This was an attempt to use a const parameter outside its scope.
2280 self.report_error(span, ResolutionError::GenericParamsFromOuterFunction(
2281 res, has_generic_params));
2291 fn record_partial_res(&mut self, node_id: NodeId, resolution: PartialRes) {
2292 debug!("(recording res) recording {:?} for {}", resolution, node_id);
2293 if let Some(prev_res) = self.partial_res_map.insert(node_id, resolution) {
2294 panic!("path resolved multiple times ({:?} before, {:?} now)", prev_res, resolution);
2298 fn is_accessible_from(&self, vis: ty::Visibility, module: Module<'a>) -> bool {
2299 vis.is_accessible_from(module.normal_ancestor_id, self)
2302 fn set_binding_parent_module(&mut self, binding: &'a NameBinding<'a>, module: Module<'a>) {
2303 if let Some(old_module) = self.binding_parent_modules.insert(PtrKey(binding), module) {
2304 if !ptr::eq(module, old_module) {
2305 span_bug!(binding.span, "parent module is reset for binding");
2310 fn disambiguate_legacy_vs_modern(
2312 legacy: &'a NameBinding<'a>,
2313 modern: &'a NameBinding<'a>,
2315 // Some non-controversial subset of ambiguities "modern macro name" vs "macro_rules"
2316 // is disambiguated to mitigate regressions from macro modularization.
2317 // Scoping for `macro_rules` behaves like scoping for `let` at module level, in general.
2318 match (self.binding_parent_modules.get(&PtrKey(legacy)),
2319 self.binding_parent_modules.get(&PtrKey(modern))) {
2320 (Some(legacy), Some(modern)) =>
2321 legacy.normal_ancestor_id == modern.normal_ancestor_id &&
2322 modern.is_ancestor_of(legacy),
2327 fn binding_description(&self, b: &NameBinding<'_>, ident: Ident, from_prelude: bool) -> String {
2329 if b.span.is_dummy() {
2330 let add_built_in = match b.res() {
2331 // These already contain the "built-in" prefix or look bad with it.
2332 Res::NonMacroAttr(..) | Res::PrimTy(..) | Res::ToolMod => false,
2335 let (built_in, from) = if from_prelude {
2336 ("", " from prelude")
2337 } else if b.is_extern_crate() && !b.is_import() &&
2338 self.session.opts.externs.get(&ident.as_str()).is_some() {
2339 ("", " passed with `--extern`")
2340 } else if add_built_in {
2346 let article = if built_in.is_empty() { res.article() } else { "a" };
2347 format!("{a}{built_in} {thing}{from}",
2348 a = article, thing = res.descr(), built_in = built_in, from = from)
2350 let introduced = if b.is_import() { "imported" } else { "defined" };
2351 format!("the {thing} {introduced} here",
2352 thing = res.descr(), introduced = introduced)
2356 fn report_ambiguity_error(&self, ambiguity_error: &AmbiguityError<'_>) {
2357 let AmbiguityError { kind, ident, b1, b2, misc1, misc2 } = *ambiguity_error;
2358 let (b1, b2, misc1, misc2, swapped) = if b2.span.is_dummy() && !b1.span.is_dummy() {
2359 // We have to print the span-less alternative first, otherwise formatting looks bad.
2360 (b2, b1, misc2, misc1, true)
2362 (b1, b2, misc1, misc2, false)
2365 let mut err = struct_span_err!(self.session, ident.span, E0659,
2366 "`{ident}` is ambiguous ({why})",
2367 ident = ident, why = kind.descr());
2368 err.span_label(ident.span, "ambiguous name");
2370 let mut could_refer_to = |b: &NameBinding<'_>, misc: AmbiguityErrorMisc, also: &str| {
2371 let what = self.binding_description(b, ident, misc == AmbiguityErrorMisc::FromPrelude);
2372 let note_msg = format!("`{ident}` could{also} refer to {what}",
2373 ident = ident, also = also, what = what);
2375 let thing = b.res().descr();
2376 let mut help_msgs = Vec::new();
2377 if b.is_glob_import() && (kind == AmbiguityKind::GlobVsGlob ||
2378 kind == AmbiguityKind::GlobVsExpanded ||
2379 kind == AmbiguityKind::GlobVsOuter &&
2380 swapped != also.is_empty()) {
2381 help_msgs.push(format!("consider adding an explicit import of \
2382 `{ident}` to disambiguate", ident = ident))
2384 if b.is_extern_crate() && ident.span.rust_2018() {
2385 help_msgs.push(format!(
2386 "use `::{ident}` to refer to this {thing} unambiguously",
2387 ident = ident, thing = thing,
2390 if misc == AmbiguityErrorMisc::SuggestCrate {
2391 help_msgs.push(format!(
2392 "use `crate::{ident}` to refer to this {thing} unambiguously",
2393 ident = ident, thing = thing,
2395 } else if misc == AmbiguityErrorMisc::SuggestSelf {
2396 help_msgs.push(format!(
2397 "use `self::{ident}` to refer to this {thing} unambiguously",
2398 ident = ident, thing = thing,
2402 err.span_note(b.span, ¬e_msg);
2403 for (i, help_msg) in help_msgs.iter().enumerate() {
2404 let or = if i == 0 { "" } else { "or " };
2405 err.help(&format!("{}{}", or, help_msg));
2409 could_refer_to(b1, misc1, "");
2410 could_refer_to(b2, misc2, " also");
2414 fn report_errors(&mut self, krate: &Crate) {
2415 self.report_with_use_injections(krate);
2417 for &(span_use, span_def) in &self.macro_expanded_macro_export_errors {
2418 let msg = "macro-expanded `macro_export` macros from the current crate \
2419 cannot be referred to by absolute paths";
2420 self.lint_buffer.buffer_lint_with_diagnostic(
2421 lint::builtin::MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS,
2422 CRATE_NODE_ID, span_use, msg,
2423 lint::builtin::BuiltinLintDiagnostics::
2424 MacroExpandedMacroExportsAccessedByAbsolutePaths(span_def),
2428 for ambiguity_error in &self.ambiguity_errors {
2429 self.report_ambiguity_error(ambiguity_error);
2432 let mut reported_spans = FxHashSet::default();
2433 for &PrivacyError(dedup_span, ident, binding) in &self.privacy_errors {
2434 if reported_spans.insert(dedup_span) {
2435 let session = &self.session;
2436 let mk_struct_span_error = |is_constructor| {
2441 "{}{} `{}` is private",
2442 binding.res().descr(),
2443 if is_constructor { " constructor"} else { "" },
2448 let mut err = if let NameBindingKind::Res(
2449 Res::Def(DefKind::Ctor(CtorOf::Struct, CtorKind::Fn), ctor_def_id), _
2451 let def_id = (&*self).parent(ctor_def_id).expect("no parent for a constructor");
2452 if let Some(fields) = self.field_names.get(&def_id) {
2453 let mut err = mk_struct_span_error(true);
2454 let first_field = fields.first().expect("empty field list in the map");
2456 fields.iter().fold(first_field.span, |acc, field| acc.to(field.span)),
2457 "a constructor is private if any of the fields is private",
2461 mk_struct_span_error(false)
2464 mk_struct_span_error(false)
2472 fn report_with_use_injections(&mut self, krate: &Crate) {
2473 for UseError { mut err, candidates, node_id, better } in self.use_injections.drain(..) {
2474 let (span, found_use) = UsePlacementFinder::check(krate, node_id);
2475 if !candidates.is_empty() {
2476 diagnostics::show_candidates(&mut err, span, &candidates, better, found_use);
2482 fn report_conflict<'b>(&mut self,
2486 new_binding: &NameBinding<'b>,
2487 old_binding: &NameBinding<'b>) {
2488 // Error on the second of two conflicting names
2489 if old_binding.span.lo() > new_binding.span.lo() {
2490 return self.report_conflict(parent, ident, ns, old_binding, new_binding);
2493 let container = match parent.kind {
2494 ModuleKind::Def(DefKind::Mod, _, _) => "module",
2495 ModuleKind::Def(DefKind::Trait, _, _) => "trait",
2496 ModuleKind::Block(..) => "block",
2500 let old_noun = match old_binding.is_import() {
2502 false => "definition",
2505 let new_participle = match new_binding.is_import() {
2510 let (name, span) = (ident.name, self.session.source_map().def_span(new_binding.span));
2512 if let Some(s) = self.name_already_seen.get(&name) {
2518 let old_kind = match (ns, old_binding.module()) {
2519 (ValueNS, _) => "value",
2520 (MacroNS, _) => "macro",
2521 (TypeNS, _) if old_binding.is_extern_crate() => "extern crate",
2522 (TypeNS, Some(module)) if module.is_normal() => "module",
2523 (TypeNS, Some(module)) if module.is_trait() => "trait",
2524 (TypeNS, _) => "type",
2527 let msg = format!("the name `{}` is defined multiple times", name);
2529 let mut err = match (old_binding.is_extern_crate(), new_binding.is_extern_crate()) {
2530 (true, true) => struct_span_err!(self.session, span, E0259, "{}", msg),
2531 (true, _) | (_, true) => match new_binding.is_import() && old_binding.is_import() {
2532 true => struct_span_err!(self.session, span, E0254, "{}", msg),
2533 false => struct_span_err!(self.session, span, E0260, "{}", msg),
2535 _ => match (old_binding.is_import(), new_binding.is_import()) {
2536 (false, false) => struct_span_err!(self.session, span, E0428, "{}", msg),
2537 (true, true) => struct_span_err!(self.session, span, E0252, "{}", msg),
2538 _ => struct_span_err!(self.session, span, E0255, "{}", msg),
2542 err.note(&format!("`{}` must be defined only once in the {} namespace of this {}",
2547 err.span_label(span, format!("`{}` re{} here", name, new_participle));
2549 self.session.source_map().def_span(old_binding.span),
2550 format!("previous {} of the {} `{}` here", old_noun, old_kind, name),
2553 // See https://github.com/rust-lang/rust/issues/32354
2554 use NameBindingKind::Import;
2555 let directive = match (&new_binding.kind, &old_binding.kind) {
2556 // If there are two imports where one or both have attributes then prefer removing the
2557 // import without attributes.
2558 (Import { directive: new, .. }, Import { directive: old, .. }) if {
2559 !new_binding.span.is_dummy() && !old_binding.span.is_dummy() &&
2560 (new.has_attributes || old.has_attributes)
2562 if old.has_attributes {
2563 Some((new, new_binding.span, true))
2565 Some((old, old_binding.span, true))
2568 // Otherwise prioritize the new binding.
2569 (Import { directive, .. }, other) if !new_binding.span.is_dummy() =>
2570 Some((directive, new_binding.span, other.is_import())),
2571 (other, Import { directive, .. }) if !old_binding.span.is_dummy() =>
2572 Some((directive, old_binding.span, other.is_import())),
2576 // Check if the target of the use for both bindings is the same.
2577 let duplicate = new_binding.res().opt_def_id() == old_binding.res().opt_def_id();
2578 let has_dummy_span = new_binding.span.is_dummy() || old_binding.span.is_dummy();
2579 let from_item = self.extern_prelude.get(&ident)
2580 .map(|entry| entry.introduced_by_item)
2582 // Only suggest removing an import if both bindings are to the same def, if both spans
2583 // aren't dummy spans. Further, if both bindings are imports, then the ident must have
2584 // been introduced by a item.
2585 let should_remove_import = duplicate && !has_dummy_span &&
2586 ((new_binding.is_extern_crate() || old_binding.is_extern_crate()) || from_item);
2589 Some((directive, span, true)) if should_remove_import && directive.is_nested() =>
2590 self.add_suggestion_for_duplicate_nested_use(&mut err, directive, span),
2591 Some((directive, _, true)) if should_remove_import && !directive.is_glob() => {
2592 // Simple case - remove the entire import. Due to the above match arm, this can
2593 // only be a single use so just remove it entirely.
2594 err.tool_only_span_suggestion(
2595 directive.use_span_with_attributes,
2596 "remove unnecessary import",
2598 Applicability::MaybeIncorrect,
2601 Some((directive, span, _)) =>
2602 self.add_suggestion_for_rename_of_use(&mut err, name, directive, span),
2607 self.name_already_seen.insert(name, span);
2610 /// This function adds a suggestion to change the binding name of a new import that conflicts
2611 /// with an existing import.
2613 /// ```ignore (diagnostic)
2614 /// help: you can use `as` to change the binding name of the import
2616 /// LL | use foo::bar as other_bar;
2617 /// | ^^^^^^^^^^^^^^^^^^^^^
2619 fn add_suggestion_for_rename_of_use(
2621 err: &mut DiagnosticBuilder<'_>,
2623 directive: &ImportDirective<'_>,
2626 let suggested_name = if name.as_str().chars().next().unwrap().is_uppercase() {
2627 format!("Other{}", name)
2629 format!("other_{}", name)
2632 let mut suggestion = None;
2633 match directive.subclass {
2634 ImportDirectiveSubclass::SingleImport { type_ns_only: true, .. } =>
2635 suggestion = Some(format!("self as {}", suggested_name)),
2636 ImportDirectiveSubclass::SingleImport { source, .. } => {
2637 if let Some(pos) = source.span.hi().0.checked_sub(binding_span.lo().0)
2638 .map(|pos| pos as usize) {
2639 if let Ok(snippet) = self.session.source_map()
2640 .span_to_snippet(binding_span) {
2641 if pos <= snippet.len() {
2642 suggestion = Some(format!(
2646 if snippet.ends_with(";") { ";" } else { "" }
2652 ImportDirectiveSubclass::ExternCrate { source, target, .. } =>
2653 suggestion = Some(format!(
2654 "extern crate {} as {};",
2655 source.unwrap_or(target.name),
2658 _ => unreachable!(),
2661 let rename_msg = "you can use `as` to change the binding name of the import";
2662 if let Some(suggestion) = suggestion {
2663 err.span_suggestion(
2667 Applicability::MaybeIncorrect,
2670 err.span_label(binding_span, rename_msg);
2674 /// This function adds a suggestion to remove a unnecessary binding from an import that is
2675 /// nested. In the following example, this function will be invoked to remove the `a` binding
2676 /// in the second use statement:
2678 /// ```ignore (diagnostic)
2679 /// use issue_52891::a;
2680 /// use issue_52891::{d, a, e};
2683 /// The following suggestion will be added:
2685 /// ```ignore (diagnostic)
2686 /// use issue_52891::{d, a, e};
2687 /// ^-- help: remove unnecessary import
2690 /// If the nested use contains only one import then the suggestion will remove the entire
2693 /// It is expected that the directive provided is a nested import - this isn't checked by the
2694 /// function. If this invariant is not upheld, this function's behaviour will be unexpected
2695 /// as characters expected by span manipulations won't be present.
2696 fn add_suggestion_for_duplicate_nested_use(
2698 err: &mut DiagnosticBuilder<'_>,
2699 directive: &ImportDirective<'_>,
2702 assert!(directive.is_nested());
2703 let message = "remove unnecessary import";
2705 // Two examples will be used to illustrate the span manipulations we're doing:
2707 // - Given `use issue_52891::{d, a, e};` where `a` is a duplicate then `binding_span` is
2708 // `a` and `directive.use_span` is `issue_52891::{d, a, e};`.
2709 // - Given `use issue_52891::{d, e, a};` where `a` is a duplicate then `binding_span` is
2710 // `a` and `directive.use_span` is `issue_52891::{d, e, a};`.
2712 let (found_closing_brace, span) = find_span_of_binding_until_next_binding(
2713 self.session, binding_span, directive.use_span,
2716 // If there was a closing brace then identify the span to remove any trailing commas from
2717 // previous imports.
2718 if found_closing_brace {
2719 if let Some(span) = extend_span_to_previous_binding(self.session, span) {
2720 err.tool_only_span_suggestion(span, message, String::new(),
2721 Applicability::MaybeIncorrect);
2723 // Remove the entire line if we cannot extend the span back, this indicates a
2724 // `issue_52891::{self}` case.
2725 err.span_suggestion(directive.use_span_with_attributes, message, String::new(),
2726 Applicability::MaybeIncorrect);
2732 err.span_suggestion(span, message, String::new(), Applicability::MachineApplicable);
2735 fn extern_prelude_get(&mut self, ident: Ident, speculative: bool)
2736 -> Option<&'a NameBinding<'a>> {
2737 if ident.is_path_segment_keyword() {
2738 // Make sure `self`, `super` etc produce an error when passed to here.
2741 self.extern_prelude.get(&ident.modern()).cloned().and_then(|entry| {
2742 if let Some(binding) = entry.extern_crate_item {
2743 if !speculative && entry.introduced_by_item {
2744 self.record_use(ident, TypeNS, binding, false);
2748 let crate_id = if !speculative {
2749 self.crate_loader.process_path_extern(ident.name, ident.span)
2750 } else if let Some(crate_id) =
2751 self.crate_loader.maybe_process_path_extern(ident.name, ident.span) {
2756 let crate_root = self.get_module(DefId { krate: crate_id, index: CRATE_DEF_INDEX });
2757 Some((crate_root, ty::Visibility::Public, DUMMY_SP, ExpnId::root())
2758 .to_name_binding(self.arenas))
2763 /// Rustdoc uses this to resolve things in a recoverable way. `ResolutionError<'a>`
2764 /// isn't something that can be returned because it can't be made to live that long,
2765 /// and also it's a private type. Fortunately rustdoc doesn't need to know the error,
2766 /// just that an error occurred.
2767 // FIXME(Manishearth): intra-doc links won't get warned of epoch changes.
2768 pub fn resolve_str_path_error(
2769 &mut self, span: Span, path_str: &str, ns: Namespace, module_id: NodeId
2770 ) -> Result<(ast::Path, Res), ()> {
2771 let path = if path_str.starts_with("::") {
2774 segments: iter::once(Ident::with_dummy_span(kw::PathRoot))
2776 path_str.split("::").skip(1).map(Ident::from_str)
2778 .map(|i| self.new_ast_path_segment(i))
2786 .map(Ident::from_str)
2787 .map(|i| self.new_ast_path_segment(i))
2791 let module = self.block_map.get(&module_id).copied().unwrap_or_else(|| {
2792 let def_id = self.definitions.local_def_id(module_id);
2793 self.module_map.get(&def_id).copied().unwrap_or(self.graph_root)
2795 let parent_scope = &ParentScope::module(module);
2796 let res = self.resolve_ast_path(&path, ns, parent_scope).map_err(|_| ())?;
2800 // Resolve a path passed from rustdoc or HIR lowering.
2801 fn resolve_ast_path(
2805 parent_scope: &ParentScope<'a>,
2806 ) -> Result<Res, (Span, ResolutionError<'a>)> {
2807 match self.resolve_path(
2808 &Segment::from_path(path), Some(ns), parent_scope, true, path.span, CrateLint::No
2810 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
2811 Ok(module.res().unwrap()),
2812 PathResult::NonModule(path_res) if path_res.unresolved_segments() == 0 =>
2813 Ok(path_res.base_res()),
2814 PathResult::NonModule(..) => {
2815 Err((path.span, ResolutionError::FailedToResolve {
2816 label: String::from("type-relative paths are not supported in this context"),
2820 PathResult::Module(..) | PathResult::Indeterminate => unreachable!(),
2821 PathResult::Failed { span, label, suggestion, .. } => {
2822 Err((span, ResolutionError::FailedToResolve {
2830 fn new_ast_path_segment(&self, ident: Ident) -> ast::PathSegment {
2831 let mut seg = ast::PathSegment::from_ident(ident);
2832 seg.id = self.session.next_node_id();
2837 pub fn graph_root(&self) -> Module<'a> {
2842 pub fn all_macros(&self) -> &FxHashMap<Name, Res> {
2847 fn names_to_string(names: &[Name]) -> String {
2848 let mut result = String::new();
2849 for (i, name) in names.iter()
2850 .filter(|name| **name != kw::PathRoot)
2853 result.push_str("::");
2855 result.push_str(&name.as_str());
2860 fn path_names_to_string(path: &Path) -> String {
2861 names_to_string(&path.segments.iter()
2862 .map(|seg| seg.ident.name)
2863 .collect::<Vec<_>>())
2866 /// A somewhat inefficient routine to obtain the name of a module.
2867 fn module_to_string(module: Module<'_>) -> Option<String> {
2868 let mut names = Vec::new();
2870 fn collect_mod(names: &mut Vec<Name>, module: Module<'_>) {
2871 if let ModuleKind::Def(.., name) = module.kind {
2872 if let Some(parent) = module.parent {
2874 collect_mod(names, parent);
2877 names.push(Name::intern("<opaque>"));
2878 collect_mod(names, module.parent.unwrap());
2881 collect_mod(&mut names, module);
2883 if names.is_empty() {
2887 Some(names_to_string(&names))
2890 #[derive(Copy, Clone, Debug)]
2892 /// Do not issue the lint.
2895 /// This lint applies to some arbitrary path; e.g., `impl ::foo::Bar`.
2896 /// In this case, we can take the span of that path.
2899 /// This lint comes from a `use` statement. In this case, what we
2900 /// care about really is the *root* `use` statement; e.g., if we
2901 /// have nested things like `use a::{b, c}`, we care about the
2903 UsePath { root_id: NodeId, root_span: Span },
2905 /// This is the "trait item" from a fully qualified path. For example,
2906 /// we might be resolving `X::Y::Z` from a path like `<T as X::Y>::Z`.
2907 /// The `path_span` is the span of the to the trait itself (`X::Y`).
2908 QPathTrait { qpath_id: NodeId, qpath_span: Span },
2912 fn node_id(&self) -> Option<NodeId> {
2914 CrateLint::No => None,
2915 CrateLint::SimplePath(id) |
2916 CrateLint::UsePath { root_id: id, .. } |
2917 CrateLint::QPathTrait { qpath_id: id, .. } => Some(id),