1 //! This crate is responsible for the part of name resolution that doesn't require type checker.
3 //! Module structure of the crate is built here.
4 //! Paths in macros, imports, expressions, types, patterns are resolved here.
5 //! Label names are resolved here as well.
7 //! Type-relative name resolution (methods, fields, associated items) happens in `librustc_typeck`.
8 //! Lifetime names are resolved in `librustc/middle/resolve_lifetime.rs`.
10 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
12 #![feature(crate_visibility_modifier)]
13 #![feature(label_break_value)]
16 #![feature(rustc_diagnostic_macros)]
18 #![recursion_limit="256"]
20 pub use rustc::hir::def::{Namespace, PerNS};
24 use rustc::hir::map::Definitions;
25 use rustc::hir::{self, PrimTy, Bool, Char, Float, Int, Uint, Str};
26 use rustc::middle::cstore::CrateStore;
27 use rustc::session::Session;
29 use rustc::hir::def::{self, DefKind, PartialRes, CtorKind, CtorOf, NonMacroAttrKind, ExportMap};
30 use rustc::hir::def::Namespace::*;
31 use rustc::hir::def_id::{CRATE_DEF_INDEX, LOCAL_CRATE, DefId};
32 use rustc::hir::{TraitMap, GlobMap};
34 use rustc::util::nodemap::{NodeMap, NodeSet, FxHashMap, FxHashSet, DefIdMap};
37 use rustc_metadata::creader::CrateLoader;
38 use rustc_metadata::cstore::CStore;
40 use syntax::ext::hygiene::{ExpnId, Transparency, SyntaxContext};
41 use syntax::ast::{self, Name, NodeId, Ident, FloatTy, IntTy, UintTy};
42 use syntax::ext::base::{SyntaxExtension, MacroKind, SpecialDerives};
43 use syntax::symbol::{Symbol, kw, sym};
45 use syntax::visit::{self, Visitor};
47 use syntax::ast::{CRATE_NODE_ID, Crate};
48 use syntax::ast::{ItemKind, Path};
49 use syntax::{struct_span_err, unwrap_or};
51 use syntax_pos::{Span, DUMMY_SP};
52 use errors::{Applicability, DiagnosticBuilder};
56 use std::cell::{Cell, RefCell};
57 use std::{cmp, fmt, iter, ptr};
58 use std::collections::BTreeSet;
59 use rustc_data_structures::ptr_key::PtrKey;
60 use rustc_data_structures::sync::Lrc;
62 use diagnostics::{Suggestion, ImportSuggestion};
63 use diagnostics::{find_span_of_binding_until_next_binding, extend_span_to_previous_binding};
64 use late::{PathSource, Rib, RibKind::*};
65 use resolve_imports::{ImportDirective, ImportDirectiveSubclass, NameResolution, ImportResolver};
66 use macros::{LegacyBinding, LegacyScope};
68 type Res = def::Res<NodeId>;
70 // N.B., this module needs to be declared first so diagnostics are
71 // registered before they are used.
77 mod build_reduced_graph;
80 const KNOWN_TOOLS: &[Name] = &[sym::clippy, sym::rustfmt];
87 #[derive(Copy, Clone, PartialEq, Debug)]
88 pub enum Determinacy {
94 fn determined(determined: bool) -> Determinacy {
95 if determined { Determinacy::Determined } else { Determinacy::Undetermined }
99 /// A specific scope in which a name can be looked up.
100 /// This enum is currently used only for early resolution (imports and macros),
101 /// but not for late resolution yet.
102 #[derive(Clone, Copy)]
105 MacroRules(LegacyScope<'a>),
117 /// Names from different contexts may want to visit different subsets of all specific scopes
118 /// with different restrictions when looking up the resolution.
119 /// This enum is currently used only for early resolution (imports and macros),
120 /// but not for late resolution yet.
122 /// All scopes with the given namespace.
123 All(Namespace, /*is_import*/ bool),
124 /// Crate root, then extern prelude (used for mixed 2015-2018 mode in macros).
125 AbsolutePath(Namespace),
126 /// All scopes with macro namespace and the given macro kind restriction.
130 /// Everything you need to know about a name's location to resolve it.
131 /// Serves as a starting point for the scope visitor.
132 /// This struct is currently used only for early resolution (imports and macros),
133 /// but not for late resolution yet.
134 #[derive(Clone, Copy, Debug)]
135 pub struct ParentScope<'a> {
138 legacy: LegacyScope<'a>,
139 derives: &'a [ast::Path],
142 impl<'a> ParentScope<'a> {
143 /// Creates a parent scope with the passed argument used as the module scope component,
144 /// and other scope components set to default empty values.
145 pub fn module(module: Module<'a>) -> ParentScope<'a> {
148 expansion: ExpnId::root(),
149 legacy: LegacyScope::Empty,
156 struct BindingError {
158 origin: BTreeSet<Span>,
159 target: BTreeSet<Span>,
163 impl PartialOrd for BindingError {
164 fn partial_cmp(&self, other: &BindingError) -> Option<cmp::Ordering> {
165 Some(self.cmp(other))
169 impl PartialEq for BindingError {
170 fn eq(&self, other: &BindingError) -> bool {
171 self.name == other.name
175 impl Ord for BindingError {
176 fn cmp(&self, other: &BindingError) -> cmp::Ordering {
177 self.name.cmp(&other.name)
181 enum ResolutionError<'a> {
182 /// Error E0401: can't use type or const parameters from outer function.
183 GenericParamsFromOuterFunction(Res),
184 /// Error E0403: the name is already used for a type or const parameter in this generic
186 NameAlreadyUsedInParameterList(Name, Span),
187 /// Error E0407: method is not a member of trait.
188 MethodNotMemberOfTrait(Name, &'a str),
189 /// Error E0437: type is not a member of trait.
190 TypeNotMemberOfTrait(Name, &'a str),
191 /// Error E0438: const is not a member of trait.
192 ConstNotMemberOfTrait(Name, &'a str),
193 /// Error E0408: variable `{}` is not bound in all patterns.
194 VariableNotBoundInPattern(&'a BindingError),
195 /// Error E0409: variable `{}` is bound in inconsistent ways within the same match arm.
196 VariableBoundWithDifferentMode(Name, Span),
197 /// Error E0415: identifier is bound more than once in this parameter list.
198 IdentifierBoundMoreThanOnceInParameterList(&'a str),
199 /// Error E0416: identifier is bound more than once in the same pattern.
200 IdentifierBoundMoreThanOnceInSamePattern(&'a str),
201 /// Error E0426: use of undeclared label.
202 UndeclaredLabel(&'a str, Option<Name>),
203 /// Error E0429: `self` imports are only allowed within a `{ }` list.
204 SelfImportsOnlyAllowedWithin,
205 /// Error E0430: `self` import can only appear once in the list.
206 SelfImportCanOnlyAppearOnceInTheList,
207 /// Error E0431: `self` import can only appear in an import list with a non-empty prefix.
208 SelfImportOnlyInImportListWithNonEmptyPrefix,
209 /// Error E0433: failed to resolve.
210 FailedToResolve { label: String, suggestion: Option<Suggestion> },
211 /// Error E0434: can't capture dynamic environment in a fn item.
212 CannotCaptureDynamicEnvironmentInFnItem,
213 /// Error E0435: attempt to use a non-constant value in a constant.
214 AttemptToUseNonConstantValueInConstant,
215 /// Error E0530: `X` bindings cannot shadow `Y`s.
216 BindingShadowsSomethingUnacceptable(&'a str, Name, &'a NameBinding<'a>),
217 /// Error E0128: type parameters with a default cannot use forward-declared identifiers.
218 ForwardDeclaredTyParam, // FIXME(const_generics:defaults)
219 /// Error E0671: const parameter cannot depend on type parameter.
220 ConstParamDependentOnTypeParam,
223 // A minimal representation of a path segment. We use this in resolve because
224 // we synthesize 'path segments' which don't have the rest of an AST or HIR
226 #[derive(Clone, Copy, Debug)]
233 fn from_path(path: &Path) -> Vec<Segment> {
234 path.segments.iter().map(|s| s.into()).collect()
237 fn from_ident(ident: Ident) -> Segment {
244 fn names_to_string(segments: &[Segment]) -> String {
245 names_to_string(&segments.iter()
246 .map(|seg| seg.ident)
247 .collect::<Vec<_>>())
251 impl<'a> From<&'a ast::PathSegment> for Segment {
252 fn from(seg: &'a ast::PathSegment) -> Segment {
260 struct UsePlacementFinder {
261 target_module: NodeId,
266 impl UsePlacementFinder {
267 fn check(krate: &Crate, target_module: NodeId) -> (Option<Span>, bool) {
268 let mut finder = UsePlacementFinder {
273 visit::walk_crate(&mut finder, krate);
274 (finder.span, finder.found_use)
278 impl<'tcx> Visitor<'tcx> for UsePlacementFinder {
281 module: &'tcx ast::Mod,
283 _: &[ast::Attribute],
286 if self.span.is_some() {
289 if node_id != self.target_module {
290 visit::walk_mod(self, module);
293 // find a use statement
294 for item in &module.items {
296 ItemKind::Use(..) => {
297 // don't suggest placing a use before the prelude
298 // import or other generated ones
299 if !item.span.from_expansion() {
300 self.span = Some(item.span.shrink_to_lo());
301 self.found_use = true;
305 // don't place use before extern crate
306 ItemKind::ExternCrate(_) => {}
307 // but place them before the first other item
308 _ => if self.span.map_or(true, |span| item.span < span ) {
309 if !item.span.from_expansion() {
310 // don't insert between attributes and an item
311 if item.attrs.is_empty() {
312 self.span = Some(item.span.shrink_to_lo());
314 // find the first attribute on the item
315 for attr in &item.attrs {
316 if self.span.map_or(true, |span| attr.span < span) {
317 self.span = Some(attr.span.shrink_to_lo());
328 /// An intermediate resolution result.
330 /// This refers to the thing referred by a name. The difference between `Res` and `Item` is that
331 /// items are visible in their whole block, while `Res`es only from the place they are defined
334 enum LexicalScopeBinding<'a> {
335 Item(&'a NameBinding<'a>),
339 impl<'a> LexicalScopeBinding<'a> {
340 fn item(self) -> Option<&'a NameBinding<'a>> {
342 LexicalScopeBinding::Item(binding) => Some(binding),
347 fn res(self) -> Res {
349 LexicalScopeBinding::Item(binding) => binding.res(),
350 LexicalScopeBinding::Res(res) => res,
355 #[derive(Copy, Clone, Debug)]
356 enum ModuleOrUniformRoot<'a> {
360 /// Virtual module that denotes resolution in crate root with fallback to extern prelude.
361 CrateRootAndExternPrelude,
363 /// Virtual module that denotes resolution in extern prelude.
364 /// Used for paths starting with `::` on 2018 edition.
367 /// Virtual module that denotes resolution in current scope.
368 /// Used only for resolving single-segment imports. The reason it exists is that import paths
369 /// are always split into two parts, the first of which should be some kind of module.
373 impl ModuleOrUniformRoot<'_> {
374 fn same_def(lhs: Self, rhs: Self) -> bool {
376 (ModuleOrUniformRoot::Module(lhs),
377 ModuleOrUniformRoot::Module(rhs)) => lhs.def_id() == rhs.def_id(),
378 (ModuleOrUniformRoot::CrateRootAndExternPrelude,
379 ModuleOrUniformRoot::CrateRootAndExternPrelude) |
380 (ModuleOrUniformRoot::ExternPrelude, ModuleOrUniformRoot::ExternPrelude) |
381 (ModuleOrUniformRoot::CurrentScope, ModuleOrUniformRoot::CurrentScope) => true,
387 #[derive(Clone, Debug)]
388 enum PathResult<'a> {
389 Module(ModuleOrUniformRoot<'a>),
390 NonModule(PartialRes),
395 suggestion: Option<Suggestion>,
396 is_error_from_last_segment: bool,
401 /// An anonymous module; e.g., just a block.
406 /// { // This is an anonymous module
407 /// f(); // This resolves to (2) as we are inside the block.
410 /// f(); // Resolves to (1)
414 /// Any module with a name.
418 /// * A normal module ‒ either `mod from_file;` or `mod from_block { }`.
419 /// * A trait or an enum (it implicitly contains associated types, methods and variant
421 Def(DefKind, DefId, Name),
425 /// Get name of the module.
426 pub fn name(&self) -> Option<Name> {
428 ModuleKind::Block(..) => None,
429 ModuleKind::Def(.., name) => Some(*name),
434 type Resolutions<'a> = RefCell<FxHashMap<(Ident, Namespace), &'a RefCell<NameResolution<'a>>>>;
436 /// One node in the tree of modules.
437 pub struct ModuleData<'a> {
438 parent: Option<Module<'a>>,
441 // The def id of the closest normal module (`mod`) ancestor (including this module).
442 normal_ancestor_id: DefId,
444 // Mapping between names and their (possibly in-progress) resolutions in this module.
445 // Resolutions in modules from other crates are not populated until accessed.
446 lazy_resolutions: Resolutions<'a>,
447 // True if this is a module from other crate that needs to be populated on access.
448 populate_on_access: Cell<bool>,
450 // Macro invocations that can expand into items in this module.
451 unexpanded_invocations: RefCell<FxHashSet<ExpnId>>,
453 no_implicit_prelude: bool,
455 glob_importers: RefCell<Vec<&'a ImportDirective<'a>>>,
456 globs: RefCell<Vec<&'a ImportDirective<'a>>>,
458 // Used to memoize the traits in this module for faster searches through all traits in scope.
459 traits: RefCell<Option<Box<[(Ident, &'a NameBinding<'a>)]>>>,
461 /// Span of the module itself. Used for error reporting.
467 type Module<'a> = &'a ModuleData<'a>;
469 impl<'a> ModuleData<'a> {
470 fn new(parent: Option<Module<'a>>,
472 normal_ancestor_id: DefId,
474 span: Span) -> Self {
479 lazy_resolutions: Default::default(),
480 populate_on_access: Cell::new(!normal_ancestor_id.is_local()),
481 unexpanded_invocations: Default::default(),
482 no_implicit_prelude: false,
483 glob_importers: RefCell::new(Vec::new()),
484 globs: RefCell::new(Vec::new()),
485 traits: RefCell::new(None),
491 fn for_each_child<R, F>(&'a self, resolver: &mut R, mut f: F)
492 where R: AsMut<Resolver<'a>>, F: FnMut(&mut R, Ident, Namespace, &'a NameBinding<'a>)
494 for (&(ident, ns), name_resolution) in resolver.as_mut().resolutions(self).borrow().iter() {
495 name_resolution.borrow().binding.map(|binding| f(resolver, ident, ns, binding));
499 fn for_each_child_stable<R, F>(&'a self, resolver: &mut R, mut f: F)
500 where R: AsMut<Resolver<'a>>, F: FnMut(&mut R, Ident, Namespace, &'a NameBinding<'a>)
502 let resolutions = resolver.as_mut().resolutions(self).borrow();
503 let mut resolutions = resolutions.iter().collect::<Vec<_>>();
504 resolutions.sort_by_cached_key(|&(&(ident, ns), _)| (ident.as_str(), ns));
505 for &(&(ident, ns), &resolution) in resolutions.iter() {
506 resolution.borrow().binding.map(|binding| f(resolver, ident, ns, binding));
510 fn res(&self) -> Option<Res> {
512 ModuleKind::Def(kind, def_id, _) => Some(Res::Def(kind, def_id)),
517 fn def_id(&self) -> Option<DefId> {
519 ModuleKind::Def(_, def_id, _) => Some(def_id),
524 // `self` resolves to the first module ancestor that `is_normal`.
525 fn is_normal(&self) -> bool {
527 ModuleKind::Def(DefKind::Mod, _, _) => true,
532 fn is_trait(&self) -> bool {
534 ModuleKind::Def(DefKind::Trait, _, _) => true,
539 fn nearest_item_scope(&'a self) -> Module<'a> {
540 if self.is_trait() { self.parent.unwrap() } else { self }
543 fn is_ancestor_of(&self, mut other: &Self) -> bool {
544 while !ptr::eq(self, other) {
545 if let Some(parent) = other.parent {
555 impl<'a> fmt::Debug for ModuleData<'a> {
556 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
557 write!(f, "{:?}", self.res())
561 /// Records a possibly-private value, type, or module definition.
562 #[derive(Clone, Debug)]
563 pub struct NameBinding<'a> {
564 kind: NameBindingKind<'a>,
565 ambiguity: Option<(&'a NameBinding<'a>, AmbiguityKind)>,
571 pub trait ToNameBinding<'a> {
572 fn to_name_binding(self, arenas: &'a ResolverArenas<'a>) -> &'a NameBinding<'a>;
575 impl<'a> ToNameBinding<'a> for &'a NameBinding<'a> {
576 fn to_name_binding(self, _: &'a ResolverArenas<'a>) -> &'a NameBinding<'a> {
581 #[derive(Clone, Debug)]
582 enum NameBindingKind<'a> {
583 Res(Res, /* is_macro_export */ bool),
586 binding: &'a NameBinding<'a>,
587 directive: &'a ImportDirective<'a>,
592 impl<'a> NameBindingKind<'a> {
593 /// Is this a name binding of a import?
594 fn is_import(&self) -> bool {
596 NameBindingKind::Import { .. } => true,
602 struct PrivacyError<'a>(Span, Ident, &'a NameBinding<'a>);
604 struct UseError<'a> {
605 err: DiagnosticBuilder<'a>,
606 /// Attach `use` statements for these candidates.
607 candidates: Vec<ImportSuggestion>,
608 /// The `NodeId` of the module to place the use-statements in.
610 /// Whether the diagnostic should state that it's "better".
614 #[derive(Clone, Copy, PartialEq, Debug)]
619 LegacyHelperVsPrelude,
628 fn descr(self) -> &'static str {
630 AmbiguityKind::Import =>
631 "name vs any other name during import resolution",
632 AmbiguityKind::BuiltinAttr =>
633 "built-in attribute vs any other name",
634 AmbiguityKind::DeriveHelper =>
635 "derive helper attribute vs any other name",
636 AmbiguityKind::LegacyHelperVsPrelude =>
637 "legacy plugin helper attribute vs name from prelude",
638 AmbiguityKind::LegacyVsModern =>
639 "`macro_rules` vs non-`macro_rules` from other module",
640 AmbiguityKind::GlobVsOuter =>
641 "glob import vs any other name from outer scope during import/macro resolution",
642 AmbiguityKind::GlobVsGlob =>
643 "glob import vs glob import in the same module",
644 AmbiguityKind::GlobVsExpanded =>
645 "glob import vs macro-expanded name in the same \
646 module during import/macro resolution",
647 AmbiguityKind::MoreExpandedVsOuter =>
648 "macro-expanded name vs less macro-expanded name \
649 from outer scope during import/macro resolution",
654 /// Miscellaneous bits of metadata for better ambiguity error reporting.
655 #[derive(Clone, Copy, PartialEq)]
656 enum AmbiguityErrorMisc {
663 struct AmbiguityError<'a> {
666 b1: &'a NameBinding<'a>,
667 b2: &'a NameBinding<'a>,
668 misc1: AmbiguityErrorMisc,
669 misc2: AmbiguityErrorMisc,
672 impl<'a> NameBinding<'a> {
673 fn module(&self) -> Option<Module<'a>> {
675 NameBindingKind::Module(module) => Some(module),
676 NameBindingKind::Import { binding, .. } => binding.module(),
681 fn res(&self) -> Res {
683 NameBindingKind::Res(res, _) => res,
684 NameBindingKind::Module(module) => module.res().unwrap(),
685 NameBindingKind::Import { binding, .. } => binding.res(),
689 fn is_ambiguity(&self) -> bool {
690 self.ambiguity.is_some() || match self.kind {
691 NameBindingKind::Import { binding, .. } => binding.is_ambiguity(),
696 // We sometimes need to treat variants as `pub` for backwards compatibility.
697 fn pseudo_vis(&self) -> ty::Visibility {
698 if self.is_variant() && self.res().def_id().is_local() {
699 ty::Visibility::Public
705 fn is_variant(&self) -> bool {
707 NameBindingKind::Res(Res::Def(DefKind::Variant, _), _) |
708 NameBindingKind::Res(Res::Def(DefKind::Ctor(CtorOf::Variant, ..), _), _) => true,
713 fn is_extern_crate(&self) -> bool {
715 NameBindingKind::Import {
716 directive: &ImportDirective {
717 subclass: ImportDirectiveSubclass::ExternCrate { .. }, ..
720 NameBindingKind::Module(
721 &ModuleData { kind: ModuleKind::Def(DefKind::Mod, def_id, _), .. }
722 ) => def_id.index == CRATE_DEF_INDEX,
727 fn is_import(&self) -> bool {
729 NameBindingKind::Import { .. } => true,
734 fn is_glob_import(&self) -> bool {
736 NameBindingKind::Import { directive, .. } => directive.is_glob(),
741 fn is_importable(&self) -> bool {
743 Res::Def(DefKind::AssocConst, _)
744 | Res::Def(DefKind::Method, _)
745 | Res::Def(DefKind::AssocTy, _) => false,
750 fn is_macro_def(&self) -> bool {
752 NameBindingKind::Res(Res::Def(DefKind::Macro(..), _), _) => true,
757 fn macro_kind(&self) -> Option<MacroKind> {
758 self.res().macro_kind()
761 // Suppose that we resolved macro invocation with `invoc_parent_expansion` to binding `binding`
762 // at some expansion round `max(invoc, binding)` when they both emerged from macros.
763 // Then this function returns `true` if `self` may emerge from a macro *after* that
764 // in some later round and screw up our previously found resolution.
765 // See more detailed explanation in
766 // https://github.com/rust-lang/rust/pull/53778#issuecomment-419224049
767 fn may_appear_after(&self, invoc_parent_expansion: ExpnId, binding: &NameBinding<'_>) -> bool {
768 // self > max(invoc, binding) => !(self <= invoc || self <= binding)
769 // Expansions are partially ordered, so "may appear after" is an inversion of
770 // "certainly appears before or simultaneously" and includes unordered cases.
771 let self_parent_expansion = self.expansion;
772 let other_parent_expansion = binding.expansion;
773 let certainly_before_other_or_simultaneously =
774 other_parent_expansion.is_descendant_of(self_parent_expansion);
775 let certainly_before_invoc_or_simultaneously =
776 invoc_parent_expansion.is_descendant_of(self_parent_expansion);
777 !(certainly_before_other_or_simultaneously || certainly_before_invoc_or_simultaneously)
781 /// Interns the names of the primitive types.
783 /// All other types are defined somewhere and possibly imported, but the primitive ones need
784 /// special handling, since they have no place of origin.
785 struct PrimitiveTypeTable {
786 primitive_types: FxHashMap<Name, PrimTy>,
789 impl PrimitiveTypeTable {
790 fn new() -> PrimitiveTypeTable {
791 let mut table = FxHashMap::default();
793 table.insert(sym::bool, Bool);
794 table.insert(sym::char, Char);
795 table.insert(sym::f32, Float(FloatTy::F32));
796 table.insert(sym::f64, Float(FloatTy::F64));
797 table.insert(sym::isize, Int(IntTy::Isize));
798 table.insert(sym::i8, Int(IntTy::I8));
799 table.insert(sym::i16, Int(IntTy::I16));
800 table.insert(sym::i32, Int(IntTy::I32));
801 table.insert(sym::i64, Int(IntTy::I64));
802 table.insert(sym::i128, Int(IntTy::I128));
803 table.insert(sym::str, Str);
804 table.insert(sym::usize, Uint(UintTy::Usize));
805 table.insert(sym::u8, Uint(UintTy::U8));
806 table.insert(sym::u16, Uint(UintTy::U16));
807 table.insert(sym::u32, Uint(UintTy::U32));
808 table.insert(sym::u64, Uint(UintTy::U64));
809 table.insert(sym::u128, Uint(UintTy::U128));
810 Self { primitive_types: table }
814 #[derive(Debug, Default, Clone)]
815 pub struct ExternPreludeEntry<'a> {
816 extern_crate_item: Option<&'a NameBinding<'a>>,
817 pub introduced_by_item: bool,
820 /// The main resolver class.
822 /// This is the visitor that walks the whole crate.
823 pub struct Resolver<'a> {
824 session: &'a Session,
827 pub definitions: Definitions,
829 pub graph_root: Module<'a>,
831 prelude: Option<Module<'a>>,
832 pub extern_prelude: FxHashMap<Ident, ExternPreludeEntry<'a>>,
834 /// N.B., this is used only for better diagnostics, not name resolution itself.
835 has_self: FxHashSet<DefId>,
837 /// Names of fields of an item `DefId` accessible with dot syntax.
838 /// Used for hints during error reporting.
839 field_names: FxHashMap<DefId, Vec<Name>>,
841 /// All imports known to succeed or fail.
842 determined_imports: Vec<&'a ImportDirective<'a>>,
844 /// All non-determined imports.
845 indeterminate_imports: Vec<&'a ImportDirective<'a>>,
847 /// FIXME: Refactor things so that these fields are passed through arguments and not resolver.
848 /// We are resolving a last import segment during import validation.
849 last_import_segment: bool,
850 /// This binding should be ignored during in-module resolution, so that we don't get
851 /// "self-confirming" import resolutions during import validation.
852 blacklisted_binding: Option<&'a NameBinding<'a>>,
854 /// The idents for the primitive types.
855 primitive_type_table: PrimitiveTypeTable,
857 /// Resolutions for nodes that have a single resolution.
858 partial_res_map: NodeMap<PartialRes>,
859 /// Resolutions for import nodes, which have multiple resolutions in different namespaces.
860 import_res_map: NodeMap<PerNS<Option<Res>>>,
861 /// Resolutions for labels (node IDs of their corresponding blocks or loops).
862 label_res_map: NodeMap<NodeId>,
864 pub export_map: ExportMap<NodeId>,
865 pub trait_map: TraitMap,
867 /// A map from nodes to anonymous modules.
868 /// Anonymous modules are pseudo-modules that are implicitly created around items
869 /// contained within blocks.
871 /// For example, if we have this:
879 /// There will be an anonymous module created around `g` with the ID of the
880 /// entry block for `f`.
881 block_map: NodeMap<Module<'a>>,
882 module_map: FxHashMap<DefId, Module<'a>>,
883 extern_module_map: FxHashMap<(DefId, bool /* MacrosOnly? */), Module<'a>>,
884 binding_parent_modules: FxHashMap<PtrKey<'a, NameBinding<'a>>, Module<'a>>,
886 /// Maps glob imports to the names of items actually imported.
887 pub glob_map: GlobMap,
889 used_imports: FxHashSet<(NodeId, Namespace)>,
890 pub maybe_unused_trait_imports: NodeSet,
891 pub maybe_unused_extern_crates: Vec<(NodeId, Span)>,
893 /// Privacy errors are delayed until the end in order to deduplicate them.
894 privacy_errors: Vec<PrivacyError<'a>>,
895 /// Ambiguity errors are delayed for deduplication.
896 ambiguity_errors: Vec<AmbiguityError<'a>>,
897 /// `use` injections are delayed for better placement and deduplication.
898 use_injections: Vec<UseError<'a>>,
899 /// Crate-local macro expanded `macro_export` referred to by a module-relative path.
900 macro_expanded_macro_export_errors: BTreeSet<(Span, Span)>,
902 arenas: &'a ResolverArenas<'a>,
903 dummy_binding: &'a NameBinding<'a>,
905 crate_loader: &'a mut CrateLoader<'a>,
906 macro_names: FxHashSet<Ident>,
907 builtin_macros: FxHashMap<Name, SyntaxExtension>,
908 macro_use_prelude: FxHashMap<Name, &'a NameBinding<'a>>,
909 pub all_macros: FxHashMap<Name, Res>,
910 macro_map: FxHashMap<DefId, Lrc<SyntaxExtension>>,
911 dummy_ext_bang: Lrc<SyntaxExtension>,
912 dummy_ext_derive: Lrc<SyntaxExtension>,
913 non_macro_attrs: [Lrc<SyntaxExtension>; 2],
914 macro_defs: FxHashMap<ExpnId, DefId>,
915 local_macro_def_scopes: FxHashMap<NodeId, Module<'a>>,
916 unused_macros: NodeMap<Span>,
917 proc_macro_stubs: NodeSet,
918 /// Traces collected during macro resolution and validated when it's complete.
919 single_segment_macro_resolutions: Vec<(Ident, MacroKind, ParentScope<'a>,
920 Option<&'a NameBinding<'a>>)>,
921 multi_segment_macro_resolutions: Vec<(Vec<Segment>, Span, MacroKind, ParentScope<'a>,
923 builtin_attrs: Vec<(Ident, ParentScope<'a>)>,
924 /// Some built-in derives mark items they are applied to so they are treated specially later.
925 /// Derive macros cannot modify the item themselves and have to store the markers in the global
926 /// context, so they attach the markers to derive container IDs using this resolver table.
927 /// FIXME: Find a way for `PartialEq` and `Eq` to emulate `#[structural_match]`
928 /// by marking the produced impls rather than the original items.
929 special_derives: FxHashMap<ExpnId, SpecialDerives>,
930 /// Parent scopes in which the macros were invoked.
931 /// FIXME: `derives` are missing in these parent scopes and need to be taken from elsewhere.
932 invocation_parent_scopes: FxHashMap<ExpnId, ParentScope<'a>>,
933 /// Legacy scopes *produced* by expanding the macro invocations,
934 /// include all the `macro_rules` items and other invocations generated by them.
935 output_legacy_scopes: FxHashMap<ExpnId, LegacyScope<'a>>,
937 /// Avoid duplicated errors for "name already defined".
938 name_already_seen: FxHashMap<Name, Span>,
940 potentially_unused_imports: Vec<&'a ImportDirective<'a>>,
942 /// Table for mapping struct IDs into struct constructor IDs,
943 /// it's not used during normal resolution, only for better error reporting.
944 struct_constructors: DefIdMap<(Res, ty::Visibility)>,
946 /// Features enabled for this crate.
947 active_features: FxHashSet<Symbol>,
950 /// Nothing really interesting here; it just provides memory for the rest of the crate.
952 pub struct ResolverArenas<'a> {
953 modules: arena::TypedArena<ModuleData<'a>>,
954 local_modules: RefCell<Vec<Module<'a>>>,
955 name_bindings: arena::TypedArena<NameBinding<'a>>,
956 import_directives: arena::TypedArena<ImportDirective<'a>>,
957 name_resolutions: arena::TypedArena<RefCell<NameResolution<'a>>>,
958 legacy_bindings: arena::TypedArena<LegacyBinding<'a>>,
959 ast_paths: arena::TypedArena<ast::Path>,
962 impl<'a> ResolverArenas<'a> {
963 fn alloc_module(&'a self, module: ModuleData<'a>) -> Module<'a> {
964 let module = self.modules.alloc(module);
965 if module.def_id().map(|def_id| def_id.is_local()).unwrap_or(true) {
966 self.local_modules.borrow_mut().push(module);
970 fn local_modules(&'a self) -> std::cell::Ref<'a, Vec<Module<'a>>> {
971 self.local_modules.borrow()
973 fn alloc_name_binding(&'a self, name_binding: NameBinding<'a>) -> &'a NameBinding<'a> {
974 self.name_bindings.alloc(name_binding)
976 fn alloc_import_directive(&'a self, import_directive: ImportDirective<'a>)
977 -> &'a ImportDirective<'_> {
978 self.import_directives.alloc(import_directive)
980 fn alloc_name_resolution(&'a self) -> &'a RefCell<NameResolution<'a>> {
981 self.name_resolutions.alloc(Default::default())
983 fn alloc_legacy_binding(&'a self, binding: LegacyBinding<'a>) -> &'a LegacyBinding<'a> {
984 self.legacy_bindings.alloc(binding)
986 fn alloc_ast_paths(&'a self, paths: &[ast::Path]) -> &'a [ast::Path] {
987 self.ast_paths.alloc_from_iter(paths.iter().cloned())
991 impl<'a> AsMut<Resolver<'a>> for Resolver<'a> {
992 fn as_mut(&mut self) -> &mut Resolver<'a> { self }
995 impl<'a, 'b> ty::DefIdTree for &'a Resolver<'b> {
996 fn parent(self, id: DefId) -> Option<DefId> {
998 LOCAL_CRATE => self.definitions.def_key(id.index).parent,
999 _ => self.cstore.def_key(id).parent,
1000 }.map(|index| DefId { index, ..id })
1004 /// This interface is used through the AST→HIR step, to embed full paths into the HIR. After that
1005 /// the resolver is no longer needed as all the relevant information is inline.
1006 impl<'a> hir::lowering::Resolver for Resolver<'a> {
1007 fn resolve_str_path(
1010 crate_root: Option<Symbol>,
1011 components: &[Symbol],
1013 ) -> (ast::Path, Res) {
1014 let root = if crate_root.is_some() {
1019 let segments = iter::once(Ident::with_dummy_span(root))
1021 crate_root.into_iter()
1022 .chain(components.iter().cloned())
1023 .map(Ident::with_dummy_span)
1024 ).map(|i| self.new_ast_path_segment(i)).collect::<Vec<_>>();
1026 let path = ast::Path {
1031 let parent_scope = &ParentScope::module(self.graph_root);
1032 let res = match self.resolve_ast_path(&path, ns, parent_scope) {
1034 Err((span, error)) => {
1035 self.report_error(span, error);
1042 fn get_partial_res(&mut self, id: NodeId) -> Option<PartialRes> {
1043 self.partial_res_map.get(&id).cloned()
1046 fn get_import_res(&mut self, id: NodeId) -> PerNS<Option<Res>> {
1047 self.import_res_map.get(&id).cloned().unwrap_or_default()
1050 fn get_label_res(&mut self, id: NodeId) -> Option<NodeId> {
1051 self.label_res_map.get(&id).cloned()
1054 fn definitions(&mut self) -> &mut Definitions {
1055 &mut self.definitions
1058 fn has_derives(&self, node_id: NodeId, derives: SpecialDerives) -> bool {
1059 let def_id = self.definitions.local_def_id(node_id);
1060 let expn_id = self.definitions.expansion_that_defined(def_id.index);
1061 self.has_derives(expn_id, derives)
1065 impl<'a> Resolver<'a> {
1066 pub fn new(session: &'a Session,
1070 crate_loader: &'a mut CrateLoader<'a>,
1071 arenas: &'a ResolverArenas<'a>)
1073 let root_def_id = DefId::local(CRATE_DEF_INDEX);
1074 let root_module_kind = ModuleKind::Def(
1079 let graph_root = arenas.alloc_module(ModuleData {
1080 no_implicit_prelude: attr::contains_name(&krate.attrs, sym::no_implicit_prelude),
1081 ..ModuleData::new(None, root_module_kind, root_def_id, ExpnId::root(), krate.span)
1083 let mut module_map = FxHashMap::default();
1084 module_map.insert(DefId::local(CRATE_DEF_INDEX), graph_root);
1086 let mut definitions = Definitions::default();
1087 definitions.create_root_def(crate_name, session.local_crate_disambiguator());
1089 let mut extern_prelude: FxHashMap<Ident, ExternPreludeEntry<'_>> =
1090 session.opts.externs.iter().map(|kv| (Ident::from_str(kv.0), Default::default()))
1093 if !attr::contains_name(&krate.attrs, sym::no_core) {
1094 extern_prelude.insert(Ident::with_dummy_span(sym::core), Default::default());
1095 if !attr::contains_name(&krate.attrs, sym::no_std) {
1096 extern_prelude.insert(Ident::with_dummy_span(sym::std), Default::default());
1097 if session.rust_2018() {
1098 extern_prelude.insert(Ident::with_dummy_span(sym::meta), Default::default());
1103 let mut invocation_parent_scopes = FxHashMap::default();
1104 invocation_parent_scopes.insert(ExpnId::root(), ParentScope::module(graph_root));
1106 let mut macro_defs = FxHashMap::default();
1107 macro_defs.insert(ExpnId::root(), root_def_id);
1109 let features = session.features_untracked();
1110 let non_macro_attr =
1111 |mark_used| Lrc::new(SyntaxExtension::non_macro_attr(mark_used, session.edition()));
1120 // The outermost module has def ID 0; this is not reflected in the
1126 has_self: FxHashSet::default(),
1127 field_names: FxHashMap::default(),
1129 determined_imports: Vec::new(),
1130 indeterminate_imports: Vec::new(),
1132 last_import_segment: false,
1133 blacklisted_binding: None,
1135 primitive_type_table: PrimitiveTypeTable::new(),
1137 partial_res_map: Default::default(),
1138 import_res_map: Default::default(),
1139 label_res_map: Default::default(),
1140 export_map: FxHashMap::default(),
1141 trait_map: Default::default(),
1143 block_map: Default::default(),
1144 extern_module_map: FxHashMap::default(),
1145 binding_parent_modules: FxHashMap::default(),
1147 glob_map: Default::default(),
1149 used_imports: FxHashSet::default(),
1150 maybe_unused_trait_imports: Default::default(),
1151 maybe_unused_extern_crates: Vec::new(),
1153 privacy_errors: Vec::new(),
1154 ambiguity_errors: Vec::new(),
1155 use_injections: Vec::new(),
1156 macro_expanded_macro_export_errors: BTreeSet::new(),
1159 dummy_binding: arenas.alloc_name_binding(NameBinding {
1160 kind: NameBindingKind::Res(Res::Err, false),
1162 expansion: ExpnId::root(),
1164 vis: ty::Visibility::Public,
1168 macro_names: FxHashSet::default(),
1169 builtin_macros: Default::default(),
1170 macro_use_prelude: FxHashMap::default(),
1171 all_macros: FxHashMap::default(),
1172 macro_map: FxHashMap::default(),
1173 dummy_ext_bang: Lrc::new(SyntaxExtension::dummy_bang(session.edition())),
1174 dummy_ext_derive: Lrc::new(SyntaxExtension::dummy_derive(session.edition())),
1175 non_macro_attrs: [non_macro_attr(false), non_macro_attr(true)],
1176 invocation_parent_scopes,
1177 output_legacy_scopes: Default::default(),
1179 local_macro_def_scopes: FxHashMap::default(),
1180 name_already_seen: FxHashMap::default(),
1181 potentially_unused_imports: Vec::new(),
1182 struct_constructors: Default::default(),
1183 unused_macros: Default::default(),
1184 proc_macro_stubs: Default::default(),
1185 single_segment_macro_resolutions: Default::default(),
1186 multi_segment_macro_resolutions: Default::default(),
1187 builtin_attrs: Default::default(),
1188 special_derives: Default::default(),
1190 features.declared_lib_features.iter().map(|(feat, ..)| *feat)
1191 .chain(features.declared_lang_features.iter().map(|(feat, ..)| *feat))
1196 pub fn arenas() -> ResolverArenas<'a> {
1200 fn non_macro_attr(&self, mark_used: bool) -> Lrc<SyntaxExtension> {
1201 self.non_macro_attrs[mark_used as usize].clone()
1204 fn dummy_ext(&self, macro_kind: MacroKind) -> Lrc<SyntaxExtension> {
1206 MacroKind::Bang => self.dummy_ext_bang.clone(),
1207 MacroKind::Derive => self.dummy_ext_derive.clone(),
1208 MacroKind::Attr => self.non_macro_attr(true),
1212 /// Runs the function on each namespace.
1213 fn per_ns<F: FnMut(&mut Self, Namespace)>(&mut self, mut f: F) {
1219 fn is_builtin_macro(&mut self, res: Res) -> bool {
1220 self.get_macro(res).map_or(false, |ext| ext.is_builtin)
1223 fn macro_def(&self, mut ctxt: SyntaxContext) -> DefId {
1225 match self.macro_defs.get(&ctxt.outer_expn()) {
1226 Some(&def_id) => return def_id,
1227 None => ctxt.remove_mark(),
1232 fn has_derives(&self, expn_id: ExpnId, markers: SpecialDerives) -> bool {
1233 self.special_derives.get(&expn_id).map_or(false, |m| m.contains(markers))
1236 /// Entry point to crate resolution.
1237 pub fn resolve_crate(&mut self, krate: &Crate) {
1238 ImportResolver { r: self }.finalize_imports();
1239 self.finalize_macro_resolutions();
1241 self.late_resolve_crate(krate);
1243 self.check_unused(krate);
1244 self.report_errors(krate);
1245 self.crate_loader.postprocess(krate);
1252 normal_ancestor_id: DefId,
1256 let module = ModuleData::new(Some(parent), kind, normal_ancestor_id, expn_id, span);
1257 self.arenas.alloc_module(module)
1260 fn resolutions(&mut self, module: Module<'a>) -> &'a Resolutions<'a> {
1261 if module.populate_on_access.get() {
1262 module.populate_on_access.set(false);
1263 self.build_reduced_graph_external(module);
1265 &module.lazy_resolutions
1268 fn resolution(&mut self, module: Module<'a>, ident: Ident, ns: Namespace)
1269 -> &'a RefCell<NameResolution<'a>> {
1270 *self.resolutions(module).borrow_mut().entry((ident.modern(), ns))
1271 .or_insert_with(|| self.arenas.alloc_name_resolution())
1274 fn record_use(&mut self, ident: Ident, ns: Namespace,
1275 used_binding: &'a NameBinding<'a>, is_lexical_scope: bool) {
1276 if let Some((b2, kind)) = used_binding.ambiguity {
1277 self.ambiguity_errors.push(AmbiguityError {
1278 kind, ident, b1: used_binding, b2,
1279 misc1: AmbiguityErrorMisc::None,
1280 misc2: AmbiguityErrorMisc::None,
1283 if let NameBindingKind::Import { directive, binding, ref used } = used_binding.kind {
1284 // Avoid marking `extern crate` items that refer to a name from extern prelude,
1285 // but not introduce it, as used if they are accessed from lexical scope.
1286 if is_lexical_scope {
1287 if let Some(entry) = self.extern_prelude.get(&ident.modern()) {
1288 if let Some(crate_item) = entry.extern_crate_item {
1289 if ptr::eq(used_binding, crate_item) && !entry.introduced_by_item {
1296 directive.used.set(true);
1297 self.used_imports.insert((directive.id, ns));
1298 self.add_to_glob_map(&directive, ident);
1299 self.record_use(ident, ns, binding, false);
1304 fn add_to_glob_map(&mut self, directive: &ImportDirective<'_>, ident: Ident) {
1305 if directive.is_glob() {
1306 self.glob_map.entry(directive.id).or_default().insert(ident.name);
1310 /// A generic scope visitor.
1311 /// Visits scopes in order to resolve some identifier in them or perform other actions.
1312 /// If the callback returns `Some` result, we stop visiting scopes and return it.
1315 scope_set: ScopeSet,
1316 parent_scope: &ParentScope<'a>,
1318 mut visitor: impl FnMut(&mut Self, Scope<'a>, /*use_prelude*/ bool, Ident) -> Option<T>,
1320 // General principles:
1321 // 1. Not controlled (user-defined) names should have higher priority than controlled names
1322 // built into the language or standard library. This way we can add new names into the
1323 // language or standard library without breaking user code.
1324 // 2. "Closed set" below means new names cannot appear after the current resolution attempt.
1325 // Places to search (in order of decreasing priority):
1327 // 1. FIXME: Ribs (type parameters), there's no necessary infrastructure yet
1328 // (open set, not controlled).
1329 // 2. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1330 // (open, not controlled).
1331 // 3. Extern prelude (open, the open part is from macro expansions, not controlled).
1332 // 4. Tool modules (closed, controlled right now, but not in the future).
1333 // 5. Standard library prelude (de-facto closed, controlled).
1334 // 6. Language prelude (closed, controlled).
1336 // 1. FIXME: Ribs (local variables), there's no necessary infrastructure yet
1337 // (open set, not controlled).
1338 // 2. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1339 // (open, not controlled).
1340 // 3. Standard library prelude (de-facto closed, controlled).
1342 // 1-3. Derive helpers (open, not controlled). All ambiguities with other names
1343 // are currently reported as errors. They should be higher in priority than preludes
1344 // and probably even names in modules according to the "general principles" above. They
1345 // also should be subject to restricted shadowing because are effectively produced by
1346 // derives (you need to resolve the derive first to add helpers into scope), but they
1347 // should be available before the derive is expanded for compatibility.
1348 // It's mess in general, so we are being conservative for now.
1349 // 1-3. `macro_rules` (open, not controlled), loop through legacy scopes. Have higher
1350 // priority than prelude macros, but create ambiguities with macros in modules.
1351 // 1-3. Names in modules (both normal `mod`ules and blocks), loop through hygienic parents
1352 // (open, not controlled). Have higher priority than prelude macros, but create
1353 // ambiguities with `macro_rules`.
1354 // 4. `macro_use` prelude (open, the open part is from macro expansions, not controlled).
1355 // 4a. User-defined prelude from macro-use
1356 // (open, the open part is from macro expansions, not controlled).
1357 // 4b. "Standard library prelude" part implemented through `macro-use` (closed, controlled).
1358 // 4c. Standard library prelude (de-facto closed, controlled).
1359 // 6. Language prelude: builtin attributes (closed, controlled).
1360 // 4-6. Legacy plugin helpers (open, not controlled). Similar to derive helpers,
1361 // but introduced by legacy plugins using `register_attribute`. Priority is somewhere
1362 // in prelude, not sure where exactly (creates ambiguities with any other prelude names).
1364 let rust_2015 = ident.span.rust_2015();
1365 let (ns, is_absolute_path) = match scope_set {
1366 ScopeSet::All(ns, _) => (ns, false),
1367 ScopeSet::AbsolutePath(ns) => (ns, true),
1368 ScopeSet::Macro(_) => (MacroNS, false),
1370 // Jump out of trait or enum modules, they do not act as scopes.
1371 let module = parent_scope.module.nearest_item_scope();
1372 let mut scope = match ns {
1373 _ if is_absolute_path => Scope::CrateRoot,
1374 TypeNS | ValueNS => Scope::Module(module),
1375 MacroNS => Scope::DeriveHelpers,
1377 let mut ident = ident.modern();
1378 let mut use_prelude = !module.no_implicit_prelude;
1381 let visit = match scope {
1382 Scope::DeriveHelpers => true,
1383 Scope::MacroRules(..) => true,
1384 Scope::CrateRoot => true,
1385 Scope::Module(..) => true,
1386 Scope::MacroUsePrelude => use_prelude || rust_2015,
1387 Scope::BuiltinAttrs => true,
1388 Scope::LegacyPluginHelpers => use_prelude || rust_2015,
1389 Scope::ExternPrelude => use_prelude || is_absolute_path,
1390 Scope::ToolPrelude => use_prelude,
1391 Scope::StdLibPrelude => use_prelude || ns == MacroNS,
1392 Scope::BuiltinTypes => true,
1396 if let break_result @ Some(..) = visitor(self, scope, use_prelude, ident) {
1397 return break_result;
1401 scope = match scope {
1402 Scope::DeriveHelpers =>
1403 Scope::MacroRules(parent_scope.legacy),
1404 Scope::MacroRules(legacy_scope) => match legacy_scope {
1405 LegacyScope::Binding(binding) => Scope::MacroRules(
1406 binding.parent_legacy_scope
1408 LegacyScope::Invocation(invoc_id) => Scope::MacroRules(
1409 self.output_legacy_scopes.get(&invoc_id).cloned()
1410 .unwrap_or(self.invocation_parent_scopes[&invoc_id].legacy)
1412 LegacyScope::Empty => Scope::Module(module),
1414 Scope::CrateRoot => match ns {
1416 ident.span.adjust(ExpnId::root());
1417 Scope::ExternPrelude
1419 ValueNS | MacroNS => break,
1421 Scope::Module(module) => {
1422 use_prelude = !module.no_implicit_prelude;
1423 match self.hygienic_lexical_parent(module, &mut ident.span) {
1424 Some(parent_module) => Scope::Module(parent_module),
1426 ident.span.adjust(ExpnId::root());
1428 TypeNS => Scope::ExternPrelude,
1429 ValueNS => Scope::StdLibPrelude,
1430 MacroNS => Scope::MacroUsePrelude,
1435 Scope::MacroUsePrelude => Scope::StdLibPrelude,
1436 Scope::BuiltinAttrs => Scope::LegacyPluginHelpers,
1437 Scope::LegacyPluginHelpers => break, // nowhere else to search
1438 Scope::ExternPrelude if is_absolute_path => break,
1439 Scope::ExternPrelude => Scope::ToolPrelude,
1440 Scope::ToolPrelude => Scope::StdLibPrelude,
1441 Scope::StdLibPrelude => match ns {
1442 TypeNS => Scope::BuiltinTypes,
1443 ValueNS => break, // nowhere else to search
1444 MacroNS => Scope::BuiltinAttrs,
1446 Scope::BuiltinTypes => break, // nowhere else to search
1453 /// This resolves the identifier `ident` in the namespace `ns` in the current lexical scope.
1454 /// More specifically, we proceed up the hierarchy of scopes and return the binding for
1455 /// `ident` in the first scope that defines it (or None if no scopes define it).
1457 /// A block's items are above its local variables in the scope hierarchy, regardless of where
1458 /// the items are defined in the block. For example,
1461 /// g(); // Since there are no local variables in scope yet, this resolves to the item.
1464 /// g(); // This resolves to the local variable `g` since it shadows the item.
1468 /// Invariant: This must only be called during main resolution, not during
1469 /// import resolution.
1470 fn resolve_ident_in_lexical_scope(&mut self,
1473 parent_scope: &ParentScope<'a>,
1474 record_used_id: Option<NodeId>,
1477 -> Option<LexicalScopeBinding<'a>> {
1478 assert!(ns == TypeNS || ns == ValueNS);
1479 if ident.name == kw::Invalid {
1480 return Some(LexicalScopeBinding::Res(Res::Err));
1482 let (general_span, modern_span) = if ident.name == kw::SelfUpper {
1483 // FIXME(jseyfried) improve `Self` hygiene
1484 let empty_span = ident.span.with_ctxt(SyntaxContext::root());
1485 (empty_span, empty_span)
1486 } else if ns == TypeNS {
1487 let modern_span = ident.span.modern();
1488 (modern_span, modern_span)
1490 (ident.span.modern_and_legacy(), ident.span.modern())
1492 ident.span = general_span;
1493 let modern_ident = Ident { span: modern_span, ..ident };
1495 // Walk backwards up the ribs in scope.
1496 let record_used = record_used_id.is_some();
1497 let mut module = self.graph_root;
1498 for i in (0 .. ribs.len()).rev() {
1499 debug!("walk rib\n{:?}", ribs[i].bindings);
1500 // Use the rib kind to determine whether we are resolving parameters
1501 // (modern hygiene) or local variables (legacy hygiene).
1502 let rib_ident = if ribs[i].kind.contains_params() {
1507 if let Some(res) = ribs[i].bindings.get(&rib_ident).cloned() {
1508 // The ident resolves to a type parameter or local variable.
1509 return Some(LexicalScopeBinding::Res(
1510 self.validate_res_from_ribs(i, res, record_used, path_span, ribs),
1514 module = match ribs[i].kind {
1515 ModuleRibKind(module) => module,
1516 MacroDefinition(def) if def == self.macro_def(ident.span.ctxt()) => {
1517 // If an invocation of this macro created `ident`, give up on `ident`
1518 // and switch to `ident`'s source from the macro definition.
1519 ident.span.remove_mark();
1526 let item = self.resolve_ident_in_module_unadjusted(
1527 ModuleOrUniformRoot::Module(module),
1534 if let Ok(binding) = item {
1535 // The ident resolves to an item.
1536 return Some(LexicalScopeBinding::Item(binding));
1540 ModuleKind::Block(..) => {}, // We can see through blocks
1545 ident = modern_ident;
1546 let mut poisoned = None;
1548 let opt_module = if let Some(node_id) = record_used_id {
1549 self.hygienic_lexical_parent_with_compatibility_fallback(module, &mut ident.span,
1550 node_id, &mut poisoned)
1552 self.hygienic_lexical_parent(module, &mut ident.span)
1554 module = unwrap_or!(opt_module, break);
1555 let adjusted_parent_scope = &ParentScope { module, ..*parent_scope };
1556 let result = self.resolve_ident_in_module_unadjusted(
1557 ModuleOrUniformRoot::Module(module),
1560 adjusted_parent_scope,
1567 if let Some(node_id) = poisoned {
1568 self.session.buffer_lint_with_diagnostic(
1569 lint::builtin::PROC_MACRO_DERIVE_RESOLUTION_FALLBACK,
1570 node_id, ident.span,
1571 &format!("cannot find {} `{}` in this scope", ns.descr(), ident),
1572 lint::builtin::BuiltinLintDiagnostics::
1573 ProcMacroDeriveResolutionFallback(ident.span),
1576 return Some(LexicalScopeBinding::Item(binding))
1578 Err(Determined) => continue,
1579 Err(Undetermined) =>
1580 span_bug!(ident.span, "undetermined resolution during main resolution pass"),
1584 if !module.no_implicit_prelude {
1585 ident.span.adjust(ExpnId::root());
1587 if let Some(binding) = self.extern_prelude_get(ident, !record_used) {
1588 return Some(LexicalScopeBinding::Item(binding));
1591 if ns == TypeNS && KNOWN_TOOLS.contains(&ident.name) {
1592 let binding = (Res::ToolMod, ty::Visibility::Public,
1593 DUMMY_SP, ExpnId::root()).to_name_binding(self.arenas);
1594 return Some(LexicalScopeBinding::Item(binding));
1596 if let Some(prelude) = self.prelude {
1597 if let Ok(binding) = self.resolve_ident_in_module_unadjusted(
1598 ModuleOrUniformRoot::Module(prelude),
1605 return Some(LexicalScopeBinding::Item(binding));
1613 fn hygienic_lexical_parent(&mut self, module: Module<'a>, span: &mut Span)
1614 -> Option<Module<'a>> {
1615 if !module.expansion.outer_expn_is_descendant_of(span.ctxt()) {
1616 return Some(self.macro_def_scope(span.remove_mark()));
1619 if let ModuleKind::Block(..) = module.kind {
1620 return Some(module.parent.unwrap());
1626 fn hygienic_lexical_parent_with_compatibility_fallback(&mut self, module: Module<'a>,
1627 span: &mut Span, node_id: NodeId,
1628 poisoned: &mut Option<NodeId>)
1629 -> Option<Module<'a>> {
1630 if let module @ Some(..) = self.hygienic_lexical_parent(module, span) {
1634 // We need to support the next case under a deprecation warning
1637 // ---- begin: this comes from a proc macro derive
1638 // mod implementation_details {
1639 // // Note that `MyStruct` is not in scope here.
1640 // impl SomeTrait for MyStruct { ... }
1644 // So we have to fall back to the module's parent during lexical resolution in this case.
1645 if let Some(parent) = module.parent {
1646 // Inner module is inside the macro, parent module is outside of the macro.
1647 if module.expansion != parent.expansion &&
1648 module.expansion.is_descendant_of(parent.expansion) {
1649 // The macro is a proc macro derive
1650 if module.expansion.looks_like_proc_macro_derive() {
1651 if parent.expansion.outer_expn_is_descendant_of(span.ctxt()) {
1652 *poisoned = Some(node_id);
1653 return module.parent;
1662 fn resolve_ident_in_module(
1664 module: ModuleOrUniformRoot<'a>,
1667 parent_scope: &ParentScope<'a>,
1670 ) -> Result<&'a NameBinding<'a>, Determinacy> {
1671 self.resolve_ident_in_module_ext(
1672 module, ident, ns, parent_scope, record_used, path_span
1673 ).map_err(|(determinacy, _)| determinacy)
1676 fn resolve_ident_in_module_ext(
1678 module: ModuleOrUniformRoot<'a>,
1681 parent_scope: &ParentScope<'a>,
1684 ) -> Result<&'a NameBinding<'a>, (Determinacy, Weak)> {
1685 let tmp_parent_scope;
1686 let mut adjusted_parent_scope = parent_scope;
1688 ModuleOrUniformRoot::Module(m) => {
1689 if let Some(def) = ident.span.modernize_and_adjust(m.expansion) {
1691 ParentScope { module: self.macro_def_scope(def), ..*parent_scope };
1692 adjusted_parent_scope = &tmp_parent_scope;
1695 ModuleOrUniformRoot::ExternPrelude => {
1696 ident.span.modernize_and_adjust(ExpnId::root());
1698 ModuleOrUniformRoot::CrateRootAndExternPrelude |
1699 ModuleOrUniformRoot::CurrentScope => {
1703 let result = self.resolve_ident_in_module_unadjusted_ext(
1704 module, ident, ns, adjusted_parent_scope, false, record_used, path_span,
1709 fn resolve_crate_root(&mut self, ident: Ident) -> Module<'a> {
1710 let mut ctxt = ident.span.ctxt();
1711 let mark = if ident.name == kw::DollarCrate {
1712 // When resolving `$crate` from a `macro_rules!` invoked in a `macro`,
1713 // we don't want to pretend that the `macro_rules!` definition is in the `macro`
1714 // as described in `SyntaxContext::apply_mark`, so we ignore prepended modern marks.
1715 // FIXME: This is only a guess and it doesn't work correctly for `macro_rules!`
1716 // definitions actually produced by `macro` and `macro` definitions produced by
1717 // `macro_rules!`, but at least such configurations are not stable yet.
1718 ctxt = ctxt.modern_and_legacy();
1719 let mut iter = ctxt.marks().into_iter().rev().peekable();
1720 let mut result = None;
1721 // Find the last modern mark from the end if it exists.
1722 while let Some(&(mark, transparency)) = iter.peek() {
1723 if transparency == Transparency::Opaque {
1724 result = Some(mark);
1730 // Then find the last legacy mark from the end if it exists.
1731 for (mark, transparency) in iter {
1732 if transparency == Transparency::SemiTransparent {
1733 result = Some(mark);
1740 ctxt = ctxt.modern();
1741 ctxt.adjust(ExpnId::root())
1743 let module = match mark {
1744 Some(def) => self.macro_def_scope(def),
1745 None => return self.graph_root,
1747 self.get_module(DefId { index: CRATE_DEF_INDEX, ..module.normal_ancestor_id })
1750 fn resolve_self(&mut self, ctxt: &mut SyntaxContext, module: Module<'a>) -> Module<'a> {
1751 let mut module = self.get_module(module.normal_ancestor_id);
1752 while module.span.ctxt().modern() != *ctxt {
1753 let parent = module.parent.unwrap_or_else(|| self.macro_def_scope(ctxt.remove_mark()));
1754 module = self.get_module(parent.normal_ancestor_id);
1762 opt_ns: Option<Namespace>, // `None` indicates a module path in import
1763 parent_scope: &ParentScope<'a>,
1766 crate_lint: CrateLint,
1767 ) -> PathResult<'a> {
1768 self.resolve_path_with_ribs(
1769 path, opt_ns, parent_scope, record_used, path_span, crate_lint, None
1773 fn resolve_path_with_ribs(
1776 opt_ns: Option<Namespace>, // `None` indicates a module path in import
1777 parent_scope: &ParentScope<'a>,
1780 crate_lint: CrateLint,
1781 ribs: Option<&PerNS<Vec<Rib<'a>>>>,
1782 ) -> PathResult<'a> {
1783 let mut module = None;
1784 let mut allow_super = true;
1785 let mut second_binding = None;
1788 "resolve_path(path={:?}, opt_ns={:?}, record_used={:?}, \
1789 path_span={:?}, crate_lint={:?})",
1797 for (i, &Segment { ident, id }) in path.iter().enumerate() {
1798 debug!("resolve_path ident {} {:?} {:?}", i, ident, id);
1799 let record_segment_res = |this: &mut Self, res| {
1801 if let Some(id) = id {
1802 if !this.partial_res_map.contains_key(&id) {
1803 assert!(id != ast::DUMMY_NODE_ID, "Trying to resolve dummy id");
1804 this.record_partial_res(id, PartialRes::new(res));
1810 let is_last = i == path.len() - 1;
1811 let ns = if is_last { opt_ns.unwrap_or(TypeNS) } else { TypeNS };
1812 let name = ident.name;
1814 allow_super &= ns == TypeNS &&
1815 (name == kw::SelfLower ||
1819 if allow_super && name == kw::Super {
1820 let mut ctxt = ident.span.ctxt().modern();
1821 let self_module = match i {
1822 0 => Some(self.resolve_self(&mut ctxt, parent_scope.module)),
1824 Some(ModuleOrUniformRoot::Module(module)) => Some(module),
1828 if let Some(self_module) = self_module {
1829 if let Some(parent) = self_module.parent {
1830 module = Some(ModuleOrUniformRoot::Module(
1831 self.resolve_self(&mut ctxt, parent)));
1835 let msg = "there are too many initial `super`s.".to_string();
1836 return PathResult::Failed {
1840 is_error_from_last_segment: false,
1844 if name == kw::SelfLower {
1845 let mut ctxt = ident.span.ctxt().modern();
1846 module = Some(ModuleOrUniformRoot::Module(
1847 self.resolve_self(&mut ctxt, parent_scope.module)));
1850 if name == kw::PathRoot && ident.span.rust_2018() {
1851 module = Some(ModuleOrUniformRoot::ExternPrelude);
1854 if name == kw::PathRoot &&
1855 ident.span.rust_2015() && self.session.rust_2018() {
1856 // `::a::b` from 2015 macro on 2018 global edition
1857 module = Some(ModuleOrUniformRoot::CrateRootAndExternPrelude);
1860 if name == kw::PathRoot ||
1861 name == kw::Crate ||
1862 name == kw::DollarCrate {
1863 // `::a::b`, `crate::a::b` or `$crate::a::b`
1864 module = Some(ModuleOrUniformRoot::Module(
1865 self.resolve_crate_root(ident)));
1871 // Report special messages for path segment keywords in wrong positions.
1872 if ident.is_path_segment_keyword() && i != 0 {
1873 let name_str = if name == kw::PathRoot {
1874 "crate root".to_string()
1876 format!("`{}`", name)
1878 let label = if i == 1 && path[0].ident.name == kw::PathRoot {
1879 format!("global paths cannot start with {}", name_str)
1881 format!("{} in paths can only be used in start position", name_str)
1883 return PathResult::Failed {
1887 is_error_from_last_segment: false,
1891 let binding = if let Some(module) = module {
1892 self.resolve_ident_in_module(
1893 module, ident, ns, parent_scope, record_used, path_span
1895 } else if ribs.is_none() || opt_ns.is_none() || opt_ns == Some(MacroNS) {
1896 let scopes = ScopeSet::All(ns, opt_ns.is_none());
1897 self.early_resolve_ident_in_lexical_scope(ident, scopes, parent_scope, record_used,
1898 record_used, path_span)
1900 let record_used_id =
1901 if record_used { crate_lint.node_id().or(Some(CRATE_NODE_ID)) } else { None };
1902 match self.resolve_ident_in_lexical_scope(
1903 ident, ns, parent_scope, record_used_id, path_span, &ribs.unwrap()[ns]
1905 // we found a locally-imported or available item/module
1906 Some(LexicalScopeBinding::Item(binding)) => Ok(binding),
1907 // we found a local variable or type param
1908 Some(LexicalScopeBinding::Res(res))
1909 if opt_ns == Some(TypeNS) || opt_ns == Some(ValueNS) => {
1910 record_segment_res(self, res);
1911 return PathResult::NonModule(PartialRes::with_unresolved_segments(
1915 _ => Err(Determinacy::determined(record_used)),
1922 second_binding = Some(binding);
1924 let res = binding.res();
1925 let maybe_assoc = opt_ns != Some(MacroNS) && PathSource::Type.is_expected(res);
1926 if let Some(next_module) = binding.module() {
1927 module = Some(ModuleOrUniformRoot::Module(next_module));
1928 record_segment_res(self, res);
1929 } else if res == Res::ToolMod && i + 1 != path.len() {
1930 if binding.is_import() {
1931 self.session.struct_span_err(
1932 ident.span, "cannot use a tool module through an import"
1934 binding.span, "the tool module imported here"
1937 let res = Res::NonMacroAttr(NonMacroAttrKind::Tool);
1938 return PathResult::NonModule(PartialRes::new(res));
1939 } else if res == Res::Err {
1940 return PathResult::NonModule(PartialRes::new(Res::Err));
1941 } else if opt_ns.is_some() && (is_last || maybe_assoc) {
1942 self.lint_if_path_starts_with_module(
1948 return PathResult::NonModule(PartialRes::with_unresolved_segments(
1949 res, path.len() - i - 1
1952 let label = format!(
1953 "`{}` is {} {}, not a module",
1959 return PathResult::Failed {
1963 is_error_from_last_segment: is_last,
1967 Err(Undetermined) => return PathResult::Indeterminate,
1968 Err(Determined) => {
1969 if let Some(ModuleOrUniformRoot::Module(module)) = module {
1970 if opt_ns.is_some() && !module.is_normal() {
1971 return PathResult::NonModule(PartialRes::with_unresolved_segments(
1972 module.res().unwrap(), path.len() - i
1976 let module_res = match module {
1977 Some(ModuleOrUniformRoot::Module(module)) => module.res(),
1980 let (label, suggestion) = if module_res == self.graph_root.res() {
1981 let is_mod = |res| {
1982 match res { Res::Def(DefKind::Mod, _) => true, _ => false }
1984 let mut candidates =
1985 self.lookup_import_candidates(ident, TypeNS, is_mod);
1986 candidates.sort_by_cached_key(|c| {
1987 (c.path.segments.len(), c.path.to_string())
1989 if let Some(candidate) = candidates.get(0) {
1991 String::from("unresolved import"),
1993 vec![(ident.span, candidate.path.to_string())],
1994 String::from("a similar path exists"),
1995 Applicability::MaybeIncorrect,
1998 } else if !ident.is_reserved() {
1999 (format!("maybe a missing crate `{}`?", ident), None)
2001 // the parser will already have complained about the keyword being used
2002 return PathResult::NonModule(PartialRes::new(Res::Err));
2005 (format!("use of undeclared type or module `{}`", ident), None)
2007 (format!("could not find `{}` in `{}`", ident, path[i - 1].ident), None)
2009 return PathResult::Failed {
2013 is_error_from_last_segment: is_last,
2019 self.lint_if_path_starts_with_module(crate_lint, path, path_span, second_binding);
2021 PathResult::Module(match module {
2022 Some(module) => module,
2023 None if path.is_empty() => ModuleOrUniformRoot::CurrentScope,
2024 _ => span_bug!(path_span, "resolve_path: non-empty path `{:?}` has no module", path),
2028 fn lint_if_path_starts_with_module(
2030 crate_lint: CrateLint,
2033 second_binding: Option<&NameBinding<'_>>,
2035 let (diag_id, diag_span) = match crate_lint {
2036 CrateLint::No => return,
2037 CrateLint::SimplePath(id) => (id, path_span),
2038 CrateLint::UsePath { root_id, root_span } => (root_id, root_span),
2039 CrateLint::QPathTrait { qpath_id, qpath_span } => (qpath_id, qpath_span),
2042 let first_name = match path.get(0) {
2043 // In the 2018 edition this lint is a hard error, so nothing to do
2044 Some(seg) if seg.ident.span.rust_2015() && self.session.rust_2015() => seg.ident.name,
2048 // We're only interested in `use` paths which should start with
2049 // `{{root}}` currently.
2050 if first_name != kw::PathRoot {
2055 // If this import looks like `crate::...` it's already good
2056 Some(Segment { ident, .. }) if ident.name == kw::Crate => return,
2057 // Otherwise go below to see if it's an extern crate
2059 // If the path has length one (and it's `PathRoot` most likely)
2060 // then we don't know whether we're gonna be importing a crate or an
2061 // item in our crate. Defer this lint to elsewhere
2065 // If the first element of our path was actually resolved to an
2066 // `ExternCrate` (also used for `crate::...`) then no need to issue a
2067 // warning, this looks all good!
2068 if let Some(binding) = second_binding {
2069 if let NameBindingKind::Import { directive: d, .. } = binding.kind {
2070 // Careful: we still want to rewrite paths from
2071 // renamed extern crates.
2072 if let ImportDirectiveSubclass::ExternCrate { source: None, .. } = d.subclass {
2078 let diag = lint::builtin::BuiltinLintDiagnostics
2079 ::AbsPathWithModule(diag_span);
2080 self.session.buffer_lint_with_diagnostic(
2081 lint::builtin::ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE,
2083 "absolute paths must start with `self`, `super`, \
2084 `crate`, or an external crate name in the 2018 edition",
2088 // Validate a local resolution (from ribs).
2089 fn validate_res_from_ribs(
2095 all_ribs: &[Rib<'a>],
2097 debug!("validate_res_from_ribs({:?})", res);
2098 let ribs = &all_ribs[rib_index + 1..];
2100 // An invalid forward use of a type parameter from a previous default.
2101 if let ForwardTyParamBanRibKind = all_ribs[rib_index].kind {
2103 self.report_error(span, ResolutionError::ForwardDeclaredTyParam);
2105 assert_eq!(res, Res::Err);
2109 // An invalid use of a type parameter as the type of a const parameter.
2110 if let TyParamAsConstParamTy = all_ribs[rib_index].kind {
2112 self.report_error(span, ResolutionError::ConstParamDependentOnTypeParam);
2114 assert_eq!(res, Res::Err);
2120 use ResolutionError::*;
2121 let mut res_err = None;
2125 NormalRibKind | ModuleRibKind(..) | MacroDefinition(..) |
2126 ForwardTyParamBanRibKind | TyParamAsConstParamTy => {
2127 // Nothing to do. Continue.
2129 ItemRibKind | FnItemRibKind | AssocItemRibKind => {
2130 // This was an attempt to access an upvar inside a
2131 // named function item. This is not allowed, so we
2134 // We don't immediately trigger a resolve error, because
2135 // we want certain other resolution errors (namely those
2136 // emitted for `ConstantItemRibKind` below) to take
2138 res_err = Some(CannotCaptureDynamicEnvironmentInFnItem);
2141 ConstantItemRibKind => {
2142 // Still doesn't deal with upvars
2144 self.report_error(span, AttemptToUseNonConstantValueInConstant);
2150 if let Some(res_err) = res_err {
2151 self.report_error(span, res_err);
2155 Res::Def(DefKind::TyParam, _) | Res::SelfTy(..) => {
2158 NormalRibKind | AssocItemRibKind |
2159 ModuleRibKind(..) | MacroDefinition(..) | ForwardTyParamBanRibKind |
2160 ConstantItemRibKind | TyParamAsConstParamTy => {
2161 // Nothing to do. Continue.
2163 ItemRibKind | FnItemRibKind => {
2164 // This was an attempt to use a type parameter outside its scope.
2167 span, ResolutionError::GenericParamsFromOuterFunction(res)
2175 Res::Def(DefKind::ConstParam, _) => {
2176 let mut ribs = ribs.iter().peekable();
2177 if let Some(Rib { kind: FnItemRibKind, .. }) = ribs.peek() {
2178 // When declaring const parameters inside function signatures, the first rib
2179 // is always a `FnItemRibKind`. In this case, we can skip it, to avoid it
2180 // (spuriously) conflicting with the const param.
2184 if let ItemRibKind | FnItemRibKind = rib.kind {
2185 // This was an attempt to use a const parameter outside its scope.
2188 span, ResolutionError::GenericParamsFromOuterFunction(res)
2200 fn record_partial_res(&mut self, node_id: NodeId, resolution: PartialRes) {
2201 debug!("(recording res) recording {:?} for {}", resolution, node_id);
2202 if let Some(prev_res) = self.partial_res_map.insert(node_id, resolution) {
2203 panic!("path resolved multiple times ({:?} before, {:?} now)", prev_res, resolution);
2207 fn is_accessible_from(&self, vis: ty::Visibility, module: Module<'a>) -> bool {
2208 vis.is_accessible_from(module.normal_ancestor_id, self)
2211 fn set_binding_parent_module(&mut self, binding: &'a NameBinding<'a>, module: Module<'a>) {
2212 if let Some(old_module) = self.binding_parent_modules.insert(PtrKey(binding), module) {
2213 if !ptr::eq(module, old_module) {
2214 span_bug!(binding.span, "parent module is reset for binding");
2219 fn disambiguate_legacy_vs_modern(
2221 legacy: &'a NameBinding<'a>,
2222 modern: &'a NameBinding<'a>,
2224 // Some non-controversial subset of ambiguities "modern macro name" vs "macro_rules"
2225 // is disambiguated to mitigate regressions from macro modularization.
2226 // Scoping for `macro_rules` behaves like scoping for `let` at module level, in general.
2227 match (self.binding_parent_modules.get(&PtrKey(legacy)),
2228 self.binding_parent_modules.get(&PtrKey(modern))) {
2229 (Some(legacy), Some(modern)) =>
2230 legacy.normal_ancestor_id == modern.normal_ancestor_id &&
2231 modern.is_ancestor_of(legacy),
2236 fn binding_description(&self, b: &NameBinding<'_>, ident: Ident, from_prelude: bool) -> String {
2238 if b.span.is_dummy() {
2239 let add_built_in = match b.res() {
2240 // These already contain the "built-in" prefix or look bad with it.
2241 Res::NonMacroAttr(..) | Res::PrimTy(..) | Res::ToolMod => false,
2244 let (built_in, from) = if from_prelude {
2245 ("", " from prelude")
2246 } else if b.is_extern_crate() && !b.is_import() &&
2247 self.session.opts.externs.get(&ident.as_str()).is_some() {
2248 ("", " passed with `--extern`")
2249 } else if add_built_in {
2255 let article = if built_in.is_empty() { res.article() } else { "a" };
2256 format!("{a}{built_in} {thing}{from}",
2257 a = article, thing = res.descr(), built_in = built_in, from = from)
2259 let introduced = if b.is_import() { "imported" } else { "defined" };
2260 format!("the {thing} {introduced} here",
2261 thing = res.descr(), introduced = introduced)
2265 fn report_ambiguity_error(&self, ambiguity_error: &AmbiguityError<'_>) {
2266 let AmbiguityError { kind, ident, b1, b2, misc1, misc2 } = *ambiguity_error;
2267 let (b1, b2, misc1, misc2, swapped) = if b2.span.is_dummy() && !b1.span.is_dummy() {
2268 // We have to print the span-less alternative first, otherwise formatting looks bad.
2269 (b2, b1, misc2, misc1, true)
2271 (b1, b2, misc1, misc2, false)
2274 let mut err = struct_span_err!(self.session, ident.span, E0659,
2275 "`{ident}` is ambiguous ({why})",
2276 ident = ident, why = kind.descr());
2277 err.span_label(ident.span, "ambiguous name");
2279 let mut could_refer_to = |b: &NameBinding<'_>, misc: AmbiguityErrorMisc, also: &str| {
2280 let what = self.binding_description(b, ident, misc == AmbiguityErrorMisc::FromPrelude);
2281 let note_msg = format!("`{ident}` could{also} refer to {what}",
2282 ident = ident, also = also, what = what);
2284 let thing = b.res().descr();
2285 let mut help_msgs = Vec::new();
2286 if b.is_glob_import() && (kind == AmbiguityKind::GlobVsGlob ||
2287 kind == AmbiguityKind::GlobVsExpanded ||
2288 kind == AmbiguityKind::GlobVsOuter &&
2289 swapped != also.is_empty()) {
2290 help_msgs.push(format!("consider adding an explicit import of \
2291 `{ident}` to disambiguate", ident = ident))
2293 if b.is_extern_crate() && ident.span.rust_2018() {
2294 help_msgs.push(format!(
2295 "use `::{ident}` to refer to this {thing} unambiguously",
2296 ident = ident, thing = thing,
2299 if misc == AmbiguityErrorMisc::SuggestCrate {
2300 help_msgs.push(format!(
2301 "use `crate::{ident}` to refer to this {thing} unambiguously",
2302 ident = ident, thing = thing,
2304 } else if misc == AmbiguityErrorMisc::SuggestSelf {
2305 help_msgs.push(format!(
2306 "use `self::{ident}` to refer to this {thing} unambiguously",
2307 ident = ident, thing = thing,
2311 err.span_note(b.span, ¬e_msg);
2312 for (i, help_msg) in help_msgs.iter().enumerate() {
2313 let or = if i == 0 { "" } else { "or " };
2314 err.help(&format!("{}{}", or, help_msg));
2318 could_refer_to(b1, misc1, "");
2319 could_refer_to(b2, misc2, " also");
2323 fn report_errors(&mut self, krate: &Crate) {
2324 self.report_with_use_injections(krate);
2326 for &(span_use, span_def) in &self.macro_expanded_macro_export_errors {
2327 let msg = "macro-expanded `macro_export` macros from the current crate \
2328 cannot be referred to by absolute paths";
2329 self.session.buffer_lint_with_diagnostic(
2330 lint::builtin::MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS,
2331 CRATE_NODE_ID, span_use, msg,
2332 lint::builtin::BuiltinLintDiagnostics::
2333 MacroExpandedMacroExportsAccessedByAbsolutePaths(span_def),
2337 for ambiguity_error in &self.ambiguity_errors {
2338 self.report_ambiguity_error(ambiguity_error);
2341 let mut reported_spans = FxHashSet::default();
2342 for &PrivacyError(dedup_span, ident, binding) in &self.privacy_errors {
2343 if reported_spans.insert(dedup_span) {
2344 let mut err = struct_span_err!(
2348 "{} `{}` is private",
2349 binding.res().descr(),
2352 // FIXME: use the ctor's `def_id` to check wether any of the fields is not visible
2353 match binding.kind {
2354 NameBindingKind::Res(Res::Def(DefKind::Ctor(
2357 ), _def_id), _) => {
2358 err.note("a tuple struct constructor is private if any of its fields \
2361 NameBindingKind::Res(Res::Def(DefKind::Ctor(
2364 ), _def_id), _) => {
2365 err.note("a tuple variant constructor is private if any of its fields \
2375 fn report_with_use_injections(&mut self, krate: &Crate) {
2376 for UseError { mut err, candidates, node_id, better } in self.use_injections.drain(..) {
2377 let (span, found_use) = UsePlacementFinder::check(krate, node_id);
2378 if !candidates.is_empty() {
2379 diagnostics::show_candidates(&mut err, span, &candidates, better, found_use);
2385 fn report_conflict<'b>(&mut self,
2389 new_binding: &NameBinding<'b>,
2390 old_binding: &NameBinding<'b>) {
2391 // Error on the second of two conflicting names
2392 if old_binding.span.lo() > new_binding.span.lo() {
2393 return self.report_conflict(parent, ident, ns, old_binding, new_binding);
2396 let container = match parent.kind {
2397 ModuleKind::Def(DefKind::Mod, _, _) => "module",
2398 ModuleKind::Def(DefKind::Trait, _, _) => "trait",
2399 ModuleKind::Block(..) => "block",
2403 let old_noun = match old_binding.is_import() {
2405 false => "definition",
2408 let new_participle = match new_binding.is_import() {
2413 let (name, span) = (ident.name, self.session.source_map().def_span(new_binding.span));
2415 if let Some(s) = self.name_already_seen.get(&name) {
2421 let old_kind = match (ns, old_binding.module()) {
2422 (ValueNS, _) => "value",
2423 (MacroNS, _) => "macro",
2424 (TypeNS, _) if old_binding.is_extern_crate() => "extern crate",
2425 (TypeNS, Some(module)) if module.is_normal() => "module",
2426 (TypeNS, Some(module)) if module.is_trait() => "trait",
2427 (TypeNS, _) => "type",
2430 let msg = format!("the name `{}` is defined multiple times", name);
2432 let mut err = match (old_binding.is_extern_crate(), new_binding.is_extern_crate()) {
2433 (true, true) => struct_span_err!(self.session, span, E0259, "{}", msg),
2434 (true, _) | (_, true) => match new_binding.is_import() && old_binding.is_import() {
2435 true => struct_span_err!(self.session, span, E0254, "{}", msg),
2436 false => struct_span_err!(self.session, span, E0260, "{}", msg),
2438 _ => match (old_binding.is_import(), new_binding.is_import()) {
2439 (false, false) => struct_span_err!(self.session, span, E0428, "{}", msg),
2440 (true, true) => struct_span_err!(self.session, span, E0252, "{}", msg),
2441 _ => struct_span_err!(self.session, span, E0255, "{}", msg),
2445 err.note(&format!("`{}` must be defined only once in the {} namespace of this {}",
2450 err.span_label(span, format!("`{}` re{} here", name, new_participle));
2452 self.session.source_map().def_span(old_binding.span),
2453 format!("previous {} of the {} `{}` here", old_noun, old_kind, name),
2456 // See https://github.com/rust-lang/rust/issues/32354
2457 use NameBindingKind::Import;
2458 let directive = match (&new_binding.kind, &old_binding.kind) {
2459 // If there are two imports where one or both have attributes then prefer removing the
2460 // import without attributes.
2461 (Import { directive: new, .. }, Import { directive: old, .. }) if {
2462 !new_binding.span.is_dummy() && !old_binding.span.is_dummy() &&
2463 (new.has_attributes || old.has_attributes)
2465 if old.has_attributes {
2466 Some((new, new_binding.span, true))
2468 Some((old, old_binding.span, true))
2471 // Otherwise prioritize the new binding.
2472 (Import { directive, .. }, other) if !new_binding.span.is_dummy() =>
2473 Some((directive, new_binding.span, other.is_import())),
2474 (other, Import { directive, .. }) if !old_binding.span.is_dummy() =>
2475 Some((directive, old_binding.span, other.is_import())),
2479 // Check if the target of the use for both bindings is the same.
2480 let duplicate = new_binding.res().opt_def_id() == old_binding.res().opt_def_id();
2481 let has_dummy_span = new_binding.span.is_dummy() || old_binding.span.is_dummy();
2482 let from_item = self.extern_prelude.get(&ident)
2483 .map(|entry| entry.introduced_by_item)
2485 // Only suggest removing an import if both bindings are to the same def, if both spans
2486 // aren't dummy spans. Further, if both bindings are imports, then the ident must have
2487 // been introduced by a item.
2488 let should_remove_import = duplicate && !has_dummy_span &&
2489 ((new_binding.is_extern_crate() || old_binding.is_extern_crate()) || from_item);
2492 Some((directive, span, true)) if should_remove_import && directive.is_nested() =>
2493 self.add_suggestion_for_duplicate_nested_use(&mut err, directive, span),
2494 Some((directive, _, true)) if should_remove_import && !directive.is_glob() => {
2495 // Simple case - remove the entire import. Due to the above match arm, this can
2496 // only be a single use so just remove it entirely.
2497 err.tool_only_span_suggestion(
2498 directive.use_span_with_attributes,
2499 "remove unnecessary import",
2501 Applicability::MaybeIncorrect,
2504 Some((directive, span, _)) =>
2505 self.add_suggestion_for_rename_of_use(&mut err, name, directive, span),
2510 self.name_already_seen.insert(name, span);
2513 /// This function adds a suggestion to change the binding name of a new import that conflicts
2514 /// with an existing import.
2516 /// ```ignore (diagnostic)
2517 /// help: you can use `as` to change the binding name of the import
2519 /// LL | use foo::bar as other_bar;
2520 /// | ^^^^^^^^^^^^^^^^^^^^^
2522 fn add_suggestion_for_rename_of_use(
2524 err: &mut DiagnosticBuilder<'_>,
2526 directive: &ImportDirective<'_>,
2529 let suggested_name = if name.as_str().chars().next().unwrap().is_uppercase() {
2530 format!("Other{}", name)
2532 format!("other_{}", name)
2535 let mut suggestion = None;
2536 match directive.subclass {
2537 ImportDirectiveSubclass::SingleImport { type_ns_only: true, .. } =>
2538 suggestion = Some(format!("self as {}", suggested_name)),
2539 ImportDirectiveSubclass::SingleImport { source, .. } => {
2540 if let Some(pos) = source.span.hi().0.checked_sub(binding_span.lo().0)
2541 .map(|pos| pos as usize) {
2542 if let Ok(snippet) = self.session.source_map()
2543 .span_to_snippet(binding_span) {
2544 if pos <= snippet.len() {
2545 suggestion = Some(format!(
2549 if snippet.ends_with(";") { ";" } else { "" }
2555 ImportDirectiveSubclass::ExternCrate { source, target, .. } =>
2556 suggestion = Some(format!(
2557 "extern crate {} as {};",
2558 source.unwrap_or(target.name),
2561 _ => unreachable!(),
2564 let rename_msg = "you can use `as` to change the binding name of the import";
2565 if let Some(suggestion) = suggestion {
2566 err.span_suggestion(
2570 Applicability::MaybeIncorrect,
2573 err.span_label(binding_span, rename_msg);
2577 /// This function adds a suggestion to remove a unnecessary binding from an import that is
2578 /// nested. In the following example, this function will be invoked to remove the `a` binding
2579 /// in the second use statement:
2581 /// ```ignore (diagnostic)
2582 /// use issue_52891::a;
2583 /// use issue_52891::{d, a, e};
2586 /// The following suggestion will be added:
2588 /// ```ignore (diagnostic)
2589 /// use issue_52891::{d, a, e};
2590 /// ^-- help: remove unnecessary import
2593 /// If the nested use contains only one import then the suggestion will remove the entire
2596 /// It is expected that the directive provided is a nested import - this isn't checked by the
2597 /// function. If this invariant is not upheld, this function's behaviour will be unexpected
2598 /// as characters expected by span manipulations won't be present.
2599 fn add_suggestion_for_duplicate_nested_use(
2601 err: &mut DiagnosticBuilder<'_>,
2602 directive: &ImportDirective<'_>,
2605 assert!(directive.is_nested());
2606 let message = "remove unnecessary import";
2608 // Two examples will be used to illustrate the span manipulations we're doing:
2610 // - Given `use issue_52891::{d, a, e};` where `a` is a duplicate then `binding_span` is
2611 // `a` and `directive.use_span` is `issue_52891::{d, a, e};`.
2612 // - Given `use issue_52891::{d, e, a};` where `a` is a duplicate then `binding_span` is
2613 // `a` and `directive.use_span` is `issue_52891::{d, e, a};`.
2615 let (found_closing_brace, span) = find_span_of_binding_until_next_binding(
2616 self.session, binding_span, directive.use_span,
2619 // If there was a closing brace then identify the span to remove any trailing commas from
2620 // previous imports.
2621 if found_closing_brace {
2622 if let Some(span) = extend_span_to_previous_binding(self.session, span) {
2623 err.tool_only_span_suggestion(span, message, String::new(),
2624 Applicability::MaybeIncorrect);
2626 // Remove the entire line if we cannot extend the span back, this indicates a
2627 // `issue_52891::{self}` case.
2628 err.span_suggestion(directive.use_span_with_attributes, message, String::new(),
2629 Applicability::MaybeIncorrect);
2635 err.span_suggestion(span, message, String::new(), Applicability::MachineApplicable);
2638 fn extern_prelude_get(&mut self, ident: Ident, speculative: bool)
2639 -> Option<&'a NameBinding<'a>> {
2640 if ident.is_path_segment_keyword() {
2641 // Make sure `self`, `super` etc produce an error when passed to here.
2644 self.extern_prelude.get(&ident.modern()).cloned().and_then(|entry| {
2645 if let Some(binding) = entry.extern_crate_item {
2646 if !speculative && entry.introduced_by_item {
2647 self.record_use(ident, TypeNS, binding, false);
2651 let crate_id = if !speculative {
2652 self.crate_loader.process_path_extern(ident.name, ident.span)
2653 } else if let Some(crate_id) =
2654 self.crate_loader.maybe_process_path_extern(ident.name, ident.span) {
2659 let crate_root = self.get_module(DefId { krate: crate_id, index: CRATE_DEF_INDEX });
2660 Some((crate_root, ty::Visibility::Public, DUMMY_SP, ExpnId::root())
2661 .to_name_binding(self.arenas))
2666 /// Rustdoc uses this to resolve things in a recoverable way. `ResolutionError<'a>`
2667 /// isn't something that can be returned because it can't be made to live that long,
2668 /// and also it's a private type. Fortunately rustdoc doesn't need to know the error,
2669 /// just that an error occurred.
2670 // FIXME(Manishearth): intra-doc links won't get warned of epoch changes.
2671 pub fn resolve_str_path_error(
2672 &mut self, span: Span, path_str: &str, ns: Namespace, module_id: NodeId
2673 ) -> Result<(ast::Path, Res), ()> {
2674 let path = if path_str.starts_with("::") {
2677 segments: iter::once(Ident::with_dummy_span(kw::PathRoot))
2679 path_str.split("::").skip(1).map(Ident::from_str)
2681 .map(|i| self.new_ast_path_segment(i))
2689 .map(Ident::from_str)
2690 .map(|i| self.new_ast_path_segment(i))
2694 let module = self.block_map.get(&module_id).copied().unwrap_or_else(|| {
2695 let def_id = self.definitions.local_def_id(module_id);
2696 self.module_map.get(&def_id).copied().unwrap_or(self.graph_root)
2698 let parent_scope = &ParentScope::module(module);
2699 let res = self.resolve_ast_path(&path, ns, parent_scope).map_err(|_| ())?;
2703 // Resolve a path passed from rustdoc or HIR lowering.
2704 fn resolve_ast_path(
2708 parent_scope: &ParentScope<'a>,
2709 ) -> Result<Res, (Span, ResolutionError<'a>)> {
2710 match self.resolve_path(
2711 &Segment::from_path(path), Some(ns), parent_scope, true, path.span, CrateLint::No
2713 PathResult::Module(ModuleOrUniformRoot::Module(module)) =>
2714 Ok(module.res().unwrap()),
2715 PathResult::NonModule(path_res) if path_res.unresolved_segments() == 0 =>
2716 Ok(path_res.base_res()),
2717 PathResult::NonModule(..) => {
2718 Err((path.span, ResolutionError::FailedToResolve {
2719 label: String::from("type-relative paths are not supported in this context"),
2723 PathResult::Module(..) | PathResult::Indeterminate => unreachable!(),
2724 PathResult::Failed { span, label, suggestion, .. } => {
2725 Err((span, ResolutionError::FailedToResolve {
2733 fn new_ast_path_segment(&self, ident: Ident) -> ast::PathSegment {
2734 let mut seg = ast::PathSegment::from_ident(ident);
2735 seg.id = self.session.next_node_id();
2740 fn names_to_string(idents: &[Ident]) -> String {
2741 let mut result = String::new();
2742 for (i, ident) in idents.iter()
2743 .filter(|ident| ident.name != kw::PathRoot)
2746 result.push_str("::");
2748 result.push_str(&ident.as_str());
2753 fn path_names_to_string(path: &Path) -> String {
2754 names_to_string(&path.segments.iter()
2755 .map(|seg| seg.ident)
2756 .collect::<Vec<_>>())
2759 /// A somewhat inefficient routine to obtain the name of a module.
2760 fn module_to_string(module: Module<'_>) -> Option<String> {
2761 let mut names = Vec::new();
2763 fn collect_mod(names: &mut Vec<Ident>, module: Module<'_>) {
2764 if let ModuleKind::Def(.., name) = module.kind {
2765 if let Some(parent) = module.parent {
2766 names.push(Ident::with_dummy_span(name));
2767 collect_mod(names, parent);
2770 // danger, shouldn't be ident?
2771 names.push(Ident::from_str("<opaque>"));
2772 collect_mod(names, module.parent.unwrap());
2775 collect_mod(&mut names, module);
2777 if names.is_empty() {
2780 Some(names_to_string(&names.into_iter()
2782 .collect::<Vec<_>>()))
2785 #[derive(Copy, Clone, Debug)]
2787 /// Do not issue the lint.
2790 /// This lint applies to some arbitrary path; e.g., `impl ::foo::Bar`.
2791 /// In this case, we can take the span of that path.
2794 /// This lint comes from a `use` statement. In this case, what we
2795 /// care about really is the *root* `use` statement; e.g., if we
2796 /// have nested things like `use a::{b, c}`, we care about the
2798 UsePath { root_id: NodeId, root_span: Span },
2800 /// This is the "trait item" from a fully qualified path. For example,
2801 /// we might be resolving `X::Y::Z` from a path like `<T as X::Y>::Z`.
2802 /// The `path_span` is the span of the to the trait itself (`X::Y`).
2803 QPathTrait { qpath_id: NodeId, qpath_span: Span },
2807 fn node_id(&self) -> Option<NodeId> {
2809 CrateLint::No => None,
2810 CrateLint::SimplePath(id) |
2811 CrateLint::UsePath { root_id: id, .. } |
2812 CrateLint::QPathTrait { qpath_id: id, .. } => Some(id),
2817 __build_diagnostic_array! { librustc_resolve, DIAGNOSTICS }