src/librustc_passes/ast_validation.rs

   1 // Validate AST before lowering it to HIR
   2 //
   3 // This pass is supposed to catch things that fit into AST data structures,
   4 // but not permitted by the language. It runs after expansion when AST is frozen,
   5 // so it can check for erroneous constructions produced by syntax extensions.
   6 // This pass is supposed to perform only simple checks not requiring name resolution
   7 // or type checking or some other kind of complex analysis.
   8
   9 use std::mem;
  10 use syntax::print::pprust;
  11 use rustc::lint;
  12 use rustc::lint::builtin::{BuiltinLintDiagnostics, NESTED_IMPL_TRAIT};
  13 use rustc::session::Session;
  14 use rustc_data_structures::fx::FxHashMap;
  15 use syntax::ast::*;
  16 use syntax::attr;
  17 use syntax::source_map::Spanned;
  18 use syntax::symbol::keywords;
  19 use syntax::ptr::P;
  20 use syntax::visit::{self, Visitor};
  21 use syntax::{span_err, struct_span_err, walk_list};
  22 use syntax_ext::proc_macro_decls::is_proc_macro_attr;
  23 use syntax_pos::Span;
  24 use errors::Applicability;
  25 use log::debug;
  26
  27 #[derive(Copy, Clone, Debug)]
  28 struct OuterImplTrait {
  29     span: Span,
  30
  31     /// rust-lang/rust#57979: a bug in original implementation caused
  32     /// us to fail sometimes to record an outer `impl Trait`.
  33     /// Therefore, in order to reliably issue a warning (rather than
  34     /// an error) in the *precise* places where we are newly injecting
  35     /// the diagnostic, we have to distinguish between the places
  36     /// where the outer `impl Trait` has always been recorded, versus
  37     /// the places where it has only recently started being recorded.
  38     only_recorded_since_pull_request_57730: bool,
  39 }
  40
  41 impl OuterImplTrait {
  42     /// This controls whether we should downgrade the nested impl
  43     /// trait diagnostic to a warning rather than an error, based on
  44     /// whether the outer impl trait had been improperly skipped in
  45     /// earlier implementations of the analysis on the stable
  46     /// compiler.
  47     fn should_warn_instead_of_error(&self) -> bool {
  48         self.only_recorded_since_pull_request_57730
  49     }
  50 }
  51
  52 struct AstValidator<'a> {
  53     session: &'a Session,
  54     has_proc_macro_decls: bool,
  55     has_global_allocator: bool,
  56
  57     // Used to ban nested `impl Trait`, e.g., `impl Into<impl Debug>`.
  58     // Nested `impl Trait` _is_ allowed in associated type position,
  59     // e.g `impl Iterator<Item=impl Debug>`
  60     outer_impl_trait: Option<OuterImplTrait>,
  61
  62     // Used to ban `impl Trait` in path projections like `<impl Iterator>::Item`
  63     // or `Foo::Bar<impl Trait>`
  64     is_impl_trait_banned: bool,
  65
  66     // rust-lang/rust#57979: the ban of nested `impl Trait` was buggy
  67     // until PRs #57730 and #57981 landed: it would jump directly to
  68     // walk_ty rather than visit_ty (or skip recurring entirely for
  69     // impl trait in projections), and thus miss some cases. We track
  70     // whether we should downgrade to a warning for short-term via
  71     // these booleans.
  72     warning_period_57979_didnt_record_next_impl_trait: bool,
  73     warning_period_57979_impl_trait_in_proj: bool,
  74 }
  75
  76 impl<'a> AstValidator<'a> {
  77     fn with_impl_trait_in_proj_warning<T>(&mut self, v: bool, f: impl FnOnce(&mut Self) -> T) -> T {
  78         let old = mem::replace(&mut self.warning_period_57979_impl_trait_in_proj, v);
  79         let ret = f(self);
  80         self.warning_period_57979_impl_trait_in_proj = old;
  81         ret
  82     }
  83
  84     fn with_banned_impl_trait(&mut self, f: impl FnOnce(&mut Self)) {
  85         let old = mem::replace(&mut self.is_impl_trait_banned, true);
  86         f(self);
  87         self.is_impl_trait_banned = old;
  88     }
  89
  90     fn with_impl_trait(&mut self, outer: Option<OuterImplTrait>, f: impl FnOnce(&mut Self)) {
  91         let old = mem::replace(&mut self.outer_impl_trait, outer);
  92         f(self);
  93         self.outer_impl_trait = old;
  94     }
  95
  96     fn visit_assoc_type_binding_from_generic_args(&mut self, type_binding: &'a TypeBinding) {
  97         // rust-lang/rust#57979: bug in old visit_generic_args called
  98         // walk_ty rather than visit_ty, skipping outer `impl Trait`
  99         // if it happened to occur at `type_binding.ty`
 100         if let TyKind::ImplTrait(..) = type_binding.ty.node {
 101             self.warning_period_57979_didnt_record_next_impl_trait = true;
 102         }
 103         self.visit_assoc_type_binding(type_binding);
 104     }
 105
 106     fn visit_ty_from_generic_args(&mut self, ty: &'a Ty) {
 107         // rust-lang/rust#57979: bug in old visit_generic_args called
 108         // walk_ty rather than visit_ty, skippping outer `impl Trait`
 109         // if it happened to occur at `ty`
 110         if let TyKind::ImplTrait(..) = ty.node {
 111             self.warning_period_57979_didnt_record_next_impl_trait = true;
 112         }
 113         self.visit_ty(ty);
 114     }
 115
 116     fn outer_impl_trait(&mut self, span: Span) -> OuterImplTrait {
 117         let only_recorded_since_pull_request_57730 =
 118             self.warning_period_57979_didnt_record_next_impl_trait;
 119
 120         // (this flag is designed to be set to true and then only
 121         // reach the construction point for the outer impl trait once,
 122         // so its safe and easiest to unconditionally reset it to
 123         // false)
 124         self.warning_period_57979_didnt_record_next_impl_trait = false;
 125
 126         OuterImplTrait {
 127             span, only_recorded_since_pull_request_57730,
 128         }
 129     }
 130
 131     // Mirrors visit::walk_ty, but tracks relevant state
 132     fn walk_ty(&mut self, t: &'a Ty) {
 133         match t.node {
 134             TyKind::ImplTrait(..) => {
 135                 let outer_impl_trait = self.outer_impl_trait(t.span);
 136                 self.with_impl_trait(Some(outer_impl_trait), |this| visit::walk_ty(this, t))
 137             }
 138             TyKind::Path(ref qself, ref path) => {
 139                 // We allow these:
 140                 //  - `Option<impl Trait>`
 141                 //  - `option::Option<impl Trait>`
 142                 //  - `option::Option<T>::Foo<impl Trait>
 143                 //
 144                 // But not these:
 145                 //  - `<impl Trait>::Foo`
 146                 //  - `option::Option<impl Trait>::Foo`.
 147                 //
 148                 // To implement this, we disallow `impl Trait` from `qself`
 149                 // (for cases like `<impl Trait>::Foo>`)
 150                 // but we allow `impl Trait` in `GenericArgs`
 151                 // iff there are no more PathSegments.
 152                 if let Some(ref qself) = *qself {
 153                     // `impl Trait` in `qself` is always illegal
 154                     self.with_banned_impl_trait(|this| this.visit_ty(&qself.ty));
 155                 }
 156
 157                 // Note that there should be a call to visit_path here,
 158                 // so if any logic is added to process `Path`s a call to it should be
 159                 // added both in visit_path and here. This code mirrors visit::walk_path.
 160                 for (i, segment) in path.segments.iter().enumerate() {
 161                     // Allow `impl Trait` iff we're on the final path segment
 162                     if i == path.segments.len() - 1 {
 163                         self.visit_path_segment(path.span, segment);
 164                     } else {
 165                         self.with_banned_impl_trait(|this| {
 166                             this.visit_path_segment(path.span, segment)
 167                         });
 168                     }
 169                 }
 170             }
 171             _ => visit::walk_ty(self, t),
 172         }
 173     }
 174
 175     fn err_handler(&self) -> &errors::Handler {
 176         &self.session.diagnostic()
 177     }
 178
 179     fn check_lifetime(&self, ident: Ident) {
 180         let valid_names = [keywords::UnderscoreLifetime.name(),
 181                            keywords::StaticLifetime.name(),
 182                            keywords::Invalid.name()];
 183         if !valid_names.contains(&ident.name) && ident.without_first_quote().is_reserved() {
 184             self.err_handler().span_err(ident.span, "lifetimes cannot use keyword names");
 185         }
 186     }
 187
 188     fn check_label(&self, ident: Ident) {
 189         if ident.without_first_quote().is_reserved() {
 190             self.err_handler()
 191                 .span_err(ident.span, &format!("invalid label name `{}`", ident.name));
 192         }
 193     }
 194
 195     fn invalid_non_exhaustive_attribute(&self, variant: &Variant) {
 196         let has_non_exhaustive = attr::contains_name(&variant.node.attrs, "non_exhaustive");
 197         if has_non_exhaustive {
 198             self.err_handler().span_err(variant.span,
 199                                         "#[non_exhaustive] is not yet supported on variants");
 200         }
 201     }
 202
 203     fn invalid_visibility(&self, vis: &Visibility, note: Option<&str>) {
 204         if let VisibilityKind::Inherited = vis.node {
 205             return
 206         }
 207
 208         let mut err = struct_span_err!(self.session,
 209                                         vis.span,
 210                                         E0449,
 211                                         "unnecessary visibility qualifier");
 212         if vis.node.is_pub() {
 213             err.span_label(vis.span, "`pub` not permitted here because it's implied");
 214         }
 215         if let Some(note) = note {
 216             err.note(note);
 217         }
 218         err.emit();
 219     }
 220
 221     fn check_decl_no_pat<ReportFn: Fn(Span, bool)>(&self, decl: &FnDecl, report_err: ReportFn) {
 222         for arg in &decl.inputs {
 223             match arg.pat.node {
 224                 PatKind::Ident(BindingMode::ByValue(Mutability::Immutable), _, None) |
 225                 PatKind::Wild => {}
 226                 PatKind::Ident(BindingMode::ByValue(Mutability::Mutable), _, None) =>
 227                     report_err(arg.pat.span, true),
 228                 _ => report_err(arg.pat.span, false),
 229             }
 230         }
 231     }
 232
 233     fn check_trait_fn_not_async(&self, span: Span, asyncness: IsAsync) {
 234         if asyncness.is_async() {
 235             struct_span_err!(self.session, span, E0706,
 236                              "trait fns cannot be declared `async`").emit()
 237         }
 238     }
 239
 240     fn check_trait_fn_not_const(&self, constness: Spanned<Constness>) {
 241         if constness.node == Constness::Const {
 242             struct_span_err!(self.session, constness.span, E0379,
 243                              "trait fns cannot be declared const")
 244                 .span_label(constness.span, "trait fns cannot be const")
 245                 .emit();
 246         }
 247     }
 248
 249     fn no_questions_in_bounds(&self, bounds: &GenericBounds, where_: &str, is_trait: bool) {
 250         for bound in bounds {
 251             if let GenericBound::Trait(ref poly, TraitBoundModifier::Maybe) = *bound {
 252                 let mut err = self.err_handler().struct_span_err(poly.span,
 253                     &format!("`?Trait` is not permitted in {}", where_));
 254                 if is_trait {
 255                     err.note(&format!("traits are `?{}` by default", poly.trait_ref.path));
 256                 }
 257                 err.emit();
 258             }
 259         }
 260     }
 261
 262     /// Matches `'-' lit | lit (cf. parser::Parser::parse_literal_maybe_minus)`,
 263     /// or paths for ranges.
 264     //
 265     // FIXME: do we want to allow `expr -> pattern` conversion to create path expressions?
 266     // That means making this work:
 267     //
 268     // ```rust,ignore (FIXME)
 269     // struct S;
 270     // macro_rules! m {
 271     //     ($a:expr) => {
 272     //         let $a = S;
 273     //     }
 274     // }
 275     // m!(S);
 276     // ```
 277     fn check_expr_within_pat(&self, expr: &Expr, allow_paths: bool) {
 278         match expr.node {
 279             ExprKind::Lit(..) => {}
 280             ExprKind::Path(..) if allow_paths => {}
 281             ExprKind::Unary(UnOp::Neg, ref inner)
 282                 if match inner.node { ExprKind::Lit(_) => true, _ => false } => {}
 283             _ => self.err_handler().span_err(expr.span, "arbitrary expressions aren't allowed \
 284                                                          in patterns")
 285         }
 286     }
 287
 288     fn check_late_bound_lifetime_defs(&self, params: &[GenericParam]) {
 289         // Check only lifetime parameters are present and that the lifetime
 290         // parameters that are present have no bounds.
 291         let non_lt_param_spans: Vec<_> = params.iter().filter_map(|param| match param.kind {
 292             GenericParamKind::Lifetime { .. } => {
 293                 if !param.bounds.is_empty() {
 294                     let spans: Vec<_> = param.bounds.iter().map(|b| b.span()).collect();
 295                     self.err_handler()
 296                         .span_err(spans, "lifetime bounds cannot be used in this context");
 297                 }
 298                 None
 299             }
 300             _ => Some(param.ident.span),
 301         }).collect();
 302         if !non_lt_param_spans.is_empty() {
 303             self.err_handler().span_err(non_lt_param_spans,
 304                 "only lifetime parameters can be used in this context");
 305         }
 306     }
 307
 308     /// With eRFC 2497, we need to check whether an expression is ambiguous and warn or error
 309     /// depending on the edition, this function handles that.
 310     fn while_if_let_ambiguity(&self, expr: &P<Expr>) {
 311         if let Some((span, op_kind)) = self.while_if_let_expr_ambiguity(&expr) {
 312             let mut err = self.err_handler().struct_span_err(
 313                 span, &format!("ambiguous use of `{}`", op_kind.to_string())
 314             );
 315
 316             err.note(
 317                 "this will be a error until the `let_chains` feature is stabilized"
 318             );
 319             err.note(
 320                 "see rust-lang/rust#53668 for more information"
 321             );
 322
 323             if let Ok(snippet) = self.session.source_map().span_to_snippet(span) {
 324                 err.span_suggestion(
 325                     span, "consider adding parentheses", format!("({})", snippet),
 326                     Applicability::MachineApplicable,
 327                 );
 328             }
 329
 330             err.emit();
 331         }
 332     }
 333
 334     /// With eRFC 2497 adding if-let chains, there is a requirement that the parsing of
 335     /// `&&` and `||` in a if-let statement be unambiguous. This function returns a span and
 336     /// a `BinOpKind` (either `&&` or `||` depending on what was ambiguous) if it is determined
 337     /// that the current expression parsed is ambiguous and will break in future.
 338     fn while_if_let_expr_ambiguity(&self, expr: &P<Expr>) -> Option<(Span, BinOpKind)> {
 339         debug!("while_if_let_expr_ambiguity: expr.node: {:?}", expr.node);
 340         match &expr.node {
 341             ExprKind::Binary(op, _, _) if op.node == BinOpKind::And || op.node == BinOpKind::Or => {
 342                 Some((expr.span, op.node))
 343             },
 344             ExprKind::Range(ref lhs, ref rhs, _) => {
 345                 let lhs_ambiguous = lhs.as_ref()
 346                     .and_then(|lhs| self.while_if_let_expr_ambiguity(lhs));
 347                 let rhs_ambiguous = rhs.as_ref()
 348                     .and_then(|rhs| self.while_if_let_expr_ambiguity(rhs));
 349
 350                 lhs_ambiguous.or(rhs_ambiguous)
 351             }
 352             _ => None,
 353         }
 354     }
 355 }
 356
 357 enum GenericPosition {
 358     Param,
 359     Arg,
 360 }
 361
 362 fn validate_generics_order<'a>(
 363     handler: &errors::Handler,
 364     generics: impl Iterator<
 365         Item = (
 366             ParamKindOrd,
 367             Option<&'a [GenericBound]>,
 368             Span,
 369             Option<String>
 370         ),
 371     >,
 372     pos: GenericPosition,
 373     span: Span,
 374 ) {
 375     let mut max_param: Option<ParamKindOrd> = None;
 376     let mut out_of_order = FxHashMap::default();
 377     let mut param_idents = vec![];
 378
 379     for (kind, bounds, span, ident) in generics {
 380         if let Some(ident) = ident {
 381             param_idents.push((kind, bounds, param_idents.len(), ident));
 382         }
 383         let max_param = &mut max_param;
 384         match max_param {
 385             Some(max_param) if *max_param > kind => {
 386                 let entry = out_of_order.entry(kind).or_insert((*max_param, vec![]));
 387                 entry.1.push(span);
 388             }
 389             Some(_) | None => *max_param = Some(kind),
 390         };
 391     }
 392
 393     let mut ordered_params = "<".to_string();
 394     if !out_of_order.is_empty() {
 395         param_idents.sort_by_key(|&(po, _, i, _)| (po, i));
 396         let mut first = true;
 397         for (_, bounds, _, ident) in param_idents {
 398             if !first {
 399                 ordered_params += ", ";
 400             }
 401             ordered_params += &ident;
 402             if let Some(bounds) = bounds {
 403                 if !bounds.is_empty() {
 404                     ordered_params += ": ";
 405                     ordered_params += &pprust::bounds_to_string(&bounds);
 406                 }
 407             }
 408             first = false;
 409         }
 410     }
 411     ordered_params += ">";
 412
 413     let pos_str = match pos {
 414         GenericPosition::Param => "parameter",
 415         GenericPosition::Arg => "argument",
 416     };
 417
 418     for (param_ord, (max_param, spans)) in out_of_order {
 419         let mut err = handler.struct_span_err(spans,
 420             &format!(
 421                 "{} {pos}s must be declared prior to {} {pos}s",
 422                 param_ord,
 423                 max_param,
 424                 pos = pos_str,
 425             ));
 426         if let GenericPosition::Param = pos {
 427             err.span_suggestion(
 428                 span,
 429                 &format!("reorder the {}s: lifetimes, then types, then consts", pos_str),
 430                 ordered_params.clone(),
 431                 Applicability::MachineApplicable,
 432             );
 433         }
 434         err.emit();
 435     }
 436 }
 437
 438 impl<'a> Visitor<'a> for AstValidator<'a> {
 439     fn visit_expr(&mut self, expr: &'a Expr) {
 440         match expr.node {
 441             ExprKind::IfLet(_, ref expr, _, _) | ExprKind::WhileLet(_, ref expr, _, _) =>
 442                 self.while_if_let_ambiguity(&expr),
 443             ExprKind::InlineAsm(..) if !self.session.target.target.options.allow_asm => {
 444                 span_err!(self.session, expr.span, E0472, "asm! is unsupported on this target");
 445             }
 446             ExprKind::ObsoleteInPlace(ref place, ref val) => {
 447                 let mut err = self.err_handler().struct_span_err(
 448                     expr.span,
 449                     "emplacement syntax is obsolete (for now, anyway)",
 450                 );
 451                 err.note(
 452                     "for more information, see \
 453                      <https://github.com/rust-lang/rust/issues/27779#issuecomment-378416911>"
 454                 );
 455                 match val.node {
 456                     ExprKind::Lit(ref v) if v.node.is_numeric() => {
 457                         err.span_suggestion(
 458                             place.span.between(val.span),
 459                             "if you meant to write a comparison against a negative value, add a \
 460                              space in between `<` and `-`",
 461                             "< -".to_string(),
 462                             Applicability::MaybeIncorrect
 463                         );
 464                     }
 465                     _ => {}
 466                 }
 467                 err.emit();
 468             }
 469             _ => {}
 470         }
 471
 472         visit::walk_expr(self, expr)
 473     }
 474
 475     fn visit_ty(&mut self, ty: &'a Ty) {
 476         match ty.node {
 477             TyKind::BareFn(ref bfty) => {
 478                 self.check_decl_no_pat(&bfty.decl, |span, _| {
 479                     struct_span_err!(self.session, span, E0561,
 480                                      "patterns aren't allowed in function pointer types").emit();
 481                 });
 482                 self.check_late_bound_lifetime_defs(&bfty.generic_params);
 483             }
 484             TyKind::TraitObject(ref bounds, ..) => {
 485                 let mut any_lifetime_bounds = false;
 486                 for bound in bounds {
 487                     if let GenericBound::Outlives(ref lifetime) = *bound {
 488                         if any_lifetime_bounds {
 489                             span_err!(self.session, lifetime.ident.span, E0226,
 490                                       "only a single explicit lifetime bound is permitted");
 491                             break;
 492                         }
 493                         any_lifetime_bounds = true;
 494                     }
 495                 }
 496                 self.no_questions_in_bounds(bounds, "trait object types", false);
 497             }
 498             TyKind::ImplTrait(_, ref bounds) => {
 499                 if self.is_impl_trait_banned {
 500                     if self.warning_period_57979_impl_trait_in_proj {
 501                         self.session.buffer_lint(
 502                             NESTED_IMPL_TRAIT, ty.id, ty.span,
 503                             "`impl Trait` is not allowed in path parameters");
 504                     } else {
 505                         struct_span_err!(self.session, ty.span, E0667,
 506                             "`impl Trait` is not allowed in path parameters").emit();
 507                     }
 508                 }
 509
 510                 if let Some(outer_impl_trait) = self.outer_impl_trait {
 511                     if outer_impl_trait.should_warn_instead_of_error() {
 512                         self.session.buffer_lint_with_diagnostic(
 513                             NESTED_IMPL_TRAIT, ty.id, ty.span,
 514                             "nested `impl Trait` is not allowed",
 515                             BuiltinLintDiagnostics::NestedImplTrait {
 516                                 outer_impl_trait_span: outer_impl_trait.span,
 517                                 inner_impl_trait_span: ty.span,
 518                             });
 519                     } else {
 520                         struct_span_err!(self.session, ty.span, E0666,
 521                             "nested `impl Trait` is not allowed")
 522                             .span_label(outer_impl_trait.span, "outer `impl Trait`")
 523                             .span_label(ty.span, "nested `impl Trait` here")
 524                             .emit();
 525                     }
 526                 }
 527
 528                 if !bounds.iter()
 529                           .any(|b| if let GenericBound::Trait(..) = *b { true } else { false }) {
 530                     self.err_handler().span_err(ty.span, "at least one trait must be specified");
 531                 }
 532
 533                 self.with_impl_trait_in_proj_warning(true, |this| this.walk_ty(ty));
 534                 return;
 535             }
 536             _ => {}
 537         }
 538
 539         self.walk_ty(ty)
 540     }
 541
 542     fn visit_label(&mut self, label: &'a Label) {
 543         self.check_label(label.ident);
 544         visit::walk_label(self, label);
 545     }
 546
 547     fn visit_lifetime(&mut self, lifetime: &'a Lifetime) {
 548         self.check_lifetime(lifetime.ident);
 549         visit::walk_lifetime(self, lifetime);
 550     }
 551
 552     fn visit_item(&mut self, item: &'a Item) {
 553         if item.attrs.iter().any(|attr| is_proc_macro_attr(attr)  ) {
 554             self.has_proc_macro_decls = true;
 555         }
 556
 557         if attr::contains_name(&item.attrs, "global_allocator") {
 558             self.has_global_allocator = true;
 559         }
 560
 561         match item.node {
 562             ItemKind::Impl(unsafety, polarity, _, _, Some(..), ref ty, ref impl_items) => {
 563                 self.invalid_visibility(&item.vis, None);
 564                 if let TyKind::Err = ty.node {
 565                     self.err_handler()
 566                         .struct_span_err(item.span, "`impl Trait for .. {}` is an obsolete syntax")
 567                         .help("use `auto trait Trait {}` instead").emit();
 568                 }
 569                 if unsafety == Unsafety::Unsafe && polarity == ImplPolarity::Negative {
 570                     span_err!(self.session, item.span, E0198, "negative impls cannot be unsafe");
 571                 }
 572                 for impl_item in impl_items {
 573                     self.invalid_visibility(&impl_item.vis, None);
 574                     if let ImplItemKind::Method(ref sig, _) = impl_item.node {
 575                         self.check_trait_fn_not_const(sig.header.constness);
 576                         self.check_trait_fn_not_async(impl_item.span, sig.header.asyncness.node);
 577                     }
 578                 }
 579             }
 580             ItemKind::Impl(unsafety, polarity, defaultness, _, None, _, _) => {
 581                 self.invalid_visibility(&item.vis,
 582                                         Some("place qualifiers on individual impl items instead"));
 583                 if unsafety == Unsafety::Unsafe {
 584                     span_err!(self.session, item.span, E0197, "inherent impls cannot be unsafe");
 585                 }
 586                 if polarity == ImplPolarity::Negative {
 587                     self.err_handler().span_err(item.span, "inherent impls cannot be negative");
 588                 }
 589                 if defaultness == Defaultness::Default {
 590                     self.err_handler()
 591                         .struct_span_err(item.span, "inherent impls cannot be default")
 592                         .note("only trait implementations may be annotated with default").emit();
 593                 }
 594             }
 595             ItemKind::Fn(_, ref header, ref generics, _) => {
 596                 // We currently do not permit const generics in `const fn`, as
 597                 // this is tantamount to allowing compile-time dependent typing.
 598                 self.visit_fn_header(header);
 599                 if header.constness.node == Constness::Const {
 600                     // Look for const generics and error if we find any.
 601                     for param in &generics.params {
 602                         match param.kind {
 603                             GenericParamKind::Const { .. } => {
 604                                 self.err_handler()
 605                                     .struct_span_err(
 606                                         item.span,
 607                                         "const parameters are not permitted in `const fn`",
 608                                     )
 609                                     .emit();
 610                             }
 611                             _ => {}
 612                         }
 613                     }
 614                 }
 615             }
 616             ItemKind::ForeignMod(..) => {
 617                 self.invalid_visibility(
 618                     &item.vis,
 619                     Some("place qualifiers on individual foreign items instead"),
 620                 );
 621             }
 622             ItemKind::Enum(ref def, _) => {
 623                 for variant in &def.variants {
 624                     self.invalid_non_exhaustive_attribute(variant);
 625                     for field in variant.node.data.fields() {
 626                         self.invalid_visibility(&field.vis, None);
 627                     }
 628                 }
 629             }
 630             ItemKind::Trait(is_auto, _, ref generics, ref bounds, ref trait_items) => {
 631                 if is_auto == IsAuto::Yes {
 632                     // Auto traits cannot have generics, super traits nor contain items.
 633                     if !generics.params.is_empty() {
 634                         struct_span_err!(self.session, item.span, E0567,
 635                                         "auto traits cannot have generic parameters").emit();
 636                     }
 637                     if !bounds.is_empty() {
 638                         struct_span_err!(self.session, item.span, E0568,
 639                                         "auto traits cannot have super traits").emit();
 640                     }
 641                     if !trait_items.is_empty() {
 642                         struct_span_err!(self.session, item.span, E0380,
 643                                 "auto traits cannot have methods or associated items").emit();
 644                     }
 645                 }
 646                 self.no_questions_in_bounds(bounds, "supertraits", true);
 647                 for trait_item in trait_items {
 648                     if let TraitItemKind::Method(ref sig, ref block) = trait_item.node {
 649                         self.check_trait_fn_not_async(trait_item.span, sig.header.asyncness.node);
 650                         self.check_trait_fn_not_const(sig.header.constness);
 651                         if block.is_none() {
 652                             self.check_decl_no_pat(&sig.decl, |span, mut_ident| {
 653                                 if mut_ident {
 654                                     self.session.buffer_lint(
 655                                         lint::builtin::PATTERNS_IN_FNS_WITHOUT_BODY,
 656                                         trait_item.id, span,
 657                                         "patterns aren't allowed in methods without bodies");
 658                                 } else {
 659                                     struct_span_err!(self.session, span, E0642,
 660                                         "patterns aren't allowed in methods without bodies").emit();
 661                                 }
 662                             });
 663                         }
 664                     }
 665                 }
 666             }
 667             ItemKind::Mod(_) => {
 668                 // Ensure that `path` attributes on modules are recorded as used (cf. issue #35584).
 669                 attr::first_attr_value_str_by_name(&item.attrs, "path");
 670                 if attr::contains_name(&item.attrs, "warn_directory_ownership") {
 671                     let lint = lint::builtin::LEGACY_DIRECTORY_OWNERSHIP;
 672                     let msg = "cannot declare a new module at this location";
 673                     self.session.buffer_lint(lint, item.id, item.span, msg);
 674                 }
 675             }
 676             ItemKind::Union(ref vdata, _) => {
 677                 if let VariantData::Tuple(..) | VariantData::Unit(..) = vdata {
 678                     self.err_handler().span_err(item.span,
 679                                                 "tuple and unit unions are not permitted");
 680                 }
 681                 if vdata.fields().is_empty() {
 682                     self.err_handler().span_err(item.span,
 683                                                 "unions cannot have zero fields");
 684                 }
 685             }
 686             _ => {}
 687         }
 688
 689         visit::walk_item(self, item)
 690     }
 691
 692     fn visit_foreign_item(&mut self, fi: &'a ForeignItem) {
 693         match fi.node {
 694             ForeignItemKind::Fn(ref decl, _) => {
 695                 self.check_decl_no_pat(decl, |span, _| {
 696                     struct_span_err!(self.session, span, E0130,
 697                                      "patterns aren't allowed in foreign function declarations")
 698                         .span_label(span, "pattern not allowed in foreign function").emit();
 699                 });
 700             }
 701             ForeignItemKind::Static(..) | ForeignItemKind::Ty | ForeignItemKind::Macro(..) => {}
 702         }
 703
 704         visit::walk_foreign_item(self, fi)
 705     }
 706
 707     // Mirrors visit::walk_generic_args, but tracks relevant state
 708     fn visit_generic_args(&mut self, _: Span, generic_args: &'a GenericArgs) {
 709         match *generic_args {
 710             GenericArgs::AngleBracketed(ref data) => {
 711                 walk_list!(self, visit_generic_arg, &data.args);
 712                 validate_generics_order(self.err_handler(), data.args.iter().map(|arg| {
 713                     (match arg {
 714                         GenericArg::Lifetime(..) => ParamKindOrd::Lifetime,
 715                         GenericArg::Type(..) => ParamKindOrd::Type,
 716                         GenericArg::Const(..) => ParamKindOrd::Const,
 717                     }, None, arg.span(), None)
 718                 }), GenericPosition::Arg, generic_args.span());
 719
 720                 // Type bindings such as `Item=impl Debug` in `Iterator<Item=Debug>`
 721                 // are allowed to contain nested `impl Trait`.
 722                 self.with_impl_trait(None, |this| {
 723                     walk_list!(this, visit_assoc_type_binding_from_generic_args, &data.bindings);
 724                 });
 725             }
 726             GenericArgs::Parenthesized(ref data) => {
 727                 walk_list!(self, visit_ty, &data.inputs);
 728                 if let Some(ref type_) = data.output {
 729                     // `-> Foo` syntax is essentially an associated type binding,
 730                     // so it is also allowed to contain nested `impl Trait`.
 731                     self.with_impl_trait(None, |this| this.visit_ty_from_generic_args(type_));
 732                 }
 733             }
 734         }
 735     }
 736
 737     fn visit_generics(&mut self, generics: &'a Generics) {
 738         let mut prev_ty_default = None;
 739         for param in &generics.params {
 740             if let GenericParamKind::Type { ref default, .. } = param.kind {
 741                 if default.is_some() {
 742                     prev_ty_default = Some(param.ident.span);
 743                 } else if let Some(span) = prev_ty_default {
 744                     self.err_handler()
 745                         .span_err(span, "type parameters with a default must be trailing");
 746                     break;
 747                 }
 748             }
 749         }
 750
 751         validate_generics_order(self.err_handler(), generics.params.iter().map(|param| {
 752             let ident = Some(param.ident.to_string());
 753             let (kind, ident) = match &param.kind {
 754                 GenericParamKind::Lifetime { .. } => (ParamKindOrd::Lifetime, ident),
 755                 GenericParamKind::Type { .. } => (ParamKindOrd::Type, ident),
 756                 GenericParamKind::Const { ref ty } => {
 757                     let ty = pprust::ty_to_string(ty);
 758                     (ParamKindOrd::Const, Some(format!("const {}: {}", param.ident, ty)))
 759                 }
 760             };
 761             (kind, Some(&*param.bounds), param.ident.span, ident)
 762         }), GenericPosition::Param, generics.span);
 763
 764         for predicate in &generics.where_clause.predicates {
 765             if let WherePredicate::EqPredicate(ref predicate) = *predicate {
 766                 self.err_handler()
 767                     .span_err(predicate.span, "equality constraints are not yet \
 768                                                supported in where clauses (see #20041)");
 769             }
 770         }
 771
 772         visit::walk_generics(self, generics)
 773     }
 774
 775     fn visit_generic_param(&mut self, param: &'a GenericParam) {
 776         if let GenericParamKind::Lifetime { .. } = param.kind {
 777             self.check_lifetime(param.ident);
 778         }
 779         visit::walk_generic_param(self, param);
 780     }
 781
 782     fn visit_pat(&mut self, pat: &'a Pat) {
 783         match pat.node {
 784             PatKind::Lit(ref expr) => {
 785                 self.check_expr_within_pat(expr, false);
 786             }
 787             PatKind::Range(ref start, ref end, _) => {
 788                 self.check_expr_within_pat(start, true);
 789                 self.check_expr_within_pat(end, true);
 790             }
 791             _ => {}
 792         }
 793
 794         visit::walk_pat(self, pat)
 795     }
 796
 797     fn visit_where_predicate(&mut self, p: &'a WherePredicate) {
 798         if let &WherePredicate::BoundPredicate(ref bound_predicate) = p {
 799             // A type binding, eg `for<'c> Foo: Send+Clone+'c`
 800             self.check_late_bound_lifetime_defs(&bound_predicate.bound_generic_params);
 801         }
 802         visit::walk_where_predicate(self, p);
 803     }
 804
 805     fn visit_poly_trait_ref(&mut self, t: &'a PolyTraitRef, m: &'a TraitBoundModifier) {
 806         self.check_late_bound_lifetime_defs(&t.bound_generic_params);
 807         visit::walk_poly_trait_ref(self, t, m);
 808     }
 809
 810     fn visit_mac(&mut self, mac: &Spanned<Mac_>) {
 811         // when a new macro kind is added but the author forgets to set it up for expansion
 812         // because that's the only part that won't cause a compiler error
 813         self.session.diagnostic()
 814             .span_bug(mac.span, "macro invocation missed in expansion; did you forget to override \
 815                                  the relevant `fold_*()` method in `PlaceholderExpander`?");
 816     }
 817
 818     fn visit_fn_header(&mut self, header: &'a FnHeader) {
 819         if header.asyncness.node.is_async() && self.session.rust_2015() {
 820             struct_span_err!(self.session, header.asyncness.span, E0670,
 821                              "`async fn` is not permitted in the 2015 edition").emit();
 822         }
 823     }
 824 }
 825
 826 pub fn check_crate(session: &Session, krate: &Crate) -> (bool, bool) {
 827     let mut validator = AstValidator {
 828         session,
 829         has_proc_macro_decls: false,
 830         has_global_allocator: false,
 831         outer_impl_trait: None,
 832         is_impl_trait_banned: false,
 833         warning_period_57979_didnt_record_next_impl_trait: false,
 834         warning_period_57979_impl_trait_in_proj: false,
 835     };
 836     visit::walk_crate(&mut validator, krate);
 837
 838     (validator.has_proc_macro_decls, validator.has_global_allocator)
 839 }