1 //! A pass that promotes borrows of constant rvalues.
3 //! The rvalues considered constant are trees of temps,
4 //! each with exactly one initialization, and holding
5 //! a constant value with no interior mutability.
6 //! They are placed into a new MIR constant body in
7 //! `promoted` and the borrow rvalue is replaced with
8 //! a `Literal::Promoted` using the index into `promoted`
9 //! of that constant MIR.
11 //! This pass assumes that every use is dominated by an
12 //! initialization and can otherwise silence errors, if
13 //! move analysis runs after promotion on broken MIR.
15 use rustc::mir::traversal::ReversePostorder;
16 use rustc::mir::visit::{MutVisitor, MutatingUseContext, PlaceContext, Visitor};
18 use rustc::ty::cast::CastTy;
19 use rustc::ty::subst::InternalSubsts;
20 use rustc::ty::{self, List, TyCtxt, TypeFoldable};
21 use rustc_hir::def_id::DefId;
22 use rustc_span::symbol::sym;
23 use rustc_span::{Span, DUMMY_SP};
24 use syntax::ast::LitKind;
26 use rustc_index::vec::{Idx, IndexVec};
27 use rustc_target::spec::abi::Abi;
30 use std::{cmp, iter, mem, usize};
32 use crate::const_eval::{is_const_fn, is_unstable_const_fn};
33 use crate::transform::check_consts::{is_lang_panic_fn, qualifs, ConstKind, Item};
34 use crate::transform::{MirPass, MirSource};
36 /// A `MirPass` for promotion.
38 /// Promotion is the extraction of promotable temps into separate MIR bodies. This pass also emits
39 /// errors when promotion of `#[rustc_args_required_const]` arguments fails.
41 /// After this pass is run, `promoted_fragments` will hold the MIR body corresponding to each
42 /// newly created `Constant`.
44 pub struct PromoteTemps<'tcx> {
45 pub promoted_fragments: Cell<IndexVec<Promoted, BodyAndCache<'tcx>>>,
48 impl<'tcx> MirPass<'tcx> for PromoteTemps<'tcx> {
49 fn run_pass(&self, tcx: TyCtxt<'tcx>, src: MirSource<'tcx>, body: &mut BodyAndCache<'tcx>) {
50 // There's not really any point in promoting errorful MIR.
52 // This does not include MIR that failed const-checking, which we still try to promote.
53 if body.return_ty().references_error() {
54 tcx.sess.delay_span_bug(body.span, "PromoteTemps: MIR had errors");
58 if src.promoted.is_some() {
62 let def_id = src.def_id();
64 let mut rpo = traversal::reverse_postorder(body);
65 let (temps, all_candidates) = collect_temps_and_candidates(tcx, body, &mut rpo);
67 let promotable_candidates =
68 validate_candidates(tcx, read_only!(body), def_id, &temps, &all_candidates);
70 let promoted = promote_candidates(def_id, body, tcx, temps, promotable_candidates);
71 self.promoted_fragments.set(promoted);
75 /// State of a temporary during collection and promotion.
76 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
78 /// No references to this temp.
80 /// One direct assignment and any number of direct uses.
81 /// A borrow of this temp is promotable if the assigned
82 /// value is qualified as constant.
83 Defined { location: Location, uses: usize },
84 /// Any other combination of assignments/uses.
86 /// This temp was part of an rvalue which got extracted
87 /// during promotion and needs cleanup.
92 pub fn is_promotable(&self) -> bool {
93 debug!("is_promotable: self={:?}", self);
94 if let TempState::Defined { .. } = *self { true } else { false }
98 /// A "root candidate" for promotion, which will become the
99 /// returned value in a promoted MIR, unless it's a subset
100 /// of a larger candidate.
101 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
103 /// Borrow of a constant temporary.
106 /// Promotion of the `x` in `[x; 32]`.
109 /// Currently applied to function calls where the callee has the unstable
110 /// `#[rustc_args_required_const]` attribute as well as the SIMD shuffle
111 /// intrinsic. The intrinsic requires the arguments are indeed constant and
112 /// the attribute currently provides the semantic requirement that arguments
113 /// must be constant.
114 Argument { bb: BasicBlock, index: usize },
118 /// Returns `true` if we should use the "explicit" rules for promotability for this `Candidate`.
119 fn forces_explicit_promotion(&self) -> bool {
121 Candidate::Ref(_) | Candidate::Repeat(_) => false,
122 Candidate::Argument { .. } => true,
127 fn args_required_const(tcx: TyCtxt<'_>, def_id: DefId) -> Option<Vec<usize>> {
128 let attrs = tcx.get_attrs(def_id);
129 let attr = attrs.iter().find(|a| a.check_name(sym::rustc_args_required_const))?;
130 let mut ret = vec![];
131 for meta in attr.meta_item_list()? {
132 match meta.literal()?.kind {
133 LitKind::Int(a, _) => {
134 ret.push(a as usize);
142 struct Collector<'a, 'tcx> {
144 body: &'a Body<'tcx>,
145 temps: IndexVec<Local, TempState>,
146 candidates: Vec<Candidate>,
150 impl<'tcx> Visitor<'tcx> for Collector<'_, 'tcx> {
151 fn visit_local(&mut self, &index: &Local, context: PlaceContext, location: Location) {
152 debug!("visit_local: index={:?} context={:?} location={:?}", index, context, location);
153 // We're only interested in temporaries and the return place
154 match self.body.local_kind(index) {
155 LocalKind::Temp | LocalKind::ReturnPointer => {}
156 LocalKind::Arg | LocalKind::Var => return,
159 // Ignore drops, if the temp gets promoted,
160 // then it's constant and thus drop is noop.
161 // Non-uses are also irrelevant.
162 if context.is_drop() || !context.is_use() {
164 "visit_local: context.is_drop={:?} context.is_use={:?}",
171 let temp = &mut self.temps[index];
172 debug!("visit_local: temp={:?}", temp);
173 if *temp == TempState::Undefined {
175 PlaceContext::MutatingUse(MutatingUseContext::Store)
176 | PlaceContext::MutatingUse(MutatingUseContext::Call) => {
177 *temp = TempState::Defined { location, uses: 0 };
180 _ => { /* mark as unpromotable below */ }
182 } else if let TempState::Defined { ref mut uses, .. } = *temp {
183 // We always allow borrows, even mutable ones, as we need
184 // to promote mutable borrows of some ZSTs e.g., `&mut []`.
185 let allowed_use = match context {
186 PlaceContext::MutatingUse(MutatingUseContext::Borrow)
187 | PlaceContext::NonMutatingUse(_) => true,
188 PlaceContext::MutatingUse(_) | PlaceContext::NonUse(_) => false,
190 debug!("visit_local: allowed_use={:?}", allowed_use);
195 /* mark as unpromotable below */
197 *temp = TempState::Unpromotable;
200 fn visit_rvalue(&mut self, rvalue: &Rvalue<'tcx>, location: Location) {
201 self.super_rvalue(rvalue, location);
205 self.candidates.push(Candidate::Ref(location));
207 Rvalue::Repeat(..) if self.tcx.features().const_in_array_repeat_expressions => {
208 // FIXME(#49147) only promote the element when it isn't `Copy`
209 // (so that code that can copy it at runtime is unaffected).
210 self.candidates.push(Candidate::Repeat(location));
216 fn visit_terminator_kind(&mut self, kind: &TerminatorKind<'tcx>, location: Location) {
217 self.super_terminator_kind(kind, location);
219 if let TerminatorKind::Call { ref func, .. } = *kind {
220 if let ty::FnDef(def_id, _) = func.ty(self.body, self.tcx).kind {
221 let fn_sig = self.tcx.fn_sig(def_id);
222 if let Abi::RustIntrinsic | Abi::PlatformIntrinsic = fn_sig.abi() {
223 let name = self.tcx.item_name(def_id);
224 // FIXME(eddyb) use `#[rustc_args_required_const(2)]` for shuffles.
225 if name.as_str().starts_with("simd_shuffle") {
226 self.candidates.push(Candidate::Argument { bb: location.block, index: 2 });
228 return; // Don't double count `simd_shuffle` candidates
232 if let Some(constant_args) = args_required_const(self.tcx, def_id) {
233 for index in constant_args {
234 self.candidates.push(Candidate::Argument { bb: location.block, index });
241 fn visit_source_info(&mut self, source_info: &SourceInfo) {
242 self.span = source_info.span;
246 pub fn collect_temps_and_candidates(
249 rpo: &mut ReversePostorder<'_, 'tcx>,
250 ) -> (IndexVec<Local, TempState>, Vec<Candidate>) {
251 let mut collector = Collector {
254 temps: IndexVec::from_elem(TempState::Undefined, &body.local_decls),
258 for (bb, data) in rpo {
259 collector.visit_basic_block_data(bb, data);
261 (collector.temps, collector.candidates)
264 /// Checks whether locals that appear in a promotion context (`Candidate`) are actually promotable.
266 /// This wraps an `Item`, and has access to all fields of that `Item` via `Deref` coercion.
267 struct Validator<'a, 'tcx> {
268 item: Item<'a, 'tcx>,
269 temps: &'a IndexVec<Local, TempState>,
271 /// Explicit promotion happens e.g. for constant arguments declared via
272 /// `rustc_args_required_const`.
273 /// Implicit promotion has almost the same rules, except that disallows `const fn`
274 /// except for those marked `#[rustc_promotable]`. This is to avoid changing
275 /// a legitimate run-time operation into a failing compile-time operation
276 /// e.g. due to addresses being compared inside the function.
280 impl std::ops::Deref for Validator<'a, 'tcx> {
281 type Target = Item<'a, 'tcx>;
283 fn deref(&self) -> &Self::Target {
290 impl<'tcx> Validator<'_, 'tcx> {
291 fn validate_candidate(&self, candidate: Candidate) -> Result<(), Unpromotable> {
293 Candidate::Ref(loc) => {
294 assert!(!self.explicit);
296 let statement = &self.body[loc.block].statements[loc.statement_index];
297 match &statement.kind {
298 StatementKind::Assign(box (_, Rvalue::Ref(_, kind, place))) => {
300 BorrowKind::Shared | BorrowKind::Mut { .. } => {}
302 // FIXME(eddyb) these aren't promoted here but *could*
303 // be promoted as part of a larger value because
304 // `validate_rvalue` doesn't check them, need to
305 // figure out what is the intended behavior.
306 BorrowKind::Shallow | BorrowKind::Unique => return Err(Unpromotable),
309 // We can only promote interior borrows of promotable temps (non-temps
310 // don't get promoted anyway).
311 self.validate_local(place.local)?;
313 if place.projection.contains(&ProjectionElem::Deref) {
314 return Err(Unpromotable);
317 let mut has_mut_interior =
318 self.qualif_local::<qualifs::HasMutInterior>(place.local);
319 // HACK(eddyb) this should compute the same thing as
320 // `<HasMutInterior as Qualif>::in_projection` from
321 // `check_consts::qualifs` but without recursion.
322 if has_mut_interior {
323 // This allows borrowing fields which don't have
324 // `HasMutInterior`, from a type that does, e.g.:
325 // `let _: &'static _ = &(Cell::new(1), 2).1;`
326 let mut place_projection = &place.projection[..];
327 // FIXME(eddyb) use a forward loop instead of a reverse one.
328 while let [proj_base @ .., elem] = place_projection {
329 // FIXME(eddyb) this is probably excessive, with
330 // the exception of `union` member accesses.
332 Place::ty_from(&place.local, proj_base, *self.body, self.tcx)
333 .projection_ty(self.tcx, elem)
335 if ty.is_freeze(self.tcx, self.param_env, DUMMY_SP) {
336 has_mut_interior = false;
340 place_projection = proj_base;
344 // FIXME(eddyb) this duplicates part of `validate_rvalue`.
345 if has_mut_interior {
346 return Err(Unpromotable);
348 if self.qualif_local::<qualifs::NeedsDrop>(place.local) {
349 return Err(Unpromotable);
352 if let BorrowKind::Mut { .. } = kind {
353 let ty = place.ty(*self.body, self.tcx).ty;
355 // In theory, any zero-sized value could be borrowed
356 // mutably without consequences. However, only &mut []
357 // is allowed right now, and only in functions.
358 if self.const_kind == Some(ConstKind::StaticMut) {
359 // Inside a `static mut`, &mut [...] is also allowed.
361 ty::Array(..) | ty::Slice(_) => {}
362 _ => return Err(Unpromotable),
364 } else if let ty::Array(_, len) = ty.kind {
365 // FIXME(eddyb) the `self.is_non_const_fn` condition
366 // seems unnecessary, given that this is merely a ZST.
367 match len.try_eval_usize(self.tcx, self.param_env) {
368 Some(0) if self.const_kind.is_none() => {}
369 _ => return Err(Unpromotable),
372 return Err(Unpromotable);
381 Candidate::Repeat(loc) => {
382 assert!(!self.explicit);
384 let statement = &self.body[loc.block].statements[loc.statement_index];
385 match &statement.kind {
386 StatementKind::Assign(box (_, Rvalue::Repeat(ref operand, _))) => {
387 if !self.tcx.features().const_in_array_repeat_expressions {
388 return Err(Unpromotable);
391 self.validate_operand(operand)
396 Candidate::Argument { bb, index } => {
397 assert!(self.explicit);
399 let terminator = self.body[bb].terminator();
400 match &terminator.kind {
401 TerminatorKind::Call { args, .. } => self.validate_operand(&args[index]),
408 // FIXME(eddyb) maybe cache this?
409 fn qualif_local<Q: qualifs::Qualif>(&self, local: Local) -> bool {
410 let per_local = &|l| self.qualif_local::<Q>(l);
412 if let TempState::Defined { location: loc, .. } = self.temps[local] {
413 let num_stmts = self.body[loc.block].statements.len();
415 if loc.statement_index < num_stmts {
416 let statement = &self.body[loc.block].statements[loc.statement_index];
417 match &statement.kind {
418 StatementKind::Assign(box (_, rhs)) => Q::in_rvalue(&self.item, per_local, rhs),
421 statement.source_info.span,
422 "{:?} is not an assignment",
428 let terminator = self.body[loc.block].terminator();
429 match &terminator.kind {
430 TerminatorKind::Call { func, args, .. } => {
431 let return_ty = self.body.local_decls[local].ty;
432 Q::in_call(&self.item, per_local, func, args, return_ty)
435 span_bug!(terminator.source_info.span, "{:?} not promotable", kind);
440 let span = self.body.local_decls[local].source_info.span;
441 span_bug!(span, "{:?} not promotable, qualif_local shouldn't have been called", local);
445 // FIXME(eddyb) maybe cache this?
446 fn validate_local(&self, local: Local) -> Result<(), Unpromotable> {
447 if let TempState::Defined { location: loc, .. } = self.temps[local] {
448 let num_stmts = self.body[loc.block].statements.len();
450 if loc.statement_index < num_stmts {
451 let statement = &self.body[loc.block].statements[loc.statement_index];
452 match &statement.kind {
453 StatementKind::Assign(box (_, rhs)) => self.validate_rvalue(rhs),
456 statement.source_info.span,
457 "{:?} is not an assignment",
463 let terminator = self.body[loc.block].terminator();
464 match &terminator.kind {
465 TerminatorKind::Call { func, args, .. } => self.validate_call(func, args),
467 span_bug!(terminator.source_info.span, "{:?} not promotable", kind);
476 fn validate_place(&self, place: PlaceRef<'_, 'tcx>) -> Result<(), Unpromotable> {
478 PlaceRef { local, projection: [] } => self.validate_local(*local),
479 PlaceRef { local: _, projection: [proj_base @ .., elem] } => {
481 ProjectionElem::Deref | ProjectionElem::Downcast(..) => {
482 return Err(Unpromotable);
485 ProjectionElem::ConstantIndex { .. } | ProjectionElem::Subslice { .. } => {}
487 ProjectionElem::Index(local) => {
488 self.validate_local(local)?;
491 ProjectionElem::Field(..) => {
492 if self.const_kind.is_none() {
494 Place::ty_from(place.local, proj_base, *self.body, self.tcx).ty;
495 if let Some(def) = base_ty.ty_adt_def() {
496 // No promotion of union field accesses.
498 return Err(Unpromotable);
505 self.validate_place(PlaceRef { local: place.local, projection: proj_base })
510 fn validate_operand(&self, operand: &Operand<'tcx>) -> Result<(), Unpromotable> {
512 Operand::Copy(place) | Operand::Move(place) => self.validate_place(place.as_ref()),
514 // The qualifs for a constant (e.g. `HasMutInterior`) are checked in
515 // `validate_rvalue` upon access.
516 Operand::Constant(c) => {
517 if let Some(def_id) = c.check_static_ptr(self.tcx) {
518 // Only allow statics (not consts) to refer to other statics.
519 // FIXME(eddyb) does this matter at all for promotion?
520 let is_static = self.const_kind.map_or(false, |k| k.is_static());
522 return Err(Unpromotable);
525 let is_thread_local = self.tcx.has_attr(def_id, sym::thread_local);
527 return Err(Unpromotable);
536 fn validate_rvalue(&self, rvalue: &Rvalue<'tcx>) -> Result<(), Unpromotable> {
538 Rvalue::Cast(CastKind::Misc, ref operand, cast_ty) if self.const_kind.is_none() => {
539 let operand_ty = operand.ty(*self.body, self.tcx);
540 let cast_in = CastTy::from_ty(operand_ty).expect("bad input type for cast");
541 let cast_out = CastTy::from_ty(cast_ty).expect("bad output type for cast");
542 match (cast_in, cast_out) {
543 (CastTy::Ptr(_), CastTy::Int(_)) | (CastTy::FnPtr, CastTy::Int(_)) => {
544 // in normal functions, mark such casts as not promotable
545 return Err(Unpromotable);
551 Rvalue::BinaryOp(op, ref lhs, _) if self.const_kind.is_none() => {
552 if let ty::RawPtr(_) | ty::FnPtr(..) = lhs.ty(*self.body, self.tcx).kind {
560 || op == BinOp::Offset
563 // raw pointer operations are not allowed inside promoteds
564 return Err(Unpromotable);
568 Rvalue::NullaryOp(NullOp::Box, _) => return Err(Unpromotable),
574 Rvalue::NullaryOp(..) => Ok(()),
576 Rvalue::Discriminant(place) | Rvalue::Len(place) => self.validate_place(place.as_ref()),
579 | Rvalue::Repeat(operand, _)
580 | Rvalue::UnaryOp(_, operand)
581 | Rvalue::Cast(_, operand, _) => self.validate_operand(operand),
583 Rvalue::BinaryOp(_, lhs, rhs) | Rvalue::CheckedBinaryOp(_, lhs, rhs) => {
584 self.validate_operand(lhs)?;
585 self.validate_operand(rhs)
588 Rvalue::AddressOf(_, place) => {
589 // Raw reborrows can come from reference to pointer coercions,
591 if let [proj_base @ .., ProjectionElem::Deref] = place.projection.as_ref() {
592 let base_ty = Place::ty_from(&place.local, proj_base, *self.body, self.tcx).ty;
593 if let ty::Ref(..) = base_ty.kind {
594 return self.validate_place(PlaceRef {
596 projection: proj_base,
603 Rvalue::Ref(_, kind, place) => {
604 if let BorrowKind::Mut { .. } = kind {
605 let ty = place.ty(*self.body, self.tcx).ty;
607 // In theory, any zero-sized value could be borrowed
608 // mutably without consequences. However, only &mut []
609 // is allowed right now, and only in functions.
610 if self.const_kind == Some(ConstKind::StaticMut) {
611 // Inside a `static mut`, &mut [...] is also allowed.
613 ty::Array(..) | ty::Slice(_) => {}
614 _ => return Err(Unpromotable),
616 } else if let ty::Array(_, len) = ty.kind {
617 // FIXME(eddyb): We only return `Unpromotable` for `&mut []` inside a
618 // const context which seems unnecessary given that this is merely a ZST.
619 match len.try_eval_usize(self.tcx, self.param_env) {
620 Some(0) if self.const_kind.is_none() => {}
621 _ => return Err(Unpromotable),
624 return Err(Unpromotable);
628 // Special-case reborrows to be more like a copy of the reference.
629 let mut place = place.as_ref();
630 if let [proj_base @ .., ProjectionElem::Deref] = &place.projection {
631 let base_ty = Place::ty_from(&place.local, proj_base, *self.body, self.tcx).ty;
632 if let ty::Ref(..) = base_ty.kind {
633 place = PlaceRef { local: &place.local, projection: proj_base };
637 self.validate_place(place)?;
639 // HACK(eddyb) this should compute the same thing as
640 // `<HasMutInterior as Qualif>::in_projection` from
641 // `check_consts::qualifs` but without recursion.
642 let mut has_mut_interior =
643 self.qualif_local::<qualifs::HasMutInterior>(*place.local);
644 if has_mut_interior {
645 let mut place_projection = place.projection;
646 // FIXME(eddyb) use a forward loop instead of a reverse one.
647 while let [proj_base @ .., elem] = place_projection {
648 // FIXME(eddyb) this is probably excessive, with
649 // the exception of `union` member accesses.
650 let ty = Place::ty_from(place.local, proj_base, *self.body, self.tcx)
651 .projection_ty(self.tcx, elem)
653 if ty.is_freeze(self.tcx, self.param_env, DUMMY_SP) {
654 has_mut_interior = false;
658 place_projection = proj_base;
661 if has_mut_interior {
662 return Err(Unpromotable);
668 Rvalue::Aggregate(_, ref operands) => {
670 self.validate_operand(o)?;
680 callee: &Operand<'tcx>,
681 args: &[Operand<'tcx>],
682 ) -> Result<(), Unpromotable> {
683 let fn_ty = callee.ty(*self.body, self.tcx);
685 if !self.explicit && self.const_kind.is_none() {
686 if let ty::FnDef(def_id, _) = fn_ty.kind {
687 // Never promote runtime `const fn` calls of
688 // functions without `#[rustc_promotable]`.
689 if !self.tcx.is_promotable_const_fn(def_id) {
690 return Err(Unpromotable);
695 let is_const_fn = match fn_ty.kind {
696 ty::FnDef(def_id, _) => {
697 is_const_fn(self.tcx, def_id)
698 || is_unstable_const_fn(self.tcx, def_id).is_some()
699 || is_lang_panic_fn(self.tcx, self.def_id)
704 return Err(Unpromotable);
707 self.validate_operand(callee)?;
709 self.validate_operand(arg)?;
716 // FIXME(eddyb) remove the differences for promotability in `static`, `const`, `const fn`.
717 pub fn validate_candidates(
719 body: ReadOnlyBodyAndCache<'_, 'tcx>,
721 temps: &IndexVec<Local, TempState>,
722 candidates: &[Candidate],
723 ) -> Vec<Candidate> {
724 let mut validator = Validator { item: Item::new(tcx, def_id, body), temps, explicit: false };
729 .filter(|&candidate| {
730 validator.explicit = candidate.forces_explicit_promotion();
732 // FIXME(eddyb) also emit the errors for shuffle indices
733 // and `#[rustc_args_required_const]` arguments here.
735 let is_promotable = validator.validate_candidate(candidate).is_ok();
737 Candidate::Argument { bb, index } if !is_promotable => {
738 let span = body[bb].terminator().source_info.span;
739 let msg = format!("argument {} is required to be a constant", index + 1);
740 tcx.sess.span_err(span, &msg);
750 struct Promoter<'a, 'tcx> {
752 source: &'a mut BodyAndCache<'tcx>,
753 promoted: BodyAndCache<'tcx>,
754 temps: &'a mut IndexVec<Local, TempState>,
755 extra_statements: &'a mut Vec<(Location, Statement<'tcx>)>,
757 /// If true, all nested temps are also kept in the
758 /// source MIR, not moved to the promoted MIR.
762 impl<'a, 'tcx> Promoter<'a, 'tcx> {
763 fn new_block(&mut self) -> BasicBlock {
764 let span = self.promoted.span;
765 self.promoted.basic_blocks_mut().push(BasicBlockData {
767 terminator: Some(Terminator {
768 source_info: SourceInfo { span, scope: OUTERMOST_SOURCE_SCOPE },
769 kind: TerminatorKind::Return,
775 fn assign(&mut self, dest: Local, rvalue: Rvalue<'tcx>, span: Span) {
776 let last = self.promoted.basic_blocks().last().unwrap();
777 let data = &mut self.promoted[last];
778 data.statements.push(Statement {
779 source_info: SourceInfo { span, scope: OUTERMOST_SOURCE_SCOPE },
780 kind: StatementKind::Assign(box (Place::from(dest), rvalue)),
784 fn is_temp_kind(&self, local: Local) -> bool {
785 self.source.local_kind(local) == LocalKind::Temp
788 /// Copies the initialization of this temp to the
789 /// promoted MIR, recursing through temps.
790 fn promote_temp(&mut self, temp: Local) -> Local {
791 let old_keep_original = self.keep_original;
792 let loc = match self.temps[temp] {
793 TempState::Defined { location, uses } if uses > 0 => {
795 self.keep_original = true;
800 span_bug!(self.promoted.span, "{:?} not promotable: {:?}", temp, state);
803 if !self.keep_original {
804 self.temps[temp] = TempState::PromotedOut;
807 let num_stmts = self.source[loc.block].statements.len();
808 let new_temp = self.promoted.local_decls.push(LocalDecl::new_temp(
809 self.source.local_decls[temp].ty,
810 self.source.local_decls[temp].source_info.span,
813 debug!("promote({:?} @ {:?}/{:?}, {:?})", temp, loc, num_stmts, self.keep_original);
815 // First, take the Rvalue or Call out of the source MIR,
816 // or duplicate it, depending on keep_original.
817 if loc.statement_index < num_stmts {
818 let (mut rvalue, source_info) = {
819 let statement = &mut self.source[loc.block].statements[loc.statement_index];
820 let rhs = match statement.kind {
821 StatementKind::Assign(box (_, ref mut rhs)) => rhs,
824 statement.source_info.span,
825 "{:?} is not an assignment",
832 if self.keep_original {
835 let unit = Rvalue::Aggregate(box AggregateKind::Tuple, vec![]);
836 mem::replace(rhs, unit)
838 statement.source_info,
842 self.visit_rvalue(&mut rvalue, loc);
843 self.assign(new_temp, rvalue, source_info.span);
845 let terminator = if self.keep_original {
846 self.source[loc.block].terminator().clone()
848 let terminator = self.source[loc.block].terminator_mut();
849 let target = match terminator.kind {
850 TerminatorKind::Call { destination: Some((_, target)), .. } => target,
852 span_bug!(terminator.source_info.span, "{:?} not promotable", kind);
856 source_info: terminator.source_info,
857 kind: mem::replace(&mut terminator.kind, TerminatorKind::Goto { target }),
861 match terminator.kind {
862 TerminatorKind::Call { mut func, mut args, from_hir_call, .. } => {
863 self.visit_operand(&mut func, loc);
864 for arg in &mut args {
865 self.visit_operand(arg, loc);
868 let last = self.promoted.basic_blocks().last().unwrap();
869 let new_target = self.new_block();
871 *self.promoted[last].terminator_mut() = Terminator {
872 kind: TerminatorKind::Call {
876 destination: Some((Place::from(new_temp), new_target)),
883 span_bug!(terminator.source_info.span, "{:?} not promotable", kind);
888 self.keep_original = old_keep_original;
892 fn promote_candidate(
895 candidate: Candidate,
896 next_promoted_id: usize,
897 ) -> Option<BodyAndCache<'tcx>> {
899 let promoted = &mut self.promoted;
900 let promoted_id = Promoted::new(next_promoted_id);
902 let mut promoted_operand = |ty, span| {
903 promoted.span = span;
904 promoted.local_decls[RETURN_PLACE] = LocalDecl::new_return_place(ty, span);
906 Operand::Constant(Box::new(Constant {
909 literal: tcx.mk_const(ty::Const {
911 val: ty::ConstKind::Unevaluated(
913 InternalSubsts::identity_for_item(tcx, def_id),
919 let (blocks, local_decls) = self.source.basic_blocks_and_local_decls_mut();
921 Candidate::Ref(loc) => {
922 let ref mut statement = blocks[loc.block].statements[loc.statement_index];
923 match statement.kind {
924 StatementKind::Assign(box (
926 Rvalue::Ref(ref mut region, borrow_kind, ref mut place),
928 // Use the underlying local for this (necessarily interior) borrow.
929 let ty = local_decls.local_decls()[place.local].ty;
930 let span = statement.source_info.span;
932 let ref_ty = tcx.mk_ref(
933 tcx.lifetimes.re_erased,
934 ty::TypeAndMut { ty, mutbl: borrow_kind.to_mutbl_lossy() },
937 *region = tcx.lifetimes.re_erased;
939 let mut projection = vec![PlaceElem::Deref];
940 projection.extend(place.projection);
941 place.projection = tcx.intern_place_elems(&projection);
943 // Create a temp to hold the promoted reference.
944 // This is because `*r` requires `r` to be a local,
945 // otherwise we would use the `promoted` directly.
946 let mut promoted_ref = LocalDecl::new_temp(ref_ty, span);
947 promoted_ref.source_info = statement.source_info;
948 let promoted_ref = local_decls.push(promoted_ref);
949 assert_eq!(self.temps.push(TempState::Unpromotable), promoted_ref);
951 let promoted_ref_statement = Statement {
952 source_info: statement.source_info,
953 kind: StatementKind::Assign(Box::new((
954 Place::from(promoted_ref),
955 Rvalue::Use(promoted_operand(ref_ty, span)),
958 self.extra_statements.push((loc, promoted_ref_statement));
961 tcx.lifetimes.re_erased,
964 local: mem::replace(&mut place.local, promoted_ref),
965 projection: List::empty(),
972 Candidate::Repeat(loc) => {
973 let ref mut statement = blocks[loc.block].statements[loc.statement_index];
974 match statement.kind {
975 StatementKind::Assign(box (_, Rvalue::Repeat(ref mut operand, _))) => {
976 let ty = operand.ty(local_decls, self.tcx);
977 let span = statement.source_info.span;
979 Rvalue::Use(mem::replace(operand, promoted_operand(ty, span)))
984 Candidate::Argument { bb, index } => {
985 let terminator = blocks[bb].terminator_mut();
986 match terminator.kind {
987 TerminatorKind::Call { ref mut args, .. } => {
988 let ty = args[index].ty(local_decls, self.tcx);
989 let span = terminator.source_info.span;
991 Rvalue::Use(mem::replace(&mut args[index], promoted_operand(ty, span)))
993 // We expected a `TerminatorKind::Call` for which we'd like to promote an
994 // argument. `qualify_consts` saw a `TerminatorKind::Call` here, but
995 // we are seeing a `Goto`. That means that the `promote_temps` method
996 // already promoted this call away entirely. This case occurs when calling
997 // a function requiring a constant argument and as that constant value
998 // providing a value whose computation contains another call to a function
999 // requiring a constant argument.
1000 TerminatorKind::Goto { .. } => return None,
1007 assert_eq!(self.new_block(), START_BLOCK);
1010 Location { block: BasicBlock::new(0), statement_index: usize::MAX },
1013 let span = self.promoted.span;
1014 self.assign(RETURN_PLACE, rvalue, span);
1019 /// Replaces all temporaries with their promoted counterparts.
1020 impl<'a, 'tcx> MutVisitor<'tcx> for Promoter<'a, 'tcx> {
1021 fn tcx(&self) -> TyCtxt<'tcx> {
1025 fn visit_local(&mut self, local: &mut Local, _: PlaceContext, _: Location) {
1026 if self.is_temp_kind(*local) {
1027 *local = self.promote_temp(*local);
1031 fn process_projection_elem(&mut self, elem: &PlaceElem<'tcx>) -> Option<PlaceElem<'tcx>> {
1033 PlaceElem::Index(local) if self.is_temp_kind(*local) => {
1034 Some(PlaceElem::Index(self.promote_temp(*local)))
1041 pub fn promote_candidates<'tcx>(
1043 body: &mut BodyAndCache<'tcx>,
1045 mut temps: IndexVec<Local, TempState>,
1046 candidates: Vec<Candidate>,
1047 ) -> IndexVec<Promoted, BodyAndCache<'tcx>> {
1048 // Visit candidates in reverse, in case they're nested.
1049 debug!("promote_candidates({:?})", candidates);
1051 let mut promotions = IndexVec::new();
1053 let mut extra_statements = vec![];
1054 for candidate in candidates.into_iter().rev() {
1056 Candidate::Repeat(Location { block, statement_index })
1057 | Candidate::Ref(Location { block, statement_index }) => {
1058 match &body[block].statements[statement_index].kind {
1059 StatementKind::Assign(box (place, _)) => {
1060 if let Some(local) = place.as_local() {
1061 if temps[local] == TempState::PromotedOut {
1062 // Already promoted.
1070 Candidate::Argument { .. } => {}
1073 // Declare return place local so that `mir::Body::new` doesn't complain.
1074 let initial_locals =
1075 iter::once(LocalDecl::new_return_place(tcx.types.never, body.span)).collect();
1077 let mut promoted = Body::new(
1079 // FIXME: maybe try to filter this to avoid blowing up
1081 body.source_scopes.clone(),
1088 body.generator_kind,
1090 promoted.ignore_interior_mut_in_const_validation = true;
1092 let promoter = Promoter {
1093 promoted: BodyAndCache::new(promoted),
1097 extra_statements: &mut extra_statements,
1098 keep_original: false,
1101 //FIXME(oli-obk): having a `maybe_push()` method on `IndexVec` might be nice
1102 if let Some(promoted) = promoter.promote_candidate(def_id, candidate, promotions.len()) {
1103 promotions.push(promoted);
1107 // Insert each of `extra_statements` before its indicated location, which
1108 // has to be done in reverse location order, to not invalidate the rest.
1109 extra_statements.sort_by_key(|&(loc, _)| cmp::Reverse(loc));
1110 for (loc, statement) in extra_statements {
1111 body[loc.block].statements.insert(loc.statement_index, statement);
1114 // Eliminate assignments to, and drops of promoted temps.
1115 let promoted = |index: Local| temps[index] == TempState::PromotedOut;
1116 for block in body.basic_blocks_mut() {
1117 block.statements.retain(|statement| match &statement.kind {
1118 StatementKind::Assign(box (place, _)) => {
1119 if let Some(index) = place.as_local() {
1125 StatementKind::StorageLive(index) | StatementKind::StorageDead(index) => {
1130 let terminator = block.terminator_mut();
1131 match &terminator.kind {
1132 TerminatorKind::Drop { location: place, target, .. } => {
1133 if let Some(index) = place.as_local() {
1134 if promoted(index) {
1135 terminator.kind = TerminatorKind::Goto { target: *target };
1146 /// This function returns `true` if the `const_in_array_repeat_expressions` feature attribute should
1147 /// be suggested. This function is probably quite expensive, it shouldn't be run in the happy path.
1148 /// Feature attribute should be suggested if `operand` can be promoted and the feature is not
1150 crate fn should_suggest_const_in_array_repeat_expressions_attribute<'tcx>(
1153 body: ReadOnlyBodyAndCache<'_, 'tcx>,
1154 operand: &Operand<'tcx>,
1156 let mut rpo = traversal::reverse_postorder(&body);
1157 let (temps, _) = collect_temps_and_candidates(tcx, &body, &mut rpo);
1159 Validator { item: Item::new(tcx, mir_def_id, body), temps: &temps, explicit: false };
1161 let should_promote = validator.validate_operand(operand).is_ok();
1162 let feature_flag = tcx.features().const_in_array_repeat_expressions;
1164 "should_suggest_const_in_array_repeat_expressions_flag: mir_def_id={:?} \
1165 should_promote={:?} feature_flag={:?}",
1166 mir_def_id, should_promote, feature_flag
1168 should_promote && !feature_flag