1 // Copyright 2017 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 use rustc_data_structures::fx::FxHashSet;
12 use rustc_data_structures::indexed_vec::IndexVec;
13 use rustc_data_structures::sync::Lrc;
15 use rustc::ty::query::Providers;
16 use rustc::ty::{self, TyCtxt};
19 use rustc::hir::def_id::DefId;
20 use rustc::lint::builtin::{SAFE_EXTERN_STATICS, SAFE_PACKED_BORROWS, UNUSED_UNSAFE};
22 use rustc::mir::visit::{PlaceContext, Visitor, MutatingUseContext};
25 use syntax::symbol::Symbol;
31 pub struct UnsafetyChecker<'a, 'tcx: 'a> {
34 source_scope_local_data: &'a IndexVec<SourceScope, SourceScopeLocalData>,
35 violations: Vec<UnsafetyViolation>,
36 source_info: SourceInfo,
37 tcx: TyCtxt<'a, 'tcx, 'tcx>,
38 param_env: ty::ParamEnv<'tcx>,
39 /// mark an `unsafe` block as used, so we don't lint it
40 used_unsafe: FxHashSet<ast::NodeId>,
41 inherited_blocks: Vec<(ast::NodeId, bool)>,
44 impl<'a, 'gcx, 'tcx> UnsafetyChecker<'a, 'tcx> {
48 source_scope_local_data: &'a IndexVec<SourceScope, SourceScopeLocalData>,
49 tcx: TyCtxt<'a, 'tcx, 'tcx>,
50 param_env: ty::ParamEnv<'tcx>,
55 source_scope_local_data,
57 source_info: SourceInfo {
59 scope: OUTERMOST_SOURCE_SCOPE
63 used_unsafe: Default::default(),
64 inherited_blocks: vec![],
69 impl<'a, 'tcx> Visitor<'tcx> for UnsafetyChecker<'a, 'tcx> {
70 fn visit_terminator(&mut self,
72 terminator: &Terminator<'tcx>,
75 self.source_info = terminator.source_info;
76 match terminator.kind {
77 TerminatorKind::Goto { .. } |
78 TerminatorKind::SwitchInt { .. } |
79 TerminatorKind::Drop { .. } |
80 TerminatorKind::Yield { .. } |
81 TerminatorKind::Assert { .. } |
82 TerminatorKind::DropAndReplace { .. } |
83 TerminatorKind::GeneratorDrop |
84 TerminatorKind::Resume |
85 TerminatorKind::Abort |
86 TerminatorKind::Return |
87 TerminatorKind::Unreachable |
88 TerminatorKind::FalseEdges { .. } |
89 TerminatorKind::FalseUnwind { .. } => {
90 // safe (at least as emitted during MIR construction)
93 TerminatorKind::Call { ref func, .. } => {
94 let func_ty = func.ty(self.mir, self.tcx);
95 let sig = func_ty.fn_sig(self.tcx);
96 if let hir::Unsafety::Unsafe = sig.unsafety() {
97 self.require_unsafe("call to unsafe function",
98 "consult the function's documentation for information on how to avoid \
99 undefined behavior", UnsafetyViolationKind::MinConstFn)
103 self.super_terminator(block, terminator, location);
106 fn visit_statement(&mut self,
108 statement: &Statement<'tcx>,
111 self.source_info = statement.source_info;
112 match statement.kind {
113 StatementKind::Assign(..) |
114 StatementKind::FakeRead(..) |
115 StatementKind::SetDiscriminant { .. } |
116 StatementKind::StorageLive(..) |
117 StatementKind::StorageDead(..) |
118 StatementKind::Retag { .. } |
119 StatementKind::EscapeToRaw { .. } |
120 StatementKind::AscribeUserType(..) |
121 StatementKind::Nop => {
122 // safe (at least as emitted during MIR construction)
125 StatementKind::InlineAsm { .. } => {
126 self.require_unsafe("use of inline assembly",
127 "inline assembly is entirely unchecked and can cause undefined behavior",
128 UnsafetyViolationKind::General)
131 self.super_statement(block, statement, location);
134 fn visit_rvalue(&mut self,
135 rvalue: &Rvalue<'tcx>,
138 if let &Rvalue::Aggregate(box ref aggregate, _) = rvalue {
140 &AggregateKind::Array(..) |
141 &AggregateKind::Tuple => {}
142 &AggregateKind::Adt(ref def, ..) => {
143 match self.tcx.layout_scalar_valid_range(def.did) {
144 (Bound::Unbounded, Bound::Unbounded) => {},
145 _ => self.require_unsafe(
146 "initializing type with `rustc_layout_scalar_valid_range` attr",
147 "initializing a layout restricted type's field with a value outside \
148 the valid range is undefined behavior",
149 UnsafetyViolationKind::MinConstFn,
153 &AggregateKind::Closure(def_id, _) |
154 &AggregateKind::Generator(def_id, _, _) => {
155 let UnsafetyCheckResult {
156 violations, unsafe_blocks
157 } = self.tcx.unsafety_check_result(def_id);
158 self.register_violations(&violations, &unsafe_blocks);
162 self.super_rvalue(rvalue, location);
165 fn visit_place(&mut self,
167 context: PlaceContext<'tcx>,
168 location: Location) {
170 &Place::Projection(box Projection {
173 if context.is_borrow() {
174 if util::is_disaligned(self.tcx, self.mir, self.param_env, place) {
175 let source_info = self.source_info;
177 self.source_scope_local_data[source_info.scope].lint_root;
178 self.register_violations(&[UnsafetyViolation {
180 description: Symbol::intern("borrow of packed field").as_interned_str(),
182 Symbol::intern("fields of packed structs might be misaligned: \
183 dereferencing a misaligned pointer or even just \
184 creating a misaligned reference is undefined \
187 kind: UnsafetyViolationKind::BorrowPacked(lint_root)
191 .ty(self.mir, self.tcx)
193 .is_freeze(self.tcx, self.param_env, self.source_info.span);
194 if context.is_mutating_use() || !is_freeze {
195 self.check_mut_borrowing_layout_constrained_field(place);
198 let old_source_info = self.source_info;
199 if let &Place::Local(local) = base {
200 if self.mir.local_decls[local].internal {
201 // Internal locals are used in the `move_val_init` desugaring.
202 // We want to check unsafety against the source info of the
203 // desugaring, rather than the source info of the RHS.
204 self.source_info = self.mir.local_decls[local].source_info;
207 let base_ty = base.ty(self.mir, self.tcx).to_ty(self.tcx);
210 self.require_unsafe("dereference of raw pointer",
211 "raw pointers may be NULL, dangling or unaligned; they can violate \
212 aliasing rules and cause data races: all of these are undefined \
213 behavior", UnsafetyViolationKind::General)
217 if context == PlaceContext::MutatingUse(MutatingUseContext::Store) ||
218 context == PlaceContext::MutatingUse(MutatingUseContext::Drop) ||
219 context == PlaceContext::MutatingUse(
220 MutatingUseContext::AsmOutput
223 let elem_ty = match elem {
224 &ProjectionElem::Field(_, ty) => ty,
226 self.source_info.span,
227 "non-field projection {:?} from union?",
230 if elem_ty.moves_by_default(self.tcx, self.param_env,
231 self.source_info.span) {
233 "assignment to non-`Copy` union field",
234 "the previous content of the field will be dropped, which \
235 causes undefined behavior if the field was not properly \
236 initialized", UnsafetyViolationKind::General)
238 // write to non-move union, safe
241 self.require_unsafe("access to union field",
242 "the field may not be properly initialized: using \
243 uninitialized data will cause undefined behavior",
244 UnsafetyViolationKind::General)
250 self.source_info = old_source_info;
252 &Place::Local(..) => {
255 &Place::Promoted(_) => {
256 bug!("unsafety checking should happen before promotion")
258 &Place::Static(box Static { def_id, ty: _ }) => {
259 if self.tcx.is_static(def_id) == Some(hir::Mutability::MutMutable) {
260 self.require_unsafe("use of mutable static",
261 "mutable statics can be mutated by multiple threads: aliasing violations \
262 or data races will cause undefined behavior",
263 UnsafetyViolationKind::General);
264 } else if self.tcx.is_foreign_item(def_id) {
265 let source_info = self.source_info;
267 self.source_scope_local_data[source_info.scope].lint_root;
268 self.register_violations(&[UnsafetyViolation {
270 description: Symbol::intern("use of extern static").as_interned_str(),
272 Symbol::intern("extern statics are not controlled by the Rust type \
273 system: invalid data, aliasing violations or data \
274 races will cause undefined behavior")
276 kind: UnsafetyViolationKind::ExternStatic(lint_root)
281 self.super_place(place, context, location);
285 impl<'a, 'tcx> UnsafetyChecker<'a, 'tcx> {
288 description: &'static str,
289 details: &'static str,
290 kind: UnsafetyViolationKind,
292 let source_info = self.source_info;
293 self.register_violations(&[UnsafetyViolation {
295 description: Symbol::intern(description).as_interned_str(),
296 details: Symbol::intern(details).as_interned_str(),
301 fn register_violations(&mut self,
302 violations: &[UnsafetyViolation],
303 unsafe_blocks: &[(ast::NodeId, bool)]) {
304 let safety = self.source_scope_local_data[self.source_info.scope].safety;
305 let within_unsafe = match (safety, self.min_const_fn) {
306 // Erring on the safe side, pun intended
307 (Safety::BuiltinUnsafe, true) |
308 // mir building encodes const fn bodies as safe, even for `const unsafe fn`
309 (Safety::FnUnsafe, true) => bug!("const unsafe fn body treated as inherently unsafe"),
310 // `unsafe` blocks are required in safe code
311 (Safety::Safe, _) => {
312 for violation in violations {
313 let mut violation = violation.clone();
314 if self.min_const_fn {
315 // overwrite unsafety violation in const fn with a single hard error kind
316 violation.kind = UnsafetyViolationKind::MinConstFn;
317 } else if let UnsafetyViolationKind::MinConstFn = violation.kind {
318 // outside of const fns we treat `MinConstFn` and `General` the same
319 violation.kind = UnsafetyViolationKind::General;
321 if !self.violations.contains(&violation) {
322 self.violations.push(violation)
327 // regular `unsafe` function bodies allow unsafe without additional unsafe blocks
328 (Safety::BuiltinUnsafe, false) | (Safety::FnUnsafe, false) => true,
329 (Safety::ExplicitUnsafe(node_id), _) => {
330 // mark unsafe block as used if there are any unsafe operations inside
331 if !violations.is_empty() {
332 self.used_unsafe.insert(node_id);
334 // only some unsafety is allowed in const fn
335 if self.min_const_fn {
336 for violation in violations {
337 match violation.kind {
339 UnsafetyViolationKind::MinConstFn
340 // if `#![feature(min_const_unsafe_fn)]` is active
341 if self.tcx.sess.features_untracked().min_const_unsafe_fn => {},
343 let mut violation = violation.clone();
344 // overwrite unsafety violation in const fn with a hard error
345 violation.kind = UnsafetyViolationKind::MinConstFn;
346 if !self.violations.contains(&violation) {
347 self.violations.push(violation)
356 self.inherited_blocks.extend(unsafe_blocks.iter().map(|&(node_id, is_used)| {
357 (node_id, is_used && !within_unsafe)
360 fn check_mut_borrowing_layout_constrained_field(
362 mut place: &Place<'tcx>,
364 while let &Place::Projection(box Projection {
368 ProjectionElem::Field(..) => {
369 let ty = base.ty(&self.mir.local_decls, self.tcx).to_ty(self.tcx);
371 ty::Adt(def, _) => match self.tcx.layout_scalar_valid_range(def.did) {
372 (Bound::Unbounded, Bound::Unbounded) => {},
374 let source_info = self.source_info;
375 self.register_violations(&[UnsafetyViolation {
377 description: Symbol::intern(
378 "borrow of layout constrained field",
382 "references to fields of layout constrained fields \
383 lose the constraints",
385 kind: UnsafetyViolationKind::MinConstFn,
399 pub(crate) fn provide(providers: &mut Providers) {
400 *providers = Providers {
401 unsafety_check_result,
402 unsafe_derive_on_repr_packed,
407 struct UnusedUnsafeVisitor<'a> {
408 used_unsafe: &'a FxHashSet<ast::NodeId>,
409 unsafe_blocks: &'a mut Vec<(ast::NodeId, bool)>,
412 impl<'a, 'tcx> hir::intravisit::Visitor<'tcx> for UnusedUnsafeVisitor<'a> {
413 fn nested_visit_map<'this>(&'this mut self) ->
414 hir::intravisit::NestedVisitorMap<'this, 'tcx>
416 hir::intravisit::NestedVisitorMap::None
419 fn visit_block(&mut self, block: &'tcx hir::Block) {
420 hir::intravisit::walk_block(self, block);
422 if let hir::UnsafeBlock(hir::UserProvided) = block.rules {
423 self.unsafe_blocks.push((block.id, self.used_unsafe.contains(&block.id)));
428 fn check_unused_unsafe<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
430 used_unsafe: &FxHashSet<ast::NodeId>,
431 unsafe_blocks: &'a mut Vec<(ast::NodeId, bool)>)
434 tcx.hir.as_local_node_id(def_id).and_then(|node_id| {
435 tcx.hir.maybe_body_owned_by(node_id)
438 let body_id = match body_id {
441 debug!("check_unused_unsafe({:?}) - no body found", def_id);
445 let body = tcx.hir.body(body_id);
446 debug!("check_unused_unsafe({:?}, body={:?}, used_unsafe={:?})",
447 def_id, body, used_unsafe);
449 let mut visitor = UnusedUnsafeVisitor { used_unsafe, unsafe_blocks };
450 hir::intravisit::Visitor::visit_body(&mut visitor, body);
453 fn unsafety_check_result<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId)
454 -> UnsafetyCheckResult
456 debug!("unsafety_violations({:?})", def_id);
458 // NB: this borrow is valid because all the consumers of
459 // `mir_built` force this.
460 let mir = &tcx.mir_built(def_id).borrow();
462 let source_scope_local_data = match mir.source_scope_local_data {
463 ClearCrossCrate::Set(ref data) => data,
464 ClearCrossCrate::Clear => {
465 debug!("unsafety_violations: {:?} - remote, skipping", def_id);
466 return UnsafetyCheckResult {
467 violations: Lrc::new([]),
468 unsafe_blocks: Lrc::new([])
473 let param_env = tcx.param_env(def_id);
474 let mut checker = UnsafetyChecker::new(
475 tcx.is_const_fn(def_id) && tcx.is_min_const_fn(def_id),
476 mir, source_scope_local_data, tcx, param_env);
477 checker.visit_mir(mir);
479 check_unused_unsafe(tcx, def_id, &checker.used_unsafe, &mut checker.inherited_blocks);
480 UnsafetyCheckResult {
481 violations: checker.violations.into(),
482 unsafe_blocks: checker.inherited_blocks.into()
486 fn unsafe_derive_on_repr_packed<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) {
487 let lint_node_id = match tcx.hir.as_local_node_id(def_id) {
488 Some(node_id) => node_id,
489 None => bug!("checking unsafety for non-local def id {:?}", def_id)
492 // FIXME: when we make this a hard error, this should have its
494 let message = if tcx.generics_of(def_id).own_counts().types != 0 {
495 "#[derive] can't be used on a #[repr(packed)] struct with \
496 type parameters (error E0133)".to_string()
498 "#[derive] can't be used on a #[repr(packed)] struct that \
499 does not derive Copy (error E0133)".to_string()
501 tcx.lint_node(SAFE_PACKED_BORROWS,
503 tcx.def_span(def_id),
507 /// Return the NodeId for an enclosing scope that is also `unsafe`
508 fn is_enclosed(tcx: TyCtxt,
509 used_unsafe: &FxHashSet<ast::NodeId>,
510 id: ast::NodeId) -> Option<(String, ast::NodeId)> {
511 let parent_id = tcx.hir.get_parent_node(id);
513 if used_unsafe.contains(&parent_id) {
514 Some(("block".to_string(), parent_id))
515 } else if let Some(Node::Item(&hir::Item {
516 node: hir::ItemKind::Fn(_, header, _, _),
518 })) = tcx.hir.find(parent_id) {
519 match header.unsafety {
520 hir::Unsafety::Unsafe => Some(("fn".to_string(), parent_id)),
521 hir::Unsafety::Normal => None,
524 is_enclosed(tcx, used_unsafe, parent_id)
531 fn report_unused_unsafe(tcx: TyCtxt, used_unsafe: &FxHashSet<ast::NodeId>, id: ast::NodeId) {
532 let span = tcx.sess.source_map().def_span(tcx.hir.span(id));
533 let msg = "unnecessary `unsafe` block";
534 let mut db = tcx.struct_span_lint_node(UNUSED_UNSAFE, id, span, msg);
535 db.span_label(span, msg);
536 if let Some((kind, id)) = is_enclosed(tcx, used_unsafe, id) {
537 db.span_label(tcx.sess.source_map().def_span(tcx.hir.span(id)),
538 format!("because it's nested under this `unsafe` {}", kind));
543 fn builtin_derive_def_id<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) -> Option<DefId> {
544 debug!("builtin_derive_def_id({:?})", def_id);
545 if let Some(impl_def_id) = tcx.impl_of_method(def_id) {
546 if tcx.has_attr(impl_def_id, "automatically_derived") {
547 debug!("builtin_derive_def_id({:?}) - is {:?}", def_id, impl_def_id);
550 debug!("builtin_derive_def_id({:?}) - not automatically derived", def_id);
554 debug!("builtin_derive_def_id({:?}) - not a method", def_id);
559 pub fn check_unsafety<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) {
560 debug!("check_unsafety({:?})", def_id);
562 // closures are handled by their parent fn.
563 if tcx.is_closure(def_id) {
567 let UnsafetyCheckResult {
570 } = tcx.unsafety_check_result(def_id);
572 for &UnsafetyViolation {
573 source_info, description, details, kind
574 } in violations.iter() {
577 UnsafetyViolationKind::General => {
579 tcx.sess, source_info.span, E0133,
580 "{} is unsafe and requires unsafe function or block", description)
581 .span_label(source_info.span, &description.as_str()[..])
582 .note(&details.as_str()[..])
585 UnsafetyViolationKind::MinConstFn => {
586 tcx.sess.struct_span_err(
588 &format!("{} is unsafe and unsafe operations \
589 are not allowed in const fn", description))
590 .span_label(source_info.span, &description.as_str()[..])
591 .note(&details.as_str()[..])
594 UnsafetyViolationKind::ExternStatic(lint_node_id) => {
595 tcx.lint_node_note(SAFE_EXTERN_STATICS,
598 &format!("{} is unsafe and requires unsafe function or block \
599 (error E0133)", &description.as_str()[..]),
600 &details.as_str()[..]);
602 UnsafetyViolationKind::BorrowPacked(lint_node_id) => {
603 if let Some(impl_def_id) = builtin_derive_def_id(tcx, def_id) {
604 tcx.unsafe_derive_on_repr_packed(impl_def_id);
606 tcx.lint_node_note(SAFE_PACKED_BORROWS,
609 &format!("{} is unsafe and requires unsafe function or block \
610 (error E0133)", &description.as_str()[..]),
611 &details.as_str()[..]);
617 let mut unsafe_blocks: Vec<_> = unsafe_blocks.into_iter().collect();
618 unsafe_blocks.sort();
619 let used_unsafe: FxHashSet<_> = unsafe_blocks.iter()
620 .flat_map(|&&(id, used)| if used { Some(id) } else { None })
622 for &(block_id, is_used) in unsafe_blocks {
624 report_unused_unsafe(tcx, &used_unsafe, block_id);