1 use rustc::hir::map::Map;
2 use rustc::lint::builtin::{SAFE_PACKED_BORROWS, UNUSED_UNSAFE};
3 use rustc::mir::visit::{MutatingUseContext, PlaceContext, Visitor};
5 use rustc::ty::cast::CastTy;
6 use rustc::ty::query::Providers;
7 use rustc::ty::{self, TyCtxt};
8 use rustc_data_structures::fx::FxHashSet;
9 use rustc_errors::struct_span_err;
11 use rustc_hir::def_id::DefId;
12 use rustc_hir::intravisit;
14 use rustc_span::symbol::{sym, Symbol};
18 use crate::const_eval::{is_const_fn, is_min_const_fn};
21 use rustc_error_codes::*;
23 pub struct UnsafetyChecker<'a, 'tcx> {
27 violations: Vec<UnsafetyViolation>,
28 source_info: SourceInfo,
30 param_env: ty::ParamEnv<'tcx>,
31 /// Mark an `unsafe` block as used, so we don't lint it.
32 used_unsafe: FxHashSet<hir::HirId>,
33 inherited_blocks: Vec<(hir::HirId, bool)>,
36 impl<'a, 'tcx> UnsafetyChecker<'a, 'tcx> {
42 param_env: ty::ParamEnv<'tcx>,
46 assert!(const_context);
53 source_info: SourceInfo { span: body.span, scope: OUTERMOST_SOURCE_SCOPE },
56 used_unsafe: Default::default(),
57 inherited_blocks: vec![],
62 impl<'a, 'tcx> Visitor<'tcx> for UnsafetyChecker<'a, 'tcx> {
63 fn visit_terminator(&mut self, terminator: &Terminator<'tcx>, location: Location) {
64 self.source_info = terminator.source_info;
65 match terminator.kind {
66 TerminatorKind::Goto { .. }
67 | TerminatorKind::SwitchInt { .. }
68 | TerminatorKind::Drop { .. }
69 | TerminatorKind::Yield { .. }
70 | TerminatorKind::Assert { .. }
71 | TerminatorKind::DropAndReplace { .. }
72 | TerminatorKind::GeneratorDrop
73 | TerminatorKind::Resume
74 | TerminatorKind::Abort
75 | TerminatorKind::Return
76 | TerminatorKind::Unreachable
77 | TerminatorKind::FalseEdges { .. }
78 | TerminatorKind::FalseUnwind { .. } => {
79 // safe (at least as emitted during MIR construction)
82 TerminatorKind::Call { ref func, .. } => {
83 let func_ty = func.ty(self.body, self.tcx);
84 let sig = func_ty.fn_sig(self.tcx);
85 if let hir::Unsafety::Unsafe = sig.unsafety() {
87 "call to unsafe function",
88 "consult the function's documentation for information on how to avoid \
90 UnsafetyViolationKind::GeneralAndConstFn,
95 self.super_terminator(terminator, location);
98 fn visit_statement(&mut self, statement: &Statement<'tcx>, location: Location) {
99 self.source_info = statement.source_info;
100 match statement.kind {
101 StatementKind::Assign(..)
102 | StatementKind::FakeRead(..)
103 | StatementKind::SetDiscriminant { .. }
104 | StatementKind::StorageLive(..)
105 | StatementKind::StorageDead(..)
106 | StatementKind::Retag { .. }
107 | StatementKind::AscribeUserType(..)
108 | StatementKind::Nop => {
109 // safe (at least as emitted during MIR construction)
112 StatementKind::InlineAsm { .. } => self.require_unsafe(
113 "use of inline assembly",
114 "inline assembly is entirely unchecked and can cause undefined behavior",
115 UnsafetyViolationKind::General,
118 self.super_statement(statement, location);
121 fn visit_rvalue(&mut self, rvalue: &Rvalue<'tcx>, location: Location) {
123 Rvalue::Aggregate(box ref aggregate, _) => match aggregate {
124 &AggregateKind::Array(..) | &AggregateKind::Tuple => {}
125 &AggregateKind::Adt(ref def, ..) => {
126 match self.tcx.layout_scalar_valid_range(def.did) {
127 (Bound::Unbounded, Bound::Unbounded) => {}
128 _ => self.require_unsafe(
129 "initializing type with `rustc_layout_scalar_valid_range` attr",
130 "initializing a layout restricted type's field with a value \
131 outside the valid range is undefined behavior",
132 UnsafetyViolationKind::GeneralAndConstFn,
136 &AggregateKind::Closure(def_id, _) | &AggregateKind::Generator(def_id, _, _) => {
137 let UnsafetyCheckResult { violations, unsafe_blocks } =
138 self.tcx.unsafety_check_result(def_id);
139 self.register_violations(&violations, &unsafe_blocks);
142 // casting pointers to ints is unsafe in const fn because the const evaluator cannot
143 // possibly know what the result of various operations like `address / 2` would be
144 // pointers during const evaluation have no integral address, only an abstract one
145 Rvalue::Cast(CastKind::Misc, ref operand, cast_ty)
146 if self.const_context && self.tcx.features().const_raw_ptr_to_usize_cast =>
148 let operand_ty = operand.ty(self.body, self.tcx);
149 let cast_in = CastTy::from_ty(operand_ty).expect("bad input type for cast");
150 let cast_out = CastTy::from_ty(cast_ty).expect("bad output type for cast");
151 match (cast_in, cast_out) {
152 (CastTy::Ptr(_), CastTy::Int(_)) | (CastTy::FnPtr, CastTy::Int(_)) => {
153 self.register_violations(
154 &[UnsafetyViolation {
155 source_info: self.source_info,
156 description: Symbol::intern("cast of pointer to int"),
157 details: Symbol::intern(
158 "casting pointers to integers in constants",
160 kind: UnsafetyViolationKind::General,
168 // raw pointer and fn pointer operations are unsafe as it is not clear whether one
169 // pointer would be "less" or "equal" to another, because we cannot know where llvm
170 // or the linker will place various statics in memory. Without this information the
171 // result of a comparison of addresses would differ between runtime and compile-time.
172 Rvalue::BinaryOp(_, ref lhs, _)
173 if self.const_context && self.tcx.features().const_compare_raw_pointers =>
175 if let ty::RawPtr(_) | ty::FnPtr(..) = lhs.ty(self.body, self.tcx).kind {
176 self.register_violations(
177 &[UnsafetyViolation {
178 source_info: self.source_info,
179 description: Symbol::intern("pointer operation"),
180 details: Symbol::intern("operations on pointers in constants"),
181 kind: UnsafetyViolationKind::General,
189 self.super_rvalue(rvalue, location);
192 fn visit_place(&mut self, place: &Place<'tcx>, context: PlaceContext, _location: Location) {
194 PlaceBase::Local(..) => {
199 for (i, elem) in place.projection.iter().enumerate() {
200 let proj_base = &place.projection[..i];
202 if context.is_borrow() {
203 if util::is_disaligned(self.tcx, self.body, self.param_env, place) {
204 let source_info = self.source_info;
205 let lint_root = self.body.source_scopes[source_info.scope]
208 .assert_crate_local()
210 self.register_violations(
211 &[UnsafetyViolation {
213 description: Symbol::intern("borrow of packed field"),
214 details: Symbol::intern(
215 "fields of packed structs might be misaligned: dereferencing a \
216 misaligned pointer or even just creating a misaligned reference \
217 is undefined behavior",
219 kind: UnsafetyViolationKind::BorrowPacked(lint_root),
225 let is_borrow_of_interior_mut = context.is_borrow()
226 && !Place::ty_from(&place.base, proj_base, self.body, self.tcx).ty.is_freeze(
229 self.source_info.span,
234 // * `&x.field` if `field`'s type has interior mutability
235 // because either of these would allow modifying the layout constrained field and
236 // insert values that violate the layout constraints.
237 if context.is_mutating_use() || is_borrow_of_interior_mut {
238 self.check_mut_borrowing_layout_constrained_field(place, context.is_mutating_use());
240 let old_source_info = self.source_info;
241 if let (PlaceBase::Local(local), []) = (&place.base, proj_base) {
242 let decl = &self.body.local_decls[*local];
244 // Internal locals are used in the `move_val_init` desugaring.
245 // We want to check unsafety against the source info of the
246 // desugaring, rather than the source info of the RHS.
247 self.source_info = self.body.local_decls[*local].source_info;
248 } else if let LocalInfo::StaticRef { def_id, .. } = decl.local_info {
249 if self.tcx.is_mutable_static(def_id) {
251 "use of mutable static",
252 "mutable statics can be mutated by multiple threads: aliasing \
253 violations or data races will cause undefined behavior",
254 UnsafetyViolationKind::General,
257 } else if self.tcx.is_foreign_item(def_id) {
259 "use of extern static",
260 "extern statics are not controlled by the Rust type system: \
261 invalid data, aliasing violations or data races will cause \
263 UnsafetyViolationKind::General,
269 let base_ty = Place::ty_from(&place.base, proj_base, self.body, self.tcx).ty;
271 ty::RawPtr(..) => self.require_unsafe(
272 "dereference of raw pointer",
273 "raw pointers may be NULL, dangling or unaligned; they can violate \
274 aliasing rules and cause data races: all of these are undefined \
276 UnsafetyViolationKind::General,
280 if context == PlaceContext::MutatingUse(MutatingUseContext::Store)
281 || context == PlaceContext::MutatingUse(MutatingUseContext::Drop)
282 || context == PlaceContext::MutatingUse(MutatingUseContext::AsmOutput)
284 let elem_ty = match elem {
285 ProjectionElem::Field(_, ty) => ty,
287 self.source_info.span,
288 "non-field projection {:?} from union?",
292 if !elem_ty.is_copy_modulo_regions(
295 self.source_info.span,
298 "assignment to non-`Copy` union field",
299 "the previous content of the field will be dropped, which \
300 causes undefined behavior if the field was not properly \
302 UnsafetyViolationKind::GeneralAndConstFn,
305 // write to non-move union, safe
309 "access to union field",
310 "the field may not be properly initialized: using \
311 uninitialized data will cause undefined behavior",
312 UnsafetyViolationKind::GeneralAndConstFn,
319 self.source_info = old_source_info;
324 impl<'a, 'tcx> UnsafetyChecker<'a, 'tcx> {
327 description: &'static str,
328 details: &'static str,
329 kind: UnsafetyViolationKind,
331 let source_info = self.source_info;
332 self.register_violations(
333 &[UnsafetyViolation {
335 description: Symbol::intern(description),
336 details: Symbol::intern(details),
343 fn register_violations(
345 violations: &[UnsafetyViolation],
346 unsafe_blocks: &[(hir::HirId, bool)],
348 let safety = self.body.source_scopes[self.source_info.scope]
351 .assert_crate_local()
353 let within_unsafe = match safety {
354 // `unsafe` blocks are required in safe code
356 for violation in violations {
357 let mut violation = violation.clone();
358 match violation.kind {
359 UnsafetyViolationKind::GeneralAndConstFn
360 | UnsafetyViolationKind::General => {}
361 UnsafetyViolationKind::BorrowPacked(_) => {
362 if self.min_const_fn {
363 // const fns don't need to be backwards compatible and can
364 // emit these violations as a hard error instead of a backwards
366 violation.kind = UnsafetyViolationKind::General;
370 if !self.violations.contains(&violation) {
371 self.violations.push(violation)
376 // `unsafe` function bodies allow unsafe without additional unsafe blocks
377 Safety::BuiltinUnsafe | Safety::FnUnsafe => true,
378 Safety::ExplicitUnsafe(hir_id) => {
379 // mark unsafe block as used if there are any unsafe operations inside
380 if !violations.is_empty() {
381 self.used_unsafe.insert(hir_id);
383 // only some unsafety is allowed in const fn
384 if self.min_const_fn {
385 for violation in violations {
386 match violation.kind {
387 // these unsafe things are stable in const fn
388 UnsafetyViolationKind::GeneralAndConstFn => {}
389 // these things are forbidden in const fns
390 UnsafetyViolationKind::General
391 | UnsafetyViolationKind::BorrowPacked(_) => {
392 let mut violation = violation.clone();
393 // const fns don't need to be backwards compatible and can
394 // emit these violations as a hard error instead of a backwards
396 violation.kind = UnsafetyViolationKind::General;
397 if !self.violations.contains(&violation) {
398 self.violations.push(violation)
407 self.inherited_blocks.extend(
408 unsafe_blocks.iter().map(|&(hir_id, is_used)| (hir_id, is_used && !within_unsafe)),
411 fn check_mut_borrowing_layout_constrained_field(
416 let mut cursor = place.projection.as_ref();
417 while let &[ref proj_base @ .., elem] = cursor {
421 ProjectionElem::Field(..) => {
423 Place::ty_from(&place.base, proj_base, &self.body.local_decls, self.tcx).ty;
425 ty::Adt(def, _) => match self.tcx.layout_scalar_valid_range(def.did) {
426 (Bound::Unbounded, Bound::Unbounded) => {}
428 let (description, details) = if is_mut_use {
430 "mutation of layout constrained field",
431 "mutating layout constrained fields cannot statically be \
432 checked for valid values",
436 "borrow of layout constrained field with interior \
438 "references to fields of layout constrained fields \
439 lose the constraints. Coupled with interior mutability, \
440 the field can be changed to invalid values",
443 let source_info = self.source_info;
444 self.register_violations(
445 &[UnsafetyViolation {
447 description: Symbol::intern(description),
448 details: Symbol::intern(details),
449 kind: UnsafetyViolationKind::GeneralAndConstFn,
464 pub(crate) fn provide(providers: &mut Providers<'_>) {
465 *providers = Providers { unsafety_check_result, unsafe_derive_on_repr_packed, ..*providers };
468 struct UnusedUnsafeVisitor<'a> {
469 used_unsafe: &'a FxHashSet<hir::HirId>,
470 unsafe_blocks: &'a mut Vec<(hir::HirId, bool)>,
473 impl<'a, 'tcx> intravisit::Visitor<'tcx> for UnusedUnsafeVisitor<'a> {
474 type Map = Map<'tcx>;
476 fn nested_visit_map<'this>(&'this mut self) -> intravisit::NestedVisitorMap<'this, Self::Map> {
477 intravisit::NestedVisitorMap::None
480 fn visit_block(&mut self, block: &'tcx hir::Block<'tcx>) {
481 intravisit::walk_block(self, block);
483 if let hir::BlockCheckMode::UnsafeBlock(hir::UnsafeSource::UserProvided) = block.rules {
484 self.unsafe_blocks.push((block.hir_id, self.used_unsafe.contains(&block.hir_id)));
489 fn check_unused_unsafe(
492 used_unsafe: &FxHashSet<hir::HirId>,
493 unsafe_blocks: &mut Vec<(hir::HirId, bool)>,
496 tcx.hir().as_local_hir_id(def_id).and_then(|hir_id| tcx.hir().maybe_body_owned_by(hir_id));
498 let body_id = match body_id {
501 debug!("check_unused_unsafe({:?}) - no body found", def_id);
505 let body = tcx.hir().body(body_id);
506 debug!("check_unused_unsafe({:?}, body={:?}, used_unsafe={:?})", def_id, body, used_unsafe);
508 let mut visitor = UnusedUnsafeVisitor { used_unsafe, unsafe_blocks };
509 intravisit::Visitor::visit_body(&mut visitor, body);
512 fn unsafety_check_result(tcx: TyCtxt<'_>, def_id: DefId) -> UnsafetyCheckResult {
513 debug!("unsafety_violations({:?})", def_id);
515 // N.B., this borrow is valid because all the consumers of
516 // `mir_built` force this.
517 let body = &tcx.mir_built(def_id).borrow();
519 let param_env = tcx.param_env(def_id);
521 let id = tcx.hir().as_local_hir_id(def_id).unwrap();
522 let (const_context, min_const_fn) = match tcx.hir().body_owner_kind(id) {
523 hir::BodyOwnerKind::Closure => (false, false),
524 hir::BodyOwnerKind::Fn => (is_const_fn(tcx, def_id), is_min_const_fn(tcx, def_id)),
525 hir::BodyOwnerKind::Const | hir::BodyOwnerKind::Static(_) => (true, false),
527 let mut checker = UnsafetyChecker::new(const_context, min_const_fn, body, tcx, param_env);
528 // mir_built ensures that body has a computed cache, so we don't (and can't) attempt to
529 // recompute it here.
530 let body = body.unwrap_read_only();
531 checker.visit_body(body);
533 check_unused_unsafe(tcx, def_id, &checker.used_unsafe, &mut checker.inherited_blocks);
534 UnsafetyCheckResult {
535 violations: checker.violations.into(),
536 unsafe_blocks: checker.inherited_blocks.into(),
540 fn unsafe_derive_on_repr_packed(tcx: TyCtxt<'_>, def_id: DefId) {
541 let lint_hir_id = tcx
543 .as_local_hir_id(def_id)
544 .unwrap_or_else(|| bug!("checking unsafety for non-local def id {:?}", def_id));
546 // FIXME: when we make this a hard error, this should have its
548 let message = if tcx.generics_of(def_id).own_requires_monomorphization() {
549 "`#[derive]` can't be used on a `#[repr(packed)]` struct with \
550 type or const parameters (error E0133)"
553 "`#[derive]` can't be used on a `#[repr(packed)]` struct that \
554 does not derive Copy (error E0133)"
557 tcx.lint_hir(SAFE_PACKED_BORROWS, lint_hir_id, tcx.def_span(def_id), &message);
560 /// Returns the `HirId` for an enclosing scope that is also `unsafe`.
563 used_unsafe: &FxHashSet<hir::HirId>,
565 ) -> Option<(String, hir::HirId)> {
566 let parent_id = tcx.hir().get_parent_node(id);
568 if used_unsafe.contains(&parent_id) {
569 Some(("block".to_string(), parent_id))
570 } else if let Some(Node::Item(&hir::Item {
571 kind: hir::ItemKind::Fn(ref sig, _, _), ..
572 })) = tcx.hir().find(parent_id)
574 match sig.header.unsafety {
575 hir::Unsafety::Unsafe => Some(("fn".to_string(), parent_id)),
576 hir::Unsafety::Normal => None,
579 is_enclosed(tcx, used_unsafe, parent_id)
586 fn report_unused_unsafe(tcx: TyCtxt<'_>, used_unsafe: &FxHashSet<hir::HirId>, id: hir::HirId) {
587 let span = tcx.sess.source_map().def_span(tcx.hir().span(id));
588 let msg = "unnecessary `unsafe` block";
589 let mut db = tcx.struct_span_lint_hir(UNUSED_UNSAFE, id, span, msg);
590 db.span_label(span, msg);
591 if let Some((kind, id)) = is_enclosed(tcx, used_unsafe, id) {
593 tcx.sess.source_map().def_span(tcx.hir().span(id)),
594 format!("because it's nested under this `unsafe` {}", kind),
600 fn builtin_derive_def_id(tcx: TyCtxt<'_>, def_id: DefId) -> Option<DefId> {
601 debug!("builtin_derive_def_id({:?})", def_id);
602 if let Some(impl_def_id) = tcx.impl_of_method(def_id) {
603 if tcx.has_attr(impl_def_id, sym::automatically_derived) {
604 debug!("builtin_derive_def_id({:?}) - is {:?}", def_id, impl_def_id);
607 debug!("builtin_derive_def_id({:?}) - not automatically derived", def_id);
611 debug!("builtin_derive_def_id({:?}) - not a method", def_id);
616 pub fn check_unsafety(tcx: TyCtxt<'_>, def_id: DefId) {
617 debug!("check_unsafety({:?})", def_id);
619 // closures are handled by their parent fn.
620 if tcx.is_closure(def_id) {
624 let UnsafetyCheckResult { violations, unsafe_blocks } = tcx.unsafety_check_result(def_id);
626 for &UnsafetyViolation { source_info, description, details, kind } in violations.iter() {
629 UnsafetyViolationKind::GeneralAndConstFn | UnsafetyViolationKind::General => {
634 "{} is unsafe and requires unsafe function or block",
637 .span_label(source_info.span, &*description.as_str())
638 .note(&details.as_str())
641 UnsafetyViolationKind::BorrowPacked(lint_hir_id) => {
642 if let Some(impl_def_id) = builtin_derive_def_id(tcx, def_id) {
643 tcx.unsafe_derive_on_repr_packed(impl_def_id);
650 "{} is unsafe and requires unsafe function or block \
661 let mut unsafe_blocks: Vec<_> = unsafe_blocks.into_iter().collect();
662 unsafe_blocks.sort_by_cached_key(|(hir_id, _)| tcx.hir().hir_to_node_id(*hir_id));
663 let used_unsafe: FxHashSet<_> =
664 unsafe_blocks.iter().flat_map(|&&(id, used)| used.then_some(id)).collect();
665 for &(block_id, is_used) in unsafe_blocks {
667 report_unused_unsafe(tcx, &used_unsafe, block_id);