1 use crate::borrow_check::ArtificialField;
2 use crate::borrow_check::Overlap;
3 use crate::borrow_check::{Deep, Shallow, AccessDepth};
6 Body, BorrowKind, Place, PlaceBase, PlaceElem, PlaceRef, ProjectionElem, StaticKind,
8 use rustc::ty::{self, TyCtxt};
11 /// When checking if a place conflicts with another place, this enum is used to influence decisions
12 /// where a place might be equal or disjoint with another place, such as if `a[i] == a[j]`.
13 /// `PlaceConflictBias::Overlap` would bias toward assuming that `i` might equal `j` and that these
14 /// places overlap. `PlaceConflictBias::NoOverlap` assumes that for the purposes of the predicate
15 /// being run in the calling context, the conservative choice is to assume the compared indices
16 /// are disjoint (and therefore, do not overlap).
17 #[derive(Copy, Clone, Debug, Eq, PartialEq)]
18 crate enum PlaceConflictBias {
23 /// Helper function for checking if places conflict with a mutable borrow and deep access depth.
24 /// This is used to check for places conflicting outside of the borrow checking code (such as in
26 crate fn places_conflict<'tcx>(
28 param_env: ty::ParamEnv<'tcx>,
30 borrow_place: &Place<'tcx>,
31 access_place: &Place<'tcx>,
32 bias: PlaceConflictBias,
34 borrow_conflicts_with_place(
39 BorrowKind::Mut { allow_two_phase_borrow: true },
40 access_place.as_ref(),
46 /// Checks whether the `borrow_place` conflicts with the `access_place` given a borrow kind and
47 /// access depth. The `bias` parameter is used to determine how the unknowable (comparing runtime
48 /// array indices, for example) should be interpreted - this depends on what the caller wants in
49 /// order to make the conservative choice and preserve soundness.
50 pub(super) fn borrow_conflicts_with_place<'tcx>(
52 param_env: ty::ParamEnv<'tcx>,
54 borrow_place: &Place<'tcx>,
55 borrow_kind: BorrowKind,
56 access_place: PlaceRef<'_, 'tcx>,
58 bias: PlaceConflictBias,
61 "borrow_conflicts_with_place({:?}, {:?}, {:?}, {:?})",
62 borrow_place, access_place, access, bias,
65 // This Local/Local case is handled by the more general code below, but
66 // it's so common that it's a speed win to check for it first.
67 if let Some(l1) = borrow_place.as_local() {
68 if let Some(l2) = access_place.as_local() {
73 place_components_conflict(
85 fn place_components_conflict<'tcx>(
87 param_env: ty::ParamEnv<'tcx>,
89 borrow_place: &Place<'tcx>,
90 borrow_kind: BorrowKind,
91 access_place: PlaceRef<'_, 'tcx>,
93 bias: PlaceConflictBias,
95 // The borrowck rules for proving disjointness are applied from the "root" of the
96 // borrow forwards, iterating over "similar" projections in lockstep until
97 // we can prove overlap one way or another. Essentially, we treat `Overlap` as
98 // a monoid and report a conflict if the product ends up not being `Disjoint`.
100 // At each step, if we didn't run out of borrow or place, we know that our elements
101 // have the same type, and that they only overlap if they are the identical.
103 // For example, if we are comparing these:
104 // BORROW: (*x1[2].y).z.a
105 // ACCESS: (*x1[i].y).w.b
107 // Then our steps are:
108 // x1 | x1 -- places are the same
109 // x1[2] | x1[i] -- equal or disjoint (disjoint if indexes differ)
110 // x1[2].y | x1[i].y -- equal or disjoint
111 // *x1[2].y | *x1[i].y -- equal or disjoint
112 // (*x1[2].y).z | (*x1[i].y).w -- we are disjoint and don't need to check more!
114 // Because `zip` does potentially bad things to the iterator inside, this loop
115 // also handles the case where the access might be a *prefix* of the borrow, e.g.
117 // BORROW: (*x1[2].y).z.a
120 // Then our steps are:
121 // x1 | x1 -- places are the same
122 // x1[2] | x1[i] -- equal or disjoint (disjoint if indexes differ)
123 // x1[2].y | x1[i].y -- equal or disjoint
125 // -- here we run out of access - the borrow can access a part of it. If this
126 // is a full deep access, then we *know* the borrow conflicts with it. However,
127 // if the access is shallow, then we can proceed:
129 // x1[2].y | (*x1[i].y) -- a deref! the access can't get past this, so we
132 // Our invariant is, that at each step of the iteration:
133 // - If we didn't run out of access to match, our borrow and access are comparable
134 // and either equal or disjoint.
135 // - If we did run out of access, the borrow can access a part of it.
137 let borrow_base = &borrow_place.base;
138 let access_base = access_place.base;
140 match place_base_conflict(tcx, param_env, borrow_base, access_base) {
141 Overlap::Arbitrary => {
142 bug!("Two base can't return Arbitrary");
144 Overlap::EqualOrDisjoint => {
145 // This is the recursive case - proceed to the next element.
147 Overlap::Disjoint => {
148 // We have proven the borrow disjoint - further
149 // projections will remain disjoint.
150 debug!("borrow_conflicts_with_place: disjoint");
155 // loop invariant: borrow_c is always either equal to access_c or disjoint from it.
156 for (i, (borrow_c, access_c)) in
157 borrow_place.projection.iter().zip(access_place.projection.iter()).enumerate()
159 debug!("borrow_conflicts_with_place: borrow_c = {:?}", borrow_c);
160 let borrow_proj_base = &borrow_place.projection[..i];
162 debug!("borrow_conflicts_with_place: access_c = {:?}", access_c);
164 // Borrow and access path both have more components.
168 // - borrow of `a.(...)`, access to `a.(...)`
169 // - borrow of `a.(...)`, access to `b.(...)`
171 // Here we only see the components we have checked so
172 // far (in our examples, just the first component). We
173 // check whether the components being borrowed vs
174 // accessed are disjoint (as in the second example,
175 // but not the first).
176 match place_projection_conflict(
185 Overlap::Arbitrary => {
186 // We have encountered different fields of potentially
187 // the same union - the borrow now partially overlaps.
189 // There is no *easy* way of comparing the fields
190 // further on, because they might have different types
191 // (e.g., borrows of `u.a.0` and `u.b.y` where `.0` and
192 // `.y` come from different structs).
194 // We could try to do some things here - e.g., count
195 // dereferences - but that's probably not a good
196 // idea, at least for now, so just give up and
197 // report a conflict. This is unsafe code anyway so
198 // the user could always use raw pointers.
199 debug!("borrow_conflicts_with_place: arbitrary -> conflict");
202 Overlap::EqualOrDisjoint => {
203 // This is the recursive case - proceed to the next element.
205 Overlap::Disjoint => {
206 // We have proven the borrow disjoint - further
207 // projections will remain disjoint.
208 debug!("borrow_conflicts_with_place: disjoint");
214 if borrow_place.projection.len() > access_place.projection.len() {
215 for (i, elem) in borrow_place.projection[access_place.projection.len()..].iter().enumerate()
217 // Borrow path is longer than the access path. Examples:
219 // - borrow of `a.b.c`, access to `a.b`
221 // Here, we know that the borrow can access a part of
222 // our place. This is a conflict if that is a part our
223 // access cares about.
225 let proj_base = &borrow_place.projection[..access_place.projection.len() + i];
226 let base_ty = Place::ty_from(borrow_base, proj_base, body, tcx).ty;
228 match (elem, &base_ty.kind, access) {
229 (_, _, Shallow(Some(ArtificialField::ArrayLength)))
230 | (_, _, Shallow(Some(ArtificialField::ShallowBorrow))) => {
231 // The array length is like additional fields on the
232 // type; it does not overlap any existing data there.
233 // Furthermore, if cannot actually be a prefix of any
234 // borrowed place (at least in MIR as it is currently.)
236 // e.g., a (mutable) borrow of `a[5]` while we read the
237 // array length of `a`.
238 debug!("borrow_conflicts_with_place: implicit field");
242 (ProjectionElem::Deref, _, Shallow(None)) => {
243 // e.g., a borrow of `*x.y` while we shallowly access `x.y` or some
244 // prefix thereof - the shallow access can't touch anything behind
246 debug!("borrow_conflicts_with_place: shallow access behind ptr");
249 (ProjectionElem::Deref, ty::Ref(_, _, hir::Mutability::Not), _) => {
250 // Shouldn't be tracked
251 bug!("Tracking borrow behind shared reference.");
253 (ProjectionElem::Deref, ty::Ref(_, _, hir::Mutability::Mut), AccessDepth::Drop) => {
254 // Values behind a mutable reference are not access either by dropping a
255 // value, or by StorageDead
256 debug!("borrow_conflicts_with_place: drop access behind ptr");
260 (ProjectionElem::Field { .. }, ty::Adt(def, _), AccessDepth::Drop) => {
261 // Drop can read/write arbitrary projections, so places
262 // conflict regardless of further projections.
263 if def.has_dtor(tcx) {
268 (ProjectionElem::Deref, _, Deep)
269 | (ProjectionElem::Deref, _, AccessDepth::Drop)
270 | (ProjectionElem::Field { .. }, _, _)
271 | (ProjectionElem::Index { .. }, _, _)
272 | (ProjectionElem::ConstantIndex { .. }, _, _)
273 | (ProjectionElem::Subslice { .. }, _, _)
274 | (ProjectionElem::Downcast { .. }, _, _) => {
275 // Recursive case. This can still be disjoint on a
276 // further iteration if this a shallow access and
277 // there's a deref later on, e.g., a borrow
278 // of `*x.y` while accessing `x`.
284 // Borrow path ran out but access path may not
287 // - borrow of `a.b`, access to `a.b.c`
288 // - borrow of `a.b`, access to `a.b`
290 // In the first example, where we didn't run out of
291 // access, the borrow can access all of our place, so we
294 // If the second example, where we did, then we still know
295 // that the borrow can access a *part* of our place that
296 // our access cares about, so we still have a conflict.
297 if borrow_kind == BorrowKind::Shallow
298 && borrow_place.projection.len() < access_place.projection.len()
300 debug!("borrow_conflicts_with_place: shallow borrow");
303 debug!("borrow_conflicts_with_place: full borrow, CONFLICT");
308 // Given that the bases of `elem1` and `elem2` are always either equal
309 // or disjoint (and have the same type!), return the overlap situation
310 // between `elem1` and `elem2`.
311 fn place_base_conflict<'tcx>(
313 param_env: ty::ParamEnv<'tcx>,
314 elem1: &PlaceBase<'tcx>,
315 elem2: &PlaceBase<'tcx>,
317 match (elem1, elem2) {
318 (PlaceBase::Local(l1), PlaceBase::Local(l2)) => {
320 // the same local - base case, equal
321 debug!("place_element_conflict: DISJOINT-OR-EQ-LOCAL");
322 Overlap::EqualOrDisjoint
324 // different locals - base case, disjoint
325 debug!("place_element_conflict: DISJOINT-LOCAL");
329 (PlaceBase::Static(s1), PlaceBase::Static(s2)) => {
330 match (&s1.kind, &s2.kind) {
331 (StaticKind::Static, StaticKind::Static) => {
332 if s1.def_id != s2.def_id {
333 debug!("place_element_conflict: DISJOINT-STATIC");
335 } else if tcx.is_mutable_static(s1.def_id) {
336 // We ignore mutable statics - they can only be unsafe code.
337 debug!("place_element_conflict: IGNORE-STATIC-MUT");
340 debug!("place_element_conflict: DISJOINT-OR-EQ-STATIC");
341 Overlap::EqualOrDisjoint
344 (StaticKind::Promoted(promoted_1, _), StaticKind::Promoted(promoted_2, _)) => {
345 if promoted_1 == promoted_2 {
346 if let ty::Array(_, len) = s1.ty.kind {
347 if let Some(0) = len.try_eval_usize(tcx, param_env) {
348 // Ignore conflicts with promoted [T; 0].
349 debug!("place_element_conflict: IGNORE-LEN-0-PROMOTED");
350 return Overlap::Disjoint;
353 // the same promoted - base case, equal
354 debug!("place_element_conflict: DISJOINT-OR-EQ-PROMOTED");
355 Overlap::EqualOrDisjoint
357 // different promoteds - base case, disjoint
358 debug!("place_element_conflict: DISJOINT-PROMOTED");
363 debug!("place_element_conflict: DISJOINT-STATIC-PROMOTED");
368 (PlaceBase::Local(_), PlaceBase::Static(_)) |
369 (PlaceBase::Static(_), PlaceBase::Local(_)) => {
370 debug!("place_element_conflict: DISJOINT-STATIC-LOCAL-PROMOTED");
376 // Given that the bases of `elem1` and `elem2` are always either equal
377 // or disjoint (and have the same type!), return the overlap situation
378 // between `elem1` and `elem2`.
379 fn place_projection_conflict<'tcx>(
382 pi1_base: &PlaceBase<'tcx>,
383 pi1_proj_base: &[PlaceElem<'tcx>],
384 pi1_elem: &PlaceElem<'tcx>,
385 pi2_elem: &PlaceElem<'tcx>,
386 bias: PlaceConflictBias,
388 match (pi1_elem, pi2_elem) {
389 (ProjectionElem::Deref, ProjectionElem::Deref) => {
390 // derefs (e.g., `*x` vs. `*x`) - recur.
391 debug!("place_element_conflict: DISJOINT-OR-EQ-DEREF");
392 Overlap::EqualOrDisjoint
394 (ProjectionElem::Field(f1, _), ProjectionElem::Field(f2, _)) => {
396 // same field (e.g., `a.y` vs. `a.y`) - recur.
397 debug!("place_element_conflict: DISJOINT-OR-EQ-FIELD");
398 Overlap::EqualOrDisjoint
400 let ty = Place::ty_from(pi1_base, pi1_proj_base, body, tcx).ty;
402 ty::Adt(def, _) if def.is_union() => {
403 // Different fields of a union, we are basically stuck.
404 debug!("place_element_conflict: STUCK-UNION");
408 // Different fields of a struct (`a.x` vs. `a.y`). Disjoint!
409 debug!("place_element_conflict: DISJOINT-FIELD");
415 (ProjectionElem::Downcast(_, v1), ProjectionElem::Downcast(_, v2)) => {
416 // different variants are treated as having disjoint fields,
417 // even if they occupy the same "space", because it's
418 // impossible for 2 variants of the same enum to exist
419 // (and therefore, to be borrowed) at the same time.
421 // Note that this is different from unions - we *do* allow
422 // this code to compile:
425 // fn foo(x: &mut Result<i32, i32>) {
427 // if let Ok(ref mut a) = *x {
430 // // here, you would *think* that the
431 // // *entirety* of `x` would be borrowed,
432 // // but in fact only the `Ok` variant is,
433 // // so the `Err` variant is *entirely free*:
434 // if let Err(ref mut a) = *x {
441 debug!("place_element_conflict: DISJOINT-OR-EQ-FIELD");
442 Overlap::EqualOrDisjoint
444 debug!("place_element_conflict: DISJOINT-FIELD");
448 (ProjectionElem::Index(..), ProjectionElem::Index(..))
449 | (ProjectionElem::Index(..), ProjectionElem::ConstantIndex { .. })
450 | (ProjectionElem::Index(..), ProjectionElem::Subslice { .. })
451 | (ProjectionElem::ConstantIndex { .. }, ProjectionElem::Index(..))
452 | (ProjectionElem::Subslice { .. }, ProjectionElem::Index(..)) => {
453 // Array indexes (`a[0]` vs. `a[i]`). These can either be disjoint
454 // (if the indexes differ) or equal (if they are the same).
456 PlaceConflictBias::Overlap => {
457 // If we are biased towards overlapping, then this is the recursive
458 // case that gives "equal *or* disjoint" its meaning.
459 debug!("place_element_conflict: DISJOINT-OR-EQ-ARRAY-INDEX");
460 Overlap::EqualOrDisjoint
462 PlaceConflictBias::NoOverlap => {
463 // If we are biased towards no overlapping, then this is disjoint.
464 debug!("place_element_conflict: DISJOINT-ARRAY-INDEX");
469 (ProjectionElem::ConstantIndex { offset: o1, min_length: _, from_end: false },
470 ProjectionElem::ConstantIndex { offset: o2, min_length: _, from_end: false })
471 | (ProjectionElem::ConstantIndex { offset: o1, min_length: _, from_end: true },
472 ProjectionElem::ConstantIndex {
473 offset: o2, min_length: _, from_end: true }) => {
475 debug!("place_element_conflict: DISJOINT-OR-EQ-ARRAY-CONSTANT-INDEX");
476 Overlap::EqualOrDisjoint
478 debug!("place_element_conflict: DISJOINT-ARRAY-CONSTANT-INDEX");
482 (ProjectionElem::ConstantIndex {
483 offset: offset_from_begin, min_length: min_length1, from_end: false },
484 ProjectionElem::ConstantIndex {
485 offset: offset_from_end, min_length: min_length2, from_end: true })
486 | (ProjectionElem::ConstantIndex {
487 offset: offset_from_end, min_length: min_length1, from_end: true },
488 ProjectionElem::ConstantIndex {
489 offset: offset_from_begin, min_length: min_length2, from_end: false }) => {
490 // both patterns matched so it must be at least the greater of the two
491 let min_length = max(min_length1, min_length2);
492 // `offset_from_end` can be in range `[1..min_length]`, 1 indicates the last
493 // element (like -1 in Python) and `min_length` the first.
494 // Therefore, `min_length - offset_from_end` gives the minimal possible
495 // offset from the beginning
496 if *offset_from_begin >= *min_length - *offset_from_end {
497 debug!("place_element_conflict: DISJOINT-OR-EQ-ARRAY-CONSTANT-INDEX-FE");
498 Overlap::EqualOrDisjoint
500 debug!("place_element_conflict: DISJOINT-ARRAY-CONSTANT-INDEX-FE");
505 ProjectionElem::ConstantIndex { offset, min_length: _, from_end: false },
506 ProjectionElem::Subslice { from, to, from_end: false }
509 ProjectionElem::Subslice { from, to, from_end: false },
510 ProjectionElem::ConstantIndex { offset, min_length: _, from_end: false }
512 if (from..to).contains(&offset) {
513 debug!("place_element_conflict: DISJOINT-OR-EQ-ARRAY-CONSTANT-INDEX-SUBSLICE");
514 Overlap::EqualOrDisjoint
516 debug!("place_element_conflict: DISJOINT-ARRAY-CONSTANT-INDEX-SUBSLICE");
520 (ProjectionElem::ConstantIndex { offset, min_length: _, from_end: false },
521 ProjectionElem::Subslice {from, .. })
522 | (ProjectionElem::Subslice {from, .. },
523 ProjectionElem::ConstantIndex { offset, min_length: _, from_end: false }) => {
526 "place_element_conflict: DISJOINT-OR-EQ-SLICE-CONSTANT-INDEX-SUBSLICE");
527 Overlap::EqualOrDisjoint
529 debug!("place_element_conflict: DISJOINT-SLICE-CONSTANT-INDEX-SUBSLICE");
533 (ProjectionElem::ConstantIndex { offset, min_length: _, from_end: true },
534 ProjectionElem::Subslice { to, from_end: true, .. })
535 | (ProjectionElem::Subslice { to, from_end: true, .. },
536 ProjectionElem::ConstantIndex { offset, min_length: _, from_end: true }) => {
538 debug!("place_element_conflict: \
539 DISJOINT-OR-EQ-SLICE-CONSTANT-INDEX-SUBSLICE-FE");
540 Overlap::EqualOrDisjoint
542 debug!("place_element_conflict: DISJOINT-SLICE-CONSTANT-INDEX-SUBSLICE-FE");
547 ProjectionElem::Subslice { from: f1, to: t1, from_end: false },
548 ProjectionElem::Subslice { from: f2, to: t2, from_end: false }
550 if f2 >= t1 || f1 >= t2 {
551 debug!("place_element_conflict: DISJOINT-ARRAY-SUBSLICES");
554 debug!("place_element_conflict: DISJOINT-OR-EQ-ARRAY-SUBSLICES");
555 Overlap::EqualOrDisjoint
558 (ProjectionElem::Subslice { .. }, ProjectionElem::Subslice { .. }) => {
559 debug!("place_element_conflict: DISJOINT-OR-EQ-SLICE-SUBSLICES");
560 Overlap::EqualOrDisjoint
562 (ProjectionElem::Deref, _)
563 | (ProjectionElem::Field(..), _)
564 | (ProjectionElem::Index(..), _)
565 | (ProjectionElem::ConstantIndex { .. }, _)
566 | (ProjectionElem::Subslice { .. }, _)
567 | (ProjectionElem::Downcast(..), _) => bug!(
568 "mismatched projections in place_element_conflict: {:?} and {:?}",