src/librustc_mir/borrow_check/nll/explain_borrow/mod.rs

   1 use std::collections::VecDeque;
   2
   3 use crate::borrow_check::borrow_set::BorrowData;
   4 use crate::borrow_check::error_reporting::UseSpans;
   5 use crate::borrow_check::nll::region_infer::{Cause, RegionName};
   6 use crate::borrow_check::nll::ConstraintDescription;
   7 use crate::borrow_check::{MirBorrowckCtxt, WriteKind};
   8 use rustc::mir::{
   9     CastKind, ConstraintCategory, FakeReadCause, Local, Location, Mir, Operand, Place, PlaceBase,
  10     Projection, ProjectionElem, Rvalue, Statement, StatementKind, TerminatorKind,
  11 };
  12 use rustc::ty::{self, TyCtxt};
  13 use rustc::ty::adjustment::{PointerCast};
  14 use rustc_data_structures::fx::FxHashSet;
  15 use rustc_errors::DiagnosticBuilder;
  16 use syntax_pos::Span;
  17
  18 mod find_use;
  19
  20 pub(in crate::borrow_check) enum BorrowExplanation {
  21     UsedLater(LaterUseKind, Span),
  22     UsedLaterInLoop(LaterUseKind, Span),
  23     UsedLaterWhenDropped {
  24         drop_loc: Location,
  25         dropped_local: Local,
  26         should_note_order: bool,
  27     },
  28     MustBeValidFor {
  29         category: ConstraintCategory,
  30         from_closure: bool,
  31         span: Span,
  32         region_name: RegionName,
  33         opt_place_desc: Option<String>,
  34     },
  35     Unexplained,
  36 }
  37
  38 #[derive(Clone, Copy)]
  39 pub(in crate::borrow_check) enum LaterUseKind {
  40     TraitCapture,
  41     ClosureCapture,
  42     Call,
  43     FakeLetRead,
  44     Other,
  45 }
  46
  47 impl BorrowExplanation {
  48     pub(in crate::borrow_check) fn is_explained(&self) -> bool {
  49         match self {
  50             BorrowExplanation::Unexplained => false,
  51             _ => true,
  52         }
  53     }
  54     pub(in crate::borrow_check) fn add_explanation_to_diagnostic<'cx, 'gcx, 'tcx>(
  55         &self,
  56         tcx: TyCtxt<'cx, 'gcx, 'tcx>,
  57         mir: &Mir<'tcx>,
  58         err: &mut DiagnosticBuilder<'_>,
  59         borrow_desc: &str,
  60         borrow_span: Option<Span>,
  61     ) {
  62         match *self {
  63             BorrowExplanation::UsedLater(later_use_kind, var_or_use_span) => {
  64                 let message = match later_use_kind {
  65                     LaterUseKind::TraitCapture => "captured here by trait object",
  66                     LaterUseKind::ClosureCapture => "captured here by closure",
  67                     LaterUseKind::Call => "used by call",
  68                     LaterUseKind::FakeLetRead => "stored here",
  69                     LaterUseKind::Other => "used here",
  70                 };
  71                 if !borrow_span.map(|sp| sp.overlaps(var_or_use_span)).unwrap_or(false) {
  72                     err.span_label(
  73                         var_or_use_span,
  74                         format!("{}borrow later {}", borrow_desc, message),
  75                     );
  76                 }
  77             }
  78             BorrowExplanation::UsedLaterInLoop(later_use_kind, var_or_use_span) => {
  79                 let message = match later_use_kind {
  80                     LaterUseKind::TraitCapture => {
  81                         "borrow captured here by trait object, in later iteration of loop"
  82                     }
  83                     LaterUseKind::ClosureCapture => {
  84                         "borrow captured here by closure, in later iteration of loop"
  85                     }
  86                     LaterUseKind::Call => "borrow used by call, in later iteration of loop",
  87                     LaterUseKind::FakeLetRead => "borrow later stored here",
  88                     LaterUseKind::Other => "borrow used here, in later iteration of loop",
  89                 };
  90                 err.span_label(var_or_use_span, format!("{}{}", borrow_desc, message));
  91             }
  92             BorrowExplanation::UsedLaterWhenDropped {
  93                 drop_loc,
  94                 dropped_local,
  95                 should_note_order,
  96             } => {
  97                 let local_decl = &mir.local_decls[dropped_local];
  98                 let (dtor_desc, type_desc) = match local_decl.ty.sty {
  99                     // If type is an ADT that implements Drop, then
 100                     // simplify output by reporting just the ADT name.
 101                     ty::Adt(adt, _substs) if adt.has_dtor(tcx) && !adt.is_box() => (
 102                         "`Drop` code",
 103                         format!("type `{}`", tcx.def_path_str(adt.did)),
 104                     ),
 105
 106                     // Otherwise, just report the whole type (and use
 107                     // the intentionally fuzzy phrase "destructor")
 108                     ty::Closure(..) => ("destructor", "closure".to_owned()),
 109                     ty::Generator(..) => ("destructor", "generator".to_owned()),
 110
 111                     _ => ("destructor", format!("type `{}`", local_decl.ty)),
 112                 };
 113
 114                 match local_decl.name {
 115                     Some(local_name) => {
 116                         let message = format!(
 117                             "{B}borrow might be used here, when `{LOC}` is dropped \
 118                              and runs the {DTOR} for {TYPE}",
 119                             B = borrow_desc,
 120                             LOC = local_name,
 121                             TYPE = type_desc,
 122                             DTOR = dtor_desc
 123                         );
 124                         err.span_label(mir.source_info(drop_loc).span, message);
 125
 126                         if should_note_order {
 127                             err.note(
 128                                 "values in a scope are dropped \
 129                                  in the opposite order they are defined",
 130                             );
 131                         }
 132                     }
 133                     None => {
 134                         err.span_label(
 135                             local_decl.source_info.span,
 136                             format!(
 137                                 "a temporary with access to the {B}borrow \
 138                                  is created here ...",
 139                                 B = borrow_desc
 140                             ),
 141                         );
 142                         let message = format!(
 143                             "... and the {B}borrow might be used here, \
 144                              when that temporary is dropped \
 145                              and runs the {DTOR} for {TYPE}",
 146                             B = borrow_desc,
 147                             TYPE = type_desc,
 148                             DTOR = dtor_desc
 149                         );
 150                         err.span_label(mir.source_info(drop_loc).span, message);
 151
 152                         if let Some(info) = &local_decl.is_block_tail {
 153                             // FIXME: use span_suggestion instead, highlighting the
 154                             // whole block tail expression.
 155                             let msg = if info.tail_result_is_ignored {
 156                                 "The temporary is part of an expression at the end of a block. \
 157                                  Consider adding semicolon after the expression so its temporaries \
 158                                  are dropped sooner, before the local variables declared by the \
 159                                  block are dropped."
 160                             } else {
 161                                 "The temporary is part of an expression at the end of a block. \
 162                                  Consider forcing this temporary to be dropped sooner, before \
 163                                  the block's local variables are dropped. \
 164                                  For example, you could save the expression's value in a new \
 165                                  local variable `x` and then make `x` be the expression \
 166                                  at the end of the block."
 167                             };
 168
 169                             err.note(msg);
 170                         }
 171                     }
 172                 }
 173             }
 174             BorrowExplanation::MustBeValidFor {
 175                 category,
 176                 span,
 177                 ref region_name,
 178                 ref opt_place_desc,
 179                 from_closure: _,
 180             } => {
 181                 region_name.highlight_region_name(err);
 182
 183                 if let Some(desc) = opt_place_desc {
 184                     err.span_label(
 185                         span,
 186                         format!(
 187                             "{}requires that `{}` is borrowed for `{}`",
 188                             category.description(),
 189                             desc,
 190                             region_name,
 191                         ),
 192                     );
 193                 } else {
 194                     err.span_label(
 195                         span,
 196                         format!(
 197                             "{}requires that {}borrow lasts for `{}`",
 198                             category.description(),
 199                             borrow_desc,
 200                             region_name,
 201                         ),
 202                     );
 203                 };
 204             }
 205             _ => {}
 206         }
 207     }
 208 }
 209
 210 impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
 211     /// Returns structured explanation for *why* the borrow contains the
 212     /// point from `location`. This is key for the "3-point errors"
 213     /// [described in the NLL RFC][d].
 214     ///
 215     /// # Parameters
 216     ///
 217     /// - `borrow`: the borrow in question
 218     /// - `location`: where the borrow occurs
 219     /// - `kind_place`: if Some, this describes the statement that triggered the error.
 220     ///   - first half is the kind of write, if any, being performed
 221     ///   - second half is the place being accessed
 222     ///
 223     /// [d]: https://rust-lang.github.io/rfcs/2094-nll.html#leveraging-intuition-framing-errors-in-terms-of-points
 224     pub(in crate::borrow_check) fn explain_why_borrow_contains_point(
 225         &self,
 226         location: Location,
 227         borrow: &BorrowData<'tcx>,
 228         kind_place: Option<(WriteKind, &Place<'tcx>)>,
 229     ) -> BorrowExplanation {
 230         debug!(
 231             "explain_why_borrow_contains_point(location={:?}, borrow={:?}, kind_place={:?})",
 232             location, borrow, kind_place
 233         );
 234
 235         let regioncx = &self.nonlexical_regioncx;
 236         let mir = self.mir;
 237         let tcx = self.infcx.tcx;
 238
 239         let borrow_region_vid = borrow.region;
 240         debug!(
 241             "explain_why_borrow_contains_point: borrow_region_vid={:?}",
 242             borrow_region_vid
 243         );
 244
 245         let region_sub = regioncx.find_sub_region_live_at(borrow_region_vid, location);
 246         debug!(
 247             "explain_why_borrow_contains_point: region_sub={:?}",
 248             region_sub
 249         );
 250
 251         match find_use::find(mir, regioncx, tcx, region_sub, location) {
 252             Some(Cause::LiveVar(local, location)) => {
 253                 let span = mir.source_info(location).span;
 254                 let spans = self
 255                     .move_spans(&Place::Base(PlaceBase::Local(local)), location)
 256                     .or_else(|| self.borrow_spans(span, location));
 257
 258                 let borrow_location = location;
 259                 if self.is_use_in_later_iteration_of_loop(borrow_location, location) {
 260                     let later_use = self.later_use_kind(borrow, spans, location);
 261                     BorrowExplanation::UsedLaterInLoop(later_use.0, later_use.1)
 262                 } else {
 263                     // Check if the location represents a `FakeRead`, and adapt the error
 264                     // message to the `FakeReadCause` it is from: in particular,
 265                     // the ones inserted in optimized `let var = <expr>` patterns.
 266                     let later_use = self.later_use_kind(borrow, spans, location);
 267                     BorrowExplanation::UsedLater(later_use.0, later_use.1)
 268                 }
 269             }
 270
 271             Some(Cause::DropVar(local, location)) => {
 272                 let mut should_note_order = false;
 273                 if mir.local_decls[local].name.is_some() {
 274                     if let Some((WriteKind::StorageDeadOrDrop, place)) = kind_place {
 275                         if let Place::Base(PlaceBase::Local(borrowed_local)) = place {
 276                              if mir.local_decls[*borrowed_local].name.is_some()
 277                                 && local != *borrowed_local
 278                             {
 279                                 should_note_order = true;
 280                             }
 281                         }
 282                     }
 283                 }
 284
 285                 BorrowExplanation::UsedLaterWhenDropped {
 286                     drop_loc: location,
 287                     dropped_local: local,
 288                     should_note_order,
 289                 }
 290             }
 291
 292             None => {
 293                 if let Some(region) = regioncx.to_error_region_vid(borrow_region_vid) {
 294                     let (category, from_closure, span, region_name) =
 295                         self.nonlexical_regioncx.free_region_constraint_info(
 296                             self.mir,
 297                         &self.upvars,
 298                             self.mir_def_id,
 299                             self.infcx,
 300                             borrow_region_vid,
 301                             region,
 302                         );
 303                     if let Some(region_name) = region_name {
 304                         let opt_place_desc = self.describe_place(&borrow.borrowed_place);
 305                         BorrowExplanation::MustBeValidFor {
 306                             category,
 307                             from_closure,
 308                             span,
 309                             region_name,
 310                             opt_place_desc,
 311                         }
 312                     } else {
 313                         BorrowExplanation::Unexplained
 314                     }
 315                 } else {
 316                     BorrowExplanation::Unexplained
 317                 }
 318             }
 319         }
 320     }
 321
 322     /// true if `borrow_location` can reach `use_location` by going through a loop and
 323     /// `use_location` is also inside of that loop
 324     fn is_use_in_later_iteration_of_loop(
 325         &self,
 326         borrow_location: Location,
 327         use_location: Location,
 328     ) -> bool {
 329         let back_edge = self.reach_through_backedge(borrow_location, use_location);
 330         back_edge.map_or(false, |back_edge| {
 331             self.can_reach_head_of_loop(use_location, back_edge)
 332         })
 333     }
 334
 335     /// Returns the outmost back edge if `from` location can reach `to` location passing through
 336     /// that back edge
 337     fn reach_through_backedge(&self, from: Location, to: Location) -> Option<Location> {
 338         let mut visited_locations = FxHashSet::default();
 339         let mut pending_locations = VecDeque::new();
 340         visited_locations.insert(from);
 341         pending_locations.push_back(from);
 342         debug!("reach_through_backedge: from={:?} to={:?}", from, to,);
 343
 344         let mut outmost_back_edge = None;
 345         while let Some(location) = pending_locations.pop_front() {
 346             debug!(
 347                 "reach_through_backedge: location={:?} outmost_back_edge={:?}
 348                    pending_locations={:?} visited_locations={:?}",
 349                 location, outmost_back_edge, pending_locations, visited_locations
 350             );
 351
 352             if location == to && outmost_back_edge.is_some() {
 353                 // We've managed to reach the use location
 354                 debug!("reach_through_backedge: found!");
 355                 return outmost_back_edge;
 356             }
 357
 358             let block = &self.mir.basic_blocks()[location.block];
 359
 360             if location.statement_index < block.statements.len() {
 361                 let successor = location.successor_within_block();
 362                 if visited_locations.insert(successor) {
 363                     pending_locations.push_back(successor);
 364                 }
 365             } else {
 366                 pending_locations.extend(
 367                     block
 368                         .terminator()
 369                         .successors()
 370                         .map(|bb| Location {
 371                             statement_index: 0,
 372                             block: *bb,
 373                         })
 374                         .filter(|s| visited_locations.insert(*s))
 375                         .map(|s| {
 376                             if self.is_back_edge(location, s) {
 377                                 match outmost_back_edge {
 378                                     None => {
 379                                         outmost_back_edge = Some(location);
 380                                     }
 381
 382                                     Some(back_edge)
 383                                         if location.dominates(back_edge, &self.dominators) =>
 384                                     {
 385                                         outmost_back_edge = Some(location);
 386                                     }
 387
 388                                     Some(_) => {}
 389                                 }
 390                             }
 391
 392                             s
 393                         }),
 394                 );
 395             }
 396         }
 397
 398         None
 399     }
 400
 401     /// true if `from` location can reach `loop_head` location and `loop_head` dominates all the
 402     /// intermediate nodes
 403     fn can_reach_head_of_loop(&self, from: Location, loop_head: Location) -> bool {
 404         self.find_loop_head_dfs(from, loop_head, &mut FxHashSet::default())
 405     }
 406
 407     fn find_loop_head_dfs(
 408         &self,
 409         from: Location,
 410         loop_head: Location,
 411         visited_locations: &mut FxHashSet<Location>,
 412     ) -> bool {
 413         visited_locations.insert(from);
 414
 415         if from == loop_head {
 416             return true;
 417         }
 418
 419         if loop_head.dominates(from, &self.dominators) {
 420             let block = &self.mir.basic_blocks()[from.block];
 421
 422             if from.statement_index < block.statements.len() {
 423                 let successor = from.successor_within_block();
 424
 425                 if !visited_locations.contains(&successor)
 426                     && self.find_loop_head_dfs(successor, loop_head, visited_locations)
 427                 {
 428                     return true;
 429                 }
 430             } else {
 431                 for bb in block.terminator().successors() {
 432                     let successor = Location {
 433                         statement_index: 0,
 434                         block: *bb,
 435                     };
 436
 437                     if !visited_locations.contains(&successor)
 438                         && self.find_loop_head_dfs(successor, loop_head, visited_locations)
 439                     {
 440                         return true;
 441                     }
 442                 }
 443             }
 444         }
 445
 446         false
 447     }
 448
 449     /// True if an edge `source -> target` is a backedge -- in other words, if the target
 450     /// dominates the source.
 451     fn is_back_edge(&self, source: Location, target: Location) -> bool {
 452         target.dominates(source, &self.mir.dominators())
 453     }
 454
 455     /// Determine how the borrow was later used.
 456     fn later_use_kind(
 457         &self,
 458         borrow: &BorrowData<'tcx>,
 459         use_spans: UseSpans,
 460         location: Location,
 461     ) -> (LaterUseKind, Span) {
 462         match use_spans {
 463             UseSpans::ClosureUse { var_span, .. } => {
 464                 // Used in a closure.
 465                 (LaterUseKind::ClosureCapture, var_span)
 466             }
 467             UseSpans::OtherUse(span) => {
 468                 let block = &self.mir.basic_blocks()[location.block];
 469
 470                 let kind = if let Some(&Statement {
 471                     kind: StatementKind::FakeRead(FakeReadCause::ForLet, _),
 472                     ..
 473                 }) = block.statements.get(location.statement_index)
 474                 {
 475                     LaterUseKind::FakeLetRead
 476                 } else if self.was_captured_by_trait_object(borrow) {
 477                     LaterUseKind::TraitCapture
 478                 } else if location.statement_index == block.statements.len() {
 479                     if let TerminatorKind::Call {
 480                         ref func,
 481                         from_hir_call: true,
 482                         ..
 483                     } = block.terminator().kind
 484                     {
 485                         // Just point to the function, to reduce the chance of overlapping spans.
 486                         let function_span = match func {
 487                             Operand::Constant(c) => c.span,
 488                             Operand::Copy(Place::Base(PlaceBase::Local(l))) |
 489                             Operand::Move(Place::Base(PlaceBase::Local(l))) => {
 490                                 let local_decl = &self.mir.local_decls[*l];
 491                                 if local_decl.name.is_none() {
 492                                     local_decl.source_info.span
 493                                 } else {
 494                                     span
 495                                 }
 496                             }
 497                             _ => span,
 498                         };
 499                         return (LaterUseKind::Call, function_span);
 500                     } else {
 501                         LaterUseKind::Other
 502                     }
 503                 } else {
 504                     LaterUseKind::Other
 505                 };
 506
 507                 (kind, span)
 508             }
 509         }
 510     }
 511
 512     /// Checks if a borrowed value was captured by a trait object. We do this by
 513     /// looking forward in the MIR from the reserve location and checking if we see
 514     /// a unsized cast to a trait object on our data.
 515     fn was_captured_by_trait_object(&self, borrow: &BorrowData<'tcx>) -> bool {
 516         // Start at the reserve location, find the place that we want to see cast to a trait object.
 517         let location = borrow.reserve_location;
 518         let block = &self.mir[location.block];
 519         let stmt = block.statements.get(location.statement_index);
 520         debug!(
 521             "was_captured_by_trait_object: location={:?} stmt={:?}",
 522             location, stmt
 523         );
 524
 525         // We make a `queue` vector that has the locations we want to visit. As of writing, this
 526         // will only ever have one item at any given time, but by using a vector, we can pop from
 527         // it which simplifies the termination logic.
 528         let mut queue = vec![location];
 529         let mut target = if let Some(&Statement {
 530             kind: StatementKind::Assign(Place::Base(PlaceBase::Local(local)), _),
 531             ..
 532         }) = stmt
 533         {
 534             local
 535         } else {
 536             return false;
 537         };
 538
 539         debug!(
 540             "was_captured_by_trait: target={:?} queue={:?}",
 541             target, queue
 542         );
 543         while let Some(current_location) = queue.pop() {
 544             debug!("was_captured_by_trait: target={:?}", target);
 545             let block = &self.mir[current_location.block];
 546             // We need to check the current location to find out if it is a terminator.
 547             let is_terminator = current_location.statement_index == block.statements.len();
 548             if !is_terminator {
 549                 let stmt = &block.statements[current_location.statement_index];
 550                 debug!("was_captured_by_trait_object: stmt={:?}", stmt);
 551
 552                 // The only kind of statement that we care about is assignments...
 553                 if let StatementKind::Assign(place, box rvalue) = &stmt.kind {
 554                     let into = match place {
 555                         Place::Base(PlaceBase::Local(into)) => into,
 556                         Place::Projection(box Projection {
 557                             base: Place::Base(PlaceBase::Local(into)),
 558                             elem: ProjectionElem::Deref,
 559                         }) => into,
 560                         _ => {
 561                             // Continue at the next location.
 562                             queue.push(current_location.successor_within_block());
 563                             continue;
 564                         }
 565                     };
 566
 567                     match rvalue {
 568                         // If we see a use, we should check whether it is our data, and if so
 569                         // update the place that we're looking for to that new place.
 570                         Rvalue::Use(operand) => match operand {
 571                             Operand::Copy(Place::Base(PlaceBase::Local(from)))
 572                             | Operand::Move(Place::Base(PlaceBase::Local(from)))
 573                                 if *from == target =>
 574                             {
 575                                 target = *into;
 576                             }
 577                             _ => {}
 578                         },
 579                         // If we see a unsized cast, then if it is our data we should check
 580                         // whether it is being cast to a trait object.
 581                         Rvalue::Cast(
 582                             CastKind::Pointer(PointerCast::Unsize), operand, ty
 583                         ) => match operand {
 584                             Operand::Copy(Place::Base(PlaceBase::Local(from)))
 585                             | Operand::Move(Place::Base(PlaceBase::Local(from)))
 586                                 if *from == target =>
 587                             {
 588                                 debug!("was_captured_by_trait_object: ty={:?}", ty);
 589                                 // Check the type for a trait object.
 590                                 return match ty.sty {
 591                                     // `&dyn Trait`
 592                                     ty::Ref(_, ty, _) if ty.is_trait() => true,
 593                                     // `Box<dyn Trait>`
 594                                     _ if ty.is_box() && ty.boxed_ty().is_trait() => true,
 595                                     // `dyn Trait`
 596                                     _ if ty.is_trait() => true,
 597                                     // Anything else.
 598                                     _ => false,
 599                                 };
 600                             }
 601                             _ => return false,
 602                         },
 603                         _ => {}
 604                     }
 605                 }
 606
 607                 // Continue at the next location.
 608                 queue.push(current_location.successor_within_block());
 609             } else {
 610                 // The only thing we need to do for terminators is progress to the next block.
 611                 let terminator = block.terminator();
 612                 debug!("was_captured_by_trait_object: terminator={:?}", terminator);
 613
 614                 if let TerminatorKind::Call {
 615                     destination: Some((Place::Base(PlaceBase::Local(dest)), block)),
 616                     args,
 617                     ..
 618                 } = &terminator.kind
 619                 {
 620                     debug!(
 621                         "was_captured_by_trait_object: target={:?} dest={:?} args={:?}",
 622                         target, dest, args
 623                     );
 624                     // Check if one of the arguments to this function is the target place.
 625                     let found_target = args.iter().any(|arg| {
 626                         if let Operand::Move(Place::Base(PlaceBase::Local(potential))) = arg {
 627                             *potential == target
 628                         } else {
 629                             false
 630                         }
 631                     });
 632
 633                     // If it is, follow this to the next block and update the target.
 634                     if found_target {
 635                         target = *dest;
 636                         queue.push(block.start_location());
 637                     }
 638                 }
 639             }
 640
 641             debug!("was_captured_by_trait: queue={:?}", queue);
 642         }
 643
 644         // We didn't find anything and ran out of locations to check.
 645         false
 646     }
 647 }