1 // Copyright 2017 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 //! This query borrow-checks the MIR to (further) ensure it is not broken.
13 use borrow_check::nll::region_infer::RegionInferenceContext;
15 use rustc::hir::def_id::DefId;
16 use rustc::hir::map::definitions::DefPathData;
17 use rustc::infer::InferCtxt;
18 use rustc::lint::builtin::UNUSED_MUT;
19 use rustc::mir::{self, AggregateKind, BasicBlock, BorrowCheckResult, BorrowKind};
20 use rustc::mir::{ClearCrossCrate, Local, Location, Mir, Mutability, Operand, Place};
21 use rustc::mir::{Field, Projection, ProjectionElem, Rvalue, Statement, StatementKind};
22 use rustc::mir::{Terminator, TerminatorKind};
23 use rustc::ty::query::Providers;
24 use rustc::ty::{self, ParamEnv, TyCtxt};
26 use rustc_data_structures::control_flow_graph::dominators::Dominators;
27 use rustc_data_structures::fx::FxHashSet;
28 use rustc_data_structures::indexed_set::IdxSetBuf;
29 use rustc_data_structures::indexed_vec::Idx;
30 use rustc_data_structures::small_vec::SmallVec;
32 use core::unicode::property::Pattern_White_Space;
38 use dataflow::indexes::BorrowIndex;
39 use dataflow::move_paths::{HasMoveData, LookupResult, MoveData, MovePathIndex};
40 use dataflow::Borrows;
41 use dataflow::DataflowResultsConsumer;
42 use dataflow::FlowAtLocation;
43 use dataflow::MoveDataParamEnv;
44 use dataflow::{do_dataflow, DebugFormatted};
45 use dataflow::{EverInitializedPlaces, MovingOutStatements};
46 use dataflow::{MaybeInitializedPlaces, MaybeUninitializedPlaces};
47 use util::borrowck_errors::{BorrowckErrors, Origin};
48 use util::collect_writes::FindAssignments;
50 use self::borrow_set::{BorrowData, BorrowSet};
51 use self::flows::Flows;
52 use self::location::LocationTable;
53 use self::prefixes::PrefixSet;
54 use self::MutateMode::{JustWrite, WriteAndRead};
56 use self::path_utils::*;
71 pub fn provide(providers: &mut Providers) {
72 *providers = Providers {
78 fn mir_borrowck<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) -> BorrowCheckResult<'tcx> {
79 let input_mir = tcx.mir_validated(def_id);
80 debug!("run query mir_borrowck: {}", tcx.item_path_str(def_id));
84 // Return early if we are not supposed to use MIR borrow checker for this function.
85 return_early = !tcx.has_attr(def_id, "rustc_mir") && !tcx.use_mir_borrowck();
87 if tcx.is_struct_constructor(def_id) {
88 // We are not borrow checking the automatically generated struct constructors
89 // because we want to accept structs such as this (taken from the `linked-hash-map`
92 // struct Qey<Q: ?Sized>(Q);
94 // MIR of this struct constructor looks something like this:
96 // fn Qey(_1: Q) -> Qey<Q>{
97 // let mut _0: Qey<Q>; // return place
100 // (_0.0: Q) = move _1; // bb0[0]: scope 0 at src/main.rs:1:1: 1:26
101 // return; // bb0[1]: scope 0 at src/main.rs:1:1: 1:26
105 // The problem here is that `(_0.0: Q) = move _1;` is valid only if `Q` is
106 // of statically known size, which is not known to be true because of the
107 // `Q: ?Sized` constraint. However, it is true because the constructor can be
108 // called only when `Q` is of statically known size.
113 return BorrowCheckResult {
114 closure_requirements: None,
115 used_mut_upvars: SmallVec::new(),
119 let opt_closure_req = tcx.infer_ctxt().enter(|infcx| {
120 let input_mir: &Mir = &input_mir.borrow();
121 do_mir_borrowck(&infcx, input_mir, def_id)
123 debug!("mir_borrowck done");
128 fn do_mir_borrowck<'a, 'gcx, 'tcx>(
129 infcx: &InferCtxt<'a, 'gcx, 'tcx>,
130 input_mir: &Mir<'gcx>,
132 ) -> BorrowCheckResult<'gcx> {
133 debug!("do_mir_borrowck(def_id = {:?})", def_id);
136 let attributes = tcx.get_attrs(def_id);
137 let param_env = tcx.param_env(def_id);
140 .as_local_node_id(def_id)
141 .expect("do_mir_borrowck: non-local DefId");
143 // Replace all regions with fresh inference variables. This
144 // requires first making our own copy of the MIR. This copy will
145 // be modified (in place) to contain non-lexical lifetimes. It
146 // will have a lifetime tied to the inference context.
147 let mut mir: Mir<'tcx> = input_mir.clone();
148 let free_regions = nll::replace_regions_in_mir(infcx, def_id, param_env, &mut mir);
149 let mir = &mir; // no further changes
150 let location_table = &LocationTable::new(mir);
152 let move_data: MoveData<'tcx> = match MoveData::gather_moves(mir, tcx) {
153 Ok(move_data) => move_data,
154 Err((move_data, move_errors)) => {
155 move_errors::report_move_errors(&mir, tcx, move_errors, &move_data);
160 let mdpe = MoveDataParamEnv {
161 move_data: move_data,
162 param_env: param_env,
164 let body_id = match tcx.def_key(def_id).disambiguated_data.data {
165 DefPathData::StructCtor | DefPathData::EnumVariant(_) => None,
166 _ => Some(tcx.hir.body_owned_by(id)),
169 let dead_unwinds = IdxSetBuf::new_empty(mir.basic_blocks().len());
170 let mut flow_inits = FlowAtLocation::new(do_dataflow(
176 MaybeInitializedPlaces::new(tcx, mir, &mdpe),
177 |bd, i| DebugFormatted::new(&bd.move_data().move_paths[i]),
179 let flow_uninits = FlowAtLocation::new(do_dataflow(
185 MaybeUninitializedPlaces::new(tcx, mir, &mdpe),
186 |bd, i| DebugFormatted::new(&bd.move_data().move_paths[i]),
188 let flow_move_outs = FlowAtLocation::new(do_dataflow(
194 MovingOutStatements::new(tcx, mir, &mdpe),
195 |bd, i| DebugFormatted::new(&bd.move_data().moves[i]),
197 let flow_ever_inits = FlowAtLocation::new(do_dataflow(
203 EverInitializedPlaces::new(tcx, mir, &mdpe),
204 |bd, i| DebugFormatted::new(&bd.move_data().inits[i]),
207 let borrow_set = Rc::new(BorrowSet::build(tcx, mir));
209 // If we are in non-lexical mode, compute the non-lexical lifetimes.
210 let (regioncx, polonius_output, opt_closure_req) = nll::compute_regions(
221 let regioncx = Rc::new(regioncx);
222 let flow_inits = flow_inits; // remove mut
224 let flow_borrows = FlowAtLocation::new(do_dataflow(
230 Borrows::new(tcx, mir, regioncx.clone(), def_id, body_id, &borrow_set),
231 |rs, i| DebugFormatted::new(&rs.location(i)),
234 let movable_generator = match tcx.hir.get(id) {
235 hir::map::Node::NodeExpr(&hir::Expr {
236 node: hir::ExprClosure(.., Some(hir::GeneratorMovability::Static)),
242 let dominators = mir.dominators();
244 let mut mbcx = MirBorrowckCtxt {
248 move_data: &mdpe.move_data,
249 param_env: param_env,
252 locals_are_invalidated_at_exit: match tcx.hir.body_owner_kind(id) {
253 hir::BodyOwnerKind::Const | hir::BodyOwnerKind::Static(_) => false,
254 hir::BodyOwnerKind::Fn => true,
256 access_place_error_reported: FxHashSet(),
257 reservation_error_reported: FxHashSet(),
258 moved_error_reported: FxHashSet(),
259 nonlexical_regioncx: regioncx,
260 used_mut: FxHashSet(),
261 used_mut_upvars: SmallVec::new(),
266 let mut state = Flows::new(
275 mbcx.analyze_results(&mut state); // entry point for DataflowResultsConsumer
277 // For each non-user used mutable variable, check if it's been assigned from
278 // a user-declared local. If so, then put that local into the used_mut set.
279 // Note that this set is expected to be small - only upvars from closures
280 // would have a chance of erroneously adding non-user-defined mutable vars
282 let temporary_used_locals: FxHashSet<Local> = mbcx
285 .filter(|&local| !mbcx.mir.local_decls[*local].is_user_variable.is_some())
288 mbcx.gather_used_muts(temporary_used_locals);
290 debug!("mbcx.used_mut: {:?}", mbcx.used_mut);
294 .mut_vars_and_args_iter()
295 .filter(|local| !mbcx.used_mut.contains(local))
297 if let ClearCrossCrate::Set(ref vsi) = mbcx.mir.source_scope_local_data {
298 let local_decl = &mbcx.mir.local_decls[local];
300 // Skip implicit `self` argument for closures
301 if local.index() == 1 && tcx.is_closure(mbcx.mir_def_id) {
305 // Skip over locals that begin with an underscore or have no name
306 match local_decl.name {
307 Some(name) => if name.as_str().starts_with("_") {
313 let span = local_decl.source_info.span;
314 let mut_span = tcx.sess.codemap().span_until_non_whitespace(span);
316 tcx.struct_span_lint_node(
318 vsi[local_decl.source_info.scope].lint_root,
320 "variable does not need to be mutable",
321 ).span_suggestion_short(mut_span, "remove this `mut`", "".to_owned())
326 let result = BorrowCheckResult {
327 closure_requirements: opt_closure_req,
328 used_mut_upvars: mbcx.used_mut_upvars,
331 debug!("do_mir_borrowck: result = {:#?}", result);
337 pub struct MirBorrowckCtxt<'cx, 'gcx: 'tcx, 'tcx: 'cx> {
338 tcx: TyCtxt<'cx, 'gcx, 'tcx>,
341 move_data: &'cx MoveData<'tcx>,
343 /// Map from MIR `Location` to `LocationIndex`; created
344 /// when MIR borrowck begins.
345 location_table: &'cx LocationTable,
347 param_env: ParamEnv<'gcx>,
348 movable_generator: bool,
349 /// This keeps track of whether local variables are free-ed when the function
350 /// exits even without a `StorageDead`, which appears to be the case for
353 /// I'm not sure this is the right approach - @eddyb could you try and
355 locals_are_invalidated_at_exit: bool,
356 /// This field keeps track of when borrow errors are reported in the access_place function
357 /// so that there is no duplicate reporting. This field cannot also be used for the conflicting
358 /// borrow errors that is handled by the `reservation_error_reported` field as the inclusion
359 /// of the `Span` type (while required to mute some errors) stops the muting of the reservation
361 access_place_error_reported: FxHashSet<(Place<'tcx>, Span)>,
362 /// This field keeps track of when borrow conflict errors are reported
363 /// for reservations, so that we don't report seemingly duplicate
364 /// errors for corresponding activations
366 /// FIXME: Ideally this would be a set of BorrowIndex, not Places,
367 /// but it is currently inconvenient to track down the BorrowIndex
368 /// at the time we detect and report a reservation error.
369 reservation_error_reported: FxHashSet<Place<'tcx>>,
370 /// This field keeps track of errors reported in the checking of moved variables,
371 /// so that we don't report report seemingly duplicate errors.
372 moved_error_reported: FxHashSet<Place<'tcx>>,
373 /// This field keeps track of all the local variables that are declared mut and are mutated.
374 /// Used for the warning issued by an unused mutable local variable.
375 used_mut: FxHashSet<Local>,
376 /// If the function we're checking is a closure, then we'll need to report back the list of
377 /// mutable upvars that have been used. This field keeps track of them.
378 used_mut_upvars: SmallVec<[Field; 8]>,
379 /// Non-lexical region inference context, if NLL is enabled. This
380 /// contains the results from region inference and lets us e.g.
381 /// find out which CFG points are contained in each borrow region.
382 nonlexical_regioncx: Rc<RegionInferenceContext<'tcx>>,
384 /// The set of borrows extracted from the MIR
385 borrow_set: Rc<BorrowSet<'tcx>>,
387 /// Dominators for MIR
388 dominators: Dominators<BasicBlock>,
392 // 1. assignments are always made to mutable locations (FIXME: does that still really go here?)
393 // 2. loans made in overlapping scopes do not conflict
394 // 3. assignments do not affect things loaned out as immutable
395 // 4. moves do not affect things loaned out in any way
396 impl<'cx, 'gcx, 'tcx> DataflowResultsConsumer<'cx, 'tcx> for MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
397 type FlowState = Flows<'cx, 'gcx, 'tcx>;
399 fn mir(&self) -> &'cx Mir<'tcx> {
403 fn visit_block_entry(&mut self, bb: BasicBlock, flow_state: &Self::FlowState) {
404 debug!("MirBorrowckCtxt::process_block({:?}): {}", bb, flow_state);
407 fn visit_statement_entry(
410 stmt: &Statement<'tcx>,
411 flow_state: &Self::FlowState,
414 "MirBorrowckCtxt::process_statement({:?}, {:?}): {}",
415 location, stmt, flow_state
417 let span = stmt.source_info.span;
419 self.check_activations(location, span, flow_state);
422 StatementKind::Assign(ref lhs, ref rhs) => {
424 ContextKind::AssignRhs.new(location),
431 ContextKind::AssignLhs.new(location),
438 StatementKind::ReadForMatch(ref place) => {
440 ContextKind::ReadForMatch.new(location),
442 (Deep, Read(ReadKind::Borrow(BorrowKind::Shared))),
443 LocalMutationIsAllowed::No,
447 StatementKind::SetDiscriminant {
452 ContextKind::SetDiscrim.new(location),
454 Shallow(Some(ArtificialField::Discriminant)),
459 StatementKind::InlineAsm {
464 let context = ContextKind::InlineAsm.new(location);
465 for (o, output) in asm.outputs.iter().zip(outputs) {
467 // FIXME(eddyb) indirect inline asm outputs should
468 // be encoeded through MIR place derefs instead.
472 (Deep, Read(ReadKind::Copy)),
473 LocalMutationIsAllowed::No,
476 self.check_if_path_or_subpath_is_moved(
478 InitializationRequiringAction::Use,
486 if o.is_rw { Deep } else { Shallow(None) },
487 if o.is_rw { WriteAndRead } else { JustWrite },
492 for input in inputs {
493 self.consume_operand(context, (input, span), flow_state);
496 StatementKind::EndRegion(ref _rgn) => {
497 // ignored when consuming results (update to
498 // flow_state already handled).
501 | StatementKind::UserAssertTy(..)
502 | StatementKind::Validate(..)
503 | StatementKind::StorageLive(..) => {
504 // `Nop`, `UserAssertTy`, `Validate`, and `StorageLive` are irrelevant
507 StatementKind::StorageDead(local) => {
509 ContextKind::StorageDead.new(location),
510 (&Place::Local(local), span),
511 (Shallow(None), Write(WriteKind::StorageDeadOrDrop)),
512 LocalMutationIsAllowed::Yes,
519 fn visit_terminator_entry(
522 term: &Terminator<'tcx>,
523 flow_state: &Self::FlowState,
527 "MirBorrowckCtxt::process_terminator({:?}, {:?}): {}",
528 location, term, flow_state
530 let span = term.source_info.span;
532 self.check_activations(location, span, flow_state);
535 TerminatorKind::SwitchInt {
541 self.consume_operand(ContextKind::SwitchInt.new(loc), (discr, span), flow_state);
543 TerminatorKind::Drop {
544 location: ref drop_place,
548 let gcx = self.tcx.global_tcx();
550 // Compute the type with accurate region information.
551 let drop_place_ty = drop_place.ty(self.mir, self.tcx);
553 // Erase the regions.
554 let drop_place_ty = self.tcx.erase_regions(&drop_place_ty).to_ty(self.tcx);
556 // "Lift" into the gcx -- once regions are erased, this type should be in the
557 // global arenas; this "lift" operation basically just asserts that is true, but
558 // that is useful later.
559 let drop_place_ty = gcx.lift(&drop_place_ty).unwrap();
561 self.visit_terminator_drop(loc, term, flow_state, drop_place, drop_place_ty, span);
563 TerminatorKind::DropAndReplace {
564 location: ref drop_place,
565 value: ref new_value,
570 ContextKind::DropAndReplace.new(loc),
576 self.consume_operand(
577 ContextKind::DropAndReplace.new(loc),
582 TerminatorKind::Call {
588 self.consume_operand(ContextKind::CallOperator.new(loc), (func, span), flow_state);
590 self.consume_operand(
591 ContextKind::CallOperand.new(loc),
596 if let Some((ref dest, _ /*bb*/)) = *destination {
598 ContextKind::CallDest.new(loc),
606 TerminatorKind::Assert {
613 self.consume_operand(ContextKind::Assert.new(loc), (cond, span), flow_state);
614 use rustc::mir::interpret::EvalErrorKind::BoundsCheck;
615 if let BoundsCheck { ref len, ref index } = *msg {
616 self.consume_operand(ContextKind::Assert.new(loc), (len, span), flow_state);
617 self.consume_operand(ContextKind::Assert.new(loc), (index, span), flow_state);
621 TerminatorKind::Yield {
626 self.consume_operand(ContextKind::Yield.new(loc), (value, span), flow_state);
628 if self.movable_generator {
629 // Look for any active borrows to locals
630 let borrow_set = self.borrow_set.clone();
631 flow_state.with_outgoing_borrows(|borrows| {
633 let borrow = &borrow_set[i];
634 self.check_for_local_borrow(borrow, span);
640 TerminatorKind::Resume | TerminatorKind::Return | TerminatorKind::GeneratorDrop => {
641 // Returning from the function implicitly kills storage for all locals and statics.
642 // Often, the storage will already have been killed by an explicit
643 // StorageDead, but we don't always emit those (notably on unwind paths),
644 // so this "extra check" serves as a kind of backup.
645 let borrow_set = self.borrow_set.clone();
646 flow_state.with_outgoing_borrows(|borrows| {
648 let borrow = &borrow_set[i];
649 let context = ContextKind::StorageDead.new(loc);
650 self.check_for_invalidation_at_exit(context, borrow, span);
654 TerminatorKind::Goto { target: _ }
655 | TerminatorKind::Abort
656 | TerminatorKind::Unreachable
657 | TerminatorKind::FalseEdges {
659 imaginary_targets: _,
661 | TerminatorKind::FalseUnwind {
665 // no data used, thus irrelevant to borrowck
671 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
677 use self::ReadOrWrite::{Activation, Read, Reservation, Write};
678 use self::ShallowOrDeep::{Deep, Shallow};
680 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
681 enum ArtificialField {
686 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
688 /// From the RFC: "A *shallow* access means that the immediate
689 /// fields reached at P are accessed, but references or pointers
690 /// found within are not dereferenced. Right now, the only access
691 /// that is shallow is an assignment like `x = ...;`, which would
692 /// be a *shallow write* of `x`."
693 Shallow(Option<ArtificialField>),
695 /// From the RFC: "A *deep* access means that all data reachable
696 /// through the given place may be invalidated or accesses by
701 /// Kind of access to a value: read or write
702 /// (For informational purposes only)
703 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
705 /// From the RFC: "A *read* means that the existing data may be
706 /// read, but will not be changed."
709 /// From the RFC: "A *write* means that the data may be mutated to
710 /// new values or otherwise invalidated (for example, it could be
711 /// de-initialized, as in a move operation).
714 /// For two-phase borrows, we distinguish a reservation (which is treated
715 /// like a Read) from an activation (which is treated like a write), and
716 /// each of those is furthermore distinguished from Reads/Writes above.
717 Reservation(WriteKind),
718 Activation(WriteKind, BorrowIndex),
721 /// Kind of read access to a value
722 /// (For informational purposes only)
723 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
729 /// Kind of write access to a value
730 /// (For informational purposes only)
731 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
734 MutableBorrow(BorrowKind),
739 /// When checking permissions for a place access, this flag is used to indicate that an immutable
740 /// local place can be mutated.
742 /// FIXME: @nikomatsakis suggested that this flag could be removed with the following modifications:
743 /// - Merge `check_access_permissions()` and `check_if_reassignment_to_immutable_state()`
744 /// - Split `is_mutable()` into `is_assignable()` (can be directly assigned) and
745 /// `is_declared_mutable()`
746 /// - Take flow state into consideration in `is_assignable()` for local variables
747 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
748 enum LocalMutationIsAllowed {
750 /// We want use of immutable upvars to cause a "write to immutable upvar"
751 /// error, not an "reassignment" error.
756 struct AccessErrorsReported {
757 mutability_error: bool,
759 conflict_error: bool,
762 #[derive(Copy, Clone)]
763 enum InitializationRequiringAction {
770 struct RootPlace<'d, 'tcx: 'd> {
771 place: &'d Place<'tcx>,
772 is_local_mutation_allowed: LocalMutationIsAllowed,
775 impl InitializationRequiringAction {
776 fn as_noun(self) -> &'static str {
778 InitializationRequiringAction::Update => "update",
779 InitializationRequiringAction::Borrow => "borrow",
780 InitializationRequiringAction::Use => "use",
781 InitializationRequiringAction::Assignment => "assign",
785 fn as_verb_in_past_tense(self) -> &'static str {
787 InitializationRequiringAction::Update => "updated",
788 InitializationRequiringAction::Borrow => "borrowed",
789 InitializationRequiringAction::Use => "used",
790 InitializationRequiringAction::Assignment => "assigned",
795 impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
796 /// Invokes `access_place` as appropriate for dropping the value
797 /// at `drop_place`. Note that the *actual* `Drop` in the MIR is
798 /// always for a variable (e.g., `Drop(x)`) -- but we recursively
799 /// break this variable down into subpaths (e.g., `Drop(x.foo)`)
800 /// to indicate more precisely which fields might actually be
801 /// accessed by a destructor.
802 fn visit_terminator_drop(
805 term: &Terminator<'tcx>,
806 flow_state: &Flows<'cx, 'gcx, 'tcx>,
807 drop_place: &Place<'tcx>,
808 erased_drop_place_ty: ty::Ty<'gcx>,
811 let gcx = self.tcx.global_tcx();
812 let drop_field = |mir: &mut MirBorrowckCtxt<'cx, 'gcx, 'tcx>,
813 (index, field): (usize, ty::Ty<'gcx>)| {
814 let field_ty = gcx.normalize_erasing_regions(mir.param_env, field);
815 let place = drop_place.clone().field(Field::new(index), field_ty);
817 mir.visit_terminator_drop(loc, term, flow_state, &place, field_ty, span);
820 match erased_drop_place_ty.sty {
821 // When a struct is being dropped, we need to check
822 // whether it has a destructor, if it does, then we can
823 // call it, if it does not then we need to check the
824 // individual fields instead. This way if `foo` has a
825 // destructor but `bar` does not, we will only check for
826 // borrows of `x.foo` and not `x.bar`. See #47703.
827 ty::TyAdt(def, substs) if def.is_struct() && !def.has_dtor(self.tcx) => {
829 .map(|field| field.ty(gcx, substs))
831 .for_each(|field| drop_field(self, field));
833 // Same as above, but for tuples.
834 ty::TyTuple(tys) => {
838 .for_each(|field| drop_field(self, field));
840 // Closures also have disjoint fields, but they are only
841 // directly accessed in the body of the closure.
842 ty::TyClosure(def, substs)
843 if *drop_place == Place::Local(Local::new(1))
844 && !self.mir.upvar_decls.is_empty() =>
847 .upvar_tys(def, self.tcx)
849 .for_each(|field| drop_field(self, field));
851 // Generators also have disjoint fields, but they are only
852 // directly accessed in the body of the generator.
853 ty::TyGenerator(def, substs, _)
854 if *drop_place == Place::Local(Local::new(1))
855 && !self.mir.upvar_decls.is_empty() =>
858 .upvar_tys(def, self.tcx)
860 .for_each(|field| drop_field(self, field));
863 // We have now refined the type of the value being
864 // dropped (potentially) to just the type of a
865 // subfield; so check whether that field's type still
866 // "needs drop". If so, we assume that the destructor
867 // may access any data it likes (i.e., a Deep Write).
868 if erased_drop_place_ty.needs_drop(gcx, self.param_env) {
870 ContextKind::Drop.new(loc),
872 (Deep, Write(WriteKind::StorageDeadOrDrop)),
873 LocalMutationIsAllowed::Yes,
881 /// Checks an access to the given place to see if it is allowed. Examines the set of borrows
882 /// that are in scope, as well as which paths have been initialized, to ensure that (a) the
883 /// place is initialized and (b) it is not borrowed in some way that would prevent this
886 /// Returns true if an error is reported, false otherwise.
890 place_span: (&Place<'tcx>, Span),
891 kind: (ShallowOrDeep, ReadOrWrite),
892 is_local_mutation_allowed: LocalMutationIsAllowed,
893 flow_state: &Flows<'cx, 'gcx, 'tcx>,
894 ) -> AccessErrorsReported {
897 if let Activation(_, borrow_index) = rw {
898 if self.reservation_error_reported.contains(&place_span.0) {
900 "skipping access_place for activation of invalid reservation \
901 place: {:?} borrow_index: {:?}",
902 place_span.0, borrow_index
904 return AccessErrorsReported {
905 mutability_error: false,
906 conflict_error: true,
912 .access_place_error_reported
913 .contains(&(place_span.0.clone(), place_span.1))
916 "access_place: suppressing error place_span=`{:?}` kind=`{:?}`",
919 return AccessErrorsReported {
920 mutability_error: false,
921 conflict_error: true,
925 let mutability_error =
926 self.check_access_permissions(place_span, rw, is_local_mutation_allowed, flow_state);
928 self.check_access_for_conflict(context, place_span, sd, rw, flow_state);
930 if conflict_error || mutability_error {
932 "access_place: logging error place_span=`{:?}` kind=`{:?}`",
935 self.access_place_error_reported
936 .insert((place_span.0.clone(), place_span.1));
939 AccessErrorsReported {
945 fn check_access_for_conflict(
948 place_span: (&Place<'tcx>, Span),
951 flow_state: &Flows<'cx, 'gcx, 'tcx>,
954 "check_access_for_conflict(context={:?}, place_span={:?}, sd={:?}, rw={:?})",
955 context, place_span, sd, rw,
958 let mut error_reported = false;
961 let location = self.location_table.start_index(context.loc);
962 let borrow_set = self.borrow_set.clone();
963 each_borrow_involving_path(
970 flow_state.borrows_in_scope(location),
971 |this, borrow_index, borrow| match (rw, borrow.kind) {
972 // Obviously an activation is compatible with its own
973 // reservation (or even prior activating uses of same
974 // borrow); so don't check if they interfere.
976 // NOTE: *reservations* do conflict with themselves;
977 // thus aren't injecting unsoundenss w/ this check.)
978 (Activation(_, activating), _) if activating == borrow_index => {
980 "check_access_for_conflict place_span: {:?} sd: {:?} rw: {:?} \
981 skipping {:?} b/c activation of same borrow_index",
985 (borrow_index, borrow),
990 (Read(_), BorrowKind::Shared) | (Reservation(..), BorrowKind::Shared) => {
994 (Read(kind), BorrowKind::Unique) | (Read(kind), BorrowKind::Mut { .. }) => {
995 // Reading from mere reservations of mutable-borrows is OK.
996 if !is_active(&this.dominators, borrow, context.loc) {
997 assert!(allow_two_phase_borrow(&this.tcx, borrow.kind));
998 return Control::Continue;
1003 error_reported = true;
1004 this.report_use_while_mutably_borrowed(context, place_span, borrow)
1006 ReadKind::Borrow(bk) => {
1007 error_reported = true;
1008 this.report_conflicting_borrow(context, place_span, bk, &borrow)
1014 (Reservation(kind), BorrowKind::Unique)
1015 | (Reservation(kind), BorrowKind::Mut { .. })
1016 | (Activation(kind, _), _)
1017 | (Write(kind), _) => {
1021 "recording invalid reservation of \
1025 this.reservation_error_reported.insert(place_span.0.clone());
1027 Activation(_, activating) => {
1029 "observing check_place for activation of \
1030 borrow_index: {:?}",
1034 Read(..) | Write(..) => {}
1038 WriteKind::MutableBorrow(bk) => {
1039 error_reported = true;
1040 this.report_conflicting_borrow(context, place_span, bk, &borrow)
1042 WriteKind::StorageDeadOrDrop => {
1043 error_reported = true;
1044 this.report_borrowed_value_does_not_live_long_enough(
1051 WriteKind::Mutate => {
1052 error_reported = true;
1053 this.report_illegal_mutation_of_borrowed(context, place_span, borrow)
1055 WriteKind::Move => {
1056 error_reported = true;
1057 this.report_move_out_while_borrowed(context, place_span, &borrow)
1071 place_span: (&Place<'tcx>, Span),
1072 kind: ShallowOrDeep,
1074 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1076 // Write of P[i] or *P, or WriteAndRead of any P, requires P init'd.
1078 MutateMode::WriteAndRead => {
1079 self.check_if_path_or_subpath_is_moved(
1081 InitializationRequiringAction::Update,
1086 MutateMode::JustWrite => {
1087 self.check_if_assigned_path_is_moved(context, place_span, flow_state);
1091 let errors_reported = self.access_place(
1094 (kind, Write(WriteKind::Mutate)),
1095 // We want immutable upvars to cause an "assignment to immutable var"
1096 // error, not an "reassignment of immutable var" error, because the
1097 // latter can't find a good previous assignment span.
1099 // There's probably a better way to do this.
1100 LocalMutationIsAllowed::ExceptUpvars,
1104 if !errors_reported.mutability_error {
1105 // check for reassignments to immutable local variables
1106 self.check_if_reassignment_to_immutable_state(context, place_span, flow_state);
1113 (rvalue, span): (&Rvalue<'tcx>, Span),
1114 _location: Location,
1115 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1118 Rvalue::Ref(_ /*rgn*/, bk, ref place) => {
1119 let access_kind = match bk {
1120 BorrowKind::Shared => (Deep, Read(ReadKind::Borrow(bk))),
1121 BorrowKind::Unique | BorrowKind::Mut { .. } => {
1122 let wk = WriteKind::MutableBorrow(bk);
1123 if allow_two_phase_borrow(&self.tcx, bk) {
1124 (Deep, Reservation(wk))
1135 LocalMutationIsAllowed::No,
1139 self.check_if_path_or_subpath_is_moved(
1141 InitializationRequiringAction::Borrow,
1147 Rvalue::Use(ref operand)
1148 | Rvalue::Repeat(ref operand, _)
1149 | Rvalue::UnaryOp(_ /*un_op*/, ref operand)
1150 | Rvalue::Cast(_ /*cast_kind*/, ref operand, _ /*ty*/) => {
1151 self.consume_operand(context, (operand, span), flow_state)
1154 Rvalue::Len(ref place) | Rvalue::Discriminant(ref place) => {
1155 let af = match *rvalue {
1156 Rvalue::Len(..) => ArtificialField::ArrayLength,
1157 Rvalue::Discriminant(..) => ArtificialField::Discriminant,
1158 _ => unreachable!(),
1163 (Shallow(Some(af)), Read(ReadKind::Copy)),
1164 LocalMutationIsAllowed::No,
1167 self.check_if_path_or_subpath_is_moved(
1169 InitializationRequiringAction::Use,
1175 Rvalue::BinaryOp(_bin_op, ref operand1, ref operand2)
1176 | Rvalue::CheckedBinaryOp(_bin_op, ref operand1, ref operand2) => {
1177 self.consume_operand(context, (operand1, span), flow_state);
1178 self.consume_operand(context, (operand2, span), flow_state);
1181 Rvalue::NullaryOp(_op, _ty) => {
1182 // nullary ops take no dynamic input; no borrowck effect.
1184 // FIXME: is above actually true? Do we want to track
1185 // the fact that uninitialized data can be created via
1189 Rvalue::Aggregate(ref aggregate_kind, ref operands) => {
1190 // We need to report back the list of mutable upvars that were
1191 // moved into the closure and subsequently used by the closure,
1192 // in order to populate our used_mut set.
1193 match **aggregate_kind {
1194 AggregateKind::Closure(def_id, _)
1195 | AggregateKind::Generator(def_id, _, _) => {
1196 let BorrowCheckResult {
1198 } = self.tcx.mir_borrowck(def_id);
1199 debug!("{:?} used_mut_upvars={:?}", def_id, used_mut_upvars);
1200 for field in used_mut_upvars {
1201 // This relies on the current way that by-value
1202 // captures of a closure are copied/moved directly
1203 // when generating MIR.
1204 match operands[field.index()] {
1205 Operand::Move(Place::Local(local))
1206 | Operand::Copy(Place::Local(local)) => {
1207 self.used_mut.insert(local);
1209 Operand::Move(ref place @ Place::Projection(_))
1210 | Operand::Copy(ref place @ Place::Projection(_)) => {
1211 if let Some(field) = self.is_upvar_field_projection(place) {
1212 self.used_mut_upvars.push(field);
1215 Operand::Move(Place::Static(..))
1216 | Operand::Copy(Place::Static(..))
1217 | Operand::Constant(..) => {}
1221 AggregateKind::Adt(..)
1222 | AggregateKind::Array(..)
1223 | AggregateKind::Tuple { .. } => (),
1226 for operand in operands {
1227 self.consume_operand(context, (operand, span), flow_state);
1236 (operand, span): (&Operand<'tcx>, Span),
1237 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1240 Operand::Copy(ref place) => {
1241 // copy of place: check if this is "copy of frozen path"
1242 // (FIXME: see check_loans.rs)
1246 (Deep, Read(ReadKind::Copy)),
1247 LocalMutationIsAllowed::No,
1251 // Finally, check if path was already moved.
1252 self.check_if_path_or_subpath_is_moved(
1254 InitializationRequiringAction::Use,
1259 Operand::Move(ref place) => {
1260 // move of place: check if this is move of already borrowed path
1264 (Deep, Write(WriteKind::Move)),
1265 LocalMutationIsAllowed::Yes,
1269 // Finally, check if path was already moved.
1270 self.check_if_path_or_subpath_is_moved(
1272 InitializationRequiringAction::Use,
1277 Operand::Constant(_) => {}
1281 /// Returns whether a borrow of this place is invalidated when the function
1283 fn check_for_invalidation_at_exit(
1286 borrow: &BorrowData<'tcx>,
1289 debug!("check_for_invalidation_at_exit({:?})", borrow);
1290 let place = &borrow.borrowed_place;
1291 let root_place = self.prefixes(place, PrefixSet::All).last().unwrap();
1293 // FIXME(nll-rfc#40): do more precise destructor tracking here. For now
1294 // we just know that all locals are dropped at function exit (otherwise
1295 // we'll have a memory leak) and assume that all statics have a destructor.
1297 // FIXME: allow thread-locals to borrow other thread locals?
1298 let (might_be_alive, will_be_dropped) = match root_place {
1299 Place::Static(statik) => {
1300 // Thread-locals might be dropped after the function exits, but
1301 // "true" statics will never be.
1302 let is_thread_local = self
1304 .get_attrs(statik.def_id)
1306 .any(|attr| attr.check_name("thread_local"));
1308 (true, is_thread_local)
1310 Place::Local(_) => {
1311 // Locals are always dropped at function exit, and if they
1312 // have a destructor it would've been called already.
1313 (false, self.locals_are_invalidated_at_exit)
1315 Place::Projection(..) => {
1316 bug!("root of {:?} is a projection ({:?})?", place, root_place)
1320 if !will_be_dropped {
1322 "place_is_invalidated_at_exit({:?}) - won't be dropped",
1328 // FIXME: replace this with a proper borrow_conflicts_with_place when
1330 let sd = if might_be_alive { Deep } else { Shallow(None) };
1332 if places_conflict::places_conflict(self.tcx, self.mir, place, root_place, sd) {
1333 debug!("check_for_invalidation_at_exit({:?}): INVALID", place);
1334 // FIXME: should be talking about the region lifetime instead
1335 // of just a span here.
1336 let span = self.tcx.sess.codemap().end_point(span);
1337 self.report_borrowed_value_does_not_live_long_enough(
1346 /// Reports an error if this is a borrow of local data.
1347 /// This is called for all Yield statements on movable generators
1348 fn check_for_local_borrow(&mut self, borrow: &BorrowData<'tcx>, yield_span: Span) {
1349 debug!("check_for_local_borrow({:?})", borrow);
1351 if borrow_of_local_data(&borrow.borrowed_place) {
1353 .cannot_borrow_across_generator_yield(
1354 self.retrieve_borrow_span(borrow),
1362 fn check_activations(
1366 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1368 if !self.tcx.two_phase_borrows() {
1372 // Two-phase borrow support: For each activation that is newly
1373 // generated at this statement, check if it interferes with
1375 let borrow_set = self.borrow_set.clone();
1376 for &borrow_index in borrow_set.activations_at_location(location) {
1377 let borrow = &borrow_set[borrow_index];
1379 // only mutable borrows should be 2-phase
1380 assert!(match borrow.kind {
1381 BorrowKind::Shared => false,
1382 BorrowKind::Unique | BorrowKind::Mut { .. } => true,
1386 ContextKind::Activation.new(location),
1387 (&borrow.borrowed_place, span),
1390 Activation(WriteKind::MutableBorrow(borrow.kind), borrow_index),
1392 LocalMutationIsAllowed::No,
1395 // We do not need to call `check_if_path_or_subpath_is_moved`
1396 // again, as we already called it when we made the
1397 // initial reservation.
1402 impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
1403 fn check_if_reassignment_to_immutable_state(
1406 (place, span): (&Place<'tcx>, Span),
1407 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1409 debug!("check_if_reassignment_to_immutable_state({:?})", place);
1410 // determine if this path has a non-mut owner (and thus needs checking).
1411 let err_place = match self.is_mutable(place, LocalMutationIsAllowed::No) {
1413 Err(place) => place,
1416 "check_if_reassignment_to_immutable_state({:?}) - is an imm local",
1420 for i in flow_state.ever_inits.iter_incoming() {
1421 let init = self.move_data.inits[i];
1422 let init_place = &self.move_data.move_paths[init.path].place;
1423 if places_conflict::places_conflict(self.tcx, self.mir, &init_place, place, Deep) {
1424 self.report_illegal_reassignment(context, (place, span), init.span, err_place);
1430 fn check_if_full_path_is_moved(
1433 desired_action: InitializationRequiringAction,
1434 place_span: (&Place<'tcx>, Span),
1435 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1437 // FIXME: analogous code in check_loans first maps `place` to
1438 // its base_path ... but is that what we want here?
1439 let place = self.base_path(place_span.0);
1441 let maybe_uninits = &flow_state.uninits;
1442 let curr_move_outs = &flow_state.move_outs;
1446 // 1. Move of `a.b.c`, use of `a.b.c`
1447 // 2. Move of `a.b.c`, use of `a.b.c.d` (without first reinitializing `a.b.c.d`)
1448 // 3. Uninitialized `(a.b.c: &_)`, use of `*a.b.c`; note that with
1449 // partial initialization support, one might have `a.x`
1450 // initialized but not `a.b`.
1454 // 4. Move of `a.b.c`, use of `a.b.d`
1455 // 5. Uninitialized `a.x`, initialized `a.b`, use of `a.b`
1456 // 6. Copied `(a.b: &_)`, use of `*(a.b).c`; note that `a.b`
1457 // must have been initialized for the use to be sound.
1458 // 7. Move of `a.b.c` then reinit of `a.b.c.d`, use of `a.b.c.d`
1460 // The dataflow tracks shallow prefixes distinctly (that is,
1461 // field-accesses on P distinctly from P itself), in order to
1462 // track substructure initialization separately from the whole
1465 // E.g., when looking at (*a.b.c).d, if the closest prefix for
1466 // which we have a MovePath is `a.b`, then that means that the
1467 // initialization state of `a.b` is all we need to inspect to
1468 // know if `a.b.c` is valid (and from that we infer that the
1469 // dereference and `.d` access is also valid, since we assume
1470 // `a.b.c` is assigned a reference to a initialized and
1471 // well-formed record structure.)
1473 // Therefore, if we seek out the *closest* prefix for which we
1474 // have a MovePath, that should capture the initialization
1475 // state for the place scenario.
1477 // This code covers scenarios 1, 2, and 3.
1479 debug!("check_if_full_path_is_moved place: {:?}", place);
1480 match self.move_path_closest_to(place) {
1482 if maybe_uninits.contains(&mpi) {
1483 self.report_use_of_moved_or_uninitialized(
1490 return; // don't bother finding other problems.
1493 Err(NoMovePathFound::ReachedStatic) => {
1494 // Okay: we do not build MoveData for static variables
1495 } // Only query longest prefix with a MovePath, not further
1496 // ancestors; dataflow recurs on children when parents
1497 // move (to support partial (re)inits).
1499 // (I.e. querying parents breaks scenario 7; but may want
1500 // to do such a query based on partial-init feature-gate.)
1504 fn check_if_path_or_subpath_is_moved(
1507 desired_action: InitializationRequiringAction,
1508 place_span: (&Place<'tcx>, Span),
1509 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1511 // FIXME: analogous code in check_loans first maps `place` to
1512 // its base_path ... but is that what we want here?
1513 let place = self.base_path(place_span.0);
1515 let maybe_uninits = &flow_state.uninits;
1516 let curr_move_outs = &flow_state.move_outs;
1520 // 1. Move of `a.b.c`, use of `a` or `a.b`
1521 // partial initialization support, one might have `a.x`
1522 // initialized but not `a.b`.
1523 // 2. All bad scenarios from `check_if_full_path_is_moved`
1527 // 3. Move of `a.b.c`, use of `a.b.d`
1528 // 4. Uninitialized `a.x`, initialized `a.b`, use of `a.b`
1529 // 5. Copied `(a.b: &_)`, use of `*(a.b).c`; note that `a.b`
1530 // must have been initialized for the use to be sound.
1531 // 6. Move of `a.b.c` then reinit of `a.b.c.d`, use of `a.b.c.d`
1533 self.check_if_full_path_is_moved(context, desired_action, place_span, flow_state);
1535 // A move of any shallow suffix of `place` also interferes
1536 // with an attempt to use `place`. This is scenario 3 above.
1538 // (Distinct from handling of scenarios 1+2+4 above because
1539 // `place` does not interfere with suffixes of its prefixes,
1540 // e.g. `a.b.c` does not interfere with `a.b.d`)
1542 // This code covers scenario 1.
1544 debug!("check_if_path_or_subpath_is_moved place: {:?}", place);
1545 if let Some(mpi) = self.move_path_for_place(place) {
1546 if let Some(child_mpi) = maybe_uninits.has_any_child_of(mpi) {
1547 self.report_use_of_moved_or_uninitialized(
1554 return; // don't bother finding other problems.
1559 /// Currently MoveData does not store entries for all places in
1560 /// the input MIR. For example it will currently filter out
1561 /// places that are Copy; thus we do not track places of shared
1562 /// reference type. This routine will walk up a place along its
1563 /// prefixes, searching for a foundational place that *is*
1564 /// tracked in the MoveData.
1566 /// An Err result includes a tag indicated why the search failed.
1567 /// Currently this can only occur if the place is built off of a
1568 /// static variable, as we do not track those in the MoveData.
1569 fn move_path_closest_to(
1571 place: &Place<'tcx>,
1572 ) -> Result<MovePathIndex, NoMovePathFound> {
1573 let mut last_prefix = place;
1574 for prefix in self.prefixes(place, PrefixSet::All) {
1575 if let Some(mpi) = self.move_path_for_place(prefix) {
1578 last_prefix = prefix;
1580 match *last_prefix {
1581 Place::Local(_) => panic!("should have move path for every Local"),
1582 Place::Projection(_) => panic!("PrefixSet::All meant don't stop for Projection"),
1583 Place::Static(_) => return Err(NoMovePathFound::ReachedStatic),
1587 fn move_path_for_place(&mut self, place: &Place<'tcx>) -> Option<MovePathIndex> {
1588 // If returns None, then there is no move path corresponding
1589 // to a direct owner of `place` (which means there is nothing
1590 // that borrowck tracks for its analysis).
1592 match self.move_data.rev_lookup.find(place) {
1593 LookupResult::Parent(_) => None,
1594 LookupResult::Exact(mpi) => Some(mpi),
1598 fn check_if_assigned_path_is_moved(
1601 (place, span): (&Place<'tcx>, Span),
1602 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1604 debug!("check_if_assigned_path_is_moved place: {:?}", place);
1605 // recur down place; dispatch to external checks when necessary
1606 let mut place = place;
1609 Place::Local(_) | Place::Static(_) => {
1610 // assigning to `x` does not require `x` be initialized.
1613 Place::Projection(ref proj) => {
1614 let Projection { ref base, ref elem } = **proj;
1616 ProjectionElem::Index(_/*operand*/) |
1617 ProjectionElem::ConstantIndex { .. } |
1618 // assigning to P[i] requires P to be valid.
1619 ProjectionElem::Downcast(_/*adt_def*/, _/*variant_idx*/) =>
1620 // assigning to (P->variant) is okay if assigning to `P` is okay
1622 // FIXME: is this true even if P is a adt with a dtor?
1625 // assigning to (*P) requires P to be initialized
1626 ProjectionElem::Deref => {
1627 self.check_if_full_path_is_moved(
1628 context, InitializationRequiringAction::Use,
1629 (base, span), flow_state);
1630 // (base initialized; no need to
1635 ProjectionElem::Subslice { .. } => {
1636 panic!("we don't allow assignments to subslices, context: {:?}",
1640 ProjectionElem::Field(..) => {
1641 // if type of `P` has a dtor, then
1642 // assigning to `P.f` requires `P` itself
1643 // be already initialized
1645 match base.ty(self.mir, tcx).to_ty(tcx).sty {
1646 ty::TyAdt(def, _) if def.has_dtor(tcx) => {
1648 // FIXME: analogous code in
1649 // check_loans.rs first maps
1650 // `base` to its base_path.
1652 self.check_if_path_or_subpath_is_moved(
1653 context, InitializationRequiringAction::Assignment,
1654 (base, span), flow_state);
1656 // (base initialized; no need to
1672 /// Check the permissions for the given place and read or write kind
1674 /// Returns true if an error is reported, false otherwise.
1675 fn check_access_permissions(
1677 (place, span): (&Place<'tcx>, Span),
1679 is_local_mutation_allowed: LocalMutationIsAllowed,
1680 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1683 "check_access_permissions({:?}, {:?}, {:?})",
1684 place, kind, is_local_mutation_allowed
1687 #[derive(Copy, Clone, Debug)]
1696 Reservation(WriteKind::MutableBorrow(borrow_kind @ BorrowKind::Unique))
1697 | Reservation(WriteKind::MutableBorrow(borrow_kind @ BorrowKind::Mut { .. }))
1698 | Write(WriteKind::MutableBorrow(borrow_kind @ BorrowKind::Unique))
1699 | Write(WriteKind::MutableBorrow(borrow_kind @ BorrowKind::Mut { .. })) => {
1700 let is_local_mutation_allowed = match borrow_kind {
1701 BorrowKind::Unique => LocalMutationIsAllowed::Yes,
1702 BorrowKind::Mut { .. } => is_local_mutation_allowed,
1703 BorrowKind::Shared => unreachable!(),
1705 match self.is_mutable(place, is_local_mutation_allowed) {
1707 self.add_used_mut(root_place, flow_state);
1711 error_access = AccessKind::MutableBorrow;
1712 the_place_err = place_err;
1716 Reservation(WriteKind::Mutate) | Write(WriteKind::Mutate) => {
1717 match self.is_mutable(place, is_local_mutation_allowed) {
1719 self.add_used_mut(root_place, flow_state);
1723 error_access = AccessKind::Mutate;
1724 the_place_err = place_err;
1729 Reservation(WriteKind::Move)
1730 | Write(WriteKind::Move)
1731 | Reservation(WriteKind::StorageDeadOrDrop)
1732 | Reservation(WriteKind::MutableBorrow(BorrowKind::Shared))
1733 | Write(WriteKind::StorageDeadOrDrop)
1734 | Write(WriteKind::MutableBorrow(BorrowKind::Shared)) => {
1735 if let Err(_place_err) = self.is_mutable(place, is_local_mutation_allowed) {
1736 self.tcx.sess.delay_span_bug(
1739 "Accessing `{:?}` with the kind `{:?}` shouldn't be possible",
1747 // permission checks are done at Reservation point.
1750 Read(ReadKind::Borrow(BorrowKind::Unique))
1751 | Read(ReadKind::Borrow(BorrowKind::Mut { .. }))
1752 | Read(ReadKind::Borrow(BorrowKind::Shared))
1753 | Read(ReadKind::Copy) => {
1754 // Access authorized
1759 // at this point, we have set up the error reporting state.
1762 let item_msg = match self.describe_place(place) {
1763 Some(name) => format!("immutable item `{}`", name),
1764 None => "immutable item".to_owned(),
1767 // `act` and `acted_on` are strings that let us abstract over
1768 // the verbs used in some diagnostic messages.
1772 match error_access {
1773 AccessKind::Mutate => {
1774 let item_msg = match the_place_err {
1775 Place::Projection(box Projection {
1777 elem: ProjectionElem::Deref,
1778 }) => match self.describe_place(place) {
1779 Some(description) => {
1780 format!("`{}` which is behind a `&` reference", description)
1782 None => format!("data in a `&` reference"),
1786 err = self.tcx.cannot_assign(span, &item_msg, Origin::Mir);
1788 acted_on = "written";
1790 AccessKind::MutableBorrow => {
1793 .cannot_borrow_path_as_mutable(span, &item_msg, Origin::Mir);
1794 act = "borrow as mutable";
1795 acted_on = "borrowed as mutable";
1799 match the_place_err {
1800 // We want to suggest users use `let mut` for local (user
1801 // variable) mutations...
1802 Place::Local(local) if self.mir.local_decls[*local].can_be_made_mutable() => {
1803 // ... but it doesn't make sense to suggest it on
1804 // variables that are `ref x`, `ref mut x`, `&self`,
1805 // or `&mut self` (such variables are simply not
1807 let local_decl = &self.mir.local_decls[*local];
1808 assert_eq!(local_decl.mutability, Mutability::Not);
1810 err.span_label(span, format!("cannot {ACT}", ACT = act));
1811 err.span_suggestion(
1812 local_decl.source_info.span,
1813 "consider changing this to be mutable",
1814 format!("mut {}", local_decl.name.unwrap()),
1818 // complete hack to approximate old AST-borrowck
1819 // diagnostic: if the span starts with a mutable borrow of
1820 // a local variable, then just suggest the user remove it.
1823 if let Ok(snippet) = self.tcx.sess.codemap().span_to_snippet(span) {
1824 snippet.starts_with("&mut ")
1830 err.span_label(span, format!("cannot {ACT}", ACT = act));
1831 err.span_label(span, "try removing `&mut` here");
1834 // We want to point out when a `&` can be readily replaced
1837 // FIXME: can this case be generalized to work for an
1838 // arbitrary base for the projection?
1839 Place::Projection(box Projection {
1840 base: Place::Local(local),
1841 elem: ProjectionElem::Deref,
1842 }) if self.mir.local_decls[*local].is_user_variable.is_some() => {
1843 let local_decl = &self.mir.local_decls[*local];
1844 let suggestion = match local_decl.is_user_variable.as_ref().unwrap() {
1845 ClearCrossCrate::Set(mir::BindingForm::ImplicitSelf) => {
1846 Some(suggest_ampmut_self(local_decl))
1849 ClearCrossCrate::Set(mir::BindingForm::Var(mir::VarBindingForm {
1850 binding_mode: ty::BindingMode::BindByValue(_),
1853 })) => Some(suggest_ampmut(
1861 ClearCrossCrate::Set(mir::BindingForm::Var(mir::VarBindingForm {
1862 binding_mode: ty::BindingMode::BindByReference(_),
1864 })) => suggest_ref_mut(self.tcx, local_decl),
1866 ClearCrossCrate::Clear => bug!("saw cleared local state"),
1869 if let Some((err_help_span, suggested_code)) = suggestion {
1870 err.span_suggestion(
1872 "consider changing this to be a mutable reference",
1877 if let Some(name) = local_decl.name {
1881 "`{NAME}` is a `&` reference, \
1882 so the data it refers to cannot be {ACTED_ON}",
1890 format!("cannot {ACT} through `&`-reference", ACT = act),
1896 err.span_label(span, format!("cannot {ACT}", ACT = act));
1903 fn suggest_ampmut_self<'cx, 'gcx, 'tcx>(
1904 local_decl: &mir::LocalDecl<'tcx>,
1905 ) -> (Span, String) {
1906 (local_decl.source_info.span, "&mut self".to_string())
1909 // When we want to suggest a user change a local variable to be a `&mut`, there
1910 // are three potential "obvious" things to highlight:
1912 // let ident [: Type] [= RightHandSideExpression];
1913 // ^^^^^ ^^^^ ^^^^^^^^^^^^^^^^^^^^^^^
1916 // We can always fallback on highlighting the first. But chances are good that
1917 // the user experience will be better if we highlight one of the others if possible;
1918 // for example, if the RHS is present and the Type is not, then the type is going to
1919 // be inferred *from* the RHS, which means we should highlight that (and suggest
1920 // that they borrow the RHS mutably).
1922 // This implementation attempts to emulate AST-borrowck prioritization
1923 // by trying (3.), then (2.) and finally falling back on (1.).
1924 fn suggest_ampmut<'cx, 'gcx, 'tcx>(
1925 tcx: TyCtxt<'cx, 'gcx, 'tcx>,
1928 local_decl: &mir::LocalDecl<'tcx>,
1929 opt_ty_info: Option<Span>,
1930 ) -> (Span, String) {
1931 let locations = mir.find_assignments(local);
1932 if locations.len() > 0 {
1933 let assignment_rhs_span = mir.source_info(locations[0]).span;
1934 let snippet = tcx.sess.codemap().span_to_snippet(assignment_rhs_span);
1935 if let Ok(src) = snippet {
1936 if src.starts_with('&') {
1937 let borrowed_expr = src[1..].to_string();
1939 assignment_rhs_span,
1940 format!("&mut {}", borrowed_expr),
1946 let highlight_span = match opt_ty_info {
1947 // if this is a variable binding with an explicit type,
1948 // try to highlight that for the suggestion.
1949 Some(ty_span) => ty_span,
1951 // otherwise, just highlight the span associated with
1952 // the (MIR) LocalDecl.
1953 None => local_decl.source_info.span,
1956 let ty_mut = local_decl.ty.builtin_deref(true).unwrap();
1957 assert_eq!(ty_mut.mutbl, hir::MutImmutable);
1958 (highlight_span, format!("&mut {}", ty_mut.ty))
1961 fn suggest_ref_mut<'cx, 'gcx, 'tcx>(
1962 tcx: TyCtxt<'cx, 'gcx, 'tcx>,
1963 local_decl: &mir::LocalDecl<'tcx>,
1964 ) -> Option<(Span, String)> {
1965 let hi_span = local_decl.source_info.span;
1966 let hi_src = tcx.sess.codemap().span_to_snippet(hi_span).unwrap();
1967 if hi_src.starts_with("ref")
1968 && hi_src["ref".len()..].starts_with(Pattern_White_Space)
1970 let suggestion = format!("ref mut{}", &hi_src["ref".len()..]);
1971 Some((hi_span, suggestion))
1978 /// Adds the place into the used mutable variables set
1979 fn add_used_mut<'d>(
1981 root_place: RootPlace<'d, 'tcx>,
1982 flow_state: &Flows<'cx, 'gcx, 'tcx>,
1986 place: Place::Local(local),
1987 is_local_mutation_allowed,
1989 if is_local_mutation_allowed != LocalMutationIsAllowed::Yes {
1990 // If the local may be initialized, and it is now currently being
1991 // mutated, then it is justified to be annotated with the `mut`
1992 // keyword, since the mutation may be a possible reassignment.
1993 let mpi = self.move_data.rev_lookup.find_local(*local);
1994 let ii = &self.move_data.init_path_map[mpi];
1996 if flow_state.ever_inits.contains(index) {
1997 self.used_mut.insert(*local);
2005 is_local_mutation_allowed: LocalMutationIsAllowed::Yes,
2008 place: place @ Place::Projection(_),
2009 is_local_mutation_allowed: _,
2011 if let Some(field) = self.is_upvar_field_projection(&place) {
2012 self.used_mut_upvars.push(field);
2016 place: Place::Static(..),
2017 is_local_mutation_allowed: _,
2022 /// Whether this value be written or borrowed mutably.
2023 /// Returns the root place if the place passed in is a projection.
2026 place: &'d Place<'tcx>,
2027 is_local_mutation_allowed: LocalMutationIsAllowed,
2028 ) -> Result<RootPlace<'d, 'tcx>, &'d Place<'tcx>> {
2030 Place::Local(local) => {
2031 let local = &self.mir.local_decls[local];
2032 match local.mutability {
2033 Mutability::Not => match is_local_mutation_allowed {
2034 LocalMutationIsAllowed::Yes => Ok(RootPlace {
2036 is_local_mutation_allowed: LocalMutationIsAllowed::Yes,
2038 LocalMutationIsAllowed::ExceptUpvars => Ok(RootPlace {
2040 is_local_mutation_allowed: LocalMutationIsAllowed::ExceptUpvars,
2042 LocalMutationIsAllowed::No => Err(place),
2044 Mutability::Mut => Ok(RootPlace {
2046 is_local_mutation_allowed,
2050 Place::Static(ref static_) => {
2051 if self.tcx.is_static(static_.def_id) != Some(hir::Mutability::MutMutable) {
2056 is_local_mutation_allowed,
2060 Place::Projection(ref proj) => {
2062 ProjectionElem::Deref => {
2063 let base_ty = proj.base.ty(self.mir, self.tcx).to_ty(self.tcx);
2065 // Check the kind of deref to decide
2067 ty::TyRef(_, _, mutbl) => {
2069 // Shared borrowed data is never mutable
2070 hir::MutImmutable => Err(place),
2071 // Mutably borrowed data is mutable, but only if we have a
2072 // unique path to the `&mut`
2073 hir::MutMutable => {
2074 let mode = match self.is_upvar_field_projection(&proj.base)
2078 self.mir.upvar_decls[field.index()].by_ref
2081 is_local_mutation_allowed
2083 _ => LocalMutationIsAllowed::Yes,
2086 self.is_mutable(&proj.base, mode)
2090 ty::TyRawPtr(tnm) => {
2092 // `*const` raw pointers are not mutable
2093 hir::MutImmutable => return Err(place),
2094 // `*mut` raw pointers are always mutable, regardless of
2095 // context. The users have to check by themselves.
2096 hir::MutMutable => {
2097 return Ok(RootPlace {
2099 is_local_mutation_allowed,
2104 // `Box<T>` owns its content, so mutable if its location is mutable
2105 _ if base_ty.is_box() => {
2106 self.is_mutable(&proj.base, is_local_mutation_allowed)
2108 // Deref should only be for reference, pointers or boxes
2109 _ => bug!("Deref of unexpected type: {:?}", base_ty),
2112 // All other projections are owned by their base path, so mutable if
2113 // base path is mutable
2114 ProjectionElem::Field(..)
2115 | ProjectionElem::Index(..)
2116 | ProjectionElem::ConstantIndex { .. }
2117 | ProjectionElem::Subslice { .. }
2118 | ProjectionElem::Downcast(..) => {
2119 if let Some(field) = self.is_upvar_field_projection(place) {
2120 let decl = &self.mir.upvar_decls[field.index()];
2122 "decl.mutability={:?} local_mutation_is_allowed={:?} place={:?}",
2123 decl, is_local_mutation_allowed, place
2125 match (decl.mutability, is_local_mutation_allowed) {
2126 (Mutability::Not, LocalMutationIsAllowed::No)
2127 | (Mutability::Not, LocalMutationIsAllowed::ExceptUpvars) => {
2130 (Mutability::Not, LocalMutationIsAllowed::Yes)
2131 | (Mutability::Mut, _) => {
2132 // Subtle: this is an upvar
2133 // reference, so it looks like
2134 // `self.foo` -- we want to double
2135 // check that the context `*self`
2136 // is mutable (i.e., this is not a
2137 // `Fn` closure). But if that
2138 // check succeeds, we want to
2139 // *blame* the mutability on
2140 // `place` (that is,
2141 // `self.foo`). This is used to
2142 // propagate the info about
2143 // whether mutability declarations
2144 // are used outwards, so that we register
2145 // the outer variable as mutable. Otherwise a
2146 // test like this fails to record the `mut`
2150 // fn foo<F: FnOnce()>(_f: F) { }
2152 // let var = Vec::new();
2158 let _ = self.is_mutable(&proj.base, is_local_mutation_allowed)?;
2161 is_local_mutation_allowed,
2166 self.is_mutable(&proj.base, is_local_mutation_allowed)
2174 /// If this is a field projection, and the field is being projected from a closure type,
2175 /// then returns the index of the field being projected. Note that this closure will always
2176 /// be `self` in the current MIR, because that is the only time we directly access the fields
2177 /// of a closure type.
2178 fn is_upvar_field_projection(&self, place: &Place<'tcx>) -> Option<Field> {
2180 Place::Projection(ref proj) => match proj.elem {
2181 ProjectionElem::Field(field, _ty) => {
2182 let base_ty = proj.base.ty(self.mir, self.tcx).to_ty(self.tcx);
2184 if base_ty.is_closure() || base_ty.is_generator() {
2197 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
2198 enum NoMovePathFound {
2202 /// The degree of overlap between 2 places for borrow-checking.
2204 /// The places might partially overlap - in this case, we give
2205 /// up and say that they might conflict. This occurs when
2206 /// different fields of a union are borrowed. For example,
2207 /// if `u` is a union, we have no way of telling how disjoint
2208 /// `u.a.x` and `a.b.y` are.
2210 /// The places have the same type, and are either completely disjoint
2211 /// or equal - i.e. they can't "partially" overlap as can occur with
2212 /// unions. This is the "base case" on which we recur for extensions
2215 /// The places are disjoint, so we know all extensions of them
2216 /// will also be disjoint.
2220 impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
2221 // FIXME (#16118): function intended to allow the borrow checker
2222 // to be less precise in its handling of Box while still allowing
2223 // moves out of a Box. They should be removed when/if we stop
2224 // treating Box specially (e.g. when/if DerefMove is added...)
2226 fn base_path<'d>(&self, place: &'d Place<'tcx>) -> &'d Place<'tcx> {
2227 //! Returns the base of the leftmost (deepest) dereference of an
2228 //! Box in `place`. If there is no dereference of an Box
2229 //! in `place`, then it just returns `place` itself.
2231 let mut cursor = place;
2232 let mut deepest = place;
2234 let proj = match *cursor {
2235 Place::Local(..) | Place::Static(..) => return deepest,
2236 Place::Projection(ref proj) => proj,
2238 if proj.elem == ProjectionElem::Deref
2239 && place.ty(self.mir, self.tcx).to_ty(self.tcx).is_box()
2241 deepest = &proj.base;
2243 cursor = &proj.base;
2248 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
2254 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
2274 fn new(self, loc: Location) -> Context {