2 self, AggregateKind, BindingForm, BorrowKind, ClearCrossCrate, ConstraintCategory,
3 FakeReadCause, Local, LocalDecl, LocalInfo, LocalKind, Location, Operand, Place, PlaceRef,
4 ProjectionElem, Rvalue, Statement, StatementKind, TerminatorKind, VarBindingForm,
6 use rustc::ty::{self, Ty};
7 use rustc_data_structures::fx::FxHashSet;
8 use rustc_errors::{Applicability, DiagnosticBuilder};
10 use rustc_hir::def_id::DefId;
11 use rustc_hir::{AsyncGeneratorKind, GeneratorKind};
12 use rustc_index::vec::Idx;
13 use rustc_infer::traits::error_reporting::suggest_constraining_type_param;
14 use rustc_span::source_map::DesugaringKind;
17 use crate::dataflow::drop_flag_effects;
18 use crate::dataflow::indexes::{MoveOutIndex, MovePathIndex};
19 use crate::util::borrowck_errors;
21 use crate::borrow_check::{
22 borrow_set::BorrowData, prefixes::IsPrefixOf, InitializationRequiringAction, MirBorrowckCtxt,
27 explain_borrow::BorrowExplanation, IncludingDowncast, RegionName, RegionNameSource, UseSpans,
32 /// Index of the "move out" that we found. The `MoveData` can
33 /// then tell us where the move occurred.
36 /// `true` if we traversed a back edge while walking from the point
37 /// of error to the move site.
38 traversed_back_edge: bool,
41 /// Which case a StorageDeadOrDrop is for.
42 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
43 enum StorageDeadOrDrop<'tcx> {
49 impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {
50 pub(in crate::borrow_check) fn report_use_of_moved_or_uninitialized(
53 desired_action: InitializationRequiringAction,
54 (moved_place, used_place, span): (PlaceRef<'cx, 'tcx>, PlaceRef<'cx, 'tcx>, Span),
58 "report_use_of_moved_or_uninitialized: location={:?} desired_action={:?} \
59 moved_place={:?} used_place={:?} span={:?} mpi={:?}",
60 location, desired_action, moved_place, used_place, span, mpi
64 self.move_spans(moved_place, location).or_else(|| self.borrow_spans(span, location));
65 let span = use_spans.args_or_use();
67 let move_site_vec = self.get_moved_indexes(location, mpi);
68 debug!("report_use_of_moved_or_uninitialized: move_site_vec={:?}", move_site_vec);
69 let move_out_indices: Vec<_> =
70 move_site_vec.iter().map(|move_site| move_site.moi).collect();
72 if move_out_indices.is_empty() {
73 let root_place = PlaceRef { projection: &[], ..used_place };
75 if !self.uninitialized_error_reported.insert(root_place) {
77 "report_use_of_moved_or_uninitialized place: error about {:?} suppressed",
84 match self.describe_place_with_options(used_place, IncludingDowncast(true)) {
85 Some(name) => format!("`{}`", name),
86 None => "value".to_owned(),
88 let mut err = self.cannot_act_on_uninitialized_variable(
90 desired_action.as_noun(),
92 .describe_place_with_options(moved_place, IncludingDowncast(true))
93 .unwrap_or_else(|| "_".to_owned()),
95 err.span_label(span, format!("use of possibly-uninitialized {}", item_msg));
97 use_spans.var_span_label(
99 format!("{} occurs due to use{}", desired_action.as_noun(), use_spans.describe()),
102 err.buffer(&mut self.errors_buffer);
104 if let Some((reported_place, _)) = self.move_error_reported.get(&move_out_indices) {
105 if self.prefixes(*reported_place, PrefixSet::All).any(|p| p == used_place) {
107 "report_use_of_moved_or_uninitialized place: error suppressed \
115 let msg = ""; //FIXME: add "partially " or "collaterally "
117 let mut err = self.cannot_act_on_moved_value(
119 desired_action.as_noun(),
121 self.describe_place_with_options(moved_place, IncludingDowncast(true)),
124 self.add_moved_or_invoked_closure_note(location, used_place, &mut err);
126 let mut is_loop_move = false;
127 let is_partial_move = move_site_vec.iter().any(|move_site| {
128 let move_out = self.move_data.moves[(*move_site).moi];
129 let moved_place = &self.move_data.move_paths[move_out.path].place;
130 used_place != moved_place.as_ref() && used_place.is_prefix_of(moved_place.as_ref())
132 for move_site in &move_site_vec {
133 let move_out = self.move_data.moves[(*move_site).moi];
134 let moved_place = &self.move_data.move_paths[move_out.path].place;
136 let move_spans = self.move_spans(moved_place.as_ref(), move_out.source);
137 let move_span = move_spans.args_or_use();
139 let move_msg = if move_spans.for_closure() { " into closure" } else { "" };
141 if span == move_span {
144 format!("value moved{} here, in previous iteration of loop", move_msg),
147 } else if move_site.traversed_back_edge {
150 format!("value moved{} here, in previous iteration of loop", move_msg),
153 err.span_label(move_span, format!("value moved{} here", move_msg));
154 move_spans.var_span_label(
156 format!("variable moved due to use{}", move_spans.describe()),
159 if Some(DesugaringKind::ForLoop) == move_span.desugaring_kind() {
160 let sess = self.infcx.tcx.sess;
161 if let Ok(snippet) = sess.source_map().span_to_snippet(move_span) {
164 "consider borrowing to avoid moving into the for loop",
165 format!("&{}", snippet),
166 Applicability::MaybeIncorrect,
172 use_spans.var_span_label(
174 format!("{} occurs due to use{}", desired_action.as_noun(), use_spans.describe()),
182 desired_action.as_verb_in_past_tense(),
183 if is_partial_move { "after partial move" } else { "after move" },
189 Place::ty_from(used_place.local, used_place.projection, *self.body, self.infcx.tcx)
191 let needs_note = match ty.kind {
192 ty::Closure(id, _) => {
193 let tables = self.infcx.tcx.typeck_tables_of(id);
194 let hir_id = self.infcx.tcx.hir().as_local_hir_id(id).unwrap();
196 tables.closure_kind_origins().get(hir_id).is_none()
202 let mpi = self.move_data.moves[move_out_indices[0]].path;
203 let place = &self.move_data.move_paths[mpi].place;
205 let ty = place.ty(*self.body, self.infcx.tcx).ty;
207 self.describe_place_with_options(place.as_ref(), IncludingDowncast(true));
208 let note_msg = match opt_name {
209 Some(ref name) => format!("`{}`", name),
210 None => "value".to_owned(),
212 if let ty::Param(param_ty) = ty.kind {
213 let tcx = self.infcx.tcx;
214 let generics = tcx.generics_of(self.mir_def_id);
215 let param = generics.type_param(¶m_ty, tcx);
216 if let Some(generics) =
217 tcx.hir().get_generics(tcx.closure_base_def_id(self.mir_def_id))
219 suggest_constraining_type_param(
223 ¶m.name.as_str(),
225 tcx.sess.source_map(),
231 let span = if let Some(local) = place.as_local() {
232 let decl = &self.body.local_decls[local];
233 Some(decl.source_info.span)
237 self.note_type_does_not_implement_copy(&mut err, ¬e_msg, ty, span);
240 if let Some((_, mut old_err)) =
241 self.move_error_reported.insert(move_out_indices, (used_place, err))
243 // Cancel the old error so it doesn't ICE.
249 pub(in crate::borrow_check) fn report_move_out_while_borrowed(
252 (place, span): (&Place<'tcx>, Span),
253 borrow: &BorrowData<'tcx>,
256 "report_move_out_while_borrowed: location={:?} place={:?} span={:?} borrow={:?}",
257 location, place, span, borrow
259 let value_msg = match self.describe_place(place.as_ref()) {
260 Some(name) => format!("`{}`", name),
261 None => "value".to_owned(),
263 let borrow_msg = match self.describe_place(borrow.borrowed_place.as_ref()) {
264 Some(name) => format!("`{}`", name),
265 None => "value".to_owned(),
268 let borrow_spans = self.retrieve_borrow_spans(borrow);
269 let borrow_span = borrow_spans.args_or_use();
271 let move_spans = self.move_spans(place.as_ref(), location);
272 let span = move_spans.args_or_use();
274 let mut err = self.cannot_move_when_borrowed(
276 &self.describe_place(place.as_ref()).unwrap_or_else(|| "_".to_owned()),
278 err.span_label(borrow_span, format!("borrow of {} occurs here", borrow_msg));
279 err.span_label(span, format!("move out of {} occurs here", value_msg));
281 borrow_spans.var_span_label(
283 format!("borrow occurs due to use{}", borrow_spans.describe()),
287 .var_span_label(&mut err, format!("move occurs due to use{}", move_spans.describe()));
289 self.explain_why_borrow_contains_point(location, borrow, None)
290 .add_explanation_to_diagnostic(
298 err.buffer(&mut self.errors_buffer);
301 pub(in crate::borrow_check) fn report_use_while_mutably_borrowed(
304 (place, _span): (&Place<'tcx>, Span),
305 borrow: &BorrowData<'tcx>,
306 ) -> DiagnosticBuilder<'cx> {
307 let borrow_spans = self.retrieve_borrow_spans(borrow);
308 let borrow_span = borrow_spans.args_or_use();
310 // Conflicting borrows are reported separately, so only check for move
312 let use_spans = self.move_spans(place.as_ref(), location);
313 let span = use_spans.var_or_use();
315 let mut err = self.cannot_use_when_mutably_borrowed(
317 &self.describe_place(place.as_ref()).unwrap_or_else(|| "_".to_owned()),
319 &self.describe_place(borrow.borrowed_place.as_ref()).unwrap_or_else(|| "_".to_owned()),
322 borrow_spans.var_span_label(&mut err, {
323 let place = &borrow.borrowed_place;
324 let desc_place = self.describe_place(place.as_ref()).unwrap_or_else(|| "_".to_owned());
326 format!("borrow occurs due to use of `{}`{}", desc_place, borrow_spans.describe())
329 self.explain_why_borrow_contains_point(location, borrow, None)
330 .add_explanation_to_diagnostic(
341 pub(in crate::borrow_check) fn report_conflicting_borrow(
344 (place, span): (&Place<'tcx>, Span),
345 gen_borrow_kind: BorrowKind,
346 issued_borrow: &BorrowData<'tcx>,
347 ) -> DiagnosticBuilder<'cx> {
348 let issued_spans = self.retrieve_borrow_spans(issued_borrow);
349 let issued_span = issued_spans.args_or_use();
351 let borrow_spans = self.borrow_spans(span, location);
352 let span = borrow_spans.args_or_use();
354 let container_name = if issued_spans.for_generator() || borrow_spans.for_generator() {
360 let (desc_place, msg_place, msg_borrow, union_type_name) =
361 self.describe_place_for_conflicting_borrow(place, &issued_borrow.borrowed_place);
363 let explanation = self.explain_why_borrow_contains_point(location, issued_borrow, None);
364 let second_borrow_desc = if explanation.is_explained() { "second " } else { "" };
366 // FIXME: supply non-"" `opt_via` when appropriate
367 let first_borrow_desc;
368 let mut err = match (gen_borrow_kind, issued_borrow.kind) {
369 (BorrowKind::Shared, BorrowKind::Mut { .. }) => {
370 first_borrow_desc = "mutable ";
371 self.cannot_reborrow_already_borrowed(
383 (BorrowKind::Mut { .. }, BorrowKind::Shared) => {
384 first_borrow_desc = "immutable ";
385 self.cannot_reborrow_already_borrowed(
398 (BorrowKind::Mut { .. }, BorrowKind::Mut { .. }) => {
399 first_borrow_desc = "first ";
400 let mut err = self.cannot_mutably_borrow_multiply(
408 self.suggest_split_at_mut_if_applicable(
411 &issued_borrow.borrowed_place,
416 (BorrowKind::Unique, BorrowKind::Unique) => {
417 first_borrow_desc = "first ";
418 self.cannot_uniquely_borrow_by_two_closures(span, &desc_place, issued_span, None)
421 (BorrowKind::Mut { .. }, BorrowKind::Shallow)
422 | (BorrowKind::Unique, BorrowKind::Shallow) => {
423 if let Some(immutable_section_description) =
424 self.classify_immutable_section(&issued_borrow.assigned_place)
426 let mut err = self.cannot_mutate_in_immutable_section(
430 immutable_section_description,
433 borrow_spans.var_span_label(
436 "borrow occurs due to use of `{}`{}",
438 borrow_spans.describe(),
444 first_borrow_desc = "immutable ";
445 self.cannot_reborrow_already_borrowed(
459 (BorrowKind::Unique, _) => {
460 first_borrow_desc = "first ";
461 self.cannot_uniquely_borrow_by_one_closure(
473 (BorrowKind::Shared, BorrowKind::Unique) => {
474 first_borrow_desc = "first ";
475 self.cannot_reborrow_already_uniquely_borrowed(
488 (BorrowKind::Mut { .. }, BorrowKind::Unique) => {
489 first_borrow_desc = "first ";
490 self.cannot_reborrow_already_uniquely_borrowed(
503 (BorrowKind::Shared, BorrowKind::Shared)
504 | (BorrowKind::Shared, BorrowKind::Shallow)
505 | (BorrowKind::Shallow, BorrowKind::Mut { .. })
506 | (BorrowKind::Shallow, BorrowKind::Unique)
507 | (BorrowKind::Shallow, BorrowKind::Shared)
508 | (BorrowKind::Shallow, BorrowKind::Shallow) => unreachable!(),
511 if issued_spans == borrow_spans {
512 borrow_spans.var_span_label(
514 format!("borrows occur due to use of `{}`{}", desc_place, borrow_spans.describe()),
517 let borrow_place = &issued_borrow.borrowed_place;
518 let borrow_place_desc =
519 self.describe_place(borrow_place.as_ref()).unwrap_or_else(|| "_".to_owned());
520 issued_spans.var_span_label(
523 "first borrow occurs due to use of `{}`{}",
525 issued_spans.describe(),
529 borrow_spans.var_span_label(
532 "second borrow occurs due to use of `{}`{}",
534 borrow_spans.describe(),
539 if union_type_name != "" {
541 "`{}` is a field of the union `{}`, so it overlaps the field `{}`",
542 msg_place, union_type_name, msg_borrow,
546 explanation.add_explanation_to_diagnostic(
558 fn suggest_split_at_mut_if_applicable(
560 err: &mut DiagnosticBuilder<'_>,
562 borrowed_place: &Place<'tcx>,
564 match (&place.projection[..], &borrowed_place.projection[..]) {
565 ([ProjectionElem::Index(_)], [ProjectionElem::Index(_)]) => {
567 "consider using `.split_at_mut(position)` or similar method to obtain \
568 two mutable non-overlapping sub-slices",
575 /// Returns the description of the root place for a conflicting borrow and the full
576 /// descriptions of the places that caused the conflict.
578 /// In the simplest case, where there are no unions involved, if a mutable borrow of `x` is
579 /// attempted while a shared borrow is live, then this function will return:
583 /// In the simple union case, if a mutable borrow of a union field `x.z` is attempted while
584 /// a shared borrow of another field `x.y`, then this function will return:
586 /// ("x", "x.z", "x.y")
588 /// In the more complex union case, where the union is a field of a struct, then if a mutable
589 /// borrow of a union field in a struct `x.u.z` is attempted while a shared borrow of
590 /// another field `x.u.y`, then this function will return:
592 /// ("x.u", "x.u.z", "x.u.y")
594 /// This is used when creating error messages like below:
596 /// > cannot borrow `a.u` (via `a.u.z.c`) as immutable because it is also borrowed as
597 /// > mutable (via `a.u.s.b`) [E0502]
598 pub(in crate::borrow_check) fn describe_place_for_conflicting_borrow(
600 first_borrowed_place: &Place<'tcx>,
601 second_borrowed_place: &Place<'tcx>,
602 ) -> (String, String, String, String) {
603 // Define a small closure that we can use to check if the type of a place
605 let union_ty = |place_base, place_projection| {
606 let ty = Place::ty_from(place_base, place_projection, *self.body, self.infcx.tcx).ty;
607 ty.ty_adt_def().filter(|adt| adt.is_union()).map(|_| ty)
609 let describe_place = |place| self.describe_place(place).unwrap_or_else(|| "_".to_owned());
611 // Start with an empty tuple, so we can use the functions on `Option` to reduce some
612 // code duplication (particularly around returning an empty description in the failure
616 // If we have a conflicting borrow of the same place, then we don't want to add
617 // an extraneous "via x.y" to our diagnostics, so filter out this case.
618 first_borrowed_place != second_borrowed_place
621 // We're going to want to traverse the first borrowed place to see if we can find
622 // field access to a union. If we find that, then we will keep the place of the
623 // union being accessed and the field that was being accessed so we can check the
624 // second borrowed place for the same union and a access to a different field.
625 let Place { local, projection } = first_borrowed_place;
627 let mut cursor = projection.as_ref();
628 while let [proj_base @ .., elem] = cursor {
632 ProjectionElem::Field(field, _)
633 if union_ty(*local, proj_base).is_some() =>
636 PlaceRef { local: *local, projection: proj_base },
645 .and_then(|(target_base, target_field)| {
646 // With the place of a union and a field access into it, we traverse the second
647 // borrowed place and look for a access to a different field of the same union.
648 let Place { local, projection } = second_borrowed_place;
650 let mut cursor = projection.as_ref();
651 while let [proj_base @ .., elem] = cursor {
654 if let ProjectionElem::Field(field, _) = elem {
655 if let Some(union_ty) = union_ty(*local, proj_base) {
656 if field != target_field
657 && *local == target_base.local
658 && proj_base == target_base.projection
660 // FIXME when we avoid clone reuse describe_place closure
661 let describe_base_place = self
662 .describe_place(PlaceRef {
664 projection: proj_base,
666 .unwrap_or_else(|| "_".to_owned());
670 describe_place(first_borrowed_place.as_ref()),
671 describe_place(second_borrowed_place.as_ref()),
672 union_ty.to_string(),
681 // If we didn't find a field access into a union, or both places match, then
682 // only return the description of the first place.
684 describe_place(first_borrowed_place.as_ref()),
692 /// Reports StorageDeadOrDrop of `place` conflicts with `borrow`.
694 /// This means that some data referenced by `borrow` needs to live
695 /// past the point where the StorageDeadOrDrop of `place` occurs.
696 /// This is usually interpreted as meaning that `place` has too
697 /// short a lifetime. (But sometimes it is more useful to report
698 /// it as a more direct conflict between the execution of a
699 /// `Drop::drop` with an aliasing borrow.)
700 pub(in crate::borrow_check) fn report_borrowed_value_does_not_live_long_enough(
703 borrow: &BorrowData<'tcx>,
704 place_span: (&Place<'tcx>, Span),
705 kind: Option<WriteKind>,
708 "report_borrowed_value_does_not_live_long_enough(\
709 {:?}, {:?}, {:?}, {:?}\
711 location, borrow, place_span, kind
714 let drop_span = place_span.1;
716 self.prefixes(borrow.borrowed_place.as_ref(), PrefixSet::All).last().unwrap();
718 let borrow_spans = self.retrieve_borrow_spans(borrow);
719 let borrow_span = borrow_spans.var_or_use();
721 assert!(root_place.projection.is_empty());
722 let proper_span = self.body.local_decls[root_place.local].source_info.span;
724 let root_place_projection = self.infcx.tcx.intern_place_elems(root_place.projection);
726 if self.access_place_error_reported.contains(&(
727 Place { local: root_place.local, projection: root_place_projection },
731 "suppressing access_place error when borrow doesn't live long enough for {:?}",
737 self.access_place_error_reported.insert((
738 Place { local: root_place.local, projection: root_place_projection },
742 let borrowed_local = borrow.borrowed_place.local;
743 if self.body.local_decls[borrowed_local].is_ref_to_thread_local() {
745 self.report_thread_local_value_does_not_live_long_enough(drop_span, borrow_span);
746 err.buffer(&mut self.errors_buffer);
750 if let StorageDeadOrDrop::Destructor(dropped_ty) =
751 self.classify_drop_access_kind(borrow.borrowed_place.as_ref())
753 // If a borrow of path `B` conflicts with drop of `D` (and
754 // we're not in the uninteresting case where `B` is a
755 // prefix of `D`), then report this as a more interesting
756 // destructor conflict.
757 if !borrow.borrowed_place.as_ref().is_prefix_of(place_span.0.as_ref()) {
758 self.report_borrow_conflicts_with_destructor(
759 location, borrow, place_span, kind, dropped_ty,
765 let place_desc = self.describe_place(borrow.borrowed_place.as_ref());
767 let kind_place = kind.filter(|_| place_desc.is_some()).map(|k| (k, place_span.0));
768 let explanation = self.explain_why_borrow_contains_point(location, &borrow, kind_place);
771 "report_borrowed_value_does_not_live_long_enough(place_desc: {:?}, explanation: {:?})",
772 place_desc, explanation
774 let err = match (place_desc, explanation) {
775 // If the outlives constraint comes from inside the closure,
780 // Box::new(|| y) as Box<Fn() -> &'static i32>
782 // then just use the normal error. The closure isn't escaping
783 // and `move` will not help here.
786 BorrowExplanation::MustBeValidFor {
787 category: category @ ConstraintCategory::Return,
796 BorrowExplanation::MustBeValidFor {
797 category: category @ ConstraintCategory::CallArgument,
803 ) if borrow_spans.for_closure() => self.report_escaping_closure_capture(
809 &format!("`{}`", name),
813 BorrowExplanation::MustBeValidFor {
814 category: category @ ConstraintCategory::OpaqueType,
820 ) if borrow_spans.for_generator() => self.report_escaping_closure_capture(
826 &format!("`{}`", name),
830 BorrowExplanation::MustBeValidFor {
831 category: ConstraintCategory::Assignment,
836 RegionNameSource::AnonRegionFromUpvar(upvar_span, ref upvar_name),
842 ) => self.report_escaping_data(borrow_span, name, upvar_span, upvar_name, span),
843 (Some(name), explanation) => self.report_local_value_does_not_live_long_enough(
851 (None, explanation) => self.report_temporary_value_does_not_live_long_enough(
861 err.buffer(&mut self.errors_buffer);
864 fn report_local_value_does_not_live_long_enough(
868 borrow: &BorrowData<'tcx>,
870 borrow_spans: UseSpans,
871 explanation: BorrowExplanation,
872 ) -> DiagnosticBuilder<'cx> {
874 "report_local_value_does_not_live_long_enough(\
875 {:?}, {:?}, {:?}, {:?}, {:?}\
877 location, name, borrow, drop_span, borrow_spans
880 let borrow_span = borrow_spans.var_or_use();
881 if let BorrowExplanation::MustBeValidFor {
889 if let Some(diag) = self.try_report_cannot_return_reference_to_local(
894 opt_place_desc.as_ref(),
900 let mut err = self.path_does_not_live_long_enough(borrow_span, &format!("`{}`", name));
902 if let Some(annotation) = self.annotate_argument_and_return_for_borrow(borrow) {
903 let region_name = annotation.emit(self, &mut err);
907 format!("`{}` would have to be valid for `{}`...", name, region_name),
910 if let Some(fn_hir_id) = self.infcx.tcx.hir().as_local_hir_id(self.mir_def_id) {
914 "...but `{}` will be dropped here, when the {} returns",
920 .map(|name| format!("function `{}`", name))
925 .typeck_tables_of(self.mir_def_id)
926 .node_type(fn_hir_id)
929 ty::Closure(..) => "enclosing closure",
930 ty::Generator(..) => "enclosing generator",
931 kind => bug!("expected closure or generator, found {:?}", kind),
939 "functions cannot return a borrow to data owned within the function's scope, \
940 functions can only return borrows to data passed as arguments",
943 "to learn more, visit <https://doc.rust-lang.org/book/ch04-02-\
944 references-and-borrowing.html#dangling-references>",
949 format!("...but `{}` dropped here while still borrowed", name),
953 if let BorrowExplanation::MustBeValidFor { .. } = explanation {
955 explanation.add_explanation_to_diagnostic(
965 err.span_label(borrow_span, "borrowed value does not live long enough");
966 err.span_label(drop_span, format!("`{}` dropped here while still borrowed", name));
968 let within = if borrow_spans.for_generator() { " by generator" } else { "" };
970 borrow_spans.args_span_label(&mut err, format!("value captured here{}", within));
972 explanation.add_explanation_to_diagnostic(
985 fn report_borrow_conflicts_with_destructor(
988 borrow: &BorrowData<'tcx>,
989 (place, drop_span): (&Place<'tcx>, Span),
990 kind: Option<WriteKind>,
991 dropped_ty: Ty<'tcx>,
994 "report_borrow_conflicts_with_destructor(\
995 {:?}, {:?}, ({:?}, {:?}), {:?}\
997 location, borrow, place, drop_span, kind,
1000 let borrow_spans = self.retrieve_borrow_spans(borrow);
1001 let borrow_span = borrow_spans.var_or_use();
1003 let mut err = self.cannot_borrow_across_destructor(borrow_span);
1005 let what_was_dropped = match self.describe_place(place.as_ref()) {
1006 Some(name) => format!("`{}`", name),
1007 None => String::from("temporary value"),
1010 let label = match self.describe_place(borrow.borrowed_place.as_ref()) {
1011 Some(borrowed) => format!(
1012 "here, drop of {D} needs exclusive access to `{B}`, \
1013 because the type `{T}` implements the `Drop` trait",
1014 D = what_was_dropped,
1019 "here is drop of {D}; whose type `{T}` implements the `Drop` trait",
1020 D = what_was_dropped,
1024 err.span_label(drop_span, label);
1026 // Only give this note and suggestion if they could be relevant.
1028 self.explain_why_borrow_contains_point(location, borrow, kind.map(|k| (k, place)));
1030 BorrowExplanation::UsedLater { .. }
1031 | BorrowExplanation::UsedLaterWhenDropped { .. } => {
1032 err.note("consider using a `let` binding to create a longer lived value");
1037 explanation.add_explanation_to_diagnostic(
1046 err.buffer(&mut self.errors_buffer);
1049 fn report_thread_local_value_does_not_live_long_enough(
1053 ) -> DiagnosticBuilder<'cx> {
1055 "report_thread_local_value_does_not_live_long_enough(\
1058 drop_span, borrow_span
1061 let mut err = self.thread_local_value_does_not_live_long_enough(borrow_span);
1065 "thread-local variables cannot be borrowed beyond the end of the function",
1067 err.span_label(drop_span, "end of enclosing function is here");
1072 fn report_temporary_value_does_not_live_long_enough(
1075 borrow: &BorrowData<'tcx>,
1077 borrow_spans: UseSpans,
1079 explanation: BorrowExplanation,
1080 ) -> DiagnosticBuilder<'cx> {
1082 "report_temporary_value_does_not_live_long_enough(\
1083 {:?}, {:?}, {:?}, {:?}\
1085 location, borrow, drop_span, proper_span
1088 if let BorrowExplanation::MustBeValidFor { category, span, from_closure: false, .. } =
1091 if let Some(diag) = self.try_report_cannot_return_reference_to_local(
1102 let mut err = self.temporary_value_borrowed_for_too_long(proper_span);
1103 err.span_label(proper_span, "creates a temporary which is freed while still in use");
1104 err.span_label(drop_span, "temporary value is freed at the end of this statement");
1107 BorrowExplanation::UsedLater(..)
1108 | BorrowExplanation::UsedLaterInLoop(..)
1109 | BorrowExplanation::UsedLaterWhenDropped { .. } => {
1110 // Only give this note and suggestion if it could be relevant.
1111 err.note("consider using a `let` binding to create a longer lived value");
1115 explanation.add_explanation_to_diagnostic(
1124 let within = if borrow_spans.for_generator() { " by generator" } else { "" };
1126 borrow_spans.args_span_label(&mut err, format!("value captured here{}", within));
1131 fn try_report_cannot_return_reference_to_local(
1133 borrow: &BorrowData<'tcx>,
1136 category: ConstraintCategory,
1137 opt_place_desc: Option<&String>,
1138 ) -> Option<DiagnosticBuilder<'cx>> {
1139 let return_kind = match category {
1140 ConstraintCategory::Return => "return",
1141 ConstraintCategory::Yield => "yield",
1145 // FIXME use a better heuristic than Spans
1146 let reference_desc = if return_span == self.body.source_info(borrow.reserve_location).span {
1152 let (place_desc, note) = if let Some(place_desc) = opt_place_desc {
1153 let local_kind = if let Some(local) = borrow.borrowed_place.as_local() {
1154 match self.body.local_kind(local) {
1155 LocalKind::ReturnPointer | LocalKind::Temp => {
1156 bug!("temporary or return pointer with a name")
1158 LocalKind::Var => "local variable ",
1159 LocalKind::Arg if !self.upvars.is_empty() && local == Local::new(1) => {
1160 "variable captured by `move` "
1162 LocalKind::Arg => "function parameter ",
1168 format!("{}`{}`", local_kind, place_desc),
1169 format!("`{}` is borrowed here", place_desc),
1173 self.prefixes(borrow.borrowed_place.as_ref(), PrefixSet::All).last().unwrap();
1174 let local = root_place.local;
1175 match self.body.local_kind(local) {
1176 LocalKind::ReturnPointer | LocalKind::Temp => {
1177 ("temporary value".to_string(), "temporary value created here".to_string())
1180 "function parameter".to_string(),
1181 "function parameter borrowed here".to_string(),
1184 ("local binding".to_string(), "local binding introduced here".to_string())
1189 let mut err = self.cannot_return_reference_to_local(
1196 if return_span != borrow_span {
1197 err.span_label(borrow_span, note);
1203 fn report_escaping_closure_capture(
1207 fr_name: &RegionName,
1208 category: ConstraintCategory,
1209 constraint_span: Span,
1211 ) -> DiagnosticBuilder<'cx> {
1212 let tcx = self.infcx.tcx;
1213 let args_span = use_span.args_or_use();
1214 let mut err = self.cannot_capture_in_long_lived_closure(args_span, captured_var, var_span);
1216 let suggestion = match tcx.sess.source_map().span_to_snippet(args_span) {
1218 if string.starts_with("async ") {
1219 string.insert_str(6, "move ");
1220 } else if string.starts_with("async|") {
1221 string.insert_str(5, " move");
1223 string.insert_str(0, "move ");
1227 Err(_) => "move |<args>| <body>".to_string(),
1229 let kind = match use_span.generator_kind() {
1230 Some(generator_kind) => match generator_kind {
1231 GeneratorKind::Async(async_kind) => match async_kind {
1232 AsyncGeneratorKind::Block => "async block",
1233 AsyncGeneratorKind::Closure => "async closure",
1234 _ => bug!("async block/closure expected, but async funtion found."),
1236 GeneratorKind::Gen => "generator",
1240 err.span_suggestion(
1243 "to force the {} to take ownership of {} (and any \
1244 other referenced variables), use the `move` keyword",
1248 Applicability::MachineApplicable,
1251 let msg = match category {
1252 ConstraintCategory::Return => "closure is returned here".to_string(),
1253 ConstraintCategory::OpaqueType => "generator is returned here".to_string(),
1254 ConstraintCategory::CallArgument => {
1255 fr_name.highlight_region_name(&mut err);
1256 format!("function requires argument type to outlive `{}`", fr_name)
1259 "report_escaping_closure_capture called with unexpected constraint \
1264 err.span_note(constraint_span, &msg);
1268 fn report_escaping_data(
1271 name: &Option<String>,
1275 ) -> DiagnosticBuilder<'cx> {
1276 let tcx = self.infcx.tcx;
1278 let (_, escapes_from) = tcx.article_and_description(self.mir_def_id);
1281 borrowck_errors::borrowed_data_escapes_closure(tcx, escape_span, escapes_from);
1285 format!("`{}` declared here, outside of the {} body", upvar_name, escapes_from),
1288 err.span_label(borrow_span, format!("borrow is only valid in the {} body", escapes_from));
1290 if let Some(name) = name {
1293 format!("reference to `{}` escapes the {} body here", name, escapes_from),
1298 format!("reference escapes the {} body here", escapes_from),
1305 fn get_moved_indexes(&mut self, location: Location, mpi: MovePathIndex) -> Vec<MoveSite> {
1306 let mut stack = Vec::new();
1307 stack.extend(self.body.predecessor_locations(location).map(|predecessor| {
1308 let is_back_edge = location.dominates(predecessor, &self.dominators);
1309 (predecessor, is_back_edge)
1312 let mut visited = FxHashSet::default();
1313 let mut result = vec![];
1315 'dfs: while let Some((location, is_back_edge)) = stack.pop() {
1317 "report_use_of_moved_or_uninitialized: (current_location={:?}, back_edge={})",
1318 location, is_back_edge
1321 if !visited.insert(location) {
1327 self.body[location.block].statements.get(location.statement_index).map(|s| &s.kind);
1328 if let Some(StatementKind::StorageDead(..)) = stmt_kind {
1329 // this analysis only tries to find moves explicitly
1330 // written by the user, so we ignore the move-outs
1331 // created by `StorageDead` and at the beginning
1334 // If we are found a use of a.b.c which was in error, then we want to look for
1335 // moves not only of a.b.c but also a.b and a.
1337 // Note that the moves data already includes "parent" paths, so we don't have to
1338 // worry about the other case: that is, if there is a move of a.b.c, it is already
1339 // marked as a move of a.b and a as well, so we will generate the correct errors
1341 let mut mpis = vec![mpi];
1342 let move_paths = &self.move_data.move_paths;
1343 mpis.extend(move_paths[mpi].parents(move_paths).map(|(mpi, _)| mpi));
1345 for moi in &self.move_data.loc_map[location] {
1346 debug!("report_use_of_moved_or_uninitialized: moi={:?}", moi);
1347 if mpis.contains(&self.move_data.moves[*moi].path) {
1348 debug!("report_use_of_moved_or_uninitialized: found");
1349 result.push(MoveSite { moi: *moi, traversed_back_edge: is_back_edge });
1351 // Strictly speaking, we could continue our DFS here. There may be
1352 // other moves that can reach the point of error. But it is kind of
1353 // confusing to highlight them.
1361 // drop(a); // <-- current point of error
1364 // Because we stop the DFS here, we only highlight `let c = a`,
1365 // and not `let b = a`. We will of course also report an error at
1366 // `let c = a` which highlights `let b = a` as the move.
1373 let mut any_match = false;
1374 drop_flag_effects::for_location_inits(
1389 stack.extend(self.body.predecessor_locations(location).map(|predecessor| {
1390 let back_edge = location.dominates(predecessor, &self.dominators);
1391 (predecessor, is_back_edge || back_edge)
1398 pub(in crate::borrow_check) fn report_illegal_mutation_of_borrowed(
1401 (place, span): (&Place<'tcx>, Span),
1402 loan: &BorrowData<'tcx>,
1404 let loan_spans = self.retrieve_borrow_spans(loan);
1405 let loan_span = loan_spans.args_or_use();
1407 if loan.kind == BorrowKind::Shallow {
1408 if let Some(section) = self.classify_immutable_section(&loan.assigned_place) {
1409 let mut err = self.cannot_mutate_in_immutable_section(
1412 &self.describe_place(place.as_ref()).unwrap_or_else(|| "_".to_owned()),
1416 loan_spans.var_span_label(
1418 format!("borrow occurs due to use{}", loan_spans.describe()),
1421 err.buffer(&mut self.errors_buffer);
1427 let mut err = self.cannot_assign_to_borrowed(
1430 &self.describe_place(place.as_ref()).unwrap_or_else(|| "_".to_owned()),
1434 .var_span_label(&mut err, format!("borrow occurs due to use{}", loan_spans.describe()));
1436 self.explain_why_borrow_contains_point(location, loan, None).add_explanation_to_diagnostic(
1445 err.buffer(&mut self.errors_buffer);
1448 /// Reports an illegal reassignment; for example, an assignment to
1449 /// (part of) a non-`mut` local that occurs potentially after that
1450 /// local has already been initialized. `place` is the path being
1451 /// assigned; `err_place` is a place providing a reason why
1452 /// `place` is not mutable (e.g., the non-`mut` local `x` in an
1453 /// assignment to `x.f`).
1454 pub(in crate::borrow_check) fn report_illegal_reassignment(
1456 _location: Location,
1457 (place, span): (&Place<'tcx>, Span),
1458 assigned_span: Span,
1459 err_place: &Place<'tcx>,
1461 let (from_arg, local_decl, local_name) = match err_place.as_local() {
1463 self.body.local_kind(local) == LocalKind::Arg,
1464 Some(&self.body.local_decls[local]),
1465 self.local_names[local],
1467 None => (false, None, None),
1470 // If root local is initialized immediately (everything apart from let
1471 // PATTERN;) then make the error refer to that local, rather than the
1472 // place being assigned later.
1473 let (place_description, assigned_span) = match local_decl {
1474 Some(LocalDecl { local_info: LocalInfo::User(ClearCrossCrate::Clear), .. })
1477 LocalInfo::User(ClearCrossCrate::Set(BindingForm::Var(VarBindingForm {
1478 opt_match_place: None,
1483 | Some(LocalDecl { local_info: LocalInfo::StaticRef { .. }, .. })
1484 | Some(LocalDecl { local_info: LocalInfo::Other, .. })
1485 | None => (self.describe_place(place.as_ref()), assigned_span),
1486 Some(decl) => (self.describe_place(err_place.as_ref()), decl.source_info.span),
1489 let mut err = self.cannot_reassign_immutable(
1491 place_description.as_ref().map(AsRef::as_ref).unwrap_or("_"),
1494 let msg = if from_arg {
1495 "cannot assign to immutable argument"
1497 "cannot assign twice to immutable variable"
1499 if span != assigned_span {
1501 let value_msg = match place_description {
1502 Some(name) => format!("`{}`", name),
1503 None => "value".to_owned(),
1505 err.span_label(assigned_span, format!("first assignment to {}", value_msg));
1508 if let Some(decl) = local_decl {
1509 if let Some(name) = local_name {
1510 if decl.can_be_made_mutable() {
1511 err.span_suggestion(
1512 decl.source_info.span,
1513 "make this binding mutable",
1514 format!("mut {}", name),
1515 Applicability::MachineApplicable,
1520 err.span_label(span, msg);
1521 err.buffer(&mut self.errors_buffer);
1524 fn classify_drop_access_kind(&self, place: PlaceRef<'cx, 'tcx>) -> StorageDeadOrDrop<'tcx> {
1525 let tcx = self.infcx.tcx;
1526 match place.projection {
1527 [] => StorageDeadOrDrop::LocalStorageDead,
1528 [proj_base @ .., elem] => {
1529 // FIXME(spastorino) make this iterate
1530 let base_access = self.classify_drop_access_kind(PlaceRef {
1532 projection: proj_base,
1535 ProjectionElem::Deref => match base_access {
1536 StorageDeadOrDrop::LocalStorageDead
1537 | StorageDeadOrDrop::BoxedStorageDead => {
1539 Place::ty_from(place.local, proj_base, *self.body, tcx).ty.is_box(),
1540 "Drop of value behind a reference or raw pointer"
1542 StorageDeadOrDrop::BoxedStorageDead
1544 StorageDeadOrDrop::Destructor(_) => base_access,
1546 ProjectionElem::Field(..) | ProjectionElem::Downcast(..) => {
1547 let base_ty = Place::ty_from(place.local, proj_base, *self.body, tcx).ty;
1548 match base_ty.kind {
1549 ty::Adt(def, _) if def.has_dtor(tcx) => {
1550 // Report the outermost adt with a destructor
1552 StorageDeadOrDrop::Destructor(_) => base_access,
1553 StorageDeadOrDrop::LocalStorageDead
1554 | StorageDeadOrDrop::BoxedStorageDead => {
1555 StorageDeadOrDrop::Destructor(base_ty)
1563 ProjectionElem::ConstantIndex { .. }
1564 | ProjectionElem::Subslice { .. }
1565 | ProjectionElem::Index(_) => base_access,
1571 /// Describe the reason for the fake borrow that was assigned to `place`.
1572 fn classify_immutable_section(&self, place: &Place<'tcx>) -> Option<&'static str> {
1573 use rustc::mir::visit::Visitor;
1574 struct FakeReadCauseFinder<'a, 'tcx> {
1575 place: &'a Place<'tcx>,
1576 cause: Option<FakeReadCause>,
1578 impl<'tcx> Visitor<'tcx> for FakeReadCauseFinder<'_, 'tcx> {
1579 fn visit_statement(&mut self, statement: &Statement<'tcx>, _: Location) {
1581 Statement { kind: StatementKind::FakeRead(cause, box ref place), .. }
1582 if *place == *self.place =>
1584 self.cause = Some(*cause);
1590 let mut visitor = FakeReadCauseFinder { place, cause: None };
1591 visitor.visit_body(self.body);
1592 match visitor.cause {
1593 Some(FakeReadCause::ForMatchGuard) => Some("match guard"),
1594 Some(FakeReadCause::ForIndex) => Some("indexing expression"),
1599 /// Annotate argument and return type of function and closure with (synthesized) lifetime for
1600 /// borrow of local value that does not live long enough.
1601 fn annotate_argument_and_return_for_borrow(
1603 borrow: &BorrowData<'tcx>,
1604 ) -> Option<AnnotatedBorrowFnSignature<'tcx>> {
1605 // Define a fallback for when we can't match a closure.
1607 let is_closure = self.infcx.tcx.is_closure(self.mir_def_id);
1611 let ty = self.infcx.tcx.type_of(self.mir_def_id);
1613 ty::FnDef(_, _) | ty::FnPtr(_) => self
1614 .annotate_fn_sig(self.mir_def_id, self.infcx.tcx.fn_sig(self.mir_def_id)),
1620 // In order to determine whether we need to annotate, we need to check whether the reserve
1621 // place was an assignment into a temporary.
1623 // If it was, we check whether or not that temporary is eventually assigned into the return
1624 // place. If it was, we can add annotations about the function's return type and arguments
1625 // and it'll make sense.
1626 let location = borrow.reserve_location;
1627 debug!("annotate_argument_and_return_for_borrow: location={:?}", location);
1628 if let Some(&Statement { kind: StatementKind::Assign(box (ref reservation, _)), .. }) =
1629 &self.body[location.block].statements.get(location.statement_index)
1631 debug!("annotate_argument_and_return_for_borrow: reservation={:?}", reservation);
1632 // Check that the initial assignment of the reserve location is into a temporary.
1633 let mut target = match reservation.as_local() {
1634 Some(local) if self.body.local_kind(local) == LocalKind::Temp => local,
1638 // Next, look through the rest of the block, checking if we are assigning the
1639 // `target` (that is, the place that contains our borrow) to anything.
1640 let mut annotated_closure = None;
1641 for stmt in &self.body[location.block].statements[location.statement_index + 1..] {
1643 "annotate_argument_and_return_for_borrow: target={:?} stmt={:?}",
1646 if let StatementKind::Assign(box (place, rvalue)) = &stmt.kind {
1647 if let Some(assigned_to) = place.as_local() {
1649 "annotate_argument_and_return_for_borrow: assigned_to={:?} \
1653 // Check if our `target` was captured by a closure.
1654 if let Rvalue::Aggregate(
1655 box AggregateKind::Closure(def_id, substs),
1659 for operand in operands {
1660 let assigned_from = match operand {
1661 Operand::Copy(assigned_from) | Operand::Move(assigned_from) => {
1667 "annotate_argument_and_return_for_borrow: assigned_from={:?}",
1671 // Find the local from the operand.
1672 let assigned_from_local = match assigned_from.local_or_deref_local()
1674 Some(local) => local,
1678 if assigned_from_local != target {
1682 // If a closure captured our `target` and then assigned
1683 // into a place then we should annotate the closure in
1684 // case it ends up being assigned into the return place.
1685 annotated_closure = self.annotate_fn_sig(
1687 self.infcx.closure_sig(*def_id, *substs),
1690 "annotate_argument_and_return_for_borrow: \
1691 annotated_closure={:?} assigned_from_local={:?} \
1693 annotated_closure, assigned_from_local, assigned_to
1696 if assigned_to == mir::RETURN_PLACE {
1697 // If it was assigned directly into the return place, then
1699 return annotated_closure;
1701 // Otherwise, update the target.
1702 target = assigned_to;
1706 // If none of our closure's operands matched, then skip to the next
1711 // Otherwise, look at other types of assignment.
1712 let assigned_from = match rvalue {
1713 Rvalue::Ref(_, _, assigned_from) => assigned_from,
1714 Rvalue::Use(operand) => match operand {
1715 Operand::Copy(assigned_from) | Operand::Move(assigned_from) => {
1723 "annotate_argument_and_return_for_borrow: \
1724 assigned_from={:?}",
1728 // Find the local from the rvalue.
1729 let assigned_from_local = match assigned_from.local_or_deref_local() {
1730 Some(local) => local,
1734 "annotate_argument_and_return_for_borrow: \
1735 assigned_from_local={:?}",
1736 assigned_from_local,
1739 // Check if our local matches the target - if so, we've assigned our
1740 // borrow to a new place.
1741 if assigned_from_local != target {
1745 // If we assigned our `target` into a new place, then we should
1746 // check if it was the return place.
1748 "annotate_argument_and_return_for_borrow: \
1749 assigned_from_local={:?} assigned_to={:?}",
1750 assigned_from_local, assigned_to
1752 if assigned_to == mir::RETURN_PLACE {
1753 // If it was then return the annotated closure if there was one,
1754 // else, annotate this function.
1755 return annotated_closure.or_else(fallback);
1758 // If we didn't assign into the return place, then we just update
1760 target = assigned_to;
1765 // Check the terminator if we didn't find anything in the statements.
1766 let terminator = &self.body[location.block].terminator();
1768 "annotate_argument_and_return_for_borrow: target={:?} terminator={:?}",
1771 if let TerminatorKind::Call { destination: Some((place, _)), args, .. } =
1774 if let Some(assigned_to) = place.as_local() {
1776 "annotate_argument_and_return_for_borrow: assigned_to={:?} args={:?}",
1779 for operand in args {
1780 let assigned_from = match operand {
1781 Operand::Copy(assigned_from) | Operand::Move(assigned_from) => {
1787 "annotate_argument_and_return_for_borrow: assigned_from={:?}",
1791 if let Some(assigned_from_local) = assigned_from.local_or_deref_local() {
1793 "annotate_argument_and_return_for_borrow: assigned_from_local={:?}",
1794 assigned_from_local,
1797 if assigned_to == mir::RETURN_PLACE && assigned_from_local == target {
1798 return annotated_closure.or_else(fallback);
1806 // If we haven't found an assignment into the return place, then we need not add
1808 debug!("annotate_argument_and_return_for_borrow: none found");
1812 /// Annotate the first argument and return type of a function signature if they are
1817 sig: ty::PolyFnSig<'tcx>,
1818 ) -> Option<AnnotatedBorrowFnSignature<'tcx>> {
1819 debug!("annotate_fn_sig: did={:?} sig={:?}", did, sig);
1820 let is_closure = self.infcx.tcx.is_closure(did);
1821 let fn_hir_id = self.infcx.tcx.hir().as_local_hir_id(did)?;
1822 let fn_decl = self.infcx.tcx.hir().fn_decl_by_hir_id(fn_hir_id)?;
1824 // We need to work out which arguments to highlight. We do this by looking
1825 // at the return type, where there are three cases:
1827 // 1. If there are named arguments, then we should highlight the return type and
1828 // highlight any of the arguments that are also references with that lifetime.
1829 // If there are no arguments that have the same lifetime as the return type,
1830 // then don't highlight anything.
1831 // 2. The return type is a reference with an anonymous lifetime. If this is
1832 // the case, then we can take advantage of (and teach) the lifetime elision
1835 // We know that an error is being reported. So the arguments and return type
1836 // must satisfy the elision rules. Therefore, if there is a single argument
1837 // then that means the return type and first (and only) argument have the same
1838 // lifetime and the borrow isn't meeting that, we can highlight the argument
1841 // If there are multiple arguments then the first argument must be self (else
1842 // it would not satisfy the elision rules), so we can highlight self and the
1844 // 3. The return type is not a reference. In this case, we don't highlight
1846 let return_ty = sig.output();
1847 match return_ty.skip_binder().kind {
1848 ty::Ref(return_region, _, _) if return_region.has_name() && !is_closure => {
1849 // This is case 1 from above, return type is a named reference so we need to
1850 // search for relevant arguments.
1851 let mut arguments = Vec::new();
1852 for (index, argument) in sig.inputs().skip_binder().iter().enumerate() {
1853 if let ty::Ref(argument_region, _, _) = argument.kind {
1854 if argument_region == return_region {
1855 // Need to use the `rustc::ty` types to compare against the
1856 // `return_region`. Then use the `rustc_hir` type to get only
1857 // the lifetime span.
1858 if let hir::TyKind::Rptr(lifetime, _) = &fn_decl.inputs[index].kind {
1859 // With access to the lifetime, we can get
1861 arguments.push((*argument, lifetime.span));
1863 bug!("ty type is a ref but hir type is not");
1869 // We need to have arguments. This shouldn't happen, but it's worth checking.
1870 if arguments.is_empty() {
1874 // We use a mix of the HIR and the Ty types to get information
1875 // as the HIR doesn't have full types for closure arguments.
1876 let return_ty = *sig.output().skip_binder();
1877 let mut return_span = fn_decl.output.span();
1878 if let hir::FnRetTy::Return(ty) = &fn_decl.output {
1879 if let hir::TyKind::Rptr(lifetime, _) = ty.kind {
1880 return_span = lifetime.span;
1884 Some(AnnotatedBorrowFnSignature::NamedFunction {
1890 ty::Ref(_, _, _) if is_closure => {
1891 // This is case 2 from above but only for closures, return type is anonymous
1892 // reference so we select
1893 // the first argument.
1894 let argument_span = fn_decl.inputs.first()?.span;
1895 let argument_ty = sig.inputs().skip_binder().first()?;
1897 // Closure arguments are wrapped in a tuple, so we need to get the first
1899 if let ty::Tuple(elems) = argument_ty.kind {
1900 let argument_ty = elems.first()?.expect_ty();
1901 if let ty::Ref(_, _, _) = argument_ty.kind {
1902 return Some(AnnotatedBorrowFnSignature::Closure {
1911 ty::Ref(_, _, _) => {
1912 // This is also case 2 from above but for functions, return type is still an
1913 // anonymous reference so we select the first argument.
1914 let argument_span = fn_decl.inputs.first()?.span;
1915 let argument_ty = sig.inputs().skip_binder().first()?;
1917 let return_span = fn_decl.output.span();
1918 let return_ty = *sig.output().skip_binder();
1920 // We expect the first argument to be a reference.
1921 match argument_ty.kind {
1922 ty::Ref(_, _, _) => {}
1926 Some(AnnotatedBorrowFnSignature::AnonymousFunction {
1934 // This is case 3 from above, return type is not a reference so don't highlight
1943 enum AnnotatedBorrowFnSignature<'tcx> {
1945 arguments: Vec<(Ty<'tcx>, Span)>,
1946 return_ty: Ty<'tcx>,
1950 argument_ty: Ty<'tcx>,
1951 argument_span: Span,
1952 return_ty: Ty<'tcx>,
1956 argument_ty: Ty<'tcx>,
1957 argument_span: Span,
1961 impl<'tcx> AnnotatedBorrowFnSignature<'tcx> {
1962 /// Annotate the provided diagnostic with information about borrow from the fn signature that
1964 pub(in crate::borrow_check) fn emit(
1966 cx: &mut MirBorrowckCtxt<'_, 'tcx>,
1967 diag: &mut DiagnosticBuilder<'_>,
1970 AnnotatedBorrowFnSignature::Closure { argument_ty, argument_span } => {
1973 format!("has type `{}`", cx.get_name_for_ty(argument_ty, 0)),
1976 cx.get_region_name_for_ty(argument_ty, 0)
1978 AnnotatedBorrowFnSignature::AnonymousFunction {
1984 let argument_ty_name = cx.get_name_for_ty(argument_ty, 0);
1985 diag.span_label(*argument_span, format!("has type `{}`", argument_ty_name));
1987 let return_ty_name = cx.get_name_for_ty(return_ty, 0);
1988 let types_equal = return_ty_name == argument_ty_name;
1993 if types_equal { "also " } else { "" },
1999 "argument and return type have the same lifetime due to lifetime elision rules",
2002 "to learn more, visit <https://doc.rust-lang.org/book/ch10-03-\
2003 lifetime-syntax.html#lifetime-elision>",
2006 cx.get_region_name_for_ty(return_ty, 0)
2008 AnnotatedBorrowFnSignature::NamedFunction { arguments, return_ty, return_span } => {
2009 // Region of return type and arguments checked to be the same earlier.
2010 let region_name = cx.get_region_name_for_ty(return_ty, 0);
2011 for (_, argument_span) in arguments {
2012 diag.span_label(*argument_span, format!("has lifetime `{}`", region_name));
2015 diag.span_label(*return_span, format!("also has lifetime `{}`", region_name,));
2018 "use data from the highlighted arguments which match the `{}` lifetime of \