1 // Copyright 2015 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 //! Lints in the Rust compiler.
13 //! This currently only contains the definitions and implementations
14 //! of most of the lints that `rustc` supports directly, it does not
15 //! contain the infrastructure for defining/registering lints. That is
16 //! available in `rustc::lint` and `rustc_plugin` respectively.
20 //! This API is completely unstable and subject to change.
22 #![doc(html_logo_url = "https://www.rust-lang.org/logos/rust-logo-128x128-blk-v2.png",
23 html_favicon_url = "https://doc.rust-lang.org/favicon.ico",
24 html_root_url = "https://doc.rust-lang.org/nightly/")]
26 #![cfg_attr(test, feature(test))]
27 #![feature(box_patterns)]
28 #![feature(box_syntax)]
29 #![feature(macro_vis_matcher)]
31 #![feature(rustc_diagnostic_macros)]
32 #![feature(macro_at_most_once_rep)]
39 extern crate rustc_mir;
40 extern crate rustc_target;
41 extern crate syntax_pos;
44 use rustc::lint::builtin::{BARE_TRAIT_OBJECTS, ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE};
49 use syntax::edition::Edition;
51 use lint::FutureIncompatibleInfo;
63 /// Tell the `LintStore` about all the built-in lints (the ones
64 /// defined in this crate and the ones defined in
65 /// `rustc::lint::builtin`).
66 pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) {
67 macro_rules! add_builtin {
68 ($sess:ident, $($name:ident),*,) => (
70 store.register_late_pass($sess, false, box $name);
75 macro_rules! add_early_builtin {
76 ($sess:ident, $($name:ident),*,) => (
78 store.register_early_pass($sess, false, box $name);
83 macro_rules! add_builtin_with_new {
84 ($sess:ident, $($name:ident),*,) => (
86 store.register_late_pass($sess, false, box $name::new());
91 macro_rules! add_early_builtin_with_new {
92 ($sess:ident, $($name:ident),*,) => (
94 store.register_early_pass($sess, false, box $name::new());
99 macro_rules! add_lint_group {
100 ($sess:ident, $name:expr, $($lint:ident),*) => (
101 store.register_group($sess, false, $name, vec![$(LintId::of($lint)),*]);
105 add_early_builtin!(sess,
113 add_early_builtin_with_new!(sess,
121 VariantSizeDifferences,
129 NonShorthandFieldPatterns,
132 MissingCopyImplementations,
134 UnconditionalRecursion,
135 InvalidNoMangleItems,
138 UnionsWithDropFields,
145 add_builtin_with_new!(sess,
148 MissingDebugImplementations,
151 add_lint_group!(sess,
153 NON_CAMEL_CASE_TYPES,
155 NON_UPPER_CASE_GLOBALS);
157 add_lint_group!(sess,
159 NON_CAMEL_CASE_TYPES,
161 NON_UPPER_CASE_GLOBALS);
163 add_lint_group!(sess,
171 UNREACHABLE_PATTERNS,
179 UNUSED_EXTERN_CRATES,
184 add_lint_group!(sess,
188 UNUSED_EXTERN_CRATES);
190 // Guidelines for creating a future incompatibility lint:
192 // - Create a lint defaulting to warn as normal, with ideally the same error
193 // message you would normally give
194 // - Add a suitable reference, typically an RFC or tracking issue. Go ahead
195 // and include the full URL, sort items in ascending order of issue numbers.
196 // - Later, change lint to error
197 // - Eventually, remove lint
198 store.register_future_incompatible(sess,
200 FutureIncompatibleInfo {
201 id: LintId::of(PRIVATE_IN_PUBLIC),
202 reference: "issue #34537 <https://github.com/rust-lang/rust/issues/34537>",
205 FutureIncompatibleInfo {
206 id: LintId::of(PUB_USE_OF_PRIVATE_EXTERN_CRATE),
207 reference: "issue #34537 <https://github.com/rust-lang/rust/issues/34537>",
210 FutureIncompatibleInfo {
211 id: LintId::of(PATTERNS_IN_FNS_WITHOUT_BODY),
212 reference: "issue #35203 <https://github.com/rust-lang/rust/issues/35203>",
215 FutureIncompatibleInfo {
216 id: LintId::of(SAFE_EXTERN_STATICS),
217 reference: "issue #36247 <https://github.com/rust-lang/rust/issues/36247>",
220 FutureIncompatibleInfo {
221 id: LintId::of(INVALID_TYPE_PARAM_DEFAULT),
222 reference: "issue #36887 <https://github.com/rust-lang/rust/issues/36887>",
225 FutureIncompatibleInfo {
226 id: LintId::of(LEGACY_DIRECTORY_OWNERSHIP),
227 reference: "issue #37872 <https://github.com/rust-lang/rust/issues/37872>",
230 FutureIncompatibleInfo {
231 id: LintId::of(LEGACY_CONSTRUCTOR_VISIBILITY),
232 reference: "issue #39207 <https://github.com/rust-lang/rust/issues/39207>",
235 FutureIncompatibleInfo {
236 id: LintId::of(MISSING_FRAGMENT_SPECIFIER),
237 reference: "issue #40107 <https://github.com/rust-lang/rust/issues/40107>",
240 FutureIncompatibleInfo {
241 id: LintId::of(ILLEGAL_FLOATING_POINT_LITERAL_PATTERN),
242 reference: "issue #41620 <https://github.com/rust-lang/rust/issues/41620>",
245 FutureIncompatibleInfo {
246 id: LintId::of(ANONYMOUS_PARAMETERS),
247 reference: "issue #41686 <https://github.com/rust-lang/rust/issues/41686>",
250 FutureIncompatibleInfo {
251 id: LintId::of(PARENTHESIZED_PARAMS_IN_TYPES_AND_MODULES),
252 reference: "issue #42238 <https://github.com/rust-lang/rust/issues/42238>",
255 FutureIncompatibleInfo {
256 id: LintId::of(LATE_BOUND_LIFETIME_ARGUMENTS),
257 reference: "issue #42868 <https://github.com/rust-lang/rust/issues/42868>",
260 FutureIncompatibleInfo {
261 id: LintId::of(SAFE_PACKED_BORROWS),
262 reference: "issue #46043 <https://github.com/rust-lang/rust/issues/46043>",
265 FutureIncompatibleInfo {
266 id: LintId::of(INCOHERENT_FUNDAMENTAL_IMPLS),
267 reference: "issue #46205 <https://github.com/rust-lang/rust/issues/46205>",
270 FutureIncompatibleInfo {
271 id: LintId::of(TYVAR_BEHIND_RAW_POINTER),
272 reference: "issue #46906 <https://github.com/rust-lang/rust/issues/46906>",
273 edition: Some(Edition::Edition2018),
275 FutureIncompatibleInfo {
276 id: LintId::of(UNSTABLE_NAME_COLLISIONS),
277 reference: "issue #48919 <https://github.com/rust-lang/rust/issues/48919>",
279 // Note: this item represents future incompatibility of all unstable functions in the
280 // standard library, and thus should never be removed or changed to an error.
282 FutureIncompatibleInfo {
283 id: LintId::of(ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE),
284 reference: "issue TBD",
285 edition: Some(Edition::Edition2018),
287 FutureIncompatibleInfo {
288 id: LintId::of(DUPLICATE_ASSOCIATED_TYPE_BINDINGS),
289 reference: "issue #50589 <https://github.com/rust-lang/rust/issues/50589>",
294 // Register renamed and removed lints
295 store.register_renamed("single_use_lifetime", "single_use_lifetimes");
296 store.register_renamed("elided_lifetime_in_path", "elided_lifetimes_in_paths");
297 store.register_renamed("bare_trait_object", "bare_trait_objects");
298 store.register_renamed("unstable_name_collision", "unstable_name_collisions");
299 store.register_renamed("unused_doc_comment", "unused_doc_comments");
300 store.register_renamed("unknown_features", "unused_features");
301 store.register_removed("unsigned_negation", "replaced by negate_unsigned feature gate");
302 store.register_removed("negate_unsigned", "cast a signed value instead");
303 store.register_removed("raw_pointer_derive", "using derive with raw pointers is ok");
304 // This was renamed to raw_pointer_derive, which was then removed,
305 // so it is also considered removed
306 store.register_removed("raw_pointer_deriving", "using derive with raw pointers is ok");
307 store.register_removed("drop_with_repr_extern", "drop flags have been removed");
308 store.register_removed("fat_ptr_transmutes", "was accidentally removed back in 2014");
309 store.register_removed("deprecated_attr", "use `deprecated` instead");
310 store.register_removed("transmute_from_fn_item_types",
311 "always cast functions before transmuting them");
312 store.register_removed("hr_lifetime_in_assoc_type",
313 "converted into hard error, see https://github.com/rust-lang/rust/issues/33685");
314 store.register_removed("inaccessible_extern_crate",
315 "converted into hard error, see https://github.com/rust-lang/rust/issues/36886");
316 store.register_removed("super_or_self_in_global_path",
317 "converted into hard error, see https://github.com/rust-lang/rust/issues/36888");
318 store.register_removed("overlapping_inherent_impls",
319 "converted into hard error, see https://github.com/rust-lang/rust/issues/36889");
320 store.register_removed("illegal_floating_point_constant_pattern",
321 "converted into hard error, see https://github.com/rust-lang/rust/issues/36890");
322 store.register_removed("illegal_struct_or_enum_constant_pattern",
323 "converted into hard error, see https://github.com/rust-lang/rust/issues/36891");
324 store.register_removed("lifetime_underscore",
325 "converted into hard error, see https://github.com/rust-lang/rust/issues/36892");
326 store.register_removed("extra_requirement_in_impl",
327 "converted into hard error, see https://github.com/rust-lang/rust/issues/37166");
328 store.register_removed("legacy_imports",
329 "converted into hard error, see https://github.com/rust-lang/rust/issues/38260");
330 store.register_removed("coerce_never",
331 "converted into hard error, see https://github.com/rust-lang/rust/issues/48950");
332 store.register_removed("resolve_trait_on_defaulted_unit",
333 "converted into hard error, see https://github.com/rust-lang/rust/issues/48950");