src/librustc_lint/lib.rs

   1 //! Lints, aka compiler warnings.
   2 //!
   3 //! A 'lint' check is a kind of miscellaneous constraint that a user _might_
   4 //! want to enforce, but might reasonably want to permit as well, on a
   5 //! module-by-module basis. They contrast with static constraints enforced by
   6 //! other phases of the compiler, which are generally required to hold in order
   7 //! to compile the program at all.
   8 //!
   9 //! Most lints can be written as `LintPass` instances. These run after
  10 //! all other analyses. The `LintPass`es built into rustc are defined
  11 //! within `rustc_session::lint::builtin`,
  12 //! which has further comments on how to add such a lint.
  13 //! rustc can also load user-defined lint plugins via the plugin mechanism.
  14 //!
  15 //! Some of rustc's lints are defined elsewhere in the compiler and work by
  16 //! calling `add_lint()` on the overall `Session` object. This works when
  17 //! it happens before the main lint pass, which emits the lints stored by
  18 //! `add_lint()`. To emit lints after the main lint pass (from codegen, for
  19 //! example) requires more effort. See `emit_lint` and `GatherNodeLevels`
  20 //! in `context.rs`.
  21 //!
  22 //! Some code also exists in `rustc_session::lint`, `rustc::lint`.
  23 //!
  24 //! ## Note
  25 //!
  26 //! This API is completely unstable and subject to change.
  27
  28 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
  29 #![cfg_attr(test, feature(test))]
  30 #![feature(bool_to_option)]
  31 #![feature(box_syntax)]
  32 #![feature(crate_visibility_modifier)]
  33 #![feature(never_type)]
  34 #![feature(nll)]
  35 #![recursion_limit = "256"]
  36
  37 #[macro_use]
  38 extern crate rustc;
  39 #[macro_use]
  40 extern crate rustc_session;
  41
  42 mod array_into_iter;
  43 pub mod builtin;
  44 mod context;
  45 mod early;
  46 mod internal;
  47 mod late;
  48 mod levels;
  49 mod non_ascii_idents;
  50 mod nonstandard_style;
  51 mod passes;
  52 mod redundant_semicolon;
  53 mod types;
  54 mod unused;
  55
  56 use rustc::ty::query::Providers;
  57 use rustc::ty::TyCtxt;
  58 use rustc_ast::ast;
  59 use rustc_hir as hir;
  60 use rustc_hir::def_id::DefId;
  61 use rustc_session::lint::builtin::{
  62     BARE_TRAIT_OBJECTS, ELIDED_LIFETIMES_IN_PATHS, EXPLICIT_OUTLIVES_REQUIREMENTS,
  63     INTRA_DOC_LINK_RESOLUTION_FAILURE, MISSING_DOC_CODE_EXAMPLES, PRIVATE_DOC_TESTS,
  64 };
  65 use rustc_span::Span;
  66
  67 use array_into_iter::ArrayIntoIter;
  68 use builtin::*;
  69 use internal::*;
  70 use non_ascii_idents::*;
  71 use nonstandard_style::*;
  72 use redundant_semicolon::*;
  73 use types::*;
  74 use unused::*;
  75
  76 /// Useful for other parts of the compiler / Clippy.
  77 pub use builtin::SoftLints;
  78 pub use context::{CheckLintNameResult, EarlyContext, LateContext, LintContext, LintStore};
  79 pub use early::check_ast_crate;
  80 pub use late::check_crate;
  81 pub use passes::{EarlyLintPass, LateLintPass};
  82 pub use rustc_session::lint::Level::{self, *};
  83 pub use rustc_session::lint::{BufferedEarlyLint, FutureIncompatibleInfo, Lint, LintId};
  84 pub use rustc_session::lint::{LintArray, LintPass};
  85
  86 pub fn provide(providers: &mut Providers<'_>) {
  87     levels::provide(providers);
  88     *providers = Providers { lint_mod, ..*providers };
  89 }
  90
  91 fn lint_mod(tcx: TyCtxt<'_>, module_def_id: DefId) {
  92     late::late_lint_mod(tcx, module_def_id, BuiltinCombinedModuleLateLintPass::new());
  93 }
  94
  95 macro_rules! pre_expansion_lint_passes {
  96     ($macro:path, $args:tt) => {
  97         $macro!($args, [KeywordIdents: KeywordIdents,]);
  98     };
  99 }
 100
 101 macro_rules! early_lint_passes {
 102     ($macro:path, $args:tt) => {
 103         $macro!(
 104             $args,
 105             [
 106                 UnusedParens: UnusedParens,
 107                 UnusedImportBraces: UnusedImportBraces,
 108                 UnsafeCode: UnsafeCode,
 109                 AnonymousParameters: AnonymousParameters,
 110                 EllipsisInclusiveRangePatterns: EllipsisInclusiveRangePatterns::default(),
 111                 NonCamelCaseTypes: NonCamelCaseTypes,
 112                 DeprecatedAttr: DeprecatedAttr::new(),
 113                 WhileTrue: WhileTrue,
 114                 NonAsciiIdents: NonAsciiIdents,
 115                 IncompleteFeatures: IncompleteFeatures,
 116                 RedundantSemicolons: RedundantSemicolons,
 117                 UnusedDocComment: UnusedDocComment,
 118             ]
 119         );
 120     };
 121 }
 122
 123 macro_rules! declare_combined_early_pass {
 124     ([$name:ident], $passes:tt) => (
 125         early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]);
 126     )
 127 }
 128
 129 pre_expansion_lint_passes!(declare_combined_early_pass, [BuiltinCombinedPreExpansionLintPass]);
 130 early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]);
 131
 132 macro_rules! late_lint_passes {
 133     ($macro:path, $args:tt) => {
 134         $macro!(
 135             $args,
 136             [
 137                 // FIXME: Look into regression when this is used as a module lint
 138                 // May Depend on constants elsewhere
 139                 UnusedBrokenConst: UnusedBrokenConst,
 140                 // Uses attr::is_used which is untracked, can't be an incremental module pass.
 141                 UnusedAttributes: UnusedAttributes::new(),
 142                 // Needs to run after UnusedAttributes as it marks all `feature` attributes as used.
 143                 UnstableFeatures: UnstableFeatures,
 144                 // Tracks state across modules
 145                 UnnameableTestItems: UnnameableTestItems::new(),
 146                 // Tracks attributes of parents
 147                 MissingDoc: MissingDoc::new(),
 148                 // Depends on access levels
 149                 // FIXME: Turn the computation of types which implement Debug into a query
 150                 // and change this to a module lint pass
 151                 MissingDebugImplementations: MissingDebugImplementations::default(),
 152                 ArrayIntoIter: ArrayIntoIter,
 153             ]
 154         );
 155     };
 156 }
 157
 158 macro_rules! late_lint_mod_passes {
 159     ($macro:path, $args:tt) => {
 160         $macro!(
 161             $args,
 162             [
 163                 HardwiredLints: HardwiredLints,
 164                 ImproperCTypes: ImproperCTypes,
 165                 VariantSizeDifferences: VariantSizeDifferences,
 166                 BoxPointers: BoxPointers,
 167                 PathStatements: PathStatements,
 168                 // Depends on referenced function signatures in expressions
 169                 UnusedResults: UnusedResults,
 170                 NonUpperCaseGlobals: NonUpperCaseGlobals,
 171                 NonShorthandFieldPatterns: NonShorthandFieldPatterns,
 172                 UnusedAllocation: UnusedAllocation,
 173                 // Depends on types used in type definitions
 174                 MissingCopyImplementations: MissingCopyImplementations,
 175                 // Depends on referenced function signatures in expressions
 176                 MutableTransmutes: MutableTransmutes,
 177                 TypeAliasBounds: TypeAliasBounds,
 178                 TrivialConstraints: TrivialConstraints,
 179                 TypeLimits: TypeLimits::new(),
 180                 NonSnakeCase: NonSnakeCase,
 181                 InvalidNoMangleItems: InvalidNoMangleItems,
 182                 // Depends on access levels
 183                 UnreachablePub: UnreachablePub,
 184                 ExplicitOutlivesRequirements: ExplicitOutlivesRequirements,
 185                 InvalidValue: InvalidValue,
 186             ]
 187         );
 188     };
 189 }
 190
 191 macro_rules! declare_combined_late_pass {
 192     ([$v:vis $name:ident], $passes:tt) => (
 193         late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]);
 194     )
 195 }
 196
 197 // FIXME: Make a separate lint type which do not require typeck tables
 198 late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]);
 199
 200 late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]);
 201
 202 pub fn new_lint_store(no_interleave_lints: bool, internal_lints: bool) -> LintStore {
 203     let mut lint_store = LintStore::new();
 204
 205     register_builtins(&mut lint_store, no_interleave_lints);
 206     if internal_lints {
 207         register_internals(&mut lint_store);
 208     }
 209
 210     lint_store
 211 }
 212
 213 /// Tell the `LintStore` about all the built-in lints (the ones
 214 /// defined in this crate and the ones defined in
 215 /// `rustc::lint::builtin`).
 216 fn register_builtins(store: &mut LintStore, no_interleave_lints: bool) {
 217     macro_rules! add_lint_group {
 218         ($name:expr, $($lint:ident),*) => (
 219             store.register_group(false, $name, None, vec![$(LintId::of($lint)),*]);
 220         )
 221     }
 222
 223     macro_rules! register_pass {
 224         ($method:ident, $ty:ident, $constructor:expr) => {
 225             store.register_lints(&$ty::get_lints());
 226             store.$method(|| box $constructor);
 227         };
 228     }
 229
 230     macro_rules! register_passes {
 231         ($method:ident, [$($passes:ident: $constructor:expr,)*]) => (
 232             $(
 233                 register_pass!($method, $passes, $constructor);
 234             )*
 235         )
 236     }
 237
 238     if no_interleave_lints {
 239         pre_expansion_lint_passes!(register_passes, register_pre_expansion_pass);
 240         early_lint_passes!(register_passes, register_early_pass);
 241         late_lint_passes!(register_passes, register_late_pass);
 242         late_lint_mod_passes!(register_passes, register_late_mod_pass);
 243     } else {
 244         store.register_lints(&BuiltinCombinedPreExpansionLintPass::get_lints());
 245         store.register_lints(&BuiltinCombinedEarlyLintPass::get_lints());
 246         store.register_lints(&BuiltinCombinedModuleLateLintPass::get_lints());
 247         store.register_lints(&BuiltinCombinedLateLintPass::get_lints());
 248     }
 249
 250     add_lint_group!(
 251         "nonstandard_style",
 252         NON_CAMEL_CASE_TYPES,
 253         NON_SNAKE_CASE,
 254         NON_UPPER_CASE_GLOBALS
 255     );
 256
 257     add_lint_group!(
 258         "unused",
 259         UNUSED_IMPORTS,
 260         UNUSED_VARIABLES,
 261         UNUSED_ASSIGNMENTS,
 262         DEAD_CODE,
 263         UNUSED_MUT,
 264         UNREACHABLE_CODE,
 265         UNREACHABLE_PATTERNS,
 266         OVERLAPPING_PATTERNS,
 267         UNUSED_MUST_USE,
 268         UNUSED_UNSAFE,
 269         PATH_STATEMENTS,
 270         UNUSED_ATTRIBUTES,
 271         UNUSED_MACROS,
 272         UNUSED_ALLOCATION,
 273         UNUSED_DOC_COMMENTS,
 274         UNUSED_EXTERN_CRATES,
 275         UNUSED_FEATURES,
 276         UNUSED_LABELS,
 277         UNUSED_PARENS,
 278         REDUNDANT_SEMICOLONS
 279     );
 280
 281     add_lint_group!(
 282         "rust_2018_idioms",
 283         BARE_TRAIT_OBJECTS,
 284         UNUSED_EXTERN_CRATES,
 285         ELLIPSIS_INCLUSIVE_RANGE_PATTERNS,
 286         ELIDED_LIFETIMES_IN_PATHS,
 287         EXPLICIT_OUTLIVES_REQUIREMENTS // FIXME(#52665, #47816) not always applicable and not all
 288                                        // macros are ready for this yet.
 289                                        // UNREACHABLE_PUB,
 290
 291                                        // FIXME macro crates are not up for this yet, too much
 292                                        // breakage is seen if we try to encourage this lint.
 293                                        // MACRO_USE_EXTERN_CRATE
 294     );
 295
 296     add_lint_group!(
 297         "rustdoc",
 298         INTRA_DOC_LINK_RESOLUTION_FAILURE,
 299         MISSING_DOC_CODE_EXAMPLES,
 300         PRIVATE_DOC_TESTS
 301     );
 302
 303     // Register renamed and removed lints.
 304     store.register_renamed("single_use_lifetime", "single_use_lifetimes");
 305     store.register_renamed("elided_lifetime_in_path", "elided_lifetimes_in_paths");
 306     store.register_renamed("bare_trait_object", "bare_trait_objects");
 307     store.register_renamed("unstable_name_collision", "unstable_name_collisions");
 308     store.register_renamed("unused_doc_comment", "unused_doc_comments");
 309     store.register_renamed("async_idents", "keyword_idents");
 310     store.register_renamed("exceeding_bitshifts", "arithmetic_overflow");
 311     store.register_renamed("redundant_semicolon", "redundant_semicolons");
 312     store.register_removed("unknown_features", "replaced by an error");
 313     store.register_removed("unsigned_negation", "replaced by negate_unsigned feature gate");
 314     store.register_removed("negate_unsigned", "cast a signed value instead");
 315     store.register_removed("raw_pointer_derive", "using derive with raw pointers is ok");
 316     // Register lint group aliases.
 317     store.register_group_alias("nonstandard_style", "bad_style");
 318     // This was renamed to `raw_pointer_derive`, which was then removed,
 319     // so it is also considered removed.
 320     store.register_removed("raw_pointer_deriving", "using derive with raw pointers is ok");
 321     store.register_removed("drop_with_repr_extern", "drop flags have been removed");
 322     store.register_removed("fat_ptr_transmutes", "was accidentally removed back in 2014");
 323     store.register_removed("deprecated_attr", "use `deprecated` instead");
 324     store.register_removed(
 325         "transmute_from_fn_item_types",
 326         "always cast functions before transmuting them",
 327     );
 328     store.register_removed(
 329         "hr_lifetime_in_assoc_type",
 330         "converted into hard error, see issue #33685 \
 331          <https://github.com/rust-lang/rust/issues/33685> for more information",
 332     );
 333     store.register_removed(
 334         "inaccessible_extern_crate",
 335         "converted into hard error, see issue #36886 \
 336          <https://github.com/rust-lang/rust/issues/36886> for more information",
 337     );
 338     store.register_removed(
 339         "super_or_self_in_global_path",
 340         "converted into hard error, see issue #36888 \
 341          <https://github.com/rust-lang/rust/issues/36888> for more information",
 342     );
 343     store.register_removed(
 344         "overlapping_inherent_impls",
 345         "converted into hard error, see issue #36889 \
 346          <https://github.com/rust-lang/rust/issues/36889> for more information",
 347     );
 348     store.register_removed(
 349         "illegal_floating_point_constant_pattern",
 350         "converted into hard error, see issue #36890 \
 351          <https://github.com/rust-lang/rust/issues/36890> for more information",
 352     );
 353     store.register_removed(
 354         "illegal_struct_or_enum_constant_pattern",
 355         "converted into hard error, see issue #36891 \
 356          <https://github.com/rust-lang/rust/issues/36891> for more information",
 357     );
 358     store.register_removed(
 359         "lifetime_underscore",
 360         "converted into hard error, see issue #36892 \
 361          <https://github.com/rust-lang/rust/issues/36892> for more information",
 362     );
 363     store.register_removed(
 364         "extra_requirement_in_impl",
 365         "converted into hard error, see issue #37166 \
 366          <https://github.com/rust-lang/rust/issues/37166> for more information",
 367     );
 368     store.register_removed(
 369         "legacy_imports",
 370         "converted into hard error, see issue #38260 \
 371          <https://github.com/rust-lang/rust/issues/38260> for more information",
 372     );
 373     store.register_removed(
 374         "coerce_never",
 375         "converted into hard error, see issue #48950 \
 376          <https://github.com/rust-lang/rust/issues/48950> for more information",
 377     );
 378     store.register_removed(
 379         "resolve_trait_on_defaulted_unit",
 380         "converted into hard error, see issue #48950 \
 381          <https://github.com/rust-lang/rust/issues/48950> for more information",
 382     );
 383     store.register_removed(
 384         "private_no_mangle_fns",
 385         "no longer a warning, `#[no_mangle]` functions always exported",
 386     );
 387     store.register_removed(
 388         "private_no_mangle_statics",
 389         "no longer a warning, `#[no_mangle]` statics always exported",
 390     );
 391     store.register_removed("bad_repr", "replaced with a generic attribute input check");
 392     store.register_removed(
 393         "duplicate_matcher_binding_name",
 394         "converted into hard error, see issue #57742 \
 395          <https://github.com/rust-lang/rust/issues/57742> for more information",
 396     );
 397     store.register_removed(
 398         "incoherent_fundamental_impls",
 399         "converted into hard error, see issue #46205 \
 400          <https://github.com/rust-lang/rust/issues/46205> for more information",
 401     );
 402     store.register_removed(
 403         "legacy_constructor_visibility",
 404         "converted into hard error, see issue #39207 \
 405          <https://github.com/rust-lang/rust/issues/39207> for more information",
 406     );
 407     store.register_removed(
 408         "legacy_directory_ownership",
 409         "converted into hard error, see issue #37872 \
 410          <https://github.com/rust-lang/rust/issues/37872> for more information",
 411     );
 412     store.register_removed(
 413         "safe_extern_statics",
 414         "converted into hard error, see issue #36247 \
 415          <https://github.com/rust-lang/rust/issues/36247> for more information",
 416     );
 417     store.register_removed(
 418         "parenthesized_params_in_types_and_modules",
 419         "converted into hard error, see issue #42238 \
 420          <https://github.com/rust-lang/rust/issues/42238> for more information",
 421     );
 422     store.register_removed(
 423         "duplicate_macro_exports",
 424         "converted into hard error, see issue #35896 \
 425          <https://github.com/rust-lang/rust/issues/35896> for more information",
 426     );
 427     store.register_removed(
 428         "nested_impl_trait",
 429         "converted into hard error, see issue #59014 \
 430          <https://github.com/rust-lang/rust/issues/59014> for more information",
 431     );
 432     store.register_removed("plugin_as_library", "plugins have been deprecated and retired");
 433 }
 434
 435 fn register_internals(store: &mut LintStore) {
 436     store.register_lints(&DefaultHashTypes::get_lints());
 437     store.register_early_pass(|| box DefaultHashTypes::new());
 438     store.register_lints(&LintPassImpl::get_lints());
 439     store.register_early_pass(|| box LintPassImpl);
 440     store.register_lints(&TyTyKind::get_lints());
 441     store.register_late_pass(|| box TyTyKind);
 442     store.register_group(
 443         false,
 444         "rustc::internal",
 445         None,
 446         vec![
 447             LintId::of(DEFAULT_HASH_TYPES),
 448             LintId::of(USAGE_OF_TY_TYKIND),
 449             LintId::of(LINT_PASS_IMPL_WITHOUT_MACRO),
 450             LintId::of(TY_PASS_BY_REFERENCE),
 451             LintId::of(USAGE_OF_QUALIFIED_TY),
 452         ],
 453     );
 454 }