1 // Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 //! See The Book chapter on the borrow checker for more details.
13 #![allow(non_camel_case_types)]
15 pub use self::LoanPathKind::*;
16 pub use self::LoanPathElem::*;
17 pub use self::bckerr_code::*;
18 pub use self::AliasableViolationKind::*;
19 pub use self::MovedValueUseKind::*;
21 pub use self::mir::elaborate_drops::ElaborateDrops;
23 use self::InteriorKind::*;
25 use rustc::dep_graph::DepNode;
26 use rustc::hir::map as hir_map;
27 use rustc::hir::map::blocks::FnLikeNode;
29 use rustc::middle::dataflow::DataFlowContext;
30 use rustc::middle::dataflow::BitwiseOperator;
31 use rustc::middle::dataflow::DataFlowOperator;
32 use rustc::middle::dataflow::KillFrom;
33 use rustc::hir::def_id::DefId;
34 use rustc::middle::expr_use_visitor as euv;
35 use rustc::middle::free_region::FreeRegionMap;
36 use rustc::middle::mem_categorization as mc;
37 use rustc::middle::mem_categorization::Categorization;
38 use rustc::middle::region;
39 use rustc::ty::{self, TyCtxt};
44 use std::hash::{Hash, Hasher};
46 use syntax_pos::{MultiSpan, Span};
47 use errors::DiagnosticBuilder;
50 use rustc::hir::intravisit::{self, Visitor, FnKind, NestedVisitorMap};
60 #[derive(Clone, Copy)]
61 pub struct LoanDataFlowOperator;
63 pub type LoanDataFlow<'a, 'tcx> = DataFlowContext<'a, 'tcx, LoanDataFlowOperator>;
65 impl<'a, 'tcx> Visitor<'tcx> for BorrowckCtxt<'a, 'tcx> {
66 fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
67 NestedVisitorMap::OnlyBodies(&self.tcx.hir)
70 fn visit_fn(&mut self, fk: FnKind<'tcx>, fd: &'tcx hir::FnDecl,
71 b: hir::BodyId, s: Span, id: ast::NodeId) {
74 FnKind::Method(..) => {
75 self.with_temp_region_map(id, |this| {
76 borrowck_fn(this, fk, fd, b, s, id, fk.attrs())
80 FnKind::Closure(..) => {
81 borrowck_fn(self, fk, fd, b, s, id, fk.attrs());
86 fn visit_item(&mut self, item: &'tcx hir::Item) {
87 borrowck_item(self, item);
90 fn visit_trait_item(&mut self, ti: &'tcx hir::TraitItem) {
91 if let hir::TraitItemKind::Const(_, Some(expr)) = ti.node {
92 gather_loans::gather_loans_in_static_initializer(self, expr);
94 intravisit::walk_trait_item(self, ti);
97 fn visit_impl_item(&mut self, ii: &'tcx hir::ImplItem) {
98 if let hir::ImplItemKind::Const(_, expr) = ii.node {
99 gather_loans::gather_loans_in_static_initializer(self, expr);
101 intravisit::walk_impl_item(self, ii);
105 pub fn check_crate<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>) {
106 let mut bccx = BorrowckCtxt {
108 free_region_map: FreeRegionMap::new(),
110 loaned_paths_same: 0,
117 tcx.visit_all_item_likes_in_krate(DepNode::BorrowCheck, &mut bccx.as_deep_visitor());
119 if tcx.sess.borrowck_stats() {
120 println!("--- borrowck stats ---");
121 println!("paths requiring guarantees: {}",
122 bccx.stats.guaranteed_paths);
123 println!("paths requiring loans : {}",
124 make_stat(&bccx, bccx.stats.loaned_paths_same));
125 println!("paths requiring imm loans : {}",
126 make_stat(&bccx, bccx.stats.loaned_paths_imm));
127 println!("stable paths : {}",
128 make_stat(&bccx, bccx.stats.stable_paths));
131 fn make_stat(bccx: &BorrowckCtxt, stat: usize) -> String {
132 let total = bccx.stats.guaranteed_paths as f64;
133 let perc = if total == 0.0 { 0.0 } else { stat as f64 * 100.0 / total };
134 format!("{} ({:.0}%)", stat, perc)
138 fn borrowck_item<'a, 'tcx>(this: &mut BorrowckCtxt<'a, 'tcx>, item: &'tcx hir::Item) {
139 // Gather loans for items. Note that we don't need
140 // to check loans for single expressions. The check
141 // loan step is intended for things that have a data
142 // flow dependent conditions.
144 hir::ItemStatic(.., ex) |
145 hir::ItemConst(_, ex) => {
146 gather_loans::gather_loans_in_static_initializer(this, ex);
151 intravisit::walk_item(this, item);
154 /// Collection of conclusions determined via borrow checker analyses.
155 pub struct AnalysisData<'a, 'tcx: 'a> {
156 pub all_loans: Vec<Loan<'tcx>>,
157 pub loans: DataFlowContext<'a, 'tcx, LoanDataFlowOperator>,
158 pub move_data: move_data::FlowedMoveData<'a, 'tcx>,
161 fn borrowck_fn<'a, 'tcx>(this: &mut BorrowckCtxt<'a, 'tcx>,
163 decl: &'tcx hir::FnDecl,
164 body_id: hir::BodyId,
167 attributes: &[ast::Attribute]) {
168 debug!("borrowck_fn(id={})", id);
170 let body = this.tcx.hir.body(body_id);
172 if attributes.iter().any(|item| item.check_name("rustc_mir_borrowck")) {
173 this.with_temp_region_map(id, |this| {
174 mir::borrowck_mir(this, id, attributes)
178 let cfg = cfg::CFG::new(this.tcx, &body.value);
179 let AnalysisData { all_loans,
181 move_data: flowed_moves } =
182 build_borrowck_dataflow_data(this, &cfg, body_id);
184 move_data::fragments::instrument_move_fragments(&flowed_moves.move_data,
188 move_data::fragments::build_unfragmented_map(this,
189 &flowed_moves.move_data,
192 check_loans::check_loans(this, &loan_dfcx, &flowed_moves, &all_loans[..], body);
194 intravisit::walk_fn(this, fk, decl, body_id, sp, id);
197 fn build_borrowck_dataflow_data<'a, 'tcx>(this: &mut BorrowckCtxt<'a, 'tcx>,
199 body_id: hir::BodyId)
200 -> AnalysisData<'a, 'tcx>
202 // Check the body of fn items.
204 let body = tcx.hir.body(body_id);
206 let mut visitor = intravisit::IdRangeComputingVisitor::new(&tcx.hir);
207 visitor.visit_body(body);
210 let (all_loans, move_data) =
211 gather_loans::gather_loans_in_fn(this, body_id);
214 DataFlowContext::new(this.tcx,
218 LoanDataFlowOperator,
221 for (loan_idx, loan) in all_loans.iter().enumerate() {
222 loan_dfcx.add_gen(loan.gen_scope.node_id(&tcx.region_maps), loan_idx);
223 loan_dfcx.add_kill(KillFrom::ScopeEnd,
224 loan.kill_scope.node_id(&tcx.region_maps), loan_idx);
226 loan_dfcx.add_kills_from_flow_exits(cfg);
227 loan_dfcx.propagate(cfg, body);
229 let flowed_moves = move_data::FlowedMoveData::new(move_data,
235 AnalysisData { all_loans: all_loans,
237 move_data:flowed_moves }
240 /// Accessor for introspective clients inspecting `AnalysisData` and
241 /// the `BorrowckCtxt` itself , e.g. the flowgraph visualizer.
242 pub fn build_borrowck_dataflow_data_for_fn<'a, 'tcx>(
243 tcx: TyCtxt<'a, 'tcx, 'tcx>,
246 -> (BorrowckCtxt<'a, 'tcx>, AnalysisData<'a, 'tcx>)
249 let mut bccx = BorrowckCtxt {
251 free_region_map: FreeRegionMap::new(),
253 loaned_paths_same: 0,
260 let dataflow_data = build_borrowck_dataflow_data(&mut bccx, cfg, body);
261 (bccx, dataflow_data)
264 // ----------------------------------------------------------------------
267 pub struct BorrowckCtxt<'a, 'tcx: 'a> {
268 tcx: TyCtxt<'a, 'tcx, 'tcx>,
270 // Hacky. As we visit various fns, we have to load up the
271 // free-region map for each one. This map is computed by during
272 // typeck for each fn item and stored -- closures just use the map
273 // from the fn item that encloses them. Since we walk the fns in
274 // order, we basically just overwrite this field as we enter a fn
275 // item and restore it afterwards in a stack-like fashion. Then
276 // the borrow checking code can assume that `free_region_map` is
277 // always the correct map for the current fn. Feels like it'd be
278 // better to just recompute this, rather than store it, but it's a
279 // bit of a pain to factor that code out at the moment.
280 free_region_map: FreeRegionMap,
288 loaned_paths_same: usize,
289 loaned_paths_imm: usize,
291 guaranteed_paths: usize
294 ///////////////////////////////////////////////////////////////////////////
295 // Loans and loan paths
297 /// Record of a loan that was issued.
298 pub struct Loan<'tcx> {
300 loan_path: Rc<LoanPath<'tcx>>,
301 kind: ty::BorrowKind,
302 restricted_paths: Vec<Rc<LoanPath<'tcx>>>,
304 /// gen_scope indicates where loan is introduced. Typically the
305 /// loan is introduced at the point of the borrow, but in some
306 /// cases, notably method arguments, the loan may be introduced
307 /// only later, once it comes into scope. See also
308 /// `GatherLoanCtxt::compute_gen_scope`.
309 gen_scope: region::CodeExtent,
311 /// kill_scope indicates when the loan goes out of scope. This is
312 /// either when the lifetime expires or when the local variable
313 /// which roots the loan-path goes out of scope, whichever happens
314 /// faster. See also `GatherLoanCtxt::compute_kill_scope`.
315 kill_scope: region::CodeExtent,
317 cause: euv::LoanCause,
320 impl<'tcx> Loan<'tcx> {
321 pub fn loan_path(&self) -> Rc<LoanPath<'tcx>> {
322 self.loan_path.clone()
327 pub struct LoanPath<'tcx> {
328 kind: LoanPathKind<'tcx>,
332 impl<'tcx> PartialEq for LoanPath<'tcx> {
333 fn eq(&self, that: &LoanPath<'tcx>) -> bool {
334 self.kind == that.kind
338 impl<'tcx> Hash for LoanPath<'tcx> {
339 fn hash<H: Hasher>(&self, state: &mut H) {
340 self.kind.hash(state);
344 #[derive(PartialEq, Eq, Hash, Debug)]
345 pub enum LoanPathKind<'tcx> {
346 LpVar(ast::NodeId), // `x` in README.md
347 LpUpvar(ty::UpvarId), // `x` captured by-value into closure
348 LpDowncast(Rc<LoanPath<'tcx>>, DefId), // `x` downcast to particular enum variant
349 LpExtend(Rc<LoanPath<'tcx>>, mc::MutabilityCategory, LoanPathElem<'tcx>)
352 impl<'tcx> LoanPath<'tcx> {
353 fn new(kind: LoanPathKind<'tcx>, ty: ty::Ty<'tcx>) -> LoanPath<'tcx> {
354 LoanPath { kind: kind, ty: ty }
357 fn to_type(&self) -> ty::Ty<'tcx> { self.ty }
360 // FIXME (pnkfelix): See discussion here
361 // https://github.com/pnkfelix/rust/commit/
362 // b2b39e8700e37ad32b486b9a8409b50a8a53aa51#commitcomment-7892003
363 const DOWNCAST_PRINTED_OPERATOR: &'static str = " as ";
365 // A local, "cleaned" version of `mc::InteriorKind` that drops
366 // information that is not relevant to loan-path analysis. (In
367 // particular, the distinction between how precisely an array-element
368 // is tracked is irrelevant here.)
369 #[derive(Clone, Copy, PartialEq, Eq, Hash)]
370 pub enum InteriorKind {
371 InteriorField(mc::FieldName),
372 InteriorElement(mc::ElementKind),
375 trait ToInteriorKind { fn cleaned(self) -> InteriorKind; }
376 impl ToInteriorKind for mc::InteriorKind {
377 fn cleaned(self) -> InteriorKind {
379 mc::InteriorField(name) => InteriorField(name),
380 mc::InteriorElement(_, elem_kind) => InteriorElement(elem_kind),
386 // - a pointer dereference (`*LV` in README.md)
387 // - a field reference, with an optional definition of the containing
388 // enum variant (`LV.f` in README.md)
389 // `DefId` is present when the field is part of struct that is in
390 // a variant of an enum. For instance in:
391 // `enum E { X { foo: u32 }, Y { foo: u32 }}`
392 // each `foo` is qualified by the definitition id of the variant (`X` or `Y`).
393 #[derive(Copy, Clone, PartialEq, Eq, Hash, Debug)]
394 pub enum LoanPathElem<'tcx> {
395 LpDeref(mc::PointerKind<'tcx>),
396 LpInterior(Option<DefId>, InteriorKind),
399 pub fn closure_to_block(closure_id: ast::NodeId,
400 tcx: TyCtxt) -> ast::NodeId {
401 match tcx.hir.get(closure_id) {
402 hir_map::NodeExpr(expr) => match expr.node {
403 hir::ExprClosure(.., body_id, _) => {
407 bug!("encountered non-closure id: {}", closure_id)
410 _ => bug!("encountered non-expr id: {}", closure_id)
414 impl<'a, 'tcx> LoanPath<'tcx> {
415 pub fn kill_scope(&self, tcx: TyCtxt<'a, 'tcx, 'tcx>) -> region::CodeExtent {
417 LpVar(local_id) => tcx.region_maps.var_scope(local_id),
418 LpUpvar(upvar_id) => {
419 let block_id = closure_to_block(upvar_id.closure_expr_id, tcx);
420 tcx.region_maps.node_extent(block_id)
422 LpDowncast(ref base, _) |
423 LpExtend(ref base, ..) => base.kill_scope(tcx),
427 fn has_fork(&self, other: &LoanPath<'tcx>) -> bool {
428 match (&self.kind, &other.kind) {
429 (&LpExtend(ref base, _, LpInterior(opt_variant_id, id)),
430 &LpExtend(ref base2, _, LpInterior(opt_variant_id2, id2))) =>
431 if id == id2 && opt_variant_id == opt_variant_id2 {
432 base.has_fork(&base2)
436 (&LpExtend(ref base, _, LpDeref(_)), _) => base.has_fork(other),
437 (_, &LpExtend(ref base, _, LpDeref(_))) => self.has_fork(&base),
442 fn depth(&self) -> usize {
444 LpExtend(ref base, _, LpDeref(_)) => base.depth(),
445 LpExtend(ref base, _, LpInterior(..)) => base.depth() + 1,
450 fn common(&self, other: &LoanPath<'tcx>) -> Option<LoanPath<'tcx>> {
451 match (&self.kind, &other.kind) {
452 (&LpExtend(ref base, a, LpInterior(opt_variant_id, id)),
453 &LpExtend(ref base2, _, LpInterior(opt_variant_id2, id2))) => {
454 if id == id2 && opt_variant_id == opt_variant_id2 {
455 base.common(&base2).map(|x| {
457 if base.depth() == xd && base2.depth() == xd {
459 kind: LpExtend(Rc::new(x), a, LpInterior(opt_variant_id, id)),
470 (&LpExtend(ref base, _, LpDeref(_)), _) => base.common(other),
471 (_, &LpExtend(ref other, _, LpDeref(_))) => self.common(&other),
472 (&LpVar(id), &LpVar(id2)) => {
474 Some(LoanPath { kind: LpVar(id), ty: self.ty })
479 (&LpUpvar(id), &LpUpvar(id2)) => {
481 Some(LoanPath { kind: LpUpvar(id), ty: self.ty })
491 pub fn opt_loan_path<'tcx>(cmt: &mc::cmt<'tcx>) -> Option<Rc<LoanPath<'tcx>>> {
492 //! Computes the `LoanPath` (if any) for a `cmt`.
493 //! Note that this logic is somewhat duplicated in
494 //! the method `compute()` found in `gather_loans::restrictions`,
495 //! which allows it to share common loan path pieces as it
496 //! traverses the CMT.
498 let new_lp = |v: LoanPathKind<'tcx>| Rc::new(LoanPath::new(v, cmt.ty));
501 Categorization::Rvalue(..) |
502 Categorization::StaticItem => {
506 Categorization::Local(id) => {
507 Some(new_lp(LpVar(id)))
510 Categorization::Upvar(mc::Upvar { id, .. }) => {
511 Some(new_lp(LpUpvar(id)))
514 Categorization::Deref(ref cmt_base, _, pk) => {
515 opt_loan_path(cmt_base).map(|lp| {
516 new_lp(LpExtend(lp, cmt.mutbl, LpDeref(pk)))
520 Categorization::Interior(ref cmt_base, ik) => {
521 opt_loan_path(cmt_base).map(|lp| {
522 let opt_variant_id = match cmt_base.cat {
523 Categorization::Downcast(_, did) => Some(did),
526 new_lp(LpExtend(lp, cmt.mutbl, LpInterior(opt_variant_id, ik.cleaned())))
530 Categorization::Downcast(ref cmt_base, variant_def_id) =>
531 opt_loan_path(cmt_base)
533 new_lp(LpDowncast(lp, variant_def_id))
539 ///////////////////////////////////////////////////////////////////////////
542 // Errors that can occur
543 #[derive(Debug, PartialEq)]
544 pub enum bckerr_code<'tcx> {
546 /// superscope, subscope, loan cause
547 err_out_of_scope(&'tcx ty::Region, &'tcx ty::Region, euv::LoanCause),
548 err_borrowed_pointer_too_short(&'tcx ty::Region, &'tcx ty::Region), // loan, ptr
551 // Combination of an error code and the categorization of the expression
553 #[derive(Debug, PartialEq)]
554 pub struct BckError<'tcx> {
556 cause: AliasableViolationKind,
558 code: bckerr_code<'tcx>
561 #[derive(Copy, Clone, Debug, PartialEq)]
562 pub enum AliasableViolationKind {
564 BorrowViolation(euv::LoanCause)
567 #[derive(Copy, Clone, Debug)]
568 pub enum MovedValueUseKind {
573 ///////////////////////////////////////////////////////////////////////////
576 impl<'a, 'tcx> BorrowckCtxt<'a, 'tcx> {
577 fn with_temp_region_map<F>(&mut self, id: ast::NodeId, f: F)
578 where F: for <'b> FnOnce(&'b mut BorrowckCtxt<'a, 'tcx>)
580 let new_free_region_map = self.tcx.free_region_map(id);
581 let old_free_region_map = mem::replace(&mut self.free_region_map, new_free_region_map);
583 self.free_region_map = old_free_region_map;
586 pub fn is_subregion_of(&self, r_sub: &'tcx ty::Region, r_sup: &'tcx ty::Region)
589 self.free_region_map.is_subregion_of(self.tcx, r_sub, r_sup)
592 pub fn report(&self, err: BckError<'tcx>) {
593 // Catch and handle some particular cases.
594 match (&err.code, &err.cause) {
595 (&err_out_of_scope(&ty::ReScope(_), &ty::ReStatic, _),
596 &BorrowViolation(euv::ClosureCapture(span))) |
597 (&err_out_of_scope(&ty::ReScope(_), &ty::ReFree(..), _),
598 &BorrowViolation(euv::ClosureCapture(span))) => {
599 return self.report_out_of_scope_escaping_closure_capture(&err, span);
604 let mut db = self.bckerr_to_diag(&err);
605 self.note_and_explain_bckerr(&mut db, err);
609 pub fn report_use_of_moved_value(&self,
611 use_kind: MovedValueUseKind,
613 the_move: &move_data::Move,
614 moved_lp: &LoanPath<'tcx>,
615 _param_env: &ty::ParameterEnvironment<'tcx>) {
616 let (verb, verb_participle) = match use_kind {
617 MovedInUse => ("use", "used"),
618 MovedInCapture => ("capture", "captured"),
621 let (_ol, _moved_lp_msg, mut err) = match the_move.kind {
622 move_data::Declared => {
623 // If this is an uninitialized variable, just emit a simple warning
626 self.tcx.sess, use_span, E0381,
627 "{} of possibly uninitialized variable: `{}`",
629 self.loan_path_to_string(lp))
630 .span_label(use_span, &format!("use of possibly uninitialized `{}`",
631 self.loan_path_to_string(lp)))
636 // If moved_lp is something like `x.a`, and lp is something like `x.b`, we would
637 // normally generate a rather confusing message:
639 // error: use of moved value: `x.b`
640 // note: `x.a` moved here...
642 // What we want to do instead is get the 'common ancestor' of the two moves and
643 // use that for most of the message instead, giving is something like this:
645 // error: use of moved value: `x`
646 // note: `x` moved here (through moving `x.a`)...
648 let common = moved_lp.common(lp);
649 let has_common = common.is_some();
650 let has_fork = moved_lp.has_fork(lp);
651 let (nl, ol, moved_lp_msg) =
652 if has_fork && has_common {
653 let nl = self.loan_path_to_string(&common.unwrap());
655 let moved_lp_msg = format!(" (through moving `{}`)",
656 self.loan_path_to_string(moved_lp));
657 (nl, ol, moved_lp_msg)
659 (self.loan_path_to_string(lp),
660 self.loan_path_to_string(moved_lp),
664 let partial = moved_lp.depth() > lp.depth();
665 let msg = if !has_fork && partial { "partially " }
666 else if has_fork && !has_common { "collaterally "}
668 let err = struct_span_err!(
669 self.tcx.sess, use_span, E0382,
670 "{} of {}moved value: `{}`",
672 (ol, moved_lp_msg, err)}
675 // Get type of value and span where it was previously
677 let (move_span, move_note) = match the_move.kind {
678 move_data::Declared => {
682 move_data::MoveExpr |
683 move_data::MovePat =>
684 (self.tcx.hir.span(the_move.id), ""),
686 move_data::Captured =>
687 (match self.tcx.hir.expect_expr(the_move.id).node {
688 hir::ExprClosure(.., fn_decl_span) => fn_decl_span,
689 ref r => bug!("Captured({}) maps to non-closure: {:?}",
691 }, " (into closure)"),
694 // Annotate the use and the move in the span. Watch out for
695 // the case where the use and the move are the same. This
696 // means the use is in a loop.
697 err = if use_span == move_span {
700 &format!("value moved{} here in previous iteration of loop",
704 err.span_label(use_span, &format!("value {} here after move", verb_participle))
705 .span_label(move_span, &format!("value moved{} here", move_note));
709 err.note(&format!("move occurs because `{}` has type `{}`, \
710 which does not implement the `Copy` trait",
711 self.loan_path_to_string(moved_lp),
714 // Note: we used to suggest adding a `ref binding` or calling
715 // `clone` but those suggestions have been removed because
716 // they are often not what you actually want to do, and were
717 // not considered particularly helpful.
722 pub fn report_partial_reinitialization_of_uninitialized_structure(
725 lp: &LoanPath<'tcx>) {
727 self.tcx.sess, span, E0383,
728 "partial reinitialization of uninitialized structure `{}`",
729 self.loan_path_to_string(lp));
732 pub fn report_reassigned_immutable_variable(&self,
736 &move_data::Assignment) {
737 let mut err = struct_span_err!(
738 self.tcx.sess, span, E0384,
739 "re-assignment of immutable variable `{}`",
740 self.loan_path_to_string(lp));
741 err.span_label(span, &format!("re-assignment of immutable variable"));
742 if span != assign.span {
743 err.span_label(assign.span, &format!("first assignment to `{}`",
744 self.loan_path_to_string(lp)));
749 pub fn span_err(&self, s: Span, m: &str) {
750 self.tcx.sess.span_err(s, m);
753 pub fn struct_span_err<S: Into<MultiSpan>>(&self, s: S, m: &str)
754 -> DiagnosticBuilder<'a> {
755 self.tcx.sess.struct_span_err(s, m)
758 pub fn struct_span_err_with_code<S: Into<MultiSpan>>(&self,
762 -> DiagnosticBuilder<'a> {
763 self.tcx.sess.struct_span_err_with_code(s, msg, code)
766 pub fn span_err_with_code<S: Into<MultiSpan>>(&self, s: S, msg: &str, code: &str) {
767 self.tcx.sess.span_err_with_code(s, msg, code);
770 pub fn bckerr_to_diag(&self, err: &BckError<'tcx>) -> DiagnosticBuilder<'a> {
771 let span = err.span.clone();
772 let mut immutable_field = None;
774 let msg = &match err.code {
776 let descr = match err.cmt.note {
777 mc::NoteClosureEnv(_) | mc::NoteUpvarRef(_) => {
778 self.cmt_to_string(&err.cmt)
780 _ => match opt_loan_path(&err.cmt) {
783 err.cmt.mutbl.to_user_str(),
784 self.cmt_to_string(&err.cmt))
788 format!("{} {} `{}`",
789 err.cmt.mutbl.to_user_str(),
790 self.cmt_to_string(&err.cmt),
791 self.loan_path_to_string(&lp))
797 MutabilityViolation => {
798 format!("cannot assign to {}", descr)
800 BorrowViolation(euv::ClosureCapture(_)) => {
801 format!("closure cannot assign to {}", descr)
803 BorrowViolation(euv::OverloadedOperator) |
804 BorrowViolation(euv::AddrOf) |
805 BorrowViolation(euv::RefBinding) |
806 BorrowViolation(euv::AutoRef) |
807 BorrowViolation(euv::AutoUnsafe) |
808 BorrowViolation(euv::ForLoop) |
809 BorrowViolation(euv::MatchDiscriminant) => {
810 // Check for this field's definition to see if it is an immutable reference
811 // and suggest making it mutable if that is the case.
812 immutable_field = err.cmt.get_field_name()
813 .and_then(|name| err.cmt.get_field(name))
814 .and_then(|did| self.tcx.hir.as_local_node_id(did))
816 if let hir_map::Node::NodeField(ref field) = self.tcx.hir.get(nid) {
817 return self.suggest_mut_for_immutable(&field.ty)
818 .map(|msg| (self.tcx.hir.span(nid), msg));
823 format!("cannot borrow {} as mutable", descr)
825 BorrowViolation(euv::ClosureInvocation) => {
827 "err_mutbl with a closure invocation");
831 err_out_of_scope(..) => {
832 let msg = match opt_loan_path(&err.cmt) {
833 None => "borrowed value".to_string(),
835 format!("`{}`", self.loan_path_to_string(&lp))
838 format!("{} does not live long enough", msg)
840 err_borrowed_pointer_too_short(..) => {
841 let descr = self.cmt_to_path_or_string(&err.cmt);
842 format!("lifetime of {} is too short to guarantee \
843 its contents can be safely reborrowed",
848 let mut db = self.struct_span_err(span, msg);
849 if let Some((span, msg)) = immutable_field {
850 db.span_label(span, &msg);
855 pub fn report_aliasability_violation(&self,
857 kind: AliasableViolationKind,
858 cause: mc::AliasableReason,
859 cmt: mc::cmt<'tcx>) {
860 let mut is_closure = false;
861 let prefix = match kind {
862 MutabilityViolation => {
863 "cannot assign to data"
865 BorrowViolation(euv::ClosureCapture(_)) |
866 BorrowViolation(euv::OverloadedOperator) |
867 BorrowViolation(euv::AddrOf) |
868 BorrowViolation(euv::AutoRef) |
869 BorrowViolation(euv::AutoUnsafe) |
870 BorrowViolation(euv::RefBinding) |
871 BorrowViolation(euv::MatchDiscriminant) => {
872 "cannot borrow data mutably"
875 BorrowViolation(euv::ClosureInvocation) => {
880 BorrowViolation(euv::ForLoop) => {
885 let mut err = match cause {
886 mc::AliasableOther => {
888 self.tcx.sess, span, E0385,
889 "{} in an aliasable location", prefix)
891 mc::AliasableReason::UnaliasableImmutable => {
893 self.tcx.sess, span, E0386,
894 "{} in an immutable container", prefix)
896 mc::AliasableClosure(id) => {
897 let mut err = struct_span_err!(
898 self.tcx.sess, span, E0387,
899 "{} in a captured outer variable in an `Fn` closure", prefix);
900 if let BorrowViolation(euv::ClosureCapture(_)) = kind {
901 // The aliasability violation with closure captures can
902 // happen for nested closures, so we know the enclosing
903 // closure incorrectly accepts an `Fn` while it needs to
905 span_help!(&mut err, self.tcx.hir.span(id),
906 "consider changing this to accept closures that implement `FnMut`");
908 span_help!(&mut err, self.tcx.hir.span(id),
909 "consider changing this closure to take self by mutable reference");
913 mc::AliasableStatic |
914 mc::AliasableStaticMut => {
915 let mut err = struct_span_err!(
916 self.tcx.sess, span, E0388,
917 "{} in a static location", prefix);
918 err.span_label(span, &format!("cannot write data in a static definition"));
921 mc::AliasableBorrowed => {
922 let mut e = struct_span_err!(
923 self.tcx.sess, span, E0389,
924 "{} in a `&` reference", prefix);
925 e.span_label(span, &"assignment into an immutable reference");
926 if let Some(nid) = cmt.get_arg_if_immutable(&self.tcx.hir) {
927 self.immutable_argument_should_be_mut(nid, &mut e);
934 err.help("closures behind references must be called via `&mut`");
939 /// Given a type, if it is an immutable reference, return a suggestion to make it mutable
940 fn suggest_mut_for_immutable(&self, pty: &hir::Ty) -> Option<String> {
941 // Check wether the argument is an immutable reference
942 if let hir::TyRptr(lifetime, hir::MutTy {
943 mutbl: hir::Mutability::MutImmutable,
946 // Account for existing lifetimes when generating the message
947 if !lifetime.is_elided() {
948 if let Ok(snippet) = self.tcx.sess.codemap().span_to_snippet(ty.span) {
949 if let Ok(lifetime_snippet) = self.tcx.sess.codemap()
950 .span_to_snippet(lifetime.span) {
951 return Some(format!("use `&{} mut {}` here to make mutable",
956 } else if let Ok(snippet) = self.tcx.sess.codemap().span_to_snippet(pty.span) {
957 if snippet.starts_with("&") {
958 return Some(format!("use `{}` here to make mutable",
959 snippet.replace("&", "&mut ")));
962 bug!("couldn't find a snippet for span: {:?}", pty.span);
968 fn immutable_argument_should_be_mut(&self, nid: ast::NodeId, db: &mut DiagnosticBuilder) {
969 let parent = self.tcx.hir.get_parent_node(nid);
970 let parent_node = self.tcx.hir.get(parent);
972 // The parent node is like a fn
973 if let Some(fn_like) = FnLikeNode::from_node(parent_node) {
974 // `nid`'s parent's `Body`
975 let fn_body = self.tcx.hir.body(fn_like.body());
976 // Get the position of `nid` in the arguments list
977 let arg_pos = fn_body.arguments.iter().position(|arg| arg.pat.id == nid);
978 if let Some(i) = arg_pos {
979 // The argument's `Ty`
980 let arg_ty = &fn_like.decl().inputs[i];
981 if let Some(msg) = self.suggest_mut_for_immutable(&arg_ty) {
982 db.span_label(arg_ty.span, &msg);
988 fn report_out_of_scope_escaping_closure_capture(&self,
989 err: &BckError<'tcx>,
992 let cmt_path_or_string = self.cmt_to_path_or_string(&err.cmt);
995 match self.tcx.sess.codemap().span_to_snippet(err.span) {
996 Ok(string) => format!("move {}", string),
997 Err(_) => format!("move |<args>| <body>")
1000 struct_span_err!(self.tcx.sess, err.span, E0373,
1001 "closure may outlive the current function, \
1002 but it borrows {}, \
1003 which is owned by the current function",
1005 .span_label(capture_span,
1006 &format!("{} is borrowed here",
1007 cmt_path_or_string))
1008 .span_label(err.span,
1009 &format!("may outlive borrowed value {}",
1010 cmt_path_or_string))
1011 .span_suggestion(err.span,
1012 &format!("to force the closure to take ownership of {} \
1013 (and any other referenced variables), \
1014 use the `move` keyword, as shown:",
1015 cmt_path_or_string),
1020 fn region_end_span(&self, region: &'tcx ty::Region) -> Option<Span> {
1022 ty::ReScope(scope) => {
1023 match scope.span(&self.tcx.region_maps, &self.tcx.hir) {
1036 pub fn note_and_explain_bckerr(&self, db: &mut DiagnosticBuilder, err: BckError<'tcx>) {
1037 let error_span = err.span.clone();
1039 err_mutbl => self.note_and_explain_mutbl_error(db, &err, &error_span),
1040 err_out_of_scope(super_scope, sub_scope, cause) => {
1041 let (value_kind, value_msg) = match err.cmt.cat {
1042 mc::Categorization::Rvalue(..) =>
1043 ("temporary value", "temporary value created here"),
1045 ("borrowed value", "borrow occurs here")
1048 let is_closure = match cause {
1049 euv::ClosureCapture(s) => {
1050 // The primary span starts out as the closure creation point.
1051 // Change the primary span here to highlight the use of the variable
1052 // in the closure, because it seems more natural. Highlight
1053 // closure creation point as a secondary span.
1054 match db.span.primary_span() {
1056 db.span = MultiSpan::from_span(s);
1057 db.span_label(primary, &format!("capture occurs here"));
1058 db.span_label(s, &"does not live long enough");
1065 db.span_label(error_span, &"does not live long enough");
1070 let sub_span = self.region_end_span(sub_scope);
1071 let super_span = self.region_end_span(super_scope);
1073 match (sub_span, super_span) {
1074 (Some(s1), Some(s2)) if s1 == s2 => {
1076 db.span = MultiSpan::from_span(s1);
1077 db.span_label(error_span, &value_msg);
1078 let msg = match opt_loan_path(&err.cmt) {
1079 None => value_kind.to_string(),
1081 format!("`{}`", self.loan_path_to_string(&lp))
1085 &format!("{} dropped here while still borrowed", msg));
1087 db.span_label(s1, &format!("{} dropped before borrower", value_kind));
1089 db.note("values in a scope are dropped in the opposite order \
1092 (Some(s1), Some(s2)) if !is_closure => {
1093 db.span = MultiSpan::from_span(s2);
1094 db.span_label(error_span, &value_msg);
1095 let msg = match opt_loan_path(&err.cmt) {
1096 None => value_kind.to_string(),
1098 format!("`{}`", self.loan_path_to_string(&lp))
1101 db.span_label(s2, &format!("{} dropped here while still borrowed", msg));
1102 db.span_label(s1, &format!("{} needs to live until here", value_kind));
1107 db.span_label(s, &format!("{} needs to live until here",
1111 self.tcx.note_and_explain_region(
1113 "borrowed value must be valid for ",
1120 db.span_label(s, &format!("{} only lives until here", value_kind));
1123 self.tcx.note_and_explain_region(
1125 "...but borrowed value is only valid for ",
1133 if let Some(_) = statement_scope_span(self.tcx, super_scope) {
1134 db.note("consider using a `let` binding to increase its lifetime");
1140 mc::Categorization::Rvalue(r, or) if r != or => {
1142 before rustc 1.16, this temporary lived longer - see issue #39283 \
1143 (https://github.com/rust-lang/rust/issues/39283)");
1149 err_borrowed_pointer_too_short(loan_scope, ptr_scope) => {
1150 let descr = match opt_loan_path(&err.cmt) {
1152 format!("`{}`", self.loan_path_to_string(&lp))
1154 None => self.cmt_to_string(&err.cmt),
1156 self.tcx.note_and_explain_region(
1158 &format!("{} would have to be valid for ",
1162 self.tcx.note_and_explain_region(
1164 &format!("...but {} is only valid for ", descr),
1171 fn note_and_explain_mutbl_error(&self, db: &mut DiagnosticBuilder, err: &BckError<'tcx>,
1172 error_span: &Span) {
1173 match err.cmt.note {
1174 mc::NoteClosureEnv(upvar_id) | mc::NoteUpvarRef(upvar_id) => {
1175 // If this is an `Fn` closure, it simply can't mutate upvars.
1176 // If it's an `FnMut` closure, the original variable was declared immutable.
1177 // We need to determine which is the case here.
1178 let kind = match err.cmt.upvar().unwrap().cat {
1179 Categorization::Upvar(mc::Upvar { kind, .. }) => kind,
1182 if kind == ty::ClosureKind::Fn {
1183 db.span_help(self.tcx.hir.span(upvar_id.closure_expr_id),
1184 "consider changing this closure to take \
1185 self by mutable reference");
1189 if let Categorization::Deref(..) = err.cmt.cat {
1190 db.span_label(*error_span, &"cannot borrow as mutable");
1191 if let Some(local_id) = err.cmt.get_arg_if_immutable(&self.tcx.hir) {
1192 self.immutable_argument_should_be_mut(local_id, db);
1193 } else if let Categorization::Deref(ref inner_cmt, ..) = err.cmt.cat {
1194 if let Categorization::Local(local_id) = inner_cmt.cat {
1195 self.immutable_argument_should_be_mut(local_id, db);
1198 } else if let Categorization::Local(local_id) = err.cmt.cat {
1199 let span = self.tcx.hir.span(local_id);
1200 if let Ok(snippet) = self.tcx.sess.codemap().span_to_snippet(span) {
1201 if snippet.starts_with("ref mut ") || snippet.starts_with("&mut ") {
1202 db.span_label(*error_span, &format!("cannot reborrow mutably"));
1203 db.span_label(*error_span, &format!("try removing `&mut` here"));
1205 if snippet.starts_with("ref ") {
1206 db.span_label(span, &format!("use `{}` here to make mutable",
1207 snippet.replace("ref ", "ref mut ")));
1208 } else if snippet != "self" {
1210 &format!("use `mut {}` here to make mutable",
1213 db.span_label(*error_span, &format!("cannot borrow mutably"));
1216 db.span_label(*error_span, &format!("cannot borrow mutably"));
1222 pub fn append_loan_path_to_string(&self,
1223 loan_path: &LoanPath<'tcx>,
1225 match loan_path.kind {
1226 LpUpvar(ty::UpvarId{ var_id: id, closure_expr_id: _ }) |
1228 out.push_str(&self.tcx.local_var_name_str(id));
1231 LpDowncast(ref lp_base, variant_def_id) => {
1233 self.append_loan_path_to_string(&lp_base, out);
1234 out.push_str(DOWNCAST_PRINTED_OPERATOR);
1235 out.push_str(&self.tcx.item_path_str(variant_def_id));
1239 LpExtend(ref lp_base, _, LpInterior(_, InteriorField(fname))) => {
1240 self.append_autoderefd_loan_path_to_string(&lp_base, out);
1242 mc::NamedField(fname) => {
1244 out.push_str(&fname.as_str());
1246 mc::PositionalField(idx) => {
1248 out.push_str(&idx.to_string());
1253 LpExtend(ref lp_base, _, LpInterior(_, InteriorElement(..))) => {
1254 self.append_autoderefd_loan_path_to_string(&lp_base, out);
1255 out.push_str("[..]");
1258 LpExtend(ref lp_base, _, LpDeref(_)) => {
1260 self.append_loan_path_to_string(&lp_base, out);
1265 pub fn append_autoderefd_loan_path_to_string(&self,
1266 loan_path: &LoanPath<'tcx>,
1268 match loan_path.kind {
1269 LpExtend(ref lp_base, _, LpDeref(_)) => {
1270 // For a path like `(*x).f` or `(*x)[3]`, autoderef
1271 // rules would normally allow users to omit the `*x`.
1272 // So just serialize such paths to `x.f` or x[3]` respectively.
1273 self.append_autoderefd_loan_path_to_string(&lp_base, out)
1276 LpDowncast(ref lp_base, variant_def_id) => {
1278 self.append_autoderefd_loan_path_to_string(&lp_base, out);
1280 out.push_str(&self.tcx.item_path_str(variant_def_id));
1284 LpVar(..) | LpUpvar(..) | LpExtend(.., LpInterior(..)) => {
1285 self.append_loan_path_to_string(loan_path, out)
1290 pub fn loan_path_to_string(&self, loan_path: &LoanPath<'tcx>) -> String {
1291 let mut result = String::new();
1292 self.append_loan_path_to_string(loan_path, &mut result);
1296 pub fn cmt_to_string(&self, cmt: &mc::cmt_<'tcx>) -> String {
1297 cmt.descriptive_string(self.tcx)
1300 pub fn cmt_to_path_or_string(&self, cmt: &mc::cmt<'tcx>) -> String {
1301 match opt_loan_path(cmt) {
1302 Some(lp) => format!("`{}`", self.loan_path_to_string(&lp)),
1303 None => self.cmt_to_string(cmt),
1308 fn statement_scope_span(tcx: TyCtxt, region: &ty::Region) -> Option<Span> {
1310 ty::ReScope(scope) => {
1311 match tcx.hir.find(scope.node_id(&tcx.region_maps)) {
1312 Some(hir_map::NodeStmt(stmt)) => Some(stmt.span),
1320 impl BitwiseOperator for LoanDataFlowOperator {
1322 fn join(&self, succ: usize, pred: usize) -> usize {
1323 succ | pred // loans from both preds are in scope
1327 impl DataFlowOperator for LoanDataFlowOperator {
1329 fn initial_value(&self) -> bool {
1330 false // no loans in scope by default
1334 impl<'tcx> fmt::Debug for InteriorKind {
1335 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1337 InteriorField(mc::NamedField(fld)) => write!(f, "{}", fld),
1338 InteriorField(mc::PositionalField(i)) => write!(f, "#{}", i),
1339 InteriorElement(..) => write!(f, "[]"),
1344 impl<'tcx> fmt::Debug for Loan<'tcx> {
1345 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1346 write!(f, "Loan_{}({:?}, {:?}, {:?}-{:?}, {:?})",
1352 self.restricted_paths)
1356 impl<'tcx> fmt::Debug for LoanPath<'tcx> {
1357 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1360 write!(f, "$({})", ty::tls::with(|tcx| tcx.hir.node_to_string(id)))
1363 LpUpvar(ty::UpvarId{ var_id, closure_expr_id }) => {
1364 let s = ty::tls::with(|tcx| tcx.hir.node_to_string(var_id));
1365 write!(f, "$({} captured by id={})", s, closure_expr_id)
1368 LpDowncast(ref lp, variant_def_id) => {
1369 let variant_str = if variant_def_id.is_local() {
1370 ty::tls::with(|tcx| tcx.item_path_str(variant_def_id))
1372 format!("{:?}", variant_def_id)
1374 write!(f, "({:?}{}{})", lp, DOWNCAST_PRINTED_OPERATOR, variant_str)
1377 LpExtend(ref lp, _, LpDeref(_)) => {
1378 write!(f, "{:?}.*", lp)
1381 LpExtend(ref lp, _, LpInterior(_, ref interior)) => {
1382 write!(f, "{:?}.{:?}", lp, interior)
1388 impl<'tcx> fmt::Display for LoanPath<'tcx> {
1389 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
1392 write!(f, "$({})", ty::tls::with(|tcx| tcx.hir.node_to_user_string(id)))
1395 LpUpvar(ty::UpvarId{ var_id, closure_expr_id: _ }) => {
1396 let s = ty::tls::with(|tcx| tcx.hir.node_to_user_string(var_id));
1397 write!(f, "$({} captured by closure)", s)
1400 LpDowncast(ref lp, variant_def_id) => {
1401 let variant_str = if variant_def_id.is_local() {
1402 ty::tls::with(|tcx| tcx.item_path_str(variant_def_id))
1404 format!("{:?}", variant_def_id)
1406 write!(f, "({}{}{})", lp, DOWNCAST_PRINTED_OPERATOR, variant_str)
1409 LpExtend(ref lp, _, LpDeref(_)) => {
1410 write!(f, "{}.*", lp)
1413 LpExtend(ref lp, _, LpInterior(_, ref interior)) => {
1414 write!(f, "{}.{:?}", lp, interior)