1 use rustc_errors::{struct_span_err, Handler};
2 use rustc_feature::{AttributeGate, BUILTIN_ATTRIBUTE_MAP};
3 use rustc_feature::{Features, GateIssue, UnstableFeatures};
4 use rustc_session::parse::{feature_err, feature_err_issue, ParseSess};
5 use rustc_span::source_map::Spanned;
6 use rustc_span::symbol::sym;
8 use syntax::ast::{self, AssocTyConstraint, AssocTyConstraintKind, NodeId};
9 use syntax::ast::{GenericParam, GenericParamKind, PatKind, RangeEnd, VariantData};
11 use syntax::visit::{self, AssocCtxt, FnCtxt, FnKind, Visitor};
15 macro_rules! gate_feature_fn {
16 ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
17 let (cx, has_feature, span, name, explain) = (&*$cx, $has_feature, $span, $name, $explain);
18 let has_feature: bool = has_feature(&$cx.features);
19 debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
20 if !has_feature && !span.allows_unstable($name) {
21 feature_err_issue(cx.parse_sess, name, span, GateIssue::Language, explain).emit();
26 macro_rules! gate_feature_post {
27 ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
28 gate_feature_fn!($cx, |x: &Features| x.$feature, $span, sym::$feature, $explain)
32 pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess, features: &Features) {
33 PostExpansionVisitor { parse_sess, features }.visit_attribute(attr)
36 struct PostExpansionVisitor<'a> {
37 parse_sess: &'a ParseSess,
38 features: &'a Features,
41 impl<'a> PostExpansionVisitor<'a> {
42 fn check_abi(&self, abi: ast::StrLit) {
43 let ast::StrLit { symbol_unescaped, span, .. } = abi;
45 match &*symbol_unescaped.as_str() {
47 "Rust" | "C" | "cdecl" | "stdcall" | "fastcall" | "aapcs" | "win64" | "sysv64"
50 gate_feature_post!(&self, intrinsics, span, "intrinsics are subject to change");
52 "platform-intrinsic" => {
57 "platform intrinsics are experimental and possibly buggy"
65 "vectorcall is experimental and subject to change"
73 "thiscall is experimental and subject to change"
81 "rust-call ABI is subject to change"
89 "PTX ABIs are experimental and subject to change"
97 "unadjusted ABI is an implementation detail and perma-unstable"
100 "msp430-interrupt" => {
103 abi_msp430_interrupt,
105 "msp430-interrupt ABI is experimental and subject to change"
113 "x86-interrupt ABI is experimental and subject to change"
121 "amdgpu-kernel ABI is experimental and subject to change"
129 "efiapi ABI is experimental and subject to change"
135 .delay_span_bug(span, &format!("unrecognized ABI not caught in lowering: {}", abi)),
139 fn check_extern(&self, ext: ast::Extern) {
140 if let ast::Extern::Explicit(abi) = ext {
145 fn maybe_report_invalid_custom_discriminants(&self, variants: &[ast::Variant]) {
146 let has_fields = variants.iter().any(|variant| match variant.data {
147 VariantData::Tuple(..) | VariantData::Struct(..) => true,
148 VariantData::Unit(..) => false,
151 let discriminant_spans = variants
153 .filter(|variant| match variant.data {
154 VariantData::Tuple(..) | VariantData::Struct(..) => false,
155 VariantData::Unit(..) => true,
157 .filter_map(|variant| variant.disr_expr.as_ref().map(|c| c.value.span))
158 .collect::<Vec<_>>();
160 if !discriminant_spans.is_empty() && has_fields {
161 let mut err = feature_err(
163 sym::arbitrary_enum_discriminant,
164 discriminant_spans.clone(),
165 "custom discriminant values are not allowed in enums with tuple or struct variants",
167 for sp in discriminant_spans {
168 err.span_label(sp, "disallowed custom discriminant");
170 for variant in variants.iter() {
171 match &variant.data {
172 VariantData::Struct(..) => {
173 err.span_label(variant.span, "struct variant defined here");
175 VariantData::Tuple(..) => {
176 err.span_label(variant.span, "tuple variant defined here");
178 VariantData::Unit(..) => {}
185 fn check_gat(&self, generics: &ast::Generics, span: Span) {
186 if !generics.params.is_empty() {
189 generic_associated_types,
191 "generic associated types are unstable"
194 if !generics.where_clause.predicates.is_empty() {
197 generic_associated_types,
199 "where clauses on associated types are unstable"
204 /// Feature gate `impl Trait` inside `type Alias = $type_expr;`.
205 fn check_impl_trait(&self, ty: &ast::Ty) {
206 struct ImplTraitVisitor<'a> {
207 vis: &'a PostExpansionVisitor<'a>,
209 impl Visitor<'_> for ImplTraitVisitor<'_> {
210 fn visit_ty(&mut self, ty: &ast::Ty) {
211 if let ast::TyKind::ImplTrait(..) = ty.kind {
214 type_alias_impl_trait,
216 "`impl Trait` in type aliases is unstable"
219 visit::walk_ty(self, ty);
222 ImplTraitVisitor { vis: self }.visit_ty(ty);
226 impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
227 fn visit_attribute(&mut self, attr: &ast::Attribute) {
229 attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name)).map(|a| **a);
230 // Check feature gates for built-in attributes.
231 if let Some((.., AttributeGate::Gated(_, name, descr, has_feature))) = attr_info {
232 gate_feature_fn!(self, has_feature, attr.span, name, descr);
234 // Check unstable flavors of the `#[doc]` attribute.
235 if attr.check_name(sym::doc) {
236 for nested_meta in attr.meta_item_list().unwrap_or_default() {
237 macro_rules! gate_doc { ($($name:ident => $feature:ident)*) => {
238 $(if nested_meta.check_name(sym::$name) {
239 let msg = concat!("`#[doc(", stringify!($name), ")]` is experimental");
240 gate_feature_post!(self, $feature, attr.span, msg);
245 include => external_doc
248 spotlight => doc_spotlight
250 keyword => doc_keyword
256 fn visit_name(&mut self, sp: Span, name: ast::Name) {
257 if !name.as_str().is_ascii() {
261 self.parse_sess.source_map().def_span(sp),
262 "non-ascii idents are not fully supported"
267 fn visit_item(&mut self, i: &'a ast::Item) {
269 ast::ItemKind::ForeignMod(ref foreign_module) => {
270 if let Some(abi) = foreign_module.abi {
275 ast::ItemKind::Fn(..) => {
276 if attr::contains_name(&i.attrs[..], sym::plugin_registrar) {
281 "compiler plugins are experimental and possibly buggy"
284 if attr::contains_name(&i.attrs[..], sym::start) {
289 "`#[start]` functions are experimental \
290 and their signature may change \
294 if attr::contains_name(&i.attrs[..], sym::main) {
299 "declaration of a non-standard `#[main]` \
300 function may change over time, for now \
301 a top-level `fn main()` is required"
306 ast::ItemKind::Struct(..) => {
307 for attr in attr::filter_by_name(&i.attrs[..], sym::repr) {
308 for item in attr.meta_item_list().unwrap_or_else(Vec::new) {
309 if item.check_name(sym::simd) {
314 "SIMD types are experimental and possibly buggy"
321 ast::ItemKind::Enum(ast::EnumDef { ref variants, .. }, ..) => {
322 for variant in variants {
323 match (&variant.data, &variant.disr_expr) {
324 (ast::VariantData::Unit(..), _) => {}
325 (_, Some(disr_expr)) => gate_feature_post!(
327 arbitrary_enum_discriminant,
328 disr_expr.value.span,
329 "discriminants on non-unit variants are experimental"
335 let has_feature = self.features.arbitrary_enum_discriminant;
336 if !has_feature && !i.span.allows_unstable(sym::arbitrary_enum_discriminant) {
337 self.maybe_report_invalid_custom_discriminants(&variants);
341 ast::ItemKind::Impl { polarity, defaultness, .. } => {
342 if polarity == ast::ImplPolarity::Negative {
345 optin_builtin_traits,
347 "negative trait bounds are not yet fully implemented; \
348 use marker types for now"
352 if let ast::Defaultness::Default = defaultness {
353 gate_feature_post!(&self, specialization, i.span, "specialization is unstable");
357 ast::ItemKind::Trait(ast::IsAuto::Yes, ..) => {
360 optin_builtin_traits,
362 "auto traits are experimental and possibly buggy"
366 ast::ItemKind::TraitAlias(..) => {
367 gate_feature_post!(&self, trait_alias, i.span, "trait aliases are experimental");
370 ast::ItemKind::MacroDef(ast::MacroDef { legacy: false, .. }) => {
371 let msg = "`macro` is experimental";
372 gate_feature_post!(&self, decl_macro, i.span, msg);
375 ast::ItemKind::TyAlias(ref ty, ..) => self.check_impl_trait(&ty),
380 visit::walk_item(self, i);
383 fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
385 ast::ForeignItemKind::Fn(..) | ast::ForeignItemKind::Static(..) => {
386 let link_name = attr::first_attr_value_str_by_name(&i.attrs, sym::link_name);
387 let links_to_llvm = match link_name {
388 Some(val) => val.as_str().starts_with("llvm."),
394 link_llvm_intrinsics,
396 "linking to LLVM intrinsics is experimental"
400 ast::ForeignItemKind::Ty => {
401 gate_feature_post!(&self, extern_types, i.span, "extern types are experimental");
403 ast::ForeignItemKind::Macro(..) => {}
406 visit::walk_foreign_item(self, i)
409 fn visit_ty(&mut self, ty: &'a ast::Ty) {
411 ast::TyKind::BareFn(ref bare_fn_ty) => {
412 self.check_extern(bare_fn_ty.ext);
414 ast::TyKind::Never => {
415 gate_feature_post!(&self, never_type, ty.span, "the `!` type is experimental");
419 visit::walk_ty(self, ty)
422 fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
423 if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
424 if let ast::TyKind::Never = output_ty.kind {
427 self.visit_ty(output_ty)
432 fn visit_expr(&mut self, e: &'a ast::Expr) {
434 ast::ExprKind::Box(_) => {
439 "box expression syntax is experimental; you can call `Box::new` instead"
442 ast::ExprKind::Type(..) => {
443 // To avoid noise about type ascription in common syntax errors, only emit if it
444 // is the *only* error.
445 if self.parse_sess.span_diagnostic.err_count() == 0 {
450 "type ascription is experimental"
454 ast::ExprKind::TryBlock(_) => {
455 gate_feature_post!(&self, try_blocks, e.span, "`try` expression is experimental");
457 ast::ExprKind::Block(_, opt_label) => {
458 if let Some(label) = opt_label {
463 "labels on blocks are unstable"
469 visit::walk_expr(self, e)
472 fn visit_pat(&mut self, pattern: &'a ast::Pat) {
473 match &pattern.kind {
474 PatKind::Box(..) => {
479 "box pattern syntax is experimental"
482 PatKind::Range(_, _, Spanned { node: RangeEnd::Excluded, .. }) => {
485 exclusive_range_pattern,
487 "exclusive range pattern syntax is experimental"
492 visit::walk_pat(self, pattern)
495 fn visit_fn(&mut self, fn_kind: FnKind<'a>, span: Span, _: NodeId) {
496 if let Some(header) = fn_kind.header() {
497 // Stability of const fn methods are covered in `visit_assoc_item` below.
498 self.check_extern(header.ext);
501 if fn_kind.ctxt() != Some(FnCtxt::Foreign) && fn_kind.decl().c_variadic() {
502 gate_feature_post!(&self, c_variadic, span, "C-variadic functions are unstable");
505 visit::walk_fn(self, fn_kind, span)
508 fn visit_generic_param(&mut self, param: &'a GenericParam) {
510 GenericParamKind::Const { .. } => gate_feature_post!(
514 "const generics are unstable"
518 visit::walk_generic_param(self, param)
521 fn visit_assoc_ty_constraint(&mut self, constraint: &'a AssocTyConstraint) {
522 match constraint.kind {
523 AssocTyConstraintKind::Bound { .. } => gate_feature_post!(
525 associated_type_bounds,
527 "associated type bounds are unstable"
531 visit::walk_assoc_ty_constraint(self, constraint)
534 fn visit_assoc_item(&mut self, i: &'a ast::AssocItem, ctxt: AssocCtxt) {
535 if i.defaultness == ast::Defaultness::Default {
536 gate_feature_post!(&self, specialization, i.span, "specialization is unstable");
540 ast::AssocItemKind::Fn(ref sig, _) => {
541 let constness = sig.header.constness.node;
542 if let (ast::Constness::Const, AssocCtxt::Trait) = (constness, ctxt) {
543 gate_feature_post!(&self, const_fn, i.span, "const fn is unstable");
546 ast::AssocItemKind::TyAlias(_, ref ty) => {
547 if let (Some(_), AssocCtxt::Trait) = (ty, ctxt) {
550 associated_type_defaults,
552 "associated type defaults are unstable"
555 if let Some(ty) = ty {
556 self.check_impl_trait(ty);
558 self.check_gat(&i.generics, i.span);
562 visit::walk_assoc_item(self, i, ctxt)
565 fn visit_vis(&mut self, vis: &'a ast::Visibility) {
566 if let ast::VisibilityKind::Crate(ast::CrateSugar::JustCrate) = vis.node {
569 crate_visibility_modifier,
571 "`crate` visibility modifier is experimental"
574 visit::walk_vis(self, vis)
580 parse_sess: &ParseSess,
582 unstable: UnstableFeatures,
584 maybe_stage_features(&parse_sess.span_diagnostic, krate, unstable);
585 let mut visitor = PostExpansionVisitor { parse_sess, features };
587 let spans = parse_sess.gated_spans.spans.borrow();
588 macro_rules! gate_all {
589 ($gate:ident, $msg:literal) => {
590 for span in spans.get(&sym::$gate).unwrap_or(&vec![]) {
591 gate_feature_post!(&visitor, $gate, *span, $msg);
595 gate_all!(let_chains, "`let` expressions in this position are experimental");
596 gate_all!(async_closure, "async closures are unstable");
597 gate_all!(generators, "yield syntax is experimental");
598 gate_all!(or_patterns, "or-patterns syntax is experimental");
599 gate_all!(const_extern_fn, "`const extern fn` definitions are unstable");
600 gate_all!(raw_ref_op, "raw address of syntax is experimental");
601 gate_all!(const_trait_bound_opt_out, "`?const` on trait bounds is experimental");
602 gate_all!(const_trait_impl, "const trait impls are experimental");
603 gate_all!(half_open_range_patterns, "half-open range patterns are unstable");
605 // All uses of `gate_all!` below this point were added in #65742,
606 // and subsequently disabled (with the non-early gating readded).
607 macro_rules! gate_all {
608 ($gate:ident, $msg:literal) => {
609 // FIXME(eddyb) do something more useful than always
610 // disabling these uses of early feature-gatings.
612 for span in spans.get(&sym::$gate).unwrap_or(&vec![]) {
613 gate_feature_post!(&visitor, $gate, *span, $msg);
619 gate_all!(trait_alias, "trait aliases are experimental");
620 gate_all!(associated_type_bounds, "associated type bounds are unstable");
621 gate_all!(crate_visibility_modifier, "`crate` visibility modifier is experimental");
622 gate_all!(const_generics, "const generics are unstable");
623 gate_all!(decl_macro, "`macro` is experimental");
624 gate_all!(box_patterns, "box pattern syntax is experimental");
625 gate_all!(exclusive_range_pattern, "exclusive range pattern syntax is experimental");
626 gate_all!(try_blocks, "`try` blocks are unstable");
627 gate_all!(label_break_value, "labels on blocks are unstable");
628 gate_all!(box_syntax, "box expression syntax is experimental; you can call `Box::new` instead");
629 // To avoid noise about type ascription in common syntax errors,
630 // only emit if it is the *only* error. (Also check it last.)
631 if parse_sess.span_diagnostic.err_count() == 0 {
632 gate_all!(type_ascription, "type ascription is experimental");
635 visit::walk_crate(&mut visitor, krate);
638 fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate, unstable: UnstableFeatures) {
639 if !unstable.is_nightly_build() {
640 for attr in krate.attrs.iter().filter(|attr| attr.check_name(sym::feature)) {
645 "`#![feature]` may not be used on the {} release channel",
646 option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)")