]> git.lizzy.rs Git - rust.git/blob - src/librustc/traits/error_reporting.rs
Rollup merge of #66576 - pnkfelix:more-robust-gdb-vec-printer, r=alexcrichton
[rust.git] / src / librustc / traits / error_reporting.rs
1 use super::{
2     ConstEvalFailure,
3     EvaluationResult,
4     FulfillmentError,
5     FulfillmentErrorCode,
6     MismatchedProjectionTypes,
7     ObjectSafetyViolation,
8     Obligation,
9     ObligationCause,
10     ObligationCauseCode,
11     OnUnimplementedDirective,
12     OnUnimplementedNote,
13     OutputTypeParameterMismatch,
14     Overflow,
15     PredicateObligation,
16     SelectionContext,
17     SelectionError,
18     TraitNotObjectSafe,
19 };
20
21 use crate::hir;
22 use crate::hir::Node;
23 use crate::hir::def_id::DefId;
24 use crate::infer::{self, InferCtxt};
25 use crate::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
26 use crate::session::DiagnosticMessageId;
27 use crate::ty::{self, AdtKind, DefIdTree, ToPredicate, ToPolyTraitRef, Ty, TyCtxt, TypeFoldable};
28 use crate::ty::GenericParamDefKind;
29 use crate::ty::error::ExpectedFound;
30 use crate::ty::fast_reject;
31 use crate::ty::fold::TypeFolder;
32 use crate::ty::subst::Subst;
33 use crate::ty::SubtypePredicate;
34 use crate::util::nodemap::{FxHashMap, FxHashSet};
35
36 use errors::{Applicability, DiagnosticBuilder, pluralize, Style};
37 use std::fmt;
38 use syntax::ast;
39 use syntax::symbol::{sym, kw};
40 use syntax_pos::{DUMMY_SP, Span, ExpnKind, MultiSpan};
41
42 use rustc_error_codes::*;
43
44 impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
45     pub fn report_fulfillment_errors(
46         &self,
47         errors: &[FulfillmentError<'tcx>],
48         body_id: Option<hir::BodyId>,
49         fallback_has_occurred: bool,
50     ) {
51         #[derive(Debug)]
52         struct ErrorDescriptor<'tcx> {
53             predicate: ty::Predicate<'tcx>,
54             index: Option<usize>, // None if this is an old error
55         }
56
57         let mut error_map: FxHashMap<_, Vec<_>> =
58             self.reported_trait_errors.borrow().iter().map(|(&span, predicates)| {
59                 (span, predicates.iter().map(|predicate| ErrorDescriptor {
60                     predicate: predicate.clone(),
61                     index: None
62                 }).collect())
63             }).collect();
64
65         for (index, error) in errors.iter().enumerate() {
66             // We want to ignore desugarings here: spans are equivalent even
67             // if one is the result of a desugaring and the other is not.
68             let mut span = error.obligation.cause.span;
69             let expn_data = span.ctxt().outer_expn_data();
70             if let ExpnKind::Desugaring(_) = expn_data.kind {
71                 span = expn_data.call_site;
72             }
73
74             error_map.entry(span).or_default().push(
75                 ErrorDescriptor {
76                     predicate: error.obligation.predicate.clone(),
77                     index: Some(index)
78                 }
79             );
80
81             self.reported_trait_errors.borrow_mut()
82                 .entry(span).or_default()
83                 .push(error.obligation.predicate.clone());
84         }
85
86         // We do this in 2 passes because we want to display errors in order, though
87         // maybe it *is* better to sort errors by span or something.
88         let mut is_suppressed = vec![false; errors.len()];
89         for (_, error_set) in error_map.iter() {
90             // We want to suppress "duplicate" errors with the same span.
91             for error in error_set {
92                 if let Some(index) = error.index {
93                     // Suppress errors that are either:
94                     // 1) strictly implied by another error.
95                     // 2) implied by an error with a smaller index.
96                     for error2 in error_set {
97                         if error2.index.map_or(false, |index2| is_suppressed[index2]) {
98                             // Avoid errors being suppressed by already-suppressed
99                             // errors, to prevent all errors from being suppressed
100                             // at once.
101                             continue
102                         }
103
104                         if self.error_implies(&error2.predicate, &error.predicate) &&
105                             !(error2.index >= error.index &&
106                               self.error_implies(&error.predicate, &error2.predicate))
107                         {
108                             info!("skipping {:?} (implied by {:?})", error, error2);
109                             is_suppressed[index] = true;
110                             break
111                         }
112                     }
113                 }
114             }
115         }
116
117         for (error, suppressed) in errors.iter().zip(is_suppressed) {
118             if !suppressed {
119                 self.report_fulfillment_error(error, body_id, fallback_has_occurred);
120             }
121         }
122     }
123
124     // returns if `cond` not occurring implies that `error` does not occur - i.e., that
125     // `error` occurring implies that `cond` occurs.
126     fn error_implies(
127         &self,
128         cond: &ty::Predicate<'tcx>,
129         error: &ty::Predicate<'tcx>,
130     ) -> bool {
131         if cond == error {
132             return true
133         }
134
135         let (cond, error) = match (cond, error) {
136             (&ty::Predicate::Trait(..), &ty::Predicate::Trait(ref error))
137                 => (cond, error),
138             _ => {
139                 // FIXME: make this work in other cases too.
140                 return false
141             }
142         };
143
144         for implication in super::elaborate_predicates(self.tcx, vec![cond.clone()]) {
145             if let ty::Predicate::Trait(implication) = implication {
146                 let error = error.to_poly_trait_ref();
147                 let implication = implication.to_poly_trait_ref();
148                 // FIXME: I'm just not taking associated types at all here.
149                 // Eventually I'll need to implement param-env-aware
150                 // `Γ₁ ⊦ φ₁ => Γ₂ ⊦ φ₂` logic.
151                 let param_env = ty::ParamEnv::empty();
152                 if self.can_sub(param_env, error, implication).is_ok() {
153                     debug!("error_implies: {:?} -> {:?} -> {:?}", cond, error, implication);
154                     return true
155                 }
156             }
157         }
158
159         false
160     }
161
162     fn report_fulfillment_error(
163         &self,
164         error: &FulfillmentError<'tcx>,
165         body_id: Option<hir::BodyId>,
166         fallback_has_occurred: bool,
167     ) {
168         debug!("report_fulfillment_errors({:?})", error);
169         match error.code {
170             FulfillmentErrorCode::CodeSelectionError(ref selection_error) => {
171                 self.report_selection_error(
172                     &error.obligation,
173                     selection_error,
174                     fallback_has_occurred,
175                     error.points_at_arg_span,
176                 );
177             }
178             FulfillmentErrorCode::CodeProjectionError(ref e) => {
179                 self.report_projection_error(&error.obligation, e);
180             }
181             FulfillmentErrorCode::CodeAmbiguity => {
182                 self.maybe_report_ambiguity(&error.obligation, body_id);
183             }
184             FulfillmentErrorCode::CodeSubtypeError(ref expected_found, ref err) => {
185                 self.report_mismatched_types(
186                     &error.obligation.cause,
187                     expected_found.expected,
188                     expected_found.found,
189                     err.clone(),
190                 ).emit();
191             }
192         }
193     }
194
195     fn report_projection_error(
196         &self,
197         obligation: &PredicateObligation<'tcx>,
198         error: &MismatchedProjectionTypes<'tcx>,
199     ) {
200         let predicate = self.resolve_vars_if_possible(&obligation.predicate);
201
202         if predicate.references_error() {
203             return
204         }
205
206         self.probe(|_| {
207             let err_buf;
208             let mut err = &error.err;
209             let mut values = None;
210
211             // try to find the mismatched types to report the error with.
212             //
213             // this can fail if the problem was higher-ranked, in which
214             // cause I have no idea for a good error message.
215             if let ty::Predicate::Projection(ref data) = predicate {
216                 let mut selcx = SelectionContext::new(self);
217                 let (data, _) = self.replace_bound_vars_with_fresh_vars(
218                     obligation.cause.span,
219                     infer::LateBoundRegionConversionTime::HigherRankedType,
220                     data
221                 );
222                 let mut obligations = vec![];
223                 let normalized_ty = super::normalize_projection_type(
224                     &mut selcx,
225                     obligation.param_env,
226                     data.projection_ty,
227                     obligation.cause.clone(),
228                     0,
229                     &mut obligations
230                 );
231
232                 debug!("report_projection_error obligation.cause={:?} obligation.param_env={:?}",
233                        obligation.cause, obligation.param_env);
234
235                 debug!("report_projection_error normalized_ty={:?} data.ty={:?}",
236                        normalized_ty, data.ty);
237
238                 let is_normalized_ty_expected = match &obligation.cause.code {
239                     ObligationCauseCode::ItemObligation(_) |
240                     ObligationCauseCode::BindingObligation(_, _) |
241                     ObligationCauseCode::ObjectCastObligation(_) => false,
242                     _ => true,
243                 };
244
245                 if let Err(error) = self.at(&obligation.cause, obligation.param_env)
246                     .eq_exp(is_normalized_ty_expected, normalized_ty, data.ty)
247                 {
248                     values = Some(infer::ValuePairs::Types(
249                         ExpectedFound::new(is_normalized_ty_expected, normalized_ty, data.ty)));
250
251                     err_buf = error;
252                     err = &err_buf;
253                 }
254             }
255
256             let msg = format!("type mismatch resolving `{}`", predicate);
257             let error_id = (
258                 DiagnosticMessageId::ErrorId(271),
259                 Some(obligation.cause.span),
260                 msg,
261             );
262             let fresh = self.tcx.sess.one_time_diagnostics.borrow_mut().insert(error_id);
263             if fresh {
264                 let mut diag = struct_span_err!(
265                     self.tcx.sess,
266                     obligation.cause.span,
267                     E0271,
268                     "type mismatch resolving `{}`",
269                     predicate
270                 );
271                 self.note_type_err(&mut diag, &obligation.cause, None, values, err);
272                 self.note_obligation_cause(&mut diag, obligation);
273                 diag.emit();
274             }
275         });
276     }
277
278     fn fuzzy_match_tys(&self, a: Ty<'tcx>, b: Ty<'tcx>) -> bool {
279         /// returns the fuzzy category of a given type, or None
280         /// if the type can be equated to any type.
281         fn type_category(t: Ty<'_>) -> Option<u32> {
282             match t.kind {
283                 ty::Bool => Some(0),
284                 ty::Char => Some(1),
285                 ty::Str => Some(2),
286                 ty::Int(..) | ty::Uint(..) | ty::Infer(ty::IntVar(..)) => Some(3),
287                 ty::Float(..) | ty::Infer(ty::FloatVar(..)) => Some(4),
288                 ty::Ref(..) | ty::RawPtr(..) => Some(5),
289                 ty::Array(..) | ty::Slice(..) => Some(6),
290                 ty::FnDef(..) | ty::FnPtr(..) => Some(7),
291                 ty::Dynamic(..) => Some(8),
292                 ty::Closure(..) => Some(9),
293                 ty::Tuple(..) => Some(10),
294                 ty::Projection(..) => Some(11),
295                 ty::Param(..) => Some(12),
296                 ty::Opaque(..) => Some(13),
297                 ty::Never => Some(14),
298                 ty::Adt(adt, ..) => match adt.adt_kind() {
299                     AdtKind::Struct => Some(15),
300                     AdtKind::Union => Some(16),
301                     AdtKind::Enum => Some(17),
302                 },
303                 ty::Generator(..) => Some(18),
304                 ty::Foreign(..) => Some(19),
305                 ty::GeneratorWitness(..) => Some(20),
306                 ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) | ty::Error => None,
307                 ty::UnnormalizedProjection(..) => bug!("only used with chalk-engine"),
308             }
309         }
310
311         match (type_category(a), type_category(b)) {
312             (Some(cat_a), Some(cat_b)) => match (&a.kind, &b.kind) {
313                 (&ty::Adt(def_a, _), &ty::Adt(def_b, _)) => def_a == def_b,
314                 _ => cat_a == cat_b
315             },
316             // infer and error can be equated to all types
317             _ => true
318         }
319     }
320
321     fn impl_similar_to(&self,
322                        trait_ref: ty::PolyTraitRef<'tcx>,
323                        obligation: &PredicateObligation<'tcx>)
324                        -> Option<DefId>
325     {
326         let tcx = self.tcx;
327         let param_env = obligation.param_env;
328         let trait_ref = tcx.erase_late_bound_regions(&trait_ref);
329         let trait_self_ty = trait_ref.self_ty();
330
331         let mut self_match_impls = vec![];
332         let mut fuzzy_match_impls = vec![];
333
334         self.tcx.for_each_relevant_impl(
335             trait_ref.def_id, trait_self_ty, |def_id| {
336                 let impl_substs = self.fresh_substs_for_item(obligation.cause.span, def_id);
337                 let impl_trait_ref = tcx
338                     .impl_trait_ref(def_id)
339                     .unwrap()
340                     .subst(tcx, impl_substs);
341
342                 let impl_self_ty = impl_trait_ref.self_ty();
343
344                 if let Ok(..) = self.can_eq(param_env, trait_self_ty, impl_self_ty) {
345                     self_match_impls.push(def_id);
346
347                     if trait_ref.substs.types().skip(1)
348                         .zip(impl_trait_ref.substs.types().skip(1))
349                         .all(|(u,v)| self.fuzzy_match_tys(u, v))
350                     {
351                         fuzzy_match_impls.push(def_id);
352                     }
353                 }
354             });
355
356         let impl_def_id = if self_match_impls.len() == 1 {
357             self_match_impls[0]
358         } else if fuzzy_match_impls.len() == 1 {
359             fuzzy_match_impls[0]
360         } else {
361             return None
362         };
363
364         if tcx.has_attr(impl_def_id, sym::rustc_on_unimplemented) {
365             Some(impl_def_id)
366         } else {
367             None
368         }
369     }
370
371     fn describe_generator(&self, body_id: hir::BodyId) -> Option<&'static str> {
372         self.tcx.hir().body(body_id).generator_kind.map(|gen_kind| {
373             match gen_kind {
374                 hir::GeneratorKind::Gen => "a generator",
375                 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Block) => "an async block",
376                 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Fn) => "an async function",
377                 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Closure) => "an async closure",
378             }
379         })
380     }
381
382     /// Used to set on_unimplemented's `ItemContext`
383     /// to be the enclosing (async) block/function/closure
384     fn describe_enclosure(&self, hir_id: hir::HirId) -> Option<&'static str> {
385         let hir = &self.tcx.hir();
386         let node = hir.find(hir_id)?;
387         if let hir::Node::Item(
388             hir::Item{kind: hir::ItemKind::Fn(sig, _, body_id), .. }) = &node {
389             self.describe_generator(*body_id).or_else(||
390                 Some(if let hir::FnHeader{ asyncness: hir::IsAsync::Async, .. } = sig.header {
391                     "an async function"
392                 } else {
393                     "a function"
394                 })
395             )
396         } else if let hir::Node::Expr(hir::Expr {
397             kind: hir::ExprKind::Closure(_is_move, _, body_id, _, gen_movability), .. }) = &node {
398             self.describe_generator(*body_id).or_else(||
399                 Some(if gen_movability.is_some() {
400                     "an async closure"
401                 } else {
402                     "a closure"
403                 })
404             )
405         } else if let hir::Node::Expr(hir::Expr { .. }) = &node {
406             let parent_hid = hir.get_parent_node(hir_id);
407             if parent_hid != hir_id {
408                 return self.describe_enclosure(parent_hid);
409             } else {
410                 None
411             }
412         } else {
413             None
414         }
415     }
416
417     fn on_unimplemented_note(
418         &self,
419         trait_ref: ty::PolyTraitRef<'tcx>,
420         obligation: &PredicateObligation<'tcx>,
421     ) -> OnUnimplementedNote {
422         let def_id = self.impl_similar_to(trait_ref, obligation)
423             .unwrap_or_else(|| trait_ref.def_id());
424         let trait_ref = *trait_ref.skip_binder();
425
426         let mut flags = vec![];
427         flags.push((sym::item_context,
428             self.describe_enclosure(obligation.cause.body_id).map(|s|s.to_owned())));
429
430         match obligation.cause.code {
431             ObligationCauseCode::BuiltinDerivedObligation(..) |
432             ObligationCauseCode::ImplDerivedObligation(..) => {}
433             _ => {
434                 // this is a "direct", user-specified, rather than derived,
435                 // obligation.
436                 flags.push((sym::direct, None));
437             }
438         }
439
440         if let ObligationCauseCode::ItemObligation(item) = obligation.cause.code {
441             // FIXME: maybe also have some way of handling methods
442             // from other traits? That would require name resolution,
443             // which we might want to be some sort of hygienic.
444             //
445             // Currently I'm leaving it for what I need for `try`.
446             if self.tcx.trait_of_item(item) == Some(trait_ref.def_id) {
447                 let method = self.tcx.item_name(item);
448                 flags.push((sym::from_method, None));
449                 flags.push((sym::from_method, Some(method.to_string())));
450             }
451         }
452         if let Some(t) = self.get_parent_trait_ref(&obligation.cause.code) {
453             flags.push((sym::parent_trait, Some(t)));
454         }
455
456         if let Some(k) = obligation.cause.span.desugaring_kind() {
457             flags.push((sym::from_desugaring, None));
458             flags.push((sym::from_desugaring, Some(format!("{:?}", k))));
459         }
460         let generics = self.tcx.generics_of(def_id);
461         let self_ty = trait_ref.self_ty();
462         // This is also included through the generics list as `Self`,
463         // but the parser won't allow you to use it
464         flags.push((sym::_Self, Some(self_ty.to_string())));
465         if let Some(def) = self_ty.ty_adt_def() {
466             // We also want to be able to select self's original
467             // signature with no type arguments resolved
468             flags.push((sym::_Self, Some(self.tcx.type_of(def.did).to_string())));
469         }
470
471         for param in generics.params.iter() {
472             let value = match param.kind {
473                 GenericParamDefKind::Type { .. } |
474                 GenericParamDefKind::Const => {
475                     trait_ref.substs[param.index as usize].to_string()
476                 },
477                 GenericParamDefKind::Lifetime => continue,
478             };
479             let name = param.name;
480             flags.push((name, Some(value)));
481         }
482
483         if let Some(true) = self_ty.ty_adt_def().map(|def| def.did.is_local()) {
484             flags.push((sym::crate_local, None));
485         }
486
487         // Allow targeting all integers using `{integral}`, even if the exact type was resolved
488         if self_ty.is_integral() {
489             flags.push((sym::_Self, Some("{integral}".to_owned())));
490         }
491
492         if let ty::Array(aty, len) = self_ty.kind {
493             flags.push((sym::_Self, Some("[]".to_owned())));
494             flags.push((sym::_Self, Some(format!("[{}]", aty))));
495             if let Some(def) = aty.ty_adt_def() {
496                 // We also want to be able to select the array's type's original
497                 // signature with no type arguments resolved
498                 flags.push((
499                     sym::_Self,
500                     Some(format!("[{}]", self.tcx.type_of(def.did).to_string())),
501                 ));
502                 let tcx = self.tcx;
503                 if let Some(len) = len.try_eval_usize(tcx, ty::ParamEnv::empty()) {
504                     flags.push((
505                         sym::_Self,
506                         Some(format!("[{}; {}]", self.tcx.type_of(def.did).to_string(), len)),
507                     ));
508                 } else {
509                     flags.push((
510                         sym::_Self,
511                         Some(format!("[{}; _]", self.tcx.type_of(def.did).to_string())),
512                     ));
513                 }
514             }
515         }
516
517         if let Ok(Some(command)) = OnUnimplementedDirective::of_item(
518             self.tcx, trait_ref.def_id, def_id
519         ) {
520             command.evaluate(self.tcx, trait_ref, &flags[..])
521         } else {
522             OnUnimplementedNote::empty()
523         }
524     }
525
526     fn find_similar_impl_candidates(
527         &self,
528         trait_ref: ty::PolyTraitRef<'tcx>,
529     ) -> Vec<ty::TraitRef<'tcx>> {
530         let simp = fast_reject::simplify_type(self.tcx, trait_ref.skip_binder().self_ty(), true);
531         let all_impls = self.tcx.all_impls(trait_ref.def_id());
532
533         match simp {
534             Some(simp) => all_impls.iter().filter_map(|&def_id| {
535                 let imp = self.tcx.impl_trait_ref(def_id).unwrap();
536                 let imp_simp = fast_reject::simplify_type(self.tcx, imp.self_ty(), true);
537                 if let Some(imp_simp) = imp_simp {
538                     if simp != imp_simp {
539                         return None
540                     }
541                 }
542
543                 Some(imp)
544             }).collect(),
545             None => all_impls.iter().map(|&def_id|
546                 self.tcx.impl_trait_ref(def_id).unwrap()
547             ).collect()
548         }
549     }
550
551     fn report_similar_impl_candidates(
552         &self,
553         impl_candidates: Vec<ty::TraitRef<'tcx>>,
554         err: &mut DiagnosticBuilder<'_>,
555     ) {
556         if impl_candidates.is_empty() {
557             return;
558         }
559
560         let len = impl_candidates.len();
561         let end = if impl_candidates.len() <= 5 {
562             impl_candidates.len()
563         } else {
564             4
565         };
566
567         let normalize = |candidate| self.tcx.infer_ctxt().enter(|ref infcx| {
568             let normalized = infcx
569                 .at(&ObligationCause::dummy(), ty::ParamEnv::empty())
570                 .normalize(candidate)
571                 .ok();
572             match normalized {
573                 Some(normalized) => format!("\n  {:?}", normalized.value),
574                 None => format!("\n  {:?}", candidate),
575             }
576         });
577
578         // Sort impl candidates so that ordering is consistent for UI tests.
579         let mut normalized_impl_candidates = impl_candidates
580             .iter()
581             .map(normalize)
582             .collect::<Vec<String>>();
583
584         // Sort before taking the `..end` range,
585         // because the ordering of `impl_candidates` may not be deterministic:
586         // https://github.com/rust-lang/rust/pull/57475#issuecomment-455519507
587         normalized_impl_candidates.sort();
588
589         err.help(&format!("the following implementations were found:{}{}",
590                           normalized_impl_candidates[..end].join(""),
591                           if len > 5 {
592                               format!("\nand {} others", len - 4)
593                           } else {
594                               String::new()
595                           }
596                           ));
597     }
598
599     /// Reports that an overflow has occurred and halts compilation. We
600     /// halt compilation unconditionally because it is important that
601     /// overflows never be masked -- they basically represent computations
602     /// whose result could not be truly determined and thus we can't say
603     /// if the program type checks or not -- and they are unusual
604     /// occurrences in any case.
605     pub fn report_overflow_error<T>(
606         &self,
607         obligation: &Obligation<'tcx, T>,
608         suggest_increasing_limit: bool,
609     ) -> !
610         where T: fmt::Display + TypeFoldable<'tcx>
611     {
612         let predicate =
613             self.resolve_vars_if_possible(&obligation.predicate);
614         let mut err = struct_span_err!(
615             self.tcx.sess,
616             obligation.cause.span,
617             E0275,
618             "overflow evaluating the requirement `{}`",
619             predicate
620         );
621
622         if suggest_increasing_limit {
623             self.suggest_new_overflow_limit(&mut err);
624         }
625
626         self.note_obligation_cause_code(
627             &mut err,
628             &obligation.predicate,
629             &obligation.cause.code,
630             &mut vec![],
631         );
632
633         err.emit();
634         self.tcx.sess.abort_if_errors();
635         bug!();
636     }
637
638     /// Reports that a cycle was detected which led to overflow and halts
639     /// compilation. This is equivalent to `report_overflow_error` except
640     /// that we can give a more helpful error message (and, in particular,
641     /// we do not suggest increasing the overflow limit, which is not
642     /// going to help).
643     pub fn report_overflow_error_cycle(&self, cycle: &[PredicateObligation<'tcx>]) -> ! {
644         let cycle = self.resolve_vars_if_possible(&cycle.to_owned());
645         assert!(cycle.len() > 0);
646
647         debug!("report_overflow_error_cycle: cycle={:?}", cycle);
648
649         self.report_overflow_error(&cycle[0], false);
650     }
651
652     pub fn report_extra_impl_obligation(&self,
653                                         error_span: Span,
654                                         item_name: ast::Name,
655                                         _impl_item_def_id: DefId,
656                                         trait_item_def_id: DefId,
657                                         requirement: &dyn fmt::Display)
658                                         -> DiagnosticBuilder<'tcx>
659     {
660         let msg = "impl has stricter requirements than trait";
661         let sp = self.tcx.sess.source_map().def_span(error_span);
662
663         let mut err = struct_span_err!(self.tcx.sess, sp, E0276, "{}", msg);
664
665         if let Some(trait_item_span) = self.tcx.hir().span_if_local(trait_item_def_id) {
666             let span = self.tcx.sess.source_map().def_span(trait_item_span);
667             err.span_label(span, format!("definition of `{}` from trait", item_name));
668         }
669
670         err.span_label(sp, format!("impl has extra requirement {}", requirement));
671
672         err
673     }
674
675
676     /// Gets the parent trait chain start
677     fn get_parent_trait_ref(&self, code: &ObligationCauseCode<'tcx>) -> Option<String> {
678         match code {
679             &ObligationCauseCode::BuiltinDerivedObligation(ref data) => {
680                 let parent_trait_ref = self.resolve_vars_if_possible(
681                     &data.parent_trait_ref);
682                 match self.get_parent_trait_ref(&data.parent_code) {
683                     Some(t) => Some(t),
684                     None => Some(parent_trait_ref.skip_binder().self_ty().to_string()),
685                 }
686             }
687             _ => None,
688         }
689     }
690
691     pub fn report_selection_error(
692         &self,
693         obligation: &PredicateObligation<'tcx>,
694         error: &SelectionError<'tcx>,
695         fallback_has_occurred: bool,
696         points_at_arg: bool,
697     ) {
698         let span = obligation.cause.span;
699
700         let mut err = match *error {
701             SelectionError::Unimplemented => {
702                 if let ObligationCauseCode::CompareImplMethodObligation {
703                     item_name, impl_item_def_id, trait_item_def_id,
704                 } = obligation.cause.code {
705                     self.report_extra_impl_obligation(
706                         span,
707                         item_name,
708                         impl_item_def_id,
709                         trait_item_def_id,
710                         &format!("`{}`", obligation.predicate))
711                         .emit();
712                     return;
713                 }
714                 match obligation.predicate {
715                     ty::Predicate::Trait(ref trait_predicate) => {
716                         let trait_predicate = self.resolve_vars_if_possible(trait_predicate);
717
718                         if self.tcx.sess.has_errors() && trait_predicate.references_error() {
719                             return;
720                         }
721                         let trait_ref = trait_predicate.to_poly_trait_ref();
722                         let (
723                             post_message,
724                             pre_message,
725                         ) = self.get_parent_trait_ref(&obligation.cause.code)
726                             .map(|t| (format!(" in `{}`", t), format!("within `{}`, ", t)))
727                             .unwrap_or_default();
728
729                         let OnUnimplementedNote {
730                             message,
731                             label,
732                             note,
733                         } = self.on_unimplemented_note(trait_ref, obligation);
734                         let have_alt_message = message.is_some() || label.is_some();
735                         let is_try = self.tcx.sess.source_map().span_to_snippet(span)
736                             .map(|s| &s == "?")
737                             .unwrap_or(false);
738                         let is_from = format!("{}", trait_ref).starts_with("std::convert::From<");
739                         let (message, note) = if is_try && is_from {
740                             (Some(format!(
741                                 "`?` couldn't convert the error to `{}`",
742                                 trait_ref.self_ty(),
743                             )), Some(
744                                 "the question mark operation (`?`) implicitly performs a \
745                                  conversion on the error value using the `From` trait".to_owned()
746                             ))
747                         } else {
748                             (message, note)
749                         };
750
751                         let mut err = struct_span_err!(
752                             self.tcx.sess,
753                             span,
754                             E0277,
755                             "{}",
756                             message.unwrap_or_else(|| format!(
757                                 "the trait bound `{}` is not satisfied{}",
758                                 trait_ref.to_predicate(),
759                                 post_message,
760                             )));
761
762                         let explanation =
763                             if obligation.cause.code == ObligationCauseCode::MainFunctionType {
764                                 "consider using `()`, or a `Result`".to_owned()
765                             } else {
766                                 format!(
767                                     "{}the trait `{}` is not implemented for `{}`",
768                                     pre_message,
769                                     trait_ref,
770                                     trait_ref.self_ty(),
771                                 )
772                             };
773
774                         if self.suggest_add_reference_to_arg(
775                             &obligation,
776                             &mut err,
777                             &trait_ref,
778                             points_at_arg,
779                             have_alt_message,
780                         ) {
781                             self.note_obligation_cause(&mut err, obligation);
782                             err.emit();
783                             return;
784                         }
785                         if let Some(ref s) = label {
786                             // If it has a custom `#[rustc_on_unimplemented]`
787                             // error message, let's display it as the label!
788                             err.span_label(span, s.as_str());
789                             err.help(&explanation);
790                         } else {
791                             err.span_label(span, explanation);
792                         }
793                         if let Some(ref s) = note {
794                             // If it has a custom `#[rustc_on_unimplemented]` note, let's display it
795                             err.note(s.as_str());
796                         }
797
798                         self.suggest_borrow_on_unsized_slice(&obligation.cause.code, &mut err);
799                         self.suggest_fn_call(&obligation, &mut err, &trait_ref, points_at_arg);
800                         self.suggest_remove_reference(&obligation, &mut err, &trait_ref);
801                         self.suggest_semicolon_removal(&obligation, &mut err, span, &trait_ref);
802
803                         // Try to report a help message
804                         if !trait_ref.has_infer_types() &&
805                             self.predicate_can_apply(obligation.param_env, trait_ref) {
806                             // If a where-clause may be useful, remind the
807                             // user that they can add it.
808                             //
809                             // don't display an on-unimplemented note, as
810                             // these notes will often be of the form
811                             //     "the type `T` can't be frobnicated"
812                             // which is somewhat confusing.
813                             self.suggest_restricting_param_bound(
814                                 &mut err,
815                                 &trait_ref,
816                                 obligation.cause.body_id,
817                             );
818                         } else {
819                             if !have_alt_message {
820                                 // Can't show anything else useful, try to find similar impls.
821                                 let impl_candidates = self.find_similar_impl_candidates(trait_ref);
822                                 self.report_similar_impl_candidates(impl_candidates, &mut err);
823                             }
824                             self.suggest_change_mut(
825                                 &obligation,
826                                 &mut err,
827                                 &trait_ref,
828                                 points_at_arg,
829                             );
830                         }
831
832                         // If this error is due to `!: Trait` not implemented but `(): Trait` is
833                         // implemented, and fallback has occurred, then it could be due to a
834                         // variable that used to fallback to `()` now falling back to `!`. Issue a
835                         // note informing about the change in behaviour.
836                         if trait_predicate.skip_binder().self_ty().is_never()
837                             && fallback_has_occurred
838                         {
839                             let predicate = trait_predicate.map_bound(|mut trait_pred| {
840                                 trait_pred.trait_ref.substs = self.tcx.mk_substs_trait(
841                                     self.tcx.mk_unit(),
842                                     &trait_pred.trait_ref.substs[1..],
843                                 );
844                                 trait_pred
845                             });
846                             let unit_obligation = Obligation {
847                                 predicate: ty::Predicate::Trait(predicate),
848                                 .. obligation.clone()
849                             };
850                             if self.predicate_may_hold(&unit_obligation) {
851                                 err.note("the trait is implemented for `()`. \
852                                          Possibly this error has been caused by changes to \
853                                          Rust's type-inference algorithm \
854                                          (see: https://github.com/rust-lang/rust/issues/48950 \
855                                          for more info). Consider whether you meant to use the \
856                                          type `()` here instead.");
857                             }
858                         }
859
860                         err
861                     }
862
863                     ty::Predicate::Subtype(ref predicate) => {
864                         // Errors for Subtype predicates show up as
865                         // `FulfillmentErrorCode::CodeSubtypeError`,
866                         // not selection error.
867                         span_bug!(span, "subtype requirement gave wrong error: `{:?}`", predicate)
868                     }
869
870                     ty::Predicate::RegionOutlives(ref predicate) => {
871                         let predicate = self.resolve_vars_if_possible(predicate);
872                         let err = self.region_outlives_predicate(&obligation.cause,
873                                                                  &predicate).err().unwrap();
874                         struct_span_err!(
875                             self.tcx.sess, span, E0279,
876                             "the requirement `{}` is not satisfied (`{}`)",
877                             predicate, err,
878                         )
879                     }
880
881                     ty::Predicate::Projection(..) | ty::Predicate::TypeOutlives(..) => {
882                         let predicate =
883                             self.resolve_vars_if_possible(&obligation.predicate);
884                         struct_span_err!(self.tcx.sess, span, E0280,
885                             "the requirement `{}` is not satisfied",
886                             predicate)
887                     }
888
889                     ty::Predicate::ObjectSafe(trait_def_id) => {
890                         let violations = self.tcx.object_safety_violations(trait_def_id);
891                         self.tcx.report_object_safety_error(
892                             span,
893                             trait_def_id,
894                             violations,
895                         )
896                     }
897
898                     ty::Predicate::ClosureKind(closure_def_id, closure_substs, kind) => {
899                         let found_kind = self.closure_kind(closure_def_id, closure_substs).unwrap();
900                         let closure_span = self.tcx.sess.source_map()
901                             .def_span(self.tcx.hir().span_if_local(closure_def_id).unwrap());
902                         let hir_id = self.tcx.hir().as_local_hir_id(closure_def_id).unwrap();
903                         let mut err = struct_span_err!(
904                             self.tcx.sess, closure_span, E0525,
905                             "expected a closure that implements the `{}` trait, \
906                              but this closure only implements `{}`",
907                             kind,
908                             found_kind);
909
910                         err.span_label(
911                             closure_span,
912                             format!("this closure implements `{}`, not `{}`", found_kind, kind));
913                         err.span_label(
914                             obligation.cause.span,
915                             format!("the requirement to implement `{}` derives from here", kind));
916
917                         // Additional context information explaining why the closure only implements
918                         // a particular trait.
919                         if let Some(tables) = self.in_progress_tables {
920                             let tables = tables.borrow();
921                             match (found_kind, tables.closure_kind_origins().get(hir_id)) {
922                                 (ty::ClosureKind::FnOnce, Some((span, name))) => {
923                                     err.span_label(*span, format!(
924                                         "closure is `FnOnce` because it moves the \
925                                          variable `{}` out of its environment", name));
926                                 },
927                                 (ty::ClosureKind::FnMut, Some((span, name))) => {
928                                     err.span_label(*span, format!(
929                                         "closure is `FnMut` because it mutates the \
930                                          variable `{}` here", name));
931                                 },
932                                 _ => {}
933                             }
934                         }
935
936                         err.emit();
937                         return;
938                     }
939
940                     ty::Predicate::WellFormed(ty) => {
941                         if !self.tcx.sess.opts.debugging_opts.chalk {
942                             // WF predicates cannot themselves make
943                             // errors. They can only block due to
944                             // ambiguity; otherwise, they always
945                             // degenerate into other obligations
946                             // (which may fail).
947                             span_bug!(span, "WF predicate not satisfied for {:?}", ty);
948                         } else {
949                             // FIXME: we'll need a better message which takes into account
950                             // which bounds actually failed to hold.
951                             self.tcx.sess.struct_span_err(
952                                 span,
953                                 &format!("the type `{}` is not well-formed (chalk)", ty)
954                             )
955                         }
956                     }
957
958                     ty::Predicate::ConstEvaluatable(..) => {
959                         // Errors for `ConstEvaluatable` predicates show up as
960                         // `SelectionError::ConstEvalFailure`,
961                         // not `Unimplemented`.
962                         span_bug!(span,
963                             "const-evaluatable requirement gave wrong error: `{:?}`", obligation)
964                     }
965                 }
966             }
967
968             OutputTypeParameterMismatch(ref found_trait_ref, ref expected_trait_ref, _) => {
969                 let found_trait_ref = self.resolve_vars_if_possible(&*found_trait_ref);
970                 let expected_trait_ref = self.resolve_vars_if_possible(&*expected_trait_ref);
971
972                 if expected_trait_ref.self_ty().references_error() {
973                     return;
974                 }
975
976                 let found_trait_ty = found_trait_ref.self_ty();
977
978                 let found_did = match found_trait_ty.kind {
979                     ty::Closure(did, _) | ty::Foreign(did) | ty::FnDef(did, _) => Some(did),
980                     ty::Adt(def, _) => Some(def.did),
981                     _ => None,
982                 };
983
984                 let found_span = found_did.and_then(|did|
985                     self.tcx.hir().span_if_local(did)
986                 ).map(|sp| self.tcx.sess.source_map().def_span(sp)); // the sp could be an fn def
987
988                 if self.reported_closure_mismatch.borrow().contains(&(span, found_span)) {
989                     // We check closures twice, with obligations flowing in different directions,
990                     // but we want to complain about them only once.
991                     return;
992                 }
993
994                 self.reported_closure_mismatch.borrow_mut().insert((span, found_span));
995
996                 let found = match found_trait_ref.skip_binder().substs.type_at(1).kind {
997                     ty::Tuple(ref tys) => vec![ArgKind::empty(); tys.len()],
998                     _ => vec![ArgKind::empty()],
999                 };
1000
1001                 let expected_ty = expected_trait_ref.skip_binder().substs.type_at(1);
1002                 let expected = match expected_ty.kind {
1003                     ty::Tuple(ref tys) => tys.iter()
1004                         .map(|t| ArgKind::from_expected_ty(t.expect_ty(), Some(span))).collect(),
1005                     _ => vec![ArgKind::Arg("_".to_owned(), expected_ty.to_string())],
1006                 };
1007
1008                 if found.len() == expected.len() {
1009                     self.report_closure_arg_mismatch(span,
1010                                                      found_span,
1011                                                      found_trait_ref,
1012                                                      expected_trait_ref)
1013                 } else {
1014                     let (closure_span, found) = found_did
1015                         .and_then(|did| self.tcx.hir().get_if_local(did))
1016                         .map(|node| {
1017                             let (found_span, found) = self.get_fn_like_arguments(node);
1018                             (Some(found_span), found)
1019                         }).unwrap_or((found_span, found));
1020
1021                     self.report_arg_count_mismatch(span,
1022                                                    closure_span,
1023                                                    expected,
1024                                                    found,
1025                                                    found_trait_ty.is_closure())
1026                 }
1027             }
1028
1029             TraitNotObjectSafe(did) => {
1030                 let violations = self.tcx.object_safety_violations(did);
1031                 self.tcx.report_object_safety_error(span, did, violations)
1032             }
1033
1034             // already reported in the query
1035             ConstEvalFailure(err) => {
1036                 self.tcx.sess.delay_span_bug(
1037                     span,
1038                     &format!("constant in type had an ignored error: {:?}", err),
1039                 );
1040                 return;
1041             }
1042
1043             Overflow => {
1044                 bug!("overflow should be handled before the `report_selection_error` path");
1045             }
1046         };
1047
1048         self.note_obligation_cause(&mut err, obligation);
1049
1050         err.emit();
1051     }
1052
1053     fn suggest_restricting_param_bound(
1054         &self,
1055         err: &mut DiagnosticBuilder<'_>,
1056         trait_ref: &ty::PolyTraitRef<'_>,
1057         body_id: hir::HirId,
1058     ) {
1059         let self_ty = trait_ref.self_ty();
1060         let (param_ty, projection) = match &self_ty.kind {
1061             ty::Param(_) => (true, None),
1062             ty::Projection(projection) => (false, Some(projection)),
1063             _ => return,
1064         };
1065
1066         let mut suggest_restriction = |generics: &hir::Generics, msg| {
1067             let span = generics.where_clause.span_for_predicates_or_empty_place();
1068             if !span.from_expansion() && span.desugaring_kind().is_none() {
1069                 err.span_suggestion(
1070                     generics.where_clause.span_for_predicates_or_empty_place().shrink_to_hi(),
1071                     &format!("consider further restricting {}", msg),
1072                     format!(
1073                         "{} {} ",
1074                         if !generics.where_clause.predicates.is_empty() {
1075                             ","
1076                         } else {
1077                             " where"
1078                         },
1079                         trait_ref.to_predicate(),
1080                     ),
1081                     Applicability::MachineApplicable,
1082                 );
1083             }
1084         };
1085
1086         // FIXME: Add check for trait bound that is already present, particularly `?Sized` so we
1087         //        don't suggest `T: Sized + ?Sized`.
1088         let mut hir_id = body_id;
1089         while let Some(node) = self.tcx.hir().find(hir_id) {
1090             match node {
1091                 hir::Node::TraitItem(hir::TraitItem {
1092                     generics,
1093                     kind: hir::TraitItemKind::Method(..), ..
1094                 }) if param_ty && self_ty == self.tcx.types.self_param => {
1095                     // Restricting `Self` for a single method.
1096                     suggest_restriction(&generics, "`Self`");
1097                     return;
1098                 }
1099
1100                 hir::Node::Item(hir::Item {
1101                     kind: hir::ItemKind::Fn(_, generics, _), ..
1102                 }) |
1103                 hir::Node::TraitItem(hir::TraitItem {
1104                     generics,
1105                     kind: hir::TraitItemKind::Method(..), ..
1106                 }) |
1107                 hir::Node::ImplItem(hir::ImplItem {
1108                     generics,
1109                     kind: hir::ImplItemKind::Method(..), ..
1110                 }) |
1111                 hir::Node::Item(hir::Item {
1112                     kind: hir::ItemKind::Trait(_, _, generics, _, _), ..
1113                 }) |
1114                 hir::Node::Item(hir::Item {
1115                     kind: hir::ItemKind::Impl(_, _, _, generics, ..), ..
1116                 }) if projection.is_some() => {
1117                     // Missing associated type bound.
1118                     suggest_restriction(&generics, "the associated type");
1119                     return;
1120                 }
1121
1122                 hir::Node::Item(hir::Item { kind: hir::ItemKind::Struct(_, generics), span, .. }) |
1123                 hir::Node::Item(hir::Item { kind: hir::ItemKind::Enum(_, generics), span, .. }) |
1124                 hir::Node::Item(hir::Item { kind: hir::ItemKind::Union(_, generics), span, .. }) |
1125                 hir::Node::Item(hir::Item {
1126                     kind: hir::ItemKind::Trait(_, _, generics, ..), span, ..
1127                 }) |
1128                 hir::Node::Item(hir::Item {
1129                     kind: hir::ItemKind::Impl(_, _, _, generics, ..), span, ..
1130                 }) |
1131                 hir::Node::Item(hir::Item {
1132                     kind: hir::ItemKind::Fn(_, generics, _), span, ..
1133                 }) |
1134                 hir::Node::Item(hir::Item {
1135                     kind: hir::ItemKind::TyAlias(_, generics), span, ..
1136                 }) |
1137                 hir::Node::Item(hir::Item {
1138                     kind: hir::ItemKind::TraitAlias(generics, _), span, ..
1139                 }) |
1140                 hir::Node::Item(hir::Item {
1141                     kind: hir::ItemKind::OpaqueTy(hir::OpaqueTy { generics, .. }), span, ..
1142                 }) |
1143                 hir::Node::TraitItem(hir::TraitItem { generics, span, .. }) |
1144                 hir::Node::ImplItem(hir::ImplItem { generics, span, .. })
1145                 if param_ty => {
1146                     // Missing generic type parameter bound.
1147                     let restrict_msg = "consider further restricting this bound";
1148                     let param_name = self_ty.to_string();
1149                     for param in generics.params.iter().filter(|p| {
1150                         p.name.ident().as_str() == param_name
1151                     }) {
1152                         if param_name.starts_with("impl ") {
1153                             // `impl Trait` in argument:
1154                             // `fn foo(x: impl Trait) {}` → `fn foo(t: impl Trait + Trait2) {}`
1155                             err.span_suggestion(
1156                                 param.span,
1157                                 restrict_msg,
1158                                 // `impl CurrentTrait + MissingTrait`
1159                                 format!("{} + {}", param.name.ident(), trait_ref),
1160                                 Applicability::MachineApplicable,
1161                             );
1162                         } else if generics.where_clause.predicates.is_empty() &&
1163                                 param.bounds.is_empty()
1164                         {
1165                             // If there are no bounds whatsoever, suggest adding a constraint
1166                             // to the type parameter:
1167                             // `fn foo<T>(t: T) {}` → `fn foo<T: Trait>(t: T) {}`
1168                             err.span_suggestion(
1169                                 param.span,
1170                                 "consider restricting this bound",
1171                                 format!("{}", trait_ref.to_predicate()),
1172                                 Applicability::MachineApplicable,
1173                             );
1174                         } else if !generics.where_clause.predicates.is_empty() {
1175                             // There is a `where` clause, so suggest expanding it:
1176                             // `fn foo<T>(t: T) where T: Debug {}` →
1177                             // `fn foo<T>(t: T) where T: Debug, T: Trait {}`
1178                             err.span_suggestion(
1179                                 generics.where_clause.span().unwrap().shrink_to_hi(),
1180                                 &format!(
1181                                     "consider further restricting type parameter `{}`",
1182                                     param_name,
1183                                 ),
1184                                 format!(", {}", trait_ref.to_predicate()),
1185                                 Applicability::MachineApplicable,
1186                             );
1187                         } else {
1188                             // If there is no `where` clause lean towards constraining to the
1189                             // type parameter:
1190                             // `fn foo<X: Bar, T>(t: T, x: X) {}` → `fn foo<T: Trait>(t: T) {}`
1191                             // `fn foo<T: Bar>(t: T) {}` → `fn foo<T: Bar + Trait>(t: T) {}`
1192                             let sp = param.span.with_hi(span.hi());
1193                             let span = self.tcx.sess.source_map()
1194                                 .span_through_char(sp, ':');
1195                             if sp != param.span && sp != span {
1196                                 // Only suggest if we have high certainty that the span
1197                                 // covers the colon in `foo<T: Trait>`.
1198                                 err.span_suggestion(span, restrict_msg, format!(
1199                                     "{} + ",
1200                                     trait_ref.to_predicate(),
1201                                 ), Applicability::MachineApplicable);
1202                             } else {
1203                                 err.span_label(param.span, &format!(
1204                                     "consider adding a `where {}` bound",
1205                                     trait_ref.to_predicate(),
1206                                 ));
1207                             }
1208                         }
1209                         return;
1210                     }
1211                 }
1212
1213                 hir::Node::Crate => return,
1214
1215                 _ => {}
1216             }
1217
1218             hir_id = self.tcx.hir().get_parent_item(hir_id);
1219         }
1220     }
1221
1222     /// When encountering an assignment of an unsized trait, like `let x = ""[..];`, provide a
1223     /// suggestion to borrow the initializer in order to use have a slice instead.
1224     fn suggest_borrow_on_unsized_slice(
1225         &self,
1226         code: &ObligationCauseCode<'tcx>,
1227         err: &mut DiagnosticBuilder<'tcx>,
1228     ) {
1229         if let &ObligationCauseCode::VariableType(hir_id) = code {
1230             let parent_node = self.tcx.hir().get_parent_node(hir_id);
1231             if let Some(Node::Local(ref local)) = self.tcx.hir().find(parent_node) {
1232                 if let Some(ref expr) = local.init {
1233                     if let hir::ExprKind::Index(_, _) = expr.kind {
1234                         if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
1235                             err.span_suggestion(
1236                                 expr.span,
1237                                 "consider borrowing here",
1238                                 format!("&{}", snippet),
1239                                 Applicability::MachineApplicable
1240                             );
1241                         }
1242                     }
1243                 }
1244             }
1245         }
1246     }
1247
1248     fn mk_obligation_for_def_id(
1249         &self,
1250         def_id: DefId,
1251         output_ty: Ty<'tcx>,
1252         cause: ObligationCause<'tcx>,
1253         param_env: ty::ParamEnv<'tcx>,
1254     ) -> PredicateObligation<'tcx> {
1255         let new_trait_ref = ty::TraitRef {
1256             def_id,
1257             substs: self.tcx.mk_substs_trait(output_ty, &[]),
1258         };
1259         Obligation::new(cause, param_env, new_trait_ref.to_predicate())
1260     }
1261
1262     /// Given a closure's `DefId`, return the given name of the closure.
1263     ///
1264     /// This doesn't account for reassignments, but it's only used for suggestions.
1265     fn get_closure_name(
1266         &self,
1267         def_id: DefId,
1268         err: &mut DiagnosticBuilder<'_>,
1269         msg: &str,
1270     ) -> Option<String> {
1271         let get_name = |err: &mut DiagnosticBuilder<'_>, kind: &hir::PatKind| -> Option<String> {
1272             // Get the local name of this closure. This can be inaccurate because
1273             // of the possibility of reassignment, but this should be good enough.
1274             match &kind {
1275                 hir::PatKind::Binding(hir::BindingAnnotation::Unannotated, _, name, None) => {
1276                     Some(format!("{}", name))
1277                 }
1278                 _ => {
1279                     err.note(&msg);
1280                     None
1281                 }
1282             }
1283         };
1284
1285         let hir = self.tcx.hir();
1286         let hir_id = hir.as_local_hir_id(def_id)?;
1287         let parent_node = hir.get_parent_node(hir_id);
1288         match hir.find(parent_node) {
1289             Some(hir::Node::Stmt(hir::Stmt {
1290                 kind: hir::StmtKind::Local(local), ..
1291             })) => get_name(err, &local.pat.kind),
1292             // Different to previous arm because one is `&hir::Local` and the other
1293             // is `P<hir::Local>`.
1294             Some(hir::Node::Local(local)) => get_name(err, &local.pat.kind),
1295             _ => return None,
1296         }
1297     }
1298
1299     /// We tried to apply the bound to an `fn` or closure. Check whether calling it would
1300     /// evaluate to a type that *would* satisfy the trait binding. If it would, suggest calling
1301     /// it: `bar(foo)` → `bar(foo())`. This case is *very* likely to be hit if `foo` is `async`.
1302     fn suggest_fn_call(
1303         &self,
1304         obligation: &PredicateObligation<'tcx>,
1305         err: &mut DiagnosticBuilder<'_>,
1306         trait_ref: &ty::Binder<ty::TraitRef<'tcx>>,
1307         points_at_arg: bool,
1308     ) {
1309         let self_ty = trait_ref.self_ty();
1310         let (def_id, output_ty, callable) = match self_ty.kind {
1311             ty::Closure(def_id, substs) => {
1312                 (def_id, self.closure_sig(def_id, substs).output(), "closure")
1313             }
1314             ty::FnDef(def_id, _) => {
1315                 (def_id, self_ty.fn_sig(self.tcx).output(), "function")
1316             }
1317             _ => return,
1318         };
1319         let msg = format!("use parentheses to call the {}", callable);
1320
1321         let obligation = self.mk_obligation_for_def_id(
1322             trait_ref.def_id(),
1323             output_ty.skip_binder(),
1324             obligation.cause.clone(),
1325             obligation.param_env,
1326         );
1327
1328         match self.evaluate_obligation(&obligation) {
1329             Ok(EvaluationResult::EvaluatedToOk) |
1330             Ok(EvaluationResult::EvaluatedToOkModuloRegions) |
1331             Ok(EvaluationResult::EvaluatedToAmbig) => {}
1332             _ => return,
1333         }
1334         let hir = self.tcx.hir();
1335         // Get the name of the callable and the arguments to be used in the suggestion.
1336         let snippet = match hir.get_if_local(def_id) {
1337             Some(hir::Node::Expr(hir::Expr {
1338                 kind: hir::ExprKind::Closure(_, decl, _, span, ..),
1339                 ..
1340             })) => {
1341                 err.span_label(*span, "consider calling this closure");
1342                 let name = match self.get_closure_name(def_id, err, &msg) {
1343                     Some(name) => name,
1344                     None => return,
1345                 };
1346                 let args = decl.inputs.iter()
1347                     .map(|_| "_")
1348                     .collect::<Vec<_>>()
1349                     .join(", ");
1350                 format!("{}({})", name, args)
1351             }
1352             Some(hir::Node::Item(hir::Item {
1353                 ident,
1354                 kind: hir::ItemKind::Fn(.., body_id),
1355                 ..
1356             })) => {
1357                 err.span_label(ident.span, "consider calling this function");
1358                 let body = hir.body(*body_id);
1359                 let args = body.params.iter()
1360                     .map(|arg| match &arg.pat.kind {
1361                         hir::PatKind::Binding(_, _, ident, None)
1362                         // FIXME: provide a better suggestion when encountering `SelfLower`, it
1363                         // should suggest a method call.
1364                         if ident.name != kw::SelfLower => ident.to_string(),
1365                         _ => "_".to_string(),
1366                     })
1367                     .collect::<Vec<_>>()
1368                     .join(", ");
1369                 format!("{}({})", ident, args)
1370             }
1371             _ => return,
1372         };
1373         if points_at_arg {
1374             // When the obligation error has been ensured to have been caused by
1375             // an argument, the `obligation.cause.span` points at the expression
1376             // of the argument, so we can provide a suggestion. This is signaled
1377             // by `points_at_arg`. Otherwise, we give a more general note.
1378             err.span_suggestion(
1379                 obligation.cause.span,
1380                 &msg,
1381                 snippet,
1382                 Applicability::HasPlaceholders,
1383             );
1384         } else {
1385             err.help(&format!("{}: `{}`", msg, snippet));
1386         }
1387     }
1388
1389     fn suggest_add_reference_to_arg(
1390         &self,
1391         obligation: &PredicateObligation<'tcx>,
1392         err: &mut DiagnosticBuilder<'tcx>,
1393         trait_ref: &ty::Binder<ty::TraitRef<'tcx>>,
1394         points_at_arg: bool,
1395         has_custom_message: bool,
1396     ) -> bool {
1397         if !points_at_arg {
1398             return false;
1399         }
1400
1401         let span = obligation.cause.span;
1402         let param_env = obligation.param_env;
1403         let trait_ref = trait_ref.skip_binder();
1404
1405         if let ObligationCauseCode::ImplDerivedObligation(obligation) = &obligation.cause.code {
1406             // Try to apply the original trait binding obligation by borrowing.
1407             let self_ty = trait_ref.self_ty();
1408             let found = self_ty.to_string();
1409             let new_self_ty = self.tcx.mk_imm_ref(self.tcx.lifetimes.re_static, self_ty);
1410             let substs = self.tcx.mk_substs_trait(new_self_ty, &[]);
1411             let new_trait_ref = ty::TraitRef::new(obligation.parent_trait_ref.def_id(), substs);
1412             let new_obligation = Obligation::new(
1413                 ObligationCause::dummy(),
1414                 param_env,
1415                 new_trait_ref.to_predicate(),
1416             );
1417             if self.predicate_must_hold_modulo_regions(&new_obligation) {
1418                 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
1419                     // We have a very specific type of error, where just borrowing this argument
1420                     // might solve the problem. In cases like this, the important part is the
1421                     // original type obligation, not the last one that failed, which is arbitrary.
1422                     // Because of this, we modify the error to refer to the original obligation and
1423                     // return early in the caller.
1424                     let msg = format!(
1425                         "the trait bound `{}: {}` is not satisfied",
1426                         found,
1427                         obligation.parent_trait_ref.skip_binder(),
1428                     );
1429                     if has_custom_message {
1430                         err.note(&msg);
1431                     } else {
1432                         err.message = vec![(msg, Style::NoStyle)];
1433                     }
1434                     if snippet.starts_with('&') {
1435                         // This is already a literal borrow and the obligation is failing
1436                         // somewhere else in the obligation chain. Do not suggest non-sense.
1437                         return false;
1438                     }
1439                     err.span_label(span, &format!(
1440                         "expected an implementor of trait `{}`",
1441                         obligation.parent_trait_ref.skip_binder(),
1442                     ));
1443                     err.span_suggestion(
1444                         span,
1445                         "consider borrowing here",
1446                         format!("&{}", snippet),
1447                         Applicability::MaybeIncorrect,
1448                     );
1449                     return true;
1450                 }
1451             }
1452         }
1453         false
1454     }
1455
1456     /// Whenever references are used by mistake, like `for (i, e) in &vec.iter().enumerate()`,
1457     /// suggest removing these references until we reach a type that implements the trait.
1458     fn suggest_remove_reference(
1459         &self,
1460         obligation: &PredicateObligation<'tcx>,
1461         err: &mut DiagnosticBuilder<'tcx>,
1462         trait_ref: &ty::Binder<ty::TraitRef<'tcx>>,
1463     ) {
1464         let trait_ref = trait_ref.skip_binder();
1465         let span = obligation.cause.span;
1466
1467         if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
1468             let refs_number = snippet.chars()
1469                 .filter(|c| !c.is_whitespace())
1470                 .take_while(|c| *c == '&')
1471                 .count();
1472             if let Some('\'') = snippet.chars()
1473                 .filter(|c| !c.is_whitespace())
1474                 .skip(refs_number)
1475                 .next()
1476             { // Do not suggest removal of borrow from type arguments.
1477                 return;
1478             }
1479
1480             let mut trait_type = trait_ref.self_ty();
1481
1482             for refs_remaining in 0..refs_number {
1483                 if let ty::Ref(_, t_type, _) = trait_type.kind {
1484                     trait_type = t_type;
1485
1486                     let new_obligation = self.mk_obligation_for_def_id(
1487                         trait_ref.def_id,
1488                         trait_type,
1489                         ObligationCause::dummy(),
1490                         obligation.param_env,
1491                     );
1492
1493                     if self.predicate_may_hold(&new_obligation) {
1494                         let sp = self.tcx.sess.source_map()
1495                             .span_take_while(span, |c| c.is_whitespace() || *c == '&');
1496
1497                         let remove_refs = refs_remaining + 1;
1498                         let format_str = format!("consider removing {} leading `&`-references",
1499                                                  remove_refs);
1500
1501                         err.span_suggestion_short(
1502                             sp, &format_str, String::new(), Applicability::MachineApplicable
1503                         );
1504                         break;
1505                     }
1506                 } else {
1507                     break;
1508                 }
1509             }
1510         }
1511     }
1512
1513     /// Check if the trait bound is implemented for a different mutability and note it in the
1514     /// final error.
1515     fn suggest_change_mut(
1516         &self,
1517         obligation: &PredicateObligation<'tcx>,
1518         err: &mut DiagnosticBuilder<'tcx>,
1519         trait_ref: &ty::Binder<ty::TraitRef<'tcx>>,
1520         points_at_arg: bool,
1521     ) {
1522         let span = obligation.cause.span;
1523         if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
1524             let refs_number = snippet.chars()
1525                 .filter(|c| !c.is_whitespace())
1526                 .take_while(|c| *c == '&')
1527                 .count();
1528             if let Some('\'') = snippet.chars()
1529                 .filter(|c| !c.is_whitespace())
1530                 .skip(refs_number)
1531                 .next()
1532             { // Do not suggest removal of borrow from type arguments.
1533                 return;
1534             }
1535             let trait_ref = self.resolve_vars_if_possible(trait_ref);
1536             if trait_ref.has_infer_types() {
1537                 // Do not ICE while trying to find if a reborrow would succeed on a trait with
1538                 // unresolved bindings.
1539                 return;
1540             }
1541
1542             if let ty::Ref(region, t_type, mutability) = trait_ref.skip_binder().self_ty().kind {
1543                 let trait_type = match mutability {
1544                     hir::Mutability::Mutable => self.tcx.mk_imm_ref(region, t_type),
1545                     hir::Mutability::Immutable => self.tcx.mk_mut_ref(region, t_type),
1546                 };
1547
1548                 let new_obligation = self.mk_obligation_for_def_id(
1549                     trait_ref.skip_binder().def_id,
1550                     trait_type,
1551                     ObligationCause::dummy(),
1552                     obligation.param_env,
1553                 );
1554
1555                 if self.evaluate_obligation_no_overflow(
1556                     &new_obligation,
1557                 ).must_apply_modulo_regions() {
1558                     let sp = self.tcx.sess.source_map()
1559                         .span_take_while(span, |c| c.is_whitespace() || *c == '&');
1560                     if points_at_arg &&
1561                         mutability == hir::Mutability::Immutable &&
1562                         refs_number > 0
1563                     {
1564                         err.span_suggestion(
1565                             sp,
1566                             "consider changing this borrow's mutability",
1567                             "&mut ".to_string(),
1568                             Applicability::MachineApplicable,
1569                         );
1570                     } else {
1571                         err.note(&format!(
1572                             "`{}` is implemented for `{:?}`, but not for `{:?}`",
1573                             trait_ref,
1574                             trait_type,
1575                             trait_ref.skip_binder().self_ty(),
1576                         ));
1577                     }
1578                 }
1579             }
1580         }
1581     }
1582
1583     fn suggest_semicolon_removal(
1584         &self,
1585         obligation: &PredicateObligation<'tcx>,
1586         err: &mut DiagnosticBuilder<'tcx>,
1587         span: Span,
1588         trait_ref: &ty::Binder<ty::TraitRef<'tcx>>,
1589     ) {
1590         let hir = self.tcx.hir();
1591         let parent_node = hir.get_parent_node(obligation.cause.body_id);
1592         let node = hir.find(parent_node);
1593         if let Some(hir::Node::Item(hir::Item {
1594             kind: hir::ItemKind::Fn(sig, _, body_id),
1595             ..
1596         })) = node {
1597             let body = hir.body(*body_id);
1598             if let hir::ExprKind::Block(blk, _) = &body.value.kind {
1599                 if sig.decl.output.span().overlaps(span) && blk.expr.is_none() &&
1600                     "()" == &trait_ref.self_ty().to_string()
1601                 {
1602                     // FIXME(estebank): When encountering a method with a trait
1603                     // bound not satisfied in the return type with a body that has
1604                     // no return, suggest removal of semicolon on last statement.
1605                     // Once that is added, close #54771.
1606                     if let Some(ref stmt) = blk.stmts.last() {
1607                         let sp = self.tcx.sess.source_map().end_point(stmt.span);
1608                         err.span_label(sp, "consider removing this semicolon");
1609                     }
1610                 }
1611             }
1612         }
1613     }
1614
1615     /// Given some node representing a fn-like thing in the HIR map,
1616     /// returns a span and `ArgKind` information that describes the
1617     /// arguments it expects. This can be supplied to
1618     /// `report_arg_count_mismatch`.
1619     pub fn get_fn_like_arguments(&self, node: Node<'_>) -> (Span, Vec<ArgKind>) {
1620         match node {
1621             Node::Expr(&hir::Expr {
1622                 kind: hir::ExprKind::Closure(_, ref _decl, id, span, _),
1623                 ..
1624             }) => {
1625                 (self.tcx.sess.source_map().def_span(span),
1626                  self.tcx.hir().body(id).params.iter()
1627                     .map(|arg| {
1628                         if let hir::Pat {
1629                             kind: hir::PatKind::Tuple(ref args, _),
1630                             span,
1631                             ..
1632                         } = *arg.pat {
1633                             ArgKind::Tuple(
1634                                 Some(span),
1635                                 args.iter().map(|pat| {
1636                                     let snippet = self.tcx.sess.source_map()
1637                                         .span_to_snippet(pat.span).unwrap();
1638                                     (snippet, "_".to_owned())
1639                                 }).collect::<Vec<_>>(),
1640                             )
1641                         } else {
1642                             let name = self.tcx.sess.source_map()
1643                                 .span_to_snippet(arg.pat.span).unwrap();
1644                             ArgKind::Arg(name, "_".to_owned())
1645                         }
1646                     })
1647                     .collect::<Vec<ArgKind>>())
1648             }
1649             Node::Item(&hir::Item {
1650                 span,
1651                 kind: hir::ItemKind::Fn(ref sig, ..),
1652                 ..
1653             }) |
1654             Node::ImplItem(&hir::ImplItem {
1655                 span,
1656                 kind: hir::ImplItemKind::Method(ref sig, _),
1657                 ..
1658             }) |
1659             Node::TraitItem(&hir::TraitItem {
1660                 span,
1661                 kind: hir::TraitItemKind::Method(ref sig, _),
1662                 ..
1663             }) => {
1664                 (self.tcx.sess.source_map().def_span(span), sig.decl.inputs.iter()
1665                         .map(|arg| match arg.clone().kind {
1666                     hir::TyKind::Tup(ref tys) => ArgKind::Tuple(
1667                         Some(arg.span),
1668                         vec![("_".to_owned(), "_".to_owned()); tys.len()]
1669                     ),
1670                     _ => ArgKind::empty()
1671                 }).collect::<Vec<ArgKind>>())
1672             }
1673             Node::Ctor(ref variant_data) => {
1674                 let span = variant_data.ctor_hir_id()
1675                     .map(|hir_id| self.tcx.hir().span(hir_id))
1676                     .unwrap_or(DUMMY_SP);
1677                 let span = self.tcx.sess.source_map().def_span(span);
1678
1679                 (span, vec![ArgKind::empty(); variant_data.fields().len()])
1680             }
1681             _ => panic!("non-FnLike node found: {:?}", node),
1682         }
1683     }
1684
1685     /// Reports an error when the number of arguments needed by a
1686     /// trait match doesn't match the number that the expression
1687     /// provides.
1688     pub fn report_arg_count_mismatch(
1689         &self,
1690         span: Span,
1691         found_span: Option<Span>,
1692         expected_args: Vec<ArgKind>,
1693         found_args: Vec<ArgKind>,
1694         is_closure: bool,
1695     ) -> DiagnosticBuilder<'tcx> {
1696         let kind = if is_closure { "closure" } else { "function" };
1697
1698         let args_str = |arguments: &[ArgKind], other: &[ArgKind]| {
1699             let arg_length = arguments.len();
1700             let distinct = match &other[..] {
1701                 &[ArgKind::Tuple(..)] => true,
1702                 _ => false,
1703             };
1704             match (arg_length, arguments.get(0)) {
1705                 (1, Some(&ArgKind::Tuple(_, ref fields))) => {
1706                     format!("a single {}-tuple as argument", fields.len())
1707                 }
1708                 _ => format!("{} {}argument{}",
1709                              arg_length,
1710                              if distinct && arg_length > 1 { "distinct " } else { "" },
1711                              pluralize!(arg_length))
1712             }
1713         };
1714
1715         let expected_str = args_str(&expected_args, &found_args);
1716         let found_str = args_str(&found_args, &expected_args);
1717
1718         let mut err = struct_span_err!(
1719             self.tcx.sess,
1720             span,
1721             E0593,
1722             "{} is expected to take {}, but it takes {}",
1723             kind,
1724             expected_str,
1725             found_str,
1726         );
1727
1728         err.span_label(span, format!("expected {} that takes {}", kind, expected_str));
1729
1730         if let Some(found_span) = found_span {
1731             err.span_label(found_span, format!("takes {}", found_str));
1732
1733             // move |_| { ... }
1734             // ^^^^^^^^-- def_span
1735             //
1736             // move |_| { ... }
1737             // ^^^^^-- prefix
1738             let prefix_span = self.tcx.sess.source_map().span_until_non_whitespace(found_span);
1739             // move |_| { ... }
1740             //      ^^^-- pipe_span
1741             let pipe_span = if let Some(span) = found_span.trim_start(prefix_span) {
1742                 span
1743             } else {
1744                 found_span
1745             };
1746
1747             // Suggest to take and ignore the arguments with expected_args_length `_`s if
1748             // found arguments is empty (assume the user just wants to ignore args in this case).
1749             // For example, if `expected_args_length` is 2, suggest `|_, _|`.
1750             if found_args.is_empty() && is_closure {
1751                 let underscores = vec!["_"; expected_args.len()].join(", ");
1752                 err.span_suggestion(
1753                     pipe_span,
1754                     &format!(
1755                         "consider changing the closure to take and ignore the expected argument{}",
1756                         if expected_args.len() < 2 {
1757                             ""
1758                         } else {
1759                             "s"
1760                         }
1761                     ),
1762                     format!("|{}|", underscores),
1763                     Applicability::MachineApplicable,
1764                 );
1765             }
1766
1767             if let &[ArgKind::Tuple(_, ref fields)] = &found_args[..] {
1768                 if fields.len() == expected_args.len() {
1769                     let sugg = fields.iter()
1770                         .map(|(name, _)| name.to_owned())
1771                         .collect::<Vec<String>>()
1772                         .join(", ");
1773                     err.span_suggestion(
1774                         found_span,
1775                         "change the closure to take multiple arguments instead of a single tuple",
1776                         format!("|{}|", sugg),
1777                         Applicability::MachineApplicable,
1778                     );
1779                 }
1780             }
1781             if let &[ArgKind::Tuple(_, ref fields)] = &expected_args[..] {
1782                 if fields.len() == found_args.len() && is_closure {
1783                     let sugg = format!(
1784                         "|({}){}|",
1785                         found_args.iter()
1786                             .map(|arg| match arg {
1787                                 ArgKind::Arg(name, _) => name.to_owned(),
1788                                 _ => "_".to_owned(),
1789                             })
1790                             .collect::<Vec<String>>()
1791                             .join(", "),
1792                         // add type annotations if available
1793                         if found_args.iter().any(|arg| match arg {
1794                             ArgKind::Arg(_, ty) => ty != "_",
1795                             _ => false,
1796                         }) {
1797                             format!(": ({})",
1798                                     fields.iter()
1799                                         .map(|(_, ty)| ty.to_owned())
1800                                         .collect::<Vec<String>>()
1801                                         .join(", "))
1802                         } else {
1803                             String::new()
1804                         },
1805                     );
1806                     err.span_suggestion(
1807                         found_span,
1808                         "change the closure to accept a tuple instead of individual arguments",
1809                         sugg,
1810                         Applicability::MachineApplicable,
1811                     );
1812                 }
1813             }
1814         }
1815
1816         err
1817     }
1818
1819     fn report_closure_arg_mismatch(
1820         &self,
1821         span: Span,
1822         found_span: Option<Span>,
1823         expected_ref: ty::PolyTraitRef<'tcx>,
1824         found: ty::PolyTraitRef<'tcx>,
1825     ) -> DiagnosticBuilder<'tcx> {
1826         fn build_fn_sig_string<'tcx>(tcx: TyCtxt<'tcx>, trait_ref: &ty::TraitRef<'tcx>) -> String {
1827             let inputs = trait_ref.substs.type_at(1);
1828             let sig = if let ty::Tuple(inputs) = inputs.kind {
1829                 tcx.mk_fn_sig(
1830                     inputs.iter().map(|k| k.expect_ty()),
1831                     tcx.mk_ty_infer(ty::TyVar(ty::TyVid { index: 0 })),
1832                     false,
1833                     hir::Unsafety::Normal,
1834                     ::rustc_target::spec::abi::Abi::Rust
1835                 )
1836             } else {
1837                 tcx.mk_fn_sig(
1838                     ::std::iter::once(inputs),
1839                     tcx.mk_ty_infer(ty::TyVar(ty::TyVid { index: 0 })),
1840                     false,
1841                     hir::Unsafety::Normal,
1842                     ::rustc_target::spec::abi::Abi::Rust
1843                 )
1844             };
1845             ty::Binder::bind(sig).to_string()
1846         }
1847
1848         let argument_is_closure = expected_ref.skip_binder().substs.type_at(0).is_closure();
1849         let mut err = struct_span_err!(self.tcx.sess, span, E0631,
1850                                        "type mismatch in {} arguments",
1851                                        if argument_is_closure { "closure" } else { "function" });
1852
1853         let found_str = format!(
1854             "expected signature of `{}`",
1855             build_fn_sig_string(self.tcx, found.skip_binder())
1856         );
1857         err.span_label(span, found_str);
1858
1859         let found_span = found_span.unwrap_or(span);
1860         let expected_str = format!(
1861             "found signature of `{}`",
1862             build_fn_sig_string(self.tcx, expected_ref.skip_binder())
1863         );
1864         err.span_label(found_span, expected_str);
1865
1866         err
1867     }
1868 }
1869
1870 impl<'tcx> TyCtxt<'tcx> {
1871     pub fn recursive_type_with_infinite_size_error(self,
1872                                                    type_def_id: DefId)
1873                                                    -> DiagnosticBuilder<'tcx>
1874     {
1875         assert!(type_def_id.is_local());
1876         let span = self.hir().span_if_local(type_def_id).unwrap();
1877         let span = self.sess.source_map().def_span(span);
1878         let mut err = struct_span_err!(self.sess, span, E0072,
1879                                        "recursive type `{}` has infinite size",
1880                                        self.def_path_str(type_def_id));
1881         err.span_label(span, "recursive type has infinite size");
1882         err.help(&format!("insert indirection (e.g., a `Box`, `Rc`, or `&`) \
1883                            at some point to make `{}` representable",
1884                           self.def_path_str(type_def_id)));
1885         err
1886     }
1887
1888     pub fn report_object_safety_error(
1889         self,
1890         span: Span,
1891         trait_def_id: DefId,
1892         violations: Vec<ObjectSafetyViolation>,
1893     ) -> DiagnosticBuilder<'tcx> {
1894         let trait_str = self.def_path_str(trait_def_id);
1895         let span = self.sess.source_map().def_span(span);
1896         let mut err = struct_span_err!(
1897             self.sess, span, E0038,
1898             "the trait `{}` cannot be made into an object",
1899             trait_str);
1900         err.span_label(span, format!("the trait `{}` cannot be made into an object", trait_str));
1901
1902         let mut reported_violations = FxHashSet::default();
1903         for violation in violations {
1904             if reported_violations.insert(violation.clone()) {
1905                 match violation.span() {
1906                     Some(span) => err.span_label(span, violation.error_msg()),
1907                     None => err.note(&violation.error_msg()),
1908                 };
1909             }
1910         }
1911
1912         if self.sess.trait_methods_not_found.borrow().contains(&span) {
1913             // Avoid emitting error caused by non-existing method (#58734)
1914             err.cancel();
1915         }
1916
1917         err
1918     }
1919 }
1920
1921 impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
1922     fn maybe_report_ambiguity(
1923         &self,
1924         obligation: &PredicateObligation<'tcx>,
1925         body_id: Option<hir::BodyId>,
1926     ) {
1927         // Unable to successfully determine, probably means
1928         // insufficient type information, but could mean
1929         // ambiguous impls. The latter *ought* to be a
1930         // coherence violation, so we don't report it here.
1931
1932         let predicate = self.resolve_vars_if_possible(&obligation.predicate);
1933         let span = obligation.cause.span;
1934
1935         debug!(
1936             "maybe_report_ambiguity(predicate={:?}, obligation={:?} body_id={:?}, code={:?})",
1937             predicate,
1938             obligation,
1939             body_id,
1940             obligation.cause.code,
1941         );
1942
1943         // Ambiguity errors are often caused as fallout from earlier
1944         // errors. So just ignore them if this infcx is tainted.
1945         if self.is_tainted_by_errors() {
1946             return;
1947         }
1948
1949         match predicate {
1950             ty::Predicate::Trait(ref data) => {
1951                 let trait_ref = data.to_poly_trait_ref();
1952                 let self_ty = trait_ref.self_ty();
1953                 debug!("self_ty {:?} {:?} trait_ref {:?}", self_ty, self_ty.kind, trait_ref);
1954
1955                 if predicate.references_error() {
1956                     return;
1957                 }
1958                 // Typically, this ambiguity should only happen if
1959                 // there are unresolved type inference variables
1960                 // (otherwise it would suggest a coherence
1961                 // failure). But given #21974 that is not necessarily
1962                 // the case -- we can have multiple where clauses that
1963                 // are only distinguished by a region, which results
1964                 // in an ambiguity even when all types are fully
1965                 // known, since we don't dispatch based on region
1966                 // relationships.
1967
1968                 // This is kind of a hack: it frequently happens that some earlier
1969                 // error prevents types from being fully inferred, and then we get
1970                 // a bunch of uninteresting errors saying something like "<generic
1971                 // #0> doesn't implement Sized".  It may even be true that we
1972                 // could just skip over all checks where the self-ty is an
1973                 // inference variable, but I was afraid that there might be an
1974                 // inference variable created, registered as an obligation, and
1975                 // then never forced by writeback, and hence by skipping here we'd
1976                 // be ignoring the fact that we don't KNOW the type works
1977                 // out. Though even that would probably be harmless, given that
1978                 // we're only talking about builtin traits, which are known to be
1979                 // inhabited. We used to check for `self.tcx.sess.has_errors()` to
1980                 // avoid inundating the user with unnecessary errors, but we now
1981                 // check upstream for type errors and dont add the obligations to
1982                 // begin with in those cases.
1983                 if
1984                     self.tcx.lang_items().sized_trait()
1985                     .map_or(false, |sized_id| sized_id == trait_ref.def_id())
1986                 {
1987                     self.need_type_info_err(body_id, span, self_ty).emit();
1988                 } else {
1989                     let mut err = struct_span_err!(
1990                         self.tcx.sess,
1991                         span,
1992                         E0283,
1993                         "type annotations needed: cannot resolve `{}`",
1994                         predicate,
1995                     );
1996                     self.note_obligation_cause(&mut err, obligation);
1997                     err.emit();
1998                 }
1999             }
2000
2001             ty::Predicate::WellFormed(ty) => {
2002                 // Same hacky approach as above to avoid deluging user
2003                 // with error messages.
2004                 if !ty.references_error() && !self.tcx.sess.has_errors() {
2005                     self.need_type_info_err(body_id, span, ty).emit();
2006                 }
2007             }
2008
2009             ty::Predicate::Subtype(ref data) => {
2010                 if data.references_error() || self.tcx.sess.has_errors() {
2011                     // no need to overload user in such cases
2012                 } else {
2013                     let &SubtypePredicate { a_is_expected: _, a, b } = data.skip_binder();
2014                     // both must be type variables, or the other would've been instantiated
2015                     assert!(a.is_ty_var() && b.is_ty_var());
2016                     self.need_type_info_err(body_id,
2017                                             obligation.cause.span,
2018                                             a).emit();
2019                 }
2020             }
2021
2022             _ => {
2023                 if !self.tcx.sess.has_errors() {
2024                     let mut err = struct_span_err!(
2025                         self.tcx.sess,
2026                         obligation.cause.span,
2027                         E0284,
2028                         "type annotations needed: cannot resolve `{}`",
2029                         predicate,
2030                     );
2031                     self.note_obligation_cause(&mut err, obligation);
2032                     err.emit();
2033                 }
2034             }
2035         }
2036     }
2037
2038     /// Returns `true` if the trait predicate may apply for *some* assignment
2039     /// to the type parameters.
2040     fn predicate_can_apply(
2041         &self,
2042         param_env: ty::ParamEnv<'tcx>,
2043         pred: ty::PolyTraitRef<'tcx>,
2044     ) -> bool {
2045         struct ParamToVarFolder<'a, 'tcx> {
2046             infcx: &'a InferCtxt<'a, 'tcx>,
2047             var_map: FxHashMap<Ty<'tcx>, Ty<'tcx>>,
2048         }
2049
2050         impl<'a, 'tcx> TypeFolder<'tcx> for ParamToVarFolder<'a, 'tcx> {
2051             fn tcx<'b>(&'b self) -> TyCtxt<'tcx> { self.infcx.tcx }
2052
2053             fn fold_ty(&mut self, ty: Ty<'tcx>) -> Ty<'tcx> {
2054                 if let ty::Param(ty::ParamTy {name, .. }) = ty.kind {
2055                     let infcx = self.infcx;
2056                     self.var_map.entry(ty).or_insert_with(||
2057                         infcx.next_ty_var(
2058                             TypeVariableOrigin {
2059                                 kind: TypeVariableOriginKind::TypeParameterDefinition(name),
2060                                 span: DUMMY_SP,
2061                             }
2062                         )
2063                     )
2064                 } else {
2065                     ty.super_fold_with(self)
2066                 }
2067             }
2068         }
2069
2070         self.probe(|_| {
2071             let mut selcx = SelectionContext::new(self);
2072
2073             let cleaned_pred = pred.fold_with(&mut ParamToVarFolder {
2074                 infcx: self,
2075                 var_map: Default::default()
2076             });
2077
2078             let cleaned_pred = super::project::normalize(
2079                 &mut selcx,
2080                 param_env,
2081                 ObligationCause::dummy(),
2082                 &cleaned_pred
2083             ).value;
2084
2085             let obligation = Obligation::new(
2086                 ObligationCause::dummy(),
2087                 param_env,
2088                 cleaned_pred.to_predicate()
2089             );
2090
2091             self.predicate_may_hold(&obligation)
2092         })
2093     }
2094
2095     fn note_obligation_cause(
2096         &self,
2097         err: &mut DiagnosticBuilder<'_>,
2098         obligation: &PredicateObligation<'tcx>,
2099     ) {
2100         // First, attempt to add note to this error with an async-await-specific
2101         // message, and fall back to regular note otherwise.
2102         if !self.note_obligation_cause_for_async_await(err, obligation) {
2103             self.note_obligation_cause_code(err, &obligation.predicate, &obligation.cause.code,
2104                                             &mut vec![]);
2105         }
2106     }
2107
2108     /// Adds an async-await specific note to the diagnostic:
2109     ///
2110     /// ```ignore (diagnostic)
2111     /// note: future does not implement `std::marker::Send` because this value is used across an
2112     ///       await
2113     ///   --> $DIR/issue-64130-non-send-future-diags.rs:15:5
2114     ///    |
2115     /// LL |     let g = x.lock().unwrap();
2116     ///    |         - has type `std::sync::MutexGuard<'_, u32>`
2117     /// LL |     baz().await;
2118     ///    |     ^^^^^^^^^^^ await occurs here, with `g` maybe used later
2119     /// LL | }
2120     ///    | - `g` is later dropped here
2121     /// ```
2122     ///
2123     /// Returns `true` if an async-await specific note was added to the diagnostic.
2124     fn note_obligation_cause_for_async_await(
2125         &self,
2126         err: &mut DiagnosticBuilder<'_>,
2127         obligation: &PredicateObligation<'tcx>,
2128     ) -> bool {
2129         debug!("note_obligation_cause_for_async_await: obligation.predicate={:?} \
2130                 obligation.cause.span={:?}", obligation.predicate, obligation.cause.span);
2131         let source_map = self.tcx.sess.source_map();
2132
2133         // Look into the obligation predicate to determine the type in the generator which meant
2134         // that the predicate was not satisifed.
2135         let (trait_ref, target_ty) = match obligation.predicate {
2136             ty::Predicate::Trait(trait_predicate) =>
2137                 (trait_predicate.skip_binder().trait_ref, trait_predicate.skip_binder().self_ty()),
2138             _ => return false,
2139         };
2140         debug!("note_obligation_cause_for_async_await: target_ty={:?}", target_ty);
2141
2142         // Attempt to detect an async-await error by looking at the obligation causes, looking
2143         // for only generators, generator witnesses, opaque types or `std::future::GenFuture` to
2144         // be present.
2145         //
2146         // When a future does not implement a trait because of a captured type in one of the
2147         // generators somewhere in the call stack, then the result is a chain of obligations.
2148         // Given a `async fn` A that calls a `async fn` B which captures a non-send type and that
2149         // future is passed as an argument to a function C which requires a `Send` type, then the
2150         // chain looks something like this:
2151         //
2152         // - `BuiltinDerivedObligation` with a generator witness (B)
2153         // - `BuiltinDerivedObligation` with a generator (B)
2154         // - `BuiltinDerivedObligation` with `std::future::GenFuture` (B)
2155         // - `BuiltinDerivedObligation` with `impl std::future::Future` (B)
2156         // - `BuiltinDerivedObligation` with `impl std::future::Future` (B)
2157         // - `BuiltinDerivedObligation` with a generator witness (A)
2158         // - `BuiltinDerivedObligation` with a generator (A)
2159         // - `BuiltinDerivedObligation` with `std::future::GenFuture` (A)
2160         // - `BuiltinDerivedObligation` with `impl std::future::Future` (A)
2161         // - `BuiltinDerivedObligation` with `impl std::future::Future` (A)
2162         // - `BindingObligation` with `impl_send (Send requirement)
2163         //
2164         // The first obligations in the chain can be used to get the details of the type that is
2165         // captured but the entire chain must be inspected to detect this case.
2166         let mut generator = None;
2167         let mut next_code = Some(&obligation.cause.code);
2168         while let Some(code) = next_code {
2169             debug!("note_obligation_cause_for_async_await: code={:?}", code);
2170             match code {
2171                 ObligationCauseCode::BuiltinDerivedObligation(derived_obligation) |
2172                 ObligationCauseCode::ImplDerivedObligation(derived_obligation) => {
2173                     debug!("note_obligation_cause_for_async_await: self_ty.kind={:?}",
2174                            derived_obligation.parent_trait_ref.self_ty().kind);
2175                     match derived_obligation.parent_trait_ref.self_ty().kind {
2176                         ty::Adt(ty::AdtDef { did, .. }, ..) if
2177                             self.tcx.is_diagnostic_item(sym::gen_future, *did) => {},
2178                         ty::Generator(did, ..) => generator = generator.or(Some(did)),
2179                         ty::GeneratorWitness(_) | ty::Opaque(..) => {},
2180                         _ => return false,
2181                     }
2182
2183                     next_code = Some(derived_obligation.parent_code.as_ref());
2184                 },
2185                 ObligationCauseCode::ItemObligation(_) | ObligationCauseCode::BindingObligation(..)
2186                     if generator.is_some() => break,
2187                 _ => return false,
2188             }
2189         }
2190
2191         let generator_did = generator.expect("can only reach this if there was a generator");
2192
2193         // Only continue to add a note if the generator is from an `async` function.
2194         let parent_node = self.tcx.parent(generator_did)
2195             .and_then(|parent_did| self.tcx.hir().get_if_local(parent_did));
2196         debug!("note_obligation_cause_for_async_await: parent_node={:?}", parent_node);
2197         if let Some(hir::Node::Item(hir::Item {
2198             kind: hir::ItemKind::Fn(sig, _, _),
2199             ..
2200         })) = parent_node {
2201             debug!("note_obligation_cause_for_async_await: header={:?}", sig.header);
2202             if sig.header.asyncness != hir::IsAsync::Async {
2203                 return false;
2204             }
2205         }
2206
2207         let span = self.tcx.def_span(generator_did);
2208         let tables = self.tcx.typeck_tables_of(generator_did);
2209         debug!("note_obligation_cause_for_async_await: generator_did={:?} span={:?} ",
2210                generator_did, span);
2211
2212         // Look for a type inside the generator interior that matches the target type to get
2213         // a span.
2214         let target_span = tables.generator_interior_types.iter()
2215             .find(|ty::GeneratorInteriorTypeCause { ty, .. }| ty::TyS::same_type(*ty, target_ty))
2216             .map(|ty::GeneratorInteriorTypeCause { span, scope_span, .. }|
2217                  (span, source_map.span_to_snippet(*span), scope_span));
2218         if let Some((target_span, Ok(snippet), scope_span)) = target_span {
2219             // Look at the last interior type to get a span for the `.await`.
2220             let await_span = tables.generator_interior_types.iter().map(|i| i.span).last().unwrap();
2221             let mut span = MultiSpan::from_span(await_span);
2222             span.push_span_label(
2223                 await_span, format!("await occurs here, with `{}` maybe used later", snippet));
2224
2225             span.push_span_label(*target_span, format!("has type `{}`", target_ty));
2226
2227             // If available, use the scope span to annotate the drop location.
2228             if let Some(scope_span) = scope_span {
2229                 span.push_span_label(
2230                     source_map.end_point(*scope_span),
2231                     format!("`{}` is later dropped here", snippet),
2232                 );
2233             }
2234
2235             err.span_note(span, &format!(
2236                 "future does not implement `{}` as this value is used across an await",
2237                 trait_ref,
2238             ));
2239
2240             // Add a note for the item obligation that remains - normally a note pointing to the
2241             // bound that introduced the obligation (e.g. `T: Send`).
2242             debug!("note_obligation_cause_for_async_await: next_code={:?}", next_code);
2243             self.note_obligation_cause_code(
2244                 err,
2245                 &obligation.predicate,
2246                 next_code.unwrap(),
2247                 &mut Vec::new(),
2248             );
2249
2250             true
2251         } else {
2252             false
2253         }
2254     }
2255
2256     fn note_obligation_cause_code<T>(&self,
2257                                      err: &mut DiagnosticBuilder<'_>,
2258                                      predicate: &T,
2259                                      cause_code: &ObligationCauseCode<'tcx>,
2260                                      obligated_types: &mut Vec<&ty::TyS<'tcx>>)
2261         where T: fmt::Display
2262     {
2263         let tcx = self.tcx;
2264         match *cause_code {
2265             ObligationCauseCode::ExprAssignable |
2266             ObligationCauseCode::MatchExpressionArm { .. } |
2267             ObligationCauseCode::MatchExpressionArmPattern { .. } |
2268             ObligationCauseCode::IfExpression { .. } |
2269             ObligationCauseCode::IfExpressionWithNoElse |
2270             ObligationCauseCode::MainFunctionType |
2271             ObligationCauseCode::StartFunctionType |
2272             ObligationCauseCode::IntrinsicType |
2273             ObligationCauseCode::MethodReceiver |
2274             ObligationCauseCode::ReturnNoExpression |
2275             ObligationCauseCode::MiscObligation => {}
2276             ObligationCauseCode::SliceOrArrayElem => {
2277                 err.note("slice and array elements must have `Sized` type");
2278             }
2279             ObligationCauseCode::TupleElem => {
2280                 err.note("only the last element of a tuple may have a dynamically sized type");
2281             }
2282             ObligationCauseCode::ProjectionWf(data) => {
2283                 err.note(&format!(
2284                     "required so that the projection `{}` is well-formed",
2285                     data,
2286                 ));
2287             }
2288             ObligationCauseCode::ReferenceOutlivesReferent(ref_ty) => {
2289                 err.note(&format!(
2290                     "required so that reference `{}` does not outlive its referent",
2291                     ref_ty,
2292                 ));
2293             }
2294             ObligationCauseCode::ObjectTypeBound(object_ty, region) => {
2295                 err.note(&format!(
2296                     "required so that the lifetime bound of `{}` for `{}` is satisfied",
2297                     region,
2298                     object_ty,
2299                 ));
2300             }
2301             ObligationCauseCode::ItemObligation(item_def_id) => {
2302                 let item_name = tcx.def_path_str(item_def_id);
2303                 let msg = format!("required by `{}`", item_name);
2304
2305                 if let Some(sp) = tcx.hir().span_if_local(item_def_id) {
2306                     let sp = tcx.sess.source_map().def_span(sp);
2307                     err.span_label(sp, &msg);
2308                 } else {
2309                     err.note(&msg);
2310                 }
2311             }
2312             ObligationCauseCode::BindingObligation(item_def_id, span) => {
2313                 let item_name = tcx.def_path_str(item_def_id);
2314                 let msg = format!("required by this bound in `{}`", item_name);
2315                 if let Some(ident) = tcx.opt_item_name(item_def_id) {
2316                     err.span_label(ident.span, "");
2317                 }
2318                 if span != DUMMY_SP {
2319                     err.span_label(span, &msg);
2320                 } else {
2321                     err.note(&msg);
2322                 }
2323             }
2324             ObligationCauseCode::ObjectCastObligation(object_ty) => {
2325                 err.note(&format!("required for the cast to the object type `{}`",
2326                                   self.ty_to_string(object_ty)));
2327             }
2328             ObligationCauseCode::Coercion { source: _, target } => {
2329                 err.note(&format!("required by cast to type `{}`",
2330                                   self.ty_to_string(target)));
2331             }
2332             ObligationCauseCode::RepeatVec(suggest_const_in_array_repeat_expressions) => {
2333                 err.note("the `Copy` trait is required because the \
2334                           repeated element will be copied");
2335                 if suggest_const_in_array_repeat_expressions {
2336                     err.note("this array initializer can be evaluated at compile-time, for more \
2337                               information, see issue \
2338                               https://github.com/rust-lang/rust/issues/49147");
2339                     if tcx.sess.opts.unstable_features.is_nightly_build() {
2340                         err.help("add `#![feature(const_in_array_repeat_expressions)]` to the \
2341                                   crate attributes to enable");
2342                     }
2343                 }
2344             }
2345             ObligationCauseCode::VariableType(_) => {
2346                 err.note("all local variables must have a statically known size");
2347                 if !self.tcx.features().unsized_locals {
2348                     err.help("unsized locals are gated as an unstable feature");
2349                 }
2350             }
2351             ObligationCauseCode::SizedArgumentType => {
2352                 err.note("all function arguments must have a statically known size");
2353                 if !self.tcx.features().unsized_locals {
2354                     err.help("unsized locals are gated as an unstable feature");
2355                 }
2356             }
2357             ObligationCauseCode::SizedReturnType => {
2358                 err.note("the return type of a function must have a \
2359                           statically known size");
2360             }
2361             ObligationCauseCode::SizedYieldType => {
2362                 err.note("the yield type of a generator must have a \
2363                           statically known size");
2364             }
2365             ObligationCauseCode::AssignmentLhsSized => {
2366                 err.note("the left-hand-side of an assignment must have a statically known size");
2367             }
2368             ObligationCauseCode::TupleInitializerSized => {
2369                 err.note("tuples must have a statically known size to be initialized");
2370             }
2371             ObligationCauseCode::StructInitializerSized => {
2372                 err.note("structs must have a statically known size to be initialized");
2373             }
2374             ObligationCauseCode::FieldSized { adt_kind: ref item, last } => {
2375                 match *item {
2376                     AdtKind::Struct => {
2377                         if last {
2378                             err.note("the last field of a packed struct may only have a \
2379                                       dynamically sized type if it does not need drop to be run");
2380                         } else {
2381                             err.note("only the last field of a struct may have a dynamically \
2382                                       sized type");
2383                         }
2384                     }
2385                     AdtKind::Union => {
2386                         err.note("no field of a union may have a dynamically sized type");
2387                     }
2388                     AdtKind::Enum => {
2389                         err.note("no field of an enum variant may have a dynamically sized type");
2390                     }
2391                 }
2392             }
2393             ObligationCauseCode::ConstSized => {
2394                 err.note("constant expressions must have a statically known size");
2395             }
2396             ObligationCauseCode::ConstPatternStructural => {
2397                 err.note("constants used for pattern-matching must derive `PartialEq` and `Eq`");
2398             }
2399             ObligationCauseCode::SharedStatic => {
2400                 err.note("shared static variables must have a type that implements `Sync`");
2401             }
2402             ObligationCauseCode::BuiltinDerivedObligation(ref data) => {
2403                 let parent_trait_ref = self.resolve_vars_if_possible(&data.parent_trait_ref);
2404                 let ty = parent_trait_ref.skip_binder().self_ty();
2405                 err.note(&format!("required because it appears within the type `{}`", ty));
2406                 obligated_types.push(ty);
2407
2408                 let parent_predicate = parent_trait_ref.to_predicate();
2409                 if !self.is_recursive_obligation(obligated_types, &data.parent_code) {
2410                     self.note_obligation_cause_code(err,
2411                                                     &parent_predicate,
2412                                                     &data.parent_code,
2413                                                     obligated_types);
2414                 }
2415             }
2416             ObligationCauseCode::ImplDerivedObligation(ref data) => {
2417                 let parent_trait_ref = self.resolve_vars_if_possible(&data.parent_trait_ref);
2418                 err.note(
2419                     &format!("required because of the requirements on the impl of `{}` for `{}`",
2420                              parent_trait_ref,
2421                              parent_trait_ref.skip_binder().self_ty()));
2422                 let parent_predicate = parent_trait_ref.to_predicate();
2423                 self.note_obligation_cause_code(err,
2424                                                 &parent_predicate,
2425                                                 &data.parent_code,
2426                                                 obligated_types);
2427             }
2428             ObligationCauseCode::CompareImplMethodObligation { .. } => {
2429                 err.note(
2430                     &format!("the requirement `{}` appears on the impl method \
2431                               but not on the corresponding trait method",
2432                              predicate));
2433             }
2434             ObligationCauseCode::ReturnType |
2435             ObligationCauseCode::ReturnValue(_) |
2436             ObligationCauseCode::BlockTailExpression(_) => (),
2437             ObligationCauseCode::TrivialBound => {
2438                 err.help("see issue #48214");
2439                 if tcx.sess.opts.unstable_features.is_nightly_build() {
2440                     err.help("add `#![feature(trivial_bounds)]` to the \
2441                               crate attributes to enable",
2442                     );
2443                 }
2444             }
2445             ObligationCauseCode::AssocTypeBound(ref data) => {
2446                 err.span_label(data.original, "associated type defined here");
2447                 if let Some(sp) = data.impl_span {
2448                     err.span_label(sp, "in this `impl` item");
2449                 }
2450                 for sp in &data.bounds {
2451                     err.span_label(*sp, "restricted in this bound");
2452                 }
2453             }
2454         }
2455     }
2456
2457     fn suggest_new_overflow_limit(&self, err: &mut DiagnosticBuilder<'_>) {
2458         let current_limit = self.tcx.sess.recursion_limit.get();
2459         let suggested_limit = current_limit * 2;
2460         err.help(&format!("consider adding a `#![recursion_limit=\"{}\"]` attribute to your crate",
2461                           suggested_limit));
2462     }
2463
2464     fn is_recursive_obligation(&self,
2465                                obligated_types: &mut Vec<&ty::TyS<'tcx>>,
2466                                cause_code: &ObligationCauseCode<'tcx>) -> bool {
2467         if let ObligationCauseCode::BuiltinDerivedObligation(ref data) = cause_code {
2468             let parent_trait_ref = self.resolve_vars_if_possible(&data.parent_trait_ref);
2469
2470             if obligated_types.iter().any(|ot| ot == &parent_trait_ref.skip_binder().self_ty()) {
2471                 return true;
2472             }
2473         }
2474         false
2475     }
2476 }
2477
2478 /// Summarizes information
2479 #[derive(Clone)]
2480 pub enum ArgKind {
2481     /// An argument of non-tuple type. Parameters are (name, ty)
2482     Arg(String, String),
2483
2484     /// An argument of tuple type. For a "found" argument, the span is
2485     /// the locationo in the source of the pattern. For a "expected"
2486     /// argument, it will be None. The vector is a list of (name, ty)
2487     /// strings for the components of the tuple.
2488     Tuple(Option<Span>, Vec<(String, String)>),
2489 }
2490
2491 impl ArgKind {
2492     fn empty() -> ArgKind {
2493         ArgKind::Arg("_".to_owned(), "_".to_owned())
2494     }
2495
2496     /// Creates an `ArgKind` from the expected type of an
2497     /// argument. It has no name (`_`) and an optional source span.
2498     pub fn from_expected_ty(t: Ty<'_>, span: Option<Span>) -> ArgKind {
2499         match t.kind {
2500             ty::Tuple(ref tys) => ArgKind::Tuple(
2501                 span,
2502                 tys.iter()
2503                    .map(|ty| ("_".to_owned(), ty.to_string()))
2504                    .collect::<Vec<_>>()
2505             ),
2506             _ => ArgKind::Arg("_".to_owned(), t.to_string()),
2507         }
2508     }
2509 }