1 //! See Rustc Guide chapters on [trait-resolution] and [trait-specialization] for more info on how
4 //! [trait-resolution]: https://rust-lang.github.io/rustc-guide/traits/resolution.html
5 //! [trait-specialization]: https://rust-lang.github.io/rustc-guide/traits/specialization.html
7 use crate::infer::{CombinedSnapshot, InferOk};
8 use crate::hir::def_id::{DefId, LOCAL_CRATE};
9 use crate::traits::{self, Normalized, SelectionContext, Obligation, ObligationCause};
10 use crate::traits::IntercrateMode;
11 use crate::traits::select::IntercrateAmbiguityCause;
12 use crate::ty::{self, Ty, TyCtxt};
13 use crate::ty::fold::TypeFoldable;
14 use crate::ty::subst::Subst;
15 use syntax::symbol::sym;
16 use syntax_pos::DUMMY_SP;
18 /// Whether we do the orphan check relative to this crate or
19 /// to some remote crate.
20 #[derive(Copy, Clone, Debug)]
26 #[derive(Debug, Copy, Clone)]
29 Downstream { used_to_be_broken: bool }
32 pub struct OverlapResult<'tcx> {
33 pub impl_header: ty::ImplHeader<'tcx>,
34 pub intercrate_ambiguity_causes: Vec<IntercrateAmbiguityCause>,
36 /// `true` if the overlap might've been permitted before the shift
38 pub involves_placeholder: bool,
41 pub fn add_placeholder_note(err: &mut errors::DiagnosticBuilder<'_>) {
43 "this behavior recently changed as a result of a bug fix; \
44 see rust-lang/rust#56105 for details"
48 /// If there are types that satisfy both impls, invokes `on_overlap`
49 /// with a suitably-freshened `ImplHeader` with those types
50 /// substituted. Otherwise, invokes `no_overlap`.
51 pub fn overlapping_impls<F1, F2, R>(
55 intercrate_mode: IntercrateMode,
60 F1: FnOnce(OverlapResult<'_>) -> R,
63 debug!("overlapping_impls(\
66 intercrate_mode={:?})",
71 let overlaps = tcx.infer_ctxt().enter(|infcx| {
72 let selcx = &mut SelectionContext::intercrate(&infcx, intercrate_mode);
73 overlap(selcx, impl1_def_id, impl2_def_id).is_some()
80 // In the case where we detect an error, run the check again, but
81 // this time tracking intercrate ambuiguity causes for better
82 // diagnostics. (These take time and can lead to false errors.)
83 tcx.infer_ctxt().enter(|infcx| {
84 let selcx = &mut SelectionContext::intercrate(&infcx, intercrate_mode);
85 selcx.enable_tracking_intercrate_ambiguity_causes();
86 on_overlap(overlap(selcx, impl1_def_id, impl2_def_id).unwrap())
90 fn with_fresh_ty_vars<'cx, 'tcx>(
91 selcx: &mut SelectionContext<'cx, 'tcx>,
92 param_env: ty::ParamEnv<'tcx>,
94 ) -> ty::ImplHeader<'tcx> {
95 let tcx = selcx.tcx();
96 let impl_substs = selcx.infcx().fresh_substs_for_item(DUMMY_SP, impl_def_id);
98 let header = ty::ImplHeader {
100 self_ty: tcx.type_of(impl_def_id).subst(tcx, impl_substs),
101 trait_ref: tcx.impl_trait_ref(impl_def_id).subst(tcx, impl_substs),
102 predicates: tcx.predicates_of(impl_def_id).instantiate(tcx, impl_substs).predicates,
105 let Normalized { value: mut header, obligations } =
106 traits::normalize(selcx, param_env, ObligationCause::dummy(), &header);
108 header.predicates.extend(obligations.into_iter().map(|o| o.predicate));
112 /// Can both impl `a` and impl `b` be satisfied by a common type (including
113 /// where-clauses)? If so, returns an `ImplHeader` that unifies the two impls.
114 fn overlap<'cx, 'tcx>(
115 selcx: &mut SelectionContext<'cx, 'tcx>,
118 ) -> Option<OverlapResult<'tcx>> {
119 debug!("overlap(a_def_id={:?}, b_def_id={:?})", a_def_id, b_def_id);
121 selcx.infcx().probe(|snapshot| overlap_within_probe(selcx, a_def_id, b_def_id, snapshot))
124 fn overlap_within_probe(
125 selcx: &mut SelectionContext<'cx, 'tcx>,
128 snapshot: &CombinedSnapshot<'_, 'tcx>,
129 ) -> Option<OverlapResult<'tcx>> {
130 // For the purposes of this check, we don't bring any placeholder
131 // types into scope; instead, we replace the generic types with
132 // fresh type variables, and hence we do our evaluations in an
133 // empty environment.
134 let param_env = ty::ParamEnv::empty();
136 let a_impl_header = with_fresh_ty_vars(selcx, param_env, a_def_id);
137 let b_impl_header = with_fresh_ty_vars(selcx, param_env, b_def_id);
139 debug!("overlap: a_impl_header={:?}", a_impl_header);
140 debug!("overlap: b_impl_header={:?}", b_impl_header);
142 // Do `a` and `b` unify? If not, no overlap.
143 let obligations = match selcx.infcx().at(&ObligationCause::dummy(), param_env)
144 .eq_impl_headers(&a_impl_header, &b_impl_header)
146 Ok(InferOk { obligations, value: () }) => obligations,
147 Err(_) => return None
150 debug!("overlap: unification check succeeded");
152 // Are any of the obligations unsatisfiable? If so, no overlap.
153 let infcx = selcx.infcx();
154 let opt_failing_obligation =
155 a_impl_header.predicates
157 .chain(&b_impl_header.predicates)
158 .map(|p| infcx.resolve_vars_if_possible(p))
159 .map(|p| Obligation { cause: ObligationCause::dummy(),
164 .find(|o| !selcx.predicate_may_hold_fatal(o));
165 // FIXME: the call to `selcx.predicate_may_hold_fatal` above should be ported
166 // to the canonical trait query form, `infcx.predicate_may_hold`, once
167 // the new system supports intercrate mode (which coherence needs).
169 if let Some(failing_obligation) = opt_failing_obligation {
170 debug!("overlap: obligation unsatisfiable {:?}", failing_obligation);
174 let impl_header = selcx.infcx().resolve_vars_if_possible(&a_impl_header);
175 let intercrate_ambiguity_causes = selcx.take_intercrate_ambiguity_causes();
176 debug!("overlap: intercrate_ambiguity_causes={:#?}", intercrate_ambiguity_causes);
178 let involves_placeholder = match selcx.infcx().region_constraints_added_in_snapshot(snapshot) {
183 Some(OverlapResult { impl_header, intercrate_ambiguity_causes, involves_placeholder })
186 pub fn trait_ref_is_knowable<'tcx>(
188 trait_ref: ty::TraitRef<'tcx>,
189 ) -> Option<Conflict> {
190 debug!("trait_ref_is_knowable(trait_ref={:?})", trait_ref);
191 if orphan_check_trait_ref(tcx, trait_ref, InCrate::Remote).is_ok() {
192 // A downstream or cousin crate is allowed to implement some
193 // substitution of this trait-ref.
195 // A trait can be implementable for a trait ref by both the current
196 // crate and crates downstream of it. Older versions of rustc
197 // were not aware of this, causing incoherence (issue #43355).
198 let used_to_be_broken =
199 orphan_check_trait_ref(tcx, trait_ref, InCrate::Local).is_ok();
200 if used_to_be_broken {
201 debug!("trait_ref_is_knowable({:?}) - USED TO BE BROKEN", trait_ref);
203 return Some(Conflict::Downstream { used_to_be_broken });
206 if trait_ref_is_local_or_fundamental(tcx, trait_ref) {
207 // This is a local or fundamental trait, so future-compatibility
208 // is no concern. We know that downstream/cousin crates are not
209 // allowed to implement a substitution of this trait ref, which
210 // means impls could only come from dependencies of this crate,
211 // which we already know about.
215 // This is a remote non-fundamental trait, so if another crate
216 // can be the "final owner" of a substitution of this trait-ref,
217 // they are allowed to implement it future-compatibly.
219 // However, if we are a final owner, then nobody else can be,
220 // and if we are an intermediate owner, then we don't care
221 // about future-compatibility, which means that we're OK if
223 if orphan_check_trait_ref(tcx, trait_ref, InCrate::Local).is_ok() {
224 debug!("trait_ref_is_knowable: orphan check passed");
227 debug!("trait_ref_is_knowable: nonlocal, nonfundamental, unowned");
228 return Some(Conflict::Upstream);
232 pub fn trait_ref_is_local_or_fundamental<'tcx>(
234 trait_ref: ty::TraitRef<'tcx>,
236 trait_ref.def_id.krate == LOCAL_CRATE || tcx.has_attr(trait_ref.def_id, sym::fundamental)
239 pub enum OrphanCheckErr<'tcx> {
240 NonLocalInputType(Vec<(Ty<'tcx>, bool /* Is this the first input type? */)>),
241 UncoveredTy(Ty<'tcx>, Option<Ty<'tcx>>),
244 /// Checks the coherence orphan rules. `impl_def_id` should be the
245 /// `DefId` of a trait impl. To pass, either the trait must be local, or else
246 /// two conditions must be satisfied:
248 /// 1. All type parameters in `Self` must be "covered" by some local type constructor.
249 /// 2. Some local type must appear in `Self`.
253 ) -> Result<(), OrphanCheckErr<'_>> {
254 debug!("orphan_check({:?})", impl_def_id);
256 // We only except this routine to be invoked on implementations
257 // of a trait, not inherent implementations.
258 let trait_ref = tcx.impl_trait_ref(impl_def_id).unwrap();
259 debug!("orphan_check: trait_ref={:?}", trait_ref);
261 // If the *trait* is local to the crate, ok.
262 if trait_ref.def_id.is_local() {
263 debug!("trait {:?} is local to current crate",
268 orphan_check_trait_ref(tcx, trait_ref, InCrate::Local)
271 /// Checks whether a trait-ref is potentially implementable by a crate.
273 /// The current rule is that a trait-ref orphan checks in a crate C:
275 /// 1. Order the parameters in the trait-ref in subst order - Self first,
276 /// others linearly (e.g., `<U as Foo<V, W>>` is U < V < W).
277 /// 2. Of these type parameters, there is at least one type parameter
278 /// in which, walking the type as a tree, you can reach a type local
279 /// to C where all types in-between are fundamental types. Call the
280 /// first such parameter the "local key parameter".
281 /// - e.g., `Box<LocalType>` is OK, because you can visit LocalType
282 /// going through `Box`, which is fundamental.
283 /// - similarly, `FundamentalPair<Vec<()>, Box<LocalType>>` is OK for
285 /// - but (knowing that `Vec<T>` is non-fundamental, and assuming it's
286 /// not local), `Vec<LocalType>` is bad, because `Vec<->` is between
287 /// the local type and the type parameter.
288 /// 3. Every type parameter before the local key parameter is fully known in C.
289 /// - e.g., `impl<T> T: Trait<LocalType>` is bad, because `T` might be
291 /// - but `impl<T> LocalType: Trait<T>` is OK, because `LocalType`
292 /// occurs before `T`.
293 /// 4. Every type in the local key parameter not known in C, going
294 /// through the parameter's type tree, must appear only as a subtree of
295 /// a type local to C, with only fundamental types between the type
296 /// local to C and the local key parameter.
297 /// - e.g., `Vec<LocalType<T>>>` (or equivalently `Box<Vec<LocalType<T>>>`)
298 /// is bad, because the only local type with `T` as a subtree is
299 /// `LocalType<T>`, and `Vec<->` is between it and the type parameter.
300 /// - similarly, `FundamentalPair<LocalType<T>, T>` is bad, because
301 /// the second occurrence of `T` is not a subtree of *any* local type.
302 /// - however, `LocalType<Vec<T>>` is OK, because `T` is a subtree of
303 /// `LocalType<Vec<T>>`, which is local and has no types between it and
304 /// the type parameter.
306 /// The orphan rules actually serve several different purposes:
308 /// 1. They enable link-safety - i.e., 2 mutually-unknowing crates (where
309 /// every type local to one crate is unknown in the other) can't implement
310 /// the same trait-ref. This follows because it can be seen that no such
311 /// type can orphan-check in 2 such crates.
313 /// To check that a local impl follows the orphan rules, we check it in
314 /// InCrate::Local mode, using type parameters for the "generic" types.
316 /// 2. They ground negative reasoning for coherence. If a user wants to
317 /// write both a conditional blanket impl and a specific impl, we need to
318 /// make sure they do not overlap. For example, if we write
320 /// impl<T> IntoIterator for Vec<T>
321 /// impl<T: Iterator> IntoIterator for T
323 /// We need to be able to prove that `Vec<$0>: !Iterator` for every type $0.
324 /// We can observe that this holds in the current crate, but we need to make
325 /// sure this will also hold in all unknown crates (both "independent" crates,
326 /// which we need for link-safety, and also child crates, because we don't want
327 /// child crates to get error for impl conflicts in a *dependency*).
329 /// For that, we only allow negative reasoning if, for every assignment to the
330 /// inference variables, every unknown crate would get an orphan error if they
331 /// try to implement this trait-ref. To check for this, we use InCrate::Remote
332 /// mode. That is sound because we already know all the impls from known crates.
334 /// 3. For non-#[fundamental] traits, they guarantee that parent crates can
335 /// add "non-blanket" impls without breaking negative reasoning in dependent
336 /// crates. This is the "rebalancing coherence" (RFC 1023) restriction.
338 /// For that, we only a allow crate to perform negative reasoning on
339 /// non-local-non-#[fundamental] only if there's a local key parameter as per (2).
341 /// Because we never perform negative reasoning generically (coherence does
342 /// not involve type parameters), this can be interpreted as doing the full
343 /// orphan check (using InCrate::Local mode), substituting non-local known
344 /// types for all inference variables.
346 /// This allows for crates to future-compatibly add impls as long as they
347 /// can't apply to types with a key parameter in a child crate - applying
348 /// the rules, this basically means that every type parameter in the impl
349 /// must appear behind a non-fundamental type (because this is not a
350 /// type-system requirement, crate owners might also go for "semantic
351 /// future-compatibility" involving things such as sealed traits, but
352 /// the above requirement is sufficient, and is necessary in "open world"
355 /// Note that this function is never called for types that have both type
356 /// parameters and inference variables.
357 fn orphan_check_trait_ref<'tcx>(
359 trait_ref: ty::TraitRef<'tcx>,
361 ) -> Result<(), OrphanCheckErr<'tcx>> {
362 debug!("orphan_check_trait_ref(trait_ref={:?}, in_crate={:?})",
363 trait_ref, in_crate);
365 if trait_ref.needs_infer() && trait_ref.needs_subst() {
366 bug!("can't orphan check a trait ref with both params and inference variables {:?}",
370 // Given impl<P1..=Pn> Trait<T1..=Tn> for T0, an impl is valid only
371 // if at least one of the following is true:
373 // - Trait is a local trait
374 // (already checked in orphan_check prior to calling this function)
376 // - At least one of the types T0..=Tn must be a local type.
377 // Let Ti be the first such type.
378 // - No uncovered type parameters P1..=Pn may appear in T0..Ti (excluding Ti)
380 fn uncover_fundamental_ty<'tcx>(
385 if fundamental_ty(ty) && ty_is_non_local(tcx, ty, in_crate).is_some() {
386 ty.walk_shallow().flat_map(|ty| uncover_fundamental_ty(tcx, ty, in_crate)).collect()
392 let mut non_local_spans = vec![];
393 for (i, input_ty) in trait_ref
395 .flat_map(|ty| uncover_fundamental_ty(tcx, ty, in_crate))
398 debug!("orphan_check_trait_ref: check ty `{:?}`", input_ty);
399 let non_local_tys = ty_is_non_local(tcx, input_ty, in_crate);
400 if non_local_tys.is_none() {
401 debug!("orphan_check_trait_ref: ty_is_local `{:?}`", input_ty);
403 } else if let ty::Param(_) = input_ty.kind {
404 debug!("orphan_check_trait_ref: uncovered ty: `{:?}`", input_ty);
405 let local_type = trait_ref
407 .flat_map(|ty| uncover_fundamental_ty(tcx, ty, in_crate))
408 .filter(|ty| ty_is_non_local_constructor(tcx, ty, in_crate).is_none())
411 debug!("orphan_check_trait_ref: uncovered ty local_type: `{:?}`", local_type);
413 return Err(OrphanCheckErr::UncoveredTy(input_ty, local_type))
415 if let Some(non_local_tys) = non_local_tys {
416 for input_ty in non_local_tys {
417 non_local_spans.push((input_ty, i == 0));
421 // If we exit above loop, never found a local type.
422 debug!("orphan_check_trait_ref: no local type");
423 Err(OrphanCheckErr::NonLocalInputType(non_local_spans))
426 fn ty_is_non_local<'t>(tcx: TyCtxt<'t>, ty: Ty<'t>, in_crate: InCrate) -> Option<Vec<Ty<'t>>> {
427 match ty_is_non_local_constructor(tcx, ty, in_crate) {
428 Some(ty) => if !fundamental_ty(ty) {
431 let tys: Vec<_> = ty.walk_shallow()
432 .filter_map(|t| ty_is_non_local(tcx, t, in_crate))
445 fn fundamental_ty(ty: Ty<'_>) -> bool {
448 ty::Adt(def, _) => def.is_fundamental(),
453 fn def_id_is_local(def_id: DefId, in_crate: InCrate) -> bool {
455 // The type is local to *this* crate - it will not be
456 // local in any other crate.
457 InCrate::Remote => false,
458 InCrate::Local => def_id.is_local()
462 fn ty_is_non_local_constructor<'tcx>(
466 ) -> Option<Ty<'tcx>> {
467 debug!("ty_is_non_local_constructor({:?})", ty);
485 ty::Projection(..) => {
489 ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) => match in_crate {
490 InCrate::Local => Some(ty),
491 // The inference variable might be unified with a local
492 // type in that remote crate.
493 InCrate::Remote => None,
496 ty::Adt(def, _) => if def_id_is_local(def.did, in_crate) {
501 ty::Foreign(did) => if def_id_is_local(did, in_crate) {
506 ty::Opaque(did, _) => {
507 // Check the underlying type that this opaque
509 // This recursion will eventually terminate,
510 // since we've already managed to successfully
511 // resolve all opaque types by this point
512 let real_ty = tcx.type_of(did);
513 ty_is_non_local_constructor(tcx, real_ty, in_crate)
516 ty::Dynamic(ref tt, ..) => {
517 if let Some(principal) = tt.principal() {
518 if def_id_is_local(principal.def_id(), in_crate) {
530 ty::UnnormalizedProjection(..) |
533 ty::GeneratorWitness(..) => {
534 bug!("ty_is_local invoked on unexpected type: {:?}", ty)