src/librustc/middle/resolve_lifetime.rs

   1 //! Name resolution for lifetimes.
   2 //!
   3 //! Name resolution for lifetimes follows *much* simpler rules than the
   4 //! full resolve. For example, lifetime names are never exported or
   5 //! used between functions, and they operate in a purely top-down
   6 //! way. Therefore, we break lifetime name resolution into a separate pass.
   7
   8 use crate::hir::def::{Res, DefKind};
   9 use crate::hir::def_id::{CrateNum, DefId, LocalDefId, LOCAL_CRATE};
  10 use crate::hir::map::Map;
  11 use crate::hir::{GenericArg, GenericParam, ItemLocalId, LifetimeName, Node, ParamName};
  12 use crate::ty::{self, DefIdTree, GenericParamDefKind, TyCtxt};
  13
  14 use crate::rustc::lint;
  15 use crate::session::Session;
  16 use crate::util::nodemap::{DefIdMap, FxHashMap, FxHashSet, HirIdMap, HirIdSet};
  17 use errors::{Applicability, DiagnosticBuilder};
  18 use rustc_macros::HashStable;
  19 use std::borrow::Cow;
  20 use std::cell::Cell;
  21 use std::mem::{replace, take};
  22 use syntax::ast;
  23 use syntax::attr;
  24 use syntax::ptr::P;
  25 use syntax::symbol::{kw, sym};
  26 use syntax_pos::Span;
  27
  28 use crate::hir::intravisit::{self, NestedVisitorMap, Visitor};
  29 use crate::hir::{self, GenericParamKind, LifetimeParamKind};
  30
  31 /// The origin of a named lifetime definition.
  32 ///
  33 /// This is used to prevent the usage of in-band lifetimes in `Fn`/`fn` syntax.
  34 #[derive(Copy, Clone, PartialEq, Eq, Hash, RustcEncodable, RustcDecodable, Debug, HashStable)]
  35 pub enum LifetimeDefOrigin {
  36     // Explicit binders like `fn foo<'a>(x: &'a u8)` or elided like `impl Foo<&u32>`
  37     ExplicitOrElided,
  38     // In-band declarations like `fn foo(x: &'a u8)`
  39     InBand,
  40     // Some kind of erroneous origin
  41     Error,
  42 }
  43
  44 impl LifetimeDefOrigin {
  45     fn from_param(param: &GenericParam) -> Self {
  46         match param.kind {
  47             GenericParamKind::Lifetime { kind } => match kind {
  48                 LifetimeParamKind::InBand => LifetimeDefOrigin::InBand,
  49                 LifetimeParamKind::Explicit => LifetimeDefOrigin::ExplicitOrElided,
  50                 LifetimeParamKind::Elided => LifetimeDefOrigin::ExplicitOrElided,
  51                 LifetimeParamKind::Error => LifetimeDefOrigin::Error,
  52             },
  53             _ => bug!("expected a lifetime param"),
  54         }
  55     }
  56 }
  57
  58 // This counts the no of times a lifetime is used
  59 #[derive(Clone, Copy, Debug)]
  60 pub enum LifetimeUseSet<'tcx> {
  61     One(&'tcx hir::Lifetime),
  62     Many,
  63 }
  64
  65 #[derive(Clone, Copy, PartialEq, Eq, Hash, RustcEncodable, RustcDecodable, Debug, HashStable)]
  66 pub enum Region {
  67     Static,
  68     EarlyBound(
  69         /* index */ u32,
  70         /* lifetime decl */ DefId,
  71         LifetimeDefOrigin,
  72     ),
  73     LateBound(
  74         ty::DebruijnIndex,
  75         /* lifetime decl */ DefId,
  76         LifetimeDefOrigin,
  77     ),
  78     LateBoundAnon(ty::DebruijnIndex, /* anon index */ u32),
  79     Free(DefId, /* lifetime decl */ DefId),
  80 }
  81
  82 impl Region {
  83     fn early(hir_map: &Map<'_>, index: &mut u32, param: &GenericParam) -> (ParamName, Region) {
  84         let i = *index;
  85         *index += 1;
  86         let def_id = hir_map.local_def_id_from_hir_id(param.hir_id);
  87         let origin = LifetimeDefOrigin::from_param(param);
  88         debug!("Region::early: index={} def_id={:?}", i, def_id);
  89         (param.name.modern(), Region::EarlyBound(i, def_id, origin))
  90     }
  91
  92     fn late(hir_map: &Map<'_>, param: &GenericParam) -> (ParamName, Region) {
  93         let depth = ty::INNERMOST;
  94         let def_id = hir_map.local_def_id_from_hir_id(param.hir_id);
  95         let origin = LifetimeDefOrigin::from_param(param);
  96         debug!(
  97             "Region::late: param={:?} depth={:?} def_id={:?} origin={:?}",
  98             param, depth, def_id, origin,
  99         );
 100         (
 101             param.name.modern(),
 102             Region::LateBound(depth, def_id, origin),
 103         )
 104     }
 105
 106     fn late_anon(index: &Cell<u32>) -> Region {
 107         let i = index.get();
 108         index.set(i + 1);
 109         let depth = ty::INNERMOST;
 110         Region::LateBoundAnon(depth, i)
 111     }
 112
 113     fn id(&self) -> Option<DefId> {
 114         match *self {
 115             Region::Static | Region::LateBoundAnon(..) => None,
 116
 117             Region::EarlyBound(_, id, _) | Region::LateBound(_, id, _) | Region::Free(_, id) => {
 118                 Some(id)
 119             }
 120         }
 121     }
 122
 123     fn shifted(self, amount: u32) -> Region {
 124         match self {
 125             Region::LateBound(debruijn, id, origin) => {
 126                 Region::LateBound(debruijn.shifted_in(amount), id, origin)
 127             }
 128             Region::LateBoundAnon(debruijn, index) => {
 129                 Region::LateBoundAnon(debruijn.shifted_in(amount), index)
 130             }
 131             _ => self,
 132         }
 133     }
 134
 135     fn shifted_out_to_binder(self, binder: ty::DebruijnIndex) -> Region {
 136         match self {
 137             Region::LateBound(debruijn, id, origin) => {
 138                 Region::LateBound(debruijn.shifted_out_to_binder(binder), id, origin)
 139             }
 140             Region::LateBoundAnon(debruijn, index) => {
 141                 Region::LateBoundAnon(debruijn.shifted_out_to_binder(binder), index)
 142             }
 143             _ => self,
 144         }
 145     }
 146
 147     fn subst<'a, L>(self, mut params: L, map: &NamedRegionMap) -> Option<Region>
 148     where
 149         L: Iterator<Item = &'a hir::Lifetime>,
 150     {
 151         if let Region::EarlyBound(index, _, _) = self {
 152             params
 153                 .nth(index as usize)
 154                 .and_then(|lifetime| map.defs.get(&lifetime.hir_id).cloned())
 155         } else {
 156             Some(self)
 157         }
 158     }
 159 }
 160
 161 /// A set containing, at most, one known element.
 162 /// If two distinct values are inserted into a set, then it
 163 /// becomes `Many`, which can be used to detect ambiguities.
 164 #[derive(Copy, Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Debug, HashStable)]
 165 pub enum Set1<T> {
 166     Empty,
 167     One(T),
 168     Many,
 169 }
 170
 171 impl<T: PartialEq> Set1<T> {
 172     pub fn insert(&mut self, value: T) {
 173         *self = match self {
 174             Set1::Empty => Set1::One(value),
 175             Set1::One(old) if *old == value => return,
 176             _ => Set1::Many,
 177         };
 178     }
 179 }
 180
 181 pub type ObjectLifetimeDefault = Set1<Region>;
 182
 183 /// Maps the id of each lifetime reference to the lifetime decl
 184 /// that it corresponds to.
 185 ///
 186 /// FIXME. This struct gets converted to a `ResolveLifetimes` for
 187 /// actual use. It has the same data, but indexed by `DefIndex`.  This
 188 /// is silly.
 189 #[derive(Default)]
 190 struct NamedRegionMap {
 191     // maps from every use of a named (not anonymous) lifetime to a
 192     // `Region` describing how that region is bound
 193     pub defs: HirIdMap<Region>,
 194
 195     // the set of lifetime def ids that are late-bound; a region can
 196     // be late-bound if (a) it does NOT appear in a where-clause and
 197     // (b) it DOES appear in the arguments.
 198     pub late_bound: HirIdSet,
 199
 200     // For each type and trait definition, maps type parameters
 201     // to the trait object lifetime defaults computed from them.
 202     pub object_lifetime_defaults: HirIdMap<Vec<ObjectLifetimeDefault>>,
 203 }
 204
 205 /// See [`NamedRegionMap`].
 206 #[derive(Default)]
 207 pub struct ResolveLifetimes {
 208     defs: FxHashMap<LocalDefId, FxHashMap<ItemLocalId, Region>>,
 209     late_bound: FxHashMap<LocalDefId, FxHashSet<ItemLocalId>>,
 210     object_lifetime_defaults:
 211         FxHashMap<LocalDefId, FxHashMap<ItemLocalId, Vec<ObjectLifetimeDefault>>>,
 212 }
 213
 214 impl_stable_hash_for!(struct crate::middle::resolve_lifetime::ResolveLifetimes {
 215     defs,
 216     late_bound,
 217     object_lifetime_defaults
 218 });
 219
 220 struct LifetimeContext<'a, 'tcx> {
 221     tcx: TyCtxt<'tcx>,
 222     map: &'a mut NamedRegionMap,
 223     scope: ScopeRef<'a>,
 224
 225     /// This is slightly complicated. Our representation for poly-trait-refs contains a single
 226     /// binder and thus we only allow a single level of quantification. However,
 227     /// the syntax of Rust permits quantification in two places, e.g., `T: for <'a> Foo<'a>`
 228     /// and `for <'a, 'b> &'b T: Foo<'a>`. In order to get the De Bruijn indices
 229     /// correct when representing these constraints, we should only introduce one
 230     /// scope. However, we want to support both locations for the quantifier and
 231     /// during lifetime resolution we want precise information (so we can't
 232     /// desugar in an earlier phase).
 233     ///
 234     /// So, if we encounter a quantifier at the outer scope, we set
 235     /// `trait_ref_hack` to `true` (and introduce a scope), and then if we encounter
 236     /// a quantifier at the inner scope, we error. If `trait_ref_hack` is `false`,
 237     /// then we introduce the scope at the inner quantifier.
 238     trait_ref_hack: bool,
 239
 240     /// Used to disallow the use of in-band lifetimes in `fn` or `Fn` syntax.
 241     is_in_fn_syntax: bool,
 242
 243     /// List of labels in the function/method currently under analysis.
 244     labels_in_fn: Vec<ast::Ident>,
 245
 246     /// Cache for cross-crate per-definition object lifetime defaults.
 247     xcrate_object_lifetime_defaults: DefIdMap<Vec<ObjectLifetimeDefault>>,
 248
 249     lifetime_uses: &'a mut DefIdMap<LifetimeUseSet<'tcx>>,
 250 }
 251
 252 #[derive(Debug)]
 253 enum Scope<'a> {
 254     /// Declares lifetimes, and each can be early-bound or late-bound.
 255     /// The `DebruijnIndex` of late-bound lifetimes starts at `1` and
 256     /// it should be shifted by the number of `Binder`s in between the
 257     /// declaration `Binder` and the location it's referenced from.
 258     Binder {
 259         lifetimes: FxHashMap<hir::ParamName, Region>,
 260
 261         /// if we extend this scope with another scope, what is the next index
 262         /// we should use for an early-bound region?
 263         next_early_index: u32,
 264
 265         /// Flag is set to true if, in this binder, `'_` would be
 266         /// equivalent to a "single-use region". This is true on
 267         /// impls, but not other kinds of items.
 268         track_lifetime_uses: bool,
 269
 270         /// Whether or not this binder would serve as the parent
 271         /// binder for abstract types introduced within. For example:
 272         ///
 273         ///     fn foo<'a>() -> impl for<'b> Trait<Item = impl Trait2<'a>>
 274         ///
 275         /// Here, the abstract types we create for the `impl Trait`
 276         /// and `impl Trait2` references will both have the `foo` item
 277         /// as their parent. When we get to `impl Trait2`, we find
 278         /// that it is nested within the `for<>` binder -- this flag
 279         /// allows us to skip that when looking for the parent binder
 280         /// of the resulting abstract type.
 281         abstract_type_parent: bool,
 282
 283         s: ScopeRef<'a>,
 284     },
 285
 286     /// Lifetimes introduced by a fn are scoped to the call-site for that fn,
 287     /// if this is a fn body, otherwise the original definitions are used.
 288     /// Unspecified lifetimes are inferred, unless an elision scope is nested,
 289     /// e.g., `(&T, fn(&T) -> &T);` becomes `(&'_ T, for<'a> fn(&'a T) -> &'a T)`.
 290     Body {
 291         id: hir::BodyId,
 292         s: ScopeRef<'a>,
 293     },
 294
 295     /// A scope which either determines unspecified lifetimes or errors
 296     /// on them (e.g., due to ambiguity). For more details, see `Elide`.
 297     Elision {
 298         elide: Elide,
 299         s: ScopeRef<'a>,
 300     },
 301
 302     /// Use a specific lifetime (if `Some`) or leave it unset (to be
 303     /// inferred in a function body or potentially error outside one),
 304     /// for the default choice of lifetime in a trait object type.
 305     ObjectLifetimeDefault {
 306         lifetime: Option<Region>,
 307         s: ScopeRef<'a>,
 308     },
 309
 310     Root,
 311 }
 312
 313 #[derive(Clone, Debug)]
 314 enum Elide {
 315     /// Use a fresh anonymous late-bound lifetime each time, by
 316     /// incrementing the counter to generate sequential indices.
 317     FreshLateAnon(Cell<u32>),
 318     /// Always use this one lifetime.
 319     Exact(Region),
 320     /// Less or more than one lifetime were found, error on unspecified.
 321     Error(Vec<ElisionFailureInfo>),
 322 }
 323
 324 #[derive(Clone, Debug)]
 325 struct ElisionFailureInfo {
 326     /// Where we can find the argument pattern.
 327     parent: Option<hir::BodyId>,
 328     /// The index of the argument in the original definition.
 329     index: usize,
 330     lifetime_count: usize,
 331     have_bound_regions: bool,
 332 }
 333
 334 type ScopeRef<'a> = &'a Scope<'a>;
 335
 336 const ROOT_SCOPE: ScopeRef<'static> = &Scope::Root;
 337
 338 pub fn provide(providers: &mut ty::query::Providers<'_>) {
 339     *providers = ty::query::Providers {
 340         resolve_lifetimes,
 341
 342         named_region_map: |tcx, id| {
 343             let id = LocalDefId::from_def_id(DefId::local(id)); // (*)
 344             tcx.resolve_lifetimes(LOCAL_CRATE).defs.get(&id)
 345         },
 346
 347         is_late_bound_map: |tcx, id| {
 348             let id = LocalDefId::from_def_id(DefId::local(id)); // (*)
 349             tcx.resolve_lifetimes(LOCAL_CRATE)
 350                 .late_bound
 351                 .get(&id)
 352         },
 353
 354         object_lifetime_defaults_map: |tcx, id| {
 355             let id = LocalDefId::from_def_id(DefId::local(id)); // (*)
 356             tcx.resolve_lifetimes(LOCAL_CRATE)
 357                 .object_lifetime_defaults
 358                 .get(&id)
 359         },
 360
 361         ..*providers
 362     };
 363
 364     // (*) FIXME the query should be defined to take a LocalDefId
 365 }
 366
 367 /// Computes the `ResolveLifetimes` map that contains data for the
 368 /// entire crate. You should not read the result of this query
 369 /// directly, but rather use `named_region_map`, `is_late_bound_map`,
 370 /// etc.
 371 fn resolve_lifetimes<'tcx>(tcx: TyCtxt<'tcx>, for_krate: CrateNum) -> &'tcx ResolveLifetimes {
 372     assert_eq!(for_krate, LOCAL_CRATE);
 373
 374     let named_region_map = krate(tcx);
 375
 376     let mut rl = ResolveLifetimes::default();
 377
 378     for (hir_id, v) in named_region_map.defs {
 379         let map = rl.defs.entry(hir_id.owner_local_def_id()).or_default();
 380         map.insert(hir_id.local_id, v);
 381     }
 382     for hir_id in named_region_map.late_bound {
 383         let map = rl.late_bound
 384             .entry(hir_id.owner_local_def_id())
 385             .or_default();
 386         map.insert(hir_id.local_id);
 387     }
 388     for (hir_id, v) in named_region_map.object_lifetime_defaults {
 389         let map = rl.object_lifetime_defaults
 390             .entry(hir_id.owner_local_def_id())
 391             .or_default();
 392         map.insert(hir_id.local_id, v);
 393     }
 394
 395     tcx.arena.alloc(rl)
 396 }
 397
 398 fn krate<'tcx>(tcx: TyCtxt<'tcx>) -> NamedRegionMap {
 399     let krate = tcx.hir().krate();
 400     let mut map = NamedRegionMap {
 401         defs: Default::default(),
 402         late_bound: Default::default(),
 403         object_lifetime_defaults: compute_object_lifetime_defaults(tcx),
 404     };
 405     {
 406         let mut visitor = LifetimeContext {
 407             tcx,
 408             map: &mut map,
 409             scope: ROOT_SCOPE,
 410             trait_ref_hack: false,
 411             is_in_fn_syntax: false,
 412             labels_in_fn: vec![],
 413             xcrate_object_lifetime_defaults: Default::default(),
 414             lifetime_uses: &mut Default::default(),
 415         };
 416         for (_, item) in &krate.items {
 417             visitor.visit_item(item);
 418         }
 419     }
 420     map
 421 }
 422
 423 /// In traits, there is an implicit `Self` type parameter which comes before the generics.
 424 /// We have to account for this when computing the index of the other generic parameters.
 425 /// This function returns whether there is such an implicit parameter defined on the given item.
 426 fn sub_items_have_self_param(node: &hir::ItemKind) -> bool {
 427     match *node {
 428         hir::ItemKind::Trait(..) |
 429         hir::ItemKind::TraitAlias(..) => true,
 430         _ => false,
 431     }
 432 }
 433
 434 impl<'a, 'tcx> Visitor<'tcx> for LifetimeContext<'a, 'tcx> {
 435     fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
 436         NestedVisitorMap::All(&self.tcx.hir())
 437     }
 438
 439     // We want to nest trait/impl items in their parent, but nothing else.
 440     fn visit_nested_item(&mut self, _: hir::ItemId) {}
 441
 442     fn visit_nested_body(&mut self, body: hir::BodyId) {
 443         // Each body has their own set of labels, save labels.
 444         let saved = take(&mut self.labels_in_fn);
 445         let body = self.tcx.hir().body(body);
 446         extract_labels(self, body);
 447         self.with(
 448             Scope::Body {
 449                 id: body.id(),
 450                 s: self.scope,
 451             },
 452             |_, this| {
 453                 this.visit_body(body);
 454             },
 455         );
 456         replace(&mut self.labels_in_fn, saved);
 457     }
 458
 459     fn visit_item(&mut self, item: &'tcx hir::Item) {
 460         match item.node {
 461             hir::ItemKind::Fn(ref decl, _, ref generics, _) => {
 462                 self.visit_early_late(None, decl, generics, |this| {
 463                     intravisit::walk_item(this, item);
 464                 });
 465             }
 466
 467             hir::ItemKind::ExternCrate(_)
 468             | hir::ItemKind::Use(..)
 469             | hir::ItemKind::Mod(..)
 470             | hir::ItemKind::ForeignMod(..)
 471             | hir::ItemKind::GlobalAsm(..) => {
 472                 // These sorts of items have no lifetime parameters at all.
 473                 intravisit::walk_item(self, item);
 474             }
 475             hir::ItemKind::Static(..) | hir::ItemKind::Const(..) => {
 476                 // No lifetime parameters, but implied 'static.
 477                 let scope = Scope::Elision {
 478                     elide: Elide::Exact(Region::Static),
 479                     s: ROOT_SCOPE,
 480                 };
 481                 self.with(scope, |_, this| intravisit::walk_item(this, item));
 482             }
 483             hir::ItemKind::Existential(hir::ExistTy {
 484                 impl_trait_fn: Some(_),
 485                 ..
 486             }) => {
 487                 // currently existential type declarations are just generated from impl Trait
 488                 // items. doing anything on this node is irrelevant, as we currently don't need
 489                 // it.
 490             }
 491             hir::ItemKind::Ty(_, ref generics)
 492             | hir::ItemKind::Existential(hir::ExistTy {
 493                 impl_trait_fn: None,
 494                 ref generics,
 495                 ..
 496             })
 497             | hir::ItemKind::Enum(_, ref generics)
 498             | hir::ItemKind::Struct(_, ref generics)
 499             | hir::ItemKind::Union(_, ref generics)
 500             | hir::ItemKind::Trait(_, _, ref generics, ..)
 501             | hir::ItemKind::TraitAlias(ref generics, ..)
 502             | hir::ItemKind::Impl(_, _, _, ref generics, ..) => {
 503                 // Impls permit `'_` to be used and it is equivalent to "some fresh lifetime name".
 504                 // This is not true for other kinds of items.x
 505                 let track_lifetime_uses = match item.node {
 506                     hir::ItemKind::Impl(..) => true,
 507                     _ => false,
 508                 };
 509                 // These kinds of items have only early-bound lifetime parameters.
 510                 let mut index = if sub_items_have_self_param(&item.node) {
 511                     1 // Self comes before lifetimes
 512                 } else {
 513                     0
 514                 };
 515                 let mut non_lifetime_count = 0;
 516                 let lifetimes = generics.params.iter().filter_map(|param| match param.kind {
 517                     GenericParamKind::Lifetime { .. } => {
 518                         Some(Region::early(&self.tcx.hir(), &mut index, param))
 519                     }
 520                     GenericParamKind::Type { .. } |
 521                     GenericParamKind::Const { .. } => {
 522                         non_lifetime_count += 1;
 523                         None
 524                     }
 525                 }).collect();
 526                 let scope = Scope::Binder {
 527                     lifetimes,
 528                     next_early_index: index + non_lifetime_count,
 529                     abstract_type_parent: true,
 530                     track_lifetime_uses,
 531                     s: ROOT_SCOPE,
 532                 };
 533                 self.with(scope, |old_scope, this| {
 534                     this.check_lifetime_params(old_scope, &generics.params);
 535                     intravisit::walk_item(this, item);
 536                 });
 537             }
 538         }
 539     }
 540
 541     fn visit_foreign_item(&mut self, item: &'tcx hir::ForeignItem) {
 542         match item.node {
 543             hir::ForeignItemKind::Fn(ref decl, _, ref generics) => {
 544                 self.visit_early_late(None, decl, generics, |this| {
 545                     intravisit::walk_foreign_item(this, item);
 546                 })
 547             }
 548             hir::ForeignItemKind::Static(..) => {
 549                 intravisit::walk_foreign_item(self, item);
 550             }
 551             hir::ForeignItemKind::Type => {
 552                 intravisit::walk_foreign_item(self, item);
 553             }
 554         }
 555     }
 556
 557     fn visit_ty(&mut self, ty: &'tcx hir::Ty) {
 558         debug!("visit_ty: id={:?} ty={:?}", ty.hir_id, ty);
 559         match ty.node {
 560             hir::TyKind::BareFn(ref c) => {
 561                 let next_early_index = self.next_early_index();
 562                 let was_in_fn_syntax = self.is_in_fn_syntax;
 563                 self.is_in_fn_syntax = true;
 564                 let scope = Scope::Binder {
 565                     lifetimes: c.generic_params
 566                         .iter()
 567                         .filter_map(|param| match param.kind {
 568                             GenericParamKind::Lifetime { .. } => {
 569                                 Some(Region::late(&self.tcx.hir(), param))
 570                             }
 571                             _ => None,
 572                         })
 573                         .collect(),
 574                     s: self.scope,
 575                     next_early_index,
 576                     track_lifetime_uses: true,
 577                     abstract_type_parent: false,
 578                 };
 579                 self.with(scope, |old_scope, this| {
 580                     // a bare fn has no bounds, so everything
 581                     // contained within is scoped within its binder.
 582                     this.check_lifetime_params(old_scope, &c.generic_params);
 583                     intravisit::walk_ty(this, ty);
 584                 });
 585                 self.is_in_fn_syntax = was_in_fn_syntax;
 586             }
 587             hir::TyKind::TraitObject(ref bounds, ref lifetime) => {
 588                 for bound in bounds {
 589                     self.visit_poly_trait_ref(bound, hir::TraitBoundModifier::None);
 590                 }
 591                 match lifetime.name {
 592                     LifetimeName::Implicit => {
 593                         // If the user does not write *anything*, we
 594                         // use the object lifetime defaulting
 595                         // rules. So e.g., `Box<dyn Debug>` becomes
 596                         // `Box<dyn Debug + 'static>`.
 597                         self.resolve_object_lifetime_default(lifetime)
 598                     }
 599                     LifetimeName::Underscore => {
 600                         // If the user writes `'_`, we use the *ordinary* elision
 601                         // rules. So the `'_` in e.g., `Box<dyn Debug + '_>` will be
 602                         // resolved the same as the `'_` in `&'_ Foo`.
 603                         //
 604                         // cc #48468
 605                         self.resolve_elided_lifetimes(vec![lifetime])
 606                     }
 607                     LifetimeName::Param(_) | LifetimeName::Static => {
 608                         // If the user wrote an explicit name, use that.
 609                         self.visit_lifetime(lifetime);
 610                     }
 611                     LifetimeName::Error => {}
 612                 }
 613             }
 614             hir::TyKind::Rptr(ref lifetime_ref, ref mt) => {
 615                 self.visit_lifetime(lifetime_ref);
 616                 let scope = Scope::ObjectLifetimeDefault {
 617                     lifetime: self.map.defs.get(&lifetime_ref.hir_id).cloned(),
 618                     s: self.scope,
 619                 };
 620                 self.with(scope, |_, this| this.visit_ty(&mt.ty));
 621             }
 622             hir::TyKind::Def(item_id, ref lifetimes) => {
 623                 // Resolve the lifetimes in the bounds to the lifetime defs in the generics.
 624                 // `fn foo<'a>() -> impl MyTrait<'a> { ... }` desugars to
 625                 // `abstract type MyAnonTy<'b>: MyTrait<'b>;`
 626                 //                          ^            ^ this gets resolved in the scope of
 627                 //                                         the exist_ty generics
 628                 let (generics, bounds) = match self.tcx.hir().expect_item(item_id.id).node
 629                 {
 630                     // named existential types are reached via TyKind::Path
 631                     // this arm is for `impl Trait` in the types of statics, constants and locals
 632                     hir::ItemKind::Existential(hir::ExistTy {
 633                         impl_trait_fn: None,
 634                         ..
 635                     }) => {
 636                         intravisit::walk_ty(self, ty);
 637                         return;
 638                     }
 639                     // RPIT (return position impl trait)
 640                     hir::ItemKind::Existential(hir::ExistTy {
 641                         ref generics,
 642                         ref bounds,
 643                         ..
 644                     }) => (generics, bounds),
 645                     ref i => bug!("impl Trait pointed to non-existential type?? {:#?}", i),
 646                 };
 647
 648                 // Resolve the lifetimes that are applied to the existential type.
 649                 // These are resolved in the current scope.
 650                 // `fn foo<'a>() -> impl MyTrait<'a> { ... }` desugars to
 651                 // `fn foo<'a>() -> MyAnonTy<'a> { ... }`
 652                 //          ^                 ^this gets resolved in the current scope
 653                 for lifetime in lifetimes {
 654                     if let hir::GenericArg::Lifetime(lifetime) = lifetime {
 655                         self.visit_lifetime(lifetime);
 656
 657                         // Check for predicates like `impl for<'a> Trait<impl OtherTrait<'a>>`
 658                         // and ban them. Type variables instantiated inside binders aren't
 659                         // well-supported at the moment, so this doesn't work.
 660                         // In the future, this should be fixed and this error should be removed.
 661                         let def = self.map.defs.get(&lifetime.hir_id).cloned();
 662                         if let Some(Region::LateBound(_, def_id, _)) = def {
 663                             if let Some(hir_id) = self.tcx.hir().as_local_hir_id(def_id) {
 664                                 // Ensure that the parent of the def is an item, not HRTB
 665                                 let parent_id = self.tcx.hir().get_parent_node(hir_id);
 666                                 let parent_impl_id = hir::ImplItemId { hir_id: parent_id };
 667                                 let parent_trait_id = hir::TraitItemId { hir_id: parent_id };
 668                                 let krate = self.tcx.hir().forest.krate();
 669
 670                                 if !(krate.items.contains_key(&parent_id)
 671                                     || krate.impl_items.contains_key(&parent_impl_id)
 672                                     || krate.trait_items.contains_key(&parent_trait_id))
 673                                 {
 674                                     span_err!(
 675                                         self.tcx.sess,
 676                                         lifetime.span,
 677                                         E0657,
 678                                         "`impl Trait` can only capture lifetimes \
 679                                          bound at the fn or impl level"
 680                                     );
 681                                     self.uninsert_lifetime_on_error(lifetime, def.unwrap());
 682                                 }
 683                             }
 684                         }
 685                     }
 686                 }
 687
 688                 // We want to start our early-bound indices at the end of the parent scope,
 689                 // not including any parent `impl Trait`s.
 690                 let mut index = self.next_early_index_for_abstract_type();
 691                 debug!("visit_ty: index = {}", index);
 692
 693                 let mut elision = None;
 694                 let mut lifetimes = FxHashMap::default();
 695                 let mut non_lifetime_count = 0;
 696                 for param in &generics.params {
 697                     match param.kind {
 698                         GenericParamKind::Lifetime { .. } => {
 699                             let (name, reg) = Region::early(&self.tcx.hir(), &mut index, &param);
 700                             if let hir::ParamName::Plain(param_name) = name {
 701                                 if param_name.name == kw::UnderscoreLifetime {
 702                                     // Pick the elided lifetime "definition" if one exists
 703                                     // and use it to make an elision scope.
 704                                     elision = Some(reg);
 705                                 } else {
 706                                     lifetimes.insert(name, reg);
 707                                 }
 708                             } else {
 709                                 lifetimes.insert(name, reg);
 710                             }
 711                         }
 712                         GenericParamKind::Type { .. } |
 713                         GenericParamKind::Const { .. } => {
 714                             non_lifetime_count += 1;
 715                         }
 716                     }
 717                 }
 718                 let next_early_index = index + non_lifetime_count;
 719
 720                 if let Some(elision_region) = elision {
 721                     let scope = Scope::Elision {
 722                         elide: Elide::Exact(elision_region),
 723                         s: self.scope,
 724                     };
 725                     self.with(scope, |_old_scope, this| {
 726                         let scope = Scope::Binder {
 727                             lifetimes,
 728                             next_early_index,
 729                             s: this.scope,
 730                             track_lifetime_uses: true,
 731                             abstract_type_parent: false,
 732                         };
 733                         this.with(scope, |_old_scope, this| {
 734                             this.visit_generics(generics);
 735                             for bound in bounds {
 736                                 this.visit_param_bound(bound);
 737                             }
 738                         });
 739                     });
 740                 } else {
 741                     let scope = Scope::Binder {
 742                         lifetimes,
 743                         next_early_index,
 744                         s: self.scope,
 745                         track_lifetime_uses: true,
 746                         abstract_type_parent: false,
 747                     };
 748                     self.with(scope, |_old_scope, this| {
 749                         this.visit_generics(generics);
 750                         for bound in bounds {
 751                             this.visit_param_bound(bound);
 752                         }
 753                     });
 754                 }
 755             }
 756             hir::TyKind::CVarArgs(ref lt) => {
 757                 // Resolve the generated lifetime for the C-variadic arguments.
 758                 // The lifetime is generated in AST -> HIR lowering.
 759                 if lt.name.is_elided() {
 760                     self.resolve_elided_lifetimes(vec![lt])
 761                 }
 762             }
 763             _ => intravisit::walk_ty(self, ty),
 764         }
 765     }
 766
 767     fn visit_trait_item(&mut self, trait_item: &'tcx hir::TraitItem) {
 768         use self::hir::TraitItemKind::*;
 769         match trait_item.node {
 770             Method(ref sig, _) => {
 771                 let tcx = self.tcx;
 772                 self.visit_early_late(
 773                     Some(tcx.hir().get_parent_item(trait_item.hir_id)),
 774                     &sig.decl,
 775                     &trait_item.generics,
 776                     |this| intravisit::walk_trait_item(this, trait_item),
 777                 );
 778             }
 779             Type(ref bounds, ref ty) => {
 780                 let generics = &trait_item.generics;
 781                 let mut index = self.next_early_index();
 782                 debug!("visit_ty: index = {}", index);
 783                 let mut non_lifetime_count = 0;
 784                 let lifetimes = generics.params.iter().filter_map(|param| match param.kind {
 785                     GenericParamKind::Lifetime { .. } => {
 786                         Some(Region::early(&self.tcx.hir(), &mut index, param))
 787                     }
 788                     GenericParamKind::Type { .. } |
 789                     GenericParamKind::Const { .. } => {
 790                         non_lifetime_count += 1;
 791                         None
 792                     }
 793                 }).collect();
 794                 let scope = Scope::Binder {
 795                     lifetimes,
 796                     next_early_index: index + non_lifetime_count,
 797                     s: self.scope,
 798                     track_lifetime_uses: true,
 799                     abstract_type_parent: true,
 800                 };
 801                 self.with(scope, |_old_scope, this| {
 802                     this.visit_generics(generics);
 803                     for bound in bounds {
 804                         this.visit_param_bound(bound);
 805                     }
 806                     if let Some(ty) = ty {
 807                         this.visit_ty(ty);
 808                     }
 809                 });
 810             }
 811             Const(_, _) => {
 812                 // Only methods and types support generics.
 813                 assert!(trait_item.generics.params.is_empty());
 814                 intravisit::walk_trait_item(self, trait_item);
 815             }
 816         }
 817     }
 818
 819     fn visit_impl_item(&mut self, impl_item: &'tcx hir::ImplItem) {
 820         use self::hir::ImplItemKind::*;
 821         match impl_item.node {
 822             Method(ref sig, _) => {
 823                 let tcx = self.tcx;
 824                 self.visit_early_late(
 825                     Some(tcx.hir().get_parent_item(impl_item.hir_id)),
 826                     &sig.decl,
 827                     &impl_item.generics,
 828                     |this| intravisit::walk_impl_item(this, impl_item),
 829                 )
 830             }
 831             Type(ref ty) => {
 832                 let generics = &impl_item.generics;
 833                 let mut index = self.next_early_index();
 834                 let mut non_lifetime_count = 0;
 835                 debug!("visit_ty: index = {}", index);
 836                 let lifetimes = generics.params.iter().filter_map(|param| match param.kind {
 837                     GenericParamKind::Lifetime { .. } => {
 838                         Some(Region::early(&self.tcx.hir(), &mut index, param))
 839                     }
 840                     GenericParamKind::Const { .. } |
 841                     GenericParamKind::Type { .. } => {
 842                         non_lifetime_count += 1;
 843                         None
 844                     }
 845                 }).collect();
 846                 let scope = Scope::Binder {
 847                     lifetimes,
 848                     next_early_index: index + non_lifetime_count,
 849                     s: self.scope,
 850                     track_lifetime_uses: true,
 851                     abstract_type_parent: true,
 852                 };
 853                 self.with(scope, |_old_scope, this| {
 854                     this.visit_generics(generics);
 855                     this.visit_ty(ty);
 856                 });
 857             }
 858             Existential(ref bounds) => {
 859                 let generics = &impl_item.generics;
 860                 let mut index = self.next_early_index();
 861                 let mut next_early_index = index;
 862                 debug!("visit_ty: index = {}", index);
 863                 let lifetimes = generics.params.iter().filter_map(|param| match param.kind {
 864                     GenericParamKind::Lifetime { .. } => {
 865                         Some(Region::early(&self.tcx.hir(), &mut index, param))
 866                     }
 867                     GenericParamKind::Type { .. } => {
 868                         next_early_index += 1;
 869                         None
 870                     }
 871                     GenericParamKind::Const { .. } => {
 872                         next_early_index += 1;
 873                         None
 874                     }
 875                 }).collect();
 876
 877                 let scope = Scope::Binder {
 878                     lifetimes,
 879                     next_early_index,
 880                     s: self.scope,
 881                     track_lifetime_uses: true,
 882                     abstract_type_parent: true,
 883                 };
 884                 self.with(scope, |_old_scope, this| {
 885                     this.visit_generics(generics);
 886                     for bound in bounds {
 887                         this.visit_param_bound(bound);
 888                     }
 889                 });
 890             }
 891             Const(_, _) => {
 892                 // Only methods and types support generics.
 893                 assert!(impl_item.generics.params.is_empty());
 894                 intravisit::walk_impl_item(self, impl_item);
 895             }
 896         }
 897     }
 898
 899     fn visit_lifetime(&mut self, lifetime_ref: &'tcx hir::Lifetime) {
 900         if lifetime_ref.is_elided() {
 901             self.resolve_elided_lifetimes(vec![lifetime_ref]);
 902             return;
 903         }
 904         if lifetime_ref.is_static() {
 905             self.insert_lifetime(lifetime_ref, Region::Static);
 906             return;
 907         }
 908         self.resolve_lifetime_ref(lifetime_ref);
 909     }
 910
 911     fn visit_path(&mut self, path: &'tcx hir::Path, _: hir::HirId) {
 912         for (i, segment) in path.segments.iter().enumerate() {
 913             let depth = path.segments.len() - i - 1;
 914             if let Some(ref args) = segment.args {
 915                 self.visit_segment_args(path.res, depth, args);
 916             }
 917         }
 918     }
 919
 920     fn visit_fn_decl(&mut self, fd: &'tcx hir::FnDecl) {
 921         let output = match fd.output {
 922             hir::DefaultReturn(_) => None,
 923             hir::Return(ref ty) => Some(&**ty),
 924         };
 925         self.visit_fn_like_elision(&fd.inputs, output);
 926     }
 927
 928     fn visit_generics(&mut self, generics: &'tcx hir::Generics) {
 929         check_mixed_explicit_and_in_band_defs(self.tcx, &generics.params);
 930         for param in &generics.params {
 931             match param.kind {
 932                 GenericParamKind::Lifetime { .. } => {}
 933                 GenericParamKind::Type { ref default, .. } => {
 934                     walk_list!(self, visit_param_bound, &param.bounds);
 935                     if let Some(ref ty) = default {
 936                         self.visit_ty(&ty);
 937                     }
 938                 }
 939                 GenericParamKind::Const { ref ty, .. } => {
 940                     walk_list!(self, visit_param_bound, &param.bounds);
 941                     self.visit_ty(&ty);
 942                 }
 943             }
 944         }
 945         for predicate in &generics.where_clause.predicates {
 946             match predicate {
 947                 &hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate {
 948                     ref bounded_ty,
 949                     ref bounds,
 950                     ref bound_generic_params,
 951                     ..
 952                 }) => {
 953                     let lifetimes: FxHashMap<_, _> = bound_generic_params
 954                         .iter()
 955                         .filter_map(|param| match param.kind {
 956                             GenericParamKind::Lifetime { .. } => {
 957                                 Some(Region::late(&self.tcx.hir(), param))
 958                             }
 959                             _ => None,
 960                         })
 961                         .collect();
 962                     if !lifetimes.is_empty() {
 963                         self.trait_ref_hack = true;
 964                         let next_early_index = self.next_early_index();
 965                         let scope = Scope::Binder {
 966                             lifetimes,
 967                             s: self.scope,
 968                             next_early_index,
 969                             track_lifetime_uses: true,
 970                             abstract_type_parent: false,
 971                         };
 972                         let result = self.with(scope, |old_scope, this| {
 973                             this.check_lifetime_params(old_scope, &bound_generic_params);
 974                             this.visit_ty(&bounded_ty);
 975                             walk_list!(this, visit_param_bound, bounds);
 976                         });
 977                         self.trait_ref_hack = false;
 978                         result
 979                     } else {
 980                         self.visit_ty(&bounded_ty);
 981                         walk_list!(self, visit_param_bound, bounds);
 982                     }
 983                 }
 984                 &hir::WherePredicate::RegionPredicate(hir::WhereRegionPredicate {
 985                     ref lifetime,
 986                     ref bounds,
 987                     ..
 988                 }) => {
 989                     self.visit_lifetime(lifetime);
 990                     walk_list!(self, visit_param_bound, bounds);
 991                 }
 992                 &hir::WherePredicate::EqPredicate(hir::WhereEqPredicate {
 993                     ref lhs_ty,
 994                     ref rhs_ty,
 995                     ..
 996                 }) => {
 997                     self.visit_ty(lhs_ty);
 998                     self.visit_ty(rhs_ty);
 999                 }
1000             }
1001         }
1002     }
1003
1004     fn visit_poly_trait_ref(
1005         &mut self,
1006         trait_ref: &'tcx hir::PolyTraitRef,
1007         _modifier: hir::TraitBoundModifier,
1008     ) {
1009         debug!("visit_poly_trait_ref(trait_ref={:?})", trait_ref);
1010
1011         if !self.trait_ref_hack || trait_ref.bound_generic_params.iter().any(|param| {
1012             match param.kind {
1013                 GenericParamKind::Lifetime { .. } => true,
1014                 _ => false,
1015             }
1016         }) {
1017             if self.trait_ref_hack {
1018                 span_err!(
1019                     self.tcx.sess,
1020                     trait_ref.span,
1021                     E0316,
1022                     "nested quantification of lifetimes"
1023                 );
1024             }
1025             let next_early_index = self.next_early_index();
1026             let scope = Scope::Binder {
1027                 lifetimes: trait_ref
1028                     .bound_generic_params
1029                     .iter()
1030                     .filter_map(|param| match param.kind {
1031                         GenericParamKind::Lifetime { .. } => {
1032                             Some(Region::late(&self.tcx.hir(), param))
1033                         }
1034                         _ => None,
1035                     })
1036                     .collect(),
1037                 s: self.scope,
1038                 next_early_index,
1039                 track_lifetime_uses: true,
1040                 abstract_type_parent: false,
1041             };
1042             self.with(scope, |old_scope, this| {
1043                 this.check_lifetime_params(old_scope, &trait_ref.bound_generic_params);
1044                 walk_list!(this, visit_generic_param, &trait_ref.bound_generic_params);
1045                 this.visit_trait_ref(&trait_ref.trait_ref)
1046             })
1047         } else {
1048             self.visit_trait_ref(&trait_ref.trait_ref)
1049         }
1050     }
1051 }
1052
1053 #[derive(Copy, Clone, PartialEq)]
1054 enum ShadowKind {
1055     Label,
1056     Lifetime,
1057 }
1058 struct Original {
1059     kind: ShadowKind,
1060     span: Span,
1061 }
1062 struct Shadower {
1063     kind: ShadowKind,
1064     span: Span,
1065 }
1066
1067 fn original_label(span: Span) -> Original {
1068     Original {
1069         kind: ShadowKind::Label,
1070         span: span,
1071     }
1072 }
1073 fn shadower_label(span: Span) -> Shadower {
1074     Shadower {
1075         kind: ShadowKind::Label,
1076         span: span,
1077     }
1078 }
1079 fn original_lifetime(span: Span) -> Original {
1080     Original {
1081         kind: ShadowKind::Lifetime,
1082         span: span,
1083     }
1084 }
1085 fn shadower_lifetime(param: &hir::GenericParam) -> Shadower {
1086     Shadower {
1087         kind: ShadowKind::Lifetime,
1088         span: param.span,
1089     }
1090 }
1091
1092 impl ShadowKind {
1093     fn desc(&self) -> &'static str {
1094         match *self {
1095             ShadowKind::Label => "label",
1096             ShadowKind::Lifetime => "lifetime",
1097         }
1098     }
1099 }
1100
1101 fn check_mixed_explicit_and_in_band_defs(tcx: TyCtxt<'_>, params: &P<[hir::GenericParam]>) {
1102     let lifetime_params: Vec<_> = params
1103         .iter()
1104         .filter_map(|param| match param.kind {
1105             GenericParamKind::Lifetime { kind, .. } => Some((kind, param.span)),
1106             _ => None,
1107         })
1108         .collect();
1109     let explicit = lifetime_params
1110         .iter()
1111         .find(|(kind, _)| *kind == LifetimeParamKind::Explicit);
1112     let in_band = lifetime_params
1113         .iter()
1114         .find(|(kind, _)| *kind == LifetimeParamKind::InBand);
1115
1116     if let (Some((_, explicit_span)), Some((_, in_band_span))) = (explicit, in_band) {
1117         struct_span_err!(
1118             tcx.sess,
1119             *in_band_span,
1120             E0688,
1121             "cannot mix in-band and explicit lifetime definitions"
1122         ).span_label(*in_band_span, "in-band lifetime definition here")
1123             .span_label(*explicit_span, "explicit lifetime definition here")
1124             .emit();
1125     }
1126 }
1127
1128 fn signal_shadowing_problem(tcx: TyCtxt<'_>, name: ast::Name, orig: Original, shadower: Shadower) {
1129     let mut err = if let (ShadowKind::Lifetime, ShadowKind::Lifetime) = (orig.kind, shadower.kind) {
1130         // lifetime/lifetime shadowing is an error
1131         struct_span_err!(
1132             tcx.sess,
1133             shadower.span,
1134             E0496,
1135             "{} name `{}` shadows a \
1136              {} name that is already in scope",
1137             shadower.kind.desc(),
1138             name,
1139             orig.kind.desc()
1140         )
1141     } else {
1142         // shadowing involving a label is only a warning, due to issues with
1143         // labels and lifetimes not being macro-hygienic.
1144         tcx.sess.struct_span_warn(
1145             shadower.span,
1146             &format!(
1147                 "{} name `{}` shadows a \
1148                  {} name that is already in scope",
1149                 shadower.kind.desc(),
1150                 name,
1151                 orig.kind.desc()
1152             ),
1153         )
1154     };
1155     err.span_label(orig.span, "first declared here");
1156     err.span_label(shadower.span, format!("lifetime {} already in scope", name));
1157     err.emit();
1158 }
1159
1160 // Adds all labels in `b` to `ctxt.labels_in_fn`, signalling a warning
1161 // if one of the label shadows a lifetime or another label.
1162 fn extract_labels(ctxt: &mut LifetimeContext<'_, '_>, body: &hir::Body) {
1163     struct GatherLabels<'a, 'tcx> {
1164         tcx: TyCtxt<'tcx>,
1165         scope: ScopeRef<'a>,
1166         labels_in_fn: &'a mut Vec<ast::Ident>,
1167     }
1168
1169     let mut gather = GatherLabels {
1170         tcx: ctxt.tcx,
1171         scope: ctxt.scope,
1172         labels_in_fn: &mut ctxt.labels_in_fn,
1173     };
1174     gather.visit_body(body);
1175
1176     impl<'v, 'a, 'tcx> Visitor<'v> for GatherLabels<'a, 'tcx> {
1177         fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'v> {
1178             NestedVisitorMap::None
1179         }
1180
1181         fn visit_expr(&mut self, ex: &hir::Expr) {
1182             if let Some(label) = expression_label(ex) {
1183                 for prior_label in &self.labels_in_fn[..] {
1184                     // FIXME (#24278): non-hygienic comparison
1185                     if label.name == prior_label.name {
1186                         signal_shadowing_problem(
1187                             self.tcx,
1188                             label.name,
1189                             original_label(prior_label.span),
1190                             shadower_label(label.span),
1191                         );
1192                     }
1193                 }
1194
1195                 check_if_label_shadows_lifetime(self.tcx, self.scope, label);
1196
1197                 self.labels_in_fn.push(label);
1198             }
1199             intravisit::walk_expr(self, ex)
1200         }
1201     }
1202
1203     fn expression_label(ex: &hir::Expr) -> Option<ast::Ident> {
1204         match ex.node {
1205             hir::ExprKind::While(.., Some(label)) | hir::ExprKind::Loop(_, Some(label), _) => {
1206                 Some(label.ident)
1207             }
1208             _ => None,
1209         }
1210     }
1211
1212     fn check_if_label_shadows_lifetime(
1213         tcx: TyCtxt<'_>,
1214         mut scope: ScopeRef<'_>,
1215         label: ast::Ident,
1216     ) {
1217         loop {
1218             match *scope {
1219                 Scope::Body { s, .. }
1220                 | Scope::Elision { s, .. }
1221                 | Scope::ObjectLifetimeDefault { s, .. } => {
1222                     scope = s;
1223                 }
1224
1225                 Scope::Root => {
1226                     return;
1227                 }
1228
1229                 Scope::Binder {
1230                     ref lifetimes, s, ..
1231                 } => {
1232                     // FIXME (#24278): non-hygienic comparison
1233                     if let Some(def) = lifetimes.get(&hir::ParamName::Plain(label.modern())) {
1234                         let hir_id = tcx.hir().as_local_hir_id(def.id().unwrap()).unwrap();
1235
1236                         signal_shadowing_problem(
1237                             tcx,
1238                             label.name,
1239                             original_lifetime(tcx.hir().span(hir_id)),
1240                             shadower_label(label.span),
1241                         );
1242                         return;
1243                     }
1244                     scope = s;
1245                 }
1246             }
1247         }
1248     }
1249 }
1250
1251 fn compute_object_lifetime_defaults(tcx: TyCtxt<'_>) -> HirIdMap<Vec<ObjectLifetimeDefault>> {
1252     let mut map = HirIdMap::default();
1253     for item in tcx.hir().krate().items.values() {
1254         match item.node {
1255             hir::ItemKind::Struct(_, ref generics)
1256             | hir::ItemKind::Union(_, ref generics)
1257             | hir::ItemKind::Enum(_, ref generics)
1258             | hir::ItemKind::Existential(hir::ExistTy {
1259                 ref generics,
1260                 impl_trait_fn: None,
1261                 ..
1262             })
1263             | hir::ItemKind::Ty(_, ref generics)
1264             | hir::ItemKind::Trait(_, _, ref generics, ..) => {
1265                 let result = object_lifetime_defaults_for_item(tcx, generics);
1266
1267                 // Debugging aid.
1268                 if attr::contains_name(&item.attrs, sym::rustc_object_lifetime_default) {
1269                     let object_lifetime_default_reprs: String = result
1270                         .iter()
1271                         .map(|set| match *set {
1272                             Set1::Empty => "BaseDefault".into(),
1273                             Set1::One(Region::Static) => "'static".into(),
1274                             Set1::One(Region::EarlyBound(mut i, _, _)) => generics
1275                                 .params
1276                                 .iter()
1277                                 .find_map(|param| match param.kind {
1278                                     GenericParamKind::Lifetime { .. } => {
1279                                         if i == 0 {
1280                                             return Some(param.name.ident().to_string().into());
1281                                         }
1282                                         i -= 1;
1283                                         None
1284                                     }
1285                                     _ => None,
1286                                 })
1287                                 .unwrap(),
1288                             Set1::One(_) => bug!(),
1289                             Set1::Many => "Ambiguous".into(),
1290                         })
1291                         .collect::<Vec<Cow<'static, str>>>()
1292                         .join(",");
1293                     tcx.sess.span_err(item.span, &object_lifetime_default_reprs);
1294                 }
1295
1296                 map.insert(item.hir_id, result);
1297             }
1298             _ => {}
1299         }
1300     }
1301     map
1302 }
1303
1304 /// Scan the bounds and where-clauses on parameters to extract bounds
1305 /// of the form `T:'a` so as to determine the `ObjectLifetimeDefault`
1306 /// for each type parameter.
1307 fn object_lifetime_defaults_for_item(
1308     tcx: TyCtxt<'_>,
1309     generics: &hir::Generics,
1310 ) -> Vec<ObjectLifetimeDefault> {
1311     fn add_bounds(set: &mut Set1<hir::LifetimeName>, bounds: &[hir::GenericBound]) {
1312         for bound in bounds {
1313             if let hir::GenericBound::Outlives(ref lifetime) = *bound {
1314                 set.insert(lifetime.name.modern());
1315             }
1316         }
1317     }
1318
1319     generics
1320         .params
1321         .iter()
1322         .filter_map(|param| match param.kind {
1323             GenericParamKind::Lifetime { .. } => None,
1324             GenericParamKind::Type { .. } => {
1325                 let mut set = Set1::Empty;
1326
1327                 add_bounds(&mut set, &param.bounds);
1328
1329                 let param_def_id = tcx.hir().local_def_id_from_hir_id(param.hir_id);
1330                 for predicate in &generics.where_clause.predicates {
1331                     // Look for `type: ...` where clauses.
1332                     let data = match *predicate {
1333                         hir::WherePredicate::BoundPredicate(ref data) => data,
1334                         _ => continue,
1335                     };
1336
1337                     // Ignore `for<'a> type: ...` as they can change what
1338                     // lifetimes mean (although we could "just" handle it).
1339                     if !data.bound_generic_params.is_empty() {
1340                         continue;
1341                     }
1342
1343                     let res = match data.bounded_ty.node {
1344                         hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) => path.res,
1345                         _ => continue,
1346                     };
1347
1348                     if res == Res::Def(DefKind::TyParam, param_def_id) {
1349                         add_bounds(&mut set, &data.bounds);
1350                     }
1351                 }
1352
1353                 Some(match set {
1354                     Set1::Empty => Set1::Empty,
1355                     Set1::One(name) => {
1356                         if name == hir::LifetimeName::Static {
1357                             Set1::One(Region::Static)
1358                         } else {
1359                             generics
1360                                 .params
1361                                 .iter()
1362                                 .filter_map(|param| match param.kind {
1363                                     GenericParamKind::Lifetime { .. } => Some((
1364                                         param.hir_id,
1365                                         hir::LifetimeName::Param(param.name),
1366                                         LifetimeDefOrigin::from_param(param),
1367                                     )),
1368                                     _ => None,
1369                                 })
1370                                 .enumerate()
1371                                 .find(|&(_, (_, lt_name, _))| lt_name == name)
1372                                 .map_or(Set1::Many, |(i, (id, _, origin))| {
1373                                     let def_id = tcx.hir().local_def_id_from_hir_id(id);
1374                                     Set1::One(Region::EarlyBound(i as u32, def_id, origin))
1375                                 })
1376                         }
1377                     }
1378                     Set1::Many => Set1::Many,
1379                 })
1380             }
1381             GenericParamKind::Const { .. } => {
1382                 // Generic consts don't impose any constraints.
1383                 None
1384             }
1385         })
1386         .collect()
1387 }
1388
1389 impl<'a, 'tcx> LifetimeContext<'a, 'tcx> {
1390     // FIXME(#37666) this works around a limitation in the region inferencer
1391     fn hack<F>(&mut self, f: F)
1392     where
1393         F: for<'b> FnOnce(&mut LifetimeContext<'b, 'tcx>),
1394     {
1395         f(self)
1396     }
1397
1398     fn with<F>(&mut self, wrap_scope: Scope<'_>, f: F)
1399     where
1400         F: for<'b> FnOnce(ScopeRef<'_>, &mut LifetimeContext<'b, 'tcx>),
1401     {
1402         let LifetimeContext {
1403             tcx,
1404             map,
1405             lifetime_uses,
1406             ..
1407         } = self;
1408         let labels_in_fn = take(&mut self.labels_in_fn);
1409         let xcrate_object_lifetime_defaults = take(&mut self.xcrate_object_lifetime_defaults);
1410         let mut this = LifetimeContext {
1411             tcx: *tcx,
1412             map: map,
1413             scope: &wrap_scope,
1414             trait_ref_hack: self.trait_ref_hack,
1415             is_in_fn_syntax: self.is_in_fn_syntax,
1416             labels_in_fn,
1417             xcrate_object_lifetime_defaults,
1418             lifetime_uses: lifetime_uses,
1419         };
1420         debug!("entering scope {:?}", this.scope);
1421         f(self.scope, &mut this);
1422         this.check_uses_for_lifetimes_defined_by_scope();
1423         debug!("exiting scope {:?}", this.scope);
1424         self.labels_in_fn = this.labels_in_fn;
1425         self.xcrate_object_lifetime_defaults = this.xcrate_object_lifetime_defaults;
1426     }
1427
1428     /// helper method to determine the span to remove when suggesting the
1429     /// deletion of a lifetime
1430     fn lifetime_deletion_span(&self, name: ast::Ident, generics: &hir::Generics) -> Option<Span> {
1431         generics.params.iter().enumerate().find_map(|(i, param)| {
1432             if param.name.ident() == name {
1433                 let mut in_band = false;
1434                 if let hir::GenericParamKind::Lifetime { kind } = param.kind {
1435                     if let hir::LifetimeParamKind::InBand = kind {
1436                         in_band = true;
1437                     }
1438                 }
1439                 if in_band {
1440                     Some(param.span)
1441                 } else {
1442                     if generics.params.len() == 1 {
1443                         // if sole lifetime, remove the entire `<>` brackets
1444                         Some(generics.span)
1445                     } else {
1446                         // if removing within `<>` brackets, we also want to
1447                         // delete a leading or trailing comma as appropriate
1448                         if i >= generics.params.len() - 1 {
1449                             Some(generics.params[i - 1].span.shrink_to_hi().to(param.span))
1450                         } else {
1451                             Some(param.span.to(generics.params[i + 1].span.shrink_to_lo()))
1452                         }
1453                     }
1454                 }
1455             } else {
1456                 None
1457             }
1458         })
1459     }
1460
1461     // helper method to issue suggestions from `fn rah<'a>(&'a T)` to `fn rah(&T)`
1462     fn suggest_eliding_single_use_lifetime(
1463         &self, err: &mut DiagnosticBuilder<'_>, def_id: DefId, lifetime: &hir::Lifetime
1464     ) {
1465         // FIXME: future work: also suggest `impl Foo<'_>` for `impl<'a> Foo<'a>`
1466         let name = lifetime.name.ident();
1467         let mut remove_decl = None;
1468         if let Some(parent_def_id) = self.tcx.parent(def_id) {
1469             if let Some(generics) = self.tcx.hir().get_generics(parent_def_id) {
1470                 remove_decl = self.lifetime_deletion_span(name, generics);
1471             }
1472         }
1473
1474         let mut remove_use = None;
1475         let mut find_arg_use_span = |inputs: &hir::HirVec<hir::Ty>| {
1476             for input in inputs {
1477                 if let hir::TyKind::Rptr(lt, _) = input.node {
1478                     if lt.name.ident() == name {
1479                         // include the trailing whitespace between the ampersand and the type name
1480                         let lt_through_ty_span = lifetime.span.to(input.span.shrink_to_hi());
1481                         remove_use = Some(
1482                             self.tcx.sess.source_map()
1483                                 .span_until_non_whitespace(lt_through_ty_span)
1484                         );
1485                         break;
1486                     }
1487                 }
1488             }
1489         };
1490         if let Node::Lifetime(hir_lifetime) = self.tcx.hir().get(lifetime.hir_id) {
1491             if let Some(parent) = self.tcx.hir().find(
1492                 self.tcx.hir().get_parent_item(hir_lifetime.hir_id))
1493             {
1494                 match parent {
1495                     Node::Item(item) => {
1496                         if let hir::ItemKind::Fn(decl, _, _, _) = &item.node {
1497                             find_arg_use_span(&decl.inputs);
1498                         }
1499                     },
1500                     Node::ImplItem(impl_item) => {
1501                         if let hir::ImplItemKind::Method(sig, _) = &impl_item.node {
1502                             find_arg_use_span(&sig.decl.inputs);
1503                         }
1504                     }
1505                     _ => {}
1506                 }
1507             }
1508         }
1509
1510         if let (Some(decl_span), Some(use_span)) = (remove_decl, remove_use) {
1511             // if both declaration and use deletion spans start at the same
1512             // place ("start at" because the latter includes trailing
1513             // whitespace), then this is an in-band lifetime
1514             if decl_span.shrink_to_lo() == use_span.shrink_to_lo() {
1515                 err.span_suggestion(
1516                     use_span,
1517                     "elide the single-use lifetime",
1518                     String::new(),
1519                     Applicability::MachineApplicable,
1520                 );
1521             } else {
1522                 err.multipart_suggestion(
1523                     "elide the single-use lifetime",
1524                     vec![(decl_span, String::new()), (use_span, String::new())],
1525                     Applicability::MachineApplicable,
1526                 );
1527             }
1528         }
1529     }
1530
1531     fn check_uses_for_lifetimes_defined_by_scope(&mut self) {
1532         let defined_by = match self.scope {
1533             Scope::Binder { lifetimes, .. } => lifetimes,
1534             _ => {
1535                 debug!("check_uses_for_lifetimes_defined_by_scope: not in a binder scope");
1536                 return;
1537             }
1538         };
1539
1540         let mut def_ids: Vec<_> = defined_by
1541             .values()
1542             .flat_map(|region| match region {
1543                 Region::EarlyBound(_, def_id, _)
1544                 | Region::LateBound(_, def_id, _)
1545                 | Region::Free(_, def_id) => Some(*def_id),
1546
1547                 Region::LateBoundAnon(..) | Region::Static => None,
1548             })
1549             .collect();
1550
1551         // ensure that we issue lints in a repeatable order
1552         def_ids.sort_by_cached_key(|&def_id| self.tcx.def_path_hash(def_id));
1553
1554         for def_id in def_ids {
1555             debug!(
1556                 "check_uses_for_lifetimes_defined_by_scope: def_id = {:?}",
1557                 def_id
1558             );
1559
1560             let lifetimeuseset = self.lifetime_uses.remove(&def_id);
1561
1562             debug!(
1563                 "check_uses_for_lifetimes_defined_by_scope: lifetimeuseset = {:?}",
1564                 lifetimeuseset
1565             );
1566
1567             match lifetimeuseset {
1568                 Some(LifetimeUseSet::One(lifetime)) => {
1569                     let hir_id = self.tcx.hir().as_local_hir_id(def_id).unwrap();
1570                     debug!("hir id first={:?}", hir_id);
1571                     if let Some((id, span, name)) = match self.tcx.hir().get(hir_id) {
1572                         Node::Lifetime(hir_lifetime) => Some((
1573                             hir_lifetime.hir_id,
1574                             hir_lifetime.span,
1575                             hir_lifetime.name.ident(),
1576                         )),
1577                         Node::GenericParam(param) => {
1578                             Some((param.hir_id, param.span, param.name.ident()))
1579                         }
1580                         _ => None,
1581                     } {
1582                         debug!("id = {:?} span = {:?} name = {:?}", id, span, name);
1583
1584                         if name.name == kw::UnderscoreLifetime {
1585                             continue;
1586                         }
1587
1588                         if let Some(parent_def_id) = self.tcx.parent(def_id) {
1589                             if let Some(parent_hir_id) = self.tcx.hir()
1590                                 .as_local_hir_id(parent_def_id) {
1591                                     // lifetimes in `derive` expansions don't count (Issue #53738)
1592                                     if self.tcx.hir().attrs(parent_hir_id).iter()
1593                                         .any(|attr| attr.check_name(sym::automatically_derived)) {
1594                                             continue;
1595                                         }
1596                                 }
1597                         }
1598
1599                         let mut err = self.tcx.struct_span_lint_hir(
1600                             lint::builtin::SINGLE_USE_LIFETIMES,
1601                             id,
1602                             span,
1603                             &format!("lifetime parameter `{}` only used once", name),
1604                         );
1605
1606                         if span == lifetime.span {
1607                             // spans are the same for in-band lifetime declarations
1608                             err.span_label(span, "this lifetime is only used here");
1609                         } else {
1610                             err.span_label(span, "this lifetime...");
1611                             err.span_label(lifetime.span, "...is used only here");
1612                         }
1613                         self.suggest_eliding_single_use_lifetime(&mut err, def_id, lifetime);
1614                         err.emit();
1615                     }
1616                 }
1617                 Some(LifetimeUseSet::Many) => {
1618                     debug!("Not one use lifetime");
1619                 }
1620                 None => {
1621                     let hir_id = self.tcx.hir().as_local_hir_id(def_id).unwrap();
1622                     if let Some((id, span, name)) = match self.tcx.hir().get(hir_id) {
1623                         Node::Lifetime(hir_lifetime) => Some((
1624                             hir_lifetime.hir_id,
1625                             hir_lifetime.span,
1626                             hir_lifetime.name.ident(),
1627                         )),
1628                         Node::GenericParam(param) => {
1629                             Some((param.hir_id, param.span, param.name.ident()))
1630                         }
1631                         _ => None,
1632                     } {
1633                         debug!("id ={:?} span = {:?} name = {:?}", id, span, name);
1634                         let mut err = self.tcx.struct_span_lint_hir(
1635                             lint::builtin::UNUSED_LIFETIMES,
1636                             id,
1637                             span,
1638                             &format!("lifetime parameter `{}` never used", name),
1639                         );
1640                         if let Some(parent_def_id) = self.tcx.parent(def_id) {
1641                             if let Some(generics) = self.tcx.hir().get_generics(parent_def_id) {
1642                                 let unused_lt_span = self.lifetime_deletion_span(name, generics);
1643                                 if let Some(span) = unused_lt_span {
1644                                     err.span_suggestion(
1645                                         span,
1646                                         "elide the unused lifetime",
1647                                         String::new(),
1648                                         Applicability::MachineApplicable,
1649                                     );
1650                                 }
1651                             }
1652                         }
1653                         err.emit();
1654                     }
1655                 }
1656             }
1657         }
1658     }
1659
1660     /// Visits self by adding a scope and handling recursive walk over the contents with `walk`.
1661     ///
1662     /// Handles visiting fns and methods. These are a bit complicated because we must distinguish
1663     /// early- vs late-bound lifetime parameters. We do this by checking which lifetimes appear
1664     /// within type bounds; those are early bound lifetimes, and the rest are late bound.
1665     ///
1666     /// For example:
1667     ///
1668     ///    fn foo<'a,'b,'c,T:Trait<'b>>(...)
1669     ///
1670     /// Here `'a` and `'c` are late bound but `'b` is early bound. Note that early- and late-bound
1671     /// lifetimes may be interspersed together.
1672     ///
1673     /// If early bound lifetimes are present, we separate them into their own list (and likewise
1674     /// for late bound). They will be numbered sequentially, starting from the lowest index that is
1675     /// already in scope (for a fn item, that will be 0, but for a method it might not be). Late
1676     /// bound lifetimes are resolved by name and associated with a binder ID (`binder_id`), so the
1677     /// ordering is not important there.
1678     fn visit_early_late<F>(
1679         &mut self,
1680         parent_id: Option<hir::HirId>,
1681         decl: &'tcx hir::FnDecl,
1682         generics: &'tcx hir::Generics,
1683         walk: F,
1684     ) where
1685         F: for<'b, 'c> FnOnce(&'b mut LifetimeContext<'c, 'tcx>),
1686     {
1687         insert_late_bound_lifetimes(self.map, decl, generics);
1688
1689         // Find the start of nested early scopes, e.g., in methods.
1690         let mut index = 0;
1691         if let Some(parent_id) = parent_id {
1692             let parent = self.tcx.hir().expect_item(parent_id);
1693             if sub_items_have_self_param(&parent.node) {
1694                 index += 1; // Self comes before lifetimes
1695             }
1696             match parent.node {
1697                 hir::ItemKind::Trait(_, _, ref generics, ..)
1698                 | hir::ItemKind::Impl(_, _, _, ref generics, ..) => {
1699                     index += generics.params.len() as u32;
1700                 }
1701                 _ => {}
1702             }
1703         }
1704
1705         let mut non_lifetime_count = 0;
1706         let lifetimes = generics.params.iter().filter_map(|param| match param.kind {
1707             GenericParamKind::Lifetime { .. } => {
1708                 if self.map.late_bound.contains(&param.hir_id) {
1709                     Some(Region::late(&self.tcx.hir(), param))
1710                 } else {
1711                     Some(Region::early(&self.tcx.hir(), &mut index, param))
1712                 }
1713             }
1714             GenericParamKind::Type { .. } |
1715             GenericParamKind::Const { .. } => {
1716                 non_lifetime_count += 1;
1717                 None
1718             }
1719         }).collect();
1720         let next_early_index = index + non_lifetime_count;
1721
1722         let scope = Scope::Binder {
1723             lifetimes,
1724             next_early_index,
1725             s: self.scope,
1726             abstract_type_parent: true,
1727             track_lifetime_uses: false,
1728         };
1729         self.with(scope, move |old_scope, this| {
1730             this.check_lifetime_params(old_scope, &generics.params);
1731             this.hack(walk); // FIXME(#37666) workaround in place of `walk(this)`
1732         });
1733     }
1734
1735     fn next_early_index_helper(&self, only_abstract_type_parent: bool) -> u32 {
1736         let mut scope = self.scope;
1737         loop {
1738             match *scope {
1739                 Scope::Root => return 0,
1740
1741                 Scope::Binder {
1742                     next_early_index,
1743                     abstract_type_parent,
1744                     ..
1745                 } if (!only_abstract_type_parent || abstract_type_parent) =>
1746                 {
1747                     return next_early_index
1748                 }
1749
1750                 Scope::Binder { s, .. }
1751                 | Scope::Body { s, .. }
1752                 | Scope::Elision { s, .. }
1753                 | Scope::ObjectLifetimeDefault { s, .. } => scope = s,
1754             }
1755         }
1756     }
1757
1758     /// Returns the next index one would use for an early-bound-region
1759     /// if extending the current scope.
1760     fn next_early_index(&self) -> u32 {
1761         self.next_early_index_helper(true)
1762     }
1763
1764     /// Returns the next index one would use for an `impl Trait` that
1765     /// is being converted into an `abstract type`. This will be the
1766     /// next early index from the enclosing item, for the most
1767     /// part. See the `abstract_type_parent` field for more info.
1768     fn next_early_index_for_abstract_type(&self) -> u32 {
1769         self.next_early_index_helper(false)
1770     }
1771
1772     fn resolve_lifetime_ref(&mut self, lifetime_ref: &'tcx hir::Lifetime) {
1773         debug!("resolve_lifetime_ref(lifetime_ref={:?})", lifetime_ref);
1774
1775         // If we've already reported an error, just ignore `lifetime_ref`.
1776         if let LifetimeName::Error = lifetime_ref.name {
1777             return;
1778         }
1779
1780         // Walk up the scope chain, tracking the number of fn scopes
1781         // that we pass through, until we find a lifetime with the
1782         // given name or we run out of scopes.
1783         // search.
1784         let mut late_depth = 0;
1785         let mut scope = self.scope;
1786         let mut outermost_body = None;
1787         let result = loop {
1788             match *scope {
1789                 Scope::Body { id, s } => {
1790                     outermost_body = Some(id);
1791                     scope = s;
1792                 }
1793
1794                 Scope::Root => {
1795                     break None;
1796                 }
1797
1798                 Scope::Binder {
1799                     ref lifetimes, s, ..
1800                 } => {
1801                     match lifetime_ref.name {
1802                         LifetimeName::Param(param_name) => {
1803                             if let Some(&def) = lifetimes.get(&param_name.modern()) {
1804                                 break Some(def.shifted(late_depth));
1805                             }
1806                         }
1807                         _ => bug!("expected LifetimeName::Param"),
1808                     }
1809
1810                     late_depth += 1;
1811                     scope = s;
1812                 }
1813
1814                 Scope::Elision { s, .. } | Scope::ObjectLifetimeDefault { s, .. } => {
1815                     scope = s;
1816                 }
1817             }
1818         };
1819
1820         if let Some(mut def) = result {
1821             if let Region::EarlyBound(..) = def {
1822                 // Do not free early-bound regions, only late-bound ones.
1823             } else if let Some(body_id) = outermost_body {
1824                 let fn_id = self.tcx.hir().body_owner(body_id);
1825                 match self.tcx.hir().get(fn_id) {
1826                     Node::Item(&hir::Item {
1827                         node: hir::ItemKind::Fn(..),
1828                         ..
1829                     })
1830                     | Node::TraitItem(&hir::TraitItem {
1831                         node: hir::TraitItemKind::Method(..),
1832                         ..
1833                     })
1834                     | Node::ImplItem(&hir::ImplItem {
1835                         node: hir::ImplItemKind::Method(..),
1836                         ..
1837                     }) => {
1838                         let scope = self.tcx.hir().local_def_id_from_hir_id(fn_id);
1839                         def = Region::Free(scope, def.id().unwrap());
1840                     }
1841                     _ => {}
1842                 }
1843             }
1844
1845             // Check for fn-syntax conflicts with in-band lifetime definitions
1846             if self.is_in_fn_syntax {
1847                 match def {
1848                     Region::EarlyBound(_, _, LifetimeDefOrigin::InBand)
1849                     | Region::LateBound(_, _, LifetimeDefOrigin::InBand) => {
1850                         struct_span_err!(
1851                             self.tcx.sess,
1852                             lifetime_ref.span,
1853                             E0687,
1854                             "lifetimes used in `fn` or `Fn` syntax must be \
1855                              explicitly declared using `<...>` binders"
1856                         ).span_label(lifetime_ref.span, "in-band lifetime definition")
1857                             .emit();
1858                     }
1859
1860                     Region::Static
1861                     | Region::EarlyBound(_, _, LifetimeDefOrigin::ExplicitOrElided)
1862                     | Region::LateBound(_, _, LifetimeDefOrigin::ExplicitOrElided)
1863                     | Region::EarlyBound(_, _, LifetimeDefOrigin::Error)
1864                     | Region::LateBound(_, _, LifetimeDefOrigin::Error)
1865                     | Region::LateBoundAnon(..)
1866                     | Region::Free(..) => {}
1867                 }
1868             }
1869
1870             self.insert_lifetime(lifetime_ref, def);
1871         } else {
1872             struct_span_err!(
1873                 self.tcx.sess,
1874                 lifetime_ref.span,
1875                 E0261,
1876                 "use of undeclared lifetime name `{}`",
1877                 lifetime_ref
1878             ).span_label(lifetime_ref.span, "undeclared lifetime")
1879                 .emit();
1880         }
1881     }
1882
1883     fn visit_segment_args(&mut self, res: Res, depth: usize, generic_args: &'tcx hir::GenericArgs) {
1884         if generic_args.parenthesized {
1885             let was_in_fn_syntax = self.is_in_fn_syntax;
1886             self.is_in_fn_syntax = true;
1887             self.visit_fn_like_elision(generic_args.inputs(), Some(generic_args.bindings[0].ty()));
1888             self.is_in_fn_syntax = was_in_fn_syntax;
1889             return;
1890         }
1891
1892         let mut elide_lifetimes = true;
1893         let lifetimes = generic_args
1894             .args
1895             .iter()
1896             .filter_map(|arg| match arg {
1897                 hir::GenericArg::Lifetime(lt) => {
1898                     if !lt.is_elided() {
1899                         elide_lifetimes = false;
1900                     }
1901                     Some(lt)
1902                 }
1903                 _ => None,
1904             })
1905             .collect();
1906         if elide_lifetimes {
1907             self.resolve_elided_lifetimes(lifetimes);
1908         } else {
1909             lifetimes.iter().for_each(|lt| self.visit_lifetime(lt));
1910         }
1911
1912         // Figure out if this is a type/trait segment,
1913         // which requires object lifetime defaults.
1914         let parent_def_id = |this: &mut Self, def_id: DefId| {
1915             let def_key = this.tcx.def_key(def_id);
1916             DefId {
1917                 krate: def_id.krate,
1918                 index: def_key.parent.expect("missing parent"),
1919             }
1920         };
1921         let type_def_id = match res {
1922             Res::Def(DefKind::AssocTy, def_id)
1923                 if depth == 1 => Some(parent_def_id(self, def_id)),
1924             Res::Def(DefKind::Variant, def_id)
1925                 if depth == 0 => Some(parent_def_id(self, def_id)),
1926             Res::Def(DefKind::Struct, def_id)
1927             | Res::Def(DefKind::Union, def_id)
1928             | Res::Def(DefKind::Enum, def_id)
1929             | Res::Def(DefKind::TyAlias, def_id)
1930             | Res::Def(DefKind::Trait, def_id) if depth == 0 =>
1931             {
1932                 Some(def_id)
1933             }
1934             _ => None,
1935         };
1936
1937         let object_lifetime_defaults = type_def_id.map_or(vec![], |def_id| {
1938             let in_body = {
1939                 let mut scope = self.scope;
1940                 loop {
1941                     match *scope {
1942                         Scope::Root => break false,
1943
1944                         Scope::Body { .. } => break true,
1945
1946                         Scope::Binder { s, .. }
1947                         | Scope::Elision { s, .. }
1948                         | Scope::ObjectLifetimeDefault { s, .. } => {
1949                             scope = s;
1950                         }
1951                     }
1952                 }
1953             };
1954
1955             let map = &self.map;
1956             let unsubst = if let Some(id) = self.tcx.hir().as_local_hir_id(def_id) {
1957                 &map.object_lifetime_defaults[&id]
1958             } else {
1959                 let tcx = self.tcx;
1960                 self.xcrate_object_lifetime_defaults
1961                     .entry(def_id)
1962                     .or_insert_with(|| {
1963                         tcx.generics_of(def_id)
1964                             .params
1965                             .iter()
1966                             .filter_map(|param| match param.kind {
1967                                 GenericParamDefKind::Type {
1968                                     object_lifetime_default,
1969                                     ..
1970                                 } => Some(object_lifetime_default),
1971                                 GenericParamDefKind::Lifetime | GenericParamDefKind::Const => None,
1972                             })
1973                             .collect()
1974                     })
1975             };
1976             unsubst
1977                 .iter()
1978                 .map(|set| match *set {
1979                     Set1::Empty => if in_body {
1980                         None
1981                     } else {
1982                         Some(Region::Static)
1983                     },
1984                     Set1::One(r) => {
1985                         let lifetimes = generic_args.args.iter().filter_map(|arg| match arg {
1986                             GenericArg::Lifetime(lt) => Some(lt),
1987                             _ => None,
1988                         });
1989                         r.subst(lifetimes, map)
1990                     }
1991                     Set1::Many => None,
1992                 })
1993                 .collect()
1994         });
1995
1996         let mut i = 0;
1997         for arg in &generic_args.args {
1998             match arg {
1999                 GenericArg::Lifetime(_) => {}
2000                 GenericArg::Type(ty) => {
2001                     if let Some(&lt) = object_lifetime_defaults.get(i) {
2002                         let scope = Scope::ObjectLifetimeDefault {
2003                             lifetime: lt,
2004                             s: self.scope,
2005                         };
2006                         self.with(scope, |_, this| this.visit_ty(ty));
2007                     } else {
2008                         self.visit_ty(ty);
2009                     }
2010                     i += 1;
2011                 }
2012                 GenericArg::Const(ct) => {
2013                     self.visit_anon_const(&ct.value);
2014                 }
2015             }
2016         }
2017
2018         for b in &generic_args.bindings {
2019             self.visit_assoc_type_binding(b);
2020         }
2021     }
2022
2023     fn visit_fn_like_elision(&mut self, inputs: &'tcx [hir::Ty], output: Option<&'tcx hir::Ty>) {
2024         debug!("visit_fn_like_elision: enter");
2025         let mut arg_elide = Elide::FreshLateAnon(Cell::new(0));
2026         let arg_scope = Scope::Elision {
2027             elide: arg_elide.clone(),
2028             s: self.scope,
2029         };
2030         self.with(arg_scope, |_, this| {
2031             for input in inputs {
2032                 this.visit_ty(input);
2033             }
2034             match *this.scope {
2035                 Scope::Elision { ref elide, .. } => {
2036                     arg_elide = elide.clone();
2037                 }
2038                 _ => bug!(),
2039             }
2040         });
2041
2042         let output = match output {
2043             Some(ty) => ty,
2044             None => return,
2045         };
2046
2047         debug!("visit_fn_like_elision: determine output");
2048
2049         // Figure out if there's a body we can get argument names from,
2050         // and whether there's a `self` argument (treated specially).
2051         let mut assoc_item_kind = None;
2052         let mut impl_self = None;
2053         let parent = self.tcx.hir().get_parent_node(output.hir_id);
2054         let body = match self.tcx.hir().get(parent) {
2055             // `fn` definitions and methods.
2056             Node::Item(&hir::Item {
2057                 node: hir::ItemKind::Fn(.., body),
2058                 ..
2059             }) => Some(body),
2060
2061             Node::TraitItem(&hir::TraitItem {
2062                 node: hir::TraitItemKind::Method(_, ref m),
2063                 ..
2064             }) => {
2065                 if let hir::ItemKind::Trait(.., ref trait_items) = self.tcx
2066                     .hir()
2067                     .expect_item(self.tcx.hir().get_parent_item(parent))
2068                     .node
2069                 {
2070                     assoc_item_kind = trait_items
2071                         .iter()
2072                         .find(|ti| ti.id.hir_id == parent)
2073                         .map(|ti| ti.kind);
2074                 }
2075                 match *m {
2076                     hir::TraitMethod::Required(_) => None,
2077                     hir::TraitMethod::Provided(body) => Some(body),
2078                 }
2079             }
2080
2081             Node::ImplItem(&hir::ImplItem {
2082                 node: hir::ImplItemKind::Method(_, body),
2083                 ..
2084             }) => {
2085                 if let hir::ItemKind::Impl(.., ref self_ty, ref impl_items) = self.tcx
2086                     .hir()
2087                     .expect_item(self.tcx.hir().get_parent_item(parent))
2088                     .node
2089                 {
2090                     impl_self = Some(self_ty);
2091                     assoc_item_kind = impl_items
2092                         .iter()
2093                         .find(|ii| ii.id.hir_id == parent)
2094                         .map(|ii| ii.kind);
2095                 }
2096                 Some(body)
2097             }
2098
2099             // Foreign functions, `fn(...) -> R` and `Trait(...) -> R` (both types and bounds).
2100             Node::ForeignItem(_) | Node::Ty(_) | Node::TraitRef(_) => None,
2101             // Everything else (only closures?) doesn't
2102             // actually enjoy elision in return types.
2103             _ => {
2104                 self.visit_ty(output);
2105                 return;
2106             }
2107         };
2108
2109         let has_self = match assoc_item_kind {
2110             Some(hir::AssocItemKind::Method { has_self }) => has_self,
2111             _ => false,
2112         };
2113
2114         // In accordance with the rules for lifetime elision, we can determine
2115         // what region to use for elision in the output type in two ways.
2116         // First (determined here), if `self` is by-reference, then the
2117         // implied output region is the region of the self parameter.
2118         if has_self {
2119             // Look for `self: &'a Self` - also desugared from `&'a self`,
2120             // and if that matches, use it for elision and return early.
2121             let is_self_ty = |res: Res| {
2122                 if let Res::SelfTy(..) = res {
2123                     return true;
2124                 }
2125
2126                 // Can't always rely on literal (or implied) `Self` due
2127                 // to the way elision rules were originally specified.
2128                 let impl_self = impl_self.map(|ty| &ty.node);
2129                 if let Some(&hir::TyKind::Path(hir::QPath::Resolved(None, ref path))) = impl_self {
2130                     match path.res {
2131                         // Whitelist the types that unambiguously always
2132                         // result in the same type constructor being used
2133                         // (it can't differ between `Self` and `self`).
2134                         Res::Def(DefKind::Struct, _)
2135                         | Res::Def(DefKind::Union, _)
2136                         | Res::Def(DefKind::Enum, _)
2137                         | Res::PrimTy(_) => {
2138                             return res == path.res
2139                         }
2140                         _ => {}
2141                     }
2142                 }
2143
2144                 false
2145             };
2146
2147             if let hir::TyKind::Rptr(lifetime_ref, ref mt) = inputs[0].node {
2148                 if let hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) = mt.ty.node {
2149                     if is_self_ty(path.res) {
2150                         if let Some(&lifetime) = self.map.defs.get(&lifetime_ref.hir_id) {
2151                             let scope = Scope::Elision {
2152                                 elide: Elide::Exact(lifetime),
2153                                 s: self.scope,
2154                             };
2155                             self.with(scope, |_, this| this.visit_ty(output));
2156                             return;
2157                         }
2158                     }
2159                 }
2160             }
2161         }
2162
2163         // Second, if there was exactly one lifetime (either a substitution or a
2164         // reference) in the arguments, then any anonymous regions in the output
2165         // have that lifetime.
2166         let mut possible_implied_output_region = None;
2167         let mut lifetime_count = 0;
2168         let arg_lifetimes = inputs
2169             .iter()
2170             .enumerate()
2171             .skip(has_self as usize)
2172             .map(|(i, input)| {
2173                 let mut gather = GatherLifetimes {
2174                     map: self.map,
2175                     outer_index: ty::INNERMOST,
2176                     have_bound_regions: false,
2177                     lifetimes: Default::default(),
2178                 };
2179                 gather.visit_ty(input);
2180
2181                 lifetime_count += gather.lifetimes.len();
2182
2183                 if lifetime_count == 1 && gather.lifetimes.len() == 1 {
2184                     // there's a chance that the unique lifetime of this
2185                     // iteration will be the appropriate lifetime for output
2186                     // parameters, so lets store it.
2187                     possible_implied_output_region = gather.lifetimes.iter().cloned().next();
2188                 }
2189
2190                 ElisionFailureInfo {
2191                     parent: body,
2192                     index: i,
2193                     lifetime_count: gather.lifetimes.len(),
2194                     have_bound_regions: gather.have_bound_regions,
2195                 }
2196             })
2197             .collect();
2198
2199         let elide = if lifetime_count == 1 {
2200             Elide::Exact(possible_implied_output_region.unwrap())
2201         } else {
2202             Elide::Error(arg_lifetimes)
2203         };
2204
2205         debug!("visit_fn_like_elision: elide={:?}", elide);
2206
2207         let scope = Scope::Elision {
2208             elide,
2209             s: self.scope,
2210         };
2211         self.with(scope, |_, this| this.visit_ty(output));
2212         debug!("visit_fn_like_elision: exit");
2213
2214         struct GatherLifetimes<'a> {
2215             map: &'a NamedRegionMap,
2216             outer_index: ty::DebruijnIndex,
2217             have_bound_regions: bool,
2218             lifetimes: FxHashSet<Region>,
2219         }
2220
2221         impl<'v, 'a> Visitor<'v> for GatherLifetimes<'a> {
2222             fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'v> {
2223                 NestedVisitorMap::None
2224             }
2225
2226             fn visit_ty(&mut self, ty: &hir::Ty) {
2227                 if let hir::TyKind::BareFn(_) = ty.node {
2228                     self.outer_index.shift_in(1);
2229                 }
2230                 match ty.node {
2231                     hir::TyKind::TraitObject(ref bounds, ref lifetime) => {
2232                         for bound in bounds {
2233                             self.visit_poly_trait_ref(bound, hir::TraitBoundModifier::None);
2234                         }
2235
2236                         // Stay on the safe side and don't include the object
2237                         // lifetime default (which may not end up being used).
2238                         if !lifetime.is_elided() {
2239                             self.visit_lifetime(lifetime);
2240                         }
2241                     }
2242                     hir::TyKind::CVarArgs(_) => {}
2243                     _ => {
2244                         intravisit::walk_ty(self, ty);
2245                     }
2246                 }
2247                 if let hir::TyKind::BareFn(_) = ty.node {
2248                     self.outer_index.shift_out(1);
2249                 }
2250             }
2251
2252             fn visit_generic_param(&mut self, param: &hir::GenericParam) {
2253                 if let hir::GenericParamKind::Lifetime { .. } = param.kind {
2254                     // FIXME(eddyb) Do we want this? It only makes a difference
2255                     // if this `for<'a>` lifetime parameter is never used.
2256                     self.have_bound_regions = true;
2257                 }
2258
2259                 intravisit::walk_generic_param(self, param);
2260             }
2261
2262             fn visit_poly_trait_ref(
2263                 &mut self,
2264                 trait_ref: &hir::PolyTraitRef,
2265                 modifier: hir::TraitBoundModifier,
2266             ) {
2267                 self.outer_index.shift_in(1);
2268                 intravisit::walk_poly_trait_ref(self, trait_ref, modifier);
2269                 self.outer_index.shift_out(1);
2270             }
2271
2272             fn visit_lifetime(&mut self, lifetime_ref: &hir::Lifetime) {
2273                 if let Some(&lifetime) = self.map.defs.get(&lifetime_ref.hir_id) {
2274                     match lifetime {
2275                         Region::LateBound(debruijn, _, _) | Region::LateBoundAnon(debruijn, _)
2276                             if debruijn < self.outer_index =>
2277                         {
2278                             self.have_bound_regions = true;
2279                         }
2280                         _ => {
2281                             self.lifetimes
2282                                 .insert(lifetime.shifted_out_to_binder(self.outer_index));
2283                         }
2284                     }
2285                 }
2286             }
2287         }
2288     }
2289
2290     fn resolve_elided_lifetimes(&mut self, lifetime_refs: Vec<&'tcx hir::Lifetime>) {
2291         if lifetime_refs.is_empty() {
2292             return;
2293         }
2294
2295         let span = lifetime_refs[0].span;
2296         let mut late_depth = 0;
2297         let mut scope = self.scope;
2298         let mut lifetime_names = FxHashSet::default();
2299         let error = loop {
2300             match *scope {
2301                 // Do not assign any resolution, it will be inferred.
2302                 Scope::Body { .. } => return,
2303
2304                 Scope::Root => break None,
2305
2306                 Scope::Binder { s, ref lifetimes, .. } => {
2307                     // collect named lifetimes for suggestions
2308                     for name in lifetimes.keys() {
2309                         if let hir::ParamName::Plain(name) = name {
2310                             lifetime_names.insert(*name);
2311                         }
2312                     }
2313                     late_depth += 1;
2314                     scope = s;
2315                 }
2316
2317                 Scope::Elision { ref elide, ref s, .. } => {
2318                     let lifetime = match *elide {
2319                         Elide::FreshLateAnon(ref counter) => {
2320                             for lifetime_ref in lifetime_refs {
2321                                 let lifetime = Region::late_anon(counter).shifted(late_depth);
2322                                 self.insert_lifetime(lifetime_ref, lifetime);
2323                             }
2324                             return;
2325                         }
2326                         Elide::Exact(l) => l.shifted(late_depth),
2327                         Elide::Error(ref e) => {
2328                             if let Scope::Binder { ref lifetimes, .. } = s {
2329                                 // collect named lifetimes for suggestions
2330                                 for name in lifetimes.keys() {
2331                                     if let hir::ParamName::Plain(name) = name {
2332                                         lifetime_names.insert(*name);
2333                                     }
2334                                 }
2335                             }
2336                             break Some(e);
2337                         }
2338                     };
2339                     for lifetime_ref in lifetime_refs {
2340                         self.insert_lifetime(lifetime_ref, lifetime);
2341                     }
2342                     return;
2343                 }
2344
2345                 Scope::ObjectLifetimeDefault { s, .. } => {
2346                     scope = s;
2347                 }
2348             }
2349         };
2350
2351         let mut err = report_missing_lifetime_specifiers(self.tcx.sess, span, lifetime_refs.len());
2352         let mut add_label = true;
2353
2354         if let Some(params) = error {
2355             if lifetime_refs.len() == 1 {
2356                 add_label = add_label && self.report_elision_failure(&mut err, params, span);
2357             }
2358         }
2359         if add_label {
2360             add_missing_lifetime_specifiers_label(
2361                 &mut err,
2362                 span,
2363                 lifetime_refs.len(),
2364                 &lifetime_names,
2365                 self.tcx.sess.source_map().span_to_snippet(span).ok().as_ref().map(|s| s.as_str()),
2366             );
2367         }
2368
2369         err.emit();
2370     }
2371
2372     fn suggest_lifetime(&self, db: &mut DiagnosticBuilder<'_>, span: Span, msg: &str) -> bool {
2373         match self.tcx.sess.source_map().span_to_snippet(span) {
2374             Ok(ref snippet) => {
2375                 let (sugg, applicability) = if snippet == "&" {
2376                     ("&'static ".to_owned(), Applicability::MachineApplicable)
2377                 } else if snippet == "'_" {
2378                     ("'static".to_owned(), Applicability::MachineApplicable)
2379                 } else {
2380                     (format!("{} + 'static", snippet), Applicability::MaybeIncorrect)
2381                 };
2382                 db.span_suggestion(span, msg, sugg, applicability);
2383                 false
2384             }
2385             Err(_) => {
2386                 db.help(msg);
2387                 true
2388             }
2389         }
2390     }
2391
2392     fn report_elision_failure(
2393         &mut self,
2394         db: &mut DiagnosticBuilder<'_>,
2395         params: &[ElisionFailureInfo],
2396         span: Span,
2397     ) -> bool {
2398         let mut m = String::new();
2399         let len = params.len();
2400
2401         let elided_params: Vec<_> = params
2402             .iter()
2403             .cloned()
2404             .filter(|info| info.lifetime_count > 0)
2405             .collect();
2406
2407         let elided_len = elided_params.len();
2408
2409         for (i, info) in elided_params.into_iter().enumerate() {
2410             let ElisionFailureInfo {
2411                 parent,
2412                 index,
2413                 lifetime_count: n,
2414                 have_bound_regions,
2415             } = info;
2416
2417             let help_name = if let Some(ident) = parent.and_then(|body| {
2418                 self.tcx.hir().body(body).arguments[index].pat.simple_ident()
2419             }) {
2420                 format!("`{}`", ident)
2421             } else {
2422                 format!("argument {}", index + 1)
2423             };
2424
2425             m.push_str(
2426                 &(if n == 1 {
2427                     help_name
2428                 } else {
2429                     format!(
2430                         "one of {}'s {} {}lifetimes",
2431                         help_name,
2432                         n,
2433                         if have_bound_regions { "free " } else { "" }
2434                     )
2435                 })[..],
2436             );
2437
2438             if elided_len == 2 && i == 0 {
2439                 m.push_str(" or ");
2440             } else if i + 2 == elided_len {
2441                 m.push_str(", or ");
2442             } else if i != elided_len - 1 {
2443                 m.push_str(", ");
2444             }
2445         }
2446
2447         if len == 0 {
2448             help!(
2449                 db,
2450                 "this function's return type contains a borrowed value, but \
2451                  there is no value for it to be borrowed from"
2452             );
2453             self.suggest_lifetime(db, span, "consider giving it a 'static lifetime")
2454         } else if elided_len == 0 {
2455             help!(
2456                 db,
2457                 "this function's return type contains a borrowed value with \
2458                  an elided lifetime, but the lifetime cannot be derived from \
2459                  the arguments"
2460             );
2461             let msg = "consider giving it an explicit bounded or 'static lifetime";
2462             self.suggest_lifetime(db, span, msg)
2463         } else if elided_len == 1 {
2464             help!(
2465                 db,
2466                 "this function's return type contains a borrowed value, but \
2467                  the signature does not say which {} it is borrowed from",
2468                 m
2469             );
2470             true
2471         } else {
2472             help!(
2473                 db,
2474                 "this function's return type contains a borrowed value, but \
2475                  the signature does not say whether it is borrowed from {}",
2476                 m
2477             );
2478             true
2479         }
2480     }
2481
2482     fn resolve_object_lifetime_default(&mut self, lifetime_ref: &'tcx hir::Lifetime) {
2483         let mut late_depth = 0;
2484         let mut scope = self.scope;
2485         let lifetime = loop {
2486             match *scope {
2487                 Scope::Binder { s, .. } => {
2488                     late_depth += 1;
2489                     scope = s;
2490                 }
2491
2492                 Scope::Root | Scope::Elision { .. } => break Region::Static,
2493
2494                 Scope::Body { .. } | Scope::ObjectLifetimeDefault { lifetime: None, .. } => return,
2495
2496                 Scope::ObjectLifetimeDefault {
2497                     lifetime: Some(l), ..
2498                 } => break l,
2499             }
2500         };
2501         self.insert_lifetime(lifetime_ref, lifetime.shifted(late_depth));
2502     }
2503
2504     fn check_lifetime_params(
2505         &mut self,
2506         old_scope: ScopeRef<'_>,
2507         params: &'tcx [hir::GenericParam],
2508     ) {
2509         let lifetimes: Vec<_> = params
2510             .iter()
2511             .filter_map(|param| match param.kind {
2512                 GenericParamKind::Lifetime { .. } => Some((param, param.name)),
2513                 _ => None,
2514             })
2515             .collect();
2516         for (i, (lifetime_i, lifetime_i_name)) in lifetimes.iter().enumerate() {
2517             if let hir::ParamName::Plain(_) = lifetime_i_name {
2518                 let name = lifetime_i_name.ident().name;
2519                 if name == kw::UnderscoreLifetime
2520                     || name == kw::StaticLifetime
2521                 {
2522                     let mut err = struct_span_err!(
2523                         self.tcx.sess,
2524                         lifetime_i.span,
2525                         E0262,
2526                         "invalid lifetime parameter name: `{}`",
2527                         lifetime_i.name.ident(),
2528                     );
2529                     err.span_label(
2530                         lifetime_i.span,
2531                         format!("{} is a reserved lifetime name", name),
2532                     );
2533                     err.emit();
2534                 }
2535             }
2536
2537             // It is a hard error to shadow a lifetime within the same scope.
2538             for (lifetime_j, lifetime_j_name) in lifetimes.iter().skip(i + 1) {
2539                 if lifetime_i_name == lifetime_j_name {
2540                     struct_span_err!(
2541                         self.tcx.sess,
2542                         lifetime_j.span,
2543                         E0263,
2544                         "lifetime name `{}` declared twice in the same scope",
2545                         lifetime_j.name.ident()
2546                     ).span_label(lifetime_j.span, "declared twice")
2547                         .span_label(lifetime_i.span, "previous declaration here")
2548                         .emit();
2549                 }
2550             }
2551
2552             // It is a soft error to shadow a lifetime within a parent scope.
2553             self.check_lifetime_param_for_shadowing(old_scope, &lifetime_i);
2554
2555             for bound in &lifetime_i.bounds {
2556                 match bound {
2557                     hir::GenericBound::Outlives(lt) => match lt.name {
2558                         hir::LifetimeName::Underscore => self.tcx.sess.delay_span_bug(
2559                             lt.span,
2560                             "use of `'_` in illegal place, but not caught by lowering",
2561                         ),
2562                         hir::LifetimeName::Static => {
2563                             self.insert_lifetime(lt, Region::Static);
2564                             self.tcx
2565                                 .sess
2566                                 .struct_span_warn(
2567                                     lifetime_i.span.to(lt.span),
2568                                     &format!(
2569                                         "unnecessary lifetime parameter `{}`",
2570                                         lifetime_i.name.ident(),
2571                                     ),
2572                                 )
2573                                 .help(&format!(
2574                                     "you can use the `'static` lifetime directly, in place of `{}`",
2575                                     lifetime_i.name.ident(),
2576                                 ))
2577                                 .emit();
2578                         }
2579                         hir::LifetimeName::Param(_) | hir::LifetimeName::Implicit => {
2580                             self.resolve_lifetime_ref(lt);
2581                         }
2582                         hir::LifetimeName::Error => {
2583                             // No need to do anything, error already reported.
2584                         }
2585                     },
2586                     _ => bug!(),
2587                 }
2588             }
2589         }
2590     }
2591
2592     fn check_lifetime_param_for_shadowing(
2593         &self,
2594         mut old_scope: ScopeRef<'_>,
2595         param: &'tcx hir::GenericParam,
2596     ) {
2597         for label in &self.labels_in_fn {
2598             // FIXME (#24278): non-hygienic comparison
2599             if param.name.ident().name == label.name {
2600                 signal_shadowing_problem(
2601                     self.tcx,
2602                     label.name,
2603                     original_label(label.span),
2604                     shadower_lifetime(&param),
2605                 );
2606                 return;
2607             }
2608         }
2609
2610         loop {
2611             match *old_scope {
2612                 Scope::Body { s, .. }
2613                 | Scope::Elision { s, .. }
2614                 | Scope::ObjectLifetimeDefault { s, .. } => {
2615                     old_scope = s;
2616                 }
2617
2618                 Scope::Root => {
2619                     return;
2620                 }
2621
2622                 Scope::Binder {
2623                     ref lifetimes, s, ..
2624                 } => {
2625                     if let Some(&def) = lifetimes.get(&param.name.modern()) {
2626                         let hir_id = self.tcx.hir().as_local_hir_id(def.id().unwrap()).unwrap();
2627
2628                         signal_shadowing_problem(
2629                             self.tcx,
2630                             param.name.ident().name,
2631                             original_lifetime(self.tcx.hir().span(hir_id)),
2632                             shadower_lifetime(&param),
2633                         );
2634                         return;
2635                     }
2636
2637                     old_scope = s;
2638                 }
2639             }
2640         }
2641     }
2642
2643     /// Returns `true` if, in the current scope, replacing `'_` would be
2644     /// equivalent to a single-use lifetime.
2645     fn track_lifetime_uses(&self) -> bool {
2646         let mut scope = self.scope;
2647         loop {
2648             match *scope {
2649                 Scope::Root => break false,
2650
2651                 // Inside of items, it depends on the kind of item.
2652                 Scope::Binder {
2653                     track_lifetime_uses,
2654                     ..
2655                 } => break track_lifetime_uses,
2656
2657                 // Inside a body, `'_` will use an inference variable,
2658                 // should be fine.
2659                 Scope::Body { .. } => break true,
2660
2661                 // A lifetime only used in a fn argument could as well
2662                 // be replaced with `'_`, as that would generate a
2663                 // fresh name, too.
2664                 Scope::Elision {
2665                     elide: Elide::FreshLateAnon(_),
2666                     ..
2667                 } => break true,
2668
2669                 // In the return type or other such place, `'_` is not
2670                 // going to make a fresh name, so we cannot
2671                 // necessarily replace a single-use lifetime with
2672                 // `'_`.
2673                 Scope::Elision {
2674                     elide: Elide::Exact(_),
2675                     ..
2676                 } => break false,
2677                 Scope::Elision {
2678                     elide: Elide::Error(_),
2679                     ..
2680                 } => break false,
2681
2682                 Scope::ObjectLifetimeDefault { s, .. } => scope = s,
2683             }
2684         }
2685     }
2686
2687     fn insert_lifetime(&mut self, lifetime_ref: &'tcx hir::Lifetime, def: Region) {
2688         if lifetime_ref.hir_id == hir::DUMMY_HIR_ID {
2689             span_bug!(
2690                 lifetime_ref.span,
2691                 "lifetime reference not renumbered, \
2692                  probably a bug in syntax::fold"
2693             );
2694         }
2695
2696         debug!(
2697             "insert_lifetime: {} resolved to {:?} span={:?}",
2698             self.tcx.hir().node_to_string(lifetime_ref.hir_id),
2699             def,
2700             self.tcx.sess.source_map().span_to_string(lifetime_ref.span)
2701         );
2702         self.map.defs.insert(lifetime_ref.hir_id, def);
2703
2704         match def {
2705             Region::LateBoundAnon(..) | Region::Static => {
2706                 // These are anonymous lifetimes or lifetimes that are not declared.
2707             }
2708
2709             Region::Free(_, def_id)
2710             | Region::LateBound(_, def_id, _)
2711             | Region::EarlyBound(_, def_id, _) => {
2712                 // A lifetime declared by the user.
2713                 let track_lifetime_uses = self.track_lifetime_uses();
2714                 debug!(
2715                     "insert_lifetime: track_lifetime_uses={}",
2716                     track_lifetime_uses
2717                 );
2718                 if track_lifetime_uses && !self.lifetime_uses.contains_key(&def_id) {
2719                     debug!("insert_lifetime: first use of {:?}", def_id);
2720                     self.lifetime_uses
2721                         .insert(def_id, LifetimeUseSet::One(lifetime_ref));
2722                 } else {
2723                     debug!("insert_lifetime: many uses of {:?}", def_id);
2724                     self.lifetime_uses.insert(def_id, LifetimeUseSet::Many);
2725                 }
2726             }
2727         }
2728     }
2729
2730     /// Sometimes we resolve a lifetime, but later find that it is an
2731     /// error (esp. around impl trait). In that case, we remove the
2732     /// entry into `map.defs` so as not to confuse later code.
2733     fn uninsert_lifetime_on_error(&mut self, lifetime_ref: &'tcx hir::Lifetime, bad_def: Region) {
2734         let old_value = self.map.defs.remove(&lifetime_ref.hir_id);
2735         assert_eq!(old_value, Some(bad_def));
2736     }
2737 }
2738
2739 /// Detects late-bound lifetimes and inserts them into
2740 /// `map.late_bound`.
2741 ///
2742 /// A region declared on a fn is **late-bound** if:
2743 /// - it is constrained by an argument type;
2744 /// - it does not appear in a where-clause.
2745 ///
2746 /// "Constrained" basically means that it appears in any type but
2747 /// not amongst the inputs to a projection. In other words, `<&'a
2748 /// T as Trait<''b>>::Foo` does not constrain `'a` or `'b`.
2749 fn insert_late_bound_lifetimes(
2750     map: &mut NamedRegionMap,
2751     decl: &hir::FnDecl,
2752     generics: &hir::Generics,
2753 ) {
2754     debug!(
2755         "insert_late_bound_lifetimes(decl={:?}, generics={:?})",
2756         decl, generics
2757     );
2758
2759     let mut constrained_by_input = ConstrainedCollector::default();
2760     for arg_ty in &decl.inputs {
2761         constrained_by_input.visit_ty(arg_ty);
2762     }
2763
2764     let mut appears_in_output = AllCollector::default();
2765     intravisit::walk_fn_ret_ty(&mut appears_in_output, &decl.output);
2766
2767     debug!(
2768         "insert_late_bound_lifetimes: constrained_by_input={:?}",
2769         constrained_by_input.regions
2770     );
2771
2772     // Walk the lifetimes that appear in where clauses.
2773     //
2774     // Subtle point: because we disallow nested bindings, we can just
2775     // ignore binders here and scrape up all names we see.
2776     let mut appears_in_where_clause = AllCollector::default();
2777     appears_in_where_clause.visit_generics(generics);
2778
2779     for param in &generics.params {
2780         if let hir::GenericParamKind::Lifetime { .. } = param.kind {
2781             if !param.bounds.is_empty() {
2782                 // `'a: 'b` means both `'a` and `'b` are referenced
2783                 appears_in_where_clause
2784                     .regions
2785                     .insert(hir::LifetimeName::Param(param.name.modern()));
2786             }
2787         }
2788     }
2789
2790     debug!(
2791         "insert_late_bound_lifetimes: appears_in_where_clause={:?}",
2792         appears_in_where_clause.regions
2793     );
2794
2795     // Late bound regions are those that:
2796     // - appear in the inputs
2797     // - do not appear in the where-clauses
2798     // - are not implicitly captured by `impl Trait`
2799     for param in &generics.params {
2800         match param.kind {
2801             hir::GenericParamKind::Lifetime { .. } => { /* fall through */ }
2802
2803             // Neither types nor consts are late-bound.
2804             hir::GenericParamKind::Type { .. }
2805             | hir::GenericParamKind::Const { .. } => continue,
2806         }
2807
2808         let lt_name = hir::LifetimeName::Param(param.name.modern());
2809         // appears in the where clauses? early-bound.
2810         if appears_in_where_clause.regions.contains(&lt_name) {
2811             continue;
2812         }
2813
2814         // does not appear in the inputs, but appears in the return type? early-bound.
2815         if !constrained_by_input.regions.contains(&lt_name)
2816             && appears_in_output.regions.contains(&lt_name)
2817         {
2818             continue;
2819         }
2820
2821         debug!(
2822             "insert_late_bound_lifetimes: lifetime {:?} with id {:?} is late-bound",
2823             param.name.ident(),
2824             param.hir_id
2825         );
2826
2827         let inserted = map.late_bound.insert(param.hir_id);
2828         assert!(inserted, "visited lifetime {:?} twice", param.hir_id);
2829     }
2830
2831     return;
2832
2833     #[derive(Default)]
2834     struct ConstrainedCollector {
2835         regions: FxHashSet<hir::LifetimeName>,
2836     }
2837
2838     impl<'v> Visitor<'v> for ConstrainedCollector {
2839         fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'v> {
2840             NestedVisitorMap::None
2841         }
2842
2843         fn visit_ty(&mut self, ty: &'v hir::Ty) {
2844             match ty.node {
2845                 hir::TyKind::Path(hir::QPath::Resolved(Some(_), _))
2846                 | hir::TyKind::Path(hir::QPath::TypeRelative(..)) => {
2847                     // ignore lifetimes appearing in associated type
2848                     // projections, as they are not *constrained*
2849                     // (defined above)
2850                 }
2851
2852                 hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) => {
2853                     // consider only the lifetimes on the final
2854                     // segment; I am not sure it's even currently
2855                     // valid to have them elsewhere, but even if it
2856                     // is, those would be potentially inputs to
2857                     // projections
2858                     if let Some(last_segment) = path.segments.last() {
2859                         self.visit_path_segment(path.span, last_segment);
2860                     }
2861                 }
2862
2863                 _ => {
2864                     intravisit::walk_ty(self, ty);
2865                 }
2866             }
2867         }
2868
2869         fn visit_lifetime(&mut self, lifetime_ref: &'v hir::Lifetime) {
2870             self.regions.insert(lifetime_ref.name.modern());
2871         }
2872     }
2873
2874     #[derive(Default)]
2875     struct AllCollector {
2876         regions: FxHashSet<hir::LifetimeName>,
2877     }
2878
2879     impl<'v> Visitor<'v> for AllCollector {
2880         fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'v> {
2881             NestedVisitorMap::None
2882         }
2883
2884         fn visit_lifetime(&mut self, lifetime_ref: &'v hir::Lifetime) {
2885             self.regions.insert(lifetime_ref.name.modern());
2886         }
2887     }
2888 }
2889
2890 pub fn report_missing_lifetime_specifiers(
2891     sess: &Session,
2892     span: Span,
2893     count: usize,
2894 ) -> DiagnosticBuilder<'_> {
2895     struct_span_err!(
2896         sess,
2897         span,
2898         E0106,
2899         "missing lifetime specifier{}",
2900         if count > 1 { "s" } else { "" }
2901     )
2902 }
2903
2904 fn add_missing_lifetime_specifiers_label(
2905     err: &mut DiagnosticBuilder<'_>,
2906     span: Span,
2907     count: usize,
2908     lifetime_names: &FxHashSet<ast::Ident>,
2909     snippet: Option<&str>,
2910 ) {
2911     if count > 1 {
2912         err.span_label(span, format!("expected {} lifetime parameters", count));
2913     } else if let (1, Some(name), Some("&")) = (
2914         lifetime_names.len(),
2915         lifetime_names.iter().next(),
2916         snippet,
2917     ) {
2918         err.span_suggestion(
2919             span,
2920             "consider using the named lifetime",
2921             format!("&{} ", name),
2922             Applicability::MaybeIncorrect,
2923         );
2924     } else {
2925         err.span_label(span, "expected lifetime parameter");
2926     }
2927 }