1 //! Implementation of lint checking.
3 //! The lint checking is mostly consolidated into one pass which runs
4 //! after all other analyses. Throughout compilation, lint warnings
5 //! can be added via the `add_lint` method on the Session structure. This
6 //! requires a span and an ID of the node that the lint is being added to. The
7 //! lint isn't actually emitted at that time because it is unknown what the
8 //! actual lint level at that location is.
10 //! To actually emit lint warnings/errors, a separate pass is used.
11 //! A context keeps track of the current state of all lint levels.
12 //! Upon entering a node of the ast which can modify the lint settings, the
13 //! previous lint state is pushed onto a stack and the ast is then recursed
14 //! upon. As the ast is traversed, this keeps track of the current lint level
15 //! for all lint attributes.
17 use self::TargetLint::*;
20 use crate::hir::def_id::{CrateNum, DefId, LOCAL_CRATE};
21 use crate::hir::intravisit as hir_visit;
22 use crate::hir::intravisit::Visitor;
23 use crate::hir::map::{definitions::DisambiguatedDefPathData, DefPathData};
24 use crate::lint::{EarlyLintPass, LateLintPass, EarlyLintPassObject, LateLintPassObject};
25 use crate::lint::{LintArray, Level, Lint, LintId, LintPass, LintBuffer};
26 use crate::lint::builtin::BuiltinLintDiagnostics;
27 use crate::lint::levels::{LintLevelSets, LintLevelsBuilder};
28 use crate::middle::privacy::AccessLevels;
29 use crate::session::{config, early_error, Session};
30 use crate::ty::{self, print::Printer, subst::GenericArg, TyCtxt, Ty};
31 use crate::ty::layout::{LayoutError, LayoutOf, TyLayout};
32 use crate::util::nodemap::FxHashMap;
33 use crate::util::common::time;
35 use errors::DiagnosticBuilder;
37 use std::default::Default as StdDefault;
38 use rustc_data_structures::sync::{ReadGuard, Lock, ParallelIterator, join, par_iter};
39 use rustc_serialize::{Decoder, Decodable, Encoder, Encodable};
42 use syntax::util::lev_distance::find_best_match_for_name;
43 use syntax::visit as ast_visit;
44 use syntax_pos::{MultiSpan, Span, symbol::Symbol};
46 /// Information about the registered lints.
48 /// This is basically the subset of `Context` that we can
49 /// build early in the compile pipeline.
50 pub struct LintStore {
51 /// Registered lints. The bool is true if the lint was
52 /// added by a plugin.
53 lints: Vec<(&'static Lint, bool)>,
55 /// Trait objects for each lint pass.
56 /// This is only `None` while performing a lint pass.
57 pre_expansion_passes: Option<Vec<EarlyLintPassObject>>,
58 early_passes: Option<Vec<EarlyLintPassObject>>,
59 late_passes: Lock<Option<Vec<LateLintPassObject>>>,
60 late_module_passes: Vec<LateLintPassObject>,
62 /// Lints indexed by name.
63 by_name: FxHashMap<String, TargetLint>,
65 /// Map of registered lint groups to what lints they expand to.
66 lint_groups: FxHashMap<&'static str, LintGroup>,
68 /// Extra info for future incompatibility lints, describing the
69 /// issue or RFC that caused the incompatibility.
70 future_incompatible: FxHashMap<LintId, FutureIncompatibleInfo>,
73 /// Lints that are buffered up early on in the `Session` before the
74 /// `LintLevels` is calculated
75 #[derive(PartialEq, RustcEncodable, RustcDecodable, Debug)]
76 pub struct BufferedEarlyLint {
78 pub ast_id: ast::NodeId,
81 pub diagnostic: BuiltinLintDiagnostics,
84 /// Extra information for a future incompatibility lint. See the call
85 /// to `register_future_incompatible` in `librustc_lint/lib.rs` for
87 pub struct FutureIncompatibleInfo {
89 /// e.g., a URL for an issue/PR/RFC or error code
90 pub reference: &'static str,
91 /// If this is an edition fixing lint, the edition in which
92 /// this lint becomes obsolete
93 pub edition: Option<edition::Edition>,
96 /// The target of the `by_name` map, which accounts for renaming/deprecation.
98 /// A direct lint target
101 /// Temporary renaming, used for easing migration pain; see #16545
102 Renamed(String, LintId),
104 /// Lint with this name existed previously, but has been removed/deprecated.
105 /// The string argument is the reason for removal.
109 pub enum FindLintError {
116 /// Whether deprecation warnings should be suppressed for this alias.
121 lint_ids: Vec<LintId>,
123 depr: Option<LintAlias>,
126 pub enum CheckLintNameResult<'a> {
128 /// Lint doesn't exist. Potentially contains a suggestion for a correct lint name.
129 NoLint(Option<Symbol>),
130 /// The lint is either renamed or removed. This is the warning
131 /// message, and an optional new name (`None` if removed).
132 Warning(String, Option<String>),
133 /// The lint is from a tool. If the Option is None, then either
134 /// the lint does not exist in the tool or the code was not
135 /// compiled with the tool and therefore the lint was never
136 /// added to the `LintStore`. Otherwise the `LintId` will be
137 /// returned as if it where a rustc lint.
138 Tool(Result<&'a [LintId], (Option<&'a [LintId]>, String)>),
142 pub fn new() -> LintStore {
145 pre_expansion_passes: Some(vec![]),
146 early_passes: Some(vec![]),
147 late_passes: Lock::new(Some(vec![])),
148 late_module_passes: vec![],
149 by_name: Default::default(),
150 future_incompatible: Default::default(),
151 lint_groups: Default::default(),
155 pub fn get_lints<'t>(&'t self) -> &'t [(&'static Lint, bool)] {
159 pub fn get_lint_groups<'t>(&'t self) -> Vec<(&'static str, Vec<LintId>, bool)> {
160 self.lint_groups.iter()
161 .filter(|(_, LintGroup { depr, .. })| {
162 // Don't display deprecated lint groups.
165 .map(|(k, LintGroup { lint_ids, from_plugin, .. })| {
166 (*k, lint_ids.clone(), *from_plugin)
171 pub fn register_early_pass(&mut self,
172 sess: Option<&Session>,
175 pass: EarlyLintPassObject) {
176 self.push_pass(sess, from_plugin, &pass);
178 self.early_passes.as_mut().unwrap().push(pass);
182 pub fn register_pre_expansion_pass(
184 sess: Option<&Session>,
187 pass: EarlyLintPassObject,
189 self.push_pass(sess, from_plugin, &pass);
191 self.pre_expansion_passes.as_mut().unwrap().push(pass);
195 pub fn register_late_pass(&mut self,
196 sess: Option<&Session>,
200 pass: LateLintPassObject) {
201 self.push_pass(sess, from_plugin, &pass);
204 self.late_module_passes.push(pass);
206 self.late_passes.lock().as_mut().unwrap().push(pass);
211 // Helper method for register_early/late_pass
212 fn push_pass<P: LintPass + ?Sized + 'static>(&mut self,
213 sess: Option<&Session>,
216 for lint in pass.get_lints() {
217 self.lints.push((lint, from_plugin));
219 let id = LintId::of(lint);
220 if self.by_name.insert(lint.name_lower(), Id(id)).is_some() {
221 bug!("duplicate specification of lint {}", lint.name_lower())
226 pub fn register_future_incompatible(&mut self,
227 sess: Option<&Session>,
228 lints: Vec<FutureIncompatibleInfo>) {
230 for edition in edition::ALL_EDITIONS {
231 let lints = lints.iter().filter(|f| f.edition == Some(*edition)).map(|f| f.id)
232 .collect::<Vec<_>>();
233 if !lints.is_empty() {
234 self.register_group(sess, false, edition.lint_name(), None, lints)
238 let mut future_incompatible = Vec::with_capacity(lints.len());
240 future_incompatible.push(lint.id);
241 self.future_incompatible.insert(lint.id, lint);
247 "future_incompatible",
253 pub fn future_incompatible(&self, id: LintId) -> Option<&FutureIncompatibleInfo> {
254 self.future_incompatible.get(&id)
257 pub fn register_group_alias(
259 lint_name: &'static str,
262 self.lint_groups.insert(alias, LintGroup {
265 depr: Some(LintAlias { name: lint_name, silent: true }),
269 pub fn register_group(
271 sess: Option<&Session>,
274 deprecated_name: Option<&'static str>,
279 .insert(name, LintGroup {
285 if let Some(deprecated) = deprecated_name {
286 self.lint_groups.insert(deprecated, LintGroup {
289 depr: Some(LintAlias { name, silent: false }),
294 bug!("duplicate specification of lint group {}", name);
298 pub fn register_renamed(&mut self, old_name: &str, new_name: &str) {
299 let target = match self.by_name.get(new_name) {
300 Some(&Id(lint_id)) => lint_id.clone(),
301 _ => bug!("invalid lint renaming of {} to {}", old_name, new_name)
303 self.by_name.insert(old_name.to_string(), Renamed(new_name.to_string(), target));
306 pub fn register_removed(&mut self, name: &str, reason: &str) {
307 self.by_name.insert(name.into(), Removed(reason.into()));
310 pub fn find_lints(&self, mut lint_name: &str) -> Result<Vec<LintId>, FindLintError> {
311 match self.by_name.get(lint_name) {
312 Some(&Id(lint_id)) => Ok(vec![lint_id]),
313 Some(&Renamed(_, lint_id)) => {
316 Some(&Removed(_)) => {
317 Err(FindLintError::Removed)
321 return match self.lint_groups.get(lint_name) {
322 Some(LintGroup {lint_ids, depr, .. }) => {
323 if let Some(LintAlias { name, .. }) = depr {
329 None => Err(FindLintError::Removed)
336 /// Checks the validity of lint names derived from the command line
337 pub fn check_lint_name_cmdline(&self,
341 let db = match self.check_lint_name(lint_name, None) {
342 CheckLintNameResult::Ok(_) => None,
343 CheckLintNameResult::Warning(ref msg, _) => {
344 Some(sess.struct_warn(msg))
346 CheckLintNameResult::NoLint(suggestion) => {
347 let mut err = struct_err!(sess, E0602, "unknown lint: `{}`", lint_name);
349 if let Some(suggestion) = suggestion {
350 err.help(&format!("did you mean: `{}`", suggestion));
355 CheckLintNameResult::Tool(result) => match result {
356 Err((Some(_), new_name)) => Some(sess.struct_warn(&format!(
357 "lint name `{}` is deprecated \
358 and does not have an effect anymore. \
366 if let Some(mut db) = db {
367 let msg = format!("requested on the command line with `{} {}`",
369 Level::Allow => "-A",
372 Level::Forbid => "-F",
380 /// Checks the name of a lint for its existence, and whether it was
381 /// renamed or removed. Generates a DiagnosticBuilder containing a
382 /// warning for renamed and removed lints. This is over both lint
383 /// names from attributes and those passed on the command line. Since
384 /// it emits non-fatal warnings and there are *two* lint passes that
385 /// inspect attributes, this is only run from the late pass to avoid
386 /// printing duplicate warnings.
387 pub fn check_lint_name(
390 tool_name: Option<Symbol>,
391 ) -> CheckLintNameResult<'_> {
392 let complete_name = if let Some(tool_name) = tool_name {
393 format!("{}::{}", tool_name, lint_name)
395 lint_name.to_string()
397 // If the lint was scoped with `tool::` check if the tool lint exists
398 if let Some(_) = tool_name {
399 match self.by_name.get(&complete_name) {
400 None => match self.lint_groups.get(&*complete_name) {
401 None => return CheckLintNameResult::Tool(Err((None, String::new()))),
402 Some(LintGroup { lint_ids, .. }) => {
403 return CheckLintNameResult::Tool(Ok(&lint_ids));
406 Some(&Id(ref id)) => return CheckLintNameResult::Tool(Ok(slice::from_ref(id))),
407 // If the lint was registered as removed or renamed by the lint tool, we don't need
408 // to treat tool_lints and rustc lints different and can use the code below.
412 match self.by_name.get(&complete_name) {
413 Some(&Renamed(ref new_name, _)) => CheckLintNameResult::Warning(
415 "lint `{}` has been renamed to `{}`",
416 complete_name, new_name
418 Some(new_name.to_owned()),
420 Some(&Removed(ref reason)) => CheckLintNameResult::Warning(
421 format!("lint `{}` has been removed: `{}`", complete_name, reason),
424 None => match self.lint_groups.get(&*complete_name) {
425 // If neither the lint, nor the lint group exists check if there is a `clippy::`
426 // variant of this lint
427 None => self.check_tool_name_for_backwards_compat(&complete_name, "clippy"),
428 Some(LintGroup { lint_ids, depr, .. }) => {
429 // Check if the lint group name is deprecated
430 if let Some(LintAlias { name, silent }) = depr {
431 let LintGroup { lint_ids, .. } = self.lint_groups.get(name).unwrap();
433 CheckLintNameResult::Ok(&lint_ids)
435 CheckLintNameResult::Tool(Err((
441 CheckLintNameResult::Ok(&lint_ids)
444 Some(&Id(ref id)) => CheckLintNameResult::Ok(slice::from_ref(id)),
448 fn check_tool_name_for_backwards_compat(
452 ) -> CheckLintNameResult<'_> {
453 let complete_name = format!("{}::{}", tool_name, lint_name);
454 match self.by_name.get(&complete_name) {
455 None => match self.lint_groups.get(&*complete_name) {
456 // Now we are sure, that this lint exists nowhere
458 let symbols = self.by_name.keys()
459 .map(|name| Symbol::intern(&name))
460 .collect::<Vec<_>>();
463 find_best_match_for_name(symbols.iter(), &lint_name.to_lowercase(), None);
465 CheckLintNameResult::NoLint(suggestion)
467 Some(LintGroup { lint_ids, depr, .. }) => {
468 // Reaching this would be weird, but let's cover this case anyway
469 if let Some(LintAlias { name, silent }) = depr {
470 let LintGroup { lint_ids, .. } = self.lint_groups.get(name).unwrap();
472 CheckLintNameResult::Tool(Err((Some(&lint_ids), complete_name)))
474 CheckLintNameResult::Tool(Err((
480 CheckLintNameResult::Tool(Err((Some(&lint_ids), complete_name)))
483 Some(&Id(ref id)) => {
484 CheckLintNameResult::Tool(Err((Some(slice::from_ref(id)), complete_name)))
486 _ => CheckLintNameResult::NoLint(None),
491 /// Context for lint checking after type checking.
492 pub struct LateContext<'a, 'tcx> {
493 /// Type context we're checking in.
494 pub tcx: TyCtxt<'tcx>,
496 /// Side-tables for the body we are in.
497 // FIXME: Make this lazy to avoid running the TypeckTables query?
498 pub tables: &'a ty::TypeckTables<'tcx>,
500 /// Parameter environment for the item we are in.
501 pub param_env: ty::ParamEnv<'tcx>,
503 /// Items accessible from the crate being checked.
504 pub access_levels: &'a AccessLevels,
506 /// The store of registered lints and the lint levels.
507 lint_store: ReadGuard<'a, LintStore>,
509 last_node_with_lint_attrs: hir::HirId,
511 /// Generic type parameters in scope for the item we are in.
512 pub generics: Option<&'tcx hir::Generics>,
514 /// We are only looking at one module
518 pub struct LateContextAndPass<'a, 'tcx, T: LateLintPass<'a, 'tcx>> {
519 context: LateContext<'a, 'tcx>,
523 /// Context for lint checking of the AST, after expansion, before lowering to
525 pub struct EarlyContext<'a> {
526 /// Type context we're checking in.
527 pub sess: &'a Session,
529 /// The crate being checked.
530 pub krate: &'a ast::Crate,
532 builder: LintLevelsBuilder<'a>,
534 /// The store of registered lints and the lint levels.
535 lint_store: ReadGuard<'a, LintStore>,
537 buffered: LintBuffer,
540 pub struct EarlyContextAndPass<'a, T: EarlyLintPass> {
541 context: EarlyContext<'a>,
545 pub trait LintPassObject: Sized {}
547 impl LintPassObject for EarlyLintPassObject {}
549 impl LintPassObject for LateLintPassObject {}
551 pub trait LintContext: Sized {
552 type PassObject: LintPassObject;
554 fn sess(&self) -> &Session;
555 fn lints(&self) -> &LintStore;
557 fn lookup_and_emit<S: Into<MultiSpan>>(&self,
561 self.lookup(lint, span, msg).emit();
564 fn lookup_and_emit_with_diagnostics<S: Into<MultiSpan>>(&self,
568 diagnostic: BuiltinLintDiagnostics) {
569 let mut db = self.lookup(lint, span, msg);
570 diagnostic.run(self.sess(), &mut db);
574 fn lookup<S: Into<MultiSpan>>(&self,
578 -> DiagnosticBuilder<'_>;
580 /// Emit a lint at the appropriate level, for a particular span.
581 fn span_lint<S: Into<MultiSpan>>(&self, lint: &'static Lint, span: S, msg: &str) {
582 self.lookup_and_emit(lint, Some(span), msg);
585 fn struct_span_lint<S: Into<MultiSpan>>(&self,
589 -> DiagnosticBuilder<'_> {
590 self.lookup(lint, Some(span), msg)
593 /// Emit a lint and note at the appropriate level, for a particular span.
594 fn span_lint_note(&self, lint: &'static Lint, span: Span, msg: &str,
595 note_span: Span, note: &str) {
596 let mut err = self.lookup(lint, Some(span), msg);
597 if note_span == span {
600 err.span_note(note_span, note);
605 /// Emit a lint and help at the appropriate level, for a particular span.
606 fn span_lint_help(&self, lint: &'static Lint, span: Span,
607 msg: &str, help: &str) {
608 let mut err = self.lookup(lint, Some(span), msg);
609 self.span_lint(lint, span, msg);
610 err.span_help(span, help);
614 /// Emit a lint at the appropriate level, with no associated span.
615 fn lint(&self, lint: &'static Lint, msg: &str) {
616 self.lookup_and_emit(lint, None as Option<Span>, msg);
621 impl<'a> EarlyContext<'a> {
624 krate: &'a ast::Crate,
625 buffered: LintBuffer,
626 ) -> EarlyContext<'a> {
630 lint_store: sess.lint_store.borrow(),
631 builder: LintLevelSets::builder(sess),
637 macro_rules! lint_callback { ($cx:expr, $f:ident, $($args:expr),*) => ({
638 $cx.pass.$f(&$cx.context, $($args),*);
641 macro_rules! run_early_pass { ($cx:expr, $f:ident, $($args:expr),*) => ({
642 $cx.pass.$f(&$cx.context, $($args),*);
645 impl<'a, T: EarlyLintPass> EarlyContextAndPass<'a, T> {
646 fn check_id(&mut self, id: ast::NodeId) {
647 for early_lint in self.context.buffered.take(id) {
648 self.context.lookup_and_emit_with_diagnostics(
649 early_lint.lint_id.lint,
650 Some(early_lint.span.clone()),
652 early_lint.diagnostic
657 /// Merge the lints specified by any lint attributes into the
658 /// current lint context, call the provided function, then reset the
659 /// lints in effect to their previous state.
660 fn with_lint_attrs<F>(&mut self,
662 attrs: &'a [ast::Attribute],
664 where F: FnOnce(&mut Self)
666 let push = self.context.builder.push(attrs);
668 self.enter_attrs(attrs);
670 self.exit_attrs(attrs);
671 self.context.builder.pop(push);
674 fn enter_attrs(&mut self, attrs: &'a [ast::Attribute]) {
675 debug!("early context: enter_attrs({:?})", attrs);
676 run_early_pass!(self, enter_lint_attrs, attrs);
679 fn exit_attrs(&mut self, attrs: &'a [ast::Attribute]) {
680 debug!("early context: exit_attrs({:?})", attrs);
681 run_early_pass!(self, exit_lint_attrs, attrs);
685 impl LintContext for LateContext<'_, '_> {
686 type PassObject = LateLintPassObject;
688 /// Gets the overall compiler `Session` object.
689 fn sess(&self) -> &Session {
693 fn lints(&self) -> &LintStore {
697 fn lookup<S: Into<MultiSpan>>(&self,
701 -> DiagnosticBuilder<'_> {
702 let hir_id = self.last_node_with_lint_attrs;
705 Some(s) => self.tcx.struct_span_lint_hir(lint, hir_id, s, msg),
707 self.tcx.struct_lint_node(lint, hir_id, msg)
713 impl LintContext for EarlyContext<'_> {
714 type PassObject = EarlyLintPassObject;
716 /// Gets the overall compiler `Session` object.
717 fn sess(&self) -> &Session {
721 fn lints(&self) -> &LintStore {
725 fn lookup<S: Into<MultiSpan>>(&self,
729 -> DiagnosticBuilder<'_> {
730 self.builder.struct_lint(lint, span.map(|s| s.into()), msg)
734 impl<'a, 'tcx> LateContext<'a, 'tcx> {
735 pub fn current_lint_root(&self) -> hir::HirId {
736 self.last_node_with_lint_attrs
739 /// Check if a `DefId`'s path matches the given absolute type path usage.
743 /// ```rust,ignore (no context or def id available)
744 /// if cx.match_def_path(def_id, &[sym::core, sym::option, sym::Option]) {
745 /// // The given `def_id` is that of an `Option` type
748 pub fn match_def_path(&self, def_id: DefId, path: &[Symbol]) -> bool {
749 let names = self.get_def_path(def_id);
751 names.len() == path.len() && names.into_iter().zip(path.iter()).all(|(a, &b)| a == b)
754 /// Gets the absolute path of `def_id` as a vector of `Symbol`.
758 /// ```rust,ignore (no context or def id available)
759 /// let def_path = cx.get_def_path(def_id);
760 /// if let &[sym::core, sym::option, sym::Option] = &def_path[..] {
761 /// // The given `def_id` is that of an `Option` type
764 pub fn get_def_path(&self, def_id: DefId) -> Vec<Symbol> {
765 pub struct AbsolutePathPrinter<'tcx> {
766 pub tcx: TyCtxt<'tcx>,
769 impl<'tcx> Printer<'tcx> for AbsolutePathPrinter<'tcx> {
772 type Path = Vec<Symbol>;
775 type DynExistential = ();
778 fn tcx(&self) -> TyCtxt<'tcx> {
782 fn print_region(self, _region: ty::Region<'_>) -> Result<Self::Region, Self::Error> {
786 fn print_type(self, _ty: Ty<'tcx>) -> Result<Self::Type, Self::Error> {
790 fn print_dyn_existential(
792 _predicates: &'tcx ty::List<ty::ExistentialPredicate<'tcx>>,
793 ) -> Result<Self::DynExistential, Self::Error> {
799 _ct: &'tcx ty::Const<'tcx>,
800 ) -> Result<Self::Const, Self::Error> {
804 fn path_crate(self, cnum: CrateNum) -> Result<Self::Path, Self::Error> {
805 Ok(vec![self.tcx.original_crate_name(cnum)])
811 trait_ref: Option<ty::TraitRef<'tcx>>,
812 ) -> Result<Self::Path, Self::Error> {
813 if trait_ref.is_none() {
814 if let ty::Adt(def, substs) = self_ty.kind {
815 return self.print_def_path(def.did, substs);
819 // This shouldn't ever be needed, but just in case:
820 Ok(vec![match trait_ref {
821 Some(trait_ref) => Symbol::intern(&format!("{:?}", trait_ref)),
822 None => Symbol::intern(&format!("<{}>", self_ty)),
828 print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
829 _disambiguated_data: &DisambiguatedDefPathData,
831 trait_ref: Option<ty::TraitRef<'tcx>>,
832 ) -> Result<Self::Path, Self::Error> {
833 let mut path = print_prefix(self)?;
835 // This shouldn't ever be needed, but just in case:
836 path.push(match trait_ref {
838 Symbol::intern(&format!("<impl {} for {}>", trait_ref,
841 None => Symbol::intern(&format!("<impl {}>", self_ty)),
849 print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
850 disambiguated_data: &DisambiguatedDefPathData,
851 ) -> Result<Self::Path, Self::Error> {
852 let mut path = print_prefix(self)?;
854 // Skip `::{{constructor}}` on tuple/unit structs.
855 match disambiguated_data.data {
856 DefPathData::Ctor => return Ok(path),
860 path.push(disambiguated_data.data.as_interned_str().as_symbol());
864 fn path_generic_args(
866 print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
867 _args: &[GenericArg<'tcx>],
868 ) -> Result<Self::Path, Self::Error> {
873 AbsolutePathPrinter { tcx: self.tcx }
874 .print_def_path(def_id, &[])
879 impl<'a, 'tcx> LayoutOf for LateContext<'a, 'tcx> {
881 type TyLayout = Result<TyLayout<'tcx>, LayoutError<'tcx>>;
883 fn layout_of(&self, ty: Ty<'tcx>) -> Self::TyLayout {
884 self.tcx.layout_of(self.param_env.and(ty))
888 impl<'a, 'tcx, T: LateLintPass<'a, 'tcx>> LateContextAndPass<'a, 'tcx, T> {
889 /// Merge the lints specified by any lint attributes into the
890 /// current lint context, call the provided function, then reset the
891 /// lints in effect to their previous state.
892 fn with_lint_attrs<F>(&mut self,
894 attrs: &'tcx [ast::Attribute],
896 where F: FnOnce(&mut Self)
898 let prev = self.context.last_node_with_lint_attrs;
899 self.context.last_node_with_lint_attrs = id;
900 self.enter_attrs(attrs);
902 self.exit_attrs(attrs);
903 self.context.last_node_with_lint_attrs = prev;
906 fn with_param_env<F>(&mut self, id: hir::HirId, f: F)
907 where F: FnOnce(&mut Self),
909 let old_param_env = self.context.param_env;
910 self.context.param_env = self.context.tcx.param_env(
911 self.context.tcx.hir().local_def_id(id)
914 self.context.param_env = old_param_env;
917 fn process_mod(&mut self, m: &'tcx hir::Mod, s: Span, n: hir::HirId) {
918 lint_callback!(self, check_mod, m, s, n);
919 hir_visit::walk_mod(self, m, n);
920 lint_callback!(self, check_mod_post, m, s, n);
923 fn enter_attrs(&mut self, attrs: &'tcx [ast::Attribute]) {
924 debug!("late context: enter_attrs({:?})", attrs);
925 lint_callback!(self, enter_lint_attrs, attrs);
928 fn exit_attrs(&mut self, attrs: &'tcx [ast::Attribute]) {
929 debug!("late context: exit_attrs({:?})", attrs);
930 lint_callback!(self, exit_lint_attrs, attrs);
934 impl<'a, 'tcx, T: LateLintPass<'a, 'tcx>> hir_visit::Visitor<'tcx>
935 for LateContextAndPass<'a, 'tcx, T> {
936 /// Because lints are scoped lexically, we want to walk nested
937 /// items in the context of the outer item, so enable
939 fn nested_visit_map<'this>(&'this mut self) -> hir_visit::NestedVisitorMap<'this, 'tcx> {
940 hir_visit::NestedVisitorMap::All(&self.context.tcx.hir())
943 fn visit_nested_body(&mut self, body: hir::BodyId) {
944 let old_tables = self.context.tables;
945 self.context.tables = self.context.tcx.body_tables(body);
946 let body = self.context.tcx.hir().body(body);
947 self.visit_body(body);
948 self.context.tables = old_tables;
951 fn visit_param(&mut self, param: &'tcx hir::Param) {
952 self.with_lint_attrs(param.hir_id, ¶m.attrs, |cx| {
953 lint_callback!(cx, check_param, param);
954 hir_visit::walk_param(cx, param);
958 fn visit_body(&mut self, body: &'tcx hir::Body) {
959 lint_callback!(self, check_body, body);
960 hir_visit::walk_body(self, body);
961 lint_callback!(self, check_body_post, body);
964 fn visit_item(&mut self, it: &'tcx hir::Item) {
965 let generics = self.context.generics.take();
966 self.context.generics = it.kind.generics();
967 self.with_lint_attrs(it.hir_id, &it.attrs, |cx| {
968 cx.with_param_env(it.hir_id, |cx| {
969 lint_callback!(cx, check_item, it);
970 hir_visit::walk_item(cx, it);
971 lint_callback!(cx, check_item_post, it);
974 self.context.generics = generics;
977 fn visit_foreign_item(&mut self, it: &'tcx hir::ForeignItem) {
978 self.with_lint_attrs(it.hir_id, &it.attrs, |cx| {
979 cx.with_param_env(it.hir_id, |cx| {
980 lint_callback!(cx, check_foreign_item, it);
981 hir_visit::walk_foreign_item(cx, it);
982 lint_callback!(cx, check_foreign_item_post, it);
987 fn visit_pat(&mut self, p: &'tcx hir::Pat) {
988 lint_callback!(self, check_pat, p);
989 hir_visit::walk_pat(self, p);
992 fn visit_expr(&mut self, e: &'tcx hir::Expr) {
993 self.with_lint_attrs(e.hir_id, &e.attrs, |cx| {
994 lint_callback!(cx, check_expr, e);
995 hir_visit::walk_expr(cx, e);
996 lint_callback!(cx, check_expr_post, e);
1000 fn visit_stmt(&mut self, s: &'tcx hir::Stmt) {
1001 // statement attributes are actually just attributes on one of
1005 // so we keep track of lint levels there
1006 lint_callback!(self, check_stmt, s);
1007 hir_visit::walk_stmt(self, s);
1010 fn visit_fn(&mut self, fk: hir_visit::FnKind<'tcx>, decl: &'tcx hir::FnDecl,
1011 body_id: hir::BodyId, span: Span, id: hir::HirId) {
1012 // Wrap in tables here, not just in visit_nested_body,
1013 // in order for `check_fn` to be able to use them.
1014 let old_tables = self.context.tables;
1015 self.context.tables = self.context.tcx.body_tables(body_id);
1016 let body = self.context.tcx.hir().body(body_id);
1017 lint_callback!(self, check_fn, fk, decl, body, span, id);
1018 hir_visit::walk_fn(self, fk, decl, body_id, span, id);
1019 lint_callback!(self, check_fn_post, fk, decl, body, span, id);
1020 self.context.tables = old_tables;
1023 fn visit_variant_data(&mut self,
1024 s: &'tcx hir::VariantData,
1026 _: &'tcx hir::Generics,
1029 lint_callback!(self, check_struct_def, s);
1030 hir_visit::walk_struct_def(self, s);
1031 lint_callback!(self, check_struct_def_post, s);
1034 fn visit_struct_field(&mut self, s: &'tcx hir::StructField) {
1035 self.with_lint_attrs(s.hir_id, &s.attrs, |cx| {
1036 lint_callback!(cx, check_struct_field, s);
1037 hir_visit::walk_struct_field(cx, s);
1041 fn visit_variant(&mut self,
1042 v: &'tcx hir::Variant,
1043 g: &'tcx hir::Generics,
1044 item_id: hir::HirId) {
1045 self.with_lint_attrs(v.id, &v.attrs, |cx| {
1046 lint_callback!(cx, check_variant, v);
1047 hir_visit::walk_variant(cx, v, g, item_id);
1048 lint_callback!(cx, check_variant_post, v);
1052 fn visit_ty(&mut self, t: &'tcx hir::Ty) {
1053 lint_callback!(self, check_ty, t);
1054 hir_visit::walk_ty(self, t);
1057 fn visit_name(&mut self, sp: Span, name: ast::Name) {
1058 lint_callback!(self, check_name, sp, name);
1061 fn visit_mod(&mut self, m: &'tcx hir::Mod, s: Span, n: hir::HirId) {
1062 if !self.context.only_module {
1063 self.process_mod(m, s, n);
1067 fn visit_local(&mut self, l: &'tcx hir::Local) {
1068 self.with_lint_attrs(l.hir_id, &l.attrs, |cx| {
1069 lint_callback!(cx, check_local, l);
1070 hir_visit::walk_local(cx, l);
1074 fn visit_block(&mut self, b: &'tcx hir::Block) {
1075 lint_callback!(self, check_block, b);
1076 hir_visit::walk_block(self, b);
1077 lint_callback!(self, check_block_post, b);
1080 fn visit_arm(&mut self, a: &'tcx hir::Arm) {
1081 lint_callback!(self, check_arm, a);
1082 hir_visit::walk_arm(self, a);
1085 fn visit_generic_param(&mut self, p: &'tcx hir::GenericParam) {
1086 lint_callback!(self, check_generic_param, p);
1087 hir_visit::walk_generic_param(self, p);
1090 fn visit_generics(&mut self, g: &'tcx hir::Generics) {
1091 lint_callback!(self, check_generics, g);
1092 hir_visit::walk_generics(self, g);
1095 fn visit_where_predicate(&mut self, p: &'tcx hir::WherePredicate) {
1096 lint_callback!(self, check_where_predicate, p);
1097 hir_visit::walk_where_predicate(self, p);
1100 fn visit_poly_trait_ref(&mut self, t: &'tcx hir::PolyTraitRef,
1101 m: hir::TraitBoundModifier) {
1102 lint_callback!(self, check_poly_trait_ref, t, m);
1103 hir_visit::walk_poly_trait_ref(self, t, m);
1106 fn visit_trait_item(&mut self, trait_item: &'tcx hir::TraitItem) {
1107 let generics = self.context.generics.take();
1108 self.context.generics = Some(&trait_item.generics);
1109 self.with_lint_attrs(trait_item.hir_id, &trait_item.attrs, |cx| {
1110 cx.with_param_env(trait_item.hir_id, |cx| {
1111 lint_callback!(cx, check_trait_item, trait_item);
1112 hir_visit::walk_trait_item(cx, trait_item);
1113 lint_callback!(cx, check_trait_item_post, trait_item);
1116 self.context.generics = generics;
1119 fn visit_impl_item(&mut self, impl_item: &'tcx hir::ImplItem) {
1120 let generics = self.context.generics.take();
1121 self.context.generics = Some(&impl_item.generics);
1122 self.with_lint_attrs(impl_item.hir_id, &impl_item.attrs, |cx| {
1123 cx.with_param_env(impl_item.hir_id, |cx| {
1124 lint_callback!(cx, check_impl_item, impl_item);
1125 hir_visit::walk_impl_item(cx, impl_item);
1126 lint_callback!(cx, check_impl_item_post, impl_item);
1129 self.context.generics = generics;
1132 fn visit_lifetime(&mut self, lt: &'tcx hir::Lifetime) {
1133 lint_callback!(self, check_lifetime, lt);
1134 hir_visit::walk_lifetime(self, lt);
1137 fn visit_path(&mut self, p: &'tcx hir::Path, id: hir::HirId) {
1138 lint_callback!(self, check_path, p, id);
1139 hir_visit::walk_path(self, p);
1142 fn visit_attribute(&mut self, attr: &'tcx ast::Attribute) {
1143 lint_callback!(self, check_attribute, attr);
1147 impl<'a, T: EarlyLintPass> ast_visit::Visitor<'a> for EarlyContextAndPass<'a, T> {
1148 fn visit_param(&mut self, param: &'a ast::Param) {
1149 self.with_lint_attrs(param.id, ¶m.attrs, |cx| {
1150 run_early_pass!(cx, check_param, param);
1151 ast_visit::walk_param(cx, param);
1155 fn visit_item(&mut self, it: &'a ast::Item) {
1156 self.with_lint_attrs(it.id, &it.attrs, |cx| {
1157 run_early_pass!(cx, check_item, it);
1158 ast_visit::walk_item(cx, it);
1159 run_early_pass!(cx, check_item_post, it);
1163 fn visit_foreign_item(&mut self, it: &'a ast::ForeignItem) {
1164 self.with_lint_attrs(it.id, &it.attrs, |cx| {
1165 run_early_pass!(cx, check_foreign_item, it);
1166 ast_visit::walk_foreign_item(cx, it);
1167 run_early_pass!(cx, check_foreign_item_post, it);
1171 fn visit_pat(&mut self, p: &'a ast::Pat) {
1172 run_early_pass!(self, check_pat, p);
1173 self.check_id(p.id);
1174 ast_visit::walk_pat(self, p);
1175 run_early_pass!(self, check_pat_post, p);
1178 fn visit_expr(&mut self, e: &'a ast::Expr) {
1179 self.with_lint_attrs(e.id, &e.attrs, |cx| {
1180 run_early_pass!(cx, check_expr, e);
1181 ast_visit::walk_expr(cx, e);
1185 fn visit_stmt(&mut self, s: &'a ast::Stmt) {
1186 run_early_pass!(self, check_stmt, s);
1187 self.check_id(s.id);
1188 ast_visit::walk_stmt(self, s);
1191 fn visit_fn(&mut self, fk: ast_visit::FnKind<'a>, decl: &'a ast::FnDecl,
1192 span: Span, id: ast::NodeId) {
1193 run_early_pass!(self, check_fn, fk, decl, span, id);
1195 ast_visit::walk_fn(self, fk, decl, span);
1196 run_early_pass!(self, check_fn_post, fk, decl, span, id);
1199 fn visit_variant_data(&mut self, s: &'a ast::VariantData) {
1200 run_early_pass!(self, check_struct_def, s);
1201 if let Some(ctor_hir_id) = s.ctor_id() {
1202 self.check_id(ctor_hir_id);
1204 ast_visit::walk_struct_def(self, s);
1205 run_early_pass!(self, check_struct_def_post, s);
1208 fn visit_struct_field(&mut self, s: &'a ast::StructField) {
1209 self.with_lint_attrs(s.id, &s.attrs, |cx| {
1210 run_early_pass!(cx, check_struct_field, s);
1211 ast_visit::walk_struct_field(cx, s);
1215 fn visit_variant(&mut self, v: &'a ast::Variant) {
1216 self.with_lint_attrs(v.id, &v.attrs, |cx| {
1217 run_early_pass!(cx, check_variant, v);
1218 ast_visit::walk_variant(cx, v);
1219 run_early_pass!(cx, check_variant_post, v);
1223 fn visit_ty(&mut self, t: &'a ast::Ty) {
1224 run_early_pass!(self, check_ty, t);
1225 self.check_id(t.id);
1226 ast_visit::walk_ty(self, t);
1229 fn visit_ident(&mut self, ident: ast::Ident) {
1230 run_early_pass!(self, check_ident, ident);
1233 fn visit_mod(&mut self, m: &'a ast::Mod, s: Span, _a: &[ast::Attribute], n: ast::NodeId) {
1234 run_early_pass!(self, check_mod, m, s, n);
1236 ast_visit::walk_mod(self, m);
1237 run_early_pass!(self, check_mod_post, m, s, n);
1240 fn visit_local(&mut self, l: &'a ast::Local) {
1241 self.with_lint_attrs(l.id, &l.attrs, |cx| {
1242 run_early_pass!(cx, check_local, l);
1243 ast_visit::walk_local(cx, l);
1247 fn visit_block(&mut self, b: &'a ast::Block) {
1248 run_early_pass!(self, check_block, b);
1249 self.check_id(b.id);
1250 ast_visit::walk_block(self, b);
1251 run_early_pass!(self, check_block_post, b);
1254 fn visit_arm(&mut self, a: &'a ast::Arm) {
1255 run_early_pass!(self, check_arm, a);
1256 ast_visit::walk_arm(self, a);
1259 fn visit_expr_post(&mut self, e: &'a ast::Expr) {
1260 run_early_pass!(self, check_expr_post, e);
1263 fn visit_generic_param(&mut self, param: &'a ast::GenericParam) {
1264 run_early_pass!(self, check_generic_param, param);
1265 ast_visit::walk_generic_param(self, param);
1268 fn visit_generics(&mut self, g: &'a ast::Generics) {
1269 run_early_pass!(self, check_generics, g);
1270 ast_visit::walk_generics(self, g);
1273 fn visit_where_predicate(&mut self, p: &'a ast::WherePredicate) {
1274 run_early_pass!(self, check_where_predicate, p);
1275 ast_visit::walk_where_predicate(self, p);
1278 fn visit_poly_trait_ref(&mut self, t: &'a ast::PolyTraitRef, m: &'a ast::TraitBoundModifier) {
1279 run_early_pass!(self, check_poly_trait_ref, t, m);
1280 ast_visit::walk_poly_trait_ref(self, t, m);
1283 fn visit_trait_item(&mut self, trait_item: &'a ast::TraitItem) {
1284 self.with_lint_attrs(trait_item.id, &trait_item.attrs, |cx| {
1285 run_early_pass!(cx, check_trait_item, trait_item);
1286 ast_visit::walk_trait_item(cx, trait_item);
1287 run_early_pass!(cx, check_trait_item_post, trait_item);
1291 fn visit_impl_item(&mut self, impl_item: &'a ast::ImplItem) {
1292 self.with_lint_attrs(impl_item.id, &impl_item.attrs, |cx| {
1293 run_early_pass!(cx, check_impl_item, impl_item);
1294 ast_visit::walk_impl_item(cx, impl_item);
1295 run_early_pass!(cx, check_impl_item_post, impl_item);
1299 fn visit_lifetime(&mut self, lt: &'a ast::Lifetime) {
1300 run_early_pass!(self, check_lifetime, lt);
1301 self.check_id(lt.id);
1304 fn visit_path(&mut self, p: &'a ast::Path, id: ast::NodeId) {
1305 run_early_pass!(self, check_path, p, id);
1307 ast_visit::walk_path(self, p);
1310 fn visit_attribute(&mut self, attr: &'a ast::Attribute) {
1311 run_early_pass!(self, check_attribute, attr);
1314 fn visit_mac_def(&mut self, mac: &'a ast::MacroDef, id: ast::NodeId) {
1315 run_early_pass!(self, check_mac_def, mac, id);
1319 fn visit_mac(&mut self, mac: &'a ast::Mac) {
1320 // FIXME(#54110): So, this setup isn't really right. I think
1321 // that (a) the libsyntax visitor ought to be doing this as
1322 // part of `walk_mac`, and (b) we should be calling
1323 // `visit_path`, *but* that would require a `NodeId`, and I
1324 // want to get #53686 fixed quickly. -nmatsakis
1325 ast_visit::walk_path(self, &mac.path);
1327 run_early_pass!(self, check_mac, mac);
1331 struct LateLintPassObjects<'a> {
1332 lints: &'a mut [LateLintPassObject],
1335 #[allow(rustc::lint_pass_impl_without_macro)]
1336 impl LintPass for LateLintPassObjects<'_> {
1337 fn name(&self) -> &'static str {
1341 fn get_lints(&self) -> LintArray {
1346 macro_rules! expand_late_lint_pass_impl_methods {
1347 ([$a:tt, $hir:tt], [$($(#[$attr:meta])* fn $name:ident($($param:ident: $arg:ty),*);)*]) => (
1348 $(fn $name(&mut self, context: &LateContext<$a, $hir>, $($param: $arg),*) {
1349 for obj in self.lints.iter_mut() {
1350 obj.$name(context, $($param),*);
1356 macro_rules! late_lint_pass_impl {
1357 ([], [$hir:tt], $methods:tt) => (
1358 impl LateLintPass<'a, $hir> for LateLintPassObjects<'_> {
1359 expand_late_lint_pass_impl_methods!(['a, $hir], $methods);
1364 late_lint_methods!(late_lint_pass_impl, [], ['tcx]);
1366 fn late_lint_mod_pass<'tcx, T: for<'a> LateLintPass<'a, 'tcx>>(
1368 module_def_id: DefId,
1371 let access_levels = &tcx.privacy_access_levels(LOCAL_CRATE);
1373 let context = LateContext {
1375 tables: &ty::TypeckTables::empty(None),
1376 param_env: ty::ParamEnv::empty(),
1378 lint_store: tcx.sess.lint_store.borrow(),
1379 last_node_with_lint_attrs: tcx.hir().as_local_hir_id(module_def_id).unwrap(),
1384 let mut cx = LateContextAndPass {
1389 let (module, span, hir_id) = tcx.hir().get_module(module_def_id);
1390 cx.process_mod(module, span, hir_id);
1392 // Visit the crate attributes
1393 if hir_id == hir::CRATE_HIR_ID {
1394 walk_list!(cx, visit_attribute, tcx.hir().attrs(hir::CRATE_HIR_ID));
1398 pub fn late_lint_mod<'tcx, T: for<'a> LateLintPass<'a, 'tcx>>(
1400 module_def_id: DefId,
1403 if tcx.sess.opts.debugging_opts.no_interleave_lints {
1404 // These passes runs in late_lint_crate with -Z no_interleave_lints
1408 late_lint_mod_pass(tcx, module_def_id, builtin_lints);
1410 let mut passes: Vec<_> = tcx.sess.lint_store.borrow().late_module_passes
1411 .iter().map(|pass| pass.fresh_late_pass()).collect();
1413 if !passes.is_empty() {
1414 late_lint_mod_pass(tcx, module_def_id, LateLintPassObjects { lints: &mut passes[..] });
1418 fn late_lint_pass_crate<'tcx, T: for<'a> LateLintPass<'a, 'tcx>>(tcx: TyCtxt<'tcx>, pass: T) {
1419 let access_levels = &tcx.privacy_access_levels(LOCAL_CRATE);
1421 let krate = tcx.hir().krate();
1423 let context = LateContext {
1425 tables: &ty::TypeckTables::empty(None),
1426 param_env: ty::ParamEnv::empty(),
1428 lint_store: tcx.sess.lint_store.borrow(),
1429 last_node_with_lint_attrs: hir::CRATE_HIR_ID,
1434 let mut cx = LateContextAndPass {
1439 // Visit the whole crate.
1440 cx.with_lint_attrs(hir::CRATE_HIR_ID, &krate.attrs, |cx| {
1441 // since the root module isn't visited as an item (because it isn't an
1442 // item), warn for it here.
1443 lint_callback!(cx, check_crate, krate);
1445 hir_visit::walk_crate(cx, krate);
1447 lint_callback!(cx, check_crate_post, krate);
1451 fn late_lint_crate<'tcx, T: for<'a> LateLintPass<'a, 'tcx>>(tcx: TyCtxt<'tcx>, builtin_lints: T) {
1452 let mut passes = tcx.sess.lint_store.borrow().late_passes.lock().take().unwrap();
1454 if !tcx.sess.opts.debugging_opts.no_interleave_lints {
1455 if !passes.is_empty() {
1456 late_lint_pass_crate(tcx, LateLintPassObjects { lints: &mut passes[..] });
1459 late_lint_pass_crate(tcx, builtin_lints);
1461 for pass in &mut passes {
1462 time(tcx.sess, &format!("running late lint: {}", pass.name()), || {
1463 late_lint_pass_crate(tcx, LateLintPassObjects { lints: slice::from_mut(pass) });
1467 let mut passes: Vec<_> = tcx.sess.lint_store.borrow().late_module_passes
1468 .iter().map(|pass| pass.fresh_late_pass()).collect();
1470 for pass in &mut passes {
1471 time(tcx.sess, &format!("running late module lint: {}", pass.name()), || {
1472 late_lint_pass_crate(tcx, LateLintPassObjects { lints: slice::from_mut(pass) });
1477 // Put the passes back in the session.
1478 *tcx.sess.lint_store.borrow().late_passes.lock() = Some(passes);
1481 /// Performs lint checking on a crate.
1482 pub fn check_crate<'tcx, T: for<'a> LateLintPass<'a, 'tcx>>(
1484 builtin_lints: impl FnOnce() -> T + Send,
1487 time(tcx.sess, "crate lints", || {
1488 // Run whole crate non-incremental lints
1489 late_lint_crate(tcx, builtin_lints());
1492 time(tcx.sess, "module lints", || {
1493 // Run per-module lints
1494 par_iter(&tcx.hir().krate().modules).for_each(|(&module, _)| {
1495 tcx.ensure().lint_mod(tcx.hir().local_def_id(module));
1501 struct EarlyLintPassObjects<'a> {
1502 lints: &'a mut [EarlyLintPassObject],
1505 #[allow(rustc::lint_pass_impl_without_macro)]
1506 impl LintPass for EarlyLintPassObjects<'_> {
1507 fn name(&self) -> &'static str {
1511 fn get_lints(&self) -> LintArray {
1516 macro_rules! expand_early_lint_pass_impl_methods {
1517 ([$($(#[$attr:meta])* fn $name:ident($($param:ident: $arg:ty),*);)*]) => (
1518 $(fn $name(&mut self, context: &EarlyContext<'_>, $($param: $arg),*) {
1519 for obj in self.lints.iter_mut() {
1520 obj.$name(context, $($param),*);
1526 macro_rules! early_lint_pass_impl {
1527 ([], [$($methods:tt)*]) => (
1528 impl EarlyLintPass for EarlyLintPassObjects<'_> {
1529 expand_early_lint_pass_impl_methods!([$($methods)*]);
1534 early_lint_methods!(early_lint_pass_impl, []);
1536 fn early_lint_crate<T: EarlyLintPass>(
1540 buffered: LintBuffer,
1542 let mut cx = EarlyContextAndPass {
1543 context: EarlyContext::new(sess, krate, buffered),
1547 // Visit the whole crate.
1548 cx.with_lint_attrs(ast::CRATE_NODE_ID, &krate.attrs, |cx| {
1549 // since the root module isn't visited as an item (because it isn't an
1550 // item), warn for it here.
1551 run_early_pass!(cx, check_crate, krate);
1553 ast_visit::walk_crate(cx, krate);
1555 run_early_pass!(cx, check_crate_post, krate);
1560 pub fn check_ast_crate<T: EarlyLintPass>(
1563 pre_expansion: bool,
1566 let (mut passes, mut buffered) = if pre_expansion {
1568 sess.lint_store.borrow_mut().pre_expansion_passes.take().unwrap(),
1569 LintBuffer::default(),
1573 sess.lint_store.borrow_mut().early_passes.take().unwrap(),
1574 sess.buffered_lints.borrow_mut().take().unwrap(),
1578 if !sess.opts.debugging_opts.no_interleave_lints {
1579 buffered = early_lint_crate(sess, krate, builtin_lints, buffered);
1581 if !passes.is_empty() {
1582 buffered = early_lint_crate(
1585 EarlyLintPassObjects { lints: &mut passes[..] },
1590 for pass in &mut passes {
1591 buffered = time(sess, &format!("running lint: {}", pass.name()), || {
1595 EarlyLintPassObjects { lints: slice::from_mut(pass) },
1602 // Put the lint store levels and passes back in the session.
1604 sess.lint_store.borrow_mut().pre_expansion_passes = Some(passes);
1606 sess.lint_store.borrow_mut().early_passes = Some(passes);
1609 // All of the buffered lints should have been emitted at this point.
1610 // If not, that means that we somehow buffered a lint for a node id
1611 // that was not lint-checked (perhaps it doesn't exist?). This is a bug.
1613 // Rustdoc runs everybody-loops before the early lints and removes
1614 // function bodies, so it's totally possible for linted
1615 // node ids to not exist (e.g., macros defined within functions for the
1616 // unused_macro lint) anymore. So we only run this check
1617 // when we're not in rustdoc mode. (see issue #47639)
1618 if !sess.opts.actually_rustdoc {
1619 for (_id, lints) in buffered.map {
1620 for early_lint in lints {
1621 sess.delay_span_bug(early_lint.span, "failed to process buffered lint here");
1627 impl Encodable for LintId {
1628 fn encode<S: Encoder>(&self, s: &mut S) -> Result<(), S::Error> {
1629 s.emit_str(&self.lint.name.to_lowercase())
1633 impl Decodable for LintId {
1635 fn decode<D: Decoder>(d: &mut D) -> Result<LintId, D::Error> {
1636 let s = d.read_str()?;
1637 ty::tls::with(|tcx| {
1638 match tcx.sess.lint_store.borrow().find_lints(&s) {
1641 panic!("invalid lint-id `{}`", s);
1645 Err(_) => panic!("invalid lint-id `{}`", s),