1 use crate::hir::def_id::{DefId, DefIndex, CRATE_DEF_INDEX};
2 use crate::hir::{self, intravisit, HirId, ItemLocalId};
3 use crate::hir::itemlikevisit::ItemLikeVisitor;
4 use rustc_data_structures::fx::FxHashSet;
5 use rustc_data_structures::sync::{Lock, ParallelIterator, par_iter};
7 pub fn check_crate(hir_map: &hir::map::Map<'_>) {
8 hir_map.dep_graph.assert_ignored();
10 let errors = Lock::new(Vec::new());
12 par_iter(&hir_map.krate().modules).for_each(|(module_id, _)| {
13 let local_def_id = hir_map.local_def_id_from_node_id(*module_id);
14 hir_map.visit_item_likes_in_module(local_def_id, &mut OuterVisitor {
20 let errors = errors.into_inner();
22 if !errors.is_empty() {
25 .fold(String::new(), |s1, s2| s1 + "\n" + s2);
30 struct HirIdValidator<'a, 'hir> {
31 hir_map: &'a hir::map::Map<'hir>,
32 owner_def_index: Option<DefIndex>,
33 hir_ids_seen: FxHashSet<ItemLocalId>,
34 errors: &'a Lock<Vec<String>>,
37 struct OuterVisitor<'a, 'hir> {
38 hir_map: &'a hir::map::Map<'hir>,
39 errors: &'a Lock<Vec<String>>,
42 impl<'a, 'hir> OuterVisitor<'a, 'hir> {
43 fn new_inner_visitor(&self,
44 hir_map: &'a hir::map::Map<'hir>)
45 -> HirIdValidator<'a, 'hir> {
48 owner_def_index: None,
49 hir_ids_seen: Default::default(),
55 impl<'a, 'hir> ItemLikeVisitor<'hir> for OuterVisitor<'a, 'hir> {
56 fn visit_item(&mut self, i: &'hir hir::Item) {
57 let mut inner_visitor = self.new_inner_visitor(self.hir_map);
58 inner_visitor.check(i.hir_id, |this| intravisit::walk_item(this, i));
61 fn visit_trait_item(&mut self, i: &'hir hir::TraitItem) {
62 let mut inner_visitor = self.new_inner_visitor(self.hir_map);
63 inner_visitor.check(i.hir_id, |this| intravisit::walk_trait_item(this, i));
66 fn visit_impl_item(&mut self, i: &'hir hir::ImplItem) {
67 let mut inner_visitor = self.new_inner_visitor(self.hir_map);
68 inner_visitor.check(i.hir_id, |this| intravisit::walk_impl_item(this, i));
72 impl<'a, 'hir> HirIdValidator<'a, 'hir> {
75 fn error(&self, f: impl FnOnce() -> String) {
76 self.errors.lock().push(f());
79 fn check<F: FnOnce(&mut HirIdValidator<'a, 'hir>)>(&mut self,
82 assert!(self.owner_def_index.is_none());
83 let owner_def_index = self.hir_map.local_def_id(hir_id).index;
84 self.owner_def_index = Some(owner_def_index);
87 if owner_def_index == CRATE_DEF_INDEX {
91 // There's always at least one entry for the owning item itself
92 let max = self.hir_ids_seen
94 .map(|local_id| local_id.as_usize())
96 .expect("owning item has no entry");
98 if max != self.hir_ids_seen.len() - 1 {
99 // Collect the missing ItemLocalIds
100 let missing: Vec<_> = (0 ..= max as u32)
101 .filter(|&i| !self.hir_ids_seen.contains(&ItemLocalId::from_u32(i)))
104 // Try to map those to something more useful
105 let mut missing_items = Vec::with_capacity(missing.len());
107 for local_id in missing {
109 owner: owner_def_index,
110 local_id: ItemLocalId::from_u32(local_id),
113 trace!("missing hir id {:#?}", hir_id);
115 missing_items.push(format!("[local_id: {}, node:{}]",
117 self.hir_map.node_to_string(hir_id)));
119 self.error(|| format!(
120 "ItemLocalIds not assigned densely in {}. \
121 Max ItemLocalId = {}, missing IDs = {:?}; seens IDs = {:?}",
122 self.hir_map.def_path(DefId::local(owner_def_index)).to_string_no_crate(),
127 .map(|&local_id| HirId {
128 owner: owner_def_index,
131 .map(|h| format!("({:?} {})", h, self.hir_map.node_to_string(h)))
132 .collect::<Vec<_>>()));
137 impl<'a, 'hir> intravisit::Visitor<'hir> for HirIdValidator<'a, 'hir> {
139 fn nested_visit_map<'this>(&'this mut self)
140 -> intravisit::NestedVisitorMap<'this, 'hir> {
141 intravisit::NestedVisitorMap::OnlyBodies(self.hir_map)
144 fn visit_id(&mut self, hir_id: HirId) {
145 let owner = self.owner_def_index.expect("no owner_def_index");
147 if hir_id == hir::DUMMY_HIR_ID {
148 self.error(|| format!("HirIdValidator: HirId {:?} is invalid",
149 self.hir_map.node_to_string(hir_id)));
153 if owner != hir_id.owner {
154 self.error(|| format!(
155 "HirIdValidator: The recorded owner of {} is {} instead of {}",
156 self.hir_map.node_to_string(hir_id),
157 self.hir_map.def_path(DefId::local(hir_id.owner)).to_string_no_crate(),
158 self.hir_map.def_path(DefId::local(owner)).to_string_no_crate()));
161 self.hir_ids_seen.insert(hir_id.local_id);
164 fn visit_impl_item_ref(&mut self, _: &'hir hir::ImplItemRef) {
165 // Explicitly do nothing here. ImplItemRefs contain hir::Visibility
166 // values that actually belong to an ImplItem instead of the ItemKind::Impl
167 // we are currently in. So for those it's correct that they have a