]> git.lizzy.rs Git - rust.git/blob - src/librustc/hir/lowering.rs
Rollup merge of #35710 - matthew-piziak:explicit-drop, r=steveklabnik
[rust.git] / src / librustc / hir / lowering.rs
1 // Copyright 2015 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
4 //
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
10
11 // Lowers the AST to the HIR.
12 //
13 // Since the AST and HIR are fairly similar, this is mostly a simple procedure,
14 // much like a fold. Where lowering involves a bit more work things get more
15 // interesting and there are some invariants you should know about. These mostly
16 // concern spans and ids.
17 //
18 // Spans are assigned to AST nodes during parsing and then are modified during
19 // expansion to indicate the origin of a node and the process it went through
20 // being expanded. Ids are assigned to AST nodes just before lowering.
21 //
22 // For the simpler lowering steps, ids and spans should be preserved. Unlike
23 // expansion we do not preserve the process of lowering in the spans, so spans
24 // should not be modified here. When creating a new node (as opposed to
25 // 'folding' an existing one), then you create a new id using `next_id()`.
26 //
27 // You must ensure that ids are unique. That means that you should only use the
28 // id from an AST node in a single HIR node (you can assume that AST node ids
29 // are unique). Every new node must have a unique id. Avoid cloning HIR nodes.
30 // If you do, you must then set the new node's id to a fresh one.
31 //
32 // Spans are used for error messages and for tools to map semantics back to
33 // source code. It is therefore not as important with spans as ids to be strict
34 // about use (you can't break the compiler by screwing up a span). Obviously, a
35 // HIR node can only have a single span. But multiple nodes can have the same
36 // span and spans don't need to be kept in order, etc. Where code is preserved
37 // by lowering, it should have the same span as in the AST. Where HIR nodes are
38 // new it is probably best to give a span for the whole AST node being lowered.
39 // All nodes should have real spans, don't use dummy spans. Tools are likely to
40 // get confused if the spans from leaf AST nodes occur in multiple places
41 // in the HIR, especially for multiple identifiers.
42
43 use hir;
44 use hir::map::Definitions;
45 use hir::map::definitions::DefPathData;
46 use hir::def_id::{DefIndex, DefId};
47 use hir::def::{Def, PathResolution};
48 use session::Session;
49
50 use std::collections::BTreeMap;
51 use std::iter;
52 use syntax::ast::*;
53 use syntax::errors;
54 use syntax::ptr::P;
55 use syntax::codemap::{respan, Spanned};
56 use syntax::parse::token;
57 use syntax::std_inject;
58 use syntax::visit::{self, Visitor};
59 use syntax_pos::Span;
60
61 pub struct LoweringContext<'a> {
62     crate_root: Option<&'static str>,
63     // Use to assign ids to hir nodes that do not directly correspond to an ast node
64     sess: Option<&'a Session>,
65     // As we walk the AST we must keep track of the current 'parent' def id (in
66     // the form of a DefIndex) so that if we create a new node which introduces
67     // a definition, then we can properly create the def id.
68     parent_def: Option<DefIndex>,
69     resolver: &'a mut Resolver,
70 }
71
72 pub trait Resolver {
73     // Resolve a global hir path generated by the lowerer when expanding `for`, `if let`, etc.
74     fn resolve_generated_global_path(&mut self, path: &hir::Path, is_value: bool) -> Def;
75
76     // Obtain the resolution for a node id
77     fn get_resolution(&mut self, id: NodeId) -> Option<PathResolution>;
78
79     // Record the resolution of a path or binding generated by the lowerer when expanding.
80     fn record_resolution(&mut self, id: NodeId, def: Def);
81
82     // We must keep the set of definitions up to date as we add nodes that weren't in the AST.
83     // This should only return `None` during testing.
84     fn definitions(&mut self) -> Option<&mut Definitions>;
85 }
86
87 pub struct DummyResolver;
88 impl Resolver for DummyResolver {
89     fn resolve_generated_global_path(&mut self, _path: &hir::Path, _is_value: bool) -> Def {
90         Def::Err
91     }
92     fn get_resolution(&mut self, _id: NodeId) -> Option<PathResolution> {
93         None
94     }
95     fn record_resolution(&mut self, _id: NodeId, _def: Def) {}
96     fn definitions(&mut self) -> Option<&mut Definitions> {
97         None
98     }
99 }
100
101 pub fn lower_crate(sess: &Session,
102                    krate: &Crate,
103                    resolver: &mut Resolver)
104                    -> hir::Crate {
105     // We're constructing the HIR here; we don't care what we will
106     // read, since we haven't even constructed the *input* to
107     // incr. comp. yet.
108     let _ignore = sess.dep_graph.in_ignore();
109
110     LoweringContext {
111         crate_root: if std_inject::no_core(krate) {
112             None
113         } else if std_inject::no_std(krate) {
114             Some("core")
115         } else {
116             Some("std")
117         },
118         sess: Some(sess),
119         parent_def: None,
120         resolver: resolver,
121     }.lower_crate(krate)
122 }
123
124 impl<'a> LoweringContext<'a> {
125     pub fn testing_context(resolver: &'a mut Resolver) -> Self {
126         LoweringContext {
127             crate_root: None,
128             sess: None,
129             parent_def: None,
130             resolver: resolver,
131         }
132     }
133
134     fn lower_crate(&mut self, c: &Crate) -> hir::Crate {
135         struct ItemLowerer<'lcx, 'interner: 'lcx> {
136             items: BTreeMap<NodeId, hir::Item>,
137             lctx: &'lcx mut LoweringContext<'interner>,
138         }
139
140         impl<'lcx, 'interner> Visitor for ItemLowerer<'lcx, 'interner> {
141             fn visit_item(&mut self, item: &Item) {
142                 self.items.insert(item.id, self.lctx.lower_item(item));
143                 visit::walk_item(self, item);
144             }
145         }
146
147         let items = {
148             let mut item_lowerer = ItemLowerer { items: BTreeMap::new(), lctx: self };
149             visit::walk_crate(&mut item_lowerer, c);
150             item_lowerer.items
151         };
152
153         hir::Crate {
154             module: self.lower_mod(&c.module),
155             attrs: self.lower_attrs(&c.attrs),
156             config: c.config.clone().into(),
157             span: c.span,
158             exported_macros: c.exported_macros.iter().map(|m| self.lower_macro_def(m)).collect(),
159             items: items,
160         }
161     }
162
163     fn next_id(&self) -> NodeId {
164         self.sess.map(Session::next_node_id).unwrap_or(0)
165     }
166
167     fn diagnostic(&self) -> &errors::Handler {
168         self.sess.map(Session::diagnostic)
169                  .unwrap_or_else(|| panic!("this lowerer cannot emit diagnostics"))
170     }
171
172     fn str_to_ident(&self, s: &'static str) -> Name {
173         token::gensym(s)
174     }
175
176     fn with_parent_def<T, F>(&mut self, parent_id: NodeId, f: F) -> T
177         where F: FnOnce(&mut LoweringContext) -> T
178     {
179         let old_def = self.parent_def;
180         self.parent_def = match self.resolver.definitions() {
181             Some(defs) => Some(defs.opt_def_index(parent_id).unwrap()),
182             None => old_def,
183         };
184
185         let result = f(self);
186
187         self.parent_def = old_def;
188         result
189     }
190
191     fn lower_opt_sp_ident(&mut self, o_id: Option<Spanned<Ident>>) -> Option<Spanned<Name>> {
192         o_id.map(|sp_ident| respan(sp_ident.span, sp_ident.node.name))
193     }
194
195     fn lower_attrs(&mut self, attrs: &Vec<Attribute>) -> hir::HirVec<Attribute> {
196         attrs.clone().into()
197     }
198
199     fn lower_view_path(&mut self, view_path: &ViewPath) -> P<hir::ViewPath> {
200         P(Spanned {
201             node: match view_path.node {
202                 ViewPathSimple(ident, ref path) => {
203                     hir::ViewPathSimple(ident.name, self.lower_path(path))
204                 }
205                 ViewPathGlob(ref path) => {
206                     hir::ViewPathGlob(self.lower_path(path))
207                 }
208                 ViewPathList(ref path, ref path_list_idents) => {
209                     hir::ViewPathList(self.lower_path(path),
210                                       path_list_idents.iter()
211                                                       .map(|item| self.lower_path_list_item(item))
212                                                       .collect())
213                 }
214             },
215             span: view_path.span,
216         })
217     }
218
219     fn lower_path_list_item(&mut self, path_list_ident: &PathListItem) -> hir::PathListItem {
220         Spanned {
221             node: match path_list_ident.node {
222                 PathListItemKind::Ident { id, name, rename } => hir::PathListIdent {
223                     id: id,
224                     name: name.name,
225                     rename: rename.map(|x| x.name),
226                 },
227                 PathListItemKind::Mod { id, rename } => hir::PathListMod {
228                     id: id,
229                     rename: rename.map(|x| x.name),
230                 },
231             },
232             span: path_list_ident.span,
233         }
234     }
235
236     fn lower_arm(&mut self, arm: &Arm) -> hir::Arm {
237         hir::Arm {
238             attrs: self.lower_attrs(&arm.attrs),
239             pats: arm.pats.iter().map(|x| self.lower_pat(x)).collect(),
240             guard: arm.guard.as_ref().map(|ref x| self.lower_expr(x)),
241             body: self.lower_expr(&arm.body),
242         }
243     }
244
245     fn lower_ty_binding(&mut self, b: &TypeBinding) -> hir::TypeBinding {
246         hir::TypeBinding {
247             id: b.id,
248             name: b.ident.name,
249             ty: self.lower_ty(&b.ty),
250             span: b.span,
251         }
252     }
253
254     fn lower_ty(&mut self, t: &Ty) -> P<hir::Ty> {
255         use syntax::ast::TyKind::*;
256         P(hir::Ty {
257             id: t.id,
258             node: match t.node {
259                 Infer | ImplicitSelf => hir::TyInfer,
260                 Vec(ref ty) => hir::TyVec(self.lower_ty(ty)),
261                 Ptr(ref mt) => hir::TyPtr(self.lower_mt(mt)),
262                 Rptr(ref region, ref mt) => {
263                     hir::TyRptr(self.lower_opt_lifetime(region), self.lower_mt(mt))
264                 }
265                 BareFn(ref f) => {
266                     hir::TyBareFn(P(hir::BareFnTy {
267                         lifetimes: self.lower_lifetime_defs(&f.lifetimes),
268                         unsafety: self.lower_unsafety(f.unsafety),
269                         abi: f.abi,
270                         decl: self.lower_fn_decl(&f.decl),
271                     }))
272                 }
273                 Never => hir::TyNever,
274                 Tup(ref tys) => hir::TyTup(tys.iter().map(|ty| self.lower_ty(ty)).collect()),
275                 Paren(ref ty) => {
276                     return self.lower_ty(ty);
277                 }
278                 Path(ref qself, ref path) => {
279                     let qself = qself.as_ref().map(|&QSelf { ref ty, position }| {
280                         hir::QSelf {
281                             ty: self.lower_ty(ty),
282                             position: position,
283                         }
284                     });
285                     hir::TyPath(qself, self.lower_path(path))
286                 }
287                 ObjectSum(ref ty, ref bounds) => {
288                     hir::TyObjectSum(self.lower_ty(ty), self.lower_bounds(bounds))
289                 }
290                 FixedLengthVec(ref ty, ref e) => {
291                     hir::TyFixedLengthVec(self.lower_ty(ty), self.lower_expr(e))
292                 }
293                 Typeof(ref expr) => {
294                     hir::TyTypeof(self.lower_expr(expr))
295                 }
296                 PolyTraitRef(ref bounds) => {
297                     hir::TyPolyTraitRef(self.lower_bounds(bounds))
298                 }
299                 ImplTrait(ref bounds) => {
300                     hir::TyImplTrait(self.lower_bounds(bounds))
301                 }
302                 Mac(_) => panic!("TyMac should have been expanded by now."),
303             },
304             span: t.span,
305         })
306     }
307
308     fn lower_foreign_mod(&mut self, fm: &ForeignMod) -> hir::ForeignMod {
309         hir::ForeignMod {
310             abi: fm.abi,
311             items: fm.items.iter().map(|x| self.lower_foreign_item(x)).collect(),
312         }
313     }
314
315     fn lower_variant(&mut self, v: &Variant) -> hir::Variant {
316         Spanned {
317             node: hir::Variant_ {
318                 name: v.node.name.name,
319                 attrs: self.lower_attrs(&v.node.attrs),
320                 data: self.lower_variant_data(&v.node.data),
321                 disr_expr: v.node.disr_expr.as_ref().map(|e| self.lower_expr(e)),
322             },
323             span: v.span,
324         }
325     }
326
327     fn lower_path(&mut self, p: &Path) -> hir::Path {
328         hir::Path {
329             global: p.global,
330             segments: p.segments
331                        .iter()
332                        .map(|&PathSegment { identifier, ref parameters }| {
333                            hir::PathSegment {
334                                name: identifier.name,
335                                parameters: self.lower_path_parameters(parameters),
336                            }
337                        })
338                        .collect(),
339             span: p.span,
340         }
341     }
342
343     fn lower_path_parameters(&mut self, path_parameters: &PathParameters) -> hir::PathParameters {
344         match *path_parameters {
345             PathParameters::AngleBracketed(ref data) =>
346                 hir::AngleBracketedParameters(self.lower_angle_bracketed_parameter_data(data)),
347             PathParameters::Parenthesized(ref data) =>
348                 hir::ParenthesizedParameters(self.lower_parenthesized_parameter_data(data)),
349         }
350     }
351
352     fn lower_angle_bracketed_parameter_data(&mut self,
353                                             data: &AngleBracketedParameterData)
354                                             -> hir::AngleBracketedParameterData {
355         let &AngleBracketedParameterData { ref lifetimes, ref types, ref bindings } = data;
356         hir::AngleBracketedParameterData {
357             lifetimes: self.lower_lifetimes(lifetimes),
358             types: types.iter().map(|ty| self.lower_ty(ty)).collect(),
359             bindings: bindings.iter().map(|b| self.lower_ty_binding(b)).collect(),
360         }
361     }
362
363     fn lower_parenthesized_parameter_data(&mut self,
364                                           data: &ParenthesizedParameterData)
365                                           -> hir::ParenthesizedParameterData {
366         let &ParenthesizedParameterData { ref inputs, ref output, span } = data;
367         hir::ParenthesizedParameterData {
368             inputs: inputs.iter().map(|ty| self.lower_ty(ty)).collect(),
369             output: output.as_ref().map(|ty| self.lower_ty(ty)),
370             span: span,
371         }
372     }
373
374     fn lower_local(&mut self, l: &Local) -> P<hir::Local> {
375         P(hir::Local {
376             id: l.id,
377             ty: l.ty.as_ref().map(|t| self.lower_ty(t)),
378             pat: self.lower_pat(&l.pat),
379             init: l.init.as_ref().map(|e| self.lower_expr(e)),
380             span: l.span,
381             attrs: l.attrs.clone(),
382         })
383     }
384
385     fn lower_mutability(&mut self, m: Mutability) -> hir::Mutability {
386         match m {
387             Mutability::Mutable => hir::MutMutable,
388             Mutability::Immutable => hir::MutImmutable,
389         }
390     }
391
392     fn lower_arg(&mut self, arg: &Arg) -> hir::Arg {
393         hir::Arg {
394             id: arg.id,
395             pat: self.lower_pat(&arg.pat),
396             ty: self.lower_ty(&arg.ty),
397         }
398     }
399
400     fn lower_fn_decl(&mut self, decl: &FnDecl) -> P<hir::FnDecl> {
401         P(hir::FnDecl {
402             inputs: decl.inputs.iter().map(|x| self.lower_arg(x)).collect(),
403             output: match decl.output {
404                 FunctionRetTy::Ty(ref ty) => hir::Return(self.lower_ty(ty)),
405                 FunctionRetTy::Default(span) => hir::DefaultReturn(span),
406             },
407             variadic: decl.variadic,
408         })
409     }
410
411     fn lower_ty_param_bound(&mut self, tpb: &TyParamBound) -> hir::TyParamBound {
412         match *tpb {
413             TraitTyParamBound(ref ty, modifier) => {
414                 hir::TraitTyParamBound(self.lower_poly_trait_ref(ty),
415                                        self.lower_trait_bound_modifier(modifier))
416             }
417             RegionTyParamBound(ref lifetime) => {
418                 hir::RegionTyParamBound(self.lower_lifetime(lifetime))
419             }
420         }
421     }
422
423     fn lower_ty_param(&mut self, tp: &TyParam) -> hir::TyParam {
424         hir::TyParam {
425             id: tp.id,
426             name: tp.ident.name,
427             bounds: self.lower_bounds(&tp.bounds),
428             default: tp.default.as_ref().map(|x| self.lower_ty(x)),
429             span: tp.span,
430         }
431     }
432
433     fn lower_ty_params(&mut self, tps: &P<[TyParam]>) -> hir::HirVec<hir::TyParam> {
434         tps.iter().map(|tp| self.lower_ty_param(tp)).collect()
435     }
436
437     fn lower_lifetime(&mut self, l: &Lifetime) -> hir::Lifetime {
438         hir::Lifetime {
439             id: l.id,
440             name: l.name,
441             span: l.span,
442         }
443     }
444
445     fn lower_lifetime_def(&mut self, l: &LifetimeDef) -> hir::LifetimeDef {
446         hir::LifetimeDef {
447             lifetime: self.lower_lifetime(&l.lifetime),
448             bounds: self.lower_lifetimes(&l.bounds),
449         }
450     }
451
452     fn lower_lifetimes(&mut self, lts: &Vec<Lifetime>) -> hir::HirVec<hir::Lifetime> {
453         lts.iter().map(|l| self.lower_lifetime(l)).collect()
454     }
455
456     fn lower_lifetime_defs(&mut self, lts: &Vec<LifetimeDef>) -> hir::HirVec<hir::LifetimeDef> {
457         lts.iter().map(|l| self.lower_lifetime_def(l)).collect()
458     }
459
460     fn lower_opt_lifetime(&mut self, o_lt: &Option<Lifetime>) -> Option<hir::Lifetime> {
461         o_lt.as_ref().map(|lt| self.lower_lifetime(lt))
462     }
463
464     fn lower_generics(&mut self, g: &Generics) -> hir::Generics {
465         hir::Generics {
466             ty_params: self.lower_ty_params(&g.ty_params),
467             lifetimes: self.lower_lifetime_defs(&g.lifetimes),
468             where_clause: self.lower_where_clause(&g.where_clause),
469         }
470     }
471
472     fn lower_where_clause(&mut self, wc: &WhereClause) -> hir::WhereClause {
473         hir::WhereClause {
474             id: wc.id,
475             predicates: wc.predicates
476                           .iter()
477                           .map(|predicate| self.lower_where_predicate(predicate))
478                           .collect(),
479         }
480     }
481
482     fn lower_where_predicate(&mut self, pred: &WherePredicate) -> hir::WherePredicate {
483         match *pred {
484             WherePredicate::BoundPredicate(WhereBoundPredicate{ ref bound_lifetimes,
485                                                                 ref bounded_ty,
486                                                                 ref bounds,
487                                                                 span}) => {
488                 hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate {
489                     bound_lifetimes: self.lower_lifetime_defs(bound_lifetimes),
490                     bounded_ty: self.lower_ty(bounded_ty),
491                     bounds: bounds.iter().map(|x| self.lower_ty_param_bound(x)).collect(),
492                     span: span,
493                 })
494             }
495             WherePredicate::RegionPredicate(WhereRegionPredicate{ ref lifetime,
496                                                                   ref bounds,
497                                                                   span}) => {
498                 hir::WherePredicate::RegionPredicate(hir::WhereRegionPredicate {
499                     span: span,
500                     lifetime: self.lower_lifetime(lifetime),
501                     bounds: bounds.iter().map(|bound| self.lower_lifetime(bound)).collect(),
502                 })
503             }
504             WherePredicate::EqPredicate(WhereEqPredicate{ id,
505                                                           ref path,
506                                                           ref ty,
507                                                           span}) => {
508                 hir::WherePredicate::EqPredicate(hir::WhereEqPredicate {
509                     id: id,
510                     path: self.lower_path(path),
511                     ty: self.lower_ty(ty),
512                     span: span,
513                 })
514             }
515         }
516     }
517
518     fn lower_variant_data(&mut self, vdata: &VariantData) -> hir::VariantData {
519         match *vdata {
520             VariantData::Struct(ref fields, id) => {
521                 hir::VariantData::Struct(fields.iter()
522                                                .enumerate()
523                                                .map(|f| self.lower_struct_field(f))
524                                                .collect(),
525                                          id)
526             }
527             VariantData::Tuple(ref fields, id) => {
528                 hir::VariantData::Tuple(fields.iter()
529                                               .enumerate()
530                                               .map(|f| self.lower_struct_field(f))
531                                               .collect(),
532                                         id)
533             }
534             VariantData::Unit(id) => hir::VariantData::Unit(id),
535         }
536     }
537
538     fn lower_trait_ref(&mut self, p: &TraitRef) -> hir::TraitRef {
539         hir::TraitRef {
540             path: self.lower_path(&p.path),
541             ref_id: p.ref_id,
542         }
543     }
544
545     fn lower_poly_trait_ref(&mut self, p: &PolyTraitRef) -> hir::PolyTraitRef {
546         hir::PolyTraitRef {
547             bound_lifetimes: self.lower_lifetime_defs(&p.bound_lifetimes),
548             trait_ref: self.lower_trait_ref(&p.trait_ref),
549             span: p.span,
550         }
551     }
552
553     fn lower_struct_field(&mut self, (index, f): (usize, &StructField)) -> hir::StructField {
554         hir::StructField {
555             span: f.span,
556             id: f.id,
557             name: f.ident.map(|ident| ident.name).unwrap_or(token::intern(&index.to_string())),
558             vis: self.lower_visibility(&f.vis),
559             ty: self.lower_ty(&f.ty),
560             attrs: self.lower_attrs(&f.attrs),
561         }
562     }
563
564     fn lower_field(&mut self, f: &Field) -> hir::Field {
565         hir::Field {
566             name: respan(f.ident.span, f.ident.node.name),
567             expr: self.lower_expr(&f.expr),
568             span: f.span,
569         }
570     }
571
572     fn lower_mt(&mut self, mt: &MutTy) -> hir::MutTy {
573         hir::MutTy {
574             ty: self.lower_ty(&mt.ty),
575             mutbl: self.lower_mutability(mt.mutbl),
576         }
577     }
578
579     fn lower_bounds(&mut self, bounds: &TyParamBounds) -> hir::TyParamBounds {
580         bounds.iter().map(|bound| self.lower_ty_param_bound(bound)).collect()
581     }
582
583     fn lower_block(&mut self, b: &Block) -> P<hir::Block> {
584         let mut stmts = Vec::new();
585         let mut expr = None;
586
587         if let Some((last, rest)) = b.stmts.split_last() {
588             stmts = rest.iter().map(|s| self.lower_stmt(s)).collect::<Vec<_>>();
589             let last = self.lower_stmt(last);
590             if let hir::StmtExpr(e, _) = last.node {
591                 expr = Some(e);
592             } else {
593                 stmts.push(last);
594             }
595         }
596
597         P(hir::Block {
598             id: b.id,
599             stmts: stmts.into(),
600             expr: expr,
601             rules: self.lower_block_check_mode(&b.rules),
602             span: b.span,
603         })
604     }
605
606     fn lower_item_kind(&mut self, i: &ItemKind) -> hir::Item_ {
607         match *i {
608             ItemKind::ExternCrate(string) => hir::ItemExternCrate(string),
609             ItemKind::Use(ref view_path) => {
610                 hir::ItemUse(self.lower_view_path(view_path))
611             }
612             ItemKind::Static(ref t, m, ref e) => {
613                 hir::ItemStatic(self.lower_ty(t),
614                                 self.lower_mutability(m),
615                                 self.lower_expr(e))
616             }
617             ItemKind::Const(ref t, ref e) => {
618                 hir::ItemConst(self.lower_ty(t), self.lower_expr(e))
619             }
620             ItemKind::Fn(ref decl, unsafety, constness, abi, ref generics, ref body) => {
621                 hir::ItemFn(self.lower_fn_decl(decl),
622                             self.lower_unsafety(unsafety),
623                             self.lower_constness(constness),
624                             abi,
625                             self.lower_generics(generics),
626                             self.lower_block(body))
627             }
628             ItemKind::Mod(ref m) => hir::ItemMod(self.lower_mod(m)),
629             ItemKind::ForeignMod(ref nm) => hir::ItemForeignMod(self.lower_foreign_mod(nm)),
630             ItemKind::Ty(ref t, ref generics) => {
631                 hir::ItemTy(self.lower_ty(t), self.lower_generics(generics))
632             }
633             ItemKind::Enum(ref enum_definition, ref generics) => {
634                 hir::ItemEnum(hir::EnumDef {
635                                   variants: enum_definition.variants
636                                                            .iter()
637                                                            .map(|x| self.lower_variant(x))
638                                                            .collect(),
639                               },
640                               self.lower_generics(generics))
641             }
642             ItemKind::Struct(ref struct_def, ref generics) => {
643                 let struct_def = self.lower_variant_data(struct_def);
644                 hir::ItemStruct(struct_def, self.lower_generics(generics))
645             }
646             ItemKind::DefaultImpl(unsafety, ref trait_ref) => {
647                 hir::ItemDefaultImpl(self.lower_unsafety(unsafety),
648                                      self.lower_trait_ref(trait_ref))
649             }
650             ItemKind::Impl(unsafety, polarity, ref generics, ref ifce, ref ty, ref impl_items) => {
651                 let new_impl_items = impl_items.iter()
652                                                .map(|item| self.lower_impl_item(item))
653                                                .collect();
654                 let ifce = ifce.as_ref().map(|trait_ref| self.lower_trait_ref(trait_ref));
655                 hir::ItemImpl(self.lower_unsafety(unsafety),
656                               self.lower_impl_polarity(polarity),
657                               self.lower_generics(generics),
658                               ifce,
659                               self.lower_ty(ty),
660                               new_impl_items)
661             }
662             ItemKind::Trait(unsafety, ref generics, ref bounds, ref items) => {
663                 let bounds = self.lower_bounds(bounds);
664                 let items = items.iter().map(|item| self.lower_trait_item(item)).collect();
665                 hir::ItemTrait(self.lower_unsafety(unsafety),
666                                self.lower_generics(generics),
667                                bounds,
668                                items)
669             }
670             ItemKind::Mac(_) => panic!("Shouldn't still be around"),
671         }
672     }
673
674     fn lower_trait_item(&mut self, i: &TraitItem) -> hir::TraitItem {
675         self.with_parent_def(i.id, |this| {
676             hir::TraitItem {
677                 id: i.id,
678                 name: i.ident.name,
679                 attrs: this.lower_attrs(&i.attrs),
680                 node: match i.node {
681                     TraitItemKind::Const(ref ty, ref default) => {
682                         hir::ConstTraitItem(this.lower_ty(ty),
683                                             default.as_ref().map(|x| this.lower_expr(x)))
684                     }
685                     TraitItemKind::Method(ref sig, ref body) => {
686                         hir::MethodTraitItem(this.lower_method_sig(sig),
687                                              body.as_ref().map(|x| this.lower_block(x)))
688                     }
689                     TraitItemKind::Type(ref bounds, ref default) => {
690                         hir::TypeTraitItem(this.lower_bounds(bounds),
691                                            default.as_ref().map(|x| this.lower_ty(x)))
692                     }
693                     TraitItemKind::Macro(..) => panic!("Shouldn't exist any more"),
694                 },
695                 span: i.span,
696             }
697         })
698     }
699
700     fn lower_impl_item(&mut self, i: &ImplItem) -> hir::ImplItem {
701         self.with_parent_def(i.id, |this| {
702             hir::ImplItem {
703                 id: i.id,
704                 name: i.ident.name,
705                 attrs: this.lower_attrs(&i.attrs),
706                 vis: this.lower_visibility(&i.vis),
707                 defaultness: this.lower_defaultness(i.defaultness),
708                 node: match i.node {
709                     ImplItemKind::Const(ref ty, ref expr) => {
710                         hir::ImplItemKind::Const(this.lower_ty(ty), this.lower_expr(expr))
711                     }
712                     ImplItemKind::Method(ref sig, ref body) => {
713                         hir::ImplItemKind::Method(this.lower_method_sig(sig),
714                                                   this.lower_block(body))
715                     }
716                     ImplItemKind::Type(ref ty) => hir::ImplItemKind::Type(this.lower_ty(ty)),
717                     ImplItemKind::Macro(..) => panic!("Shouldn't exist any more"),
718                 },
719                 span: i.span,
720             }
721         })
722     }
723
724     fn lower_mod(&mut self, m: &Mod) -> hir::Mod {
725         hir::Mod {
726             inner: m.inner,
727             item_ids: m.items.iter().map(|x| self.lower_item_id(x)).collect(),
728         }
729     }
730
731     fn lower_macro_def(&mut self, m: &MacroDef) -> hir::MacroDef {
732         hir::MacroDef {
733             name: m.ident.name,
734             attrs: self.lower_attrs(&m.attrs),
735             id: m.id,
736             span: m.span,
737             imported_from: m.imported_from.map(|x| x.name),
738             export: m.export,
739             use_locally: m.use_locally,
740             allow_internal_unstable: m.allow_internal_unstable,
741             body: m.body.clone().into(),
742         }
743     }
744
745     fn lower_item_id(&mut self, i: &Item) -> hir::ItemId {
746         hir::ItemId { id: i.id }
747     }
748
749     pub fn lower_item(&mut self, i: &Item) -> hir::Item {
750         let node = self.with_parent_def(i.id, |this| {
751             this.lower_item_kind(&i.node)
752         });
753
754         hir::Item {
755             id: i.id,
756             name: i.ident.name,
757             attrs: self.lower_attrs(&i.attrs),
758             node: node,
759             vis: self.lower_visibility(&i.vis),
760             span: i.span,
761         }
762     }
763
764     fn lower_foreign_item(&mut self, i: &ForeignItem) -> hir::ForeignItem {
765         self.with_parent_def(i.id, |this| {
766             hir::ForeignItem {
767                 id: i.id,
768                 name: i.ident.name,
769                 attrs: this.lower_attrs(&i.attrs),
770                 node: match i.node {
771                     ForeignItemKind::Fn(ref fdec, ref generics) => {
772                         hir::ForeignItemFn(this.lower_fn_decl(fdec), this.lower_generics(generics))
773                     }
774                     ForeignItemKind::Static(ref t, m) => {
775                         hir::ForeignItemStatic(this.lower_ty(t), m)
776                     }
777                 },
778                 vis: this.lower_visibility(&i.vis),
779                 span: i.span,
780             }
781         })
782     }
783
784     fn lower_method_sig(&mut self, sig: &MethodSig) -> hir::MethodSig {
785         let hir_sig = hir::MethodSig {
786             generics: self.lower_generics(&sig.generics),
787             abi: sig.abi,
788             unsafety: self.lower_unsafety(sig.unsafety),
789             constness: self.lower_constness(sig.constness),
790             decl: self.lower_fn_decl(&sig.decl),
791         };
792         // Check for `self: _` and `self: &_`
793         if let Some(SelfKind::Explicit(..)) = sig.decl.get_self().map(|eself| eself.node) {
794             match hir_sig.decl.get_self().map(|eself| eself.node) {
795                 Some(hir::SelfKind::Value(..)) | Some(hir::SelfKind::Region(..)) => {
796                     self.diagnostic().span_err(sig.decl.inputs[0].ty.span,
797                         "the type placeholder `_` is not allowed within types on item signatures");
798                 }
799                 _ => {}
800             }
801         }
802         hir_sig
803     }
804
805     fn lower_unsafety(&mut self, u: Unsafety) -> hir::Unsafety {
806         match u {
807             Unsafety::Unsafe => hir::Unsafety::Unsafe,
808             Unsafety::Normal => hir::Unsafety::Normal,
809         }
810     }
811
812     fn lower_constness(&mut self, c: Constness) -> hir::Constness {
813         match c {
814             Constness::Const => hir::Constness::Const,
815             Constness::NotConst => hir::Constness::NotConst,
816         }
817     }
818
819     fn lower_unop(&mut self, u: UnOp) -> hir::UnOp {
820         match u {
821             UnOp::Deref => hir::UnDeref,
822             UnOp::Not => hir::UnNot,
823             UnOp::Neg => hir::UnNeg,
824         }
825     }
826
827     fn lower_binop(&mut self, b: BinOp) -> hir::BinOp {
828         Spanned {
829             node: match b.node {
830                 BinOpKind::Add => hir::BiAdd,
831                 BinOpKind::Sub => hir::BiSub,
832                 BinOpKind::Mul => hir::BiMul,
833                 BinOpKind::Div => hir::BiDiv,
834                 BinOpKind::Rem => hir::BiRem,
835                 BinOpKind::And => hir::BiAnd,
836                 BinOpKind::Or => hir::BiOr,
837                 BinOpKind::BitXor => hir::BiBitXor,
838                 BinOpKind::BitAnd => hir::BiBitAnd,
839                 BinOpKind::BitOr => hir::BiBitOr,
840                 BinOpKind::Shl => hir::BiShl,
841                 BinOpKind::Shr => hir::BiShr,
842                 BinOpKind::Eq => hir::BiEq,
843                 BinOpKind::Lt => hir::BiLt,
844                 BinOpKind::Le => hir::BiLe,
845                 BinOpKind::Ne => hir::BiNe,
846                 BinOpKind::Ge => hir::BiGe,
847                 BinOpKind::Gt => hir::BiGt,
848             },
849             span: b.span,
850         }
851     }
852
853     fn lower_pat(&mut self, p: &Pat) -> P<hir::Pat> {
854         P(hir::Pat {
855             id: p.id,
856             node: match p.node {
857                 PatKind::Wild => hir::PatKind::Wild,
858                 PatKind::Ident(ref binding_mode, pth1, ref sub) => {
859                     self.with_parent_def(p.id, |this| {
860                         match this.resolver.get_resolution(p.id).map(|d| d.base_def) {
861                             // `None` can occur in body-less function signatures
862                             None | Some(Def::Local(..)) => {
863                                 hir::PatKind::Binding(this.lower_binding_mode(binding_mode),
864                                                       respan(pth1.span, pth1.node.name),
865                                                       sub.as_ref().map(|x| this.lower_pat(x)))
866                             }
867                             _ => hir::PatKind::Path(None, hir::Path::from_name(pth1.span,
868                                                                                pth1.node.name))
869                         }
870                     })
871                 }
872                 PatKind::Lit(ref e) => hir::PatKind::Lit(self.lower_expr(e)),
873                 PatKind::TupleStruct(ref pth, ref pats, ddpos) => {
874                     hir::PatKind::TupleStruct(self.lower_path(pth),
875                                               pats.iter().map(|x| self.lower_pat(x)).collect(),
876                                               ddpos)
877                 }
878                 PatKind::Path(ref opt_qself, ref path) => {
879                     let opt_qself = opt_qself.as_ref().map(|qself| {
880                         hir::QSelf { ty: self.lower_ty(&qself.ty), position: qself.position }
881                     });
882                     hir::PatKind::Path(opt_qself, self.lower_path(path))
883                 }
884                 PatKind::Struct(ref pth, ref fields, etc) => {
885                     let pth = self.lower_path(pth);
886                     let fs = fields.iter()
887                                    .map(|f| {
888                                        Spanned {
889                                            span: f.span,
890                                            node: hir::FieldPat {
891                                                name: f.node.ident.name,
892                                                pat: self.lower_pat(&f.node.pat),
893                                                is_shorthand: f.node.is_shorthand,
894                                            },
895                                        }
896                                    })
897                                    .collect();
898                     hir::PatKind::Struct(pth, fs, etc)
899                 }
900                 PatKind::Tuple(ref elts, ddpos) => {
901                     hir::PatKind::Tuple(elts.iter().map(|x| self.lower_pat(x)).collect(), ddpos)
902                 }
903                 PatKind::Box(ref inner) => hir::PatKind::Box(self.lower_pat(inner)),
904                 PatKind::Ref(ref inner, mutbl) => {
905                     hir::PatKind::Ref(self.lower_pat(inner), self.lower_mutability(mutbl))
906                 }
907                 PatKind::Range(ref e1, ref e2) => {
908                     hir::PatKind::Range(self.lower_expr(e1), self.lower_expr(e2))
909                 }
910                 PatKind::Vec(ref before, ref slice, ref after) => {
911                     hir::PatKind::Vec(before.iter().map(|x| self.lower_pat(x)).collect(),
912                                 slice.as_ref().map(|x| self.lower_pat(x)),
913                                 after.iter().map(|x| self.lower_pat(x)).collect())
914                 }
915                 PatKind::Mac(_) => panic!("Shouldn't exist here"),
916             },
917             span: p.span,
918         })
919     }
920
921     fn lower_expr(&mut self, e: &Expr) -> P<hir::Expr> {
922         P(hir::Expr {
923             id: e.id,
924             node: match e.node {
925                 // Issue #22181:
926                 // Eventually a desugaring for `box EXPR`
927                 // (similar to the desugaring above for `in PLACE BLOCK`)
928                 // should go here, desugaring
929                 //
930                 // to:
931                 //
932                 // let mut place = BoxPlace::make_place();
933                 // let raw_place = Place::pointer(&mut place);
934                 // let value = $value;
935                 // unsafe {
936                 //     ::std::ptr::write(raw_place, value);
937                 //     Boxed::finalize(place)
938                 // }
939                 //
940                 // But for now there are type-inference issues doing that.
941                 ExprKind::Box(ref e) => {
942                     hir::ExprBox(self.lower_expr(e))
943                 }
944
945                 // Desugar ExprBox: `in (PLACE) EXPR`
946                 ExprKind::InPlace(ref placer, ref value_expr) => {
947                     // to:
948                     //
949                     // let p = PLACE;
950                     // let mut place = Placer::make_place(p);
951                     // let raw_place = Place::pointer(&mut place);
952                     // push_unsafe!({
953                     //     std::intrinsics::move_val_init(raw_place, pop_unsafe!( EXPR ));
954                     //     InPlace::finalize(place)
955                     // })
956                     let placer_expr = self.lower_expr(placer);
957                     let value_expr = self.lower_expr(value_expr);
958
959                     let placer_ident = self.str_to_ident("placer");
960                     let place_ident = self.str_to_ident("place");
961                     let p_ptr_ident = self.str_to_ident("p_ptr");
962
963                     let make_place = ["ops", "Placer", "make_place"];
964                     let place_pointer = ["ops", "Place", "pointer"];
965                     let move_val_init = ["intrinsics", "move_val_init"];
966                     let inplace_finalize = ["ops", "InPlace", "finalize"];
967
968                     let make_call = |this: &mut LoweringContext, p, args| {
969                         let path = this.core_path(e.span, p);
970                         let path = this.expr_path(path, ThinVec::new());
971                         this.expr_call(e.span, path, args)
972                     };
973
974                     let mk_stmt_let = |this: &mut LoweringContext, bind, expr| {
975                         this.stmt_let(e.span, false, bind, expr)
976                     };
977
978                     let mk_stmt_let_mut = |this: &mut LoweringContext, bind, expr| {
979                         this.stmt_let(e.span, true, bind, expr)
980                     };
981
982                     // let placer = <placer_expr> ;
983                     let (s1, placer_binding) = {
984                         let placer_expr = self.signal_block_expr(hir_vec![],
985                                                                  placer_expr,
986                                                                  e.span,
987                                                                  hir::PopUnstableBlock,
988                                                                  ThinVec::new());
989                         mk_stmt_let(self, placer_ident, placer_expr)
990                     };
991
992                     // let mut place = Placer::make_place(placer);
993                     let (s2, place_binding) = {
994                         let placer = self.expr_ident(e.span, placer_ident, placer_binding);
995                         let call = make_call(self, &make_place, hir_vec![placer]);
996                         mk_stmt_let_mut(self, place_ident, call)
997                     };
998
999                     // let p_ptr = Place::pointer(&mut place);
1000                     let (s3, p_ptr_binding) = {
1001                         let agent = self.expr_ident(e.span, place_ident, place_binding);
1002                         let args = hir_vec![self.expr_mut_addr_of(e.span, agent)];
1003                         let call = make_call(self, &place_pointer, args);
1004                         mk_stmt_let(self, p_ptr_ident, call)
1005                     };
1006
1007                     // pop_unsafe!(EXPR));
1008                     let pop_unsafe_expr = {
1009                         let value_expr = self.signal_block_expr(hir_vec![],
1010                                                                 value_expr,
1011                                                                 e.span,
1012                                                                 hir::PopUnstableBlock,
1013                                                                 ThinVec::new());
1014                         self.signal_block_expr(hir_vec![],
1015                                                value_expr,
1016                                                e.span,
1017                                                hir::PopUnsafeBlock(hir::CompilerGenerated),
1018                                                ThinVec::new())
1019                     };
1020
1021                     // push_unsafe!({
1022                     //     std::intrinsics::move_val_init(raw_place, pop_unsafe!( EXPR ));
1023                     //     InPlace::finalize(place)
1024                     // })
1025                     let expr = {
1026                         let ptr = self.expr_ident(e.span, p_ptr_ident, p_ptr_binding);
1027                         let call_move_val_init =
1028                             hir::StmtSemi(
1029                                 make_call(self, &move_val_init, hir_vec![ptr, pop_unsafe_expr]),
1030                                 self.next_id());
1031                         let call_move_val_init = respan(e.span, call_move_val_init);
1032
1033                         let place = self.expr_ident(e.span, place_ident, place_binding);
1034                         let call = make_call(self, &inplace_finalize, hir_vec![place]);
1035                         self.signal_block_expr(hir_vec![call_move_val_init],
1036                                                call,
1037                                                e.span,
1038                                                hir::PushUnsafeBlock(hir::CompilerGenerated),
1039                                                ThinVec::new())
1040                     };
1041
1042                     return self.signal_block_expr(hir_vec![s1, s2, s3],
1043                                                   expr,
1044                                                   e.span,
1045                                                   hir::PushUnstableBlock,
1046                                                   e.attrs.clone());
1047                 }
1048
1049                 ExprKind::Vec(ref exprs) => {
1050                     hir::ExprVec(exprs.iter().map(|x| self.lower_expr(x)).collect())
1051                 }
1052                 ExprKind::Repeat(ref expr, ref count) => {
1053                     let expr = self.lower_expr(expr);
1054                     let count = self.lower_expr(count);
1055                     hir::ExprRepeat(expr, count)
1056                 }
1057                 ExprKind::Tup(ref elts) => {
1058                     hir::ExprTup(elts.iter().map(|x| self.lower_expr(x)).collect())
1059                 }
1060                 ExprKind::Call(ref f, ref args) => {
1061                     let f = self.lower_expr(f);
1062                     hir::ExprCall(f, args.iter().map(|x| self.lower_expr(x)).collect())
1063                 }
1064                 ExprKind::MethodCall(i, ref tps, ref args) => {
1065                     let tps = tps.iter().map(|x| self.lower_ty(x)).collect();
1066                     let args = args.iter().map(|x| self.lower_expr(x)).collect();
1067                     hir::ExprMethodCall(respan(i.span, i.node.name), tps, args)
1068                 }
1069                 ExprKind::Binary(binop, ref lhs, ref rhs) => {
1070                     let binop = self.lower_binop(binop);
1071                     let lhs = self.lower_expr(lhs);
1072                     let rhs = self.lower_expr(rhs);
1073                     hir::ExprBinary(binop, lhs, rhs)
1074                 }
1075                 ExprKind::Unary(op, ref ohs) => {
1076                     let op = self.lower_unop(op);
1077                     let ohs = self.lower_expr(ohs);
1078                     hir::ExprUnary(op, ohs)
1079                 }
1080                 ExprKind::Lit(ref l) => hir::ExprLit(P((**l).clone())),
1081                 ExprKind::Cast(ref expr, ref ty) => {
1082                     let expr = self.lower_expr(expr);
1083                     hir::ExprCast(expr, self.lower_ty(ty))
1084                 }
1085                 ExprKind::Type(ref expr, ref ty) => {
1086                     let expr = self.lower_expr(expr);
1087                     hir::ExprType(expr, self.lower_ty(ty))
1088                 }
1089                 ExprKind::AddrOf(m, ref ohs) => {
1090                     let m = self.lower_mutability(m);
1091                     let ohs = self.lower_expr(ohs);
1092                     hir::ExprAddrOf(m, ohs)
1093                 }
1094                 // More complicated than you might expect because the else branch
1095                 // might be `if let`.
1096                 ExprKind::If(ref cond, ref blk, ref else_opt) => {
1097                     let else_opt = else_opt.as_ref().map(|els| {
1098                         match els.node {
1099                             ExprKind::IfLet(..) => {
1100                                 // wrap the if-let expr in a block
1101                                 let span = els.span;
1102                                 let els = self.lower_expr(els);
1103                                 let id = self.next_id();
1104                                 let blk = P(hir::Block {
1105                                     stmts: hir_vec![],
1106                                     expr: Some(els),
1107                                     id: id,
1108                                     rules: hir::DefaultBlock,
1109                                     span: span,
1110                                 });
1111                                 self.expr_block(blk, ThinVec::new())
1112                             }
1113                             _ => self.lower_expr(els),
1114                         }
1115                     });
1116
1117                     hir::ExprIf(self.lower_expr(cond), self.lower_block(blk), else_opt)
1118                 }
1119                 ExprKind::While(ref cond, ref body, opt_ident) => {
1120                     hir::ExprWhile(self.lower_expr(cond), self.lower_block(body),
1121                                    self.lower_opt_sp_ident(opt_ident))
1122                 }
1123                 ExprKind::Loop(ref body, opt_ident) => {
1124                     hir::ExprLoop(self.lower_block(body), self.lower_opt_sp_ident(opt_ident))
1125                 }
1126                 ExprKind::Match(ref expr, ref arms) => {
1127                     hir::ExprMatch(self.lower_expr(expr),
1128                                    arms.iter().map(|x| self.lower_arm(x)).collect(),
1129                                    hir::MatchSource::Normal)
1130                 }
1131                 ExprKind::Closure(capture_clause, ref decl, ref body, fn_decl_span) => {
1132                     self.with_parent_def(e.id, |this| {
1133                         hir::ExprClosure(this.lower_capture_clause(capture_clause),
1134                                          this.lower_fn_decl(decl),
1135                                          this.lower_block(body),
1136                                          fn_decl_span)
1137                     })
1138                 }
1139                 ExprKind::Block(ref blk) => hir::ExprBlock(self.lower_block(blk)),
1140                 ExprKind::Assign(ref el, ref er) => {
1141                     hir::ExprAssign(self.lower_expr(el), self.lower_expr(er))
1142                 }
1143                 ExprKind::AssignOp(op, ref el, ref er) => {
1144                     hir::ExprAssignOp(self.lower_binop(op),
1145                                       self.lower_expr(el),
1146                                       self.lower_expr(er))
1147                 }
1148                 ExprKind::Field(ref el, ident) => {
1149                     hir::ExprField(self.lower_expr(el), respan(ident.span, ident.node.name))
1150                 }
1151                 ExprKind::TupField(ref el, ident) => {
1152                     hir::ExprTupField(self.lower_expr(el), ident)
1153                 }
1154                 ExprKind::Index(ref el, ref er) => {
1155                     hir::ExprIndex(self.lower_expr(el), self.lower_expr(er))
1156                 }
1157                 ExprKind::Range(ref e1, ref e2, lims) => {
1158                     fn make_struct(this: &mut LoweringContext,
1159                                    ast_expr: &Expr,
1160                                    path: &[&str],
1161                                    fields: &[(&str, &P<Expr>)]) -> P<hir::Expr> {
1162                         let strs = this.std_path(&iter::once(&"ops")
1163                                                         .chain(path)
1164                                                         .map(|s| *s)
1165                                                         .collect::<Vec<_>>());
1166
1167                         let structpath = this.path_global(ast_expr.span, strs);
1168
1169                         let hir_expr = if fields.len() == 0 {
1170                             this.expr_path(structpath, ast_expr.attrs.clone())
1171                         } else {
1172                             let fields = fields.into_iter().map(|&(s, e)| {
1173                                 let expr = this.lower_expr(&e);
1174                                 let signal_block = this.signal_block_expr(hir_vec![],
1175                                                                           expr,
1176                                                                           e.span,
1177                                                                           hir::PopUnstableBlock,
1178                                                                           ThinVec::new());
1179                                 this.field(token::intern(s), signal_block, ast_expr.span)
1180                             }).collect();
1181                             let attrs = ast_expr.attrs.clone();
1182
1183                             this.expr_struct(ast_expr.span, structpath, fields, None, attrs)
1184                         };
1185
1186                         this.signal_block_expr(hir_vec![],
1187                                                hir_expr,
1188                                                ast_expr.span,
1189                                                hir::PushUnstableBlock,
1190                                                ThinVec::new())
1191                     }
1192
1193                     use syntax::ast::RangeLimits::*;
1194
1195                     return match (e1, e2, lims) {
1196                         (&None,         &None,         HalfOpen) =>
1197                             make_struct(self, e, &["RangeFull"], &[]),
1198
1199                         (&Some(ref e1), &None,         HalfOpen) =>
1200                             make_struct(self, e, &["RangeFrom"],
1201                                                  &[("start", e1)]),
1202
1203                         (&None,         &Some(ref e2), HalfOpen) =>
1204                             make_struct(self, e, &["RangeTo"],
1205                                                  &[("end", e2)]),
1206
1207                         (&Some(ref e1), &Some(ref e2), HalfOpen) =>
1208                             make_struct(self, e, &["Range"],
1209                                                  &[("start", e1), ("end", e2)]),
1210
1211                         (&None,         &Some(ref e2), Closed)   =>
1212                             make_struct(self, e, &["RangeToInclusive"],
1213                                                  &[("end", e2)]),
1214
1215                         (&Some(ref e1), &Some(ref e2), Closed)   =>
1216                             make_struct(self, e, &["RangeInclusive", "NonEmpty"],
1217                                                  &[("start", e1), ("end", e2)]),
1218
1219                         _ => panic!(self.diagnostic()
1220                                         .span_fatal(e.span, "inclusive range with no end")),
1221                     };
1222                 }
1223                 ExprKind::Path(ref qself, ref path) => {
1224                     let hir_qself = qself.as_ref().map(|&QSelf { ref ty, position }| {
1225                         hir::QSelf {
1226                             ty: self.lower_ty(ty),
1227                             position: position,
1228                         }
1229                     });
1230                     hir::ExprPath(hir_qself, self.lower_path(path))
1231                 }
1232                 ExprKind::Break(opt_ident) => hir::ExprBreak(self.lower_opt_sp_ident(opt_ident)),
1233                 ExprKind::Continue(opt_ident) => hir::ExprAgain(self.lower_opt_sp_ident(opt_ident)),
1234                 ExprKind::Ret(ref e) => hir::ExprRet(e.as_ref().map(|x| self.lower_expr(x))),
1235                 ExprKind::InlineAsm(InlineAsm {
1236                         ref inputs,
1237                         ref outputs,
1238                         ref asm,
1239                         asm_str_style,
1240                         ref clobbers,
1241                         volatile,
1242                         alignstack,
1243                         dialect,
1244                         expn_id,
1245                     }) => hir::ExprInlineAsm(hir::InlineAsm {
1246                     inputs: inputs.iter().map(|&(ref c, _)| c.clone()).collect(),
1247                     outputs: outputs.iter()
1248                                     .map(|out| {
1249                                         hir::InlineAsmOutput {
1250                                             constraint: out.constraint.clone(),
1251                                             is_rw: out.is_rw,
1252                                             is_indirect: out.is_indirect,
1253                                         }
1254                                     })
1255                                     .collect(),
1256                     asm: asm.clone(),
1257                     asm_str_style: asm_str_style,
1258                     clobbers: clobbers.clone().into(),
1259                     volatile: volatile,
1260                     alignstack: alignstack,
1261                     dialect: dialect,
1262                     expn_id: expn_id,
1263                 }, outputs.iter().map(|out| self.lower_expr(&out.expr)).collect(),
1264                    inputs.iter().map(|&(_, ref input)| self.lower_expr(input)).collect()),
1265                 ExprKind::Struct(ref path, ref fields, ref maybe_expr) => {
1266                     hir::ExprStruct(self.lower_path(path),
1267                                     fields.iter().map(|x| self.lower_field(x)).collect(),
1268                                     maybe_expr.as_ref().map(|x| self.lower_expr(x)))
1269                 }
1270                 ExprKind::Paren(ref ex) => {
1271                     return self.lower_expr(ex).map(|mut ex| {
1272                         // include parens in span, but only if it is a super-span.
1273                         if e.span.contains(ex.span) {
1274                             ex.span = e.span;
1275                         }
1276                         // merge attributes into the inner expression.
1277                         let mut attrs = e.attrs.clone();
1278                         attrs.extend::<Vec<_>>(ex.attrs.into());
1279                         ex.attrs = attrs;
1280                         ex
1281                     });
1282                 }
1283
1284                 // Desugar ExprIfLet
1285                 // From: `if let <pat> = <sub_expr> <body> [<else_opt>]`
1286                 ExprKind::IfLet(ref pat, ref sub_expr, ref body, ref else_opt) => {
1287                     // to:
1288                     //
1289                     //   match <sub_expr> {
1290                     //     <pat> => <body>,
1291                     //     [_ if <else_opt_if_cond> => <else_opt_if_body>,]
1292                     //     _ => [<else_opt> | ()]
1293                     //   }
1294
1295                     // `<pat> => <body>`
1296                     let pat_arm = {
1297                         let body = self.lower_block(body);
1298                         let body_expr = self.expr_block(body, ThinVec::new());
1299                         let pat = self.lower_pat(pat);
1300                         self.arm(hir_vec![pat], body_expr)
1301                     };
1302
1303                     // `[_ if <else_opt_if_cond> => <else_opt_if_body>,]`
1304                     let mut else_opt = else_opt.as_ref().map(|e| self.lower_expr(e));
1305                     let else_if_arms = {
1306                         let mut arms = vec![];
1307                         loop {
1308                             let else_opt_continue = else_opt.and_then(|els| {
1309                                 els.and_then(|els| {
1310                                     match els.node {
1311                                         // else if
1312                                         hir::ExprIf(cond, then, else_opt) => {
1313                                             let pat_under = self.pat_wild(e.span);
1314                                             arms.push(hir::Arm {
1315                                                 attrs: hir_vec![],
1316                                                 pats: hir_vec![pat_under],
1317                                                 guard: Some(cond),
1318                                                 body: self.expr_block(then, ThinVec::new()),
1319                                             });
1320                                             else_opt.map(|else_opt| (else_opt, true))
1321                                         }
1322                                         _ => Some((P(els), false)),
1323                                     }
1324                                 })
1325                             });
1326                             match else_opt_continue {
1327                                 Some((e, true)) => {
1328                                     else_opt = Some(e);
1329                                 }
1330                                 Some((e, false)) => {
1331                                     else_opt = Some(e);
1332                                     break;
1333                                 }
1334                                 None => {
1335                                     else_opt = None;
1336                                     break;
1337                                 }
1338                             }
1339                         }
1340                         arms
1341                     };
1342
1343                     let contains_else_clause = else_opt.is_some();
1344
1345                     // `_ => [<else_opt> | ()]`
1346                     let else_arm = {
1347                         let pat_under = self.pat_wild(e.span);
1348                         let else_expr =
1349                             else_opt.unwrap_or_else(|| self.expr_tuple(e.span, hir_vec![]));
1350                         self.arm(hir_vec![pat_under], else_expr)
1351                     };
1352
1353                     let mut arms = Vec::with_capacity(else_if_arms.len() + 2);
1354                     arms.push(pat_arm);
1355                     arms.extend(else_if_arms);
1356                     arms.push(else_arm);
1357
1358                     let sub_expr = self.lower_expr(sub_expr);
1359                     // add attributes to the outer returned expr node
1360                     return self.expr(e.span,
1361                                      hir::ExprMatch(sub_expr,
1362                                                     arms.into(),
1363                                                     hir::MatchSource::IfLetDesugar {
1364                                                         contains_else_clause: contains_else_clause,
1365                                                     }),
1366                                      e.attrs.clone());
1367                 }
1368
1369                 // Desugar ExprWhileLet
1370                 // From: `[opt_ident]: while let <pat> = <sub_expr> <body>`
1371                 ExprKind::WhileLet(ref pat, ref sub_expr, ref body, opt_ident) => {
1372                     // to:
1373                     //
1374                     //   [opt_ident]: loop {
1375                     //     match <sub_expr> {
1376                     //       <pat> => <body>,
1377                     //       _ => break
1378                     //     }
1379                     //   }
1380
1381                     // `<pat> => <body>`
1382                     let pat_arm = {
1383                         let body = self.lower_block(body);
1384                         let body_expr = self.expr_block(body, ThinVec::new());
1385                         let pat = self.lower_pat(pat);
1386                         self.arm(hir_vec![pat], body_expr)
1387                     };
1388
1389                     // `_ => break`
1390                     let break_arm = {
1391                         let pat_under = self.pat_wild(e.span);
1392                         let break_expr = self.expr_break(e.span, ThinVec::new());
1393                         self.arm(hir_vec![pat_under], break_expr)
1394                     };
1395
1396                     // `match <sub_expr> { ... }`
1397                     let arms = hir_vec![pat_arm, break_arm];
1398                     let sub_expr = self.lower_expr(sub_expr);
1399                     let match_expr = self.expr(e.span,
1400                                                hir::ExprMatch(sub_expr,
1401                                                               arms,
1402                                                               hir::MatchSource::WhileLetDesugar),
1403                                                ThinVec::new());
1404
1405                     // `[opt_ident]: loop { ... }`
1406                     let loop_block = self.block_expr(match_expr);
1407                     let loop_expr = hir::ExprLoop(loop_block, self.lower_opt_sp_ident(opt_ident));
1408                     // add attributes to the outer returned expr node
1409                     let attrs = e.attrs.clone();
1410                     return P(hir::Expr { id: e.id, node: loop_expr, span: e.span, attrs: attrs });
1411                 }
1412
1413                 // Desugar ExprForLoop
1414                 // From: `[opt_ident]: for <pat> in <head> <body>`
1415                 ExprKind::ForLoop(ref pat, ref head, ref body, opt_ident) => {
1416                     // to:
1417                     //
1418                     //   {
1419                     //     let result = match ::std::iter::IntoIterator::into_iter(<head>) {
1420                     //       mut iter => {
1421                     //         [opt_ident]: loop {
1422                     //           match ::std::iter::Iterator::next(&mut iter) {
1423                     //             ::std::option::Option::Some(<pat>) => <body>,
1424                     //             ::std::option::Option::None => break
1425                     //           }
1426                     //         }
1427                     //       }
1428                     //     };
1429                     //     result
1430                     //   }
1431
1432                     // expand <head>
1433                     let head = self.lower_expr(head);
1434
1435                     let iter = self.str_to_ident("iter");
1436
1437                     // `::std::option::Option::Some(<pat>) => <body>`
1438                     let pat_arm = {
1439                         let body_block = self.lower_block(body);
1440                         let body_span = body_block.span;
1441                         let body_expr = P(hir::Expr {
1442                             id: self.next_id(),
1443                             node: hir::ExprBlock(body_block),
1444                             span: body_span,
1445                             attrs: ThinVec::new(),
1446                         });
1447                         let pat = self.lower_pat(pat);
1448                         let some_pat = self.pat_some(e.span, pat);
1449
1450                         self.arm(hir_vec![some_pat], body_expr)
1451                     };
1452
1453                     // `::std::option::Option::None => break`
1454                     let break_arm = {
1455                         let break_expr = self.expr_break(e.span, ThinVec::new());
1456                         let pat = self.pat_none(e.span);
1457                         self.arm(hir_vec![pat], break_expr)
1458                     };
1459
1460                     // `mut iter`
1461                     let iter_pat = self.pat_ident_binding_mode(e.span, iter,
1462                                                                hir::BindByValue(hir::MutMutable));
1463
1464                     // `match ::std::iter::Iterator::next(&mut iter) { ... }`
1465                     let match_expr = {
1466                         let next_path = {
1467                             let strs = self.std_path(&["iter", "Iterator", "next"]);
1468
1469                             self.path_global(e.span, strs)
1470                         };
1471                         let iter = self.expr_ident(e.span, iter, iter_pat.id);
1472                         let ref_mut_iter = self.expr_mut_addr_of(e.span, iter);
1473                         let next_path = self.expr_path(next_path, ThinVec::new());
1474                         let next_expr = self.expr_call(e.span, next_path, hir_vec![ref_mut_iter]);
1475                         let arms = hir_vec![pat_arm, break_arm];
1476
1477                         self.expr(e.span,
1478                                   hir::ExprMatch(next_expr, arms, hir::MatchSource::ForLoopDesugar),
1479                                   ThinVec::new())
1480                     };
1481
1482                     // `[opt_ident]: loop { ... }`
1483                     let loop_block = self.block_expr(match_expr);
1484                     let loop_expr = hir::ExprLoop(loop_block, self.lower_opt_sp_ident(opt_ident));
1485                     let loop_expr = P(hir::Expr {
1486                         id: e.id,
1487                         node: loop_expr,
1488                         span: e.span,
1489                         attrs: ThinVec::new(),
1490                     });
1491
1492                     // `mut iter => { ... }`
1493                     let iter_arm = self.arm(hir_vec![iter_pat], loop_expr);
1494
1495                     // `match ::std::iter::IntoIterator::into_iter(<head>) { ... }`
1496                     let into_iter_expr = {
1497                         let into_iter_path = {
1498                             let strs = self.std_path(&["iter", "IntoIterator", "into_iter"]);
1499
1500                             self.path_global(e.span, strs)
1501                         };
1502
1503                         let into_iter = self.expr_path(into_iter_path, ThinVec::new());
1504                         self.expr_call(e.span, into_iter, hir_vec![head])
1505                     };
1506
1507                     let match_expr = self.expr_match(e.span,
1508                                                      into_iter_expr,
1509                                                      hir_vec![iter_arm],
1510                                                      hir::MatchSource::ForLoopDesugar);
1511
1512                     // `{ let _result = ...; _result }`
1513                     // underscore prevents an unused_variables lint if the head diverges
1514                     let result_ident = self.str_to_ident("_result");
1515                     let (let_stmt, let_stmt_binding) =
1516                         self.stmt_let(e.span, false, result_ident, match_expr);
1517
1518                     let result = self.expr_ident(e.span, result_ident, let_stmt_binding);
1519                     let block = self.block_all(e.span, hir_vec![let_stmt], Some(result));
1520                     // add the attributes to the outer returned expr node
1521                     return self.expr_block(block, e.attrs.clone());
1522                 }
1523
1524                 // Desugar ExprKind::Try
1525                 // From: `<expr>?`
1526                 ExprKind::Try(ref sub_expr) => {
1527                     // to:
1528                     //
1529                     // {
1530                     //     match <expr> {
1531                     //         Ok(val) => val,
1532                     //         Err(err) => {
1533                     //             return Err(From::from(err))
1534                     //         }
1535                     //     }
1536                     // }
1537
1538                     // expand <expr>
1539                     let sub_expr = self.lower_expr(sub_expr);
1540
1541                     // Ok(val) => val
1542                     let ok_arm = {
1543                         let val_ident = self.str_to_ident("val");
1544                         let val_pat = self.pat_ident(e.span, val_ident);
1545                         let val_expr = self.expr_ident(e.span, val_ident, val_pat.id);
1546                         let ok_pat = self.pat_ok(e.span, val_pat);
1547
1548                         self.arm(hir_vec![ok_pat], val_expr)
1549                     };
1550
1551                     // Err(err) => return Err(From::from(err))
1552                     let err_arm = {
1553                         let err_ident = self.str_to_ident("err");
1554                         let err_local = self.pat_ident(e.span, err_ident);
1555                         let from_expr = {
1556                             let path = self.std_path(&["convert", "From", "from"]);
1557                             let path = self.path_global(e.span, path);
1558                             let from = self.expr_path(path, ThinVec::new());
1559                             let err_expr = self.expr_ident(e.span, err_ident, err_local.id);
1560
1561                             self.expr_call(e.span, from, hir_vec![err_expr])
1562                         };
1563                         let err_expr = {
1564                             let path = self.std_path(&["result", "Result", "Err"]);
1565                             let path = self.path_global(e.span, path);
1566                             let err_ctor = self.expr_path(path, ThinVec::new());
1567                             self.expr_call(e.span, err_ctor, hir_vec![from_expr])
1568                         };
1569                         let err_pat = self.pat_err(e.span, err_local);
1570                         let ret_expr = self.expr(e.span,
1571                                                  hir::Expr_::ExprRet(Some(err_expr)),
1572                                                  ThinVec::new());
1573                         self.arm(hir_vec![err_pat], ret_expr)
1574                     };
1575
1576                     return self.expr_match(e.span, sub_expr, hir_vec![err_arm, ok_arm],
1577                                            hir::MatchSource::TryDesugar);
1578                 }
1579
1580                 ExprKind::Mac(_) => panic!("Shouldn't exist here"),
1581             },
1582             span: e.span,
1583             attrs: e.attrs.clone(),
1584         })
1585     }
1586
1587     fn lower_stmt(&mut self, s: &Stmt) -> hir::Stmt {
1588         match s.node {
1589             StmtKind::Local(ref l) => Spanned {
1590                 node: hir::StmtDecl(P(Spanned {
1591                     node: hir::DeclLocal(self.lower_local(l)),
1592                     span: s.span,
1593                 }), s.id),
1594                 span: s.span,
1595             },
1596             StmtKind::Item(ref it) => Spanned {
1597                 node: hir::StmtDecl(P(Spanned {
1598                     node: hir::DeclItem(self.lower_item_id(it)),
1599                     span: s.span,
1600                 }), s.id),
1601                 span: s.span,
1602             },
1603             StmtKind::Expr(ref e) => {
1604                 Spanned {
1605                     node: hir::StmtExpr(self.lower_expr(e), s.id),
1606                     span: s.span,
1607                 }
1608             }
1609             StmtKind::Semi(ref e) => {
1610                 Spanned {
1611                     node: hir::StmtSemi(self.lower_expr(e), s.id),
1612                     span: s.span,
1613                 }
1614             }
1615             StmtKind::Mac(..) => panic!("Shouldn't exist here"),
1616         }
1617     }
1618
1619     fn lower_capture_clause(&mut self, c: CaptureBy) -> hir::CaptureClause {
1620         match c {
1621             CaptureBy::Value => hir::CaptureByValue,
1622             CaptureBy::Ref => hir::CaptureByRef,
1623         }
1624     }
1625
1626     fn lower_visibility(&mut self, v: &Visibility) -> hir::Visibility {
1627         match *v {
1628             Visibility::Public => hir::Public,
1629             Visibility::Crate(_) => hir::Visibility::Crate,
1630             Visibility::Restricted { ref path, id } =>
1631                 hir::Visibility::Restricted { path: P(self.lower_path(path)), id: id },
1632             Visibility::Inherited => hir::Inherited,
1633         }
1634     }
1635
1636     fn lower_defaultness(&mut self, d: Defaultness) -> hir::Defaultness {
1637         match d {
1638             Defaultness::Default => hir::Defaultness::Default,
1639             Defaultness::Final => hir::Defaultness::Final,
1640         }
1641     }
1642
1643     fn lower_block_check_mode(&mut self, b: &BlockCheckMode) -> hir::BlockCheckMode {
1644         match *b {
1645             BlockCheckMode::Default => hir::DefaultBlock,
1646             BlockCheckMode::Unsafe(u) => hir::UnsafeBlock(self.lower_unsafe_source(u)),
1647         }
1648     }
1649
1650     fn lower_binding_mode(&mut self, b: &BindingMode) -> hir::BindingMode {
1651         match *b {
1652             BindingMode::ByRef(m) => hir::BindByRef(self.lower_mutability(m)),
1653             BindingMode::ByValue(m) => hir::BindByValue(self.lower_mutability(m)),
1654         }
1655     }
1656
1657     fn lower_unsafe_source(&mut self, u: UnsafeSource) -> hir::UnsafeSource {
1658         match u {
1659             CompilerGenerated => hir::CompilerGenerated,
1660             UserProvided => hir::UserProvided,
1661         }
1662     }
1663
1664     fn lower_impl_polarity(&mut self, i: ImplPolarity) -> hir::ImplPolarity {
1665         match i {
1666             ImplPolarity::Positive => hir::ImplPolarity::Positive,
1667             ImplPolarity::Negative => hir::ImplPolarity::Negative,
1668         }
1669     }
1670
1671     fn lower_trait_bound_modifier(&mut self, f: TraitBoundModifier) -> hir::TraitBoundModifier {
1672         match f {
1673             TraitBoundModifier::None => hir::TraitBoundModifier::None,
1674             TraitBoundModifier::Maybe => hir::TraitBoundModifier::Maybe,
1675         }
1676     }
1677
1678     // Helper methods for building HIR.
1679
1680     fn arm(&mut self, pats: hir::HirVec<P<hir::Pat>>, expr: P<hir::Expr>) -> hir::Arm {
1681         hir::Arm {
1682             attrs: hir_vec![],
1683             pats: pats,
1684             guard: None,
1685             body: expr,
1686         }
1687     }
1688
1689     fn field(&mut self, name: Name, expr: P<hir::Expr>, span: Span) -> hir::Field {
1690         hir::Field {
1691             name: Spanned {
1692                 node: name,
1693                 span: span,
1694             },
1695             span: span,
1696             expr: expr,
1697         }
1698     }
1699
1700     fn expr_break(&mut self, span: Span, attrs: ThinVec<Attribute>) -> P<hir::Expr> {
1701         self.expr(span, hir::ExprBreak(None), attrs)
1702     }
1703
1704     fn expr_call(&mut self, span: Span, e: P<hir::Expr>, args: hir::HirVec<P<hir::Expr>>)
1705                  -> P<hir::Expr> {
1706         self.expr(span, hir::ExprCall(e, args), ThinVec::new())
1707     }
1708
1709     fn expr_ident(&mut self, span: Span, id: Name, binding: NodeId) -> P<hir::Expr> {
1710         let expr_path = hir::ExprPath(None, self.path_ident(span, id));
1711         let expr = self.expr(span, expr_path, ThinVec::new());
1712
1713         let def = self.resolver.definitions().map(|defs| {
1714             Def::Local(defs.local_def_id(binding), binding)
1715         }).unwrap_or(Def::Err);
1716         self.resolver.record_resolution(expr.id, def);
1717
1718         expr
1719     }
1720
1721     fn expr_mut_addr_of(&mut self, span: Span, e: P<hir::Expr>) -> P<hir::Expr> {
1722         self.expr(span, hir::ExprAddrOf(hir::MutMutable, e), ThinVec::new())
1723     }
1724
1725     fn expr_path(&mut self, path: hir::Path, attrs: ThinVec<Attribute>) -> P<hir::Expr> {
1726         let def = self.resolver.resolve_generated_global_path(&path, true);
1727         let expr = self.expr(path.span, hir::ExprPath(None, path), attrs);
1728         self.resolver.record_resolution(expr.id, def);
1729         expr
1730     }
1731
1732     fn expr_match(&mut self,
1733                   span: Span,
1734                   arg: P<hir::Expr>,
1735                   arms: hir::HirVec<hir::Arm>,
1736                   source: hir::MatchSource)
1737                   -> P<hir::Expr> {
1738         self.expr(span, hir::ExprMatch(arg, arms, source), ThinVec::new())
1739     }
1740
1741     fn expr_block(&mut self, b: P<hir::Block>, attrs: ThinVec<Attribute>) -> P<hir::Expr> {
1742         self.expr(b.span, hir::ExprBlock(b), attrs)
1743     }
1744
1745     fn expr_tuple(&mut self, sp: Span, exprs: hir::HirVec<P<hir::Expr>>) -> P<hir::Expr> {
1746         self.expr(sp, hir::ExprTup(exprs), ThinVec::new())
1747     }
1748
1749     fn expr_struct(&mut self,
1750                    sp: Span,
1751                    path: hir::Path,
1752                    fields: hir::HirVec<hir::Field>,
1753                    e: Option<P<hir::Expr>>,
1754                    attrs: ThinVec<Attribute>) -> P<hir::Expr> {
1755         let def = self.resolver.resolve_generated_global_path(&path, false);
1756         let expr = self.expr(sp, hir::ExprStruct(path, fields, e), attrs);
1757         self.resolver.record_resolution(expr.id, def);
1758         expr
1759     }
1760
1761     fn expr(&mut self, span: Span, node: hir::Expr_, attrs: ThinVec<Attribute>) -> P<hir::Expr> {
1762         P(hir::Expr {
1763             id: self.next_id(),
1764             node: node,
1765             span: span,
1766             attrs: attrs,
1767         })
1768     }
1769
1770     fn stmt_let(&mut self, sp: Span, mutbl: bool, ident: Name, ex: P<hir::Expr>)
1771                 -> (hir::Stmt, NodeId) {
1772         let pat = if mutbl {
1773             self.pat_ident_binding_mode(sp, ident, hir::BindByValue(hir::MutMutable))
1774         } else {
1775             self.pat_ident(sp, ident)
1776         };
1777         let pat_id = pat.id;
1778         let local = P(hir::Local {
1779             pat: pat,
1780             ty: None,
1781             init: Some(ex),
1782             id: self.next_id(),
1783             span: sp,
1784             attrs: ThinVec::new(),
1785         });
1786         let decl = respan(sp, hir::DeclLocal(local));
1787         (respan(sp, hir::StmtDecl(P(decl), self.next_id())), pat_id)
1788     }
1789
1790     fn block_expr(&mut self, expr: P<hir::Expr>) -> P<hir::Block> {
1791         self.block_all(expr.span, hir::HirVec::new(), Some(expr))
1792     }
1793
1794     fn block_all(&mut self, span: Span, stmts: hir::HirVec<hir::Stmt>, expr: Option<P<hir::Expr>>)
1795                  -> P<hir::Block> {
1796         P(hir::Block {
1797             stmts: stmts,
1798             expr: expr,
1799             id: self.next_id(),
1800             rules: hir::DefaultBlock,
1801             span: span,
1802         })
1803     }
1804
1805     fn pat_ok(&mut self, span: Span, pat: P<hir::Pat>) -> P<hir::Pat> {
1806         let ok = self.std_path(&["result", "Result", "Ok"]);
1807         let path = self.path_global(span, ok);
1808         self.pat_enum(span, path, hir_vec![pat])
1809     }
1810
1811     fn pat_err(&mut self, span: Span, pat: P<hir::Pat>) -> P<hir::Pat> {
1812         let err = self.std_path(&["result", "Result", "Err"]);
1813         let path = self.path_global(span, err);
1814         self.pat_enum(span, path, hir_vec![pat])
1815     }
1816
1817     fn pat_some(&mut self, span: Span, pat: P<hir::Pat>) -> P<hir::Pat> {
1818         let some = self.std_path(&["option", "Option", "Some"]);
1819         let path = self.path_global(span, some);
1820         self.pat_enum(span, path, hir_vec![pat])
1821     }
1822
1823     fn pat_none(&mut self, span: Span) -> P<hir::Pat> {
1824         let none = self.std_path(&["option", "Option", "None"]);
1825         let path = self.path_global(span, none);
1826         self.pat_enum(span, path, hir_vec![])
1827     }
1828
1829     fn pat_enum(&mut self, span: Span, path: hir::Path, subpats: hir::HirVec<P<hir::Pat>>)
1830                 -> P<hir::Pat> {
1831         let def = self.resolver.resolve_generated_global_path(&path, true);
1832         let pt = if subpats.is_empty() {
1833             hir::PatKind::Path(None, path)
1834         } else {
1835             hir::PatKind::TupleStruct(path, subpats, None)
1836         };
1837         let pat = self.pat(span, pt);
1838         self.resolver.record_resolution(pat.id, def);
1839         pat
1840     }
1841
1842     fn pat_ident(&mut self, span: Span, name: Name) -> P<hir::Pat> {
1843         self.pat_ident_binding_mode(span, name, hir::BindByValue(hir::MutImmutable))
1844     }
1845
1846     fn pat_ident_binding_mode(&mut self, span: Span, name: Name, bm: hir::BindingMode)
1847                               -> P<hir::Pat> {
1848         let pat_ident = hir::PatKind::Binding(bm,
1849                                             Spanned {
1850                                                 span: span,
1851                                                 node: name,
1852                                             },
1853                                             None);
1854
1855         let pat = self.pat(span, pat_ident);
1856
1857         let parent_def = self.parent_def;
1858         let def = self.resolver.definitions().map(|defs| {
1859             let def_path_data = DefPathData::Binding(name.as_str());
1860             let def_index = defs.create_def_with_parent(parent_def, pat.id, def_path_data);
1861             Def::Local(DefId::local(def_index), pat.id)
1862         }).unwrap_or(Def::Err);
1863         self.resolver.record_resolution(pat.id, def);
1864
1865         pat
1866     }
1867
1868     fn pat_wild(&mut self, span: Span) -> P<hir::Pat> {
1869         self.pat(span, hir::PatKind::Wild)
1870     }
1871
1872     fn pat(&mut self, span: Span, pat: hir::PatKind) -> P<hir::Pat> {
1873         P(hir::Pat {
1874             id: self.next_id(),
1875             node: pat,
1876             span: span,
1877         })
1878     }
1879
1880     fn path_ident(&mut self, span: Span, id: Name) -> hir::Path {
1881         self.path(span, vec![id])
1882     }
1883
1884     fn path(&mut self, span: Span, strs: Vec<Name>) -> hir::Path {
1885         self.path_all(span, false, strs, hir::HirVec::new(), hir::HirVec::new(), hir::HirVec::new())
1886     }
1887
1888     fn path_global(&mut self, span: Span, strs: Vec<Name>) -> hir::Path {
1889         self.path_all(span, true, strs, hir::HirVec::new(), hir::HirVec::new(), hir::HirVec::new())
1890     }
1891
1892     fn path_all(&mut self,
1893                 sp: Span,
1894                 global: bool,
1895                 mut names: Vec<Name>,
1896                 lifetimes: hir::HirVec<hir::Lifetime>,
1897                 types: hir::HirVec<P<hir::Ty>>,
1898                 bindings: hir::HirVec<hir::TypeBinding>)
1899                 -> hir::Path {
1900         let last_identifier = names.pop().unwrap();
1901         let mut segments: Vec<hir::PathSegment> = names.into_iter().map(|name| {
1902             hir::PathSegment {
1903                 name: name,
1904                 parameters: hir::PathParameters::none(),
1905            }
1906         }).collect();
1907
1908         segments.push(hir::PathSegment {
1909             name: last_identifier,
1910             parameters: hir::AngleBracketedParameters(hir::AngleBracketedParameterData {
1911                 lifetimes: lifetimes,
1912                 types: types,
1913                 bindings: bindings,
1914             }),
1915         });
1916         hir::Path {
1917             span: sp,
1918             global: global,
1919             segments: segments.into(),
1920         }
1921     }
1922
1923     fn std_path(&mut self, components: &[&str]) -> Vec<Name> {
1924         let mut v = Vec::new();
1925         if let Some(s) = self.crate_root {
1926             v.push(token::intern(s));
1927         }
1928         v.extend(components.iter().map(|s| token::intern(s)));
1929         return v;
1930     }
1931
1932     // Given suffix ["b","c","d"], returns path `::std::b::c::d` when
1933     // `fld.cx.use_std`, and `::core::b::c::d` otherwise.
1934     fn core_path(&mut self, span: Span, components: &[&str]) -> hir::Path {
1935         let idents = self.std_path(components);
1936         self.path_global(span, idents)
1937     }
1938
1939     fn signal_block_expr(&mut self,
1940                          stmts: hir::HirVec<hir::Stmt>,
1941                          expr: P<hir::Expr>,
1942                          span: Span,
1943                          rule: hir::BlockCheckMode,
1944                          attrs: ThinVec<Attribute>)
1945                          -> P<hir::Expr> {
1946         let id = self.next_id();
1947         let block = P(hir::Block {
1948             rules: rule,
1949             span: span,
1950             id: id,
1951             stmts: stmts,
1952             expr: Some(expr),
1953         });
1954         self.expr_block(block, attrs)
1955     }
1956 }