1 #![feature(type_macros)]
2 #![feature(plugin_registrar, box_syntax)]
3 #![feature(rustc_private, collections)]
4 #![feature(iter_arith)]
5 #![feature(custom_attribute)]
6 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
8 // this only exists to allow the "dogfood" integration test to work
10 #[allow(print_stdout)]
12 println!("What are you doing? Don't run clippy as an executable");
20 extern crate rustc_front;
24 // Only for the compile time checking of paths
26 extern crate collections;
28 // for unicode nfc normalization
29 extern crate unicode_normalization;
31 // for semver check in attrs.rs
35 extern crate regex_syntax;
37 extern crate rustc_plugin;
39 use rustc_plugin::Registry;
45 // begin lints modules, do not remove this comment, it’s used in `update_lints`
47 pub mod array_indexing;
50 pub mod blacklisted_name;
51 pub mod block_in_if_condition;
52 pub mod collapsible_if;
54 pub mod cyclomatic_complexity;
59 pub mod enum_glob_use;
60 pub mod enum_variants;
63 pub mod eta_reduction;
68 pub mod items_after_statements;
79 pub mod mut_reference;
81 pub mod needless_bool;
82 pub mod needless_features;
83 pub mod needless_update;
84 pub mod new_without_default;
87 pub mod overflow_check_conditional;
98 pub mod temporary_assignment;
102 pub mod unused_label;
104 pub mod zero_div_zero;
105 // end lints modules, do not remove this comment, it’s used in `update_lints`
108 pub use syntax::ast::{Name, NodeId};
112 #[cfg_attr(rustfmt, rustfmt_skip)]
113 pub fn plugin_registrar(reg: &mut Registry) {
114 let conf = match utils::conf::conf_file(reg.args()) {
116 // if the user specified a file, it must exist, otherwise default to `Clippy.toml` but
117 // do not require the file to exist
118 let (ref file_name, must_exist) = if let Some(ref file_name) = file_name {
121 ("Clippy.toml", false)
124 let (conf, errors) = utils::conf::read_conf(&file_name, must_exist);
126 // all conf errors are non-fatal, we just use the default conf in case of error
127 for error in errors {
128 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
133 Err((err, span)) => {
134 reg.sess.struct_span_err(span, err)
135 .span_note(span, "Clippy will use defaulf configuration")
137 utils::conf::Conf::default()
141 reg.register_late_lint_pass(box types::TypePass);
142 reg.register_late_lint_pass(box misc::TopLevelRefPass);
143 reg.register_late_lint_pass(box misc::CmpNan);
144 reg.register_late_lint_pass(box eq_op::EqOp);
145 reg.register_early_lint_pass(box enum_variants::EnumVariantNames);
146 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
147 reg.register_late_lint_pass(box enum_clike::EnumClikeUnportableVariant);
148 reg.register_late_lint_pass(box bit_mask::BitMask);
149 reg.register_late_lint_pass(box ptr_arg::PtrArg);
150 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
151 reg.register_late_lint_pass(box needless_bool::BoolComparison);
152 reg.register_late_lint_pass(box approx_const::ApproxConstant);
153 reg.register_late_lint_pass(box misc::FloatCmp);
154 reg.register_early_lint_pass(box precedence::Precedence);
155 reg.register_late_lint_pass(box eta_reduction::EtaPass);
156 reg.register_late_lint_pass(box identity_op::IdentityOp);
157 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatemets);
158 reg.register_late_lint_pass(box mut_mut::MutMut);
159 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
160 reg.register_late_lint_pass(box len_zero::LenZero);
161 reg.register_late_lint_pass(box misc::CmpOwned);
162 reg.register_late_lint_pass(box attrs::AttrPass);
163 reg.register_late_lint_pass(box collapsible_if::CollapsibleIf);
164 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
165 reg.register_late_lint_pass(box misc::ModuloOne);
166 reg.register_late_lint_pass(box unicode::Unicode);
167 reg.register_late_lint_pass(box strings::StringAdd);
168 reg.register_early_lint_pass(box returns::ReturnPass);
169 reg.register_late_lint_pass(box methods::MethodsPass);
170 reg.register_late_lint_pass(box shadow::ShadowPass);
171 reg.register_late_lint_pass(box types::LetPass);
172 reg.register_late_lint_pass(box types::UnitCmp);
173 reg.register_late_lint_pass(box loops::LoopsPass);
174 reg.register_late_lint_pass(box lifetimes::LifetimePass);
175 reg.register_late_lint_pass(box entry::HashMapLint);
176 reg.register_late_lint_pass(box ranges::StepByZero);
177 reg.register_late_lint_pass(box types::CastPass);
178 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
179 reg.register_late_lint_pass(box matches::MatchPass);
180 reg.register_late_lint_pass(box misc::PatternPass);
181 reg.register_late_lint_pass(box minmax::MinMaxPass);
182 reg.register_late_lint_pass(box open_options::NonSensicalOpenOptions);
183 reg.register_late_lint_pass(box zero_div_zero::ZeroDivZeroPass);
184 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
185 reg.register_late_lint_pass(box needless_features::NeedlessFeaturesPass);
186 reg.register_late_lint_pass(box needless_update::NeedlessUpdatePass);
187 reg.register_late_lint_pass(box no_effect::NoEffectPass);
188 reg.register_late_lint_pass(box map_clone::MapClonePass);
189 reg.register_late_lint_pass(box temporary_assignment::TemporaryAssignmentPass);
190 reg.register_late_lint_pass(box transmute::UselessTransmute);
191 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
192 reg.register_late_lint_pass(box escape::EscapePass);
193 reg.register_early_lint_pass(box misc_early::MiscEarly);
194 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
195 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
196 reg.register_late_lint_pass(box panic::PanicPass);
197 reg.register_late_lint_pass(box strings::StringLitAsBytes);
198 reg.register_late_lint_pass(box derive::Derive);
199 reg.register_late_lint_pass(box types::CharLitAsU8);
200 reg.register_late_lint_pass(box print::PrintLint);
201 reg.register_late_lint_pass(box vec::UselessVec);
202 reg.register_late_lint_pass(box drop_ref::DropRefPass);
203 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
204 reg.register_late_lint_pass(box regex::RegexPass::default());
205 reg.register_late_lint_pass(box copies::CopyAndPaste);
206 reg.register_late_lint_pass(box format::FormatMacLint);
207 reg.register_early_lint_pass(box formatting::Formatting);
208 reg.register_late_lint_pass(box swap::Swap);
209 reg.register_early_lint_pass(box if_not_else::IfNotElse);
210 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
211 reg.register_late_lint_pass(box unused_label::UnusedLabel);
212 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
213 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
215 reg.register_lint_group("clippy_pedantic", vec![
216 array_indexing::INDEXING_SLICING,
217 enum_glob_use::ENUM_GLOB_USE,
218 matches::SINGLE_MATCH_ELSE,
219 methods::OPTION_UNWRAP_USED,
220 methods::RESULT_UNWRAP_USED,
221 methods::WRONG_PUB_SELF_CONVENTION,
223 mutex_atomic::MUTEX_INTEGER,
226 shadow::SHADOW_REUSE,
228 shadow::SHADOW_UNRELATED,
230 strings::STRING_ADD_ASSIGN,
231 types::CAST_POSSIBLE_TRUNCATION,
232 types::CAST_POSSIBLE_WRAP,
233 types::CAST_PRECISION_LOSS,
234 types::CAST_SIGN_LOSS,
235 unicode::NON_ASCII_LITERAL,
236 unicode::UNICODE_NOT_NFC,
239 reg.register_lint_group("clippy", vec![
240 approx_const::APPROX_CONSTANT,
241 array_indexing::OUT_OF_BOUNDS_INDEXING,
242 attrs::DEPRECATED_SEMVER,
243 attrs::INLINE_ALWAYS,
244 bit_mask::BAD_BIT_MASK,
245 bit_mask::INEFFECTIVE_BIT_MASK,
246 blacklisted_name::BLACKLISTED_NAME,
247 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
248 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
249 collapsible_if::COLLAPSIBLE_IF,
250 copies::IF_SAME_THEN_ELSE,
251 copies::IFS_SAME_COND,
252 copies::MATCH_SAME_ARMS,
253 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
254 derive::DERIVE_HASH_XOR_EQ,
255 derive::EXPL_IMPL_CLONE_ON_COPY,
258 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
259 enum_variants::ENUM_VARIANT_NAMES,
262 eta_reduction::REDUNDANT_CLOSURE,
263 format::USELESS_FORMAT,
264 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
265 formatting::SUSPICIOUS_ELSE_FORMATTING,
266 identity_op::IDENTITY_OP,
267 if_not_else::IF_NOT_ELSE,
268 items_after_statements::ITEMS_AFTER_STATEMENTS,
269 len_zero::LEN_WITHOUT_IS_EMPTY,
271 lifetimes::NEEDLESS_LIFETIMES,
272 lifetimes::UNUSED_LIFETIMES,
274 loops::EXPLICIT_COUNTER_LOOP,
275 loops::EXPLICIT_ITER_LOOP,
277 loops::FOR_LOOP_OVER_OPTION,
278 loops::FOR_LOOP_OVER_RESULT,
279 loops::ITER_NEXT_LOOP,
280 loops::NEEDLESS_RANGE_LOOP,
281 loops::REVERSE_RANGE_LOOP,
282 loops::UNUSED_COLLECT,
283 loops::WHILE_LET_LOOP,
284 loops::WHILE_LET_ON_ITERATOR,
285 map_clone::MAP_CLONE,
287 matches::MATCH_OVERLAPPING_ARM,
288 matches::MATCH_REF_PATS,
289 matches::SINGLE_MATCH,
290 methods::CHARS_NEXT_CMP,
291 methods::CLONE_DOUBLE_REF,
292 methods::CLONE_ON_COPY,
293 methods::EXTEND_FROM_SLICE,
294 methods::FILTER_NEXT,
295 methods::NEW_RET_NO_SELF,
297 methods::OPTION_MAP_UNWRAP_OR,
298 methods::OPTION_MAP_UNWRAP_OR_ELSE,
299 methods::OR_FUN_CALL,
300 methods::SEARCH_IS_SOME,
301 methods::SHOULD_IMPLEMENT_TRAIT,
302 methods::SINGLE_CHAR_PATTERN,
303 methods::STR_TO_STRING,
304 methods::STRING_TO_STRING,
305 methods::WRONG_SELF_CONVENTION,
311 misc::REDUNDANT_PATTERN,
312 misc::TOPLEVEL_REF_ARG,
313 misc::USED_UNDERSCORE_BINDING,
314 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
315 misc_early::REDUNDANT_CLOSURE_CALL,
316 misc_early::UNNEEDED_FIELD_PATTERN,
317 mut_reference::UNNECESSARY_MUT_PASSED,
318 mutex_atomic::MUTEX_ATOMIC,
319 needless_bool::BOOL_COMPARISON,
320 needless_bool::NEEDLESS_BOOL,
321 needless_features::UNSTABLE_AS_MUT_SLICE,
322 needless_features::UNSTABLE_AS_SLICE,
323 needless_update::NEEDLESS_UPDATE,
324 new_without_default::NEW_WITHOUT_DEFAULT,
325 no_effect::NO_EFFECT,
326 open_options::NONSENSICAL_OPEN_OPTIONS,
327 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
329 precedence::PRECEDENCE,
331 ranges::RANGE_STEP_BY_ZERO,
332 ranges::RANGE_ZIP_WITH_LEN,
333 regex::INVALID_REGEX,
335 regex::TRIVIAL_REGEX,
336 returns::LET_AND_RETURN,
337 returns::NEEDLESS_RETURN,
338 strings::STRING_LIT_AS_BYTES,
339 swap::ALMOST_SWAPPED,
341 temporary_assignment::TEMPORARY_ASSIGNMENT,
342 transmute::USELESS_TRANSMUTE,
343 types::ABSURD_EXTREME_COMPARISONS,
345 types::CHAR_LIT_AS_U8,
346 types::LET_UNIT_VALUE,
348 types::TYPE_COMPLEXITY,
350 unicode::ZERO_WIDTH_SPACE,
351 unused_label::UNUSED_LABEL,
353 zero_div_zero::ZERO_DIVIDED_BY_ZERO,