1 #![feature(type_macros)]
2 #![feature(plugin_registrar, box_syntax)]
3 #![feature(rustc_private, collections)]
4 #![feature(iter_arith)]
5 #![feature(custom_attribute)]
6 #![feature(slice_patterns)]
7 #![feature(question_mark)]
8 #![feature(stmt_expr_attributes)]
9 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
10 #![allow(float_arithmetic, integer_arithmetic)]
12 // this only exists to allow the "dogfood" integration test to work
14 #[allow(print_stdout)]
16 println!("What are you doing? Don't run clippy as an executable");
26 // Only for the compile time checking of paths
28 extern crate collections;
30 // for unicode nfc normalization
31 extern crate unicode_normalization;
33 // for semver check in attrs.rs
37 extern crate regex_syntax;
39 // for finding minimal boolean expressions
40 extern crate quine_mc_cluskey;
42 extern crate rustc_plugin;
43 extern crate rustc_const_eval;
44 extern crate rustc_const_math;
45 use rustc_plugin::Registry;
47 macro_rules! declare_restriction_lint {
48 { pub $name:tt, $description:tt } => {
49 declare_lint! { pub $name, Allow, $description }
57 // begin lints modules, do not remove this comment, it’s used in `update_lints`
60 pub mod array_indexing;
63 pub mod blacklisted_name;
64 pub mod block_in_if_condition;
66 pub mod collapsible_if;
68 pub mod cyclomatic_complexity;
74 pub mod enum_glob_use;
75 pub mod enum_variants;
78 pub mod eta_reduction;
84 pub mod items_after_statements;
96 pub mod mut_reference;
98 pub mod needless_bool;
99 pub mod needless_borrow;
100 pub mod needless_update;
101 pub mod neg_multiply;
102 pub mod new_without_default;
104 pub mod non_expressive_names;
105 pub mod open_options;
106 pub mod overflow_check_conditional;
117 pub mod temporary_assignment;
121 pub mod unsafe_removed_from_name;
122 pub mod unused_label;
124 pub mod zero_div_zero;
125 // end lints modules, do not remove this comment, it’s used in `update_lints`
128 pub use syntax::ast::{Name, NodeId};
132 #[cfg_attr(rustfmt, rustfmt_skip)]
133 pub fn plugin_registrar(reg: &mut Registry) {
134 let conf = match utils::conf::conf_file(reg.args()) {
136 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
137 // do not require the file to exist
138 let (ref file_name, must_exist) = if let Some(ref file_name) = file_name {
141 ("clippy.toml", false)
144 let (conf, errors) = utils::conf::read_conf(file_name, must_exist);
146 // all conf errors are non-fatal, we just use the default conf in case of error
147 for error in errors {
148 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
153 Err((err, span)) => {
154 reg.sess.struct_span_err(span, err)
155 .span_note(span, "Clippy will use default configuration")
157 utils::conf::Conf::default()
161 let mut store = reg.sess.lint_store.borrow_mut();
162 store.register_removed("unstable_as_slice", "`Vec::as_slice` has been stabilized in 1.7");
163 store.register_removed("unstable_as_mut_slice", "`Vec::as_mut_slice` has been stabilized in 1.7");
164 store.register_removed("str_to_string", "using `str::to_string` is common even today and specialization will likely happen soon");
165 store.register_removed("string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon");
166 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
168 reg.register_late_lint_pass(box types::TypePass);
169 reg.register_late_lint_pass(box booleans::NonminimalBool);
170 reg.register_late_lint_pass(box misc::TopLevelRefPass);
171 reg.register_late_lint_pass(box misc::CmpNan);
172 reg.register_late_lint_pass(box eq_op::EqOp);
173 reg.register_early_lint_pass(box enum_variants::EnumVariantNames);
174 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
175 reg.register_late_lint_pass(box enum_clike::EnumClikeUnportableVariant);
176 reg.register_late_lint_pass(box bit_mask::BitMask);
177 reg.register_late_lint_pass(box ptr_arg::PtrArg);
178 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
179 reg.register_late_lint_pass(box needless_bool::BoolComparison);
180 reg.register_late_lint_pass(box approx_const::ApproxConstant);
181 reg.register_late_lint_pass(box misc::FloatCmp);
182 reg.register_early_lint_pass(box precedence::Precedence);
183 reg.register_late_lint_pass(box eta_reduction::EtaPass);
184 reg.register_late_lint_pass(box identity_op::IdentityOp);
185 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
186 reg.register_late_lint_pass(box mut_mut::MutMut);
187 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
188 reg.register_late_lint_pass(box len_zero::LenZero);
189 reg.register_late_lint_pass(box misc::CmpOwned);
190 reg.register_late_lint_pass(box attrs::AttrPass);
191 reg.register_late_lint_pass(box collapsible_if::CollapsibleIf);
192 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
193 reg.register_late_lint_pass(box misc::ModuloOne);
194 reg.register_late_lint_pass(box unicode::Unicode);
195 reg.register_late_lint_pass(box strings::StringAdd);
196 reg.register_early_lint_pass(box returns::ReturnPass);
197 reg.register_late_lint_pass(box methods::MethodsPass);
198 reg.register_late_lint_pass(box shadow::ShadowPass);
199 reg.register_late_lint_pass(box types::LetPass);
200 reg.register_late_lint_pass(box types::UnitCmp);
201 reg.register_late_lint_pass(box loops::LoopsPass);
202 reg.register_late_lint_pass(box lifetimes::LifetimePass);
203 reg.register_late_lint_pass(box entry::HashMapLint);
204 reg.register_late_lint_pass(box ranges::StepByZero);
205 reg.register_late_lint_pass(box types::CastPass);
206 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
207 reg.register_late_lint_pass(box matches::MatchPass);
208 reg.register_late_lint_pass(box misc::PatternPass);
209 reg.register_late_lint_pass(box minmax::MinMaxPass);
210 reg.register_late_lint_pass(box open_options::NonSensicalOpenOptions);
211 reg.register_late_lint_pass(box zero_div_zero::ZeroDivZeroPass);
212 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
213 reg.register_late_lint_pass(box needless_update::NeedlessUpdatePass);
214 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
215 reg.register_late_lint_pass(box no_effect::NoEffectPass);
216 reg.register_late_lint_pass(box map_clone::MapClonePass);
217 reg.register_late_lint_pass(box temporary_assignment::TemporaryAssignmentPass);
218 reg.register_late_lint_pass(box transmute::Transmute);
219 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
220 reg.register_late_lint_pass(box escape::EscapePass);
221 reg.register_early_lint_pass(box misc_early::MiscEarly);
222 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
223 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
224 reg.register_late_lint_pass(box panic::PanicPass);
225 reg.register_late_lint_pass(box strings::StringLitAsBytes);
226 reg.register_late_lint_pass(box derive::Derive);
227 reg.register_late_lint_pass(box types::CharLitAsU8);
228 reg.register_late_lint_pass(box print::PrintLint);
229 reg.register_late_lint_pass(box vec::UselessVec);
230 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
231 max_single_char_names: conf.max_single_char_names,
233 reg.register_late_lint_pass(box drop_ref::DropRefPass);
234 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
235 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
236 reg.register_late_lint_pass(box regex::RegexPass::default());
237 reg.register_late_lint_pass(box copies::CopyAndPaste);
238 reg.register_late_lint_pass(box format::FormatMacLint);
239 reg.register_early_lint_pass(box formatting::Formatting);
240 reg.register_late_lint_pass(box swap::Swap);
241 reg.register_early_lint_pass(box if_not_else::IfNotElse);
242 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
243 reg.register_late_lint_pass(box unused_label::UnusedLabel);
244 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
245 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
246 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
247 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
248 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
249 reg.register_late_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
250 reg.register_late_lint_pass(box mem_forget::MemForget);
251 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
253 reg.register_lint_group("clippy_restrictions", vec![
254 arithmetic::FLOAT_ARITHMETIC,
255 arithmetic::INTEGER_ARITHMETIC,
258 reg.register_lint_group("clippy_pedantic", vec![
259 array_indexing::INDEXING_SLICING,
260 booleans::NONMINIMAL_BOOL,
261 enum_glob_use::ENUM_GLOB_USE,
262 if_not_else::IF_NOT_ELSE,
263 items_after_statements::ITEMS_AFTER_STATEMENTS,
264 matches::SINGLE_MATCH_ELSE,
265 mem_forget::MEM_FORGET,
266 methods::OPTION_UNWRAP_USED,
267 methods::RESULT_UNWRAP_USED,
268 methods::WRONG_PUB_SELF_CONVENTION,
270 mutex_atomic::MUTEX_INTEGER,
271 non_expressive_names::SIMILAR_NAMES,
274 shadow::SHADOW_REUSE,
276 shadow::SHADOW_UNRELATED,
278 strings::STRING_ADD_ASSIGN,
279 types::CAST_POSSIBLE_TRUNCATION,
280 types::CAST_POSSIBLE_WRAP,
281 types::CAST_PRECISION_LOSS,
282 types::CAST_SIGN_LOSS,
283 unicode::NON_ASCII_LITERAL,
284 unicode::UNICODE_NOT_NFC,
287 reg.register_lint_group("clippy", vec![
288 approx_const::APPROX_CONSTANT,
289 array_indexing::OUT_OF_BOUNDS_INDEXING,
290 attrs::DEPRECATED_SEMVER,
291 attrs::INLINE_ALWAYS,
292 bit_mask::BAD_BIT_MASK,
293 bit_mask::INEFFECTIVE_BIT_MASK,
294 blacklisted_name::BLACKLISTED_NAME,
295 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
296 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
298 collapsible_if::COLLAPSIBLE_IF,
299 copies::IF_SAME_THEN_ELSE,
300 copies::IFS_SAME_COND,
301 copies::MATCH_SAME_ARMS,
302 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
303 derive::DERIVE_HASH_XOR_EQ,
304 derive::EXPL_IMPL_CLONE_ON_COPY,
308 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
309 enum_variants::ENUM_VARIANT_NAMES,
312 eta_reduction::REDUNDANT_CLOSURE,
313 format::USELESS_FORMAT,
314 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
315 formatting::SUSPICIOUS_ELSE_FORMATTING,
316 functions::TOO_MANY_ARGUMENTS,
317 identity_op::IDENTITY_OP,
318 len_zero::LEN_WITHOUT_IS_EMPTY,
320 lifetimes::NEEDLESS_LIFETIMES,
321 lifetimes::UNUSED_LIFETIMES,
323 loops::EXPLICIT_COUNTER_LOOP,
324 loops::EXPLICIT_ITER_LOOP,
326 loops::FOR_LOOP_OVER_OPTION,
327 loops::FOR_LOOP_OVER_RESULT,
328 loops::ITER_NEXT_LOOP,
329 loops::NEEDLESS_RANGE_LOOP,
330 loops::REVERSE_RANGE_LOOP,
331 loops::UNUSED_COLLECT,
332 loops::WHILE_LET_LOOP,
333 loops::WHILE_LET_ON_ITERATOR,
334 map_clone::MAP_CLONE,
336 matches::MATCH_OVERLAPPING_ARM,
337 matches::MATCH_REF_PATS,
338 matches::SINGLE_MATCH,
339 methods::CHARS_NEXT_CMP,
340 methods::CLONE_DOUBLE_REF,
341 methods::CLONE_ON_COPY,
342 methods::EXTEND_FROM_SLICE,
343 methods::FILTER_NEXT,
344 methods::NEW_RET_NO_SELF,
346 methods::OPTION_MAP_UNWRAP_OR,
347 methods::OPTION_MAP_UNWRAP_OR_ELSE,
348 methods::OR_FUN_CALL,
349 methods::SEARCH_IS_SOME,
350 methods::SHOULD_IMPLEMENT_TRAIT,
351 methods::SINGLE_CHAR_PATTERN,
352 methods::TEMPORARY_CSTRING_AS_PTR,
353 methods::WRONG_SELF_CONVENTION,
359 misc::REDUNDANT_PATTERN,
360 misc::TOPLEVEL_REF_ARG,
361 misc::USED_UNDERSCORE_BINDING,
362 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
363 misc_early::REDUNDANT_CLOSURE_CALL,
364 misc_early::UNNEEDED_FIELD_PATTERN,
365 mut_reference::UNNECESSARY_MUT_PASSED,
366 mutex_atomic::MUTEX_ATOMIC,
367 needless_bool::BOOL_COMPARISON,
368 needless_bool::NEEDLESS_BOOL,
369 needless_borrow::NEEDLESS_BORROW,
370 needless_update::NEEDLESS_UPDATE,
371 neg_multiply::NEG_MULTIPLY,
372 new_without_default::NEW_WITHOUT_DEFAULT,
373 no_effect::NO_EFFECT,
374 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
375 open_options::NONSENSICAL_OPEN_OPTIONS,
376 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
378 precedence::PRECEDENCE,
380 ranges::RANGE_STEP_BY_ZERO,
381 ranges::RANGE_ZIP_WITH_LEN,
382 regex::INVALID_REGEX,
384 regex::TRIVIAL_REGEX,
385 returns::LET_AND_RETURN,
386 returns::NEEDLESS_RETURN,
387 strings::STRING_LIT_AS_BYTES,
388 swap::ALMOST_SWAPPED,
390 temporary_assignment::TEMPORARY_ASSIGNMENT,
391 transmute::CROSSPOINTER_TRANSMUTE,
392 transmute::TRANSMUTE_PTR_TO_REF,
393 transmute::USELESS_TRANSMUTE,
394 types::ABSURD_EXTREME_COMPARISONS,
396 types::CHAR_LIT_AS_U8,
397 types::INVALID_UPCAST_COMPARISONS,
398 types::LET_UNIT_VALUE,
400 types::TYPE_COMPLEXITY,
402 unicode::ZERO_WIDTH_SPACE,
403 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
404 unused_label::UNUSED_LABEL,
406 zero_div_zero::ZERO_DIVIDED_BY_ZERO,