1 #![feature(plugin_registrar, box_syntax)]
2 #![feature(rustc_private, collections)]
3 #![feature(iter_arith)]
4 #![feature(custom_attribute)]
5 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
7 // this only exists to allow the "dogfood" integration test to work
11 println!("What are you doing? Don't run clippy as an executable");
19 extern crate rustc_front;
23 // Only for the compile time checking of paths
25 extern crate collections;
27 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 extern crate rustc_plugin;
38 use rustc_plugin::Registry;
45 // begin lints modules, do not remove this comment, it’s used in `update_lints`
47 pub mod array_indexing;
50 pub mod block_in_if_condition;
51 pub mod collapsible_if;
53 pub mod cyclomatic_complexity;
58 pub mod enum_glob_use;
59 pub mod enum_variants;
62 pub mod eta_reduction;
67 pub mod items_after_statements;
78 pub mod mut_reference;
80 pub mod needless_bool;
81 pub mod needless_features;
82 pub mod needless_update;
83 pub mod new_without_default;
86 pub mod overflow_check_conditional;
97 pub mod temporary_assignment;
101 pub mod unused_label;
103 pub mod zero_div_zero;
104 // end lints modules, do not remove this comment, it’s used in `update_lints`
107 pub use syntax::ast::{Name, NodeId};
111 #[cfg_attr(rustfmt, rustfmt_skip)]
112 pub fn plugin_registrar(reg: &mut Registry) {
113 let conferr = match conf::conf_file(reg.args()) {
114 Ok(Some(file_name)) => {
115 conf::read_conf(&file_name, true)
118 conf::read_conf("Clippy.toml", false)
120 Err((err, span)) => {
121 reg.sess.struct_span_err(span, err).emit();
126 let conf = match conferr {
129 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", err)).emit();
134 reg.register_late_lint_pass(box types::TypePass);
135 reg.register_late_lint_pass(box misc::TopLevelRefPass);
136 reg.register_late_lint_pass(box misc::CmpNan);
137 reg.register_late_lint_pass(box eq_op::EqOp);
138 reg.register_early_lint_pass(box enum_variants::EnumVariantNames);
139 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
140 reg.register_late_lint_pass(box enum_clike::EnumClikeUnportableVariant);
141 reg.register_late_lint_pass(box bit_mask::BitMask);
142 reg.register_late_lint_pass(box ptr_arg::PtrArg);
143 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
144 reg.register_late_lint_pass(box needless_bool::BoolComparison);
145 reg.register_late_lint_pass(box approx_const::ApproxConstant);
146 reg.register_late_lint_pass(box misc::FloatCmp);
147 reg.register_early_lint_pass(box precedence::Precedence);
148 reg.register_late_lint_pass(box eta_reduction::EtaPass);
149 reg.register_late_lint_pass(box identity_op::IdentityOp);
150 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatemets);
151 reg.register_late_lint_pass(box mut_mut::MutMut);
152 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
153 reg.register_late_lint_pass(box len_zero::LenZero);
154 reg.register_late_lint_pass(box misc::CmpOwned);
155 reg.register_late_lint_pass(box attrs::AttrPass);
156 reg.register_late_lint_pass(box collapsible_if::CollapsibleIf);
157 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
158 reg.register_late_lint_pass(box misc::ModuloOne);
159 reg.register_late_lint_pass(box unicode::Unicode);
160 reg.register_late_lint_pass(box strings::StringAdd);
161 reg.register_early_lint_pass(box returns::ReturnPass);
162 reg.register_late_lint_pass(box methods::MethodsPass);
163 reg.register_late_lint_pass(box shadow::ShadowPass);
164 reg.register_late_lint_pass(box types::LetPass);
165 reg.register_late_lint_pass(box types::UnitCmp);
166 reg.register_late_lint_pass(box loops::LoopsPass);
167 reg.register_late_lint_pass(box lifetimes::LifetimePass);
168 reg.register_late_lint_pass(box entry::HashMapLint);
169 reg.register_late_lint_pass(box ranges::StepByZero);
170 reg.register_late_lint_pass(box types::CastPass);
171 reg.register_late_lint_pass(box types::TypeComplexityPass);
172 reg.register_late_lint_pass(box matches::MatchPass);
173 reg.register_late_lint_pass(box misc::PatternPass);
174 reg.register_late_lint_pass(box minmax::MinMaxPass);
175 reg.register_late_lint_pass(box open_options::NonSensicalOpenOptions);
176 reg.register_late_lint_pass(box zero_div_zero::ZeroDivZeroPass);
177 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
178 reg.register_late_lint_pass(box needless_features::NeedlessFeaturesPass);
179 reg.register_late_lint_pass(box needless_update::NeedlessUpdatePass);
180 reg.register_late_lint_pass(box no_effect::NoEffectPass);
181 reg.register_late_lint_pass(box map_clone::MapClonePass);
182 reg.register_late_lint_pass(box temporary_assignment::TemporaryAssignmentPass);
183 reg.register_late_lint_pass(box transmute::UselessTransmute);
184 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
185 reg.register_late_lint_pass(box escape::EscapePass);
186 reg.register_early_lint_pass(box misc_early::MiscEarly);
187 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
188 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
189 reg.register_late_lint_pass(box panic::PanicPass);
190 reg.register_late_lint_pass(box strings::StringLitAsBytes);
191 reg.register_late_lint_pass(box derive::Derive);
192 reg.register_late_lint_pass(box types::CharLitAsU8);
193 reg.register_late_lint_pass(box print::PrintLint);
194 reg.register_late_lint_pass(box vec::UselessVec);
195 reg.register_late_lint_pass(box drop_ref::DropRefPass);
196 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
197 reg.register_late_lint_pass(box regex::RegexPass::default());
198 reg.register_late_lint_pass(box copies::CopyAndPaste);
199 reg.register_late_lint_pass(box format::FormatMacLint);
200 reg.register_early_lint_pass(box formatting::Formatting);
201 reg.register_late_lint_pass(box swap::Swap);
202 reg.register_early_lint_pass(box if_not_else::IfNotElse);
203 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
204 reg.register_late_lint_pass(box unused_label::UnusedLabel);
205 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
207 reg.register_lint_group("clippy_pedantic", vec![
208 array_indexing::INDEXING_SLICING,
209 enum_glob_use::ENUM_GLOB_USE,
210 matches::SINGLE_MATCH_ELSE,
211 methods::OPTION_UNWRAP_USED,
212 methods::RESULT_UNWRAP_USED,
213 methods::WRONG_PUB_SELF_CONVENTION,
215 mutex_atomic::MUTEX_INTEGER,
218 shadow::SHADOW_REUSE,
220 shadow::SHADOW_UNRELATED,
222 strings::STRING_ADD_ASSIGN,
223 types::CAST_POSSIBLE_TRUNCATION,
224 types::CAST_POSSIBLE_WRAP,
225 types::CAST_PRECISION_LOSS,
226 types::CAST_SIGN_LOSS,
227 unicode::NON_ASCII_LITERAL,
228 unicode::UNICODE_NOT_NFC,
231 reg.register_lint_group("clippy", vec![
232 approx_const::APPROX_CONSTANT,
233 array_indexing::OUT_OF_BOUNDS_INDEXING,
234 attrs::DEPRECATED_SEMVER,
235 attrs::INLINE_ALWAYS,
236 bit_mask::BAD_BIT_MASK,
237 bit_mask::INEFFECTIVE_BIT_MASK,
238 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
239 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
240 collapsible_if::COLLAPSIBLE_IF,
241 copies::IF_SAME_THEN_ELSE,
242 copies::IFS_SAME_COND,
243 copies::MATCH_SAME_ARMS,
244 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
245 derive::DERIVE_HASH_XOR_EQ,
246 derive::EXPL_IMPL_CLONE_ON_COPY,
249 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
250 enum_variants::ENUM_VARIANT_NAMES,
253 eta_reduction::REDUNDANT_CLOSURE,
254 format::USELESS_FORMAT,
255 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
256 formatting::SUSPICIOUS_ELSE_FORMATTING,
257 identity_op::IDENTITY_OP,
258 if_not_else::IF_NOT_ELSE,
259 items_after_statements::ITEMS_AFTER_STATEMENTS,
260 len_zero::LEN_WITHOUT_IS_EMPTY,
262 lifetimes::NEEDLESS_LIFETIMES,
263 lifetimes::UNUSED_LIFETIMES,
265 loops::EXPLICIT_COUNTER_LOOP,
266 loops::EXPLICIT_ITER_LOOP,
268 loops::FOR_LOOP_OVER_OPTION,
269 loops::FOR_LOOP_OVER_RESULT,
270 loops::ITER_NEXT_LOOP,
271 loops::NEEDLESS_RANGE_LOOP,
272 loops::REVERSE_RANGE_LOOP,
273 loops::UNUSED_COLLECT,
274 loops::WHILE_LET_LOOP,
275 loops::WHILE_LET_ON_ITERATOR,
276 map_clone::MAP_CLONE,
278 matches::MATCH_OVERLAPPING_ARM,
279 matches::MATCH_REF_PATS,
280 matches::SINGLE_MATCH,
281 methods::CHARS_NEXT_CMP,
282 methods::CLONE_DOUBLE_REF,
283 methods::CLONE_ON_COPY,
284 methods::EXTEND_FROM_SLICE,
285 methods::FILTER_NEXT,
286 methods::NEW_RET_NO_SELF,
288 methods::OPTION_MAP_UNWRAP_OR,
289 methods::OPTION_MAP_UNWRAP_OR_ELSE,
290 methods::OR_FUN_CALL,
291 methods::SEARCH_IS_SOME,
292 methods::SHOULD_IMPLEMENT_TRAIT,
293 methods::SINGLE_CHAR_PATTERN,
294 methods::STR_TO_STRING,
295 methods::STRING_TO_STRING,
296 methods::WRONG_SELF_CONVENTION,
302 misc::REDUNDANT_PATTERN,
303 misc::TOPLEVEL_REF_ARG,
304 misc::USED_UNDERSCORE_BINDING,
305 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
306 misc_early::REDUNDANT_CLOSURE_CALL,
307 misc_early::UNNEEDED_FIELD_PATTERN,
308 mut_reference::UNNECESSARY_MUT_PASSED,
309 mutex_atomic::MUTEX_ATOMIC,
310 needless_bool::BOOL_COMPARISON,
311 needless_bool::NEEDLESS_BOOL,
312 needless_features::UNSTABLE_AS_MUT_SLICE,
313 needless_features::UNSTABLE_AS_SLICE,
314 needless_update::NEEDLESS_UPDATE,
315 new_without_default::NEW_WITHOUT_DEFAULT,
316 no_effect::NO_EFFECT,
317 open_options::NONSENSICAL_OPEN_OPTIONS,
318 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
320 precedence::PRECEDENCE,
322 ranges::RANGE_STEP_BY_ZERO,
323 ranges::RANGE_ZIP_WITH_LEN,
324 regex::INVALID_REGEX,
326 regex::TRIVIAL_REGEX,
327 returns::LET_AND_RETURN,
328 returns::NEEDLESS_RETURN,
329 strings::STRING_LIT_AS_BYTES,
330 swap::ALMOST_SWAPPED,
332 temporary_assignment::TEMPORARY_ASSIGNMENT,
333 transmute::USELESS_TRANSMUTE,
334 types::ABSURD_EXTREME_COMPARISONS,
336 types::CHAR_LIT_AS_U8,
337 types::LET_UNIT_VALUE,
339 types::TYPE_COMPLEXITY,
341 unicode::ZERO_WIDTH_SPACE,
342 unused_label::UNUSED_LABEL,
344 zero_div_zero::ZERO_DIVIDED_BY_ZERO,