1 // Copyright 2015 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution and at
3 // http://rust-lang.org/COPYRIGHT.
5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8 // option. This file may not be copied, modified, or distributed
9 // except according to those terms.
11 // Objects for seeking through a char stream for occurences of TODO and FIXME.
12 // Depending on the loaded configuration, may also check that these have an
13 // associated issue number.
16 pub use config::ReportTactic;
18 const TO_DO_CHARS: &'static [char] = &['T', 'O', 'D', 'O'];
19 const FIX_ME_CHARS: &'static [char] = &['F', 'I', 'X', 'M', 'E'];
21 // Enabled implementation detail is here because it is
22 // irrelevant outside the issues module
24 fn is_enabled(&self) -> bool {
26 ReportTactic::Always => true,
27 ReportTactic::Unnumbered => true,
28 ReportTactic::Never => false,
33 #[derive(Clone, Copy)]
35 Issue { todo_idx: usize, fixme_idx: usize },
36 Number { issue: Issue, part: NumberPart },
39 #[derive(Clone, Copy)]
47 #[derive(PartialEq, Eq, Debug, Clone, Copy)]
49 issue_type: IssueType,
50 // Indicates whether we're looking for issues with missing numbers, or
51 // all issues of this type.
55 impl fmt::Display for Issue {
56 fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
57 let msg = match self.issue_type {
58 IssueType::Todo => "TODO",
59 IssueType::Fixme => "FIXME",
61 let details = if self.missing_number {
62 " without issue number"
67 write!(fmt, "{}{}", msg, details)
71 #[derive(PartialEq, Eq, Debug, Clone, Copy)]
77 enum IssueClassification {
83 pub struct BadIssueSeeker {
85 report_todo: ReportTactic,
86 report_fixme: ReportTactic,
90 pub fn new(report_todo: ReportTactic, report_fixme: ReportTactic) -> BadIssueSeeker {
92 state: Seeking::Issue {
96 report_todo: report_todo,
97 report_fixme: report_fixme,
101 // Check whether or not the current char is conclusive evidence for an
102 // unnumbered TO-DO or FIX-ME.
103 pub fn inspect(&mut self, c: char) -> Option<Issue> {
105 Seeking::Issue { todo_idx, fixme_idx } => {
106 self.state = self.inspect_issue(c, todo_idx, fixme_idx);
108 Seeking::Number { issue, part } => {
109 let result = self.inspect_number(c, issue, part);
111 if let IssueClassification::None = result {
115 self.state = Seeking::Issue {
120 if let IssueClassification::Bad(issue) = result {
129 fn inspect_issue(&mut self, c: char, mut todo_idx: usize, mut fixme_idx: usize) -> Seeking {
130 // FIXME: Should we also check for lower case characters?
131 if self.report_todo.is_enabled() && c == TO_DO_CHARS[todo_idx] {
133 if todo_idx == TO_DO_CHARS.len() {
134 return Seeking::Number {
136 issue_type: IssueType::Todo,
137 missing_number: if let ReportTactic::Unnumbered = self.report_todo {
143 part: NumberPart::OpenParen,
147 } else if self.report_fixme.is_enabled() && c == FIX_ME_CHARS[fixme_idx] {
148 // Exploit the fact that the character sets of todo and fixme
149 // are disjoint by adding else.
151 if fixme_idx == FIX_ME_CHARS.len() {
152 return Seeking::Number {
154 issue_type: IssueType::Fixme,
155 missing_number: if let ReportTactic::Unnumbered = self.report_fixme {
161 part: NumberPart::OpenParen,
172 fixme_idx: fixme_idx,
176 fn inspect_number(&mut self,
179 mut part: NumberPart)
180 -> IssueClassification {
181 if !issue.missing_number || c == '\n' {
182 return IssueClassification::Bad(issue);
184 return if let NumberPart::CloseParen = part {
185 IssueClassification::Good
187 IssueClassification::Bad(issue)
192 NumberPart::OpenParen => {
194 return IssueClassification::Bad(issue);
196 part = NumberPart::Pound;
199 NumberPart::Pound => {
201 part = NumberPart::Number;
204 NumberPart::Number => {
205 if c >= '0' && c <= '9' {
206 part = NumberPart::CloseParen;
208 return IssueClassification::Bad(issue);
211 NumberPart::CloseParen => {}
214 self.state = Seeking::Number {
219 IssueClassification::None
224 fn find_unnumbered_issue() {
225 fn check_fail(text: &str, failing_pos: usize) {
226 let mut seeker = BadIssueSeeker::new(ReportTactic::Unnumbered, ReportTactic::Unnumbered);
227 assert_eq!(Some(failing_pos),
228 text.chars().position(|c| seeker.inspect(c).is_some()));
231 fn check_pass(text: &str) {
232 let mut seeker = BadIssueSeeker::new(ReportTactic::Unnumbered, ReportTactic::Unnumbered);
233 assert_eq!(None, text.chars().position(|c| seeker.inspect(c).is_some()));
236 check_fail("TODO\n", 4);
237 check_pass(" TO FIX DOME\n");
238 check_fail(" \n FIXME\n", 8);
239 check_fail("FIXME(\n", 6);
240 check_fail("FIXME(#\n", 7);
241 check_fail("FIXME(#1\n", 8);
242 check_fail("FIXME(#)1\n", 7);
243 check_pass("FIXME(#1222)\n");
244 check_fail("FIXME(#12\n22)\n", 9);
245 check_pass("FIXME(@maintainer, #1222, hello)\n");
246 check_fail("TODO(#22) FIXME\n", 15);
251 fn is_bad_issue(text: &str, report_todo: ReportTactic, report_fixme: ReportTactic) -> bool {
252 let mut seeker = BadIssueSeeker::new(report_todo, report_fixme);
253 text.chars().any(|c| seeker.inspect(c).is_some())
256 assert!(is_bad_issue("TODO(@maintainer, #1222, hello)\n",
257 ReportTactic::Always,
258 ReportTactic::Never));
260 assert!(!is_bad_issue("TODO: no number\n",
262 ReportTactic::Always));
264 assert!(is_bad_issue("This is a FIXME(#1)\n",
266 ReportTactic::Always));
268 assert!(!is_bad_issue("bad FIXME\n", ReportTactic::Always, ReportTactic::Never));
273 let mut seeker = BadIssueSeeker::new(ReportTactic::Always, ReportTactic::Never);
274 let expected = Some(Issue {
275 issue_type: IssueType::Todo,
276 missing_number: false,
280 "TODO(#100): more awesomeness"
282 .map(|c| seeker.inspect(c))
283 .find(Option::is_some)
286 let mut seeker = BadIssueSeeker::new(ReportTactic::Never, ReportTactic::Unnumbered);
287 let expected = Some(Issue {
288 issue_type: IssueType::Fixme,
289 missing_number: true,
293 "Test. FIXME: bad, bad, not good"
295 .map(|c| seeker.inspect(c))
296 .find(Option::is_some)