1 // High level formatting functions.
3 use std::collections::HashMap;
4 use std::io::{self, Write};
5 use std::panic::{catch_unwind, AssertUnwindSafe};
7 use std::time::{Duration, Instant};
10 use syntax::codemap::{CodeMap, FilePathMapping, Span};
11 use syntax::errors::emitter::{ColorConfig, EmitterWriter};
12 use syntax::errors::{DiagnosticBuilder, Handler};
13 use syntax::parse::{self, ParseSess};
15 use comment::{CharClasses, FullCodeCharKind};
16 use config::{Config, FileName, NewlineStyle, Verbosity};
17 use issues::BadIssueSeeker;
18 use visitor::{FmtVisitor, SnippetProvider};
19 use {filemap, modules, ErrorKind, FormatReport, Input, Session};
21 // A map of the files of a crate, with their new content
22 pub(crate) type FileMap = Vec<FileRecord>;
24 pub(crate) type FileRecord = (FileName, String);
26 pub(crate) struct FormattingError {
27 pub(crate) line: usize,
28 pub(crate) kind: ErrorKind,
31 pub(crate) line_buffer: String,
34 impl FormattingError {
35 pub(crate) fn from_span(span: &Span, codemap: &CodeMap, kind: ErrorKind) -> FormattingError {
37 line: codemap.lookup_char_pos(span.lo()).line,
38 is_comment: kind.is_comment(),
46 .get_line(fl.lines[0].line_index)
47 .map(|l| l.into_owned())
49 .unwrap_or_else(|| String::new()),
53 pub(crate) fn msg_prefix(&self) -> &str {
55 ErrorKind::LineOverflow(..)
56 | ErrorKind::TrailingWhitespace
57 | ErrorKind::IoError(_)
58 | ErrorKind::ParseError
59 | ErrorKind::LostComment => "internal error:",
60 ErrorKind::LicenseCheck | ErrorKind::BadAttr | ErrorKind::VersionMismatch => "error:",
61 ErrorKind::BadIssue(_) | ErrorKind::DeprecatedAttr => "warning:",
65 pub(crate) fn msg_suffix(&self) -> &str {
66 if self.is_comment || self.is_string {
67 "set `error_on_unformatted = false` to suppress \
68 the warning against comments or string literals\n"
75 pub(crate) fn format_len(&self) -> (usize, usize) {
77 ErrorKind::LineOverflow(found, max) => (max, found - max),
78 ErrorKind::TrailingWhitespace
79 | ErrorKind::DeprecatedAttr
81 | ErrorKind::LostComment => {
82 let trailing_ws_start = self
84 .rfind(|c: char| !c.is_whitespace())
89 self.line_buffer.len() - trailing_ws_start,
97 pub(crate) type FormatErrorMap = HashMap<FileName, Vec<FormattingError>>;
99 #[derive(Default, Debug)]
100 pub(crate) struct ReportedErrors {
101 pub(crate) has_operational_errors: bool,
102 pub(crate) has_check_errors: bool,
105 fn should_emit_verbose<F>(is_stdin: bool, config: &Config, f: F)
109 if config.verbose() == Verbosity::Verbose && !is_stdin {
114 /// Returns true if the line with the given line number was skipped by `#[rustfmt::skip]`.
115 fn is_skipped_line(line_number: usize, skipped_range: &[(usize, usize)]) -> bool {
118 .any(|&(lo, hi)| lo <= line_number && line_number <= hi)
121 fn should_report_error(
123 char_kind: FullCodeCharKind,
125 error_kind: &ErrorKind,
127 let allow_error_report = if char_kind.is_comment() || is_string || error_kind.is_comment() {
128 config.error_on_unformatted()
134 ErrorKind::LineOverflow(..) => config.error_on_line_overflow() && allow_error_report,
135 ErrorKind::TrailingWhitespace | ErrorKind::LostComment => allow_error_report,
140 // Formatting done on a char by char or line by line basis.
141 // FIXME(#20) other stuff for parity with make tidy
145 skipped_range: &[(usize, usize)],
147 report: &FormatReport,
149 let mut last_was_space = false;
150 let mut line_len = 0;
151 let mut cur_line = 1;
152 let mut newline_count = 0;
153 let mut errors = vec![];
154 let mut issue_seeker = BadIssueSeeker::new(config.report_todo(), config.report_fixme());
155 let mut line_buffer = String::with_capacity(config.max_width() * 2);
156 let mut is_string = false; // true if the current line contains a string literal.
157 let mut format_line = config.file_lines().contains_line(name, cur_line);
158 let allow_issue_seek = !issue_seeker.is_disabled();
161 if let Some(ref license_template) = config.license_template {
162 if !license_template.is_match(text) {
163 errors.push(FormattingError {
165 kind: ErrorKind::LicenseCheck,
168 line_buffer: String::new(),
173 // Iterate over the chars in the file map.
174 for (kind, c) in CharClasses::new(text.chars()) {
179 if allow_issue_seek && format_line {
180 // Add warnings for bad todos/ fixmes
181 if let Some(issue) = issue_seeker.inspect(c) {
182 errors.push(FormattingError {
184 kind: ErrorKind::BadIssue(issue),
187 line_buffer: String::new(),
194 // Check for (and record) trailing whitespace.
196 if should_report_error(config, kind, is_string, &ErrorKind::TrailingWhitespace)
197 && !is_skipped_line(cur_line, skipped_range)
199 errors.push(FormattingError {
201 kind: ErrorKind::TrailingWhitespace,
202 is_comment: kind.is_comment(),
203 is_string: kind.is_string(),
204 line_buffer: line_buffer.clone(),
210 // Check for any line width errors we couldn't correct.
211 let error_kind = ErrorKind::LineOverflow(line_len, config.max_width());
212 if line_len > config.max_width()
213 && !is_skipped_line(cur_line, skipped_range)
214 && should_report_error(config, kind, is_string, &error_kind)
216 errors.push(FormattingError {
219 is_comment: kind.is_comment(),
221 line_buffer: line_buffer.clone(),
228 format_line = config.file_lines().contains_line(name, cur_line);
230 last_was_space = false;
235 line_len += if c == '\t' { config.tab_spaces() } else { 1 };
236 last_was_space = c.is_whitespace();
238 if kind.is_string() {
244 if newline_count > 1 {
245 debug!("track truncate: {} {}", text.len(), newline_count);
246 let line = text.len() - newline_count + 1;
250 report.append(name.clone(), errors);
253 fn parse_input<'sess>(
255 parse_session: &'sess ParseSess,
257 ) -> Result<ast::Crate, ParseError<'sess>> {
258 let mut parser = match input {
259 Input::File(file) => parse::new_parser_from_file(parse_session, &file),
260 Input::Text(text) => parse::new_parser_from_source_str(
262 syntax::codemap::FileName::Custom("stdin".to_owned()),
267 parser.cfg_mods = false;
268 if config.skip_children() {
269 parser.recurse_into_file_modules = false;
272 let mut parser = AssertUnwindSafe(parser);
273 let result = catch_unwind(move || parser.0.parse_crate_mod());
277 if parse_session.span_diagnostic.has_errors() {
278 // Bail out if the parser recovered from an error.
279 Err(ParseError::Recovered)
284 Ok(Err(e)) => Err(ParseError::Error(e)),
285 Err(_) => Err(ParseError::Panic),
289 /// All the ways that parsing can fail.
290 enum ParseError<'sess> {
291 /// There was an error, but the parser recovered.
293 /// There was an error (supplied) and parsing failed.
294 Error(DiagnosticBuilder<'sess>),
295 /// The parser panicked.
299 impl<'b, T: Write + 'b> Session<'b, T> {
300 pub(crate) fn format_input_inner(
303 ) -> Result<(FileMap, FormatReport), ErrorKind> {
304 syntax_pos::hygiene::set_default_edition(self.config.edition().to_libsyntax_pos_edition());
306 if self.config.disable_all_formatting() {
307 // When the input is from stdin, echo back the input.
308 if let Input::Text(ref buf) = input {
309 if let Err(e) = io::stdout().write_all(buf.as_bytes()) {
310 return Err(From::from(e));
313 return Ok((FileMap::new(), FormatReport::new()));
316 let mut filemap = FileMap::new();
317 let config = &self.config.clone();
318 let format_result = format_project(input, config, |path, mut result| {
319 if let Some(ref mut out) = self.out {
320 match filemap::write_file(&mut result, &path, out, &self.config) {
321 Ok(b) if b => self.summary.add_diff(),
323 // Create a new error with path_str to help users see which files failed
324 let err_msg = format!("{}: {}", path, e);
325 return Err(io::Error::new(e.kind(), err_msg).into());
331 filemap.push((path, result));
335 format_result.map(|(result, summary)| {
336 self.summary.add(summary);
342 fn format_project<F>(
345 mut formatted_file: F,
346 ) -> Result<(FormatReport, Summary), ErrorKind>
348 F: FnMut(FileName, String) -> Result<(), ErrorKind>,
350 let mut summary = Summary::default();
351 let mut timer = Timer::Initialized(Instant::now());
353 let input_is_stdin = input.is_text();
354 let main_file = match input {
355 Input::File(ref file) => FileName::Real(file.clone()),
356 Input::Text(..) => FileName::Stdin,
360 let codemap = Rc::new(CodeMap::new(FilePathMapping::empty()));
361 let mut parse_session = make_parse_sess(codemap.clone(), config);
362 let krate = match parse_input(input, &parse_session, config) {
366 ParseError::Error(mut diagnostic) => diagnostic.emit(),
367 ParseError::Panic => {
368 // Note that if you see this message and want more information,
369 // then go to `parse_input` and run the parse function without
370 // `catch_unwind` so rustfmt panics and you can get a backtrace.
371 should_emit_verbose(main_file != FileName::Stdin, config, || {
372 println!("The Rust parser panicked")
375 ParseError::Recovered => {}
377 summary.add_parsing_error();
378 return Err(ErrorKind::ParseError);
381 timer = timer.done_parsing();
383 // Suppress error output if we have to do any further parsing.
384 let silent_emitter = Box::new(EmitterWriter::new(
385 Box::new(Vec::new()),
386 Some(codemap.clone()),
390 parse_session.span_diagnostic = Handler::with_emitter(true, false, silent_emitter);
392 let report = FormatReport::new();
394 let skip_children = config.skip_children();
395 for (path, module) in modules::list_files(&krate, parse_session.codemap())? {
396 if (skip_children && path != main_file) || config.ignore().skip_file(&path) {
399 should_emit_verbose(main_file != FileName::Stdin, config, || {
400 println!("Formatting {}", path)
402 let filemap = parse_session
404 .lookup_char_pos(module.inner.lo())
406 let big_snippet = filemap.src.as_ref().unwrap();
407 let snippet_provider = SnippetProvider::new(filemap.start_pos, big_snippet);
409 FmtVisitor::from_codemap(&parse_session, config, &snippet_provider, report.clone());
410 // Format inner attributes if available.
411 if !krate.attrs.is_empty() && path == main_file {
412 visitor.skip_empty_lines(filemap.end_pos);
413 if visitor.visit_attrs(&krate.attrs, ast::AttrStyle::Inner) {
414 visitor.push_rewrite(module.inner, None);
416 visitor.format_separate_mod(module, &*filemap);
419 visitor.last_pos = filemap.start_pos;
420 visitor.skip_empty_lines(filemap.end_pos);
421 visitor.format_separate_mod(module, &*filemap);
426 ::utils::count_newlines(&visitor.buffer)
429 // For some reason, the codemap does not include terminating
430 // newlines so we must add one on for each file. This is sad.
431 filemap::append_newline(&mut visitor.buffer);
436 &visitor.skipped_range,
440 replace_with_system_newlines(&mut visitor.buffer, config);
442 if visitor.macro_rewrite_failure {
443 summary.add_macro_format_failure();
446 formatted_file(path, visitor.buffer)?;
448 timer = timer.done_formatting();
450 should_emit_verbose(input_is_stdin, config, || {
452 "Spent {0:.3} secs in the parsing phase, and {1:.3} secs in the formatting phase",
453 timer.get_parse_time(),
454 timer.get_format_time(),
458 if report.has_warnings() {
459 summary.add_formatting_error();
462 let report_errs = &report.internal.borrow().1;
463 if report_errs.has_check_errors {
464 summary.add_check_error();
466 if report_errs.has_operational_errors {
467 summary.add_operational_error();
471 Ok((report, summary))
474 fn make_parse_sess(codemap: Rc<CodeMap>, config: &Config) -> ParseSess {
475 let tty_handler = if config.hide_parse_errors() {
476 let silent_emitter = Box::new(EmitterWriter::new(
477 Box::new(Vec::new()),
478 Some(codemap.clone()),
482 Handler::with_emitter(true, false, silent_emitter)
484 let supports_color = term::stderr().map_or(false, |term| term.supports_color());
485 let color_cfg = if supports_color {
490 Handler::with_tty_emitter(color_cfg, true, false, Some(codemap.clone()))
493 ParseSess::with_span_handler(tty_handler, codemap)
496 fn replace_with_system_newlines(text: &mut String, config: &Config) -> () {
497 let style = if config.newline_style() == NewlineStyle::Native {
499 NewlineStyle::Windows
504 config.newline_style()
508 NewlineStyle::Unix => return,
509 NewlineStyle::Windows => {
510 let mut transformed = String::with_capacity(text.capacity());
511 for c in text.chars() {
513 '\n' => transformed.push_str("\r\n"),
515 c => transformed.push(c),
520 NewlineStyle::Native => unreachable!(),
524 /// A single span of changed lines, with 0 or more removed lines
525 /// and a vector of 0 or more inserted lines.
526 #[derive(Debug, PartialEq, Eq)]
527 pub(crate) struct ModifiedChunk {
528 /// The first to be removed from the original text
529 pub line_number_orig: u32,
530 /// The number of lines which have been replaced
531 pub lines_removed: u32,
533 pub lines: Vec<String>,
536 /// Set of changed sections of a file.
537 #[derive(Debug, PartialEq, Eq)]
538 pub(crate) struct ModifiedLines {
539 /// The set of changed chunks.
540 pub chunks: Vec<ModifiedChunk>,
543 #[derive(Clone, Copy, Debug)]
545 Initialized(Instant),
546 DoneParsing(Instant, Instant),
547 DoneFormatting(Instant, Instant, Instant),
551 fn done_parsing(self) -> Self {
553 Timer::Initialized(init_time) => Timer::DoneParsing(init_time, Instant::now()),
554 _ => panic!("Timer can only transition to DoneParsing from Initialized state"),
558 fn done_formatting(self) -> Self {
560 Timer::DoneParsing(init_time, parse_time) => {
561 Timer::DoneFormatting(init_time, parse_time, Instant::now())
563 _ => panic!("Timer can only transition to DoneFormatting from DoneParsing state"),
567 /// Returns the time it took to parse the source files in seconds.
568 fn get_parse_time(&self) -> f32 {
570 Timer::DoneParsing(init, parse_time) | Timer::DoneFormatting(init, parse_time, _) => {
571 // This should never underflow since `Instant::now()` guarantees monotonicity.
572 Self::duration_to_f32(parse_time.duration_since(init))
574 Timer::Initialized(..) => unreachable!(),
578 /// Returns the time it took to go from the parsed AST to the formatted output. Parsing time is
580 fn get_format_time(&self) -> f32 {
582 Timer::DoneFormatting(_init, parse_time, format_time) => {
583 Self::duration_to_f32(format_time.duration_since(parse_time))
585 Timer::DoneParsing(..) | Timer::Initialized(..) => unreachable!(),
589 fn duration_to_f32(d: Duration) -> f32 {
590 d.as_secs() as f32 + d.subsec_nanos() as f32 / 1_000_000_000f32
594 /// A summary of a Rustfmt run.
595 #[derive(Debug, Default, Clone, Copy)]
597 // Encountered e.g. an IO error.
598 has_operational_errors: bool,
600 // Failed to reformat code because of parsing errors.
601 has_parsing_errors: bool,
603 // Code is valid, but it is impossible to format it properly.
604 has_formatting_errors: bool,
606 // Code contains macro call that was unable to format.
607 pub(crate) has_macro_format_failure: bool,
609 // Failed a check, such as the license check or other opt-in checking.
610 has_check_errors: bool,
612 /// Formatted code differs from existing code (--check only).
617 pub fn has_operational_errors(&self) -> bool {
618 self.has_operational_errors
621 pub fn has_parsing_errors(&self) -> bool {
622 self.has_parsing_errors
625 pub fn has_formatting_errors(&self) -> bool {
626 self.has_formatting_errors
629 pub fn has_check_errors(&self) -> bool {
630 self.has_check_errors
633 pub(crate) fn has_macro_formatting_failure(&self) -> bool {
634 self.has_macro_format_failure
637 pub fn add_operational_error(&mut self) {
638 self.has_operational_errors = true;
641 pub(crate) fn add_parsing_error(&mut self) {
642 self.has_parsing_errors = true;
645 pub(crate) fn add_formatting_error(&mut self) {
646 self.has_formatting_errors = true;
649 pub(crate) fn add_check_error(&mut self) {
650 self.has_check_errors = true;
653 pub(crate) fn add_diff(&mut self) {
654 self.has_diff = true;
657 pub(crate) fn add_macro_format_failure(&mut self) {
658 self.has_macro_format_failure = true;
661 pub fn has_no_errors(&self) -> bool {
662 !(self.has_operational_errors
663 || self.has_parsing_errors
664 || self.has_formatting_errors
668 /// Combine two summaries together.
669 pub fn add(&mut self, other: Summary) {
670 self.has_operational_errors |= other.has_operational_errors;
671 self.has_formatting_errors |= other.has_formatting_errors;
672 self.has_macro_format_failure |= other.has_macro_format_failure;
673 self.has_parsing_errors |= other.has_parsing_errors;
674 self.has_check_errors |= other.has_check_errors;
675 self.has_diff |= other.has_diff;