1 // High level formatting functions.
3 use std::collections::HashMap;
4 use std::io::{self, Write};
5 use std::panic::{catch_unwind, AssertUnwindSafe};
7 use std::time::{Duration, Instant};
10 use syntax::codemap::{CodeMap, FilePathMapping, Span};
11 use syntax::errors::emitter::{ColorConfig, EmitterWriter};
12 use syntax::errors::Handler;
13 use syntax::parse::{self, ParseSess};
15 use comment::{CharClasses, FullCodeCharKind};
16 use config::{Config, FileName, Verbosity};
17 use issues::BadIssueSeeker;
18 use visitor::{FmtVisitor, SnippetProvider};
19 use {filemap, modules, ErrorKind, FormatReport, Input, Session};
21 // A map of the files of a crate, with their new content
22 pub(crate) type FileMap = Vec<FileRecord>;
23 pub(crate) type FileRecord = (FileName, String);
25 impl<'b, T: Write + 'b> Session<'b, T> {
26 pub(crate) fn format_input_inner(&mut self, input: Input) -> Result<FormatReport, ErrorKind> {
27 if !self.config.version_meets_requirement() {
28 return Err(ErrorKind::VersionMismatch);
31 syntax::with_globals(|| {
32 syntax_pos::hygiene::set_default_edition(
33 self.config.edition().to_libsyntax_pos_edition(),
36 if self.config.disable_all_formatting() {
37 // When the input is from stdin, echo back the input.
38 if let Input::Text(ref buf) = input {
39 if let Err(e) = io::stdout().write_all(buf.as_bytes()) {
40 return Err(From::from(e));
43 return Ok(FormatReport::new());
46 let config = &self.config.clone();
47 let format_result = format_project(input, config, self);
49 format_result.map(|report| {
51 let new_errors = &report.internal.borrow().1;
53 self.errors.add(new_errors);
61 // Format an entire crate (or subset of the module tree).
62 fn format_project<T: FormatHandler>(
66 ) -> Result<FormatReport, ErrorKind> {
67 let mut timer = Timer::Initialized(Instant::now());
69 let main_file = input.file_name();
70 let input_is_stdin = main_file == FileName::Stdin;
73 let codemap = Rc::new(CodeMap::new(FilePathMapping::empty()));
74 let mut parse_session = make_parse_sess(codemap.clone(), config);
75 let mut report = FormatReport::new();
76 let krate = parse_crate(input, &parse_session, config, &mut report)?;
77 timer = timer.done_parsing();
79 // Suppress error output if we have to do any further parsing.
80 let silent_emitter = silent_emitter(codemap);
81 parse_session.span_diagnostic = Handler::with_emitter(true, false, silent_emitter);
83 let mut context = FormatContext::new(&krate, report, parse_session, config, handler);
85 let files = modules::list_files(&krate, context.parse_session.codemap())?;
86 for (path, module) in files {
87 if (config.skip_children() && path != main_file) || config.ignore().skip_file(&path) {
90 should_emit_verbose(!input_is_stdin, config, || println!("Formatting {}", path));
91 let is_root = path == main_file;
92 context.format_file(path, module, is_root)?;
94 timer = timer.done_formatting();
96 should_emit_verbose(!input_is_stdin, config, || {
98 "Spent {0:.3} secs in the parsing phase, and {1:.3} secs in the formatting phase",
99 timer.get_parse_time(),
100 timer.get_format_time(),
107 // Used for formatting files.
109 struct FormatContext<'a, T: FormatHandler + 'a> {
110 krate: &'a ast::Crate,
111 report: FormatReport,
112 parse_session: ParseSess,
117 impl<'a, T: FormatHandler + 'a> FormatContext<'a, T> {
118 // Formats a single file/module.
124 ) -> Result<(), ErrorKind> {
128 .lookup_char_pos(module.inner.lo())
130 let big_snippet = filemap.src.as_ref().unwrap();
131 let snippet_provider = SnippetProvider::new(filemap.start_pos, big_snippet);
132 let mut visitor = FmtVisitor::from_codemap(
139 // Format inner attributes if available.
140 if !self.krate.attrs.is_empty() && is_root {
141 visitor.skip_empty_lines(filemap.end_pos);
142 if visitor.visit_attrs(&self.krate.attrs, ast::AttrStyle::Inner) {
143 visitor.push_rewrite(module.inner, None);
145 visitor.format_separate_mod(module, &*filemap);
148 visitor.last_pos = filemap.start_pos;
149 visitor.skip_empty_lines(filemap.end_pos);
150 visitor.format_separate_mod(module, &*filemap);
155 ::utils::count_newlines(&visitor.buffer)
158 // For some reason, the codemap does not include terminating
159 // newlines so we must add one on for each file. This is sad.
160 filemap::append_newline(&mut visitor.buffer);
165 &visitor.skipped_range,
171 .apply(&mut visitor.buffer, &big_snippet);
173 if visitor.macro_rewrite_failure {
174 self.report.add_macro_format_failure();
178 .handle_formatted_file(path, visitor.buffer, &mut self.report)
182 // Handle the results of formatting.
183 trait FormatHandler {
184 fn handle_formatted_file(
188 report: &mut FormatReport,
189 ) -> Result<(), ErrorKind>;
192 impl<'b, T: Write + 'b> FormatHandler for Session<'b, T> {
193 // Called for each formatted file.
194 fn handle_formatted_file(
198 report: &mut FormatReport,
199 ) -> Result<(), ErrorKind> {
200 if let Some(ref mut out) = self.out {
201 match filemap::write_file(&mut result, &path, out, &self.config) {
202 Ok(b) if b => report.add_diff(),
204 // Create a new error with path_str to help users see which files failed
205 let err_msg = format!("{}: {}", path, e);
206 return Err(io::Error::new(e.kind(), err_msg).into());
212 self.filemap.push((path, result));
217 pub(crate) struct FormattingError {
218 pub(crate) line: usize,
219 pub(crate) kind: ErrorKind,
222 pub(crate) line_buffer: String,
225 impl FormattingError {
226 pub(crate) fn from_span(span: &Span, codemap: &CodeMap, kind: ErrorKind) -> FormattingError {
228 line: codemap.lookup_char_pos(span.lo()).line,
229 is_comment: kind.is_comment(),
233 .span_to_lines(*span)
237 .get_line(fl.lines[0].line_index)
238 .map(|l| l.into_owned())
239 }).unwrap_or_else(|| String::new()),
243 pub(crate) fn msg_prefix(&self) -> &str {
245 ErrorKind::LineOverflow(..)
246 | ErrorKind::TrailingWhitespace
247 | ErrorKind::IoError(_)
248 | ErrorKind::ParseError
249 | ErrorKind::LostComment => "internal error:",
250 ErrorKind::LicenseCheck | ErrorKind::BadAttr | ErrorKind::VersionMismatch => "error:",
251 ErrorKind::BadIssue(_) | ErrorKind::DeprecatedAttr => "warning:",
255 pub(crate) fn msg_suffix(&self) -> &str {
256 if self.is_comment || self.is_string {
257 "set `error_on_unformatted = false` to suppress \
258 the warning against comments or string literals\n"
265 pub(crate) fn format_len(&self) -> (usize, usize) {
267 ErrorKind::LineOverflow(found, max) => (max, found - max),
268 ErrorKind::TrailingWhitespace
269 | ErrorKind::DeprecatedAttr
271 | ErrorKind::LostComment => {
272 let trailing_ws_start = self
274 .rfind(|c: char| !c.is_whitespace())
279 self.line_buffer.len() - trailing_ws_start,
287 pub(crate) type FormatErrorMap = HashMap<FileName, Vec<FormattingError>>;
289 #[derive(Default, Debug)]
290 pub(crate) struct ReportedErrors {
291 // Encountered e.g. an IO error.
292 pub(crate) has_operational_errors: bool,
294 // Failed to reformat code because of parsing errors.
295 pub(crate) has_parsing_errors: bool,
297 // Code is valid, but it is impossible to format it properly.
298 pub(crate) has_formatting_errors: bool,
300 // Code contains macro call that was unable to format.
301 pub(crate) has_macro_format_failure: bool,
303 // Failed a check, such as the license check or other opt-in checking.
304 pub(crate) has_check_errors: bool,
306 /// Formatted code differs from existing code (--check only).
307 pub(crate) has_diff: bool,
310 impl ReportedErrors {
311 /// Combine two summaries together.
312 pub fn add(&mut self, other: &ReportedErrors) {
313 self.has_operational_errors |= other.has_operational_errors;
314 self.has_parsing_errors |= other.has_parsing_errors;
315 self.has_formatting_errors |= other.has_formatting_errors;
316 self.has_macro_format_failure |= other.has_macro_format_failure;
317 self.has_check_errors |= other.has_check_errors;
318 self.has_diff |= other.has_diff;
322 /// A single span of changed lines, with 0 or more removed lines
323 /// and a vector of 0 or more inserted lines.
324 #[derive(Debug, PartialEq, Eq)]
325 pub(crate) struct ModifiedChunk {
326 /// The first to be removed from the original text
327 pub line_number_orig: u32,
328 /// The number of lines which have been replaced
329 pub lines_removed: u32,
331 pub lines: Vec<String>,
334 /// Set of changed sections of a file.
335 #[derive(Debug, PartialEq, Eq)]
336 pub(crate) struct ModifiedLines {
337 /// The set of changed chunks.
338 pub chunks: Vec<ModifiedChunk>,
341 #[derive(Clone, Copy, Debug)]
343 Initialized(Instant),
344 DoneParsing(Instant, Instant),
345 DoneFormatting(Instant, Instant, Instant),
349 fn done_parsing(self) -> Self {
351 Timer::Initialized(init_time) => Timer::DoneParsing(init_time, Instant::now()),
352 _ => panic!("Timer can only transition to DoneParsing from Initialized state"),
356 fn done_formatting(self) -> Self {
358 Timer::DoneParsing(init_time, parse_time) => {
359 Timer::DoneFormatting(init_time, parse_time, Instant::now())
361 _ => panic!("Timer can only transition to DoneFormatting from DoneParsing state"),
365 /// Returns the time it took to parse the source files in seconds.
366 fn get_parse_time(&self) -> f32 {
368 Timer::DoneParsing(init, parse_time) | Timer::DoneFormatting(init, parse_time, _) => {
369 // This should never underflow since `Instant::now()` guarantees monotonicity.
370 Self::duration_to_f32(parse_time.duration_since(init))
372 Timer::Initialized(..) => unreachable!(),
376 /// Returns the time it took to go from the parsed AST to the formatted output. Parsing time is
378 fn get_format_time(&self) -> f32 {
380 Timer::DoneFormatting(_init, parse_time, format_time) => {
381 Self::duration_to_f32(format_time.duration_since(parse_time))
383 Timer::DoneParsing(..) | Timer::Initialized(..) => unreachable!(),
387 fn duration_to_f32(d: Duration) -> f32 {
388 d.as_secs() as f32 + d.subsec_nanos() as f32 / 1_000_000_000f32
392 // Formatting done on a char by char or line by line basis.
393 // FIXME(#20) other stuff for parity with make tidy
397 skipped_range: &[(usize, usize)],
399 report: &FormatReport,
401 let mut formatter = FormatLines::new(name, skipped_range, config);
402 formatter.check_license(text);
403 formatter.iterate(text);
405 if formatter.newline_count > 1 {
406 debug!("track truncate: {} {}", text.len(), formatter.newline_count);
407 let line = text.len() - formatter.newline_count + 1;
411 report.append(name.clone(), formatter.errors);
414 struct FormatLines<'a> {
416 skipped_range: &'a [(usize, usize)],
417 last_was_space: bool,
420 newline_count: usize,
421 errors: Vec<FormattingError>,
422 issue_seeker: BadIssueSeeker,
424 // true if the current line contains a string literal.
427 allow_issue_seek: bool,
431 impl<'a> FormatLines<'a> {
434 skipped_range: &'a [(usize, usize)],
436 ) -> FormatLines<'a> {
437 let issue_seeker = BadIssueSeeker::new(config.report_todo(), config.report_fixme());
441 last_was_space: false,
446 allow_issue_seek: !issue_seeker.is_disabled(),
448 line_buffer: String::with_capacity(config.max_width() * 2),
450 format_line: config.file_lines().contains_line(name, 1),
455 fn check_license(&mut self, text: &mut String) {
456 if let Some(ref license_template) = self.config.license_template {
457 if !license_template.is_match(text) {
458 self.errors.push(FormattingError {
460 kind: ErrorKind::LicenseCheck,
463 line_buffer: String::new(),
469 // Iterate over the chars in the file map.
470 fn iterate(&mut self, text: &mut String) {
471 for (kind, c) in CharClasses::new(text.chars()) {
476 if self.allow_issue_seek && self.format_line {
477 // Add warnings for bad todos/ fixmes
478 if let Some(issue) = self.issue_seeker.inspect(c) {
479 self.push_err(ErrorKind::BadIssue(issue), false, false);
491 fn new_line(&mut self, kind: FullCodeCharKind) {
492 if self.format_line {
493 // Check for (and record) trailing whitespace.
494 if self.last_was_space {
495 if self.should_report_error(kind, &ErrorKind::TrailingWhitespace)
496 && !self.is_skipped_line()
499 ErrorKind::TrailingWhitespace,
507 // Check for any line width errors we couldn't correct.
508 let error_kind = ErrorKind::LineOverflow(self.line_len, self.config.max_width());
509 if self.line_len > self.config.max_width()
510 && !self.is_skipped_line()
511 && self.should_report_error(kind, &error_kind)
513 self.push_err(error_kind, kind.is_comment(), self.is_string);
519 self.format_line = self
522 .contains_line(self.name, self.cur_line);
523 self.newline_count += 1;
524 self.last_was_space = false;
525 self.line_buffer.clear();
526 self.is_string = false;
529 fn char(&mut self, c: char, kind: FullCodeCharKind) {
530 self.newline_count = 0;
531 self.line_len += if c == '\t' {
532 self.config.tab_spaces()
536 self.last_was_space = c.is_whitespace();
537 self.line_buffer.push(c);
538 if kind.is_string() {
539 self.is_string = true;
543 fn push_err(&mut self, kind: ErrorKind, is_comment: bool, is_string: bool) {
544 self.errors.push(FormattingError {
549 line_buffer: self.line_buffer.clone(),
553 fn should_report_error(&self, char_kind: FullCodeCharKind, error_kind: &ErrorKind) -> bool {
554 let allow_error_report =
555 if char_kind.is_comment() || self.is_string || error_kind.is_comment() {
556 self.config.error_on_unformatted()
562 ErrorKind::LineOverflow(..) => {
563 self.config.error_on_line_overflow() && allow_error_report
565 ErrorKind::TrailingWhitespace | ErrorKind::LostComment => allow_error_report,
570 /// Returns true if the line with the given line number was skipped by `#[rustfmt::skip]`.
571 fn is_skipped_line(&self) -> bool {
574 .any(|&(lo, hi)| lo <= self.cur_line && self.cur_line <= hi)
580 parse_session: &ParseSess,
582 report: &mut FormatReport,
583 ) -> Result<ast::Crate, ErrorKind> {
584 let input_is_stdin = input.is_text();
586 let mut parser = match input {
587 Input::File(file) => parse::new_parser_from_file(parse_session, &file),
588 Input::Text(text) => parse::new_parser_from_source_str(
590 syntax::codemap::FileName::Custom("stdin".to_owned()),
595 parser.cfg_mods = false;
596 if config.skip_children() {
597 parser.recurse_into_file_modules = false;
600 let mut parser = AssertUnwindSafe(parser);
601 let result = catch_unwind(move || parser.0.parse_crate_mod());
605 if !parse_session.span_diagnostic.has_errors() {
609 Ok(Err(mut e)) => e.emit(),
611 // Note that if you see this message and want more information,
612 // then run the `parse_crate_mod` function above without
613 // `catch_unwind` so rustfmt panics and you can get a backtrace.
614 should_emit_verbose(!input_is_stdin, config, || {
615 println!("The Rust parser panicked")
620 report.add_parsing_error();
621 Err(ErrorKind::ParseError)
624 fn silent_emitter(codemap: Rc<CodeMap>) -> Box<EmitterWriter> {
625 Box::new(EmitterWriter::new(
626 Box::new(Vec::new()),
633 fn make_parse_sess(codemap: Rc<CodeMap>, config: &Config) -> ParseSess {
634 let tty_handler = if config.hide_parse_errors() {
635 let silent_emitter = silent_emitter(codemap.clone());
636 Handler::with_emitter(true, false, silent_emitter)
638 let supports_color = term::stderr().map_or(false, |term| term.supports_color());
639 let color_cfg = if supports_color {
644 Handler::with_tty_emitter(color_cfg, true, false, Some(codemap.clone()))
647 ParseSess::with_span_handler(tty_handler, codemap)
650 fn should_emit_verbose<F>(is_stdin: bool, config: &Config, f: F)
654 if config.verbose() == Verbosity::Verbose && !is_stdin {