1 //! Implementation of a data-race detector using Lamport Timestamps / Vector-clocks
2 //! based on the Dynamic Race Detection for C++:
3 //! <https://www.doc.ic.ac.uk/~afd/homepages/papers/pdfs/2017/POPL.pdf>
4 //! which does not report false-positives when fences are used, and gives better
5 //! accuracy in presence of read-modify-write operations.
7 //! The implementation contains modifications to correctly model the changes to the memory model in C++20
8 //! regarding the weakening of release sequences: <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0982r1.html>.
9 //! Relaxed stores now unconditionally block all currently active release sequences and so per-thread tracking of release
10 //! sequences is not needed.
12 //! The implementation also models races with memory allocation and deallocation via treating allocation and
13 //! deallocation as a type of write internally for detecting data-races.
15 //! Weak memory orders are explored but not all weak behaviours are exhibited, so it can still miss data-races
16 //! but should not report false-positives
18 //! Data-race definition from(<https://en.cppreference.com/w/cpp/language/memory_model#Threads_and_data_races>):
19 //! a data race occurs between two memory accesses if they are on different threads, at least one operation
20 //! is non-atomic, at least one operation is a write and neither access happens-before the other. Read the link
21 //! for full definition.
23 //! This re-uses vector indexes for threads that are known to be unable to report data-races, this is valid
24 //! because it only re-uses vector indexes once all currently-active (not-terminated) threads have an internal
25 //! vector clock that happens-after the join operation of the candidate thread. Threads that have not been joined
26 //! on are not considered. Since the thread's vector clock will only increase and a data-race implies that
27 //! there is some index x where clock\[x\] > thread_clock, when this is true clock\[candidate-idx\] > thread_clock
28 //! can never hold and hence a data-race can never be reported in that vector index again.
29 //! This means that the thread-index can be safely re-used, starting on the next timestamp for the newly created
32 //! The timestamps used in the data-race detector assign each sequence of non-atomic operations
33 //! followed by a single atomic or concurrent operation a single timestamp.
34 //! Write, Read, Write, ThreadJoin will be represented by a single timestamp value on a thread.
35 //! This is because extra increment operations between the operations in the sequence are not
36 //! required for accurate reporting of data-race values.
38 //! As per the paper a threads timestamp is only incremented after a release operation is performed
39 //! so some atomic operations that only perform acquires do not increment the timestamp. Due to shared
40 //! code some atomic operations may increment the timestamp when not necessary but this has no effect
41 //! on the data-race detection code.
44 //! currently we have our own local copy of the currently active thread index and names, this is due
45 //! in part to the inability to access the current location of threads.active_thread inside the AllocExtra
46 //! read, write and deallocate functions and should be cleaned up in the future.
49 cell::{Cell, Ref, RefCell, RefMut},
54 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
55 use rustc_index::vec::{Idx, IndexVec};
56 use rustc_middle::{mir, ty::layout::TyAndLayout};
57 use rustc_target::abi::Size;
61 use super::weak_memory::EvalContextExt as _;
63 pub type AllocExtra = VClockAlloc;
65 /// Valid atomic read-write operations, alias of atomic::Ordering (not non-exhaustive).
66 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
75 /// Valid atomic read operations, subset of atomic::Ordering.
76 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
77 pub enum AtomicReadOp {
83 /// Valid atomic write operations, subset of atomic::Ordering.
84 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
85 pub enum AtomicWriteOp {
91 /// Valid atomic fence operations, subset of atomic::Ordering.
92 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
93 pub enum AtomicFenceOp {
100 /// The current set of vector clocks describing the state
101 /// of a thread, contains the happens-before clock and
102 /// additional metadata to model atomic fence operations.
103 #[derive(Clone, Default, Debug)]
104 pub(super) struct ThreadClockSet {
105 /// The increasing clock representing timestamps
106 /// that happen-before this thread.
107 pub(super) clock: VClock,
109 /// The set of timestamps that will happen-before this
110 /// thread once it performs an acquire fence.
111 fence_acquire: VClock,
113 /// The last timestamp of happens-before relations that
114 /// have been released by this thread by a fence.
115 fence_release: VClock,
117 /// Timestamps of the last SC fence performed by each
118 /// thread, updated when this thread performs an SC fence
119 pub(super) fence_seqcst: VClock,
121 /// Timestamps of the last SC write performed by each
122 /// thread, updated when this thread performs an SC fence
123 pub(super) write_seqcst: VClock,
125 /// Timestamps of the last SC fence performed by each
126 /// thread, updated when this thread performs an SC read
127 pub(super) read_seqcst: VClock,
130 impl ThreadClockSet {
131 /// Apply the effects of a release fence to this
132 /// set of thread vector clocks.
134 fn apply_release_fence(&mut self) {
135 self.fence_release.clone_from(&self.clock);
138 /// Apply the effects of an acquire fence to this
139 /// set of thread vector clocks.
141 fn apply_acquire_fence(&mut self) {
142 self.clock.join(&self.fence_acquire);
145 /// Increment the happens-before clock at a
148 fn increment_clock(&mut self, index: VectorIdx) {
149 self.clock.increment_index(index);
152 /// Join the happens-before clock with that of
153 /// another thread, used to model thread join
155 fn join_with(&mut self, other: &ThreadClockSet) {
156 self.clock.join(&other.clock);
160 /// Error returned by finding a data race
161 /// should be elaborated upon.
162 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Debug)]
165 /// Externally stored memory cell clocks
166 /// explicitly to reduce memory usage for the
167 /// common case where no atomic operations
168 /// exists on the memory cell.
169 #[derive(Clone, PartialEq, Eq, Default, Debug)]
170 struct AtomicMemoryCellClocks {
171 /// The clock-vector of the timestamp of the last atomic
172 /// read operation performed by each thread.
173 /// This detects potential data-races between atomic read
174 /// and non-atomic write operations.
177 /// The clock-vector of the timestamp of the last atomic
178 /// write operation performed by each thread.
179 /// This detects potential data-races between atomic write
180 /// and non-atomic read or write operations.
181 write_vector: VClock,
183 /// Synchronization vector for acquire-release semantics
184 /// contains the vector of timestamps that will
185 /// happen-before a thread if an acquire-load is
186 /// performed on the data.
190 /// Type of write operation: allocating memory
191 /// non-atomic writes and deallocating memory
192 /// are all treated as writes for the purpose
193 /// of the data-race detector.
194 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
199 /// Standard unsynchronized write.
202 /// Deallocate memory.
203 /// Note that when memory is deallocated first, later non-atomic accesses
204 /// will be reported as use-after-free, not as data races.
205 /// (Same for `Allocate` above.)
209 fn get_descriptor(self) -> &'static str {
211 WriteType::Allocate => "Allocate",
212 WriteType::Write => "Write",
213 WriteType::Deallocate => "Deallocate",
218 /// Memory Cell vector clock metadata
219 /// for data-race detection.
220 #[derive(Clone, PartialEq, Eq, Debug)]
221 struct MemoryCellClocks {
222 /// The vector-clock timestamp of the last write
223 /// corresponding to the writing threads timestamp.
226 /// The identifier of the vector index, corresponding to a thread
227 /// that performed the last write operation.
228 write_index: VectorIdx,
230 /// The type of operation that the write index represents,
231 /// either newly allocated memory, a non-atomic write or
232 /// a deallocation of memory.
233 write_type: WriteType,
235 /// The vector-clock of the timestamp of the last read operation
236 /// performed by a thread since the last write operation occurred.
237 /// It is reset to zero on each write operation.
240 /// Atomic acquire & release sequence tracking clocks.
241 /// For non-atomic memory in the common case this
242 /// value is set to None.
243 atomic_ops: Option<Box<AtomicMemoryCellClocks>>,
246 impl MemoryCellClocks {
247 /// Create a new set of clocks representing memory allocated
248 /// at a given vector timestamp and index.
249 fn new(alloc: VTimestamp, alloc_index: VectorIdx) -> Self {
251 read: VClock::default(),
253 write_index: alloc_index,
254 write_type: WriteType::Allocate,
259 /// Load the internal atomic memory cells if they exist.
261 fn atomic(&self) -> Option<&AtomicMemoryCellClocks> {
262 match &self.atomic_ops {
263 Some(op) => Some(&*op),
268 /// Load or create the internal atomic memory metadata
269 /// if it does not exist.
271 fn atomic_mut(&mut self) -> &mut AtomicMemoryCellClocks {
272 self.atomic_ops.get_or_insert_with(Default::default)
275 /// Update memory cell data-race tracking for atomic
276 /// load acquire semantics, is a no-op if this memory was
277 /// not used previously as atomic memory.
280 clocks: &mut ThreadClockSet,
282 ) -> Result<(), DataRace> {
283 self.atomic_read_detect(clocks, index)?;
284 if let Some(atomic) = self.atomic() {
285 clocks.clock.join(&atomic.sync_vector);
290 /// Update memory cell data-race tracking for atomic
291 /// load relaxed semantics, is a no-op if this memory was
292 /// not used previously as atomic memory.
295 clocks: &mut ThreadClockSet,
297 ) -> Result<(), DataRace> {
298 self.atomic_read_detect(clocks, index)?;
299 if let Some(atomic) = self.atomic() {
300 clocks.fence_acquire.join(&atomic.sync_vector);
305 /// Update the memory cell data-race tracking for atomic
306 /// store release semantics.
307 fn store_release(&mut self, clocks: &ThreadClockSet, index: VectorIdx) -> Result<(), DataRace> {
308 self.atomic_write_detect(clocks, index)?;
309 let atomic = self.atomic_mut();
310 atomic.sync_vector.clone_from(&clocks.clock);
314 /// Update the memory cell data-race tracking for atomic
315 /// store relaxed semantics.
316 fn store_relaxed(&mut self, clocks: &ThreadClockSet, index: VectorIdx) -> Result<(), DataRace> {
317 self.atomic_write_detect(clocks, index)?;
319 // The handling of release sequences was changed in C++20 and so
320 // the code here is different to the paper since now all relaxed
321 // stores block release sequences. The exception for same-thread
322 // relaxed stores has been removed.
323 let atomic = self.atomic_mut();
324 atomic.sync_vector.clone_from(&clocks.fence_release);
328 /// Update the memory cell data-race tracking for atomic
329 /// store release semantics for RMW operations.
330 fn rmw_release(&mut self, clocks: &ThreadClockSet, index: VectorIdx) -> Result<(), DataRace> {
331 self.atomic_write_detect(clocks, index)?;
332 let atomic = self.atomic_mut();
333 atomic.sync_vector.join(&clocks.clock);
337 /// Update the memory cell data-race tracking for atomic
338 /// store relaxed semantics for RMW operations.
339 fn rmw_relaxed(&mut self, clocks: &ThreadClockSet, index: VectorIdx) -> Result<(), DataRace> {
340 self.atomic_write_detect(clocks, index)?;
341 let atomic = self.atomic_mut();
342 atomic.sync_vector.join(&clocks.fence_release);
346 /// Detect data-races with an atomic read, caused by a non-atomic write that does
347 /// not happen-before the atomic-read.
348 fn atomic_read_detect(
350 clocks: &ThreadClockSet,
352 ) -> Result<(), DataRace> {
353 log::trace!("Atomic read with vectors: {:#?} :: {:#?}", self, clocks);
354 if self.write <= clocks.clock[self.write_index] {
355 let atomic = self.atomic_mut();
356 atomic.read_vector.set_at_index(&clocks.clock, index);
363 /// Detect data-races with an atomic write, either with a non-atomic read or with
364 /// a non-atomic write.
365 fn atomic_write_detect(
367 clocks: &ThreadClockSet,
369 ) -> Result<(), DataRace> {
370 log::trace!("Atomic write with vectors: {:#?} :: {:#?}", self, clocks);
371 if self.write <= clocks.clock[self.write_index] && self.read <= clocks.clock {
372 let atomic = self.atomic_mut();
373 atomic.write_vector.set_at_index(&clocks.clock, index);
380 /// Detect races for non-atomic read operations at the current memory cell
381 /// returns true if a data-race is detected.
384 clocks: &ThreadClockSet,
386 ) -> Result<(), DataRace> {
387 log::trace!("Unsynchronized read with vectors: {:#?} :: {:#?}", self, clocks);
388 if self.write <= clocks.clock[self.write_index] {
389 let race_free = if let Some(atomic) = self.atomic() {
390 atomic.write_vector <= clocks.clock
395 self.read.set_at_index(&clocks.clock, index);
405 /// Detect races for non-atomic write operations at the current memory cell
406 /// returns true if a data-race is detected.
407 fn write_race_detect(
409 clocks: &ThreadClockSet,
411 write_type: WriteType,
412 ) -> Result<(), DataRace> {
413 log::trace!("Unsynchronized write with vectors: {:#?} :: {:#?}", self, clocks);
414 if self.write <= clocks.clock[self.write_index] && self.read <= clocks.clock {
415 let race_free = if let Some(atomic) = self.atomic() {
416 atomic.write_vector <= clocks.clock && atomic.read_vector <= clocks.clock
421 self.write = clocks.clock[index];
422 self.write_index = index;
423 self.write_type = write_type;
424 self.read.set_zero_vector();
435 /// Evaluation context extensions.
436 impl<'mir, 'tcx: 'mir> EvalContextExt<'mir, 'tcx> for MiriEvalContext<'mir, 'tcx> {}
437 pub trait EvalContextExt<'mir, 'tcx: 'mir>: MiriEvalContextExt<'mir, 'tcx> {
438 /// Temporarily allow data-races to occur. This should only be used in
439 /// one of these cases:
440 /// - One of the appropriate `validate_atomic` functions will be called to
441 /// to treat a memory access as atomic.
442 /// - The memory being accessed should be treated as internal state, that
443 /// cannot be accessed by the interpreted program.
444 /// - Execution of the interpreted program execution has halted.
446 fn allow_data_races_ref<R>(&self, op: impl FnOnce(&MiriEvalContext<'mir, 'tcx>) -> R) -> R {
447 let this = self.eval_context_ref();
448 if let Some(data_race) = &this.machine.data_race {
449 data_race.ongoing_atomic_access.set(true);
451 let result = op(this);
452 if let Some(data_race) = &this.machine.data_race {
453 data_race.ongoing_atomic_access.set(false);
458 /// Same as `allow_data_races_ref`, this temporarily disables any data-race detection and
459 /// so should only be used for atomic operations or internal state that the program cannot
462 fn allow_data_races_mut<R>(
464 op: impl FnOnce(&mut MiriEvalContext<'mir, 'tcx>) -> R,
466 let this = self.eval_context_mut();
467 if let Some(data_race) = &this.machine.data_race {
468 data_race.ongoing_atomic_access.set(true);
470 let result = op(this);
471 if let Some(data_race) = &this.machine.data_race {
472 data_race.ongoing_atomic_access.set(false);
477 /// Atomic variant of read_scalar_at_offset.
478 fn read_scalar_at_offset_atomic(
480 op: &OpTy<'tcx, Tag>,
482 layout: TyAndLayout<'tcx>,
483 atomic: AtomicReadOp,
484 ) -> InterpResult<'tcx, ScalarMaybeUninit<Tag>> {
485 let this = self.eval_context_ref();
486 let value_place = this.deref_operand_and_offset(op, offset, layout)?;
487 this.read_scalar_atomic(&value_place, atomic)
490 /// Atomic variant of write_scalar_at_offset.
491 fn write_scalar_at_offset_atomic(
493 op: &OpTy<'tcx, Tag>,
495 value: impl Into<ScalarMaybeUninit<Tag>>,
496 layout: TyAndLayout<'tcx>,
497 atomic: AtomicWriteOp,
498 ) -> InterpResult<'tcx> {
499 let this = self.eval_context_mut();
500 let value_place = this.deref_operand_and_offset(op, offset, layout)?;
501 this.write_scalar_atomic(value.into(), &value_place, atomic)
504 /// Perform an atomic read operation at the memory location.
505 fn read_scalar_atomic(
507 place: &MPlaceTy<'tcx, Tag>,
508 atomic: AtomicReadOp,
509 ) -> InterpResult<'tcx, ScalarMaybeUninit<Tag>> {
510 let this = self.eval_context_ref();
511 // This will read from the last store in the modification order of this location. In case
512 // weak memory emulation is enabled, this may not be the store we will pick to actually read from and return.
513 // This is fine with StackedBorrow and race checks because they don't concern metadata on
514 // the *value* (including the associated provenance if this is an AtomicPtr) at this location.
515 // Only metadata on the location itself is used.
516 let scalar = this.allow_data_races_ref(move |this| this.read_scalar(&place.into()))?;
517 this.buffered_atomic_read(place, atomic, scalar, || {
518 this.validate_atomic_load(place, atomic)
522 /// Perform an atomic write operation at the memory location.
523 fn write_scalar_atomic(
525 val: ScalarMaybeUninit<Tag>,
526 dest: &MPlaceTy<'tcx, Tag>,
527 atomic: AtomicWriteOp,
528 ) -> InterpResult<'tcx> {
529 let this = self.eval_context_mut();
530 this.allow_data_races_mut(move |this| this.write_scalar(val, &(*dest).into()))?;
531 this.validate_atomic_store(dest, atomic)?;
532 // FIXME: it's not possible to get the value before write_scalar. A read_scalar will cause
533 // side effects from a read the program did not perform. So we have to initialise
534 // the store buffer with the value currently being written
535 // ONCE this is fixed please remove the hack in buffered_atomic_write() in weak_memory.rs
536 this.buffered_atomic_write(val, dest, atomic, val)
539 /// Perform an atomic operation on a memory location.
540 fn atomic_op_immediate(
542 place: &MPlaceTy<'tcx, Tag>,
543 rhs: &ImmTy<'tcx, Tag>,
547 ) -> InterpResult<'tcx, ImmTy<'tcx, Tag>> {
548 let this = self.eval_context_mut();
550 let old = this.allow_data_races_mut(|this| this.read_immediate(&place.into()))?;
552 // Atomics wrap around on overflow.
553 let val = this.binary_op(op, &old, rhs)?;
554 let val = if neg { this.unary_op(mir::UnOp::Not, &val)? } else { val };
555 this.allow_data_races_mut(|this| this.write_immediate(*val, &(*place).into()))?;
557 this.validate_atomic_rmw(place, atomic)?;
559 this.buffered_atomic_rmw(
560 val.to_scalar_or_uninit(),
563 old.to_scalar_or_uninit(),
568 /// Perform an atomic exchange with a memory place and a new
569 /// scalar value, the old value is returned.
570 fn atomic_exchange_scalar(
572 place: &MPlaceTy<'tcx, Tag>,
573 new: ScalarMaybeUninit<Tag>,
575 ) -> InterpResult<'tcx, ScalarMaybeUninit<Tag>> {
576 let this = self.eval_context_mut();
578 let old = this.allow_data_races_mut(|this| this.read_scalar(&place.into()))?;
579 this.allow_data_races_mut(|this| this.write_scalar(new, &(*place).into()))?;
581 this.validate_atomic_rmw(place, atomic)?;
583 this.buffered_atomic_rmw(new, place, atomic, old)?;
587 /// Perform an conditional atomic exchange with a memory place and a new
588 /// scalar value, the old value is returned.
589 fn atomic_min_max_scalar(
591 place: &MPlaceTy<'tcx, Tag>,
592 rhs: ImmTy<'tcx, Tag>,
595 ) -> InterpResult<'tcx, ImmTy<'tcx, Tag>> {
596 let this = self.eval_context_mut();
598 let old = this.allow_data_races_mut(|this| this.read_immediate(&place.into()))?;
599 let lt = this.binary_op(mir::BinOp::Lt, &old, &rhs)?.to_scalar()?.to_bool()?;
601 let new_val = if min {
602 if lt { &old } else { &rhs }
604 if lt { &rhs } else { &old }
607 this.allow_data_races_mut(|this| this.write_immediate(**new_val, &(*place).into()))?;
609 this.validate_atomic_rmw(place, atomic)?;
611 this.buffered_atomic_rmw(
612 new_val.to_scalar_or_uninit(),
615 old.to_scalar_or_uninit(),
618 // Return the old value.
622 /// Perform an atomic compare and exchange at a given memory location.
623 /// On success an atomic RMW operation is performed and on failure
624 /// only an atomic read occurs. If `can_fail_spuriously` is true,
625 /// then we treat it as a "compare_exchange_weak" operation, and
626 /// some portion of the time fail even when the values are actually
628 fn atomic_compare_exchange_scalar(
630 place: &MPlaceTy<'tcx, Tag>,
631 expect_old: &ImmTy<'tcx, Tag>,
632 new: ScalarMaybeUninit<Tag>,
635 can_fail_spuriously: bool,
636 ) -> InterpResult<'tcx, Immediate<Tag>> {
638 let this = self.eval_context_mut();
640 // Failure ordering cannot be stronger than success ordering, therefore first attempt
641 // to read with the failure ordering and if successful then try again with the success
642 // read ordering and write in the success case.
643 // Read as immediate for the sake of `binary_op()`
644 let old = this.allow_data_races_mut(|this| this.read_immediate(&(place.into())))?;
645 // `binary_op` will bail if either of them is not a scalar.
646 let eq = this.binary_op(mir::BinOp::Eq, &old, expect_old)?;
647 // If the operation would succeed, but is "weak", fail some portion
648 // of the time, based on `success_rate`.
649 let success_rate = 1.0 - this.machine.cmpxchg_weak_failure_rate;
650 let cmpxchg_success = eq.to_scalar()?.to_bool()?
651 && if can_fail_spuriously {
652 this.machine.rng.get_mut().gen_bool(success_rate)
656 let res = Immediate::ScalarPair(
657 old.to_scalar_or_uninit(),
658 Scalar::from_bool(cmpxchg_success).into(),
661 // Update ptr depending on comparison.
662 // if successful, perform a full rw-atomic validation
663 // otherwise treat this as an atomic load with the fail ordering.
665 this.allow_data_races_mut(|this| this.write_scalar(new, &(*place).into()))?;
666 this.validate_atomic_rmw(place, success)?;
667 this.buffered_atomic_rmw(new, place, success, old.to_scalar_or_uninit())?;
669 this.validate_atomic_load(place, fail)?;
670 // A failed compare exchange is equivalent to a load, reading from the latest store
671 // in the modification order.
672 // Since `old` is only a value and not the store element, we need to separately
673 // find it in our store buffer and perform load_impl on it.
674 this.perform_read_on_buffered_latest(place, fail, old.to_scalar_or_uninit())?;
677 // Return the old value.
681 /// Update the data-race detector for an atomic read occurring at the
682 /// associated memory-place and on the current thread.
683 fn validate_atomic_load(
685 place: &MPlaceTy<'tcx, Tag>,
686 atomic: AtomicReadOp,
687 ) -> InterpResult<'tcx> {
688 let this = self.eval_context_ref();
689 this.validate_atomic_op(
693 move |memory, clocks, index, atomic| {
694 if atomic == AtomicReadOp::Relaxed {
695 memory.load_relaxed(&mut *clocks, index)
697 memory.load_acquire(&mut *clocks, index)
703 /// Update the data-race detector for an atomic write occurring at the
704 /// associated memory-place and on the current thread.
705 fn validate_atomic_store(
707 place: &MPlaceTy<'tcx, Tag>,
708 atomic: AtomicWriteOp,
709 ) -> InterpResult<'tcx> {
710 let this = self.eval_context_mut();
711 this.validate_atomic_op(
715 move |memory, clocks, index, atomic| {
716 if atomic == AtomicWriteOp::Relaxed {
717 memory.store_relaxed(clocks, index)
719 memory.store_release(clocks, index)
725 /// Update the data-race detector for an atomic read-modify-write occurring
726 /// at the associated memory place and on the current thread.
727 fn validate_atomic_rmw(
729 place: &MPlaceTy<'tcx, Tag>,
731 ) -> InterpResult<'tcx> {
733 let acquire = matches!(atomic, Acquire | AcqRel | SeqCst);
734 let release = matches!(atomic, Release | AcqRel | SeqCst);
735 let this = self.eval_context_mut();
736 this.validate_atomic_op(place, atomic, "Atomic RMW", move |memory, clocks, index, _| {
738 memory.load_acquire(clocks, index)?;
740 memory.load_relaxed(clocks, index)?;
743 memory.rmw_release(clocks, index)
745 memory.rmw_relaxed(clocks, index)
750 /// Update the data-race detector for an atomic fence on the current thread.
751 fn validate_atomic_fence(&mut self, atomic: AtomicFenceOp) -> InterpResult<'tcx> {
752 let this = self.eval_context_mut();
753 if let Some(data_race) = &mut this.machine.data_race {
754 data_race.maybe_perform_sync_operation(|index, mut clocks| {
755 log::trace!("Atomic fence on {:?} with ordering {:?}", index, atomic);
757 // Apply data-race detection for the current fences
758 // this treats AcqRel and SeqCst as the same as an acquire
759 // and release fence applied in the same timestamp.
760 if atomic != AtomicFenceOp::Release {
761 // Either Acquire | AcqRel | SeqCst
762 clocks.apply_acquire_fence();
764 if atomic != AtomicFenceOp::Acquire {
765 // Either Release | AcqRel | SeqCst
766 clocks.apply_release_fence();
768 if atomic == AtomicFenceOp::SeqCst {
769 data_race.last_sc_fence.borrow_mut().set_at_index(&clocks.clock, index);
770 clocks.fence_seqcst.join(&data_race.last_sc_fence.borrow());
771 clocks.write_seqcst.join(&data_race.last_sc_write.borrow());
774 // Increment timestamp in case of release semantics.
775 Ok(atomic != AtomicFenceOp::Acquire)
783 /// Vector clock metadata for a logical memory allocation.
784 #[derive(Debug, Clone)]
785 pub struct VClockAlloc {
786 /// Assigning each byte a MemoryCellClocks.
787 alloc_ranges: RefCell<RangeMap<MemoryCellClocks>>,
791 /// Create a new data-race detector for newly allocated memory.
792 pub fn new_allocation(
793 global: &GlobalState,
795 kind: MemoryKind<MiriMemoryKind>,
797 let (alloc_timestamp, alloc_index) = match kind {
798 // User allocated and stack memory should track allocation.
800 MiriMemoryKind::Rust | MiriMemoryKind::C | MiriMemoryKind::WinHeap,
802 | MemoryKind::Stack => {
803 let (alloc_index, clocks) = global.current_thread_state();
804 let alloc_timestamp = clocks.clock[alloc_index];
805 (alloc_timestamp, alloc_index)
807 // Other global memory should trace races but be allocated at the 0 timestamp.
809 MiriMemoryKind::Global
810 | MiriMemoryKind::Machine
811 | MiriMemoryKind::Runtime
812 | MiriMemoryKind::ExternStatic
813 | MiriMemoryKind::Tls,
815 | MemoryKind::CallerLocation => (0, VectorIdx::MAX_INDEX),
818 alloc_ranges: RefCell::new(RangeMap::new(
820 MemoryCellClocks::new(alloc_timestamp, alloc_index),
825 // Find an index, if one exists where the value
826 // in `l` is greater than the value in `r`.
827 fn find_gt_index(l: &VClock, r: &VClock) -> Option<VectorIdx> {
828 log::trace!("Find index where not {:?} <= {:?}", l, r);
829 let l_slice = l.as_slice();
830 let r_slice = r.as_slice();
835 .find_map(|(idx, (&l, &r))| if l > r { Some(idx) } else { None })
837 if l_slice.len() > r_slice.len() {
838 // By invariant, if l_slice is longer
839 // then one element must be larger.
840 // This just validates that this is true
841 // and reports earlier elements first.
842 let l_remainder_slice = &l_slice[r_slice.len()..];
843 let idx = l_remainder_slice
846 .find_map(|(idx, &r)| if r == 0 { None } else { Some(idx) })
847 .expect("Invalid VClock Invariant");
848 Some(idx + r_slice.len())
856 /// Report a data-race found in the program.
857 /// This finds the two racing threads and the type
858 /// of data-race that occurred. This will also
859 /// return info about the memory location the data-race
863 fn report_data_race<'tcx>(
864 global: &GlobalState,
865 range: &MemoryCellClocks,
868 ptr_dbg: Pointer<AllocId>,
869 ) -> InterpResult<'tcx> {
870 let (current_index, current_clocks) = global.current_thread_state();
872 let (other_action, other_thread, other_clock) = if range.write
873 > current_clocks.clock[range.write_index]
875 // Convert the write action into the vector clock it
876 // represents for diagnostic purposes.
877 write_clock = VClock::new_with_index(range.write_index, range.write);
878 (range.write_type.get_descriptor(), range.write_index, &write_clock)
879 } else if let Some(idx) = Self::find_gt_index(&range.read, ¤t_clocks.clock) {
880 ("Read", idx, &range.read)
881 } else if !is_atomic {
882 if let Some(atomic) = range.atomic() {
883 if let Some(idx) = Self::find_gt_index(&atomic.write_vector, ¤t_clocks.clock)
885 ("Atomic Store", idx, &atomic.write_vector)
886 } else if let Some(idx) =
887 Self::find_gt_index(&atomic.read_vector, ¤t_clocks.clock)
889 ("Atomic Load", idx, &atomic.read_vector)
892 "Failed to report data-race for non-atomic operation: no race found"
897 "Failed to report data-race for non-atomic operation: no atomic component"
901 unreachable!("Failed to report data-race for atomic operation")
904 // Load elaborated thread information about the racing thread actions.
905 let current_thread_info = global.print_thread_metadata(current_index);
906 let other_thread_info = global.print_thread_metadata(other_thread);
908 // Throw the data-race detection.
910 "Data race detected between {} on {} and {} on {} at {:?} (current vector clock = {:?}, conflicting timestamp = {:?})",
916 current_clocks.clock,
921 /// Detect data-races for an unsynchronized read operation, will not perform
922 /// data-race detection if `race_detecting()` is false, either due to no threads
923 /// being created or if it is temporarily disabled during a racy read or write
924 /// operation for which data-race detection is handled separately, for example
925 /// atomic read operations.
930 global: &GlobalState,
931 ) -> InterpResult<'tcx> {
932 if global.race_detecting() {
933 let (index, clocks) = global.current_thread_state();
934 let mut alloc_ranges = self.alloc_ranges.borrow_mut();
935 for (offset, range) in alloc_ranges.iter_mut(range.start, range.size) {
936 if let Err(DataRace) = range.read_race_detect(&*clocks, index) {
938 return Self::report_data_race(
943 Pointer::new(alloc_id, offset),
953 // Shared code for detecting data-races on unique access to a section of memory
954 fn unique_access<'tcx>(
958 write_type: WriteType,
959 global: &mut GlobalState,
960 ) -> InterpResult<'tcx> {
961 if global.race_detecting() {
962 let (index, clocks) = global.current_thread_state();
963 for (offset, range) in self.alloc_ranges.get_mut().iter_mut(range.start, range.size) {
964 if let Err(DataRace) = range.write_race_detect(&*clocks, index, write_type) {
966 return Self::report_data_race(
969 write_type.get_descriptor(),
971 Pointer::new(alloc_id, offset),
981 /// Detect data-races for an unsynchronized write operation, will not perform
982 /// data-race threads if `race_detecting()` is false, either due to no threads
983 /// being created or if it is temporarily disabled during a racy read or write
989 global: &mut GlobalState,
990 ) -> InterpResult<'tcx> {
991 self.unique_access(alloc_id, range, WriteType::Write, global)
994 /// Detect data-races for an unsynchronized deallocate operation, will not perform
995 /// data-race threads if `race_detecting()` is false, either due to no threads
996 /// being created or if it is temporarily disabled during a racy read or write
998 pub fn deallocate<'tcx>(
1002 global: &mut GlobalState,
1003 ) -> InterpResult<'tcx> {
1004 self.unique_access(alloc_id, range, WriteType::Deallocate, global)
1008 impl<'mir, 'tcx: 'mir> EvalContextPrivExt<'mir, 'tcx> for MiriEvalContext<'mir, 'tcx> {}
1009 trait EvalContextPrivExt<'mir, 'tcx: 'mir>: MiriEvalContextExt<'mir, 'tcx> {
1010 /// Generic atomic operation implementation
1011 fn validate_atomic_op<A: Debug + Copy>(
1013 place: &MPlaceTy<'tcx, Tag>,
1017 &mut MemoryCellClocks,
1018 &mut ThreadClockSet,
1021 ) -> Result<(), DataRace>,
1022 ) -> InterpResult<'tcx> {
1023 let this = self.eval_context_ref();
1024 if let Some(data_race) = &this.machine.data_race {
1025 if data_race.race_detecting() {
1026 let size = place.layout.size;
1027 let (alloc_id, base_offset, _tag) = this.ptr_get_alloc_id(place.ptr)?;
1028 // Load and log the atomic operation.
1029 // Note that atomic loads are possible even from read-only allocations, so `get_alloc_extra_mut` is not an option.
1030 let alloc_meta = &this.get_alloc_extra(alloc_id)?.data_race.as_ref().unwrap();
1032 "Atomic op({}) with ordering {:?} on {:?} (size={})",
1039 // Perform the atomic operation.
1040 data_race.maybe_perform_sync_operation(|index, mut clocks| {
1041 for (offset, range) in
1042 alloc_meta.alloc_ranges.borrow_mut().iter_mut(base_offset, size)
1044 if let Err(DataRace) = op(range, &mut *clocks, index, atomic) {
1046 return VClockAlloc::report_data_race(
1051 Pointer::new(alloc_id, offset),
1057 // This conservatively assumes all operations have release semantics
1061 // Log changes to atomic memory.
1062 if log::log_enabled!(log::Level::Trace) {
1063 for (_offset, range) in alloc_meta.alloc_ranges.borrow().iter(base_offset, size)
1066 "Updated atomic memory({:?}, size={}) to {:#?}",
1079 /// Extra metadata associated with a thread.
1080 #[derive(Debug, Clone, Default)]
1081 struct ThreadExtraState {
1082 /// The current vector index in use by the
1083 /// thread currently, this is set to None
1084 /// after the vector index has been re-used
1085 /// and hence the value will never need to be
1086 /// read during data-race reporting.
1087 vector_index: Option<VectorIdx>,
1089 /// The name of the thread, updated for better
1090 /// diagnostics when reporting detected data
1092 thread_name: Option<Box<str>>,
1094 /// Thread termination vector clock, this
1095 /// is set on thread termination and is used
1096 /// for joining on threads since the vector_index
1097 /// may be re-used when the join operation occurs.
1098 termination_vector_clock: Option<VClock>,
1101 /// Global data-race detection state, contains the currently
1102 /// executing thread as well as the vector-clocks associated
1103 /// with each of the threads.
1104 // FIXME: it is probably better to have one large RefCell, than to have so many small ones.
1105 #[derive(Debug, Clone)]
1106 pub struct GlobalState {
1107 /// Set to true once the first additional
1108 /// thread has launched, due to the dependency
1109 /// between before and after a thread launch.
1110 /// Any data-races must be recorded after this
1111 /// so concurrent execution can ignore recording
1113 multi_threaded: Cell<bool>,
1115 /// A flag to mark we are currently performing
1116 /// an atomic access to supress data race detection
1117 ongoing_atomic_access: Cell<bool>,
1119 /// Mapping of a vector index to a known set of thread
1120 /// clocks, this is not directly mapping from a thread id
1121 /// since it may refer to multiple threads.
1122 vector_clocks: RefCell<IndexVec<VectorIdx, ThreadClockSet>>,
1124 /// Mapping of a given vector index to the current thread
1125 /// that the execution is representing, this may change
1126 /// if a vector index is re-assigned to a new thread.
1127 vector_info: RefCell<IndexVec<VectorIdx, ThreadId>>,
1129 /// The mapping of a given thread to associated thread metadata.
1130 thread_info: RefCell<IndexVec<ThreadId, ThreadExtraState>>,
1132 /// The current vector index being executed.
1133 current_index: Cell<VectorIdx>,
1135 /// Potential vector indices that could be re-used on thread creation
1136 /// values are inserted here on after the thread has terminated and
1137 /// been joined with, and hence may potentially become free
1138 /// for use as the index for a new thread.
1139 /// Elements in this set may still require the vector index to
1140 /// report data-races, and can only be re-used after all
1141 /// active vector-clocks catch up with the threads timestamp.
1142 reuse_candidates: RefCell<FxHashSet<VectorIdx>>,
1144 /// Counts the number of threads that are currently active
1145 /// if the number of active threads reduces to 1 and then
1146 /// a join operation occurs with the remaining main thread
1147 /// then multi-threaded execution may be disabled.
1148 active_thread_count: Cell<usize>,
1150 /// This contains threads that have terminated, but not yet joined
1151 /// and so cannot become re-use candidates until a join operation
1153 /// The associated vector index will be moved into re-use candidates
1154 /// after the join operation occurs.
1155 terminated_threads: RefCell<FxHashMap<ThreadId, VectorIdx>>,
1157 /// The timestamp of last SC fence performed by each thread
1158 last_sc_fence: RefCell<VClock>,
1160 /// The timestamp of last SC write performed by each thread
1161 last_sc_write: RefCell<VClock>,
1165 /// Create a new global state, setup with just thread-id=0
1166 /// advanced to timestamp = 1.
1167 pub fn new() -> Self {
1168 let mut global_state = GlobalState {
1169 multi_threaded: Cell::new(false),
1170 ongoing_atomic_access: Cell::new(false),
1171 vector_clocks: RefCell::new(IndexVec::new()),
1172 vector_info: RefCell::new(IndexVec::new()),
1173 thread_info: RefCell::new(IndexVec::new()),
1174 current_index: Cell::new(VectorIdx::new(0)),
1175 active_thread_count: Cell::new(1),
1176 reuse_candidates: RefCell::new(FxHashSet::default()),
1177 terminated_threads: RefCell::new(FxHashMap::default()),
1178 last_sc_fence: RefCell::new(VClock::default()),
1179 last_sc_write: RefCell::new(VClock::default()),
1182 // Setup the main-thread since it is not explicitly created:
1183 // uses vector index and thread-id 0, also the rust runtime gives
1184 // the main-thread a name of "main".
1185 let index = global_state.vector_clocks.get_mut().push(ThreadClockSet::default());
1186 global_state.vector_info.get_mut().push(ThreadId::new(0));
1187 global_state.thread_info.get_mut().push(ThreadExtraState {
1188 vector_index: Some(index),
1189 thread_name: Some("main".to_string().into_boxed_str()),
1190 termination_vector_clock: None,
1196 // We perform data race detection when there are more than 1 active thread
1197 // and we are not currently in the middle of an atomic acces where data race
1199 fn race_detecting(&self) -> bool {
1200 self.multi_threaded.get() && !self.ongoing_atomic_access.get()
1203 pub fn ongoing_atomic_access(&self) -> bool {
1204 self.ongoing_atomic_access.get()
1207 // Try to find vector index values that can potentially be re-used
1208 // by a new thread instead of a new vector index being created.
1209 fn find_vector_index_reuse_candidate(&self) -> Option<VectorIdx> {
1210 let mut reuse = self.reuse_candidates.borrow_mut();
1211 let vector_clocks = self.vector_clocks.borrow();
1212 let vector_info = self.vector_info.borrow();
1213 let terminated_threads = self.terminated_threads.borrow();
1214 for &candidate in reuse.iter() {
1215 let target_timestamp = vector_clocks[candidate].clock[candidate];
1216 if vector_clocks.iter_enumerated().all(|(clock_idx, clock)| {
1217 // The thread happens before the clock, and hence cannot report
1218 // a data-race with this the candidate index.
1219 let no_data_race = clock.clock[candidate] >= target_timestamp;
1221 // The vector represents a thread that has terminated and hence cannot
1222 // report a data-race with the candidate index.
1223 let thread_id = vector_info[clock_idx];
1224 let vector_terminated =
1225 reuse.contains(&clock_idx) || terminated_threads.contains_key(&thread_id);
1227 // The vector index cannot report a race with the candidate index
1228 // and hence allows the candidate index to be re-used.
1229 no_data_race || vector_terminated
1231 // All vector clocks for each vector index are equal to
1232 // the target timestamp, and the thread is known to have
1233 // terminated, therefore this vector clock index cannot
1234 // report any more data-races.
1235 assert!(reuse.remove(&candidate));
1236 return Some(candidate);
1242 // Hook for thread creation, enabled multi-threaded execution and marks
1243 // the current thread timestamp as happening-before the current thread.
1245 pub fn thread_created(&mut self, thread: ThreadId) {
1246 let current_index = self.current_index();
1248 // Increment the number of active threads.
1249 let active_threads = self.active_thread_count.get();
1250 self.active_thread_count.set(active_threads + 1);
1252 // Enable multi-threaded execution, there are now two threads
1253 // so data-races are now possible.
1254 self.multi_threaded.set(true);
1256 // Load and setup the associated thread metadata
1257 let mut thread_info = self.thread_info.borrow_mut();
1258 thread_info.ensure_contains_elem(thread, Default::default);
1260 // Assign a vector index for the thread, attempting to re-use an old
1261 // vector index that can no longer report any data-races if possible.
1262 let created_index = if let Some(reuse_index) = self.find_vector_index_reuse_candidate() {
1263 // Now re-configure the re-use candidate, increment the clock
1264 // for the new sync use of the vector.
1265 let vector_clocks = self.vector_clocks.get_mut();
1266 vector_clocks[reuse_index].increment_clock(reuse_index);
1268 // Locate the old thread the vector was associated with and update
1269 // it to represent the new thread instead.
1270 let vector_info = self.vector_info.get_mut();
1271 let old_thread = vector_info[reuse_index];
1272 vector_info[reuse_index] = thread;
1274 // Mark the thread the vector index was associated with as no longer
1275 // representing a thread index.
1276 thread_info[old_thread].vector_index = None;
1280 // No vector re-use candidates available, instead create
1281 // a new vector index.
1282 let vector_info = self.vector_info.get_mut();
1283 vector_info.push(thread)
1286 log::trace!("Creating thread = {:?} with vector index = {:?}", thread, created_index);
1288 // Mark the chosen vector index as in use by the thread.
1289 thread_info[thread].vector_index = Some(created_index);
1291 // Create a thread clock set if applicable.
1292 let vector_clocks = self.vector_clocks.get_mut();
1293 if created_index == vector_clocks.next_index() {
1294 vector_clocks.push(ThreadClockSet::default());
1297 // Now load the two clocks and configure the initial state.
1298 let (current, created) = vector_clocks.pick2_mut(current_index, created_index);
1300 // Join the created with current, since the current threads
1301 // previous actions happen-before the created thread.
1302 created.join_with(current);
1304 // Advance both threads after the synchronized operation.
1305 // Both operations are considered to have release semantics.
1306 current.increment_clock(current_index);
1307 created.increment_clock(created_index);
1310 /// Hook on a thread join to update the implicit happens-before relation
1311 /// between the joined thread and the current thread.
1313 pub fn thread_joined(&mut self, current_thread: ThreadId, join_thread: ThreadId) {
1314 let clocks_vec = self.vector_clocks.get_mut();
1315 let thread_info = self.thread_info.get_mut();
1317 // Load the vector clock of the current thread.
1318 let current_index = thread_info[current_thread]
1320 .expect("Performed thread join on thread with no assigned vector");
1321 let current = &mut clocks_vec[current_index];
1323 // Load the associated vector clock for the terminated thread.
1324 let join_clock = thread_info[join_thread]
1325 .termination_vector_clock
1327 .expect("Joined with thread but thread has not terminated");
1329 // The join thread happens-before the current thread
1330 // so update the current vector clock.
1331 // Is not a release operation so the clock is not incremented.
1332 current.clock.join(join_clock);
1334 // Check the number of active threads, if the value is 1
1335 // then test for potentially disabling multi-threaded execution.
1336 let active_threads = self.active_thread_count.get();
1337 if active_threads == 1 {
1338 // May potentially be able to disable multi-threaded execution.
1339 let current_clock = &clocks_vec[current_index];
1342 .all(|(idx, clocks)| clocks.clock[idx] <= current_clock.clock[idx])
1344 // All thread terminations happen-before the current clock
1345 // therefore no data-races can be reported until a new thread
1346 // is created, so disable multi-threaded execution.
1347 self.multi_threaded.set(false);
1351 // If the thread is marked as terminated but not joined
1352 // then move the thread to the re-use set.
1353 let termination = self.terminated_threads.get_mut();
1354 if let Some(index) = termination.remove(&join_thread) {
1355 let reuse = self.reuse_candidates.get_mut();
1356 reuse.insert(index);
1360 /// On thread termination, the vector-clock may re-used
1361 /// in the future once all remaining thread-clocks catch
1362 /// up with the time index of the terminated thread.
1363 /// This assigns thread termination with a unique index
1364 /// which will be used to join the thread
1365 /// This should be called strictly before any calls to
1366 /// `thread_joined`.
1368 pub fn thread_terminated(&mut self) {
1369 let current_index = self.current_index();
1371 // Increment the clock to a unique termination timestamp.
1372 let vector_clocks = self.vector_clocks.get_mut();
1373 let current_clocks = &mut vector_clocks[current_index];
1374 current_clocks.increment_clock(current_index);
1376 // Load the current thread id for the executing vector.
1377 let vector_info = self.vector_info.get_mut();
1378 let current_thread = vector_info[current_index];
1380 // Load the current thread metadata, and move to a terminated
1381 // vector state. Setting up the vector clock all join operations
1383 let thread_info = self.thread_info.get_mut();
1384 let current = &mut thread_info[current_thread];
1385 current.termination_vector_clock = Some(current_clocks.clock.clone());
1387 // Add this thread as a candidate for re-use after a thread join
1389 let termination = self.terminated_threads.get_mut();
1390 termination.insert(current_thread, current_index);
1392 // Reduce the number of active threads, now that a thread has
1394 let mut active_threads = self.active_thread_count.get();
1395 active_threads -= 1;
1396 self.active_thread_count.set(active_threads);
1399 /// Hook for updating the local tracker of the currently
1400 /// enabled thread, should always be updated whenever
1401 /// `active_thread` in thread.rs is updated.
1403 pub fn thread_set_active(&self, thread: ThreadId) {
1404 let thread_info = self.thread_info.borrow();
1405 let vector_idx = thread_info[thread]
1407 .expect("Setting thread active with no assigned vector");
1408 self.current_index.set(vector_idx);
1411 /// Hook for updating the local tracker of the threads name
1412 /// this should always mirror the local value in thread.rs
1413 /// the thread name is used for improved diagnostics
1414 /// during a data-race.
1416 pub fn thread_set_name(&mut self, thread: ThreadId, name: String) {
1417 let name = name.into_boxed_str();
1418 let thread_info = self.thread_info.get_mut();
1419 thread_info[thread].thread_name = Some(name);
1422 /// Attempt to perform a synchronized operation, this
1423 /// will perform no operation if multi-threading is
1424 /// not currently enabled.
1425 /// Otherwise it will increment the clock for the current
1426 /// vector before and after the operation for data-race
1427 /// detection between any happens-before edges the
1428 /// operation may create.
1429 fn maybe_perform_sync_operation<'tcx>(
1431 op: impl FnOnce(VectorIdx, RefMut<'_, ThreadClockSet>) -> InterpResult<'tcx, bool>,
1432 ) -> InterpResult<'tcx> {
1433 if self.multi_threaded.get() {
1434 let (index, clocks) = self.current_thread_state_mut();
1435 if op(index, clocks)? {
1436 let (_, mut clocks) = self.current_thread_state_mut();
1437 clocks.increment_clock(index);
1443 /// Internal utility to identify a thread stored internally
1444 /// returns the id and the name for better diagnostics.
1445 fn print_thread_metadata(&self, vector: VectorIdx) -> String {
1446 let thread = self.vector_info.borrow()[vector];
1447 let thread_name = &self.thread_info.borrow()[thread].thread_name;
1448 if let Some(name) = thread_name {
1449 let name: &str = name;
1450 format!("Thread(id = {:?}, name = {:?})", thread.to_u32(), &*name)
1452 format!("Thread(id = {:?})", thread.to_u32())
1456 /// Acquire a lock, express that the previous call of
1457 /// `validate_lock_release` must happen before this.
1458 /// As this is an acquire operation, the thread timestamp is not
1460 pub fn validate_lock_acquire(&self, lock: &VClock, thread: ThreadId) {
1461 let (_, mut clocks) = self.load_thread_state_mut(thread);
1462 clocks.clock.join(lock);
1465 /// Release a lock handle, express that this happens-before
1466 /// any subsequent calls to `validate_lock_acquire`.
1467 /// For normal locks this should be equivalent to `validate_lock_release_shared`
1468 /// since an acquire operation should have occurred before, however
1469 /// for futex & condvar operations this is not the case and this
1470 /// operation must be used.
1471 pub fn validate_lock_release(&self, lock: &mut VClock, thread: ThreadId) {
1472 let (index, mut clocks) = self.load_thread_state_mut(thread);
1473 lock.clone_from(&clocks.clock);
1474 clocks.increment_clock(index);
1477 /// Release a lock handle, express that this happens-before
1478 /// any subsequent calls to `validate_lock_acquire` as well
1479 /// as any previous calls to this function after any
1480 /// `validate_lock_release` calls.
1481 /// For normal locks this should be equivalent to `validate_lock_release`.
1482 /// This function only exists for joining over the set of concurrent readers
1483 /// in a read-write lock and should not be used for anything else.
1484 pub fn validate_lock_release_shared(&self, lock: &mut VClock, thread: ThreadId) {
1485 let (index, mut clocks) = self.load_thread_state_mut(thread);
1486 lock.join(&clocks.clock);
1487 clocks.increment_clock(index);
1490 /// Load the vector index used by the given thread as well as the set of vector clocks
1491 /// used by the thread.
1493 fn load_thread_state_mut(&self, thread: ThreadId) -> (VectorIdx, RefMut<'_, ThreadClockSet>) {
1494 let index = self.thread_info.borrow()[thread]
1496 .expect("Loading thread state for thread with no assigned vector");
1497 let ref_vector = self.vector_clocks.borrow_mut();
1498 let clocks = RefMut::map(ref_vector, |vec| &mut vec[index]);
1502 /// Load the current vector clock in use and the current set of thread clocks
1503 /// in use for the vector.
1505 pub(super) fn current_thread_state(&self) -> (VectorIdx, Ref<'_, ThreadClockSet>) {
1506 let index = self.current_index();
1507 let ref_vector = self.vector_clocks.borrow();
1508 let clocks = Ref::map(ref_vector, |vec| &vec[index]);
1512 /// Load the current vector clock in use and the current set of thread clocks
1513 /// in use for the vector mutably for modification.
1515 pub(super) fn current_thread_state_mut(&self) -> (VectorIdx, RefMut<'_, ThreadClockSet>) {
1516 let index = self.current_index();
1517 let ref_vector = self.vector_clocks.borrow_mut();
1518 let clocks = RefMut::map(ref_vector, |vec| &mut vec[index]);
1522 /// Return the current thread, should be the same
1523 /// as the data-race active thread.
1525 fn current_index(&self) -> VectorIdx {
1526 self.current_index.get()
1529 // SC ATOMIC STORE rule in the paper.
1530 pub(super) fn sc_write(&self) {
1531 let (index, clocks) = self.current_thread_state();
1532 self.last_sc_write.borrow_mut().set_at_index(&clocks.clock, index);
1535 // SC ATOMIC READ rule in the paper.
1536 pub(super) fn sc_read(&self) {
1537 let (.., mut clocks) = self.current_thread_state_mut();
1538 clocks.read_seqcst.join(&self.last_sc_fence.borrow());