src/bootstrap/tool.rs

   1 use std::collections::HashSet;
   2 use std::env;
   3 use std::fs;
   4 use std::path::PathBuf;
   5 use std::process::{exit, Command};
   6
   7 use build_helper::t;
   8
   9 use crate::builder::{Builder, Cargo as CargoCommand, RunConfig, ShouldRun, Step};
  10 use crate::channel::GitInfo;
  11 use crate::compile;
  12 use crate::config::TargetSelection;
  13 use crate::toolstate::ToolState;
  14 use crate::util::{add_dylib_path, exe};
  15 use crate::Compiler;
  16 use crate::Mode;
  17
  18 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
  19 pub enum SourceType {
  20     InTree,
  21     Submodule,
  22 }
  23
  24 #[derive(Debug, Clone, Hash, PartialEq, Eq)]
  25 struct ToolBuild {
  26     compiler: Compiler,
  27     target: TargetSelection,
  28     tool: &'static str,
  29     path: &'static str,
  30     mode: Mode,
  31     is_optional_tool: bool,
  32     source_type: SourceType,
  33     extra_features: Vec<String>,
  34 }
  35
  36 impl Step for ToolBuild {
  37     type Output = Option<PathBuf>;
  38
  39     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
  40         run.never()
  41     }
  42
  43     /// Builds a tool in `src/tools`
  44     ///
  45     /// This will build the specified tool with the specified `host` compiler in
  46     /// `stage` into the normal cargo output directory.
  47     fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
  48         let compiler = self.compiler;
  49         let target = self.target;
  50         let mut tool = self.tool;
  51         let path = self.path;
  52         let is_optional_tool = self.is_optional_tool;
  53
  54         match self.mode {
  55             Mode::ToolRustc => {
  56                 builder.ensure(compile::Std { compiler, target: compiler.host });
  57                 builder.ensure(compile::Rustc { compiler, target });
  58             }
  59             Mode::ToolStd => builder.ensure(compile::Std { compiler, target }),
  60             Mode::ToolBootstrap => {} // uses downloaded stage0 compiler libs
  61             _ => panic!("unexpected Mode for tool build"),
  62         }
  63
  64         let cargo = prepare_tool_cargo(
  65             builder,
  66             compiler,
  67             self.mode,
  68             target,
  69             "build",
  70             path,
  71             self.source_type,
  72             &self.extra_features,
  73         );
  74
  75         builder.info(&format!("Building stage{} tool {} ({})", compiler.stage, tool, target));
  76         let mut duplicates = Vec::new();
  77         let is_expected = compile::stream_cargo(builder, cargo, vec![], &mut |msg| {
  78             // Only care about big things like the RLS/Cargo for now
  79             match tool {
  80                 "rls" | "cargo" | "clippy-driver" | "miri" | "rustfmt" => {}
  81
  82                 _ => return,
  83             }
  84             let (id, features, filenames) = match msg {
  85                 compile::CargoMessage::CompilerArtifact {
  86                     package_id,
  87                     features,
  88                     filenames,
  89                     target: _,
  90                 } => (package_id, features, filenames),
  91                 _ => return,
  92             };
  93             let features = features.iter().map(|s| s.to_string()).collect::<Vec<_>>();
  94
  95             for path in filenames {
  96                 let val = (tool, PathBuf::from(&*path), features.clone());
  97                 // we're only interested in deduplicating rlibs for now
  98                 if val.1.extension().and_then(|s| s.to_str()) != Some("rlib") {
  99                     continue;
 100                 }
 101
 102                 // Don't worry about compiles that turn out to be host
 103                 // dependencies or build scripts. To skip these we look for
 104                 // anything that goes in `.../release/deps` but *doesn't* go in
 105                 // `$target/release/deps`. This ensure that outputs in
 106                 // `$target/release` are still considered candidates for
 107                 // deduplication.
 108                 if let Some(parent) = val.1.parent() {
 109                     if parent.ends_with("release/deps") {
 110                         let maybe_target = parent
 111                             .parent()
 112                             .and_then(|p| p.parent())
 113                             .and_then(|p| p.file_name())
 114                             .and_then(|p| p.to_str())
 115                             .unwrap();
 116                         if maybe_target != &*target.triple {
 117                             continue;
 118                         }
 119                     }
 120                 }
 121
 122                 // Record that we've built an artifact for `id`, and if one was
 123                 // already listed then we need to see if we reused the same
 124                 // artifact or produced a duplicate.
 125                 let mut artifacts = builder.tool_artifacts.borrow_mut();
 126                 let prev_artifacts = artifacts.entry(target).or_default();
 127                 let prev = match prev_artifacts.get(&*id) {
 128                     Some(prev) => prev,
 129                     None => {
 130                         prev_artifacts.insert(id.to_string(), val);
 131                         continue;
 132                     }
 133                 };
 134                 if prev.1 == val.1 {
 135                     return; // same path, same artifact
 136                 }
 137
 138                 // If the paths are different and one of them *isn't* inside of
 139                 // `release/deps`, then it means it's probably in
 140                 // `$target/release`, or it's some final artifact like
 141                 // `libcargo.rlib`. In these situations Cargo probably just
 142                 // copied it up from `$target/release/deps/libcargo-xxxx.rlib`,
 143                 // so if the features are equal we can just skip it.
 144                 let prev_no_hash = prev.1.parent().unwrap().ends_with("release/deps");
 145                 let val_no_hash = val.1.parent().unwrap().ends_with("release/deps");
 146                 if prev.2 == val.2 || !prev_no_hash || !val_no_hash {
 147                     return;
 148                 }
 149
 150                 // ... and otherwise this looks like we duplicated some sort of
 151                 // compilation, so record it to generate an error later.
 152                 duplicates.push((id.to_string(), val, prev.clone()));
 153             }
 154         });
 155
 156         if is_expected && !duplicates.is_empty() {
 157             println!(
 158                 "duplicate artifacts found when compiling a tool, this \
 159                       typically means that something was recompiled because \
 160                       a transitive dependency has different features activated \
 161                       than in a previous build:\n"
 162             );
 163             println!(
 164                 "the following dependencies are duplicated although they \
 165                       have the same features enabled:"
 166             );
 167             let (same, different): (Vec<_>, Vec<_>) =
 168                 duplicates.into_iter().partition(|(_, cur, prev)| cur.2 == prev.2);
 169             for (id, cur, prev) in same {
 170                 println!("  {}", id);
 171                 // same features
 172                 println!("    `{}` ({:?})\n    `{}` ({:?})", cur.0, cur.1, prev.0, prev.1);
 173             }
 174             println!("the following dependencies have different features:");
 175             for (id, cur, prev) in different {
 176                 println!("  {}", id);
 177                 let cur_features: HashSet<_> = cur.2.into_iter().collect();
 178                 let prev_features: HashSet<_> = prev.2.into_iter().collect();
 179                 println!(
 180                     "    `{}` additionally enabled features {:?} at {:?}",
 181                     cur.0,
 182                     &cur_features - &prev_features,
 183                     cur.1
 184                 );
 185                 println!(
 186                     "    `{}` additionally enabled features {:?} at {:?}",
 187                     prev.0,
 188                     &prev_features - &cur_features,
 189                     prev.1
 190                 );
 191             }
 192             println!();
 193             println!(
 194                 "to fix this you will probably want to edit the local \
 195                       src/tools/rustc-workspace-hack/Cargo.toml crate, as \
 196                       that will update the dependency graph to ensure that \
 197                       these crates all share the same feature set"
 198             );
 199             panic!("tools should not compile multiple copies of the same crate");
 200         }
 201
 202         builder.save_toolstate(
 203             tool,
 204             if is_expected { ToolState::TestFail } else { ToolState::BuildFail },
 205         );
 206
 207         if !is_expected {
 208             if !is_optional_tool {
 209                 exit(1);
 210             } else {
 211                 None
 212             }
 213         } else {
 214             // HACK(#82501): on Windows, the tools directory gets added to PATH when running tests, and
 215             // compiletest confuses HTML tidy with the in-tree tidy. Name the in-tree tidy something
 216             // different so the problem doesn't come up.
 217             if tool == "tidy" {
 218                 tool = "rust-tidy";
 219             }
 220             let cargo_out = builder.cargo_out(compiler, self.mode, target).join(exe(tool, target));
 221             let bin = builder.tools_dir(compiler).join(exe(tool, target));
 222             builder.copy(&cargo_out, &bin);
 223             Some(bin)
 224         }
 225     }
 226 }
 227
 228 pub fn prepare_tool_cargo(
 229     builder: &Builder<'_>,
 230     compiler: Compiler,
 231     mode: Mode,
 232     target: TargetSelection,
 233     command: &'static str,
 234     path: &'static str,
 235     source_type: SourceType,
 236     extra_features: &[String],
 237 ) -> CargoCommand {
 238     let mut cargo = builder.cargo(compiler, mode, source_type, target, command);
 239     let dir = builder.src.join(path);
 240     cargo.arg("--manifest-path").arg(dir.join("Cargo.toml"));
 241
 242     let mut features = extra_features.to_vec();
 243     if builder.build.config.cargo_native_static {
 244         if path.ends_with("cargo")
 245             || path.ends_with("rls")
 246             || path.ends_with("clippy")
 247             || path.ends_with("miri")
 248             || path.ends_with("rustfmt")
 249         {
 250             cargo.env("LIBZ_SYS_STATIC", "1");
 251             features.push("rustc-workspace-hack/all-static".to_string());
 252         }
 253     }
 254
 255     // if tools are using lzma we want to force the build script to build its
 256     // own copy
 257     cargo.env("LZMA_API_STATIC", "1");
 258
 259     // CFG_RELEASE is needed by rustfmt (and possibly other tools) which
 260     // import rustc-ap-rustc_attr which requires this to be set for the
 261     // `#[cfg(version(...))]` attribute.
 262     cargo.env("CFG_RELEASE", builder.rust_release());
 263     cargo.env("CFG_RELEASE_CHANNEL", &builder.config.channel);
 264     cargo.env("CFG_VERSION", builder.rust_version());
 265     cargo.env("CFG_RELEASE_NUM", &builder.version);
 266     cargo.env("DOC_RUST_LANG_ORG_CHANNEL", builder.doc_rust_lang_org_channel());
 267
 268     let info = GitInfo::new(builder.config.ignore_git, &dir);
 269     if let Some(sha) = info.sha() {
 270         cargo.env("CFG_COMMIT_HASH", sha);
 271     }
 272     if let Some(sha_short) = info.sha_short() {
 273         cargo.env("CFG_SHORT_COMMIT_HASH", sha_short);
 274     }
 275     if let Some(date) = info.commit_date() {
 276         cargo.env("CFG_COMMIT_DATE", date);
 277     }
 278     if !features.is_empty() {
 279         cargo.arg("--features").arg(&features.join(", "));
 280     }
 281     cargo
 282 }
 283
 284 macro_rules! bootstrap_tool {
 285     ($(
 286         $name:ident, $path:expr, $tool_name:expr
 287         $(,is_external_tool = $external:expr)*
 288         $(,is_unstable_tool = $unstable:expr)*
 289         $(,features = $features:expr)*
 290         ;
 291     )+) => {
 292         #[derive(Copy, PartialEq, Eq, Clone)]
 293         pub enum Tool {
 294             $(
 295                 $name,
 296             )+
 297         }
 298
 299         impl<'a> Builder<'a> {
 300             pub fn tool_exe(&self, tool: Tool) -> PathBuf {
 301                 match tool {
 302                     $(Tool::$name =>
 303                         self.ensure($name {
 304                             compiler: self.compiler(0, self.config.build),
 305                             target: self.config.build,
 306                         }),
 307                     )+
 308                 }
 309             }
 310         }
 311
 312         $(
 313             #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
 314         pub struct $name {
 315             pub compiler: Compiler,
 316             pub target: TargetSelection,
 317         }
 318
 319         impl Step for $name {
 320             type Output = PathBuf;
 321
 322             fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 323                 run.path($path)
 324             }
 325
 326             fn make_run(run: RunConfig<'_>) {
 327                 run.builder.ensure($name {
 328                     // snapshot compiler
 329                     compiler: run.builder.compiler(0, run.builder.config.build),
 330                     target: run.target,
 331                 });
 332             }
 333
 334             fn run(self, builder: &Builder<'_>) -> PathBuf {
 335                 builder.ensure(ToolBuild {
 336                     compiler: self.compiler,
 337                     target: self.target,
 338                     tool: $tool_name,
 339                     mode: if false $(|| $unstable)* {
 340                         // use in-tree libraries for unstable features
 341                         Mode::ToolStd
 342                     } else {
 343                         Mode::ToolBootstrap
 344                     },
 345                     path: $path,
 346                     is_optional_tool: false,
 347                     source_type: if false $(|| $external)* {
 348                         SourceType::Submodule
 349                     } else {
 350                         SourceType::InTree
 351                     },
 352                     extra_features: {
 353                         // FIXME(#60643): avoid this lint by using `_`
 354                         let mut _tmp = Vec::new();
 355                         $(_tmp.extend($features);)*
 356                         _tmp
 357                     },
 358                 }).expect("expected to build -- essential tool")
 359             }
 360         }
 361         )+
 362     }
 363 }
 364
 365 bootstrap_tool!(
 366     Rustbook, "src/tools/rustbook", "rustbook";
 367     UnstableBookGen, "src/tools/unstable-book-gen", "unstable-book-gen";
 368     Tidy, "src/tools/tidy", "tidy";
 369     Linkchecker, "src/tools/linkchecker", "linkchecker";
 370     CargoTest, "src/tools/cargotest", "cargotest";
 371     Compiletest, "src/tools/compiletest", "compiletest", is_unstable_tool = true;
 372     BuildManifest, "src/tools/build-manifest", "build-manifest";
 373     RemoteTestClient, "src/tools/remote-test-client", "remote-test-client";
 374     RustInstaller, "src/tools/rust-installer", "fabricate", is_external_tool = true;
 375     RustdocTheme, "src/tools/rustdoc-themes", "rustdoc-themes";
 376     ExpandYamlAnchors, "src/tools/expand-yaml-anchors", "expand-yaml-anchors";
 377     LintDocs, "src/tools/lint-docs", "lint-docs";
 378     JsonDocCk, "src/tools/jsondocck", "jsondocck";
 379 );
 380
 381 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq, Ord, PartialOrd)]
 382 pub struct ErrorIndex {
 383     pub compiler: Compiler,
 384 }
 385
 386 impl ErrorIndex {
 387     pub fn command(builder: &Builder<'_>) -> Command {
 388         // This uses stage-1 to match the behavior of building rustdoc.
 389         // Error-index-generator links with the rustdoc library, so we want to
 390         // use the same librustdoc to avoid building rustdoc twice (and to
 391         // avoid building the compiler an extra time). This uses
 392         // saturating_sub to deal with building with stage 0. (Using stage 0
 393         // isn't recommended, since it will fail if any new error index tests
 394         // use new syntax, but it should work otherwise.)
 395         let compiler = builder.compiler(builder.top_stage.saturating_sub(1), builder.config.build);
 396         let mut cmd = Command::new(builder.ensure(ErrorIndex { compiler }));
 397         add_dylib_path(
 398             vec![
 399                 PathBuf::from(&builder.sysroot_libdir(compiler, compiler.host)),
 400                 PathBuf::from(builder.rustc_libdir(compiler)),
 401             ],
 402             &mut cmd,
 403         );
 404         cmd
 405     }
 406 }
 407
 408 impl Step for ErrorIndex {
 409     type Output = PathBuf;
 410
 411     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 412         run.path("src/tools/error_index_generator")
 413     }
 414
 415     fn make_run(run: RunConfig<'_>) {
 416         // Compile the error-index in the same stage as rustdoc to avoid
 417         // recompiling rustdoc twice if we can.
 418         //
 419         // NOTE: This `make_run` isn't used in normal situations, only if you
 420         // manually build the tool with `x.py build
 421         // src/tools/error-index-generator` which almost nobody does.
 422         // Normally, `x.py test` or `x.py doc` will use the
 423         // `ErrorIndex::command` function instead.
 424         let compiler =
 425             run.builder.compiler(run.builder.top_stage.saturating_sub(1), run.builder.config.build);
 426         run.builder.ensure(ErrorIndex { compiler });
 427     }
 428
 429     fn run(self, builder: &Builder<'_>) -> PathBuf {
 430         builder
 431             .ensure(ToolBuild {
 432                 compiler: self.compiler,
 433                 target: self.compiler.host,
 434                 tool: "error_index_generator",
 435                 mode: Mode::ToolRustc,
 436                 path: "src/tools/error_index_generator",
 437                 is_optional_tool: false,
 438                 source_type: SourceType::InTree,
 439                 extra_features: Vec::new(),
 440             })
 441             .expect("expected to build -- essential tool")
 442     }
 443 }
 444
 445 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
 446 pub struct RemoteTestServer {
 447     pub compiler: Compiler,
 448     pub target: TargetSelection,
 449 }
 450
 451 impl Step for RemoteTestServer {
 452     type Output = PathBuf;
 453
 454     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 455         run.path("src/tools/remote-test-server")
 456     }
 457
 458     fn make_run(run: RunConfig<'_>) {
 459         run.builder.ensure(RemoteTestServer {
 460             compiler: run.builder.compiler(run.builder.top_stage, run.builder.config.build),
 461             target: run.target,
 462         });
 463     }
 464
 465     fn run(self, builder: &Builder<'_>) -> PathBuf {
 466         builder
 467             .ensure(ToolBuild {
 468                 compiler: self.compiler,
 469                 target: self.target,
 470                 tool: "remote-test-server",
 471                 mode: Mode::ToolStd,
 472                 path: "src/tools/remote-test-server",
 473                 is_optional_tool: false,
 474                 source_type: SourceType::InTree,
 475                 extra_features: Vec::new(),
 476             })
 477             .expect("expected to build -- essential tool")
 478     }
 479 }
 480
 481 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq, Ord, PartialOrd)]
 482 pub struct Rustdoc {
 483     /// This should only ever be 0 or 2.
 484     /// We sometimes want to reference the "bootstrap" rustdoc, which is why this option is here.
 485     pub compiler: Compiler,
 486 }
 487
 488 impl Step for Rustdoc {
 489     type Output = PathBuf;
 490     const DEFAULT: bool = true;
 491     const ONLY_HOSTS: bool = true;
 492
 493     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 494         run.path("src/tools/rustdoc").path("src/librustdoc")
 495     }
 496
 497     fn make_run(run: RunConfig<'_>) {
 498         run.builder.ensure(Rustdoc {
 499             // Note: this is somewhat unique in that we actually want a *target*
 500             // compiler here, because rustdoc *is* a compiler. We won't be using
 501             // this as the compiler to build with, but rather this is "what
 502             // compiler are we producing"?
 503             compiler: run.builder.compiler(run.builder.top_stage, run.target),
 504         });
 505     }
 506
 507     fn run(self, builder: &Builder<'_>) -> PathBuf {
 508         let target_compiler = self.compiler;
 509         if target_compiler.stage == 0 {
 510             if !target_compiler.is_snapshot(builder) {
 511                 panic!("rustdoc in stage 0 must be snapshot rustdoc");
 512             }
 513             return builder.initial_rustc.with_file_name(exe("rustdoc", target_compiler.host));
 514         }
 515         let target = target_compiler.host;
 516         // Similar to `compile::Assemble`, build with the previous stage's compiler. Otherwise
 517         // we'd have stageN/bin/rustc and stageN/bin/rustdoc be effectively different stage
 518         // compilers, which isn't what we want. Rustdoc should be linked in the same way as the
 519         // rustc compiler it's paired with, so it must be built with the previous stage compiler.
 520         let build_compiler = builder.compiler(target_compiler.stage - 1, builder.config.build);
 521
 522         // When using `download-rustc` and a stage0 build_compiler, copying rustc doesn't actually
 523         // build stage0 libstd (because the libstd in sysroot has the wrong ABI). Explicitly build
 524         // it.
 525         builder.ensure(compile::Std { compiler: build_compiler, target: target_compiler.host });
 526         builder.ensure(compile::Rustc { compiler: build_compiler, target: target_compiler.host });
 527         // NOTE: this implies that `download-rustc` is pretty useless when compiling with the stage0
 528         // compiler, since you do just as much work.
 529         if !builder.config.dry_run && builder.config.download_rustc && build_compiler.stage == 0 {
 530             println!(
 531                 "warning: `download-rustc` does nothing when building stage1 tools; consider using `--stage 2` instead"
 532             );
 533         }
 534
 535         // The presence of `target_compiler` ensures that the necessary libraries (codegen backends,
 536         // compiler libraries, ...) are built. Rustdoc does not require the presence of any
 537         // libraries within sysroot_libdir (i.e., rustlib), though doctests may want it (since
 538         // they'll be linked to those libraries). As such, don't explicitly `ensure` any additional
 539         // libraries here. The intuition here is that If we've built a compiler, we should be able
 540         // to build rustdoc.
 541         //
 542         let mut features = Vec::new();
 543         if builder.config.jemalloc {
 544             features.push("jemalloc".to_string());
 545         }
 546
 547         let cargo = prepare_tool_cargo(
 548             builder,
 549             build_compiler,
 550             Mode::ToolRustc,
 551             target,
 552             "build",
 553             "src/tools/rustdoc",
 554             SourceType::InTree,
 555             features.as_slice(),
 556         );
 557
 558         builder.info(&format!(
 559             "Building rustdoc for stage{} ({})",
 560             target_compiler.stage, target_compiler.host
 561         ));
 562         builder.run(&mut cargo.into());
 563
 564         // Cargo adds a number of paths to the dylib search path on windows, which results in
 565         // the wrong rustdoc being executed. To avoid the conflicting rustdocs, we name the "tool"
 566         // rustdoc a different name.
 567         let tool_rustdoc = builder
 568             .cargo_out(build_compiler, Mode::ToolRustc, target)
 569             .join(exe("rustdoc_tool_binary", target_compiler.host));
 570
 571         // don't create a stage0-sysroot/bin directory.
 572         if target_compiler.stage > 0 {
 573             let sysroot = builder.sysroot(target_compiler);
 574             let bindir = sysroot.join("bin");
 575             t!(fs::create_dir_all(&bindir));
 576             let bin_rustdoc = bindir.join(exe("rustdoc", target_compiler.host));
 577             let _ = fs::remove_file(&bin_rustdoc);
 578             builder.copy(&tool_rustdoc, &bin_rustdoc);
 579             bin_rustdoc
 580         } else {
 581             tool_rustdoc
 582         }
 583     }
 584 }
 585
 586 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
 587 pub struct Cargo {
 588     pub compiler: Compiler,
 589     pub target: TargetSelection,
 590 }
 591
 592 impl Step for Cargo {
 593     type Output = PathBuf;
 594     const DEFAULT: bool = true;
 595     const ONLY_HOSTS: bool = true;
 596
 597     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 598         let builder = run.builder;
 599         run.path("src/tools/cargo").default_condition(
 600             builder.config.extended
 601                 && builder.config.tools.as_ref().map_or(
 602                     true,
 603                     // If `tools` is set, search list for this tool.
 604                     |tools| tools.iter().any(|tool| tool == "cargo"),
 605                 ),
 606         )
 607     }
 608
 609     fn make_run(run: RunConfig<'_>) {
 610         run.builder.ensure(Cargo {
 611             compiler: run.builder.compiler(run.builder.top_stage, run.builder.config.build),
 612             target: run.target,
 613         });
 614     }
 615
 616     fn run(self, builder: &Builder<'_>) -> PathBuf {
 617         let cargo_bin_path = builder
 618             .ensure(ToolBuild {
 619                 compiler: self.compiler,
 620                 target: self.target,
 621                 tool: "cargo",
 622                 mode: Mode::ToolRustc,
 623                 path: "src/tools/cargo",
 624                 is_optional_tool: false,
 625                 source_type: SourceType::Submodule,
 626                 extra_features: Vec::new(),
 627             })
 628             .expect("expected to build -- essential tool");
 629
 630         let build_cred = |name, path| {
 631             // These credential helpers are currently experimental.
 632             // Any build failures will be ignored.
 633             let _ = builder.ensure(ToolBuild {
 634                 compiler: self.compiler,
 635                 target: self.target,
 636                 tool: name,
 637                 mode: Mode::ToolRustc,
 638                 path,
 639                 is_optional_tool: true,
 640                 source_type: SourceType::Submodule,
 641                 extra_features: Vec::new(),
 642             });
 643         };
 644
 645         if self.target.contains("windows") {
 646             build_cred(
 647                 "cargo-credential-wincred",
 648                 "src/tools/cargo/crates/credential/cargo-credential-wincred",
 649             );
 650         }
 651         if self.target.contains("apple-darwin") {
 652             build_cred(
 653                 "cargo-credential-macos-keychain",
 654                 "src/tools/cargo/crates/credential/cargo-credential-macos-keychain",
 655             );
 656         }
 657         build_cred(
 658             "cargo-credential-1password",
 659             "src/tools/cargo/crates/credential/cargo-credential-1password",
 660         );
 661         cargo_bin_path
 662     }
 663 }
 664
 665 macro_rules! tool_extended {
 666     (($sel:ident, $builder:ident),
 667        $($name:ident,
 668        $toolstate:ident,
 669        $path:expr,
 670        $tool_name:expr,
 671        stable = $stable:expr,
 672        $(in_tree = $in_tree:expr,)*
 673        $extra_deps:block;)+) => {
 674         $(
 675             #[derive(Debug, Clone, Hash, PartialEq, Eq)]
 676         pub struct $name {
 677             pub compiler: Compiler,
 678             pub target: TargetSelection,
 679             pub extra_features: Vec<String>,
 680         }
 681
 682         impl Step for $name {
 683             type Output = Option<PathBuf>;
 684             const DEFAULT: bool = true; // Overwritten below
 685             const ONLY_HOSTS: bool = true;
 686
 687             fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
 688                 let builder = run.builder;
 689                 run.path($path).default_condition(
 690                     builder.config.extended
 691                         && builder.config.tools.as_ref().map_or(
 692                             // By default, on nightly/dev enable all tools, else only
 693                             // build stable tools.
 694                             $stable || builder.build.unstable_features(),
 695                             // If `tools` is set, search list for this tool.
 696                             |tools| {
 697                                 tools.iter().any(|tool| match tool.as_ref() {
 698                                     "clippy" => $tool_name == "clippy-driver",
 699                                     x => $tool_name == x,
 700                             })
 701                         }),
 702                 )
 703             }
 704
 705             fn make_run(run: RunConfig<'_>) {
 706                 run.builder.ensure($name {
 707                     compiler: run.builder.compiler(run.builder.top_stage, run.builder.config.build),
 708                     target: run.target,
 709                     extra_features: Vec::new(),
 710                 });
 711             }
 712
 713             #[allow(unused_mut)]
 714             fn run(mut $sel, $builder: &Builder<'_>) -> Option<PathBuf> {
 715                 $extra_deps
 716                 $builder.ensure(ToolBuild {
 717                     compiler: $sel.compiler,
 718                     target: $sel.target,
 719                     tool: $tool_name,
 720                     mode: Mode::ToolRustc,
 721                     path: $path,
 722                     extra_features: $sel.extra_features,
 723                     is_optional_tool: true,
 724                     source_type: if false $(|| $in_tree)* {
 725                         SourceType::InTree
 726                     } else {
 727                         SourceType::Submodule
 728                     },
 729                 })
 730             }
 731         }
 732         )+
 733     }
 734 }
 735
 736 // Note: tools need to be also added to `Builder::get_step_descriptions` in `builder.rs`
 737 // to make `./x.py build <tool>` work.
 738 tool_extended!((self, builder),
 739     Cargofmt, rustfmt, "src/tools/rustfmt", "cargo-fmt", stable=true, in_tree=true, {};
 740     CargoClippy, clippy, "src/tools/clippy", "cargo-clippy", stable=true, in_tree=true, {};
 741     Clippy, clippy, "src/tools/clippy", "clippy-driver", stable=true, in_tree=true, {};
 742     Miri, miri, "src/tools/miri", "miri", stable=false, {};
 743     CargoMiri, miri, "src/tools/miri/cargo-miri", "cargo-miri", stable=false, {};
 744     Rls, rls, "src/tools/rls", "rls", stable=true, {
 745         builder.ensure(Clippy {
 746             compiler: self.compiler,
 747             target: self.target,
 748             extra_features: Vec::new(),
 749         });
 750         self.extra_features.push("clippy".to_owned());
 751     };
 752     RustDemangler, rust_demangler, "src/tools/rust-demangler", "rust-demangler", stable=false, in_tree=true, {};
 753     Rustfmt, rustfmt, "src/tools/rustfmt", "rustfmt", stable=true, in_tree=true, {};
 754     RustAnalyzer, rust_analyzer, "src/tools/rust-analyzer/crates/rust-analyzer", "rust-analyzer", stable=false, {};
 755 );
 756
 757 impl<'a> Builder<'a> {
 758     /// Gets a `Command` which is ready to run `tool` in `stage` built for
 759     /// `host`.
 760     pub fn tool_cmd(&self, tool: Tool) -> Command {
 761         let mut cmd = Command::new(self.tool_exe(tool));
 762         let compiler = self.compiler(0, self.config.build);
 763         let host = &compiler.host;
 764         // Prepares the `cmd` provided to be able to run the `compiler` provided.
 765         //
 766         // Notably this munges the dynamic library lookup path to point to the
 767         // right location to run `compiler`.
 768         let mut lib_paths: Vec<PathBuf> = vec![
 769             self.build.rustc_snapshot_libdir(),
 770             self.cargo_out(compiler, Mode::ToolBootstrap, *host).join("deps"),
 771         ];
 772
 773         // On MSVC a tool may invoke a C compiler (e.g., compiletest in run-make
 774         // mode) and that C compiler may need some extra PATH modification. Do
 775         // so here.
 776         if compiler.host.contains("msvc") {
 777             let curpaths = env::var_os("PATH").unwrap_or_default();
 778             let curpaths = env::split_paths(&curpaths).collect::<Vec<_>>();
 779             for &(ref k, ref v) in self.cc[&compiler.host].env() {
 780                 if k != "PATH" {
 781                     continue;
 782                 }
 783                 for path in env::split_paths(v) {
 784                     if !curpaths.contains(&path) {
 785                         lib_paths.push(path);
 786                     }
 787                 }
 788             }
 789         }
 790
 791         add_dylib_path(lib_paths, &mut cmd);
 792
 793         // Provide a RUSTC for this command to use.
 794         cmd.env("RUSTC", &self.initial_rustc);
 795
 796         cmd
 797     }
 798 }