1 //! Runs rustfmt on the repository.
4 use build_helper::{output, t};
5 use ignore::WalkBuilder;
7 use std::process::{Command, Stdio};
9 fn rustfmt(src: &Path, rustfmt: &Path, path: &Path, check: bool) {
10 let mut cmd = Command::new(&rustfmt);
11 // avoid the submodule config paths from coming into play,
12 // we only allow a single global config for the workspace for now
13 cmd.arg("--config-path").arg(&src.canonicalize().unwrap());
14 cmd.arg("--edition").arg("2018");
15 cmd.arg("--unstable-features");
16 cmd.arg("--skip-children");
21 let cmd_debug = format!("{:?}", cmd);
22 let status = cmd.status().expect("executing rustfmt");
23 if !status.success() {
25 "Running `{}` failed.\nIf you're running `tidy`, \
26 try again with `--bless`. Or, if you just want to format \
27 code, run `./x.py fmt` instead.",
30 std::process::exit(1);
34 #[derive(serde::Deserialize)]
35 struct RustfmtConfig {
39 pub fn format(build: &Build, check: bool) {
40 if build.config.dry_run {
43 let mut builder = ignore::types::TypesBuilder::new();
44 builder.add_defaults();
45 builder.select("rust");
46 let matcher = builder.build().unwrap();
47 let rustfmt_config = build.src.join("rustfmt.toml");
48 if !rustfmt_config.exists() {
49 eprintln!("Not running formatting checks; rustfmt.toml does not exist.");
50 eprintln!("This may happen in distributed tarballs.");
53 let rustfmt_config = t!(std::fs::read_to_string(&rustfmt_config));
54 let rustfmt_config: RustfmtConfig = t!(toml::from_str(&rustfmt_config));
55 let mut ignore_fmt = ignore::overrides::OverrideBuilder::new(&build.src);
56 for ignore in rustfmt_config.ignore {
57 ignore_fmt.add(&format!("!{}", ignore)).expect(&ignore);
59 let git_available = match Command::new("git")
61 .stdout(Stdio::null())
62 .stderr(Stdio::null())
65 Ok(status) => status.success(),
69 let in_working_tree = match Command::new("git")
71 .arg("--is-inside-work-tree")
72 .stdout(Stdio::null())
73 .stderr(Stdio::null())
76 Ok(status) => status.success(),
80 let untracked_paths_output = output(
84 .arg("--untracked-files=normal"),
86 let untracked_paths = untracked_paths_output
88 .filter(|entry| entry.starts_with("??"))
90 entry.split(' ').nth(1).expect("every git status entry should list a path")
92 for untracked_path in untracked_paths {
93 eprintln!("skip untracked path {} during rustfmt invocations", untracked_path);
94 ignore_fmt.add(&format!("!{}", untracked_path)).expect(&untracked_path);
97 eprintln!("Not in git tree. Skipping git-aware format checks");
100 eprintln!("Could not find usable git. Skipping git-aware format checks");
102 let ignore_fmt = ignore_fmt.build().unwrap();
104 let rustfmt_path = build.config.initial_rustfmt.as_ref().unwrap_or_else(|| {
105 eprintln!("./x.py fmt is not supported on this channel");
106 std::process::exit(1);
108 let src = &build.src;
109 let walker = WalkBuilder::new(src).types(matcher).overrides(ignore_fmt).build_parallel();
111 Box::new(move |entry| {
112 let entry = t!(entry);
113 if entry.file_type().map_or(false, |t| t.is_file()) {
114 rustfmt(src, &rustfmt_path, &entry.path(), check);
116 ignore::WalkState::Continue