2 use std::cell::{Cell, RefCell};
3 use std::collections::BTreeSet;
10 use std::path::{Path, PathBuf};
11 use std::process::Command;
12 use std::time::{Duration, Instant};
14 use build_helper::{output, t};
16 use crate::cache::{Cache, Interned, INTERNER};
19 use crate::config::TargetSelection;
22 use crate::flags::{Color, Subcommand};
27 use crate::tool::{self, SourceType};
28 use crate::util::{self, add_dylib_path, add_link_lib_path, exe, libdir};
29 use crate::{Build, DocTests, GitRepo, Mode};
31 pub use crate::Compiler;
32 // FIXME: replace with std::lazy after it gets stabilized and reaches beta
33 use once_cell::sync::Lazy;
35 pub struct Builder<'a> {
40 stack: RefCell<Vec<Box<dyn Any>>>,
41 time_spent_on_dependencies: Cell<Duration>,
42 pub paths: Vec<PathBuf>,
45 impl<'a> Deref for Builder<'a> {
48 fn deref(&self) -> &Self::Target {
53 pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
54 /// `PathBuf` when directories are created or to return a `Compiler` once
55 /// it's been assembled.
58 /// Whether this step is run by default as part of its respective phase.
59 /// `true` here can still be overwritten by `should_run` calling `default_condition`.
60 const DEFAULT: bool = false;
62 /// If true, then this rule should be skipped if --target was specified, but --host was not
63 const ONLY_HOSTS: bool = false;
65 /// Primary function to execute this rule. Can call `builder.ensure()`
66 /// with other steps to run those.
67 fn run(self, builder: &Builder<'_>) -> Self::Output;
69 /// When bootstrap is passed a set of paths, this controls whether this rule
70 /// will execute. However, it does not get called in a "default" context
71 /// when we are not passed any paths; in that case, `make_run` is called
73 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
75 /// Builds up a "root" rule, either as a default rule or from a path passed
78 /// When path is `None`, we are executing in a context where no paths were
79 /// passed. When `./x.py build` is run, for example, this rule could get
80 /// called if it is in the correct list below with a path of `None`.
81 fn make_run(_run: RunConfig<'_>) {
82 // It is reasonable to not have an implementation of make_run for rules
83 // who do not want to get called from the root context. This means that
84 // they are likely dependencies (e.g., sysroot creation) or similar, and
85 // as such calling them from ./x.py isn't logical.
90 pub struct RunConfig<'a> {
91 pub builder: &'a Builder<'a>,
92 pub target: TargetSelection,
97 pub fn build_triple(&self) -> TargetSelection {
98 self.builder.build.build
102 struct StepDescription {
105 should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
106 make_run: fn(RunConfig<'_>),
110 /// Collection of paths used to match a task rule.
111 #[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
113 /// A collection of individual paths.
115 /// These are generally matched as a path suffix. For example, a
116 /// command-line value of `libstd` will match if `src/libstd` is in the
118 Set(BTreeSet<PathBuf>),
119 /// A "suite" of paths.
121 /// These can match as a path suffix (like `Set`), or as a prefix. For
122 /// example, a command-line value of `src/test/ui/abi/variadic-ffi.rs`
123 /// will match `src/test/ui`. A command-line value of `ui` would also
124 /// match `src/test/ui`.
129 fn empty() -> PathSet {
130 PathSet::Set(BTreeSet::new())
133 fn one<P: Into<PathBuf>>(path: P) -> PathSet {
134 let mut set = BTreeSet::new();
135 set.insert(path.into());
139 fn has(&self, needle: &Path) -> bool {
141 PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
142 PathSet::Suite(suite) => suite.ends_with(needle),
146 fn path(&self, builder: &Builder<'_>) -> PathBuf {
148 PathSet::Set(set) => set.iter().next().unwrap_or(&builder.build.src).to_path_buf(),
149 PathSet::Suite(path) => PathBuf::from(path),
154 impl StepDescription {
155 fn from<S: Step>() -> StepDescription {
158 only_hosts: S::ONLY_HOSTS,
159 should_run: S::should_run,
160 make_run: S::make_run,
161 name: std::any::type_name::<S>(),
165 fn maybe_run(&self, builder: &Builder<'_>, pathset: &PathSet) {
166 if self.is_excluded(builder, pathset) {
170 // Determine the targets participating in this rule.
171 let targets = if self.only_hosts { &builder.hosts } else { &builder.targets };
173 for target in targets {
174 let run = RunConfig { builder, path: pathset.path(builder), target: *target };
175 (self.make_run)(run);
179 fn is_excluded(&self, builder: &Builder<'_>, pathset: &PathSet) -> bool {
180 if builder.config.exclude.iter().any(|e| pathset.has(e)) {
181 eprintln!("Skipping {:?} because it is excluded", pathset);
185 if !builder.config.exclude.is_empty() {
187 "{:?} not skipped for {:?} -- not in {:?}",
188 pathset, self.name, builder.config.exclude
194 fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
196 v.iter().map(|desc| (desc.should_run)(ShouldRun::new(builder))).collect::<Vec<_>>();
198 // sanity checks on rules
199 for (desc, should_run) in v.iter().zip(&should_runs) {
201 !should_run.paths.is_empty(),
202 "{:?} should have at least one pathset",
207 if paths.is_empty() || builder.config.include_default_paths {
208 for (desc, should_run) in v.iter().zip(&should_runs) {
209 if desc.default && should_run.is_really_default() {
210 for pathset in &should_run.paths {
211 desc.maybe_run(builder, pathset);
218 // strip CurDir prefix if present
219 let path = match path.strip_prefix(".") {
224 let mut attempted_run = false;
225 for (desc, should_run) in v.iter().zip(&should_runs) {
226 if let Some(suite) = should_run.is_suite_path(path) {
227 attempted_run = true;
228 desc.maybe_run(builder, suite);
229 } else if let Some(pathset) = should_run.pathset_for_path(path) {
230 attempted_run = true;
231 desc.maybe_run(builder, pathset);
236 panic!("error: no rules matched {}", path.display());
242 enum ReallyDefault<'a> {
244 Lazy(Lazy<bool, Box<dyn Fn() -> bool + 'a>>),
247 pub struct ShouldRun<'a> {
248 pub builder: &'a Builder<'a>,
249 // use a BTreeSet to maintain sort order
250 paths: BTreeSet<PathSet>,
252 // If this is a default rule, this is an additional constraint placed on
253 // its run. Generally something like compiler docs being enabled.
254 is_really_default: ReallyDefault<'a>,
257 impl<'a> ShouldRun<'a> {
258 fn new(builder: &'a Builder<'_>) -> ShouldRun<'a> {
261 paths: BTreeSet::new(),
262 is_really_default: ReallyDefault::Bool(true), // by default no additional conditions
266 pub fn default_condition(mut self, cond: bool) -> Self {
267 self.is_really_default = ReallyDefault::Bool(cond);
271 pub fn lazy_default_condition(mut self, lazy_cond: Box<dyn Fn() -> bool + 'a>) -> Self {
272 self.is_really_default = ReallyDefault::Lazy(Lazy::new(lazy_cond));
276 pub fn is_really_default(&self) -> bool {
277 match &self.is_really_default {
278 ReallyDefault::Bool(val) => *val,
279 ReallyDefault::Lazy(lazy) => *lazy.deref(),
283 /// Indicates it should run if the command-line selects the given crate or
284 /// any of its (local) dependencies.
286 /// Compared to `krate`, this treats the dependencies as aliases for the
287 /// same job. Generally it is preferred to use `krate`, and treat each
288 /// individual path separately. For example `./x.py test src/liballoc`
289 /// (which uses `krate`) will test just `liballoc`. However, `./x.py check
290 /// src/liballoc` (which uses `all_krates`) will check all of `libtest`.
291 /// `all_krates` should probably be removed at some point.
292 pub fn all_krates(mut self, name: &str) -> Self {
293 let mut set = BTreeSet::new();
294 for krate in self.builder.in_tree_crates(name, None) {
295 let path = krate.local_path(self.builder);
298 self.paths.insert(PathSet::Set(set));
302 /// Indicates it should run if the command-line selects the given crate or
303 /// any of its (local) dependencies.
305 /// `make_run` will be called separately for each matching command-line path.
306 pub fn krate(mut self, name: &str) -> Self {
307 for krate in self.builder.in_tree_crates(name, None) {
308 let path = krate.local_path(self.builder);
309 self.paths.insert(PathSet::one(path));
314 // single, non-aliased path
315 pub fn path(self, path: &str) -> Self {
319 // multiple aliases for the same job
320 pub fn paths(mut self, paths: &[&str]) -> Self {
321 self.paths.insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
325 pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
326 self.paths.iter().find(|pathset| match pathset {
327 PathSet::Suite(p) => path.starts_with(p),
328 PathSet::Set(_) => false,
332 pub fn suite_path(mut self, suite: &str) -> Self {
333 self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
337 // allows being more explicit about why should_run in Step returns the value passed to it
338 pub fn never(mut self) -> ShouldRun<'a> {
339 self.paths.insert(PathSet::empty());
343 fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
344 self.paths.iter().find(|pathset| pathset.has(path))
348 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
363 impl<'a> Builder<'a> {
364 fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
365 macro_rules! describe {
366 ($($rule:ty),+ $(,)?) => {{
367 vec![$(StepDescription::from::<$rule>()),+]
371 Kind::Build => describe!(
374 compile::CodegenBackend,
375 compile::StartupObjects,
379 tool::UnstableBookGen,
384 tool::RemoteTestServer,
385 tool::RemoteTestClient,
402 Kind::Check | Kind::Clippy { .. } | Kind::Fix | Kind::Format => describe!(
406 check::CodegenBackend,
413 Kind::Test => describe!(
414 crate::toolstate::ToolStateCheck,
415 test::ExpandYamlAnchors,
418 test::RunPassValgrind,
431 test::CrateRustdocJsonTypes,
439 test::RunMakeFullDeps,
455 test::CompiletestTest,
457 test::RustdocJSNotStd,
463 // Run bootstrap close to the end as it's unlikely to fail
465 // Run run-make last, since these won't pass without make on Windows
468 Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
469 Kind::Doc => describe!(
471 doc::UnstableBookGen,
489 Kind::Dist => describe!(
494 dist::DebuggerScripts,
499 dist::PlainSourceTarball,
511 dist::ReproducibleArtifacts,
513 Kind::Install => describe!(
518 install::RustAnalyzer,
520 install::RustDemangler,
527 Kind::Run => describe!(run::ExpandYamlAnchors, run::BuildManifest, run::BumpStage0),
531 pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
532 let kind = match subcommand {
533 "build" => Kind::Build,
535 "test" => Kind::Test,
536 "bench" => Kind::Bench,
537 "dist" => Kind::Dist,
538 "install" => Kind::Install,
542 let builder = Self::new_internal(build, kind, vec![]);
543 let builder = &builder;
544 let mut should_run = ShouldRun::new(builder);
545 for desc in Builder::get_step_descriptions(builder.kind) {
546 should_run = (desc.should_run)(should_run);
548 let mut help = String::from("Available paths:\n");
549 let mut add_path = |path: &Path| {
550 help.push_str(&format!(" ./x.py {} {}\n", subcommand, path.display()));
552 for pathset in should_run.paths {
554 PathSet::Set(set) => {
559 PathSet::Suite(path) => {
560 add_path(&path.join("..."));
567 fn new_internal(build: &Build, kind: Kind, paths: Vec<PathBuf>) -> Builder<'_> {
570 top_stage: build.config.stage,
573 stack: RefCell::new(Vec::new()),
574 time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
579 pub fn new(build: &Build) -> Builder<'_> {
580 let (kind, paths) = match build.config.cmd {
581 Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
582 Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
583 Subcommand::Clippy { ref paths, .. } => (Kind::Clippy, &paths[..]),
584 Subcommand::Fix { ref paths } => (Kind::Fix, &paths[..]),
585 Subcommand::Doc { ref paths, .. } => (Kind::Doc, &paths[..]),
586 Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
587 Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
588 Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
589 Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
590 Subcommand::Run { ref paths } => (Kind::Run, &paths[..]),
591 Subcommand::Format { .. } | Subcommand::Clean { .. } | Subcommand::Setup { .. } => {
596 Self::new_internal(build, kind, paths.to_owned())
599 pub fn execute_cli(&self) {
600 self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
603 pub fn default_doc(&self, paths: &[PathBuf]) {
604 self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
607 /// NOTE: keep this in sync with `rustdoc::clean::utils::doc_rust_lang_org_channel`, or tests will fail on beta/stable.
608 pub fn doc_rust_lang_org_channel(&self) -> String {
609 let channel = match &*self.config.channel {
610 "stable" => &self.version,
612 "nightly" | "dev" => "nightly",
613 // custom build of rustdoc maybe? link to the latest stable docs just in case
616 "https://doc.rust-lang.org/".to_owned() + channel
619 fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
620 StepDescription::run(v, self, paths);
623 /// Obtain a compiler at a given stage and for a given host. Explicitly does
624 /// not take `Compiler` since all `Compiler` instances are meant to be
625 /// obtained through this function, since it ensures that they are valid
626 /// (i.e., built and assembled).
627 pub fn compiler(&self, stage: u32, host: TargetSelection) -> Compiler {
628 self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
631 /// Similar to `compiler`, except handles the full-bootstrap option to
632 /// silently use the stage1 compiler instead of a stage2 compiler if one is
635 /// Note that this does *not* have the side effect of creating
636 /// `compiler(stage, host)`, unlike `compiler` above which does have such
637 /// a side effect. The returned compiler here can only be used to compile
638 /// new artifacts, it can't be used to rely on the presence of a particular
641 /// See `force_use_stage1` for documentation on what each argument is.
645 host: TargetSelection,
646 target: TargetSelection,
648 if self.build.force_use_stage1(Compiler { stage, host }, target) {
649 self.compiler(1, self.config.build)
651 self.compiler(stage, host)
655 pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
656 self.ensure(compile::Sysroot { compiler })
659 /// Returns the libdir where the standard library and other artifacts are
660 /// found for a compiler's sysroot.
661 pub fn sysroot_libdir(&self, compiler: Compiler, target: TargetSelection) -> Interned<PathBuf> {
662 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
665 target: TargetSelection,
667 impl Step for Libdir {
668 type Output = Interned<PathBuf>;
670 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
674 fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
675 let lib = builder.sysroot_libdir_relative(self.compiler);
676 let sysroot = builder
677 .sysroot(self.compiler)
680 .join(self.target.triple)
682 // Avoid deleting the rustlib/ directory we just copied
683 // (in `impl Step for Sysroot`).
684 if !builder.config.download_rustc {
685 let _ = fs::remove_dir_all(&sysroot);
686 t!(fs::create_dir_all(&sysroot));
688 INTERNER.intern_path(sysroot)
691 self.ensure(Libdir { compiler, target })
694 pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
695 self.sysroot_libdir(compiler, compiler.host).with_file_name("codegen-backends")
698 /// Returns the compiler's libdir where it stores the dynamic libraries that
699 /// it itself links against.
701 /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
703 pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
704 if compiler.is_snapshot(self) {
705 self.rustc_snapshot_libdir()
707 match self.config.libdir_relative() {
708 Some(relative_libdir) if compiler.stage >= 1 => {
709 self.sysroot(compiler).join(relative_libdir)
711 _ => self.sysroot(compiler).join(libdir(compiler.host)),
716 /// Returns the compiler's relative libdir where it stores the dynamic libraries that
717 /// it itself links against.
719 /// For example this returns `lib` on Unix and `bin` on
721 pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
722 if compiler.is_snapshot(self) {
723 libdir(self.config.build).as_ref()
725 match self.config.libdir_relative() {
726 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
727 _ => libdir(compiler.host).as_ref(),
732 /// Returns the compiler's relative libdir where the standard library and other artifacts are
733 /// found for a compiler's sysroot.
735 /// For example this returns `lib` on Unix and Windows.
736 pub fn sysroot_libdir_relative(&self, compiler: Compiler) -> &Path {
737 match self.config.libdir_relative() {
738 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
739 _ if compiler.stage == 0 => &self.build.initial_libdir,
740 _ => Path::new("lib"),
744 /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
745 /// library lookup path.
746 pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
747 // Windows doesn't need dylib path munging because the dlls for the
748 // compiler live next to the compiler and the system will find them
754 let mut dylib_dirs = vec![self.rustc_libdir(compiler)];
756 // Ensure that the downloaded LLVM libraries can be found.
757 if self.config.llvm_from_ci {
758 let ci_llvm_lib = self.out.join(&*compiler.host.triple).join("ci-llvm").join("lib");
759 dylib_dirs.push(ci_llvm_lib);
762 add_dylib_path(dylib_dirs, cmd);
765 /// Gets a path to the compiler specified.
766 pub fn rustc(&self, compiler: Compiler) -> PathBuf {
767 if compiler.is_snapshot(self) {
768 self.initial_rustc.clone()
770 self.sysroot(compiler).join("bin").join(exe("rustc", compiler.host))
774 /// Gets the paths to all of the compiler's codegen backends.
775 fn codegen_backends(&self, compiler: Compiler) -> impl Iterator<Item = PathBuf> {
776 fs::read_dir(self.sysroot_codegen_backends(compiler))
779 .filter_map(Result::ok)
780 .map(|entry| entry.path())
783 pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
784 self.ensure(tool::Rustdoc { compiler })
787 pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
788 let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
789 cmd.env("RUSTC_STAGE", compiler.stage.to_string())
790 .env("RUSTC_SYSROOT", self.sysroot(compiler))
791 // Note that this is *not* the sysroot_libdir because rustdoc must be linked
792 // equivalently to rustc.
793 .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
794 .env("CFG_RELEASE_CHANNEL", &self.config.channel)
795 .env("RUSTDOC_REAL", self.rustdoc(compiler))
796 .env("RUSTC_BOOTSTRAP", "1");
798 cmd.arg("-Wrustdoc::invalid_codeblock_attributes");
800 if self.config.deny_warnings {
801 cmd.arg("-Dwarnings");
803 cmd.arg("-Znormalize-docs");
805 // Remove make-related flags that can cause jobserver problems.
806 cmd.env_remove("MAKEFLAGS");
807 cmd.env_remove("MFLAGS");
809 if let Some(linker) = self.linker(compiler.host) {
810 cmd.env("RUSTDOC_LINKER", linker);
812 if self.is_fuse_ld_lld(compiler.host) {
813 cmd.env("RUSTDOC_FUSE_LD_LLD", "1");
818 /// Return the path to `llvm-config` for the target, if it exists.
820 /// Note that this returns `None` if LLVM is disabled, or if we're in a
821 /// check build or dry-run, where there's no need to build all of LLVM.
822 fn llvm_config(&self, target: TargetSelection) -> Option<PathBuf> {
823 if self.config.llvm_enabled() && self.kind != Kind::Check && !self.config.dry_run {
824 let llvm_config = self.ensure(native::Llvm { target });
825 if llvm_config.is_file() {
826 return Some(llvm_config);
832 /// Prepares an invocation of `cargo` to be run.
834 /// This will create a `Command` that represents a pending execution of
835 /// Cargo. This cargo will be configured to use `compiler` as the actual
836 /// rustc compiler, its output will be scoped by `mode`'s output directory,
837 /// it will pass the `--target` flag for the specified `target`, and will be
838 /// executing the Cargo command `cmd`.
843 source_type: SourceType,
844 target: TargetSelection,
847 let mut cargo = Command::new(&self.initial_cargo);
848 let out_dir = self.stage_out(compiler, mode);
850 // Codegen backends are not yet tracked by -Zbinary-dep-depinfo,
851 // so we need to explicitly clear out if they've been updated.
852 for backend in self.codegen_backends(compiler) {
853 self.clear_if_dirty(&out_dir, &backend);
856 if cmd == "doc" || cmd == "rustdoc" {
857 let my_out = match mode {
858 // This is the intended out directory for compiler documentation.
859 Mode::Rustc | Mode::ToolRustc => self.compiler_doc_out(target),
860 Mode::Std => out_dir.join(target.triple).join("doc"),
861 _ => panic!("doc mode {:?} not expected", mode),
863 let rustdoc = self.rustdoc(compiler);
864 self.clear_if_dirty(&my_out, &rustdoc);
867 cargo.env("CARGO_TARGET_DIR", &out_dir).arg(cmd);
869 let profile_var = |name: &str| {
870 let profile = if self.config.rust_optimize { "RELEASE" } else { "DEV" };
871 format!("CARGO_PROFILE_{}_{}", profile, name)
874 // See comment in rustc_llvm/build.rs for why this is necessary, largely llvm-config
875 // needs to not accidentally link to libLLVM in stage0/lib.
876 cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
877 if let Some(e) = env::var_os(util::dylib_path_var()) {
878 cargo.env("REAL_LIBRARY_PATH", e);
881 // Found with `rg "init_env_logger\("`. If anyone uses `init_env_logger`
882 // from out of tree it shouldn't matter, since x.py is only used for
884 let color_logs = ["RUSTDOC_LOG_COLOR", "RUSTC_LOG_COLOR", "RUST_LOG_COLOR"];
885 match self.build.config.color {
887 cargo.arg("--color=always");
888 for log in &color_logs {
889 cargo.env(log, "always");
893 cargo.arg("--color=never");
894 for log in &color_logs {
895 cargo.env(log, "never");
898 Color::Auto => {} // nothing to do
901 if cmd != "install" {
902 cargo.arg("--target").arg(target.rustc_target_arg());
904 assert_eq!(target, compiler.host);
907 // Set a flag for `check`/`clippy`/`fix`, so that certain build
908 // scripts can do less work (i.e. not building/requiring LLVM).
909 if cmd == "check" || cmd == "clippy" || cmd == "fix" {
910 // If we've not yet built LLVM, or it's stale, then bust
911 // the rustc_llvm cache. That will always work, even though it
912 // may mean that on the next non-check build we'll need to rebuild
913 // rustc_llvm. But if LLVM is stale, that'll be a tiny amount
914 // of work comparitively, and we'd likely need to rebuild it anyway,
916 if crate::native::prebuilt_llvm_config(self, target).is_err() {
917 cargo.env("RUST_CHECK", "1");
921 let stage = if compiler.stage == 0 && self.local_rebuild {
922 // Assume the local-rebuild rustc already has stage1 features.
928 let mut rustflags = Rustflags::new(target);
930 if let Ok(s) = env::var("CARGOFLAGS_NOT_BOOTSTRAP") {
931 cargo.args(s.split_whitespace());
933 rustflags.env("RUSTFLAGS_NOT_BOOTSTRAP");
935 if let Ok(s) = env::var("CARGOFLAGS_BOOTSTRAP") {
936 cargo.args(s.split_whitespace());
938 rustflags.env("RUSTFLAGS_BOOTSTRAP");
940 // clippy overwrites sysroot if we pass it to cargo.
941 // Pass it directly to clippy instead.
942 // NOTE: this can't be fixed in clippy because we explicitly don't set `RUSTC`,
943 // so it has no way of knowing the sysroot.
944 rustflags.arg("--sysroot");
946 self.sysroot(compiler)
949 .expect("sysroot must be valid UTF-8"),
951 // Only run clippy on a very limited subset of crates (in particular, not build scripts).
952 cargo.arg("-Zunstable-options");
953 // Explicitly does *not* set `--cfg=bootstrap`, since we're using a nightly clippy.
954 let host_version = Command::new("rustc").arg("--version").output().map_err(|_| ());
955 let output = host_version.and_then(|output| {
956 if output.status.success() {
961 }).unwrap_or_else(|_| {
963 "error: `x.py clippy` requires a host `rustc` toolchain with the `clippy` component"
965 eprintln!("help: try `rustup component add clippy`");
966 std::process::exit(1);
968 if !t!(std::str::from_utf8(&output.stdout)).contains("nightly") {
969 rustflags.arg("--cfg=bootstrap");
972 rustflags.arg("--cfg=bootstrap");
976 let use_new_symbol_mangling = match self.config.rust_new_symbol_mangling {
978 // If an explicit setting is given, use that
982 if mode == Mode::Std {
983 // The standard library defaults to the legacy scheme
986 // The compiler and tools default to the new scheme
992 if use_new_symbol_mangling {
993 rustflags.arg("-Zsymbol-mangling-version=v0");
995 rustflags.arg("-Zsymbol-mangling-version=legacy");
998 // FIXME: It might be better to use the same value for both `RUSTFLAGS` and `RUSTDOCFLAGS`,
999 // but this breaks CI. At the very least, stage0 `rustdoc` needs `--cfg bootstrap`. See
1001 let mut rustdocflags = rustflags.clone();
1002 rustdocflags.propagate_cargo_env("RUSTDOCFLAGS");
1004 rustdocflags.env("RUSTDOCFLAGS_BOOTSTRAP");
1006 rustdocflags.env("RUSTDOCFLAGS_NOT_BOOTSTRAP");
1009 if let Ok(s) = env::var("CARGOFLAGS") {
1010 cargo.args(s.split_whitespace());
1014 Mode::Std | Mode::ToolBootstrap | Mode::ToolStd => {}
1015 Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
1016 // Build proc macros both for the host and the target
1017 if target != compiler.host && cmd != "check" {
1018 cargo.arg("-Zdual-proc-macros");
1019 rustflags.arg("-Zdual-proc-macros");
1024 // This tells Cargo (and in turn, rustc) to output more complete
1025 // dependency information. Most importantly for rustbuild, this
1026 // includes sysroot artifacts, like libstd, which means that we don't
1027 // need to track those in rustbuild (an error prone process!). This
1028 // feature is currently unstable as there may be some bugs and such, but
1029 // it represents a big improvement in rustbuild's reliability on
1030 // rebuilds, so we're using it here.
1032 // For some additional context, see #63470 (the PR originally adding
1033 // this), as well as #63012 which is the tracking issue for this
1034 // feature on the rustc side.
1035 cargo.arg("-Zbinary-dep-depinfo");
1037 cargo.arg("-j").arg(self.jobs().to_string());
1038 // Remove make-related flags to ensure Cargo can correctly set things up
1039 cargo.env_remove("MAKEFLAGS");
1040 cargo.env_remove("MFLAGS");
1042 // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
1043 // Force cargo to output binaries with disambiguating hashes in the name
1044 let mut metadata = if compiler.stage == 0 {
1045 // Treat stage0 like a special channel, whether it's a normal prior-
1046 // release rustc or a local rebuild with the same version, so we
1047 // never mix these libraries by accident.
1048 "bootstrap".to_string()
1050 self.config.channel.to_string()
1052 // We want to make sure that none of the dependencies between
1053 // std/test/rustc unify with one another. This is done for weird linkage
1054 // reasons but the gist of the problem is that if librustc, libtest, and
1055 // libstd all depend on libc from crates.io (which they actually do) we
1056 // want to make sure they all get distinct versions. Things get really
1057 // weird if we try to unify all these dependencies right now, namely
1058 // around how many times the library is linked in dynamic libraries and
1059 // such. If rustc were a static executable or if we didn't ship dylibs
1060 // this wouldn't be a problem, but we do, so it is. This is in general
1061 // just here to make sure things build right. If you can remove this and
1062 // things still build right, please do!
1064 Mode::Std => metadata.push_str("std"),
1065 // When we're building rustc tools, they're built with a search path
1066 // that contains things built during the rustc build. For example,
1067 // bitflags is built during the rustc build, and is a dependency of
1068 // rustdoc as well. We're building rustdoc in a different target
1069 // directory, though, which means that Cargo will rebuild the
1070 // dependency. When we go on to build rustdoc, we'll look for
1071 // bitflags, and find two different copies: one built during the
1072 // rustc step and one that we just built. This isn't always a
1073 // problem, somehow -- not really clear why -- but we know that this
1075 Mode::ToolRustc => metadata.push_str("tool-rustc"),
1076 // Same for codegen backends.
1077 Mode::Codegen => metadata.push_str("codegen"),
1080 cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
1082 if cmd == "clippy" {
1083 rustflags.arg("-Zforce-unstable-if-unmarked");
1086 rustflags.arg("-Zmacro-backtrace");
1088 let want_rustdoc = self.doc_tests != DocTests::No;
1090 // We synthetically interpret a stage0 compiler used to build tools as a
1091 // "raw" compiler in that it's the exact snapshot we download. Normally
1092 // the stage0 build means it uses libraries build by the stage0
1093 // compiler, but for tools we just use the precompiled libraries that
1095 let use_snapshot = mode == Mode::ToolBootstrap;
1096 assert!(!use_snapshot || stage == 0 || self.local_rebuild);
1098 let maybe_sysroot = self.sysroot(compiler);
1099 let sysroot = if use_snapshot { self.rustc_snapshot_sysroot() } else { &maybe_sysroot };
1100 let libdir = self.rustc_libdir(compiler);
1102 // Clear the output directory if the real rustc we're using has changed;
1103 // Cargo cannot detect this as it thinks rustc is bootstrap/debug/rustc.
1105 // Avoid doing this during dry run as that usually means the relevant
1106 // compiler is not yet linked/copied properly.
1108 // Only clear out the directory if we're compiling std; otherwise, we
1109 // should let Cargo take care of things for us (via depdep info)
1110 if !self.config.dry_run && mode == Mode::Std && cmd == "build" {
1111 self.clear_if_dirty(&out_dir, &self.rustc(compiler));
1114 // Customize the compiler we're running. Specify the compiler to cargo
1115 // as our shim and then pass it some various options used to configure
1116 // how the actual compiler itself is called.
1118 // These variables are primarily all read by
1119 // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
1121 .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
1122 .env("RUSTC_REAL", self.rustc(compiler))
1123 .env("RUSTC_STAGE", stage.to_string())
1124 .env("RUSTC_SYSROOT", &sysroot)
1125 .env("RUSTC_LIBDIR", &libdir)
1126 .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
1129 if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
1130 self.rustdoc(compiler)
1132 PathBuf::from("/path/to/nowhere/rustdoc/not/required")
1135 .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir())
1136 .env("RUSTC_BREAK_ON_ICE", "1");
1137 // Clippy support is a hack and uses the default `cargo-clippy` in path.
1138 // Don't override RUSTC so that the `cargo-clippy` in path will be run.
1139 if cmd != "clippy" {
1140 cargo.env("RUSTC", self.out.join("bootstrap/debug/rustc"));
1143 // Dealing with rpath here is a little special, so let's go into some
1144 // detail. First off, `-rpath` is a linker option on Unix platforms
1145 // which adds to the runtime dynamic loader path when looking for
1146 // dynamic libraries. We use this by default on Unix platforms to ensure
1147 // that our nightlies behave the same on Windows, that is they work out
1148 // of the box. This can be disabled, of course, but basically that's why
1149 // we're gated on RUSTC_RPATH here.
1151 // Ok, so the astute might be wondering "why isn't `-C rpath` used
1152 // here?" and that is indeed a good question to ask. This codegen
1153 // option is the compiler's current interface to generating an rpath.
1154 // Unfortunately it doesn't quite suffice for us. The flag currently
1155 // takes no value as an argument, so the compiler calculates what it
1156 // should pass to the linker as `-rpath`. This unfortunately is based on
1157 // the **compile time** directory structure which when building with
1158 // Cargo will be very different than the runtime directory structure.
1160 // All that's a really long winded way of saying that if we use
1161 // `-Crpath` then the executables generated have the wrong rpath of
1162 // something like `$ORIGIN/deps` when in fact the way we distribute
1163 // rustc requires the rpath to be `$ORIGIN/../lib`.
1165 // So, all in all, to set up the correct rpath we pass the linker
1166 // argument manually via `-C link-args=-Wl,-rpath,...`. Plus isn't it
1167 // fun to pass a flag to a tool to pass a flag to pass a flag to a tool
1168 // to change a flag in a binary?
1169 if self.config.rust_rpath && util::use_host_linker(target) {
1170 let rpath = if target.contains("apple") {
1171 // Note that we need to take one extra step on macOS to also pass
1172 // `-Wl,-instal_name,@rpath/...` to get things to work right. To
1173 // do that we pass a weird flag to the compiler to get it to do
1174 // so. Note that this is definitely a hack, and we should likely
1175 // flesh out rpath support more fully in the future.
1176 rustflags.arg("-Zosx-rpath-install-name");
1177 Some("-Wl,-rpath,@loader_path/../lib")
1178 } else if !target.contains("windows") {
1179 rustflags.arg("-Clink-args=-Wl,-z,origin");
1180 Some("-Wl,-rpath,$ORIGIN/../lib")
1184 if let Some(rpath) = rpath {
1185 rustflags.arg(&format!("-Clink-args={}", rpath));
1189 if let Some(host_linker) = self.linker(compiler.host) {
1190 cargo.env("RUSTC_HOST_LINKER", host_linker);
1192 if self.is_fuse_ld_lld(compiler.host) {
1193 cargo.env("RUSTC_HOST_FUSE_LD_LLD", "1");
1194 cargo.env("RUSTDOC_FUSE_LD_LLD", "1");
1197 if let Some(target_linker) = self.linker(target) {
1198 let target = crate::envify(&target.triple);
1199 cargo.env(&format!("CARGO_TARGET_{}_LINKER", target), target_linker);
1201 if self.is_fuse_ld_lld(target) {
1202 rustflags.arg("-Clink-args=-fuse-ld=lld");
1204 self.lld_flags(target).for_each(|flag| {
1205 rustdocflags.arg(&flag);
1208 if !(["build", "check", "clippy", "fix", "rustc"].contains(&cmd)) && want_rustdoc {
1209 cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
1212 let debuginfo_level = match mode {
1213 Mode::Rustc | Mode::Codegen => self.config.rust_debuginfo_level_rustc,
1214 Mode::Std => self.config.rust_debuginfo_level_std,
1215 Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolRustc => {
1216 self.config.rust_debuginfo_level_tools
1219 cargo.env(profile_var("DEBUG"), debuginfo_level.to_string());
1221 profile_var("DEBUG_ASSERTIONS"),
1222 if mode == Mode::Std {
1223 self.config.rust_debug_assertions_std.to_string()
1225 self.config.rust_debug_assertions.to_string()
1229 profile_var("OVERFLOW_CHECKS"),
1230 if mode == Mode::Std {
1231 self.config.rust_overflow_checks_std.to_string()
1233 self.config.rust_overflow_checks.to_string()
1237 // `dsymutil` adds time to builds on Apple platforms for no clear benefit, and also makes
1238 // it more difficult for debuggers to find debug info. The compiler currently defaults to
1239 // running `dsymutil` to preserve its historical default, but when compiling the compiler
1240 // itself, we skip it by default since we know it's safe to do so in that case.
1241 // See https://github.com/rust-lang/rust/issues/79361 for more info on this flag.
1242 if target.contains("apple") {
1243 if self.config.rust_run_dsymutil {
1244 rustflags.arg("-Csplit-debuginfo=packed");
1246 rustflags.arg("-Csplit-debuginfo=unpacked");
1250 if self.config.cmd.bless() {
1251 // Bless `expect!` tests.
1252 cargo.env("UPDATE_EXPECT", "1");
1255 if !mode.is_tool() {
1256 cargo.env("RUSTC_FORCE_UNSTABLE", "1");
1259 if let Some(x) = self.crt_static(target) {
1261 rustflags.arg("-Ctarget-feature=+crt-static");
1263 rustflags.arg("-Ctarget-feature=-crt-static");
1267 if let Some(x) = self.crt_static(compiler.host) {
1268 cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
1271 if let Some(map_to) = self.build.debuginfo_map_to(GitRepo::Rustc) {
1272 let map = format!("{}={}", self.build.src.display(), map_to);
1273 cargo.env("RUSTC_DEBUGINFO_MAP", map);
1275 // `rustc` needs to know the virtual `/rustc/$hash` we're mapping to,
1276 // in order to opportunistically reverse it later.
1277 cargo.env("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR", map_to);
1280 // Enable usage of unstable features
1281 cargo.env("RUSTC_BOOTSTRAP", "1");
1282 self.add_rust_test_threads(&mut cargo);
1284 // Almost all of the crates that we compile as part of the bootstrap may
1285 // have a build script, including the standard library. To compile a
1286 // build script, however, it itself needs a standard library! This
1287 // introduces a bit of a pickle when we're compiling the standard
1290 // To work around this we actually end up using the snapshot compiler
1291 // (stage0) for compiling build scripts of the standard library itself.
1292 // The stage0 compiler is guaranteed to have a libstd available for use.
1294 // For other crates, however, we know that we've already got a standard
1295 // library up and running, so we can use the normal compiler to compile
1296 // build scripts in that situation.
1297 if mode == Mode::Std {
1299 .env("RUSTC_SNAPSHOT", &self.initial_rustc)
1300 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1303 .env("RUSTC_SNAPSHOT", self.rustc(compiler))
1304 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1307 // Tools that use compiler libraries may inherit the `-lLLVM` link
1308 // requirement, but the `-L` library path is not propagated across
1309 // separate Cargo projects. We can add LLVM's library path to the
1310 // platform-specific environment variable as a workaround.
1311 if mode == Mode::ToolRustc || mode == Mode::Codegen {
1312 if let Some(llvm_config) = self.llvm_config(target) {
1313 let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
1314 add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cargo);
1318 // Compile everything except libraries and proc macros with the more
1319 // efficient initial-exec TLS model. This doesn't work with `dlopen`,
1320 // so we can't use it by default in general, but we can use it for tools
1321 // and our own internal libraries.
1322 if !mode.must_support_dlopen() && !target.triple.starts_with("powerpc-") {
1323 rustflags.arg("-Ztls-model=initial-exec");
1326 if self.config.incremental {
1327 cargo.env("CARGO_INCREMENTAL", "1");
1329 // Don't rely on any default setting for incr. comp. in Cargo
1330 cargo.env("CARGO_INCREMENTAL", "0");
1333 if let Some(ref on_fail) = self.config.on_fail {
1334 cargo.env("RUSTC_ON_FAIL", on_fail);
1337 if self.config.print_step_timings {
1338 cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
1341 if self.config.print_step_rusage {
1342 cargo.env("RUSTC_PRINT_STEP_RUSAGE", "1");
1345 if self.config.backtrace_on_ice {
1346 cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
1349 cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1351 if source_type == SourceType::InTree {
1352 let mut lint_flags = Vec::new();
1353 // When extending this list, add the new lints to the RUSTFLAGS of the
1354 // build_bootstrap function of src/bootstrap/bootstrap.py as well as
1355 // some code doesn't go through this `rustc` wrapper.
1356 lint_flags.push("-Wrust_2018_idioms");
1357 lint_flags.push("-Wunused_lifetimes");
1358 lint_flags.push("-Wsemicolon_in_expressions_from_macros");
1360 if self.config.deny_warnings {
1361 lint_flags.push("-Dwarnings");
1362 rustdocflags.arg("-Dwarnings");
1365 // This does not use RUSTFLAGS due to caching issues with Cargo.
1366 // Clippy is treated as an "in tree" tool, but shares the same
1367 // cache as other "submodule" tools. With these options set in
1368 // RUSTFLAGS, that causes *every* shared dependency to be rebuilt.
1369 // By injecting this into the rustc wrapper, this circumvents
1370 // Cargo's fingerprint detection. This is fine because lint flags
1371 // are always ignored in dependencies. Eventually this should be
1372 // fixed via better support from Cargo.
1373 cargo.env("RUSTC_LINT_FLAGS", lint_flags.join(" "));
1375 rustdocflags.arg("-Wrustdoc::invalid_codeblock_attributes");
1378 if mode == Mode::Rustc {
1379 rustflags.arg("-Zunstable-options");
1380 rustflags.arg("-Wrustc::internal");
1383 // Throughout the build Cargo can execute a number of build scripts
1384 // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
1385 // obtained previously to those build scripts.
1386 // Build scripts use either the `cc` crate or `configure/make` so we pass
1387 // the options through environment variables that are fetched and understood by both.
1389 // FIXME: the guard against msvc shouldn't need to be here
1390 if target.contains("msvc") {
1391 if let Some(ref cl) = self.config.llvm_clang_cl {
1392 cargo.env("CC", cl).env("CXX", cl);
1395 let ccache = self.config.ccache.as_ref();
1396 let ccacheify = |s: &Path| {
1397 let ccache = match ccache {
1399 None => return s.display().to_string(),
1401 // FIXME: the cc-rs crate only recognizes the literal strings
1402 // `ccache` and `sccache` when doing caching compilations, so we
1403 // mirror that here. It should probably be fixed upstream to
1404 // accept a new env var or otherwise work with custom ccache
1407 "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
1408 _ => s.display().to_string(),
1411 let cc = ccacheify(&self.cc(target));
1412 cargo.env(format!("CC_{}", target.triple), &cc);
1414 let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
1415 cargo.env(format!("CFLAGS_{}", target.triple), &cflags);
1417 if let Some(ar) = self.ar(target) {
1418 let ranlib = format!("{} s", ar.display());
1420 .env(format!("AR_{}", target.triple), ar)
1421 .env(format!("RANLIB_{}", target.triple), ranlib);
1424 if let Ok(cxx) = self.cxx(target) {
1425 let cxx = ccacheify(&cxx);
1427 .env(format!("CXX_{}", target.triple), &cxx)
1428 .env(format!("CXXFLAGS_{}", target.triple), cflags);
1432 if mode == Mode::Std && self.config.extended && compiler.is_final_stage(self) {
1433 rustflags.arg("-Zsave-analysis");
1435 "RUST_SAVE_ANALYSIS_CONFIG",
1436 "{\"output_file\": null,\"full_docs\": false,\
1437 \"pub_only\": true,\"reachable_only\": false,\
1438 \"distro_crate\": true,\"signatures\": false,\"borrow_data\": false}",
1442 // If Control Flow Guard is enabled, pass the `control-flow-guard` flag to rustc
1443 // when compiling the standard library, since this might be linked into the final outputs
1444 // produced by rustc. Since this mitigation is only available on Windows, only enable it
1445 // for the standard library in case the compiler is run on a non-Windows platform.
1446 // This is not needed for stage 0 artifacts because these will only be used for building
1447 // the stage 1 compiler.
1449 && mode == Mode::Std
1450 && self.config.control_flow_guard
1451 && compiler.stage >= 1
1453 rustflags.arg("-Ccontrol-flow-guard");
1456 // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1457 // This replaces spaces with newlines because RUSTDOCFLAGS does not
1458 // support arguments with regular spaces. Hopefully someday Cargo will
1459 // have space support.
1460 let rust_version = self.rust_version().replace(' ', "\n");
1461 rustdocflags.arg("--crate-version").arg(&rust_version);
1463 // Environment variables *required* throughout the build
1465 // FIXME: should update code to not require this env var
1466 cargo.env("CFG_COMPILER_HOST_TRIPLE", target.triple);
1468 // Set this for all builds to make sure doc builds also get it.
1469 cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1471 // This one's a bit tricky. As of the time of this writing the compiler
1472 // links to the `winapi` crate on crates.io. This crate provides raw
1473 // bindings to Windows system functions, sort of like libc does for
1474 // Unix. This crate also, however, provides "import libraries" for the
1475 // MinGW targets. There's an import library per dll in the windows
1476 // distribution which is what's linked to. These custom import libraries
1477 // are used because the winapi crate can reference Windows functions not
1478 // present in the MinGW import libraries.
1480 // For example MinGW may ship libdbghelp.a, but it may not have
1481 // references to all the functions in the dbghelp dll. Instead the
1482 // custom import library for dbghelp in the winapi crates has all this
1485 // Unfortunately for us though the import libraries are linked by
1486 // default via `-ldylib=winapi_foo`. That is, they're linked with the
1487 // `dylib` type with a `winapi_` prefix (so the winapi ones don't
1488 // conflict with the system MinGW ones). This consequently means that
1489 // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1490 // DLL) when linked against *again*, for example with procedural macros
1491 // or plugins, will trigger the propagation logic of `-ldylib`, passing
1492 // `-lwinapi_foo` to the linker again. This isn't actually available in
1493 // our distribution, however, so the link fails.
1495 // To solve this problem we tell winapi to not use its bundled import
1496 // libraries. This means that it will link to the system MinGW import
1497 // libraries by default, and the `-ldylib=foo` directives will still get
1498 // passed to the final linker, but they'll look like `-lfoo` which can
1499 // be resolved because MinGW has the import library. The downside is we
1500 // don't get newer functions from Windows, but we don't use any of them
1502 if !mode.is_tool() {
1503 cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
1506 for _ in 0..self.verbosity {
1510 match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
1511 (Mode::Std, Some(n), _) | (_, _, Some(n)) => {
1512 cargo.env(profile_var("CODEGEN_UNITS"), n.to_string());
1515 // Don't set anything
1519 if self.config.rust_optimize {
1520 // FIXME: cargo bench/install do not accept `--release`
1521 if cmd != "bench" && cmd != "install" {
1522 cargo.arg("--release");
1526 if self.config.locked_deps {
1527 cargo.arg("--locked");
1529 if self.config.vendor || self.is_sudo {
1530 cargo.arg("--frozen");
1533 // Try to use a sysroot-relative bindir, in case it was configured absolutely.
1534 cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
1536 self.ci_env.force_coloring_in_ci(&mut cargo);
1538 // When we build Rust dylibs they're all intended for intermediate
1539 // usage, so make sure we pass the -Cprefer-dynamic flag instead of
1540 // linking all deps statically into the dylib.
1541 if matches!(mode, Mode::Std | Mode::Rustc) {
1542 rustflags.arg("-Cprefer-dynamic");
1545 // When building incrementally we default to a lower ThinLTO import limit
1546 // (unless explicitly specified otherwise). This will produce a somewhat
1547 // slower code but give way better compile times.
1549 let limit = match self.config.rust_thin_lto_import_instr_limit {
1550 Some(limit) => Some(limit),
1551 None if self.config.incremental => Some(10),
1555 if let Some(limit) = limit {
1556 rustflags.arg(&format!("-Cllvm-args=-import-instr-limit={}", limit));
1560 Cargo { command: cargo, rustflags, rustdocflags }
1563 /// Ensure that a given step is built, returning its output. This will
1564 /// cache the step, so it is safe (and good!) to call this as often as
1565 /// needed to ensure that all dependencies are built.
1566 pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1568 let mut stack = self.stack.borrow_mut();
1569 for stack_step in stack.iter() {
1571 if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
1574 let mut out = String::new();
1575 out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1576 for el in stack.iter().rev() {
1577 out += &format!("\t{:?}\n", el);
1581 if let Some(out) = self.cache.get(&step) {
1582 self.verbose_than(1, &format!("{}c {:?}", " ".repeat(stack.len()), step));
1586 self.verbose_than(1, &format!("{}> {:?}", " ".repeat(stack.len()), step));
1587 stack.push(Box::new(step.clone()));
1591 let start = Instant::now();
1592 let zero = Duration::new(0, 0);
1593 let parent = self.time_spent_on_dependencies.replace(zero);
1594 let out = step.clone().run(self);
1595 let dur = start.elapsed();
1596 let deps = self.time_spent_on_dependencies.replace(parent + dur);
1600 if self.config.print_step_timings && !self.config.dry_run {
1601 println!("[TIMING] {:?} -- {}.{:03}", step, dur.as_secs(), dur.subsec_millis());
1605 let mut stack = self.stack.borrow_mut();
1606 let cur_step = stack.pop().expect("step stack empty");
1607 assert_eq!(cur_step.downcast_ref(), Some(&step));
1609 self.verbose_than(1, &format!("{}< {:?}", " ".repeat(self.stack.borrow().len()), step));
1610 self.cache.put(step, out.clone());
1614 /// Ensure that a given step is built *only if it's supposed to be built by default*, returning
1615 /// its output. This will cache the step, so it's safe (and good!) to call this as often as
1616 /// needed to ensure that all dependencies are build.
1617 pub(crate) fn ensure_if_default<T, S: Step<Output = Option<T>>>(
1621 let desc = StepDescription::from::<S>();
1622 let should_run = (desc.should_run)(ShouldRun::new(self));
1624 // Avoid running steps contained in --exclude
1625 for pathset in &should_run.paths {
1626 if desc.is_excluded(self, pathset) {
1631 // Only execute if it's supposed to run as default
1632 if desc.default && should_run.is_really_default() { self.ensure(step) } else { None }
1635 /// Checks if any of the "should_run" paths is in the `Builder` paths.
1636 pub(crate) fn was_invoked_explicitly<S: Step>(&'a self) -> bool {
1637 let desc = StepDescription::from::<S>();
1638 let should_run = (desc.should_run)(ShouldRun::new(self));
1640 for path in &self.paths {
1641 if should_run.paths.iter().any(|s| s.has(path))
1642 && !desc.is_excluded(self, &PathSet::Suite(path.clone()))
1655 #[derive(Debug, Clone)]
1656 struct Rustflags(String, TargetSelection);
1659 fn new(target: TargetSelection) -> Rustflags {
1660 let mut ret = Rustflags(String::new(), target);
1661 ret.propagate_cargo_env("RUSTFLAGS");
1665 /// By default, cargo will pick up on various variables in the environment. However, bootstrap
1666 /// reuses those variables to pass additional flags to rustdoc, so by default they get overriden.
1667 /// Explicitly add back any previous value in the environment.
1669 /// `prefix` is usually `RUSTFLAGS` or `RUSTDOCFLAGS`.
1670 fn propagate_cargo_env(&mut self, prefix: &str) {
1671 // Inherit `RUSTFLAGS` by default ...
1674 // ... and also handle target-specific env RUSTFLAGS if they're configured.
1675 let target_specific = format!("CARGO_TARGET_{}_{}", crate::envify(&self.1.triple), prefix);
1676 self.env(&target_specific);
1679 fn env(&mut self, env: &str) {
1680 if let Ok(s) = env::var(env) {
1681 for part in s.split(' ') {
1687 fn arg(&mut self, arg: &str) -> &mut Self {
1688 assert_eq!(arg.split(' ').count(), 1);
1689 if !self.0.is_empty() {
1692 self.0.push_str(arg);
1700 rustflags: Rustflags,
1701 rustdocflags: Rustflags,
1705 pub fn rustdocflag(&mut self, arg: &str) -> &mut Cargo {
1706 self.rustdocflags.arg(arg);
1709 pub fn rustflag(&mut self, arg: &str) -> &mut Cargo {
1710 self.rustflags.arg(arg);
1714 pub fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Cargo {
1715 self.command.arg(arg.as_ref());
1719 pub fn args<I, S>(&mut self, args: I) -> &mut Cargo
1721 I: IntoIterator<Item = S>,
1725 self.arg(arg.as_ref());
1730 pub fn env(&mut self, key: impl AsRef<OsStr>, value: impl AsRef<OsStr>) -> &mut Cargo {
1731 // These are managed through rustflag/rustdocflag interfaces.
1732 assert_ne!(key.as_ref(), "RUSTFLAGS");
1733 assert_ne!(key.as_ref(), "RUSTDOCFLAGS");
1734 self.command.env(key.as_ref(), value.as_ref());
1738 pub fn add_rustc_lib_path(&mut self, builder: &Builder<'_>, compiler: Compiler) {
1739 builder.add_rustc_lib_path(compiler, &mut self.command);
1742 pub fn current_dir(&mut self, dir: &Path) -> &mut Cargo {
1743 self.command.current_dir(dir);
1748 impl From<Cargo> for Command {
1749 fn from(mut cargo: Cargo) -> Command {
1750 let rustflags = &cargo.rustflags.0;
1751 if !rustflags.is_empty() {
1752 cargo.command.env("RUSTFLAGS", rustflags);
1755 let rustdocflags = &cargo.rustdocflags.0;
1756 if !rustdocflags.is_empty() {
1757 cargo.command.env("RUSTDOCFLAGS", rustdocflags);