2 use std::cell::{Cell, RefCell};
3 use std::collections::BTreeSet;
10 use std::path::{Path, PathBuf};
11 use std::process::Command;
12 use std::time::{Duration, Instant};
14 use build_helper::{output, t};
16 use crate::cache::{Cache, Interned, INTERNER};
19 use crate::config::TargetSelection;
22 use crate::flags::Subcommand;
27 use crate::tool::{self, SourceType};
28 use crate::util::{self, add_dylib_path, add_link_lib_path, exe, libdir};
29 use crate::{Build, DocTests, GitRepo, Mode};
31 pub use crate::Compiler;
33 pub struct Builder<'a> {
38 stack: RefCell<Vec<Box<dyn Any>>>,
39 time_spent_on_dependencies: Cell<Duration>,
40 pub paths: Vec<PathBuf>,
43 impl<'a> Deref for Builder<'a> {
46 fn deref(&self) -> &Self::Target {
51 pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
52 /// `PathBuf` when directories are created or to return a `Compiler` once
53 /// it's been assembled.
56 /// Whether this step is run by default as part of its respective phase.
57 /// `true` here can still be overwritten by `should_run` calling `default_condition`.
58 const DEFAULT: bool = false;
60 /// If true, then this rule should be skipped if --target was specified, but --host was not
61 const ONLY_HOSTS: bool = false;
63 /// Primary function to execute this rule. Can call `builder.ensure()`
64 /// with other steps to run those.
65 fn run(self, builder: &Builder<'_>) -> Self::Output;
67 /// When bootstrap is passed a set of paths, this controls whether this rule
68 /// will execute. However, it does not get called in a "default" context
69 /// when we are not passed any paths; in that case, `make_run` is called
71 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
73 /// Builds up a "root" rule, either as a default rule or from a path passed
76 /// When path is `None`, we are executing in a context where no paths were
77 /// passed. When `./x.py build` is run, for example, this rule could get
78 /// called if it is in the correct list below with a path of `None`.
79 fn make_run(_run: RunConfig<'_>) {
80 // It is reasonable to not have an implementation of make_run for rules
81 // who do not want to get called from the root context. This means that
82 // they are likely dependencies (e.g., sysroot creation) or similar, and
83 // as such calling them from ./x.py isn't logical.
88 pub struct RunConfig<'a> {
89 pub builder: &'a Builder<'a>,
90 pub host: TargetSelection,
91 pub target: TargetSelection,
95 struct StepDescription {
98 should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
99 make_run: fn(RunConfig<'_>),
103 /// Collection of paths used to match a task rule.
104 #[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
106 /// A collection of individual paths.
108 /// These are generally matched as a path suffix. For example, a
109 /// command-line value of `libstd` will match if `src/libstd` is in the
111 Set(BTreeSet<PathBuf>),
112 /// A "suite" of paths.
114 /// These can match as a path suffix (like `Set`), or as a prefix. For
115 /// example, a command-line value of `src/test/ui/abi/variadic-ffi.rs`
116 /// will match `src/test/ui`. A command-line value of `ui` would also
117 /// match `src/test/ui`.
122 fn empty() -> PathSet {
123 PathSet::Set(BTreeSet::new())
126 fn one<P: Into<PathBuf>>(path: P) -> PathSet {
127 let mut set = BTreeSet::new();
128 set.insert(path.into());
132 fn has(&self, needle: &Path) -> bool {
134 PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
135 PathSet::Suite(suite) => suite.ends_with(needle),
139 fn path(&self, builder: &Builder<'_>) -> PathBuf {
141 PathSet::Set(set) => set.iter().next().unwrap_or(&builder.build.src).to_path_buf(),
142 PathSet::Suite(path) => PathBuf::from(path),
147 impl StepDescription {
148 fn from<S: Step>() -> StepDescription {
151 only_hosts: S::ONLY_HOSTS,
152 should_run: S::should_run,
153 make_run: S::make_run,
154 name: std::any::type_name::<S>(),
158 fn maybe_run(&self, builder: &Builder<'_>, pathset: &PathSet) {
159 if builder.config.exclude.iter().any(|e| pathset.has(e)) {
160 eprintln!("Skipping {:?} because it is excluded", pathset);
162 } else if !builder.config.exclude.is_empty() {
164 "{:?} not skipped for {:?} -- not in {:?}",
165 pathset, self.name, builder.config.exclude
168 let hosts = &builder.hosts;
170 // Determine the targets participating in this rule.
171 let targets = if self.only_hosts {
172 if builder.config.skip_only_host_steps {
173 return; // don't run anything
182 for target in targets {
183 let run = RunConfig {
185 path: pathset.path(builder),
189 (self.make_run)(run);
194 fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
196 v.iter().map(|desc| (desc.should_run)(ShouldRun::new(builder))).collect::<Vec<_>>();
198 // sanity checks on rules
199 for (desc, should_run) in v.iter().zip(&should_runs) {
201 !should_run.paths.is_empty(),
202 "{:?} should have at least one pathset",
207 if paths.is_empty() {
208 for (desc, should_run) in v.iter().zip(should_runs) {
209 if desc.default && should_run.is_really_default {
210 for pathset in &should_run.paths {
211 desc.maybe_run(builder, pathset);
217 // strip CurDir prefix if present
218 let path = match path.strip_prefix(".") {
223 let mut attempted_run = false;
224 for (desc, should_run) in v.iter().zip(&should_runs) {
225 if let Some(suite) = should_run.is_suite_path(path) {
226 attempted_run = true;
227 desc.maybe_run(builder, suite);
228 } else if let Some(pathset) = should_run.pathset_for_path(path) {
229 attempted_run = true;
230 desc.maybe_run(builder, pathset);
235 panic!("error: no rules matched {}", path.display());
243 pub struct ShouldRun<'a> {
244 pub builder: &'a Builder<'a>,
245 // use a BTreeSet to maintain sort order
246 paths: BTreeSet<PathSet>,
248 // If this is a default rule, this is an additional constraint placed on
249 // its run. Generally something like compiler docs being enabled.
250 is_really_default: bool,
253 impl<'a> ShouldRun<'a> {
254 fn new(builder: &'a Builder<'_>) -> ShouldRun<'a> {
257 paths: BTreeSet::new(),
258 is_really_default: true, // by default no additional conditions
262 pub fn default_condition(mut self, cond: bool) -> Self {
263 self.is_really_default = cond;
267 /// Indicates it should run if the command-line selects the given crate or
268 /// any of its (local) dependencies.
270 /// Compared to `krate`, this treats the dependencies as aliases for the
271 /// same job. Generally it is preferred to use `krate`, and treat each
272 /// individual path separately. For example `./x.py test src/liballoc`
273 /// (which uses `krate`) will test just `liballoc`. However, `./x.py check
274 /// src/liballoc` (which uses `all_krates`) will check all of `libtest`.
275 /// `all_krates` should probably be removed at some point.
276 pub fn all_krates(mut self, name: &str) -> Self {
277 let mut set = BTreeSet::new();
278 for krate in self.builder.in_tree_crates(name) {
279 let path = krate.local_path(self.builder);
282 self.paths.insert(PathSet::Set(set));
286 /// Indicates it should run if the command-line selects the given crate or
287 /// any of its (local) dependencies.
289 /// `make_run` will be called separately for each matching command-line path.
290 pub fn krate(mut self, name: &str) -> Self {
291 for krate in self.builder.in_tree_crates(name) {
292 let path = krate.local_path(self.builder);
293 self.paths.insert(PathSet::one(path));
298 // single, non-aliased path
299 pub fn path(self, path: &str) -> Self {
303 // multiple aliases for the same job
304 pub fn paths(mut self, paths: &[&str]) -> Self {
305 self.paths.insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
309 pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
310 self.paths.iter().find(|pathset| match pathset {
311 PathSet::Suite(p) => path.starts_with(p),
312 PathSet::Set(_) => false,
316 pub fn suite_path(mut self, suite: &str) -> Self {
317 self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
321 // allows being more explicit about why should_run in Step returns the value passed to it
322 pub fn never(mut self) -> ShouldRun<'a> {
323 self.paths.insert(PathSet::empty());
327 fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
328 self.paths.iter().find(|pathset| pathset.has(path))
332 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
347 impl<'a> Builder<'a> {
348 fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
349 macro_rules! describe {
350 ($($rule:ty),+ $(,)?) => {{
351 vec![$(StepDescription::from::<$rule>()),+]
355 Kind::Build => describe!(
358 compile::StartupObjects,
362 tool::UnstableBookGen,
367 tool::RemoteTestServer,
368 tool::RemoteTestClient,
384 Kind::Check | Kind::Clippy | Kind::Fix | Kind::Format => {
385 describe!(check::Std, check::Rustc, check::Rustdoc, check::Clippy)
387 Kind::Test => describe!(
388 crate::toolstate::ToolStateCheck,
389 test::ExpandYamlAnchors,
393 test::RunPassValgrind,
413 test::RunMakeFullDeps,
427 test::CompiletestTest,
429 test::RustdocJSNotStd,
432 // Run bootstrap close to the end as it's unlikely to fail
434 // Run run-make last, since these won't pass without make on Windows
437 Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
438 Kind::Doc => describe!(
440 doc::UnstableBookGen,
456 Kind::Dist => describe!(
461 dist::DebuggerScripts,
466 dist::PlainSourceTarball,
477 Kind::Install => describe!(
482 install::RustAnalyzer,
490 Kind::Run => describe!(run::ExpandYamlAnchors,),
494 pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
495 let kind = match subcommand {
496 "build" => Kind::Build,
498 "test" => Kind::Test,
499 "bench" => Kind::Bench,
500 "dist" => Kind::Dist,
501 "install" => Kind::Install,
505 let builder = Self::new_internal(build, kind, vec![]);
506 let builder = &builder;
507 let mut should_run = ShouldRun::new(builder);
508 for desc in Builder::get_step_descriptions(builder.kind) {
509 should_run = (desc.should_run)(should_run);
511 let mut help = String::from("Available paths:\n");
512 let mut add_path = |path: &Path| {
513 help.push_str(&format!(" ./x.py {} {}\n", subcommand, path.display()));
515 for pathset in should_run.paths {
517 PathSet::Set(set) => {
522 PathSet::Suite(path) => {
523 add_path(&path.join("..."));
530 fn new_internal(build: &Build, kind: Kind, paths: Vec<PathBuf>) -> Builder<'_> {
531 let top_stage = if let Some(explicit_stage) = build.config.stage {
534 // See https://github.com/rust-lang/compiler-team/issues/326
537 Kind::Build | Kind::Test => 1,
538 Kind::Bench | Kind::Dist | Kind::Install => 2,
539 // These are all bootstrap tools, which don't depend on the compiler.
540 // The stage we pass shouldn't matter, but use 0 just in case.
541 Kind::Check | Kind::Clippy | Kind::Fix | Kind::Run | Kind::Format => 0,
550 stack: RefCell::new(Vec::new()),
551 time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
556 pub fn new(build: &Build) -> Builder<'_> {
557 let (kind, paths) = match build.config.cmd {
558 Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
559 Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
560 Subcommand::Clippy { ref paths } => (Kind::Clippy, &paths[..]),
561 Subcommand::Fix { ref paths } => (Kind::Fix, &paths[..]),
562 Subcommand::Doc { ref paths, .. } => (Kind::Doc, &paths[..]),
563 Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
564 Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
565 Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
566 Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
567 Subcommand::Run { ref paths } => (Kind::Run, &paths[..]),
568 Subcommand::Format { .. } | Subcommand::Clean { .. } => panic!(),
571 let this = Self::new_internal(build, kind, paths.to_owned());
573 // CI should always run stage 2 builds, unless it specifically states otherwise
575 if build.config.stage.is_none() && build.ci_env != crate::CiEnv::None {
577 Kind::Test | Kind::Doc | Kind::Build | Kind::Bench | Kind::Dist | Kind::Install => {
578 assert_eq!(this.top_stage, 2)
580 Kind::Check | Kind::Clippy | Kind::Fix | Kind::Run | Kind::Format => {}
587 pub fn execute_cli(&self) {
588 self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
591 pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
592 let paths = paths.unwrap_or(&[]);
593 self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
596 fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
597 StepDescription::run(v, self, paths);
600 /// Obtain a compiler at a given stage and for a given host. Explicitly does
601 /// not take `Compiler` since all `Compiler` instances are meant to be
602 /// obtained through this function, since it ensures that they are valid
603 /// (i.e., built and assembled).
604 pub fn compiler(&self, stage: u32, host: TargetSelection) -> Compiler {
605 self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
608 /// Similar to `compiler`, except handles the full-bootstrap option to
609 /// silently use the stage1 compiler instead of a stage2 compiler if one is
612 /// Note that this does *not* have the side effect of creating
613 /// `compiler(stage, host)`, unlike `compiler` above which does have such
614 /// a side effect. The returned compiler here can only be used to compile
615 /// new artifacts, it can't be used to rely on the presence of a particular
618 /// See `force_use_stage1` for documentation on what each argument is.
622 host: TargetSelection,
623 target: TargetSelection,
625 if self.build.force_use_stage1(Compiler { stage, host }, target) {
626 self.compiler(1, self.config.build)
628 self.compiler(stage, host)
632 pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
633 self.ensure(compile::Sysroot { compiler })
636 /// Returns the libdir where the standard library and other artifacts are
637 /// found for a compiler's sysroot.
638 pub fn sysroot_libdir(&self, compiler: Compiler, target: TargetSelection) -> Interned<PathBuf> {
639 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
642 target: TargetSelection,
644 impl Step for Libdir {
645 type Output = Interned<PathBuf>;
647 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
651 fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
652 let lib = builder.sysroot_libdir_relative(self.compiler);
653 let sysroot = builder
654 .sysroot(self.compiler)
657 .join(self.target.triple)
659 let _ = fs::remove_dir_all(&sysroot);
660 t!(fs::create_dir_all(&sysroot));
661 INTERNER.intern_path(sysroot)
664 self.ensure(Libdir { compiler, target })
667 /// Returns the compiler's libdir where it stores the dynamic libraries that
668 /// it itself links against.
670 /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
672 pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
673 if compiler.is_snapshot(self) {
674 self.rustc_snapshot_libdir()
676 match self.config.libdir_relative() {
677 Some(relative_libdir) if compiler.stage >= 1 => {
678 self.sysroot(compiler).join(relative_libdir)
680 _ => self.sysroot(compiler).join(libdir(compiler.host)),
685 /// Returns the compiler's relative libdir where it stores the dynamic libraries that
686 /// it itself links against.
688 /// For example this returns `lib` on Unix and `bin` on
690 pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
691 if compiler.is_snapshot(self) {
692 libdir(self.config.build).as_ref()
694 match self.config.libdir_relative() {
695 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
696 _ => libdir(compiler.host).as_ref(),
701 /// Returns the compiler's relative libdir where the standard library and other artifacts are
702 /// found for a compiler's sysroot.
704 /// For example this returns `lib` on Unix and Windows.
705 pub fn sysroot_libdir_relative(&self, compiler: Compiler) -> &Path {
706 match self.config.libdir_relative() {
707 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
708 _ if compiler.stage == 0 => &self.build.initial_libdir,
709 _ => Path::new("lib"),
713 /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
714 /// library lookup path.
715 pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Cargo) {
716 // Windows doesn't need dylib path munging because the dlls for the
717 // compiler live next to the compiler and the system will find them
723 add_dylib_path(vec![self.rustc_libdir(compiler)], &mut cmd.command);
726 /// Gets a path to the compiler specified.
727 pub fn rustc(&self, compiler: Compiler) -> PathBuf {
728 if compiler.is_snapshot(self) {
729 self.initial_rustc.clone()
731 self.sysroot(compiler).join("bin").join(exe("rustc", compiler.host))
735 pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
736 self.ensure(tool::Rustdoc { compiler })
739 pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
740 let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
741 cmd.env("RUSTC_STAGE", compiler.stage.to_string())
742 .env("RUSTC_SYSROOT", self.sysroot(compiler))
743 // Note that this is *not* the sysroot_libdir because rustdoc must be linked
744 // equivalently to rustc.
745 .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
746 .env("CFG_RELEASE_CHANNEL", &self.config.channel)
747 .env("RUSTDOC_REAL", self.rustdoc(compiler))
748 .env("RUSTC_BOOTSTRAP", "1")
749 .arg("-Winvalid_codeblock_attributes");
750 if self.config.deny_warnings {
751 cmd.arg("-Dwarnings");
754 // Remove make-related flags that can cause jobserver problems.
755 cmd.env_remove("MAKEFLAGS");
756 cmd.env_remove("MFLAGS");
758 if let Some(linker) = self.linker(compiler.host, true) {
759 cmd.env("RUSTC_TARGET_LINKER", linker);
764 /// Return the path to `llvm-config` for the target, if it exists.
766 /// Note that this returns `None` if LLVM is disabled, or if we're in a
767 /// check build or dry-run, where there's no need to build all of LLVM.
768 fn llvm_config(&self, target: TargetSelection) -> Option<PathBuf> {
769 if self.config.llvm_enabled() && self.kind != Kind::Check && !self.config.dry_run {
770 let llvm_config = self.ensure(native::Llvm { target });
771 if llvm_config.is_file() {
772 return Some(llvm_config);
778 /// Prepares an invocation of `cargo` to be run.
780 /// This will create a `Command` that represents a pending execution of
781 /// Cargo. This cargo will be configured to use `compiler` as the actual
782 /// rustc compiler, its output will be scoped by `mode`'s output directory,
783 /// it will pass the `--target` flag for the specified `target`, and will be
784 /// executing the Cargo command `cmd`.
789 source_type: SourceType,
790 target: TargetSelection,
793 let mut cargo = Command::new(&self.initial_cargo);
794 let out_dir = self.stage_out(compiler, mode);
796 if cmd == "doc" || cmd == "rustdoc" {
797 let my_out = match mode {
798 // This is the intended out directory for compiler documentation.
799 Mode::Rustc | Mode::ToolRustc | Mode::Codegen => self.compiler_doc_out(target),
800 Mode::Std => out_dir.join(target.triple).join("doc"),
801 _ => panic!("doc mode {:?} not expected", mode),
803 let rustdoc = self.rustdoc(compiler);
804 self.clear_if_dirty(&my_out, &rustdoc);
807 cargo.env("CARGO_TARGET_DIR", &out_dir).arg(cmd);
809 let profile_var = |name: &str| {
810 let profile = if self.config.rust_optimize { "RELEASE" } else { "DEV" };
811 format!("CARGO_PROFILE_{}_{}", profile, name)
814 // See comment in librustc_llvm/build.rs for why this is necessary, largely llvm-config
815 // needs to not accidentally link to libLLVM in stage0/lib.
816 cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
817 if let Some(e) = env::var_os(util::dylib_path_var()) {
818 cargo.env("REAL_LIBRARY_PATH", e);
821 if cmd != "install" {
822 cargo.arg("--target").arg(target.rustc_target_arg());
824 assert_eq!(target, compiler.host);
827 // Set a flag for `check`/`clippy`/`fix`, so that certain build
828 // scripts can do less work (i.e. not building/requiring LLVM).
829 if cmd == "check" || cmd == "clippy" || cmd == "fix" {
830 // If we've not yet built LLVM, or it's stale, then bust
831 // the librustc_llvm cache. That will always work, even though it
832 // may mean that on the next non-check build we'll need to rebuild
833 // librustc_llvm. But if LLVM is stale, that'll be a tiny amount
834 // of work comparitively, and we'd likely need to rebuild it anyway,
836 if crate::native::prebuilt_llvm_config(self, target).is_err() {
837 cargo.env("RUST_CHECK", "1");
841 let stage = if compiler.stage == 0 && self.local_rebuild {
842 // Assume the local-rebuild rustc already has stage1 features.
848 let mut rustflags = Rustflags::new(target);
850 if let Ok(s) = env::var("CARGOFLAGS_NOT_BOOTSTRAP") {
851 cargo.args(s.split_whitespace());
853 rustflags.env("RUSTFLAGS_NOT_BOOTSTRAP");
855 if let Ok(s) = env::var("CARGOFLAGS_BOOTSTRAP") {
856 cargo.args(s.split_whitespace());
858 rustflags.env("RUSTFLAGS_BOOTSTRAP");
859 rustflags.arg("--cfg=bootstrap");
862 if self.config.rust_new_symbol_mangling {
863 rustflags.arg("-Zsymbol-mangling-version=v0");
866 // FIXME: It might be better to use the same value for both `RUSTFLAGS` and `RUSTDOCFLAGS`,
867 // but this breaks CI. At the very least, stage0 `rustdoc` needs `--cfg bootstrap`. See
869 let mut rustdocflags = rustflags.clone();
871 if let Ok(s) = env::var("CARGOFLAGS") {
872 cargo.args(s.split_whitespace());
876 Mode::Std | Mode::ToolBootstrap | Mode::ToolStd => {}
877 Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
878 // Build proc macros both for the host and the target
879 if target != compiler.host && cmd != "check" {
880 cargo.arg("-Zdual-proc-macros");
881 rustflags.arg("-Zdual-proc-macros");
886 // This tells Cargo (and in turn, rustc) to output more complete
887 // dependency information. Most importantly for rustbuild, this
888 // includes sysroot artifacts, like libstd, which means that we don't
889 // need to track those in rustbuild (an error prone process!). This
890 // feature is currently unstable as there may be some bugs and such, but
891 // it represents a big improvement in rustbuild's reliability on
892 // rebuilds, so we're using it here.
894 // For some additional context, see #63470 (the PR originally adding
895 // this), as well as #63012 which is the tracking issue for this
896 // feature on the rustc side.
897 cargo.arg("-Zbinary-dep-depinfo");
899 cargo.arg("-j").arg(self.jobs().to_string());
900 // Remove make-related flags to ensure Cargo can correctly set things up
901 cargo.env_remove("MAKEFLAGS");
902 cargo.env_remove("MFLAGS");
904 // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
905 // Force cargo to output binaries with disambiguating hashes in the name
906 let mut metadata = if compiler.stage == 0 {
907 // Treat stage0 like a special channel, whether it's a normal prior-
908 // release rustc or a local rebuild with the same version, so we
909 // never mix these libraries by accident.
910 "bootstrap".to_string()
912 self.config.channel.to_string()
914 // We want to make sure that none of the dependencies between
915 // std/test/rustc unify with one another. This is done for weird linkage
916 // reasons but the gist of the problem is that if librustc, libtest, and
917 // libstd all depend on libc from crates.io (which they actually do) we
918 // want to make sure they all get distinct versions. Things get really
919 // weird if we try to unify all these dependencies right now, namely
920 // around how many times the library is linked in dynamic libraries and
921 // such. If rustc were a static executable or if we didn't ship dylibs
922 // this wouldn't be a problem, but we do, so it is. This is in general
923 // just here to make sure things build right. If you can remove this and
924 // things still build right, please do!
926 Mode::Std => metadata.push_str("std"),
927 // When we're building rustc tools, they're built with a search path
928 // that contains things built during the rustc build. For example,
929 // bitflags is built during the rustc build, and is a dependency of
930 // rustdoc as well. We're building rustdoc in a different target
931 // directory, though, which means that Cargo will rebuild the
932 // dependency. When we go on to build rustdoc, we'll look for
933 // bitflags, and find two different copies: one built during the
934 // rustc step and one that we just built. This isn't always a
935 // problem, somehow -- not really clear why -- but we know that this
937 Mode::ToolRustc => metadata.push_str("tool-rustc"),
940 cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
943 rustflags.arg("-Zforce-unstable-if-unmarked");
946 rustflags.arg("-Zmacro-backtrace");
948 let want_rustdoc = self.doc_tests != DocTests::No;
950 // We synthetically interpret a stage0 compiler used to build tools as a
951 // "raw" compiler in that it's the exact snapshot we download. Normally
952 // the stage0 build means it uses libraries build by the stage0
953 // compiler, but for tools we just use the precompiled libraries that
955 let use_snapshot = mode == Mode::ToolBootstrap;
956 assert!(!use_snapshot || stage == 0 || self.local_rebuild);
958 let maybe_sysroot = self.sysroot(compiler);
959 let sysroot = if use_snapshot { self.rustc_snapshot_sysroot() } else { &maybe_sysroot };
960 let libdir = self.rustc_libdir(compiler);
962 // Clear the output directory if the real rustc we're using has changed;
963 // Cargo cannot detect this as it thinks rustc is bootstrap/debug/rustc.
965 // Avoid doing this during dry run as that usually means the relevant
966 // compiler is not yet linked/copied properly.
968 // Only clear out the directory if we're compiling std; otherwise, we
969 // should let Cargo take care of things for us (via depdep info)
970 if !self.config.dry_run && mode == Mode::Std && cmd == "build" {
971 self.clear_if_dirty(&out_dir, &self.rustc(compiler));
974 // Customize the compiler we're running. Specify the compiler to cargo
975 // as our shim and then pass it some various options used to configure
976 // how the actual compiler itself is called.
978 // These variables are primarily all read by
979 // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
981 .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
982 .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
983 .env("RUSTC_REAL", self.rustc(compiler))
984 .env("RUSTC_STAGE", stage.to_string())
985 .env("RUSTC_SYSROOT", &sysroot)
986 .env("RUSTC_LIBDIR", &libdir)
987 .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
990 if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
991 self.rustdoc(compiler)
993 PathBuf::from("/path/to/nowhere/rustdoc/not/required")
996 .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir())
997 .env("RUSTC_BREAK_ON_ICE", "1");
999 // Dealing with rpath here is a little special, so let's go into some
1000 // detail. First off, `-rpath` is a linker option on Unix platforms
1001 // which adds to the runtime dynamic loader path when looking for
1002 // dynamic libraries. We use this by default on Unix platforms to ensure
1003 // that our nightlies behave the same on Windows, that is they work out
1004 // of the box. This can be disabled, of course, but basically that's why
1005 // we're gated on RUSTC_RPATH here.
1007 // Ok, so the astute might be wondering "why isn't `-C rpath` used
1008 // here?" and that is indeed a good question to ask. This codegen
1009 // option is the compiler's current interface to generating an rpath.
1010 // Unfortunately it doesn't quite suffice for us. The flag currently
1011 // takes no value as an argument, so the compiler calculates what it
1012 // should pass to the linker as `-rpath`. This unfortunately is based on
1013 // the **compile time** directory structure which when building with
1014 // Cargo will be very different than the runtime directory structure.
1016 // All that's a really long winded way of saying that if we use
1017 // `-Crpath` then the executables generated have the wrong rpath of
1018 // something like `$ORIGIN/deps` when in fact the way we distribute
1019 // rustc requires the rpath to be `$ORIGIN/../lib`.
1021 // So, all in all, to set up the correct rpath we pass the linker
1022 // argument manually via `-C link-args=-Wl,-rpath,...`. Plus isn't it
1023 // fun to pass a flag to a tool to pass a flag to pass a flag to a tool
1024 // to change a flag in a binary?
1025 if self.config.rust_rpath && util::use_host_linker(target) {
1026 let rpath = if target.contains("apple") {
1027 // Note that we need to take one extra step on macOS to also pass
1028 // `-Wl,-instal_name,@rpath/...` to get things to work right. To
1029 // do that we pass a weird flag to the compiler to get it to do
1030 // so. Note that this is definitely a hack, and we should likely
1031 // flesh out rpath support more fully in the future.
1032 rustflags.arg("-Zosx-rpath-install-name");
1033 Some("-Wl,-rpath,@loader_path/../lib")
1034 } else if !target.contains("windows") {
1035 Some("-Wl,-rpath,$ORIGIN/../lib")
1039 if let Some(rpath) = rpath {
1040 rustflags.arg(&format!("-Clink-args={}", rpath));
1044 if let Some(host_linker) = self.linker(compiler.host, true) {
1045 cargo.env("RUSTC_HOST_LINKER", host_linker);
1048 if let Some(target_linker) = self.linker(target, true) {
1049 let target = crate::envify(&target.triple);
1050 cargo.env(&format!("CARGO_TARGET_{}_LINKER", target), target_linker);
1053 if self.config.use_lld && !target.contains("msvc") {
1054 rustflags.arg("-Clink-args=-fuse-ld=lld");
1057 if !(["build", "check", "clippy", "fix", "rustc"].contains(&cmd)) && want_rustdoc {
1058 cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
1061 let debuginfo_level = match mode {
1062 Mode::Rustc | Mode::Codegen => self.config.rust_debuginfo_level_rustc,
1063 Mode::Std => self.config.rust_debuginfo_level_std,
1064 Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolRustc => {
1065 self.config.rust_debuginfo_level_tools
1068 cargo.env(profile_var("DEBUG"), debuginfo_level.to_string());
1070 profile_var("DEBUG_ASSERTIONS"),
1071 if mode == Mode::Std {
1072 self.config.rust_debug_assertions_std.to_string()
1074 self.config.rust_debug_assertions.to_string()
1078 if self.config.cmd.bless() {
1079 // Bless `expect!` tests.
1080 cargo.env("UPDATE_EXPECT", "1");
1083 if !mode.is_tool() {
1084 cargo.env("RUSTC_FORCE_UNSTABLE", "1");
1087 if let Some(x) = self.crt_static(target) {
1089 rustflags.arg("-Ctarget-feature=+crt-static");
1091 rustflags.arg("-Ctarget-feature=-crt-static");
1095 if let Some(x) = self.crt_static(compiler.host) {
1096 cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
1099 if let Some(map_to) = self.build.debuginfo_map_to(GitRepo::Rustc) {
1100 let map = format!("{}={}", self.build.src.display(), map_to);
1101 cargo.env("RUSTC_DEBUGINFO_MAP", map);
1103 // `rustc` needs to know the virtual `/rustc/$hash` we're mapping to,
1104 // in order to opportunistically reverse it later.
1105 cargo.env("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR", map_to);
1108 // Enable usage of unstable features
1109 cargo.env("RUSTC_BOOTSTRAP", "1");
1110 self.add_rust_test_threads(&mut cargo);
1112 // Almost all of the crates that we compile as part of the bootstrap may
1113 // have a build script, including the standard library. To compile a
1114 // build script, however, it itself needs a standard library! This
1115 // introduces a bit of a pickle when we're compiling the standard
1118 // To work around this we actually end up using the snapshot compiler
1119 // (stage0) for compiling build scripts of the standard library itself.
1120 // The stage0 compiler is guaranteed to have a libstd available for use.
1122 // For other crates, however, we know that we've already got a standard
1123 // library up and running, so we can use the normal compiler to compile
1124 // build scripts in that situation.
1125 if mode == Mode::Std {
1127 .env("RUSTC_SNAPSHOT", &self.initial_rustc)
1128 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1131 .env("RUSTC_SNAPSHOT", self.rustc(compiler))
1132 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1135 // Tools that use compiler libraries may inherit the `-lLLVM` link
1136 // requirement, but the `-L` library path is not propagated across
1137 // separate Cargo projects. We can add LLVM's library path to the
1138 // platform-specific environment variable as a workaround.
1139 if mode == Mode::ToolRustc {
1140 if let Some(llvm_config) = self.llvm_config(target) {
1141 let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
1142 add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cargo);
1146 if self.config.incremental {
1147 cargo.env("CARGO_INCREMENTAL", "1");
1149 // Don't rely on any default setting for incr. comp. in Cargo
1150 cargo.env("CARGO_INCREMENTAL", "0");
1153 if let Some(ref on_fail) = self.config.on_fail {
1154 cargo.env("RUSTC_ON_FAIL", on_fail);
1157 if self.config.print_step_timings {
1158 cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
1161 if self.config.backtrace_on_ice {
1162 cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
1165 cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1167 if source_type == SourceType::InTree {
1168 let mut lint_flags = Vec::new();
1169 // When extending this list, add the new lints to the RUSTFLAGS of the
1170 // build_bootstrap function of src/bootstrap/bootstrap.py as well as
1171 // some code doesn't go through this `rustc` wrapper.
1172 lint_flags.push("-Wrust_2018_idioms");
1173 lint_flags.push("-Wunused_lifetimes");
1175 if self.config.deny_warnings {
1176 lint_flags.push("-Dwarnings");
1177 rustdocflags.arg("-Dwarnings");
1180 // FIXME(#58633) hide "unused attribute" errors in incremental
1181 // builds of the standard library, as the underlying checks are
1182 // not yet properly integrated with incremental recompilation.
1183 if mode == Mode::Std && compiler.stage == 0 && self.config.incremental {
1184 lint_flags.push("-Aunused-attributes");
1186 // This does not use RUSTFLAGS due to caching issues with Cargo.
1187 // Clippy is treated as an "in tree" tool, but shares the same
1188 // cache as other "submodule" tools. With these options set in
1189 // RUSTFLAGS, that causes *every* shared dependency to be rebuilt.
1190 // By injecting this into the rustc wrapper, this circumvents
1191 // Cargo's fingerprint detection. This is fine because lint flags
1192 // are always ignored in dependencies. Eventually this should be
1193 // fixed via better support from Cargo.
1194 cargo.env("RUSTC_LINT_FLAGS", lint_flags.join(" "));
1196 rustdocflags.arg("-Winvalid_codeblock_attributes");
1199 if let Mode::Rustc | Mode::Codegen = mode {
1200 rustflags.arg("-Zunstable-options");
1201 rustflags.arg("-Wrustc::internal");
1204 // Throughout the build Cargo can execute a number of build scripts
1205 // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
1206 // obtained previously to those build scripts.
1207 // Build scripts use either the `cc` crate or `configure/make` so we pass
1208 // the options through environment variables that are fetched and understood by both.
1210 // FIXME: the guard against msvc shouldn't need to be here
1211 if target.contains("msvc") {
1212 if let Some(ref cl) = self.config.llvm_clang_cl {
1213 cargo.env("CC", cl).env("CXX", cl);
1216 let ccache = self.config.ccache.as_ref();
1217 let ccacheify = |s: &Path| {
1218 let ccache = match ccache {
1220 None => return s.display().to_string(),
1222 // FIXME: the cc-rs crate only recognizes the literal strings
1223 // `ccache` and `sccache` when doing caching compilations, so we
1224 // mirror that here. It should probably be fixed upstream to
1225 // accept a new env var or otherwise work with custom ccache
1228 "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
1229 _ => s.display().to_string(),
1232 let cc = ccacheify(&self.cc(target));
1233 cargo.env(format!("CC_{}", target.triple), &cc);
1235 let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
1236 cargo.env(format!("CFLAGS_{}", target.triple), cflags.clone());
1238 if let Some(ar) = self.ar(target) {
1239 let ranlib = format!("{} s", ar.display());
1241 .env(format!("AR_{}", target.triple), ar)
1242 .env(format!("RANLIB_{}", target.triple), ranlib);
1245 if let Ok(cxx) = self.cxx(target) {
1246 let cxx = ccacheify(&cxx);
1248 .env(format!("CXX_{}", target.triple), &cxx)
1249 .env(format!("CXXFLAGS_{}", target.triple), cflags);
1253 if mode == Mode::Std && self.config.extended && compiler.is_final_stage(self) {
1254 rustflags.arg("-Zsave-analysis");
1256 "RUST_SAVE_ANALYSIS_CONFIG",
1257 "{\"output_file\": null,\"full_docs\": false,\
1258 \"pub_only\": true,\"reachable_only\": false,\
1259 \"distro_crate\": true,\"signatures\": false,\"borrow_data\": false}",
1263 // If Control Flow Guard is enabled, pass the `control-flow-guard` flag to rustc
1264 // when compiling the standard library, since this might be linked into the final outputs
1265 // produced by rustc. Since this mitigation is only available on Windows, only enable it
1266 // for the standard library in case the compiler is run on a non-Windows platform.
1267 // This is not needed for stage 0 artifacts because these will only be used for building
1268 // the stage 1 compiler.
1270 && mode == Mode::Std
1271 && self.config.control_flow_guard
1272 && compiler.stage >= 1
1274 rustflags.arg("-Ccontrol-flow-guard");
1277 // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1278 // This replaces spaces with newlines because RUSTDOCFLAGS does not
1279 // support arguments with regular spaces. Hopefully someday Cargo will
1280 // have space support.
1281 let rust_version = self.rust_version().replace(' ', "\n");
1282 rustdocflags.arg("--crate-version").arg(&rust_version);
1284 // Environment variables *required* throughout the build
1286 // FIXME: should update code to not require this env var
1287 cargo.env("CFG_COMPILER_HOST_TRIPLE", target.triple);
1289 // Set this for all builds to make sure doc builds also get it.
1290 cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1292 // This one's a bit tricky. As of the time of this writing the compiler
1293 // links to the `winapi` crate on crates.io. This crate provides raw
1294 // bindings to Windows system functions, sort of like libc does for
1295 // Unix. This crate also, however, provides "import libraries" for the
1296 // MinGW targets. There's an import library per dll in the windows
1297 // distribution which is what's linked to. These custom import libraries
1298 // are used because the winapi crate can reference Windows functions not
1299 // present in the MinGW import libraries.
1301 // For example MinGW may ship libdbghelp.a, but it may not have
1302 // references to all the functions in the dbghelp dll. Instead the
1303 // custom import library for dbghelp in the winapi crates has all this
1306 // Unfortunately for us though the import libraries are linked by
1307 // default via `-ldylib=winapi_foo`. That is, they're linked with the
1308 // `dylib` type with a `winapi_` prefix (so the winapi ones don't
1309 // conflict with the system MinGW ones). This consequently means that
1310 // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1311 // DLL) when linked against *again*, for example with procedural macros
1312 // or plugins, will trigger the propagation logic of `-ldylib`, passing
1313 // `-lwinapi_foo` to the linker again. This isn't actually available in
1314 // our distribution, however, so the link fails.
1316 // To solve this problem we tell winapi to not use its bundled import
1317 // libraries. This means that it will link to the system MinGW import
1318 // libraries by default, and the `-ldylib=foo` directives will still get
1319 // passed to the final linker, but they'll look like `-lfoo` which can
1320 // be resolved because MinGW has the import library. The downside is we
1321 // don't get newer functions from Windows, but we don't use any of them
1323 if !mode.is_tool() {
1324 cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
1327 for _ in 1..self.verbosity {
1331 match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
1332 (Mode::Std, Some(n), _) | (_, _, Some(n)) => {
1333 cargo.env(profile_var("CODEGEN_UNITS"), n.to_string());
1336 // Don't set anything
1340 if self.config.rust_optimize {
1341 // FIXME: cargo bench/install do not accept `--release`
1342 if cmd != "bench" && cmd != "install" {
1343 cargo.arg("--release");
1347 if self.config.locked_deps {
1348 cargo.arg("--locked");
1350 if self.config.vendor || self.is_sudo {
1351 cargo.arg("--frozen");
1354 // Try to use a sysroot-relative bindir, in case it was configured absolutely.
1355 cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
1357 self.ci_env.force_coloring_in_ci(&mut cargo);
1359 // When we build Rust dylibs they're all intended for intermediate
1360 // usage, so make sure we pass the -Cprefer-dynamic flag instead of
1361 // linking all deps statically into the dylib.
1362 if let Mode::Std | Mode::Rustc | Mode::Codegen = mode {
1363 rustflags.arg("-Cprefer-dynamic");
1366 // When building incrementally we default to a lower ThinLTO import limit
1367 // (unless explicitly specified otherwise). This will produce a somewhat
1368 // slower code but give way better compile times.
1370 let limit = match self.config.rust_thin_lto_import_instr_limit {
1371 Some(limit) => Some(limit),
1372 None if self.config.incremental => Some(10),
1376 if let Some(limit) = limit {
1377 rustflags.arg(&format!("-Cllvm-args=-import-instr-limit={}", limit));
1381 Cargo { command: cargo, rustflags, rustdocflags }
1384 /// Ensure that a given step is built, returning its output. This will
1385 /// cache the step, so it is safe (and good!) to call this as often as
1386 /// needed to ensure that all dependencies are built.
1387 pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1389 let mut stack = self.stack.borrow_mut();
1390 for stack_step in stack.iter() {
1392 if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
1395 let mut out = String::new();
1396 out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1397 for el in stack.iter().rev() {
1398 out += &format!("\t{:?}\n", el);
1402 if let Some(out) = self.cache.get(&step) {
1403 self.verbose(&format!("{}c {:?}", " ".repeat(stack.len()), step));
1407 self.verbose(&format!("{}> {:?}", " ".repeat(stack.len()), step));
1408 stack.push(Box::new(step.clone()));
1412 let start = Instant::now();
1413 let zero = Duration::new(0, 0);
1414 let parent = self.time_spent_on_dependencies.replace(zero);
1415 let out = step.clone().run(self);
1416 let dur = start.elapsed();
1417 let deps = self.time_spent_on_dependencies.replace(parent + dur);
1421 if self.config.print_step_timings && dur > Duration::from_millis(100) {
1422 println!("[TIMING] {:?} -- {}.{:03}", step, dur.as_secs(), dur.subsec_millis());
1426 let mut stack = self.stack.borrow_mut();
1427 let cur_step = stack.pop().expect("step stack empty");
1428 assert_eq!(cur_step.downcast_ref(), Some(&step));
1430 self.verbose(&format!("{}< {:?}", " ".repeat(self.stack.borrow().len()), step));
1431 self.cache.put(step, out.clone());
1439 #[derive(Debug, Clone)]
1440 struct Rustflags(String);
1443 fn new(target: TargetSelection) -> Rustflags {
1444 let mut ret = Rustflags(String::new());
1446 // Inherit `RUSTFLAGS` by default ...
1447 ret.env("RUSTFLAGS");
1449 // ... and also handle target-specific env RUSTFLAGS if they're
1451 let target_specific = format!("CARGO_TARGET_{}_RUSTFLAGS", crate::envify(&target.triple));
1452 ret.env(&target_specific);
1457 fn env(&mut self, env: &str) {
1458 if let Ok(s) = env::var(env) {
1459 for part in s.split(' ') {
1465 fn arg(&mut self, arg: &str) -> &mut Self {
1466 assert_eq!(arg.split(' ').count(), 1);
1467 if !self.0.is_empty() {
1468 self.0.push_str(" ");
1470 self.0.push_str(arg);
1478 rustflags: Rustflags,
1479 rustdocflags: Rustflags,
1483 pub fn rustdocflag(&mut self, arg: &str) -> &mut Cargo {
1484 self.rustdocflags.arg(arg);
1487 pub fn rustflag(&mut self, arg: &str) -> &mut Cargo {
1488 self.rustflags.arg(arg);
1492 pub fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Cargo {
1493 self.command.arg(arg.as_ref());
1497 pub fn args<I, S>(&mut self, args: I) -> &mut Cargo
1499 I: IntoIterator<Item = S>,
1503 self.arg(arg.as_ref());
1508 pub fn env(&mut self, key: impl AsRef<OsStr>, value: impl AsRef<OsStr>) -> &mut Cargo {
1509 // These are managed through rustflag/rustdocflag interfaces.
1510 assert_ne!(key.as_ref(), "RUSTFLAGS");
1511 assert_ne!(key.as_ref(), "RUSTDOCFLAGS");
1512 self.command.env(key.as_ref(), value.as_ref());
1517 impl From<Cargo> for Command {
1518 fn from(mut cargo: Cargo) -> Command {
1519 let rustflags = &cargo.rustflags.0;
1520 if !rustflags.is_empty() {
1521 cargo.command.env("RUSTFLAGS", rustflags);
1524 let rustdocflags = &cargo.rustdocflags.0;
1525 if !rustdocflags.is_empty() {
1526 cargo.command.env("RUSTDOCFLAGS", rustdocflags);