2 use std::cell::{Cell, RefCell};
3 use std::collections::BTreeSet;
10 use std::path::{Path, PathBuf};
11 use std::process::Command;
12 use std::time::{Duration, Instant};
14 use build_helper::{output, t};
16 use crate::cache::{Cache, Interned, INTERNER};
19 use crate::config::TargetSelection;
22 use crate::flags::Subcommand;
27 use crate::tool::{self, SourceType};
28 use crate::util::{self, add_dylib_path, add_link_lib_path, exe, libdir};
29 use crate::{Build, DocTests, GitRepo, Mode};
31 pub use crate::Compiler;
33 pub struct Builder<'a> {
38 stack: RefCell<Vec<Box<dyn Any>>>,
39 time_spent_on_dependencies: Cell<Duration>,
40 pub paths: Vec<PathBuf>,
43 impl<'a> Deref for Builder<'a> {
46 fn deref(&self) -> &Self::Target {
51 pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
52 /// `PathBuf` when directories are created or to return a `Compiler` once
53 /// it's been assembled.
56 /// Whether this step is run by default as part of its respective phase.
57 /// `true` here can still be overwritten by `should_run` calling `default_condition`.
58 const DEFAULT: bool = false;
60 /// If true, then this rule should be skipped if --target was specified, but --host was not
61 const ONLY_HOSTS: bool = false;
63 /// Primary function to execute this rule. Can call `builder.ensure()`
64 /// with other steps to run those.
65 fn run(self, builder: &Builder<'_>) -> Self::Output;
67 /// When bootstrap is passed a set of paths, this controls whether this rule
68 /// will execute. However, it does not get called in a "default" context
69 /// when we are not passed any paths; in that case, `make_run` is called
71 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
73 /// Builds up a "root" rule, either as a default rule or from a path passed
76 /// When path is `None`, we are executing in a context where no paths were
77 /// passed. When `./x.py build` is run, for example, this rule could get
78 /// called if it is in the correct list below with a path of `None`.
79 fn make_run(_run: RunConfig<'_>) {
80 // It is reasonable to not have an implementation of make_run for rules
81 // who do not want to get called from the root context. This means that
82 // they are likely dependencies (e.g., sysroot creation) or similar, and
83 // as such calling them from ./x.py isn't logical.
88 pub struct RunConfig<'a> {
89 pub builder: &'a Builder<'a>,
90 pub target: TargetSelection,
95 pub fn build_triple(&self) -> TargetSelection {
96 self.builder.build.build
100 struct StepDescription {
103 should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
104 make_run: fn(RunConfig<'_>),
108 /// Collection of paths used to match a task rule.
109 #[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
111 /// A collection of individual paths.
113 /// These are generally matched as a path suffix. For example, a
114 /// command-line value of `libstd` will match if `src/libstd` is in the
116 Set(BTreeSet<PathBuf>),
117 /// A "suite" of paths.
119 /// These can match as a path suffix (like `Set`), or as a prefix. For
120 /// example, a command-line value of `src/test/ui/abi/variadic-ffi.rs`
121 /// will match `src/test/ui`. A command-line value of `ui` would also
122 /// match `src/test/ui`.
127 fn empty() -> PathSet {
128 PathSet::Set(BTreeSet::new())
131 fn one<P: Into<PathBuf>>(path: P) -> PathSet {
132 let mut set = BTreeSet::new();
133 set.insert(path.into());
137 fn has(&self, needle: &Path) -> bool {
139 PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
140 PathSet::Suite(suite) => suite.ends_with(needle),
144 fn path(&self, builder: &Builder<'_>) -> PathBuf {
146 PathSet::Set(set) => set.iter().next().unwrap_or(&builder.build.src).to_path_buf(),
147 PathSet::Suite(path) => PathBuf::from(path),
152 impl StepDescription {
153 fn from<S: Step>() -> StepDescription {
156 only_hosts: S::ONLY_HOSTS,
157 should_run: S::should_run,
158 make_run: S::make_run,
159 name: std::any::type_name::<S>(),
163 fn maybe_run(&self, builder: &Builder<'_>, pathset: &PathSet) {
164 if builder.config.exclude.iter().any(|e| pathset.has(e)) {
165 eprintln!("Skipping {:?} because it is excluded", pathset);
167 } else if !builder.config.exclude.is_empty() {
169 "{:?} not skipped for {:?} -- not in {:?}",
170 pathset, self.name, builder.config.exclude
174 // Determine the targets participating in this rule.
175 let targets = if self.only_hosts {
176 if builder.config.skip_only_host_steps {
177 return; // don't run anything
185 for target in targets {
186 let run = RunConfig { builder, path: pathset.path(builder), target: *target };
187 (self.make_run)(run);
191 fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
193 v.iter().map(|desc| (desc.should_run)(ShouldRun::new(builder))).collect::<Vec<_>>();
195 // sanity checks on rules
196 for (desc, should_run) in v.iter().zip(&should_runs) {
198 !should_run.paths.is_empty(),
199 "{:?} should have at least one pathset",
204 if paths.is_empty() {
205 for (desc, should_run) in v.iter().zip(should_runs) {
206 if desc.default && should_run.is_really_default {
207 for pathset in &should_run.paths {
208 desc.maybe_run(builder, pathset);
214 // strip CurDir prefix if present
215 let path = match path.strip_prefix(".") {
220 let mut attempted_run = false;
221 for (desc, should_run) in v.iter().zip(&should_runs) {
222 if let Some(suite) = should_run.is_suite_path(path) {
223 attempted_run = true;
224 desc.maybe_run(builder, suite);
225 } else if let Some(pathset) = should_run.pathset_for_path(path) {
226 attempted_run = true;
227 desc.maybe_run(builder, pathset);
232 panic!("error: no rules matched {}", path.display());
240 pub struct ShouldRun<'a> {
241 pub builder: &'a Builder<'a>,
242 // use a BTreeSet to maintain sort order
243 paths: BTreeSet<PathSet>,
245 // If this is a default rule, this is an additional constraint placed on
246 // its run. Generally something like compiler docs being enabled.
247 is_really_default: bool,
250 impl<'a> ShouldRun<'a> {
251 fn new(builder: &'a Builder<'_>) -> ShouldRun<'a> {
254 paths: BTreeSet::new(),
255 is_really_default: true, // by default no additional conditions
259 pub fn default_condition(mut self, cond: bool) -> Self {
260 self.is_really_default = cond;
264 /// Indicates it should run if the command-line selects the given crate or
265 /// any of its (local) dependencies.
267 /// Compared to `krate`, this treats the dependencies as aliases for the
268 /// same job. Generally it is preferred to use `krate`, and treat each
269 /// individual path separately. For example `./x.py test src/liballoc`
270 /// (which uses `krate`) will test just `liballoc`. However, `./x.py check
271 /// src/liballoc` (which uses `all_krates`) will check all of `libtest`.
272 /// `all_krates` should probably be removed at some point.
273 pub fn all_krates(mut self, name: &str) -> Self {
274 let mut set = BTreeSet::new();
275 for krate in self.builder.in_tree_crates(name) {
276 let path = krate.local_path(self.builder);
279 self.paths.insert(PathSet::Set(set));
283 /// Indicates it should run if the command-line selects the given crate or
284 /// any of its (local) dependencies.
286 /// `make_run` will be called separately for each matching command-line path.
287 pub fn krate(mut self, name: &str) -> Self {
288 for krate in self.builder.in_tree_crates(name) {
289 let path = krate.local_path(self.builder);
290 self.paths.insert(PathSet::one(path));
295 // single, non-aliased path
296 pub fn path(self, path: &str) -> Self {
300 // multiple aliases for the same job
301 pub fn paths(mut self, paths: &[&str]) -> Self {
302 self.paths.insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
306 pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
307 self.paths.iter().find(|pathset| match pathset {
308 PathSet::Suite(p) => path.starts_with(p),
309 PathSet::Set(_) => false,
313 pub fn suite_path(mut self, suite: &str) -> Self {
314 self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
318 // allows being more explicit about why should_run in Step returns the value passed to it
319 pub fn never(mut self) -> ShouldRun<'a> {
320 self.paths.insert(PathSet::empty());
324 fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
325 self.paths.iter().find(|pathset| pathset.has(path))
329 #[derive(Copy, Clone, PartialEq, Eq, Debug)]
344 impl<'a> Builder<'a> {
345 fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
346 macro_rules! describe {
347 ($($rule:ty),+ $(,)?) => {{
348 vec![$(StepDescription::from::<$rule>()),+]
352 Kind::Build => describe!(
355 compile::StartupObjects,
359 tool::UnstableBookGen,
364 tool::RemoteTestServer,
365 tool::RemoteTestClient,
381 Kind::Check | Kind::Clippy | Kind::Fix | Kind::Format => {
382 describe!(check::Std, check::Rustc, check::Rustdoc, check::Clippy, check::Bootstrap)
384 Kind::Test => describe!(
385 crate::toolstate::ToolStateCheck,
386 test::ExpandYamlAnchors,
390 test::RunPassValgrind,
410 test::RunMakeFullDeps,
424 test::CompiletestTest,
426 test::RustdocJSNotStd,
429 // Run bootstrap close to the end as it's unlikely to fail
431 // Run run-make last, since these won't pass without make on Windows
434 Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
435 Kind::Doc => describe!(
437 doc::UnstableBookGen,
453 Kind::Dist => describe!(
458 dist::DebuggerScripts,
463 dist::PlainSourceTarball,
475 Kind::Install => describe!(
480 install::RustAnalyzer,
488 Kind::Run => describe!(run::ExpandYamlAnchors,),
492 pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
493 let kind = match subcommand {
494 "build" => Kind::Build,
496 "test" => Kind::Test,
497 "bench" => Kind::Bench,
498 "dist" => Kind::Dist,
499 "install" => Kind::Install,
503 let builder = Self::new_internal(build, kind, vec![]);
504 let builder = &builder;
505 let mut should_run = ShouldRun::new(builder);
506 for desc in Builder::get_step_descriptions(builder.kind) {
507 should_run = (desc.should_run)(should_run);
509 let mut help = String::from("Available paths:\n");
510 let mut add_path = |path: &Path| {
511 help.push_str(&format!(" ./x.py {} {}\n", subcommand, path.display()));
513 for pathset in should_run.paths {
515 PathSet::Set(set) => {
520 PathSet::Suite(path) => {
521 add_path(&path.join("..."));
528 fn new_internal(build: &Build, kind: Kind, paths: Vec<PathBuf>) -> Builder<'_> {
531 top_stage: build.config.stage,
534 stack: RefCell::new(Vec::new()),
535 time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
540 pub fn new(build: &Build) -> Builder<'_> {
541 let (kind, paths) = match build.config.cmd {
542 Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
543 Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
544 Subcommand::Clippy { ref paths } => (Kind::Clippy, &paths[..]),
545 Subcommand::Fix { ref paths } => (Kind::Fix, &paths[..]),
546 Subcommand::Doc { ref paths, .. } => (Kind::Doc, &paths[..]),
547 Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
548 Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
549 Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
550 Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
551 Subcommand::Run { ref paths } => (Kind::Run, &paths[..]),
552 Subcommand::Format { .. } | Subcommand::Clean { .. } | Subcommand::Setup { .. } => {
557 Self::new_internal(build, kind, paths.to_owned())
560 pub fn execute_cli(&self) {
561 self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
564 pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
565 let paths = paths.unwrap_or(&[]);
566 self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
569 fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
570 StepDescription::run(v, self, paths);
573 /// Obtain a compiler at a given stage and for a given host. Explicitly does
574 /// not take `Compiler` since all `Compiler` instances are meant to be
575 /// obtained through this function, since it ensures that they are valid
576 /// (i.e., built and assembled).
577 pub fn compiler(&self, stage: u32, host: TargetSelection) -> Compiler {
578 self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
581 /// Similar to `compiler`, except handles the full-bootstrap option to
582 /// silently use the stage1 compiler instead of a stage2 compiler if one is
585 /// Note that this does *not* have the side effect of creating
586 /// `compiler(stage, host)`, unlike `compiler` above which does have such
587 /// a side effect. The returned compiler here can only be used to compile
588 /// new artifacts, it can't be used to rely on the presence of a particular
591 /// See `force_use_stage1` for documentation on what each argument is.
595 host: TargetSelection,
596 target: TargetSelection,
598 if self.build.force_use_stage1(Compiler { stage, host }, target) {
599 self.compiler(1, self.config.build)
601 self.compiler(stage, host)
605 pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
606 self.ensure(compile::Sysroot { compiler })
609 /// Returns the libdir where the standard library and other artifacts are
610 /// found for a compiler's sysroot.
611 pub fn sysroot_libdir(&self, compiler: Compiler, target: TargetSelection) -> Interned<PathBuf> {
612 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
615 target: TargetSelection,
617 impl Step for Libdir {
618 type Output = Interned<PathBuf>;
620 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
624 fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
625 let lib = builder.sysroot_libdir_relative(self.compiler);
626 let sysroot = builder
627 .sysroot(self.compiler)
630 .join(self.target.triple)
632 let _ = fs::remove_dir_all(&sysroot);
633 t!(fs::create_dir_all(&sysroot));
634 INTERNER.intern_path(sysroot)
637 self.ensure(Libdir { compiler, target })
640 /// Returns the compiler's libdir where it stores the dynamic libraries that
641 /// it itself links against.
643 /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
645 pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
646 if compiler.is_snapshot(self) {
647 self.rustc_snapshot_libdir()
649 match self.config.libdir_relative() {
650 Some(relative_libdir) if compiler.stage >= 1 => {
651 self.sysroot(compiler).join(relative_libdir)
653 _ => self.sysroot(compiler).join(libdir(compiler.host)),
658 /// Returns the compiler's relative libdir where it stores the dynamic libraries that
659 /// it itself links against.
661 /// For example this returns `lib` on Unix and `bin` on
663 pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
664 if compiler.is_snapshot(self) {
665 libdir(self.config.build).as_ref()
667 match self.config.libdir_relative() {
668 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
669 _ => libdir(compiler.host).as_ref(),
674 /// Returns the compiler's relative libdir where the standard library and other artifacts are
675 /// found for a compiler's sysroot.
677 /// For example this returns `lib` on Unix and Windows.
678 pub fn sysroot_libdir_relative(&self, compiler: Compiler) -> &Path {
679 match self.config.libdir_relative() {
680 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
681 _ if compiler.stage == 0 => &self.build.initial_libdir,
682 _ => Path::new("lib"),
686 /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
687 /// library lookup path.
688 pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
689 // Windows doesn't need dylib path munging because the dlls for the
690 // compiler live next to the compiler and the system will find them
696 add_dylib_path(vec![self.rustc_libdir(compiler)], cmd);
699 /// Gets a path to the compiler specified.
700 pub fn rustc(&self, compiler: Compiler) -> PathBuf {
701 if compiler.is_snapshot(self) {
702 self.initial_rustc.clone()
704 self.sysroot(compiler).join("bin").join(exe("rustc", compiler.host))
708 pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
709 self.ensure(tool::Rustdoc { compiler })
712 pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
713 let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
714 cmd.env("RUSTC_STAGE", compiler.stage.to_string())
715 .env("RUSTC_SYSROOT", self.sysroot(compiler))
716 // Note that this is *not* the sysroot_libdir because rustdoc must be linked
717 // equivalently to rustc.
718 .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
719 .env("CFG_RELEASE_CHANNEL", &self.config.channel)
720 .env("RUSTDOC_REAL", self.rustdoc(compiler))
721 .env("RUSTC_BOOTSTRAP", "1")
722 .arg("-Winvalid_codeblock_attributes");
723 if self.config.deny_warnings {
724 cmd.arg("-Dwarnings");
727 // Remove make-related flags that can cause jobserver problems.
728 cmd.env_remove("MAKEFLAGS");
729 cmd.env_remove("MFLAGS");
731 if let Some(linker) = self.linker(compiler.host) {
732 cmd.env("RUSTDOC_LINKER", linker);
734 if self.is_fuse_ld_lld(compiler.host) {
735 cmd.env("RUSTDOC_FUSE_LD_LLD", "1");
740 /// Return the path to `llvm-config` for the target, if it exists.
742 /// Note that this returns `None` if LLVM is disabled, or if we're in a
743 /// check build or dry-run, where there's no need to build all of LLVM.
744 fn llvm_config(&self, target: TargetSelection) -> Option<PathBuf> {
745 if self.config.llvm_enabled() && self.kind != Kind::Check && !self.config.dry_run {
746 let llvm_config = self.ensure(native::Llvm { target });
747 if llvm_config.is_file() {
748 return Some(llvm_config);
754 /// Prepares an invocation of `cargo` to be run.
756 /// This will create a `Command` that represents a pending execution of
757 /// Cargo. This cargo will be configured to use `compiler` as the actual
758 /// rustc compiler, its output will be scoped by `mode`'s output directory,
759 /// it will pass the `--target` flag for the specified `target`, and will be
760 /// executing the Cargo command `cmd`.
765 source_type: SourceType,
766 target: TargetSelection,
769 let mut cargo = Command::new(&self.initial_cargo);
770 let out_dir = self.stage_out(compiler, mode);
772 if cmd == "doc" || cmd == "rustdoc" {
773 let my_out = match mode {
774 // This is the intended out directory for compiler documentation.
775 Mode::Rustc | Mode::ToolRustc => self.compiler_doc_out(target),
776 Mode::Std => out_dir.join(target.triple).join("doc"),
777 _ => panic!("doc mode {:?} not expected", mode),
779 let rustdoc = self.rustdoc(compiler);
780 self.clear_if_dirty(&my_out, &rustdoc);
783 cargo.env("CARGO_TARGET_DIR", &out_dir).arg(cmd);
785 let profile_var = |name: &str| {
786 let profile = if self.config.rust_optimize { "RELEASE" } else { "DEV" };
787 format!("CARGO_PROFILE_{}_{}", profile, name)
790 // See comment in rustc_llvm/build.rs for why this is necessary, largely llvm-config
791 // needs to not accidentally link to libLLVM in stage0/lib.
792 cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
793 if let Some(e) = env::var_os(util::dylib_path_var()) {
794 cargo.env("REAL_LIBRARY_PATH", e);
797 if cmd != "install" {
798 cargo.arg("--target").arg(target.rustc_target_arg());
800 assert_eq!(target, compiler.host);
803 // Set a flag for `check`/`clippy`/`fix`, so that certain build
804 // scripts can do less work (i.e. not building/requiring LLVM).
805 if cmd == "check" || cmd == "clippy" || cmd == "fix" {
806 // If we've not yet built LLVM, or it's stale, then bust
807 // the rustc_llvm cache. That will always work, even though it
808 // may mean that on the next non-check build we'll need to rebuild
809 // rustc_llvm. But if LLVM is stale, that'll be a tiny amount
810 // of work comparitively, and we'd likely need to rebuild it anyway,
812 if crate::native::prebuilt_llvm_config(self, target).is_err() {
813 cargo.env("RUST_CHECK", "1");
817 let stage = if compiler.stage == 0 && self.local_rebuild {
818 // Assume the local-rebuild rustc already has stage1 features.
824 let mut rustflags = Rustflags::new(target);
826 if let Ok(s) = env::var("CARGOFLAGS_NOT_BOOTSTRAP") {
827 cargo.args(s.split_whitespace());
829 rustflags.env("RUSTFLAGS_NOT_BOOTSTRAP");
831 if let Ok(s) = env::var("CARGOFLAGS_BOOTSTRAP") {
832 cargo.args(s.split_whitespace());
834 rustflags.env("RUSTFLAGS_BOOTSTRAP");
835 rustflags.arg("--cfg=bootstrap");
838 if self.config.rust_new_symbol_mangling {
839 rustflags.arg("-Zsymbol-mangling-version=v0");
842 // FIXME: It might be better to use the same value for both `RUSTFLAGS` and `RUSTDOCFLAGS`,
843 // but this breaks CI. At the very least, stage0 `rustdoc` needs `--cfg bootstrap`. See
845 let mut rustdocflags = rustflags.clone();
847 if let Ok(s) = env::var("CARGOFLAGS") {
848 cargo.args(s.split_whitespace());
852 Mode::Std | Mode::ToolBootstrap | Mode::ToolStd => {}
853 Mode::Rustc | Mode::ToolRustc => {
854 // Build proc macros both for the host and the target
855 if target != compiler.host && cmd != "check" {
856 cargo.arg("-Zdual-proc-macros");
857 rustflags.arg("-Zdual-proc-macros");
862 // This tells Cargo (and in turn, rustc) to output more complete
863 // dependency information. Most importantly for rustbuild, this
864 // includes sysroot artifacts, like libstd, which means that we don't
865 // need to track those in rustbuild (an error prone process!). This
866 // feature is currently unstable as there may be some bugs and such, but
867 // it represents a big improvement in rustbuild's reliability on
868 // rebuilds, so we're using it here.
870 // For some additional context, see #63470 (the PR originally adding
871 // this), as well as #63012 which is the tracking issue for this
872 // feature on the rustc side.
873 cargo.arg("-Zbinary-dep-depinfo");
875 cargo.arg("-j").arg(self.jobs().to_string());
876 // Remove make-related flags to ensure Cargo can correctly set things up
877 cargo.env_remove("MAKEFLAGS");
878 cargo.env_remove("MFLAGS");
880 // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
881 // Force cargo to output binaries with disambiguating hashes in the name
882 let mut metadata = if compiler.stage == 0 {
883 // Treat stage0 like a special channel, whether it's a normal prior-
884 // release rustc or a local rebuild with the same version, so we
885 // never mix these libraries by accident.
886 "bootstrap".to_string()
888 self.config.channel.to_string()
890 // We want to make sure that none of the dependencies between
891 // std/test/rustc unify with one another. This is done for weird linkage
892 // reasons but the gist of the problem is that if librustc, libtest, and
893 // libstd all depend on libc from crates.io (which they actually do) we
894 // want to make sure they all get distinct versions. Things get really
895 // weird if we try to unify all these dependencies right now, namely
896 // around how many times the library is linked in dynamic libraries and
897 // such. If rustc were a static executable or if we didn't ship dylibs
898 // this wouldn't be a problem, but we do, so it is. This is in general
899 // just here to make sure things build right. If you can remove this and
900 // things still build right, please do!
902 Mode::Std => metadata.push_str("std"),
903 // When we're building rustc tools, they're built with a search path
904 // that contains things built during the rustc build. For example,
905 // bitflags is built during the rustc build, and is a dependency of
906 // rustdoc as well. We're building rustdoc in a different target
907 // directory, though, which means that Cargo will rebuild the
908 // dependency. When we go on to build rustdoc, we'll look for
909 // bitflags, and find two different copies: one built during the
910 // rustc step and one that we just built. This isn't always a
911 // problem, somehow -- not really clear why -- but we know that this
913 Mode::ToolRustc => metadata.push_str("tool-rustc"),
916 cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
919 rustflags.arg("-Zforce-unstable-if-unmarked");
922 rustflags.arg("-Zmacro-backtrace");
924 let want_rustdoc = self.doc_tests != DocTests::No;
926 // We synthetically interpret a stage0 compiler used to build tools as a
927 // "raw" compiler in that it's the exact snapshot we download. Normally
928 // the stage0 build means it uses libraries build by the stage0
929 // compiler, but for tools we just use the precompiled libraries that
931 let use_snapshot = mode == Mode::ToolBootstrap;
932 assert!(!use_snapshot || stage == 0 || self.local_rebuild);
934 let maybe_sysroot = self.sysroot(compiler);
935 let sysroot = if use_snapshot { self.rustc_snapshot_sysroot() } else { &maybe_sysroot };
936 let libdir = self.rustc_libdir(compiler);
938 // Clear the output directory if the real rustc we're using has changed;
939 // Cargo cannot detect this as it thinks rustc is bootstrap/debug/rustc.
941 // Avoid doing this during dry run as that usually means the relevant
942 // compiler is not yet linked/copied properly.
944 // Only clear out the directory if we're compiling std; otherwise, we
945 // should let Cargo take care of things for us (via depdep info)
946 if !self.config.dry_run && mode == Mode::Std && cmd == "build" {
947 self.clear_if_dirty(&out_dir, &self.rustc(compiler));
950 // Customize the compiler we're running. Specify the compiler to cargo
951 // as our shim and then pass it some various options used to configure
952 // how the actual compiler itself is called.
954 // These variables are primarily all read by
955 // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
957 .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
958 .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
959 .env("RUSTC_REAL", self.rustc(compiler))
960 .env("RUSTC_STAGE", stage.to_string())
961 .env("RUSTC_SYSROOT", &sysroot)
962 .env("RUSTC_LIBDIR", &libdir)
963 .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
966 if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
967 self.rustdoc(compiler)
969 PathBuf::from("/path/to/nowhere/rustdoc/not/required")
972 .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir())
973 .env("RUSTC_BREAK_ON_ICE", "1");
975 // Dealing with rpath here is a little special, so let's go into some
976 // detail. First off, `-rpath` is a linker option on Unix platforms
977 // which adds to the runtime dynamic loader path when looking for
978 // dynamic libraries. We use this by default on Unix platforms to ensure
979 // that our nightlies behave the same on Windows, that is they work out
980 // of the box. This can be disabled, of course, but basically that's why
981 // we're gated on RUSTC_RPATH here.
983 // Ok, so the astute might be wondering "why isn't `-C rpath` used
984 // here?" and that is indeed a good question to ask. This codegen
985 // option is the compiler's current interface to generating an rpath.
986 // Unfortunately it doesn't quite suffice for us. The flag currently
987 // takes no value as an argument, so the compiler calculates what it
988 // should pass to the linker as `-rpath`. This unfortunately is based on
989 // the **compile time** directory structure which when building with
990 // Cargo will be very different than the runtime directory structure.
992 // All that's a really long winded way of saying that if we use
993 // `-Crpath` then the executables generated have the wrong rpath of
994 // something like `$ORIGIN/deps` when in fact the way we distribute
995 // rustc requires the rpath to be `$ORIGIN/../lib`.
997 // So, all in all, to set up the correct rpath we pass the linker
998 // argument manually via `-C link-args=-Wl,-rpath,...`. Plus isn't it
999 // fun to pass a flag to a tool to pass a flag to pass a flag to a tool
1000 // to change a flag in a binary?
1001 if self.config.rust_rpath && util::use_host_linker(target) {
1002 let rpath = if target.contains("apple") {
1003 // Note that we need to take one extra step on macOS to also pass
1004 // `-Wl,-instal_name,@rpath/...` to get things to work right. To
1005 // do that we pass a weird flag to the compiler to get it to do
1006 // so. Note that this is definitely a hack, and we should likely
1007 // flesh out rpath support more fully in the future.
1008 rustflags.arg("-Zosx-rpath-install-name");
1009 Some("-Wl,-rpath,@loader_path/../lib")
1010 } else if !target.contains("windows") {
1011 Some("-Wl,-rpath,$ORIGIN/../lib")
1015 if let Some(rpath) = rpath {
1016 rustflags.arg(&format!("-Clink-args={}", rpath));
1020 if let Some(host_linker) = self.linker(compiler.host) {
1021 cargo.env("RUSTC_HOST_LINKER", host_linker);
1023 if self.is_fuse_ld_lld(compiler.host) {
1024 cargo.env("RUSTC_HOST_FUSE_LD_LLD", "1");
1027 if let Some(target_linker) = self.linker(target) {
1028 let target = crate::envify(&target.triple);
1029 cargo.env(&format!("CARGO_TARGET_{}_LINKER", target), target_linker);
1031 if self.is_fuse_ld_lld(target) {
1032 rustflags.arg("-Clink-args=-fuse-ld=lld");
1035 if !(["build", "check", "clippy", "fix", "rustc"].contains(&cmd)) && want_rustdoc {
1036 cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
1039 let debuginfo_level = match mode {
1040 Mode::Rustc => self.config.rust_debuginfo_level_rustc,
1041 Mode::Std => self.config.rust_debuginfo_level_std,
1042 Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolRustc => {
1043 self.config.rust_debuginfo_level_tools
1046 cargo.env(profile_var("DEBUG"), debuginfo_level.to_string());
1048 profile_var("DEBUG_ASSERTIONS"),
1049 if mode == Mode::Std {
1050 self.config.rust_debug_assertions_std.to_string()
1052 self.config.rust_debug_assertions.to_string()
1056 if self.config.cmd.bless() {
1057 // Bless `expect!` tests.
1058 cargo.env("UPDATE_EXPECT", "1");
1061 if !mode.is_tool() {
1062 cargo.env("RUSTC_FORCE_UNSTABLE", "1");
1065 if let Some(x) = self.crt_static(target) {
1067 rustflags.arg("-Ctarget-feature=+crt-static");
1069 rustflags.arg("-Ctarget-feature=-crt-static");
1073 if let Some(x) = self.crt_static(compiler.host) {
1074 cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
1077 if let Some(map_to) = self.build.debuginfo_map_to(GitRepo::Rustc) {
1078 let map = format!("{}={}", self.build.src.display(), map_to);
1079 cargo.env("RUSTC_DEBUGINFO_MAP", map);
1081 // `rustc` needs to know the virtual `/rustc/$hash` we're mapping to,
1082 // in order to opportunistically reverse it later.
1083 cargo.env("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR", map_to);
1086 // Enable usage of unstable features
1087 cargo.env("RUSTC_BOOTSTRAP", "1");
1088 self.add_rust_test_threads(&mut cargo);
1090 // Almost all of the crates that we compile as part of the bootstrap may
1091 // have a build script, including the standard library. To compile a
1092 // build script, however, it itself needs a standard library! This
1093 // introduces a bit of a pickle when we're compiling the standard
1096 // To work around this we actually end up using the snapshot compiler
1097 // (stage0) for compiling build scripts of the standard library itself.
1098 // The stage0 compiler is guaranteed to have a libstd available for use.
1100 // For other crates, however, we know that we've already got a standard
1101 // library up and running, so we can use the normal compiler to compile
1102 // build scripts in that situation.
1103 if mode == Mode::Std {
1105 .env("RUSTC_SNAPSHOT", &self.initial_rustc)
1106 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1109 .env("RUSTC_SNAPSHOT", self.rustc(compiler))
1110 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1113 // Tools that use compiler libraries may inherit the `-lLLVM` link
1114 // requirement, but the `-L` library path is not propagated across
1115 // separate Cargo projects. We can add LLVM's library path to the
1116 // platform-specific environment variable as a workaround.
1117 if mode == Mode::ToolRustc {
1118 if let Some(llvm_config) = self.llvm_config(target) {
1119 let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
1120 add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cargo);
1124 if self.config.incremental {
1125 cargo.env("CARGO_INCREMENTAL", "1");
1127 // Don't rely on any default setting for incr. comp. in Cargo
1128 cargo.env("CARGO_INCREMENTAL", "0");
1131 if let Some(ref on_fail) = self.config.on_fail {
1132 cargo.env("RUSTC_ON_FAIL", on_fail);
1135 if self.config.print_step_timings {
1136 cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
1139 if self.config.backtrace_on_ice {
1140 cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
1143 cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1145 if source_type == SourceType::InTree {
1146 let mut lint_flags = Vec::new();
1147 // When extending this list, add the new lints to the RUSTFLAGS of the
1148 // build_bootstrap function of src/bootstrap/bootstrap.py as well as
1149 // some code doesn't go through this `rustc` wrapper.
1150 lint_flags.push("-Wrust_2018_idioms");
1151 lint_flags.push("-Wunused_lifetimes");
1153 if self.config.deny_warnings {
1154 lint_flags.push("-Dwarnings");
1155 rustdocflags.arg("-Dwarnings");
1158 // FIXME(#58633) hide "unused attribute" errors in incremental
1159 // builds of the standard library, as the underlying checks are
1160 // not yet properly integrated with incremental recompilation.
1161 if mode == Mode::Std && compiler.stage == 0 && self.config.incremental {
1162 lint_flags.push("-Aunused-attributes");
1164 // This does not use RUSTFLAGS due to caching issues with Cargo.
1165 // Clippy is treated as an "in tree" tool, but shares the same
1166 // cache as other "submodule" tools. With these options set in
1167 // RUSTFLAGS, that causes *every* shared dependency to be rebuilt.
1168 // By injecting this into the rustc wrapper, this circumvents
1169 // Cargo's fingerprint detection. This is fine because lint flags
1170 // are always ignored in dependencies. Eventually this should be
1171 // fixed via better support from Cargo.
1172 cargo.env("RUSTC_LINT_FLAGS", lint_flags.join(" "));
1174 rustdocflags.arg("-Winvalid_codeblock_attributes");
1177 if mode == Mode::Rustc {
1178 rustflags.arg("-Zunstable-options");
1179 rustflags.arg("-Wrustc::internal");
1182 // Throughout the build Cargo can execute a number of build scripts
1183 // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
1184 // obtained previously to those build scripts.
1185 // Build scripts use either the `cc` crate or `configure/make` so we pass
1186 // the options through environment variables that are fetched and understood by both.
1188 // FIXME: the guard against msvc shouldn't need to be here
1189 if target.contains("msvc") {
1190 if let Some(ref cl) = self.config.llvm_clang_cl {
1191 cargo.env("CC", cl).env("CXX", cl);
1194 let ccache = self.config.ccache.as_ref();
1195 let ccacheify = |s: &Path| {
1196 let ccache = match ccache {
1198 None => return s.display().to_string(),
1200 // FIXME: the cc-rs crate only recognizes the literal strings
1201 // `ccache` and `sccache` when doing caching compilations, so we
1202 // mirror that here. It should probably be fixed upstream to
1203 // accept a new env var or otherwise work with custom ccache
1206 "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
1207 _ => s.display().to_string(),
1210 let cc = ccacheify(&self.cc(target));
1211 cargo.env(format!("CC_{}", target.triple), &cc);
1213 let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
1214 cargo.env(format!("CFLAGS_{}", target.triple), &cflags);
1216 if let Some(ar) = self.ar(target) {
1217 let ranlib = format!("{} s", ar.display());
1219 .env(format!("AR_{}", target.triple), ar)
1220 .env(format!("RANLIB_{}", target.triple), ranlib);
1223 if let Ok(cxx) = self.cxx(target) {
1224 let cxx = ccacheify(&cxx);
1226 .env(format!("CXX_{}", target.triple), &cxx)
1227 .env(format!("CXXFLAGS_{}", target.triple), cflags);
1231 if mode == Mode::Std && self.config.extended && compiler.is_final_stage(self) {
1232 rustflags.arg("-Zsave-analysis");
1234 "RUST_SAVE_ANALYSIS_CONFIG",
1235 "{\"output_file\": null,\"full_docs\": false,\
1236 \"pub_only\": true,\"reachable_only\": false,\
1237 \"distro_crate\": true,\"signatures\": false,\"borrow_data\": false}",
1241 // If Control Flow Guard is enabled, pass the `control-flow-guard` flag to rustc
1242 // when compiling the standard library, since this might be linked into the final outputs
1243 // produced by rustc. Since this mitigation is only available on Windows, only enable it
1244 // for the standard library in case the compiler is run on a non-Windows platform.
1245 // This is not needed for stage 0 artifacts because these will only be used for building
1246 // the stage 1 compiler.
1248 && mode == Mode::Std
1249 && self.config.control_flow_guard
1250 && compiler.stage >= 1
1252 rustflags.arg("-Ccontrol-flow-guard");
1255 // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1256 // This replaces spaces with newlines because RUSTDOCFLAGS does not
1257 // support arguments with regular spaces. Hopefully someday Cargo will
1258 // have space support.
1259 let rust_version = self.rust_version().replace(' ', "\n");
1260 rustdocflags.arg("--crate-version").arg(&rust_version);
1262 // Environment variables *required* throughout the build
1264 // FIXME: should update code to not require this env var
1265 cargo.env("CFG_COMPILER_HOST_TRIPLE", target.triple);
1267 // Set this for all builds to make sure doc builds also get it.
1268 cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1270 // This one's a bit tricky. As of the time of this writing the compiler
1271 // links to the `winapi` crate on crates.io. This crate provides raw
1272 // bindings to Windows system functions, sort of like libc does for
1273 // Unix. This crate also, however, provides "import libraries" for the
1274 // MinGW targets. There's an import library per dll in the windows
1275 // distribution which is what's linked to. These custom import libraries
1276 // are used because the winapi crate can reference Windows functions not
1277 // present in the MinGW import libraries.
1279 // For example MinGW may ship libdbghelp.a, but it may not have
1280 // references to all the functions in the dbghelp dll. Instead the
1281 // custom import library for dbghelp in the winapi crates has all this
1284 // Unfortunately for us though the import libraries are linked by
1285 // default via `-ldylib=winapi_foo`. That is, they're linked with the
1286 // `dylib` type with a `winapi_` prefix (so the winapi ones don't
1287 // conflict with the system MinGW ones). This consequently means that
1288 // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1289 // DLL) when linked against *again*, for example with procedural macros
1290 // or plugins, will trigger the propagation logic of `-ldylib`, passing
1291 // `-lwinapi_foo` to the linker again. This isn't actually available in
1292 // our distribution, however, so the link fails.
1294 // To solve this problem we tell winapi to not use its bundled import
1295 // libraries. This means that it will link to the system MinGW import
1296 // libraries by default, and the `-ldylib=foo` directives will still get
1297 // passed to the final linker, but they'll look like `-lfoo` which can
1298 // be resolved because MinGW has the import library. The downside is we
1299 // don't get newer functions from Windows, but we don't use any of them
1301 if !mode.is_tool() {
1302 cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
1305 for _ in 1..self.verbosity {
1309 match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
1310 (Mode::Std, Some(n), _) | (_, _, Some(n)) => {
1311 cargo.env(profile_var("CODEGEN_UNITS"), n.to_string());
1314 // Don't set anything
1318 if self.config.rust_optimize {
1319 // FIXME: cargo bench/install do not accept `--release`
1320 if cmd != "bench" && cmd != "install" {
1321 cargo.arg("--release");
1325 if self.config.locked_deps {
1326 cargo.arg("--locked");
1328 if self.config.vendor || self.is_sudo {
1329 cargo.arg("--frozen");
1332 // Try to use a sysroot-relative bindir, in case it was configured absolutely.
1333 cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
1335 self.ci_env.force_coloring_in_ci(&mut cargo);
1337 // When we build Rust dylibs they're all intended for intermediate
1338 // usage, so make sure we pass the -Cprefer-dynamic flag instead of
1339 // linking all deps statically into the dylib.
1340 if matches!(mode, Mode::Std | Mode::Rustc) {
1341 rustflags.arg("-Cprefer-dynamic");
1344 // When building incrementally we default to a lower ThinLTO import limit
1345 // (unless explicitly specified otherwise). This will produce a somewhat
1346 // slower code but give way better compile times.
1348 let limit = match self.config.rust_thin_lto_import_instr_limit {
1349 Some(limit) => Some(limit),
1350 None if self.config.incremental => Some(10),
1354 if let Some(limit) = limit {
1355 rustflags.arg(&format!("-Cllvm-args=-import-instr-limit={}", limit));
1359 Cargo { command: cargo, rustflags, rustdocflags }
1362 /// Ensure that a given step is built, returning its output. This will
1363 /// cache the step, so it is safe (and good!) to call this as often as
1364 /// needed to ensure that all dependencies are built.
1365 pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1367 let mut stack = self.stack.borrow_mut();
1368 for stack_step in stack.iter() {
1370 if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
1373 let mut out = String::new();
1374 out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1375 for el in stack.iter().rev() {
1376 out += &format!("\t{:?}\n", el);
1380 if let Some(out) = self.cache.get(&step) {
1381 self.verbose(&format!("{}c {:?}", " ".repeat(stack.len()), step));
1385 self.verbose(&format!("{}> {:?}", " ".repeat(stack.len()), step));
1386 stack.push(Box::new(step.clone()));
1390 let start = Instant::now();
1391 let zero = Duration::new(0, 0);
1392 let parent = self.time_spent_on_dependencies.replace(zero);
1393 let out = step.clone().run(self);
1394 let dur = start.elapsed();
1395 let deps = self.time_spent_on_dependencies.replace(parent + dur);
1399 if self.config.print_step_timings && !self.config.dry_run {
1400 println!("[TIMING] {:?} -- {}.{:03}", step, dur.as_secs(), dur.subsec_millis());
1404 let mut stack = self.stack.borrow_mut();
1405 let cur_step = stack.pop().expect("step stack empty");
1406 assert_eq!(cur_step.downcast_ref(), Some(&step));
1408 self.verbose(&format!("{}< {:?}", " ".repeat(self.stack.borrow().len()), step));
1409 self.cache.put(step, out.clone());
1417 #[derive(Debug, Clone)]
1418 struct Rustflags(String);
1421 fn new(target: TargetSelection) -> Rustflags {
1422 let mut ret = Rustflags(String::new());
1424 // Inherit `RUSTFLAGS` by default ...
1425 ret.env("RUSTFLAGS");
1427 // ... and also handle target-specific env RUSTFLAGS if they're
1429 let target_specific = format!("CARGO_TARGET_{}_RUSTFLAGS", crate::envify(&target.triple));
1430 ret.env(&target_specific);
1435 fn env(&mut self, env: &str) {
1436 if let Ok(s) = env::var(env) {
1437 for part in s.split(' ') {
1443 fn arg(&mut self, arg: &str) -> &mut Self {
1444 assert_eq!(arg.split(' ').count(), 1);
1445 if !self.0.is_empty() {
1446 self.0.push_str(" ");
1448 self.0.push_str(arg);
1456 rustflags: Rustflags,
1457 rustdocflags: Rustflags,
1461 pub fn rustdocflag(&mut self, arg: &str) -> &mut Cargo {
1462 self.rustdocflags.arg(arg);
1465 pub fn rustflag(&mut self, arg: &str) -> &mut Cargo {
1466 self.rustflags.arg(arg);
1470 pub fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Cargo {
1471 self.command.arg(arg.as_ref());
1475 pub fn args<I, S>(&mut self, args: I) -> &mut Cargo
1477 I: IntoIterator<Item = S>,
1481 self.arg(arg.as_ref());
1486 pub fn env(&mut self, key: impl AsRef<OsStr>, value: impl AsRef<OsStr>) -> &mut Cargo {
1487 // These are managed through rustflag/rustdocflag interfaces.
1488 assert_ne!(key.as_ref(), "RUSTFLAGS");
1489 assert_ne!(key.as_ref(), "RUSTDOCFLAGS");
1490 self.command.env(key.as_ref(), value.as_ref());
1494 pub fn add_rustc_lib_path(&mut self, builder: &Builder<'_>, compiler: Compiler) {
1495 builder.add_rustc_lib_path(compiler, &mut self.command);
1499 impl From<Cargo> for Command {
1500 fn from(mut cargo: Cargo) -> Command {
1501 let rustflags = &cargo.rustflags.0;
1502 if !rustflags.is_empty() {
1503 cargo.command.env("RUSTFLAGS", rustflags);
1506 let rustdocflags = &cargo.rustdocflags.0;
1507 if !rustdocflags.is_empty() {
1508 cargo.command.env("RUSTDOCFLAGS", rustdocflags);