1 use std::any::{type_name, Any};
2 use std::cell::{Cell, RefCell};
3 use std::collections::BTreeSet;
5 use std::ffi::{OsStr, OsString};
6 use std::fmt::{Debug, Write};
7 use std::fs::{self, File};
9 use std::io::{BufRead, BufReader, ErrorKind};
11 use std::path::{Component, Path, PathBuf};
12 use std::process::{Command, Stdio};
13 use std::time::{Duration, Instant};
15 use crate::cache::{Cache, Interned, INTERNER};
16 use crate::config::{SplitDebuginfo, TargetSelection};
19 use crate::flags::{Color, Subcommand};
24 use crate::tool::{self, SourceType};
25 use crate::util::{self, add_dylib_path, add_link_lib_path, exe, libdir, output, t};
26 use crate::EXTRA_CHECK_CFGS;
27 use crate::{check, Config};
28 use crate::{compile, Crate};
29 use crate::{Build, CLang, DocTests, GitRepo, Mode};
31 pub use crate::Compiler;
32 // FIXME: replace with std::lazy after it gets stabilized and reaches beta
33 use once_cell::sync::{Lazy, OnceCell};
34 use xz2::bufread::XzDecoder;
36 pub struct Builder<'a> {
41 stack: RefCell<Vec<Box<dyn Any>>>,
42 time_spent_on_dependencies: Cell<Duration>,
43 pub paths: Vec<PathBuf>,
46 impl<'a> Deref for Builder<'a> {
49 fn deref(&self) -> &Self::Target {
54 pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
55 /// `PathBuf` when directories are created or to return a `Compiler` once
56 /// it's been assembled.
59 /// Whether this step is run by default as part of its respective phase.
60 /// `true` here can still be overwritten by `should_run` calling `default_condition`.
61 const DEFAULT: bool = false;
63 /// If true, then this rule should be skipped if --target was specified, but --host was not
64 const ONLY_HOSTS: bool = false;
66 /// Primary function to execute this rule. Can call `builder.ensure()`
67 /// with other steps to run those.
68 fn run(self, builder: &Builder<'_>) -> Self::Output;
70 /// When bootstrap is passed a set of paths, this controls whether this rule
71 /// will execute. However, it does not get called in a "default" context
72 /// when we are not passed any paths; in that case, `make_run` is called
74 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
76 /// Builds up a "root" rule, either as a default rule or from a path passed
79 /// When path is `None`, we are executing in a context where no paths were
80 /// passed. When `./x.py build` is run, for example, this rule could get
81 /// called if it is in the correct list below with a path of `None`.
82 fn make_run(_run: RunConfig<'_>) {
83 // It is reasonable to not have an implementation of make_run for rules
84 // who do not want to get called from the root context. This means that
85 // they are likely dependencies (e.g., sysroot creation) or similar, and
86 // as such calling them from ./x.py isn't logical.
91 pub struct RunConfig<'a> {
92 pub builder: &'a Builder<'a>,
93 pub target: TargetSelection,
94 pub paths: Vec<PathSet>,
98 pub fn build_triple(&self) -> TargetSelection {
99 self.builder.build.build
103 struct StepDescription {
106 should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
107 make_run: fn(RunConfig<'_>),
112 #[derive(Clone, PartialOrd, Ord, PartialEq, Eq)]
113 pub struct TaskPath {
115 pub kind: Option<Kind>,
119 pub fn parse(path: impl Into<PathBuf>) -> TaskPath {
121 let mut path = path.into();
123 let mut components = path.components();
124 if let Some(Component::Normal(os_str)) = components.next() {
125 if let Some(str) = os_str.to_str() {
126 if let Some((found_kind, found_prefix)) = str.split_once("::") {
127 if found_kind.is_empty() {
128 panic!("empty kind in task path {}", path.display());
130 kind = Kind::parse(found_kind);
131 assert!(kind.is_some());
132 path = Path::new(found_prefix).join(components.as_path());
137 TaskPath { path, kind }
141 impl Debug for TaskPath {
142 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
143 if let Some(kind) = &self.kind {
144 write!(f, "{}::", kind.as_str())?;
146 write!(f, "{}", self.path.display())
150 /// Collection of paths used to match a task rule.
151 #[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
153 /// A collection of individual paths or aliases.
155 /// These are generally matched as a path suffix. For example, a
156 /// command-line value of `std` will match if `library/std` is in the
159 /// NOTE: the paths within a set should always be aliases of one another.
160 /// For example, `src/librustdoc` and `src/tools/rustdoc` should be in the same set,
161 /// but `library/core` and `library/std` generally should not, unless there's no way (for that Step)
162 /// to build them separately.
163 Set(BTreeSet<TaskPath>),
164 /// A "suite" of paths.
166 /// These can match as a path suffix (like `Set`), or as a prefix. For
167 /// example, a command-line value of `src/test/ui/abi/variadic-ffi.rs`
168 /// will match `src/test/ui`. A command-line value of `ui` would also
169 /// match `src/test/ui`.
174 fn empty() -> PathSet {
175 PathSet::Set(BTreeSet::new())
178 fn one<P: Into<PathBuf>>(path: P, kind: Kind) -> PathSet {
179 let mut set = BTreeSet::new();
180 set.insert(TaskPath { path: path.into(), kind: Some(kind) });
184 fn has(&self, needle: &Path, module: Option<Kind>) -> bool {
186 PathSet::Set(set) => set.iter().any(|p| Self::check(p, needle, module)),
187 PathSet::Suite(suite) => Self::check(suite, needle, module),
192 fn check(p: &TaskPath, needle: &Path, module: Option<Kind>) -> bool {
193 if let (Some(p_kind), Some(kind)) = (&p.kind, module) {
194 p.path.ends_with(needle) && *p_kind == kind
196 p.path.ends_with(needle)
200 /// Return all `TaskPath`s in `Self` that contain any of the `needles`, removing the
203 /// This is used for `StepDescription::krate`, which passes all matching crates at once to
204 /// `Step::make_run`, rather than calling it many times with a single crate.
205 /// See `tests.rs` for examples.
206 fn intersection_removing_matches(
208 needles: &mut Vec<&Path>,
209 module: Option<Kind>,
211 let mut check = |p| {
212 for (i, n) in needles.iter().enumerate() {
213 let matched = Self::check(p, n, module);
222 PathSet::Set(set) => PathSet::Set(set.iter().filter(|&p| check(p)).cloned().collect()),
223 PathSet::Suite(suite) => {
233 /// A convenience wrapper for Steps which know they have no aliases and all their sets contain only a single path.
235 /// This can be used with [`ShouldRun::krate`], [`ShouldRun::path`], or [`ShouldRun::alias`].
237 pub fn assert_single_path(&self) -> &TaskPath {
239 PathSet::Set(set) => {
240 assert_eq!(set.len(), 1, "called assert_single_path on multiple paths");
241 set.iter().next().unwrap()
243 PathSet::Suite(_) => unreachable!("called assert_single_path on a Suite path"),
248 impl StepDescription {
249 fn from<S: Step>(kind: Kind) -> StepDescription {
252 only_hosts: S::ONLY_HOSTS,
253 should_run: S::should_run,
254 make_run: S::make_run,
255 name: std::any::type_name::<S>(),
260 fn maybe_run(&self, builder: &Builder<'_>, pathsets: Vec<PathSet>) {
261 if pathsets.iter().any(|set| self.is_excluded(builder, set)) {
265 // Determine the targets participating in this rule.
266 let targets = if self.only_hosts { &builder.hosts } else { &builder.targets };
268 for target in targets {
269 let run = RunConfig { builder, paths: pathsets.clone(), target: *target };
270 (self.make_run)(run);
274 fn is_excluded(&self, builder: &Builder<'_>, pathset: &PathSet) -> bool {
275 if builder.config.exclude.iter().any(|e| pathset.has(&e.path, e.kind)) {
276 println!("Skipping {:?} because it is excluded", pathset);
280 if !builder.config.exclude.is_empty() {
281 builder.verbose(&format!(
282 "{:?} not skipped for {:?} -- not in {:?}",
283 pathset, self.name, builder.config.exclude
289 fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
292 .map(|desc| (desc.should_run)(ShouldRun::new(builder, desc.kind)))
293 .collect::<Vec<_>>();
295 // sanity checks on rules
296 for (desc, should_run) in v.iter().zip(&should_runs) {
298 !should_run.paths.is_empty(),
299 "{:?} should have at least one pathset",
304 if paths.is_empty() || builder.config.include_default_paths {
305 for (desc, should_run) in v.iter().zip(&should_runs) {
306 if desc.default && should_run.is_really_default() {
307 desc.maybe_run(builder, should_run.paths.iter().cloned().collect());
312 // strip CurDir prefix if present
313 let mut paths: Vec<_> =
314 paths.into_iter().map(|p| p.strip_prefix(".").unwrap_or(p)).collect();
316 // Handle all test suite paths.
317 // (This is separate from the loop below to avoid having to handle multiple paths in `is_suite_path` somehow.)
318 paths.retain(|path| {
319 for (desc, should_run) in v.iter().zip(&should_runs) {
320 if let Some(suite) = should_run.is_suite_path(&path) {
321 desc.maybe_run(builder, vec![suite.clone()]);
328 if paths.is_empty() {
332 // Handle all PathSets.
333 for (desc, should_run) in v.iter().zip(&should_runs) {
334 let pathsets = should_run.pathset_for_paths_removing_matches(&mut paths, desc.kind);
335 if !pathsets.is_empty() {
336 desc.maybe_run(builder, pathsets);
340 if !paths.is_empty() {
341 eprintln!("error: no `{}` rules matched {:?}", builder.kind.as_str(), paths,);
343 "help: run `x.py {} --help --verbose` to show a list of available paths",
344 builder.kind.as_str()
347 "note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`"
349 crate::detail_exit(1);
354 enum ReallyDefault<'a> {
356 Lazy(Lazy<bool, Box<dyn Fn() -> bool + 'a>>),
359 pub struct ShouldRun<'a> {
360 pub builder: &'a Builder<'a>,
363 // use a BTreeSet to maintain sort order
364 paths: BTreeSet<PathSet>,
366 // If this is a default rule, this is an additional constraint placed on
367 // its run. Generally something like compiler docs being enabled.
368 is_really_default: ReallyDefault<'a>,
371 impl<'a> ShouldRun<'a> {
372 fn new(builder: &'a Builder<'_>, kind: Kind) -> ShouldRun<'a> {
376 paths: BTreeSet::new(),
377 is_really_default: ReallyDefault::Bool(true), // by default no additional conditions
381 pub fn default_condition(mut self, cond: bool) -> Self {
382 self.is_really_default = ReallyDefault::Bool(cond);
386 pub fn lazy_default_condition(mut self, lazy_cond: Box<dyn Fn() -> bool + 'a>) -> Self {
387 self.is_really_default = ReallyDefault::Lazy(Lazy::new(lazy_cond));
391 pub fn is_really_default(&self) -> bool {
392 match &self.is_really_default {
393 ReallyDefault::Bool(val) => *val,
394 ReallyDefault::Lazy(lazy) => *lazy.deref(),
398 /// Indicates it should run if the command-line selects the given crate or
399 /// any of its (local) dependencies.
401 /// Compared to `krate`, this treats the dependencies as aliases for the
402 /// same job. Generally it is preferred to use `krate`, and treat each
403 /// individual path separately. For example `./x.py test src/liballoc`
404 /// (which uses `krate`) will test just `liballoc`. However, `./x.py check
405 /// src/liballoc` (which uses `all_krates`) will check all of `libtest`.
406 /// `all_krates` should probably be removed at some point.
407 pub fn all_krates(mut self, name: &str) -> Self {
408 let mut set = BTreeSet::new();
409 for krate in self.builder.in_tree_crates(name, None) {
410 let path = krate.local_path(self.builder);
411 set.insert(TaskPath { path, kind: Some(self.kind) });
413 self.paths.insert(PathSet::Set(set));
417 /// Indicates it should run if the command-line selects the given crate or
418 /// any of its (local) dependencies.
420 /// `make_run` will be called a single time with all matching command-line paths.
421 pub fn crate_or_deps(self, name: &str) -> Self {
422 let crates = self.builder.in_tree_crates(name, None);
426 /// Indicates it should run if the command-line selects any of the given crates.
428 /// `make_run` will be called a single time with all matching command-line paths.
429 pub(crate) fn crates(mut self, crates: Vec<&Crate>) -> Self {
430 for krate in crates {
431 let path = krate.local_path(self.builder);
432 self.paths.insert(PathSet::one(path, self.kind));
437 // single alias, which does not correspond to any on-disk path
438 pub fn alias(mut self, alias: &str) -> Self {
440 !self.builder.src.join(alias).exists(),
441 "use `builder.path()` for real paths: {}",
444 self.paths.insert(PathSet::Set(
445 std::iter::once(TaskPath { path: alias.into(), kind: Some(self.kind) }).collect(),
450 // single, non-aliased path
451 pub fn path(self, path: &str) -> Self {
455 // multiple aliases for the same job
456 pub fn paths(mut self, paths: &[&str]) -> Self {
457 self.paths.insert(PathSet::Set(
461 // FIXME(#96188): make sure this is actually a path.
462 // This currently breaks for paths within submodules.
464 // self.builder.src.join(p).exists(),
465 // "`should_run.paths` should correspond to real on-disk paths - use `alias` if there is no relevant path: {}",
468 TaskPath { path: p.into(), kind: Some(self.kind) }
475 /// Handles individual files (not directories) within a test suite.
476 fn is_suite_path(&self, requested_path: &Path) -> Option<&PathSet> {
477 self.paths.iter().find(|pathset| match pathset {
478 PathSet::Suite(suite) => requested_path.starts_with(&suite.path),
479 PathSet::Set(_) => false,
483 pub fn suite_path(mut self, suite: &str) -> Self {
484 self.paths.insert(PathSet::Suite(TaskPath { path: suite.into(), kind: Some(self.kind) }));
488 // allows being more explicit about why should_run in Step returns the value passed to it
489 pub fn never(mut self) -> ShouldRun<'a> {
490 self.paths.insert(PathSet::empty());
494 /// Given a set of requested paths, return the subset which match the Step for this `ShouldRun`,
495 /// removing the matches from `paths`.
497 /// NOTE: this returns multiple PathSets to allow for the possibility of multiple units of work
498 /// within the same step. For example, `test::Crate` allows testing multiple crates in the same
499 /// cargo invocation, which are put into separate sets because they aren't aliases.
501 /// The reason we return PathSet instead of PathBuf is to allow for aliases that mean the same thing
502 /// (for now, just `all_krates` and `paths`, but we may want to add an `aliases` function in the future?)
503 fn pathset_for_paths_removing_matches(
505 paths: &mut Vec<&Path>,
508 let mut sets = vec![];
509 for pathset in &self.paths {
510 let subset = pathset.intersection_removing_matches(paths, Some(kind));
511 if subset != PathSet::empty() {
519 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug)]
537 pub fn parse(string: &str) -> Option<Kind> {
538 // these strings, including the one-letter aliases, must match the x.py help text
540 "build" | "b" => Kind::Build,
541 "check" | "c" => Kind::Check,
542 "clippy" => Kind::Clippy,
544 "fmt" => Kind::Format,
545 "test" | "t" => Kind::Test,
546 "bench" => Kind::Bench,
547 "doc" | "d" => Kind::Doc,
548 "clean" => Kind::Clean,
549 "dist" => Kind::Dist,
550 "install" => Kind::Install,
551 "run" | "r" => Kind::Run,
552 "setup" => Kind::Setup,
557 pub fn as_str(&self) -> &'static str {
559 Kind::Build => "build",
560 Kind::Check => "check",
561 Kind::Clippy => "clippy",
563 Kind::Format => "fmt",
564 Kind::Test => "test",
565 Kind::Bench => "bench",
567 Kind::Clean => "clean",
568 Kind::Dist => "dist",
569 Kind::Install => "install",
571 Kind::Setup => "setup",
576 impl<'a> Builder<'a> {
577 fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
578 macro_rules! describe {
579 ($($rule:ty),+ $(,)?) => {{
580 vec![$(StepDescription::from::<$rule>(kind)),+]
584 Kind::Build => describe!(
588 compile::CodegenBackend,
589 compile::StartupObjects,
593 tool::UnstableBookGen,
598 tool::RemoteTestServer,
599 tool::RemoteTestClient,
604 tool::RustAnalyzerProcMacroSrv,
617 Kind::Check | Kind::Clippy | Kind::Fix => describe!(
621 check::CodegenBackend,
629 Kind::Test => describe!(
630 crate::toolstate::ToolStateCheck,
631 test::ExpandYamlAnchors,
634 test::RunPassValgrind,
647 test::CrateRustdocJsonTypes,
650 test::ReplacePlaceholderTest,
656 test::RunMakeFullDeps,
672 test::CompiletestTest,
674 test::RustdocJSNotStd,
680 // Run bootstrap close to the end as it's unlikely to fail
682 // Run run-make last, since these won't pass without make on Windows
685 Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
686 Kind::Doc => describe!(
688 doc::UnstableBookGen,
708 Kind::Dist => describe!(
727 // It seems that PlainSourceTarball somehow changes how some of the tools
728 // perceive their dependencies (see #93033) which would invalidate fingerprints
729 // and force us to rebuild tools after vendoring dependencies.
730 // To work around this, create the Tarball after building all the tools.
731 dist::PlainSourceTarball,
733 dist::ReproducibleArtifacts,
735 Kind::Install => describe!(
739 install::RustAnalyzer,
741 install::RustDemangler,
748 Kind::Run => describe!(
749 run::ExpandYamlAnchors,
752 run::ReplaceVersionPlaceholder,
754 // These commands either don't use paths, or they're special-cased in Build::build()
755 Kind::Clean | Kind::Format | Kind::Setup => vec![],
759 pub fn get_help(build: &Build, kind: Kind) -> Option<String> {
760 let step_descriptions = Builder::get_step_descriptions(kind);
761 if step_descriptions.is_empty() {
765 let builder = Self::new_internal(build, kind, vec![]);
766 let builder = &builder;
767 // The "build" kind here is just a placeholder, it will be replaced with something else in
768 // the following statement.
769 let mut should_run = ShouldRun::new(builder, Kind::Build);
770 for desc in step_descriptions {
771 should_run.kind = desc.kind;
772 should_run = (desc.should_run)(should_run);
774 let mut help = String::from("Available paths:\n");
775 let mut add_path = |path: &Path| {
776 t!(write!(help, " ./x.py {} {}\n", kind.as_str(), path.display()));
778 for pathset in should_run.paths {
780 PathSet::Set(set) => {
782 add_path(&path.path);
785 PathSet::Suite(path) => {
786 add_path(&path.path.join("..."));
793 fn new_internal(build: &Build, kind: Kind, paths: Vec<PathBuf>) -> Builder<'_> {
796 top_stage: build.config.stage,
799 stack: RefCell::new(Vec::new()),
800 time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
805 pub fn new(build: &Build) -> Builder<'_> {
806 let (kind, paths) = match build.config.cmd {
807 Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
808 Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
809 Subcommand::Clippy { ref paths, .. } => (Kind::Clippy, &paths[..]),
810 Subcommand::Fix { ref paths } => (Kind::Fix, &paths[..]),
811 Subcommand::Doc { ref paths, .. } => (Kind::Doc, &paths[..]),
812 Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
813 Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
814 Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
815 Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
816 Subcommand::Run { ref paths } => (Kind::Run, &paths[..]),
817 Subcommand::Format { .. } => (Kind::Format, &[][..]),
818 Subcommand::Clean { .. } | Subcommand::Setup { .. } => {
823 Self::new_internal(build, kind, paths.to_owned())
826 pub fn execute_cli(&self) {
827 self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
830 pub fn default_doc(&self, paths: &[PathBuf]) {
831 self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
834 /// NOTE: keep this in sync with `rustdoc::clean::utils::doc_rust_lang_org_channel`, or tests will fail on beta/stable.
835 pub fn doc_rust_lang_org_channel(&self) -> String {
836 let channel = match &*self.config.channel {
837 "stable" => &self.version,
839 "nightly" | "dev" => "nightly",
840 // custom build of rustdoc maybe? link to the latest stable docs just in case
843 "https://doc.rust-lang.org/".to_owned() + channel
846 fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
847 StepDescription::run(v, self, paths);
850 /// Modifies the interpreter section of 'fname' to fix the dynamic linker,
851 /// or the RPATH section, to fix the dynamic library search path
853 /// This is only required on NixOS and uses the PatchELF utility to
854 /// change the interpreter/RPATH of ELF executables.
856 /// Please see https://nixos.org/patchelf.html for more information
857 pub(crate) fn fix_bin_or_dylib(&self, fname: &Path) {
858 // FIXME: cache NixOS detection?
859 match Command::new("uname").arg("-s").stderr(Stdio::inherit()).output() {
861 Ok(output) if !output.status.success() => return,
863 let mut s = output.stdout;
864 if s.last() == Some(&b'\n') {
873 // If the user has asked binaries to be patched for Nix, then
874 // don't check for NixOS or `/lib`, just continue to the patching.
875 // NOTE: this intentionally comes after the Linux check:
876 // - patchelf only works with ELF files, so no need to run it on Mac or Windows
877 // - On other Unix systems, there is no stable syscall interface, so Nix doesn't manage the global libc.
878 if !self.config.patch_binaries_for_nix {
879 // Use `/etc/os-release` instead of `/etc/NIXOS`.
880 // The latter one does not exist on NixOS when using tmpfs as root.
881 const NIX_IDS: &[&str] = &["ID=nixos", "ID='nixos'", "ID=\"nixos\""];
882 let os_release = match File::open("/etc/os-release") {
883 Err(e) if e.kind() == ErrorKind::NotFound => return,
884 Err(e) => panic!("failed to access /etc/os-release: {}", e),
887 if !BufReader::new(os_release).lines().any(|l| NIX_IDS.contains(&t!(l).trim())) {
890 if Path::new("/lib").exists() {
895 // At this point we're pretty sure the user is running NixOS or using Nix
896 println!("info: you seem to be using Nix. Attempting to patch {}", fname.display());
898 // Only build `.nix-deps` once.
899 static NIX_DEPS_DIR: OnceCell<PathBuf> = OnceCell::new();
900 let mut nix_build_succeeded = true;
901 let nix_deps_dir = NIX_DEPS_DIR.get_or_init(|| {
902 // Run `nix-build` to "build" each dependency (which will likely reuse
903 // the existing `/nix/store` copy, or at most download a pre-built copy).
905 // Importantly, we create a gc-root called `.nix-deps` in the `build/`
906 // directory, but still reference the actual `/nix/store` path in the rpath
907 // as it makes it significantly more robust against changes to the location of
908 // the `.nix-deps` location.
910 // bintools: Needed for the path of `ld-linux.so` (via `nix-support/dynamic-linker`).
911 // zlib: Needed as a system dependency of `libLLVM-*.so`.
912 // patchelf: Needed for patching ELF binaries (see doc comment above).
913 let nix_deps_dir = self.out.join(".nix-deps");
914 const NIX_EXPR: &str = "
915 with (import <nixpkgs> {});
917 name = \"rust-stage0-dependencies\";
925 nix_build_succeeded = self.try_run(Command::new("nix-build").args(&[
933 if !nix_build_succeeded {
937 let mut patchelf = Command::new(nix_deps_dir.join("bin/patchelf"));
938 let rpath_entries = {
939 // ORIGIN is a relative default, all binary and dynamic libraries we ship
940 // appear to have this (even when `../lib` is redundant).
941 // NOTE: there are only two paths here, delimited by a `:`
942 let mut entries = OsString::from("$ORIGIN/../lib:");
943 entries.push(t!(fs::canonicalize(nix_deps_dir)));
944 entries.push("/lib");
947 patchelf.args(&[OsString::from("--set-rpath"), rpath_entries]);
948 if !fname.extension().map_or(false, |ext| ext == "so") {
949 // Finally, set the corret .interp for binaries
950 let dynamic_linker_path = nix_deps_dir.join("nix-support/dynamic-linker");
951 // FIXME: can we support utf8 here? `args` doesn't accept Vec<u8>, only OsString ...
952 let dynamic_linker = t!(String::from_utf8(t!(fs::read(dynamic_linker_path))));
953 patchelf.args(&["--set-interpreter", dynamic_linker.trim_end()]);
956 self.try_run(patchelf.arg(fname));
959 pub(crate) fn download_component(&self, url: &str, dest_path: &Path, help_on_error: &str) {
960 self.verbose(&format!("download {url}"));
961 // Use a temporary file in case we crash while downloading, to avoid a corrupt download in cache/.
962 let tempfile = self.tempdir().join(dest_path.file_name().unwrap());
963 // While bootstrap itself only supports http and https downloads, downstream forks might
964 // need to download components from other protocols. The match allows them adding more
965 // protocols without worrying about merge conficts if we change the HTTP implementation.
966 match url.split_once("://").map(|(proto, _)| proto) {
967 Some("http") | Some("https") => {
968 self.download_http_with_retries(&tempfile, url, help_on_error)
970 Some(other) => panic!("unsupported protocol {other} in {url}"),
971 None => panic!("no protocol in {url}"),
973 t!(std::fs::rename(&tempfile, dest_path));
976 fn download_http_with_retries(&self, tempfile: &Path, url: &str, help_on_error: &str) {
977 println!("downloading {}", url);
978 // Try curl. If that fails and we are on windows, fallback to PowerShell.
979 let mut curl = Command::new("curl");
985 "10", // timeout if speed is < 10 bytes/sec for > 30 seconds
987 "30", // timeout if cannot connect within 30 seconds
995 if !self.check_run(&mut curl) {
996 if self.build.build.contains("windows-msvc") {
997 println!("Fallback to PowerShell");
999 if self.try_run(Command::new("PowerShell.exe").args(&[
1002 "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;",
1004 "(New-Object System.Net.WebClient).DownloadFile('{}', '{}')",
1005 url, tempfile.to_str().expect("invalid UTF-8 not supported with powershell downloads"),
1010 println!("\nspurious failure, trying again");
1013 if !help_on_error.is_empty() {
1014 eprintln!("{}", help_on_error);
1016 crate::detail_exit(1);
1020 pub(crate) fn unpack(&self, tarball: &Path, dst: &Path, pattern: &str) {
1021 println!("extracting {} to {}", tarball.display(), dst.display());
1023 t!(fs::create_dir_all(dst));
1026 // `tarball` ends with `.tar.xz`; strip that suffix
1027 // example: `rust-dev-nightly-x86_64-unknown-linux-gnu`
1028 let uncompressed_filename =
1029 Path::new(tarball.file_name().expect("missing tarball filename")).file_stem().unwrap();
1030 let directory_prefix = Path::new(Path::new(uncompressed_filename).file_stem().unwrap());
1032 // decompress the file
1033 let data = t!(File::open(tarball));
1034 let decompressor = XzDecoder::new(BufReader::new(data));
1036 let mut tar = tar::Archive::new(decompressor);
1037 for member in t!(tar.entries()) {
1038 let mut member = t!(member);
1039 let original_path = t!(member.path()).into_owned();
1040 // skip the top-level directory
1041 if original_path == directory_prefix {
1044 let mut short_path = t!(original_path.strip_prefix(directory_prefix));
1045 if !short_path.starts_with(pattern) {
1048 short_path = t!(short_path.strip_prefix(pattern));
1049 let dst_path = dst.join(short_path);
1050 self.verbose(&format!("extracting {} to {}", original_path.display(), dst.display()));
1051 if !t!(member.unpack_in(dst)) {
1052 panic!("path traversal attack ??");
1054 let src_path = dst.join(original_path);
1055 if src_path.is_dir() && dst_path.exists() {
1058 t!(fs::rename(src_path, dst_path));
1060 t!(fs::remove_dir_all(dst.join(directory_prefix)));
1063 /// Returns whether the SHA256 checksum of `path` matches `expected`.
1064 pub(crate) fn verify(&self, path: &Path, expected: &str) -> bool {
1067 self.verbose(&format!("verifying {}", path.display()));
1068 let mut hasher = sha2::Sha256::new();
1069 // FIXME: this is ok for rustfmt (4.1 MB large at time of writing), but it seems memory-intensive for rustc and larger components.
1070 // Consider using streaming IO instead?
1071 let contents = if self.config.dry_run { vec![] } else { t!(fs::read(path)) };
1072 hasher.update(&contents);
1073 let found = hex::encode(hasher.finalize().as_slice());
1074 let verified = found == expected;
1075 if !verified && !self.config.dry_run {
1077 "invalid checksum: \n\
1079 expected: {expected}",
1085 /// Obtain a compiler at a given stage and for a given host. Explicitly does
1086 /// not take `Compiler` since all `Compiler` instances are meant to be
1087 /// obtained through this function, since it ensures that they are valid
1088 /// (i.e., built and assembled).
1089 pub fn compiler(&self, stage: u32, host: TargetSelection) -> Compiler {
1090 self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
1093 /// Similar to `compiler`, except handles the full-bootstrap option to
1094 /// silently use the stage1 compiler instead of a stage2 compiler if one is
1097 /// Note that this does *not* have the side effect of creating
1098 /// `compiler(stage, host)`, unlike `compiler` above which does have such
1099 /// a side effect. The returned compiler here can only be used to compile
1100 /// new artifacts, it can't be used to rely on the presence of a particular
1103 /// See `force_use_stage1` for documentation on what each argument is.
1104 pub fn compiler_for(
1107 host: TargetSelection,
1108 target: TargetSelection,
1110 if self.build.force_use_stage1(Compiler { stage, host }, target) {
1111 self.compiler(1, self.config.build)
1113 self.compiler(stage, host)
1117 pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
1118 self.ensure(compile::Sysroot { compiler })
1121 /// Returns the libdir where the standard library and other artifacts are
1122 /// found for a compiler's sysroot.
1123 pub fn sysroot_libdir(&self, compiler: Compiler, target: TargetSelection) -> Interned<PathBuf> {
1124 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
1127 target: TargetSelection,
1129 impl Step for Libdir {
1130 type Output = Interned<PathBuf>;
1132 fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
1136 fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
1137 let lib = builder.sysroot_libdir_relative(self.compiler);
1138 let sysroot = builder
1139 .sysroot(self.compiler)
1142 .join(self.target.triple)
1144 // Avoid deleting the rustlib/ directory we just copied
1145 // (in `impl Step for Sysroot`).
1146 if !builder.download_rustc() {
1147 let _ = fs::remove_dir_all(&sysroot);
1148 t!(fs::create_dir_all(&sysroot));
1150 INTERNER.intern_path(sysroot)
1153 self.ensure(Libdir { compiler, target })
1156 pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
1157 self.sysroot_libdir(compiler, compiler.host).with_file_name("codegen-backends")
1160 /// Returns the compiler's libdir where it stores the dynamic libraries that
1161 /// it itself links against.
1163 /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
1165 pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
1166 if compiler.is_snapshot(self) {
1167 self.rustc_snapshot_libdir()
1169 match self.config.libdir_relative() {
1170 Some(relative_libdir) if compiler.stage >= 1 => {
1171 self.sysroot(compiler).join(relative_libdir)
1173 _ => self.sysroot(compiler).join(libdir(compiler.host)),
1178 /// Returns the compiler's relative libdir where it stores the dynamic libraries that
1179 /// it itself links against.
1181 /// For example this returns `lib` on Unix and `bin` on
1183 pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
1184 if compiler.is_snapshot(self) {
1185 libdir(self.config.build).as_ref()
1187 match self.config.libdir_relative() {
1188 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
1189 _ => libdir(compiler.host).as_ref(),
1194 /// Returns the compiler's relative libdir where the standard library and other artifacts are
1195 /// found for a compiler's sysroot.
1197 /// For example this returns `lib` on Unix and Windows.
1198 pub fn sysroot_libdir_relative(&self, compiler: Compiler) -> &Path {
1199 match self.config.libdir_relative() {
1200 Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
1201 _ if compiler.stage == 0 => &self.build.initial_libdir,
1202 _ => Path::new("lib"),
1206 pub fn rustc_lib_paths(&self, compiler: Compiler) -> Vec<PathBuf> {
1207 let mut dylib_dirs = vec![self.rustc_libdir(compiler)];
1209 // Ensure that the downloaded LLVM libraries can be found.
1210 if self.config.llvm_from_ci {
1211 let ci_llvm_lib = self.out.join(&*compiler.host.triple).join("ci-llvm").join("lib");
1212 dylib_dirs.push(ci_llvm_lib);
1218 /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
1219 /// library lookup path.
1220 pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
1221 // Windows doesn't need dylib path munging because the dlls for the
1222 // compiler live next to the compiler and the system will find them
1228 add_dylib_path(self.rustc_lib_paths(compiler), cmd);
1231 /// Gets a path to the compiler specified.
1232 pub fn rustc(&self, compiler: Compiler) -> PathBuf {
1233 if compiler.is_snapshot(self) {
1234 self.initial_rustc.clone()
1236 self.sysroot(compiler).join("bin").join(exe("rustc", compiler.host))
1240 /// Gets the paths to all of the compiler's codegen backends.
1241 fn codegen_backends(&self, compiler: Compiler) -> impl Iterator<Item = PathBuf> {
1242 fs::read_dir(self.sysroot_codegen_backends(compiler))
1245 .filter_map(Result::ok)
1246 .map(|entry| entry.path())
1249 pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
1250 self.ensure(tool::Rustdoc { compiler })
1253 pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
1254 let mut cmd = Command::new(&self.bootstrap_out.join("rustdoc"));
1255 cmd.env("RUSTC_STAGE", compiler.stage.to_string())
1256 .env("RUSTC_SYSROOT", self.sysroot(compiler))
1257 // Note that this is *not* the sysroot_libdir because rustdoc must be linked
1258 // equivalently to rustc.
1259 .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
1260 .env("CFG_RELEASE_CHANNEL", &self.config.channel)
1261 .env("RUSTDOC_REAL", self.rustdoc(compiler))
1262 .env("RUSTC_BOOTSTRAP", "1");
1264 cmd.arg("-Wrustdoc::invalid_codeblock_attributes");
1266 if self.config.deny_warnings {
1267 cmd.arg("-Dwarnings");
1269 cmd.arg("-Znormalize-docs");
1271 // Remove make-related flags that can cause jobserver problems.
1272 cmd.env_remove("MAKEFLAGS");
1273 cmd.env_remove("MFLAGS");
1275 if let Some(linker) = self.linker(compiler.host) {
1276 cmd.env("RUSTDOC_LINKER", linker);
1278 if self.is_fuse_ld_lld(compiler.host) {
1279 cmd.env("RUSTDOC_FUSE_LD_LLD", "1");
1284 /// Return the path to `llvm-config` for the target, if it exists.
1286 /// Note that this returns `None` if LLVM is disabled, or if we're in a
1287 /// check build or dry-run, where there's no need to build all of LLVM.
1288 fn llvm_config(&self, target: TargetSelection) -> Option<PathBuf> {
1289 if self.config.llvm_enabled() && self.kind != Kind::Check && !self.config.dry_run {
1290 let llvm_config = self.ensure(native::Llvm { target });
1291 if llvm_config.is_file() {
1292 return Some(llvm_config);
1298 /// Convenience wrapper to allow `builder.llvm_link_shared()` instead of `builder.config.llvm_link_shared(&builder)`.
1299 pub(crate) fn llvm_link_shared(&self) -> bool {
1300 Config::llvm_link_shared(self)
1303 pub(crate) fn download_rustc(&self) -> bool {
1304 Config::download_rustc(self)
1307 pub(crate) fn initial_rustfmt(&self) -> Option<PathBuf> {
1308 Config::initial_rustfmt(self)
1311 /// Prepares an invocation of `cargo` to be run.
1313 /// This will create a `Command` that represents a pending execution of
1314 /// Cargo. This cargo will be configured to use `compiler` as the actual
1315 /// rustc compiler, its output will be scoped by `mode`'s output directory,
1316 /// it will pass the `--target` flag for the specified `target`, and will be
1317 /// executing the Cargo command `cmd`.
1322 source_type: SourceType,
1323 target: TargetSelection,
1326 let mut cargo = Command::new(&self.initial_cargo);
1327 let out_dir = self.stage_out(compiler, mode);
1329 // Codegen backends are not yet tracked by -Zbinary-dep-depinfo,
1330 // so we need to explicitly clear out if they've been updated.
1331 for backend in self.codegen_backends(compiler) {
1332 self.clear_if_dirty(&out_dir, &backend);
1335 if cmd == "doc" || cmd == "rustdoc" {
1336 let my_out = match mode {
1337 // This is the intended out directory for compiler documentation.
1338 Mode::Rustc | Mode::ToolRustc => self.compiler_doc_out(target),
1339 Mode::Std => out_dir.join(target.triple).join("doc"),
1340 _ => panic!("doc mode {:?} not expected", mode),
1342 let rustdoc = self.rustdoc(compiler);
1343 self.clear_if_dirty(&my_out, &rustdoc);
1346 cargo.env("CARGO_TARGET_DIR", &out_dir).arg(cmd);
1348 let profile_var = |name: &str| {
1349 let profile = if self.config.rust_optimize { "RELEASE" } else { "DEV" };
1350 format!("CARGO_PROFILE_{}_{}", profile, name)
1353 // See comment in rustc_llvm/build.rs for why this is necessary, largely llvm-config
1354 // needs to not accidentally link to libLLVM in stage0/lib.
1355 cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
1356 if let Some(e) = env::var_os(util::dylib_path_var()) {
1357 cargo.env("REAL_LIBRARY_PATH", e);
1360 // Found with `rg "init_env_logger\("`. If anyone uses `init_env_logger`
1361 // from out of tree it shouldn't matter, since x.py is only used for
1362 // building in-tree.
1363 let color_logs = ["RUSTDOC_LOG_COLOR", "RUSTC_LOG_COLOR", "RUST_LOG_COLOR"];
1364 match self.build.config.color {
1366 cargo.arg("--color=always");
1367 for log in &color_logs {
1368 cargo.env(log, "always");
1372 cargo.arg("--color=never");
1373 for log in &color_logs {
1374 cargo.env(log, "never");
1377 Color::Auto => {} // nothing to do
1380 if cmd != "install" {
1381 cargo.arg("--target").arg(target.rustc_target_arg());
1383 assert_eq!(target, compiler.host);
1386 // Set a flag for `check`/`clippy`/`fix`, so that certain build
1387 // scripts can do less work (i.e. not building/requiring LLVM).
1388 if cmd == "check" || cmd == "clippy" || cmd == "fix" {
1389 // If we've not yet built LLVM, or it's stale, then bust
1390 // the rustc_llvm cache. That will always work, even though it
1391 // may mean that on the next non-check build we'll need to rebuild
1392 // rustc_llvm. But if LLVM is stale, that'll be a tiny amount
1393 // of work comparatively, and we'd likely need to rebuild it anyway,
1395 if crate::native::prebuilt_llvm_config(self, target).is_err() {
1396 cargo.env("RUST_CHECK", "1");
1400 let stage = if compiler.stage == 0 && self.local_rebuild {
1401 // Assume the local-rebuild rustc already has stage1 features.
1407 let mut rustflags = Rustflags::new(target);
1409 if let Ok(s) = env::var("CARGOFLAGS_NOT_BOOTSTRAP") {
1410 cargo.args(s.split_whitespace());
1412 rustflags.env("RUSTFLAGS_NOT_BOOTSTRAP");
1414 if let Ok(s) = env::var("CARGOFLAGS_BOOTSTRAP") {
1415 cargo.args(s.split_whitespace());
1417 rustflags.env("RUSTFLAGS_BOOTSTRAP");
1418 if cmd == "clippy" {
1419 // clippy overwrites sysroot if we pass it to cargo.
1420 // Pass it directly to clippy instead.
1421 // NOTE: this can't be fixed in clippy because we explicitly don't set `RUSTC`,
1422 // so it has no way of knowing the sysroot.
1423 rustflags.arg("--sysroot");
1425 self.sysroot(compiler)
1428 .expect("sysroot must be valid UTF-8"),
1430 // Only run clippy on a very limited subset of crates (in particular, not build scripts).
1431 cargo.arg("-Zunstable-options");
1432 // Explicitly does *not* set `--cfg=bootstrap`, since we're using a nightly clippy.
1433 let host_version = Command::new("rustc").arg("--version").output().map_err(|_| ());
1434 let output = host_version.and_then(|output| {
1435 if output.status.success() {
1440 }).unwrap_or_else(|_| {
1442 "error: `x.py clippy` requires a host `rustc` toolchain with the `clippy` component"
1444 eprintln!("help: try `rustup component add clippy`");
1445 crate::detail_exit(1);
1447 if !t!(std::str::from_utf8(&output.stdout)).contains("nightly") {
1448 rustflags.arg("--cfg=bootstrap");
1451 rustflags.arg("--cfg=bootstrap");
1455 let use_new_symbol_mangling = match self.config.rust_new_symbol_mangling {
1457 // If an explicit setting is given, use that
1461 if mode == Mode::Std {
1462 // The standard library defaults to the legacy scheme
1465 // The compiler and tools default to the new scheme
1471 if use_new_symbol_mangling {
1472 rustflags.arg("-Csymbol-mangling-version=v0");
1474 rustflags.arg("-Csymbol-mangling-version=legacy");
1475 rustflags.arg("-Zunstable-options");
1478 // Enable cfg checking of cargo features for everything but std and also enable cfg
1479 // checking of names and values.
1481 // Note: `std`, `alloc` and `core` imports some dependencies by #[path] (like
1482 // backtrace, core_simd, std_float, ...), those dependencies have their own
1483 // features but cargo isn't involved in the #[path] process and so cannot pass the
1484 // complete list of features, so for that reason we don't enable checking of
1485 // features for std crates.
1486 cargo.arg(if mode != Mode::Std {
1487 "-Zcheck-cfg=names,values,output,features"
1489 "-Zcheck-cfg=names,values,output"
1492 // Add extra cfg not defined in/by rustc
1494 // Note: Altrough it would seems that "-Zunstable-options" to `rustflags` is useless as
1495 // cargo would implicitly add it, it was discover that sometimes bootstrap only use
1496 // `rustflags` without `cargo` making it required.
1497 rustflags.arg("-Zunstable-options");
1498 for (restricted_mode, name, values) in EXTRA_CHECK_CFGS {
1499 if *restricted_mode == None || *restricted_mode == Some(mode) {
1500 // Creating a string of the values by concatenating each value:
1501 // ',"tvos","watchos"' or '' (nothing) when there are no values
1502 let values = match values {
1503 Some(values) => values
1505 .map(|val| [",", "\"", val, "\""])
1507 .collect::<String>(),
1508 None => String::new(),
1510 rustflags.arg(&format!("--check-cfg=values({name}{values})"));
1514 // FIXME: It might be better to use the same value for both `RUSTFLAGS` and `RUSTDOCFLAGS`,
1515 // but this breaks CI. At the very least, stage0 `rustdoc` needs `--cfg bootstrap`. See
1517 let mut rustdocflags = rustflags.clone();
1518 rustdocflags.propagate_cargo_env("RUSTDOCFLAGS");
1520 rustdocflags.env("RUSTDOCFLAGS_BOOTSTRAP");
1522 rustdocflags.env("RUSTDOCFLAGS_NOT_BOOTSTRAP");
1525 if let Ok(s) = env::var("CARGOFLAGS") {
1526 cargo.args(s.split_whitespace());
1530 Mode::Std | Mode::ToolBootstrap | Mode::ToolStd => {}
1531 Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
1532 // Build proc macros both for the host and the target
1533 if target != compiler.host && cmd != "check" {
1534 cargo.arg("-Zdual-proc-macros");
1535 rustflags.arg("-Zdual-proc-macros");
1540 // This tells Cargo (and in turn, rustc) to output more complete
1541 // dependency information. Most importantly for rustbuild, this
1542 // includes sysroot artifacts, like libstd, which means that we don't
1543 // need to track those in rustbuild (an error prone process!). This
1544 // feature is currently unstable as there may be some bugs and such, but
1545 // it represents a big improvement in rustbuild's reliability on
1546 // rebuilds, so we're using it here.
1548 // For some additional context, see #63470 (the PR originally adding
1549 // this), as well as #63012 which is the tracking issue for this
1550 // feature on the rustc side.
1551 cargo.arg("-Zbinary-dep-depinfo");
1553 Mode::ToolBootstrap => {
1554 // Restrict the allowed features to those passed by rustbuild, so we don't depend on nightly accidentally.
1555 // HACK: because anyhow does feature detection in build.rs, we need to allow the backtrace feature too.
1556 rustflags.arg("-Zallow-features=binary-dep-depinfo,backtrace");
1559 // Right now this is just compiletest and a few other tools that build on stable.
1560 // Allow them to use `feature(test)`, but nothing else.
1561 rustflags.arg("-Zallow-features=binary-dep-depinfo,test,backtrace,proc_macro_internals,proc_macro_diagnostic,proc_macro_span");
1563 Mode::Std | Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {}
1566 cargo.arg("-j").arg(self.jobs().to_string());
1567 // Remove make-related flags to ensure Cargo can correctly set things up
1568 cargo.env_remove("MAKEFLAGS");
1569 cargo.env_remove("MFLAGS");
1571 // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
1572 // Force cargo to output binaries with disambiguating hashes in the name
1573 let mut metadata = if compiler.stage == 0 {
1574 // Treat stage0 like a special channel, whether it's a normal prior-
1575 // release rustc or a local rebuild with the same version, so we
1576 // never mix these libraries by accident.
1577 "bootstrap".to_string()
1579 self.config.channel.to_string()
1581 // We want to make sure that none of the dependencies between
1582 // std/test/rustc unify with one another. This is done for weird linkage
1583 // reasons but the gist of the problem is that if librustc, libtest, and
1584 // libstd all depend on libc from crates.io (which they actually do) we
1585 // want to make sure they all get distinct versions. Things get really
1586 // weird if we try to unify all these dependencies right now, namely
1587 // around how many times the library is linked in dynamic libraries and
1588 // such. If rustc were a static executable or if we didn't ship dylibs
1589 // this wouldn't be a problem, but we do, so it is. This is in general
1590 // just here to make sure things build right. If you can remove this and
1591 // things still build right, please do!
1593 Mode::Std => metadata.push_str("std"),
1594 // When we're building rustc tools, they're built with a search path
1595 // that contains things built during the rustc build. For example,
1596 // bitflags is built during the rustc build, and is a dependency of
1597 // rustdoc as well. We're building rustdoc in a different target
1598 // directory, though, which means that Cargo will rebuild the
1599 // dependency. When we go on to build rustdoc, we'll look for
1600 // bitflags, and find two different copies: one built during the
1601 // rustc step and one that we just built. This isn't always a
1602 // problem, somehow -- not really clear why -- but we know that this
1604 Mode::ToolRustc => metadata.push_str("tool-rustc"),
1605 // Same for codegen backends.
1606 Mode::Codegen => metadata.push_str("codegen"),
1609 cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
1611 if cmd == "clippy" {
1612 rustflags.arg("-Zforce-unstable-if-unmarked");
1615 rustflags.arg("-Zmacro-backtrace");
1617 let want_rustdoc = self.doc_tests != DocTests::No;
1619 // We synthetically interpret a stage0 compiler used to build tools as a
1620 // "raw" compiler in that it's the exact snapshot we download. Normally
1621 // the stage0 build means it uses libraries build by the stage0
1622 // compiler, but for tools we just use the precompiled libraries that
1624 let use_snapshot = mode == Mode::ToolBootstrap;
1625 assert!(!use_snapshot || stage == 0 || self.local_rebuild);
1627 let maybe_sysroot = self.sysroot(compiler);
1628 let sysroot = if use_snapshot { self.rustc_snapshot_sysroot() } else { &maybe_sysroot };
1629 let libdir = self.rustc_libdir(compiler);
1631 // Clear the output directory if the real rustc we're using has changed;
1632 // Cargo cannot detect this as it thinks rustc is bootstrap/debug/rustc.
1634 // Avoid doing this during dry run as that usually means the relevant
1635 // compiler is not yet linked/copied properly.
1637 // Only clear out the directory if we're compiling std; otherwise, we
1638 // should let Cargo take care of things for us (via depdep info)
1639 if !self.config.dry_run && mode == Mode::Std && cmd == "build" {
1640 self.clear_if_dirty(&out_dir, &self.rustc(compiler));
1643 // Customize the compiler we're running. Specify the compiler to cargo
1644 // as our shim and then pass it some various options used to configure
1645 // how the actual compiler itself is called.
1647 // These variables are primarily all read by
1648 // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
1650 .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
1651 .env("RUSTC_REAL", self.rustc(compiler))
1652 .env("RUSTC_STAGE", stage.to_string())
1653 .env("RUSTC_SYSROOT", &sysroot)
1654 .env("RUSTC_LIBDIR", &libdir)
1655 .env("RUSTDOC", self.bootstrap_out.join("rustdoc"))
1658 if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
1659 self.rustdoc(compiler)
1661 PathBuf::from("/path/to/nowhere/rustdoc/not/required")
1664 .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir())
1665 .env("RUSTC_BREAK_ON_ICE", "1");
1666 // Clippy support is a hack and uses the default `cargo-clippy` in path.
1667 // Don't override RUSTC so that the `cargo-clippy` in path will be run.
1668 if cmd != "clippy" {
1669 cargo.env("RUSTC", self.bootstrap_out.join("rustc"));
1672 // Dealing with rpath here is a little special, so let's go into some
1673 // detail. First off, `-rpath` is a linker option on Unix platforms
1674 // which adds to the runtime dynamic loader path when looking for
1675 // dynamic libraries. We use this by default on Unix platforms to ensure
1676 // that our nightlies behave the same on Windows, that is they work out
1677 // of the box. This can be disabled, of course, but basically that's why
1678 // we're gated on RUSTC_RPATH here.
1680 // Ok, so the astute might be wondering "why isn't `-C rpath` used
1681 // here?" and that is indeed a good question to ask. This codegen
1682 // option is the compiler's current interface to generating an rpath.
1683 // Unfortunately it doesn't quite suffice for us. The flag currently
1684 // takes no value as an argument, so the compiler calculates what it
1685 // should pass to the linker as `-rpath`. This unfortunately is based on
1686 // the **compile time** directory structure which when building with
1687 // Cargo will be very different than the runtime directory structure.
1689 // All that's a really long winded way of saying that if we use
1690 // `-Crpath` then the executables generated have the wrong rpath of
1691 // something like `$ORIGIN/deps` when in fact the way we distribute
1692 // rustc requires the rpath to be `$ORIGIN/../lib`.
1694 // So, all in all, to set up the correct rpath we pass the linker
1695 // argument manually via `-C link-args=-Wl,-rpath,...`. Plus isn't it
1696 // fun to pass a flag to a tool to pass a flag to pass a flag to a tool
1697 // to change a flag in a binary?
1698 if self.config.rust_rpath && util::use_host_linker(target) {
1699 let rpath = if target.contains("apple") {
1700 // Note that we need to take one extra step on macOS to also pass
1701 // `-Wl,-instal_name,@rpath/...` to get things to work right. To
1702 // do that we pass a weird flag to the compiler to get it to do
1703 // so. Note that this is definitely a hack, and we should likely
1704 // flesh out rpath support more fully in the future.
1705 rustflags.arg("-Zosx-rpath-install-name");
1706 Some("-Wl,-rpath,@loader_path/../lib")
1707 } else if !target.contains("windows") {
1708 rustflags.arg("-Clink-args=-Wl,-z,origin");
1709 Some("-Wl,-rpath,$ORIGIN/../lib")
1713 if let Some(rpath) = rpath {
1714 rustflags.arg(&format!("-Clink-args={}", rpath));
1718 if let Some(host_linker) = self.linker(compiler.host) {
1719 cargo.env("RUSTC_HOST_LINKER", host_linker);
1721 if self.is_fuse_ld_lld(compiler.host) {
1722 cargo.env("RUSTC_HOST_FUSE_LD_LLD", "1");
1723 cargo.env("RUSTDOC_FUSE_LD_LLD", "1");
1726 if let Some(target_linker) = self.linker(target) {
1727 let target = crate::envify(&target.triple);
1728 cargo.env(&format!("CARGO_TARGET_{}_LINKER", target), target_linker);
1730 if self.is_fuse_ld_lld(target) {
1731 rustflags.arg("-Clink-args=-fuse-ld=lld");
1733 self.lld_flags(target).for_each(|flag| {
1734 rustdocflags.arg(&flag);
1737 if !(["build", "check", "clippy", "fix", "rustc"].contains(&cmd)) && want_rustdoc {
1738 cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
1741 let debuginfo_level = match mode {
1742 Mode::Rustc | Mode::Codegen => self.config.rust_debuginfo_level_rustc,
1743 Mode::Std => self.config.rust_debuginfo_level_std,
1744 Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolRustc => {
1745 self.config.rust_debuginfo_level_tools
1748 cargo.env(profile_var("DEBUG"), debuginfo_level.to_string());
1750 profile_var("DEBUG_ASSERTIONS"),
1751 if mode == Mode::Std {
1752 self.config.rust_debug_assertions_std.to_string()
1754 self.config.rust_debug_assertions.to_string()
1758 profile_var("OVERFLOW_CHECKS"),
1759 if mode == Mode::Std {
1760 self.config.rust_overflow_checks_std.to_string()
1762 self.config.rust_overflow_checks.to_string()
1766 let split_debuginfo_is_stable = target.contains("linux")
1767 || target.contains("apple")
1768 || (target.contains("msvc")
1769 && self.config.rust_split_debuginfo == SplitDebuginfo::Packed)
1770 || (target.contains("windows")
1771 && self.config.rust_split_debuginfo == SplitDebuginfo::Off);
1773 if !split_debuginfo_is_stable {
1774 rustflags.arg("-Zunstable-options");
1776 match self.config.rust_split_debuginfo {
1777 SplitDebuginfo::Packed => rustflags.arg("-Csplit-debuginfo=packed"),
1778 SplitDebuginfo::Unpacked => rustflags.arg("-Csplit-debuginfo=unpacked"),
1779 SplitDebuginfo::Off => rustflags.arg("-Csplit-debuginfo=off"),
1782 if self.config.cmd.bless() {
1783 // Bless `expect!` tests.
1784 cargo.env("UPDATE_EXPECT", "1");
1787 if !mode.is_tool() {
1788 cargo.env("RUSTC_FORCE_UNSTABLE", "1");
1791 if let Some(x) = self.crt_static(target) {
1793 rustflags.arg("-Ctarget-feature=+crt-static");
1795 rustflags.arg("-Ctarget-feature=-crt-static");
1799 if let Some(x) = self.crt_static(compiler.host) {
1800 cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
1803 if let Some(map_to) = self.build.debuginfo_map_to(GitRepo::Rustc) {
1804 let map = format!("{}={}", self.build.src.display(), map_to);
1805 cargo.env("RUSTC_DEBUGINFO_MAP", map);
1807 // `rustc` needs to know the virtual `/rustc/$hash` we're mapping to,
1808 // in order to opportunistically reverse it later.
1809 cargo.env("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR", map_to);
1812 // Enable usage of unstable features
1813 cargo.env("RUSTC_BOOTSTRAP", "1");
1814 self.add_rust_test_threads(&mut cargo);
1816 // Almost all of the crates that we compile as part of the bootstrap may
1817 // have a build script, including the standard library. To compile a
1818 // build script, however, it itself needs a standard library! This
1819 // introduces a bit of a pickle when we're compiling the standard
1822 // To work around this we actually end up using the snapshot compiler
1823 // (stage0) for compiling build scripts of the standard library itself.
1824 // The stage0 compiler is guaranteed to have a libstd available for use.
1826 // For other crates, however, we know that we've already got a standard
1827 // library up and running, so we can use the normal compiler to compile
1828 // build scripts in that situation.
1829 if mode == Mode::Std {
1831 .env("RUSTC_SNAPSHOT", &self.initial_rustc)
1832 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1835 .env("RUSTC_SNAPSHOT", self.rustc(compiler))
1836 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1839 // Tools that use compiler libraries may inherit the `-lLLVM` link
1840 // requirement, but the `-L` library path is not propagated across
1841 // separate Cargo projects. We can add LLVM's library path to the
1842 // platform-specific environment variable as a workaround.
1843 if mode == Mode::ToolRustc || mode == Mode::Codegen {
1844 if let Some(llvm_config) = self.llvm_config(target) {
1845 let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
1846 add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cargo);
1850 // Compile everything except libraries and proc macros with the more
1851 // efficient initial-exec TLS model. This doesn't work with `dlopen`,
1852 // so we can't use it by default in general, but we can use it for tools
1853 // and our own internal libraries.
1854 if !mode.must_support_dlopen() && !target.triple.starts_with("powerpc-") {
1855 cargo.env("RUSTC_TLS_MODEL_INITIAL_EXEC", "1");
1858 if self.config.incremental {
1859 cargo.env("CARGO_INCREMENTAL", "1");
1861 // Don't rely on any default setting for incr. comp. in Cargo
1862 cargo.env("CARGO_INCREMENTAL", "0");
1865 if let Some(ref on_fail) = self.config.on_fail {
1866 cargo.env("RUSTC_ON_FAIL", on_fail);
1869 if self.config.print_step_timings {
1870 cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
1873 if self.config.print_step_rusage {
1874 cargo.env("RUSTC_PRINT_STEP_RUSAGE", "1");
1877 if self.config.backtrace_on_ice {
1878 cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
1881 cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1883 if source_type == SourceType::InTree {
1884 let mut lint_flags = Vec::new();
1885 // When extending this list, add the new lints to the RUSTFLAGS of the
1886 // build_bootstrap function of src/bootstrap/bootstrap.py as well as
1887 // some code doesn't go through this `rustc` wrapper.
1888 lint_flags.push("-Wrust_2018_idioms");
1889 lint_flags.push("-Wunused_lifetimes");
1890 lint_flags.push("-Wsemicolon_in_expressions_from_macros");
1892 if self.config.deny_warnings {
1893 lint_flags.push("-Dwarnings");
1894 rustdocflags.arg("-Dwarnings");
1897 // This does not use RUSTFLAGS due to caching issues with Cargo.
1898 // Clippy is treated as an "in tree" tool, but shares the same
1899 // cache as other "submodule" tools. With these options set in
1900 // RUSTFLAGS, that causes *every* shared dependency to be rebuilt.
1901 // By injecting this into the rustc wrapper, this circumvents
1902 // Cargo's fingerprint detection. This is fine because lint flags
1903 // are always ignored in dependencies. Eventually this should be
1904 // fixed via better support from Cargo.
1905 cargo.env("RUSTC_LINT_FLAGS", lint_flags.join(" "));
1907 rustdocflags.arg("-Wrustdoc::invalid_codeblock_attributes");
1910 if mode == Mode::Rustc {
1911 rustflags.arg("-Zunstable-options");
1912 rustflags.arg("-Wrustc::internal");
1915 // Throughout the build Cargo can execute a number of build scripts
1916 // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
1917 // obtained previously to those build scripts.
1918 // Build scripts use either the `cc` crate or `configure/make` so we pass
1919 // the options through environment variables that are fetched and understood by both.
1921 // FIXME: the guard against msvc shouldn't need to be here
1922 if target.contains("msvc") {
1923 if let Some(ref cl) = self.config.llvm_clang_cl {
1924 cargo.env("CC", cl).env("CXX", cl);
1927 let ccache = self.config.ccache.as_ref();
1928 let ccacheify = |s: &Path| {
1929 let ccache = match ccache {
1931 None => return s.display().to_string(),
1933 // FIXME: the cc-rs crate only recognizes the literal strings
1934 // `ccache` and `sccache` when doing caching compilations, so we
1935 // mirror that here. It should probably be fixed upstream to
1936 // accept a new env var or otherwise work with custom ccache
1939 "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
1940 _ => s.display().to_string(),
1943 let cc = ccacheify(&self.cc(target));
1944 cargo.env(format!("CC_{}", target.triple), &cc);
1946 let cflags = self.cflags(target, GitRepo::Rustc, CLang::C).join(" ");
1947 cargo.env(format!("CFLAGS_{}", target.triple), &cflags);
1949 if let Some(ar) = self.ar(target) {
1950 let ranlib = format!("{} s", ar.display());
1952 .env(format!("AR_{}", target.triple), ar)
1953 .env(format!("RANLIB_{}", target.triple), ranlib);
1956 if let Ok(cxx) = self.cxx(target) {
1957 let cxx = ccacheify(&cxx);
1958 let cxxflags = self.cflags(target, GitRepo::Rustc, CLang::Cxx).join(" ");
1960 .env(format!("CXX_{}", target.triple), &cxx)
1961 .env(format!("CXXFLAGS_{}", target.triple), cxxflags);
1965 if mode == Mode::Std && self.config.extended && compiler.is_final_stage(self) {
1966 rustflags.arg("-Zsave-analysis");
1968 "RUST_SAVE_ANALYSIS_CONFIG",
1969 "{\"output_file\": null,\"full_docs\": false,\
1970 \"pub_only\": true,\"reachable_only\": false,\
1971 \"distro_crate\": true,\"signatures\": false,\"borrow_data\": false}",
1975 // If Control Flow Guard is enabled, pass the `control-flow-guard` flag to rustc
1976 // when compiling the standard library, since this might be linked into the final outputs
1977 // produced by rustc. Since this mitigation is only available on Windows, only enable it
1978 // for the standard library in case the compiler is run on a non-Windows platform.
1979 // This is not needed for stage 0 artifacts because these will only be used for building
1980 // the stage 1 compiler.
1982 && mode == Mode::Std
1983 && self.config.control_flow_guard
1984 && compiler.stage >= 1
1986 rustflags.arg("-Ccontrol-flow-guard");
1989 // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1990 // This replaces spaces with newlines because RUSTDOCFLAGS does not
1991 // support arguments with regular spaces. Hopefully someday Cargo will
1992 // have space support.
1993 let rust_version = self.rust_version().replace(' ', "\n");
1994 rustdocflags.arg("--crate-version").arg(&rust_version);
1996 // Environment variables *required* throughout the build
1998 // FIXME: should update code to not require this env var
1999 cargo.env("CFG_COMPILER_HOST_TRIPLE", target.triple);
2001 // Set this for all builds to make sure doc builds also get it.
2002 cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
2004 // This one's a bit tricky. As of the time of this writing the compiler
2005 // links to the `winapi` crate on crates.io. This crate provides raw
2006 // bindings to Windows system functions, sort of like libc does for
2007 // Unix. This crate also, however, provides "import libraries" for the
2008 // MinGW targets. There's an import library per dll in the windows
2009 // distribution which is what's linked to. These custom import libraries
2010 // are used because the winapi crate can reference Windows functions not
2011 // present in the MinGW import libraries.
2013 // For example MinGW may ship libdbghelp.a, but it may not have
2014 // references to all the functions in the dbghelp dll. Instead the
2015 // custom import library for dbghelp in the winapi crates has all this
2018 // Unfortunately for us though the import libraries are linked by
2019 // default via `-ldylib=winapi_foo`. That is, they're linked with the
2020 // `dylib` type with a `winapi_` prefix (so the winapi ones don't
2021 // conflict with the system MinGW ones). This consequently means that
2022 // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
2023 // DLL) when linked against *again*, for example with procedural macros
2024 // or plugins, will trigger the propagation logic of `-ldylib`, passing
2025 // `-lwinapi_foo` to the linker again. This isn't actually available in
2026 // our distribution, however, so the link fails.
2028 // To solve this problem we tell winapi to not use its bundled import
2029 // libraries. This means that it will link to the system MinGW import
2030 // libraries by default, and the `-ldylib=foo` directives will still get
2031 // passed to the final linker, but they'll look like `-lfoo` which can
2032 // be resolved because MinGW has the import library. The downside is we
2033 // don't get newer functions from Windows, but we don't use any of them
2035 if !mode.is_tool() {
2036 cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
2039 for _ in 0..self.verbosity {
2043 match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
2044 (Mode::Std, Some(n), _) | (_, _, Some(n)) => {
2045 cargo.env(profile_var("CODEGEN_UNITS"), n.to_string());
2048 // Don't set anything
2052 if self.config.rust_optimize {
2053 // FIXME: cargo bench/install do not accept `--release`
2054 if cmd != "bench" && cmd != "install" {
2055 cargo.arg("--release");
2059 if self.config.locked_deps {
2060 cargo.arg("--locked");
2062 if self.config.vendor || self.is_sudo {
2063 cargo.arg("--frozen");
2066 // Try to use a sysroot-relative bindir, in case it was configured absolutely.
2067 cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
2069 self.ci_env.force_coloring_in_ci(&mut cargo);
2071 // When we build Rust dylibs they're all intended for intermediate
2072 // usage, so make sure we pass the -Cprefer-dynamic flag instead of
2073 // linking all deps statically into the dylib.
2074 if matches!(mode, Mode::Std | Mode::Rustc) {
2075 rustflags.arg("-Cprefer-dynamic");
2078 // When building incrementally we default to a lower ThinLTO import limit
2079 // (unless explicitly specified otherwise). This will produce a somewhat
2080 // slower code but give way better compile times.
2082 let limit = match self.config.rust_thin_lto_import_instr_limit {
2083 Some(limit) => Some(limit),
2084 None if self.config.incremental => Some(10),
2088 if let Some(limit) = limit {
2089 rustflags.arg(&format!("-Cllvm-args=-import-instr-limit={}", limit));
2093 Cargo { command: cargo, rustflags, rustdocflags }
2096 /// Ensure that a given step is built, returning its output. This will
2097 /// cache the step, so it is safe (and good!) to call this as often as
2098 /// needed to ensure that all dependencies are built.
2099 pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
2101 let mut stack = self.stack.borrow_mut();
2102 for stack_step in stack.iter() {
2104 if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
2107 let mut out = String::new();
2108 out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
2109 for el in stack.iter().rev() {
2110 out += &format!("\t{:?}\n", el);
2114 if let Some(out) = self.cache.get(&step) {
2115 self.verbose_than(1, &format!("{}c {:?}", " ".repeat(stack.len()), step));
2119 self.verbose_than(1, &format!("{}> {:?}", " ".repeat(stack.len()), step));
2120 stack.push(Box::new(step.clone()));
2123 #[cfg(feature = "build-metrics")]
2124 self.metrics.enter_step(&step);
2127 let start = Instant::now();
2128 let zero = Duration::new(0, 0);
2129 let parent = self.time_spent_on_dependencies.replace(zero);
2130 let out = step.clone().run(self);
2131 let dur = start.elapsed();
2132 let deps = self.time_spent_on_dependencies.replace(parent + dur);
2136 if self.config.print_step_timings && !self.config.dry_run {
2137 let step_string = format!("{:?}", step);
2138 let brace_index = step_string.find("{").unwrap_or(0);
2139 let type_string = type_name::<S>();
2141 "[TIMING] {} {} -- {}.{:03}",
2142 &type_string.strip_prefix("bootstrap::").unwrap_or(type_string),
2143 &step_string[brace_index..],
2149 #[cfg(feature = "build-metrics")]
2150 self.metrics.exit_step();
2153 let mut stack = self.stack.borrow_mut();
2154 let cur_step = stack.pop().expect("step stack empty");
2155 assert_eq!(cur_step.downcast_ref(), Some(&step));
2157 self.verbose_than(1, &format!("{}< {:?}", " ".repeat(self.stack.borrow().len()), step));
2158 self.cache.put(step, out.clone());
2162 /// Ensure that a given step is built *only if it's supposed to be built by default*, returning
2163 /// its output. This will cache the step, so it's safe (and good!) to call this as often as
2164 /// needed to ensure that all dependencies are build.
2165 pub(crate) fn ensure_if_default<T, S: Step<Output = Option<T>>>(
2170 let desc = StepDescription::from::<S>(kind);
2171 let should_run = (desc.should_run)(ShouldRun::new(self, desc.kind));
2173 // Avoid running steps contained in --exclude
2174 for pathset in &should_run.paths {
2175 if desc.is_excluded(self, pathset) {
2180 // Only execute if it's supposed to run as default
2181 if desc.default && should_run.is_really_default() { self.ensure(step) } else { None }
2184 /// Checks if any of the "should_run" paths is in the `Builder` paths.
2185 pub(crate) fn was_invoked_explicitly<S: Step>(&'a self, kind: Kind) -> bool {
2186 let desc = StepDescription::from::<S>(kind);
2187 let should_run = (desc.should_run)(ShouldRun::new(self, desc.kind));
2189 for path in &self.paths {
2190 if should_run.paths.iter().any(|s| s.has(path, Some(desc.kind)))
2191 && !desc.is_excluded(
2193 &PathSet::Suite(TaskPath { path: path.clone(), kind: Some(desc.kind) }),
2207 #[derive(Debug, Clone)]
2208 struct Rustflags(String, TargetSelection);
2211 fn new(target: TargetSelection) -> Rustflags {
2212 let mut ret = Rustflags(String::new(), target);
2213 ret.propagate_cargo_env("RUSTFLAGS");
2217 /// By default, cargo will pick up on various variables in the environment. However, bootstrap
2218 /// reuses those variables to pass additional flags to rustdoc, so by default they get overridden.
2219 /// Explicitly add back any previous value in the environment.
2221 /// `prefix` is usually `RUSTFLAGS` or `RUSTDOCFLAGS`.
2222 fn propagate_cargo_env(&mut self, prefix: &str) {
2223 // Inherit `RUSTFLAGS` by default ...
2226 // ... and also handle target-specific env RUSTFLAGS if they're configured.
2227 let target_specific = format!("CARGO_TARGET_{}_{}", crate::envify(&self.1.triple), prefix);
2228 self.env(&target_specific);
2231 fn env(&mut self, env: &str) {
2232 if let Ok(s) = env::var(env) {
2233 for part in s.split(' ') {
2239 fn arg(&mut self, arg: &str) -> &mut Self {
2240 assert_eq!(arg.split(' ').count(), 1);
2241 if !self.0.is_empty() {
2244 self.0.push_str(arg);
2252 rustflags: Rustflags,
2253 rustdocflags: Rustflags,
2257 pub fn rustdocflag(&mut self, arg: &str) -> &mut Cargo {
2258 self.rustdocflags.arg(arg);
2261 pub fn rustflag(&mut self, arg: &str) -> &mut Cargo {
2262 self.rustflags.arg(arg);
2266 pub fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Cargo {
2267 self.command.arg(arg.as_ref());
2271 pub fn args<I, S>(&mut self, args: I) -> &mut Cargo
2273 I: IntoIterator<Item = S>,
2277 self.arg(arg.as_ref());
2282 pub fn env(&mut self, key: impl AsRef<OsStr>, value: impl AsRef<OsStr>) -> &mut Cargo {
2283 // These are managed through rustflag/rustdocflag interfaces.
2284 assert_ne!(key.as_ref(), "RUSTFLAGS");
2285 assert_ne!(key.as_ref(), "RUSTDOCFLAGS");
2286 self.command.env(key.as_ref(), value.as_ref());
2290 pub fn add_rustc_lib_path(&mut self, builder: &Builder<'_>, compiler: Compiler) {
2291 builder.add_rustc_lib_path(compiler, &mut self.command);
2294 pub fn current_dir(&mut self, dir: &Path) -> &mut Cargo {
2295 self.command.current_dir(dir);
2300 impl From<Cargo> for Command {
2301 fn from(mut cargo: Cargo) -> Command {
2302 let rustflags = &cargo.rustflags.0;
2303 if !rustflags.is_empty() {
2304 cargo.command.env("RUSTFLAGS", rustflags);
2307 let rustdocflags = &cargo.rustdocflags.0;
2308 if !rustdocflags.is_empty() {
2309 cargo.command.env("RUSTDOCFLAGS", rustdocflags);