1 use hir::{db::HirDatabase, HasSource};
3 ast::{self, edit, make, AstNode, NameOwner},
7 use crate::{Assist, AssistCtx, AssistId};
10 enum AddMissingImplMembersMode {
15 // Assist: add_impl_missing_members
17 // Adds scaffold for required impl members.
39 // fn foo(&self) { unimplemented!() }
43 pub(crate) fn add_missing_impl_members(ctx: AssistCtx<impl HirDatabase>) -> Option<Assist> {
44 add_missing_impl_members_inner(
46 AddMissingImplMembersMode::NoDefaultMethods,
47 "add_impl_missing_members",
48 "add missing impl members",
52 // Assist: add_impl_default_members
54 // Adds scaffold for overriding default impl members.
65 // fn foo(&self) {}<|>
84 pub(crate) fn add_missing_default_members(ctx: AssistCtx<impl HirDatabase>) -> Option<Assist> {
85 add_missing_impl_members_inner(
87 AddMissingImplMembersMode::DefaultMethodsOnly,
88 "add_impl_default_members",
89 "add impl default members",
93 fn add_missing_impl_members_inner(
94 mut ctx: AssistCtx<impl HirDatabase>,
95 mode: AddMissingImplMembersMode,
96 assist_id: &'static str,
99 let impl_node = ctx.node_at_offset::<ast::ImplBlock>()?;
100 let impl_item_list = impl_node.item_list()?;
103 let file_id = ctx.frange.file_id;
104 let analyzer = hir::SourceAnalyzer::new(ctx.db, file_id, impl_node.syntax(), None);
106 resolve_target_trait_def(ctx.db, &analyzer, &impl_node)?
109 let def_name = |item: &ast::ImplItem| -> Option<SmolStr> {
111 ast::ImplItem::FnDef(def) => def.name(),
112 ast::ImplItem::TypeAliasDef(def) => def.name(),
113 ast::ImplItem::ConstDef(def) => def.name(),
115 .map(|it| it.text().clone())
118 let trait_items = trait_def.item_list()?.impl_items();
119 let impl_items = impl_item_list.impl_items().collect::<Vec<_>>();
121 let missing_items: Vec<_> = trait_items
122 .filter(|t| def_name(t).is_some())
123 .filter(|t| match t {
124 ast::ImplItem::FnDef(def) => match mode {
125 AddMissingImplMembersMode::DefaultMethodsOnly => def.body().is_some(),
126 AddMissingImplMembersMode::NoDefaultMethods => def.body().is_none(),
128 _ => mode == AddMissingImplMembersMode::NoDefaultMethods,
130 .filter(|t| impl_items.iter().all(|i| def_name(i) != def_name(t)))
132 if missing_items.is_empty() {
136 ctx.add_action(AssistId(assist_id), label, |edit| {
137 let n_existing_items = impl_item_list.impl_items().count();
138 let items = missing_items
141 ast::ImplItem::FnDef(def) => ast::ImplItem::FnDef(add_body(def)),
144 .map(|it| edit::strip_attrs_and_docs(&it));
145 let new_impl_item_list = impl_item_list.append_items(items);
146 let cursor_position = {
147 let first_new_item = new_impl_item_list.impl_items().nth(n_existing_items).unwrap();
148 first_new_item.syntax().text_range().start()
151 edit.replace_ast(impl_item_list, new_impl_item_list);
152 edit.set_cursor(cursor_position);
158 fn add_body(fn_def: ast::FnDef) -> ast::FnDef {
159 if fn_def.body().is_none() {
160 fn_def.with_body(make::block_from_expr(make::expr_unimplemented()))
166 /// Given an `ast::ImplBlock`, resolves the target trait (the one being
167 /// implemented) to a `ast::TraitDef`.
168 fn resolve_target_trait_def(
169 db: &impl HirDatabase,
170 analyzer: &hir::SourceAnalyzer,
171 impl_block: &ast::ImplBlock,
172 ) -> Option<ast::TraitDef> {
173 let ast_path = impl_block
175 .map(|it| it.syntax().clone())
176 .and_then(ast::PathType::cast)?
179 match analyzer.resolve_path(db, &ast_path) {
180 Some(hir::PathResolution::Def(hir::ModuleDef::Trait(def))) => Some(def.source(db).ast),
188 use crate::helpers::{check_assist, check_assist_not_applicable};
191 fn test_add_missing_impl_members() {
193 add_missing_impl_members,
198 const CONST: usize = 42;
215 const CONST: usize = 42;
227 const CONST: usize = 42;
228 fn foo(&self) { unimplemented!() }
229 fn baz(&self) { unimplemented!() }
236 fn test_copied_overriden_members() {
238 add_missing_impl_members,
242 fn bar(&self) -> bool { true }
243 fn baz(&self) -> u32 { 42 }
255 fn bar(&self) -> bool { true }
256 fn baz(&self) -> u32 { 42 }
263 <|>fn foo(&self) { unimplemented!() }
270 fn test_empty_impl_block() {
272 add_missing_impl_members,
274 trait Foo { fn foo(&self); }
276 impl Foo for S { <|> }",
278 trait Foo { fn foo(&self); }
281 <|>fn foo(&self) { unimplemented!() }
287 fn test_cursor_after_empty_impl_block() {
289 add_missing_impl_members,
291 trait Foo { fn foo(&self); }
293 impl Foo for S {}<|>",
295 trait Foo { fn foo(&self); }
298 <|>fn foo(&self) { unimplemented!() }
304 fn test_empty_trait() {
305 check_assist_not_applicable(
306 add_missing_impl_members,
310 impl Foo for S { <|> }",
315 fn test_ignore_unnamed_trait_members_and_default_methods() {
316 check_assist_not_applicable(
317 add_missing_impl_members,
321 fn valid(some: u32) -> bool { false }
324 impl Foo for S { <|> }",
329 fn test_with_docstring_and_attrs() {
331 add_missing_impl_members,
333 #[doc(alias = "test alias")]
342 impl Foo for S {}<|>"#,
344 #[doc(alias = "test alias")]
355 fn foo(&self) { unimplemented!() }
361 fn test_default_methods() {
363 add_missing_default_members,
368 const CONST: usize = 42;
370 fn valid(some: u32) -> bool { false }
371 fn foo(some: u32) -> bool;
374 impl Foo for S { <|> }",
379 const CONST: usize = 42;
381 fn valid(some: u32) -> bool { false }
382 fn foo(some: u32) -> bool;
386 <|>fn valid(some: u32) -> bool { false }