1 use itertools::Itertools;
2 use rustc_hash::FxHashMap;
4 use hir::{Adt, ModuleDef, PathResolution, Semantics, Struct};
5 use ide_db::RootDatabase;
6 use syntax::{algo, ast, match_ast, AstNode, SyntaxKind, SyntaxKind::*, SyntaxNode};
8 use crate::{AssistContext, AssistId, AssistKind, Assists};
10 // Assist: reorder_fields
12 // Reorder the fields of record literals and record patterns in the same order as in
16 // struct Foo {foo: i32, bar: i32};
17 // const test: Foo = $0Foo {bar: 0, foo: 1}
21 // struct Foo {foo: i32, bar: i32};
22 // const test: Foo = Foo {foo: 1, bar: 0}
25 pub(crate) fn reorder_fields(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
26 reorder::<ast::RecordExpr>(acc, ctx).or_else(|| reorder::<ast::RecordPat>(acc, ctx))
29 fn reorder<R: AstNode>(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
30 let record = ctx.find_node_at_offset::<R>()?;
31 let path = record.syntax().children().find_map(ast::Path::cast)?;
33 let ranks = compute_fields_ranks(&path, &ctx)?;
35 let fields = get_fields(&record.syntax());
36 let sorted_fields = sorted_by_rank(&fields, |node| {
37 *ranks.get(&get_field_name(node)).unwrap_or(&usize::max_value())
40 if sorted_fields == fields {
41 cov_mark::hit!(reorder_sorted_fields);
45 let target = record.syntax().text_range();
47 AssistId("reorder_fields", AssistKind::RefactorRewrite),
48 "Reorder record fields",
51 let mut rewriter = algo::SyntaxRewriter::default();
52 for (old, new) in fields.iter().zip(&sorted_fields) {
53 rewriter.replace(old, new);
55 edit.rewrite(rewriter);
60 fn get_fields_kind(node: &SyntaxNode) -> Vec<SyntaxKind> {
62 RECORD_EXPR => vec![RECORD_EXPR_FIELD],
63 RECORD_PAT => vec![RECORD_PAT_FIELD, IDENT_PAT],
68 fn get_field_name(node: &SyntaxNode) -> String {
69 let res = match_ast! {
71 ast::RecordExprField(field) => field.field_name().map(|it| it.to_string()),
72 ast::RecordPatField(field) => field.field_name().map(|it| it.to_string()),
76 res.unwrap_or_default()
79 fn get_fields(record: &SyntaxNode) -> Vec<SyntaxNode> {
80 let kinds = get_fields_kind(record);
81 record.children().flat_map(|n| n.children()).filter(|n| kinds.contains(&n.kind())).collect()
85 fields: &[SyntaxNode],
86 get_rank: impl Fn(&SyntaxNode) -> usize,
87 ) -> Vec<SyntaxNode> {
88 fields.iter().cloned().sorted_by_key(get_rank).collect()
91 fn struct_definition(path: &ast::Path, sema: &Semantics<RootDatabase>) -> Option<Struct> {
92 match sema.resolve_path(path) {
93 Some(PathResolution::Def(ModuleDef::Adt(Adt::Struct(s)))) => Some(s),
98 fn compute_fields_ranks(path: &ast::Path, ctx: &AssistContext) -> Option<FxHashMap<String, usize>> {
100 struct_definition(path, &ctx.sema)?
104 .map(|(idx, field)| (field.name(ctx.db()).to_string(), idx))
111 use crate::tests::{check_assist, check_assist_not_applicable};
116 fn reorder_sorted_fields() {
117 cov_mark::check!(reorder_sorted_fields);
118 check_assist_not_applicable(
126 const test: Foo = $0Foo { foo: 0, bar: 0 };
132 fn trivial_empty_fields() {
133 check_assist_not_applicable(
137 const test: Foo = $0Foo {}
143 fn reorder_struct_fields() {
147 struct Foo {foo: i32, bar: i32};
148 const test: Foo = $0Foo {bar: 0, foo: 1}
151 struct Foo {foo: i32, bar: i32};
152 const test: Foo = Foo {foo: 1, bar: 0}
158 fn reorder_struct_pattern() {
162 struct Foo { foo: i64, bar: i64, baz: i64 }
166 $0Foo { baz: 0, ref mut bar, .. } => (),
172 struct Foo { foo: i64, bar: i64, baz: i64 }
176 Foo { ref mut bar, baz: 0, .. } => (),
185 fn reorder_with_extra_field() {
196 let foo = String::new();
199 extra: "Extra field",
213 let foo = String::new();
217 extra: "Extra field",