1 use hir::{HasSource, HirDisplay, Module, ModuleDef, Semantics, TypeInfo};
4 defs::{Definition, NameRefClass},
8 use rustc_hash::{FxHashMap, FxHashSet};
9 use stdx::to_lower_snake_case;
13 edit::{AstNodeEdit, IndentLevel},
14 make, AstNode, CallExpr, HasArgList, HasModuleItem,
16 SyntaxKind, SyntaxNode, TextRange, TextSize,
20 utils::useless_type_special_case,
21 utils::{find_struct_impl, render_snippet, Cursor},
22 AssistContext, AssistId, AssistKind, Assists,
25 // Assist: generate_function
27 // Adds a stub function with a signature matching the function under the cursor.
31 // fn baz() -> Baz { Baz }
40 // fn baz() -> Baz { Baz }
45 // fn bar(arg: &str, baz: Baz) ${0:-> _} {
50 pub(crate) fn generate_function(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
51 gen_fn(acc, ctx).or_else(|| gen_method(acc, ctx))
54 fn gen_fn(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
55 let path_expr: ast::PathExpr = ctx.find_node_at_offset()?;
56 let call = path_expr.syntax().parent().and_then(ast::CallExpr::cast)?;
57 let path = path_expr.path()?;
58 let name_ref = path.segment()?.name_ref()?;
59 if ctx.sema.resolve_path(&path).is_some() {
60 // The function call already resolves, no need to add a function
64 let fn_name = &*name_ref.text();
66 let mut adt_name = None;
68 let (target, file, insert_offset) = match path.qualifier() {
69 Some(qualifier) => match ctx.sema.resolve_path(&qualifier) {
70 Some(hir::PathResolution::Def(hir::ModuleDef::Module(module))) => {
71 target_module = Some(module);
72 get_fn_target(ctx, &target_module, call.clone())?
74 Some(hir::PathResolution::Def(hir::ModuleDef::Adt(adt))) => {
75 let current_module = current_module(call.syntax(), ctx)?;
76 let module = adt.module(ctx.sema.db);
77 target_module = if current_module == module { None } else { Some(module) };
78 if current_module.krate() != module.krate() {
81 let (impl_, file) = get_adt_source(ctx, &adt, fn_name)?;
82 let (target, insert_offset) = get_method_target(ctx, &module, &impl_)?;
83 adt_name = if impl_.is_none() { Some(adt.name(ctx.sema.db)) } else { None };
84 (target, file, insert_offset)
92 get_fn_target(ctx, &target_module, call.clone())?
95 let function_builder = FunctionBuilder::from_call(ctx, &call, fn_name, target_module, target)?;
96 let text_range = call.syntax().text_range();
97 let label = format!("Generate {} function", function_builder.fn_name);
98 add_func_to_accumulator(
110 fn gen_method(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
111 let call: ast::MethodCallExpr = ctx.find_node_at_offset()?;
112 let fn_name = call.name_ref()?;
113 let adt = ctx.sema.type_of_expr(&call.receiver()?)?.original().strip_references().as_adt()?;
115 let current_module = current_module(call.syntax(), ctx)?;
116 let target_module = adt.module(ctx.sema.db);
118 if current_module.krate() != target_module.krate() {
121 let (impl_, file) = get_adt_source(ctx, &adt, fn_name.text().as_str())?;
122 let (target, insert_offset) = get_method_target(ctx, &target_module, &impl_)?;
123 let function_builder =
124 FunctionBuilder::from_method_call(ctx, &call, &fn_name, target_module, target)?;
125 let text_range = call.syntax().text_range();
126 let adt_name = if impl_.is_none() { Some(adt.name(ctx.sema.db)) } else { None };
127 let label = format!("Generate {} method", function_builder.fn_name);
128 add_func_to_accumulator(
140 fn add_func_to_accumulator(
143 text_range: TextRange,
144 function_builder: FunctionBuilder,
145 insert_offset: TextSize,
147 adt_name: Option<hir::Name>,
150 acc.add(AssistId("generate_function", AssistKind::Generate), label, text_range, |builder| {
151 let function_template = function_builder.render();
152 let mut func = function_template.to_string(ctx.config.snippet_cap);
153 if let Some(name) = adt_name {
154 func = format!("\nimpl {} {{\n{}\n}}", name, func);
156 builder.edit_file(file);
157 match ctx.config.snippet_cap {
158 Some(cap) => builder.insert_snippet(cap, insert_offset, func),
159 None => builder.insert(insert_offset, func),
164 fn current_module(current_node: &SyntaxNode, ctx: &AssistContext) -> Option<Module> {
165 ctx.sema.scope(current_node).module()
172 ) -> Option<(Option<ast::Impl>, FileId)> {
173 let range = adt.source(ctx.sema.db)?.syntax().original_file_range(ctx.sema.db);
174 let file = ctx.sema.parse(range.file_id);
176 ctx.sema.find_node_at_offset_with_macros(file.syntax(), range.range.start())?;
177 find_struct_impl(ctx, &adt_source, fn_name).map(|impl_| (impl_, range.file_id))
180 struct FunctionTemplate {
183 ret_type: Option<ast::RetType>,
184 should_focus_return_type: bool,
186 tail_expr: ast::Expr,
189 impl FunctionTemplate {
190 fn to_string(&self, cap: Option<SnippetCap>) -> String {
193 let cursor = if self.should_focus_return_type {
194 // Focus the return type if there is one
195 if let Some(ref ret_type) = self.ret_type {
198 self.tail_expr.syntax()
201 self.tail_expr.syntax()
203 render_snippet(cap, self.fn_def.syntax(), Cursor::Replace(cursor))
205 None => self.fn_def.to_string(),
208 format!("{}{}{}", self.leading_ws, f, self.trailing_ws)
212 struct FunctionBuilder {
213 target: GeneratedFunctionTarget,
215 type_params: Option<ast::GenericParamList>,
216 params: ast::ParamList,
217 ret_type: Option<ast::RetType>,
218 should_focus_return_type: bool,
223 impl FunctionBuilder {
224 /// Prepares a generated function that matches `call`.
225 /// The function is generated in `target_module` or next to `call`
228 call: &ast::CallExpr,
230 target_module: Option<hir::Module>,
231 target: GeneratedFunctionTarget,
233 let needs_pub = target_module.is_some();
234 let target_module = target_module.or_else(|| current_module(target.syntax(), ctx))?;
235 let fn_name = make::name(fn_name);
236 let (type_params, params) =
237 fn_args(ctx, target_module, ast::CallableExpr::Call(call.clone()))?;
239 let await_expr = call.syntax().parent().and_then(ast::AwaitExpr::cast);
240 let is_async = await_expr.is_some();
242 let (ret_type, should_focus_return_type) =
243 make_return_type(ctx, &ast::Expr::CallExpr(call.clone()), target_module);
251 should_focus_return_type,
259 call: &ast::MethodCallExpr,
261 target_module: Module,
262 target: GeneratedFunctionTarget,
265 !module_is_descendant(¤t_module(call.syntax(), ctx)?, &target_module, ctx);
266 let fn_name = make::name(&name.text());
267 let (type_params, params) =
268 fn_args(ctx, target_module, ast::CallableExpr::MethodCall(call.clone()))?;
270 let await_expr = call.syntax().parent().and_then(ast::AwaitExpr::cast);
271 let is_async = await_expr.is_some();
273 let (ret_type, should_focus_return_type) =
274 make_return_type(ctx, &ast::Expr::MethodCallExpr(call.clone()), target_module);
282 should_focus_return_type,
288 fn render(self) -> FunctionTemplate {
289 let placeholder_expr = make::ext::expr_todo();
290 let fn_body = make::block_expr(vec![], Some(placeholder_expr));
291 let visibility = if self.needs_pub { Some(make::visibility_pub_crate()) } else { None };
292 let mut fn_def = make::fn_(
305 GeneratedFunctionTarget::BehindItem(it) => {
306 let indent = IndentLevel::from_node(&it);
307 leading_ws = format!("\n\n{}", indent);
308 fn_def = fn_def.indent(indent);
309 trailing_ws = String::new();
311 GeneratedFunctionTarget::InEmptyItemList(it) => {
312 let indent = IndentLevel::from_node(&it);
313 leading_ws = format!("\n{}", indent + 1);
314 fn_def = fn_def.indent(indent + 1);
315 trailing_ws = format!("\n{}", indent);
321 ret_type: fn_def.ret_type(),
322 // PANIC: we guarantee we always create a function body with a tail expr
323 tail_expr: fn_def.body().unwrap().tail_expr().unwrap(),
324 should_focus_return_type: self.should_focus_return_type,
331 /// Makes an optional return type along with whether the return type should be focused by the cursor.
332 /// If we cannot infer what the return type should be, we create a placeholder type.
334 /// The rule for whether we focus a return type or not (and thus focus the function body),
335 /// is rather simple:
336 /// * If we could *not* infer what the return type should be, focus it (so the user can fill-in
337 /// the correct return type).
338 /// * If we could infer the return type, don't focus it (and thus focus the function body) so the
339 /// user can change the `todo!` function body.
343 target_module: Module,
344 ) -> (Option<ast::RetType>, bool) {
345 let (ret_ty, should_focus_return_type) = {
346 match ctx.sema.type_of_expr(call).map(TypeInfo::original) {
347 Some(ty) if ty.is_unknown() => (Some(make::ty_placeholder()), true),
348 None => (Some(make::ty_placeholder()), true),
349 Some(ty) if ty.is_unit() => (None, false),
351 let rendered = ty.display_source_code(ctx.db(), target_module.into());
353 Ok(rendered) => (Some(make::ty(&rendered)), false),
354 Err(_) => (Some(make::ty_placeholder()), true),
359 let ret_type = ret_ty.map(make::ret_type);
360 (ret_type, should_focus_return_type)
365 target_module: &Option<Module>,
367 ) -> Option<(GeneratedFunctionTarget, FileId, TextSize)> {
368 let mut file = ctx.frange.file_id;
369 let target = match target_module {
370 Some(target_module) => {
371 let module_source = target_module.definition_source(ctx.db());
372 let (in_file, target) = next_space_for_fn_in_module(ctx.sema.db, &module_source)?;
376 None => next_space_for_fn_after_call_site(ast::CallableExpr::Call(call))?,
378 Some((target.clone(), file, get_insert_offset(&target)))
381 fn get_method_target(
383 target_module: &Module,
384 impl_: &Option<ast::Impl>,
385 ) -> Option<(GeneratedFunctionTarget, TextSize)> {
386 let target = match impl_ {
387 Some(impl_) => next_space_for_fn_in_impl(impl_)?,
389 next_space_for_fn_in_module(ctx.sema.db, &target_module.definition_source(ctx.sema.db))?
393 Some((target.clone(), get_insert_offset(&target)))
396 fn get_insert_offset(target: &GeneratedFunctionTarget) -> TextSize {
398 GeneratedFunctionTarget::BehindItem(it) => it.text_range().end(),
399 GeneratedFunctionTarget::InEmptyItemList(it) => it.text_range().start() + TextSize::of('{'),
404 enum GeneratedFunctionTarget {
405 BehindItem(SyntaxNode),
406 InEmptyItemList(SyntaxNode),
409 impl GeneratedFunctionTarget {
410 fn syntax(&self) -> &SyntaxNode {
412 GeneratedFunctionTarget::BehindItem(it) => it,
413 GeneratedFunctionTarget::InEmptyItemList(it) => it,
418 /// Computes the type variables and arguments required for the generated function
421 target_module: hir::Module,
422 call: ast::CallableExpr,
423 ) -> Option<(Option<ast::GenericParamList>, ast::ParamList)> {
424 let mut arg_names = Vec::new();
425 let mut arg_types = Vec::new();
426 for arg in call.arg_list()?.args() {
427 arg_names.push(fn_arg_name(&ctx.sema, &arg));
428 arg_types.push(match fn_arg_type(ctx, target_module, &arg) {
430 if !ty.is_empty() && ty.starts_with('&') {
431 if let Some((new_ty, _)) = useless_type_special_case("", &ty[1..].to_owned()) {
440 None => String::from("_"),
443 deduplicate_arg_names(&mut arg_names);
444 let params = arg_names.into_iter().zip(arg_types).map(|(name, ty)| {
445 make::param(make::ext::simple_ident_pat(make::name(&name)).into(), make::ty(&ty))
452 ast::CallableExpr::Call(_) => None,
453 ast::CallableExpr::MethodCall(_) => Some(make::self_param()),
460 /// Makes duplicate argument names unique by appending incrementing numbers.
463 /// let mut names: Vec<String> =
464 /// vec!["foo".into(), "foo".into(), "bar".into(), "baz".into(), "bar".into()];
465 /// deduplicate_arg_names(&mut names);
466 /// let expected: Vec<String> =
467 /// vec!["foo_1".into(), "foo_2".into(), "bar_1".into(), "baz".into(), "bar_2".into()];
468 /// assert_eq!(names, expected);
470 fn deduplicate_arg_names(arg_names: &mut Vec<String>) {
471 let arg_name_counts = arg_names.iter().fold(FxHashMap::default(), |mut m, name| {
472 *m.entry(name).or_insert(0) += 1;
475 let duplicate_arg_names: FxHashSet<String> = arg_name_counts
477 .filter(|(_, count)| *count >= 2)
478 .map(|(name, _)| name.clone())
481 let mut counter_per_name = FxHashMap::default();
482 for arg_name in arg_names.iter_mut() {
483 if duplicate_arg_names.contains(arg_name) {
484 let counter = counter_per_name.entry(arg_name.clone()).or_insert(1);
486 arg_name.push_str(&counter.to_string());
492 fn fn_arg_name(sema: &Semantics<RootDatabase>, arg_expr: &ast::Expr) -> String {
493 let name = (|| match arg_expr {
494 ast::Expr::CastExpr(cast_expr) => Some(fn_arg_name(sema, &cast_expr.expr()?)),
496 let name_ref = expr.syntax().descendants().filter_map(ast::NameRef::cast).last()?;
497 if let Some(NameRefClass::Definition(Definition::ModuleDef(
498 ModuleDef::Const(_) | ModuleDef::Static(_),
499 ))) = NameRefClass::classify(sema, &name_ref)
501 return Some(name_ref.to_string().to_lowercase());
503 Some(to_lower_snake_case(&name_ref.to_string()))
507 Some(mut name) if name.starts_with(|c: char| c.is_ascii_digit()) => {
508 name.insert_str(0, "arg");
512 None => "arg".to_string(),
518 target_module: hir::Module,
520 ) -> Option<String> {
521 let ty = ctx.sema.type_of_expr(fn_arg)?.adjusted();
526 if let Ok(rendered) = ty.display_source_code(ctx.db(), target_module.into()) {
533 /// Returns the position inside the current mod or file
534 /// directly after the current block
535 /// We want to write the generated function directly after
536 /// fns, impls or macro calls, but inside mods
537 fn next_space_for_fn_after_call_site(expr: ast::CallableExpr) -> Option<GeneratedFunctionTarget> {
538 let mut ancestors = expr.syntax().ancestors().peekable();
539 let mut last_ancestor: Option<SyntaxNode> = None;
540 while let Some(next_ancestor) = ancestors.next() {
541 match next_ancestor.kind() {
542 SyntaxKind::SOURCE_FILE => {
545 SyntaxKind::ITEM_LIST => {
546 if ancestors.peek().map(|a| a.kind()) == Some(SyntaxKind::MODULE) {
552 last_ancestor = Some(next_ancestor);
554 last_ancestor.map(GeneratedFunctionTarget::BehindItem)
557 fn next_space_for_fn_in_module(
558 db: &dyn hir::db::AstDatabase,
559 module_source: &hir::InFile<hir::ModuleSource>,
560 ) -> Option<(FileId, GeneratedFunctionTarget)> {
561 let file = module_source.file_id.original_file(db);
562 let assist_item = match &module_source.value {
563 hir::ModuleSource::SourceFile(it) => {
564 if let Some(last_item) = it.items().last() {
565 GeneratedFunctionTarget::BehindItem(last_item.syntax().clone())
567 GeneratedFunctionTarget::BehindItem(it.syntax().clone())
570 hir::ModuleSource::Module(it) => {
571 if let Some(last_item) = it.item_list().and_then(|it| it.items().last()) {
572 GeneratedFunctionTarget::BehindItem(last_item.syntax().clone())
574 GeneratedFunctionTarget::InEmptyItemList(it.item_list()?.syntax().clone())
577 hir::ModuleSource::BlockExpr(it) => {
578 if let Some(last_item) =
579 it.statements().take_while(|stmt| matches!(stmt, ast::Stmt::Item(_))).last()
581 GeneratedFunctionTarget::BehindItem(last_item.syntax().clone())
583 GeneratedFunctionTarget::InEmptyItemList(it.syntax().clone())
587 Some((file, assist_item))
590 fn next_space_for_fn_in_impl(impl_: &ast::Impl) -> Option<GeneratedFunctionTarget> {
591 if let Some(last_item) = impl_.assoc_item_list().and_then(|it| it.assoc_items().last()) {
592 Some(GeneratedFunctionTarget::BehindItem(last_item.syntax().clone()))
594 Some(GeneratedFunctionTarget::InEmptyItemList(impl_.assoc_item_list()?.syntax().clone()))
598 fn module_is_descendant(module: &hir::Module, ans: &hir::Module, ctx: &AssistContext) -> bool {
602 for c in ans.children(ctx.sema.db) {
603 if module_is_descendant(module, &c, ctx) {
612 use crate::tests::{check_assist, check_assist_not_applicable};
617 fn add_function_with_no_args() {
638 fn add_function_from_method() {
639 // This ensures that the function is correctly generated
640 // in the next outer mod or file
665 fn add_function_directly_after_current_block() {
666 // The new fn should not be created at the end of the file or module
691 fn add_function_with_no_args_in_same_module() {
716 fn add_function_with_upper_camel_case_arg() {
731 fn bar(baz_baz: BazBaz) ${0:-> _} {
739 fn add_function_with_upper_camel_case_arg_as_cast() {
745 bar$0(&BazBaz as *const BazBaz);
751 bar(&BazBaz as *const BazBaz);
754 fn bar(baz_baz: *const BazBaz) ${0:-> _} {
762 fn add_function_with_function_call_arg() {
767 fn baz() -> Baz { todo!() }
774 fn baz() -> Baz { todo!() }
779 fn bar(baz: Baz) ${0:-> _} {
787 fn add_function_with_method_call_arg() {
793 fn foo(&self) -> Baz {
796 fn baz(&self) -> Baz {
804 fn foo(&self) -> Baz {
807 fn baz(&self) -> Baz {
812 fn bar(baz: Baz) -> Baz {
820 fn add_function_with_string_literal_arg() {
841 fn add_function_with_char_literal_arg() {
862 fn add_function_with_int_literal_arg() {
883 fn add_function_with_cast_int_literal_arg() {
904 fn name_of_cast_variable_is_used() {
905 // Ensures that the name of the cast type isn't used
906 // in the generated function signature.
929 fn add_function_with_variable_arg() {
952 fn add_function_with_impl_trait_arg() {
958 fn foo() -> impl Foo {
967 fn foo() -> impl Foo {
974 fn bar(foo: impl Foo) {
987 fn baz() -> Baz { todo!() }
995 fn baz() -> Baz { todo!() }
1009 fn add_function_with_qualified_path_arg() {
1015 pub fn baz() -> Bof { Bof }
1024 pub fn baz() -> Bof { Bof }
1030 fn bar(baz: Baz::Bof) {
1038 fn add_function_with_generic_arg() {
1039 // FIXME: This is wrong, generated `bar` should include generic parameter.
1060 fn add_function_with_fn_arg() {
1061 // FIXME: The argument in `bar` is wrong.
1067 fn new() -> Self { Baz }
1076 fn new() -> Self { Baz }
1082 fn bar(new: fn) ${0:-> _} {
1090 fn add_function_with_closure_arg() {
1091 // FIXME: The argument in `bar` is wrong.
1096 let closure = |x: i64| x - 1;
1102 let closure = |x: i64| x - 1;
1106 fn bar(closure: _) {
1114 fn unresolveable_types_default_to_placeholder() {
1135 fn arg_names_dont_overlap() {
1140 fn baz() -> Baz { Baz }
1147 fn baz() -> Baz { Baz }
1152 fn bar(baz_1: Baz, baz_2: Baz) {
1160 fn arg_name_counters_start_at_1_per_name() {
1165 fn baz() -> Baz { Baz }
1167 $0bar(baz(), baz(), "foo", "bar")
1172 fn baz() -> Baz { Baz }
1174 bar(baz(), baz(), "foo", "bar")
1177 fn bar(baz_1: Baz, baz_2: Baz, arg_1: &str, arg_2: &str) {
1185 fn add_function_in_module() {
1197 pub(crate) fn my_fn() {
1210 fn qualified_path_uses_correct_scope() {
1233 fn baz(foo: foo::Foo) {
1241 fn add_function_in_module_containing_other_items() {
1246 fn something_else() {}
1255 fn something_else() {}
1257 pub(crate) fn my_fn() {
1270 fn add_function_in_nested_module() {
1285 pub(crate) fn my_fn() {
1299 fn add_function_in_another_file() {
1314 pub(crate) fn bar() {
1321 fn add_function_with_return_type() {
1326 let x: u32 = foo$0();
1342 fn add_function_not_applicable_if_function_already_exists() {
1343 check_assist_not_applicable(
1356 fn add_function_not_applicable_if_unresolved_variable_in_call_is_selected() {
1357 check_assist_not_applicable(
1358 // bar is resolved, but baz isn't.
1359 // The assist is only active if the cursor is on an unresolved path,
1360 // but the assist should only be offered if the path is a function call.
1373 fn create_method_with_no_args() {
1391 fn bar(&self) ${0:-> _} {
1400 fn create_function_with_async() {
1413 async fn bar(arg: i32) ${0:-> _} {
1421 fn create_method() {
1426 fn foo() {S.bar$0();}
1434 fn bar(&self) ${0:-> _} {
1443 fn create_method_within_an_impl() {
1448 fn foo() {S.bar$0();}
1456 fn bar(&self) ${0:-> _} {
1466 fn create_method_from_different_module() {
1473 fn foo() {s::S.bar$0();}
1481 pub(crate) fn bar(&self) ${0:-> _} {
1486 fn foo() {s::S.bar();}
1492 fn create_method_from_descendant_module() {
1514 fn bar(&self) ${0:-> _} {
1524 fn create_method_with_cursor_anywhere_on_call_expresion() {
1529 fn foo() {$0S.bar();}
1537 fn bar(&self) ${0:-> _} {
1546 fn create_static_method() {
1551 fn foo() {S::bar$0();}
1555 fn foo() {S::bar();}
1559 fn bar() ${0:-> _} {
1568 fn create_static_method_within_an_impl() {
1573 fn foo() {S::bar$0();}
1579 fn foo() {S::bar();}
1581 fn bar() ${0:-> _} {
1591 fn create_static_method_from_different_module() {
1598 fn foo() {s::S::bar$0();}
1606 pub(crate) fn bar() ${0:-> _} {
1611 fn foo() {s::S::bar();}
1617 fn create_static_method_with_cursor_anywhere_on_call_expresion() {
1622 fn foo() {$0S::bar();}
1626 fn foo() {S::bar();}
1630 fn bar() ${0:-> _} {
1639 fn no_panic_on_invalid_global_path() {
1652 fn foo() ${0:-> _} {
1660 fn handle_tuple_indexing() {
1675 fn foo(arg0: ()) ${0:-> _} {
1683 fn add_function_with_const_arg() {
1687 const VALUE: usize = 0;
1693 const VALUE: usize = 0;
1698 fn foo(value: usize) ${0:-> _} {
1706 fn add_function_with_static_arg() {
1710 static VALUE: usize = 0;
1716 static VALUE: usize = 0;
1721 fn foo(value: usize) ${0:-> _} {
1729 fn add_function_with_static_mut_arg() {
1733 static mut VALUE: usize = 0;
1739 static mut VALUE: usize = 0;
1744 fn foo(value: usize) ${0:-> _} {