4 use hir::{Module, ModuleDef, Name, Variant};
8 insert_use::{insert_use, ImportScope, InsertUseConfig},
11 search::FileReference,
14 use rustc_hash::FxHashSet;
16 algo::find_node_at_offset,
17 ast::{self, make, AstNode, NameOwner, VisibilityOwner},
21 use crate::{AssistContext, AssistId, AssistKind, Assists};
23 // Assist: extract_struct_from_enum_variant
25 // Extracts a struct from enum variant.
28 // enum A { $0One(u32, u32) }
32 // struct One(pub u32, pub u32);
34 // enum A { One(One) }
36 pub(crate) fn extract_struct_from_enum_variant(
40 let variant = ctx.find_node_at_offset::<ast::Variant>()?;
41 let field_list = extract_field_list_if_applicable(&variant)?;
43 let variant_name = variant.name()?;
44 let variant_hir = ctx.sema.to_def(&variant)?;
45 if existing_definition(ctx.db(), &variant_name, &variant_hir) {
49 let enum_ast = variant.parent_enum();
50 let enum_hir = ctx.sema.to_def(&enum_ast)?;
51 let target = variant.syntax().text_range();
53 AssistId("extract_struct_from_enum_variant", AssistKind::RefactorRewrite),
54 "Extract struct from enum variant",
57 let variant_hir_name = variant_hir.name(ctx.db());
58 let enum_module_def = ModuleDef::from(enum_hir);
60 Definition::ModuleDef(ModuleDef::Variant(variant_hir)).usages(&ctx.sema).all();
62 let mut visited_modules_set = FxHashSet::default();
63 let current_module = enum_hir.module(ctx.db());
64 visited_modules_set.insert(current_module);
65 // record file references of the file the def resides in, we only want to swap to the edited file in the builder once
66 let mut def_file_references = None;
67 for (file_id, references) in usages {
68 if file_id == ctx.frange.file_id {
69 def_file_references = Some(references);
72 builder.edit_file(file_id);
73 let source_file = builder.make_ast_mut(ctx.sema.parse(file_id));
74 let processed = process_references(
76 &mut visited_modules_set,
82 processed.into_iter().for_each(|(path, node, import)| {
83 apply_references(ctx.config.insert_use, path, node, import)
86 builder.edit_file(ctx.frange.file_id);
87 let source_file = builder.make_ast_mut(ctx.sema.parse(ctx.frange.file_id));
88 let variant = builder.make_ast_mut(variant.clone());
89 if let Some(references) = def_file_references {
90 let processed = process_references(
92 &mut visited_modules_set,
98 processed.into_iter().for_each(|(path, node, import)| {
99 apply_references(ctx.config.insert_use, path, node, import)
103 let def = create_struct_def(variant_name.clone(), &field_list, enum_ast.visibility());
104 let start_offset = &variant.parent_enum().syntax().clone();
105 ted::insert_raw(ted::Position::before(start_offset), def.syntax());
106 ted::insert_raw(ted::Position::before(start_offset), &make::tokens::blank_line());
108 update_variant(&variant);
113 fn extract_field_list_if_applicable(
114 variant: &ast::Variant,
115 ) -> Option<Either<ast::RecordFieldList, ast::TupleFieldList>> {
116 match variant.kind() {
117 ast::StructKind::Record(field_list) if field_list.fields().next().is_some() => {
118 Some(Either::Left(field_list))
120 ast::StructKind::Tuple(field_list) if field_list.fields().count() > 1 => {
121 Some(Either::Right(field_list))
127 fn existing_definition(db: &RootDatabase, variant_name: &ast::Name, variant: &Variant) -> bool {
133 .filter(|(_, def)| match def {
134 // only check type-namespace
135 hir::ScopeDef::ModuleDef(def) => matches!(
139 | ModuleDef::Variant(_)
140 | ModuleDef::Trait(_)
141 | ModuleDef::TypeAlias(_)
142 | ModuleDef::BuiltinType(_)
146 .any(|(name, _)| name.to_string() == variant_name.to_string())
149 fn create_struct_def(
150 variant_name: ast::Name,
151 field_list: &Either<ast::RecordFieldList, ast::TupleFieldList>,
152 visibility: Option<ast::Visibility>,
154 let pub_vis = make::visibility_pub();
156 let insert_pub = |node: &'_ SyntaxNode| {
157 let pub_vis = pub_vis.clone_for_update();
158 ted::insert(ted::Position::before(node), pub_vis.syntax());
161 // for fields without any existing visibility, use pub visibility
162 let field_list = match field_list {
163 Either::Left(field_list) => {
164 let field_list = field_list.clone_for_update();
168 .filter(|field| field.visibility().is_none())
169 .filter_map(|field| field.name())
170 .for_each(|it| insert_pub(it.syntax()));
174 Either::Right(field_list) => {
175 let field_list = field_list.clone_for_update();
179 .filter(|field| field.visibility().is_none())
180 .filter_map(|field| field.ty())
181 .for_each(|it| insert_pub(it.syntax()));
187 make::struct_(visibility, variant_name, None, field_list).clone_for_update()
190 fn update_variant(variant: &ast::Variant) -> Option<()> {
191 let name = variant.name()?;
192 let tuple_field = make::tuple_field(None, make::ty(&name.text()));
193 let replacement = make::variant(
195 Some(ast::FieldList::TupleFieldList(make::tuple_field_list(iter::once(tuple_field)))),
198 ted::replace(variant.syntax(), replacement.syntax());
203 insert_use_cfg: InsertUseConfig,
204 segment: ast::PathSegment,
206 import: Option<(ImportScope, hir::ModPath)>,
208 if let Some((scope, path)) = import {
209 insert_use(&scope, mod_path_to_ast(&path), insert_use_cfg);
212 ted::Position::before(segment.syntax()),
213 make::path_from_text(&format!("{}", segment)).clone_for_update().syntax(),
215 ted::insert_raw(ted::Position::before(segment.syntax()), make::token(T!['(']));
216 ted::insert_raw(ted::Position::after(&node), make::token(T![')']));
219 fn process_references(
221 visited_modules: &mut FxHashSet<Module>,
222 source_file: &SyntaxNode,
223 enum_module_def: &ModuleDef,
224 variant_hir_name: &Name,
225 refs: Vec<FileReference>,
226 ) -> Vec<(ast::PathSegment, SyntaxNode, Option<(ImportScope, hir::ModPath)>)> {
227 // we have to recollect here eagerly as we are about to edit the tree we need to calculate the changes
228 // and corresponding nodes up front
230 .flat_map(|reference| {
231 let (segment, scope_node, module) =
232 reference_to_node(&ctx.sema, source_file, reference)?;
233 if !visited_modules.contains(&module) {
234 let mod_path = module.find_use_path_prefixed(
237 ctx.config.insert_use.prefix_kind,
239 if let Some(mut mod_path) = mod_path {
240 mod_path.pop_segment();
241 mod_path.push_segment(variant_hir_name.clone());
242 let scope = ImportScope::find_insert_use_container(&scope_node)?;
243 visited_modules.insert(module);
244 return Some((segment, scope_node, Some((scope, mod_path))));
247 Some((segment, scope_node, None))
252 fn reference_to_node(
253 sema: &hir::Semantics<RootDatabase>,
254 source_file: &SyntaxNode,
255 reference: FileReference,
256 ) -> Option<(ast::PathSegment, SyntaxNode, hir::Module)> {
257 let offset = reference.range.start();
258 if let Some(path_expr) = find_node_at_offset::<ast::PathExpr>(source_file, offset) {
260 Some((path_expr.path()?.segment()?, path_expr.syntax().parent()?))
261 } else if let Some(record_expr) = find_node_at_offset::<ast::RecordExpr>(source_file, offset) {
263 Some((record_expr.path()?.segment()?, record_expr.syntax().clone()))
267 .and_then(|(segment, expr)| {
268 let module = sema.scope(&expr).module()?;
269 Some((segment, expr, module))
275 use ide_db::helpers::FamousDefs;
277 use crate::tests::{check_assist, check_assist_not_applicable};
282 fn test_extract_struct_several_fields_tuple() {
284 extract_struct_from_enum_variant,
285 "enum A { $0One(u32, u32) }",
286 r#"struct One(pub u32, pub u32);
288 enum A { One(One) }"#,
293 fn test_extract_struct_several_fields_named() {
295 extract_struct_from_enum_variant,
296 "enum A { $0One { foo: u32, bar: u32 } }",
297 r#"struct One{ pub foo: u32, pub bar: u32 }
299 enum A { One(One) }"#,
304 fn test_extract_struct_one_field_named() {
306 extract_struct_from_enum_variant,
307 "enum A { $0One { foo: u32 } }",
308 r#"struct One{ pub foo: u32 }
310 enum A { One(One) }"#,
315 fn test_extract_struct_keep_comments_and_attrs_one_field_named() {
317 extract_struct_from_enum_variant,
344 fn test_extract_struct_keep_comments_and_attrs_several_fields_named() {
346 extract_struct_from_enum_variant,
379 fn test_extract_struct_keep_comments_and_attrs_several_fields_tuple() {
381 extract_struct_from_enum_variant,
382 "enum A { $0One(/* comment */ #[attr] u32, /* another */ u32 /* tail */) }",
384 struct One(/* comment */ #[attr] pub u32, /* another */ pub u32 /* tail */);
386 enum A { One(One) }"#,
391 fn test_extract_struct_keep_existing_visibility_named() {
393 extract_struct_from_enum_variant,
394 "enum A { $0One{ pub a: u32, pub(crate) b: u32, pub(super) c: u32, d: u32 } }",
396 struct One{ pub a: u32, pub(crate) b: u32, pub(super) c: u32, pub d: u32 }
398 enum A { One(One) }"#,
403 fn test_extract_struct_keep_existing_visibility_tuple() {
405 extract_struct_from_enum_variant,
406 "enum A { $0One(pub u32, pub(crate) u32, pub(super) u32, u32) }",
408 struct One(pub u32, pub(crate) u32, pub(super) u32, pub u32);
410 enum A { One(One) }"#,
415 fn test_extract_enum_variant_name_value_namespace() {
417 extract_struct_from_enum_variant,
418 r#"const One: () = ();
419 enum A { $0One(u32, u32) }"#,
420 r#"const One: () = ();
421 struct One(pub u32, pub u32);
423 enum A { One(One) }"#,
428 fn test_extract_struct_pub_visibility() {
430 extract_struct_from_enum_variant,
431 "pub enum A { $0One(u32, u32) }",
432 r#"pub struct One(pub u32, pub u32);
434 pub enum A { One(One) }"#,
439 fn test_extract_struct_with_complex_imports() {
441 extract_struct_from_enum_variant,
444 let m = my_other_mod::MyEnum::MyField(1, 1);
447 pub mod my_other_mod {
449 let m = MyEnum::MyField(1, 1);
459 let m = my_mod::my_other_mod::MyEnum::MyField(1, 1);
461 r#"use my_mod::my_other_mod::MyField;
464 use self::my_other_mod::MyField;
467 let m = my_other_mod::MyEnum::MyField(MyField(1, 1));
470 pub mod my_other_mod {
472 let m = MyEnum::MyField(MyField(1, 1));
475 pub struct MyField(pub u8, pub u8);
484 let m = my_mod::my_other_mod::MyEnum::MyField(MyField(1, 1));
490 fn extract_record_fix_references() {
492 extract_struct_from_enum_variant,
495 $0V { i: i32, j: i32 }
499 let e = E::V { i: 9, j: 2 };
503 struct V{ pub i: i32, pub j: i32 }
510 let e = E::V(V { i: 9, j: 2 });
517 fn test_several_files() {
519 extract_struct_from_enum_variant,
535 struct V(pub i32, pub i32);
545 let e = E::V(V(9, 2));
552 fn test_several_files_record() {
554 extract_struct_from_enum_variant,
558 $0V { i: i32, j: i32 }
565 let e = E::V { i: 9, j: 2 };
570 struct V{ pub i: i32, pub j: i32 }
580 let e = E::V(V { i: 9, j: 2 });
587 fn test_extract_struct_record_nested_call_exp() {
589 extract_struct_from_enum_variant,
591 enum A { $0One { a: u32, b: u32 } }
596 let _ = B(A::One { a: 1, b: 2 });
600 struct One{ pub a: u32, pub b: u32 }
607 let _ = B(A::One(One { a: 1, b: 2 }));
613 fn check_not_applicable(ra_fixture: &str) {
615 format!("//- /main.rs crate:main deps:core\n{}\n{}", ra_fixture, FamousDefs::FIXTURE);
616 check_assist_not_applicable(extract_struct_from_enum_variant, &fixture)
620 fn test_extract_enum_not_applicable_for_element_with_no_fields() {
621 check_not_applicable("enum A { $0One }");
625 fn test_extract_enum_not_applicable_if_struct_exists() {
626 check_not_applicable(
628 enum A { $0One(u8, u32) }"#,
633 fn test_extract_not_applicable_one_field() {
634 check_not_applicable(r"enum A { $0One(u32) }");
638 fn test_extract_not_applicable_no_field_tuple() {
639 check_not_applicable(r"enum A { $0None() }");
643 fn test_extract_not_applicable_no_field_named() {
644 check_not_applicable(r"enum A { $0None {} }");