1 use ide_db::helpers::FamousDefs;
3 ast::{self, edit::AstNodeEdit, make, ArgListOwner},
7 use crate::{AssistContext, AssistId, AssistKind, Assists};
9 // Assist: convert_iter_for_each_to_for
11 // Converts an Iterator::for_each function into a for loop.
14 // # //- minicore: iterators
17 // let iter = iter::repeat((9, 2));
18 // iter.for_each$0(|(x, y)| {
19 // println!("x: {}, y: {}", x, y);
27 // let iter = iter::repeat((9, 2));
28 // for (x, y) in iter {
29 // println!("x: {}, y: {}", x, y);
34 pub(crate) fn convert_iter_for_each_to_for(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
35 let method = ctx.find_node_at_offset::<ast::MethodCallExpr>()?;
37 let closure = match method.arg_list()?.args().next()? {
38 ast::Expr::ClosureExpr(expr) => expr,
42 let (method, receiver) = validate_method_call_expr(ctx, method)?;
44 let param_list = closure.param_list()?;
45 let param = param_list.params().next()?.pat()?;
46 let body = closure.body()?;
48 let stmt = method.syntax().parent().and_then(ast::ExprStmt::cast);
49 let syntax = stmt.as_ref().map_or(method.syntax(), |stmt| stmt.syntax());
52 AssistId("convert_iter_for_each_to_for", AssistKind::RefactorRewrite),
53 "Replace this `Iterator::for_each` with a for loop",
56 let indent = stmt.as_ref().map_or(method.indent_level(), |stmt| stmt.indent_level());
58 let block = match body {
59 ast::Expr::BlockExpr(block) => block,
60 _ => make::block_expr(Vec::new(), Some(body)),
65 let expr_for_loop = make::expr_for_loop(param, receiver, block);
66 builder.replace(syntax.text_range(), expr_for_loop.syntax().text())
71 fn validate_method_call_expr(
73 expr: ast::MethodCallExpr,
74 ) -> Option<(ast::Expr, ast::Expr)> {
75 let name_ref = expr.name_ref()?;
76 if name_ref.syntax().text_range().intersect(ctx.frange.range).is_none() {
77 cov_mark::hit!(test_for_each_not_applicable_invalid_cursor_pos);
80 if name_ref.text() != "for_each" {
86 let receiver = expr.receiver()?;
87 let expr = ast::Expr::MethodCallExpr(expr);
89 let it_type = sema.type_of_expr(&receiver)?.adjusted();
90 let module = sema.scope(receiver.syntax()).module()?;
91 let krate = module.krate();
93 let iter_trait = FamousDefs(sema, Some(krate)).core_iter_Iterator()?;
94 it_type.impls_trait(sema.db, iter_trait, &[]).then(|| (expr, receiver))
99 use crate::tests::{check_assist, check_assist_not_applicable};
104 fn test_for_each_in_method_stmt() {
106 convert_iter_for_each_to_for,
108 //- minicore: iterators
110 let it = core::iter::repeat(92);
111 it.$0for_each(|(x, y)| {
112 println!("x: {}, y: {}", x, y);
118 let it = core::iter::repeat(92);
120 println!("x: {}, y: {}", x, y);
128 fn test_for_each_in_method() {
130 convert_iter_for_each_to_for,
132 //- minicore: iterators
134 let it = core::iter::repeat(92);
135 it.$0for_each(|(x, y)| {
136 println!("x: {}, y: {}", x, y);
142 let it = core::iter::repeat(92);
144 println!("x: {}, y: {}", x, y);
152 fn test_for_each_without_braces_stmt() {
154 convert_iter_for_each_to_for,
156 //- minicore: iterators
158 let it = core::iter::repeat(92);
159 it.$0for_each(|(x, y)| println!("x: {}, y: {}", x, y));
164 let it = core::iter::repeat(92);
166 println!("x: {}, y: {}", x, y)
174 fn test_for_each_not_applicable() {
175 check_assist_not_applicable(
176 convert_iter_for_each_to_for,
178 //- minicore: iterators
180 ().$0for_each(|x| println!("{}", x));
186 fn test_for_each_not_applicable_invalid_cursor_pos() {
187 cov_mark::check!(test_for_each_not_applicable_invalid_cursor_pos);
188 check_assist_not_applicable(
189 convert_iter_for_each_to_for,
191 //- minicore: iterators
193 core::iter::repeat(92).for_each(|(x, y)| $0println!("x: {}, y: {}", x, y));