1 use ide_db::helpers::FamousDefs;
3 ast::{self, edit_in_place::Indent, make, ArgListOwner},
7 use crate::{AssistContext, AssistId, AssistKind, Assists};
9 // Assist: convert_iter_for_each_to_for
11 // Converts an Iterator::for_each function into a for loop.
14 // # //- minicore: iterators
17 // let iter = iter::repeat((9, 2));
18 // iter.for_each$0(|(x, y)| {
19 // println!("x: {}, y: {}", x, y);
27 // let iter = iter::repeat((9, 2));
28 // for (x, y) in iter {
29 // println!("x: {}, y: {}", x, y);
34 pub(crate) fn convert_iter_for_each_to_for(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
35 let method = ctx.find_node_at_offset::<ast::MethodCallExpr>()?;
37 let closure = match method.arg_list()?.args().next()? {
38 ast::Expr::ClosureExpr(expr) => expr,
42 let (method, receiver) = validate_method_call_expr(ctx, method)?;
44 let param_list = closure.param_list()?;
45 let param = param_list.params().next()?.pat()?;
46 let body = closure.body()?;
48 let stmt = method.syntax().parent().and_then(ast::ExprStmt::cast);
49 let range = stmt.as_ref().map_or(method.syntax(), AstNode::syntax).text_range();
52 AssistId("convert_iter_for_each_to_for", AssistKind::RefactorRewrite),
53 "Replace this `Iterator::for_each` with a for loop",
57 stmt.as_ref().map_or_else(|| method.indent_level(), ast::ExprStmt::indent_level);
59 let block = match body {
60 ast::Expr::BlockExpr(block) => block,
61 _ => make::block_expr(Vec::new(), Some(body)),
67 let expr_for_loop = make::expr_for_loop(param, receiver, block);
68 builder.replace(range, expr_for_loop.to_string())
73 fn validate_method_call_expr(
75 expr: ast::MethodCallExpr,
76 ) -> Option<(ast::Expr, ast::Expr)> {
77 let name_ref = expr.name_ref()?;
78 if name_ref.syntax().text_range().intersect(ctx.frange.range).is_none() {
79 cov_mark::hit!(test_for_each_not_applicable_invalid_cursor_pos);
82 if name_ref.text() != "for_each" {
88 let receiver = expr.receiver()?;
89 let expr = ast::Expr::MethodCallExpr(expr);
91 let it_type = sema.type_of_expr(&receiver)?.adjusted();
92 let module = sema.scope(receiver.syntax()).module()?;
93 let krate = module.krate();
95 let iter_trait = FamousDefs(sema, Some(krate)).core_iter_Iterator()?;
96 it_type.impls_trait(sema.db, iter_trait, &[]).then(|| (expr, receiver))
101 use crate::tests::{check_assist, check_assist_not_applicable};
106 fn test_for_each_in_method_stmt() {
108 convert_iter_for_each_to_for,
110 //- minicore: iterators
112 let it = core::iter::repeat(92);
113 it.$0for_each(|(x, y)| {
114 println!("x: {}, y: {}", x, y);
120 let it = core::iter::repeat(92);
122 println!("x: {}, y: {}", x, y);
130 fn test_for_each_in_method() {
132 convert_iter_for_each_to_for,
134 //- minicore: iterators
136 let it = core::iter::repeat(92);
137 it.$0for_each(|(x, y)| {
138 println!("x: {}, y: {}", x, y);
144 let it = core::iter::repeat(92);
146 println!("x: {}, y: {}", x, y);
154 fn test_for_each_without_braces_stmt() {
156 convert_iter_for_each_to_for,
158 //- minicore: iterators
160 let it = core::iter::repeat(92);
161 it.$0for_each(|(x, y)| println!("x: {}, y: {}", x, y));
166 let it = core::iter::repeat(92);
168 println!("x: {}, y: {}", x, y)
176 fn test_for_each_not_applicable() {
177 check_assist_not_applicable(
178 convert_iter_for_each_to_for,
180 //- minicore: iterators
182 ().$0for_each(|x| println!("{}", x));
188 fn test_for_each_not_applicable_invalid_cursor_pos() {
189 cov_mark::check!(test_for_each_not_applicable_invalid_cursor_pos);
190 check_assist_not_applicable(
191 convert_iter_for_each_to_for,
193 //- minicore: iterators
195 core::iter::repeat(92).for_each(|(x, y)| $0println!("x: {}, y: {}", x, y));