1 use rustc_errors::{Applicability, StashKey};
3 use rustc_hir::def_id::{DefId, LocalDefId};
4 use rustc_hir::intravisit;
5 use rustc_hir::intravisit::Visitor;
6 use rustc_hir::{HirId, Node};
7 use rustc_middle::hir::nested_filter;
8 use rustc_middle::ty::subst::InternalSubsts;
9 use rustc_middle::ty::util::IntTypeExt;
10 use rustc_middle::ty::{self, DefIdTree, Ty, TyCtxt, TypeFolder, TypeSuperFoldable, TypeVisitable};
11 use rustc_span::symbol::Ident;
12 use rustc_span::{Span, DUMMY_SP};
15 use super::{bad_placeholder, is_suggestable_infer_ty};
16 use crate::errors::UnconstrainedOpaqueType;
18 /// Computes the relevant generic parameter for a potential generic const argument.
20 /// This should be called using the query `tcx.opt_const_param_of`.
21 pub(super) fn opt_const_param_of(tcx: TyCtxt<'_>, def_id: LocalDefId) -> Option<DefId> {
23 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
25 match tcx.hir().get(hir_id) {
26 Node::AnonConst(_) => (),
30 let parent_node_id = tcx.hir().get_parent_node(hir_id);
31 let parent_node = tcx.hir().get(parent_node_id);
33 let (generics, arg_idx) = match parent_node {
34 // This match arm is for when the def_id appears in a GAT whose
35 // path can't be resolved without typechecking e.g.
38 // type Assoc<const N: usize>;
39 // fn foo() -> Self::Assoc<3>;
42 // In the above code we would call this query with the def_id of 3 and
43 // the parent_node we match on would be the hir node for Self::Assoc<3>
45 // `Self::Assoc<3>` cant be resolved without typechecking here as we
46 // didnt write <Self as Foo>::Assoc<3>. If we did then another match
47 // arm would handle this.
49 // I believe this match arm is only needed for GAT but I am not 100% sure - BoxyUwU
50 Node::Ty(hir_ty @ Ty { kind: TyKind::Path(QPath::TypeRelative(_, segment)), .. }) => {
51 // Find the Item containing the associated type so we can create an ItemCtxt.
52 // Using the ItemCtxt convert the HIR for the unresolved assoc type into a
53 // ty which is a fully resolved projection.
54 // For the code example above, this would mean converting Self::Assoc<3>
55 // into a ty::Projection(<Self as Foo>::Assoc<3>)
59 .filter(|(_, node)| matches!(node, Node::Item(_)))
63 let item_did = tcx.hir().local_def_id(item_hir_id).to_def_id();
64 let item_ctxt = &ItemCtxt::new(tcx, item_did) as &dyn crate::astconv::AstConv<'_>;
65 let ty = item_ctxt.ast_ty_to_ty(hir_ty);
67 // Iterate through the generics of the projection to find the one that corresponds to
68 // the def_id that this query was called with. We filter to only const args here as a
69 // precaution for if it's ever allowed to elide lifetimes in GAT's. It currently isn't
70 // but it can't hurt to be safe ^^
71 if let ty::Projection(projection) = ty.kind() {
72 let generics = tcx.generics_of(projection.item_def_id);
74 let arg_index = segment
79 .filter(|arg| arg.is_ty_or_const())
80 .position(|arg| arg.hir_id() == hir_id)
83 bug!("no arg matching AnonConst in segment");
88 // I dont think it's possible to reach this but I'm not 100% sure - BoxyUwU
89 tcx.sess.delay_span_bug(
91 "unexpected non-GAT usage of an anon const",
98 ExprKind::MethodCall(segment, ..) | ExprKind::Path(QPath::TypeRelative(_, segment)),
101 let body_owner = tcx.hir().enclosing_body_owner(hir_id);
102 let tables = tcx.typeck(body_owner);
103 // This may fail in case the method/path does not actually exist.
104 // As there is no relevant param for `def_id`, we simply return
106 let type_dependent_def = tables.type_dependent_def_id(parent_node_id)?;
112 .filter(|arg| arg.is_ty_or_const())
113 .position(|arg| arg.hir_id() == hir_id)
116 bug!("no arg matching AnonConst in segment");
119 (tcx.generics_of(type_dependent_def), idx)
122 Node::Ty(&Ty { kind: TyKind::Path(_), .. })
123 | Node::Expr(&Expr { kind: ExprKind::Path(_) | ExprKind::Struct(..), .. })
126 let path = match parent_node {
127 Node::Ty(&Ty { kind: TyKind::Path(QPath::Resolved(_, path)), .. })
128 | Node::TraitRef(&TraitRef { path, .. }) => &*path,
131 ExprKind::Path(QPath::Resolved(_, path))
132 | ExprKind::Struct(&QPath::Resolved(_, path), ..),
135 let body_owner = tcx.hir().enclosing_body_owner(hir_id);
136 let _tables = tcx.typeck(body_owner);
140 if let Some(path) = get_path_containing_arg_in_pat(pat, hir_id) {
143 tcx.sess.delay_span_bug(
144 tcx.def_span(def_id),
145 &format!("unable to find const parent for {} in pat {:?}", hir_id, pat),
151 tcx.sess.delay_span_bug(
152 tcx.def_span(def_id),
153 &format!("unexpected const parent path {:?}", parent_node),
159 // We've encountered an `AnonConst` in some path, so we need to
160 // figure out which generic parameter it corresponds to and return
161 // the relevant type.
162 let Some((arg_index, segment)) = path.segments.iter().find_map(|seg| {
163 let args = seg.args?;
166 .filter(|arg| arg.is_ty_or_const())
167 .position(|arg| arg.hir_id() == hir_id)
168 .map(|index| (index, seg)).or_else(|| args.bindings
170 .filter_map(TypeBinding::opt_const)
171 .position(|ct| ct.hir_id == hir_id)
172 .map(|idx| (idx, seg)))
174 tcx.sess.delay_span_bug(
175 tcx.def_span(def_id),
176 "no arg matching AnonConst in path",
181 let generics = match tcx.res_generics_def_id(segment.res) {
182 Some(def_id) => tcx.generics_of(def_id),
184 tcx.sess.delay_span_bug(
185 tcx.def_span(def_id),
186 &format!("unexpected anon const res {:?} in path: {:?}", segment.res, path),
192 (generics, arg_index)
197 debug!(?parent_node);
198 debug!(?generics, ?arg_idx);
202 .filter(|param| param.kind.is_ty_or_const())
203 .nth(match generics.has_self && generics.parent.is_none() {
207 .and_then(|param| match param.kind {
208 ty::GenericParamDefKind::Const { .. } => {
216 fn get_path_containing_arg_in_pat<'hir>(
217 pat: &'hir hir::Pat<'hir>,
219 ) -> Option<&'hir hir::Path<'hir>> {
222 let is_arg_in_path = |p: &hir::Path<'_>| {
225 .filter_map(|seg| seg.args)
226 .flat_map(|args| args.args)
227 .any(|arg| arg.hir_id() == arg_id)
229 let mut arg_path = None;
230 pat.walk(|pat| match pat.kind {
231 PatKind::Struct(QPath::Resolved(_, path), _, _)
232 | PatKind::TupleStruct(QPath::Resolved(_, path), _, _)
233 | PatKind::Path(QPath::Resolved(_, path))
234 if is_arg_in_path(path) =>
236 arg_path = Some(path);
244 pub(super) fn type_of(tcx: TyCtxt<'_>, def_id: DefId) -> Ty<'_> {
245 let def_id = def_id.expect_local();
248 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
250 let icx = ItemCtxt::new(tcx, def_id.to_def_id());
252 match tcx.hir().get(hir_id) {
253 Node::TraitItem(item) => match item.kind {
254 TraitItemKind::Fn(..) => {
255 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
256 tcx.mk_fn_def(def_id.to_def_id(), substs)
258 TraitItemKind::Const(ty, body_id) => body_id
259 .and_then(|body_id| {
260 if is_suggestable_infer_ty(ty) {
261 Some(infer_placeholder_type(
262 tcx, def_id, body_id, ty.span, item.ident, "constant",
268 .unwrap_or_else(|| icx.to_ty(ty)),
269 TraitItemKind::Type(_, Some(ty)) => icx.to_ty(ty),
270 TraitItemKind::Type(_, None) => {
271 span_bug!(item.span, "associated type missing default");
275 Node::ImplItem(item) => match item.kind {
276 ImplItemKind::Fn(..) => {
277 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
278 tcx.mk_fn_def(def_id.to_def_id(), substs)
280 ImplItemKind::Const(ty, body_id) => {
281 if is_suggestable_infer_ty(ty) {
282 infer_placeholder_type(tcx, def_id, body_id, ty.span, item.ident, "constant")
287 ImplItemKind::TyAlias(ty) => {
288 if tcx.impl_trait_ref(tcx.hir().get_parent_item(hir_id)).is_none() {
289 check_feature_inherent_assoc_ty(tcx, item.span);
296 Node::Item(item) => {
298 ItemKind::Static(ty, .., body_id) => {
299 if is_suggestable_infer_ty(ty) {
300 infer_placeholder_type(
312 ItemKind::Const(ty, body_id) => {
313 if is_suggestable_infer_ty(ty) {
314 infer_placeholder_type(
315 tcx, def_id, body_id, ty.span, item.ident, "constant",
321 ItemKind::TyAlias(self_ty, _) => icx.to_ty(self_ty),
322 ItemKind::Impl(hir::Impl { self_ty, .. }) => icx.to_ty(*self_ty),
323 ItemKind::Fn(..) => {
324 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
325 tcx.mk_fn_def(def_id.to_def_id(), substs)
327 ItemKind::Enum(..) | ItemKind::Struct(..) | ItemKind::Union(..) => {
328 let def = tcx.adt_def(def_id);
329 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
330 tcx.mk_adt(def, substs)
332 ItemKind::OpaqueTy(OpaqueTy { origin: hir::OpaqueTyOrigin::TyAlias, .. }) => {
333 find_opaque_ty_constraints_for_tait(tcx, def_id)
335 // Opaque types desugared from `impl Trait`.
336 ItemKind::OpaqueTy(OpaqueTy { origin: hir::OpaqueTyOrigin::FnReturn(owner) | hir::OpaqueTyOrigin::AsyncFn(owner), .. }) => {
337 find_opaque_ty_constraints_for_rpit(tcx, def_id, owner)
340 | ItemKind::TraitAlias(..)
341 | ItemKind::Macro(..)
343 | ItemKind::ForeignMod { .. }
344 | ItemKind::GlobalAsm(..)
345 | ItemKind::ExternCrate(..)
346 | ItemKind::Use(..) => {
349 "compute_type_of_item: unexpected item type: {:?}",
356 Node::ForeignItem(foreign_item) => match foreign_item.kind {
357 ForeignItemKind::Fn(..) => {
358 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
359 tcx.mk_fn_def(def_id.to_def_id(), substs)
361 ForeignItemKind::Static(t, _) => icx.to_ty(t),
362 ForeignItemKind::Type => tcx.mk_foreign(def_id.to_def_id()),
365 Node::Ctor(&ref def) | Node::Variant(Variant { data: ref def, .. }) => match *def {
366 VariantData::Unit(..) | VariantData::Struct(..) => {
367 tcx.type_of(tcx.hir().get_parent_item(hir_id))
369 VariantData::Tuple(..) => {
370 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
371 tcx.mk_fn_def(def_id.to_def_id(), substs)
375 Node::Field(field) => icx.to_ty(field.ty),
377 Node::Expr(&Expr { kind: ExprKind::Closure{..}, .. }) => tcx.typeck(def_id).node_type(hir_id),
379 Node::AnonConst(_) if let Some(param) = tcx.opt_const_param_of(def_id) => {
380 // We defer to `type_of` of the corresponding parameter
381 // for generic arguments.
385 Node::AnonConst(_) => {
386 let parent_node = tcx.hir().get(tcx.hir().get_parent_node(hir_id));
388 Node::Ty(&Ty { kind: TyKind::Array(_, ref constant), .. })
389 | Node::Expr(&Expr { kind: ExprKind::Repeat(_, ref constant), .. })
390 if constant.hir_id() == hir_id =>
394 Node::Ty(&Ty { kind: TyKind::Typeof(ref e), .. }) if e.hir_id == hir_id => {
395 tcx.typeck(def_id).node_type(e.hir_id)
398 Node::Expr(&Expr { kind: ExprKind::ConstBlock(ref anon_const), .. })
399 if anon_const.hir_id == hir_id =>
401 let substs = InternalSubsts::identity_for_item(tcx, def_id.to_def_id());
402 substs.as_inline_const().ty()
405 Node::Expr(&Expr { kind: ExprKind::InlineAsm(asm), .. })
406 | Node::Item(&Item { kind: ItemKind::GlobalAsm(asm), .. })
407 if asm.operands.iter().any(|(op, _op_sp)| match op {
408 hir::InlineAsmOperand::Const { anon_const }
409 | hir::InlineAsmOperand::SymFn { anon_const } => anon_const.hir_id == hir_id,
413 tcx.typeck(def_id).node_type(hir_id)
416 Node::Variant(Variant { disr_expr: Some(ref e), .. }) if e.hir_id == hir_id => tcx
417 .adt_def(tcx.hir().get_parent_item(hir_id))
422 Node::TypeBinding(binding @ &TypeBinding { hir_id: binding_id, .. })
423 if let Node::TraitRef(trait_ref) = tcx.hir().get(
424 tcx.hir().get_parent_node(binding_id)
427 let Some(trait_def_id) = trait_ref.trait_def_id() else {
428 return tcx.ty_error_with_message(DUMMY_SP, "Could not find trait");
430 let assoc_items = tcx.associated_items(trait_def_id);
431 let assoc_item = assoc_items.find_by_name_and_kind(
432 tcx, binding.ident, ty::AssocKind::Const, def_id.to_def_id(),
434 if let Some(assoc_item) = assoc_item {
435 tcx.type_of(assoc_item.def_id)
437 // FIXME(associated_const_equality): add a useful error message here.
438 tcx.ty_error_with_message(
440 "Could not find associated const on trait",
445 Node::GenericParam(&GenericParam {
446 hir_id: param_hir_id,
447 kind: GenericParamKind::Const { default: Some(ct), .. },
449 }) if ct.hir_id == hir_id => tcx.type_of(tcx.hir().local_def_id(param_hir_id)),
452 tcx.ty_error_with_message(
454 &format!("unexpected const parent in type_of(): {x:?}"),
459 Node::GenericParam(param) => match ¶m.kind {
460 GenericParamKind::Type { default: Some(ty), .. }
461 | GenericParamKind::Const { ty, .. } => icx.to_ty(ty),
462 x => bug!("unexpected non-type Node::GenericParam: {:?}", x),
466 bug!("unexpected sort of node in type_of(): {:?}", x);
471 #[instrument(skip(tcx), level = "debug")]
472 /// Checks "defining uses" of opaque `impl Trait` types to ensure that they meet the restrictions
473 /// laid for "higher-order pattern unification".
474 /// This ensures that inference is tractable.
475 /// In particular, definitions of opaque types can only use other generics as arguments,
476 /// and they cannot repeat an argument. Example:
478 /// ```ignore (illustrative)
479 /// type Foo<A, B> = impl Bar<A, B>;
481 /// // Okay -- `Foo` is applied to two distinct, generic types.
482 /// fn a<T, U>() -> Foo<T, U> { .. }
484 /// // Not okay -- `Foo` is applied to `T` twice.
485 /// fn b<T>() -> Foo<T, T> { .. }
487 /// // Not okay -- `Foo` is applied to a non-generic type.
488 /// fn b<T>() -> Foo<T, u32> { .. }
491 fn find_opaque_ty_constraints_for_tait(tcx: TyCtxt<'_>, def_id: LocalDefId) -> Ty<'_> {
492 use rustc_hir::{Expr, ImplItem, Item, TraitItem};
494 struct ConstraintLocator<'tcx> {
497 /// def_id of the opaque type whose defining uses are being checked
500 /// as we walk the defining uses, we are checking that all of them
501 /// define the same hidden type. This variable is set to `Some`
502 /// with the first type that we find, and then later types are
503 /// checked against it (we also carry the span of that first
505 found: Option<ty::OpaqueHiddenType<'tcx>>,
508 impl ConstraintLocator<'_> {
509 #[instrument(skip(self), level = "debug")]
510 fn check(&mut self, item_def_id: LocalDefId) {
511 // Don't try to check items that cannot possibly constrain the type.
512 if !self.tcx.has_typeck_results(item_def_id) {
513 debug!("no constraint: no typeck results");
516 // Calling `mir_borrowck` can lead to cycle errors through
517 // const-checking, avoid calling it if we don't have to.
519 // type Foo = impl Fn() -> usize; // when computing type for this
520 // const fn bar() -> Foo {
523 // const BAZR: Foo = bar(); // we would mir-borrowck this, causing cycles
524 // // because we again need to reveal `Foo` so we can check whether the
525 // // constant does not contain interior mutability.
527 let tables = self.tcx.typeck(item_def_id);
528 if let Some(_) = tables.tainted_by_errors {
529 self.found = Some(ty::OpaqueHiddenType { span: DUMMY_SP, ty: self.tcx.ty_error() });
532 if !tables.concrete_opaque_types.contains_key(&self.def_id) {
533 debug!("no constraints in typeck results");
536 // Use borrowck to get the type with unerased regions.
537 let concrete_opaque_types = &self.tcx.mir_borrowck(item_def_id).concrete_opaque_types;
538 debug!(?concrete_opaque_types);
539 if let Some(&concrete_type) = concrete_opaque_types.get(&self.def_id) {
540 debug!(?concrete_type, "found constraint");
541 if let Some(prev) = self.found {
542 if concrete_type.ty != prev.ty && !(concrete_type, prev).references_error() {
543 prev.report_mismatch(&concrete_type, self.tcx);
546 self.found = Some(concrete_type);
552 impl<'tcx> intravisit::Visitor<'tcx> for ConstraintLocator<'tcx> {
553 type NestedFilter = nested_filter::All;
555 fn nested_visit_map(&mut self) -> Self::Map {
558 fn visit_expr(&mut self, ex: &'tcx Expr<'tcx>) {
559 if let hir::ExprKind::Closure { .. } = ex.kind {
560 let def_id = self.tcx.hir().local_def_id(ex.hir_id);
563 intravisit::walk_expr(self, ex);
565 fn visit_item(&mut self, it: &'tcx Item<'tcx>) {
567 // The opaque type itself or its children are not within its reveal scope.
568 if it.def_id != self.def_id {
569 self.check(it.def_id);
570 intravisit::walk_item(self, it);
573 fn visit_impl_item(&mut self, it: &'tcx ImplItem<'tcx>) {
575 // The opaque type itself or its children are not within its reveal scope.
576 if it.def_id != self.def_id {
577 self.check(it.def_id);
578 intravisit::walk_impl_item(self, it);
581 fn visit_trait_item(&mut self, it: &'tcx TraitItem<'tcx>) {
583 self.check(it.def_id);
584 intravisit::walk_trait_item(self, it);
588 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
589 let scope = tcx.hir().get_defining_scope(hir_id);
590 let mut locator = ConstraintLocator { def_id: def_id, tcx, found: None };
594 if scope == hir::CRATE_HIR_ID {
595 tcx.hir().walk_toplevel_module(&mut locator);
597 trace!("scope={:#?}", tcx.hir().get(scope));
598 match tcx.hir().get(scope) {
599 // We explicitly call `visit_*` methods, instead of using `intravisit::walk_*` methods
600 // This allows our visitor to process the defining item itself, causing
601 // it to pick up any 'sibling' defining uses.
603 // For example, this code:
606 // type Blah = impl Debug;
607 // let my_closure = || -> Blah { true };
611 // requires us to explicitly process `foo()` in order
612 // to notice the defining usage of `Blah`.
613 Node::Item(it) => locator.visit_item(it),
614 Node::ImplItem(it) => locator.visit_impl_item(it),
615 Node::TraitItem(it) => locator.visit_trait_item(it),
616 other => bug!("{:?} is not a valid scope for an opaque type item", other),
620 match locator.found {
621 Some(hidden) => hidden.ty,
623 tcx.sess.emit_err(UnconstrainedOpaqueType {
624 span: tcx.def_span(def_id),
625 name: tcx.item_name(tcx.local_parent(def_id).to_def_id()),
632 fn find_opaque_ty_constraints_for_rpit(
635 owner_def_id: LocalDefId,
637 use rustc_hir::{Expr, ImplItem, Item, TraitItem};
639 struct ConstraintChecker<'tcx> {
642 /// def_id of the opaque type whose defining uses are being checked
645 found: ty::OpaqueHiddenType<'tcx>,
648 impl ConstraintChecker<'_> {
649 #[instrument(skip(self), level = "debug")]
650 fn check(&self, def_id: LocalDefId) {
651 // Use borrowck to get the type with unerased regions.
652 let concrete_opaque_types = &self.tcx.mir_borrowck(def_id).concrete_opaque_types;
653 debug!(?concrete_opaque_types);
654 for &(def_id, concrete_type) in concrete_opaque_types {
655 if def_id != self.def_id {
656 // Ignore constraints for other opaque types.
660 debug!(?concrete_type, "found constraint");
662 if concrete_type.ty != self.found.ty
663 && !(concrete_type, self.found).references_error()
665 self.found.report_mismatch(&concrete_type, self.tcx);
671 impl<'tcx> intravisit::Visitor<'tcx> for ConstraintChecker<'tcx> {
672 type NestedFilter = nested_filter::OnlyBodies;
674 fn nested_visit_map(&mut self) -> Self::Map {
677 fn visit_expr(&mut self, ex: &'tcx Expr<'tcx>) {
678 if let hir::ExprKind::Closure { .. } = ex.kind {
679 let def_id = self.tcx.hir().local_def_id(ex.hir_id);
682 intravisit::walk_expr(self, ex);
684 fn visit_item(&mut self, it: &'tcx Item<'tcx>) {
686 // The opaque type itself or its children are not within its reveal scope.
687 if it.def_id != self.def_id {
688 self.check(it.def_id);
689 intravisit::walk_item(self, it);
692 fn visit_impl_item(&mut self, it: &'tcx ImplItem<'tcx>) {
694 // The opaque type itself or its children are not within its reveal scope.
695 if it.def_id != self.def_id {
696 self.check(it.def_id);
697 intravisit::walk_impl_item(self, it);
700 fn visit_trait_item(&mut self, it: &'tcx TraitItem<'tcx>) {
702 self.check(it.def_id);
703 intravisit::walk_trait_item(self, it);
707 let concrete = tcx.mir_borrowck(owner_def_id).concrete_opaque_types.get(&def_id).copied();
709 if let Some(concrete) = concrete {
710 let scope = tcx.hir().local_def_id_to_hir_id(owner_def_id);
712 let mut locator = ConstraintChecker { def_id: def_id, tcx, found: concrete };
714 match tcx.hir().get(scope) {
715 Node::Item(it) => intravisit::walk_item(&mut locator, it),
716 Node::ImplItem(it) => intravisit::walk_impl_item(&mut locator, it),
717 Node::TraitItem(it) => intravisit::walk_trait_item(&mut locator, it),
718 other => bug!("{:?} is not a valid scope for an opaque type item", other),
722 concrete.map(|concrete| concrete.ty).unwrap_or_else(|| {
723 let table = tcx.typeck(owner_def_id);
724 if let Some(_) = table.tainted_by_errors {
726 // owner fn prevented us from populating
727 // the `concrete_opaque_types` table.
731 .concrete_opaque_types
735 // We failed to resolve the opaque type or it
736 // resolves to itself. We interpret this as the
737 // no values of the hidden type ever being constructed,
738 // so we can just make the hidden type be `!`.
739 // For backwards compatibility reasons, we fall back to
740 // `()` until we the diverging default is changed.
741 Some(tcx.mk_diverging_default())
743 .expect("RPIT always have a hidden type from typeck")
748 fn infer_placeholder_type<'a>(
751 body_id: hir::BodyId,
756 // Attempts to make the type nameable by turning FnDefs into FnPtrs.
757 struct MakeNameable<'tcx> {
762 impl<'tcx> MakeNameable<'tcx> {
763 fn new(tcx: TyCtxt<'tcx>) -> Self {
764 MakeNameable { success: true, tcx }
768 impl<'tcx> TypeFolder<'tcx> for MakeNameable<'tcx> {
769 fn tcx(&self) -> TyCtxt<'tcx> {
773 fn fold_ty(&mut self, ty: Ty<'tcx>) -> Ty<'tcx> {
779 ty::FnDef(def_id, _) => self.tcx.mk_fn_ptr(self.tcx.fn_sig(*def_id)),
780 // FIXME: non-capturing closures should also suggest a function pointer
781 ty::Closure(..) | ty::Generator(..) => {
782 self.success = false;
785 _ => ty.super_fold_with(self),
790 let ty = tcx.diagnostic_only_typeck(def_id).node_type(body_id.hir_id);
792 // If this came from a free `const` or `static mut?` item,
793 // then the user may have written e.g. `const A = 42;`.
794 // In this case, the parser has stashed a diagnostic for
795 // us to improve in typeck so we do that now.
796 match tcx.sess.diagnostic().steal_diagnostic(span, StashKey::ItemNoType) {
798 if !ty.references_error() {
799 // Only suggest adding `:` if it was missing (and suggested by parsing diagnostic)
800 let colon = if span == item_ident.span.shrink_to_hi() { ":" } else { "" };
802 // The parser provided a sub-optimal `HasPlaceholders` suggestion for the type.
803 // We are typeck and have the real type, so remove that and suggest the actual type.
804 // FIXME(eddyb) this looks like it should be functionality on `Diagnostic`.
805 if let Ok(suggestions) = &mut err.suggestions {
809 // Suggesting unnameable types won't help.
810 let mut mk_nameable = MakeNameable::new(tcx);
811 let ty = mk_nameable.fold_ty(ty);
812 let sugg_ty = if mk_nameable.success { Some(ty) } else { None };
813 if let Some(sugg_ty) = sugg_ty {
816 &format!("provide a type for the {item}", item = kind),
817 format!("{colon} {sugg_ty}"),
818 Applicability::MachineApplicable,
822 tcx.hir().body(body_id).value.span,
823 &format!("however, the inferred type `{}` cannot be named", ty),
831 let mut diag = bad_placeholder(tcx, vec![span], kind);
833 if !ty.references_error() {
834 let mut mk_nameable = MakeNameable::new(tcx);
835 let ty = mk_nameable.fold_ty(ty);
836 let sugg_ty = if mk_nameable.success { Some(ty) } else { None };
837 if let Some(sugg_ty) = sugg_ty {
838 diag.span_suggestion(
840 "replace with the correct type",
842 Applicability::MaybeIncorrect,
846 tcx.hir().body(body_id).value.span,
847 &format!("however, the inferred type `{}` cannot be named", ty),
856 // Typeck doesn't expect erased regions to be returned from `type_of`.
857 tcx.fold_regions(ty, |r, _| match *r {
858 ty::ReErased => tcx.lifetimes.re_static,
863 fn check_feature_inherent_assoc_ty(tcx: TyCtxt<'_>, span: Span) {
864 if !tcx.features().inherent_associated_types {
865 use rustc_session::parse::feature_err;
866 use rustc_span::symbol::sym;
868 &tcx.sess.parse_sess,
869 sym::inherent_associated_types,
871 "inherent associated types are unstable",