1 //! Type checking expressions.
3 //! See `mod.rs` for more context on type checking in general.
5 use crate::astconv::AstConv as _;
6 use crate::check::cast;
7 use crate::check::coercion::CoerceMany;
8 use crate::check::fatally_break_rust;
9 use crate::check::method::SelfSource;
10 use crate::check::report_unexpected_variant_res;
11 use crate::check::BreakableCtxt;
12 use crate::check::Diverges;
13 use crate::check::DynamicCoerceMany;
14 use crate::check::Expectation::{self, ExpectCastableToType, ExpectHasType, NoExpectation};
15 use crate::check::FnCtxt;
16 use crate::check::Needs;
17 use crate::check::TupleArgumentsFlag::DontTupleArguments;
19 FieldMultiplySpecifiedInInitializer, FunctionalRecordUpdateOnNonStruct,
20 YieldExprOutsideOfGenerator,
22 use crate::type_error_struct;
24 use super::suggest_call_constructor;
25 use crate::errors::{AddressOfTemporaryTaken, ReturnStmtOutsideOfFnBody, StructExprNonExhaustive};
27 use rustc_data_structures::fx::FxHashMap;
28 use rustc_data_structures::stack::ensure_sufficient_stack;
30 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, DiagnosticId,
31 ErrorGuaranteed, StashKey,
34 use rustc_hir::def::{CtorKind, DefKind, Res};
35 use rustc_hir::def_id::DefId;
36 use rustc_hir::intravisit::Visitor;
37 use rustc_hir::lang_items::LangItem;
38 use rustc_hir::{Closure, ExprKind, HirId, QPath};
39 use rustc_infer::infer;
40 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
41 use rustc_infer::infer::InferOk;
42 use rustc_infer::traits::ObligationCause;
43 use rustc_middle::middle::stability;
44 use rustc_middle::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase};
45 use rustc_middle::ty::error::TypeError::FieldMisMatch;
46 use rustc_middle::ty::subst::SubstsRef;
47 use rustc_middle::ty::{self, AdtKind, DefIdTree, Ty, TypeVisitable};
48 use rustc_session::parse::feature_err;
49 use rustc_span::hygiene::DesugaringKind;
50 use rustc_span::lev_distance::find_best_match_for_name;
51 use rustc_span::source_map::{Span, Spanned};
52 use rustc_span::symbol::{kw, sym, Ident, Symbol};
53 use rustc_target::spec::abi::Abi::RustIntrinsic;
54 use rustc_trait_selection::infer::InferCtxtExt;
55 use rustc_trait_selection::traits::{self, ObligationCauseCode};
57 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
58 fn check_expr_eq_type(&self, expr: &'tcx hir::Expr<'tcx>, expected: Ty<'tcx>) {
59 let ty = self.check_expr_with_hint(expr, expected);
60 self.demand_eqtype(expr.span, expected, ty);
63 pub fn check_expr_has_type_or_error(
65 expr: &'tcx hir::Expr<'tcx>,
67 extend_err: impl FnMut(&mut Diagnostic),
69 self.check_expr_meets_expectation_or_error(expr, ExpectHasType(expected), extend_err)
72 fn check_expr_meets_expectation_or_error(
74 expr: &'tcx hir::Expr<'tcx>,
75 expected: Expectation<'tcx>,
76 mut extend_err: impl FnMut(&mut Diagnostic),
78 let expected_ty = expected.to_option(&self).unwrap_or(self.tcx.types.bool);
79 let mut ty = self.check_expr_with_expectation(expr, expected);
81 // While we don't allow *arbitrary* coercions here, we *do* allow
82 // coercions from ! to `expected`.
84 if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
85 self.tcx().sess.delay_span_bug(
87 "expression with never type wound up being adjusted",
89 return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
96 let adj_ty = self.next_ty_var(TypeVariableOrigin {
97 kind: TypeVariableOriginKind::AdjustmentType,
100 self.apply_adjustments(
102 vec![Adjustment { kind: Adjust::NeverToAny, target: adj_ty }],
107 if let Some(mut err) = self.demand_suptype_diag(expr.span, expected_ty, ty) {
108 let expr = expr.peel_drop_temps();
109 self.suggest_deref_ref_or_into(&mut err, expr, expected_ty, ty, None);
110 extend_err(&mut err);
116 pub(super) fn check_expr_coercable_to_type(
118 expr: &'tcx hir::Expr<'tcx>,
120 expected_ty_expr: Option<&'tcx hir::Expr<'tcx>>,
122 let ty = self.check_expr_with_hint(expr, expected);
123 // checks don't need two phase
124 self.demand_coerce(expr, ty, expected, expected_ty_expr, AllowTwoPhase::No)
127 pub(super) fn check_expr_with_hint(
129 expr: &'tcx hir::Expr<'tcx>,
132 self.check_expr_with_expectation(expr, ExpectHasType(expected))
135 fn check_expr_with_expectation_and_needs(
137 expr: &'tcx hir::Expr<'tcx>,
138 expected: Expectation<'tcx>,
141 let ty = self.check_expr_with_expectation(expr, expected);
143 // If the expression is used in a place whether mutable place is required
144 // e.g. LHS of assignment, perform the conversion.
145 if let Needs::MutPlace = needs {
146 self.convert_place_derefs_to_mutable(expr);
152 pub(super) fn check_expr(&self, expr: &'tcx hir::Expr<'tcx>) -> Ty<'tcx> {
153 self.check_expr_with_expectation(expr, NoExpectation)
156 pub(super) fn check_expr_with_needs(
158 expr: &'tcx hir::Expr<'tcx>,
161 self.check_expr_with_expectation_and_needs(expr, NoExpectation, needs)
165 /// If an expression has any sub-expressions that result in a type error,
166 /// inspecting that expression's type with `ty.references_error()` will return
167 /// true. Likewise, if an expression is known to diverge, inspecting its
168 /// type with `ty::type_is_bot` will return true (n.b.: since Rust is
169 /// strict, _|_ can appear in the type of an expression that does not,
170 /// itself, diverge: for example, fn() -> _|_.)
171 /// Note that inspecting a type's structure *directly* may expose the fact
172 /// that there are actually multiple representations for `Error`, so avoid
173 /// that when err needs to be handled differently.
174 #[instrument(skip(self, expr), level = "debug")]
175 pub(super) fn check_expr_with_expectation(
177 expr: &'tcx hir::Expr<'tcx>,
178 expected: Expectation<'tcx>,
180 self.check_expr_with_expectation_and_args(expr, expected, &[])
183 /// Same as `check_expr_with_expectation`, but allows us to pass in the arguments of a
184 /// `ExprKind::Call` when evaluating its callee when it is an `ExprKind::Path`.
185 pub(super) fn check_expr_with_expectation_and_args(
187 expr: &'tcx hir::Expr<'tcx>,
188 expected: Expectation<'tcx>,
189 args: &'tcx [hir::Expr<'tcx>],
191 if self.tcx().sess.verbose() {
192 // make this code only run with -Zverbose because it is probably slow
193 if let Ok(lint_str) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
194 if !lint_str.contains('\n') {
195 debug!("expr text: {lint_str}");
197 let mut lines = lint_str.lines();
198 if let Some(line0) = lines.next() {
199 let remaining_lines = lines.count();
200 debug!("expr text: {line0}");
201 debug!("expr text: ...(and {remaining_lines} more lines)");
207 // True if `expr` is a `Try::from_ok(())` that is a result of desugaring a try block
208 // without the final expr (e.g. `try { return; }`). We don't want to generate an
209 // unreachable_code lint for it since warnings for autogenerated code are confusing.
210 let is_try_block_generated_unit_expr = match expr.kind {
211 ExprKind::Call(_, args) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {
212 args.len() == 1 && args[0].span.is_desugaring(DesugaringKind::TryBlock)
218 // Warn for expressions after diverging siblings.
219 if !is_try_block_generated_unit_expr {
220 self.warn_if_unreachable(expr.hir_id, expr.span, "expression");
223 // Hide the outer diverging and has_errors flags.
224 let old_diverges = self.diverges.replace(Diverges::Maybe);
225 let old_has_errors = self.has_errors.replace(false);
227 let ty = ensure_sufficient_stack(|| match &expr.kind {
229 qpath @ hir::QPath::Resolved(..) | qpath @ hir::QPath::TypeRelative(..),
230 ) => self.check_expr_path(qpath, expr, args),
231 _ => self.check_expr_kind(expr, expected),
234 // Warn for non-block expressions with diverging children.
240 | ExprKind::Match(..) => {}
241 // If `expr` is a result of desugaring the try block and is an ok-wrapped
242 // diverging expression (e.g. it arose from desugaring of `try { return }`),
243 // we skip issuing a warning because it is autogenerated code.
244 ExprKind::Call(..) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {}
245 ExprKind::Call(callee, _) => self.warn_if_unreachable(expr.hir_id, callee.span, "call"),
246 ExprKind::MethodCall(segment, ..) => {
247 self.warn_if_unreachable(expr.hir_id, segment.ident.span, "call")
249 _ => self.warn_if_unreachable(expr.hir_id, expr.span, "expression"),
252 // Any expression that produces a value of type `!` must have diverged
254 self.diverges.set(self.diverges.get() | Diverges::always(expr.span));
257 // Record the type, which applies it effects.
258 // We need to do this after the warning above, so that
259 // we don't warn for the diverging expression itself.
260 self.write_ty(expr.hir_id, ty);
262 // Combine the diverging and has_error flags.
263 self.diverges.set(self.diverges.get() | old_diverges);
264 self.has_errors.set(self.has_errors.get() | old_has_errors);
266 debug!("type of {} is...", self.tcx.hir().node_to_string(expr.hir_id));
267 debug!("... {:?}, expected is {:?}", ty, expected);
272 #[instrument(skip(self, expr), level = "debug")]
275 expr: &'tcx hir::Expr<'tcx>,
276 expected: Expectation<'tcx>,
278 trace!("expr={:#?}", expr);
282 ExprKind::Box(subexpr) => self.check_expr_box(subexpr, expected),
283 ExprKind::Lit(ref lit) => self.check_lit(&lit, expected),
284 ExprKind::Binary(op, lhs, rhs) => self.check_binop(expr, op, lhs, rhs, expected),
285 ExprKind::Assign(lhs, rhs, span) => {
286 self.check_expr_assign(expr, expected, lhs, rhs, span)
288 ExprKind::AssignOp(op, lhs, rhs) => {
289 self.check_binop_assign(expr, op, lhs, rhs, expected)
291 ExprKind::Unary(unop, oprnd) => self.check_expr_unary(unop, oprnd, expected, expr),
292 ExprKind::AddrOf(kind, mutbl, oprnd) => {
293 self.check_expr_addr_of(kind, mutbl, oprnd, expected, expr)
295 ExprKind::Path(QPath::LangItem(lang_item, _, hir_id)) => {
296 self.check_lang_item_path(lang_item, expr, hir_id)
298 ExprKind::Path(ref qpath) => self.check_expr_path(qpath, expr, &[]),
299 ExprKind::InlineAsm(asm) => {
300 // We defer some asm checks as we may not have resolved the input and output types yet (they may still be infer vars).
301 self.deferred_asm_checks.borrow_mut().push((asm, expr.hir_id));
302 self.check_expr_asm(asm)
304 ExprKind::Break(destination, ref expr_opt) => {
305 self.check_expr_break(destination, expr_opt.as_deref(), expr)
307 ExprKind::Continue(destination) => {
308 if destination.target_id.is_ok() {
311 // There was an error; make type-check fail.
315 ExprKind::Ret(ref expr_opt) => self.check_expr_return(expr_opt.as_deref(), expr),
316 ExprKind::Let(let_expr) => self.check_expr_let(let_expr),
317 ExprKind::Loop(body, _, source, _) => {
318 self.check_expr_loop(body, source, expected, expr)
320 ExprKind::Match(discrim, arms, match_src) => {
321 self.check_match(expr, &discrim, arms, expected, match_src)
323 ExprKind::Closure(&Closure { capture_clause, fn_decl, body, movability, .. }) => {
324 self.check_expr_closure(expr, capture_clause, &fn_decl, body, movability, expected)
326 ExprKind::Block(body, _) => self.check_block_with_expected(&body, expected),
327 ExprKind::Call(callee, args) => self.check_call(expr, &callee, args, expected),
328 ExprKind::MethodCall(segment, args, _) => {
329 self.check_method_call(expr, segment, args, expected)
331 ExprKind::Cast(e, t) => self.check_expr_cast(e, t, expr),
332 ExprKind::Type(e, t) => {
333 let ty = self.to_ty_saving_user_provided_ty(&t);
334 self.check_expr_eq_type(&e, ty);
337 ExprKind::If(cond, then_expr, opt_else_expr) => {
338 self.check_then_else(cond, then_expr, opt_else_expr, expr.span, expected)
340 ExprKind::DropTemps(e) => self.check_expr_with_expectation(e, expected),
341 ExprKind::Array(args) => self.check_expr_array(args, expected, expr),
342 ExprKind::ConstBlock(ref anon_const) => {
343 self.check_expr_const_block(anon_const, expected, expr)
345 ExprKind::Repeat(element, ref count) => {
346 self.check_expr_repeat(element, count, expected, expr)
348 ExprKind::Tup(elts) => self.check_expr_tuple(elts, expected, expr),
349 ExprKind::Struct(qpath, fields, ref base_expr) => {
350 self.check_expr_struct(expr, expected, qpath, fields, base_expr)
352 ExprKind::Field(base, field) => self.check_field(expr, &base, field),
353 ExprKind::Index(base, idx) => self.check_expr_index(base, idx, expr),
354 ExprKind::Yield(value, ref src) => self.check_expr_yield(value, expr, src),
355 hir::ExprKind::Err => tcx.ty_error(),
359 fn check_expr_box(&self, expr: &'tcx hir::Expr<'tcx>, expected: Expectation<'tcx>) -> Ty<'tcx> {
360 let expected_inner = expected.to_option(self).map_or(NoExpectation, |ty| match ty.kind() {
361 ty::Adt(def, _) if def.is_box() => Expectation::rvalue_hint(self, ty.boxed_ty()),
364 let referent_ty = self.check_expr_with_expectation(expr, expected_inner);
365 self.require_type_is_sized(referent_ty, expr.span, traits::SizedBoxType);
366 self.tcx.mk_box(referent_ty)
372 oprnd: &'tcx hir::Expr<'tcx>,
373 expected: Expectation<'tcx>,
374 expr: &'tcx hir::Expr<'tcx>,
377 let expected_inner = match unop {
378 hir::UnOp::Not | hir::UnOp::Neg => expected,
379 hir::UnOp::Deref => NoExpectation,
381 let mut oprnd_t = self.check_expr_with_expectation(&oprnd, expected_inner);
383 if !oprnd_t.references_error() {
384 oprnd_t = self.structurally_resolved_type(expr.span, oprnd_t);
386 hir::UnOp::Deref => {
387 if let Some(ty) = self.lookup_derefing(expr, oprnd, oprnd_t) {
390 let mut err = type_error_struct!(
395 "type `{oprnd_t}` cannot be dereferenced",
397 let sp = tcx.sess.source_map().start_point(expr.span);
399 tcx.sess.parse_sess.ambiguous_block_expr_parse.borrow().get(&sp)
401 tcx.sess.parse_sess.expr_parentheses_needed(&mut err, *sp);
404 oprnd_t = tcx.ty_error();
408 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
409 // If it's builtin, we can reuse the type, this helps inference.
410 if !(oprnd_t.is_integral() || *oprnd_t.kind() == ty::Bool) {
415 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
416 // If it's builtin, we can reuse the type, this helps inference.
417 if !oprnd_t.is_numeric() {
426 fn check_expr_addr_of(
428 kind: hir::BorrowKind,
429 mutbl: hir::Mutability,
430 oprnd: &'tcx hir::Expr<'tcx>,
431 expected: Expectation<'tcx>,
432 expr: &'tcx hir::Expr<'tcx>,
434 let hint = expected.only_has_type(self).map_or(NoExpectation, |ty| {
436 ty::Ref(_, ty, _) | ty::RawPtr(ty::TypeAndMut { ty, .. }) => {
437 if oprnd.is_syntactic_place_expr() {
438 // Places may legitimately have unsized types.
439 // For example, dereferences of a fat pointer and
440 // the last field of a struct can be unsized.
443 Expectation::rvalue_hint(self, *ty)
450 self.check_expr_with_expectation_and_needs(&oprnd, hint, Needs::maybe_mut_place(mutbl));
452 let tm = ty::TypeAndMut { ty, mutbl };
454 _ if tm.ty.references_error() => self.tcx.ty_error(),
455 hir::BorrowKind::Raw => {
456 self.check_named_place_expr(oprnd);
459 hir::BorrowKind::Ref => {
460 // Note: at this point, we cannot say what the best lifetime
461 // is to use for resulting pointer. We want to use the
462 // shortest lifetime possible so as to avoid spurious borrowck
463 // errors. Moreover, the longest lifetime will depend on the
464 // precise details of the value whose address is being taken
465 // (and how long it is valid), which we don't know yet until
466 // type inference is complete.
468 // Therefore, here we simply generate a region variable. The
469 // region inferencer will then select a suitable value.
470 // Finally, borrowck will infer the value of the region again,
471 // this time with enough precision to check that the value
472 // whose address was taken can actually be made to live as long
473 // as it needs to live.
474 let region = self.next_region_var(infer::AddrOfRegion(expr.span));
475 self.tcx.mk_ref(region, tm)
480 /// Does this expression refer to a place that either:
481 /// * Is based on a local or static.
482 /// * Contains a dereference
483 /// Note that the adjustments for the children of `expr` should already
484 /// have been resolved.
485 fn check_named_place_expr(&self, oprnd: &'tcx hir::Expr<'tcx>) {
486 let is_named = oprnd.is_place_expr(|base| {
487 // Allow raw borrows if there are any deref adjustments.
489 // const VAL: (i32,) = (0,);
490 // const REF: &(i32,) = &(0,);
492 // &raw const VAL.0; // ERROR
493 // &raw const REF.0; // OK, same as &raw const (*REF).0;
495 // This is maybe too permissive, since it allows
496 // `let u = &raw const Box::new((1,)).0`, which creates an
497 // immediately dangling raw pointer.
502 .map_or(false, |x| x.iter().any(|adj| matches!(adj.kind, Adjust::Deref(_))))
505 self.tcx.sess.emit_err(AddressOfTemporaryTaken { span: oprnd.span });
509 fn check_lang_item_path(
511 lang_item: hir::LangItem,
512 expr: &'tcx hir::Expr<'tcx>,
513 hir_id: Option<hir::HirId>,
515 self.resolve_lang_item_path(lang_item, expr.span, expr.hir_id, hir_id).1
518 pub(crate) fn check_expr_path(
520 qpath: &'tcx hir::QPath<'tcx>,
521 expr: &'tcx hir::Expr<'tcx>,
522 args: &'tcx [hir::Expr<'tcx>],
525 let (res, opt_ty, segs) =
526 self.resolve_ty_and_res_fully_qualified_call(qpath, expr.hir_id, expr.span);
529 self.set_tainted_by_errors();
532 Res::Def(DefKind::Ctor(_, CtorKind::Fictive), _) => {
533 report_unexpected_variant_res(tcx, res, qpath, expr.span);
536 _ => self.instantiate_value_path(segs, opt_ty, res, expr.span, expr.hir_id).0,
539 if let ty::FnDef(did, ..) = *ty.kind() {
540 let fn_sig = ty.fn_sig(tcx);
541 if tcx.fn_sig(did).abi() == RustIntrinsic && tcx.item_name(did) == sym::transmute {
542 let from = fn_sig.inputs().skip_binder()[0];
543 let to = fn_sig.output().skip_binder();
544 // We defer the transmute to the end of typeck, once all inference vars have
545 // been resolved or we errored. This is important as we can only check transmute
546 // on concrete types, but the output type may not be known yet (it would only
547 // be known if explicitly specified via turbofish).
548 self.deferred_transmute_checks.borrow_mut().push((from, to, expr.span));
550 if !tcx.features().unsized_fn_params {
551 // We want to remove some Sized bounds from std functions,
552 // but don't want to expose the removal to stable Rust.
553 // i.e., we don't want to allow
559 // to work in stable even if the Sized bound on `drop` is relaxed.
560 for i in 0..fn_sig.inputs().skip_binder().len() {
561 // We just want to check sizedness, so instead of introducing
562 // placeholder lifetimes with probing, we just replace higher lifetimes
564 let span = args.get(i).map(|a| a.span).unwrap_or(expr.span);
565 let input = self.replace_bound_vars_with_fresh_vars(
567 infer::LateBoundRegionConversionTime::FnCall,
570 self.require_type_is_sized_deferred(
573 traits::SizedArgumentType(None),
577 // Here we want to prevent struct constructors from returning unsized types.
578 // There were two cases this happened: fn pointer coercion in stable
579 // and usual function call in presence of unsized_locals.
580 // Also, as we just want to check sizedness, instead of introducing
581 // placeholder lifetimes with probing, we just replace higher lifetimes
583 let output = self.replace_bound_vars_with_fresh_vars(
585 infer::LateBoundRegionConversionTime::FnCall,
588 self.require_type_is_sized_deferred(output, expr.span, traits::SizedReturnType);
591 // We always require that the type provided as the value for
592 // a type parameter outlives the moment of instantiation.
593 let substs = self.typeck_results.borrow().node_substs(expr.hir_id);
594 self.add_wf_bounds(substs, expr);
601 destination: hir::Destination,
602 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
603 expr: &'tcx hir::Expr<'tcx>,
606 if let Ok(target_id) = destination.target_id {
608 if let Some(e) = expr_opt {
609 // If this is a break with a value, we need to type-check
610 // the expression. Get an expected type from the loop context.
611 let opt_coerce_to = {
612 // We should release `enclosing_breakables` before the `check_expr_with_hint`
613 // below, so can't move this block of code to the enclosing scope and share
614 // `ctxt` with the second `enclosing_breakables` borrow below.
615 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
616 match enclosing_breakables.opt_find_breakable(target_id) {
617 Some(ctxt) => ctxt.coerce.as_ref().map(|coerce| coerce.expected_ty()),
619 // Avoid ICE when `break` is inside a closure (#65383).
620 return tcx.ty_error_with_message(
622 "break was outside loop, but no error was emitted",
628 // If the loop context is not a `loop { }`, then break with
629 // a value is illegal, and `opt_coerce_to` will be `None`.
630 // Just set expectation to error in that case.
631 let coerce_to = opt_coerce_to.unwrap_or_else(|| tcx.ty_error());
633 // Recurse without `enclosing_breakables` borrowed.
634 e_ty = self.check_expr_with_hint(e, coerce_to);
635 cause = self.misc(e.span);
637 // Otherwise, this is a break *without* a value. That's
638 // always legal, and is equivalent to `break ()`.
639 e_ty = tcx.mk_unit();
640 cause = self.misc(expr.span);
643 // Now that we have type-checked `expr_opt`, borrow
644 // the `enclosing_loops` field and let's coerce the
645 // type of `expr_opt` into what is expected.
646 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
647 let Some(ctxt) = enclosing_breakables.opt_find_breakable(target_id) else {
648 // Avoid ICE when `break` is inside a closure (#65383).
649 return tcx.ty_error_with_message(
651 "break was outside loop, but no error was emitted",
655 if let Some(ref mut coerce) = ctxt.coerce {
656 if let Some(ref e) = expr_opt {
657 coerce.coerce(self, &cause, e, e_ty);
659 assert!(e_ty.is_unit());
660 let ty = coerce.expected_ty();
661 coerce.coerce_forced_unit(
665 self.suggest_mismatched_types_on_tail(
666 &mut err, expr, ty, e_ty, target_id,
668 if let Some(val) = ty_kind_suggestion(ty) {
669 let label = destination
671 .map(|l| format!(" {}", l.ident))
672 .unwrap_or_else(String::new);
675 "give it a value of the expected type",
676 format!("break{label} {val}"),
677 Applicability::HasPlaceholders,
685 // If `ctxt.coerce` is `None`, we can just ignore
686 // the type of the expression. This is because
687 // either this was a break *without* a value, in
688 // which case it is always a legal type (`()`), or
689 // else an error would have been flagged by the
690 // `loops` pass for using break with an expression
691 // where you are not supposed to.
692 assert!(expr_opt.is_none() || self.tcx.sess.has_errors().is_some());
695 // If we encountered a `break`, then (no surprise) it may be possible to break from the
696 // loop... unless the value being returned from the loop diverges itself, e.g.
697 // `break return 5` or `break loop {}`.
698 ctxt.may_break |= !self.diverges.get().is_always();
700 // the type of a `break` is always `!`, since it diverges
703 // Otherwise, we failed to find the enclosing loop;
704 // this can only happen if the `break` was not
705 // inside a loop at all, which is caught by the
706 // loop-checking pass.
707 let err = self.tcx.ty_error_with_message(
709 "break was outside loop, but no error was emitted",
712 // We still need to assign a type to the inner expression to
713 // prevent the ICE in #43162.
714 if let Some(e) = expr_opt {
715 self.check_expr_with_hint(e, err);
717 // ... except when we try to 'break rust;'.
718 // ICE this expression in particular (see #43162).
719 if let ExprKind::Path(QPath::Resolved(_, path)) = e.kind {
720 if path.segments.len() == 1 && path.segments[0].ident.name == sym::rust {
721 fatally_break_rust(self.tcx.sess);
726 // There was an error; make type-check fail.
731 fn check_expr_return(
733 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
734 expr: &'tcx hir::Expr<'tcx>,
736 if self.ret_coercion.is_none() {
737 let mut err = ReturnStmtOutsideOfFnBody {
739 encl_body_span: None,
743 let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
745 if let Some(hir::Node::Item(hir::Item {
746 kind: hir::ItemKind::Fn(..),
750 | Some(hir::Node::TraitItem(hir::TraitItem {
751 kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),
755 | Some(hir::Node::ImplItem(hir::ImplItem {
756 kind: hir::ImplItemKind::Fn(..),
759 })) = self.tcx.hir().find_by_def_id(encl_item_id)
761 // We are inside a function body, so reporting "return statement
762 // outside of function body" needs an explanation.
764 let encl_body_owner_id = self.tcx.hir().enclosing_body_owner(expr.hir_id);
766 // If this didn't hold, we would not have to report an error in
768 assert_ne!(encl_item_id, encl_body_owner_id);
770 let encl_body_id = self.tcx.hir().body_owned_by(encl_body_owner_id);
771 let encl_body = self.tcx.hir().body(encl_body_id);
773 err.encl_body_span = Some(encl_body.value.span);
774 err.encl_fn_span = Some(*encl_fn_span);
777 self.tcx.sess.emit_err(err);
779 if let Some(e) = expr_opt {
780 // We still have to type-check `e` (issue #86188), but calling
781 // `check_return_expr` only works inside fn bodies.
784 } else if let Some(e) = expr_opt {
785 if self.ret_coercion_span.get().is_none() {
786 self.ret_coercion_span.set(Some(e.span));
788 self.check_return_expr(e, true);
790 let mut coercion = self.ret_coercion.as_ref().unwrap().borrow_mut();
791 if self.ret_coercion_span.get().is_none() {
792 self.ret_coercion_span.set(Some(expr.span));
794 let cause = self.cause(expr.span, ObligationCauseCode::ReturnNoExpression);
795 if let Some((fn_decl, _)) = self.get_fn_decl(expr.hir_id) {
796 coercion.coerce_forced_unit(
800 let span = fn_decl.output.span();
801 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
804 format!("expected `{snippet}` because of this return type"),
811 coercion.coerce_forced_unit(self, &cause, &mut |_| (), true);
817 /// `explicit_return` is `true` if we're checking an explicit `return expr`,
818 /// and `false` if we're checking a trailing expression.
819 pub(super) fn check_return_expr(
821 return_expr: &'tcx hir::Expr<'tcx>,
822 explicit_return: bool,
824 let ret_coercion = self.ret_coercion.as_ref().unwrap_or_else(|| {
825 span_bug!(return_expr.span, "check_return_expr called outside fn body")
828 let ret_ty = ret_coercion.borrow().expected_ty();
829 let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty);
830 let mut span = return_expr.span;
831 // Use the span of the trailing expression for our cause,
832 // not the span of the entire function
833 if !explicit_return {
834 if let ExprKind::Block(body, _) = return_expr.kind && let Some(last_expr) = body.expr {
835 span = last_expr.span;
838 ret_coercion.borrow_mut().coerce(
840 &self.cause(span, ObligationCauseCode::ReturnValue(return_expr.hir_id)),
845 if self.return_type_has_opaque {
846 // Point any obligations that were registered due to opaque type
847 // inference at the return expression.
848 self.select_obligations_where_possible(false, |errors| {
849 self.point_at_return_for_opaque_ty_error(errors, span, return_expr_ty);
854 fn point_at_return_for_opaque_ty_error(
856 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
858 return_expr_ty: Ty<'tcx>,
860 // Don't point at the whole block if it's empty
861 if span == self.tcx.hir().span(self.body_id) {
865 let cause = &mut err.obligation.cause;
866 if let ObligationCauseCode::OpaqueReturnType(None) = cause.code() {
867 let new_cause = ObligationCause::new(
870 ObligationCauseCode::OpaqueReturnType(Some((return_expr_ty, span))),
877 pub(crate) fn check_lhs_assignable(
879 lhs: &'tcx hir::Expr<'tcx>,
880 err_code: &'static str,
882 adjust_err: impl FnOnce(&mut Diagnostic),
884 if lhs.is_syntactic_place_expr() {
888 // FIXME: Make this use SessionDiagnostic once error codes can be dynamically set.
889 let mut err = self.tcx.sess.struct_span_err_with_code(
891 "invalid left-hand side of assignment",
892 DiagnosticId::Error(err_code.into()),
894 err.span_label(lhs.span, "cannot assign to this expression");
896 self.comes_from_while_condition(lhs.hir_id, |expr| {
897 err.span_suggestion_verbose(
898 expr.span.shrink_to_lo(),
899 "you might have meant to use pattern destructuring",
901 Applicability::MachineApplicable,
905 adjust_err(&mut err);
910 // Check if an expression `original_expr_id` comes from the condition of a while loop,
911 // as opposed from the body of a while loop, which we can naively check by iterating
912 // parents until we find a loop...
913 pub(super) fn comes_from_while_condition(
915 original_expr_id: HirId,
916 then: impl FnOnce(&hir::Expr<'_>),
918 let mut parent = self.tcx.hir().get_parent_node(original_expr_id);
919 while let Some(node) = self.tcx.hir().find(parent) {
921 hir::Node::Expr(hir::Expr {
928 hir::ExprKind::Match(expr, ..) | hir::ExprKind::If(expr, ..),
934 hir::LoopSource::While,
939 // Check if our original expression is a child of the condition of a while loop
940 let expr_is_ancestor = std::iter::successors(Some(original_expr_id), |id| {
941 self.tcx.hir().find_parent_node(*id)
943 .take_while(|id| *id != parent)
944 .any(|id| id == expr.hir_id);
945 // if it is, then we have a situation like `while Some(0) = value.get(0) {`,
946 // where `while let` was more likely intended.
947 if expr_is_ancestor {
953 | hir::Node::ImplItem(_)
954 | hir::Node::TraitItem(_)
955 | hir::Node::Crate(_) => break,
957 parent = self.tcx.hir().get_parent_node(parent);
963 // A generic function for checking the 'then' and 'else' clauses in an 'if'
964 // or 'if-else' expression.
967 cond_expr: &'tcx hir::Expr<'tcx>,
968 then_expr: &'tcx hir::Expr<'tcx>,
969 opt_else_expr: Option<&'tcx hir::Expr<'tcx>>,
971 orig_expected: Expectation<'tcx>,
973 let cond_ty = self.check_expr_has_type_or_error(cond_expr, self.tcx.types.bool, |_| {});
975 self.warn_if_unreachable(
978 "block in `if` or `while` expression",
981 let cond_diverges = self.diverges.get();
982 self.diverges.set(Diverges::Maybe);
984 let expected = orig_expected.adjust_for_branches(self);
985 let then_ty = self.check_expr_with_expectation(then_expr, expected);
986 let then_diverges = self.diverges.get();
987 self.diverges.set(Diverges::Maybe);
989 // We've already taken the expected type's preferences
990 // into account when typing the `then` branch. To figure
991 // out the initial shot at a LUB, we thus only consider
992 // `expected` if it represents a *hard* constraint
993 // (`only_has_type`); otherwise, we just go with a
994 // fresh type variable.
995 let coerce_to_ty = expected.coercion_target_type(self, sp);
996 let mut coerce: DynamicCoerceMany<'_> = CoerceMany::new(coerce_to_ty);
998 coerce.coerce(self, &self.misc(sp), then_expr, then_ty);
1000 if let Some(else_expr) = opt_else_expr {
1001 let else_ty = self.check_expr_with_expectation(else_expr, expected);
1002 let else_diverges = self.diverges.get();
1004 let opt_suggest_box_span = self.opt_suggest_box_span(then_ty, else_ty, orig_expected);
1005 let if_cause = self.if_cause(
1012 opt_suggest_box_span,
1015 coerce.coerce(self, &if_cause, else_expr, else_ty);
1017 // We won't diverge unless both branches do (or the condition does).
1018 self.diverges.set(cond_diverges | then_diverges & else_diverges);
1020 self.if_fallback_coercion(sp, then_expr, &mut coerce);
1022 // If the condition is false we can't diverge.
1023 self.diverges.set(cond_diverges);
1026 let result_ty = coerce.complete(self);
1027 if cond_ty.references_error() { self.tcx.ty_error() } else { result_ty }
1030 /// Type check assignment expression `expr` of form `lhs = rhs`.
1031 /// The expected type is `()` and is passed to the function for the purposes of diagnostics.
1032 fn check_expr_assign(
1034 expr: &'tcx hir::Expr<'tcx>,
1035 expected: Expectation<'tcx>,
1036 lhs: &'tcx hir::Expr<'tcx>,
1037 rhs: &'tcx hir::Expr<'tcx>,
1040 let expected_ty = expected.coercion_target_type(self, expr.span);
1041 if expected_ty == self.tcx.types.bool {
1042 // The expected type is `bool` but this will result in `()` so we can reasonably
1043 // say that the user intended to write `lhs == rhs` instead of `lhs = rhs`.
1044 // The likely cause of this is `if foo = bar { .. }`.
1045 let actual_ty = self.tcx.mk_unit();
1046 let mut err = self.demand_suptype_diag(expr.span, expected_ty, actual_ty).unwrap();
1047 let lhs_ty = self.check_expr(&lhs);
1048 let rhs_ty = self.check_expr(&rhs);
1049 let (applicability, eq) = if self.can_coerce(rhs_ty, lhs_ty) {
1050 (Applicability::MachineApplicable, true)
1052 (Applicability::MaybeIncorrect, false)
1054 if !lhs.is_syntactic_place_expr()
1055 && lhs.is_approximately_pattern()
1056 && !matches!(lhs.kind, hir::ExprKind::Lit(_))
1058 // Do not suggest `if let x = y` as `==` is way more likely to be the intention.
1059 let hir = self.tcx.hir();
1060 if let hir::Node::Expr(hir::Expr { kind: ExprKind::If { .. }, .. }) =
1061 hir.get(hir.get_parent_node(hir.get_parent_node(expr.hir_id)))
1063 err.span_suggestion_verbose(
1064 expr.span.shrink_to_lo(),
1065 "you might have meant to use pattern matching",
1072 err.span_suggestion_verbose(
1074 "you might have meant to compare for equality",
1080 // If the assignment expression itself is ill-formed, don't
1081 // bother emitting another error
1082 if lhs_ty.references_error() || rhs_ty.references_error() {
1087 return self.tcx.ty_error();
1090 let lhs_ty = self.check_expr_with_needs(&lhs, Needs::MutPlace);
1092 let suggest_deref_binop = |err: &mut Diagnostic, rhs_ty: Ty<'tcx>| {
1093 if let Some(lhs_deref_ty) = self.deref_once_mutably_for_diagnostic(lhs_ty) {
1094 // Can only assign if the type is sized, so if `DerefMut` yields a type that is
1095 // unsized, do not suggest dereferencing it.
1096 let lhs_deref_ty_is_sized = self
1098 .type_implements_trait(
1099 self.tcx.lang_items().sized_trait().unwrap(),
1105 if lhs_deref_ty_is_sized && self.can_coerce(rhs_ty, lhs_deref_ty) {
1106 err.span_suggestion_verbose(
1107 lhs.span.shrink_to_lo(),
1108 "consider dereferencing here to assign to the mutably borrowed value",
1110 Applicability::MachineApplicable,
1116 self.check_lhs_assignable(lhs, "E0070", span, |err| {
1117 let rhs_ty = self.check_expr(&rhs);
1118 suggest_deref_binop(err, rhs_ty);
1121 // This is (basically) inlined `check_expr_coercable_to_type`, but we want
1122 // to suggest an additional fixup here in `suggest_deref_binop`.
1123 let rhs_ty = self.check_expr_with_hint(&rhs, lhs_ty);
1124 if let (_, Some(mut diag)) =
1125 self.demand_coerce_diag(rhs, rhs_ty, lhs_ty, Some(lhs), AllowTwoPhase::No)
1127 suggest_deref_binop(&mut diag, rhs_ty);
1131 self.require_type_is_sized(lhs_ty, lhs.span, traits::AssignmentLhsSized);
1133 if lhs_ty.references_error() || rhs_ty.references_error() {
1140 pub(super) fn check_expr_let(&self, let_expr: &'tcx hir::Let<'tcx>) -> Ty<'tcx> {
1141 // for let statements, this is done in check_stmt
1142 let init = let_expr.init;
1143 self.warn_if_unreachable(init.hir_id, init.span, "block in `let` expression");
1144 // otherwise check exactly as a let statement
1145 self.check_decl(let_expr.into());
1146 // but return a bool, for this is a boolean expression
1152 body: &'tcx hir::Block<'tcx>,
1153 source: hir::LoopSource,
1154 expected: Expectation<'tcx>,
1155 expr: &'tcx hir::Expr<'tcx>,
1157 let coerce = match source {
1158 // you can only use break with a value from a normal `loop { }`
1159 hir::LoopSource::Loop => {
1160 let coerce_to = expected.coercion_target_type(self, body.span);
1161 Some(CoerceMany::new(coerce_to))
1164 hir::LoopSource::While | hir::LoopSource::ForLoop => None,
1167 let ctxt = BreakableCtxt {
1169 may_break: false, // Will get updated if/when we find a `break`.
1172 let (ctxt, ()) = self.with_breakable_ctxt(expr.hir_id, ctxt, || {
1173 self.check_block_no_value(&body);
1177 // No way to know whether it's diverging because
1178 // of a `break` or an outer `break` or `return`.
1179 self.diverges.set(Diverges::Maybe);
1182 // If we permit break with a value, then result type is
1183 // the LUB of the breaks (possibly ! if none); else, it
1184 // is nil. This makes sense because infinite loops
1185 // (which would have type !) are only possible iff we
1186 // permit break with a value [1].
1187 if ctxt.coerce.is_none() && !ctxt.may_break {
1189 self.tcx.sess.delay_span_bug(body.span, "no coercion, but loop may not break");
1191 ctxt.coerce.map(|c| c.complete(self)).unwrap_or_else(|| self.tcx.mk_unit())
1194 /// Checks a method call.
1195 fn check_method_call(
1197 expr: &'tcx hir::Expr<'tcx>,
1198 segment: &hir::PathSegment<'_>,
1199 args: &'tcx [hir::Expr<'tcx>],
1200 expected: Expectation<'tcx>,
1202 let rcvr = &args[0];
1203 let rcvr_t = self.check_expr(&rcvr);
1204 // no need to check for bot/err -- callee does that
1205 let rcvr_t = self.structurally_resolved_type(args[0].span, rcvr_t);
1206 let span = segment.ident.span;
1208 let method = match self.lookup_method(rcvr_t, segment, span, expr, rcvr, args) {
1210 // We could add a "consider `foo::<params>`" suggestion here, but I wasn't able to
1211 // trigger this codepath causing `structurally_resolved_type` to emit an error.
1213 self.write_method_call(expr.hir_id, method);
1217 if segment.ident.name != kw::Empty {
1218 if let Some(mut err) = self.report_method_error(
1222 SelfSource::MethodCall(&args[0]),
1233 // Call the generic checker.
1234 self.check_method_argument_types(
1246 e: &'tcx hir::Expr<'tcx>,
1247 t: &'tcx hir::Ty<'tcx>,
1248 expr: &'tcx hir::Expr<'tcx>,
1250 // Find the type of `e`. Supply hints based on the type we are casting to,
1252 let t_cast = self.to_ty_saving_user_provided_ty(t);
1253 let t_cast = self.resolve_vars_if_possible(t_cast);
1254 let t_expr = self.check_expr_with_expectation(e, ExpectCastableToType(t_cast));
1255 let t_expr = self.resolve_vars_if_possible(t_expr);
1257 // Eagerly check for some obvious errors.
1258 if t_expr.references_error() || t_cast.references_error() {
1261 // Defer other checks until we're done type checking.
1262 let mut deferred_cast_checks = self.deferred_cast_checks.borrow_mut();
1263 match cast::CastCheck::new(self, e, t_expr, t_cast, t.span, expr.span) {
1266 "check_expr_cast: deferring cast from {:?} to {:?}: {:?}",
1267 t_cast, t_expr, cast_check,
1269 deferred_cast_checks.push(cast_check);
1272 Err(_) => self.tcx.ty_error(),
1277 fn check_expr_array(
1279 args: &'tcx [hir::Expr<'tcx>],
1280 expected: Expectation<'tcx>,
1281 expr: &'tcx hir::Expr<'tcx>,
1283 let element_ty = if !args.is_empty() {
1284 let coerce_to = expected
1286 .and_then(|uty| match *uty.kind() {
1287 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1290 .unwrap_or_else(|| {
1291 self.next_ty_var(TypeVariableOrigin {
1292 kind: TypeVariableOriginKind::TypeInference,
1296 let mut coerce = CoerceMany::with_coercion_sites(coerce_to, args);
1297 assert_eq!(self.diverges.get(), Diverges::Maybe);
1299 let e_ty = self.check_expr_with_hint(e, coerce_to);
1300 let cause = self.misc(e.span);
1301 coerce.coerce(self, &cause, e, e_ty);
1303 coerce.complete(self)
1305 self.next_ty_var(TypeVariableOrigin {
1306 kind: TypeVariableOriginKind::TypeInference,
1310 let array_len = args.len() as u64;
1311 self.suggest_array_len(expr, array_len);
1312 self.tcx.mk_array(element_ty, array_len)
1315 fn suggest_array_len(&self, expr: &'tcx hir::Expr<'tcx>, array_len: u64) {
1316 if let Some(parent_hir_id) = self.tcx.hir().find_parent_node(expr.hir_id) {
1317 let ty = match self.tcx.hir().find(parent_hir_id) {
1319 hir::Node::Local(hir::Local { ty: Some(ty), .. })
1320 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Const(ty, _), .. }),
1324 if let Some(ty) = ty
1325 && let hir::TyKind::Array(_, length) = ty.kind
1326 && let hir::ArrayLen::Body(hir::AnonConst { hir_id, .. }) = length
1327 && let Some(span) = self.tcx.hir().opt_span(hir_id)
1329 match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
1331 err.span_suggestion(
1333 "consider specifying the array length",
1335 Applicability::MaybeIncorrect,
1345 fn check_expr_const_block(
1347 anon_const: &'tcx hir::AnonConst,
1348 expected: Expectation<'tcx>,
1349 _expr: &'tcx hir::Expr<'tcx>,
1351 let body = self.tcx.hir().body(anon_const.body);
1353 // Create a new function context.
1354 let fcx = FnCtxt::new(self, self.param_env.with_const(), body.value.hir_id);
1355 crate::check::GatherLocalsVisitor::new(&fcx).visit_body(body);
1357 let ty = fcx.check_expr_with_expectation(&body.value, expected);
1358 fcx.require_type_is_sized(ty, body.value.span, traits::ConstSized);
1359 fcx.write_ty(anon_const.hir_id, ty);
1363 fn check_expr_repeat(
1365 element: &'tcx hir::Expr<'tcx>,
1366 count: &'tcx hir::ArrayLen,
1367 expected: Expectation<'tcx>,
1368 expr: &'tcx hir::Expr<'tcx>,
1371 let count = self.array_length_to_const(count);
1372 if let Some(count) = count.try_eval_usize(tcx, self.param_env) {
1373 self.suggest_array_len(expr, count);
1376 let uty = match expected {
1377 ExpectHasType(uty) => match *uty.kind() {
1378 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1384 let (element_ty, t) = match uty {
1386 self.check_expr_coercable_to_type(&element, uty, None);
1390 let ty = self.next_ty_var(TypeVariableOrigin {
1391 kind: TypeVariableOriginKind::MiscVariable,
1394 let element_ty = self.check_expr_has_type_or_error(&element, ty, |_| {});
1399 if element_ty.references_error() {
1400 return tcx.ty_error();
1403 self.check_repeat_element_needs_copy_bound(element, count, element_ty);
1405 tcx.mk_ty(ty::Array(t, count))
1408 fn check_repeat_element_needs_copy_bound(
1410 element: &hir::Expr<'_>,
1411 count: ty::Const<'tcx>,
1412 element_ty: Ty<'tcx>,
1415 // Actual constants as the repeat element get inserted repeatedly instead of getting copied via Copy.
1416 match &element.kind {
1417 hir::ExprKind::ConstBlock(..) => return,
1418 hir::ExprKind::Path(qpath) => {
1419 let res = self.typeck_results.borrow().qpath_res(qpath, element.hir_id);
1420 if let Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::AnonConst, _) = res
1427 // If someone calls a const fn, they can extract that call out into a separate constant (or a const
1428 // block in the future), so we check that to tell them that in the diagnostic. Does not affect typeck.
1429 let is_const_fn = match element.kind {
1430 hir::ExprKind::Call(func, _args) => match *self.node_ty(func.hir_id).kind() {
1431 ty::FnDef(def_id, _) => tcx.is_const_fn(def_id),
1437 // If the length is 0, we don't create any elements, so we don't copy any. If the length is 1, we
1438 // don't copy that one element, we move it. Only check for Copy if the length is larger.
1439 if count.try_eval_usize(tcx, self.param_env).map_or(true, |len| len > 1) {
1440 let lang_item = self.tcx.require_lang_item(LangItem::Copy, None);
1441 let code = traits::ObligationCauseCode::RepeatElementCopy { is_const_fn };
1442 self.require_type_meets(element_ty, element.span, code, lang_item);
1446 fn check_expr_tuple(
1448 elts: &'tcx [hir::Expr<'tcx>],
1449 expected: Expectation<'tcx>,
1450 expr: &'tcx hir::Expr<'tcx>,
1452 let flds = expected.only_has_type(self).and_then(|ty| {
1453 let ty = self.resolve_vars_with_obligations(ty);
1455 ty::Tuple(flds) => Some(&flds[..]),
1460 let elt_ts_iter = elts.iter().enumerate().map(|(i, e)| match flds {
1461 Some(fs) if i < fs.len() => {
1463 self.check_expr_coercable_to_type(&e, ety, None);
1466 _ => self.check_expr_with_expectation(&e, NoExpectation),
1468 let tuple = self.tcx.mk_tup(elt_ts_iter);
1469 if tuple.references_error() {
1472 self.require_type_is_sized(tuple, expr.span, traits::TupleInitializerSized);
1477 fn check_expr_struct(
1479 expr: &hir::Expr<'_>,
1480 expected: Expectation<'tcx>,
1482 fields: &'tcx [hir::ExprField<'tcx>],
1483 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1485 // Find the relevant variant
1486 let Some((variant, adt_ty)) = self.check_struct_path(qpath, expr.hir_id) else {
1487 self.check_struct_fields_on_error(fields, base_expr);
1488 return self.tcx.ty_error();
1491 // Prohibit struct expressions when non-exhaustive flag is set.
1492 let adt = adt_ty.ty_adt_def().expect("`check_struct_path` returned non-ADT type");
1493 if !adt.did().is_local() && variant.is_field_list_non_exhaustive() {
1496 .emit_err(StructExprNonExhaustive { span: expr.span, what: adt.variant_descr() });
1499 self.check_expr_struct_fields(
1510 self.require_type_is_sized(adt_ty, expr.span, traits::StructInitializerSized);
1514 fn check_expr_struct_fields(
1517 expected: Expectation<'tcx>,
1518 expr_id: hir::HirId,
1520 variant: &'tcx ty::VariantDef,
1521 ast_fields: &'tcx [hir::ExprField<'tcx>],
1522 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1527 let expected_inputs =
1528 self.expected_inputs_for_expected_output(span, expected, adt_ty, &[adt_ty]);
1529 let adt_ty_hint = if let Some(expected_inputs) = expected_inputs {
1530 expected_inputs.get(0).cloned().unwrap_or(adt_ty)
1534 // re-link the regions that EIfEO can erase.
1535 self.demand_eqtype(span, adt_ty_hint, adt_ty);
1537 let ty::Adt(adt, substs) = adt_ty.kind() else {
1538 span_bug!(span, "non-ADT passed to check_expr_struct_fields");
1540 let adt_kind = adt.adt_kind();
1542 let mut remaining_fields = variant
1546 .map(|(i, field)| (field.ident(tcx).normalize_to_macros_2_0(), (i, field)))
1547 .collect::<FxHashMap<_, _>>();
1549 let mut seen_fields = FxHashMap::default();
1551 let mut error_happened = false;
1553 // Type-check each field.
1554 for field in ast_fields {
1555 let ident = tcx.adjust_ident(field.ident, variant.def_id);
1556 let field_type = if let Some((i, v_field)) = remaining_fields.remove(&ident) {
1557 seen_fields.insert(ident, field.span);
1558 self.write_field_index(field.hir_id, i);
1560 // We don't look at stability attributes on
1561 // struct-like enums (yet...), but it's definitely not
1562 // a bug to have constructed one.
1563 if adt_kind != AdtKind::Enum {
1564 tcx.check_stability(v_field.did, Some(expr_id), field.span, None);
1567 self.field_ty(field.span, v_field, substs)
1569 error_happened = true;
1570 if let Some(prev_span) = seen_fields.get(&ident) {
1571 tcx.sess.emit_err(FieldMultiplySpecifiedInInitializer {
1572 span: field.ident.span,
1573 prev_span: *prev_span,
1577 self.report_unknown_field(
1582 adt.variant_descr(),
1590 // Make sure to give a type to the field even if there's
1591 // an error, so we can continue type-checking.
1592 self.check_expr_coercable_to_type(&field.expr, field_type, None);
1595 // Make sure the programmer specified correct number of fields.
1596 if adt_kind == AdtKind::Union {
1597 if ast_fields.len() != 1 {
1602 "union expressions should have exactly one field",
1608 // If check_expr_struct_fields hit an error, do not attempt to populate
1609 // the fields with the base_expr. This could cause us to hit errors later
1610 // when certain fields are assumed to exist that in fact do not.
1615 if let Some(base_expr) = base_expr {
1616 // FIXME: We are currently creating two branches here in order to maintain
1617 // consistency. But they should be merged as much as possible.
1618 let fru_tys = if self.tcx.features().type_changing_struct_update {
1619 if adt.is_struct() {
1620 // Make some fresh substitutions for our ADT type.
1621 let fresh_substs = self.fresh_substs_for_item(base_expr.span, adt.did());
1622 // We do subtyping on the FRU fields first, so we can
1623 // learn exactly what types we expect the base expr
1624 // needs constrained to be compatible with the struct
1625 // type we expect from the expectation value.
1626 let fru_tys = variant
1630 let fru_ty = self.normalize_associated_types_in(
1632 self.field_ty(base_expr.span, f, fresh_substs),
1634 let ident = self.tcx.adjust_ident(f.ident(self.tcx), variant.def_id);
1635 if let Some(_) = remaining_fields.remove(&ident) {
1636 let target_ty = self.field_ty(base_expr.span, f, substs);
1637 let cause = self.misc(base_expr.span);
1638 match self.at(&cause, self.param_env).sup(target_ty, fru_ty) {
1639 Ok(InferOk { obligations, value: () }) => {
1640 self.register_predicates(obligations)
1643 // This should never happen, since we're just subtyping the
1644 // remaining_fields, but it's fine to emit this, I guess.
1645 self.report_mismatched_types(
1649 FieldMisMatch(variant.name, ident.name),
1655 self.resolve_vars_if_possible(fru_ty)
1658 // The use of fresh substs that we have subtyped against
1659 // our base ADT type's fields allows us to guide inference
1660 // along so that, e.g.
1662 // MyStruct<'a, F1, F2, const C: usize> {
1664 // // Other fields that reference `'a`, `F2`, and `C`
1667 // let x = MyStruct {
1672 // will have the `other_struct` expression constrained to
1673 // `MyStruct<'a, _, F2, C>`, as opposed to just `_`...
1674 // This is important to allow coercions to happen in
1675 // `other_struct` itself. See `coerce-in-base-expr.rs`.
1676 let fresh_base_ty = self.tcx.mk_adt(*adt, fresh_substs);
1677 self.check_expr_has_type_or_error(
1679 self.resolve_vars_if_possible(fresh_base_ty),
1684 // Check the base_expr, regardless of a bad expected adt_ty, so we can get
1685 // type errors on that expression, too.
1686 self.check_expr(base_expr);
1689 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1693 self.check_expr_has_type_or_error(base_expr, adt_ty, |_| {
1694 let base_ty = self.typeck_results.borrow().expr_ty(*base_expr);
1695 let same_adt = match (adt_ty.kind(), base_ty.kind()) {
1696 (ty::Adt(adt, _), ty::Adt(base_adt, _)) if adt == base_adt => true,
1699 if self.tcx.sess.is_nightly_build() && same_adt {
1701 &self.tcx.sess.parse_sess,
1702 sym::type_changing_struct_update,
1704 "type changing struct updating is experimental",
1709 match adt_ty.kind() {
1710 ty::Adt(adt, substs) if adt.is_struct() => variant
1714 self.normalize_associated_types_in(expr_span, f.ty(self.tcx, substs))
1720 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1725 self.typeck_results.borrow_mut().fru_field_types_mut().insert(expr_id, fru_tys);
1726 } else if adt_kind != AdtKind::Union && !remaining_fields.is_empty() {
1727 debug!(?remaining_fields);
1728 let private_fields: Vec<&ty::FieldDef> = variant
1732 !field.vis.is_accessible_from(tcx.parent_module(expr_id).to_def_id(), tcx)
1736 if !private_fields.is_empty() {
1737 self.report_private_fields(adt_ty, span, private_fields, ast_fields);
1739 self.report_missing_fields(
1751 fn check_struct_fields_on_error(
1753 fields: &'tcx [hir::ExprField<'tcx>],
1754 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1756 for field in fields {
1757 self.check_expr(&field.expr);
1759 if let Some(base) = *base_expr {
1760 self.check_expr(&base);
1764 /// Report an error for a struct field expression when there are fields which aren't provided.
1767 /// error: missing field `you_can_use_this_field` in initializer of `foo::Foo`
1768 /// --> src/main.rs:8:5
1770 /// 8 | foo::Foo {};
1771 /// | ^^^^^^^^ missing `you_can_use_this_field`
1773 /// error: aborting due to previous error
1775 fn report_missing_fields(
1779 remaining_fields: FxHashMap<Ident, (usize, &ty::FieldDef)>,
1780 variant: &'tcx ty::VariantDef,
1781 ast_fields: &'tcx [hir::ExprField<'tcx>],
1782 substs: SubstsRef<'tcx>,
1784 let len = remaining_fields.len();
1786 let mut displayable_field_names: Vec<&str> =
1787 remaining_fields.keys().map(|ident| ident.as_str()).collect();
1788 // sorting &str primitives here, sort_unstable is ok
1789 displayable_field_names.sort_unstable();
1791 let mut truncated_fields_error = String::new();
1792 let remaining_fields_names = match &displayable_field_names[..] {
1793 [field1] => format!("`{}`", field1),
1794 [field1, field2] => format!("`{field1}` and `{field2}`"),
1795 [field1, field2, field3] => format!("`{field1}`, `{field2}` and `{field3}`"),
1797 truncated_fields_error =
1798 format!(" and {} other field{}", len - 3, pluralize!(len - 3));
1799 displayable_field_names
1802 .map(|n| format!("`{n}`"))
1803 .collect::<Vec<_>>()
1808 let mut err = struct_span_err!(
1812 "missing field{} {}{} in initializer of `{}`",
1814 remaining_fields_names,
1815 truncated_fields_error,
1818 err.span_label(span, format!("missing {remaining_fields_names}{truncated_fields_error}"));
1820 // If the last field is a range literal, but it isn't supposed to be, then they probably
1821 // meant to use functional update syntax.
1823 // I don't use 'is_range_literal' because only double-sided, half-open ranges count.
1827 QPath::LangItem(LangItem::Range, ..),
1828 &[ref range_start, ref range_end],
1831 )) = ast_fields.last().map(|last| (last, &last.expr.kind)) &&
1833 variant.fields.iter().find(|field| field.ident(self.tcx) == last.ident) &&
1834 let range_def_id = self.tcx.lang_items().range_struct() &&
1836 .and_then(|field| field.ty(self.tcx, substs).ty_adt_def())
1837 .map(|adt| adt.did())
1844 .span_to_snippet(range_end.expr.span)
1845 .map(|s| format!(" from `{s}`"))
1846 .unwrap_or_default();
1847 err.span_suggestion(
1848 range_start.span.shrink_to_hi(),
1849 &format!("to set the remaining fields{instead}, separate the last named field with a comma"),
1851 Applicability::MaybeIncorrect,
1858 /// Report an error for a struct field expression when there are invisible fields.
1861 /// error: cannot construct `Foo` with struct literal syntax due to private fields
1862 /// --> src/main.rs:8:5
1864 /// 8 | foo::Foo {};
1867 /// error: aborting due to previous error
1869 fn report_private_fields(
1873 private_fields: Vec<&ty::FieldDef>,
1874 used_fields: &'tcx [hir::ExprField<'tcx>],
1876 let mut err = self.tcx.sess.struct_span_err(
1879 "cannot construct `{adt_ty}` with struct literal syntax due to private fields",
1882 let (used_private_fields, remaining_private_fields): (
1883 Vec<(Symbol, Span, bool)>,
1884 Vec<(Symbol, Span, bool)>,
1888 match used_fields.iter().find(|used_field| field.name == used_field.ident.name) {
1889 Some(used_field) => (field.name, used_field.span, true),
1890 None => (field.name, self.tcx.def_span(field.did), false),
1893 .partition(|field| field.2);
1894 err.span_labels(used_private_fields.iter().map(|(_, span, _)| *span), "private field");
1895 if !remaining_private_fields.is_empty() {
1896 let remaining_private_fields_len = remaining_private_fields.len();
1897 let names = match &remaining_private_fields
1899 .map(|(name, _, _)| name)
1900 .collect::<Vec<_>>()[..]
1902 _ if remaining_private_fields_len > 6 => String::new(),
1903 [name] => format!("`{name}` "),
1904 [names @ .., last] => {
1905 let names = names.iter().map(|name| format!("`{name}`")).collect::<Vec<_>>();
1906 format!("{} and `{last}` ", names.join(", "))
1908 [] => unreachable!(),
1911 "... and other private field{s} {names}that {were} not provided",
1912 s = pluralize!(remaining_private_fields_len),
1913 were = pluralize!("was", remaining_private_fields_len),
1919 fn report_unknown_field(
1922 variant: &'tcx ty::VariantDef,
1923 field: &hir::ExprField<'_>,
1924 skip_fields: &[hir::ExprField<'_>],
1928 if variant.is_recovered() {
1929 self.set_tainted_by_errors();
1932 let mut err = self.type_error_struct_with_diag(
1934 |actual| match ty.kind() {
1935 ty::Adt(adt, ..) if adt.is_enum() => struct_span_err!(
1939 "{} `{}::{}` has no field named `{}`",
1945 _ => struct_span_err!(
1949 "{} `{}` has no field named `{}`",
1958 let variant_ident_span = self.tcx.def_ident_span(variant.def_id).unwrap();
1959 match variant.ctor_kind {
1960 CtorKind::Fn => match ty.kind() {
1961 ty::Adt(adt, ..) if adt.is_enum() => {
1965 "`{adt}::{variant}` defined here",
1967 variant = variant.name,
1970 err.span_label(field.ident.span, "field does not exist");
1971 err.span_suggestion_verbose(
1974 "`{adt}::{variant}` is a tuple {kind_name}, use the appropriate syntax",
1976 variant = variant.name,
1979 "{adt}::{variant}(/* fields */)",
1981 variant = variant.name,
1983 Applicability::HasPlaceholders,
1987 err.span_label(variant_ident_span, format!("`{adt}` defined here", adt = ty));
1988 err.span_label(field.ident.span, "field does not exist");
1989 err.span_suggestion_verbose(
1992 "`{adt}` is a tuple {kind_name}, use the appropriate syntax",
1994 kind_name = kind_name,
1996 format!("{adt}(/* fields */)", adt = ty),
1997 Applicability::HasPlaceholders,
2002 // prevent all specified fields from being suggested
2003 let skip_fields = skip_fields.iter().map(|x| x.ident.name);
2004 if let Some(field_name) = self.suggest_field_name(
2007 skip_fields.collect(),
2010 err.span_suggestion(
2012 "a field with a similar name exists",
2014 Applicability::MaybeIncorrect,
2018 ty::Adt(adt, ..) => {
2022 format!("`{}::{}` does not have this field", ty, variant.name),
2027 format!("`{ty}` does not have this field"),
2030 let available_field_names =
2031 self.available_field_names(variant, expr_span);
2032 if !available_field_names.is_empty() {
2034 "available fields are: {}",
2035 self.name_series_display(available_field_names)
2039 _ => bug!("non-ADT passed to report_unknown_field"),
2047 // Return a hint about the closest match in field names
2048 fn suggest_field_name(
2050 variant: &'tcx ty::VariantDef,
2053 // The span where stability will be checked
2055 ) -> Option<Symbol> {
2059 .filter_map(|field| {
2060 // ignore already set fields and private fields from non-local crates
2061 // and unstable fields.
2062 if skip.iter().any(|&x| x == field.name)
2063 || (!variant.def_id.is_local() && !field.vis.is_public())
2065 self.tcx.eval_stability(field.did, None, span, None),
2066 stability::EvalResult::Deny { .. }
2074 .collect::<Vec<Symbol>>();
2076 find_best_match_for_name(&names, field, None)
2079 fn available_field_names(
2081 variant: &'tcx ty::VariantDef,
2088 let def_scope = self
2090 .adjust_ident_and_get_scope(field.ident(self.tcx), variant.def_id, self.body_id)
2092 field.vis.is_accessible_from(def_scope, self.tcx)
2094 self.tcx.eval_stability(field.did, None, access_span, None),
2095 stability::EvalResult::Deny { .. }
2098 .filter(|field| !self.tcx.is_doc_hidden(field.did))
2099 .map(|field| field.name)
2103 fn name_series_display(&self, names: Vec<Symbol>) -> String {
2104 // dynamic limit, to never omit just one field
2105 let limit = if names.len() == 6 { 6 } else { 5 };
2107 names.iter().take(limit).map(|n| format!("`{}`", n)).collect::<Vec<_>>().join(", ");
2108 if names.len() > limit {
2109 display = format!("{} ... and {} others", display, names.len() - limit);
2114 // Check field access expressions
2117 expr: &'tcx hir::Expr<'tcx>,
2118 base: &'tcx hir::Expr<'tcx>,
2121 debug!("check_field(expr: {:?}, base: {:?}, field: {:?})", expr, base, field);
2122 let expr_t = self.check_expr(base);
2123 let expr_t = self.structurally_resolved_type(base.span, expr_t);
2124 let mut private_candidate = None;
2125 let mut autoderef = self.autoderef(expr.span, expr_t);
2126 while let Some((base_t, _)) = autoderef.next() {
2127 debug!("base_t: {:?}", base_t);
2128 match base_t.kind() {
2129 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2130 debug!("struct named {:?}", base_t);
2131 let (ident, def_scope) =
2132 self.tcx.adjust_ident_and_get_scope(field, base_def.did(), self.body_id);
2133 let fields = &base_def.non_enum_variant().fields;
2134 if let Some(index) = fields
2136 .position(|f| f.ident(self.tcx).normalize_to_macros_2_0() == ident)
2138 let field = &fields[index];
2139 let field_ty = self.field_ty(expr.span, field, substs);
2140 // Save the index of all fields regardless of their visibility in case
2141 // of error recovery.
2142 self.write_field_index(expr.hir_id, index);
2143 let adjustments = self.adjust_steps(&autoderef);
2144 if field.vis.is_accessible_from(def_scope, self.tcx) {
2145 self.apply_adjustments(base, adjustments);
2146 self.register_predicates(autoderef.into_obligations());
2148 self.tcx.check_stability(field.did, Some(expr.hir_id), expr.span, None);
2151 private_candidate = Some((adjustments, base_def.did(), field_ty));
2155 let fstr = field.as_str();
2156 if let Ok(index) = fstr.parse::<usize>() {
2157 if fstr == index.to_string() {
2158 if let Some(&field_ty) = tys.get(index) {
2159 let adjustments = self.adjust_steps(&autoderef);
2160 self.apply_adjustments(base, adjustments);
2161 self.register_predicates(autoderef.into_obligations());
2163 self.write_field_index(expr.hir_id, index);
2172 self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
2174 if let Some((adjustments, did, field_ty)) = private_candidate {
2175 // (#90483) apply adjustments to avoid ExprUseVisitor from
2176 // creating erroneous projection.
2177 self.apply_adjustments(base, adjustments);
2178 self.ban_private_field_access(expr, expr_t, field, did);
2182 if field.name == kw::Empty {
2183 } else if self.method_exists(field, expr_t, expr.hir_id, true) {
2184 self.ban_take_value_of_method(expr, expr_t, field);
2185 } else if !expr_t.is_primitive_ty() {
2186 self.ban_nonexisting_field(field, base, expr, expr_t);
2188 let field_name = field.to_string();
2189 let mut err = type_error_struct!(
2194 "`{expr_t}` is a primitive type and therefore doesn't have fields",
2196 let is_valid_suffix = |field: String| {
2197 if field == "f32" || field == "f64" {
2200 let mut chars = field.chars().peekable();
2201 match chars.peek() {
2202 Some('e') | Some('E') => {
2204 if let Some(c) = chars.peek()
2205 && !c.is_numeric() && *c != '-' && *c != '+'
2209 while let Some(c) = chars.peek() {
2210 if !c.is_numeric() {
2218 let suffix = chars.collect::<String>();
2219 suffix.is_empty() || suffix == "f32" || suffix == "f64"
2221 if let ty::Infer(ty::IntVar(_)) = expr_t.kind()
2222 && let ExprKind::Lit(Spanned {
2223 node: ast::LitKind::Int(_, ast::LitIntType::Unsuffixed),
2226 && !base.span.from_expansion()
2227 && is_valid_suffix(field_name)
2229 err.span_suggestion_verbose(
2230 field.span.shrink_to_lo(),
2231 "If the number is meant to be a floating point number, consider adding a `0` after the period",
2233 Applicability::MaybeIncorrect,
2239 self.tcx().ty_error()
2242 fn check_call_constructor(
2244 err: &mut Diagnostic,
2245 base: &'tcx hir::Expr<'tcx>,
2248 if let Some(local_id) = def_id.as_local() {
2249 let hir_id = self.tcx.hir().local_def_id_to_hir_id(local_id);
2250 let node = self.tcx.hir().get(hir_id);
2252 if let Some(fields) = node.tuple_fields() {
2253 let kind = match self.tcx.opt_def_kind(local_id) {
2254 Some(DefKind::Ctor(of, _)) => of,
2258 suggest_call_constructor(base.span, kind, fields.len(), err);
2261 // The logic here isn't smart but `associated_item_def_ids`
2262 // doesn't work nicely on local.
2263 if let DefKind::Ctor(of, _) = self.tcx.def_kind(def_id) {
2264 let parent_def_id = self.tcx.parent(def_id);
2265 let fields = self.tcx.associated_item_def_ids(parent_def_id);
2266 suggest_call_constructor(base.span, of, fields.len(), err);
2271 fn suggest_await_on_field_access(
2273 err: &mut Diagnostic,
2275 base: &'tcx hir::Expr<'tcx>,
2278 let output_ty = match self.get_impl_future_output_ty(ty) {
2279 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
2282 let mut add_label = true;
2283 if let ty::Adt(def, _) = output_ty.skip_binder().kind() {
2284 // no field access on enum type
2290 .any(|field| field.ident(self.tcx) == field_ident)
2295 "field not available in `impl Future`, but it is available in its `Output`",
2297 err.span_suggestion_verbose(
2298 base.span.shrink_to_hi(),
2299 "consider `await`ing on the `Future` and access the field of its `Output`",
2301 Applicability::MaybeIncorrect,
2307 err.span_label(field_ident.span, &format!("field not found in `{ty}`"));
2311 fn ban_nonexisting_field(
2314 base: &'tcx hir::Expr<'tcx>,
2315 expr: &'tcx hir::Expr<'tcx>,
2319 "ban_nonexisting_field: field={:?}, base={:?}, expr={:?}, expr_ty={:?}",
2320 field, base, expr, expr_t
2322 let mut err = self.no_such_field_err(field, expr_t, base.hir_id);
2324 match *expr_t.peel_refs().kind() {
2325 ty::Array(_, len) => {
2326 self.maybe_suggest_array_indexing(&mut err, expr, base, field, len);
2329 self.suggest_first_deref_field(&mut err, expr, base, field);
2331 ty::Adt(def, _) if !def.is_enum() => {
2332 self.suggest_fields_on_recordish(&mut err, def, field, expr.span);
2334 ty::Param(param_ty) => {
2335 self.point_at_param_definition(&mut err, param_ty);
2337 ty::Opaque(_, _) => {
2338 self.suggest_await_on_field_access(&mut err, field, base, expr_t.peel_refs());
2340 ty::FnDef(def_id, _) => {
2341 self.check_call_constructor(&mut err, base, def_id);
2346 if field.name == kw::Await {
2347 // We know by construction that `<expr>.await` is either on Rust 2015
2348 // or results in `ExprKind::Await`. Suggest switching the edition to 2018.
2349 err.note("to `.await` a `Future`, switch to Rust 2018 or later");
2350 err.help_use_latest_edition();
2356 fn ban_private_field_access(
2358 expr: &hir::Expr<'_>,
2363 let struct_path = self.tcx().def_path_str(base_did);
2364 let kind_name = self.tcx().def_kind(base_did).descr(base_did);
2365 let mut err = struct_span_err!(
2369 "field `{field}` of {kind_name} `{struct_path}` is private",
2371 err.span_label(field.span, "private field");
2372 // Also check if an accessible method exists, which is often what is meant.
2373 if self.method_exists(field, expr_t, expr.hir_id, false) && !self.expr_in_place(expr.hir_id)
2375 self.suggest_method_call(
2377 &format!("a method `{field}` also exists, call it with parentheses"),
2387 fn ban_take_value_of_method(&self, expr: &hir::Expr<'_>, expr_t: Ty<'tcx>, field: Ident) {
2388 let mut err = type_error_struct!(
2393 "attempted to take value of method `{field}` on type `{expr_t}`",
2395 err.span_label(field.span, "method, not a field");
2397 if let hir::Node::Expr(hir::Expr { kind: ExprKind::Call(callee, _args), .. }) =
2398 self.tcx.hir().get(self.tcx.hir().get_parent_node(expr.hir_id))
2400 expr.hir_id == callee.hir_id
2405 self.tcx.sess.source_map().span_to_snippet(expr.span).unwrap_or_default();
2406 let is_wrapped = expr_snippet.starts_with('(') && expr_snippet.ends_with(')');
2407 let after_open = expr.span.lo() + rustc_span::BytePos(1);
2408 let before_close = expr.span.hi() - rustc_span::BytePos(1);
2410 if expr_is_call && is_wrapped {
2411 err.multipart_suggestion(
2412 "remove wrapping parentheses to call the method",
2414 (expr.span.with_hi(after_open), String::new()),
2415 (expr.span.with_lo(before_close), String::new()),
2417 Applicability::MachineApplicable,
2419 } else if !self.expr_in_place(expr.hir_id) {
2420 // Suggest call parentheses inside the wrapping parentheses
2421 let span = if is_wrapped {
2422 expr.span.with_lo(after_open).with_hi(before_close)
2426 self.suggest_method_call(
2428 "use parentheses to call the method",
2434 } else if let ty::RawPtr(ty_and_mut) = expr_t.kind()
2435 && let ty::Adt(adt_def, _) = ty_and_mut.ty.kind()
2436 && let ExprKind::Field(base_expr, _) = expr.kind
2437 && adt_def.variants().len() == 1
2445 .any(|f| f.ident(self.tcx) == field)
2447 err.multipart_suggestion(
2448 "to access the field, dereference first",
2450 (base_expr.span.shrink_to_lo(), "(*".to_string()),
2451 (base_expr.span.shrink_to_hi(), ")".to_string()),
2453 Applicability::MaybeIncorrect,
2456 err.help("methods are immutable and cannot be assigned to");
2462 fn point_at_param_definition(&self, err: &mut Diagnostic, param: ty::ParamTy) {
2463 let generics = self.tcx.generics_of(self.body_id.owner.to_def_id());
2464 let generic_param = generics.type_param(¶m, self.tcx);
2465 if let ty::GenericParamDefKind::Type { synthetic: true, .. } = generic_param.kind {
2468 let param_def_id = generic_param.def_id;
2469 let param_hir_id = match param_def_id.as_local() {
2470 Some(x) => self.tcx.hir().local_def_id_to_hir_id(x),
2473 let param_span = self.tcx.hir().span(param_hir_id);
2474 let param_name = self.tcx.hir().ty_param_name(param_def_id.expect_local());
2476 err.span_label(param_span, &format!("type parameter '{param_name}' declared here"));
2479 fn suggest_fields_on_recordish(
2481 err: &mut Diagnostic,
2482 def: ty::AdtDef<'tcx>,
2486 if let Some(suggested_field_name) =
2487 self.suggest_field_name(def.non_enum_variant(), field.name, vec![], access_span)
2489 err.span_suggestion(
2491 "a field with a similar name exists",
2492 suggested_field_name,
2493 Applicability::MaybeIncorrect,
2496 err.span_label(field.span, "unknown field");
2497 let struct_variant_def = def.non_enum_variant();
2498 let field_names = self.available_field_names(struct_variant_def, access_span);
2499 if !field_names.is_empty() {
2501 "available fields are: {}",
2502 self.name_series_display(field_names),
2508 fn maybe_suggest_array_indexing(
2510 err: &mut Diagnostic,
2511 expr: &hir::Expr<'_>,
2512 base: &hir::Expr<'_>,
2514 len: ty::Const<'tcx>,
2516 if let (Some(len), Ok(user_index)) =
2517 (len.try_eval_usize(self.tcx, self.param_env), field.as_str().parse::<u64>())
2518 && let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
2520 let help = "instead of using tuple indexing, use array indexing";
2521 let suggestion = format!("{base}[{field}]");
2522 let applicability = if len < user_index {
2523 Applicability::MachineApplicable
2525 Applicability::MaybeIncorrect
2527 err.span_suggestion(expr.span, help, suggestion, applicability);
2531 fn suggest_first_deref_field(
2533 err: &mut Diagnostic,
2534 expr: &hir::Expr<'_>,
2535 base: &hir::Expr<'_>,
2538 if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span) {
2539 let msg = format!("`{base}` is a raw pointer; try dereferencing it");
2540 let suggestion = format!("(*{base}).{field}");
2541 err.span_suggestion(expr.span, &msg, suggestion, Applicability::MaybeIncorrect);
2545 fn no_such_field_err(
2550 ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
2551 let span = field.span;
2552 debug!("no_such_field_err(span: {:?}, field: {:?}, expr_t: {:?})", span, field, expr_t);
2554 let mut err = type_error_struct!(
2559 "no field `{field}` on type `{expr_t}`",
2562 // try to add a suggestion in case the field is a nested field of a field of the Adt
2563 let mod_id = self.tcx.parent_module(id).to_def_id();
2564 if let Some((fields, substs)) =
2565 self.get_field_candidates_considering_privacy(span, expr_t, mod_id)
2567 for candidate_field in fields {
2568 if let Some(mut field_path) = self.check_for_nested_field_satisfying(
2570 &|candidate_field, _| candidate_field.ident(self.tcx()) == field,
2576 // field_path includes `field` that we're looking for, so pop it.
2579 let field_path_str = field_path
2581 .map(|id| id.name.to_ident_string())
2582 .collect::<Vec<String>>()
2584 debug!("field_path_str: {:?}", field_path_str);
2586 err.span_suggestion_verbose(
2587 field.span.shrink_to_lo(),
2588 "one of the expressions' fields has a field of the same name",
2589 format!("{field_path_str}."),
2590 Applicability::MaybeIncorrect,
2598 pub(crate) fn get_field_candidates_considering_privacy(
2603 ) -> Option<(impl Iterator<Item = &'tcx ty::FieldDef> + 'tcx, SubstsRef<'tcx>)> {
2604 debug!("get_field_candidates(span: {:?}, base_t: {:?}", span, base_ty);
2606 for (base_t, _) in self.autoderef(span, base_ty) {
2607 match base_t.kind() {
2608 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2610 let fields = &base_def.non_enum_variant().fields;
2611 // Some struct, e.g. some that impl `Deref`, have all private fields
2612 // because you're expected to deref them to access the _real_ fields.
2613 // This, for example, will help us suggest accessing a field through a `Box<T>`.
2614 if fields.iter().all(|field| !field.vis.is_accessible_from(mod_id, tcx)) {
2620 .filter(move |field| field.vis.is_accessible_from(mod_id, tcx))
2621 // For compile-time reasons put a limit on number of fields we search
2632 /// This method is called after we have encountered a missing field error to recursively
2633 /// search for the field
2634 pub(crate) fn check_for_nested_field_satisfying(
2637 matches: &impl Fn(&ty::FieldDef, Ty<'tcx>) -> bool,
2638 candidate_field: &ty::FieldDef,
2639 subst: SubstsRef<'tcx>,
2640 mut field_path: Vec<Ident>,
2642 ) -> Option<Vec<Ident>> {
2644 "check_for_nested_field_satisfying(span: {:?}, candidate_field: {:?}, field_path: {:?}",
2645 span, candidate_field, field_path
2648 if field_path.len() > 3 {
2649 // For compile-time reasons and to avoid infinite recursion we only check for fields
2650 // up to a depth of three
2653 field_path.push(candidate_field.ident(self.tcx).normalize_to_macros_2_0());
2654 let field_ty = candidate_field.ty(self.tcx, subst);
2655 if matches(candidate_field, field_ty) {
2656 return Some(field_path);
2657 } else if let Some((nested_fields, subst)) =
2658 self.get_field_candidates_considering_privacy(span, field_ty, mod_id)
2660 // recursively search fields of `candidate_field` if it's a ty::Adt
2661 for field in nested_fields {
2662 if let Some(field_path) = self.check_for_nested_field_satisfying(
2670 return Some(field_path);
2678 fn check_expr_index(
2680 base: &'tcx hir::Expr<'tcx>,
2681 idx: &'tcx hir::Expr<'tcx>,
2682 expr: &'tcx hir::Expr<'tcx>,
2684 let base_t = self.check_expr(&base);
2685 let idx_t = self.check_expr(&idx);
2687 if base_t.references_error() {
2689 } else if idx_t.references_error() {
2692 let base_t = self.structurally_resolved_type(base.span, base_t);
2693 match self.lookup_indexing(expr, base, base_t, idx, idx_t) {
2694 Some((index_ty, element_ty)) => {
2695 // two-phase not needed because index_ty is never mutable
2696 self.demand_coerce(idx, idx_t, index_ty, None, AllowTwoPhase::No);
2697 self.select_obligations_where_possible(false, |errors| {
2698 self.point_at_index_if_possible(errors, idx.span)
2703 let mut err = type_error_struct!(
2708 "cannot index into a value of type `{base_t}`",
2710 // Try to give some advice about indexing tuples.
2711 if let ty::Tuple(..) = base_t.kind() {
2712 let mut needs_note = true;
2713 // If the index is an integer, we can show the actual
2714 // fixed expression:
2715 if let ExprKind::Lit(ref lit) = idx.kind {
2716 if let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node {
2717 let snip = self.tcx.sess.source_map().span_to_snippet(base.span);
2718 if let Ok(snip) = snip {
2719 err.span_suggestion(
2721 "to access tuple elements, use",
2722 format!("{snip}.{i}"),
2723 Applicability::MachineApplicable,
2731 "to access tuple elements, use tuple indexing \
2732 syntax (e.g., `tuple.0`)",
2743 fn point_at_index_if_possible(
2745 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
2748 for error in errors {
2749 match error.obligation.predicate.kind().skip_binder() {
2750 ty::PredicateKind::Trait(predicate)
2751 if self.tcx.is_diagnostic_item(sym::SliceIndex, predicate.trait_ref.def_id) => {
2755 error.obligation.cause.span = span;
2759 fn check_expr_yield(
2761 value: &'tcx hir::Expr<'tcx>,
2762 expr: &'tcx hir::Expr<'tcx>,
2763 src: &'tcx hir::YieldSource,
2765 match self.resume_yield_tys {
2766 Some((resume_ty, yield_ty)) => {
2767 self.check_expr_coercable_to_type(&value, yield_ty, None);
2771 // Given that this `yield` expression was generated as a result of lowering a `.await`,
2772 // we know that the yield type must be `()`; however, the context won't contain this
2773 // information. Hence, we check the source of the yield expression here and check its
2774 // value's type against `()` (this check should always hold).
2775 None if src.is_await() => {
2776 self.check_expr_coercable_to_type(&value, self.tcx.mk_unit(), None);
2780 self.tcx.sess.emit_err(YieldExprOutsideOfGenerator { span: expr.span });
2781 // Avoid expressions without types during writeback (#78653).
2782 self.check_expr(value);
2788 fn check_expr_asm_operand(&self, expr: &'tcx hir::Expr<'tcx>, is_input: bool) {
2789 let needs = if is_input { Needs::None } else { Needs::MutPlace };
2790 let ty = self.check_expr_with_needs(expr, needs);
2791 self.require_type_is_sized(ty, expr.span, traits::InlineAsmSized);
2793 if !is_input && !expr.is_syntactic_place_expr() {
2794 let mut err = self.tcx.sess.struct_span_err(expr.span, "invalid asm output");
2795 err.span_label(expr.span, "cannot assign to this expression");
2799 // If this is an input value, we require its type to be fully resolved
2800 // at this point. This allows us to provide helpful coercions which help
2801 // pass the type candidate list in a later pass.
2803 // We don't require output types to be resolved at this point, which
2804 // allows them to be inferred based on how they are used later in the
2807 let ty = self.structurally_resolved_type(expr.span, ty);
2810 let fnptr_ty = self.tcx.mk_fn_ptr(ty.fn_sig(self.tcx));
2811 self.demand_coerce(expr, ty, fnptr_ty, None, AllowTwoPhase::No);
2813 ty::Ref(_, base_ty, mutbl) => {
2814 let ptr_ty = self.tcx.mk_ptr(ty::TypeAndMut { ty: base_ty, mutbl });
2815 self.demand_coerce(expr, ty, ptr_ty, None, AllowTwoPhase::No);
2822 fn check_expr_asm(&self, asm: &'tcx hir::InlineAsm<'tcx>) -> Ty<'tcx> {
2823 for (op, _op_sp) in asm.operands {
2825 hir::InlineAsmOperand::In { expr, .. } => {
2826 self.check_expr_asm_operand(expr, true);
2828 hir::InlineAsmOperand::Out { expr: Some(expr), .. }
2829 | hir::InlineAsmOperand::InOut { expr, .. } => {
2830 self.check_expr_asm_operand(expr, false);
2832 hir::InlineAsmOperand::Out { expr: None, .. } => {}
2833 hir::InlineAsmOperand::SplitInOut { in_expr, out_expr, .. } => {
2834 self.check_expr_asm_operand(in_expr, true);
2835 if let Some(out_expr) = out_expr {
2836 self.check_expr_asm_operand(out_expr, false);
2839 // `AnonConst`s have their own body and is type-checked separately.
2840 // As they don't flow into the type system we don't need them to
2842 hir::InlineAsmOperand::Const { .. } | hir::InlineAsmOperand::SymFn { .. } => {}
2843 hir::InlineAsmOperand::SymStatic { .. } => {}
2846 if asm.options.contains(ast::InlineAsmOptions::NORETURN) {
2847 self.tcx.types.never
2854 pub(super) fn ty_kind_suggestion(ty: Ty<'_>) -> Option<&'static str> {
2855 Some(match ty.kind() {
2858 ty::Int(_) | ty::Uint(_) => "42",
2859 ty::Float(_) => "3.14159",
2860 ty::Error(_) | ty::Never => return None,