1 //! Type checking expressions.
3 //! See `mod.rs` for more context on type checking in general.
5 use crate::astconv::AstConv as _;
6 use crate::check::cast;
7 use crate::check::coercion::CoerceMany;
8 use crate::check::fatally_break_rust;
9 use crate::check::method::SelfSource;
10 use crate::check::report_unexpected_variant_res;
11 use crate::check::BreakableCtxt;
12 use crate::check::Diverges;
13 use crate::check::DynamicCoerceMany;
14 use crate::check::Expectation::{self, ExpectCastableToType, ExpectHasType, NoExpectation};
15 use crate::check::FnCtxt;
16 use crate::check::Needs;
17 use crate::check::TupleArgumentsFlag::DontTupleArguments;
19 FieldMultiplySpecifiedInInitializer, FunctionalRecordUpdateOnNonStruct,
20 YieldExprOutsideOfGenerator,
22 use crate::type_error_struct;
24 use crate::errors::{AddressOfTemporaryTaken, ReturnStmtOutsideOfFnBody, StructExprNonExhaustive};
26 use rustc_data_structures::fx::FxHashMap;
27 use rustc_data_structures::stack::ensure_sufficient_stack;
29 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, DiagnosticId,
30 ErrorGuaranteed, StashKey,
33 use rustc_hir::def::{CtorKind, DefKind, Res};
34 use rustc_hir::def_id::DefId;
35 use rustc_hir::intravisit::Visitor;
36 use rustc_hir::lang_items::LangItem;
37 use rustc_hir::{Closure, ExprKind, HirId, QPath};
38 use rustc_infer::infer;
39 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
40 use rustc_infer::infer::InferOk;
41 use rustc_infer::traits::ObligationCause;
42 use rustc_middle::middle::stability;
43 use rustc_middle::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase};
44 use rustc_middle::ty::error::TypeError::FieldMisMatch;
45 use rustc_middle::ty::subst::SubstsRef;
46 use rustc_middle::ty::{self, AdtKind, Ty, TypeVisitable};
47 use rustc_session::parse::feature_err;
48 use rustc_span::hygiene::DesugaringKind;
49 use rustc_span::lev_distance::find_best_match_for_name;
50 use rustc_span::source_map::{Span, Spanned};
51 use rustc_span::symbol::{kw, sym, Ident, Symbol};
52 use rustc_target::spec::abi::Abi::RustIntrinsic;
53 use rustc_trait_selection::infer::InferCtxtExt;
54 use rustc_trait_selection::traits::{self, ObligationCauseCode};
56 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
57 fn check_expr_eq_type(&self, expr: &'tcx hir::Expr<'tcx>, expected: Ty<'tcx>) {
58 let ty = self.check_expr_with_hint(expr, expected);
59 self.demand_eqtype(expr.span, expected, ty);
62 pub fn check_expr_has_type_or_error(
64 expr: &'tcx hir::Expr<'tcx>,
66 extend_err: impl FnMut(&mut Diagnostic),
68 self.check_expr_meets_expectation_or_error(expr, ExpectHasType(expected), extend_err)
71 fn check_expr_meets_expectation_or_error(
73 expr: &'tcx hir::Expr<'tcx>,
74 expected: Expectation<'tcx>,
75 mut extend_err: impl FnMut(&mut Diagnostic),
77 let expected_ty = expected.to_option(&self).unwrap_or(self.tcx.types.bool);
78 let mut ty = self.check_expr_with_expectation(expr, expected);
80 // While we don't allow *arbitrary* coercions here, we *do* allow
81 // coercions from ! to `expected`.
83 if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
84 self.tcx().sess.delay_span_bug(
86 "expression with never type wound up being adjusted",
88 return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
95 let adj_ty = self.next_ty_var(TypeVariableOrigin {
96 kind: TypeVariableOriginKind::AdjustmentType,
99 self.apply_adjustments(
101 vec![Adjustment { kind: Adjust::NeverToAny, target: adj_ty }],
106 if let Some(mut err) = self.demand_suptype_diag(expr.span, expected_ty, ty) {
107 let expr = expr.peel_drop_temps();
108 self.suggest_deref_ref_or_into(&mut err, expr, expected_ty, ty, None);
109 extend_err(&mut err);
115 pub(super) fn check_expr_coercable_to_type(
117 expr: &'tcx hir::Expr<'tcx>,
119 expected_ty_expr: Option<&'tcx hir::Expr<'tcx>>,
121 let ty = self.check_expr_with_hint(expr, expected);
122 // checks don't need two phase
123 self.demand_coerce(expr, ty, expected, expected_ty_expr, AllowTwoPhase::No)
126 pub(super) fn check_expr_with_hint(
128 expr: &'tcx hir::Expr<'tcx>,
131 self.check_expr_with_expectation(expr, ExpectHasType(expected))
134 fn check_expr_with_expectation_and_needs(
136 expr: &'tcx hir::Expr<'tcx>,
137 expected: Expectation<'tcx>,
140 let ty = self.check_expr_with_expectation(expr, expected);
142 // If the expression is used in a place whether mutable place is required
143 // e.g. LHS of assignment, perform the conversion.
144 if let Needs::MutPlace = needs {
145 self.convert_place_derefs_to_mutable(expr);
151 pub(super) fn check_expr(&self, expr: &'tcx hir::Expr<'tcx>) -> Ty<'tcx> {
152 self.check_expr_with_expectation(expr, NoExpectation)
155 pub(super) fn check_expr_with_needs(
157 expr: &'tcx hir::Expr<'tcx>,
160 self.check_expr_with_expectation_and_needs(expr, NoExpectation, needs)
164 /// If an expression has any sub-expressions that result in a type error,
165 /// inspecting that expression's type with `ty.references_error()` will return
166 /// true. Likewise, if an expression is known to diverge, inspecting its
167 /// type with `ty::type_is_bot` will return true (n.b.: since Rust is
168 /// strict, _|_ can appear in the type of an expression that does not,
169 /// itself, diverge: for example, fn() -> _|_.)
170 /// Note that inspecting a type's structure *directly* may expose the fact
171 /// that there are actually multiple representations for `Error`, so avoid
172 /// that when err needs to be handled differently.
173 #[instrument(skip(self, expr), level = "debug")]
174 pub(super) fn check_expr_with_expectation(
176 expr: &'tcx hir::Expr<'tcx>,
177 expected: Expectation<'tcx>,
179 self.check_expr_with_expectation_and_args(expr, expected, &[])
182 /// Same as `check_expr_with_expectation`, but allows us to pass in the arguments of a
183 /// `ExprKind::Call` when evaluating its callee when it is an `ExprKind::Path`.
184 pub(super) fn check_expr_with_expectation_and_args(
186 expr: &'tcx hir::Expr<'tcx>,
187 expected: Expectation<'tcx>,
188 args: &'tcx [hir::Expr<'tcx>],
190 if self.tcx().sess.verbose() {
191 // make this code only run with -Zverbose because it is probably slow
192 if let Ok(lint_str) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
193 if !lint_str.contains('\n') {
194 debug!("expr text: {lint_str}");
196 let mut lines = lint_str.lines();
197 if let Some(line0) = lines.next() {
198 let remaining_lines = lines.count();
199 debug!("expr text: {line0}");
200 debug!("expr text: ...(and {remaining_lines} more lines)");
206 // True if `expr` is a `Try::from_ok(())` that is a result of desugaring a try block
207 // without the final expr (e.g. `try { return; }`). We don't want to generate an
208 // unreachable_code lint for it since warnings for autogenerated code are confusing.
209 let is_try_block_generated_unit_expr = match expr.kind {
210 ExprKind::Call(_, args) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {
211 args.len() == 1 && args[0].span.is_desugaring(DesugaringKind::TryBlock)
217 // Warn for expressions after diverging siblings.
218 if !is_try_block_generated_unit_expr {
219 self.warn_if_unreachable(expr.hir_id, expr.span, "expression");
222 // Hide the outer diverging and has_errors flags.
223 let old_diverges = self.diverges.replace(Diverges::Maybe);
224 let old_has_errors = self.has_errors.replace(false);
226 let ty = ensure_sufficient_stack(|| match &expr.kind {
228 qpath @ hir::QPath::Resolved(..) | qpath @ hir::QPath::TypeRelative(..),
229 ) => self.check_expr_path(qpath, expr, args),
230 _ => self.check_expr_kind(expr, expected),
233 // Warn for non-block expressions with diverging children.
239 | ExprKind::Match(..) => {}
240 // If `expr` is a result of desugaring the try block and is an ok-wrapped
241 // diverging expression (e.g. it arose from desugaring of `try { return }`),
242 // we skip issuing a warning because it is autogenerated code.
243 ExprKind::Call(..) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {}
244 ExprKind::Call(callee, _) => self.warn_if_unreachable(expr.hir_id, callee.span, "call"),
245 ExprKind::MethodCall(segment, ..) => {
246 self.warn_if_unreachable(expr.hir_id, segment.ident.span, "call")
248 _ => self.warn_if_unreachable(expr.hir_id, expr.span, "expression"),
251 // Any expression that produces a value of type `!` must have diverged
253 self.diverges.set(self.diverges.get() | Diverges::always(expr.span));
256 // Record the type, which applies it effects.
257 // We need to do this after the warning above, so that
258 // we don't warn for the diverging expression itself.
259 self.write_ty(expr.hir_id, ty);
261 // Combine the diverging and has_error flags.
262 self.diverges.set(self.diverges.get() | old_diverges);
263 self.has_errors.set(self.has_errors.get() | old_has_errors);
265 debug!("type of {} is...", self.tcx.hir().node_to_string(expr.hir_id));
266 debug!("... {:?}, expected is {:?}", ty, expected);
271 #[instrument(skip(self, expr), level = "debug")]
274 expr: &'tcx hir::Expr<'tcx>,
275 expected: Expectation<'tcx>,
277 trace!("expr={:#?}", expr);
281 ExprKind::Box(subexpr) => self.check_expr_box(subexpr, expected),
282 ExprKind::Lit(ref lit) => self.check_lit(&lit, expected),
283 ExprKind::Binary(op, lhs, rhs) => self.check_binop(expr, op, lhs, rhs, expected),
284 ExprKind::Assign(lhs, rhs, span) => {
285 self.check_expr_assign(expr, expected, lhs, rhs, span)
287 ExprKind::AssignOp(op, lhs, rhs) => {
288 self.check_binop_assign(expr, op, lhs, rhs, expected)
290 ExprKind::Unary(unop, oprnd) => self.check_expr_unary(unop, oprnd, expected, expr),
291 ExprKind::AddrOf(kind, mutbl, oprnd) => {
292 self.check_expr_addr_of(kind, mutbl, oprnd, expected, expr)
294 ExprKind::Path(QPath::LangItem(lang_item, _, hir_id)) => {
295 self.check_lang_item_path(lang_item, expr, hir_id)
297 ExprKind::Path(ref qpath) => self.check_expr_path(qpath, expr, &[]),
298 ExprKind::InlineAsm(asm) => {
299 // We defer some asm checks as we may not have resolved the input and output types yet (they may still be infer vars).
300 self.deferred_asm_checks.borrow_mut().push((asm, expr.hir_id));
301 self.check_expr_asm(asm)
303 ExprKind::Break(destination, ref expr_opt) => {
304 self.check_expr_break(destination, expr_opt.as_deref(), expr)
306 ExprKind::Continue(destination) => {
307 if destination.target_id.is_ok() {
310 // There was an error; make type-check fail.
314 ExprKind::Ret(ref expr_opt) => self.check_expr_return(expr_opt.as_deref(), expr),
315 ExprKind::Let(let_expr) => self.check_expr_let(let_expr),
316 ExprKind::Loop(body, _, source, _) => {
317 self.check_expr_loop(body, source, expected, expr)
319 ExprKind::Match(discrim, arms, match_src) => {
320 self.check_match(expr, &discrim, arms, expected, match_src)
322 ExprKind::Closure(&Closure { capture_clause, fn_decl, body, movability, .. }) => {
323 self.check_expr_closure(expr, capture_clause, &fn_decl, body, movability, expected)
325 ExprKind::Block(body, _) => self.check_block_with_expected(&body, expected),
326 ExprKind::Call(callee, args) => self.check_call(expr, &callee, args, expected),
327 ExprKind::MethodCall(segment, args, _) => {
328 self.check_method_call(expr, segment, args, expected)
330 ExprKind::Cast(e, t) => self.check_expr_cast(e, t, expr),
331 ExprKind::Type(e, t) => {
332 let ty = self.to_ty_saving_user_provided_ty(&t);
333 self.check_expr_eq_type(&e, ty);
336 ExprKind::If(cond, then_expr, opt_else_expr) => {
337 self.check_then_else(cond, then_expr, opt_else_expr, expr.span, expected)
339 ExprKind::DropTemps(e) => self.check_expr_with_expectation(e, expected),
340 ExprKind::Array(args) => self.check_expr_array(args, expected, expr),
341 ExprKind::ConstBlock(ref anon_const) => {
342 self.check_expr_const_block(anon_const, expected, expr)
344 ExprKind::Repeat(element, ref count) => {
345 self.check_expr_repeat(element, count, expected, expr)
347 ExprKind::Tup(elts) => self.check_expr_tuple(elts, expected, expr),
348 ExprKind::Struct(qpath, fields, ref base_expr) => {
349 self.check_expr_struct(expr, expected, qpath, fields, base_expr)
351 ExprKind::Field(base, field) => self.check_field(expr, &base, field),
352 ExprKind::Index(base, idx) => self.check_expr_index(base, idx, expr),
353 ExprKind::Yield(value, ref src) => self.check_expr_yield(value, expr, src),
354 hir::ExprKind::Err => tcx.ty_error(),
358 fn check_expr_box(&self, expr: &'tcx hir::Expr<'tcx>, expected: Expectation<'tcx>) -> Ty<'tcx> {
359 let expected_inner = expected.to_option(self).map_or(NoExpectation, |ty| match ty.kind() {
360 ty::Adt(def, _) if def.is_box() => Expectation::rvalue_hint(self, ty.boxed_ty()),
363 let referent_ty = self.check_expr_with_expectation(expr, expected_inner);
364 self.require_type_is_sized(referent_ty, expr.span, traits::SizedBoxType);
365 self.tcx.mk_box(referent_ty)
371 oprnd: &'tcx hir::Expr<'tcx>,
372 expected: Expectation<'tcx>,
373 expr: &'tcx hir::Expr<'tcx>,
376 let expected_inner = match unop {
377 hir::UnOp::Not | hir::UnOp::Neg => expected,
378 hir::UnOp::Deref => NoExpectation,
380 let mut oprnd_t = self.check_expr_with_expectation(&oprnd, expected_inner);
382 if !oprnd_t.references_error() {
383 oprnd_t = self.structurally_resolved_type(expr.span, oprnd_t);
385 hir::UnOp::Deref => {
386 if let Some(ty) = self.lookup_derefing(expr, oprnd, oprnd_t) {
389 let mut err = type_error_struct!(
394 "type `{oprnd_t}` cannot be dereferenced",
396 let sp = tcx.sess.source_map().start_point(expr.span);
398 tcx.sess.parse_sess.ambiguous_block_expr_parse.borrow().get(&sp)
400 tcx.sess.parse_sess.expr_parentheses_needed(&mut err, *sp);
403 oprnd_t = tcx.ty_error();
407 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
408 // If it's builtin, we can reuse the type, this helps inference.
409 if !(oprnd_t.is_integral() || *oprnd_t.kind() == ty::Bool) {
414 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
415 // If it's builtin, we can reuse the type, this helps inference.
416 if !oprnd_t.is_numeric() {
425 fn check_expr_addr_of(
427 kind: hir::BorrowKind,
428 mutbl: hir::Mutability,
429 oprnd: &'tcx hir::Expr<'tcx>,
430 expected: Expectation<'tcx>,
431 expr: &'tcx hir::Expr<'tcx>,
433 let hint = expected.only_has_type(self).map_or(NoExpectation, |ty| {
435 ty::Ref(_, ty, _) | ty::RawPtr(ty::TypeAndMut { ty, .. }) => {
436 if oprnd.is_syntactic_place_expr() {
437 // Places may legitimately have unsized types.
438 // For example, dereferences of a fat pointer and
439 // the last field of a struct can be unsized.
442 Expectation::rvalue_hint(self, *ty)
449 self.check_expr_with_expectation_and_needs(&oprnd, hint, Needs::maybe_mut_place(mutbl));
451 let tm = ty::TypeAndMut { ty, mutbl };
453 _ if tm.ty.references_error() => self.tcx.ty_error(),
454 hir::BorrowKind::Raw => {
455 self.check_named_place_expr(oprnd);
458 hir::BorrowKind::Ref => {
459 // Note: at this point, we cannot say what the best lifetime
460 // is to use for resulting pointer. We want to use the
461 // shortest lifetime possible so as to avoid spurious borrowck
462 // errors. Moreover, the longest lifetime will depend on the
463 // precise details of the value whose address is being taken
464 // (and how long it is valid), which we don't know yet until
465 // type inference is complete.
467 // Therefore, here we simply generate a region variable. The
468 // region inferencer will then select a suitable value.
469 // Finally, borrowck will infer the value of the region again,
470 // this time with enough precision to check that the value
471 // whose address was taken can actually be made to live as long
472 // as it needs to live.
473 let region = self.next_region_var(infer::AddrOfRegion(expr.span));
474 self.tcx.mk_ref(region, tm)
479 /// Does this expression refer to a place that either:
480 /// * Is based on a local or static.
481 /// * Contains a dereference
482 /// Note that the adjustments for the children of `expr` should already
483 /// have been resolved.
484 fn check_named_place_expr(&self, oprnd: &'tcx hir::Expr<'tcx>) {
485 let is_named = oprnd.is_place_expr(|base| {
486 // Allow raw borrows if there are any deref adjustments.
488 // const VAL: (i32,) = (0,);
489 // const REF: &(i32,) = &(0,);
491 // &raw const VAL.0; // ERROR
492 // &raw const REF.0; // OK, same as &raw const (*REF).0;
494 // This is maybe too permissive, since it allows
495 // `let u = &raw const Box::new((1,)).0`, which creates an
496 // immediately dangling raw pointer.
501 .map_or(false, |x| x.iter().any(|adj| matches!(adj.kind, Adjust::Deref(_))))
504 self.tcx.sess.emit_err(AddressOfTemporaryTaken { span: oprnd.span });
508 fn check_lang_item_path(
510 lang_item: hir::LangItem,
511 expr: &'tcx hir::Expr<'tcx>,
512 hir_id: Option<hir::HirId>,
514 self.resolve_lang_item_path(lang_item, expr.span, expr.hir_id, hir_id).1
517 pub(crate) fn check_expr_path(
519 qpath: &'tcx hir::QPath<'tcx>,
520 expr: &'tcx hir::Expr<'tcx>,
521 args: &'tcx [hir::Expr<'tcx>],
524 let (res, opt_ty, segs) =
525 self.resolve_ty_and_res_fully_qualified_call(qpath, expr.hir_id, expr.span);
528 self.set_tainted_by_errors();
531 Res::Def(DefKind::Ctor(_, CtorKind::Fictive), _) => {
532 report_unexpected_variant_res(tcx, res, qpath, expr.span);
535 _ => self.instantiate_value_path(segs, opt_ty, res, expr.span, expr.hir_id).0,
538 if let ty::FnDef(did, ..) = *ty.kind() {
539 let fn_sig = ty.fn_sig(tcx);
540 if tcx.fn_sig(did).abi() == RustIntrinsic && tcx.item_name(did) == sym::transmute {
541 let from = fn_sig.inputs().skip_binder()[0];
542 let to = fn_sig.output().skip_binder();
543 // We defer the transmute to the end of typeck, once all inference vars have
544 // been resolved or we errored. This is important as we can only check transmute
545 // on concrete types, but the output type may not be known yet (it would only
546 // be known if explicitly specified via turbofish).
547 self.deferred_transmute_checks.borrow_mut().push((from, to, expr.span));
549 if !tcx.features().unsized_fn_params {
550 // We want to remove some Sized bounds from std functions,
551 // but don't want to expose the removal to stable Rust.
552 // i.e., we don't want to allow
558 // to work in stable even if the Sized bound on `drop` is relaxed.
559 for i in 0..fn_sig.inputs().skip_binder().len() {
560 // We just want to check sizedness, so instead of introducing
561 // placeholder lifetimes with probing, we just replace higher lifetimes
563 let span = args.get(i).map(|a| a.span).unwrap_or(expr.span);
564 let input = self.replace_bound_vars_with_fresh_vars(
566 infer::LateBoundRegionConversionTime::FnCall,
569 self.require_type_is_sized_deferred(
572 traits::SizedArgumentType(None),
576 // Here we want to prevent struct constructors from returning unsized types.
577 // There were two cases this happened: fn pointer coercion in stable
578 // and usual function call in presence of unsized_locals.
579 // Also, as we just want to check sizedness, instead of introducing
580 // placeholder lifetimes with probing, we just replace higher lifetimes
582 let output = self.replace_bound_vars_with_fresh_vars(
584 infer::LateBoundRegionConversionTime::FnCall,
587 self.require_type_is_sized_deferred(output, expr.span, traits::SizedReturnType);
590 // We always require that the type provided as the value for
591 // a type parameter outlives the moment of instantiation.
592 let substs = self.typeck_results.borrow().node_substs(expr.hir_id);
593 self.add_wf_bounds(substs, expr);
600 destination: hir::Destination,
601 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
602 expr: &'tcx hir::Expr<'tcx>,
605 if let Ok(target_id) = destination.target_id {
607 if let Some(e) = expr_opt {
608 // If this is a break with a value, we need to type-check
609 // the expression. Get an expected type from the loop context.
610 let opt_coerce_to = {
611 // We should release `enclosing_breakables` before the `check_expr_with_hint`
612 // below, so can't move this block of code to the enclosing scope and share
613 // `ctxt` with the second `enclosing_breakables` borrow below.
614 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
615 match enclosing_breakables.opt_find_breakable(target_id) {
616 Some(ctxt) => ctxt.coerce.as_ref().map(|coerce| coerce.expected_ty()),
618 // Avoid ICE when `break` is inside a closure (#65383).
619 return tcx.ty_error_with_message(
621 "break was outside loop, but no error was emitted",
627 // If the loop context is not a `loop { }`, then break with
628 // a value is illegal, and `opt_coerce_to` will be `None`.
629 // Just set expectation to error in that case.
630 let coerce_to = opt_coerce_to.unwrap_or_else(|| tcx.ty_error());
632 // Recurse without `enclosing_breakables` borrowed.
633 e_ty = self.check_expr_with_hint(e, coerce_to);
634 cause = self.misc(e.span);
636 // Otherwise, this is a break *without* a value. That's
637 // always legal, and is equivalent to `break ()`.
638 e_ty = tcx.mk_unit();
639 cause = self.misc(expr.span);
642 // Now that we have type-checked `expr_opt`, borrow
643 // the `enclosing_loops` field and let's coerce the
644 // type of `expr_opt` into what is expected.
645 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
646 let Some(ctxt) = enclosing_breakables.opt_find_breakable(target_id) else {
647 // Avoid ICE when `break` is inside a closure (#65383).
648 return tcx.ty_error_with_message(
650 "break was outside loop, but no error was emitted",
654 if let Some(ref mut coerce) = ctxt.coerce {
655 if let Some(ref e) = expr_opt {
656 coerce.coerce(self, &cause, e, e_ty);
658 assert!(e_ty.is_unit());
659 let ty = coerce.expected_ty();
660 coerce.coerce_forced_unit(
664 self.suggest_mismatched_types_on_tail(
665 &mut err, expr, ty, e_ty, target_id,
667 if let Some(val) = ty_kind_suggestion(ty) {
668 let label = destination
670 .map(|l| format!(" {}", l.ident))
671 .unwrap_or_else(String::new);
674 "give it a value of the expected type",
675 format!("break{label} {val}"),
676 Applicability::HasPlaceholders,
684 // If `ctxt.coerce` is `None`, we can just ignore
685 // the type of the expression. This is because
686 // either this was a break *without* a value, in
687 // which case it is always a legal type (`()`), or
688 // else an error would have been flagged by the
689 // `loops` pass for using break with an expression
690 // where you are not supposed to.
691 assert!(expr_opt.is_none() || self.tcx.sess.has_errors().is_some());
694 // If we encountered a `break`, then (no surprise) it may be possible to break from the
695 // loop... unless the value being returned from the loop diverges itself, e.g.
696 // `break return 5` or `break loop {}`.
697 ctxt.may_break |= !self.diverges.get().is_always();
699 // the type of a `break` is always `!`, since it diverges
702 // Otherwise, we failed to find the enclosing loop;
703 // this can only happen if the `break` was not
704 // inside a loop at all, which is caught by the
705 // loop-checking pass.
706 let err = self.tcx.ty_error_with_message(
708 "break was outside loop, but no error was emitted",
711 // We still need to assign a type to the inner expression to
712 // prevent the ICE in #43162.
713 if let Some(e) = expr_opt {
714 self.check_expr_with_hint(e, err);
716 // ... except when we try to 'break rust;'.
717 // ICE this expression in particular (see #43162).
718 if let ExprKind::Path(QPath::Resolved(_, path)) = e.kind {
719 if path.segments.len() == 1 && path.segments[0].ident.name == sym::rust {
720 fatally_break_rust(self.tcx.sess);
725 // There was an error; make type-check fail.
730 fn check_expr_return(
732 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
733 expr: &'tcx hir::Expr<'tcx>,
735 if self.ret_coercion.is_none() {
736 let mut err = ReturnStmtOutsideOfFnBody {
738 encl_body_span: None,
742 let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
744 if let Some(hir::Node::Item(hir::Item {
745 kind: hir::ItemKind::Fn(..),
749 | Some(hir::Node::TraitItem(hir::TraitItem {
750 kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),
754 | Some(hir::Node::ImplItem(hir::ImplItem {
755 kind: hir::ImplItemKind::Fn(..),
758 })) = self.tcx.hir().find_by_def_id(encl_item_id)
760 // We are inside a function body, so reporting "return statement
761 // outside of function body" needs an explanation.
763 let encl_body_owner_id = self.tcx.hir().enclosing_body_owner(expr.hir_id);
765 // If this didn't hold, we would not have to report an error in
767 assert_ne!(encl_item_id, encl_body_owner_id);
769 let encl_body_id = self.tcx.hir().body_owned_by(encl_body_owner_id);
770 let encl_body = self.tcx.hir().body(encl_body_id);
772 err.encl_body_span = Some(encl_body.value.span);
773 err.encl_fn_span = Some(*encl_fn_span);
776 self.tcx.sess.emit_err(err);
778 if let Some(e) = expr_opt {
779 // We still have to type-check `e` (issue #86188), but calling
780 // `check_return_expr` only works inside fn bodies.
783 } else if let Some(e) = expr_opt {
784 if self.ret_coercion_span.get().is_none() {
785 self.ret_coercion_span.set(Some(e.span));
787 self.check_return_expr(e, true);
789 let mut coercion = self.ret_coercion.as_ref().unwrap().borrow_mut();
790 if self.ret_coercion_span.get().is_none() {
791 self.ret_coercion_span.set(Some(expr.span));
793 let cause = self.cause(expr.span, ObligationCauseCode::ReturnNoExpression);
794 if let Some((fn_decl, _)) = self.get_fn_decl(expr.hir_id) {
795 coercion.coerce_forced_unit(
799 let span = fn_decl.output.span();
800 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
803 format!("expected `{snippet}` because of this return type"),
810 coercion.coerce_forced_unit(self, &cause, &mut |_| (), true);
816 /// `explicit_return` is `true` if we're checking an explicit `return expr`,
817 /// and `false` if we're checking a trailing expression.
818 pub(super) fn check_return_expr(
820 return_expr: &'tcx hir::Expr<'tcx>,
821 explicit_return: bool,
823 let ret_coercion = self.ret_coercion.as_ref().unwrap_or_else(|| {
824 span_bug!(return_expr.span, "check_return_expr called outside fn body")
827 let ret_ty = ret_coercion.borrow().expected_ty();
828 let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty);
829 let mut span = return_expr.span;
830 // Use the span of the trailing expression for our cause,
831 // not the span of the entire function
832 if !explicit_return {
833 if let ExprKind::Block(body, _) = return_expr.kind && let Some(last_expr) = body.expr {
834 span = last_expr.span;
837 ret_coercion.borrow_mut().coerce(
839 &self.cause(span, ObligationCauseCode::ReturnValue(return_expr.hir_id)),
844 if self.return_type_has_opaque {
845 // Point any obligations that were registered due to opaque type
846 // inference at the return expression.
847 self.select_obligations_where_possible(false, |errors| {
848 self.point_at_return_for_opaque_ty_error(errors, span, return_expr_ty);
853 fn point_at_return_for_opaque_ty_error(
855 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
857 return_expr_ty: Ty<'tcx>,
859 // Don't point at the whole block if it's empty
860 if span == self.tcx.hir().span(self.body_id) {
864 let cause = &mut err.obligation.cause;
865 if let ObligationCauseCode::OpaqueReturnType(None) = cause.code() {
866 let new_cause = ObligationCause::new(
869 ObligationCauseCode::OpaqueReturnType(Some((return_expr_ty, span))),
876 pub(crate) fn check_lhs_assignable(
878 lhs: &'tcx hir::Expr<'tcx>,
879 err_code: &'static str,
881 adjust_err: impl FnOnce(&mut Diagnostic),
883 if lhs.is_syntactic_place_expr() {
887 // FIXME: Make this use SessionDiagnostic once error codes can be dynamically set.
888 let mut err = self.tcx.sess.struct_span_err_with_code(
890 "invalid left-hand side of assignment",
891 DiagnosticId::Error(err_code.into()),
893 err.span_label(lhs.span, "cannot assign to this expression");
895 self.comes_from_while_condition(lhs.hir_id, |expr| {
896 err.span_suggestion_verbose(
897 expr.span.shrink_to_lo(),
898 "you might have meant to use pattern destructuring",
900 Applicability::MachineApplicable,
904 adjust_err(&mut err);
909 // Check if an expression `original_expr_id` comes from the condition of a while loop,
910 // as opposed from the body of a while loop, which we can naively check by iterating
911 // parents until we find a loop...
912 pub(super) fn comes_from_while_condition(
914 original_expr_id: HirId,
915 then: impl FnOnce(&hir::Expr<'_>),
917 let mut parent = self.tcx.hir().get_parent_node(original_expr_id);
918 while let Some(node) = self.tcx.hir().find(parent) {
920 hir::Node::Expr(hir::Expr {
927 hir::ExprKind::Match(expr, ..) | hir::ExprKind::If(expr, ..),
933 hir::LoopSource::While,
938 // Check if our original expression is a child of the condition of a while loop
939 let expr_is_ancestor = std::iter::successors(Some(original_expr_id), |id| {
940 self.tcx.hir().find_parent_node(*id)
942 .take_while(|id| *id != parent)
943 .any(|id| id == expr.hir_id);
944 // if it is, then we have a situation like `while Some(0) = value.get(0) {`,
945 // where `while let` was more likely intended.
946 if expr_is_ancestor {
952 | hir::Node::ImplItem(_)
953 | hir::Node::TraitItem(_)
954 | hir::Node::Crate(_) => break,
956 parent = self.tcx.hir().get_parent_node(parent);
962 // A generic function for checking the 'then' and 'else' clauses in an 'if'
963 // or 'if-else' expression.
966 cond_expr: &'tcx hir::Expr<'tcx>,
967 then_expr: &'tcx hir::Expr<'tcx>,
968 opt_else_expr: Option<&'tcx hir::Expr<'tcx>>,
970 orig_expected: Expectation<'tcx>,
972 let cond_ty = self.check_expr_has_type_or_error(cond_expr, self.tcx.types.bool, |_| {});
974 self.warn_if_unreachable(
977 "block in `if` or `while` expression",
980 let cond_diverges = self.diverges.get();
981 self.diverges.set(Diverges::Maybe);
983 let expected = orig_expected.adjust_for_branches(self);
984 let then_ty = self.check_expr_with_expectation(then_expr, expected);
985 let then_diverges = self.diverges.get();
986 self.diverges.set(Diverges::Maybe);
988 // We've already taken the expected type's preferences
989 // into account when typing the `then` branch. To figure
990 // out the initial shot at a LUB, we thus only consider
991 // `expected` if it represents a *hard* constraint
992 // (`only_has_type`); otherwise, we just go with a
993 // fresh type variable.
994 let coerce_to_ty = expected.coercion_target_type(self, sp);
995 let mut coerce: DynamicCoerceMany<'_> = CoerceMany::new(coerce_to_ty);
997 coerce.coerce(self, &self.misc(sp), then_expr, then_ty);
999 if let Some(else_expr) = opt_else_expr {
1000 let else_ty = self.check_expr_with_expectation(else_expr, expected);
1001 let else_diverges = self.diverges.get();
1003 let opt_suggest_box_span = self.opt_suggest_box_span(then_ty, else_ty, orig_expected);
1004 let if_cause = self.if_cause(
1011 opt_suggest_box_span,
1014 coerce.coerce(self, &if_cause, else_expr, else_ty);
1016 // We won't diverge unless both branches do (or the condition does).
1017 self.diverges.set(cond_diverges | then_diverges & else_diverges);
1019 self.if_fallback_coercion(sp, then_expr, &mut coerce);
1021 // If the condition is false we can't diverge.
1022 self.diverges.set(cond_diverges);
1025 let result_ty = coerce.complete(self);
1026 if cond_ty.references_error() { self.tcx.ty_error() } else { result_ty }
1029 /// Type check assignment expression `expr` of form `lhs = rhs`.
1030 /// The expected type is `()` and is passed to the function for the purposes of diagnostics.
1031 fn check_expr_assign(
1033 expr: &'tcx hir::Expr<'tcx>,
1034 expected: Expectation<'tcx>,
1035 lhs: &'tcx hir::Expr<'tcx>,
1036 rhs: &'tcx hir::Expr<'tcx>,
1039 let expected_ty = expected.coercion_target_type(self, expr.span);
1040 if expected_ty == self.tcx.types.bool {
1041 // The expected type is `bool` but this will result in `()` so we can reasonably
1042 // say that the user intended to write `lhs == rhs` instead of `lhs = rhs`.
1043 // The likely cause of this is `if foo = bar { .. }`.
1044 let actual_ty = self.tcx.mk_unit();
1045 let mut err = self.demand_suptype_diag(expr.span, expected_ty, actual_ty).unwrap();
1046 let lhs_ty = self.check_expr(&lhs);
1047 let rhs_ty = self.check_expr(&rhs);
1048 let (applicability, eq) = if self.can_coerce(rhs_ty, lhs_ty) {
1049 (Applicability::MachineApplicable, true)
1051 (Applicability::MaybeIncorrect, false)
1053 if !lhs.is_syntactic_place_expr()
1054 && lhs.is_approximately_pattern()
1055 && !matches!(lhs.kind, hir::ExprKind::Lit(_))
1057 // Do not suggest `if let x = y` as `==` is way more likely to be the intention.
1058 let hir = self.tcx.hir();
1059 if let hir::Node::Expr(hir::Expr { kind: ExprKind::If { .. }, .. }) =
1060 hir.get(hir.get_parent_node(hir.get_parent_node(expr.hir_id)))
1062 err.span_suggestion_verbose(
1063 expr.span.shrink_to_lo(),
1064 "you might have meant to use pattern matching",
1071 err.span_suggestion_verbose(
1073 "you might have meant to compare for equality",
1079 // If the assignment expression itself is ill-formed, don't
1080 // bother emitting another error
1081 if lhs_ty.references_error() || rhs_ty.references_error() {
1086 return self.tcx.ty_error();
1089 let lhs_ty = self.check_expr_with_needs(&lhs, Needs::MutPlace);
1091 let suggest_deref_binop = |err: &mut Diagnostic, rhs_ty: Ty<'tcx>| {
1092 if let Some(lhs_deref_ty) = self.deref_once_mutably_for_diagnostic(lhs_ty) {
1093 // Can only assign if the type is sized, so if `DerefMut` yields a type that is
1094 // unsized, do not suggest dereferencing it.
1095 let lhs_deref_ty_is_sized = self
1097 .type_implements_trait(
1098 self.tcx.lang_items().sized_trait().unwrap(),
1104 if lhs_deref_ty_is_sized && self.can_coerce(rhs_ty, lhs_deref_ty) {
1105 err.span_suggestion_verbose(
1106 lhs.span.shrink_to_lo(),
1107 "consider dereferencing here to assign to the mutably borrowed value",
1109 Applicability::MachineApplicable,
1115 self.check_lhs_assignable(lhs, "E0070", span, |err| {
1116 let rhs_ty = self.check_expr(&rhs);
1117 suggest_deref_binop(err, rhs_ty);
1120 // This is (basically) inlined `check_expr_coercable_to_type`, but we want
1121 // to suggest an additional fixup here in `suggest_deref_binop`.
1122 let rhs_ty = self.check_expr_with_hint(&rhs, lhs_ty);
1123 if let (_, Some(mut diag)) =
1124 self.demand_coerce_diag(rhs, rhs_ty, lhs_ty, Some(lhs), AllowTwoPhase::No)
1126 suggest_deref_binop(&mut diag, rhs_ty);
1130 self.require_type_is_sized(lhs_ty, lhs.span, traits::AssignmentLhsSized);
1132 if lhs_ty.references_error() || rhs_ty.references_error() {
1139 pub(super) fn check_expr_let(&self, let_expr: &'tcx hir::Let<'tcx>) -> Ty<'tcx> {
1140 // for let statements, this is done in check_stmt
1141 let init = let_expr.init;
1142 self.warn_if_unreachable(init.hir_id, init.span, "block in `let` expression");
1143 // otherwise check exactly as a let statement
1144 self.check_decl(let_expr.into());
1145 // but return a bool, for this is a boolean expression
1151 body: &'tcx hir::Block<'tcx>,
1152 source: hir::LoopSource,
1153 expected: Expectation<'tcx>,
1154 expr: &'tcx hir::Expr<'tcx>,
1156 let coerce = match source {
1157 // you can only use break with a value from a normal `loop { }`
1158 hir::LoopSource::Loop => {
1159 let coerce_to = expected.coercion_target_type(self, body.span);
1160 Some(CoerceMany::new(coerce_to))
1163 hir::LoopSource::While | hir::LoopSource::ForLoop => None,
1166 let ctxt = BreakableCtxt {
1168 may_break: false, // Will get updated if/when we find a `break`.
1171 let (ctxt, ()) = self.with_breakable_ctxt(expr.hir_id, ctxt, || {
1172 self.check_block_no_value(&body);
1176 // No way to know whether it's diverging because
1177 // of a `break` or an outer `break` or `return`.
1178 self.diverges.set(Diverges::Maybe);
1181 // If we permit break with a value, then result type is
1182 // the LUB of the breaks (possibly ! if none); else, it
1183 // is nil. This makes sense because infinite loops
1184 // (which would have type !) are only possible iff we
1185 // permit break with a value [1].
1186 if ctxt.coerce.is_none() && !ctxt.may_break {
1188 self.tcx.sess.delay_span_bug(body.span, "no coercion, but loop may not break");
1190 ctxt.coerce.map(|c| c.complete(self)).unwrap_or_else(|| self.tcx.mk_unit())
1193 /// Checks a method call.
1194 fn check_method_call(
1196 expr: &'tcx hir::Expr<'tcx>,
1197 segment: &hir::PathSegment<'_>,
1198 args: &'tcx [hir::Expr<'tcx>],
1199 expected: Expectation<'tcx>,
1201 let rcvr = &args[0];
1202 let rcvr_t = self.check_expr(&rcvr);
1203 // no need to check for bot/err -- callee does that
1204 let rcvr_t = self.structurally_resolved_type(args[0].span, rcvr_t);
1205 let span = segment.ident.span;
1207 let method = match self.lookup_method(rcvr_t, segment, span, expr, rcvr, args) {
1209 // We could add a "consider `foo::<params>`" suggestion here, but I wasn't able to
1210 // trigger this codepath causing `structurally_resolved_type` to emit an error.
1212 self.write_method_call(expr.hir_id, method);
1216 if segment.ident.name != kw::Empty {
1217 if let Some(mut err) = self.report_method_error(
1221 SelfSource::MethodCall(&args[0]),
1232 // Call the generic checker.
1233 self.check_method_argument_types(
1245 e: &'tcx hir::Expr<'tcx>,
1246 t: &'tcx hir::Ty<'tcx>,
1247 expr: &'tcx hir::Expr<'tcx>,
1249 // Find the type of `e`. Supply hints based on the type we are casting to,
1251 let t_cast = self.to_ty_saving_user_provided_ty(t);
1252 let t_cast = self.resolve_vars_if_possible(t_cast);
1253 let t_expr = self.check_expr_with_expectation(e, ExpectCastableToType(t_cast));
1254 let t_expr = self.resolve_vars_if_possible(t_expr);
1256 // Eagerly check for some obvious errors.
1257 if t_expr.references_error() || t_cast.references_error() {
1260 // Defer other checks until we're done type checking.
1261 let mut deferred_cast_checks = self.deferred_cast_checks.borrow_mut();
1262 match cast::CastCheck::new(self, e, t_expr, t_cast, t.span, expr.span) {
1265 "check_expr_cast: deferring cast from {:?} to {:?}: {:?}",
1266 t_cast, t_expr, cast_check,
1268 deferred_cast_checks.push(cast_check);
1271 Err(_) => self.tcx.ty_error(),
1276 fn check_expr_array(
1278 args: &'tcx [hir::Expr<'tcx>],
1279 expected: Expectation<'tcx>,
1280 expr: &'tcx hir::Expr<'tcx>,
1282 let element_ty = if !args.is_empty() {
1283 let coerce_to = expected
1285 .and_then(|uty| match *uty.kind() {
1286 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1289 .unwrap_or_else(|| {
1290 self.next_ty_var(TypeVariableOrigin {
1291 kind: TypeVariableOriginKind::TypeInference,
1295 let mut coerce = CoerceMany::with_coercion_sites(coerce_to, args);
1296 assert_eq!(self.diverges.get(), Diverges::Maybe);
1298 let e_ty = self.check_expr_with_hint(e, coerce_to);
1299 let cause = self.misc(e.span);
1300 coerce.coerce(self, &cause, e, e_ty);
1302 coerce.complete(self)
1304 self.next_ty_var(TypeVariableOrigin {
1305 kind: TypeVariableOriginKind::TypeInference,
1309 let array_len = args.len() as u64;
1310 self.suggest_array_len(expr, array_len);
1311 self.tcx.mk_array(element_ty, array_len)
1314 fn suggest_array_len(&self, expr: &'tcx hir::Expr<'tcx>, array_len: u64) {
1315 if let Some(parent_hir_id) = self.tcx.hir().find_parent_node(expr.hir_id) {
1316 let ty = match self.tcx.hir().find(parent_hir_id) {
1318 hir::Node::Local(hir::Local { ty: Some(ty), .. })
1319 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Const(ty, _), .. }),
1323 if let Some(ty) = ty
1324 && let hir::TyKind::Array(_, length) = ty.kind
1325 && let hir::ArrayLen::Body(hir::AnonConst { hir_id, .. }) = length
1326 && let Some(span) = self.tcx.hir().opt_span(hir_id)
1328 match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
1330 err.span_suggestion(
1332 "consider specifying the array length",
1334 Applicability::MaybeIncorrect,
1344 fn check_expr_const_block(
1346 anon_const: &'tcx hir::AnonConst,
1347 expected: Expectation<'tcx>,
1348 _expr: &'tcx hir::Expr<'tcx>,
1350 let body = self.tcx.hir().body(anon_const.body);
1352 // Create a new function context.
1353 let fcx = FnCtxt::new(self, self.param_env.with_const(), body.value.hir_id);
1354 crate::check::GatherLocalsVisitor::new(&fcx).visit_body(body);
1356 let ty = fcx.check_expr_with_expectation(&body.value, expected);
1357 fcx.require_type_is_sized(ty, body.value.span, traits::ConstSized);
1358 fcx.write_ty(anon_const.hir_id, ty);
1362 fn check_expr_repeat(
1364 element: &'tcx hir::Expr<'tcx>,
1365 count: &'tcx hir::ArrayLen,
1366 expected: Expectation<'tcx>,
1367 expr: &'tcx hir::Expr<'tcx>,
1370 let count = self.array_length_to_const(count);
1371 if let Some(count) = count.try_eval_usize(tcx, self.param_env) {
1372 self.suggest_array_len(expr, count);
1375 let uty = match expected {
1376 ExpectHasType(uty) => match *uty.kind() {
1377 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1383 let (element_ty, t) = match uty {
1385 self.check_expr_coercable_to_type(&element, uty, None);
1389 let ty = self.next_ty_var(TypeVariableOrigin {
1390 kind: TypeVariableOriginKind::MiscVariable,
1393 let element_ty = self.check_expr_has_type_or_error(&element, ty, |_| {});
1398 if element_ty.references_error() {
1399 return tcx.ty_error();
1402 self.check_repeat_element_needs_copy_bound(element, count, element_ty);
1404 tcx.mk_ty(ty::Array(t, count))
1407 fn check_repeat_element_needs_copy_bound(
1409 element: &hir::Expr<'_>,
1410 count: ty::Const<'tcx>,
1411 element_ty: Ty<'tcx>,
1414 // Actual constants as the repeat element get inserted repeatedly instead of getting copied via Copy.
1415 match &element.kind {
1416 hir::ExprKind::ConstBlock(..) => return,
1417 hir::ExprKind::Path(qpath) => {
1418 let res = self.typeck_results.borrow().qpath_res(qpath, element.hir_id);
1419 if let Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::AnonConst, _) = res
1426 // If someone calls a const fn, they can extract that call out into a separate constant (or a const
1427 // block in the future), so we check that to tell them that in the diagnostic. Does not affect typeck.
1428 let is_const_fn = match element.kind {
1429 hir::ExprKind::Call(func, _args) => match *self.node_ty(func.hir_id).kind() {
1430 ty::FnDef(def_id, _) => tcx.is_const_fn(def_id),
1436 // If the length is 0, we don't create any elements, so we don't copy any. If the length is 1, we
1437 // don't copy that one element, we move it. Only check for Copy if the length is larger.
1438 if count.try_eval_usize(tcx, self.param_env).map_or(true, |len| len > 1) {
1439 let lang_item = self.tcx.require_lang_item(LangItem::Copy, None);
1440 let code = traits::ObligationCauseCode::RepeatElementCopy { is_const_fn };
1441 self.require_type_meets(element_ty, element.span, code, lang_item);
1445 fn check_expr_tuple(
1447 elts: &'tcx [hir::Expr<'tcx>],
1448 expected: Expectation<'tcx>,
1449 expr: &'tcx hir::Expr<'tcx>,
1451 let flds = expected.only_has_type(self).and_then(|ty| {
1452 let ty = self.resolve_vars_with_obligations(ty);
1454 ty::Tuple(flds) => Some(&flds[..]),
1459 let elt_ts_iter = elts.iter().enumerate().map(|(i, e)| match flds {
1460 Some(fs) if i < fs.len() => {
1462 self.check_expr_coercable_to_type(&e, ety, None);
1465 _ => self.check_expr_with_expectation(&e, NoExpectation),
1467 let tuple = self.tcx.mk_tup(elt_ts_iter);
1468 if tuple.references_error() {
1471 self.require_type_is_sized(tuple, expr.span, traits::TupleInitializerSized);
1476 fn check_expr_struct(
1478 expr: &hir::Expr<'_>,
1479 expected: Expectation<'tcx>,
1481 fields: &'tcx [hir::ExprField<'tcx>],
1482 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1484 // Find the relevant variant
1485 let Some((variant, adt_ty)) = self.check_struct_path(qpath, expr.hir_id) else {
1486 self.check_struct_fields_on_error(fields, base_expr);
1487 return self.tcx.ty_error();
1490 // Prohibit struct expressions when non-exhaustive flag is set.
1491 let adt = adt_ty.ty_adt_def().expect("`check_struct_path` returned non-ADT type");
1492 if !adt.did().is_local() && variant.is_field_list_non_exhaustive() {
1495 .emit_err(StructExprNonExhaustive { span: expr.span, what: adt.variant_descr() });
1498 self.check_expr_struct_fields(
1509 self.require_type_is_sized(adt_ty, expr.span, traits::StructInitializerSized);
1513 fn check_expr_struct_fields(
1516 expected: Expectation<'tcx>,
1517 expr_id: hir::HirId,
1519 variant: &'tcx ty::VariantDef,
1520 ast_fields: &'tcx [hir::ExprField<'tcx>],
1521 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1526 let expected_inputs =
1527 self.expected_inputs_for_expected_output(span, expected, adt_ty, &[adt_ty]);
1528 let adt_ty_hint = if let Some(expected_inputs) = expected_inputs {
1529 expected_inputs.get(0).cloned().unwrap_or(adt_ty)
1533 // re-link the regions that EIfEO can erase.
1534 self.demand_eqtype(span, adt_ty_hint, adt_ty);
1536 let ty::Adt(adt, substs) = adt_ty.kind() else {
1537 span_bug!(span, "non-ADT passed to check_expr_struct_fields");
1539 let adt_kind = adt.adt_kind();
1541 let mut remaining_fields = variant
1545 .map(|(i, field)| (field.ident(tcx).normalize_to_macros_2_0(), (i, field)))
1546 .collect::<FxHashMap<_, _>>();
1548 let mut seen_fields = FxHashMap::default();
1550 let mut error_happened = false;
1552 // Type-check each field.
1553 for (idx, field) in ast_fields.iter().enumerate() {
1554 let ident = tcx.adjust_ident(field.ident, variant.def_id);
1555 let field_type = if let Some((i, v_field)) = remaining_fields.remove(&ident) {
1556 seen_fields.insert(ident, field.span);
1557 self.write_field_index(field.hir_id, i);
1559 // We don't look at stability attributes on
1560 // struct-like enums (yet...), but it's definitely not
1561 // a bug to have constructed one.
1562 if adt_kind != AdtKind::Enum {
1563 tcx.check_stability(v_field.did, Some(expr_id), field.span, None);
1566 self.field_ty(field.span, v_field, substs)
1568 error_happened = true;
1569 if let Some(prev_span) = seen_fields.get(&ident) {
1570 tcx.sess.emit_err(FieldMultiplySpecifiedInInitializer {
1571 span: field.ident.span,
1572 prev_span: *prev_span,
1576 self.report_unknown_field(
1581 adt.variant_descr(),
1589 // Make sure to give a type to the field even if there's
1590 // an error, so we can continue type-checking.
1591 let ty = self.check_expr_with_hint(&field.expr, field_type);
1593 self.demand_coerce_diag(&field.expr, ty, field_type, None, AllowTwoPhase::No);
1595 if let Some(mut diag) = diag {
1596 if idx == ast_fields.len() - 1 && remaining_fields.is_empty() {
1597 self.suggest_fru_from_range(field, variant, substs, &mut diag);
1603 // Make sure the programmer specified correct number of fields.
1604 if adt_kind == AdtKind::Union {
1605 if ast_fields.len() != 1 {
1610 "union expressions should have exactly one field",
1616 // If check_expr_struct_fields hit an error, do not attempt to populate
1617 // the fields with the base_expr. This could cause us to hit errors later
1618 // when certain fields are assumed to exist that in fact do not.
1623 if let Some(base_expr) = base_expr {
1624 // FIXME: We are currently creating two branches here in order to maintain
1625 // consistency. But they should be merged as much as possible.
1626 let fru_tys = if self.tcx.features().type_changing_struct_update {
1627 if adt.is_struct() {
1628 // Make some fresh substitutions for our ADT type.
1629 let fresh_substs = self.fresh_substs_for_item(base_expr.span, adt.did());
1630 // We do subtyping on the FRU fields first, so we can
1631 // learn exactly what types we expect the base expr
1632 // needs constrained to be compatible with the struct
1633 // type we expect from the expectation value.
1634 let fru_tys = variant
1638 let fru_ty = self.normalize_associated_types_in(
1640 self.field_ty(base_expr.span, f, fresh_substs),
1642 let ident = self.tcx.adjust_ident(f.ident(self.tcx), variant.def_id);
1643 if let Some(_) = remaining_fields.remove(&ident) {
1644 let target_ty = self.field_ty(base_expr.span, f, substs);
1645 let cause = self.misc(base_expr.span);
1646 match self.at(&cause, self.param_env).sup(target_ty, fru_ty) {
1647 Ok(InferOk { obligations, value: () }) => {
1648 self.register_predicates(obligations)
1651 // This should never happen, since we're just subtyping the
1652 // remaining_fields, but it's fine to emit this, I guess.
1653 self.report_mismatched_types(
1657 FieldMisMatch(variant.name, ident.name),
1663 self.resolve_vars_if_possible(fru_ty)
1666 // The use of fresh substs that we have subtyped against
1667 // our base ADT type's fields allows us to guide inference
1668 // along so that, e.g.
1670 // MyStruct<'a, F1, F2, const C: usize> {
1672 // // Other fields that reference `'a`, `F2`, and `C`
1675 // let x = MyStruct {
1680 // will have the `other_struct` expression constrained to
1681 // `MyStruct<'a, _, F2, C>`, as opposed to just `_`...
1682 // This is important to allow coercions to happen in
1683 // `other_struct` itself. See `coerce-in-base-expr.rs`.
1684 let fresh_base_ty = self.tcx.mk_adt(*adt, fresh_substs);
1685 self.check_expr_has_type_or_error(
1687 self.resolve_vars_if_possible(fresh_base_ty),
1692 // Check the base_expr, regardless of a bad expected adt_ty, so we can get
1693 // type errors on that expression, too.
1694 self.check_expr(base_expr);
1697 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1701 self.check_expr_has_type_or_error(base_expr, adt_ty, |_| {
1702 let base_ty = self.typeck_results.borrow().expr_ty(*base_expr);
1703 let same_adt = match (adt_ty.kind(), base_ty.kind()) {
1704 (ty::Adt(adt, _), ty::Adt(base_adt, _)) if adt == base_adt => true,
1707 if self.tcx.sess.is_nightly_build() && same_adt {
1709 &self.tcx.sess.parse_sess,
1710 sym::type_changing_struct_update,
1712 "type changing struct updating is experimental",
1717 match adt_ty.kind() {
1718 ty::Adt(adt, substs) if adt.is_struct() => variant
1722 self.normalize_associated_types_in(expr_span, f.ty(self.tcx, substs))
1728 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1733 self.typeck_results.borrow_mut().fru_field_types_mut().insert(expr_id, fru_tys);
1734 } else if adt_kind != AdtKind::Union && !remaining_fields.is_empty() {
1735 debug!(?remaining_fields);
1736 let private_fields: Vec<&ty::FieldDef> = variant
1740 !field.vis.is_accessible_from(tcx.parent_module(expr_id).to_def_id(), tcx)
1744 if !private_fields.is_empty() {
1745 self.report_private_fields(adt_ty, span, private_fields, ast_fields);
1747 self.report_missing_fields(
1759 fn check_struct_fields_on_error(
1761 fields: &'tcx [hir::ExprField<'tcx>],
1762 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1764 for field in fields {
1765 self.check_expr(&field.expr);
1767 if let Some(base) = *base_expr {
1768 self.check_expr(&base);
1772 /// Report an error for a struct field expression when there are fields which aren't provided.
1775 /// error: missing field `you_can_use_this_field` in initializer of `foo::Foo`
1776 /// --> src/main.rs:8:5
1778 /// 8 | foo::Foo {};
1779 /// | ^^^^^^^^ missing `you_can_use_this_field`
1781 /// error: aborting due to previous error
1783 fn report_missing_fields(
1787 remaining_fields: FxHashMap<Ident, (usize, &ty::FieldDef)>,
1788 variant: &'tcx ty::VariantDef,
1789 ast_fields: &'tcx [hir::ExprField<'tcx>],
1790 substs: SubstsRef<'tcx>,
1792 let len = remaining_fields.len();
1794 let mut displayable_field_names: Vec<&str> =
1795 remaining_fields.keys().map(|ident| ident.as_str()).collect();
1796 // sorting &str primitives here, sort_unstable is ok
1797 displayable_field_names.sort_unstable();
1799 let mut truncated_fields_error = String::new();
1800 let remaining_fields_names = match &displayable_field_names[..] {
1801 [field1] => format!("`{}`", field1),
1802 [field1, field2] => format!("`{field1}` and `{field2}`"),
1803 [field1, field2, field3] => format!("`{field1}`, `{field2}` and `{field3}`"),
1805 truncated_fields_error =
1806 format!(" and {} other field{}", len - 3, pluralize!(len - 3));
1807 displayable_field_names
1810 .map(|n| format!("`{n}`"))
1811 .collect::<Vec<_>>()
1816 let mut err = struct_span_err!(
1820 "missing field{} {}{} in initializer of `{}`",
1822 remaining_fields_names,
1823 truncated_fields_error,
1826 err.span_label(span, format!("missing {remaining_fields_names}{truncated_fields_error}"));
1828 if let Some(last) = ast_fields.last() {
1829 self.suggest_fru_from_range(last, variant, substs, &mut err);
1835 /// If the last field is a range literal, but it isn't supposed to be, then they probably
1836 /// meant to use functional update syntax.
1837 fn suggest_fru_from_range(
1839 last_expr_field: &hir::ExprField<'tcx>,
1840 variant: &ty::VariantDef,
1841 substs: SubstsRef<'tcx>,
1842 err: &mut Diagnostic,
1844 // I don't use 'is_range_literal' because only double-sided, half-open ranges count.
1845 if let ExprKind::Struct(
1846 QPath::LangItem(LangItem::Range, ..),
1847 &[ref range_start, ref range_end],
1849 ) = last_expr_field.expr.kind
1850 && let variant_field =
1851 variant.fields.iter().find(|field| field.ident(self.tcx) == last_expr_field.ident)
1852 && let range_def_id = self.tcx.lang_items().range_struct()
1854 .and_then(|field| field.ty(self.tcx, substs).ty_adt_def())
1855 .map(|adt| adt.did())
1862 .span_to_snippet(range_end.expr.span)
1863 .map(|s| format!(" from `{s}`"))
1864 .unwrap_or_default();
1865 err.span_suggestion(
1866 range_start.span.shrink_to_hi(),
1867 &format!("to set the remaining fields{instead}, separate the last named field with a comma"),
1869 Applicability::MaybeIncorrect,
1874 /// Report an error for a struct field expression when there are invisible fields.
1877 /// error: cannot construct `Foo` with struct literal syntax due to private fields
1878 /// --> src/main.rs:8:5
1880 /// 8 | foo::Foo {};
1883 /// error: aborting due to previous error
1885 fn report_private_fields(
1889 private_fields: Vec<&ty::FieldDef>,
1890 used_fields: &'tcx [hir::ExprField<'tcx>],
1892 let mut err = self.tcx.sess.struct_span_err(
1895 "cannot construct `{adt_ty}` with struct literal syntax due to private fields",
1898 let (used_private_fields, remaining_private_fields): (
1899 Vec<(Symbol, Span, bool)>,
1900 Vec<(Symbol, Span, bool)>,
1904 match used_fields.iter().find(|used_field| field.name == used_field.ident.name) {
1905 Some(used_field) => (field.name, used_field.span, true),
1906 None => (field.name, self.tcx.def_span(field.did), false),
1909 .partition(|field| field.2);
1910 err.span_labels(used_private_fields.iter().map(|(_, span, _)| *span), "private field");
1911 if !remaining_private_fields.is_empty() {
1912 let remaining_private_fields_len = remaining_private_fields.len();
1913 let names = match &remaining_private_fields
1915 .map(|(name, _, _)| name)
1916 .collect::<Vec<_>>()[..]
1918 _ if remaining_private_fields_len > 6 => String::new(),
1919 [name] => format!("`{name}` "),
1920 [names @ .., last] => {
1921 let names = names.iter().map(|name| format!("`{name}`")).collect::<Vec<_>>();
1922 format!("{} and `{last}` ", names.join(", "))
1924 [] => unreachable!(),
1927 "... and other private field{s} {names}that {were} not provided",
1928 s = pluralize!(remaining_private_fields_len),
1929 were = pluralize!("was", remaining_private_fields_len),
1935 fn report_unknown_field(
1938 variant: &'tcx ty::VariantDef,
1939 field: &hir::ExprField<'_>,
1940 skip_fields: &[hir::ExprField<'_>],
1944 if variant.is_recovered() {
1945 self.set_tainted_by_errors();
1948 let mut err = self.type_error_struct_with_diag(
1950 |actual| match ty.kind() {
1951 ty::Adt(adt, ..) if adt.is_enum() => struct_span_err!(
1955 "{} `{}::{}` has no field named `{}`",
1961 _ => struct_span_err!(
1965 "{} `{}` has no field named `{}`",
1974 let variant_ident_span = self.tcx.def_ident_span(variant.def_id).unwrap();
1975 match variant.ctor_kind {
1976 CtorKind::Fn => match ty.kind() {
1977 ty::Adt(adt, ..) if adt.is_enum() => {
1981 "`{adt}::{variant}` defined here",
1983 variant = variant.name,
1986 err.span_label(field.ident.span, "field does not exist");
1987 err.span_suggestion_verbose(
1990 "`{adt}::{variant}` is a tuple {kind_name}, use the appropriate syntax",
1992 variant = variant.name,
1995 "{adt}::{variant}(/* fields */)",
1997 variant = variant.name,
1999 Applicability::HasPlaceholders,
2003 err.span_label(variant_ident_span, format!("`{adt}` defined here", adt = ty));
2004 err.span_label(field.ident.span, "field does not exist");
2005 err.span_suggestion_verbose(
2008 "`{adt}` is a tuple {kind_name}, use the appropriate syntax",
2010 kind_name = kind_name,
2012 format!("{adt}(/* fields */)", adt = ty),
2013 Applicability::HasPlaceholders,
2018 // prevent all specified fields from being suggested
2019 let skip_fields = skip_fields.iter().map(|x| x.ident.name);
2020 if let Some(field_name) = self.suggest_field_name(
2023 skip_fields.collect(),
2026 err.span_suggestion(
2028 "a field with a similar name exists",
2030 Applicability::MaybeIncorrect,
2034 ty::Adt(adt, ..) => {
2038 format!("`{}::{}` does not have this field", ty, variant.name),
2043 format!("`{ty}` does not have this field"),
2046 let available_field_names =
2047 self.available_field_names(variant, expr_span);
2048 if !available_field_names.is_empty() {
2050 "available fields are: {}",
2051 self.name_series_display(available_field_names)
2055 _ => bug!("non-ADT passed to report_unknown_field"),
2063 // Return a hint about the closest match in field names
2064 fn suggest_field_name(
2066 variant: &'tcx ty::VariantDef,
2069 // The span where stability will be checked
2071 ) -> Option<Symbol> {
2075 .filter_map(|field| {
2076 // ignore already set fields and private fields from non-local crates
2077 // and unstable fields.
2078 if skip.iter().any(|&x| x == field.name)
2079 || (!variant.def_id.is_local() && !field.vis.is_public())
2081 self.tcx.eval_stability(field.did, None, span, None),
2082 stability::EvalResult::Deny { .. }
2090 .collect::<Vec<Symbol>>();
2092 find_best_match_for_name(&names, field, None)
2095 fn available_field_names(
2097 variant: &'tcx ty::VariantDef,
2104 let def_scope = self
2106 .adjust_ident_and_get_scope(field.ident(self.tcx), variant.def_id, self.body_id)
2108 field.vis.is_accessible_from(def_scope, self.tcx)
2110 self.tcx.eval_stability(field.did, None, access_span, None),
2111 stability::EvalResult::Deny { .. }
2114 .filter(|field| !self.tcx.is_doc_hidden(field.did))
2115 .map(|field| field.name)
2119 fn name_series_display(&self, names: Vec<Symbol>) -> String {
2120 // dynamic limit, to never omit just one field
2121 let limit = if names.len() == 6 { 6 } else { 5 };
2123 names.iter().take(limit).map(|n| format!("`{}`", n)).collect::<Vec<_>>().join(", ");
2124 if names.len() > limit {
2125 display = format!("{} ... and {} others", display, names.len() - limit);
2130 // Check field access expressions
2133 expr: &'tcx hir::Expr<'tcx>,
2134 base: &'tcx hir::Expr<'tcx>,
2137 debug!("check_field(expr: {:?}, base: {:?}, field: {:?})", expr, base, field);
2138 let base_ty = self.check_expr(base);
2139 let base_ty = self.structurally_resolved_type(base.span, base_ty);
2140 let mut private_candidate = None;
2141 let mut autoderef = self.autoderef(expr.span, base_ty);
2142 while let Some((deref_base_ty, _)) = autoderef.next() {
2143 debug!("deref_base_ty: {:?}", deref_base_ty);
2144 match deref_base_ty.kind() {
2145 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2146 debug!("struct named {:?}", deref_base_ty);
2147 let (ident, def_scope) =
2148 self.tcx.adjust_ident_and_get_scope(field, base_def.did(), self.body_id);
2149 let fields = &base_def.non_enum_variant().fields;
2150 if let Some(index) = fields
2152 .position(|f| f.ident(self.tcx).normalize_to_macros_2_0() == ident)
2154 let field = &fields[index];
2155 let field_ty = self.field_ty(expr.span, field, substs);
2156 // Save the index of all fields regardless of their visibility in case
2157 // of error recovery.
2158 self.write_field_index(expr.hir_id, index);
2159 let adjustments = self.adjust_steps(&autoderef);
2160 if field.vis.is_accessible_from(def_scope, self.tcx) {
2161 self.apply_adjustments(base, adjustments);
2162 self.register_predicates(autoderef.into_obligations());
2164 self.tcx.check_stability(field.did, Some(expr.hir_id), expr.span, None);
2167 private_candidate = Some((adjustments, base_def.did(), field_ty));
2171 let fstr = field.as_str();
2172 if let Ok(index) = fstr.parse::<usize>() {
2173 if fstr == index.to_string() {
2174 if let Some(&field_ty) = tys.get(index) {
2175 let adjustments = self.adjust_steps(&autoderef);
2176 self.apply_adjustments(base, adjustments);
2177 self.register_predicates(autoderef.into_obligations());
2179 self.write_field_index(expr.hir_id, index);
2188 self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
2190 if let Some((adjustments, did, field_ty)) = private_candidate {
2191 // (#90483) apply adjustments to avoid ExprUseVisitor from
2192 // creating erroneous projection.
2193 self.apply_adjustments(base, adjustments);
2194 self.ban_private_field_access(expr, base_ty, field, did);
2198 if field.name == kw::Empty {
2199 } else if self.method_exists(field, base_ty, expr.hir_id, true) {
2200 self.ban_take_value_of_method(expr, base_ty, field);
2201 } else if !base_ty.is_primitive_ty() {
2202 self.ban_nonexisting_field(field, base, expr, base_ty);
2204 let field_name = field.to_string();
2205 let mut err = type_error_struct!(
2210 "`{base_ty}` is a primitive type and therefore doesn't have fields",
2212 let is_valid_suffix = |field: &str| {
2213 if field == "f32" || field == "f64" {
2216 let mut chars = field.chars().peekable();
2217 match chars.peek() {
2218 Some('e') | Some('E') => {
2220 if let Some(c) = chars.peek()
2221 && !c.is_numeric() && *c != '-' && *c != '+'
2225 while let Some(c) = chars.peek() {
2226 if !c.is_numeric() {
2234 let suffix = chars.collect::<String>();
2235 suffix.is_empty() || suffix == "f32" || suffix == "f64"
2237 let maybe_partial_suffix = |field: &str| -> Option<&str> {
2238 let first_chars = ['f', 'l'];
2240 && field.to_lowercase().starts_with(first_chars)
2241 && field[1..].chars().all(|c| c.is_ascii_digit())
2243 if field.to_lowercase().starts_with(['f']) { Some("f32") } else { Some("f64") }
2248 if let ty::Infer(ty::IntVar(_)) = base_ty.kind()
2249 && let ExprKind::Lit(Spanned {
2250 node: ast::LitKind::Int(_, ast::LitIntType::Unsuffixed),
2253 && !base.span.from_expansion()
2255 if is_valid_suffix(&field_name) {
2256 err.span_suggestion_verbose(
2257 field.span.shrink_to_lo(),
2258 "if intended to be a floating point literal, consider adding a `0` after the period",
2260 Applicability::MaybeIncorrect,
2262 } else if let Some(correct_suffix) = maybe_partial_suffix(&field_name) {
2263 err.span_suggestion_verbose(
2265 format!("if intended to be a floating point literal, consider adding a `0` after the period and a `{correct_suffix}` suffix"),
2266 format!("0{correct_suffix}"),
2267 Applicability::MaybeIncorrect,
2274 self.tcx().ty_error()
2277 fn suggest_await_on_field_access(
2279 err: &mut Diagnostic,
2281 base: &'tcx hir::Expr<'tcx>,
2284 let output_ty = match self.get_impl_future_output_ty(ty) {
2285 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
2288 let mut add_label = true;
2289 if let ty::Adt(def, _) = output_ty.skip_binder().kind() {
2290 // no field access on enum type
2296 .any(|field| field.ident(self.tcx) == field_ident)
2301 "field not available in `impl Future`, but it is available in its `Output`",
2303 err.span_suggestion_verbose(
2304 base.span.shrink_to_hi(),
2305 "consider `await`ing on the `Future` and access the field of its `Output`",
2307 Applicability::MaybeIncorrect,
2313 err.span_label(field_ident.span, &format!("field not found in `{ty}`"));
2317 fn ban_nonexisting_field(
2320 base: &'tcx hir::Expr<'tcx>,
2321 expr: &'tcx hir::Expr<'tcx>,
2325 "ban_nonexisting_field: field={:?}, base={:?}, expr={:?}, base_ty={:?}",
2326 ident, base, expr, base_ty
2328 let mut err = self.no_such_field_err(ident, base_ty, base.hir_id);
2330 match *base_ty.peel_refs().kind() {
2331 ty::Array(_, len) => {
2332 self.maybe_suggest_array_indexing(&mut err, expr, base, ident, len);
2335 self.suggest_first_deref_field(&mut err, expr, base, ident);
2337 ty::Adt(def, _) if !def.is_enum() => {
2338 self.suggest_fields_on_recordish(&mut err, def, ident, expr.span);
2340 ty::Param(param_ty) => {
2341 self.point_at_param_definition(&mut err, param_ty);
2343 ty::Opaque(_, _) => {
2344 self.suggest_await_on_field_access(&mut err, ident, base, base_ty.peel_refs());
2349 self.suggest_fn_call(&mut err, base, base_ty, |output_ty| {
2350 if let ty::Adt(def, _) = output_ty.kind() && !def.is_enum() {
2351 def.non_enum_variant().fields.iter().any(|field| {
2352 field.ident(self.tcx) == ident
2353 && field.vis.is_accessible_from(expr.hir_id.owner.to_def_id(), self.tcx)
2355 } else if let ty::Tuple(tys) = output_ty.kind()
2356 && let Ok(idx) = ident.as_str().parse::<usize>()
2364 if ident.name == kw::Await {
2365 // We know by construction that `<expr>.await` is either on Rust 2015
2366 // or results in `ExprKind::Await`. Suggest switching the edition to 2018.
2367 err.note("to `.await` a `Future`, switch to Rust 2018 or later");
2368 err.help_use_latest_edition();
2374 fn ban_private_field_access(
2376 expr: &hir::Expr<'_>,
2381 let struct_path = self.tcx().def_path_str(base_did);
2382 let kind_name = self.tcx().def_kind(base_did).descr(base_did);
2383 let mut err = struct_span_err!(
2387 "field `{field}` of {kind_name} `{struct_path}` is private",
2389 err.span_label(field.span, "private field");
2390 // Also check if an accessible method exists, which is often what is meant.
2391 if self.method_exists(field, expr_t, expr.hir_id, false) && !self.expr_in_place(expr.hir_id)
2393 self.suggest_method_call(
2395 &format!("a method `{field}` also exists, call it with parentheses"),
2405 fn ban_take_value_of_method(&self, expr: &hir::Expr<'_>, expr_t: Ty<'tcx>, field: Ident) {
2406 let mut err = type_error_struct!(
2411 "attempted to take value of method `{field}` on type `{expr_t}`",
2413 err.span_label(field.span, "method, not a field");
2415 if let hir::Node::Expr(hir::Expr { kind: ExprKind::Call(callee, _args), .. }) =
2416 self.tcx.hir().get(self.tcx.hir().get_parent_node(expr.hir_id))
2418 expr.hir_id == callee.hir_id
2423 self.tcx.sess.source_map().span_to_snippet(expr.span).unwrap_or_default();
2424 let is_wrapped = expr_snippet.starts_with('(') && expr_snippet.ends_with(')');
2425 let after_open = expr.span.lo() + rustc_span::BytePos(1);
2426 let before_close = expr.span.hi() - rustc_span::BytePos(1);
2428 if expr_is_call && is_wrapped {
2429 err.multipart_suggestion(
2430 "remove wrapping parentheses to call the method",
2432 (expr.span.with_hi(after_open), String::new()),
2433 (expr.span.with_lo(before_close), String::new()),
2435 Applicability::MachineApplicable,
2437 } else if !self.expr_in_place(expr.hir_id) {
2438 // Suggest call parentheses inside the wrapping parentheses
2439 let span = if is_wrapped {
2440 expr.span.with_lo(after_open).with_hi(before_close)
2444 self.suggest_method_call(
2446 "use parentheses to call the method",
2452 } else if let ty::RawPtr(ty_and_mut) = expr_t.kind()
2453 && let ty::Adt(adt_def, _) = ty_and_mut.ty.kind()
2454 && let ExprKind::Field(base_expr, _) = expr.kind
2455 && adt_def.variants().len() == 1
2463 .any(|f| f.ident(self.tcx) == field)
2465 err.multipart_suggestion(
2466 "to access the field, dereference first",
2468 (base_expr.span.shrink_to_lo(), "(*".to_string()),
2469 (base_expr.span.shrink_to_hi(), ")".to_string()),
2471 Applicability::MaybeIncorrect,
2474 err.help("methods are immutable and cannot be assigned to");
2480 fn point_at_param_definition(&self, err: &mut Diagnostic, param: ty::ParamTy) {
2481 let generics = self.tcx.generics_of(self.body_id.owner.to_def_id());
2482 let generic_param = generics.type_param(¶m, self.tcx);
2483 if let ty::GenericParamDefKind::Type { synthetic: true, .. } = generic_param.kind {
2486 let param_def_id = generic_param.def_id;
2487 let param_hir_id = match param_def_id.as_local() {
2488 Some(x) => self.tcx.hir().local_def_id_to_hir_id(x),
2491 let param_span = self.tcx.hir().span(param_hir_id);
2492 let param_name = self.tcx.hir().ty_param_name(param_def_id.expect_local());
2494 err.span_label(param_span, &format!("type parameter '{param_name}' declared here"));
2497 fn suggest_fields_on_recordish(
2499 err: &mut Diagnostic,
2500 def: ty::AdtDef<'tcx>,
2504 if let Some(suggested_field_name) =
2505 self.suggest_field_name(def.non_enum_variant(), field.name, vec![], access_span)
2507 err.span_suggestion(
2509 "a field with a similar name exists",
2510 suggested_field_name,
2511 Applicability::MaybeIncorrect,
2514 err.span_label(field.span, "unknown field");
2515 let struct_variant_def = def.non_enum_variant();
2516 let field_names = self.available_field_names(struct_variant_def, access_span);
2517 if !field_names.is_empty() {
2519 "available fields are: {}",
2520 self.name_series_display(field_names),
2526 fn maybe_suggest_array_indexing(
2528 err: &mut Diagnostic,
2529 expr: &hir::Expr<'_>,
2530 base: &hir::Expr<'_>,
2532 len: ty::Const<'tcx>,
2534 if let (Some(len), Ok(user_index)) =
2535 (len.try_eval_usize(self.tcx, self.param_env), field.as_str().parse::<u64>())
2536 && let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
2538 let help = "instead of using tuple indexing, use array indexing";
2539 let suggestion = format!("{base}[{field}]");
2540 let applicability = if len < user_index {
2541 Applicability::MachineApplicable
2543 Applicability::MaybeIncorrect
2545 err.span_suggestion(expr.span, help, suggestion, applicability);
2549 fn suggest_first_deref_field(
2551 err: &mut Diagnostic,
2552 expr: &hir::Expr<'_>,
2553 base: &hir::Expr<'_>,
2556 if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span) {
2557 let msg = format!("`{base}` is a raw pointer; try dereferencing it");
2558 let suggestion = format!("(*{base}).{field}");
2559 err.span_suggestion(expr.span, &msg, suggestion, Applicability::MaybeIncorrect);
2563 fn no_such_field_err(
2568 ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
2569 let span = field.span;
2570 debug!("no_such_field_err(span: {:?}, field: {:?}, expr_t: {:?})", span, field, expr_t);
2572 let mut err = type_error_struct!(
2577 "no field `{field}` on type `{expr_t}`",
2580 // try to add a suggestion in case the field is a nested field of a field of the Adt
2581 let mod_id = self.tcx.parent_module(id).to_def_id();
2582 if let Some((fields, substs)) =
2583 self.get_field_candidates_considering_privacy(span, expr_t, mod_id)
2585 let candidate_fields: Vec<_> = fields
2586 .filter_map(|candidate_field| {
2587 self.check_for_nested_field_satisfying(
2589 &|candidate_field, _| candidate_field.ident(self.tcx()) == field,
2596 .map(|mut field_path| {
2600 .map(|id| id.name.to_ident_string())
2601 .collect::<Vec<String>>()
2604 .collect::<Vec<_>>();
2606 let len = candidate_fields.len();
2608 err.span_suggestions(
2609 field.span.shrink_to_lo(),
2611 "{} of the expressions' fields {} a field of the same name",
2612 if len > 1 { "some" } else { "one" },
2613 if len > 1 { "have" } else { "has" },
2615 candidate_fields.iter().map(|path| format!("{path}.")),
2616 Applicability::MaybeIncorrect,
2623 pub(crate) fn get_field_candidates_considering_privacy(
2628 ) -> Option<(impl Iterator<Item = &'tcx ty::FieldDef> + 'tcx, SubstsRef<'tcx>)> {
2629 debug!("get_field_candidates(span: {:?}, base_t: {:?}", span, base_ty);
2631 for (base_t, _) in self.autoderef(span, base_ty) {
2632 match base_t.kind() {
2633 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2635 let fields = &base_def.non_enum_variant().fields;
2636 // Some struct, e.g. some that impl `Deref`, have all private fields
2637 // because you're expected to deref them to access the _real_ fields.
2638 // This, for example, will help us suggest accessing a field through a `Box<T>`.
2639 if fields.iter().all(|field| !field.vis.is_accessible_from(mod_id, tcx)) {
2645 .filter(move |field| field.vis.is_accessible_from(mod_id, tcx))
2646 // For compile-time reasons put a limit on number of fields we search
2657 /// This method is called after we have encountered a missing field error to recursively
2658 /// search for the field
2659 pub(crate) fn check_for_nested_field_satisfying(
2662 matches: &impl Fn(&ty::FieldDef, Ty<'tcx>) -> bool,
2663 candidate_field: &ty::FieldDef,
2664 subst: SubstsRef<'tcx>,
2665 mut field_path: Vec<Ident>,
2667 ) -> Option<Vec<Ident>> {
2669 "check_for_nested_field_satisfying(span: {:?}, candidate_field: {:?}, field_path: {:?}",
2670 span, candidate_field, field_path
2673 if field_path.len() > 3 {
2674 // For compile-time reasons and to avoid infinite recursion we only check for fields
2675 // up to a depth of three
2678 field_path.push(candidate_field.ident(self.tcx).normalize_to_macros_2_0());
2679 let field_ty = candidate_field.ty(self.tcx, subst);
2680 if matches(candidate_field, field_ty) {
2681 return Some(field_path);
2682 } else if let Some((nested_fields, subst)) =
2683 self.get_field_candidates_considering_privacy(span, field_ty, mod_id)
2685 // recursively search fields of `candidate_field` if it's a ty::Adt
2686 for field in nested_fields {
2687 if let Some(field_path) = self.check_for_nested_field_satisfying(
2695 return Some(field_path);
2703 fn check_expr_index(
2705 base: &'tcx hir::Expr<'tcx>,
2706 idx: &'tcx hir::Expr<'tcx>,
2707 expr: &'tcx hir::Expr<'tcx>,
2709 let base_t = self.check_expr(&base);
2710 let idx_t = self.check_expr(&idx);
2712 if base_t.references_error() {
2714 } else if idx_t.references_error() {
2717 let base_t = self.structurally_resolved_type(base.span, base_t);
2718 match self.lookup_indexing(expr, base, base_t, idx, idx_t) {
2719 Some((index_ty, element_ty)) => {
2720 // two-phase not needed because index_ty is never mutable
2721 self.demand_coerce(idx, idx_t, index_ty, None, AllowTwoPhase::No);
2722 self.select_obligations_where_possible(false, |errors| {
2723 self.point_at_index_if_possible(errors, idx.span)
2728 let mut err = type_error_struct!(
2733 "cannot index into a value of type `{base_t}`",
2735 // Try to give some advice about indexing tuples.
2736 if let ty::Tuple(..) = base_t.kind() {
2737 let mut needs_note = true;
2738 // If the index is an integer, we can show the actual
2739 // fixed expression:
2740 if let ExprKind::Lit(ref lit) = idx.kind {
2741 if let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node {
2742 let snip = self.tcx.sess.source_map().span_to_snippet(base.span);
2743 if let Ok(snip) = snip {
2744 err.span_suggestion(
2746 "to access tuple elements, use",
2747 format!("{snip}.{i}"),
2748 Applicability::MachineApplicable,
2756 "to access tuple elements, use tuple indexing \
2757 syntax (e.g., `tuple.0`)",
2768 fn point_at_index_if_possible(
2770 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
2773 for error in errors {
2774 match error.obligation.predicate.kind().skip_binder() {
2775 ty::PredicateKind::Trait(predicate)
2776 if self.tcx.is_diagnostic_item(sym::SliceIndex, predicate.trait_ref.def_id) => {
2780 error.obligation.cause.span = span;
2784 fn check_expr_yield(
2786 value: &'tcx hir::Expr<'tcx>,
2787 expr: &'tcx hir::Expr<'tcx>,
2788 src: &'tcx hir::YieldSource,
2790 match self.resume_yield_tys {
2791 Some((resume_ty, yield_ty)) => {
2792 self.check_expr_coercable_to_type(&value, yield_ty, None);
2796 // Given that this `yield` expression was generated as a result of lowering a `.await`,
2797 // we know that the yield type must be `()`; however, the context won't contain this
2798 // information. Hence, we check the source of the yield expression here and check its
2799 // value's type against `()` (this check should always hold).
2800 None if src.is_await() => {
2801 self.check_expr_coercable_to_type(&value, self.tcx.mk_unit(), None);
2805 self.tcx.sess.emit_err(YieldExprOutsideOfGenerator { span: expr.span });
2806 // Avoid expressions without types during writeback (#78653).
2807 self.check_expr(value);
2813 fn check_expr_asm_operand(&self, expr: &'tcx hir::Expr<'tcx>, is_input: bool) {
2814 let needs = if is_input { Needs::None } else { Needs::MutPlace };
2815 let ty = self.check_expr_with_needs(expr, needs);
2816 self.require_type_is_sized(ty, expr.span, traits::InlineAsmSized);
2818 if !is_input && !expr.is_syntactic_place_expr() {
2819 let mut err = self.tcx.sess.struct_span_err(expr.span, "invalid asm output");
2820 err.span_label(expr.span, "cannot assign to this expression");
2824 // If this is an input value, we require its type to be fully resolved
2825 // at this point. This allows us to provide helpful coercions which help
2826 // pass the type candidate list in a later pass.
2828 // We don't require output types to be resolved at this point, which
2829 // allows them to be inferred based on how they are used later in the
2832 let ty = self.structurally_resolved_type(expr.span, ty);
2835 let fnptr_ty = self.tcx.mk_fn_ptr(ty.fn_sig(self.tcx));
2836 self.demand_coerce(expr, ty, fnptr_ty, None, AllowTwoPhase::No);
2838 ty::Ref(_, base_ty, mutbl) => {
2839 let ptr_ty = self.tcx.mk_ptr(ty::TypeAndMut { ty: base_ty, mutbl });
2840 self.demand_coerce(expr, ty, ptr_ty, None, AllowTwoPhase::No);
2847 fn check_expr_asm(&self, asm: &'tcx hir::InlineAsm<'tcx>) -> Ty<'tcx> {
2848 for (op, _op_sp) in asm.operands {
2850 hir::InlineAsmOperand::In { expr, .. } => {
2851 self.check_expr_asm_operand(expr, true);
2853 hir::InlineAsmOperand::Out { expr: Some(expr), .. }
2854 | hir::InlineAsmOperand::InOut { expr, .. } => {
2855 self.check_expr_asm_operand(expr, false);
2857 hir::InlineAsmOperand::Out { expr: None, .. } => {}
2858 hir::InlineAsmOperand::SplitInOut { in_expr, out_expr, .. } => {
2859 self.check_expr_asm_operand(in_expr, true);
2860 if let Some(out_expr) = out_expr {
2861 self.check_expr_asm_operand(out_expr, false);
2864 // `AnonConst`s have their own body and is type-checked separately.
2865 // As they don't flow into the type system we don't need them to
2867 hir::InlineAsmOperand::Const { .. } | hir::InlineAsmOperand::SymFn { .. } => {}
2868 hir::InlineAsmOperand::SymStatic { .. } => {}
2871 if asm.options.contains(ast::InlineAsmOptions::NORETURN) {
2872 self.tcx.types.never
2879 pub(super) fn ty_kind_suggestion(ty: Ty<'_>) -> Option<&'static str> {
2880 Some(match ty.kind() {
2883 ty::Int(_) | ty::Uint(_) => "42",
2884 ty::Float(_) => "3.14159",
2885 ty::Error(_) | ty::Never => return None,