1 use super::coercion::CoerceMany;
2 use super::compare_method::check_type_bounds;
3 use super::compare_method::{compare_const_impl, compare_impl_method, compare_ty_impl};
6 use rustc_attr as attr;
7 use rustc_errors::{Applicability, ErrorReported};
9 use rustc_hir::def_id::{DefId, LocalDefId};
10 use rustc_hir::intravisit::Visitor;
11 use rustc_hir::lang_items::LangItem;
12 use rustc_hir::{def::Res, ItemKind, Node, PathSegment};
13 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
14 use rustc_infer::infer::{RegionVariableOrigin, TyCtxtInferExt};
15 use rustc_middle::hir::nested_filter;
16 use rustc_middle::ty::fold::TypeFoldable;
17 use rustc_middle::ty::layout::MAX_SIMD_LANES;
18 use rustc_middle::ty::subst::GenericArgKind;
19 use rustc_middle::ty::util::{Discr, IntTypeExt};
20 use rustc_middle::ty::{self, OpaqueTypeKey, ParamEnv, RegionKind, Ty, TyCtxt};
21 use rustc_session::lint::builtin::{UNINHABITED_STATIC, UNSUPPORTED_CALLING_CONVENTIONS};
22 use rustc_span::symbol::sym;
23 use rustc_span::{self, MultiSpan, Span};
24 use rustc_target::spec::abi::Abi;
25 use rustc_trait_selection::traits;
26 use rustc_trait_selection::traits::error_reporting::InferCtxtExt as _;
27 use rustc_ty_utils::representability::{self, Representability};
30 use std::ops::ControlFlow;
32 pub fn check_wf_new(tcx: TyCtxt<'_>) {
33 let visit = wfcheck::CheckTypeWellFormedVisitor::new(tcx);
34 tcx.hir().par_visit_all_item_likes(&visit);
37 pub(super) fn check_abi(tcx: TyCtxt<'_>, hir_id: hir::HirId, span: Span, abi: Abi) {
38 match tcx.sess.target.is_abi_supported(abi) {
40 Some(false) => struct_span_err!(
44 "`{}` is not a supported ABI for the current target",
49 tcx.struct_span_lint_hir(UNSUPPORTED_CALLING_CONVENTIONS, hir_id, span, |lint| {
50 lint.build("use of calling convention not supported on this target").emit()
55 // This ABI is only allowed on function pointers
56 if abi == Abi::CCmseNonSecureCall {
61 "the `\"C-cmse-nonsecure-call\"` ABI is only allowed on function pointers"
67 /// Helper used for fns and closures. Does the grungy work of checking a function
68 /// body and returns the function context used for that purpose, since in the case of a fn item
69 /// there is still a bit more to do.
72 /// * inherited: other fields inherited from the enclosing fn (if any)
73 #[instrument(skip(inherited, body), level = "debug")]
74 pub(super) fn check_fn<'a, 'tcx>(
75 inherited: &'a Inherited<'a, 'tcx>,
76 param_env: ty::ParamEnv<'tcx>,
77 fn_sig: ty::FnSig<'tcx>,
78 decl: &'tcx hir::FnDecl<'tcx>,
80 body: &'tcx hir::Body<'tcx>,
81 can_be_generator: Option<hir::Movability>,
82 return_type_pre_known: bool,
83 ) -> (FnCtxt<'a, 'tcx>, Option<GeneratorTypes<'tcx>>) {
84 let mut fn_sig = fn_sig;
86 // Create the function context. This is either derived from scratch or,
87 // in the case of closures, based on the outer context.
88 let mut fcx = FnCtxt::new(inherited, param_env, body.value.hir_id);
89 fcx.ps.set(UnsafetyState::function(fn_sig.unsafety, fn_id));
90 fcx.return_type_pre_known = return_type_pre_known;
96 let declared_ret_ty = fn_sig.output();
99 fcx.instantiate_opaque_types_from_value(declared_ret_ty, decl.output.span());
100 debug!("check_fn: declared_ret_ty: {}, revealed_ret_ty: {}", declared_ret_ty, revealed_ret_ty);
101 fcx.ret_coercion = Some(RefCell::new(CoerceMany::new(revealed_ret_ty)));
102 fcx.ret_type_span = Some(decl.output.span());
103 if let ty::Opaque(..) = declared_ret_ty.kind() {
104 fcx.ret_coercion_impl_trait = Some(declared_ret_ty);
106 fn_sig = tcx.mk_fn_sig(
107 fn_sig.inputs().iter().cloned(),
114 let span = body.value.span;
116 fn_maybe_err(tcx, span, fn_sig.abi);
118 if fn_sig.abi == Abi::RustCall {
119 let expected_args = if let ImplicitSelfKind::None = decl.implicit_self { 1 } else { 2 };
122 let item = match tcx.hir().get(fn_id) {
123 Node::Item(hir::Item { kind: ItemKind::Fn(header, ..), .. }) => Some(header),
124 Node::ImplItem(hir::ImplItem {
125 kind: hir::ImplItemKind::Fn(header, ..), ..
127 Node::TraitItem(hir::TraitItem {
128 kind: hir::TraitItemKind::Fn(header, ..),
131 // Closures are RustCall, but they tuple their arguments, so shouldn't be checked
132 Node::Expr(hir::Expr { kind: hir::ExprKind::Closure(..), .. }) => None,
133 node => bug!("Item being checked wasn't a function/closure: {:?}", node),
136 if let Some(header) = item {
137 tcx.sess.span_err(header.span, "functions with the \"rust-call\" ABI must take a single non-self argument that is a tuple")
141 if fn_sig.inputs().len() != expected_args {
144 // FIXME(CraftSpider) Add a check on parameter expansion, so we don't just make the ICE happen later on
145 // This will probably require wide-scale changes to support a TupleKind obligation
146 // We can't resolve this without knowing the type of the param
147 if !matches!(fn_sig.inputs()[expected_args - 1].kind(), ty::Tuple(_) | ty::Param(_)) {
153 if body.generator_kind.is_some() && can_be_generator.is_some() {
155 .next_ty_var(TypeVariableOrigin { kind: TypeVariableOriginKind::TypeInference, span });
156 fcx.require_type_is_sized(yield_ty, span, traits::SizedYieldType);
158 // Resume type defaults to `()` if the generator has no argument.
159 let resume_ty = fn_sig.inputs().get(0).copied().unwrap_or_else(|| tcx.mk_unit());
161 fcx.resume_yield_tys = Some((resume_ty, yield_ty));
164 GatherLocalsVisitor::new(&fcx).visit_body(body);
166 // C-variadic fns also have a `VaList` input that's not listed in `fn_sig`
167 // (as it's created inside the body itself, not passed in from outside).
168 let maybe_va_list = if fn_sig.c_variadic {
169 let span = body.params.last().unwrap().span;
170 let va_list_did = tcx.require_lang_item(LangItem::VaList, Some(span));
171 let region = fcx.next_region_var(RegionVariableOrigin::MiscVariable(span));
173 Some(tcx.type_of(va_list_did).subst(tcx, &[region.into()]))
178 // Add formal parameters.
179 let inputs_hir = hir.fn_decl_by_hir_id(fn_id).map(|decl| &decl.inputs);
180 let inputs_fn = fn_sig.inputs().iter().copied();
181 for (idx, (param_ty, param)) in inputs_fn.chain(maybe_va_list).zip(body.params).enumerate() {
182 // Check the pattern.
183 let ty_span = try { inputs_hir?.get(idx)?.span };
184 fcx.check_pat_top(¶m.pat, param_ty, ty_span, false);
186 // Check that argument is Sized.
187 // The check for a non-trivial pattern is a hack to avoid duplicate warnings
188 // for simple cases like `fn foo(x: Trait)`,
189 // where we would error once on the parameter as a whole, and once on the binding `x`.
190 if param.pat.simple_ident().is_none() && !tcx.features().unsized_fn_params {
191 fcx.require_type_is_sized(param_ty, param.pat.span, traits::SizedArgumentType(ty_span));
194 fcx.write_ty(param.hir_id, param_ty);
197 inherited.typeck_results.borrow_mut().liberated_fn_sigs_mut().insert(fn_id, fn_sig);
199 fcx.in_tail_expr = true;
200 if let ty::Dynamic(..) = declared_ret_ty.kind() {
201 // FIXME: We need to verify that the return type is `Sized` after the return expression has
202 // been evaluated so that we have types available for all the nodes being returned, but that
203 // requires the coerced evaluated type to be stored. Moving `check_return_expr` before this
204 // causes unsized errors caused by the `declared_ret_ty` to point at the return expression,
205 // while keeping the current ordering we will ignore the tail expression's type because we
206 // don't know it yet. We can't do `check_expr_kind` while keeping `check_return_expr`
207 // because we will trigger "unreachable expression" lints unconditionally.
208 // Because of all of this, we perform a crude check to know whether the simplest `!Sized`
209 // case that a newcomer might make, returning a bare trait, and in that case we populate
210 // the tail expression's type so that the suggestion will be correct, but ignore all other
212 fcx.check_expr(&body.value);
213 fcx.require_type_is_sized(declared_ret_ty, decl.output.span(), traits::SizedReturnType);
215 fcx.require_type_is_sized(declared_ret_ty, decl.output.span(), traits::SizedReturnType);
216 fcx.check_return_expr(&body.value, false);
218 fcx.in_tail_expr = false;
220 // We insert the deferred_generator_interiors entry after visiting the body.
221 // This ensures that all nested generators appear before the entry of this generator.
222 // resolve_generator_interiors relies on this property.
223 let gen_ty = if let (Some(_), Some(gen_kind)) = (can_be_generator, body.generator_kind) {
225 .next_ty_var(TypeVariableOrigin { kind: TypeVariableOriginKind::MiscVariable, span });
226 fcx.deferred_generator_interiors.borrow_mut().push((body.id(), interior, gen_kind));
228 let (resume_ty, yield_ty) = fcx.resume_yield_tys.unwrap();
229 Some(GeneratorTypes {
233 movability: can_be_generator.unwrap(),
239 // Finalize the return check by taking the LUB of the return types
240 // we saw and assigning it to the expected return type. This isn't
241 // really expected to fail, since the coercions would have failed
242 // earlier when trying to find a LUB.
243 let coercion = fcx.ret_coercion.take().unwrap().into_inner();
244 let mut actual_return_ty = coercion.complete(&fcx);
245 debug!("actual_return_ty = {:?}", actual_return_ty);
246 if let ty::Dynamic(..) = declared_ret_ty.kind() {
247 // We have special-cased the case where the function is declared
248 // `-> dyn Foo` and we don't actually relate it to the
249 // `fcx.ret_coercion`, so just substitute a type variable.
251 fcx.next_ty_var(TypeVariableOrigin { kind: TypeVariableOriginKind::DynReturnFn, span });
252 debug!("actual_return_ty replaced with {:?}", actual_return_ty);
254 fcx.demand_suptype(span, revealed_ret_ty, actual_return_ty);
256 // Check that a function marked as `#[panic_handler]` has signature `fn(&PanicInfo) -> !`
257 if let Some(panic_impl_did) = tcx.lang_items().panic_impl() {
258 if panic_impl_did == hir.local_def_id(fn_id).to_def_id() {
259 if let Some(panic_info_did) = tcx.lang_items().panic_info() {
260 if *declared_ret_ty.kind() != ty::Never {
261 sess.span_err(decl.output.span(), "return type should be `!`");
264 let inputs = fn_sig.inputs();
265 let span = hir.span(fn_id);
266 if inputs.len() == 1 {
267 let arg_is_panic_info = match *inputs[0].kind() {
268 ty::Ref(region, ty, mutbl) => match *ty.kind() {
269 ty::Adt(ref adt, _) => {
270 adt.did == panic_info_did
271 && mutbl == hir::Mutability::Not
272 && *region != RegionKind::ReStatic
279 if !arg_is_panic_info {
280 sess.span_err(decl.inputs[0].span, "argument should be `&PanicInfo`");
283 if let Node::Item(item) = hir.get(fn_id) {
284 if let ItemKind::Fn(_, ref generics, _) = item.kind {
285 if !generics.params.is_empty() {
286 sess.span_err(span, "should have no type parameters");
291 let span = sess.source_map().guess_head_span(span);
292 sess.span_err(span, "function should have one argument");
295 sess.err("language item required, but not found: `panic_info`");
300 // Check that a function marked as `#[alloc_error_handler]` has signature `fn(Layout) -> !`
301 if let Some(alloc_error_handler_did) = tcx.lang_items().oom() {
302 if alloc_error_handler_did == hir.local_def_id(fn_id).to_def_id() {
303 if let Some(alloc_layout_did) = tcx.lang_items().alloc_layout() {
304 if *declared_ret_ty.kind() != ty::Never {
305 sess.span_err(decl.output.span(), "return type should be `!`");
308 let inputs = fn_sig.inputs();
309 let span = hir.span(fn_id);
310 if inputs.len() == 1 {
311 let arg_is_alloc_layout = match inputs[0].kind() {
312 ty::Adt(ref adt, _) => adt.did == alloc_layout_did,
316 if !arg_is_alloc_layout {
317 sess.span_err(decl.inputs[0].span, "argument should be `Layout`");
320 if let Node::Item(item) = hir.get(fn_id) {
321 if let ItemKind::Fn(_, ref generics, _) = item.kind {
322 if !generics.params.is_empty() {
325 "`#[alloc_error_handler]` function should have no type \
332 let span = sess.source_map().guess_head_span(span);
333 sess.span_err(span, "function should have one argument");
336 sess.err("language item required, but not found: `alloc_layout`");
344 fn check_struct(tcx: TyCtxt<'_>, def_id: LocalDefId, span: Span) {
345 let def = tcx.adt_def(def_id);
346 def.destructor(tcx); // force the destructor to be evaluated
347 check_representable(tcx, span, def_id);
350 check_simd(tcx, span, def_id);
353 check_transparent(tcx, span, def);
354 check_packed(tcx, span, def);
357 fn check_union(tcx: TyCtxt<'_>, def_id: LocalDefId, span: Span) {
358 let def = tcx.adt_def(def_id);
359 def.destructor(tcx); // force the destructor to be evaluated
360 check_representable(tcx, span, def_id);
361 check_transparent(tcx, span, def);
362 check_union_fields(tcx, span, def_id);
363 check_packed(tcx, span, def);
366 /// Check that the fields of the `union` do not need dropping.
367 fn check_union_fields(tcx: TyCtxt<'_>, span: Span, item_def_id: LocalDefId) -> bool {
368 let item_type = tcx.type_of(item_def_id);
369 if let ty::Adt(def, substs) = item_type.kind() {
370 assert!(def.is_union());
371 let fields = &def.non_enum_variant().fields;
372 let param_env = tcx.param_env(item_def_id);
373 for field in fields {
374 let field_ty = field.ty(tcx, substs);
375 if field_ty.needs_drop(tcx, param_env) {
376 let (field_span, ty_span) = match tcx.hir().get_if_local(field.did) {
377 // We are currently checking the type this field came from, so it must be local.
378 Some(Node::Field(field)) => (field.span, field.ty.span),
379 _ => unreachable!("mir field has to correspond to hir field"),
385 "unions may not contain fields that need dropping"
387 .multipart_suggestion_verbose(
388 "wrap the type with `std::mem::ManuallyDrop` and ensure it is manually dropped",
390 (ty_span.shrink_to_lo(), format!("std::mem::ManuallyDrop<")),
391 (ty_span.shrink_to_hi(), ">".into()),
393 Applicability::MaybeIncorrect,
400 span_bug!(span, "unions must be ty::Adt, but got {:?}", item_type.kind());
405 /// Check that a `static` is inhabited.
406 fn check_static_inhabited<'tcx>(tcx: TyCtxt<'tcx>, def_id: LocalDefId, span: Span) {
407 // Make sure statics are inhabited.
408 // Other parts of the compiler assume that there are no uninhabited places. In principle it
409 // would be enough to check this for `extern` statics, as statics with an initializer will
410 // have UB during initialization if they are uninhabited, but there also seems to be no good
411 // reason to allow any statics to be uninhabited.
412 let ty = tcx.type_of(def_id);
413 let layout = match tcx.layout_of(ParamEnv::reveal_all().and(ty)) {
416 // Generic statics are rejected, but we still reach this case.
417 tcx.sess.delay_span_bug(span, "generic static must be rejected");
421 if layout.abi.is_uninhabited() {
422 tcx.struct_span_lint_hir(
424 tcx.hir().local_def_id_to_hir_id(def_id),
427 lint.build("static of uninhabited type")
428 .note("uninhabited statics cannot be initialized, and any access would be an immediate error")
435 /// Checks that an opaque type does not contain cycles and does not use `Self` or `T::Foo`
436 /// projections that would result in "inheriting lifetimes".
437 pub(super) fn check_opaque<'tcx>(
440 substs: SubstsRef<'tcx>,
442 origin: &hir::OpaqueTyOrigin,
444 check_opaque_for_inheriting_lifetimes(tcx, def_id, span);
445 if tcx.type_of(def_id).references_error() {
448 if check_opaque_for_cycles(tcx, def_id, substs, span, origin).is_err() {
451 check_opaque_meets_bounds(tcx, def_id, substs, span, origin);
454 /// Checks that an opaque type does not use `Self` or `T::Foo` projections that would result
455 /// in "inheriting lifetimes".
456 #[instrument(level = "debug", skip(tcx, span))]
457 pub(super) fn check_opaque_for_inheriting_lifetimes<'tcx>(
462 let item = tcx.hir().expect_item(def_id);
463 debug!(?item, ?span);
465 struct FoundParentLifetime;
466 struct FindParentLifetimeVisitor<'tcx>(&'tcx ty::Generics);
467 impl<'tcx> ty::fold::TypeVisitor<'tcx> for FindParentLifetimeVisitor<'tcx> {
468 type BreakTy = FoundParentLifetime;
470 fn visit_region(&mut self, r: ty::Region<'tcx>) -> ControlFlow<Self::BreakTy> {
471 debug!("FindParentLifetimeVisitor: r={:?}", r);
472 if let RegionKind::ReEarlyBound(ty::EarlyBoundRegion { index, .. }) = r {
473 if *index < self.0.parent_count as u32 {
474 return ControlFlow::Break(FoundParentLifetime);
476 return ControlFlow::CONTINUE;
480 r.super_visit_with(self)
483 fn visit_const(&mut self, c: &'tcx ty::Const<'tcx>) -> ControlFlow<Self::BreakTy> {
484 if let ty::ConstKind::Unevaluated(..) = c.val {
485 // FIXME(#72219) We currently don't detect lifetimes within substs
486 // which would violate this check. Even though the particular substitution is not used
487 // within the const, this should still be fixed.
488 return ControlFlow::CONTINUE;
490 c.super_visit_with(self)
494 struct ProhibitOpaqueVisitor<'tcx> {
496 opaque_identity_ty: Ty<'tcx>,
497 generics: &'tcx ty::Generics,
498 selftys: Vec<(Span, Option<String>)>,
501 impl<'tcx> ty::fold::TypeVisitor<'tcx> for ProhibitOpaqueVisitor<'tcx> {
502 type BreakTy = Ty<'tcx>;
504 fn visit_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<Self::BreakTy> {
505 debug!("check_opaque_for_inheriting_lifetimes: (visit_ty) t={:?}", t);
506 if t == self.opaque_identity_ty {
507 ControlFlow::CONTINUE
509 t.super_visit_with(&mut FindParentLifetimeVisitor(self.generics))
510 .map_break(|FoundParentLifetime| t)
515 impl<'tcx> Visitor<'tcx> for ProhibitOpaqueVisitor<'tcx> {
516 type NestedFilter = nested_filter::OnlyBodies;
518 fn nested_visit_map(&mut self) -> Self::Map {
522 fn visit_ty(&mut self, arg: &'tcx hir::Ty<'tcx>) {
524 hir::TyKind::Path(hir::QPath::Resolved(None, path)) => match &path.segments {
525 [PathSegment { res: Some(Res::SelfTy(_, impl_ref)), .. }] => {
527 impl_ref.map(|(def_id, _)| self.tcx.def_path_str(def_id));
528 self.selftys.push((path.span, impl_ty_name));
534 hir::intravisit::walk_ty(self, arg);
538 if let ItemKind::OpaqueTy(hir::OpaqueTy { origin: hir::OpaqueTyOrigin::FnReturn(..), .. }) =
541 let mut visitor = ProhibitOpaqueVisitor {
542 opaque_identity_ty: tcx.mk_opaque(
544 InternalSubsts::identity_for_item(tcx, def_id.to_def_id()),
546 generics: tcx.generics_of(def_id),
550 let prohibit_opaque = tcx
551 .explicit_item_bounds(def_id)
553 .try_for_each(|(predicate, _)| predicate.visit_with(&mut visitor));
555 "check_opaque_for_inheriting_lifetimes: prohibit_opaque={:?}, visitor.opaque_identity_ty={:?}, visitor.generics={:?}",
556 prohibit_opaque, visitor.opaque_identity_ty, visitor.generics
559 if let Some(ty) = prohibit_opaque.break_value() {
560 visitor.visit_item(&item);
562 let mut err = struct_span_err!(
566 "`impl Trait` return type cannot contain a projection or `Self` that references lifetimes from \
570 for (span, name) in visitor.selftys {
573 "consider spelling out the type instead",
574 name.unwrap_or_else(|| format!("{:?}", ty)),
575 Applicability::MaybeIncorrect,
583 /// Checks that an opaque type does not contain cycles.
584 pub(super) fn check_opaque_for_cycles<'tcx>(
587 substs: SubstsRef<'tcx>,
589 origin: &hir::OpaqueTyOrigin,
590 ) -> Result<(), ErrorReported> {
591 if tcx.try_expand_impl_trait_type(def_id.to_def_id(), substs).is_err() {
593 hir::OpaqueTyOrigin::AsyncFn(..) => async_opaque_type_cycle_error(tcx, span),
594 _ => opaque_type_cycle_error(tcx, def_id, span),
602 /// Check that the concrete type behind `impl Trait` actually implements `Trait`.
604 /// This is mostly checked at the places that specify the opaque type, but we
605 /// check those cases in the `param_env` of that function, which may have
606 /// bounds not on this opaque type:
608 /// type X<T> = impl Clone
609 /// fn f<T: Clone>(t: T) -> X<T> {
613 /// Without this check the above code is incorrectly accepted: we would ICE if
614 /// some tried, for example, to clone an `Option<X<&mut ()>>`.
615 #[instrument(level = "debug", skip(tcx))]
616 fn check_opaque_meets_bounds<'tcx>(
619 substs: SubstsRef<'tcx>,
621 origin: &hir::OpaqueTyOrigin,
623 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
624 let defining_use_anchor = match *origin {
625 hir::OpaqueTyOrigin::FnReturn(did) | hir::OpaqueTyOrigin::AsyncFn(did) => did,
626 hir::OpaqueTyOrigin::TyAlias => def_id,
628 let param_env = tcx.param_env(defining_use_anchor);
630 tcx.infer_ctxt().with_opaque_type_inference(defining_use_anchor).enter(move |infcx| {
631 let inh = Inherited::new(infcx, def_id);
632 let infcx = &inh.infcx;
633 let opaque_ty = tcx.mk_opaque(def_id.to_def_id(), substs);
635 let misc_cause = traits::ObligationCause::misc(span, hir_id);
637 let _ = inh.register_infer_ok_obligations(
638 infcx.instantiate_opaque_types(hir_id, param_env, opaque_ty, span),
641 let opaque_type_map = infcx.inner.borrow().opaque_types.clone();
642 for (OpaqueTypeKey { def_id, substs }, opaque_defn) in opaque_type_map {
643 let hidden_type = tcx.type_of(def_id).subst(tcx, substs);
644 trace!(?hidden_type);
645 match infcx.at(&misc_cause, param_env).eq(opaque_defn.concrete_ty, hidden_type) {
646 Ok(infer_ok) => inh.register_infer_ok_obligations(infer_ok),
647 Err(ty_err) => tcx.sess.delay_span_bug(
650 "could not check bounds on revealed type `{}`:\n{}",
657 // Check that all obligations are satisfied by the implementation's
659 let errors = inh.fulfillment_cx.borrow_mut().select_all_or_error(&infcx);
660 if !errors.is_empty() {
661 infcx.report_fulfillment_errors(&errors, None, false);
665 // Checked when type checking the function containing them.
666 hir::OpaqueTyOrigin::FnReturn(..) | hir::OpaqueTyOrigin::AsyncFn(..) => return,
667 // Can have different predicates to their defining use
668 hir::OpaqueTyOrigin::TyAlias => {
669 // Finally, resolve all regions. This catches wily misuses of
670 // lifetime parameters.
671 let fcx = FnCtxt::new(&inh, param_env, hir_id);
672 fcx.regionck_item(hir_id, span, FxHashSet::default());
678 pub fn check_item_type<'tcx>(tcx: TyCtxt<'tcx>, it: &'tcx hir::Item<'tcx>) {
680 "check_item_type(it.def_id={:?}, it.name={})",
682 tcx.def_path_str(it.def_id.to_def_id())
684 let _indenter = indenter();
686 // Consts can play a role in type-checking, so they are included here.
687 hir::ItemKind::Static(..) => {
688 tcx.ensure().typeck(it.def_id);
689 maybe_check_static_with_link_section(tcx, it.def_id, it.span);
690 check_static_inhabited(tcx, it.def_id, it.span);
692 hir::ItemKind::Const(..) => {
693 tcx.ensure().typeck(it.def_id);
695 hir::ItemKind::Enum(ref enum_definition, _) => {
696 check_enum(tcx, it.span, &enum_definition.variants, it.def_id);
698 hir::ItemKind::Fn(..) => {} // entirely within check_item_body
699 hir::ItemKind::Impl(ref impl_) => {
700 debug!("ItemKind::Impl {} with id {:?}", it.ident, it.def_id);
701 if let Some(impl_trait_ref) = tcx.impl_trait_ref(it.def_id) {
702 check_impl_items_against_trait(
709 let trait_def_id = impl_trait_ref.def_id;
710 check_on_unimplemented(tcx, trait_def_id, it);
713 hir::ItemKind::Trait(_, _, _, _, ref items) => {
714 check_on_unimplemented(tcx, it.def_id.to_def_id(), it);
716 for item in items.iter() {
717 let item = tcx.hir().trait_item(item.id);
719 hir::TraitItemKind::Fn(ref sig, _) => {
720 let abi = sig.header.abi;
721 fn_maybe_err(tcx, item.ident.span, abi);
723 hir::TraitItemKind::Type(.., Some(default)) => {
724 let assoc_item = tcx.associated_item(item.def_id);
726 InternalSubsts::identity_for_item(tcx, it.def_id.to_def_id());
727 let _: Result<_, rustc_errors::ErrorReported> = check_type_bounds(
732 ty::TraitRef { def_id: it.def_id.to_def_id(), substs: trait_substs },
739 hir::ItemKind::Struct(..) => {
740 check_struct(tcx, it.def_id, it.span);
742 hir::ItemKind::Union(..) => {
743 check_union(tcx, it.def_id, it.span);
745 hir::ItemKind::OpaqueTy(hir::OpaqueTy { origin, .. }) => {
746 // HACK(jynelson): trying to infer the type of `impl trait` breaks documenting
747 // `async-std` (and `pub async fn` in general).
748 // Since rustdoc doesn't care about the concrete type behind `impl Trait`, just don't look at it!
749 // See https://github.com/rust-lang/rust/issues/75100
750 if !tcx.sess.opts.actually_rustdoc {
751 let substs = InternalSubsts::identity_for_item(tcx, it.def_id.to_def_id());
752 check_opaque(tcx, it.def_id, substs, it.span, &origin);
755 hir::ItemKind::TyAlias(..) => {
756 let pty_ty = tcx.type_of(it.def_id);
757 let generics = tcx.generics_of(it.def_id);
758 check_type_params_are_used(tcx, &generics, pty_ty);
760 hir::ItemKind::ForeignMod { abi, items } => {
761 check_abi(tcx, it.hir_id(), it.span, abi);
763 if abi == Abi::RustIntrinsic {
765 let item = tcx.hir().foreign_item(item.id);
766 intrinsic::check_intrinsic_type(tcx, item);
768 } else if abi == Abi::PlatformIntrinsic {
770 let item = tcx.hir().foreign_item(item.id);
771 intrinsic::check_platform_intrinsic_type(tcx, item);
775 let def_id = item.id.def_id;
776 let generics = tcx.generics_of(def_id);
777 let own_counts = generics.own_counts();
778 if generics.params.len() - own_counts.lifetimes != 0 {
779 let (kinds, kinds_pl, egs) = match (own_counts.types, own_counts.consts) {
780 (_, 0) => ("type", "types", Some("u32")),
781 // We don't specify an example value, because we can't generate
782 // a valid value for any type.
783 (0, _) => ("const", "consts", None),
784 _ => ("type or const", "types or consts", None),
790 "foreign items may not have {} parameters",
793 .span_label(item.span, &format!("can't have {} parameters", kinds))
795 // FIXME: once we start storing spans for type arguments, turn this
796 // into a suggestion.
798 "replace the {} parameters with concrete {}{}",
801 egs.map(|egs| format!(" like `{}`", egs)).unwrap_or_default(),
807 let item = tcx.hir().foreign_item(item.id);
809 hir::ForeignItemKind::Fn(ref fn_decl, _, _) => {
810 require_c_abi_if_c_variadic(tcx, fn_decl, abi, item.span);
812 hir::ForeignItemKind::Static(..) => {
813 check_static_inhabited(tcx, def_id, item.span);
820 _ => { /* nothing to do */ }
824 pub(super) fn check_on_unimplemented(tcx: TyCtxt<'_>, trait_def_id: DefId, item: &hir::Item<'_>) {
825 // an error would be reported if this fails.
826 let _ = traits::OnUnimplementedDirective::of_item(tcx, trait_def_id, item.def_id.to_def_id());
829 pub(super) fn check_specialization_validity<'tcx>(
831 trait_def: &ty::TraitDef,
832 trait_item: &ty::AssocItem,
834 impl_item: &hir::ImplItemRef,
836 let ancestors = match trait_def.ancestors(tcx, impl_id) {
837 Ok(ancestors) => ancestors,
840 let mut ancestor_impls = ancestors.skip(1).filter_map(|parent| {
841 if parent.is_from_trait() {
844 Some((parent, parent.item(tcx, trait_item.def_id)))
848 let opt_result = ancestor_impls.find_map(|(parent_impl, parent_item)| {
850 // Parent impl exists, and contains the parent item we're trying to specialize, but
851 // doesn't mark it `default`.
852 Some(parent_item) if traits::impl_item_is_final(tcx, &parent_item) => {
853 Some(Err(parent_impl.def_id()))
856 // Parent impl contains item and makes it specializable.
857 Some(_) => Some(Ok(())),
859 // Parent impl doesn't mention the item. This means it's inherited from the
860 // grandparent. In that case, if parent is a `default impl`, inherited items use the
861 // "defaultness" from the grandparent, else they are final.
863 if tcx.impl_defaultness(parent_impl.def_id()).is_default() {
866 Some(Err(parent_impl.def_id()))
872 // If `opt_result` is `None`, we have only encountered `default impl`s that don't contain the
873 // item. This is allowed, the item isn't actually getting specialized here.
874 let result = opt_result.unwrap_or(Ok(()));
876 if let Err(parent_impl) = result {
877 report_forbidden_specialization(tcx, impl_item, parent_impl);
881 fn check_impl_items_against_trait<'tcx>(
883 full_impl_span: Span,
885 impl_trait_ref: ty::TraitRef<'tcx>,
886 impl_item_refs: &[hir::ImplItemRef],
888 // If the trait reference itself is erroneous (so the compilation is going
889 // to fail), skip checking the items here -- the `impl_item` table in `tcx`
890 // isn't populated for such impls.
891 if impl_trait_ref.references_error() {
895 // Negative impls are not expected to have any items
896 match tcx.impl_polarity(impl_id) {
897 ty::ImplPolarity::Reservation | ty::ImplPolarity::Positive => {}
898 ty::ImplPolarity::Negative => {
899 if let [first_item_ref, ..] = impl_item_refs {
900 let first_item_span = tcx.hir().impl_item(first_item_ref.id).span;
905 "negative impls cannot have any items"
913 let trait_def = tcx.trait_def(impl_trait_ref.def_id);
915 for impl_item in impl_item_refs {
916 let ty_impl_item = tcx.associated_item(impl_item.id.def_id);
917 let ty_trait_item = if let Some(trait_item_id) = ty_impl_item.trait_item_def_id {
918 tcx.associated_item(trait_item_id)
920 // Checked in `associated_item`.
921 tcx.sess.delay_span_bug(impl_item.span, "missing associated item in trait");
924 let impl_item_full = tcx.hir().impl_item(impl_item.id);
925 match impl_item_full.kind {
926 hir::ImplItemKind::Const(..) => {
927 // Find associated const definition.
936 hir::ImplItemKind::Fn(..) => {
937 let opt_trait_span = tcx.hir().span_if_local(ty_trait_item.def_id);
947 hir::ImplItemKind::TyAlias(impl_ty) => {
948 let opt_trait_span = tcx.hir().span_if_local(ty_trait_item.def_id);
960 check_specialization_validity(
969 if let Ok(ancestors) = trait_def.ancestors(tcx, impl_id.to_def_id()) {
970 // Check for missing items from trait
971 let mut missing_items = Vec::new();
973 let mut must_implement_one_of: Option<&[Ident]> =
974 trait_def.must_implement_one_of.as_deref();
976 for &trait_item_id in tcx.associated_item_def_ids(impl_trait_ref.def_id) {
977 let is_implemented = ancestors
978 .leaf_def(tcx, trait_item_id)
979 .map_or(false, |node_item| node_item.item.defaultness.has_value());
981 if !is_implemented && tcx.impl_defaultness(impl_id).is_final() {
982 missing_items.push(tcx.associated_item(trait_item_id));
985 if let Some(required_items) = &must_implement_one_of {
986 // true if this item is specifically implemented in this impl
987 let is_implemented_here = ancestors
988 .leaf_def(tcx, trait_item_id)
989 .map_or(false, |node_item| !node_item.defining_node.is_from_trait());
991 if is_implemented_here {
992 let trait_item = tcx.associated_item(trait_item_id);
993 if required_items.contains(&trait_item.ident(tcx)) {
994 must_implement_one_of = None;
1000 if !missing_items.is_empty() {
1001 let impl_span = tcx.sess.source_map().guess_head_span(full_impl_span);
1002 missing_items_err(tcx, impl_span, &missing_items, full_impl_span);
1005 if let Some(missing_items) = must_implement_one_of {
1006 let impl_span = tcx.sess.source_map().guess_head_span(full_impl_span);
1008 .get_attrs(impl_trait_ref.def_id)
1010 .find(|attr| attr.has_name(sym::rustc_must_implement_one_of))
1011 .map(|attr| attr.span);
1013 missing_items_must_implement_one_of_err(tcx, impl_span, missing_items, attr_span);
1018 /// Checks whether a type can be represented in memory. In particular, it
1019 /// identifies types that contain themselves without indirection through a
1020 /// pointer, which would mean their size is unbounded.
1021 pub(super) fn check_representable(tcx: TyCtxt<'_>, sp: Span, item_def_id: LocalDefId) -> bool {
1022 let rty = tcx.type_of(item_def_id);
1024 // Check that it is possible to represent this type. This call identifies
1025 // (1) types that contain themselves and (2) types that contain a different
1026 // recursive type. It is only necessary to throw an error on those that
1027 // contain themselves. For case 2, there must be an inner type that will be
1028 // caught by case 1.
1029 match representability::ty_is_representable(tcx, rty, sp) {
1030 Representability::SelfRecursive(spans) => {
1031 recursive_type_with_infinite_size_error(tcx, item_def_id.to_def_id(), spans);
1034 Representability::Representable | Representability::ContainsRecursive => (),
1039 pub fn check_simd(tcx: TyCtxt<'_>, sp: Span, def_id: LocalDefId) {
1040 let t = tcx.type_of(def_id);
1041 if let ty::Adt(def, substs) = t.kind() {
1042 if def.is_struct() {
1043 let fields = &def.non_enum_variant().fields;
1044 if fields.is_empty() {
1045 struct_span_err!(tcx.sess, sp, E0075, "SIMD vector cannot be empty").emit();
1048 let e = fields[0].ty(tcx, substs);
1049 if !fields.iter().all(|f| f.ty(tcx, substs) == e) {
1050 struct_span_err!(tcx.sess, sp, E0076, "SIMD vector should be homogeneous")
1051 .span_label(sp, "SIMD elements must have the same type")
1056 let len = if let ty::Array(_ty, c) = e.kind() {
1057 c.try_eval_usize(tcx, tcx.param_env(def.did))
1059 Some(fields.len() as u64)
1061 if let Some(len) = len {
1063 struct_span_err!(tcx.sess, sp, E0075, "SIMD vector cannot be empty").emit();
1065 } else if len > MAX_SIMD_LANES {
1070 "SIMD vector cannot have more than {} elements",
1078 // Check that we use types valid for use in the lanes of a SIMD "vector register"
1079 // These are scalar types which directly match a "machine" type
1080 // Yes: Integers, floats, "thin" pointers
1081 // No: char, "fat" pointers, compound types
1083 ty::Param(_) => (), // pass struct<T>(T, T, T, T) through, let monomorphization catch errors
1084 ty::Int(_) | ty::Uint(_) | ty::Float(_) | ty::RawPtr(_) => (), // struct(u8, u8, u8, u8) is ok
1085 ty::Array(t, _) if matches!(t.kind(), ty::Param(_)) => (), // pass struct<T>([T; N]) through, let monomorphization catch errors
1089 ty::Int(_) | ty::Uint(_) | ty::Float(_) | ty::RawPtr(_)
1091 { /* struct([f32; 4]) is ok */ }
1097 "SIMD vector element type should be a \
1098 primitive scalar (integer/float/pointer) type"
1108 pub(super) fn check_packed(tcx: TyCtxt<'_>, sp: Span, def: &ty::AdtDef) {
1109 let repr = def.repr;
1111 for attr in tcx.get_attrs(def.did).iter() {
1112 for r in attr::find_repr_attrs(&tcx.sess, attr) {
1113 if let attr::ReprPacked(pack) = r {
1114 if let Some(repr_pack) = repr.pack {
1115 if pack as u64 != repr_pack.bytes() {
1120 "type has conflicting packed representation hints"
1128 if repr.align.is_some() {
1133 "type has conflicting packed and align representation hints"
1137 if let Some(def_spans) = check_packed_inner(tcx, def.did, &mut vec![]) {
1138 let mut err = struct_span_err!(
1142 "packed type cannot transitively contain a `#[repr(align)]` type"
1146 tcx.def_span(def_spans[0].0),
1148 "`{}` has a `#[repr(align)]` attribute",
1149 tcx.item_name(def_spans[0].0)
1153 if def_spans.len() > 2 {
1154 let mut first = true;
1155 for (adt_def, span) in def_spans.iter().skip(1).rev() {
1156 let ident = tcx.item_name(*adt_def);
1161 "`{}` contains a field of type `{}`",
1162 tcx.type_of(def.did),
1166 format!("...which contains a field of type `{}`", ident)
1179 pub(super) fn check_packed_inner(
1182 stack: &mut Vec<DefId>,
1183 ) -> Option<Vec<(DefId, Span)>> {
1184 if let ty::Adt(def, substs) = tcx.type_of(def_id).kind() {
1185 if def.is_struct() || def.is_union() {
1186 if def.repr.align.is_some() {
1187 return Some(vec![(def.did, DUMMY_SP)]);
1191 for field in &def.non_enum_variant().fields {
1192 if let ty::Adt(def, _) = field.ty(tcx, substs).kind() {
1193 if !stack.contains(&def.did) {
1194 if let Some(mut defs) = check_packed_inner(tcx, def.did, stack) {
1195 defs.push((def.did, field.ident(tcx).span));
1208 pub(super) fn check_transparent<'tcx>(tcx: TyCtxt<'tcx>, sp: Span, adt: &'tcx ty::AdtDef) {
1209 if !adt.repr.transparent() {
1212 let sp = tcx.sess.source_map().guess_head_span(sp);
1214 if adt.is_union() && !tcx.features().transparent_unions {
1216 &tcx.sess.parse_sess,
1217 sym::transparent_unions,
1219 "transparent unions are unstable",
1224 if adt.variants.len() != 1 {
1225 bad_variant_count(tcx, adt, sp, adt.did);
1226 if adt.variants.is_empty() {
1227 // Don't bother checking the fields. No variants (and thus no fields) exist.
1232 // For each field, figure out if it's known to be a ZST and align(1)
1233 let field_infos = adt.all_fields().map(|field| {
1234 let ty = field.ty(tcx, InternalSubsts::identity_for_item(tcx, field.did));
1235 let param_env = tcx.param_env(field.did);
1236 let layout = tcx.layout_of(param_env.and(ty));
1237 // We are currently checking the type this field came from, so it must be local
1238 let span = tcx.hir().span_if_local(field.did).unwrap();
1239 let zst = layout.map_or(false, |layout| layout.is_zst());
1240 let align1 = layout.map_or(false, |layout| layout.align.abi.bytes() == 1);
1244 let non_zst_fields =
1245 field_infos.clone().filter_map(|(span, zst, _align1)| if !zst { Some(span) } else { None });
1246 let non_zst_count = non_zst_fields.clone().count();
1247 if non_zst_count >= 2 {
1248 bad_non_zero_sized_fields(tcx, adt, non_zst_count, non_zst_fields, sp);
1250 for (span, zst, align1) in field_infos {
1256 "zero-sized field in transparent {} has alignment larger than 1",
1259 .span_label(span, "has alignment larger than 1")
1265 #[allow(trivial_numeric_casts)]
1266 fn check_enum<'tcx>(
1269 vs: &'tcx [hir::Variant<'tcx>],
1272 let def = tcx.adt_def(def_id);
1273 def.destructor(tcx); // force the destructor to be evaluated
1276 let attributes = tcx.get_attrs(def_id.to_def_id());
1277 if let Some(attr) = tcx.sess.find_by_name(&attributes, sym::repr) {
1282 "unsupported representation for zero-variant enum"
1284 .span_label(sp, "zero-variant enum")
1289 let repr_type_ty = def.repr.discr_type().to_ty(tcx);
1290 if repr_type_ty == tcx.types.i128 || repr_type_ty == tcx.types.u128 {
1291 if !tcx.features().repr128 {
1293 &tcx.sess.parse_sess,
1296 "repr with 128-bit type is unstable",
1303 if let Some(ref e) = v.disr_expr {
1304 tcx.ensure().typeck(tcx.hir().local_def_id(e.hir_id));
1308 if tcx.adt_def(def_id).repr.int.is_none() && tcx.features().arbitrary_enum_discriminant {
1309 let is_unit = |var: &hir::Variant<'_>| matches!(var.data, hir::VariantData::Unit(..));
1311 let has_disr = |var: &hir::Variant<'_>| var.disr_expr.is_some();
1312 let has_non_units = vs.iter().any(|var| !is_unit(var));
1313 let disr_units = vs.iter().any(|var| is_unit(&var) && has_disr(&var));
1314 let disr_non_unit = vs.iter().any(|var| !is_unit(&var) && has_disr(&var));
1316 if disr_non_unit || (disr_units && has_non_units) {
1318 struct_span_err!(tcx.sess, sp, E0732, "`#[repr(inttype)]` must be specified");
1323 let mut disr_vals: Vec<Discr<'tcx>> = Vec::with_capacity(vs.len());
1324 for ((_, discr), v) in iter::zip(def.discriminants(tcx), vs) {
1325 // Check for duplicate discriminant values
1326 if let Some(i) = disr_vals.iter().position(|&x| x.val == discr.val) {
1327 let variant_did = def.variants[VariantIdx::new(i)].def_id;
1328 let variant_i_hir_id = tcx.hir().local_def_id_to_hir_id(variant_did.expect_local());
1329 let variant_i = tcx.hir().expect_variant(variant_i_hir_id);
1330 let i_span = match variant_i.disr_expr {
1331 Some(ref expr) => tcx.hir().span(expr.hir_id),
1332 None => tcx.def_span(variant_did),
1334 let span = match v.disr_expr {
1335 Some(ref expr) => tcx.hir().span(expr.hir_id),
1338 let display_discr = display_discriminant_value(tcx, v, discr.val);
1339 let display_discr_i = display_discriminant_value(tcx, variant_i, disr_vals[i].val);
1344 "discriminant value `{}` already exists",
1347 .span_label(i_span, format!("first use of {}", display_discr_i))
1348 .span_label(span, format!("enum already has {}", display_discr))
1351 disr_vals.push(discr);
1354 check_representable(tcx, sp, def_id);
1355 check_transparent(tcx, sp, def);
1358 /// Format an enum discriminant value for use in a diagnostic message.
1359 fn display_discriminant_value<'tcx>(
1361 variant: &hir::Variant<'_>,
1364 if let Some(expr) = &variant.disr_expr {
1365 let body = &tcx.hir().body(expr.body).value;
1366 if let hir::ExprKind::Lit(lit) = &body.kind {
1367 if let rustc_ast::LitKind::Int(lit_value, _int_kind) = &lit.node {
1368 if evaluated != *lit_value {
1369 return format!("`{}` (overflowed from `{}`)", evaluated, lit_value);
1374 format!("`{}`", evaluated)
1377 pub(super) fn check_type_params_are_used<'tcx>(
1379 generics: &ty::Generics,
1382 debug!("check_type_params_are_used(generics={:?}, ty={:?})", generics, ty);
1384 assert_eq!(generics.parent, None);
1386 if generics.own_counts().types == 0 {
1390 let mut params_used = BitSet::new_empty(generics.params.len());
1392 if ty.references_error() {
1393 // If there is already another error, do not emit
1394 // an error for not using a type parameter.
1395 assert!(tcx.sess.has_errors());
1399 for leaf in ty.walk() {
1400 if let GenericArgKind::Type(leaf_ty) = leaf.unpack() {
1401 if let ty::Param(param) = leaf_ty.kind() {
1402 debug!("found use of ty param {:?}", param);
1403 params_used.insert(param.index);
1408 for param in &generics.params {
1409 if !params_used.contains(param.index) {
1410 if let ty::GenericParamDefKind::Type { .. } = param.kind {
1411 let span = tcx.def_span(param.def_id);
1416 "type parameter `{}` is unused",
1419 .span_label(span, "unused type parameter")
1426 pub(super) fn check_mod_item_types(tcx: TyCtxt<'_>, module_def_id: LocalDefId) {
1427 tcx.hir().visit_item_likes_in_module(module_def_id, &mut CheckItemTypesVisitor { tcx });
1430 pub(super) use wfcheck::check_item_well_formed;
1432 pub(super) use wfcheck::check_trait_item as check_trait_item_well_formed;
1434 pub(super) use wfcheck::check_impl_item as check_impl_item_well_formed;
1436 fn async_opaque_type_cycle_error(tcx: TyCtxt<'_>, span: Span) {
1437 struct_span_err!(tcx.sess, span, E0733, "recursion in an `async fn` requires boxing")
1438 .span_label(span, "recursive `async fn`")
1439 .note("a recursive `async fn` must be rewritten to return a boxed `dyn Future`")
1441 "consider using the `async_recursion` crate: https://crates.io/crates/async_recursion",
1446 /// Emit an error for recursive opaque types.
1448 /// If this is a return `impl Trait`, find the item's return expressions and point at them. For
1449 /// direct recursion this is enough, but for indirect recursion also point at the last intermediary
1452 /// If all the return expressions evaluate to `!`, then we explain that the error will go away
1453 /// after changing it. This can happen when a user uses `panic!()` or similar as a placeholder.
1454 fn opaque_type_cycle_error(tcx: TyCtxt<'_>, def_id: LocalDefId, span: Span) {
1455 let mut err = struct_span_err!(tcx.sess, span, E0720, "cannot resolve opaque type");
1457 let mut label = false;
1458 if let Some((def_id, visitor)) = get_owner_return_paths(tcx, def_id) {
1459 let typeck_results = tcx.typeck(def_id);
1463 .filter_map(|expr| typeck_results.node_type_opt(expr.hir_id))
1464 .all(|ty| matches!(ty.kind(), ty::Never))
1469 .filter(|expr| typeck_results.node_type_opt(expr.hir_id).is_some())
1470 .map(|expr| expr.span)
1471 .collect::<Vec<Span>>();
1472 let span_len = spans.len();
1474 err.span_label(spans[0], "this returned value is of `!` type");
1476 let mut multispan: MultiSpan = spans.clone().into();
1479 .push_span_label(span, "this returned value is of `!` type".to_string());
1481 err.span_note(multispan, "these returned values have a concrete \"never\" type");
1483 err.help("this error will resolve once the item's body returns a concrete type");
1485 let mut seen = FxHashSet::default();
1487 err.span_label(span, "recursive opaque type");
1489 for (sp, ty) in visitor
1492 .filter_map(|e| typeck_results.node_type_opt(e.hir_id).map(|t| (e.span, t)))
1493 .filter(|(_, ty)| !matches!(ty.kind(), ty::Never))
1495 struct OpaqueTypeCollector(Vec<DefId>);
1496 impl<'tcx> ty::fold::TypeVisitor<'tcx> for OpaqueTypeCollector {
1497 fn visit_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<Self::BreakTy> {
1499 ty::Opaque(def, _) => {
1501 ControlFlow::CONTINUE
1503 _ => t.super_visit_with(self),
1507 let mut visitor = OpaqueTypeCollector(vec![]);
1508 ty.visit_with(&mut visitor);
1509 for def_id in visitor.0 {
1510 let ty_span = tcx.def_span(def_id);
1511 if !seen.contains(&ty_span) {
1512 err.span_label(ty_span, &format!("returning this opaque type `{}`", ty));
1513 seen.insert(ty_span);
1515 err.span_label(sp, &format!("returning here with type `{}`", ty));
1521 err.span_label(span, "cannot resolve opaque type");