2 pub mod on_unimplemented;
6 FulfillmentError, FulfillmentErrorCode, MismatchedProjectionTypes, Obligation, ObligationCause,
7 ObligationCauseCode, OutputTypeParameterMismatch, Overflow, PredicateObligation,
8 SelectionContext, SelectionError, TraitNotObjectSafe,
10 use crate::infer::error_reporting::{TyCategory, TypeAnnotationNeeded as ErrorCode};
11 use crate::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
12 use crate::infer::{self, InferCtxt, TyCtxtInferExt};
13 use crate::traits::engine::TraitEngineExt as _;
14 use crate::traits::query::evaluate_obligation::InferCtxtExt as _;
15 use crate::traits::query::normalize::AtExt as _;
16 use crate::traits::specialize::to_pretty_impl_header;
17 use on_unimplemented::OnUnimplementedNote;
18 use on_unimplemented::TypeErrCtxtExt as _;
19 use rustc_data_structures::fx::{FxHashMap, FxIndexMap};
21 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, ErrorGuaranteed,
25 use rustc_hir::def::Namespace;
26 use rustc_hir::def_id::DefId;
27 use rustc_hir::intravisit::Visitor;
28 use rustc_hir::GenericParam;
31 use rustc_infer::infer::error_reporting::TypeErrCtxt;
32 use rustc_infer::infer::TypeTrace;
33 use rustc_infer::traits::TraitEngine;
34 use rustc_middle::traits::select::OverflowError;
35 use rustc_middle::ty::abstract_const::NotConstEvaluatable;
36 use rustc_middle::ty::error::ExpectedFound;
37 use rustc_middle::ty::fold::{TypeFolder, TypeSuperFoldable};
38 use rustc_middle::ty::print::{FmtPrinter, Print};
39 use rustc_middle::ty::{
40 self, SubtypePredicate, ToPolyTraitRef, ToPredicate, TraitRef, Ty, TyCtxt, TypeFoldable,
43 use rustc_session::Limit;
44 use rustc_span::def_id::LOCAL_CRATE;
45 use rustc_span::symbol::{kw, sym};
46 use rustc_span::{ExpnKind, Span, DUMMY_SP};
49 use std::ops::ControlFlow;
50 use suggestions::TypeErrCtxtExt as _;
52 pub use rustc_infer::traits::error_reporting::*;
54 // When outputting impl candidates, prefer showing those that are more similar.
56 // We also compare candidates after skipping lifetimes, which has a lower
57 // priority than exact matches.
58 #[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord)]
59 pub enum CandidateSimilarity {
60 Exact { ignoring_lifetimes: bool },
61 Fuzzy { ignoring_lifetimes: bool },
64 #[derive(Debug, Clone, Copy)]
65 pub struct ImplCandidate<'tcx> {
66 pub trait_ref: ty::TraitRef<'tcx>,
67 pub similarity: CandidateSimilarity,
70 pub trait InferCtxtExt<'tcx> {
71 /// Given some node representing a fn-like thing in the HIR map,
72 /// returns a span and `ArgKind` information that describes the
73 /// arguments it expects. This can be supplied to
74 /// `report_arg_count_mismatch`.
75 fn get_fn_like_arguments(&self, node: Node<'_>) -> Option<(Span, Vec<ArgKind>)>;
77 /// Reports an error when the number of arguments needed by a
78 /// trait match doesn't match the number that the expression
80 fn report_arg_count_mismatch(
83 found_span: Option<Span>,
84 expected_args: Vec<ArgKind>,
85 found_args: Vec<ArgKind>,
87 ) -> DiagnosticBuilder<'tcx, ErrorGuaranteed>;
89 /// Checks if the type implements one of `Fn`, `FnMut`, or `FnOnce`
90 /// in that order, and returns the generic type corresponding to the
91 /// argument of that trait (corresponding to the closure arguments).
92 fn type_implements_fn_trait(
94 param_env: ty::ParamEnv<'tcx>,
95 ty: ty::Binder<'tcx, Ty<'tcx>>,
96 constness: ty::BoundConstness,
97 polarity: ty::ImplPolarity,
98 ) -> Result<(ty::ClosureKind, ty::Binder<'tcx, Ty<'tcx>>), ()>;
101 pub trait TypeErrCtxtExt<'tcx> {
102 fn report_fulfillment_errors(
104 errors: &[FulfillmentError<'tcx>],
105 body_id: Option<hir::BodyId>,
106 ) -> ErrorGuaranteed;
108 fn report_overflow_error<T>(
110 obligation: &Obligation<'tcx, T>,
111 suggest_increasing_limit: bool,
116 + Print<'tcx, FmtPrinter<'tcx, 'tcx>, Output = FmtPrinter<'tcx, 'tcx>>,
117 <T as Print<'tcx, FmtPrinter<'tcx, 'tcx>>>::Error: std::fmt::Debug;
119 fn suggest_new_overflow_limit(&self, err: &mut Diagnostic);
121 fn report_overflow_error_cycle(&self, cycle: &[PredicateObligation<'tcx>]) -> !;
123 /// The `root_obligation` parameter should be the `root_obligation` field
124 /// from a `FulfillmentError`. If no `FulfillmentError` is available,
125 /// then it should be the same as `obligation`.
126 fn report_selection_error(
128 obligation: PredicateObligation<'tcx>,
129 root_obligation: &PredicateObligation<'tcx>,
130 error: &SelectionError<'tcx>,
134 impl<'tcx> InferCtxtExt<'tcx> for InferCtxt<'tcx> {
135 /// Given some node representing a fn-like thing in the HIR map,
136 /// returns a span and `ArgKind` information that describes the
137 /// arguments it expects. This can be supplied to
138 /// `report_arg_count_mismatch`.
139 fn get_fn_like_arguments(&self, node: Node<'_>) -> Option<(Span, Vec<ArgKind>)> {
140 let sm = self.tcx.sess.source_map();
141 let hir = self.tcx.hir();
143 Node::Expr(&hir::Expr {
144 kind: hir::ExprKind::Closure(&hir::Closure { body, fn_decl_span, .. }),
152 if let hir::Pat { kind: hir::PatKind::Tuple(ref args, _), span, .. } =
159 sm.span_to_snippet(pat.span)
161 .map(|snippet| (snippet, "_".to_owned()))
163 .collect::<Option<Vec<_>>>()?,
166 let name = sm.span_to_snippet(arg.pat.span).ok()?;
167 Some(ArgKind::Arg(name, "_".to_owned()))
170 .collect::<Option<Vec<ArgKind>>>()?,
172 Node::Item(&hir::Item { kind: hir::ItemKind::Fn(ref sig, ..), .. })
173 | Node::ImplItem(&hir::ImplItem { kind: hir::ImplItemKind::Fn(ref sig, _), .. })
174 | Node::TraitItem(&hir::TraitItem {
175 kind: hir::TraitItemKind::Fn(ref sig, _), ..
181 .map(|arg| match arg.kind {
182 hir::TyKind::Tup(ref tys) => ArgKind::Tuple(
184 vec![("_".to_owned(), "_".to_owned()); tys.len()],
186 _ => ArgKind::empty(),
188 .collect::<Vec<ArgKind>>(),
190 Node::Ctor(ref variant_data) => {
191 let span = variant_data.ctor_hir_id().map_or(DUMMY_SP, |id| hir.span(id));
192 (span, vec![ArgKind::empty(); variant_data.fields().len()])
194 _ => panic!("non-FnLike node found: {:?}", node),
198 /// Reports an error when the number of arguments needed by a
199 /// trait match doesn't match the number that the expression
201 fn report_arg_count_mismatch(
204 found_span: Option<Span>,
205 expected_args: Vec<ArgKind>,
206 found_args: Vec<ArgKind>,
208 ) -> DiagnosticBuilder<'tcx, ErrorGuaranteed> {
209 let kind = if is_closure { "closure" } else { "function" };
211 let args_str = |arguments: &[ArgKind], other: &[ArgKind]| {
212 let arg_length = arguments.len();
213 let distinct = matches!(other, &[ArgKind::Tuple(..)]);
214 match (arg_length, arguments.get(0)) {
215 (1, Some(&ArgKind::Tuple(_, ref fields))) => {
216 format!("a single {}-tuple as argument", fields.len())
221 if distinct && arg_length > 1 { "distinct " } else { "" },
222 pluralize!(arg_length)
227 let expected_str = args_str(&expected_args, &found_args);
228 let found_str = args_str(&found_args, &expected_args);
230 let mut err = struct_span_err!(
234 "{} is expected to take {}, but it takes {}",
240 err.span_label(span, format!("expected {} that takes {}", kind, expected_str));
242 if let Some(found_span) = found_span {
243 err.span_label(found_span, format!("takes {}", found_str));
246 // ^^^^^^^^-- def_span
250 let prefix_span = self.tcx.sess.source_map().span_until_non_whitespace(found_span);
254 if let Some(span) = found_span.trim_start(prefix_span) { span } else { found_span };
256 // Suggest to take and ignore the arguments with expected_args_length `_`s if
257 // found arguments is empty (assume the user just wants to ignore args in this case).
258 // For example, if `expected_args_length` is 2, suggest `|_, _|`.
259 if found_args.is_empty() && is_closure {
260 let underscores = vec!["_"; expected_args.len()].join(", ");
261 err.span_suggestion_verbose(
264 "consider changing the closure to take and ignore the expected argument{}",
265 pluralize!(expected_args.len())
267 format!("|{}|", underscores),
268 Applicability::MachineApplicable,
272 if let &[ArgKind::Tuple(_, ref fields)] = &found_args[..] {
273 if fields.len() == expected_args.len() {
276 .map(|(name, _)| name.to_owned())
277 .collect::<Vec<String>>()
279 err.span_suggestion_verbose(
281 "change the closure to take multiple arguments instead of a single tuple",
282 format!("|{}|", sugg),
283 Applicability::MachineApplicable,
287 if let &[ArgKind::Tuple(_, ref fields)] = &expected_args[..]
288 && fields.len() == found_args.len()
295 .map(|arg| match arg {
296 ArgKind::Arg(name, _) => name.to_owned(),
299 .collect::<Vec<String>>()
301 // add type annotations if available
302 if found_args.iter().any(|arg| match arg {
303 ArgKind::Arg(_, ty) => ty != "_",
310 .map(|(_, ty)| ty.to_owned())
311 .collect::<Vec<String>>()
318 err.span_suggestion_verbose(
320 "change the closure to accept a tuple instead of individual arguments",
322 Applicability::MachineApplicable,
330 fn type_implements_fn_trait(
332 param_env: ty::ParamEnv<'tcx>,
333 ty: ty::Binder<'tcx, Ty<'tcx>>,
334 constness: ty::BoundConstness,
335 polarity: ty::ImplPolarity,
336 ) -> Result<(ty::ClosureKind, ty::Binder<'tcx, Ty<'tcx>>), ()> {
337 self.commit_if_ok(|_| {
338 for trait_def_id in [
339 self.tcx.lang_items().fn_trait(),
340 self.tcx.lang_items().fn_mut_trait(),
341 self.tcx.lang_items().fn_once_trait(),
343 let Some(trait_def_id) = trait_def_id else { continue };
344 // Make a fresh inference variable so we can determine what the substitutions
346 let var = self.next_ty_var(TypeVariableOrigin {
348 kind: TypeVariableOriginKind::MiscVariable,
350 let substs = self.tcx.mk_substs_trait(ty.skip_binder(), &[var.into()]);
351 let obligation = Obligation::new(
353 ObligationCause::dummy(),
355 ty.rebind(ty::TraitPredicate {
356 trait_ref: ty::TraitRef::new(trait_def_id, substs),
361 let mut fulfill_cx = <dyn TraitEngine<'tcx>>::new_in_snapshot(self.tcx);
362 fulfill_cx.register_predicate_obligation(self, obligation);
363 if fulfill_cx.select_all_or_error(self).is_empty() {
365 ty::ClosureKind::from_def_id(self.tcx, trait_def_id)
366 .expect("expected to map DefId to ClosureKind"),
367 ty.rebind(self.resolve_vars_if_possible(var)),
376 impl<'tcx> TypeErrCtxtExt<'tcx> for TypeErrCtxt<'_, 'tcx> {
377 fn report_fulfillment_errors(
379 errors: &[FulfillmentError<'tcx>],
380 body_id: Option<hir::BodyId>,
381 ) -> ErrorGuaranteed {
383 struct ErrorDescriptor<'tcx> {
384 predicate: ty::Predicate<'tcx>,
385 index: Option<usize>, // None if this is an old error
388 let mut error_map: FxIndexMap<_, Vec<_>> = self
389 .reported_trait_errors
392 .map(|(&span, predicates)| {
397 .map(|&predicate| ErrorDescriptor { predicate, index: None })
403 for (index, error) in errors.iter().enumerate() {
404 // We want to ignore desugarings here: spans are equivalent even
405 // if one is the result of a desugaring and the other is not.
406 let mut span = error.obligation.cause.span;
407 let expn_data = span.ctxt().outer_expn_data();
408 if let ExpnKind::Desugaring(_) = expn_data.kind {
409 span = expn_data.call_site;
412 error_map.entry(span).or_default().push(ErrorDescriptor {
413 predicate: error.obligation.predicate,
417 self.reported_trait_errors
421 .push(error.obligation.predicate);
424 // We do this in 2 passes because we want to display errors in order, though
425 // maybe it *is* better to sort errors by span or something.
426 let mut is_suppressed = vec![false; errors.len()];
427 for (_, error_set) in error_map.iter() {
428 // We want to suppress "duplicate" errors with the same span.
429 for error in error_set {
430 if let Some(index) = error.index {
431 // Suppress errors that are either:
432 // 1) strictly implied by another error.
433 // 2) implied by an error with a smaller index.
434 for error2 in error_set {
435 if error2.index.map_or(false, |index2| is_suppressed[index2]) {
436 // Avoid errors being suppressed by already-suppressed
437 // errors, to prevent all errors from being suppressed
442 if self.error_implies(error2.predicate, error.predicate)
443 && !(error2.index >= error.index
444 && self.error_implies(error.predicate, error2.predicate))
446 info!("skipping {:?} (implied by {:?})", error, error2);
447 is_suppressed[index] = true;
455 for (error, suppressed) in iter::zip(errors, is_suppressed) {
457 self.report_fulfillment_error(error, body_id);
461 self.tcx.sess.delay_span_bug(DUMMY_SP, "expected fullfillment errors")
464 /// Reports that an overflow has occurred and halts compilation. We
465 /// halt compilation unconditionally because it is important that
466 /// overflows never be masked -- they basically represent computations
467 /// whose result could not be truly determined and thus we can't say
468 /// if the program type checks or not -- and they are unusual
469 /// occurrences in any case.
470 fn report_overflow_error<T>(
472 obligation: &Obligation<'tcx, T>,
473 suggest_increasing_limit: bool,
478 + Print<'tcx, FmtPrinter<'tcx, 'tcx>, Output = FmtPrinter<'tcx, 'tcx>>,
479 <T as Print<'tcx, FmtPrinter<'tcx, 'tcx>>>::Error: std::fmt::Debug,
481 let predicate = self.resolve_vars_if_possible(obligation.predicate.clone());
482 let mut pred_str = predicate.to_string();
483 if pred_str.len() > 50 {
484 // We don't need to save the type to a file, we will be talking about this type already
485 // in a separate note when we explain the obligation, so it will be available that way.
487 .print(FmtPrinter::new_with_limit(
490 rustc_session::Limit(6),
495 let mut err = struct_span_err!(
497 obligation.cause.span,
499 "overflow evaluating the requirement `{}`",
503 if suggest_increasing_limit {
504 self.suggest_new_overflow_limit(&mut err);
507 self.note_obligation_cause_code(
509 &obligation.predicate,
510 obligation.param_env,
511 obligation.cause.code(),
513 &mut Default::default(),
517 self.tcx.sess.abort_if_errors();
521 fn suggest_new_overflow_limit(&self, err: &mut Diagnostic) {
522 let suggested_limit = match self.tcx.recursion_limit() {
523 Limit(0) => Limit(2),
527 "consider increasing the recursion limit by adding a \
528 `#![recursion_limit = \"{}\"]` attribute to your crate (`{}`)",
530 self.tcx.crate_name(LOCAL_CRATE),
534 /// Reports that a cycle was detected which led to overflow and halts
535 /// compilation. This is equivalent to `report_overflow_error` except
536 /// that we can give a more helpful error message (and, in particular,
537 /// we do not suggest increasing the overflow limit, which is not
539 fn report_overflow_error_cycle(&self, cycle: &[PredicateObligation<'tcx>]) -> ! {
540 let cycle = self.resolve_vars_if_possible(cycle.to_owned());
541 assert!(!cycle.is_empty());
543 debug!(?cycle, "report_overflow_error_cycle");
545 // The 'deepest' obligation is most likely to have a useful
547 self.report_overflow_error(cycle.iter().max_by_key(|p| p.recursion_depth).unwrap(), false);
550 fn report_selection_error(
552 mut obligation: PredicateObligation<'tcx>,
553 root_obligation: &PredicateObligation<'tcx>,
554 error: &SelectionError<'tcx>,
556 self.set_tainted_by_errors();
558 let mut span = obligation.cause.span;
560 let mut err = match *error {
561 SelectionError::Unimplemented => {
562 // If this obligation was generated as a result of well-formedness checking, see if we
563 // can get a better error message by performing HIR-based well-formedness checking.
564 if let ObligationCauseCode::WellFormed(Some(wf_loc)) =
565 root_obligation.cause.code().peel_derives()
567 if let Some(cause) = self
569 .diagnostic_hir_wf_check((tcx.erase_regions(obligation.predicate), *wf_loc))
571 obligation.cause = cause.clone();
572 span = obligation.cause.span;
575 if let ObligationCauseCode::CompareImplItemObligation {
579 } = *obligation.cause.code()
581 self.report_extra_impl_obligation(
585 &format!("`{}`", obligation.predicate),
591 let bound_predicate = obligation.predicate.kind();
592 match bound_predicate.skip_binder() {
593 ty::PredicateKind::Trait(trait_predicate) => {
594 let trait_predicate = bound_predicate.rebind(trait_predicate);
595 let mut trait_predicate = self.resolve_vars_if_possible(trait_predicate);
597 trait_predicate.remap_constness_diag(obligation.param_env);
598 let predicate_is_const = ty::BoundConstness::ConstIfConst
599 == trait_predicate.skip_binder().constness;
601 if self.tcx.sess.has_errors().is_some()
602 && trait_predicate.references_error()
606 let trait_ref = trait_predicate.to_poly_trait_ref();
607 let (post_message, pre_message, type_def) = self
608 .get_parent_trait_ref(obligation.cause.code())
611 format!(" in `{}`", t),
612 format!("within `{}`, ", t),
613 s.map(|s| (format!("within this `{}`", t), s)),
616 .unwrap_or_default();
618 let OnUnimplementedNote {
624 } = self.on_unimplemented_note(trait_ref, &obligation);
625 let have_alt_message = message.is_some() || label.is_some();
626 let is_try_conversion = self.is_try_conversion(span, trait_ref.def_id());
628 Some(trait_ref.def_id()) == self.tcx.lang_items().unsize_trait();
629 let (message, note, append_const_msg) = if is_try_conversion {
632 "`?` couldn't convert the error to `{}`",
633 trait_ref.skip_binder().self_ty(),
636 "the question mark operation (`?`) implicitly performs a \
637 conversion on the error value using the `From` trait"
643 (message, note, append_const_msg)
646 let mut err = struct_span_err!(
652 .and_then(|cannot_do_this| {
653 match (predicate_is_const, append_const_msg) {
654 // do nothing if predicate is not const
655 (false, _) => Some(cannot_do_this),
656 // suggested using default post message
657 (true, Some(None)) => {
658 Some(format!("{cannot_do_this} in const contexts"))
660 // overridden post message
661 (true, Some(Some(post_message))) => {
662 Some(format!("{cannot_do_this}{post_message}"))
664 // fallback to generic message
665 (true, None) => None,
668 .unwrap_or_else(|| format!(
669 "the trait bound `{}` is not satisfied{}",
670 trait_predicate, post_message,
674 if is_try_conversion && let Some(ret_span) = self.return_type_span(&obligation) {
678 "expected `{}` because of this",
679 trait_ref.skip_binder().self_ty()
684 if Some(trait_ref.def_id()) == tcx.lang_items().tuple_trait() {
685 match obligation.cause.code().peel_derives() {
686 ObligationCauseCode::RustCall => {
687 err.set_primary_message("functions with the \"rust-call\" ABI must take a single non-self tuple argument");
689 ObligationCauseCode::BindingObligation(def_id, _)
690 | ObligationCauseCode::ItemObligation(def_id)
691 if ty::ClosureKind::from_def_id(tcx, *def_id).is_some() =>
693 err.code(rustc_errors::error_code!(E0059));
694 err.set_primary_message(format!(
695 "type parameter to bare `{}` trait must be a tuple",
696 tcx.def_path_str(*def_id)
703 if Some(trait_ref.def_id()) == tcx.lang_items().drop_trait()
704 && predicate_is_const
706 err.note("`~const Drop` was renamed to `~const Destruct`");
707 err.note("See <https://github.com/rust-lang/rust/pull/94901> for more details");
710 let explanation = if let ObligationCauseCode::MainFunctionType =
711 obligation.cause.code()
713 "consider using `()`, or a `Result`".to_owned()
715 let ty_desc = match trait_ref.skip_binder().self_ty().kind() {
716 ty::FnDef(_, _) => Some("fn item"),
717 ty::Closure(_, _) => Some("closure"),
722 Some(desc) => format!(
723 "{}the trait `{}` is not implemented for {} `{}`",
725 trait_predicate.print_modifiers_and_trait_path(),
727 trait_ref.skip_binder().self_ty(),
730 "{}the trait `{}` is not implemented for `{}`",
732 trait_predicate.print_modifiers_and_trait_path(),
733 trait_ref.skip_binder().self_ty(),
738 if self.suggest_add_reference_to_arg(
744 self.note_obligation_cause(&mut err, &obligation);
748 if let Some(ref s) = label {
749 // If it has a custom `#[rustc_on_unimplemented]`
750 // error message, let's display it as the label!
751 err.span_label(span, s);
752 if !matches!(trait_ref.skip_binder().self_ty().kind(), ty::Param(_)) {
753 // When the self type is a type param We don't need to "the trait
754 // `std::marker::Sized` is not implemented for `T`" as we will point
755 // at the type param with a label to suggest constraining it.
756 err.help(&explanation);
759 err.span_label(span, explanation);
762 if let ObligationCauseCode::ObjectCastObligation(concrete_ty, obj_ty) = obligation.cause.code().peel_derives() &&
763 Some(trait_ref.def_id()) == self.tcx.lang_items().sized_trait() {
764 self.suggest_borrowing_for_object_cast(&mut err, &root_obligation, *concrete_ty, *obj_ty);
767 let mut unsatisfied_const = false;
768 if trait_predicate.is_const_if_const() && obligation.param_env.is_const() {
769 let non_const_predicate = trait_ref.without_const();
770 let non_const_obligation = Obligation {
771 cause: obligation.cause.clone(),
772 param_env: obligation.param_env.without_const(),
773 predicate: non_const_predicate.to_predicate(tcx),
774 recursion_depth: obligation.recursion_depth,
776 if self.predicate_may_hold(&non_const_obligation) {
777 unsatisfied_const = true;
781 "the trait `{}` is implemented for `{}`, \
782 but that implementation is not `const`",
783 non_const_predicate.print_modifiers_and_trait_path(),
784 trait_ref.skip_binder().self_ty(),
790 if let Some((msg, span)) = type_def {
791 err.span_label(span, &msg);
793 if let Some(ref s) = note {
794 // If it has a custom `#[rustc_on_unimplemented]` note, let's display it
795 err.note(s.as_str());
797 if let Some(ref s) = parent_label {
800 .opt_local_def_id(obligation.cause.body_id)
802 tcx.hir().body_owner_def_id(hir::BodyId {
803 hir_id: obligation.cause.body_id,
806 err.span_label(tcx.def_span(body), s);
809 self.suggest_floating_point_literal(&obligation, &mut err, &trait_ref);
810 self.suggest_dereferencing_index(&obligation, &mut err, trait_predicate);
812 self.suggest_dereferences(&obligation, &mut err, trait_predicate);
813 suggested |= self.suggest_fn_call(&obligation, &mut err, trait_predicate);
815 self.suggest_remove_reference(&obligation, &mut err, trait_predicate);
816 suggested |= self.suggest_semicolon_removal(
822 self.note_version_mismatch(&mut err, &trait_ref);
823 self.suggest_remove_await(&obligation, &mut err);
824 self.suggest_derive(&obligation, &mut err, trait_predicate);
826 if Some(trait_ref.def_id()) == tcx.lang_items().try_trait() {
827 self.suggest_await_before_try(
835 if self.suggest_impl_trait(&mut err, span, &obligation, trait_predicate) {
841 // If the obligation failed due to a missing implementation of the
842 // `Unsize` trait, give a pointer to why that might be the case
844 "all implementations of `Unsize` are provided \
845 automatically by the compiler, see \
846 <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> \
847 for more information",
852 ty::ClosureKind::from_def_id(tcx, trait_ref.def_id()).is_some();
853 let is_target_feature_fn = if let ty::FnDef(def_id, _) =
854 *trait_ref.skip_binder().self_ty().kind()
856 !self.tcx.codegen_fn_attrs(def_id).target_features.is_empty()
860 if is_fn_trait && is_target_feature_fn {
862 "`#[target_feature]` functions do not implement the `Fn` traits",
866 // Try to report a help message
868 && let Ok((implemented_kind, params)) = self.type_implements_fn_trait(
869 obligation.param_env,
871 trait_predicate.skip_binder().constness,
872 trait_predicate.skip_binder().polarity,
875 // If the type implements `Fn`, `FnMut`, or `FnOnce`, suppress the following
876 // suggestion to add trait bounds for the type, since we only typically implement
877 // these traits once.
879 // Note if the `FnMut` or `FnOnce` is less general than the trait we're trying
882 ty::ClosureKind::from_def_id(self.tcx, trait_ref.def_id())
883 .expect("expected to map DefId to ClosureKind");
884 if !implemented_kind.extends(selected_kind) {
887 "`{}` implements `{}`, but it must implement `{}`, which is more general",
888 trait_ref.skip_binder().self_ty(),
895 // Note any argument mismatches
896 let given_ty = params.skip_binder();
897 let expected_ty = trait_ref.skip_binder().substs.type_at(1);
898 if let ty::Tuple(given) = given_ty.kind()
899 && let ty::Tuple(expected) = expected_ty.kind()
901 if expected.len() != given.len() {
902 // Note number of types that were expected and given
905 "expected a closure taking {} argument{}, but one taking {} argument{} was given",
907 pluralize!(given.len()),
909 pluralize!(expected.len()),
912 } else if !self.same_type_modulo_infer(given_ty, expected_ty) {
913 // Print type mismatch
914 let (expected_args, given_args) =
915 self.cmp(given_ty, expected_ty);
916 err.note_expected_found(
917 &"a closure with arguments",
919 &"a closure with arguments",
924 } else if !trait_ref.has_non_region_infer()
925 && self.predicate_can_apply(obligation.param_env, trait_predicate)
927 // If a where-clause may be useful, remind the
928 // user that they can add it.
930 // don't display an on-unimplemented note, as
931 // these notes will often be of the form
932 // "the type `T` can't be frobnicated"
933 // which is somewhat confusing.
934 self.suggest_restricting_param_bound(
938 obligation.cause.body_id,
940 } else if !suggested && !unsatisfied_const {
941 // Can't show anything else useful, try to find similar impls.
942 let impl_candidates = self.find_similar_impl_candidates(trait_predicate);
943 if !self.report_similar_impl_candidates(
946 obligation.cause.body_id,
949 // This is *almost* equivalent to
950 // `obligation.cause.code().peel_derives()`, but it gives us the
951 // trait predicate for that corresponding root obligation. This
952 // lets us get a derived obligation from a type parameter, like
953 // when calling `string.strip_suffix(p)` where `p` is *not* an
954 // implementer of `Pattern<'_>`.
955 let mut code = obligation.cause.code();
956 let mut trait_pred = trait_predicate;
957 let mut peeled = false;
958 while let Some((parent_code, parent_trait_pred)) = code.parent() {
960 if let Some(parent_trait_pred) = parent_trait_pred {
961 trait_pred = parent_trait_pred;
965 let def_id = trait_pred.def_id();
966 // Mention *all* the `impl`s for the *top most* obligation, the
967 // user might have meant to use one of them, if any found. We skip
968 // auto-traits or fundamental traits that might not be exactly what
969 // the user might expect to be presented with. Instead this is
970 // useful for less general traits.
972 && !self.tcx.trait_is_auto(def_id)
973 && !self.tcx.lang_items().iter().any(|(_, id)| id == def_id)
975 let trait_ref = trait_pred.to_poly_trait_ref();
976 let impl_candidates =
977 self.find_similar_impl_candidates(trait_pred);
978 self.report_similar_impl_candidates(
981 obligation.cause.body_id,
988 // Changing mutability doesn't make a difference to whether we have
989 // an `Unsize` impl (Fixes ICE in #71036)
991 self.suggest_change_mut(&obligation, &mut err, trait_predicate);
994 // If this error is due to `!: Trait` not implemented but `(): Trait` is
995 // implemented, and fallback has occurred, then it could be due to a
996 // variable that used to fallback to `()` now falling back to `!`. Issue a
997 // note informing about the change in behaviour.
998 if trait_predicate.skip_binder().self_ty().is_never()
999 && self.fallback_has_occurred
1001 let predicate = trait_predicate.map_bound(|mut trait_pred| {
1002 trait_pred.trait_ref.substs = self.tcx.mk_substs_trait(
1004 &trait_pred.trait_ref.substs[1..],
1008 let unit_obligation = obligation.with(tcx, predicate);
1009 if self.predicate_may_hold(&unit_obligation) {
1011 "this error might have been caused by changes to \
1012 Rust's type-inference algorithm (see issue #48950 \
1013 <https://github.com/rust-lang/rust/issues/48950> \
1014 for more information)",
1016 err.help("did you intend to use the type `()` here instead?");
1020 // Return early if the trait is Debug or Display and the invocation
1021 // originates within a standard library macro, because the output
1022 // is otherwise overwhelming and unhelpful (see #85844 for an
1026 match obligation.cause.span.ctxt().outer_expn_data().macro_def_id {
1027 Some(macro_def_id) => {
1028 let crate_name = tcx.crate_name(macro_def_id.krate);
1029 crate_name == sym::std || crate_name == sym::core
1036 self.tcx.get_diagnostic_name(trait_ref.def_id()),
1037 Some(sym::Debug | sym::Display)
1047 ty::PredicateKind::Subtype(predicate) => {
1048 // Errors for Subtype predicates show up as
1049 // `FulfillmentErrorCode::CodeSubtypeError`,
1050 // not selection error.
1051 span_bug!(span, "subtype requirement gave wrong error: `{:?}`", predicate)
1054 ty::PredicateKind::Coerce(predicate) => {
1055 // Errors for Coerce predicates show up as
1056 // `FulfillmentErrorCode::CodeSubtypeError`,
1057 // not selection error.
1058 span_bug!(span, "coerce requirement gave wrong error: `{:?}`", predicate)
1061 ty::PredicateKind::RegionOutlives(..)
1062 | ty::PredicateKind::Projection(..)
1063 | ty::PredicateKind::TypeOutlives(..) => {
1064 let predicate = self.resolve_vars_if_possible(obligation.predicate);
1069 "the requirement `{}` is not satisfied",
1074 ty::PredicateKind::ObjectSafe(trait_def_id) => {
1075 let violations = self.tcx.object_safety_violations(trait_def_id);
1076 report_object_safety_error(self.tcx, span, trait_def_id, violations)
1079 ty::PredicateKind::ClosureKind(closure_def_id, closure_substs, kind) => {
1080 let found_kind = self.closure_kind(closure_substs).unwrap();
1081 let closure_span = self.tcx.def_span(closure_def_id);
1082 let mut err = struct_span_err!(
1086 "expected a closure that implements the `{}` trait, \
1087 but this closure only implements `{}`",
1094 format!("this closure implements `{}`, not `{}`", found_kind, kind),
1097 obligation.cause.span,
1098 format!("the requirement to implement `{}` derives from here", kind),
1101 // Additional context information explaining why the closure only implements
1102 // a particular trait.
1103 if let Some(typeck_results) = &self.typeck_results {
1107 .local_def_id_to_hir_id(closure_def_id.expect_local());
1108 match (found_kind, typeck_results.closure_kind_origins().get(hir_id)) {
1109 (ty::ClosureKind::FnOnce, Some((span, place))) => {
1113 "closure is `FnOnce` because it moves the \
1114 variable `{}` out of its environment",
1115 ty::place_to_string_for_capture(tcx, place)
1119 (ty::ClosureKind::FnMut, Some((span, place))) => {
1123 "closure is `FnMut` because it mutates the \
1124 variable `{}` here",
1125 ty::place_to_string_for_capture(tcx, place)
1136 ty::PredicateKind::WellFormed(ty) => {
1137 if !self.tcx.sess.opts.unstable_opts.chalk {
1138 // WF predicates cannot themselves make
1139 // errors. They can only block due to
1140 // ambiguity; otherwise, they always
1141 // degenerate into other obligations
1142 // (which may fail).
1143 span_bug!(span, "WF predicate not satisfied for {:?}", ty);
1145 // FIXME: we'll need a better message which takes into account
1146 // which bounds actually failed to hold.
1147 self.tcx.sess.struct_span_err(
1149 &format!("the type `{}` is not well-formed (chalk)", ty),
1154 ty::PredicateKind::ConstEvaluatable(..) => {
1155 // Errors for `ConstEvaluatable` predicates show up as
1156 // `SelectionError::ConstEvalFailure`,
1157 // not `Unimplemented`.
1160 "const-evaluatable requirement gave wrong error: `{:?}`",
1165 ty::PredicateKind::ConstEquate(..) => {
1166 // Errors for `ConstEquate` predicates show up as
1167 // `SelectionError::ConstEvalFailure`,
1168 // not `Unimplemented`.
1171 "const-equate requirement gave wrong error: `{:?}`",
1176 ty::PredicateKind::TypeWellFormedFromEnv(..) => span_bug!(
1178 "TypeWellFormedFromEnv predicate should only exist in the environment"
1183 OutputTypeParameterMismatch(found_trait_ref, expected_trait_ref, _) => {
1184 let found_trait_ref = self.resolve_vars_if_possible(found_trait_ref);
1185 let expected_trait_ref = self.resolve_vars_if_possible(expected_trait_ref);
1187 if expected_trait_ref.self_ty().references_error() {
1191 let Some(found_trait_ty) = found_trait_ref.self_ty().no_bound_vars() else {
1195 let found_did = match *found_trait_ty.kind() {
1199 | ty::Generator(did, ..) => Some(did),
1200 ty::Adt(def, _) => Some(def.did()),
1204 let found_span = found_did.and_then(|did| self.tcx.hir().span_if_local(did));
1206 if self.reported_closure_mismatch.borrow().contains(&(span, found_span)) {
1207 // We check closures twice, with obligations flowing in different directions,
1208 // but we want to complain about them only once.
1212 self.reported_closure_mismatch.borrow_mut().insert((span, found_span));
1214 let mut not_tupled = false;
1216 let found = match found_trait_ref.skip_binder().substs.type_at(1).kind() {
1217 ty::Tuple(ref tys) => vec![ArgKind::empty(); tys.len()],
1220 vec![ArgKind::empty()]
1224 let expected_ty = expected_trait_ref.skip_binder().substs.type_at(1);
1225 let expected = match expected_ty.kind() {
1226 ty::Tuple(ref tys) => {
1227 tys.iter().map(|t| ArgKind::from_expected_ty(t, Some(span))).collect()
1231 vec![ArgKind::Arg("_".to_owned(), expected_ty.to_string())]
1235 // If this is a `Fn` family trait and either the expected or found
1236 // is not tupled, then fall back to just a regular mismatch error.
1237 // This shouldn't be common unless manually implementing one of the
1238 // traits manually, but don't make it more confusing when it does
1240 if Some(expected_trait_ref.def_id()) != tcx.lang_items().gen_trait() && not_tupled {
1241 self.report_and_explain_type_error(
1242 TypeTrace::poly_trait_refs(
1248 ty::error::TypeError::Mismatch,
1250 } else if found.len() == expected.len() {
1251 self.report_closure_arg_mismatch(
1256 obligation.cause.code(),
1259 let (closure_span, found) = found_did
1261 let node = self.tcx.hir().get_if_local(did)?;
1262 let (found_span, found) = self.get_fn_like_arguments(node)?;
1263 Some((Some(found_span), found))
1265 .unwrap_or((found_span, found));
1267 self.report_arg_count_mismatch(
1272 found_trait_ty.is_closure(),
1277 TraitNotObjectSafe(did) => {
1278 let violations = self.tcx.object_safety_violations(did);
1279 report_object_safety_error(self.tcx, span, did, violations)
1282 SelectionError::NotConstEvaluatable(NotConstEvaluatable::MentionsInfer) => {
1284 "MentionsInfer should have been handled in `traits/fulfill.rs` or `traits/select/mod.rs`"
1287 SelectionError::NotConstEvaluatable(NotConstEvaluatable::MentionsParam) => {
1288 if !self.tcx.features().generic_const_exprs {
1289 let mut err = self.tcx.sess.struct_span_err(
1291 "constant expression depends on a generic parameter",
1293 // FIXME(const_generics): we should suggest to the user how they can resolve this
1294 // issue. However, this is currently not actually possible
1295 // (see https://github.com/rust-lang/rust/issues/66962#issuecomment-575907083).
1297 // Note that with `feature(generic_const_exprs)` this case should not
1299 err.note("this may fail depending on what value the parameter takes");
1304 match obligation.predicate.kind().skip_binder() {
1305 ty::PredicateKind::ConstEvaluatable(ct) => {
1306 let ty::ConstKind::Unevaluated(uv) = ct.kind() else {
1307 bug!("const evaluatable failed for non-unevaluated const `{ct:?}`");
1310 self.tcx.sess.struct_span_err(span, "unconstrained generic constant");
1311 let const_span = self.tcx.def_span(uv.def.did);
1312 match self.tcx.sess.source_map().span_to_snippet(const_span) {
1313 Ok(snippet) => err.help(&format!(
1314 "try adding a `where` bound using this expression: `where [(); {}]:`",
1317 _ => err.help("consider adding a `where` bound using this expression"),
1324 "unexpected non-ConstEvaluatable predicate, this should not be reachable"
1330 // Already reported in the query.
1331 SelectionError::NotConstEvaluatable(NotConstEvaluatable::Error(_)) => {
1332 // FIXME(eddyb) remove this once `ErrorGuaranteed` becomes a proof token.
1333 self.tcx.sess.delay_span_bug(span, "`ErrorGuaranteed` without an error");
1336 // Already reported.
1337 Overflow(OverflowError::Error(_)) => {
1338 self.tcx.sess.delay_span_bug(span, "`OverflowError` has been reported");
1342 bug!("overflow should be handled before the `report_selection_error` path");
1344 SelectionError::ErrorReporting => {
1345 bug!("ErrorReporting Overflow should not reach `report_selection_err` call")
1349 self.note_obligation_cause(&mut err, &obligation);
1350 self.point_at_returns_when_relevant(&mut err, &obligation);
1356 trait InferCtxtPrivExt<'tcx> {
1357 // returns if `cond` not occurring implies that `error` does not occur - i.e., that
1358 // `error` occurring implies that `cond` occurs.
1359 fn error_implies(&self, cond: ty::Predicate<'tcx>, error: ty::Predicate<'tcx>) -> bool;
1361 fn report_fulfillment_error(
1363 error: &FulfillmentError<'tcx>,
1364 body_id: Option<hir::BodyId>,
1367 fn report_projection_error(
1369 obligation: &PredicateObligation<'tcx>,
1370 error: &MismatchedProjectionTypes<'tcx>,
1373 fn maybe_detailed_projection_msg(
1375 pred: ty::ProjectionPredicate<'tcx>,
1376 normalized_ty: ty::Term<'tcx>,
1377 expected_ty: ty::Term<'tcx>,
1378 ) -> Option<String>;
1384 ignoring_lifetimes: bool,
1385 ) -> Option<CandidateSimilarity>;
1387 fn describe_generator(&self, body_id: hir::BodyId) -> Option<&'static str>;
1389 fn find_similar_impl_candidates(
1391 trait_pred: ty::PolyTraitPredicate<'tcx>,
1392 ) -> Vec<ImplCandidate<'tcx>>;
1394 fn report_similar_impl_candidates(
1396 impl_candidates: Vec<ImplCandidate<'tcx>>,
1397 trait_ref: ty::PolyTraitRef<'tcx>,
1398 body_id: hir::HirId,
1399 err: &mut Diagnostic,
1402 /// Gets the parent trait chain start
1403 fn get_parent_trait_ref(
1405 code: &ObligationCauseCode<'tcx>,
1406 ) -> Option<(String, Option<Span>)>;
1408 /// If the `Self` type of the unsatisfied trait `trait_ref` implements a trait
1409 /// with the same path as `trait_ref`, a help message about
1410 /// a probable version mismatch is added to `err`
1411 fn note_version_mismatch(
1413 err: &mut Diagnostic,
1414 trait_ref: &ty::PolyTraitRef<'tcx>,
1417 /// Creates a `PredicateObligation` with `new_self_ty` replacing the existing type in the
1420 /// For this to work, `new_self_ty` must have no escaping bound variables.
1421 fn mk_trait_obligation_with_new_self_ty(
1423 param_env: ty::ParamEnv<'tcx>,
1424 trait_ref_and_ty: ty::Binder<'tcx, (ty::TraitPredicate<'tcx>, Ty<'tcx>)>,
1425 ) -> PredicateObligation<'tcx>;
1427 fn maybe_report_ambiguity(
1429 obligation: &PredicateObligation<'tcx>,
1430 body_id: Option<hir::BodyId>,
1433 fn predicate_can_apply(
1435 param_env: ty::ParamEnv<'tcx>,
1436 pred: ty::PolyTraitPredicate<'tcx>,
1439 fn note_obligation_cause(&self, err: &mut Diagnostic, obligation: &PredicateObligation<'tcx>);
1441 fn suggest_unsized_bound_if_applicable(
1443 err: &mut Diagnostic,
1444 obligation: &PredicateObligation<'tcx>,
1447 fn annotate_source_of_ambiguity(
1449 err: &mut Diagnostic,
1451 predicate: ty::Predicate<'tcx>,
1454 fn maybe_suggest_unsized_generics(&self, err: &mut Diagnostic, span: Span, node: Node<'tcx>);
1456 fn maybe_indirection_for_unsized(
1458 err: &mut Diagnostic,
1459 item: &'tcx Item<'tcx>,
1460 param: &'tcx GenericParam<'tcx>,
1463 fn is_recursive_obligation(
1465 obligated_types: &mut Vec<Ty<'tcx>>,
1466 cause_code: &ObligationCauseCode<'tcx>,
1470 impl<'tcx> InferCtxtPrivExt<'tcx> for TypeErrCtxt<'_, 'tcx> {
1471 // returns if `cond` not occurring implies that `error` does not occur - i.e., that
1472 // `error` occurring implies that `cond` occurs.
1473 fn error_implies(&self, cond: ty::Predicate<'tcx>, error: ty::Predicate<'tcx>) -> bool {
1478 // FIXME: It should be possible to deal with `ForAll` in a cleaner way.
1479 let bound_error = error.kind();
1480 let (cond, error) = match (cond.kind().skip_binder(), bound_error.skip_binder()) {
1481 (ty::PredicateKind::Trait(..), ty::PredicateKind::Trait(error)) => {
1482 (cond, bound_error.rebind(error))
1485 // FIXME: make this work in other cases too.
1490 for obligation in super::elaborate_predicates(self.tcx, std::iter::once(cond)) {
1491 let bound_predicate = obligation.predicate.kind();
1492 if let ty::PredicateKind::Trait(implication) = bound_predicate.skip_binder() {
1493 let error = error.to_poly_trait_ref();
1494 let implication = bound_predicate.rebind(implication.trait_ref);
1495 // FIXME: I'm just not taking associated types at all here.
1496 // Eventually I'll need to implement param-env-aware
1497 // `Γ₁ ⊦ φ₁ => Γ₂ ⊦ φ₂` logic.
1498 let param_env = ty::ParamEnv::empty();
1499 if self.can_sub(param_env, error, implication).is_ok() {
1500 debug!("error_implies: {:?} -> {:?} -> {:?}", cond, error, implication);
1509 #[instrument(skip(self), level = "debug")]
1510 fn report_fulfillment_error(
1512 error: &FulfillmentError<'tcx>,
1513 body_id: Option<hir::BodyId>,
1516 FulfillmentErrorCode::CodeSelectionError(ref selection_error) => {
1517 self.report_selection_error(
1518 error.obligation.clone(),
1519 &error.root_obligation,
1523 FulfillmentErrorCode::CodeProjectionError(ref e) => {
1524 self.report_projection_error(&error.obligation, e);
1526 FulfillmentErrorCode::CodeAmbiguity => {
1527 self.maybe_report_ambiguity(&error.obligation, body_id);
1529 FulfillmentErrorCode::CodeSubtypeError(ref expected_found, ref err) => {
1530 self.report_mismatched_types(
1531 &error.obligation.cause,
1532 expected_found.expected,
1533 expected_found.found,
1538 FulfillmentErrorCode::CodeConstEquateError(ref expected_found, ref err) => {
1539 let mut diag = self.report_mismatched_consts(
1540 &error.obligation.cause,
1541 expected_found.expected,
1542 expected_found.found,
1545 let code = error.obligation.cause.code().peel_derives().peel_match_impls();
1546 if let ObligationCauseCode::BindingObligation(..)
1547 | ObligationCauseCode::ItemObligation(..)
1548 | ObligationCauseCode::ExprBindingObligation(..)
1549 | ObligationCauseCode::ExprItemObligation(..) = code
1551 self.note_obligation_cause_code(
1553 &error.obligation.predicate,
1554 error.obligation.param_env,
1557 &mut Default::default(),
1562 FulfillmentErrorCode::CodeCycle(ref cycle) => {
1563 self.report_overflow_error_cycle(cycle);
1568 #[instrument(level = "debug", skip_all)]
1569 fn report_projection_error(
1571 obligation: &PredicateObligation<'tcx>,
1572 error: &MismatchedProjectionTypes<'tcx>,
1574 let predicate = self.resolve_vars_if_possible(obligation.predicate);
1576 if predicate.references_error() {
1581 let mut err = error.err;
1582 let mut values = None;
1584 // try to find the mismatched types to report the error with.
1586 // this can fail if the problem was higher-ranked, in which
1587 // cause I have no idea for a good error message.
1588 let bound_predicate = predicate.kind();
1589 if let ty::PredicateKind::Projection(data) = bound_predicate.skip_binder() {
1590 let mut selcx = SelectionContext::new(self);
1591 let data = self.replace_bound_vars_with_fresh_vars(
1592 obligation.cause.span,
1593 infer::LateBoundRegionConversionTime::HigherRankedType,
1594 bound_predicate.rebind(data),
1596 let mut obligations = vec![];
1597 let normalized_ty = super::normalize_projection_type(
1599 obligation.param_env,
1601 obligation.cause.clone(),
1606 debug!(?obligation.cause, ?obligation.param_env);
1608 debug!(?normalized_ty, data.ty = ?data.term);
1610 let is_normalized_ty_expected = !matches!(
1611 obligation.cause.code().peel_derives(),
1612 ObligationCauseCode::ItemObligation(_)
1613 | ObligationCauseCode::BindingObligation(_, _)
1614 | ObligationCauseCode::ExprItemObligation(..)
1615 | ObligationCauseCode::ExprBindingObligation(..)
1616 | ObligationCauseCode::ObjectCastObligation(..)
1617 | ObligationCauseCode::OpaqueType
1619 if let Err(new_err) = self.at(&obligation.cause, obligation.param_env).eq_exp(
1620 is_normalized_ty_expected,
1624 values = Some((data, is_normalized_ty_expected, normalized_ty, data.term));
1630 .and_then(|(predicate, _, normalized_ty, expected_ty)| {
1631 self.maybe_detailed_projection_msg(predicate, normalized_ty, expected_ty)
1633 .unwrap_or_else(|| format!("type mismatch resolving `{}`", predicate));
1634 let mut diag = struct_span_err!(self.tcx.sess, obligation.cause.span, E0271, "{msg}");
1636 let secondary_span = match predicate.kind().skip_binder() {
1637 ty::PredicateKind::Projection(proj) => self
1639 .opt_associated_item(proj.projection_ty.item_def_id)
1640 .and_then(|trait_assoc_item| {
1642 .trait_of_item(proj.projection_ty.item_def_id)
1643 .map(|id| (trait_assoc_item, id))
1645 .and_then(|(trait_assoc_item, id)| {
1646 let trait_assoc_ident = trait_assoc_item.ident(self.tcx);
1647 self.tcx.find_map_relevant_impl(id, proj.projection_ty.self_ty(), |did| {
1649 .associated_items(did)
1650 .in_definition_order()
1651 .find(|assoc| assoc.ident(self.tcx) == trait_assoc_ident)
1654 .and_then(|item| match self.tcx.hir().get_if_local(item.def_id) {
1656 hir::Node::TraitItem(hir::TraitItem {
1657 kind: hir::TraitItemKind::Type(_, Some(ty)),
1660 | hir::Node::ImplItem(hir::ImplItem {
1661 kind: hir::ImplItemKind::Type(ty),
1664 ) => Some((ty.span, format!("type mismatch resolving `{}`", predicate))),
1673 values.map(|(_, is_normalized_ty_expected, normalized_ty, term)| {
1674 infer::ValuePairs::Terms(ExpectedFound::new(
1675 is_normalized_ty_expected,
1684 self.note_obligation_cause(&mut diag, obligation);
1689 fn maybe_detailed_projection_msg(
1691 pred: ty::ProjectionPredicate<'tcx>,
1692 normalized_ty: ty::Term<'tcx>,
1693 expected_ty: ty::Term<'tcx>,
1694 ) -> Option<String> {
1695 let trait_def_id = pred.projection_ty.trait_def_id(self.tcx);
1696 let self_ty = pred.projection_ty.self_ty();
1698 if Some(pred.projection_ty.item_def_id) == self.tcx.lang_items().fn_once_output() {
1700 "expected `{self_ty}` to be a {fn_kind} that returns `{expected_ty}`, but it returns `{normalized_ty}`",
1701 fn_kind = self_ty.prefix_string(self.tcx)
1703 } else if Some(trait_def_id) == self.tcx.lang_items().future_trait() {
1705 "expected `{self_ty}` to be a future that resolves to `{expected_ty}`, but it resolves to `{normalized_ty}`"
1707 } else if Some(trait_def_id) == self.tcx.get_diagnostic_item(sym::Iterator) {
1709 "expected `{self_ty}` to be an iterator that yields `{expected_ty}`, but it yields `{normalized_ty}`"
1720 ignoring_lifetimes: bool,
1721 ) -> Option<CandidateSimilarity> {
1722 /// returns the fuzzy category of a given type, or None
1723 /// if the type can be equated to any type.
1724 fn type_category(tcx: TyCtxt<'_>, t: Ty<'_>) -> Option<u32> {
1726 ty::Bool => Some(0),
1727 ty::Char => Some(1),
1729 ty::Adt(def, _) if tcx.is_diagnostic_item(sym::String, def.did()) => Some(2),
1733 | ty::Infer(ty::IntVar(..) | ty::FloatVar(..)) => Some(4),
1734 ty::Ref(..) | ty::RawPtr(..) => Some(5),
1735 ty::Array(..) | ty::Slice(..) => Some(6),
1736 ty::FnDef(..) | ty::FnPtr(..) => Some(7),
1737 ty::Dynamic(..) => Some(8),
1738 ty::Closure(..) => Some(9),
1739 ty::Tuple(..) => Some(10),
1740 ty::Param(..) => Some(11),
1741 ty::Projection(..) => Some(12),
1742 ty::Opaque(..) => Some(13),
1743 ty::Never => Some(14),
1744 ty::Adt(..) => Some(15),
1745 ty::Generator(..) => Some(16),
1746 ty::Foreign(..) => Some(17),
1747 ty::GeneratorWitness(..) => Some(18),
1748 ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) | ty::Error(_) => None,
1752 let strip_references = |mut t: Ty<'tcx>| -> Ty<'tcx> {
1755 ty::Ref(_, inner, _) | ty::RawPtr(ty::TypeAndMut { ty: inner, .. }) => {
1763 if !ignoring_lifetimes {
1764 a = strip_references(a);
1765 b = strip_references(b);
1768 let cat_a = type_category(self.tcx, a)?;
1769 let cat_b = type_category(self.tcx, b)?;
1771 Some(CandidateSimilarity::Exact { ignoring_lifetimes })
1772 } else if cat_a == cat_b {
1773 match (a.kind(), b.kind()) {
1774 (ty::Adt(def_a, _), ty::Adt(def_b, _)) => def_a == def_b,
1775 (ty::Foreign(def_a), ty::Foreign(def_b)) => def_a == def_b,
1776 // Matching on references results in a lot of unhelpful
1777 // suggestions, so let's just not do that for now.
1779 // We still upgrade successful matches to `ignoring_lifetimes: true`
1780 // to prioritize that impl.
1781 (ty::Ref(..) | ty::RawPtr(..), ty::Ref(..) | ty::RawPtr(..)) => {
1782 self.fuzzy_match_tys(a, b, true).is_some()
1786 .then_some(CandidateSimilarity::Fuzzy { ignoring_lifetimes })
1787 } else if ignoring_lifetimes {
1790 self.fuzzy_match_tys(a, b, true)
1794 fn describe_generator(&self, body_id: hir::BodyId) -> Option<&'static str> {
1795 self.tcx.hir().body(body_id).generator_kind.map(|gen_kind| match gen_kind {
1796 hir::GeneratorKind::Gen => "a generator",
1797 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Block) => "an async block",
1798 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Fn) => "an async function",
1799 hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Closure) => "an async closure",
1803 fn find_similar_impl_candidates(
1805 trait_pred: ty::PolyTraitPredicate<'tcx>,
1806 ) -> Vec<ImplCandidate<'tcx>> {
1808 .all_impls(trait_pred.def_id())
1809 .filter_map(|def_id| {
1810 if self.tcx.impl_polarity(def_id) == ty::ImplPolarity::Negative
1813 .is_constness_satisfied_by(self.tcx.constness(def_id))
1818 let imp = self.tcx.impl_trait_ref(def_id).unwrap();
1820 self.fuzzy_match_tys(trait_pred.skip_binder().self_ty(), imp.self_ty(), false)
1821 .map(|similarity| ImplCandidate { trait_ref: imp, similarity })
1826 fn report_similar_impl_candidates(
1828 impl_candidates: Vec<ImplCandidate<'tcx>>,
1829 trait_ref: ty::PolyTraitRef<'tcx>,
1830 body_id: hir::HirId,
1831 err: &mut Diagnostic,
1833 let report = |mut candidates: Vec<TraitRef<'tcx>>, err: &mut Diagnostic| {
1836 let len = candidates.len();
1837 if candidates.len() == 0 {
1840 if candidates.len() == 1 {
1841 let ty_desc = match candidates[0].self_ty().kind() {
1842 ty::FnPtr(_) => Some("fn pointer"),
1845 let the_desc = match ty_desc {
1846 Some(desc) => format!(" implemented for {} `", desc),
1847 None => " implemented for `".to_string(),
1849 err.highlighted_help(vec![
1851 format!("the trait `{}` ", candidates[0].print_only_trait_path()),
1854 ("is".to_string(), Style::Highlight),
1855 (the_desc, Style::NoStyle),
1856 (candidates[0].self_ty().to_string(), Style::Highlight),
1857 ("`".to_string(), Style::NoStyle),
1861 let trait_ref = TraitRef::identity(self.tcx, candidates[0].def_id);
1862 // Check if the trait is the same in all cases. If so, we'll only show the type.
1863 let mut traits: Vec<_> =
1864 candidates.iter().map(|c| c.print_only_trait_path().to_string()).collect();
1868 let mut candidates: Vec<String> = candidates
1871 if traits.len() == 1 {
1872 format!("\n {}", c.self_ty())
1881 let end = if candidates.len() <= 9 { candidates.len() } else { 8 };
1883 "the following other types implement trait `{}`:{}{}",
1884 trait_ref.print_only_trait_path(),
1885 candidates[..end].join(""),
1886 if len > 9 { format!("\nand {} others", len - 8) } else { String::new() }
1891 let def_id = trait_ref.def_id();
1892 if impl_candidates.is_empty() {
1893 if self.tcx.trait_is_auto(def_id)
1894 || self.tcx.lang_items().iter().any(|(_, id)| id == def_id)
1895 || self.tcx.get_diagnostic_name(def_id).is_some()
1897 // Mentioning implementers of `Copy`, `Debug` and friends is not useful.
1900 let normalized_impl_candidates: Vec<_> = self
1903 // Ignore automatically derived impls and `!Trait` impls.
1905 self.tcx.impl_polarity(def_id) != ty::ImplPolarity::Negative
1906 || self.tcx.is_builtin_derive(def_id)
1908 .filter_map(|def_id| self.tcx.impl_trait_ref(def_id))
1909 .filter(|trait_ref| {
1910 let self_ty = trait_ref.self_ty();
1911 // Avoid mentioning type parameters.
1912 if let ty::Param(_) = self_ty.kind() {
1915 // Avoid mentioning types that are private to another crate
1916 else if let ty::Adt(def, _) = self_ty.peel_refs().kind() {
1917 // FIXME(compiler-errors): This could be generalized, both to
1918 // be more granular, and probably look past other `#[fundamental]`
1921 .visibility(def.did())
1922 .is_accessible_from(body_id.owner.def_id, self.tcx)
1928 return report(normalized_impl_candidates, err);
1931 let normalize = |candidate| {
1932 let infcx = self.tcx.infer_ctxt().build();
1934 .at(&ObligationCause::dummy(), ty::ParamEnv::empty())
1935 .normalize(candidate)
1936 .map_or(candidate, |normalized| normalized.value)
1939 // Sort impl candidates so that ordering is consistent for UI tests.
1940 // because the ordering of `impl_candidates` may not be deterministic:
1941 // https://github.com/rust-lang/rust/pull/57475#issuecomment-455519507
1943 // Prefer more similar candidates first, then sort lexicographically
1944 // by their normalized string representation.
1945 let mut normalized_impl_candidates_and_similarities = impl_candidates
1947 .map(|ImplCandidate { trait_ref, similarity }| {
1948 let normalized = normalize(trait_ref);
1949 (similarity, normalized)
1951 .collect::<Vec<_>>();
1952 normalized_impl_candidates_and_similarities.sort();
1953 normalized_impl_candidates_and_similarities.dedup();
1955 let normalized_impl_candidates = normalized_impl_candidates_and_similarities
1957 .map(|(_, normalized)| normalized)
1958 .collect::<Vec<_>>();
1960 report(normalized_impl_candidates, err)
1963 /// Gets the parent trait chain start
1964 fn get_parent_trait_ref(
1966 code: &ObligationCauseCode<'tcx>,
1967 ) -> Option<(String, Option<Span>)> {
1969 ObligationCauseCode::BuiltinDerivedObligation(data) => {
1970 let parent_trait_ref = self.resolve_vars_if_possible(data.parent_trait_pred);
1971 match self.get_parent_trait_ref(&data.parent_code) {
1974 let ty = parent_trait_ref.skip_binder().self_ty();
1975 let span = TyCategory::from_ty(self.tcx, ty)
1976 .map(|(_, def_id)| self.tcx.def_span(def_id));
1977 Some((ty.to_string(), span))
1981 ObligationCauseCode::FunctionArgumentObligation { parent_code, .. } => {
1982 self.get_parent_trait_ref(&parent_code)
1988 /// If the `Self` type of the unsatisfied trait `trait_ref` implements a trait
1989 /// with the same path as `trait_ref`, a help message about
1990 /// a probable version mismatch is added to `err`
1991 fn note_version_mismatch(
1993 err: &mut Diagnostic,
1994 trait_ref: &ty::PolyTraitRef<'tcx>,
1996 let get_trait_impl = |trait_def_id| {
1997 self.tcx.find_map_relevant_impl(trait_def_id, trait_ref.skip_binder().self_ty(), Some)
1999 let required_trait_path = self.tcx.def_path_str(trait_ref.def_id());
2000 let traits_with_same_path: std::collections::BTreeSet<_> = self
2003 .filter(|trait_def_id| *trait_def_id != trait_ref.def_id())
2004 .filter(|trait_def_id| self.tcx.def_path_str(*trait_def_id) == required_trait_path)
2006 let mut suggested = false;
2007 for trait_with_same_path in traits_with_same_path {
2008 if let Some(impl_def_id) = get_trait_impl(trait_with_same_path) {
2009 let impl_span = self.tcx.def_span(impl_def_id);
2010 err.span_help(impl_span, "trait impl with same name found");
2011 let trait_crate = self.tcx.crate_name(trait_with_same_path.krate);
2012 let crate_msg = format!(
2013 "perhaps two different versions of crate `{}` are being used?",
2016 err.note(&crate_msg);
2023 fn mk_trait_obligation_with_new_self_ty(
2025 param_env: ty::ParamEnv<'tcx>,
2026 trait_ref_and_ty: ty::Binder<'tcx, (ty::TraitPredicate<'tcx>, Ty<'tcx>)>,
2027 ) -> PredicateObligation<'tcx> {
2028 let trait_pred = trait_ref_and_ty.map_bound_ref(|(tr, new_self_ty)| ty::TraitPredicate {
2029 trait_ref: ty::TraitRef {
2030 substs: self.tcx.mk_substs_trait(*new_self_ty, &tr.trait_ref.substs[1..]),
2036 Obligation::new(self.tcx, ObligationCause::dummy(), param_env, trait_pred)
2039 #[instrument(skip(self), level = "debug")]
2040 fn maybe_report_ambiguity(
2042 obligation: &PredicateObligation<'tcx>,
2043 body_id: Option<hir::BodyId>,
2045 // Unable to successfully determine, probably means
2046 // insufficient type information, but could mean
2047 // ambiguous impls. The latter *ought* to be a
2048 // coherence violation, so we don't report it here.
2050 let predicate = self.resolve_vars_if_possible(obligation.predicate);
2051 let span = obligation.cause.span;
2053 debug!(?predicate, obligation.cause.code = ?obligation.cause.code());
2055 // Ambiguity errors are often caused as fallout from earlier errors.
2056 // We ignore them if this `infcx` is tainted in some cases below.
2058 let bound_predicate = predicate.kind();
2059 let mut err = match bound_predicate.skip_binder() {
2060 ty::PredicateKind::Trait(data) => {
2061 let trait_ref = bound_predicate.rebind(data.trait_ref);
2064 if predicate.references_error() {
2068 // This is kind of a hack: it frequently happens that some earlier
2069 // error prevents types from being fully inferred, and then we get
2070 // a bunch of uninteresting errors saying something like "<generic
2071 // #0> doesn't implement Sized". It may even be true that we
2072 // could just skip over all checks where the self-ty is an
2073 // inference variable, but I was afraid that there might be an
2074 // inference variable created, registered as an obligation, and
2075 // then never forced by writeback, and hence by skipping here we'd
2076 // be ignoring the fact that we don't KNOW the type works
2077 // out. Though even that would probably be harmless, given that
2078 // we're only talking about builtin traits, which are known to be
2079 // inhabited. We used to check for `self.tcx.sess.has_errors()` to
2080 // avoid inundating the user with unnecessary errors, but we now
2081 // check upstream for type errors and don't add the obligations to
2082 // begin with in those cases.
2083 if self.tcx.lang_items().sized_trait() == Some(trait_ref.def_id()) {
2084 if !self.is_tainted_by_errors() {
2085 self.emit_inference_failure_err(
2088 trait_ref.self_ty().skip_binder().into(),
2097 // Typically, this ambiguity should only happen if
2098 // there are unresolved type inference variables
2099 // (otherwise it would suggest a coherence
2100 // failure). But given #21974 that is not necessarily
2101 // the case -- we can have multiple where clauses that
2102 // are only distinguished by a region, which results
2103 // in an ambiguity even when all types are fully
2104 // known, since we don't dispatch based on region
2107 // Pick the first substitution that still contains inference variables as the one
2108 // we're going to emit an error for. If there are none (see above), fall back to
2109 // a more general error.
2110 let subst = data.trait_ref.substs.iter().find(|s| s.has_non_region_infer());
2112 let mut err = if let Some(subst) = subst {
2113 self.emit_inference_failure_err(body_id, span, subst, ErrorCode::E0283, true)
2119 "type annotations needed: cannot satisfy `{}`",
2124 let obligation = obligation.with(self.tcx, trait_ref.to_poly_trait_predicate());
2125 let mut selcx = SelectionContext::with_query_mode(
2127 crate::traits::TraitQueryMode::Standard,
2129 match selcx.select_from_obligation(&obligation) {
2131 let impls = ambiguity::recompute_applicable_impls(self.infcx, &obligation);
2132 let has_non_region_infer =
2133 trait_ref.skip_binder().substs.types().any(|t| !t.is_ty_infer());
2134 // It doesn't make sense to talk about applicable impls if there are more
2135 // than a handful of them.
2136 if impls.len() > 1 && impls.len() < 5 && has_non_region_infer {
2137 self.annotate_source_of_ambiguity(&mut err, &impls, predicate);
2139 if self.is_tainted_by_errors() {
2143 err.note(&format!("cannot satisfy `{}`", predicate));
2147 if self.is_tainted_by_errors() {
2151 err.note(&format!("cannot satisfy `{}`", predicate));
2155 if let ObligationCauseCode::ItemObligation(def_id) | ObligationCauseCode::ExprItemObligation(def_id, ..) = *obligation.cause.code() {
2156 self.suggest_fully_qualified_path(&mut err, def_id, span, trait_ref.def_id());
2157 } else if let Ok(snippet) = &self.tcx.sess.source_map().span_to_snippet(span)
2158 && let ObligationCauseCode::BindingObligation(def_id, _) | ObligationCauseCode::ExprBindingObligation(def_id, ..)
2159 = *obligation.cause.code()
2161 let generics = self.tcx.generics_of(def_id);
2162 if generics.params.iter().any(|p| p.name != kw::SelfUpper)
2163 && !snippet.ends_with('>')
2164 && !generics.has_impl_trait()
2165 && !self.tcx.fn_trait_kind_from_lang_item(def_id).is_some()
2167 // FIXME: To avoid spurious suggestions in functions where type arguments
2168 // where already supplied, we check the snippet to make sure it doesn't
2169 // end with a turbofish. Ideally we would have access to a `PathSegment`
2170 // instead. Otherwise we would produce the following output:
2172 // error[E0283]: type annotations needed
2173 // --> $DIR/issue-54954.rs:3:24
2175 // LL | const ARR_LEN: usize = Tt::const_val::<[i8; 123]>();
2176 // | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2178 // | cannot infer type
2179 // | help: consider specifying the type argument
2180 // | in the function call:
2181 // | `Tt::const_val::<[i8; 123]>::<T>`
2183 // LL | const fn const_val<T: Sized>() -> usize {
2184 // | - required by this bound in `Tt::const_val`
2186 // = note: cannot satisfy `_: Tt`
2188 // Clear any more general suggestions in favor of our specific one
2189 err.clear_suggestions();
2191 err.span_suggestion_verbose(
2192 span.shrink_to_hi(),
2194 "consider specifying the type argument{} in the function call",
2195 pluralize!(generics.params.len()),
2202 .map(|p| p.name.to_string())
2203 .collect::<Vec<String>>()
2206 Applicability::HasPlaceholders,
2211 if let (Some(body_id), Some(ty::subst::GenericArgKind::Type(_))) =
2212 (body_id, subst.map(|subst| subst.unpack()))
2214 struct FindExprBySpan<'hir> {
2216 result: Option<&'hir hir::Expr<'hir>>,
2219 impl<'v> hir::intravisit::Visitor<'v> for FindExprBySpan<'v> {
2220 fn visit_expr(&mut self, ex: &'v hir::Expr<'v>) {
2221 if self.span == ex.span {
2222 self.result = Some(ex);
2224 hir::intravisit::walk_expr(self, ex);
2229 let mut expr_finder = FindExprBySpan { span, result: None };
2231 expr_finder.visit_expr(&self.tcx.hir().body(body_id).value);
2233 if let Some(hir::Expr {
2234 kind: hir::ExprKind::Path(hir::QPath::Resolved(None, path)), .. }
2235 ) = expr_finder.result
2238 trait_path_segment @ hir::PathSegment {
2239 res: rustc_hir::def::Res::Def(rustc_hir::def::DefKind::Trait, trait_id),
2243 ident: assoc_item_name,
2244 res: rustc_hir::def::Res::Def(_, item_id),
2248 && data.trait_ref.def_id == *trait_id
2249 && self.tcx.trait_of_item(*item_id) == Some(*trait_id)
2250 && !self.is_tainted_by_errors()
2252 let (verb, noun) = match self.tcx.associated_item(item_id).kind {
2253 ty::AssocKind::Const => ("refer to the", "constant"),
2254 ty::AssocKind::Fn => ("call", "function"),
2255 ty::AssocKind::Type => ("refer to the", "type"), // this is already covered by E0223, but this single match arm doesn't hurt here
2258 // Replace the more general E0283 with a more specific error
2260 err = self.tcx.sess.struct_span_err_with_code(
2263 "cannot {verb} associated {noun} on trait without specifying the corresponding `impl` type",
2265 rustc_errors::error_code!(E0790),
2268 if let Some(local_def_id) = data.trait_ref.def_id.as_local()
2269 && let Some(hir::Node::Item(hir::Item { ident: trait_name, kind: hir::ItemKind::Trait(_, _, _, _, trait_item_refs), .. })) = self.tcx.hir().find_by_def_id(local_def_id)
2270 && let Some(method_ref) = trait_item_refs.iter().find(|item_ref| item_ref.ident == *assoc_item_name) {
2271 err.span_label(method_ref.span, format!("`{}::{}` defined here", trait_name, assoc_item_name));
2274 err.span_label(span, format!("cannot {verb} associated {noun} of trait"));
2276 let trait_impls = self.tcx.trait_impls_of(data.trait_ref.def_id);
2278 if trait_impls.blanket_impls().is_empty()
2279 && let Some((impl_ty, _)) = trait_impls.non_blanket_impls().iter().next()
2280 && let Some(impl_def_id) = impl_ty.def() {
2281 let message = if trait_impls.non_blanket_impls().len() == 1 {
2282 "use the fully-qualified path to the only available implementation".to_string()
2285 "use a fully-qualified path to a specific available implementation ({} found)",
2286 trait_impls.non_blanket_impls().len()
2289 let mut suggestions = vec![(
2290 trait_path_segment.ident.span.shrink_to_lo(),
2291 format!("<{} as ", self.tcx.type_of(impl_def_id))
2293 if let Some(generic_arg) = trait_path_segment.args {
2294 let between_span = trait_path_segment.ident.span.between(generic_arg.span_ext);
2295 // get rid of :: between Trait and <type>
2296 // must be '::' between them, otherwise the parser won't accept the code
2297 suggestions.push((between_span, "".to_string(),));
2298 suggestions.push((generic_arg.span_ext.shrink_to_hi(), format!(">")));
2300 suggestions.push((trait_path_segment.ident.span.shrink_to_hi(), format!(">")));
2302 err.multipart_suggestion(
2305 Applicability::MaybeIncorrect
2314 ty::PredicateKind::WellFormed(arg) => {
2315 // Same hacky approach as above to avoid deluging user
2316 // with error messages.
2317 if arg.references_error()
2318 || self.tcx.sess.has_errors().is_some()
2319 || self.is_tainted_by_errors()
2324 self.emit_inference_failure_err(body_id, span, arg, ErrorCode::E0282, false)
2327 ty::PredicateKind::Subtype(data) => {
2328 if data.references_error()
2329 || self.tcx.sess.has_errors().is_some()
2330 || self.is_tainted_by_errors()
2332 // no need to overload user in such cases
2335 let SubtypePredicate { a_is_expected: _, a, b } = data;
2336 // both must be type variables, or the other would've been instantiated
2337 assert!(a.is_ty_var() && b.is_ty_var());
2338 self.emit_inference_failure_err(body_id, span, a.into(), ErrorCode::E0282, true)
2340 ty::PredicateKind::Projection(data) => {
2341 if predicate.references_error() || self.is_tainted_by_errors() {
2348 .chain(Some(data.term.into_arg()))
2349 .find(|g| g.has_non_region_infer());
2350 if let Some(subst) = subst {
2351 let mut err = self.emit_inference_failure_err(
2358 err.note(&format!("cannot satisfy `{}`", predicate));
2361 // If we can't find a substitution, just print a generic error
2362 let mut err = struct_span_err!(
2366 "type annotations needed: cannot satisfy `{}`",
2369 err.span_label(span, &format!("cannot satisfy `{}`", predicate));
2374 ty::PredicateKind::ConstEvaluatable(data) => {
2375 if predicate.references_error() || self.is_tainted_by_errors() {
2378 let subst = data.walk().find(|g| g.is_non_region_infer());
2379 if let Some(subst) = subst {
2380 let err = self.emit_inference_failure_err(
2389 // If we can't find a substitution, just print a generic error
2390 let mut err = struct_span_err!(
2394 "type annotations needed: cannot satisfy `{}`",
2397 err.span_label(span, &format!("cannot satisfy `{}`", predicate));
2402 if self.tcx.sess.has_errors().is_some() || self.is_tainted_by_errors() {
2405 let mut err = struct_span_err!(
2409 "type annotations needed: cannot satisfy `{}`",
2412 err.span_label(span, &format!("cannot satisfy `{}`", predicate));
2416 self.note_obligation_cause(&mut err, obligation);
2420 fn annotate_source_of_ambiguity(
2422 err: &mut Diagnostic,
2424 predicate: ty::Predicate<'tcx>,
2426 let mut spans = vec![];
2427 let mut crates = vec![];
2428 let mut post = vec![];
2429 for def_id in impls {
2430 match self.tcx.span_of_impl(*def_id) {
2431 Ok(span) => spans.push(span),
2434 if let Some(header) = to_pretty_impl_header(self.tcx, *def_id) {
2440 let mut crate_names: Vec<_> = crates.iter().map(|n| format!("`{}`", n)).collect();
2442 crate_names.dedup();
2446 if self.is_tainted_by_errors()
2447 && (crate_names.len() == 1
2449 && ["`core`", "`alloc`", "`std`"].contains(&crate_names[0].as_str())
2450 || predicate.visit_with(&mut HasNumericInferVisitor).is_break())
2452 // Avoid complaining about other inference issues for expressions like
2453 // `42 >> 1`, where the types are still `{integer}`, but we want to
2454 // Do we need `trait_ref.skip_binder().self_ty().is_numeric() &&` too?
2455 // NOTE(eddyb) this was `.cancel()`, but `err`
2456 // is borrowed, so we can't fully defuse it.
2457 err.downgrade_to_delayed_bug();
2461 let msg = format!("multiple `impl`s satisfying `{}` found", predicate);
2462 let post = if post.len() > 1 || (post.len() == 1 && post[0].contains('\n')) {
2463 format!(":\n{}", post.iter().map(|p| format!("- {}", p)).collect::<Vec<_>>().join("\n"),)
2464 } else if post.len() == 1 {
2465 format!(": `{}`", post[0])
2470 match (spans.len(), crates.len(), crate_names.len()) {
2472 err.note(&format!("cannot satisfy `{}`", predicate));
2475 err.note(&format!("{} in the `{}` crate{}", msg, crates[0], post,));
2479 "{} in the following crates: {}{}",
2481 crate_names.join(", "),
2486 let span: MultiSpan = spans.into();
2487 err.span_note(span, &msg);
2490 let span: MultiSpan = spans.into();
2491 err.span_note(span, &msg);
2493 &format!("and another `impl` found in the `{}` crate{}", crates[0], post,),
2497 let span: MultiSpan = spans.into();
2498 err.span_note(span, &msg);
2500 "and more `impl`s found in the following crates: {}{}",
2501 crate_names.join(", "),
2508 /// Returns `true` if the trait predicate may apply for *some* assignment
2509 /// to the type parameters.
2510 fn predicate_can_apply(
2512 param_env: ty::ParamEnv<'tcx>,
2513 pred: ty::PolyTraitPredicate<'tcx>,
2515 struct ParamToVarFolder<'a, 'tcx> {
2516 infcx: &'a InferCtxt<'tcx>,
2517 var_map: FxHashMap<Ty<'tcx>, Ty<'tcx>>,
2520 impl<'a, 'tcx> TypeFolder<'tcx> for ParamToVarFolder<'a, 'tcx> {
2521 fn tcx<'b>(&'b self) -> TyCtxt<'tcx> {
2525 fn fold_ty(&mut self, ty: Ty<'tcx>) -> Ty<'tcx> {
2526 if let ty::Param(ty::ParamTy { name, .. }) = *ty.kind() {
2527 let infcx = self.infcx;
2528 *self.var_map.entry(ty).or_insert_with(|| {
2529 infcx.next_ty_var(TypeVariableOrigin {
2530 kind: TypeVariableOriginKind::TypeParameterDefinition(name, None),
2535 ty.super_fold_with(self)
2541 let mut selcx = SelectionContext::new(self);
2544 pred.fold_with(&mut ParamToVarFolder { infcx: self, var_map: Default::default() });
2546 let cleaned_pred = super::project::normalize(
2549 ObligationCause::dummy(),
2555 Obligation::new(self.tcx, ObligationCause::dummy(), param_env, cleaned_pred);
2557 self.predicate_may_hold(&obligation)
2561 fn note_obligation_cause(&self, err: &mut Diagnostic, obligation: &PredicateObligation<'tcx>) {
2562 // First, attempt to add note to this error with an async-await-specific
2563 // message, and fall back to regular note otherwise.
2564 if !self.maybe_note_obligation_cause_for_async_await(err, obligation) {
2565 self.note_obligation_cause_code(
2567 &obligation.predicate,
2568 obligation.param_env,
2569 obligation.cause.code(),
2571 &mut Default::default(),
2573 self.suggest_unsized_bound_if_applicable(err, obligation);
2577 #[instrument(level = "debug", skip_all)]
2578 fn suggest_unsized_bound_if_applicable(
2580 err: &mut Diagnostic,
2581 obligation: &PredicateObligation<'tcx>,
2583 let ty::PredicateKind::Trait(pred) = obligation.predicate.kind().skip_binder() else { return; };
2584 let (ObligationCauseCode::BindingObligation(item_def_id, span)
2585 | ObligationCauseCode::ExprBindingObligation(item_def_id, span, ..))
2586 = *obligation.cause.code().peel_derives() else { return; };
2587 debug!(?pred, ?item_def_id, ?span);
2589 let (Some(node), true) = (
2590 self.tcx.hir().get_if_local(item_def_id),
2591 Some(pred.def_id()) == self.tcx.lang_items().sized_trait(),
2595 self.maybe_suggest_unsized_generics(err, span, node);
2598 #[instrument(level = "debug", skip_all)]
2599 fn maybe_suggest_unsized_generics(&self, err: &mut Diagnostic, span: Span, node: Node<'tcx>) {
2600 let Some(generics) = node.generics() else {
2603 let sized_trait = self.tcx.lang_items().sized_trait();
2604 debug!(?generics.params);
2605 debug!(?generics.predicates);
2606 let Some(param) = generics.params.iter().find(|param| param.span == span) else {
2609 // Check that none of the explicit trait bounds is `Sized`. Assume that an explicit
2610 // `Sized` bound is there intentionally and we don't need to suggest relaxing it.
2611 let explicitly_sized = generics
2612 .bounds_for_param(param.def_id)
2613 .flat_map(|bp| bp.bounds)
2614 .any(|bound| bound.trait_ref().and_then(|tr| tr.trait_def_id()) == sized_trait);
2615 if explicitly_sized {
2622 // Only suggest indirection for uses of type parameters in ADTs.
2624 hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Union(..),
2628 if self.maybe_indirection_for_unsized(err, item, param) {
2634 // Didn't add an indirection suggestion, so add a general suggestion to relax `Sized`.
2635 let (span, separator) = if let Some(s) = generics.bounds_span_for_suggestions(param.def_id)
2639 (span.shrink_to_hi(), ":")
2641 err.span_suggestion_verbose(
2643 "consider relaxing the implicit `Sized` restriction",
2644 format!("{} ?Sized", separator),
2645 Applicability::MachineApplicable,
2649 fn maybe_indirection_for_unsized(
2651 err: &mut Diagnostic,
2653 param: &GenericParam<'tcx>,
2655 // Suggesting `T: ?Sized` is only valid in an ADT if `T` is only used in a
2656 // borrow. `struct S<'a, T: ?Sized>(&'a T);` is valid, `struct S<T: ?Sized>(T);`
2657 // is not. Look for invalid "bare" parameter uses, and suggest using indirection.
2659 FindTypeParam { param: param.name.ident().name, invalid_spans: vec![], nested: false };
2660 visitor.visit_item(item);
2661 if visitor.invalid_spans.is_empty() {
2664 let mut multispan: MultiSpan = param.span.into();
2665 multispan.push_span_label(
2667 format!("this could be changed to `{}: ?Sized`...", param.name.ident()),
2669 for sp in visitor.invalid_spans {
2670 multispan.push_span_label(
2672 format!("...if indirection were used here: `Box<{}>`", param.name.ident()),
2678 "you could relax the implicit `Sized` bound on `{T}` if it were \
2679 used through indirection like `&{T}` or `Box<{T}>`",
2680 T = param.name.ident(),
2686 fn is_recursive_obligation(
2688 obligated_types: &mut Vec<Ty<'tcx>>,
2689 cause_code: &ObligationCauseCode<'tcx>,
2691 if let ObligationCauseCode::BuiltinDerivedObligation(ref data) = cause_code {
2692 let parent_trait_ref = self.resolve_vars_if_possible(data.parent_trait_pred);
2693 let self_ty = parent_trait_ref.skip_binder().self_ty();
2694 if obligated_types.iter().any(|ot| ot == &self_ty) {
2697 if let ty::Adt(def, substs) = self_ty.kind()
2698 && let [arg] = &substs[..]
2699 && let ty::subst::GenericArgKind::Type(ty) = arg.unpack()
2700 && let ty::Adt(inner_def, _) = ty.kind()
2710 /// Look for type `param` in an ADT being used only through a reference to confirm that suggesting
2711 /// `param: ?Sized` would be a valid constraint.
2712 struct FindTypeParam {
2713 param: rustc_span::Symbol,
2714 invalid_spans: Vec<Span>,
2718 impl<'v> Visitor<'v> for FindTypeParam {
2719 fn visit_where_predicate(&mut self, _: &'v hir::WherePredicate<'v>) {
2720 // Skip where-clauses, to avoid suggesting indirection for type parameters found there.
2723 fn visit_ty(&mut self, ty: &hir::Ty<'_>) {
2724 // We collect the spans of all uses of the "bare" type param, like in `field: T` or
2725 // `field: (T, T)` where we could make `T: ?Sized` while skipping cases that are known to be
2726 // valid like `field: &'a T` or `field: *mut T` and cases that *might* have further `Sized`
2727 // obligations like `Box<T>` and `Vec<T>`, but we perform no extra analysis for those cases
2728 // and suggest `T: ?Sized` regardless of their obligations. This is fine because the errors
2729 // in that case should make what happened clear enough.
2731 hir::TyKind::Ptr(_) | hir::TyKind::Rptr(..) | hir::TyKind::TraitObject(..) => {}
2732 hir::TyKind::Path(hir::QPath::Resolved(None, path))
2733 if path.segments.len() == 1 && path.segments[0].ident.name == self.param =>
2736 debug!(?ty, "FindTypeParam::visit_ty");
2737 self.invalid_spans.push(ty.span);
2740 hir::TyKind::Path(_) => {
2741 let prev = self.nested;
2743 hir::intravisit::walk_ty(self, ty);
2747 hir::intravisit::walk_ty(self, ty);
2753 /// Summarizes information
2756 /// An argument of non-tuple type. Parameters are (name, ty)
2757 Arg(String, String),
2759 /// An argument of tuple type. For a "found" argument, the span is
2760 /// the location in the source of the pattern. For an "expected"
2761 /// argument, it will be None. The vector is a list of (name, ty)
2762 /// strings for the components of the tuple.
2763 Tuple(Option<Span>, Vec<(String, String)>),
2767 fn empty() -> ArgKind {
2768 ArgKind::Arg("_".to_owned(), "_".to_owned())
2771 /// Creates an `ArgKind` from the expected type of an
2772 /// argument. It has no name (`_`) and an optional source span.
2773 pub fn from_expected_ty(t: Ty<'_>, span: Option<Span>) -> ArgKind {
2775 ty::Tuple(tys) => ArgKind::Tuple(
2777 tys.iter().map(|ty| ("_".to_owned(), ty.to_string())).collect::<Vec<_>>(),
2779 _ => ArgKind::Arg("_".to_owned(), t.to_string()),
2784 struct HasNumericInferVisitor;
2786 impl<'tcx> ty::TypeVisitor<'tcx> for HasNumericInferVisitor {
2789 fn visit_ty(&mut self, ty: Ty<'tcx>) -> ControlFlow<Self::BreakTy> {
2790 if matches!(ty.kind(), ty::Infer(ty::FloatVar(_) | ty::IntVar(_))) {
2791 ControlFlow::Break(())
2793 ControlFlow::CONTINUE
2798 pub enum DefIdOrName {