1 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
2 #![feature(associated_type_defaults)]
3 #![feature(control_flow_enum)]
4 #![feature(rustc_private)]
5 #![feature(try_blocks)]
6 #![recursion_limit = "256"]
7 #![deny(rustc::untranslatable_diagnostic)]
8 #![deny(rustc::diagnostic_outside_of_impl)]
15 use rustc_ast::MacroDef;
16 use rustc_attr as attr;
17 use rustc_data_structures::fx::FxHashSet;
18 use rustc_data_structures::intern::Interned;
20 use rustc_hir::def::{DefKind, Res};
21 use rustc_hir::def_id::{DefId, LocalDefId, LocalDefIdSet, CRATE_DEF_ID};
22 use rustc_hir::intravisit::{self, Visitor};
23 use rustc_hir::{AssocItemKind, HirIdSet, ItemId, Node, PatKind};
24 use rustc_middle::bug;
25 use rustc_middle::hir::nested_filter;
26 use rustc_middle::middle::privacy::{EffectiveVisibilities, Level};
27 use rustc_middle::span_bug;
28 use rustc_middle::ty::abstract_const::{walk_abstract_const, AbstractConst, Node as ACNode};
29 use rustc_middle::ty::query::Providers;
30 use rustc_middle::ty::subst::InternalSubsts;
31 use rustc_middle::ty::{self, Const, DefIdTree, GenericParamDefKind};
32 use rustc_middle::ty::{TraitRef, Ty, TyCtxt, TypeSuperVisitable, TypeVisitable, TypeVisitor};
33 use rustc_session::lint;
34 use rustc_span::hygiene::Transparency;
35 use rustc_span::symbol::{kw, sym, Ident};
38 use std::marker::PhantomData;
39 use std::ops::ControlFlow;
40 use std::{cmp, fmt, mem};
43 FieldIsPrivate, FieldIsPrivateLabel, FromPrivateDependencyInPublicInterface, InPublicInterface,
44 InPublicInterfaceTraits, ItemIsPrivate, PrivateInPublicLint, ReportEffectiveVisibility,
48 ////////////////////////////////////////////////////////////////////////////////
49 /// Generic infrastructure used to implement specific visitors below.
50 ////////////////////////////////////////////////////////////////////////////////
52 /// Implemented to visit all `DefId`s in a type.
53 /// Visiting `DefId`s is useful because visibilities and reachabilities are attached to them.
54 /// The idea is to visit "all components of a type", as documented in
55 /// <https://github.com/rust-lang/rfcs/blob/master/text/2145-type-privacy.md#how-to-determine-visibility-of-a-type>.
56 /// The default type visitor (`TypeVisitor`) does most of the job, but it has some shortcomings.
57 /// First, it doesn't have overridable `fn visit_trait_ref`, so we have to catch trait `DefId`s
58 /// manually. Second, it doesn't visit some type components like signatures of fn types, or traits
59 /// in `impl Trait`, see individual comments in `DefIdVisitorSkeleton::visit_ty`.
60 trait DefIdVisitor<'tcx> {
63 fn tcx(&self) -> TyCtxt<'tcx>;
64 fn shallow(&self) -> bool {
67 fn skip_assoc_tys(&self) -> bool {
74 descr: &dyn fmt::Display,
75 ) -> ControlFlow<Self::BreakTy>;
77 /// Not overridden, but used to actually visit types and traits.
78 fn skeleton(&mut self) -> DefIdVisitorSkeleton<'_, 'tcx, Self> {
79 DefIdVisitorSkeleton {
81 visited_opaque_tys: Default::default(),
82 dummy: Default::default(),
85 fn visit(&mut self, ty_fragment: impl TypeVisitable<'tcx>) -> ControlFlow<Self::BreakTy> {
86 ty_fragment.visit_with(&mut self.skeleton())
88 fn visit_trait(&mut self, trait_ref: TraitRef<'tcx>) -> ControlFlow<Self::BreakTy> {
89 self.skeleton().visit_trait(trait_ref)
91 fn visit_projection_ty(
93 projection: ty::ProjectionTy<'tcx>,
94 ) -> ControlFlow<Self::BreakTy> {
95 self.skeleton().visit_projection_ty(projection)
99 predicates: ty::GenericPredicates<'tcx>,
100 ) -> ControlFlow<Self::BreakTy> {
101 self.skeleton().visit_predicates(predicates)
105 struct DefIdVisitorSkeleton<'v, 'tcx, V: ?Sized> {
106 def_id_visitor: &'v mut V,
107 visited_opaque_tys: FxHashSet<DefId>,
108 dummy: PhantomData<TyCtxt<'tcx>>,
111 impl<'tcx, V> DefIdVisitorSkeleton<'_, 'tcx, V>
113 V: DefIdVisitor<'tcx> + ?Sized,
115 fn visit_trait(&mut self, trait_ref: TraitRef<'tcx>) -> ControlFlow<V::BreakTy> {
116 let TraitRef { def_id, substs } = trait_ref;
117 self.def_id_visitor.visit_def_id(def_id, "trait", &trait_ref.print_only_trait_path())?;
118 if self.def_id_visitor.shallow() { ControlFlow::CONTINUE } else { substs.visit_with(self) }
121 fn visit_projection_ty(
123 projection: ty::ProjectionTy<'tcx>,
124 ) -> ControlFlow<V::BreakTy> {
125 let tcx = self.def_id_visitor.tcx();
126 let (trait_ref, assoc_substs) = if tcx.def_kind(projection.item_def_id)
127 != DefKind::ImplTraitPlaceholder
129 projection.trait_ref_and_own_substs(tcx)
131 // HACK(RPITIT): Remove this when RPITITs are lowered to regular assoc tys
132 let def_id = tcx.impl_trait_in_trait_parent(projection.item_def_id);
133 let trait_generics = tcx.generics_of(def_id);
135 ty::TraitRef { def_id, substs: projection.substs.truncate_to(tcx, trait_generics) },
136 &projection.substs[trait_generics.count()..],
139 self.visit_trait(trait_ref)?;
140 if self.def_id_visitor.shallow() {
141 ControlFlow::CONTINUE
143 assoc_substs.iter().try_for_each(|subst| subst.visit_with(self))
147 fn visit_predicate(&mut self, predicate: ty::Predicate<'tcx>) -> ControlFlow<V::BreakTy> {
148 match predicate.kind().skip_binder() {
149 ty::PredicateKind::Trait(ty::TraitPredicate {
153 }) => self.visit_trait(trait_ref),
154 ty::PredicateKind::Projection(ty::ProjectionPredicate { projection_ty, term }) => {
155 term.visit_with(self)?;
156 self.visit_projection_ty(projection_ty)
158 ty::PredicateKind::TypeOutlives(ty::OutlivesPredicate(ty, _region)) => {
161 ty::PredicateKind::RegionOutlives(..) => ControlFlow::CONTINUE,
162 ty::PredicateKind::ConstEvaluatable(ct) => ct.visit_with(self),
163 ty::PredicateKind::WellFormed(arg) => arg.visit_with(self),
164 _ => bug!("unexpected predicate: {:?}", predicate),
170 predicates: ty::GenericPredicates<'tcx>,
171 ) -> ControlFlow<V::BreakTy> {
172 let ty::GenericPredicates { parent: _, predicates } = predicates;
173 predicates.iter().try_for_each(|&(predicate, _span)| self.visit_predicate(predicate))
177 impl<'tcx, V> TypeVisitor<'tcx> for DefIdVisitorSkeleton<'_, 'tcx, V>
179 V: DefIdVisitor<'tcx> + ?Sized,
181 type BreakTy = V::BreakTy;
183 fn visit_ty(&mut self, ty: Ty<'tcx>) -> ControlFlow<V::BreakTy> {
184 let tcx = self.def_id_visitor.tcx();
185 // InternalSubsts are not visited here because they are visited below
186 // in `super_visit_with`.
188 ty::Adt(ty::AdtDef(Interned(&ty::AdtDefData { did: def_id, .. }, _)), ..)
189 | ty::Foreign(def_id)
190 | ty::FnDef(def_id, ..)
191 | ty::Closure(def_id, ..)
192 | ty::Generator(def_id, ..) => {
193 self.def_id_visitor.visit_def_id(def_id, "type", &ty)?;
194 if self.def_id_visitor.shallow() {
195 return ControlFlow::CONTINUE;
197 // Default type visitor doesn't visit signatures of fn types.
198 // Something like `fn() -> Priv {my_func}` is considered a private type even if
199 // `my_func` is public, so we need to visit signatures.
200 if let ty::FnDef(..) = ty.kind() {
201 tcx.fn_sig(def_id).visit_with(self)?;
203 // Inherent static methods don't have self type in substs.
204 // Something like `fn() {my_method}` type of the method
205 // `impl Pub<Priv> { pub fn my_method() {} }` is considered a private type,
206 // so we need to visit the self type additionally.
207 if let Some(assoc_item) = tcx.opt_associated_item(def_id) {
208 if let Some(impl_def_id) = assoc_item.impl_container(tcx) {
209 tcx.type_of(impl_def_id).visit_with(self)?;
213 ty::Projection(proj) => {
214 if self.def_id_visitor.skip_assoc_tys() {
215 // Visitors searching for minimal visibility/reachability want to
216 // conservatively approximate associated types like `<Type as Trait>::Alias`
217 // as visible/reachable even if both `Type` and `Trait` are private.
218 // Ideally, associated types should be substituted in the same way as
219 // free type aliases, but this isn't done yet.
220 return ControlFlow::CONTINUE;
222 // This will also visit substs if necessary, so we don't need to recurse.
223 return self.visit_projection_ty(proj);
225 ty::Dynamic(predicates, ..) => {
226 // All traits in the list are considered the "primary" part of the type
227 // and are visited by shallow visitors.
228 for predicate in predicates {
229 let trait_ref = match predicate.skip_binder() {
230 ty::ExistentialPredicate::Trait(trait_ref) => trait_ref,
231 ty::ExistentialPredicate::Projection(proj) => proj.trait_ref(tcx),
232 ty::ExistentialPredicate::AutoTrait(def_id) => {
233 ty::ExistentialTraitRef { def_id, substs: InternalSubsts::empty() }
236 let ty::ExistentialTraitRef { def_id, substs: _ } = trait_ref;
237 self.def_id_visitor.visit_def_id(def_id, "trait", &trait_ref)?;
240 ty::Opaque(def_id, ..) => {
241 // Skip repeated `Opaque`s to avoid infinite recursion.
242 if self.visited_opaque_tys.insert(def_id) {
243 // The intent is to treat `impl Trait1 + Trait2` identically to
244 // `dyn Trait1 + Trait2`. Therefore we ignore def-id of the opaque type itself
245 // (it either has no visibility, or its visibility is insignificant, like
246 // visibilities of type aliases) and recurse into bounds instead to go
247 // through the trait list (default type visitor doesn't visit those traits).
248 // All traits in the list are considered the "primary" part of the type
249 // and are visited by shallow visitors.
250 self.visit_predicates(ty::GenericPredicates {
252 predicates: tcx.explicit_item_bounds(def_id),
256 // These types don't have their own def-ids (but may have subcomponents
257 // with def-ids that should be visited recursively).
273 | ty::GeneratorWitness(..) => {}
274 ty::Bound(..) | ty::Placeholder(..) | ty::Infer(..) => {
275 bug!("unexpected type: {:?}", ty)
279 if self.def_id_visitor.shallow() {
280 ControlFlow::CONTINUE
282 ty.super_visit_with(self)
286 fn visit_const(&mut self, c: Const<'tcx>) -> ControlFlow<Self::BreakTy> {
287 self.visit_ty(c.ty())?;
288 let tcx = self.def_id_visitor.tcx();
289 if let Ok(Some(ct)) = AbstractConst::from_const(tcx, c) {
290 walk_abstract_const(tcx, ct, |node| match node.root(tcx) {
291 ACNode::Leaf(leaf) => self.visit_const(leaf),
292 ACNode::Cast(_, _, ty) => self.visit_ty(ty),
293 ACNode::Binop(..) | ACNode::UnaryOp(..) | ACNode::FunctionCall(_, _) => {
294 ControlFlow::CONTINUE
298 ControlFlow::CONTINUE
303 fn min(vis1: ty::Visibility, vis2: ty::Visibility, tcx: TyCtxt<'_>) -> ty::Visibility {
304 if vis1.is_at_least(vis2, tcx) { vis2 } else { vis1 }
307 ////////////////////////////////////////////////////////////////////////////////
308 /// Visitor used to determine impl visibility and reachability.
309 ////////////////////////////////////////////////////////////////////////////////
311 struct FindMin<'a, 'tcx, VL: VisibilityLike> {
313 effective_visibilities: &'a EffectiveVisibilities,
317 impl<'a, 'tcx, VL: VisibilityLike> DefIdVisitor<'tcx> for FindMin<'a, 'tcx, VL> {
318 fn tcx(&self) -> TyCtxt<'tcx> {
321 fn shallow(&self) -> bool {
324 fn skip_assoc_tys(&self) -> bool {
331 _descr: &dyn fmt::Display,
332 ) -> ControlFlow<Self::BreakTy> {
333 if let Some(def_id) = def_id.as_local() {
334 self.min = VL::new_min(self, def_id);
336 ControlFlow::CONTINUE
340 trait VisibilityLike: Sized {
342 const SHALLOW: bool = false;
343 fn new_min(find: &FindMin<'_, '_, Self>, def_id: LocalDefId) -> Self;
345 // Returns an over-approximation (`skip_assoc_tys` = true) of visibility due to
346 // associated types for which we can't determine visibility precisely.
350 effective_visibilities: &EffectiveVisibilities,
352 let mut find = FindMin { tcx, effective_visibilities, min: Self::MAX };
353 find.visit(tcx.type_of(def_id));
354 if let Some(trait_ref) = tcx.impl_trait_ref(def_id) {
355 find.visit_trait(trait_ref);
360 impl VisibilityLike for ty::Visibility {
361 const MAX: Self = ty::Visibility::Public;
362 fn new_min(find: &FindMin<'_, '_, Self>, def_id: LocalDefId) -> Self {
363 min(find.tcx.local_visibility(def_id), find.min, find.tcx)
366 impl VisibilityLike for Option<Level> {
367 const MAX: Self = Some(Level::Direct);
368 // Type inference is very smart sometimes.
369 // It can make an impl reachable even some components of its type or trait are unreachable.
370 // E.g. methods of `impl ReachableTrait<UnreachableTy> for ReachableTy<UnreachableTy> { ... }`
371 // can be usable from other crates (#57264). So we skip substs when calculating reachability
372 // and consider an impl reachable if its "shallow" type and trait are reachable.
374 // The assumption we make here is that type-inference won't let you use an impl without knowing
375 // both "shallow" version of its self type and "shallow" version of its trait if it exists
376 // (which require reaching the `DefId`s in them).
377 const SHALLOW: bool = true;
378 fn new_min(find: &FindMin<'_, '_, Self>, def_id: LocalDefId) -> Self {
379 cmp::min(find.effective_visibilities.public_at_level(def_id), find.min)
383 ////////////////////////////////////////////////////////////////////////////////
384 /// The embargo visitor, used to determine the exports of the AST.
385 ////////////////////////////////////////////////////////////////////////////////
387 struct EmbargoVisitor<'tcx> {
390 /// Effective visibilities for reachable nodes.
391 effective_visibilities: EffectiveVisibilities,
392 /// A set of pairs corresponding to modules, where the first module is
393 /// reachable via a macro that's defined in the second module. This cannot
394 /// be represented as reachable because it can't handle the following case:
396 /// pub mod n { // Should be `Public`
397 /// pub(crate) mod p { // Should *not* be accessible
398 /// pub fn f() -> i32 { 12 } // Must be `Reachable`
404 macro_reachable: FxHashSet<(LocalDefId, LocalDefId)>,
405 /// Previous visibility level; `None` means unreachable.
406 prev_level: Option<Level>,
407 /// Has something changed in the level map?
411 struct ReachEverythingInTheInterfaceVisitor<'a, 'tcx> {
412 level: Option<Level>,
413 item_def_id: LocalDefId,
414 ev: &'a mut EmbargoVisitor<'tcx>,
417 impl<'tcx> EmbargoVisitor<'tcx> {
418 fn get(&self, def_id: LocalDefId) -> Option<Level> {
419 self.effective_visibilities.public_at_level(def_id)
422 fn update_with_hir_id(&mut self, hir_id: hir::HirId, level: Option<Level>) -> Option<Level> {
423 let def_id = self.tcx.hir().local_def_id(hir_id);
424 self.update(def_id, level)
427 /// Updates node level and returns the updated level.
428 fn update(&mut self, def_id: LocalDefId, level: Option<Level>) -> Option<Level> {
429 let old_level = self.get(def_id);
430 // Visibility levels can only grow.
431 if level > old_level {
432 self.effective_visibilities.set_public_at_level(
434 || ty::Visibility::Restricted(self.tcx.parent_module_from_def_id(def_id)),
447 level: Option<Level>,
448 ) -> ReachEverythingInTheInterfaceVisitor<'_, 'tcx> {
449 ReachEverythingInTheInterfaceVisitor {
450 level: cmp::min(level, Some(Level::Reachable)),
456 // We have to make sure that the items that macros might reference
457 // are reachable, since they might be exported transitively.
458 fn update_reachability_from_macro(&mut self, local_def_id: LocalDefId, md: &MacroDef) {
459 // Non-opaque macros cannot make other items more accessible than they already are.
461 let hir_id = self.tcx.hir().local_def_id_to_hir_id(local_def_id);
462 let attrs = self.tcx.hir().attrs(hir_id);
463 if attr::find_transparency(attrs, md.macro_rules).0 != Transparency::Opaque {
467 let macro_module_def_id = self.tcx.local_parent(local_def_id);
468 if self.tcx.opt_def_kind(macro_module_def_id) != Some(DefKind::Mod) {
469 // The macro's parent doesn't correspond to a `mod`, return early (#63164, #65252).
473 if self.get(local_def_id).is_none() {
477 // Since we are starting from an externally visible module,
478 // all the parents in the loop below are also guaranteed to be modules.
479 let mut module_def_id = macro_module_def_id;
481 let changed_reachability =
482 self.update_macro_reachable(module_def_id, macro_module_def_id);
483 if changed_reachability || module_def_id == CRATE_DEF_ID {
486 module_def_id = self.tcx.local_parent(module_def_id);
490 /// Updates the item as being reachable through a macro defined in the given
491 /// module. Returns `true` if the level has changed.
492 fn update_macro_reachable(
494 module_def_id: LocalDefId,
495 defining_mod: LocalDefId,
497 if self.macro_reachable.insert((module_def_id, defining_mod)) {
498 self.update_macro_reachable_mod(module_def_id, defining_mod);
505 fn update_macro_reachable_mod(&mut self, module_def_id: LocalDefId, defining_mod: LocalDefId) {
506 let module = self.tcx.hir().get_module(module_def_id).0;
507 for item_id in module.item_ids {
508 let def_kind = self.tcx.def_kind(item_id.owner_id);
509 let vis = self.tcx.local_visibility(item_id.owner_id.def_id);
510 self.update_macro_reachable_def(item_id.owner_id.def_id, def_kind, vis, defining_mod);
512 if let Some(exports) = self.tcx.module_reexports(module_def_id) {
513 for export in exports {
514 if export.vis.is_accessible_from(defining_mod, self.tcx) {
515 if let Res::Def(def_kind, def_id) = export.res {
516 if let Some(def_id) = def_id.as_local() {
517 let vis = self.tcx.local_visibility(def_id);
518 self.update_macro_reachable_def(def_id, def_kind, vis, defining_mod);
526 fn update_macro_reachable_def(
533 let level = Some(Level::Reachable);
535 self.update(def_id, level);
538 // No type privacy, so can be directly marked as reachable.
539 DefKind::Const | DefKind::Static(_) | DefKind::TraitAlias | DefKind::TyAlias => {
540 if vis.is_accessible_from(module, self.tcx) {
541 self.update(def_id, level);
545 // Hygiene isn't really implemented for `macro_rules!` macros at the
546 // moment. Accordingly, marking them as reachable is unwise. `macro` macros
547 // have normal hygiene, so we can treat them like other items without type
548 // privacy and mark them reachable.
549 DefKind::Macro(_) => {
550 let item = self.tcx.hir().expect_item(def_id);
551 if let hir::ItemKind::Macro(MacroDef { macro_rules: false, .. }, _) = item.kind {
552 if vis.is_accessible_from(module, self.tcx) {
553 self.update(def_id, level);
558 // We can't use a module name as the final segment of a path, except
559 // in use statements. Since re-export checking doesn't consider
560 // hygiene these don't need to be marked reachable. The contents of
561 // the module, however may be reachable.
563 if vis.is_accessible_from(module, self.tcx) {
564 self.update_macro_reachable(def_id, module);
568 DefKind::Struct | DefKind::Union => {
569 // While structs and unions have type privacy, their fields do not.
571 let item = self.tcx.hir().expect_item(def_id);
572 if let hir::ItemKind::Struct(ref struct_def, _)
573 | hir::ItemKind::Union(ref struct_def, _) = item.kind
575 for field in struct_def.fields() {
576 let def_id = self.tcx.hir().local_def_id(field.hir_id);
577 let field_vis = self.tcx.local_visibility(def_id);
578 if field_vis.is_accessible_from(module, self.tcx) {
579 self.reach(def_id, level).ty();
583 bug!("item {:?} with DefKind {:?}", item, def_kind);
588 // These have type privacy, so are not reachable unless they're
589 // public, or are not namespaced at all.
592 | DefKind::ConstParam
593 | DefKind::Ctor(_, _)
598 | DefKind::ImplTraitPlaceholder
603 | DefKind::LifetimeParam
604 | DefKind::ExternCrate
606 | DefKind::ForeignMod
608 | DefKind::InlineConst
613 | DefKind::Generator => (),
618 impl<'tcx> Visitor<'tcx> for EmbargoVisitor<'tcx> {
619 type NestedFilter = nested_filter::All;
621 /// We want to visit items in the context of their containing
622 /// module and so forth, so supply a crate for doing a deep walk.
623 fn nested_visit_map(&mut self) -> Self::Map {
627 fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
628 let item_level = match item.kind {
629 hir::ItemKind::Impl { .. } => {
630 let impl_level = Option::<Level>::of_impl(
631 item.owner_id.def_id,
633 &self.effective_visibilities,
635 self.update(item.owner_id.def_id, impl_level)
637 _ => self.get(item.owner_id.def_id),
640 // Update levels of nested things.
642 hir::ItemKind::Enum(ref def, _) => {
643 for variant in def.variants {
644 let variant_level = self.update_with_hir_id(variant.id, item_level);
645 if let Some(ctor_hir_id) = variant.data.ctor_hir_id() {
646 self.update_with_hir_id(ctor_hir_id, item_level);
648 for field in variant.data.fields() {
649 self.update_with_hir_id(field.hir_id, variant_level);
653 hir::ItemKind::Impl(ref impl_) => {
654 for impl_item_ref in impl_.items {
655 if impl_.of_trait.is_some()
656 || self.tcx.visibility(impl_item_ref.id.owner_id).is_public()
658 self.update(impl_item_ref.id.owner_id.def_id, item_level);
662 hir::ItemKind::Trait(.., trait_item_refs) => {
663 for trait_item_ref in trait_item_refs {
664 self.update(trait_item_ref.id.owner_id.def_id, item_level);
667 hir::ItemKind::Struct(ref def, _) | hir::ItemKind::Union(ref def, _) => {
668 if let Some(ctor_hir_id) = def.ctor_hir_id() {
669 self.update_with_hir_id(ctor_hir_id, item_level);
671 for field in def.fields() {
672 let def_id = self.tcx.hir().local_def_id(field.hir_id);
673 let vis = self.tcx.visibility(def_id);
675 self.update_with_hir_id(field.hir_id, item_level);
679 hir::ItemKind::Macro(ref macro_def, _) => {
680 self.update_reachability_from_macro(item.owner_id.def_id, macro_def);
682 hir::ItemKind::ForeignMod { items, .. } => {
683 for foreign_item in items {
684 if self.tcx.visibility(foreign_item.id.owner_id).is_public() {
685 self.update(foreign_item.id.owner_id.def_id, item_level);
690 hir::ItemKind::OpaqueTy(..)
691 | hir::ItemKind::Use(..)
692 | hir::ItemKind::Static(..)
693 | hir::ItemKind::Const(..)
694 | hir::ItemKind::GlobalAsm(..)
695 | hir::ItemKind::TyAlias(..)
696 | hir::ItemKind::Mod(..)
697 | hir::ItemKind::TraitAlias(..)
698 | hir::ItemKind::Fn(..)
699 | hir::ItemKind::ExternCrate(..) => {}
702 // Mark all items in interfaces of reachable items as reachable.
704 // The interface is empty.
705 hir::ItemKind::Macro(..) | hir::ItemKind::ExternCrate(..) => {}
706 // All nested items are checked by `visit_item`.
707 hir::ItemKind::Mod(..) => {}
708 // Handled in `rustc_resolve`.
709 hir::ItemKind::Use(..) => {}
710 // The interface is empty.
711 hir::ItemKind::GlobalAsm(..) => {}
712 hir::ItemKind::OpaqueTy(ref opaque) => {
713 // HACK(jynelson): trying to infer the type of `impl trait` breaks `async-std` (and `pub async fn` in general)
714 // Since rustdoc never needs to do codegen and doesn't care about link-time reachability,
715 // mark this as unreachable.
716 // See https://github.com/rust-lang/rust/issues/75100
717 if !opaque.in_trait && !self.tcx.sess.opts.actually_rustdoc {
718 // FIXME: This is some serious pessimization intended to workaround deficiencies
719 // in the reachability pass (`middle/reachable.rs`). Types are marked as link-time
720 // reachable if they are returned via `impl Trait`, even from private functions.
721 let exist_level = cmp::max(item_level, Some(Level::ReachableThroughImplTrait));
722 self.reach(item.owner_id.def_id, exist_level).generics().predicates().ty();
726 hir::ItemKind::Const(..)
727 | hir::ItemKind::Static(..)
728 | hir::ItemKind::Fn(..)
729 | hir::ItemKind::TyAlias(..) => {
730 if item_level.is_some() {
731 self.reach(item.owner_id.def_id, item_level).generics().predicates().ty();
734 hir::ItemKind::Trait(.., trait_item_refs) => {
735 if item_level.is_some() {
736 self.reach(item.owner_id.def_id, item_level).generics().predicates();
738 for trait_item_ref in trait_item_refs {
740 let mut reach = self.reach(trait_item_ref.id.owner_id.def_id, item_level);
741 reach.generics().predicates();
743 if trait_item_ref.kind == AssocItemKind::Type
744 && !tcx.impl_defaultness(trait_item_ref.id.owner_id).has_value()
753 hir::ItemKind::TraitAlias(..) => {
754 if item_level.is_some() {
755 self.reach(item.owner_id.def_id, item_level).generics().predicates();
758 // Visit everything except for private impl items.
759 hir::ItemKind::Impl(ref impl_) => {
760 if item_level.is_some() {
761 self.reach(item.owner_id.def_id, item_level)
767 for impl_item_ref in impl_.items {
768 let impl_item_level = self.get(impl_item_ref.id.owner_id.def_id);
769 if impl_item_level.is_some() {
770 self.reach(impl_item_ref.id.owner_id.def_id, impl_item_level)
779 // Visit everything, but enum variants have their own levels.
780 hir::ItemKind::Enum(ref def, _) => {
781 if item_level.is_some() {
782 self.reach(item.owner_id.def_id, item_level).generics().predicates();
784 for variant in def.variants {
785 let variant_level = self.get(self.tcx.hir().local_def_id(variant.id));
786 if variant_level.is_some() {
787 for field in variant.data.fields() {
788 self.reach(self.tcx.hir().local_def_id(field.hir_id), variant_level)
791 // Corner case: if the variant is reachable, but its
792 // enum is not, make the enum reachable as well.
793 self.reach(item.owner_id.def_id, variant_level).ty();
795 if let Some(hir_id) = variant.data.ctor_hir_id() {
796 let ctor_def_id = self.tcx.hir().local_def_id(hir_id);
797 let ctor_level = self.get(ctor_def_id);
798 if ctor_level.is_some() {
799 self.reach(item.owner_id.def_id, ctor_level).ty();
804 // Visit everything, but foreign items have their own levels.
805 hir::ItemKind::ForeignMod { items, .. } => {
806 for foreign_item in items {
807 let foreign_item_level = self.get(foreign_item.id.owner_id.def_id);
808 if foreign_item_level.is_some() {
809 self.reach(foreign_item.id.owner_id.def_id, foreign_item_level)
816 // Visit everything except for private fields.
817 hir::ItemKind::Struct(ref struct_def, _) | hir::ItemKind::Union(ref struct_def, _) => {
818 if item_level.is_some() {
819 self.reach(item.owner_id.def_id, item_level).generics().predicates();
820 for field in struct_def.fields() {
821 let def_id = self.tcx.hir().local_def_id(field.hir_id);
822 let field_level = self.get(def_id);
823 if field_level.is_some() {
824 self.reach(def_id, field_level).ty();
828 if let Some(hir_id) = struct_def.ctor_hir_id() {
829 let ctor_def_id = self.tcx.hir().local_def_id(hir_id);
830 let ctor_level = self.get(ctor_def_id);
831 if ctor_level.is_some() {
832 self.reach(item.owner_id.def_id, ctor_level).ty();
838 let orig_level = mem::replace(&mut self.prev_level, item_level);
839 intravisit::walk_item(self, item);
840 self.prev_level = orig_level;
843 fn visit_block(&mut self, b: &'tcx hir::Block<'tcx>) {
844 // Blocks can have public items, for example impls, but they always
845 // start as completely private regardless of publicity of a function,
846 // constant, type, field, etc., in which this block resides.
847 let orig_level = mem::replace(&mut self.prev_level, None);
848 intravisit::walk_block(self, b);
849 self.prev_level = orig_level;
853 impl ReachEverythingInTheInterfaceVisitor<'_, '_> {
854 fn generics(&mut self) -> &mut Self {
855 for param in &self.ev.tcx.generics_of(self.item_def_id).params {
857 GenericParamDefKind::Lifetime => {}
858 GenericParamDefKind::Type { has_default, .. } => {
860 self.visit(self.ev.tcx.type_of(param.def_id));
863 GenericParamDefKind::Const { has_default } => {
864 self.visit(self.ev.tcx.type_of(param.def_id));
866 self.visit(self.ev.tcx.const_param_default(param.def_id));
874 fn predicates(&mut self) -> &mut Self {
875 self.visit_predicates(self.ev.tcx.predicates_of(self.item_def_id));
879 fn ty(&mut self) -> &mut Self {
880 self.visit(self.ev.tcx.type_of(self.item_def_id));
884 fn trait_ref(&mut self) -> &mut Self {
885 if let Some(trait_ref) = self.ev.tcx.impl_trait_ref(self.item_def_id) {
886 self.visit_trait(trait_ref);
892 impl<'tcx> DefIdVisitor<'tcx> for ReachEverythingInTheInterfaceVisitor<'_, 'tcx> {
893 fn tcx(&self) -> TyCtxt<'tcx> {
900 _descr: &dyn fmt::Display,
901 ) -> ControlFlow<Self::BreakTy> {
902 if let Some(def_id) = def_id.as_local() {
903 if let (ty::Visibility::Public, _) | (_, Some(Level::ReachableThroughImplTrait)) =
904 (self.tcx().visibility(def_id.to_def_id()), self.level)
906 self.ev.update(def_id, self.level);
909 ControlFlow::CONTINUE
913 ////////////////////////////////////////////////////////////////////////////////
914 /// Visitor, used for EffectiveVisibilities table checking
915 ////////////////////////////////////////////////////////////////////////////////
916 pub struct TestReachabilityVisitor<'tcx, 'a> {
918 effective_visibilities: &'a EffectiveVisibilities,
921 impl<'tcx, 'a> TestReachabilityVisitor<'tcx, 'a> {
922 fn effective_visibility_diagnostic(&mut self, def_id: LocalDefId) {
923 if self.tcx.has_attr(def_id.to_def_id(), sym::rustc_effective_visibility) {
924 let mut error_msg = String::new();
925 let span = self.tcx.def_span(def_id.to_def_id());
926 if let Some(effective_vis) = self.effective_visibilities.effective_vis(def_id) {
927 for level in Level::all_levels() {
928 let vis_str = match effective_vis.at_level(level) {
929 ty::Visibility::Restricted(restricted_id) => {
930 if restricted_id.is_top_level_module() {
931 "pub(crate)".to_string()
932 } else if *restricted_id == self.tcx.parent_module_from_def_id(def_id) {
933 "pub(self)".to_string()
935 format!("pub({})", self.tcx.item_name(restricted_id.to_def_id()))
938 ty::Visibility::Public => "pub".to_string(),
940 if level != Level::Direct {
941 error_msg.push_str(", ");
943 error_msg.push_str(&format!("{:?}: {}", level, vis_str));
946 error_msg.push_str("not in the table");
948 self.tcx.sess.emit_err(ReportEffectiveVisibility { span, descr: error_msg });
953 impl<'tcx, 'a> Visitor<'tcx> for TestReachabilityVisitor<'tcx, 'a> {
954 fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
955 self.effective_visibility_diagnostic(item.owner_id.def_id);
958 hir::ItemKind::Enum(ref def, _) => {
959 for variant in def.variants.iter() {
960 let variant_id = self.tcx.hir().local_def_id(variant.id);
961 self.effective_visibility_diagnostic(variant_id);
962 for field in variant.data.fields() {
963 let def_id = self.tcx.hir().local_def_id(field.hir_id);
964 self.effective_visibility_diagnostic(def_id);
968 hir::ItemKind::Struct(ref def, _) | hir::ItemKind::Union(ref def, _) => {
969 for field in def.fields() {
970 let def_id = self.tcx.hir().local_def_id(field.hir_id);
971 self.effective_visibility_diagnostic(def_id);
978 fn visit_trait_item(&mut self, item: &'tcx hir::TraitItem<'tcx>) {
979 self.effective_visibility_diagnostic(item.owner_id.def_id);
981 fn visit_impl_item(&mut self, item: &'tcx hir::ImplItem<'tcx>) {
982 self.effective_visibility_diagnostic(item.owner_id.def_id);
984 fn visit_foreign_item(&mut self, item: &'tcx hir::ForeignItem<'tcx>) {
985 self.effective_visibility_diagnostic(item.owner_id.def_id);
989 //////////////////////////////////////////////////////////////////////////////////////
990 /// Name privacy visitor, checks privacy and reports violations.
991 /// Most of name privacy checks are performed during the main resolution phase,
992 /// or later in type checking when field accesses and associated items are resolved.
993 /// This pass performs remaining checks for fields in struct expressions and patterns.
994 //////////////////////////////////////////////////////////////////////////////////////
996 struct NamePrivacyVisitor<'tcx> {
998 maybe_typeck_results: Option<&'tcx ty::TypeckResults<'tcx>>,
999 current_item: LocalDefId,
1002 impl<'tcx> NamePrivacyVisitor<'tcx> {
1003 /// Gets the type-checking results for the current body.
1004 /// As this will ICE if called outside bodies, only call when working with
1005 /// `Expr` or `Pat` nodes (they are guaranteed to be found only in bodies).
1007 fn typeck_results(&self) -> &'tcx ty::TypeckResults<'tcx> {
1008 self.maybe_typeck_results
1009 .expect("`NamePrivacyVisitor::typeck_results` called outside of body")
1012 // Checks that a field in a struct constructor (expression or pattern) is accessible.
1015 use_ctxt: Span, // syntax context of the field name at the use site
1016 span: Span, // span of the field pattern, e.g., `x: 0`
1017 def: ty::AdtDef<'tcx>, // definition of the struct or enum
1018 field: &'tcx ty::FieldDef,
1019 in_update_syntax: bool,
1025 // definition of the field
1026 let ident = Ident::new(kw::Empty, use_ctxt);
1027 let hir_id = self.tcx.hir().local_def_id_to_hir_id(self.current_item);
1028 let def_id = self.tcx.adjust_ident_and_get_scope(ident, def.did(), hir_id).1;
1029 if !field.vis.is_accessible_from(def_id, self.tcx) {
1030 self.tcx.sess.emit_err(FieldIsPrivate {
1032 field_name: field.name,
1033 variant_descr: def.variant_descr(),
1034 def_path_str: self.tcx.def_path_str(def.did()),
1035 label: if in_update_syntax {
1036 FieldIsPrivateLabel::IsUpdateSyntax { span, field_name: field.name }
1038 FieldIsPrivateLabel::Other { span }
1045 impl<'tcx> Visitor<'tcx> for NamePrivacyVisitor<'tcx> {
1046 type NestedFilter = nested_filter::All;
1048 /// We want to visit items in the context of their containing
1049 /// module and so forth, so supply a crate for doing a deep walk.
1050 fn nested_visit_map(&mut self) -> Self::Map {
1054 fn visit_mod(&mut self, _m: &'tcx hir::Mod<'tcx>, _s: Span, _n: hir::HirId) {
1055 // Don't visit nested modules, since we run a separate visitor walk
1056 // for each module in `effective_visibilities`
1059 fn visit_nested_body(&mut self, body: hir::BodyId) {
1060 let old_maybe_typeck_results =
1061 self.maybe_typeck_results.replace(self.tcx.typeck_body(body));
1062 let body = self.tcx.hir().body(body);
1063 self.visit_body(body);
1064 self.maybe_typeck_results = old_maybe_typeck_results;
1067 fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
1068 let orig_current_item = mem::replace(&mut self.current_item, item.owner_id.def_id);
1069 intravisit::walk_item(self, item);
1070 self.current_item = orig_current_item;
1073 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) {
1074 if let hir::ExprKind::Struct(qpath, fields, ref base) = expr.kind {
1075 let res = self.typeck_results().qpath_res(qpath, expr.hir_id);
1076 let adt = self.typeck_results().expr_ty(expr).ty_adt_def().unwrap();
1077 let variant = adt.variant_of_res(res);
1078 if let Some(base) = *base {
1079 // If the expression uses FRU we need to make sure all the unmentioned fields
1080 // are checked for privacy (RFC 736). Rather than computing the set of
1081 // unmentioned fields, just check them all.
1082 for (vf_index, variant_field) in variant.fields.iter().enumerate() {
1083 let field = fields.iter().find(|f| {
1084 self.tcx.field_index(f.hir_id, self.typeck_results()) == vf_index
1086 let (use_ctxt, span) = match field {
1087 Some(field) => (field.ident.span, field.span),
1088 None => (base.span, base.span),
1090 self.check_field(use_ctxt, span, adt, variant_field, true);
1093 for field in fields {
1094 let use_ctxt = field.ident.span;
1095 let index = self.tcx.field_index(field.hir_id, self.typeck_results());
1096 self.check_field(use_ctxt, field.span, adt, &variant.fields[index], false);
1101 intravisit::walk_expr(self, expr);
1104 fn visit_pat(&mut self, pat: &'tcx hir::Pat<'tcx>) {
1105 if let PatKind::Struct(ref qpath, fields, _) = pat.kind {
1106 let res = self.typeck_results().qpath_res(qpath, pat.hir_id);
1107 let adt = self.typeck_results().pat_ty(pat).ty_adt_def().unwrap();
1108 let variant = adt.variant_of_res(res);
1109 for field in fields {
1110 let use_ctxt = field.ident.span;
1111 let index = self.tcx.field_index(field.hir_id, self.typeck_results());
1112 self.check_field(use_ctxt, field.span, adt, &variant.fields[index], false);
1116 intravisit::walk_pat(self, pat);
1120 ////////////////////////////////////////////////////////////////////////////////////////////
1121 /// Type privacy visitor, checks types for privacy and reports violations.
1122 /// Both explicitly written types and inferred types of expressions and patterns are checked.
1123 /// Checks are performed on "semantic" types regardless of names and their hygiene.
1124 ////////////////////////////////////////////////////////////////////////////////////////////
1126 struct TypePrivacyVisitor<'tcx> {
1128 maybe_typeck_results: Option<&'tcx ty::TypeckResults<'tcx>>,
1129 current_item: LocalDefId,
1133 impl<'tcx> TypePrivacyVisitor<'tcx> {
1134 /// Gets the type-checking results for the current body.
1135 /// As this will ICE if called outside bodies, only call when working with
1136 /// `Expr` or `Pat` nodes (they are guaranteed to be found only in bodies).
1138 fn typeck_results(&self) -> &'tcx ty::TypeckResults<'tcx> {
1139 self.maybe_typeck_results
1140 .expect("`TypePrivacyVisitor::typeck_results` called outside of body")
1143 fn item_is_accessible(&self, did: DefId) -> bool {
1144 self.tcx.visibility(did).is_accessible_from(self.current_item, self.tcx)
1147 // Take node-id of an expression or pattern and check its type for privacy.
1148 fn check_expr_pat_type(&mut self, id: hir::HirId, span: Span) -> bool {
1150 let typeck_results = self.typeck_results();
1151 let result: ControlFlow<()> = try {
1152 self.visit(typeck_results.node_type(id))?;
1153 self.visit(typeck_results.node_substs(id))?;
1154 if let Some(adjustments) = typeck_results.adjustments().get(id) {
1155 adjustments.iter().try_for_each(|adjustment| self.visit(adjustment.target))?;
1161 fn check_def_id(&mut self, def_id: DefId, kind: &str, descr: &dyn fmt::Display) -> bool {
1162 let is_error = !self.item_is_accessible(def_id);
1164 self.tcx.sess.emit_err(ItemIsPrivate { span: self.span, kind, descr: descr.into() });
1170 impl<'tcx> Visitor<'tcx> for TypePrivacyVisitor<'tcx> {
1171 type NestedFilter = nested_filter::All;
1173 /// We want to visit items in the context of their containing
1174 /// module and so forth, so supply a crate for doing a deep walk.
1175 fn nested_visit_map(&mut self) -> Self::Map {
1179 fn visit_mod(&mut self, _m: &'tcx hir::Mod<'tcx>, _s: Span, _n: hir::HirId) {
1180 // Don't visit nested modules, since we run a separate visitor walk
1181 // for each module in `effective_visibilities`
1184 fn visit_nested_body(&mut self, body: hir::BodyId) {
1185 let old_maybe_typeck_results =
1186 self.maybe_typeck_results.replace(self.tcx.typeck_body(body));
1187 let body = self.tcx.hir().body(body);
1188 self.visit_body(body);
1189 self.maybe_typeck_results = old_maybe_typeck_results;
1192 fn visit_generic_arg(&mut self, generic_arg: &'tcx hir::GenericArg<'tcx>) {
1194 hir::GenericArg::Type(t) => self.visit_ty(t),
1195 hir::GenericArg::Infer(inf) => self.visit_infer(inf),
1196 hir::GenericArg::Lifetime(_) | hir::GenericArg::Const(_) => {}
1200 fn visit_ty(&mut self, hir_ty: &'tcx hir::Ty<'tcx>) {
1201 self.span = hir_ty.span;
1202 if let Some(typeck_results) = self.maybe_typeck_results {
1204 if self.visit(typeck_results.node_type(hir_ty.hir_id)).is_break() {
1208 // Types in signatures.
1209 // FIXME: This is very ineffective. Ideally each HIR type should be converted
1210 // into a semantic type only once and the result should be cached somehow.
1211 if self.visit(rustc_hir_analysis::hir_ty_to_ty(self.tcx, hir_ty)).is_break() {
1216 intravisit::walk_ty(self, hir_ty);
1219 fn visit_infer(&mut self, inf: &'tcx hir::InferArg) {
1220 self.span = inf.span;
1221 if let Some(typeck_results) = self.maybe_typeck_results {
1222 if let Some(ty) = typeck_results.node_type_opt(inf.hir_id) {
1223 if self.visit(ty).is_break() {
1227 // We don't do anything for const infers here.
1230 bug!("visit_infer without typeck_results");
1232 intravisit::walk_inf(self, inf);
1235 fn visit_trait_ref(&mut self, trait_ref: &'tcx hir::TraitRef<'tcx>) {
1236 self.span = trait_ref.path.span;
1237 if self.maybe_typeck_results.is_none() {
1238 // Avoid calling `hir_trait_to_predicates` in bodies, it will ICE.
1239 // The traits' privacy in bodies is already checked as a part of trait object types.
1240 let bounds = rustc_hir_analysis::hir_trait_to_predicates(
1243 // NOTE: This isn't really right, but the actual type doesn't matter here. It's
1244 // just required by `ty::TraitRef`.
1245 self.tcx.types.never,
1248 for (trait_predicate, _, _) in bounds.trait_bounds {
1249 if self.visit_trait(trait_predicate.skip_binder()).is_break() {
1254 for (poly_predicate, _) in bounds.projection_bounds {
1255 let pred = poly_predicate.skip_binder();
1256 let poly_pred_term = self.visit(pred.term);
1257 if poly_pred_term.is_break()
1258 || self.visit_projection_ty(pred.projection_ty).is_break()
1265 intravisit::walk_trait_ref(self, trait_ref);
1268 // Check types of expressions
1269 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) {
1270 if self.check_expr_pat_type(expr.hir_id, expr.span) {
1271 // Do not check nested expressions if the error already happened.
1275 hir::ExprKind::Assign(_, rhs, _) | hir::ExprKind::Match(rhs, ..) => {
1276 // Do not report duplicate errors for `x = y` and `match x { ... }`.
1277 if self.check_expr_pat_type(rhs.hir_id, rhs.span) {
1281 hir::ExprKind::MethodCall(segment, ..) => {
1282 // Method calls have to be checked specially.
1283 self.span = segment.ident.span;
1284 if let Some(def_id) = self.typeck_results().type_dependent_def_id(expr.hir_id) {
1285 if self.visit(self.tcx.type_of(def_id)).is_break() {
1291 .delay_span_bug(expr.span, "no type-dependent def for method call");
1297 intravisit::walk_expr(self, expr);
1300 // Prohibit access to associated items with insufficient nominal visibility.
1302 // Additionally, until better reachability analysis for macros 2.0 is available,
1303 // we prohibit access to private statics from other crates, this allows to give
1304 // more code internal visibility at link time. (Access to private functions
1305 // is already prohibited by type privacy for function types.)
1306 fn visit_qpath(&mut self, qpath: &'tcx hir::QPath<'tcx>, id: hir::HirId, span: Span) {
1307 let def = match qpath {
1308 hir::QPath::Resolved(_, path) => match path.res {
1309 Res::Def(kind, def_id) => Some((kind, def_id)),
1312 hir::QPath::TypeRelative(..) | hir::QPath::LangItem(..) => self
1313 .maybe_typeck_results
1314 .and_then(|typeck_results| typeck_results.type_dependent_def(id)),
1316 let def = def.filter(|(kind, _)| {
1319 DefKind::AssocFn | DefKind::AssocConst | DefKind::AssocTy | DefKind::Static(_)
1322 if let Some((kind, def_id)) = def {
1323 let is_local_static =
1324 if let DefKind::Static(_) = kind { def_id.is_local() } else { false };
1325 if !self.item_is_accessible(def_id) && !is_local_static {
1326 let sess = self.tcx.sess;
1327 let sm = sess.source_map();
1328 let name = match qpath {
1329 hir::QPath::Resolved(..) | hir::QPath::LangItem(..) => {
1330 sm.span_to_snippet(qpath.span()).ok()
1332 hir::QPath::TypeRelative(_, segment) => Some(segment.ident.to_string()),
1334 let kind = kind.descr(def_id);
1335 let _ = match name {
1337 sess.emit_err(ItemIsPrivate { span, kind, descr: (&name).into() })
1339 None => sess.emit_err(UnnamedItemIsPrivate { span, kind }),
1345 intravisit::walk_qpath(self, qpath, id);
1348 // Check types of patterns.
1349 fn visit_pat(&mut self, pattern: &'tcx hir::Pat<'tcx>) {
1350 if self.check_expr_pat_type(pattern.hir_id, pattern.span) {
1351 // Do not check nested patterns if the error already happened.
1355 intravisit::walk_pat(self, pattern);
1358 fn visit_local(&mut self, local: &'tcx hir::Local<'tcx>) {
1359 if let Some(init) = local.init {
1360 if self.check_expr_pat_type(init.hir_id, init.span) {
1361 // Do not report duplicate errors for `let x = y`.
1366 intravisit::walk_local(self, local);
1369 // Check types in item interfaces.
1370 fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
1371 let orig_current_item = mem::replace(&mut self.current_item, item.owner_id.def_id);
1372 let old_maybe_typeck_results = self.maybe_typeck_results.take();
1373 intravisit::walk_item(self, item);
1374 self.maybe_typeck_results = old_maybe_typeck_results;
1375 self.current_item = orig_current_item;
1379 impl<'tcx> DefIdVisitor<'tcx> for TypePrivacyVisitor<'tcx> {
1380 fn tcx(&self) -> TyCtxt<'tcx> {
1387 descr: &dyn fmt::Display,
1388 ) -> ControlFlow<Self::BreakTy> {
1389 if self.check_def_id(def_id, kind, descr) {
1392 ControlFlow::CONTINUE
1397 ///////////////////////////////////////////////////////////////////////////////
1398 /// Obsolete visitors for checking for private items in public interfaces.
1399 /// These visitors are supposed to be kept in frozen state and produce an
1400 /// "old error node set". For backward compatibility the new visitor reports
1401 /// warnings instead of hard errors when the erroneous node is not in this old set.
1402 ///////////////////////////////////////////////////////////////////////////////
1404 struct ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> {
1406 effective_visibilities: &'a EffectiveVisibilities,
1408 // Set of errors produced by this obsolete visitor.
1409 old_error_set: HirIdSet,
1412 struct ObsoleteCheckTypeForPrivatenessVisitor<'a, 'b, 'tcx> {
1413 inner: &'a ObsoleteVisiblePrivateTypesVisitor<'b, 'tcx>,
1414 /// Whether the type refers to private types.
1415 contains_private: bool,
1416 /// Whether we've recurred at all (i.e., if we're pointing at the
1417 /// first type on which `visit_ty` was called).
1418 at_outer_type: bool,
1419 /// Whether that first type is a public path.
1420 outer_type_is_public_path: bool,
1423 impl<'a, 'tcx> ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> {
1424 fn path_is_private_type(&self, path: &hir::Path<'_>) -> bool {
1425 let did = match path.res {
1426 Res::PrimTy(..) | Res::SelfTyParam { .. } | Res::SelfTyAlias { .. } | Res::Err => {
1429 res => res.def_id(),
1432 // A path can only be private if:
1433 // it's in this crate...
1434 if let Some(did) = did.as_local() {
1435 // .. and it corresponds to a private type in the AST (this returns
1436 // `None` for type parameters).
1437 match self.tcx.hir().find(self.tcx.hir().local_def_id_to_hir_id(did)) {
1438 Some(Node::Item(_)) => !self.tcx.visibility(did).is_public(),
1439 Some(_) | None => false,
1446 fn trait_is_public(&self, trait_id: LocalDefId) -> bool {
1447 // FIXME: this would preferably be using `exported_items`, but all
1448 // traits are exported currently (see `EmbargoVisitor.exported_trait`).
1449 self.effective_visibilities.is_directly_public(trait_id)
1452 fn check_generic_bound(&mut self, bound: &hir::GenericBound<'_>) {
1453 if let hir::GenericBound::Trait(ref trait_ref, _) = *bound {
1454 if self.path_is_private_type(trait_ref.trait_ref.path) {
1455 self.old_error_set.insert(trait_ref.trait_ref.hir_ref_id);
1460 fn item_is_public(&self, def_id: LocalDefId) -> bool {
1461 self.effective_visibilities.is_reachable(def_id) || self.tcx.visibility(def_id).is_public()
1465 impl<'a, 'b, 'tcx, 'v> Visitor<'v> for ObsoleteCheckTypeForPrivatenessVisitor<'a, 'b, 'tcx> {
1466 fn visit_generic_arg(&mut self, generic_arg: &'v hir::GenericArg<'v>) {
1468 hir::GenericArg::Type(t) => self.visit_ty(t),
1469 hir::GenericArg::Infer(inf) => self.visit_ty(&inf.to_ty()),
1470 hir::GenericArg::Lifetime(_) | hir::GenericArg::Const(_) => {}
1474 fn visit_ty(&mut self, ty: &hir::Ty<'_>) {
1475 if let hir::TyKind::Path(hir::QPath::Resolved(_, path)) = ty.kind {
1476 if self.inner.path_is_private_type(path) {
1477 self.contains_private = true;
1478 // Found what we're looking for, so let's stop working.
1482 if let hir::TyKind::Path(_) = ty.kind {
1483 if self.at_outer_type {
1484 self.outer_type_is_public_path = true;
1487 self.at_outer_type = false;
1488 intravisit::walk_ty(self, ty)
1491 // Don't want to recurse into `[, .. expr]`.
1492 fn visit_expr(&mut self, _: &hir::Expr<'_>) {}
1495 impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> {
1496 type NestedFilter = nested_filter::All;
1498 /// We want to visit items in the context of their containing
1499 /// module and so forth, so supply a crate for doing a deep walk.
1500 fn nested_visit_map(&mut self) -> Self::Map {
1504 fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
1506 // Contents of a private mod can be re-exported, so we need
1507 // to check internals.
1508 hir::ItemKind::Mod(_) => {}
1510 // An `extern {}` doesn't introduce a new privacy
1511 // namespace (the contents have their own privacies).
1512 hir::ItemKind::ForeignMod { .. } => {}
1514 hir::ItemKind::Trait(.., bounds, _) => {
1515 if !self.trait_is_public(item.owner_id.def_id) {
1519 for bound in bounds.iter() {
1520 self.check_generic_bound(bound)
1524 // Impls need some special handling to try to offer useful
1525 // error messages without (too many) false positives
1526 // (i.e., we could just return here to not check them at
1527 // all, or some worse estimation of whether an impl is
1528 // publicly visible).
1529 hir::ItemKind::Impl(ref impl_) => {
1530 // `impl [... for] Private` is never visible.
1531 let self_contains_private;
1532 // `impl [... for] Public<...>`, but not `impl [... for]
1533 // Vec<Public>` or `(Public,)`, etc.
1534 let self_is_public_path;
1536 // Check the properties of the `Self` type:
1538 let mut visitor = ObsoleteCheckTypeForPrivatenessVisitor {
1540 contains_private: false,
1541 at_outer_type: true,
1542 outer_type_is_public_path: false,
1544 visitor.visit_ty(impl_.self_ty);
1545 self_contains_private = visitor.contains_private;
1546 self_is_public_path = visitor.outer_type_is_public_path;
1549 // Miscellaneous info about the impl:
1551 // `true` iff this is `impl Private for ...`.
1552 let not_private_trait = impl_.of_trait.as_ref().map_or(
1553 true, // no trait counts as public trait
1555 if let Some(def_id) = tr.path.res.def_id().as_local() {
1556 self.trait_is_public(def_id)
1558 true // external traits must be public
1563 // `true` iff this is a trait impl or at least one method is public.
1565 // `impl Public { $( fn ...() {} )* }` is not visible.
1567 // This is required over just using the methods' privacy
1568 // directly because we might have `impl<T: Foo<Private>> ...`,
1569 // and we shouldn't warn about the generics if all the methods
1570 // are private (because `T` won't be visible externally).
1571 let trait_or_some_public_method = impl_.of_trait.is_some()
1572 || impl_.items.iter().any(|impl_item_ref| {
1573 let impl_item = self.tcx.hir().impl_item(impl_item_ref.id);
1574 match impl_item.kind {
1575 hir::ImplItemKind::Const(..) | hir::ImplItemKind::Fn(..) => self
1576 .effective_visibilities
1577 .is_reachable(impl_item_ref.id.owner_id.def_id),
1578 hir::ImplItemKind::Type(_) => false,
1582 if !self_contains_private && not_private_trait && trait_or_some_public_method {
1583 intravisit::walk_generics(self, &impl_.generics);
1585 match impl_.of_trait {
1587 for impl_item_ref in impl_.items {
1588 // This is where we choose whether to walk down
1589 // further into the impl to check its items. We
1590 // should only walk into public items so that we
1591 // don't erroneously report errors for private
1592 // types in private items.
1593 let impl_item = self.tcx.hir().impl_item(impl_item_ref.id);
1594 match impl_item.kind {
1595 hir::ImplItemKind::Const(..) | hir::ImplItemKind::Fn(..)
1596 if self.item_is_public(impl_item.owner_id.def_id) =>
1598 intravisit::walk_impl_item(self, impl_item)
1600 hir::ImplItemKind::Type(..) => {
1601 intravisit::walk_impl_item(self, impl_item)
1608 // Any private types in a trait impl fall into three
1610 // 1. mentioned in the trait definition
1611 // 2. mentioned in the type params/generics
1612 // 3. mentioned in the associated types of the impl
1614 // Those in 1. can only occur if the trait is in
1615 // this crate and will have been warned about on the
1616 // trait definition (there's no need to warn twice
1617 // so we don't check the methods).
1619 // Those in 2. are warned via walk_generics and this
1621 intravisit::walk_path(self, tr.path);
1623 // Those in 3. are warned with this call.
1624 for impl_item_ref in impl_.items {
1625 let impl_item = self.tcx.hir().impl_item(impl_item_ref.id);
1626 if let hir::ImplItemKind::Type(ty) = impl_item.kind {
1632 } else if impl_.of_trait.is_none() && self_is_public_path {
1633 // `impl Public<Private> { ... }`. Any public static
1634 // methods will be visible as `Public::foo`.
1635 let mut found_pub_static = false;
1636 for impl_item_ref in impl_.items {
1638 .effective_visibilities
1639 .is_reachable(impl_item_ref.id.owner_id.def_id)
1640 || self.tcx.visibility(impl_item_ref.id.owner_id).is_public()
1642 let impl_item = self.tcx.hir().impl_item(impl_item_ref.id);
1643 match impl_item_ref.kind {
1644 AssocItemKind::Const => {
1645 found_pub_static = true;
1646 intravisit::walk_impl_item(self, impl_item);
1648 AssocItemKind::Fn { has_self: false } => {
1649 found_pub_static = true;
1650 intravisit::walk_impl_item(self, impl_item);
1656 if found_pub_static {
1657 intravisit::walk_generics(self, &impl_.generics)
1663 // `type ... = ...;` can contain private types, because
1664 // we're introducing a new name.
1665 hir::ItemKind::TyAlias(..) => return,
1667 // Not at all public, so we don't care.
1668 _ if !self.item_is_public(item.owner_id.def_id) => {
1675 // We've carefully constructed it so that if we're here, then
1676 // any `visit_ty`'s will be called on things that are in
1677 // public signatures, i.e., things that we're interested in for
1679 intravisit::walk_item(self, item);
1682 fn visit_generics(&mut self, generics: &'tcx hir::Generics<'tcx>) {
1683 for predicate in generics.predicates {
1685 hir::WherePredicate::BoundPredicate(bound_pred) => {
1686 for bound in bound_pred.bounds.iter() {
1687 self.check_generic_bound(bound)
1690 hir::WherePredicate::RegionPredicate(_) => {}
1691 hir::WherePredicate::EqPredicate(eq_pred) => {
1692 self.visit_ty(eq_pred.rhs_ty);
1698 fn visit_foreign_item(&mut self, item: &'tcx hir::ForeignItem<'tcx>) {
1699 if self.effective_visibilities.is_reachable(item.owner_id.def_id) {
1700 intravisit::walk_foreign_item(self, item)
1704 fn visit_ty(&mut self, t: &'tcx hir::Ty<'tcx>) {
1705 if let hir::TyKind::Path(hir::QPath::Resolved(_, path)) = t.kind {
1706 if self.path_is_private_type(path) {
1707 self.old_error_set.insert(t.hir_id);
1710 intravisit::walk_ty(self, t)
1713 fn visit_variant(&mut self, v: &'tcx hir::Variant<'tcx>) {
1714 if self.effective_visibilities.is_reachable(self.tcx.hir().local_def_id(v.id)) {
1715 self.in_variant = true;
1716 intravisit::walk_variant(self, v);
1717 self.in_variant = false;
1721 fn visit_field_def(&mut self, s: &'tcx hir::FieldDef<'tcx>) {
1722 let def_id = self.tcx.hir().local_def_id(s.hir_id);
1723 let vis = self.tcx.visibility(def_id);
1724 if vis.is_public() || self.in_variant {
1725 intravisit::walk_field_def(self, s);
1729 // We don't need to introspect into these at all: an
1730 // expression/block context can't possibly contain exported things.
1731 // (Making them no-ops stops us from traversing the whole AST without
1732 // having to be super careful about our `walk_...` calls above.)
1733 fn visit_block(&mut self, _: &'tcx hir::Block<'tcx>) {}
1734 fn visit_expr(&mut self, _: &'tcx hir::Expr<'tcx>) {}
1737 ///////////////////////////////////////////////////////////////////////////////
1738 /// SearchInterfaceForPrivateItemsVisitor traverses an item's interface and
1739 /// finds any private components in it.
1740 /// PrivateItemsInPublicInterfacesVisitor ensures there are no private types
1741 /// and traits in public interfaces.
1742 ///////////////////////////////////////////////////////////////////////////////
1744 struct SearchInterfaceForPrivateItemsVisitor<'tcx> {
1746 item_def_id: LocalDefId,
1747 /// The visitor checks that each component type is at least this visible.
1748 required_visibility: ty::Visibility,
1749 has_old_errors: bool,
1753 impl SearchInterfaceForPrivateItemsVisitor<'_> {
1754 fn generics(&mut self) -> &mut Self {
1755 for param in &self.tcx.generics_of(self.item_def_id).params {
1757 GenericParamDefKind::Lifetime => {}
1758 GenericParamDefKind::Type { has_default, .. } => {
1760 self.visit(self.tcx.type_of(param.def_id));
1763 // FIXME(generic_const_exprs): May want to look inside const here
1764 GenericParamDefKind::Const { .. } => {
1765 self.visit(self.tcx.type_of(param.def_id));
1772 fn predicates(&mut self) -> &mut Self {
1773 // N.B., we use `explicit_predicates_of` and not `predicates_of`
1774 // because we don't want to report privacy errors due to where
1775 // clauses that the compiler inferred. We only want to
1776 // consider the ones that the user wrote. This is important
1777 // for the inferred outlives rules; see
1778 // `src/test/ui/rfc-2093-infer-outlives/privacy.rs`.
1779 self.visit_predicates(self.tcx.explicit_predicates_of(self.item_def_id));
1783 fn bounds(&mut self) -> &mut Self {
1784 self.visit_predicates(ty::GenericPredicates {
1786 predicates: self.tcx.explicit_item_bounds(self.item_def_id),
1791 fn ty(&mut self) -> &mut Self {
1792 self.visit(self.tcx.type_of(self.item_def_id));
1796 fn check_def_id(&mut self, def_id: DefId, kind: &str, descr: &dyn fmt::Display) -> bool {
1797 if self.leaks_private_dep(def_id) {
1798 self.tcx.emit_spanned_lint(
1799 lint::builtin::EXPORTED_PRIVATE_DEPENDENCIES,
1800 self.tcx.hir().local_def_id_to_hir_id(self.item_def_id),
1801 self.tcx.def_span(self.item_def_id.to_def_id()),
1802 FromPrivateDependencyInPublicInterface {
1804 descr: descr.into(),
1805 krate: self.tcx.crate_name(def_id.krate),
1810 let Some(local_def_id) = def_id.as_local() else {
1814 let vis = self.tcx.local_visibility(local_def_id);
1815 if !vis.is_at_least(self.required_visibility, self.tcx) {
1816 let hir_id = self.tcx.hir().local_def_id_to_hir_id(local_def_id);
1817 let vis_descr = match vis {
1818 ty::Visibility::Public => "public",
1819 ty::Visibility::Restricted(vis_def_id) => {
1820 if vis_def_id == self.tcx.parent_module(hir_id) {
1822 } else if vis_def_id.is_top_level_module() {
1829 let span = self.tcx.def_span(self.item_def_id.to_def_id());
1830 if self.has_old_errors
1832 || self.tcx.resolutions(()).has_pub_restricted
1834 let vis_span = self.tcx.def_span(def_id);
1835 if kind == "trait" {
1836 self.tcx.sess.emit_err(InPublicInterfaceTraits {
1840 descr: descr.into(),
1844 self.tcx.sess.emit_err(InPublicInterface {
1848 descr: descr.into(),
1853 self.tcx.emit_spanned_lint(
1854 lint::builtin::PRIVATE_IN_PUBLIC,
1857 PrivateInPublicLint { vis_descr, kind, descr: descr.into() },
1865 /// An item is 'leaked' from a private dependency if all
1866 /// of the following are true:
1867 /// 1. It's contained within a public type
1868 /// 2. It comes from a private crate
1869 fn leaks_private_dep(&self, item_id: DefId) -> bool {
1870 let ret = self.required_visibility.is_public() && self.tcx.is_private_dep(item_id.krate);
1872 debug!("leaks_private_dep(item_id={:?})={}", item_id, ret);
1877 impl<'tcx> DefIdVisitor<'tcx> for SearchInterfaceForPrivateItemsVisitor<'tcx> {
1878 fn tcx(&self) -> TyCtxt<'tcx> {
1885 descr: &dyn fmt::Display,
1886 ) -> ControlFlow<Self::BreakTy> {
1887 if self.check_def_id(def_id, kind, descr) {
1890 ControlFlow::CONTINUE
1895 struct PrivateItemsInPublicInterfacesChecker<'tcx> {
1897 old_error_set_ancestry: LocalDefIdSet,
1900 impl<'tcx> PrivateItemsInPublicInterfacesChecker<'tcx> {
1904 required_visibility: ty::Visibility,
1905 ) -> SearchInterfaceForPrivateItemsVisitor<'tcx> {
1906 SearchInterfaceForPrivateItemsVisitor {
1908 item_def_id: def_id,
1909 required_visibility,
1910 has_old_errors: self.old_error_set_ancestry.contains(&def_id),
1915 fn check_assoc_item(
1918 assoc_item_kind: AssocItemKind,
1919 vis: ty::Visibility,
1921 let mut check = self.check(def_id, vis);
1923 let (check_ty, is_assoc_ty) = match assoc_item_kind {
1924 AssocItemKind::Const | AssocItemKind::Fn { .. } => (true, false),
1925 AssocItemKind::Type => (self.tcx.impl_defaultness(def_id).has_value(), true),
1927 check.in_assoc_ty = is_assoc_ty;
1928 check.generics().predicates();
1934 pub fn check_item(&mut self, id: ItemId) {
1936 let def_id = id.owner_id.def_id;
1937 let item_visibility = tcx.local_visibility(def_id);
1938 let def_kind = tcx.def_kind(def_id);
1941 DefKind::Const | DefKind::Static(_) | DefKind::Fn | DefKind::TyAlias => {
1942 self.check(def_id, item_visibility).generics().predicates().ty();
1944 DefKind::OpaqueTy => {
1945 // `ty()` for opaque types is the underlying type,
1946 // it's not a part of interface, so we skip it.
1947 self.check(def_id, item_visibility).generics().bounds();
1950 let item = tcx.hir().item(id);
1951 if let hir::ItemKind::Trait(.., trait_item_refs) = item.kind {
1952 self.check(item.owner_id.def_id, item_visibility).generics().predicates();
1954 for trait_item_ref in trait_item_refs {
1955 self.check_assoc_item(
1956 trait_item_ref.id.owner_id.def_id,
1957 trait_item_ref.kind,
1961 if let AssocItemKind::Type = trait_item_ref.kind {
1962 self.check(trait_item_ref.id.owner_id.def_id, item_visibility).bounds();
1967 DefKind::TraitAlias => {
1968 self.check(def_id, item_visibility).generics().predicates();
1971 let item = tcx.hir().item(id);
1972 if let hir::ItemKind::Enum(ref def, _) = item.kind {
1973 self.check(item.owner_id.def_id, item_visibility).generics().predicates();
1975 for variant in def.variants {
1976 for field in variant.data.fields() {
1977 self.check(self.tcx.hir().local_def_id(field.hir_id), item_visibility)
1983 // Subitems of foreign modules have their own publicity.
1984 DefKind::ForeignMod => {
1985 let item = tcx.hir().item(id);
1986 if let hir::ItemKind::ForeignMod { items, .. } = item.kind {
1987 for foreign_item in items {
1988 let vis = tcx.local_visibility(foreign_item.id.owner_id.def_id);
1989 self.check(foreign_item.id.owner_id.def_id, vis)
1996 // Subitems of structs and unions have their own publicity.
1997 DefKind::Struct | DefKind::Union => {
1998 let item = tcx.hir().item(id);
1999 if let hir::ItemKind::Struct(ref struct_def, _)
2000 | hir::ItemKind::Union(ref struct_def, _) = item.kind
2002 self.check(item.owner_id.def_id, item_visibility).generics().predicates();
2004 for field in struct_def.fields() {
2005 let def_id = tcx.hir().local_def_id(field.hir_id);
2006 let field_visibility = tcx.local_visibility(def_id);
2007 self.check(def_id, min(item_visibility, field_visibility, tcx)).ty();
2011 // An inherent impl is public when its type is public
2012 // Subitems of inherent impls have their own publicity.
2013 // A trait impl is public when both its type and its trait are public
2014 // Subitems of trait impls have inherited publicity.
2016 let item = tcx.hir().item(id);
2017 if let hir::ItemKind::Impl(ref impl_) = item.kind {
2019 ty::Visibility::of_impl(item.owner_id.def_id, tcx, &Default::default());
2020 // check that private components do not appear in the generics or predicates of inherent impls
2021 // this check is intentionally NOT performed for impls of traits, per #90586
2022 if impl_.of_trait.is_none() {
2023 self.check(item.owner_id.def_id, impl_vis).generics().predicates();
2025 for impl_item_ref in impl_.items {
2026 let impl_item_vis = if impl_.of_trait.is_none() {
2028 tcx.local_visibility(impl_item_ref.id.owner_id.def_id),
2035 self.check_assoc_item(
2036 impl_item_ref.id.owner_id.def_id,
2048 pub fn provide(providers: &mut Providers) {
2049 *providers = Providers {
2051 effective_visibilities,
2052 check_private_in_public,
2058 fn visibility(tcx: TyCtxt<'_>, def_id: DefId) -> ty::Visibility<DefId> {
2059 local_visibility(tcx, def_id.expect_local()).to_def_id()
2062 fn local_visibility(tcx: TyCtxt<'_>, def_id: LocalDefId) -> ty::Visibility {
2063 match tcx.resolutions(()).visibilities.get(&def_id) {
2066 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
2067 match tcx.hir().get(hir_id) {
2068 // Unique types created for closures participate in type privacy checking.
2069 // They have visibilities inherited from the module they are defined in.
2070 Node::Expr(hir::Expr { kind: hir::ExprKind::Closure{..}, .. })
2071 // - AST lowering creates dummy `use` items which don't
2072 // get their entries in the resolver's visibility table.
2073 // - AST lowering also creates opaque type items with inherited visibilities.
2074 // Visibility on them should have no effect, but to avoid the visibility
2075 // query failing on some items, we provide it for opaque types as well.
2076 | Node::Item(hir::Item {
2077 kind: hir::ItemKind::Use(_, hir::UseKind::ListStem)
2078 | hir::ItemKind::OpaqueTy(..),
2080 }) => ty::Visibility::Restricted(tcx.parent_module(hir_id)),
2081 // Visibilities of trait impl items are inherited from their traits
2082 // and are not filled in resolve.
2083 Node::ImplItem(impl_item) => {
2084 match tcx.hir().get_by_def_id(tcx.hir().get_parent_item(hir_id).def_id) {
2085 Node::Item(hir::Item {
2086 kind: hir::ItemKind::Impl(hir::Impl { of_trait: Some(tr), .. }),
2088 }) => tr.path.res.opt_def_id().map_or_else(
2090 tcx.sess.delay_span_bug(tr.path.span, "trait without a def-id");
2091 ty::Visibility::Public
2093 |def_id| tcx.visibility(def_id).expect_local(),
2095 _ => span_bug!(impl_item.span, "the parent is not a trait impl"),
2099 tcx.def_span(def_id),
2100 "visibility table unexpectedly missing a def-id: {:?}",
2108 fn check_mod_privacy(tcx: TyCtxt<'_>, module_def_id: LocalDefId) {
2109 // Check privacy of names not checked in previous compilation stages.
2111 NamePrivacyVisitor { tcx, maybe_typeck_results: None, current_item: module_def_id };
2112 let (module, span, hir_id) = tcx.hir().get_module(module_def_id);
2114 intravisit::walk_mod(&mut visitor, module, hir_id);
2116 // Check privacy of explicitly written types and traits as well as
2117 // inferred types of expressions and patterns.
2119 TypePrivacyVisitor { tcx, maybe_typeck_results: None, current_item: module_def_id, span };
2120 intravisit::walk_mod(&mut visitor, module, hir_id);
2123 fn effective_visibilities(tcx: TyCtxt<'_>, (): ()) -> &EffectiveVisibilities {
2124 // Build up a set of all exported items in the AST. This is a set of all
2125 // items which are reachable from external crates based on visibility.
2126 let mut visitor = EmbargoVisitor {
2128 effective_visibilities: tcx.resolutions(()).effective_visibilities.clone(),
2129 macro_reachable: Default::default(),
2130 prev_level: Some(Level::Direct),
2135 tcx.hir().walk_toplevel_module(&mut visitor);
2136 if visitor.changed {
2137 visitor.changed = false;
2143 let mut check_visitor =
2144 TestReachabilityVisitor { tcx, effective_visibilities: &visitor.effective_visibilities };
2145 tcx.hir().visit_all_item_likes_in_crate(&mut check_visitor);
2147 tcx.arena.alloc(visitor.effective_visibilities)
2150 fn check_private_in_public(tcx: TyCtxt<'_>, (): ()) {
2151 let effective_visibilities = tcx.effective_visibilities(());
2153 let mut visitor = ObsoleteVisiblePrivateTypesVisitor {
2155 effective_visibilities,
2157 old_error_set: Default::default(),
2159 tcx.hir().walk_toplevel_module(&mut visitor);
2161 let mut old_error_set_ancestry = HirIdSet::default();
2162 for mut id in visitor.old_error_set.iter().copied() {
2164 if !old_error_set_ancestry.insert(id) {
2167 let parent = tcx.hir().get_parent_node(id);
2175 // Check for private types and traits in public interfaces.
2176 let mut checker = PrivateItemsInPublicInterfacesChecker {
2178 // Only definition IDs are ever searched in `old_error_set_ancestry`,
2179 // so we can filter away all non-definition IDs at this point.
2180 old_error_set_ancestry: old_error_set_ancestry
2182 .filter_map(|hir_id| tcx.hir().opt_local_def_id(hir_id))
2186 for id in tcx.hir().items() {
2187 checker.check_item(id);