1 //! This module implements some validity checks for attributes.
2 //! In particular it verifies that `#[inline]` and `#[repr]` attributes are
3 //! attached to items that actually support them and if there are
4 //! conflicts between multiple such attributes attached to the same
8 self, AttrApplication, DebugVisualizerUnreadable, InvalidAttrAtCrateLevel, ObjectLifetimeErr,
9 OnlyHasEffectOn, TransparentIncompatible, UnrecognizedReprHint,
11 use rustc_ast::{ast, AttrStyle, Attribute, LitKind, MetaItemKind, MetaItemLit, NestedMetaItem};
12 use rustc_data_structures::fx::FxHashMap;
13 use rustc_errors::{fluent, Applicability, MultiSpan};
14 use rustc_expand::base::resolve_path;
15 use rustc_feature::{AttributeDuplicates, AttributeType, BuiltinAttribute, BUILTIN_ATTRIBUTE_MAP};
17 use rustc_hir::def_id::LocalDefId;
18 use rustc_hir::intravisit::{self, Visitor};
20 self, FnSig, ForeignItem, HirId, Item, ItemKind, TraitItem, CRATE_HIR_ID, CRATE_OWNER_ID,
22 use rustc_hir::{MethodKind, Target};
23 use rustc_middle::hir::nested_filter;
24 use rustc_middle::middle::resolve_lifetime::ObjectLifetimeDefault;
25 use rustc_middle::ty::query::Providers;
26 use rustc_middle::ty::TyCtxt;
27 use rustc_session::lint::builtin::{
28 CONFLICTING_REPR_HINTS, INVALID_DOC_ATTRIBUTES, UNUSED_ATTRIBUTES,
30 use rustc_session::parse::feature_err;
31 use rustc_span::symbol::{kw, sym, Symbol};
32 use rustc_span::{Span, DUMMY_SP};
33 use rustc_target::spec::abi::Abi;
34 use std::collections::hash_map::Entry;
36 pub(crate) fn target_from_impl_item<'tcx>(
38 impl_item: &hir::ImplItem<'_>,
40 match impl_item.kind {
41 hir::ImplItemKind::Const(..) => Target::AssocConst,
42 hir::ImplItemKind::Fn(..) => {
43 let parent_def_id = tcx.hir().get_parent_item(impl_item.hir_id()).def_id;
44 let containing_item = tcx.hir().expect_item(parent_def_id);
45 let containing_impl_is_for_trait = match &containing_item.kind {
46 hir::ItemKind::Impl(impl_) => impl_.of_trait.is_some(),
47 _ => bug!("parent of an ImplItem must be an Impl"),
49 if containing_impl_is_for_trait {
50 Target::Method(MethodKind::Trait { body: true })
52 Target::Method(MethodKind::Inherent)
55 hir::ImplItemKind::Type(..) => Target::AssocTy,
59 #[derive(Clone, Copy)]
61 Item(&'tcx Item<'tcx>),
65 struct CheckAttrVisitor<'tcx> {
69 impl CheckAttrVisitor<'_> {
70 /// Checks any attribute.
76 item: Option<ItemLike<'_>>,
78 let mut doc_aliases = FxHashMap::default();
79 let mut is_valid = true;
80 let mut specified_inline = None;
81 let mut seen = FxHashMap::default();
82 let attrs = self.tcx.hir().attrs(hir_id);
84 let attr_is_valid = match attr.name_or_empty() {
85 sym::inline => self.check_inline(hir_id, attr, span, target),
86 sym::no_coverage => self.check_no_coverage(hir_id, attr, span, target),
87 sym::non_exhaustive => self.check_non_exhaustive(hir_id, attr, span, target),
88 sym::marker => self.check_marker(hir_id, attr, span, target),
89 sym::rustc_must_implement_one_of => {
90 self.check_rustc_must_implement_one_of(attr, span, target)
92 sym::target_feature => self.check_target_feature(hir_id, attr, span, target),
93 sym::thread_local => self.check_thread_local(attr, span, target),
94 sym::track_caller => {
95 self.check_track_caller(hir_id, attr.span, attrs, span, target)
97 sym::doc => self.check_doc_attrs(
101 &mut specified_inline,
104 sym::no_link => self.check_no_link(hir_id, &attr, span, target),
105 sym::export_name => self.check_export_name(hir_id, &attr, span, target),
106 sym::rustc_layout_scalar_valid_range_start
107 | sym::rustc_layout_scalar_valid_range_end => {
108 self.check_rustc_layout_scalar_valid_range(&attr, span, target)
110 sym::allow_internal_unstable => {
111 self.check_allow_internal_unstable(hir_id, &attr, span, target, &attrs)
113 sym::debugger_visualizer => self.check_debugger_visualizer(&attr, target),
114 sym::rustc_allow_const_fn_unstable => {
115 self.check_rustc_allow_const_fn_unstable(hir_id, &attr, span, target)
117 sym::rustc_std_internal_symbol => {
118 self.check_rustc_std_internal_symbol(&attr, span, target)
120 sym::naked => self.check_naked(hir_id, attr, span, target),
121 sym::rustc_legacy_const_generics => {
122 self.check_rustc_legacy_const_generics(hir_id, &attr, span, target, item)
124 sym::rustc_lint_query_instability => {
125 self.check_rustc_lint_query_instability(hir_id, &attr, span, target)
127 sym::rustc_lint_diagnostics => {
128 self.check_rustc_lint_diagnostics(hir_id, &attr, span, target)
130 sym::rustc_lint_opt_ty => self.check_rustc_lint_opt_ty(&attr, span, target),
131 sym::rustc_lint_opt_deny_field_access => {
132 self.check_rustc_lint_opt_deny_field_access(&attr, span, target)
136 | sym::rustc_if_this_changed
137 | sym::rustc_then_this_would_need => self.check_rustc_dirty_clean(&attr),
138 sym::cmse_nonsecure_entry => {
139 self.check_cmse_nonsecure_entry(hir_id, attr, span, target)
141 sym::collapse_debuginfo => self.check_collapse_debuginfo(attr, span, target),
142 sym::const_trait => self.check_const_trait(attr, span, target),
143 sym::must_not_suspend => self.check_must_not_suspend(&attr, span, target),
144 sym::must_use => self.check_must_use(hir_id, &attr, target),
145 sym::rustc_pass_by_value => self.check_pass_by_value(&attr, span, target),
146 sym::rustc_allow_incoherent_impl => {
147 self.check_allow_incoherent_impl(&attr, span, target)
149 sym::rustc_has_incoherent_inherent_impls => {
150 self.check_has_incoherent_inherent_impls(&attr, span, target)
152 sym::rustc_const_unstable
153 | sym::rustc_const_stable
156 | sym::rustc_allowed_through_unstable_modules
157 | sym::rustc_promotable => self.check_stability_promotable(&attr, span, target),
158 sym::link_ordinal => self.check_link_ordinal(&attr, span, target),
161 is_valid &= attr_is_valid;
164 match attr.name_or_empty() {
165 sym::cold => self.check_cold(hir_id, attr, span, target),
166 sym::link => self.check_link(hir_id, attr, span, target),
167 sym::link_name => self.check_link_name(hir_id, attr, span, target),
168 sym::link_section => self.check_link_section(hir_id, attr, span, target),
169 sym::no_mangle => self.check_no_mangle(hir_id, attr, span, target),
170 sym::deprecated => self.check_deprecated(hir_id, attr, span, target),
171 sym::macro_use | sym::macro_escape => self.check_macro_use(hir_id, attr, target),
172 sym::path => self.check_generic_attr(hir_id, attr, target, Target::Mod),
173 sym::plugin_registrar => self.check_plugin_registrar(hir_id, attr, target),
174 sym::macro_export => self.check_macro_export(hir_id, attr, target),
175 sym::ignore | sym::should_panic | sym::proc_macro_derive => {
176 self.check_generic_attr(hir_id, attr, target, Target::Fn)
178 sym::automatically_derived => {
179 self.check_generic_attr(hir_id, attr, target, Target::Impl)
181 sym::no_implicit_prelude => {
182 self.check_generic_attr(hir_id, attr, target, Target::Mod)
184 sym::rustc_object_lifetime_default => self.check_object_lifetime_default(hir_id),
188 let builtin = attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name));
190 if hir_id != CRATE_HIR_ID {
191 if let Some(BuiltinAttribute { type_: AttributeType::CrateLevel, .. }) =
192 attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name))
195 ast::AttrStyle::Outer => self.tcx.emit_spanned_lint(
199 errors::OuterCrateLevelAttr,
201 ast::AttrStyle::Inner => self.tcx.emit_spanned_lint(
205 errors::InnerCrateLevelAttr,
211 if let Some(BuiltinAttribute { duplicates, .. }) = builtin {
212 check_duplicates(self.tcx, attr, hir_id, *duplicates, &mut seen);
215 self.check_unused_attribute(hir_id, attr)
222 self.check_repr(attrs, span, target, item, hir_id);
223 self.check_used(attrs, target);
226 fn inline_attr_str_error_with_macro_def(&self, hir_id: HirId, attr: &Attribute, sym: &str) {
227 self.tcx.emit_spanned_lint(
231 errors::IgnoredAttrWithMacro { sym },
235 fn inline_attr_str_error_without_macro_def(&self, hir_id: HirId, attr: &Attribute, sym: &str) {
236 self.tcx.emit_spanned_lint(
240 errors::IgnoredAttr { sym },
244 /// Checks if an `#[inline]` is applied to a function or a closure. Returns `true` if valid.
245 fn check_inline(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
249 | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
250 Target::Method(MethodKind::Trait { body: false }) | Target::ForeignFn => {
251 self.tcx.emit_spanned_lint(
255 errors::IgnoredInlineAttrFnProto,
259 // FIXME(#65833): We permit associated consts to have an `#[inline]` attribute with
260 // just a lint, because we previously erroneously allowed it and some crates used it
261 // accidentally, to be compatible with crates depending on them, we can't throw an
263 Target::AssocConst => {
264 self.tcx.emit_spanned_lint(
268 errors::IgnoredInlineAttrConstants,
272 // FIXME(#80564): Same for fields, arms, and macro defs
273 Target::Field | Target::Arm | Target::MacroDef => {
274 self.inline_attr_str_error_with_macro_def(hir_id, attr, "inline");
278 self.tcx.sess.emit_err(errors::InlineNotFnOrClosure {
279 attr_span: attr.span,
287 /// Checks if a `#[no_coverage]` is applied directly to a function
288 fn check_no_coverage(
296 // no_coverage on function is fine
299 | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
301 // function prototypes can't be covered
302 Target::Method(MethodKind::Trait { body: false }) | Target::ForeignFn => {
303 self.tcx.emit_spanned_lint(
307 errors::IgnoredNoCoverageFnProto,
312 Target::Mod | Target::ForeignMod | Target::Impl | Target::Trait => {
313 self.tcx.emit_spanned_lint(
317 errors::IgnoredNoCoveragePropagate,
322 Target::Expression | Target::Statement | Target::Arm => {
323 self.tcx.emit_spanned_lint(
327 errors::IgnoredNoCoverageFnDefn,
333 self.tcx.sess.emit_err(errors::IgnoredNoCoverageNotCoverable {
334 attr_span: attr.span,
342 fn check_generic_attr(
347 allowed_target: Target,
349 if target != allowed_target {
350 self.tcx.emit_spanned_lint(
355 attr_name: attr.name_or_empty(),
356 target_name: allowed_target.name().replace(' ', "_"),
362 /// Checks if `#[naked]` is applied to a function definition.
363 fn check_naked(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
366 | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
367 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
368 // `#[allow_internal_unstable]` attribute with just a lint, because we previously
369 // erroneously allowed it and some crates used it accidentally, to be compatible
370 // with crates depending on them, we can't throw an error here.
371 Target::Field | Target::Arm | Target::MacroDef => {
372 self.inline_attr_str_error_with_macro_def(hir_id, attr, "naked");
376 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToFn {
377 attr_span: attr.span,
379 on_crate: hir_id == CRATE_HIR_ID,
386 /// Checks if `#[cmse_nonsecure_entry]` is applied to a function definition.
387 fn check_cmse_nonsecure_entry(
396 | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
398 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToFn {
399 attr_span: attr.span,
401 on_crate: hir_id == CRATE_HIR_ID,
408 /// Debugging aid for `object_lifetime_default` query.
409 fn check_object_lifetime_default(&self, hir_id: HirId) {
411 if let Some(generics) = tcx.hir().get_generics(tcx.hir().local_def_id(hir_id)) {
412 for p in generics.params {
413 let hir::GenericParamKind::Type { .. } = p.kind else { continue };
414 let default = tcx.object_lifetime_default(p.def_id);
415 let repr = match default {
416 ObjectLifetimeDefault::Empty => "BaseDefault".to_owned(),
417 ObjectLifetimeDefault::Static => "'static".to_owned(),
418 ObjectLifetimeDefault::Param(def_id) => tcx.item_name(def_id).to_string(),
419 ObjectLifetimeDefault::Ambiguous => "Ambiguous".to_owned(),
421 tcx.sess.emit_err(ObjectLifetimeErr { span: p.span, repr });
426 /// Checks if `#[collapse_debuginfo]` is applied to a macro.
427 fn check_collapse_debuginfo(&self, attr: &Attribute, span: Span, target: Target) -> bool {
429 Target::MacroDef => true,
433 .emit_err(errors::CollapseDebuginfo { attr_span: attr.span, defn_span: span });
439 /// Checks if a `#[track_caller]` is applied to a non-naked function. Returns `true` if valid.
440 fn check_track_caller(
449 _ if attrs.iter().any(|attr| attr.has_name(sym::naked)) => {
450 self.tcx.sess.emit_err(errors::NakedTrackedCaller { attr_span });
453 Target::Fn | Target::Method(..) | Target::ForeignFn | Target::Closure => true,
454 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
455 // `#[track_caller]` attribute with just a lint, because we previously
456 // erroneously allowed it and some crates used it accidentally, to be compatible
457 // with crates depending on them, we can't throw an error here.
458 Target::Field | Target::Arm | Target::MacroDef => {
460 self.inline_attr_str_error_with_macro_def(hir_id, attr, "track_caller");
465 self.tcx.sess.emit_err(errors::TrackedCallerWrongLocation {
468 on_crate: hir_id == CRATE_HIR_ID,
475 /// Checks if the `#[non_exhaustive]` attribute on an `item` is valid. Returns `true` if valid.
476 fn check_non_exhaustive(
484 Target::Struct | Target::Enum | Target::Variant => true,
485 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
486 // `#[non_exhaustive]` attribute with just a lint, because we previously
487 // erroneously allowed it and some crates used it accidentally, to be compatible
488 // with crates depending on them, we can't throw an error here.
489 Target::Field | Target::Arm | Target::MacroDef => {
490 self.inline_attr_str_error_with_macro_def(hir_id, attr, "non_exhaustive");
494 self.tcx.sess.emit_err(errors::NonExhaustiveWrongLocation {
495 attr_span: attr.span,
503 /// Checks if the `#[marker]` attribute on an `item` is valid. Returns `true` if valid.
504 fn check_marker(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
506 Target::Trait => true,
507 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
508 // `#[marker]` attribute with just a lint, because we previously
509 // erroneously allowed it and some crates used it accidentally, to be compatible
510 // with crates depending on them, we can't throw an error here.
511 Target::Field | Target::Arm | Target::MacroDef => {
512 self.inline_attr_str_error_with_macro_def(hir_id, attr, "marker");
516 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToTrait {
517 attr_span: attr.span,
525 /// Checks if the `#[rustc_must_implement_one_of]` attribute on a `target` is valid. Returns `true` if valid.
526 fn check_rustc_must_implement_one_of(
533 Target::Trait => true,
535 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToTrait {
536 attr_span: attr.span,
544 /// Checks if the `#[target_feature]` attribute on `item` is valid. Returns `true` if valid.
545 fn check_target_feature(
554 | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) => true,
555 // FIXME: #[target_feature] was previously erroneously allowed on statements and some
556 // crates used this, so only emit a warning.
557 Target::Statement => {
558 self.tcx.emit_spanned_lint(
562 errors::TargetFeatureOnStatement,
566 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
567 // `#[target_feature]` attribute with just a lint, because we previously
568 // erroneously allowed it and some crates used it accidentally, to be compatible
569 // with crates depending on them, we can't throw an error here.
570 Target::Field | Target::Arm | Target::MacroDef => {
571 self.inline_attr_str_error_with_macro_def(hir_id, attr, "target_feature");
575 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToFn {
576 attr_span: attr.span,
578 on_crate: hir_id == CRATE_HIR_ID,
585 /// Checks if the `#[thread_local]` attribute on `item` is valid. Returns `true` if valid.
586 fn check_thread_local(&self, attr: &Attribute, span: Span, target: Target) -> bool {
588 Target::ForeignStatic | Target::Static => true,
590 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToStatic {
591 attr_span: attr.span,
599 fn doc_attr_str_error(&self, meta: &NestedMetaItem, attr_name: &str) {
600 self.tcx.sess.emit_err(errors::DocExpectStr { attr_span: meta.span(), attr_name });
603 fn check_doc_alias_value(
605 meta: &NestedMetaItem,
610 aliases: &mut FxHashMap<String, Span>,
613 let span = meta.name_value_literal_span().unwrap_or_else(|| meta.span());
615 &format!("`#[doc(alias{})]`", if is_list { "(\"...\")" } else { " = \"...\"" });
616 if doc_alias == kw::Empty {
617 tcx.sess.emit_err(errors::DocAliasEmpty { span, attr_str });
621 let doc_alias_str = doc_alias.as_str();
622 if let Some(c) = doc_alias_str
624 .find(|&c| c == '"' || c == '\'' || (c.is_whitespace() && c != ' '))
626 tcx.sess.emit_err(errors::DocAliasBadChar { span, attr_str, char_: c });
629 if doc_alias_str.starts_with(' ') || doc_alias_str.ends_with(' ') {
630 tcx.sess.emit_err(errors::DocAliasStartEnd { span, attr_str });
634 let span = meta.span();
635 if let Some(location) = match target {
637 let parent_def_id = self.tcx.hir().get_parent_item(hir_id).def_id;
638 let containing_item = self.tcx.hir().expect_item(parent_def_id);
639 if Target::from_item(containing_item) == Target::Impl {
640 Some("type alias in implementation block")
645 Target::AssocConst => {
646 let parent_def_id = self.tcx.hir().get_parent_item(hir_id).def_id;
647 let containing_item = self.tcx.hir().expect_item(parent_def_id);
648 // We can't link to trait impl's consts.
649 let err = "associated constant in trait implementation block";
650 match containing_item.kind {
651 ItemKind::Impl(hir::Impl { of_trait: Some(_), .. }) => Some(err),
655 // we check the validity of params elsewhere
656 Target::Param => return false,
662 | Target::Impl => Some(target.name()),
672 | Target::ImplTraitPlaceholder
682 | Target::ForeignStatic
684 | Target::GenericParam(..)
687 | Target::ExprField => None,
689 tcx.sess.emit_err(errors::DocAliasBadLocation { span, attr_str, location });
692 let item_name = self.tcx.hir().name(hir_id);
693 if item_name == doc_alias {
694 tcx.sess.emit_err(errors::DocAliasNotAnAlias { span, attr_str });
697 if let Err(entry) = aliases.try_insert(doc_alias_str.to_owned(), span) {
698 self.tcx.emit_spanned_lint(
702 errors::DocAliasDuplicated { first_defn: *entry.entry.get() },
710 meta: &NestedMetaItem,
713 aliases: &mut FxHashMap<String, Span>,
715 if let Some(values) = meta.meta_item_list() {
719 Some(l) => match l.kind {
720 LitKind::Str(s, _) => {
721 if !self.check_doc_alias_value(v, s, hir_id, target, true, aliases) {
728 .emit_err(errors::DocAliasNotStringLiteral { span: v.span() });
733 self.tcx.sess.emit_err(errors::DocAliasNotStringLiteral { span: v.span() });
739 } else if let Some(doc_alias) = meta.value_str() {
740 self.check_doc_alias_value(meta, doc_alias, hir_id, target, false, aliases)
742 self.tcx.sess.emit_err(errors::DocAliasMalformed { span: meta.span() });
747 fn check_doc_keyword(&self, meta: &NestedMetaItem, hir_id: HirId) -> bool {
748 let doc_keyword = meta.value_str().unwrap_or(kw::Empty);
749 if doc_keyword == kw::Empty {
750 self.doc_attr_str_error(meta, "keyword");
753 match self.tcx.hir().find(hir_id).and_then(|node| match node {
754 hir::Node::Item(item) => Some(&item.kind),
757 Some(ItemKind::Mod(ref module)) => {
758 if !module.item_ids.is_empty() {
759 self.tcx.sess.emit_err(errors::DocKeywordEmptyMod { span: meta.span() });
764 self.tcx.sess.emit_err(errors::DocKeywordNotMod { span: meta.span() });
768 if !rustc_lexer::is_ident(doc_keyword.as_str()) {
769 self.tcx.sess.emit_err(errors::DocKeywordInvalidIdent {
770 span: meta.name_value_literal_span().unwrap_or_else(|| meta.span()),
778 fn check_doc_fake_variadic(&self, meta: &NestedMetaItem, hir_id: HirId) -> bool {
779 match self.tcx.hir().find(hir_id).and_then(|node| match node {
780 hir::Node::Item(item) => Some(&item.kind),
783 Some(ItemKind::Impl(ref i)) => {
784 let is_valid = matches!(&i.self_ty.kind, hir::TyKind::Tup([_]))
785 || if let hir::TyKind::BareFn(bare_fn_ty) = &i.self_ty.kind {
786 bare_fn_ty.decl.inputs.len() == 1
791 self.tcx.sess.emit_err(errors::DocFakeVariadicNotValid { span: meta.span() });
796 self.tcx.sess.emit_err(errors::DocKeywordOnlyImpl { span: meta.span() });
803 /// Checks `#[doc(inline)]`/`#[doc(no_inline)]` attributes. Returns `true` if valid.
805 /// A doc inlining attribute is invalid if it is applied to a non-`use` item, or
806 /// if there are conflicting attributes for one item.
808 /// `specified_inline` is used to keep track of whether we have
809 /// already seen an inlining attribute for this item.
810 /// If so, `specified_inline` holds the value and the span of
811 /// the first `inline`/`no_inline` attribute.
815 meta: &NestedMetaItem,
818 specified_inline: &mut Option<(bool, Span)>,
820 if target == Target::Use || target == Target::ExternCrate {
821 let do_inline = meta.name_or_empty() == sym::inline;
822 if let Some((prev_inline, prev_span)) = *specified_inline {
823 if do_inline != prev_inline {
824 let mut spans = MultiSpan::from_spans(vec![prev_span, meta.span()]);
825 spans.push_span_label(prev_span, fluent::passes_doc_inline_conflict_first);
826 spans.push_span_label(meta.span(), fluent::passes_doc_inline_conflict_second);
827 self.tcx.sess.emit_err(errors::DocKeywordConflict { spans });
832 *specified_inline = Some((do_inline, meta.span()));
836 self.tcx.emit_spanned_lint(
837 INVALID_DOC_ATTRIBUTES,
840 errors::DocInlineOnlyUse {
841 attr_span: meta.span(),
842 item_span: (attr.style == AttrStyle::Outer)
843 .then(|| self.tcx.hir().span(hir_id)),
850 /// Checks that an attribute is *not* used at the crate level. Returns `true` if valid.
851 fn check_attr_not_crate_level(
853 meta: &NestedMetaItem,
857 if CRATE_HIR_ID == hir_id {
858 self.tcx.sess.emit_err(errors::DocAttrNotCrateLevel { span: meta.span(), attr_name });
864 /// Checks that an attribute is used at the crate level. Returns `true` if valid.
865 fn check_attr_crate_level(
868 meta: &NestedMetaItem,
871 if hir_id != CRATE_HIR_ID {
872 self.tcx.struct_span_lint_hir(
873 INVALID_DOC_ATTRIBUTES,
876 fluent::passes_attr_crate_level,
878 if attr.style == AttrStyle::Outer
879 && self.tcx.hir().get_parent_item(hir_id) == CRATE_OWNER_ID
881 if let Ok(mut src) = self.tcx.sess.source_map().span_to_snippet(attr.span) {
883 err.span_suggestion_verbose(
887 Applicability::MaybeIncorrect,
890 err.span_help(attr.span, fluent::help);
893 err.note(fluent::note);
902 /// Checks that `doc(test(...))` attribute contains only valid attributes. Returns `true` if
904 fn check_test_attr(&self, meta: &NestedMetaItem, hir_id: HirId) -> bool {
905 let mut is_valid = true;
906 if let Some(metas) = meta.meta_item_list() {
907 for i_meta in metas {
908 match i_meta.name_or_empty() {
909 sym::attr | sym::no_crate_inject => {}
911 self.tcx.emit_spanned_lint(
912 INVALID_DOC_ATTRIBUTES,
915 errors::DocTestUnknown {
916 path: rustc_ast_pretty::pprust::path_to_string(
917 &i_meta.meta_item().unwrap().path,
926 self.tcx.emit_spanned_lint(
927 INVALID_DOC_ATTRIBUTES,
930 errors::DocTestTakesList,
937 /// Check that the `#![doc(cfg_hide(...))]` attribute only contains a list of attributes.
938 /// Returns `true` if valid.
939 fn check_doc_cfg_hide(&self, meta: &NestedMetaItem, hir_id: HirId) -> bool {
940 if meta.meta_item_list().is_some() {
943 self.tcx.emit_spanned_lint(
944 INVALID_DOC_ATTRIBUTES,
947 errors::DocCfgHideTakesList,
953 /// Runs various checks on `#[doc]` attributes. Returns `true` if valid.
955 /// `specified_inline` should be initialized to `None` and kept for the scope
956 /// of one item. Read the documentation of [`check_doc_inline`] for more information.
958 /// [`check_doc_inline`]: Self::check_doc_inline
964 specified_inline: &mut Option<(bool, Span)>,
965 aliases: &mut FxHashMap<String, Span>,
967 let mut is_valid = true;
969 if let Some(mi) = attr.meta() && let Some(list) = mi.meta_item_list() {
971 if let Some(i_meta) = meta.meta_item() {
972 match i_meta.name_or_empty() {
974 if !self.check_attr_not_crate_level(meta, hir_id, "alias")
975 || !self.check_doc_alias(meta, hir_id, target, aliases) =>
981 if !self.check_attr_not_crate_level(meta, hir_id, "keyword")
982 || !self.check_doc_keyword(meta, hir_id) =>
988 if !self.check_attr_not_crate_level(meta, hir_id, "fake_variadic")
989 || !self.check_doc_fake_variadic(meta, hir_id) =>
994 sym::html_favicon_url
996 | sym::html_playground_url
997 | sym::issue_tracker_base_url
999 | sym::html_no_source
1001 if !self.check_attr_crate_level(attr, meta, hir_id) =>
1007 if !self.check_attr_crate_level(attr, meta, hir_id)
1008 || !self.check_doc_cfg_hide(meta, hir_id) =>
1013 sym::inline | sym::no_inline
1014 if !self.check_doc_inline(
1025 // no_default_passes: deprecated
1026 // passes: deprecated
1027 // plugins: removed, but rustdoc warns about it itself
1032 | sym::html_favicon_url
1033 | sym::html_logo_url
1034 | sym::html_no_source
1035 | sym::html_playground_url
1036 | sym::html_root_url
1038 | sym::issue_tracker_base_url
1041 | sym::no_default_passes
1043 | sym::notable_trait
1046 | sym::fake_variadic => {}
1049 if !self.check_test_attr(meta, hir_id) {
1055 if !self.tcx.features().rustdoc_internals {
1056 self.tcx.emit_spanned_lint(
1057 INVALID_DOC_ATTRIBUTES,
1060 errors::DocPrimitive,
1066 let path = rustc_ast_pretty::pprust::path_to_string(&i_meta.path);
1067 if i_meta.has_name(sym::spotlight) {
1068 self.tcx.emit_spanned_lint(
1069 INVALID_DOC_ATTRIBUTES,
1072 errors::DocTestUnknownSpotlight {
1077 } else if i_meta.has_name(sym::include) &&
1078 let Some(value) = i_meta.value_str() {
1079 let applicability = if list.len() == 1 {
1080 Applicability::MachineApplicable
1082 Applicability::MaybeIncorrect
1084 // If there are multiple attributes, the suggestion would suggest
1085 // deleting all of them, which is incorrect.
1086 self.tcx.emit_spanned_lint(
1087 INVALID_DOC_ATTRIBUTES,
1090 errors::DocTestUnknownInclude {
1092 value: value.to_string(),
1093 inner: if attr.style == AttrStyle::Inner { "!" } else { "" },
1094 sugg: (attr.meta().unwrap().span, applicability),
1098 self.tcx.emit_spanned_lint(
1099 INVALID_DOC_ATTRIBUTES,
1102 errors::DocTestUnknownAny { path }
1109 self.tcx.emit_spanned_lint(
1110 INVALID_DOC_ATTRIBUTES,
1123 /// Warns against some misuses of `#[pass_by_value]`
1124 fn check_pass_by_value(&self, attr: &Attribute, span: Span, target: Target) -> bool {
1126 Target::Struct | Target::Enum | Target::TyAlias => true,
1128 self.tcx.sess.emit_err(errors::PassByValue { attr_span: attr.span, span });
1134 fn check_allow_incoherent_impl(&self, attr: &Attribute, span: Span, target: Target) -> bool {
1136 Target::Method(MethodKind::Inherent) => true,
1138 self.tcx.sess.emit_err(errors::AllowIncoherentImpl { attr_span: attr.span, span });
1144 fn check_has_incoherent_inherent_impls(
1151 Target::Trait | Target::Struct | Target::Enum | Target::Union | Target::ForeignTy => {
1157 .emit_err(errors::HasIncoherentInherentImpl { attr_span: attr.span, span });
1163 /// Warns against some misuses of `#[must_use]`
1164 fn check_must_use(&self, hir_id: HirId, attr: &Attribute, target: Target) -> bool {
1173 // `impl Trait` in return position can trip
1174 // `unused_must_use` if `Trait` is marked as
1178 let article = match target {
1183 | Target::Expression
1185 | Target::AssocConst
1186 | Target::AssocTy => "an",
1190 self.tcx.emit_spanned_lint(
1194 errors::MustUseNoEffect { article, target },
1198 // For now, its always valid
1202 /// Checks if `#[must_not_suspend]` is applied to a function. Returns `true` if valid.
1203 fn check_must_not_suspend(&self, attr: &Attribute, span: Span, target: Target) -> bool {
1205 Target::Struct | Target::Enum | Target::Union | Target::Trait => true,
1207 self.tcx.sess.emit_err(errors::MustNotSuspend { attr_span: attr.span, span });
1213 /// Checks if `#[cold]` is applied to a non-function. Returns `true` if valid.
1214 fn check_cold(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
1216 Target::Fn | Target::Method(..) | Target::ForeignFn | Target::Closure => {}
1217 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1218 // `#[cold]` attribute with just a lint, because we previously
1219 // erroneously allowed it and some crates used it accidentally, to be compatible
1220 // with crates depending on them, we can't throw an error here.
1221 Target::Field | Target::Arm | Target::MacroDef => {
1222 self.inline_attr_str_error_with_macro_def(hir_id, attr, "cold");
1225 // FIXME: #[cold] was previously allowed on non-functions and some crates used
1226 // this, so only emit a warning.
1227 self.tcx.emit_spanned_lint(
1231 errors::Cold { span, on_crate: hir_id == CRATE_HIR_ID },
1237 /// Checks if `#[link]` is applied to an item other than a foreign module.
1238 fn check_link(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
1239 if target == Target::ForeignMod
1240 && let hir::Node::Item(item) = self.tcx.hir().get(hir_id)
1241 && let Item { kind: ItemKind::ForeignMod { abi, .. }, .. } = item
1242 && !matches!(abi, Abi::Rust | Abi::RustIntrinsic | Abi::PlatformIntrinsic)
1247 self.tcx.emit_spanned_lint(
1251 errors::Link { span: (target != Target::ForeignMod).then_some(span) },
1255 /// Checks if `#[link_name]` is applied to an item other than a foreign function or static.
1256 fn check_link_name(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
1258 Target::ForeignFn | Target::ForeignStatic => {}
1259 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1260 // `#[link_name]` attribute with just a lint, because we previously
1261 // erroneously allowed it and some crates used it accidentally, to be compatible
1262 // with crates depending on them, we can't throw an error here.
1263 Target::Field | Target::Arm | Target::MacroDef => {
1264 self.inline_attr_str_error_with_macro_def(hir_id, attr, "link_name");
1267 // FIXME: #[cold] was previously allowed on non-functions/statics and some crates
1268 // used this, so only emit a warning.
1269 let attr_span = matches!(target, Target::ForeignMod).then_some(attr.span);
1270 if let Some(s) = attr.value_str() {
1271 self.tcx.emit_spanned_lint(
1275 errors::LinkName { span, attr_span, value: s.as_str() },
1278 self.tcx.emit_spanned_lint(
1282 errors::LinkName { span, attr_span, value: "..." },
1289 /// Checks if `#[no_link]` is applied to an `extern crate`. Returns `true` if valid.
1290 fn check_no_link(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) -> bool {
1292 Target::ExternCrate => true,
1293 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1294 // `#[no_link]` attribute with just a lint, because we previously
1295 // erroneously allowed it and some crates used it accidentally, to be compatible
1296 // with crates depending on them, we can't throw an error here.
1297 Target::Field | Target::Arm | Target::MacroDef => {
1298 self.inline_attr_str_error_with_macro_def(hir_id, attr, "no_link");
1302 self.tcx.sess.emit_err(errors::NoLink { attr_span: attr.span, span });
1308 fn is_impl_item(&self, hir_id: HirId) -> bool {
1309 matches!(self.tcx.hir().get(hir_id), hir::Node::ImplItem(..))
1312 /// Checks if `#[export_name]` is applied to a function or static. Returns `true` if valid.
1313 fn check_export_name(
1321 Target::Static | Target::Fn => true,
1322 Target::Method(..) if self.is_impl_item(hir_id) => true,
1323 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1324 // `#[export_name]` attribute with just a lint, because we previously
1325 // erroneously allowed it and some crates used it accidentally, to be compatible
1326 // with crates depending on them, we can't throw an error here.
1327 Target::Field | Target::Arm | Target::MacroDef => {
1328 self.inline_attr_str_error_with_macro_def(hir_id, attr, "export_name");
1332 self.tcx.sess.emit_err(errors::ExportName { attr_span: attr.span, span });
1338 fn check_rustc_layout_scalar_valid_range(
1344 if target != Target::Struct {
1345 self.tcx.sess.emit_err(errors::RustcLayoutScalarValidRangeNotStruct {
1346 attr_span: attr.span,
1352 let Some(list) = attr.meta_item_list() else {
1356 if matches!(&list[..], &[NestedMetaItem::Lit(MetaItemLit { kind: LitKind::Int(..), .. })]) {
1359 self.tcx.sess.emit_err(errors::RustcLayoutScalarValidRangeArg { attr_span: attr.span });
1364 /// Checks if `#[rustc_legacy_const_generics]` is applied to a function and has a valid argument.
1365 fn check_rustc_legacy_const_generics(
1371 item: Option<ItemLike<'_>>,
1373 let is_function = matches!(target, Target::Fn);
1375 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToFn {
1376 attr_span: attr.span,
1378 on_crate: hir_id == CRATE_HIR_ID,
1383 let Some(list) = attr.meta_item_list() else {
1384 // The attribute form is validated on AST.
1388 let Some(ItemLike::Item(Item {
1389 kind: ItemKind::Fn(FnSig { decl, .. }, generics, _),
1392 bug!("should be a function item");
1395 for param in generics.params {
1397 hir::GenericParamKind::Const { .. } => {}
1399 self.tcx.sess.emit_err(errors::RustcLegacyConstGenericsOnly {
1400 attr_span: attr.span,
1401 param_span: param.span,
1408 if list.len() != generics.params.len() {
1409 self.tcx.sess.emit_err(errors::RustcLegacyConstGenericsIndex {
1410 attr_span: attr.span,
1411 generics_span: generics.span,
1416 let arg_count = decl.inputs.len() as u128 + generics.params.len() as u128;
1417 let mut invalid_args = vec![];
1419 if let Some(LitKind::Int(val, _)) = meta.lit().map(|lit| &lit.kind) {
1420 if *val >= arg_count {
1421 let span = meta.span();
1422 self.tcx.sess.emit_err(errors::RustcLegacyConstGenericsIndexExceed {
1424 arg_count: arg_count as usize,
1429 invalid_args.push(meta.span());
1433 if !invalid_args.is_empty() {
1434 self.tcx.sess.emit_err(errors::RustcLegacyConstGenericsIndexNegative { invalid_args });
1441 /// Helper function for checking that the provided attribute is only applied to a function or
1443 fn check_applied_to_fn_or_method(
1450 let is_function = matches!(target, Target::Fn | Target::Method(..));
1452 self.tcx.sess.emit_err(errors::AttrShouldBeAppliedToFn {
1453 attr_span: attr.span,
1455 on_crate: hir_id == CRATE_HIR_ID,
1463 /// Checks that the `#[rustc_lint_query_instability]` attribute is only applied to a function
1465 fn check_rustc_lint_query_instability(
1472 self.check_applied_to_fn_or_method(hir_id, attr, span, target)
1475 /// Checks that the `#[rustc_lint_diagnostics]` attribute is only applied to a function or
1477 fn check_rustc_lint_diagnostics(
1484 self.check_applied_to_fn_or_method(hir_id, attr, span, target)
1487 /// Checks that the `#[rustc_lint_opt_ty]` attribute is only applied to a struct.
1488 fn check_rustc_lint_opt_ty(&self, attr: &Attribute, span: Span, target: Target) -> bool {
1490 Target::Struct => true,
1492 self.tcx.sess.emit_err(errors::RustcLintOptTy { attr_span: attr.span, span });
1498 /// Checks that the `#[rustc_lint_opt_deny_field_access]` attribute is only applied to a field.
1499 fn check_rustc_lint_opt_deny_field_access(
1506 Target::Field => true,
1510 .emit_err(errors::RustcLintOptDenyFieldAccess { attr_span: attr.span, span });
1516 /// Checks that the dep-graph debugging attributes are only present when the query-dep-graph
1517 /// option is passed to the compiler.
1518 fn check_rustc_dirty_clean(&self, attr: &Attribute) -> bool {
1519 if self.tcx.sess.opts.unstable_opts.query_dep_graph {
1522 self.tcx.sess.emit_err(errors::RustcDirtyClean { span: attr.span });
1527 /// Checks if `#[link_section]` is applied to a function or static.
1528 fn check_link_section(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
1530 Target::Static | Target::Fn | Target::Method(..) => {}
1531 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1532 // `#[link_section]` attribute with just a lint, because we previously
1533 // erroneously allowed it and some crates used it accidentally, to be compatible
1534 // with crates depending on them, we can't throw an error here.
1535 Target::Field | Target::Arm | Target::MacroDef => {
1536 self.inline_attr_str_error_with_macro_def(hir_id, attr, "link_section");
1539 // FIXME: #[link_section] was previously allowed on non-functions/statics and some
1540 // crates used this, so only emit a warning.
1541 self.tcx.emit_spanned_lint(
1545 errors::LinkSection { span },
1551 /// Checks if `#[no_mangle]` is applied to a function or static.
1552 fn check_no_mangle(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
1554 Target::Static | Target::Fn => {}
1555 Target::Method(..) if self.is_impl_item(hir_id) => {}
1556 // FIXME(#80564): We permit struct fields, match arms and macro defs to have an
1557 // `#[no_mangle]` attribute with just a lint, because we previously
1558 // erroneously allowed it and some crates used it accidentally, to be compatible
1559 // with crates depending on them, we can't throw an error here.
1560 Target::Field | Target::Arm | Target::MacroDef => {
1561 self.inline_attr_str_error_with_macro_def(hir_id, attr, "no_mangle");
1563 // FIXME: #[no_mangle] was previously allowed on non-functions/statics, this should be an error
1564 // The error should specify that the item that is wrong is specifically a *foreign* fn/static
1565 // otherwise the error seems odd
1566 Target::ForeignFn | Target::ForeignStatic => {
1567 let foreign_item_kind = match target {
1568 Target::ForeignFn => "function",
1569 Target::ForeignStatic => "static",
1570 _ => unreachable!(),
1572 self.tcx.emit_spanned_lint(
1576 errors::NoMangleForeign { span, attr_span: attr.span, foreign_item_kind },
1580 // FIXME: #[no_mangle] was previously allowed on non-functions/statics and some
1581 // crates used this, so only emit a warning.
1582 self.tcx.emit_spanned_lint(
1586 errors::NoMangle { span },
1592 /// Checks if the `#[repr]` attributes on `item` are valid.
1595 attrs: &[Attribute],
1598 item: Option<ItemLike<'_>>,
1601 // Extract the names of all repr hints, e.g., [foo, bar, align] for:
1604 // #[repr(bar, align(8))]
1606 let hints: Vec<_> = attrs
1608 .filter(|attr| attr.has_name(sym::repr))
1609 .filter_map(|attr| attr.meta_item_list())
1613 let mut int_reprs = 0;
1614 let mut is_c = false;
1615 let mut is_simd = false;
1616 let mut is_transparent = false;
1618 for hint in &hints {
1619 if !hint.is_meta_item() {
1620 self.tcx.sess.emit_err(errors::ReprIdent { span: hint.span() });
1624 match hint.name_or_empty() {
1628 Target::Struct | Target::Union | Target::Enum => continue,
1630 self.tcx.sess.emit_err(AttrApplication::StructEnumUnion {
1631 hint_span: hint.span(),
1638 if let (Target::Fn, false) = (target, self.tcx.features().fn_align) {
1640 &self.tcx.sess.parse_sess,
1643 "`repr(align)` attributes on functions are unstable",
1649 Target::Struct | Target::Union | Target::Enum | Target::Fn => continue,
1651 self.tcx.sess.emit_err(AttrApplication::StructEnumFunctionUnion {
1652 hint_span: hint.span(),
1659 if target != Target::Struct && target != Target::Union {
1660 self.tcx.sess.emit_err(AttrApplication::StructUnion {
1661 hint_span: hint.span(),
1670 if target != Target::Struct {
1673 .emit_err(AttrApplication::Struct { hint_span: hint.span(), span });
1678 sym::transparent => {
1679 is_transparent = true;
1681 Target::Struct | Target::Union | Target::Enum => continue,
1683 self.tcx.sess.emit_err(AttrApplication::StructEnumUnion {
1684 hint_span: hint.span(),
1703 if target != Target::Enum {
1706 .emit_err(AttrApplication::Enum { hint_span: hint.span(), span });
1712 self.tcx.sess.emit_err(UnrecognizedReprHint { span: hint.span() });
1718 // Just point at all repr hints if there are any incompatibilities.
1719 // This is not ideal, but tracking precisely which ones are at fault is a huge hassle.
1720 let hint_spans = hints.iter().map(|hint| hint.span());
1722 // Error on repr(transparent, <anything else>).
1723 if is_transparent && hints.len() > 1 {
1724 let hint_spans: Vec<_> = hint_spans.clone().collect();
1727 .emit_err(TransparentIncompatible { hint_spans, target: target.to_string() });
1729 // Warn on repr(u8, u16), repr(C, simd), and c-like-enum-repr(C, u8)
1731 || (is_simd && is_c)
1734 && item.map_or(false, |item| {
1735 if let ItemLike::Item(item) = item {
1736 return is_c_like_enum(item);
1741 self.tcx.emit_spanned_lint(
1742 CONFLICTING_REPR_HINTS,
1744 hint_spans.collect::<Vec<Span>>(),
1745 errors::ReprConflicting,
1750 fn check_used(&self, attrs: &[Attribute], target: Target) {
1751 let mut used_linker_span = None;
1752 let mut used_compiler_span = None;
1753 for attr in attrs.iter().filter(|attr| attr.has_name(sym::used)) {
1754 if target != Target::Static {
1755 self.tcx.sess.emit_err(errors::UsedStatic { span: attr.span });
1757 let inner = attr.meta_item_list();
1758 match inner.as_deref() {
1759 Some([item]) if item.has_name(sym::linker) => {
1760 if used_linker_span.is_none() {
1761 used_linker_span = Some(attr.span);
1764 Some([item]) if item.has_name(sym::compiler) => {
1765 if used_compiler_span.is_none() {
1766 used_compiler_span = Some(attr.span);
1770 // This error case is handled in rustc_hir_analysis::collect.
1773 // Default case (compiler) when arg isn't defined.
1774 if used_compiler_span.is_none() {
1775 used_compiler_span = Some(attr.span);
1780 if let (Some(linker_span), Some(compiler_span)) = (used_linker_span, used_compiler_span) {
1783 .emit_err(errors::UsedCompilerLinker { spans: vec![linker_span, compiler_span] });
1787 /// Outputs an error for `#[allow_internal_unstable]` which can only be applied to macros.
1788 /// (Allows proc_macro functions)
1789 fn check_allow_internal_unstable(
1795 attrs: &[Attribute],
1797 debug!("Checking target: {:?}", target);
1801 if self.tcx.sess.is_proc_macro_attr(attr) {
1802 debug!("Is proc macro attr");
1806 debug!("Is not proc macro attr");
1809 Target::MacroDef => true,
1810 // FIXME(#80564): We permit struct fields and match arms to have an
1811 // `#[allow_internal_unstable]` attribute with just a lint, because we previously
1812 // erroneously allowed it and some crates used it accidentally, to be compatible
1813 // with crates depending on them, we can't throw an error here.
1814 Target::Field | Target::Arm => {
1815 self.inline_attr_str_error_without_macro_def(
1818 "allow_internal_unstable",
1825 .emit_err(errors::AllowInternalUnstable { attr_span: attr.span, span });
1831 /// Checks if the items on the `#[debugger_visualizer]` attribute are valid.
1832 fn check_debugger_visualizer(&self, attr: &Attribute, target: Target) -> bool {
1836 self.tcx.sess.emit_err(errors::DebugVisualizerPlacement { span: attr.span });
1841 let Some(hints) = attr.meta_item_list() else {
1842 self.tcx.sess.emit_err(errors::DebugVisualizerInvalid { span: attr.span });
1846 let hint = match hints.len() {
1849 self.tcx.sess.emit_err(errors::DebugVisualizerInvalid { span: attr.span });
1854 let Some(meta_item) = hint.meta_item() else {
1855 self.tcx.sess.emit_err(errors::DebugVisualizerInvalid { span: attr.span });
1859 let visualizer_path = match (meta_item.name_or_empty(), meta_item.value_str()) {
1860 (sym::natvis_file, Some(value)) => value,
1861 (sym::gdb_script_file, Some(value)) => value,
1863 self.tcx.sess.emit_err(errors::DebugVisualizerInvalid { span: meta_item.span });
1869 match resolve_path(&self.tcx.sess.parse_sess, visualizer_path.as_str(), attr.span) {
1877 match std::fs::File::open(&file) {
1880 self.tcx.sess.emit_err(DebugVisualizerUnreadable {
1881 span: meta_item.span,
1890 /// Outputs an error for `#[allow_internal_unstable]` which can only be applied to macros.
1891 /// (Allows proc_macro functions)
1892 fn check_rustc_allow_const_fn_unstable(
1900 Target::Fn | Target::Method(_)
1901 if self.tcx.is_const_fn_raw(self.tcx.hir().local_def_id(hir_id).to_def_id()) =>
1905 // FIXME(#80564): We permit struct fields and match arms to have an
1906 // `#[allow_internal_unstable]` attribute with just a lint, because we previously
1907 // erroneously allowed it and some crates used it accidentally, to be compatible
1908 // with crates depending on them, we can't throw an error here.
1909 Target::Field | Target::Arm | Target::MacroDef => {
1910 self.inline_attr_str_error_with_macro_def(hir_id, attr, "allow_internal_unstable");
1916 .emit_err(errors::RustcAllowConstFnUnstable { attr_span: attr.span, span });
1922 fn check_rustc_std_internal_symbol(
1929 Target::Fn | Target::Static => true,
1933 .emit_err(errors::RustcStdInternalSymbol { attr_span: attr.span, span });
1939 /// `#[const_trait]` only applies to traits.
1940 fn check_const_trait(&self, attr: &Attribute, _span: Span, target: Target) -> bool {
1942 Target::Trait => true,
1944 self.tcx.sess.emit_err(errors::ConstTrait { attr_span: attr.span });
1950 fn check_stability_promotable(&self, attr: &Attribute, _span: Span, target: Target) -> bool {
1952 Target::Expression => {
1953 self.tcx.sess.emit_err(errors::StabilityPromotable { attr_span: attr.span });
1960 fn check_link_ordinal(&self, attr: &Attribute, _span: Span, target: Target) -> bool {
1962 Target::ForeignFn | Target::ForeignStatic => true,
1964 self.tcx.sess.emit_err(errors::LinkOrdinal { attr_span: attr.span });
1970 fn check_deprecated(&self, hir_id: HirId, attr: &Attribute, _span: Span, target: Target) {
1972 Target::Closure | Target::Expression | Target::Statement | Target::Arm => {
1973 self.tcx.emit_spanned_lint(
1984 fn check_macro_use(&self, hir_id: HirId, attr: &Attribute, target: Target) {
1985 let name = attr.name_or_empty();
1987 Target::ExternCrate | Target::Mod => {}
1989 self.tcx.emit_spanned_lint(
1993 errors::MacroUse { name },
1999 fn check_macro_export(&self, hir_id: HirId, attr: &Attribute, target: Target) {
2000 if target != Target::MacroDef {
2001 self.tcx.emit_spanned_lint(UNUSED_ATTRIBUTES, hir_id, attr.span, errors::MacroExport);
2005 fn check_plugin_registrar(&self, hir_id: HirId, attr: &Attribute, target: Target) {
2006 if target != Target::Fn {
2007 self.tcx.emit_spanned_lint(
2011 errors::PluginRegistrar,
2016 fn check_unused_attribute(&self, hir_id: HirId, attr: &Attribute) {
2017 // Warn on useless empty attributes.
2018 let note = if matches!(
2019 attr.name_or_empty(),
2028 | sym::target_feature
2029 ) && attr.meta_item_list().map_or(false, |list| list.is_empty())
2031 errors::UnusedNote::EmptyList { name: attr.name_or_empty() }
2033 attr.name_or_empty(),
2034 sym::allow | sym::warn | sym::deny | sym::forbid | sym::expect
2035 ) && let Some(meta) = attr.meta_item_list()
2037 && let Some(item) = meta[0].meta_item()
2038 && let MetaItemKind::NameValue(_) = &item.kind
2039 && item.path == sym::reason
2041 errors::UnusedNote::NoLints { name: attr.name_or_empty() }
2042 } else if attr.name_or_empty() == sym::default_method_body_is_const {
2043 errors::UnusedNote::DefaultMethodBodyConst
2048 self.tcx.emit_spanned_lint(
2052 errors::Unused { attr_span: attr.span, note },
2057 impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
2058 type NestedFilter = nested_filter::OnlyBodies;
2060 fn nested_visit_map(&mut self) -> Self::Map {
2064 fn visit_item(&mut self, item: &'tcx Item<'tcx>) {
2065 // Historically we've run more checks on non-exported than exported macros,
2066 // so this lets us continue to run them while maintaining backwards compatibility.
2067 // In the long run, the checks should be harmonized.
2068 if let ItemKind::Macro(ref macro_def, _) = item.kind {
2069 let def_id = item.owner_id.to_def_id();
2070 if macro_def.macro_rules && !self.tcx.has_attr(def_id, sym::macro_export) {
2071 check_non_exported_macro_for_invalid_attrs(self.tcx, item);
2075 let target = Target::from_item(item);
2076 self.check_attributes(item.hir_id(), item.span, target, Some(ItemLike::Item(item)));
2077 intravisit::walk_item(self, item)
2080 fn visit_generic_param(&mut self, generic_param: &'tcx hir::GenericParam<'tcx>) {
2081 let target = Target::from_generic_param(generic_param);
2082 self.check_attributes(generic_param.hir_id, generic_param.span, target, None);
2083 intravisit::walk_generic_param(self, generic_param)
2086 fn visit_trait_item(&mut self, trait_item: &'tcx TraitItem<'tcx>) {
2087 let target = Target::from_trait_item(trait_item);
2088 self.check_attributes(trait_item.hir_id(), trait_item.span, target, None);
2089 intravisit::walk_trait_item(self, trait_item)
2092 fn visit_field_def(&mut self, struct_field: &'tcx hir::FieldDef<'tcx>) {
2093 self.check_attributes(struct_field.hir_id, struct_field.span, Target::Field, None);
2094 intravisit::walk_field_def(self, struct_field);
2097 fn visit_arm(&mut self, arm: &'tcx hir::Arm<'tcx>) {
2098 self.check_attributes(arm.hir_id, arm.span, Target::Arm, None);
2099 intravisit::walk_arm(self, arm);
2102 fn visit_foreign_item(&mut self, f_item: &'tcx ForeignItem<'tcx>) {
2103 let target = Target::from_foreign_item(f_item);
2104 self.check_attributes(f_item.hir_id(), f_item.span, target, Some(ItemLike::ForeignItem));
2105 intravisit::walk_foreign_item(self, f_item)
2108 fn visit_impl_item(&mut self, impl_item: &'tcx hir::ImplItem<'tcx>) {
2109 let target = target_from_impl_item(self.tcx, impl_item);
2110 self.check_attributes(impl_item.hir_id(), impl_item.span, target, None);
2111 intravisit::walk_impl_item(self, impl_item)
2114 fn visit_stmt(&mut self, stmt: &'tcx hir::Stmt<'tcx>) {
2115 // When checking statements ignore expressions, they will be checked later.
2116 if let hir::StmtKind::Local(ref l) = stmt.kind {
2117 self.check_attributes(l.hir_id, stmt.span, Target::Statement, None);
2119 intravisit::walk_stmt(self, stmt)
2122 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) {
2123 let target = match expr.kind {
2124 hir::ExprKind::Closure { .. } => Target::Closure,
2125 _ => Target::Expression,
2128 self.check_attributes(expr.hir_id, expr.span, target, None);
2129 intravisit::walk_expr(self, expr)
2132 fn visit_expr_field(&mut self, field: &'tcx hir::ExprField<'tcx>) {
2133 self.check_attributes(field.hir_id, field.span, Target::ExprField, None);
2134 intravisit::walk_expr_field(self, field)
2137 fn visit_variant(&mut self, variant: &'tcx hir::Variant<'tcx>) {
2138 self.check_attributes(variant.hir_id, variant.span, Target::Variant, None);
2139 intravisit::walk_variant(self, variant)
2142 fn visit_param(&mut self, param: &'tcx hir::Param<'tcx>) {
2143 self.check_attributes(param.hir_id, param.span, Target::Param, None);
2145 intravisit::walk_param(self, param);
2148 fn visit_pat_field(&mut self, field: &'tcx hir::PatField<'tcx>) {
2149 self.check_attributes(field.hir_id, field.span, Target::PatField, None);
2150 intravisit::walk_pat_field(self, field);
2154 fn is_c_like_enum(item: &Item<'_>) -> bool {
2155 if let ItemKind::Enum(ref def, _) = item.kind {
2156 for variant in def.variants {
2157 match variant.data {
2158 hir::VariantData::Unit(..) => { /* continue */ }
2168 // FIXME: Fix "Cannot determine resolution" error and remove built-in macros
2170 fn check_invalid_crate_level_attr(tcx: TyCtxt<'_>, attrs: &[Attribute]) {
2171 // Check for builtin attributes at the crate level
2172 // which were unsuccessfully resolved due to cannot determine
2173 // resolution for the attribute macro error.
2174 const ATTRS_TO_CHECK: &[Symbol] = &[
2178 sym::automatically_derived,
2185 sym::global_allocator,
2190 // This function should only be called with crate attributes
2191 // which are inner attributes always but lets check to make sure
2192 if attr.style == AttrStyle::Inner {
2193 for attr_to_check in ATTRS_TO_CHECK {
2194 if attr.has_name(*attr_to_check) {
2195 tcx.sess.emit_err(InvalidAttrAtCrateLevel {
2197 snippet: tcx.sess.source_map().span_to_snippet(attr.span).ok(),
2198 name: *attr_to_check,
2206 fn check_non_exported_macro_for_invalid_attrs(tcx: TyCtxt<'_>, item: &Item<'_>) {
2207 let attrs = tcx.hir().attrs(item.hir_id());
2210 if attr.has_name(sym::inline) {
2211 tcx.sess.emit_err(errors::NonExportedMacroInvalidAttrs { attr_span: attr.span });
2216 fn check_mod_attrs(tcx: TyCtxt<'_>, module_def_id: LocalDefId) {
2217 let check_attr_visitor = &mut CheckAttrVisitor { tcx };
2218 tcx.hir().visit_item_likes_in_module(module_def_id, check_attr_visitor);
2219 if module_def_id.is_top_level_module() {
2220 check_attr_visitor.check_attributes(CRATE_HIR_ID, DUMMY_SP, Target::Mod, None);
2221 check_invalid_crate_level_attr(tcx, tcx.hir().krate_attrs());
2225 pub(crate) fn provide(providers: &mut Providers) {
2226 *providers = Providers { check_mod_attrs, ..*providers };
2229 fn check_duplicates(
2233 duplicates: AttributeDuplicates,
2234 seen: &mut FxHashMap<Symbol, Span>,
2236 use AttributeDuplicates::*;
2237 if matches!(duplicates, WarnFollowingWordOnly) && !attr.is_word() {
2242 WarnFollowing | FutureWarnFollowing | WarnFollowingWordOnly | FutureWarnPreceding => {
2243 match seen.entry(attr.name_or_empty()) {
2244 Entry::Occupied(mut entry) => {
2245 let (this, other) = if matches!(duplicates, FutureWarnPreceding) {
2246 let to_remove = entry.insert(attr.span);
2247 (to_remove, attr.span)
2249 (attr.span, *entry.get())
2251 tcx.emit_spanned_lint(
2255 errors::UnusedDuplicate {
2260 FutureWarnFollowing | FutureWarnPreceding
2266 Entry::Vacant(entry) => {
2267 entry.insert(attr.span);
2271 ErrorFollowing | ErrorPreceding => match seen.entry(attr.name_or_empty()) {
2272 Entry::Occupied(mut entry) => {
2273 let (this, other) = if matches!(duplicates, ErrorPreceding) {
2274 let to_remove = entry.insert(attr.span);
2275 (to_remove, attr.span)
2277 (attr.span, *entry.get())
2279 tcx.sess.emit_err(errors::UnusedMultiple {
2282 name: attr.name_or_empty(),
2285 Entry::Vacant(entry) => {
2286 entry.insert(attr.span);