compiler/rustc_parse/src/parser/diagnostics.rs

   1 use super::pat::Expected;
   2 use super::{
   3     BlockMode, CommaRecoveryMode, Parser, PathStyle, Restrictions, SemiColonMode, SeqSep,
   4     TokenExpectType, TokenType,
   5 };
   6
   7 use crate::lexer::UnmatchedBrace;
   8 use rustc_ast as ast;
   9 use rustc_ast::ptr::P;
  10 use rustc_ast::token::{self, Delimiter, Lit, LitKind, TokenKind};
  11 use rustc_ast::util::parser::AssocOp;
  12 use rustc_ast::{
  13     AngleBracketedArg, AngleBracketedArgs, AnonConst, AttrVec, BinOpKind, BindingMode, Block,
  14     BlockCheckMode, Expr, ExprKind, GenericArg, Generics, Item, ItemKind, Mutability, Param, Pat,
  15     PatKind, Path, PathSegment, QSelf, Ty, TyKind,
  16 };
  17 use rustc_ast_pretty::pprust;
  18 use rustc_data_structures::fx::FxHashSet;
  19 use rustc_errors::{
  20     fluent, Applicability, DiagnosticBuilder, DiagnosticMessage, Handler, MultiSpan, PResult,
  21 };
  22 use rustc_errors::{pluralize, struct_span_err, Diagnostic, EmissionGuarantee, ErrorGuaranteed};
  23 use rustc_macros::{SessionDiagnostic, SessionSubdiagnostic};
  24 use rustc_span::source_map::Spanned;
  25 use rustc_span::symbol::{kw, Ident};
  26 use rustc_span::{Span, SpanSnippetError, DUMMY_SP};
  27 use std::ops::{Deref, DerefMut};
  28
  29 use std::mem::take;
  30
  31 use crate::parser;
  32 use tracing::{debug, trace};
  33
  34 const TURBOFISH_SUGGESTION_STR: &str =
  35     "use `::<...>` instead of `<...>` to specify lifetime, type, or const arguments";
  36
  37 /// Creates a placeholder argument.
  38 pub(super) fn dummy_arg(ident: Ident) -> Param {
  39     let pat = P(Pat {
  40         id: ast::DUMMY_NODE_ID,
  41         kind: PatKind::Ident(BindingMode::ByValue(Mutability::Not), ident, None),
  42         span: ident.span,
  43         tokens: None,
  44     });
  45     let ty = Ty { kind: TyKind::Err, span: ident.span, id: ast::DUMMY_NODE_ID, tokens: None };
  46     Param {
  47         attrs: AttrVec::default(),
  48         id: ast::DUMMY_NODE_ID,
  49         pat,
  50         span: ident.span,
  51         ty: P(ty),
  52         is_placeholder: false,
  53     }
  54 }
  55
  56 pub enum Error {
  57     UselessDocComment,
  58 }
  59
  60 impl Error {
  61     fn span_err(
  62         self,
  63         sp: impl Into<MultiSpan>,
  64         handler: &Handler,
  65     ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
  66         match self {
  67             Error::UselessDocComment => {
  68                 let mut err = struct_span_err!(
  69                     handler,
  70                     sp,
  71                     E0585,
  72                     "found a documentation comment that doesn't document anything",
  73                 );
  74                 err.help(
  75                     "doc comments must come before what they document, maybe a comment was \
  76                           intended with `//`?",
  77                 );
  78                 err
  79             }
  80         }
  81     }
  82 }
  83
  84 pub(super) trait RecoverQPath: Sized + 'static {
  85     const PATH_STYLE: PathStyle = PathStyle::Expr;
  86     fn to_ty(&self) -> Option<P<Ty>>;
  87     fn recovered(qself: Option<QSelf>, path: ast::Path) -> Self;
  88 }
  89
  90 impl RecoverQPath for Ty {
  91     const PATH_STYLE: PathStyle = PathStyle::Type;
  92     fn to_ty(&self) -> Option<P<Ty>> {
  93         Some(P(self.clone()))
  94     }
  95     fn recovered(qself: Option<QSelf>, path: ast::Path) -> Self {
  96         Self {
  97             span: path.span,
  98             kind: TyKind::Path(qself, path),
  99             id: ast::DUMMY_NODE_ID,
 100             tokens: None,
 101         }
 102     }
 103 }
 104
 105 impl RecoverQPath for Pat {
 106     fn to_ty(&self) -> Option<P<Ty>> {
 107         self.to_ty()
 108     }
 109     fn recovered(qself: Option<QSelf>, path: ast::Path) -> Self {
 110         Self {
 111             span: path.span,
 112             kind: PatKind::Path(qself, path),
 113             id: ast::DUMMY_NODE_ID,
 114             tokens: None,
 115         }
 116     }
 117 }
 118
 119 impl RecoverQPath for Expr {
 120     fn to_ty(&self) -> Option<P<Ty>> {
 121         self.to_ty()
 122     }
 123     fn recovered(qself: Option<QSelf>, path: ast::Path) -> Self {
 124         Self {
 125             span: path.span,
 126             kind: ExprKind::Path(qself, path),
 127             attrs: AttrVec::new(),
 128             id: ast::DUMMY_NODE_ID,
 129             tokens: None,
 130         }
 131     }
 132 }
 133
 134 /// Control whether the closing delimiter should be consumed when calling `Parser::consume_block`.
 135 pub(crate) enum ConsumeClosingDelim {
 136     Yes,
 137     No,
 138 }
 139
 140 #[derive(Clone, Copy)]
 141 pub enum AttemptLocalParseRecovery {
 142     Yes,
 143     No,
 144 }
 145
 146 impl AttemptLocalParseRecovery {
 147     pub fn yes(&self) -> bool {
 148         match self {
 149             AttemptLocalParseRecovery::Yes => true,
 150             AttemptLocalParseRecovery::No => false,
 151         }
 152     }
 153
 154     pub fn no(&self) -> bool {
 155         match self {
 156             AttemptLocalParseRecovery::Yes => false,
 157             AttemptLocalParseRecovery::No => true,
 158         }
 159     }
 160 }
 161
 162 /// Information for emitting suggestions and recovering from
 163 /// C-style `i++`, `--i`, etc.
 164 #[derive(Debug, Copy, Clone)]
 165 struct IncDecRecovery {
 166     /// Is this increment/decrement its own statement?
 167     standalone: IsStandalone,
 168     /// Is this an increment or decrement?
 169     op: IncOrDec,
 170     /// Is this pre- or postfix?
 171     fixity: UnaryFixity,
 172 }
 173
 174 /// Is an increment or decrement expression its own statement?
 175 #[derive(Debug, Copy, Clone)]
 176 enum IsStandalone {
 177     /// It's standalone, i.e., its own statement.
 178     Standalone,
 179     /// It's a subexpression, i.e., *not* standalone.
 180     Subexpr,
 181     /// It's maybe standalone; we're not sure.
 182     Maybe,
 183 }
 184
 185 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 186 enum IncOrDec {
 187     Inc,
 188     // FIXME: `i--` recovery isn't implemented yet
 189     #[allow(dead_code)]
 190     Dec,
 191 }
 192
 193 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 194 enum UnaryFixity {
 195     Pre,
 196     Post,
 197 }
 198
 199 impl IncOrDec {
 200     fn chr(&self) -> char {
 201         match self {
 202             Self::Inc => '+',
 203             Self::Dec => '-',
 204         }
 205     }
 206
 207     fn name(&self) -> &'static str {
 208         match self {
 209             Self::Inc => "increment",
 210             Self::Dec => "decrement",
 211         }
 212     }
 213 }
 214
 215 impl std::fmt::Display for UnaryFixity {
 216     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
 217         match self {
 218             Self::Pre => write!(f, "prefix"),
 219             Self::Post => write!(f, "postfix"),
 220         }
 221     }
 222 }
 223
 224 struct MultiSugg {
 225     msg: String,
 226     patches: Vec<(Span, String)>,
 227     applicability: Applicability,
 228 }
 229
 230 impl MultiSugg {
 231     fn emit<G: EmissionGuarantee>(self, err: &mut DiagnosticBuilder<'_, G>) {
 232         err.multipart_suggestion(&self.msg, self.patches, self.applicability);
 233     }
 234
 235     /// Overrides individual messages and applicabilities.
 236     fn emit_many<G: EmissionGuarantee>(
 237         err: &mut DiagnosticBuilder<'_, G>,
 238         msg: &str,
 239         applicability: Applicability,
 240         suggestions: impl Iterator<Item = Self>,
 241     ) {
 242         err.multipart_suggestions(msg, suggestions.map(|s| s.patches), applicability);
 243     }
 244 }
 245
 246 #[derive(SessionDiagnostic)]
 247 #[error(slug = "parser-maybe-report-ambiguous-plus")]
 248 struct AmbiguousPlus {
 249     pub sum_ty: String,
 250     #[primary_span]
 251     #[suggestion(code = "({sum_ty})")]
 252     pub span: Span,
 253 }
 254
 255 #[derive(SessionDiagnostic)]
 256 #[error(code = "E0178", slug = "parser-maybe-recover-from-bad-type-plus")]
 257 struct BadTypePlus {
 258     pub ty: String,
 259     #[primary_span]
 260     pub span: Span,
 261     #[subdiagnostic]
 262     pub sub: BadTypePlusSub,
 263 }
 264
 265 #[derive(SessionSubdiagnostic)]
 266 pub enum BadTypePlusSub {
 267     #[suggestion(
 268         slug = "parser-add-paren",
 269         code = "{sum_with_parens}",
 270         applicability = "machine-applicable"
 271     )]
 272     AddParen {
 273         sum_with_parens: String,
 274         #[primary_span]
 275         span: Span,
 276     },
 277     #[label(slug = "parser-forgot-paren")]
 278     ForgotParen {
 279         #[primary_span]
 280         span: Span,
 281     },
 282     #[label(slug = "parser-expect-path")]
 283     ExpectPath {
 284         #[primary_span]
 285         span: Span,
 286     },
 287 }
 288
 289 #[derive(SessionDiagnostic)]
 290 #[error(slug = "parser-maybe-recover-from-bad-qpath-stage-2")]
 291 struct BadQPathStage2 {
 292     #[primary_span]
 293     #[suggestion(applicability = "maybe-incorrect")]
 294     span: Span,
 295     ty: String,
 296 }
 297
 298 #[derive(SessionDiagnostic)]
 299 #[error(slug = "parser-incorrect-semicolon")]
 300 struct IncorrectSemicolon<'a> {
 301     #[primary_span]
 302     #[suggestion_short(applicability = "machine-applicable")]
 303     span: Span,
 304     #[help]
 305     opt_help: Option<()>,
 306     name: &'a str,
 307 }
 308
 309 #[derive(SessionDiagnostic)]
 310 #[error(slug = "parser-incorrect-use-of-await")]
 311 struct IncorrectUseOfAwait {
 312     #[primary_span]
 313     #[suggestion(message = "parentheses-suggestion", applicability = "machine-applicable")]
 314     span: Span,
 315 }
 316
 317 #[derive(SessionDiagnostic)]
 318 #[error(slug = "parser-incorrect-use-of-await")]
 319 struct IncorrectAwait {
 320     #[primary_span]
 321     span: Span,
 322     #[suggestion(message = "postfix-suggestion", code = "{expr}.await{question_mark}")]
 323     sugg_span: (Span, Applicability),
 324     expr: String,
 325     question_mark: &'static str,
 326 }
 327
 328 #[derive(SessionDiagnostic)]
 329 #[error(slug = "parser-in-in-typo")]
 330 struct InInTypo {
 331     #[primary_span]
 332     span: Span,
 333     #[suggestion(applicability = "machine-applicable")]
 334     sugg_span: Span,
 335 }
 336
 337 // SnapshotParser is used to create a snapshot of the parser
 338 // without causing duplicate errors being emitted when the `Parser`
 339 // is dropped.
 340 pub struct SnapshotParser<'a> {
 341     parser: Parser<'a>,
 342     unclosed_delims: Vec<UnmatchedBrace>,
 343 }
 344
 345 impl<'a> Deref for SnapshotParser<'a> {
 346     type Target = Parser<'a>;
 347
 348     fn deref(&self) -> &Self::Target {
 349         &self.parser
 350     }
 351 }
 352
 353 impl<'a> DerefMut for SnapshotParser<'a> {
 354     fn deref_mut(&mut self) -> &mut Self::Target {
 355         &mut self.parser
 356     }
 357 }
 358
 359 impl<'a> Parser<'a> {
 360     pub(super) fn span_err<S: Into<MultiSpan>>(
 361         &self,
 362         sp: S,
 363         err: Error,
 364     ) -> DiagnosticBuilder<'a, ErrorGuaranteed> {
 365         err.span_err(sp, self.diagnostic())
 366     }
 367
 368     pub fn struct_span_err<S: Into<MultiSpan>>(
 369         &self,
 370         sp: S,
 371         m: impl Into<DiagnosticMessage>,
 372     ) -> DiagnosticBuilder<'a, ErrorGuaranteed> {
 373         self.sess.span_diagnostic.struct_span_err(sp, m)
 374     }
 375
 376     pub fn span_bug<S: Into<MultiSpan>>(&self, sp: S, m: impl Into<DiagnosticMessage>) -> ! {
 377         self.sess.span_diagnostic.span_bug(sp, m)
 378     }
 379
 380     pub(super) fn diagnostic(&self) -> &'a Handler {
 381         &self.sess.span_diagnostic
 382     }
 383
 384     /// Replace `self` with `snapshot.parser` and extend `unclosed_delims` with `snapshot.unclosed_delims`.
 385     /// This is to avoid losing unclosed delims errors `create_snapshot_for_diagnostic` clears.
 386     pub(super) fn restore_snapshot(&mut self, snapshot: SnapshotParser<'a>) {
 387         *self = snapshot.parser;
 388         self.unclosed_delims.extend(snapshot.unclosed_delims.clone());
 389     }
 390
 391     pub fn unclosed_delims(&self) -> &[UnmatchedBrace] {
 392         &self.unclosed_delims
 393     }
 394
 395     /// Create a snapshot of the `Parser`.
 396     pub fn create_snapshot_for_diagnostic(&self) -> SnapshotParser<'a> {
 397         let mut snapshot = self.clone();
 398         let unclosed_delims = self.unclosed_delims.clone();
 399         // Clear `unclosed_delims` in snapshot to avoid
 400         // duplicate errors being emitted when the `Parser`
 401         // is dropped (which may or may not happen, depending
 402         // if the parsing the snapshot is created for is successful)
 403         snapshot.unclosed_delims.clear();
 404         SnapshotParser { parser: snapshot, unclosed_delims }
 405     }
 406
 407     pub(super) fn span_to_snippet(&self, span: Span) -> Result<String, SpanSnippetError> {
 408         self.sess.source_map().span_to_snippet(span)
 409     }
 410
 411     pub(super) fn expected_ident_found(&self) -> DiagnosticBuilder<'a, ErrorGuaranteed> {
 412         let mut err = self.struct_span_err(
 413             self.token.span,
 414             &format!("expected identifier, found {}", super::token_descr(&self.token)),
 415         );
 416         let valid_follow = &[
 417             TokenKind::Eq,
 418             TokenKind::Colon,
 419             TokenKind::Comma,
 420             TokenKind::Semi,
 421             TokenKind::ModSep,
 422             TokenKind::OpenDelim(Delimiter::Brace),
 423             TokenKind::OpenDelim(Delimiter::Parenthesis),
 424             TokenKind::CloseDelim(Delimiter::Brace),
 425             TokenKind::CloseDelim(Delimiter::Parenthesis),
 426         ];
 427         match self.token.ident() {
 428             Some((ident, false))
 429                 if ident.is_raw_guess()
 430                     && self.look_ahead(1, |t| valid_follow.contains(&t.kind)) =>
 431             {
 432                 err.span_suggestion_verbose(
 433                     ident.span.shrink_to_lo(),
 434                     &format!("escape `{}` to use it as an identifier", ident.name),
 435                     "r#",
 436                     Applicability::MaybeIncorrect,
 437                 );
 438             }
 439             _ => {}
 440         }
 441         if let Some(token_descr) = super::token_descr_opt(&self.token) {
 442             err.span_label(self.token.span, format!("expected identifier, found {}", token_descr));
 443         } else {
 444             err.span_label(self.token.span, "expected identifier");
 445             if self.token == token::Comma && self.look_ahead(1, |t| t.is_ident()) {
 446                 err.span_suggestion(
 447                     self.token.span,
 448                     "remove this comma",
 449                     "",
 450                     Applicability::MachineApplicable,
 451                 );
 452             }
 453         }
 454         err
 455     }
 456
 457     pub(super) fn expected_one_of_not_found(
 458         &mut self,
 459         edible: &[TokenKind],
 460         inedible: &[TokenKind],
 461     ) -> PResult<'a, bool /* recovered */> {
 462         debug!("expected_one_of_not_found(edible: {:?}, inedible: {:?})", edible, inedible);
 463         fn tokens_to_string(tokens: &[TokenType]) -> String {
 464             let mut i = tokens.iter();
 465             // This might be a sign we need a connect method on `Iterator`.
 466             let b = i.next().map_or_else(String::new, |t| t.to_string());
 467             i.enumerate().fold(b, |mut b, (i, a)| {
 468                 if tokens.len() > 2 && i == tokens.len() - 2 {
 469                     b.push_str(", or ");
 470                 } else if tokens.len() == 2 && i == tokens.len() - 2 {
 471                     b.push_str(" or ");
 472                 } else {
 473                     b.push_str(", ");
 474                 }
 475                 b.push_str(&a.to_string());
 476                 b
 477             })
 478         }
 479
 480         let mut expected = edible
 481             .iter()
 482             .map(|x| TokenType::Token(x.clone()))
 483             .chain(inedible.iter().map(|x| TokenType::Token(x.clone())))
 484             .chain(self.expected_tokens.iter().cloned())
 485             .filter_map(|token| {
 486                 // filter out suggestions which suggest the same token which was found and deemed incorrect
 487                 fn is_ident_eq_keyword(found: &TokenKind, expected: &TokenType) -> bool {
 488                     if let TokenKind::Ident(current_sym, _) = found {
 489                         if let TokenType::Keyword(suggested_sym) = expected {
 490                             return current_sym == suggested_sym;
 491                         }
 492                     }
 493                     false
 494                 }
 495                 if token != parser::TokenType::Token(self.token.kind.clone()) {
 496                     let eq = is_ident_eq_keyword(&self.token.kind, &token);
 497                     // if the suggestion is a keyword and the found token is an ident,
 498                     // the content of which are equal to the suggestion's content,
 499                     // we can remove that suggestion (see the return None statement below)
 500
 501                     // if this isn't the case however, and the suggestion is a token the
 502                     // content of which is the same as the found token's, we remove it as well
 503                     if !eq {
 504                         if let TokenType::Token(kind) = &token {
 505                             if kind == &self.token.kind {
 506                                 return None;
 507                             }
 508                         }
 509                         return Some(token);
 510                     }
 511                 }
 512                 return None;
 513             })
 514             .collect::<Vec<_>>();
 515         expected.sort_by_cached_key(|x| x.to_string());
 516         expected.dedup();
 517
 518         let sm = self.sess.source_map();
 519         let msg = format!("expected `;`, found {}", super::token_descr(&self.token));
 520         let appl = Applicability::MachineApplicable;
 521         if expected.contains(&TokenType::Token(token::Semi)) {
 522             if self.token.span == DUMMY_SP || self.prev_token.span == DUMMY_SP {
 523                 // Likely inside a macro, can't provide meaningful suggestions.
 524             } else if !sm.is_multiline(self.prev_token.span.until(self.token.span)) {
 525                 // The current token is in the same line as the prior token, not recoverable.
 526             } else if [token::Comma, token::Colon].contains(&self.token.kind)
 527                 && self.prev_token.kind == token::CloseDelim(Delimiter::Parenthesis)
 528             {
 529                 // Likely typo: The current token is on a new line and is expected to be
 530                 // `.`, `;`, `?`, or an operator after a close delimiter token.
 531                 //
 532                 // let a = std::process::Command::new("echo")
 533                 //         .arg("1")
 534                 //         ,arg("2")
 535                 //         ^
 536                 // https://github.com/rust-lang/rust/issues/72253
 537             } else if self.look_ahead(1, |t| {
 538                 t == &token::CloseDelim(Delimiter::Brace)
 539                     || t.can_begin_expr() && t.kind != token::Colon
 540             }) && [token::Comma, token::Colon].contains(&self.token.kind)
 541             {
 542                 // Likely typo: `,` → `;` or `:` → `;`. This is triggered if the current token is
 543                 // either `,` or `:`, and the next token could either start a new statement or is a
 544                 // block close. For example:
 545                 //
 546                 //   let x = 32:
 547                 //   let y = 42;
 548                 self.bump();
 549                 let sp = self.prev_token.span;
 550                 self.struct_span_err(sp, &msg)
 551                     .span_suggestion_short(sp, "change this to `;`", ";", appl)
 552                     .emit();
 553                 return Ok(true);
 554             } else if self.look_ahead(0, |t| {
 555                 t == &token::CloseDelim(Delimiter::Brace)
 556                     || (t.can_begin_expr() && t != &token::Semi && t != &token::Pound)
 557                     // Avoid triggering with too many trailing `#` in raw string.
 558                     || (sm.is_multiline(
 559                         self.prev_token.span.shrink_to_hi().until(self.token.span.shrink_to_lo())
 560                     ) && t == &token::Pound)
 561             }) {
 562                 // Missing semicolon typo. This is triggered if the next token could either start a
 563                 // new statement or is a block close. For example:
 564                 //
 565                 //   let x = 32
 566                 //   let y = 42;
 567                 let sp = self.prev_token.span.shrink_to_hi();
 568                 self.struct_span_err(sp, &msg)
 569                     .span_label(self.token.span, "unexpected token")
 570                     .span_suggestion_short(sp, "add `;` here", ";", appl)
 571                     .emit();
 572                 return Ok(true);
 573             }
 574         }
 575
 576         let expect = tokens_to_string(&expected);
 577         let actual = super::token_descr(&self.token);
 578         let (msg_exp, (label_sp, label_exp)) = if expected.len() > 1 {
 579             let short_expect = if expected.len() > 6 {
 580                 format!("{} possible tokens", expected.len())
 581             } else {
 582                 expect.clone()
 583             };
 584             (
 585                 format!("expected one of {expect}, found {actual}"),
 586                 (self.prev_token.span.shrink_to_hi(), format!("expected one of {short_expect}")),
 587             )
 588         } else if expected.is_empty() {
 589             (
 590                 format!("unexpected token: {}", actual),
 591                 (self.prev_token.span, "unexpected token after this".to_string()),
 592             )
 593         } else {
 594             (
 595                 format!("expected {expect}, found {actual}"),
 596                 (self.prev_token.span.shrink_to_hi(), format!("expected {expect}")),
 597             )
 598         };
 599         self.last_unexpected_token_span = Some(self.token.span);
 600         let mut err = self.struct_span_err(self.token.span, &msg_exp);
 601
 602         // Add suggestion for a missing closing angle bracket if '>' is included in expected_tokens
 603         // there are unclosed angle brackets
 604         if self.unmatched_angle_bracket_count > 0
 605             && self.token.kind == TokenKind::Eq
 606             && expected.iter().any(|tok| matches!(tok, TokenType::Token(TokenKind::Gt)))
 607         {
 608             err.span_label(self.prev_token.span, "maybe try to close unmatched angle bracket");
 609         }
 610
 611         let sp = if self.token == token::Eof {
 612             // This is EOF; don't want to point at the following char, but rather the last token.
 613             self.prev_token.span
 614         } else {
 615             label_sp
 616         };
 617         match self.recover_closing_delimiter(
 618             &expected
 619                 .iter()
 620                 .filter_map(|tt| match tt {
 621                     TokenType::Token(t) => Some(t.clone()),
 622                     _ => None,
 623                 })
 624                 .collect::<Vec<_>>(),
 625             err,
 626         ) {
 627             Err(e) => err = e,
 628             Ok(recovered) => {
 629                 return Ok(recovered);
 630             }
 631         }
 632
 633         if self.check_too_many_raw_str_terminators(&mut err) {
 634             if expected.contains(&TokenType::Token(token::Semi)) && self.eat(&token::Semi) {
 635                 err.emit();
 636                 return Ok(true);
 637             } else {
 638                 return Err(err);
 639             }
 640         }
 641
 642         if self.prev_token.span == DUMMY_SP {
 643             // Account for macro context where the previous span might not be
 644             // available to avoid incorrect output (#54841).
 645             err.span_label(self.token.span, label_exp);
 646         } else if !sm.is_multiline(self.token.span.shrink_to_hi().until(sp.shrink_to_lo())) {
 647             // When the spans are in the same line, it means that the only content between
 648             // them is whitespace, point at the found token in that case:
 649             //
 650             // X |     () => { syntax error };
 651             //   |                    ^^^^^ expected one of 8 possible tokens here
 652             //
 653             // instead of having:
 654             //
 655             // X |     () => { syntax error };
 656             //   |                   -^^^^^ unexpected token
 657             //   |                   |
 658             //   |                   expected one of 8 possible tokens here
 659             err.span_label(self.token.span, label_exp);
 660         } else {
 661             err.span_label(sp, label_exp);
 662             err.span_label(self.token.span, "unexpected token");
 663         }
 664         self.maybe_annotate_with_ascription(&mut err, false);
 665         Err(err)
 666     }
 667
 668     fn check_too_many_raw_str_terminators(&mut self, err: &mut Diagnostic) -> bool {
 669         let sm = self.sess.source_map();
 670         match (&self.prev_token.kind, &self.token.kind) {
 671             (
 672                 TokenKind::Literal(Lit {
 673                     kind: LitKind::StrRaw(n_hashes) | LitKind::ByteStrRaw(n_hashes),
 674                     ..
 675                 }),
 676                 TokenKind::Pound,
 677             ) if !sm.is_multiline(
 678                 self.prev_token.span.shrink_to_hi().until(self.token.span.shrink_to_lo()),
 679             ) =>
 680             {
 681                 let n_hashes: u8 = *n_hashes;
 682                 err.set_primary_message("too many `#` when terminating raw string");
 683                 let str_span = self.prev_token.span;
 684                 let mut span = self.token.span;
 685                 let mut count = 0;
 686                 while self.token.kind == TokenKind::Pound
 687                     && !sm.is_multiline(span.shrink_to_hi().until(self.token.span.shrink_to_lo()))
 688                 {
 689                     span = span.with_hi(self.token.span.hi());
 690                     self.bump();
 691                     count += 1;
 692                 }
 693                 err.set_span(span);
 694                 err.span_suggestion(
 695                     span,
 696                     &format!("remove the extra `#`{}", pluralize!(count)),
 697                     "",
 698                     Applicability::MachineApplicable,
 699                 );
 700                 err.span_label(
 701                     str_span,
 702                     &format!("this raw string started with {n_hashes} `#`{}", pluralize!(n_hashes)),
 703                 );
 704                 true
 705             }
 706             _ => false,
 707         }
 708     }
 709
 710     pub fn maybe_suggest_struct_literal(
 711         &mut self,
 712         lo: Span,
 713         s: BlockCheckMode,
 714     ) -> Option<PResult<'a, P<Block>>> {
 715         if self.token.is_ident() && self.look_ahead(1, |t| t == &token::Colon) {
 716             // We might be having a struct literal where people forgot to include the path:
 717             // fn foo() -> Foo {
 718             //     field: value,
 719             // }
 720             let mut snapshot = self.create_snapshot_for_diagnostic();
 721             let path =
 722                 Path { segments: vec![], span: self.prev_token.span.shrink_to_lo(), tokens: None };
 723             let struct_expr = snapshot.parse_struct_expr(None, path, AttrVec::new(), false);
 724             let block_tail = self.parse_block_tail(lo, s, AttemptLocalParseRecovery::No);
 725             return Some(match (struct_expr, block_tail) {
 726                 (Ok(expr), Err(mut err)) => {
 727                     // We have encountered the following:
 728                     // fn foo() -> Foo {
 729                     //     field: value,
 730                     // }
 731                     // Suggest:
 732                     // fn foo() -> Foo { Path {
 733                     //     field: value,
 734                     // } }
 735                     err.delay_as_bug();
 736                     self.struct_span_err(
 737                         expr.span,
 738                         fluent::parser::struct_literal_body_without_path,
 739                     )
 740                     .multipart_suggestion(
 741                         fluent::parser::suggestion,
 742                         vec![
 743                             (expr.span.shrink_to_lo(), "{ SomeStruct ".to_string()),
 744                             (expr.span.shrink_to_hi(), " }".to_string()),
 745                         ],
 746                         Applicability::MaybeIncorrect,
 747                     )
 748                     .emit();
 749                     self.restore_snapshot(snapshot);
 750                     let mut tail = self.mk_block(
 751                         vec![self.mk_stmt_err(expr.span)],
 752                         s,
 753                         lo.to(self.prev_token.span),
 754                     );
 755                     tail.could_be_bare_literal = true;
 756                     Ok(tail)
 757                 }
 758                 (Err(err), Ok(tail)) => {
 759                     // We have a block tail that contains a somehow valid type ascription expr.
 760                     err.cancel();
 761                     Ok(tail)
 762                 }
 763                 (Err(snapshot_err), Err(err)) => {
 764                     // We don't know what went wrong, emit the normal error.
 765                     snapshot_err.cancel();
 766                     self.consume_block(Delimiter::Brace, ConsumeClosingDelim::Yes);
 767                     Err(err)
 768                 }
 769                 (Ok(_), Ok(mut tail)) => {
 770                     tail.could_be_bare_literal = true;
 771                     Ok(tail)
 772                 }
 773             });
 774         }
 775         None
 776     }
 777
 778     pub fn maybe_annotate_with_ascription(
 779         &mut self,
 780         err: &mut Diagnostic,
 781         maybe_expected_semicolon: bool,
 782     ) {
 783         if let Some((sp, likely_path)) = self.last_type_ascription.take() {
 784             let sm = self.sess.source_map();
 785             let next_pos = sm.lookup_char_pos(self.token.span.lo());
 786             let op_pos = sm.lookup_char_pos(sp.hi());
 787
 788             let allow_unstable = self.sess.unstable_features.is_nightly_build();
 789
 790             if likely_path {
 791                 err.span_suggestion(
 792                     sp,
 793                     "maybe write a path separator here",
 794                     "::",
 795                     if allow_unstable {
 796                         Applicability::MaybeIncorrect
 797                     } else {
 798                         Applicability::MachineApplicable
 799                     },
 800                 );
 801                 self.sess.type_ascription_path_suggestions.borrow_mut().insert(sp);
 802             } else if op_pos.line != next_pos.line && maybe_expected_semicolon {
 803                 err.span_suggestion(
 804                     sp,
 805                     "try using a semicolon",
 806                     ";",
 807                     Applicability::MaybeIncorrect,
 808                 );
 809             } else if allow_unstable {
 810                 err.span_label(sp, "tried to parse a type due to this type ascription");
 811             } else {
 812                 err.span_label(sp, "tried to parse a type due to this");
 813             }
 814             if allow_unstable {
 815                 // Give extra information about type ascription only if it's a nightly compiler.
 816                 err.note(
 817                     "`#![feature(type_ascription)]` lets you annotate an expression with a type: \
 818                      `<expr>: <type>`",
 819                 );
 820                 if !likely_path {
 821                     // Avoid giving too much info when it was likely an unrelated typo.
 822                     err.note(
 823                         "see issue #23416 <https://github.com/rust-lang/rust/issues/23416> \
 824                         for more information",
 825                     );
 826                 }
 827             }
 828         }
 829     }
 830
 831     /// Eats and discards tokens until one of `kets` is encountered. Respects token trees,
 832     /// passes through any errors encountered. Used for error recovery.
 833     pub(super) fn eat_to_tokens(&mut self, kets: &[&TokenKind]) {
 834         if let Err(err) =
 835             self.parse_seq_to_before_tokens(kets, SeqSep::none(), TokenExpectType::Expect, |p| {
 836                 Ok(p.parse_token_tree())
 837             })
 838         {
 839             err.cancel();
 840         }
 841     }
 842
 843     /// This function checks if there are trailing angle brackets and produces
 844     /// a diagnostic to suggest removing them.
 845     ///
 846     /// ```ignore (diagnostic)
 847     /// let _ = [1, 2, 3].into_iter().collect::<Vec<usize>>>>();
 848     ///                                                    ^^ help: remove extra angle brackets
 849     /// ```
 850     ///
 851     /// If `true` is returned, then trailing brackets were recovered, tokens were consumed
 852     /// up until one of the tokens in 'end' was encountered, and an error was emitted.
 853     pub(super) fn check_trailing_angle_brackets(
 854         &mut self,
 855         segment: &PathSegment,
 856         end: &[&TokenKind],
 857     ) -> bool {
 858         // This function is intended to be invoked after parsing a path segment where there are two
 859         // cases:
 860         //
 861         // 1. A specific token is expected after the path segment.
 862         //    eg. `x.foo(`, `x.foo::<u32>(` (parenthesis - method call),
 863         //        `Foo::`, or `Foo::<Bar>::` (mod sep - continued path).
 864         // 2. No specific token is expected after the path segment.
 865         //    eg. `x.foo` (field access)
 866         //
 867         // This function is called after parsing `.foo` and before parsing the token `end` (if
 868         // present). This includes any angle bracket arguments, such as `.foo::<u32>` or
 869         // `Foo::<Bar>`.
 870
 871         // We only care about trailing angle brackets if we previously parsed angle bracket
 872         // arguments. This helps stop us incorrectly suggesting that extra angle brackets be
 873         // removed in this case:
 874         //
 875         // `x.foo >> (3)` (where `x.foo` is a `u32` for example)
 876         //
 877         // This case is particularly tricky as we won't notice it just looking at the tokens -
 878         // it will appear the same (in terms of upcoming tokens) as below (since the `::<u32>` will
 879         // have already been parsed):
 880         //
 881         // `x.foo::<u32>>>(3)`
 882         let parsed_angle_bracket_args =
 883             segment.args.as_ref().map_or(false, |args| args.is_angle_bracketed());
 884
 885         debug!(
 886             "check_trailing_angle_brackets: parsed_angle_bracket_args={:?}",
 887             parsed_angle_bracket_args,
 888         );
 889         if !parsed_angle_bracket_args {
 890             return false;
 891         }
 892
 893         // Keep the span at the start so we can highlight the sequence of `>` characters to be
 894         // removed.
 895         let lo = self.token.span;
 896
 897         // We need to look-ahead to see if we have `>` characters without moving the cursor forward
 898         // (since we might have the field access case and the characters we're eating are
 899         // actual operators and not trailing characters - ie `x.foo >> 3`).
 900         let mut position = 0;
 901
 902         // We can encounter `>` or `>>` tokens in any order, so we need to keep track of how
 903         // many of each (so we can correctly pluralize our error messages) and continue to
 904         // advance.
 905         let mut number_of_shr = 0;
 906         let mut number_of_gt = 0;
 907         while self.look_ahead(position, |t| {
 908             trace!("check_trailing_angle_brackets: t={:?}", t);
 909             if *t == token::BinOp(token::BinOpToken::Shr) {
 910                 number_of_shr += 1;
 911                 true
 912             } else if *t == token::Gt {
 913                 number_of_gt += 1;
 914                 true
 915             } else {
 916                 false
 917             }
 918         }) {
 919             position += 1;
 920         }
 921
 922         // If we didn't find any trailing `>` characters, then we have nothing to error about.
 923         debug!(
 924             "check_trailing_angle_brackets: number_of_gt={:?} number_of_shr={:?}",
 925             number_of_gt, number_of_shr,
 926         );
 927         if number_of_gt < 1 && number_of_shr < 1 {
 928             return false;
 929         }
 930
 931         // Finally, double check that we have our end token as otherwise this is the
 932         // second case.
 933         if self.look_ahead(position, |t| {
 934             trace!("check_trailing_angle_brackets: t={:?}", t);
 935             end.contains(&&t.kind)
 936         }) {
 937             // Eat from where we started until the end token so that parsing can continue
 938             // as if we didn't have those extra angle brackets.
 939             self.eat_to_tokens(end);
 940             let span = lo.until(self.token.span);
 941
 942             let total_num_of_gt = number_of_gt + number_of_shr * 2;
 943             self.struct_span_err(
 944                 span,
 945                 &format!("unmatched angle bracket{}", pluralize!(total_num_of_gt)),
 946             )
 947             .span_suggestion(
 948                 span,
 949                 &format!("remove extra angle bracket{}", pluralize!(total_num_of_gt)),
 950                 "",
 951                 Applicability::MachineApplicable,
 952             )
 953             .emit();
 954             return true;
 955         }
 956         false
 957     }
 958
 959     /// Check if a method call with an intended turbofish has been written without surrounding
 960     /// angle brackets.
 961     pub(super) fn check_turbofish_missing_angle_brackets(&mut self, segment: &mut PathSegment) {
 962         if token::ModSep == self.token.kind && segment.args.is_none() {
 963             let snapshot = self.create_snapshot_for_diagnostic();
 964             self.bump();
 965             let lo = self.token.span;
 966             match self.parse_angle_args(None) {
 967                 Ok(args) => {
 968                     let span = lo.to(self.prev_token.span);
 969                     // Detect trailing `>` like in `x.collect::Vec<_>>()`.
 970                     let mut trailing_span = self.prev_token.span.shrink_to_hi();
 971                     while self.token.kind == token::BinOp(token::Shr)
 972                         || self.token.kind == token::Gt
 973                     {
 974                         trailing_span = trailing_span.to(self.token.span);
 975                         self.bump();
 976                     }
 977                     if self.token.kind == token::OpenDelim(Delimiter::Parenthesis) {
 978                         // Recover from bad turbofish: `foo.collect::Vec<_>()`.
 979                         let args = AngleBracketedArgs { args, span }.into();
 980                         segment.args = args;
 981
 982                         self.struct_span_err(
 983                             span,
 984                             "generic parameters without surrounding angle brackets",
 985                         )
 986                         .multipart_suggestion(
 987                             "surround the type parameters with angle brackets",
 988                             vec![
 989                                 (span.shrink_to_lo(), "<".to_string()),
 990                                 (trailing_span, ">".to_string()),
 991                             ],
 992                             Applicability::MachineApplicable,
 993                         )
 994                         .emit();
 995                     } else {
 996                         // This doesn't look like an invalid turbofish, can't recover parse state.
 997                         self.restore_snapshot(snapshot);
 998                     }
 999                 }
1000                 Err(err) => {
1001                     // We couldn't parse generic parameters, unlikely to be a turbofish. Rely on
1002                     // generic parse error instead.
1003                     err.cancel();
1004                     self.restore_snapshot(snapshot);
1005                 }
1006             }
1007         }
1008     }
1009
1010     /// When writing a turbofish with multiple type parameters missing the leading `::`, we will
1011     /// encounter a parse error when encountering the first `,`.
1012     pub(super) fn check_mistyped_turbofish_with_multiple_type_params(
1013         &mut self,
1014         mut e: DiagnosticBuilder<'a, ErrorGuaranteed>,
1015         expr: &mut P<Expr>,
1016     ) -> PResult<'a, ()> {
1017         if let ExprKind::Binary(binop, _, _) = &expr.kind
1018             && let ast::BinOpKind::Lt = binop.node
1019             && self.eat(&token::Comma)
1020         {
1021             let x = self.parse_seq_to_before_end(
1022                 &token::Gt,
1023                 SeqSep::trailing_allowed(token::Comma),
1024                 |p| p.parse_generic_arg(None),
1025             );
1026             match x {
1027                 Ok((_, _, false)) => {
1028                     if self.eat(&token::Gt) {
1029                         e.span_suggestion_verbose(
1030                             binop.span.shrink_to_lo(),
1031                             TURBOFISH_SUGGESTION_STR,
1032                             "::",
1033                             Applicability::MaybeIncorrect,
1034                         )
1035                         .emit();
1036                         match self.parse_expr() {
1037                             Ok(_) => {
1038                                 *expr =
1039                                     self.mk_expr_err(expr.span.to(self.prev_token.span));
1040                                 return Ok(());
1041                             }
1042                             Err(err) => {
1043                                 *expr = self.mk_expr_err(expr.span);
1044                                 err.cancel();
1045                             }
1046                         }
1047                     }
1048                 }
1049                 Err(err) => {
1050                     err.cancel();
1051                 }
1052                 _ => {}
1053             }
1054         }
1055         Err(e)
1056     }
1057
1058     /// Check to see if a pair of chained operators looks like an attempt at chained comparison,
1059     /// e.g. `1 < x <= 3`. If so, suggest either splitting the comparison into two, or
1060     /// parenthesising the leftmost comparison.
1061     fn attempt_chained_comparison_suggestion(
1062         &mut self,
1063         err: &mut Diagnostic,
1064         inner_op: &Expr,
1065         outer_op: &Spanned<AssocOp>,
1066     ) -> bool /* advanced the cursor */ {
1067         if let ExprKind::Binary(op, ref l1, ref r1) = inner_op.kind {
1068             if let ExprKind::Field(_, ident) = l1.kind
1069                 && ident.as_str().parse::<i32>().is_err()
1070                 && !matches!(r1.kind, ExprKind::Lit(_))
1071             {
1072                 // The parser has encountered `foo.bar<baz`, the likelihood of the turbofish
1073                 // suggestion being the only one to apply is high.
1074                 return false;
1075             }
1076             let mut enclose = |left: Span, right: Span| {
1077                 err.multipart_suggestion(
1078                     "parenthesize the comparison",
1079                     vec![
1080                         (left.shrink_to_lo(), "(".to_string()),
1081                         (right.shrink_to_hi(), ")".to_string()),
1082                     ],
1083                     Applicability::MaybeIncorrect,
1084                 );
1085             };
1086             return match (op.node, &outer_op.node) {
1087                 // `x == y == z`
1088                 (BinOpKind::Eq, AssocOp::Equal) |
1089                 // `x < y < z` and friends.
1090                 (BinOpKind::Lt, AssocOp::Less | AssocOp::LessEqual) |
1091                 (BinOpKind::Le, AssocOp::LessEqual | AssocOp::Less) |
1092                 // `x > y > z` and friends.
1093                 (BinOpKind::Gt, AssocOp::Greater | AssocOp::GreaterEqual) |
1094                 (BinOpKind::Ge, AssocOp::GreaterEqual | AssocOp::Greater) => {
1095                     let expr_to_str = |e: &Expr| {
1096                         self.span_to_snippet(e.span)
1097                             .unwrap_or_else(|_| pprust::expr_to_string(&e))
1098                     };
1099                     err.span_suggestion_verbose(
1100                         inner_op.span.shrink_to_hi(),
1101                         "split the comparison into two",
1102                         format!(" && {}", expr_to_str(&r1)),
1103                         Applicability::MaybeIncorrect,
1104                     );
1105                     false // Keep the current parse behavior, where the AST is `(x < y) < z`.
1106                 }
1107                 // `x == y < z`
1108                 (BinOpKind::Eq, AssocOp::Less | AssocOp::LessEqual | AssocOp::Greater | AssocOp::GreaterEqual) => {
1109                     // Consume `z`/outer-op-rhs.
1110                     let snapshot = self.create_snapshot_for_diagnostic();
1111                     match self.parse_expr() {
1112                         Ok(r2) => {
1113                             // We are sure that outer-op-rhs could be consumed, the suggestion is
1114                             // likely correct.
1115                             enclose(r1.span, r2.span);
1116                             true
1117                         }
1118                         Err(expr_err) => {
1119                             expr_err.cancel();
1120                             self.restore_snapshot(snapshot);
1121                             false
1122                         }
1123                     }
1124                 }
1125                 // `x > y == z`
1126                 (BinOpKind::Lt | BinOpKind::Le | BinOpKind::Gt | BinOpKind::Ge, AssocOp::Equal) => {
1127                     let snapshot = self.create_snapshot_for_diagnostic();
1128                     // At this point it is always valid to enclose the lhs in parentheses, no
1129                     // further checks are necessary.
1130                     match self.parse_expr() {
1131                         Ok(_) => {
1132                             enclose(l1.span, r1.span);
1133                             true
1134                         }
1135                         Err(expr_err) => {
1136                             expr_err.cancel();
1137                             self.restore_snapshot(snapshot);
1138                             false
1139                         }
1140                     }
1141                 }
1142                 _ => false,
1143             };
1144         }
1145         false
1146     }
1147
1148     /// Produces an error if comparison operators are chained (RFC #558).
1149     /// We only need to check the LHS, not the RHS, because all comparison ops have same
1150     /// precedence (see `fn precedence`) and are left-associative (see `fn fixity`).
1151     ///
1152     /// This can also be hit if someone incorrectly writes `foo<bar>()` when they should have used
1153     /// the turbofish (`foo::<bar>()`) syntax. We attempt some heuristic recovery if that is the
1154     /// case.
1155     ///
1156     /// Keep in mind that given that `outer_op.is_comparison()` holds and comparison ops are left
1157     /// associative we can infer that we have:
1158     ///
1159     /// ```text
1160     ///           outer_op
1161     ///           /   \
1162     ///     inner_op   r2
1163     ///        /  \
1164     ///      l1    r1
1165     /// ```
1166     pub(super) fn check_no_chained_comparison(
1167         &mut self,
1168         inner_op: &Expr,
1169         outer_op: &Spanned<AssocOp>,
1170     ) -> PResult<'a, Option<P<Expr>>> {
1171         debug_assert!(
1172             outer_op.node.is_comparison(),
1173             "check_no_chained_comparison: {:?} is not comparison",
1174             outer_op.node,
1175         );
1176
1177         let mk_err_expr =
1178             |this: &Self, span| Ok(Some(this.mk_expr(span, ExprKind::Err, AttrVec::new())));
1179
1180         match inner_op.kind {
1181             ExprKind::Binary(op, ref l1, ref r1) if op.node.is_comparison() => {
1182                 let mut err = self.struct_span_err(
1183                     vec![op.span, self.prev_token.span],
1184                     "comparison operators cannot be chained",
1185                 );
1186
1187                 let suggest = |err: &mut Diagnostic| {
1188                     err.span_suggestion_verbose(
1189                         op.span.shrink_to_lo(),
1190                         TURBOFISH_SUGGESTION_STR,
1191                         "::",
1192                         Applicability::MaybeIncorrect,
1193                     );
1194                 };
1195
1196                 // Include `<` to provide this recommendation even in a case like
1197                 // `Foo<Bar<Baz<Qux, ()>>>`
1198                 if op.node == BinOpKind::Lt && outer_op.node == AssocOp::Less
1199                     || outer_op.node == AssocOp::Greater
1200                 {
1201                     if outer_op.node == AssocOp::Less {
1202                         let snapshot = self.create_snapshot_for_diagnostic();
1203                         self.bump();
1204                         // So far we have parsed `foo<bar<`, consume the rest of the type args.
1205                         let modifiers =
1206                             [(token::Lt, 1), (token::Gt, -1), (token::BinOp(token::Shr), -2)];
1207                         self.consume_tts(1, &modifiers);
1208
1209                         if !&[token::OpenDelim(Delimiter::Parenthesis), token::ModSep]
1210                             .contains(&self.token.kind)
1211                         {
1212                             // We don't have `foo< bar >(` or `foo< bar >::`, so we rewind the
1213                             // parser and bail out.
1214                             self.restore_snapshot(snapshot);
1215                         }
1216                     }
1217                     return if token::ModSep == self.token.kind {
1218                         // We have some certainty that this was a bad turbofish at this point.
1219                         // `foo< bar >::`
1220                         suggest(&mut err);
1221
1222                         let snapshot = self.create_snapshot_for_diagnostic();
1223                         self.bump(); // `::`
1224
1225                         // Consume the rest of the likely `foo<bar>::new()` or return at `foo<bar>`.
1226                         match self.parse_expr() {
1227                             Ok(_) => {
1228                                 // 99% certain that the suggestion is correct, continue parsing.
1229                                 err.emit();
1230                                 // FIXME: actually check that the two expressions in the binop are
1231                                 // paths and resynthesize new fn call expression instead of using
1232                                 // `ExprKind::Err` placeholder.
1233                                 mk_err_expr(self, inner_op.span.to(self.prev_token.span))
1234                             }
1235                             Err(expr_err) => {
1236                                 expr_err.cancel();
1237                                 // Not entirely sure now, but we bubble the error up with the
1238                                 // suggestion.
1239                                 self.restore_snapshot(snapshot);
1240                                 Err(err)
1241                             }
1242                         }
1243                     } else if token::OpenDelim(Delimiter::Parenthesis) == self.token.kind {
1244                         // We have high certainty that this was a bad turbofish at this point.
1245                         // `foo< bar >(`
1246                         suggest(&mut err);
1247                         // Consume the fn call arguments.
1248                         match self.consume_fn_args() {
1249                             Err(()) => Err(err),
1250                             Ok(()) => {
1251                                 err.emit();
1252                                 // FIXME: actually check that the two expressions in the binop are
1253                                 // paths and resynthesize new fn call expression instead of using
1254                                 // `ExprKind::Err` placeholder.
1255                                 mk_err_expr(self, inner_op.span.to(self.prev_token.span))
1256                             }
1257                         }
1258                     } else {
1259                         if !matches!(l1.kind, ExprKind::Lit(_))
1260                             && !matches!(r1.kind, ExprKind::Lit(_))
1261                         {
1262                             // All we know is that this is `foo < bar >` and *nothing* else. Try to
1263                             // be helpful, but don't attempt to recover.
1264                             err.help(TURBOFISH_SUGGESTION_STR);
1265                             err.help("or use `(...)` if you meant to specify fn arguments");
1266                         }
1267
1268                         // If it looks like a genuine attempt to chain operators (as opposed to a
1269                         // misformatted turbofish, for instance), suggest a correct form.
1270                         if self.attempt_chained_comparison_suggestion(&mut err, inner_op, outer_op)
1271                         {
1272                             err.emit();
1273                             mk_err_expr(self, inner_op.span.to(self.prev_token.span))
1274                         } else {
1275                             // These cases cause too many knock-down errors, bail out (#61329).
1276                             Err(err)
1277                         }
1278                     };
1279                 }
1280                 let recover =
1281                     self.attempt_chained_comparison_suggestion(&mut err, inner_op, outer_op);
1282                 err.emit();
1283                 if recover {
1284                     return mk_err_expr(self, inner_op.span.to(self.prev_token.span));
1285                 }
1286             }
1287             _ => {}
1288         }
1289         Ok(None)
1290     }
1291
1292     fn consume_fn_args(&mut self) -> Result<(), ()> {
1293         let snapshot = self.create_snapshot_for_diagnostic();
1294         self.bump(); // `(`
1295
1296         // Consume the fn call arguments.
1297         let modifiers = [
1298             (token::OpenDelim(Delimiter::Parenthesis), 1),
1299             (token::CloseDelim(Delimiter::Parenthesis), -1),
1300         ];
1301         self.consume_tts(1, &modifiers);
1302
1303         if self.token.kind == token::Eof {
1304             // Not entirely sure that what we consumed were fn arguments, rollback.
1305             self.restore_snapshot(snapshot);
1306             Err(())
1307         } else {
1308             // 99% certain that the suggestion is correct, continue parsing.
1309             Ok(())
1310         }
1311     }
1312
1313     pub(super) fn maybe_report_ambiguous_plus(&mut self, impl_dyn_multi: bool, ty: &Ty) {
1314         if impl_dyn_multi {
1315             self.sess.emit_err(AmbiguousPlus { sum_ty: pprust::ty_to_string(&ty), span: ty.span });
1316         }
1317     }
1318
1319     /// Swift lets users write `Ty?` to mean `Option<Ty>`. Parse the construct and recover from it.
1320     pub(super) fn maybe_recover_from_question_mark(&mut self, ty: P<Ty>) -> P<Ty> {
1321         if self.token == token::Question {
1322             self.bump();
1323             self.struct_span_err(self.prev_token.span, "invalid `?` in type")
1324                 .span_label(self.prev_token.span, "`?` is only allowed on expressions, not types")
1325                 .multipart_suggestion(
1326                     "if you meant to express that the type might not contain a value, use the `Option` wrapper type",
1327                     vec![
1328                         (ty.span.shrink_to_lo(), "Option<".to_string()),
1329                         (self.prev_token.span, ">".to_string()),
1330                     ],
1331                     Applicability::MachineApplicable,
1332                 )
1333                 .emit();
1334             self.mk_ty(ty.span.to(self.prev_token.span), TyKind::Err)
1335         } else {
1336             ty
1337         }
1338     }
1339
1340     pub(super) fn maybe_recover_from_bad_type_plus(&mut self, ty: &Ty) -> PResult<'a, ()> {
1341         // Do not add `+` to expected tokens.
1342         if !self.token.is_like_plus() {
1343             return Ok(());
1344         }
1345
1346         self.bump(); // `+`
1347         let bounds = self.parse_generic_bounds(None)?;
1348         let sum_span = ty.span.to(self.prev_token.span);
1349
1350         let sub = match ty.kind {
1351             TyKind::Rptr(ref lifetime, ref mut_ty) => {
1352                 let sum_with_parens = pprust::to_string(|s| {
1353                     s.s.word("&");
1354                     s.print_opt_lifetime(lifetime);
1355                     s.print_mutability(mut_ty.mutbl, false);
1356                     s.popen();
1357                     s.print_type(&mut_ty.ty);
1358                     s.print_type_bounds(" +", &bounds);
1359                     s.pclose()
1360                 });
1361
1362                 BadTypePlusSub::AddParen { sum_with_parens, span: sum_span }
1363             }
1364             TyKind::Ptr(..) | TyKind::BareFn(..) => BadTypePlusSub::ForgotParen { span: sum_span },
1365             _ => BadTypePlusSub::ExpectPath { span: sum_span },
1366         };
1367
1368         self.sess.emit_err(BadTypePlus { ty: pprust::ty_to_string(ty), span: sum_span, sub });
1369
1370         Ok(())
1371     }
1372
1373     pub(super) fn recover_from_prefix_increment(
1374         &mut self,
1375         operand_expr: P<Expr>,
1376         op_span: Span,
1377         prev_is_semi: bool,
1378     ) -> PResult<'a, P<Expr>> {
1379         let standalone =
1380             if prev_is_semi { IsStandalone::Standalone } else { IsStandalone::Subexpr };
1381         let kind = IncDecRecovery { standalone, op: IncOrDec::Inc, fixity: UnaryFixity::Pre };
1382
1383         self.recover_from_inc_dec(operand_expr, kind, op_span)
1384     }
1385
1386     pub(super) fn recover_from_postfix_increment(
1387         &mut self,
1388         operand_expr: P<Expr>,
1389         op_span: Span,
1390     ) -> PResult<'a, P<Expr>> {
1391         let kind = IncDecRecovery {
1392             standalone: IsStandalone::Maybe,
1393             op: IncOrDec::Inc,
1394             fixity: UnaryFixity::Post,
1395         };
1396
1397         self.recover_from_inc_dec(operand_expr, kind, op_span)
1398     }
1399
1400     fn recover_from_inc_dec(
1401         &mut self,
1402         base: P<Expr>,
1403         kind: IncDecRecovery,
1404         op_span: Span,
1405     ) -> PResult<'a, P<Expr>> {
1406         let mut err = self.struct_span_err(
1407             op_span,
1408             &format!("Rust has no {} {} operator", kind.fixity, kind.op.name()),
1409         );
1410         err.span_label(op_span, &format!("not a valid {} operator", kind.fixity));
1411
1412         let help_base_case = |mut err: DiagnosticBuilder<'_, _>, base| {
1413             err.help(&format!("use `{}= 1` instead", kind.op.chr()));
1414             err.emit();
1415             Ok(base)
1416         };
1417
1418         // (pre, post)
1419         let spans = match kind.fixity {
1420             UnaryFixity::Pre => (op_span, base.span.shrink_to_hi()),
1421             UnaryFixity::Post => (base.span.shrink_to_lo(), op_span),
1422         };
1423
1424         match kind.standalone {
1425             IsStandalone::Standalone => self.inc_dec_standalone_suggest(kind, spans).emit(&mut err),
1426             IsStandalone::Subexpr => {
1427                 let Ok(base_src) = self.span_to_snippet(base.span)
1428                     else { return help_base_case(err, base) };
1429                 match kind.fixity {
1430                     UnaryFixity::Pre => {
1431                         self.prefix_inc_dec_suggest(base_src, kind, spans).emit(&mut err)
1432                     }
1433                     UnaryFixity::Post => {
1434                         self.postfix_inc_dec_suggest(base_src, kind, spans).emit(&mut err)
1435                     }
1436                 }
1437             }
1438             IsStandalone::Maybe => {
1439                 let Ok(base_src) = self.span_to_snippet(base.span)
1440                     else { return help_base_case(err, base) };
1441                 let sugg1 = match kind.fixity {
1442                     UnaryFixity::Pre => self.prefix_inc_dec_suggest(base_src, kind, spans),
1443                     UnaryFixity::Post => self.postfix_inc_dec_suggest(base_src, kind, spans),
1444                 };
1445                 let sugg2 = self.inc_dec_standalone_suggest(kind, spans);
1446                 MultiSugg::emit_many(
1447                     &mut err,
1448                     "use `+= 1` instead",
1449                     Applicability::Unspecified,
1450                     [sugg1, sugg2].into_iter(),
1451                 )
1452             }
1453         }
1454         Err(err)
1455     }
1456
1457     fn prefix_inc_dec_suggest(
1458         &mut self,
1459         base_src: String,
1460         kind: IncDecRecovery,
1461         (pre_span, post_span): (Span, Span),
1462     ) -> MultiSugg {
1463         MultiSugg {
1464             msg: format!("use `{}= 1` instead", kind.op.chr()),
1465             patches: vec![
1466                 (pre_span, "{ ".to_string()),
1467                 (post_span, format!(" {}= 1; {} }}", kind.op.chr(), base_src)),
1468             ],
1469             applicability: Applicability::MachineApplicable,
1470         }
1471     }
1472
1473     fn postfix_inc_dec_suggest(
1474         &mut self,
1475         base_src: String,
1476         kind: IncDecRecovery,
1477         (pre_span, post_span): (Span, Span),
1478     ) -> MultiSugg {
1479         let tmp_var = if base_src.trim() == "tmp" { "tmp_" } else { "tmp" };
1480         MultiSugg {
1481             msg: format!("use `{}= 1` instead", kind.op.chr()),
1482             patches: vec![
1483                 (pre_span, format!("{{ let {} = ", tmp_var)),
1484                 (post_span, format!("; {} {}= 1; {} }}", base_src, kind.op.chr(), tmp_var)),
1485             ],
1486             applicability: Applicability::HasPlaceholders,
1487         }
1488     }
1489
1490     fn inc_dec_standalone_suggest(
1491         &mut self,
1492         kind: IncDecRecovery,
1493         (pre_span, post_span): (Span, Span),
1494     ) -> MultiSugg {
1495         MultiSugg {
1496             msg: format!("use `{}= 1` instead", kind.op.chr()),
1497             patches: vec![(pre_span, String::new()), (post_span, format!(" {}= 1", kind.op.chr()))],
1498             applicability: Applicability::MachineApplicable,
1499         }
1500     }
1501
1502     /// Tries to recover from associated item paths like `[T]::AssocItem` / `(T, U)::AssocItem`.
1503     /// Attempts to convert the base expression/pattern/type into a type, parses the `::AssocItem`
1504     /// tail, and combines them into a `<Ty>::AssocItem` expression/pattern/type.
1505     pub(super) fn maybe_recover_from_bad_qpath<T: RecoverQPath>(
1506         &mut self,
1507         base: P<T>,
1508     ) -> PResult<'a, P<T>> {
1509         // Do not add `::` to expected tokens.
1510         if self.token == token::ModSep {
1511             if let Some(ty) = base.to_ty() {
1512                 return self.maybe_recover_from_bad_qpath_stage_2(ty.span, ty);
1513             }
1514         }
1515         Ok(base)
1516     }
1517
1518     /// Given an already parsed `Ty`, parses the `::AssocItem` tail and
1519     /// combines them into a `<Ty>::AssocItem` expression/pattern/type.
1520     pub(super) fn maybe_recover_from_bad_qpath_stage_2<T: RecoverQPath>(
1521         &mut self,
1522         ty_span: Span,
1523         ty: P<Ty>,
1524     ) -> PResult<'a, P<T>> {
1525         self.expect(&token::ModSep)?;
1526
1527         let mut path = ast::Path { segments: Vec::new(), span: DUMMY_SP, tokens: None };
1528         self.parse_path_segments(&mut path.segments, T::PATH_STYLE, None)?;
1529         path.span = ty_span.to(self.prev_token.span);
1530
1531         let ty_str = self.span_to_snippet(ty_span).unwrap_or_else(|_| pprust::ty_to_string(&ty));
1532         self.sess.emit_err(BadQPathStage2 {
1533             span: path.span,
1534             ty: format!("<{}>::{}", ty_str, pprust::path_to_string(&path)),
1535         });
1536
1537         let path_span = ty_span.shrink_to_hi(); // Use an empty path since `position == 0`.
1538         Ok(P(T::recovered(Some(QSelf { ty, path_span, position: 0 }), path)))
1539     }
1540
1541     pub fn maybe_consume_incorrect_semicolon(&mut self, items: &[P<Item>]) -> bool {
1542         if self.token.kind == TokenKind::Semi {
1543             self.bump();
1544
1545             let mut err =
1546                 IncorrectSemicolon { span: self.prev_token.span, opt_help: None, name: "" };
1547
1548             if !items.is_empty() {
1549                 let previous_item = &items[items.len() - 1];
1550                 let previous_item_kind_name = match previous_item.kind {
1551                     // Say "braced struct" because tuple-structs and
1552                     // braceless-empty-struct declarations do take a semicolon.
1553                     ItemKind::Struct(..) => Some("braced struct"),
1554                     ItemKind::Enum(..) => Some("enum"),
1555                     ItemKind::Trait(..) => Some("trait"),
1556                     ItemKind::Union(..) => Some("union"),
1557                     _ => None,
1558                 };
1559                 if let Some(name) = previous_item_kind_name {
1560                     err.opt_help = Some(());
1561                     err.name = name;
1562                 }
1563             }
1564             self.sess.emit_err(err);
1565             true
1566         } else {
1567             false
1568         }
1569     }
1570
1571     /// Creates a `DiagnosticBuilder` for an unexpected token `t` and tries to recover if it is a
1572     /// closing delimiter.
1573     pub(super) fn unexpected_try_recover(
1574         &mut self,
1575         t: &TokenKind,
1576     ) -> PResult<'a, bool /* recovered */> {
1577         let token_str = pprust::token_kind_to_string(t);
1578         let this_token_str = super::token_descr(&self.token);
1579         let (prev_sp, sp) = match (&self.token.kind, self.subparser_name) {
1580             // Point at the end of the macro call when reaching end of macro arguments.
1581             (token::Eof, Some(_)) => {
1582                 let sp = self.sess.source_map().next_point(self.prev_token.span);
1583                 (sp, sp)
1584             }
1585             // We don't want to point at the following span after DUMMY_SP.
1586             // This happens when the parser finds an empty TokenStream.
1587             _ if self.prev_token.span == DUMMY_SP => (self.token.span, self.token.span),
1588             // EOF, don't want to point at the following char, but rather the last token.
1589             (token::Eof, None) => (self.prev_token.span, self.token.span),
1590             _ => (self.prev_token.span.shrink_to_hi(), self.token.span),
1591         };
1592         let msg = format!(
1593             "expected `{}`, found {}",
1594             token_str,
1595             match (&self.token.kind, self.subparser_name) {
1596                 (token::Eof, Some(origin)) => format!("end of {origin}"),
1597                 _ => this_token_str,
1598             },
1599         );
1600         let mut err = self.struct_span_err(sp, &msg);
1601         let label_exp = format!("expected `{token_str}`");
1602         match self.recover_closing_delimiter(&[t.clone()], err) {
1603             Err(e) => err = e,
1604             Ok(recovered) => {
1605                 return Ok(recovered);
1606             }
1607         }
1608         let sm = self.sess.source_map();
1609         if !sm.is_multiline(prev_sp.until(sp)) {
1610             // When the spans are in the same line, it means that the only content
1611             // between them is whitespace, point only at the found token.
1612             err.span_label(sp, label_exp);
1613         } else {
1614             err.span_label(prev_sp, label_exp);
1615             err.span_label(sp, "unexpected token");
1616         }
1617         Err(err)
1618     }
1619
1620     pub(super) fn expect_semi(&mut self) -> PResult<'a, ()> {
1621         if self.eat(&token::Semi) {
1622             return Ok(());
1623         }
1624         self.expect(&token::Semi).map(drop) // Error unconditionally
1625     }
1626
1627     /// Consumes alternative await syntaxes like `await!(<expr>)`, `await <expr>`,
1628     /// `await? <expr>`, `await(<expr>)`, and `await { <expr> }`.
1629     pub(super) fn recover_incorrect_await_syntax(
1630         &mut self,
1631         lo: Span,
1632         await_sp: Span,
1633         attrs: AttrVec,
1634     ) -> PResult<'a, P<Expr>> {
1635         let (hi, expr, is_question) = if self.token == token::Not {
1636             // Handle `await!(<expr>)`.
1637             self.recover_await_macro()?
1638         } else {
1639             self.recover_await_prefix(await_sp)?
1640         };
1641         let sp = self.error_on_incorrect_await(lo, hi, &expr, is_question);
1642         let kind = match expr.kind {
1643             // Avoid knock-down errors as we don't know whether to interpret this as `foo().await?`
1644             // or `foo()?.await` (the very reason we went with postfix syntax 😅).
1645             ExprKind::Try(_) => ExprKind::Err,
1646             _ => ExprKind::Await(expr),
1647         };
1648         let expr = self.mk_expr(lo.to(sp), kind, attrs);
1649         self.maybe_recover_from_bad_qpath(expr)
1650     }
1651
1652     fn recover_await_macro(&mut self) -> PResult<'a, (Span, P<Expr>, bool)> {
1653         self.expect(&token::Not)?;
1654         self.expect(&token::OpenDelim(Delimiter::Parenthesis))?;
1655         let expr = self.parse_expr()?;
1656         self.expect(&token::CloseDelim(Delimiter::Parenthesis))?;
1657         Ok((self.prev_token.span, expr, false))
1658     }
1659
1660     fn recover_await_prefix(&mut self, await_sp: Span) -> PResult<'a, (Span, P<Expr>, bool)> {
1661         let is_question = self.eat(&token::Question); // Handle `await? <expr>`.
1662         let expr = if self.token == token::OpenDelim(Delimiter::Brace) {
1663             // Handle `await { <expr> }`.
1664             // This needs to be handled separately from the next arm to avoid
1665             // interpreting `await { <expr> }?` as `<expr>?.await`.
1666             self.parse_block_expr(None, self.token.span, BlockCheckMode::Default, AttrVec::new())
1667         } else {
1668             self.parse_expr()
1669         }
1670         .map_err(|mut err| {
1671             err.span_label(await_sp, "while parsing this incorrect await expression");
1672             err
1673         })?;
1674         Ok((expr.span, expr, is_question))
1675     }
1676
1677     fn error_on_incorrect_await(&self, lo: Span, hi: Span, expr: &Expr, is_question: bool) -> Span {
1678         let span = lo.to(hi);
1679         let applicability = match expr.kind {
1680             ExprKind::Try(_) => Applicability::MaybeIncorrect, // `await <expr>?`
1681             _ => Applicability::MachineApplicable,
1682         };
1683
1684         self.sess.emit_err(IncorrectAwait {
1685             span,
1686             sugg_span: (span, applicability),
1687             expr: self.span_to_snippet(expr.span).unwrap_or_else(|_| pprust::expr_to_string(&expr)),
1688             question_mark: if is_question { "?" } else { "" },
1689         });
1690
1691         span
1692     }
1693
1694     /// If encountering `future.await()`, consumes and emits an error.
1695     pub(super) fn recover_from_await_method_call(&mut self) {
1696         if self.token == token::OpenDelim(Delimiter::Parenthesis)
1697             && self.look_ahead(1, |t| t == &token::CloseDelim(Delimiter::Parenthesis))
1698         {
1699             // future.await()
1700             let lo = self.token.span;
1701             self.bump(); // (
1702             let span = lo.to(self.token.span);
1703             self.bump(); // )
1704
1705             self.sess.emit_err(IncorrectUseOfAwait { span });
1706         }
1707     }
1708
1709     pub(super) fn try_macro_suggestion(&mut self) -> PResult<'a, P<Expr>> {
1710         let is_try = self.token.is_keyword(kw::Try);
1711         let is_questionmark = self.look_ahead(1, |t| t == &token::Not); //check for !
1712         let is_open = self.look_ahead(2, |t| t == &token::OpenDelim(Delimiter::Parenthesis)); //check for (
1713
1714         if is_try && is_questionmark && is_open {
1715             let lo = self.token.span;
1716             self.bump(); //remove try
1717             self.bump(); //remove !
1718             let try_span = lo.to(self.token.span); //we take the try!( span
1719             self.bump(); //remove (
1720             let is_empty = self.token == token::CloseDelim(Delimiter::Parenthesis); //check if the block is empty
1721             self.consume_block(Delimiter::Parenthesis, ConsumeClosingDelim::No); //eat the block
1722             let hi = self.token.span;
1723             self.bump(); //remove )
1724             let mut err = self.struct_span_err(lo.to(hi), "use of deprecated `try` macro");
1725             err.note("in the 2018 edition `try` is a reserved keyword, and the `try!()` macro is deprecated");
1726             let prefix = if is_empty { "" } else { "alternatively, " };
1727             if !is_empty {
1728                 err.multipart_suggestion(
1729                     "you can use the `?` operator instead",
1730                     vec![(try_span, "".to_owned()), (hi, "?".to_owned())],
1731                     Applicability::MachineApplicable,
1732                 );
1733             }
1734             err.span_suggestion(lo.shrink_to_lo(), &format!("{prefix}you can still access the deprecated `try!()` macro using the \"raw identifier\" syntax"), "r#", Applicability::MachineApplicable);
1735             err.emit();
1736             Ok(self.mk_expr_err(lo.to(hi)))
1737         } else {
1738             Err(self.expected_expression_found()) // The user isn't trying to invoke the try! macro
1739         }
1740     }
1741
1742     /// Recovers a situation like `for ( $pat in $expr )`
1743     /// and suggest writing `for $pat in $expr` instead.
1744     ///
1745     /// This should be called before parsing the `$block`.
1746     pub(super) fn recover_parens_around_for_head(
1747         &mut self,
1748         pat: P<Pat>,
1749         begin_paren: Option<Span>,
1750     ) -> P<Pat> {
1751         match (&self.token.kind, begin_paren) {
1752             (token::CloseDelim(Delimiter::Parenthesis), Some(begin_par_sp)) => {
1753                 self.bump();
1754
1755                 self.struct_span_err(
1756                     MultiSpan::from_spans(vec![begin_par_sp, self.prev_token.span]),
1757                     "unexpected parentheses surrounding `for` loop head",
1758                 )
1759                 .multipart_suggestion(
1760                     "remove parentheses in `for` loop",
1761                     vec![(begin_par_sp, String::new()), (self.prev_token.span, String::new())],
1762                     // With e.g. `for (x) in y)` this would replace `(x) in y)`
1763                     // with `x) in y)` which is syntactically invalid.
1764                     // However, this is prevented before we get here.
1765                     Applicability::MachineApplicable,
1766                 )
1767                 .emit();
1768
1769                 // Unwrap `(pat)` into `pat` to avoid the `unused_parens` lint.
1770                 pat.and_then(|pat| match pat.kind {
1771                     PatKind::Paren(pat) => pat,
1772                     _ => P(pat),
1773                 })
1774             }
1775             _ => pat,
1776         }
1777     }
1778
1779     pub(super) fn could_ascription_be_path(&self, node: &ast::ExprKind) -> bool {
1780         (self.token == token::Lt && // `foo:<bar`, likely a typoed turbofish.
1781             self.look_ahead(1, |t| t.is_ident() && !t.is_reserved_ident()))
1782             || self.token.is_ident() &&
1783             matches!(node, ast::ExprKind::Path(..) | ast::ExprKind::Field(..)) &&
1784             !self.token.is_reserved_ident() &&           // v `foo:bar(baz)`
1785             self.look_ahead(1, |t| t == &token::OpenDelim(Delimiter::Parenthesis))
1786             || self.look_ahead(1, |t| t == &token::OpenDelim(Delimiter::Brace)) // `foo:bar {`
1787             || self.look_ahead(1, |t| t == &token::Colon) &&     // `foo:bar::<baz`
1788             self.look_ahead(2, |t| t == &token::Lt) &&
1789             self.look_ahead(3, |t| t.is_ident())
1790             || self.look_ahead(1, |t| t == &token::Colon) &&  // `foo:bar:baz`
1791             self.look_ahead(2, |t| t.is_ident())
1792             || self.look_ahead(1, |t| t == &token::ModSep)
1793                 && (self.look_ahead(2, |t| t.is_ident()) ||   // `foo:bar::baz`
1794             self.look_ahead(2, |t| t == &token::Lt)) // `foo:bar::<baz>`
1795     }
1796
1797     pub(super) fn recover_seq_parse_error(
1798         &mut self,
1799         delim: Delimiter,
1800         lo: Span,
1801         result: PResult<'a, P<Expr>>,
1802     ) -> P<Expr> {
1803         match result {
1804             Ok(x) => x,
1805             Err(mut err) => {
1806                 err.emit();
1807                 // Recover from parse error, callers expect the closing delim to be consumed.
1808                 self.consume_block(delim, ConsumeClosingDelim::Yes);
1809                 self.mk_expr(lo.to(self.prev_token.span), ExprKind::Err, AttrVec::new())
1810             }
1811         }
1812     }
1813
1814     pub(super) fn recover_closing_delimiter(
1815         &mut self,
1816         tokens: &[TokenKind],
1817         mut err: DiagnosticBuilder<'a, ErrorGuaranteed>,
1818     ) -> PResult<'a, bool> {
1819         let mut pos = None;
1820         // We want to use the last closing delim that would apply.
1821         for (i, unmatched) in self.unclosed_delims.iter().enumerate().rev() {
1822             if tokens.contains(&token::CloseDelim(unmatched.expected_delim))
1823                 && Some(self.token.span) > unmatched.unclosed_span
1824             {
1825                 pos = Some(i);
1826             }
1827         }
1828         match pos {
1829             Some(pos) => {
1830                 // Recover and assume that the detected unclosed delimiter was meant for
1831                 // this location. Emit the diagnostic and act as if the delimiter was
1832                 // present for the parser's sake.
1833
1834                 // Don't attempt to recover from this unclosed delimiter more than once.
1835                 let unmatched = self.unclosed_delims.remove(pos);
1836                 let delim = TokenType::Token(token::CloseDelim(unmatched.expected_delim));
1837                 if unmatched.found_delim.is_none() {
1838                     // We encountered `Eof`, set this fact here to avoid complaining about missing
1839                     // `fn main()` when we found place to suggest the closing brace.
1840                     *self.sess.reached_eof.borrow_mut() = true;
1841                 }
1842
1843                 // We want to suggest the inclusion of the closing delimiter where it makes
1844                 // the most sense, which is immediately after the last token:
1845                 //
1846                 //  {foo(bar {}}
1847                 //      ^      ^
1848                 //      |      |
1849                 //      |      help: `)` may belong here
1850                 //      |
1851                 //      unclosed delimiter
1852                 if let Some(sp) = unmatched.unclosed_span {
1853                     let mut primary_span: Vec<Span> =
1854                         err.span.primary_spans().iter().cloned().collect();
1855                     primary_span.push(sp);
1856                     let mut primary_span: MultiSpan = primary_span.into();
1857                     for span_label in err.span.span_labels() {
1858                         if let Some(label) = span_label.label {
1859                             primary_span.push_span_label(span_label.span, label);
1860                         }
1861                     }
1862                     err.set_span(primary_span);
1863                     err.span_label(sp, "unclosed delimiter");
1864                 }
1865                 // Backticks should be removed to apply suggestions.
1866                 let mut delim = delim.to_string();
1867                 delim.retain(|c| c != '`');
1868                 err.span_suggestion_short(
1869                     self.prev_token.span.shrink_to_hi(),
1870                     &format!("`{delim}` may belong here"),
1871                     delim,
1872                     Applicability::MaybeIncorrect,
1873                 );
1874                 if unmatched.found_delim.is_none() {
1875                     // Encountered `Eof` when lexing blocks. Do not recover here to avoid knockdown
1876                     // errors which would be emitted elsewhere in the parser and let other error
1877                     // recovery consume the rest of the file.
1878                     Err(err)
1879                 } else {
1880                     err.emit();
1881                     self.expected_tokens.clear(); // Reduce the number of errors.
1882                     Ok(true)
1883                 }
1884             }
1885             _ => Err(err),
1886         }
1887     }
1888
1889     /// Eats tokens until we can be relatively sure we reached the end of the
1890     /// statement. This is something of a best-effort heuristic.
1891     ///
1892     /// We terminate when we find an unmatched `}` (without consuming it).
1893     pub(super) fn recover_stmt(&mut self) {
1894         self.recover_stmt_(SemiColonMode::Ignore, BlockMode::Ignore)
1895     }
1896
1897     /// If `break_on_semi` is `Break`, then we will stop consuming tokens after
1898     /// finding (and consuming) a `;` outside of `{}` or `[]` (note that this is
1899     /// approximate -- it can mean we break too early due to macros, but that
1900     /// should only lead to sub-optimal recovery, not inaccurate parsing).
1901     ///
1902     /// If `break_on_block` is `Break`, then we will stop consuming tokens
1903     /// after finding (and consuming) a brace-delimited block.
1904     pub(super) fn recover_stmt_(
1905         &mut self,
1906         break_on_semi: SemiColonMode,
1907         break_on_block: BlockMode,
1908     ) {
1909         let mut brace_depth = 0;
1910         let mut bracket_depth = 0;
1911         let mut in_block = false;
1912         debug!("recover_stmt_ enter loop (semi={:?}, block={:?})", break_on_semi, break_on_block);
1913         loop {
1914             debug!("recover_stmt_ loop {:?}", self.token);
1915             match self.token.kind {
1916                 token::OpenDelim(Delimiter::Brace) => {
1917                     brace_depth += 1;
1918                     self.bump();
1919                     if break_on_block == BlockMode::Break && brace_depth == 1 && bracket_depth == 0
1920                     {
1921                         in_block = true;
1922                     }
1923                 }
1924                 token::OpenDelim(Delimiter::Bracket) => {
1925                     bracket_depth += 1;
1926                     self.bump();
1927                 }
1928                 token::CloseDelim(Delimiter::Brace) => {
1929                     if brace_depth == 0 {
1930                         debug!("recover_stmt_ return - close delim {:?}", self.token);
1931                         break;
1932                     }
1933                     brace_depth -= 1;
1934                     self.bump();
1935                     if in_block && bracket_depth == 0 && brace_depth == 0 {
1936                         debug!("recover_stmt_ return - block end {:?}", self.token);
1937                         break;
1938                     }
1939                 }
1940                 token::CloseDelim(Delimiter::Bracket) => {
1941                     bracket_depth -= 1;
1942                     if bracket_depth < 0 {
1943                         bracket_depth = 0;
1944                     }
1945                     self.bump();
1946                 }
1947                 token::Eof => {
1948                     debug!("recover_stmt_ return - Eof");
1949                     break;
1950                 }
1951                 token::Semi => {
1952                     self.bump();
1953                     if break_on_semi == SemiColonMode::Break
1954                         && brace_depth == 0
1955                         && bracket_depth == 0
1956                     {
1957                         debug!("recover_stmt_ return - Semi");
1958                         break;
1959                     }
1960                 }
1961                 token::Comma
1962                     if break_on_semi == SemiColonMode::Comma
1963                         && brace_depth == 0
1964                         && bracket_depth == 0 =>
1965                 {
1966                     debug!("recover_stmt_ return - Semi");
1967                     break;
1968                 }
1969                 _ => self.bump(),
1970             }
1971         }
1972     }
1973
1974     pub(super) fn check_for_for_in_in_typo(&mut self, in_span: Span) {
1975         if self.eat_keyword(kw::In) {
1976             // a common typo: `for _ in in bar {}`
1977             self.sess.emit_err(InInTypo {
1978                 span: self.prev_token.span,
1979                 sugg_span: in_span.until(self.prev_token.span),
1980             });
1981         }
1982     }
1983
1984     pub(super) fn eat_incorrect_doc_comment_for_param_type(&mut self) {
1985         if let token::DocComment(..) = self.token.kind {
1986             self.struct_span_err(
1987                 self.token.span,
1988                 "documentation comments cannot be applied to a function parameter's type",
1989             )
1990             .span_label(self.token.span, "doc comments are not allowed here")
1991             .emit();
1992             self.bump();
1993         } else if self.token == token::Pound
1994             && self.look_ahead(1, |t| *t == token::OpenDelim(Delimiter::Bracket))
1995         {
1996             let lo = self.token.span;
1997             // Skip every token until next possible arg.
1998             while self.token != token::CloseDelim(Delimiter::Bracket) {
1999                 self.bump();
2000             }
2001             let sp = lo.to(self.token.span);
2002             self.bump();
2003             self.struct_span_err(sp, "attributes cannot be applied to a function parameter's type")
2004                 .span_label(sp, "attributes are not allowed here")
2005                 .emit();
2006         }
2007     }
2008
2009     pub(super) fn parameter_without_type(
2010         &mut self,
2011         err: &mut Diagnostic,
2012         pat: P<ast::Pat>,
2013         require_name: bool,
2014         first_param: bool,
2015     ) -> Option<Ident> {
2016         // If we find a pattern followed by an identifier, it could be an (incorrect)
2017         // C-style parameter declaration.
2018         if self.check_ident()
2019             && self.look_ahead(1, |t| {
2020                 *t == token::Comma || *t == token::CloseDelim(Delimiter::Parenthesis)
2021             })
2022         {
2023             // `fn foo(String s) {}`
2024             let ident = self.parse_ident().unwrap();
2025             let span = pat.span.with_hi(ident.span.hi());
2026
2027             err.span_suggestion(
2028                 span,
2029                 "declare the type after the parameter binding",
2030                 "<identifier>: <type>",
2031                 Applicability::HasPlaceholders,
2032             );
2033             return Some(ident);
2034         } else if require_name
2035             && (self.token == token::Comma
2036                 || self.token == token::Lt
2037                 || self.token == token::CloseDelim(Delimiter::Parenthesis))
2038         {
2039             let rfc_note = "anonymous parameters are removed in the 2018 edition (see RFC 1685)";
2040
2041             let (ident, self_sugg, param_sugg, type_sugg, self_span, param_span, type_span) =
2042                 match pat.kind {
2043                     PatKind::Ident(_, ident, _) => (
2044                         ident,
2045                         "self: ",
2046                         ": TypeName".to_string(),
2047                         "_: ",
2048                         pat.span.shrink_to_lo(),
2049                         pat.span.shrink_to_hi(),
2050                         pat.span.shrink_to_lo(),
2051                     ),
2052                     // Also catches `fn foo(&a)`.
2053                     PatKind::Ref(ref inner_pat, mutab)
2054                         if matches!(inner_pat.clone().into_inner().kind, PatKind::Ident(..)) =>
2055                     {
2056                         match inner_pat.clone().into_inner().kind {
2057                             PatKind::Ident(_, ident, _) => {
2058                                 let mutab = mutab.prefix_str();
2059                                 (
2060                                     ident,
2061                                     "self: ",
2062                                     format!("{ident}: &{mutab}TypeName"),
2063                                     "_: ",
2064                                     pat.span.shrink_to_lo(),
2065                                     pat.span,
2066                                     pat.span.shrink_to_lo(),
2067                                 )
2068                             }
2069                             _ => unreachable!(),
2070                         }
2071                     }
2072                     _ => {
2073                         // Otherwise, try to get a type and emit a suggestion.
2074                         if let Some(ty) = pat.to_ty() {
2075                             err.span_suggestion_verbose(
2076                                 pat.span,
2077                                 "explicitly ignore the parameter name",
2078                                 format!("_: {}", pprust::ty_to_string(&ty)),
2079                                 Applicability::MachineApplicable,
2080                             );
2081                             err.note(rfc_note);
2082                         }
2083
2084                         return None;
2085                     }
2086                 };
2087
2088             // `fn foo(a, b) {}`, `fn foo(a<x>, b<y>) {}` or `fn foo(usize, usize) {}`
2089             if first_param {
2090                 err.span_suggestion(
2091                     self_span,
2092                     "if this is a `self` type, give it a parameter name",
2093                     self_sugg,
2094                     Applicability::MaybeIncorrect,
2095                 );
2096             }
2097             // Avoid suggesting that `fn foo(HashMap<u32>)` is fixed with a change to
2098             // `fn foo(HashMap: TypeName<u32>)`.
2099             if self.token != token::Lt {
2100                 err.span_suggestion(
2101                     param_span,
2102                     "if this is a parameter name, give it a type",
2103                     param_sugg,
2104                     Applicability::HasPlaceholders,
2105                 );
2106             }
2107             err.span_suggestion(
2108                 type_span,
2109                 "if this is a type, explicitly ignore the parameter name",
2110                 type_sugg,
2111                 Applicability::MachineApplicable,
2112             );
2113             err.note(rfc_note);
2114
2115             // Don't attempt to recover by using the `X` in `X<Y>` as the parameter name.
2116             return if self.token == token::Lt { None } else { Some(ident) };
2117         }
2118         None
2119     }
2120
2121     pub(super) fn recover_arg_parse(&mut self) -> PResult<'a, (P<ast::Pat>, P<ast::Ty>)> {
2122         let pat = self.parse_pat_no_top_alt(Some("argument name"))?;
2123         self.expect(&token::Colon)?;
2124         let ty = self.parse_ty()?;
2125
2126         struct_span_err!(
2127             self.diagnostic(),
2128             pat.span,
2129             E0642,
2130             "patterns aren't allowed in methods without bodies",
2131         )
2132         .span_suggestion_short(
2133             pat.span,
2134             "give this argument a name or use an underscore to ignore it",
2135             "_",
2136             Applicability::MachineApplicable,
2137         )
2138         .emit();
2139
2140         // Pretend the pattern is `_`, to avoid duplicate errors from AST validation.
2141         let pat =
2142             P(Pat { kind: PatKind::Wild, span: pat.span, id: ast::DUMMY_NODE_ID, tokens: None });
2143         Ok((pat, ty))
2144     }
2145
2146     pub(super) fn recover_bad_self_param(&mut self, mut param: Param) -> PResult<'a, Param> {
2147         let sp = param.pat.span;
2148         param.ty.kind = TyKind::Err;
2149         self.struct_span_err(sp, "unexpected `self` parameter in function")
2150             .span_label(sp, "must be the first parameter of an associated function")
2151             .emit();
2152         Ok(param)
2153     }
2154
2155     pub(super) fn consume_block(&mut self, delim: Delimiter, consume_close: ConsumeClosingDelim) {
2156         let mut brace_depth = 0;
2157         loop {
2158             if self.eat(&token::OpenDelim(delim)) {
2159                 brace_depth += 1;
2160             } else if self.check(&token::CloseDelim(delim)) {
2161                 if brace_depth == 0 {
2162                     if let ConsumeClosingDelim::Yes = consume_close {
2163                         // Some of the callers of this method expect to be able to parse the
2164                         // closing delimiter themselves, so we leave it alone. Otherwise we advance
2165                         // the parser.
2166                         self.bump();
2167                     }
2168                     return;
2169                 } else {
2170                     self.bump();
2171                     brace_depth -= 1;
2172                     continue;
2173                 }
2174             } else if self.token == token::Eof {
2175                 return;
2176             } else {
2177                 self.bump();
2178             }
2179         }
2180     }
2181
2182     pub(super) fn expected_expression_found(&self) -> DiagnosticBuilder<'a, ErrorGuaranteed> {
2183         let (span, msg) = match (&self.token.kind, self.subparser_name) {
2184             (&token::Eof, Some(origin)) => {
2185                 let sp = self.sess.source_map().next_point(self.prev_token.span);
2186                 (sp, format!("expected expression, found end of {origin}"))
2187             }
2188             _ => (
2189                 self.token.span,
2190                 format!("expected expression, found {}", super::token_descr(&self.token),),
2191             ),
2192         };
2193         let mut err = self.struct_span_err(span, &msg);
2194         let sp = self.sess.source_map().start_point(self.token.span);
2195         if let Some(sp) = self.sess.ambiguous_block_expr_parse.borrow().get(&sp) {
2196             self.sess.expr_parentheses_needed(&mut err, *sp);
2197         }
2198         err.span_label(span, "expected expression");
2199         err
2200     }
2201
2202     fn consume_tts(
2203         &mut self,
2204         mut acc: i64, // `i64` because malformed code can have more closing delims than opening.
2205         // Not using `FxHashMap` due to `token::TokenKind: !Eq + !Hash`.
2206         modifier: &[(token::TokenKind, i64)],
2207     ) {
2208         while acc > 0 {
2209             if let Some((_, val)) = modifier.iter().find(|(t, _)| *t == self.token.kind) {
2210                 acc += *val;
2211             }
2212             if self.token.kind == token::Eof {
2213                 break;
2214             }
2215             self.bump();
2216         }
2217     }
2218
2219     /// Replace duplicated recovered parameters with `_` pattern to avoid unnecessary errors.
2220     ///
2221     /// This is necessary because at this point we don't know whether we parsed a function with
2222     /// anonymous parameters or a function with names but no types. In order to minimize
2223     /// unnecessary errors, we assume the parameters are in the shape of `fn foo(a, b, c)` where
2224     /// the parameters are *names* (so we don't emit errors about not being able to find `b` in
2225     /// the local scope), but if we find the same name multiple times, like in `fn foo(i8, i8)`,
2226     /// we deduplicate them to not complain about duplicated parameter names.
2227     pub(super) fn deduplicate_recovered_params_names(&self, fn_inputs: &mut Vec<Param>) {
2228         let mut seen_inputs = FxHashSet::default();
2229         for input in fn_inputs.iter_mut() {
2230             let opt_ident = if let (PatKind::Ident(_, ident, _), TyKind::Err) =
2231                 (&input.pat.kind, &input.ty.kind)
2232             {
2233                 Some(*ident)
2234             } else {
2235                 None
2236             };
2237             if let Some(ident) = opt_ident {
2238                 if seen_inputs.contains(&ident) {
2239                     input.pat.kind = PatKind::Wild;
2240                 }
2241                 seen_inputs.insert(ident);
2242             }
2243         }
2244     }
2245
2246     /// Handle encountering a symbol in a generic argument list that is not a `,` or `>`. In this
2247     /// case, we emit an error and try to suggest enclosing a const argument in braces if it looks
2248     /// like the user has forgotten them.
2249     pub fn handle_ambiguous_unbraced_const_arg(
2250         &mut self,
2251         args: &mut Vec<AngleBracketedArg>,
2252     ) -> PResult<'a, bool> {
2253         // If we haven't encountered a closing `>`, then the argument is malformed.
2254         // It's likely that the user has written a const expression without enclosing it
2255         // in braces, so we try to recover here.
2256         let arg = args.pop().unwrap();
2257         // FIXME: for some reason using `unexpected` or `expected_one_of_not_found` has
2258         // adverse side-effects to subsequent errors and seems to advance the parser.
2259         // We are causing this error here exclusively in case that a `const` expression
2260         // could be recovered from the current parser state, even if followed by more
2261         // arguments after a comma.
2262         let mut err = self.struct_span_err(
2263             self.token.span,
2264             &format!("expected one of `,` or `>`, found {}", super::token_descr(&self.token)),
2265         );
2266         err.span_label(self.token.span, "expected one of `,` or `>`");
2267         match self.recover_const_arg(arg.span(), err) {
2268             Ok(arg) => {
2269                 args.push(AngleBracketedArg::Arg(arg));
2270                 if self.eat(&token::Comma) {
2271                     return Ok(true); // Continue
2272                 }
2273             }
2274             Err(mut err) => {
2275                 args.push(arg);
2276                 // We will emit a more generic error later.
2277                 err.delay_as_bug();
2278             }
2279         }
2280         return Ok(false); // Don't continue.
2281     }
2282
2283     /// Attempt to parse a generic const argument that has not been enclosed in braces.
2284     /// There are a limited number of expressions that are permitted without being encoded
2285     /// in braces:
2286     /// - Literals.
2287     /// - Single-segment paths (i.e. standalone generic const parameters).
2288     /// All other expressions that can be parsed will emit an error suggesting the expression be
2289     /// wrapped in braces.
2290     pub fn handle_unambiguous_unbraced_const_arg(&mut self) -> PResult<'a, P<Expr>> {
2291         let start = self.token.span;
2292         let expr = self.parse_expr_res(Restrictions::CONST_EXPR, None).map_err(|mut err| {
2293             err.span_label(
2294                 start.shrink_to_lo(),
2295                 "while parsing a const generic argument starting here",
2296             );
2297             err
2298         })?;
2299         if !self.expr_is_valid_const_arg(&expr) {
2300             self.struct_span_err(
2301                 expr.span,
2302                 "expressions must be enclosed in braces to be used as const generic \
2303                     arguments",
2304             )
2305             .multipart_suggestion(
2306                 "enclose the `const` expression in braces",
2307                 vec![
2308                     (expr.span.shrink_to_lo(), "{ ".to_string()),
2309                     (expr.span.shrink_to_hi(), " }".to_string()),
2310                 ],
2311                 Applicability::MachineApplicable,
2312             )
2313             .emit();
2314         }
2315         Ok(expr)
2316     }
2317
2318     fn recover_const_param_decl(&mut self, ty_generics: Option<&Generics>) -> Option<GenericArg> {
2319         let snapshot = self.create_snapshot_for_diagnostic();
2320         let param = match self.parse_const_param(vec![]) {
2321             Ok(param) => param,
2322             Err(err) => {
2323                 err.cancel();
2324                 self.restore_snapshot(snapshot);
2325                 return None;
2326             }
2327         };
2328         let mut err =
2329             self.struct_span_err(param.span(), "unexpected `const` parameter declaration");
2330         err.span_label(param.span(), "expected a `const` expression, not a parameter declaration");
2331         if let (Some(generics), Ok(snippet)) =
2332             (ty_generics, self.sess.source_map().span_to_snippet(param.span()))
2333         {
2334             let (span, sugg) = match &generics.params[..] {
2335                 [] => (generics.span, format!("<{snippet}>")),
2336                 [.., generic] => (generic.span().shrink_to_hi(), format!(", {snippet}")),
2337             };
2338             err.multipart_suggestion(
2339                 "`const` parameters must be declared for the `impl`",
2340                 vec![(span, sugg), (param.span(), param.ident.to_string())],
2341                 Applicability::MachineApplicable,
2342             );
2343         }
2344         let value = self.mk_expr_err(param.span());
2345         err.emit();
2346         Some(GenericArg::Const(AnonConst { id: ast::DUMMY_NODE_ID, value }))
2347     }
2348
2349     pub fn recover_const_param_declaration(
2350         &mut self,
2351         ty_generics: Option<&Generics>,
2352     ) -> PResult<'a, Option<GenericArg>> {
2353         // We have to check for a few different cases.
2354         if let Some(arg) = self.recover_const_param_decl(ty_generics) {
2355             return Ok(Some(arg));
2356         }
2357
2358         // We haven't consumed `const` yet.
2359         let start = self.token.span;
2360         self.bump(); // `const`
2361
2362         // Detect and recover from the old, pre-RFC2000 syntax for const generics.
2363         let mut err = self
2364             .struct_span_err(start, "expected lifetime, type, or constant, found keyword `const`");
2365         if self.check_const_arg() {
2366             err.span_suggestion_verbose(
2367                 start.until(self.token.span),
2368                 "the `const` keyword is only needed in the definition of the type",
2369                 "",
2370                 Applicability::MaybeIncorrect,
2371             );
2372             err.emit();
2373             Ok(Some(GenericArg::Const(self.parse_const_arg()?)))
2374         } else {
2375             let after_kw_const = self.token.span;
2376             self.recover_const_arg(after_kw_const, err).map(Some)
2377         }
2378     }
2379
2380     /// Try to recover from possible generic const argument without `{` and `}`.
2381     ///
2382     /// When encountering code like `foo::< bar + 3 >` or `foo::< bar - baz >` we suggest
2383     /// `foo::<{ bar + 3 }>` and `foo::<{ bar - baz }>`, respectively. We only provide a suggestion
2384     /// if we think that that the resulting expression would be well formed.
2385     pub fn recover_const_arg(
2386         &mut self,
2387         start: Span,
2388         mut err: DiagnosticBuilder<'a, ErrorGuaranteed>,
2389     ) -> PResult<'a, GenericArg> {
2390         let is_op_or_dot = AssocOp::from_token(&self.token)
2391             .and_then(|op| {
2392                 if let AssocOp::Greater
2393                 | AssocOp::Less
2394                 | AssocOp::ShiftRight
2395                 | AssocOp::GreaterEqual
2396                 // Don't recover from `foo::<bar = baz>`, because this could be an attempt to
2397                 // assign a value to a defaulted generic parameter.
2398                 | AssocOp::Assign
2399                 | AssocOp::AssignOp(_) = op
2400                 {
2401                     None
2402                 } else {
2403                     Some(op)
2404                 }
2405             })
2406             .is_some()
2407             || self.token.kind == TokenKind::Dot;
2408         // This will be true when a trait object type `Foo +` or a path which was a `const fn` with
2409         // type params has been parsed.
2410         let was_op =
2411             matches!(self.prev_token.kind, token::BinOp(token::Plus | token::Shr) | token::Gt);
2412         if !is_op_or_dot && !was_op {
2413             // We perform these checks and early return to avoid taking a snapshot unnecessarily.
2414             return Err(err);
2415         }
2416         let snapshot = self.create_snapshot_for_diagnostic();
2417         if is_op_or_dot {
2418             self.bump();
2419         }
2420         match self.parse_expr_res(Restrictions::CONST_EXPR, None) {
2421             Ok(expr) => {
2422                 // Find a mistake like `MyTrait<Assoc == S::Assoc>`.
2423                 if token::EqEq == snapshot.token.kind {
2424                     err.span_suggestion(
2425                         snapshot.token.span,
2426                         "if you meant to use an associated type binding, replace `==` with `=`",
2427                         "=",
2428                         Applicability::MaybeIncorrect,
2429                     );
2430                     let value = self.mk_expr_err(start.to(expr.span));
2431                     err.emit();
2432                     return Ok(GenericArg::Const(AnonConst { id: ast::DUMMY_NODE_ID, value }));
2433                 } else if token::Colon == snapshot.token.kind
2434                     && expr.span.lo() == snapshot.token.span.hi()
2435                     && matches!(expr.kind, ExprKind::Path(..))
2436                 {
2437                     // Find a mistake like "foo::var:A".
2438                     err.span_suggestion(
2439                         snapshot.token.span,
2440                         "write a path separator here",
2441                         "::",
2442                         Applicability::MaybeIncorrect,
2443                     );
2444                     err.emit();
2445                     return Ok(GenericArg::Type(self.mk_ty(start.to(expr.span), TyKind::Err)));
2446                 } else if token::Comma == self.token.kind || self.token.kind.should_end_const_arg()
2447                 {
2448                     // Avoid the following output by checking that we consumed a full const arg:
2449                     // help: expressions must be enclosed in braces to be used as const generic
2450                     //       arguments
2451                     //    |
2452                     // LL |     let sr: Vec<{ (u32, _, _) = vec![] };
2453                     //    |                 ^                      ^
2454                     return Ok(self.dummy_const_arg_needs_braces(err, start.to(expr.span)));
2455                 }
2456             }
2457             Err(err) => {
2458                 err.cancel();
2459             }
2460         }
2461         self.restore_snapshot(snapshot);
2462         Err(err)
2463     }
2464
2465     /// Creates a dummy const argument, and reports that the expression must be enclosed in braces
2466     pub fn dummy_const_arg_needs_braces(
2467         &self,
2468         mut err: DiagnosticBuilder<'a, ErrorGuaranteed>,
2469         span: Span,
2470     ) -> GenericArg {
2471         err.multipart_suggestion(
2472             "expressions must be enclosed in braces to be used as const generic \
2473              arguments",
2474             vec![(span.shrink_to_lo(), "{ ".to_string()), (span.shrink_to_hi(), " }".to_string())],
2475             Applicability::MaybeIncorrect,
2476         );
2477         let value = self.mk_expr_err(span);
2478         err.emit();
2479         GenericArg::Const(AnonConst { id: ast::DUMMY_NODE_ID, value })
2480     }
2481
2482     /// Get the diagnostics for the cases where `move async` is found.
2483     ///
2484     /// `move_async_span` starts at the 'm' of the move keyword and ends with the 'c' of the async keyword
2485     pub(super) fn incorrect_move_async_order_found(
2486         &self,
2487         move_async_span: Span,
2488     ) -> DiagnosticBuilder<'a, ErrorGuaranteed> {
2489         let mut err =
2490             self.struct_span_err(move_async_span, "the order of `move` and `async` is incorrect");
2491         err.span_suggestion_verbose(
2492             move_async_span,
2493             "try switching the order",
2494             "async move",
2495             Applicability::MaybeIncorrect,
2496         );
2497         err
2498     }
2499
2500     /// Some special error handling for the "top-level" patterns in a match arm,
2501     /// `for` loop, `let`, &c. (in contrast to subpatterns within such).
2502     pub(crate) fn maybe_recover_colon_colon_in_pat_typo(
2503         &mut self,
2504         mut first_pat: P<Pat>,
2505         expected: Expected,
2506     ) -> P<Pat> {
2507         if token::Colon != self.token.kind {
2508             return first_pat;
2509         }
2510         if !matches!(first_pat.kind, PatKind::Ident(_, _, None) | PatKind::Path(..))
2511             || !self.look_ahead(1, |token| token.is_ident() && !token.is_reserved_ident())
2512         {
2513             return first_pat;
2514         }
2515         // The pattern looks like it might be a path with a `::` -> `:` typo:
2516         // `match foo { bar:baz => {} }`
2517         let span = self.token.span;
2518         // We only emit "unexpected `:`" error here if we can successfully parse the
2519         // whole pattern correctly in that case.
2520         let snapshot = self.create_snapshot_for_diagnostic();
2521
2522         // Create error for "unexpected `:`".
2523         match self.expected_one_of_not_found(&[], &[]) {
2524             Err(mut err) => {
2525                 self.bump(); // Skip the `:`.
2526                 match self.parse_pat_no_top_alt(expected) {
2527                     Err(inner_err) => {
2528                         // Carry on as if we had not done anything, callers will emit a
2529                         // reasonable error.
2530                         inner_err.cancel();
2531                         err.cancel();
2532                         self.restore_snapshot(snapshot);
2533                     }
2534                     Ok(mut pat) => {
2535                         // We've parsed the rest of the pattern.
2536                         let new_span = first_pat.span.to(pat.span);
2537                         let mut show_sugg = false;
2538                         // Try to construct a recovered pattern.
2539                         match &mut pat.kind {
2540                             PatKind::Struct(qself @ None, path, ..)
2541                             | PatKind::TupleStruct(qself @ None, path, _)
2542                             | PatKind::Path(qself @ None, path) => match &first_pat.kind {
2543                                 PatKind::Ident(_, ident, _) => {
2544                                     path.segments.insert(0, PathSegment::from_ident(*ident));
2545                                     path.span = new_span;
2546                                     show_sugg = true;
2547                                     first_pat = pat;
2548                                 }
2549                                 PatKind::Path(old_qself, old_path) => {
2550                                     path.segments = old_path
2551                                         .segments
2552                                         .iter()
2553                                         .cloned()
2554                                         .chain(take(&mut path.segments))
2555                                         .collect();
2556                                     path.span = new_span;
2557                                     *qself = old_qself.clone();
2558                                     first_pat = pat;
2559                                     show_sugg = true;
2560                                 }
2561                                 _ => {}
2562                             },
2563                             PatKind::Ident(BindingMode::ByValue(Mutability::Not), ident, None) => {
2564                                 match &first_pat.kind {
2565                                     PatKind::Ident(_, old_ident, _) => {
2566                                         let path = PatKind::Path(
2567                                             None,
2568                                             Path {
2569                                                 span: new_span,
2570                                                 segments: vec![
2571                                                     PathSegment::from_ident(*old_ident),
2572                                                     PathSegment::from_ident(*ident),
2573                                                 ],
2574                                                 tokens: None,
2575                                             },
2576                                         );
2577                                         first_pat = self.mk_pat(new_span, path);
2578                                         show_sugg = true;
2579                                     }
2580                                     PatKind::Path(old_qself, old_path) => {
2581                                         let mut segments = old_path.segments.clone();
2582                                         segments.push(PathSegment::from_ident(*ident));
2583                                         let path = PatKind::Path(
2584                                             old_qself.clone(),
2585                                             Path { span: new_span, segments, tokens: None },
2586                                         );
2587                                         first_pat = self.mk_pat(new_span, path);
2588                                         show_sugg = true;
2589                                     }
2590                                     _ => {}
2591                                 }
2592                             }
2593                             _ => {}
2594                         }
2595                         if show_sugg {
2596                             err.span_suggestion(
2597                                 span,
2598                                 "maybe write a path separator here",
2599                                 "::",
2600                                 Applicability::MaybeIncorrect,
2601                             );
2602                         } else {
2603                             first_pat = self.mk_pat(new_span, PatKind::Wild);
2604                         }
2605                         err.emit();
2606                     }
2607                 }
2608             }
2609             _ => {
2610                 // Carry on as if we had not done anything. This should be unreachable.
2611                 self.restore_snapshot(snapshot);
2612             }
2613         };
2614         first_pat
2615     }
2616
2617     pub(crate) fn maybe_recover_unexpected_block_label(&mut self) -> bool {
2618         let Some(label) = self.eat_label().filter(|_| {
2619             self.eat(&token::Colon) && self.token.kind == token::OpenDelim(Delimiter::Brace)
2620         }) else {
2621             return false;
2622         };
2623         let span = label.ident.span.to(self.prev_token.span);
2624         let mut err = self.struct_span_err(span, "block label not supported here");
2625         err.span_label(span, "not supported here");
2626         err.tool_only_span_suggestion(
2627             label.ident.span.until(self.token.span),
2628             "remove this block label",
2629             "",
2630             Applicability::MachineApplicable,
2631         );
2632         err.emit();
2633         true
2634     }
2635
2636     /// Some special error handling for the "top-level" patterns in a match arm,
2637     /// `for` loop, `let`, &c. (in contrast to subpatterns within such).
2638     pub(crate) fn maybe_recover_unexpected_comma(
2639         &mut self,
2640         lo: Span,
2641         rt: CommaRecoveryMode,
2642     ) -> PResult<'a, ()> {
2643         if self.token != token::Comma {
2644             return Ok(());
2645         }
2646
2647         // An unexpected comma after a top-level pattern is a clue that the
2648         // user (perhaps more accustomed to some other language) forgot the
2649         // parentheses in what should have been a tuple pattern; return a
2650         // suggestion-enhanced error here rather than choking on the comma later.
2651         let comma_span = self.token.span;
2652         self.bump();
2653         if let Err(err) = self.skip_pat_list() {
2654             // We didn't expect this to work anyway; we just wanted to advance to the
2655             // end of the comma-sequence so we know the span to suggest parenthesizing.
2656             err.cancel();
2657         }
2658         let seq_span = lo.to(self.prev_token.span);
2659         let mut err = self.struct_span_err(comma_span, "unexpected `,` in pattern");
2660         if let Ok(seq_snippet) = self.span_to_snippet(seq_span) {
2661             err.multipart_suggestion(
2662                 &format!(
2663                     "try adding parentheses to match on a tuple{}",
2664                     if let CommaRecoveryMode::LikelyTuple = rt { "" } else { "..." },
2665                 ),
2666                 vec![
2667                     (seq_span.shrink_to_lo(), "(".to_string()),
2668                     (seq_span.shrink_to_hi(), ")".to_string()),
2669                 ],
2670                 Applicability::MachineApplicable,
2671             );
2672             if let CommaRecoveryMode::EitherTupleOrPipe = rt {
2673                 err.span_suggestion(
2674                     seq_span,
2675                     "...or a vertical bar to match on multiple alternatives",
2676                     seq_snippet.replace(',', " |"),
2677                     Applicability::MachineApplicable,
2678                 );
2679             }
2680         }
2681         Err(err)
2682     }
2683
2684     pub(crate) fn maybe_recover_bounds_doubled_colon(&mut self, ty: &Ty) -> PResult<'a, ()> {
2685         let TyKind::Path(qself, path) = &ty.kind else { return Ok(()) };
2686         let qself_position = qself.as_ref().map(|qself| qself.position);
2687         for (i, segments) in path.segments.windows(2).enumerate() {
2688             if qself_position.map(|pos| i < pos).unwrap_or(false) {
2689                 continue;
2690             }
2691             if let [a, b] = segments {
2692                 let (a_span, b_span) = (a.span(), b.span());
2693                 let between_span = a_span.shrink_to_hi().to(b_span.shrink_to_lo());
2694                 if self.span_to_snippet(between_span).as_ref().map(|a| &a[..]) == Ok(":: ") {
2695                     let mut err = self.struct_span_err(
2696                         path.span.shrink_to_hi(),
2697                         "expected `:` followed by trait or lifetime",
2698                     );
2699                     err.span_suggestion(
2700                         between_span,
2701                         "use single colon",
2702                         ": ",
2703                         Applicability::MachineApplicable,
2704                     );
2705                     return Err(err);
2706                 }
2707             }
2708         }
2709         Ok(())
2710     }
2711
2712     /// Parse and throw away a parenthesized comma separated
2713     /// sequence of patterns until `)` is reached.
2714     fn skip_pat_list(&mut self) -> PResult<'a, ()> {
2715         while !self.check(&token::CloseDelim(Delimiter::Parenthesis)) {
2716             self.parse_pat_no_top_alt(None)?;
2717             if !self.eat(&token::Comma) {
2718                 return Ok(());
2719             }
2720         }
2721         Ok(())
2722     }
2723 }